a4-cli 0.48.1

CLI tool for generating TypeScript SDKs from Arete stream specifications
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
1001
1002
1003
1004
1005
1006
1007
1008
1009
1010
1011
1012
1013
1014
1015
1016
1017
1018
1019
1020
1021
1022
1023
1024
1025
1026
1027
1028
1029
1030
1031
1032
1033
1034
1035
1036
1037
1038
1039
1040
1041
1042
1043
1044
1045
1046
1047
1048
1049
1050
1051
1052
1053
1054
1055
1056
1057
1058
1059
1060
1061
1062
1063
1064
1065
1066
1067
1068
1069
1070
1071
1072
1073
1074
1075
1076
1077
1078
1079
1080
1081
1082
1083
1084
1085
1086
1087
1088
1089
1090
1091
1092
1093
1094
1095
1096
1097
1098
1099
1100
1101
1102
1103
1104
1105
1106
1107
1108
1109
1110
1111
1112
1113
1114
1115
1116
1117
1118
1119
1120
1121
1122
1123
1124
1125
1126
1127
1128
1129
1130
1131
1132
1133
1134
1135
1136
1137
1138
1139
1140
1141
1142
1143
1144
1145
1146
1147
1148
1149
1150
1151
1152
1153
1154
1155
1156
1157
1158
1159
1160
1161
1162
1163
1164
1165
1166
1167
1168
1169
1170
1171
//! Signed registry package releases.
//!
//! The registry signs each package release's identity (its
//! `packageReleaseHash`) with Ed25519 and returns the signatures beside it,
//! as `signatures: [{ keyId, signature }]`, on every package release entry
//! of an install descriptor or resolve result. Each key signs the UTF-8
//! message `arete.registry-package-release/v1\n<keyId>\n<packageReleaseHash>`;
//! the signature is 64 bytes, padded standard base64.
//!
//! Trust anchors come from `cli/registry-keys.json` compiled into `a4`, or an
//! explicitly provisioned `ARETE_REGISTRY_TRUSTED_KEYS_FILE`. Registry key
//! responses and their cache may retire a matching pinned key; they cannot
//! introduce authorities or replace public keys. Strict verification requires
//! a current key: unsigned publication times cannot revive a retired authority.
//!
//! Signatures are required by default when trust anchors are provisioned.
//! Empty bootstrap builds warn until pins are installed. Setting
//! `ARETE_REQUIRE_REGISTRY_SIGNATURES=1` always requires verification.

use std::collections::{BTreeMap, HashSet};
use std::path::PathBuf;
use std::sync::{Mutex, OnceLock};
use std::time::{Duration, SystemTime, UNIX_EPOCH};

use anyhow::{bail, Context, Result};
use base64::Engine;
use colored::Colorize;
use ed25519_dalek::{Signature, VerifyingKey};
use serde::{Deserialize, Serialize};
use serde_json::{Map, Value};

/// Schema of the key list (`GET /api/registry/v1/keys` and the compiled-in
/// file).
pub const KEYS_SCHEMA: &str = "arete.registry-keys/v1";
/// First line of every signed message.
pub const SIGNATURE_DOMAIN: &str = "arete.registry-package-release/v1";
/// Set to `1` to refuse releases without a valid signature.
pub const REQUIRE_SIGNATURES_ENV: &str = "ARETE_REQUIRE_REGISTRY_SIGNATURES";
/// Whether a missing or invalid signature refuses the response when
/// [`REQUIRE_SIGNATURES_ENV`] is not set.
const REQUIRE_SIGNATURES_BY_DEFAULT: bool = false;
/// How long a fetched key list is reused before it is fetched again.
pub const KEYS_TTL: Duration = Duration::from_secs(24 * 60 * 60);
/// The keys compiled into this build.
const EMBEDDED_KEYS: &str = include_str!("../registry-keys.json");
const KEYS_CACHE_SCHEMA: &str = "arete.registry-keys-cache/v1";
const MAX_KEY_ID_LEN: usize = 64;

/// The key list document.
#[derive(Debug, Clone, PartialEq, Eq, Serialize, Deserialize)]
#[serde(rename_all = "camelCase")]
pub struct RegistryKeysDocument {
    pub schema: String,
    pub keys: Vec<RegistryKeyEntry>,
}

/// One registry signing key.
#[derive(Debug, Clone, PartialEq, Eq, Serialize, Deserialize)]
#[serde(rename_all = "camelCase")]
pub struct RegistryKeyEntry {
    pub key_id: String,
    /// Base58 Ed25519 public key.
    pub public_key: String,
    /// Unix seconds after which the key signs nothing new.
    #[serde(default, skip_serializing_if = "Option::is_none")]
    pub retired_at: Option<i64>,
}

#[cfg(test)]
thread_local! {
    /// Test hooks for this thread: whether signatures are required, and the
    /// key cache file, so tests touch neither the process environment nor
    /// the user's Arete home.
    // Mock registries are unsigned unless a test explicitly checks trust.
    // Production builds do not compile this override.
    pub(crate) static TEST_REQUIRE: std::cell::Cell<Option<bool>> =
        const { std::cell::Cell::new(Some(false)) };
    pub(crate) static TEST_CACHE_FILE: std::cell::RefCell<Option<PathBuf>> =
        const { std::cell::RefCell::new(None) };
    pub(crate) static TEST_TRUST_FILE: std::cell::RefCell<Option<PathBuf>> =
        const { std::cell::RefCell::new(None) };
}

fn trusted_keys_file() -> Option<PathBuf> {
    #[cfg(test)]
    if let Some(path) = TEST_TRUST_FILE.with(|file| file.borrow().clone()) {
        return Some(path);
    }
    std::env::var_os("ARETE_REGISTRY_TRUSTED_KEYS_FILE").map(PathBuf::from)
}

/// Whether missing or invalid signatures refuse the response.
pub fn require_signatures() -> bool {
    #[cfg(test)]
    if let Some(require) = TEST_REQUIRE.with(std::cell::Cell::get) {
        return require;
    }
    match std::env::var(REQUIRE_SIGNATURES_ENV) {
        Ok(value) => value.trim() == "1",
        Err(_) => {
            REQUIRE_SIGNATURES_BY_DEFAULT
                || !KeySet::embedded().keys.is_empty()
                || trusted_keys_file().is_some()
        }
    }
}

/// `^[a-z0-9][a-z0-9-]{0,63}$`.
pub fn is_valid_key_id(key_id: &str) -> bool {
    let bytes = key_id.as_bytes();
    !bytes.is_empty()
        && bytes.len() <= MAX_KEY_ID_LEN
        && (bytes[0].is_ascii_lowercase() || bytes[0].is_ascii_digit())
        && bytes
            .iter()
            .all(|byte| byte.is_ascii_lowercase() || byte.is_ascii_digit() || *byte == b'-')
}

/// The message key `key_id` signs for the release `identity`.
pub fn signed_message(key_id: &str, identity: &str) -> String {
    format!("{SIGNATURE_DOMAIN}\n{key_id}\n{identity}")
}

#[derive(Debug, Clone)]
struct TrustedKey {
    key: VerifyingKey,
    retired_at: Option<i64>,
}

/// The keys signatures are checked against.
#[derive(Debug, Clone, Default)]
pub struct KeySet {
    keys: BTreeMap<String, TrustedKey>,
    /// Why the registry's keys are missing, when they are.
    pub problem: Option<String>,
    /// Whether the fetched keys came from the cache (a refresh may find
    /// newer ones).
    pub from_cache: bool,
}

impl KeySet {
    /// Parse and validate a key list document.
    pub fn from_document(document: &RegistryKeysDocument) -> Result<Self> {
        if document.schema != KEYS_SCHEMA {
            bail!(
                "registry key list has schema '{}'; this a4 reads '{KEYS_SCHEMA}'",
                document.schema
            );
        }
        let mut keys = BTreeMap::new();
        for entry in &document.keys {
            if !is_valid_key_id(&entry.key_id) {
                bail!(
                    "registry key list names an invalid key id '{}'",
                    entry.key_id
                );
            }
            let bytes = bs58::decode(&entry.public_key)
                .into_vec()
                .with_context(|| format!("registry key '{}' is not base58", entry.key_id))?;
            let bytes: [u8; 32] = bytes
                .try_into()
                .map_err(|_| anyhow::anyhow!("registry key '{}' is not 32 bytes", entry.key_id))?;
            let key = VerifyingKey::from_bytes(&bytes).with_context(|| {
                format!("registry key '{}' is not an Ed25519 key", entry.key_id)
            })?;
            if keys
                .insert(
                    entry.key_id.clone(),
                    TrustedKey {
                        key,
                        retired_at: entry.retired_at,
                    },
                )
                .is_some()
            {
                bail!("registry key list names '{}' twice", entry.key_id);
            }
        }
        Ok(Self {
            keys,
            problem: None,
            from_cache: false,
        })
    }

    /// Parse a key list from JSON.
    pub fn from_json(value: &Value) -> Result<Self> {
        let document: RegistryKeysDocument =
            serde_json::from_value(value.clone()).context("invalid registry key list")?;
        Self::from_document(&document)
    }

    /// The keys compiled into this build.
    pub fn embedded() -> Self {
        serde_json::from_str::<Value>(EMBEDDED_KEYS)
            .map_err(anyhow::Error::from)
            .and_then(|value| Self::from_json(&value))
            .unwrap_or_else(|error| Self {
                problem: Some(format!(
                    "the compiled-in registry keys are invalid: {error}"
                )),
                ..Self::default()
            })
    }

    #[cfg(test)]
    pub fn len(&self) -> usize {
        self.keys.len()
    }

    #[cfg(test)]
    pub fn is_empty(&self) -> bool {
        self.keys.is_empty()
    }

    /// Fetched/cache metadata can retire a pinned key, never introduce a new
    /// trust anchor or replace a pinned public key. Rotation adds pins via a
    /// signed CLI release or an explicit operator-managed trust file.
    fn merge(&mut self, other: KeySet) {
        for (key_id, key) in other.keys {
            if let Some(existing) = self
                .keys
                .get_mut(&key_id)
                .filter(|existing| existing.key == key.key && existing.retired_at.is_none())
            {
                existing.retired_at = key.retired_at;
            }
        }
        if self.problem.is_none() {
            self.problem = other.problem;
        }
        self.from_cache = other.from_cache;
    }
}

/// The outcome of checking one release's signatures.
#[derive(Debug, Clone, PartialEq, Eq)]
pub enum Verdict {
    /// A current key signed it.
    Verified { key_id: String },
    /// Only a retired key signed it. Strict enforcement refuses it because
    /// publication timestamps are not bound by the release signature.
    VerifiedRetired { key_id: String },
    /// No signatures.
    Unsigned,
    /// Signed only by keys this CLI does not know.
    UnknownKeys { key_ids: Vec<String> },
    /// A signature is malformed or does not verify.
    Invalid { reason: String },
}

fn parse_timestamp(value: &str) -> Option<i64> {
    chrono::DateTime::parse_from_rfc3339(value)
        .ok()
        .map(|time| time.timestamp())
}

/// Check the `signatures` of the release `identity` against `keys`.
pub fn verify_release(
    identity: &str,
    signatures: Option<&Value>,
    published_at: Option<&str>,
    keys: &KeySet,
) -> Verdict {
    let signatures = match signatures {
        None | Some(Value::Null) => return Verdict::Unsigned,
        Some(Value::Array(signatures)) if signatures.is_empty() => return Verdict::Unsigned,
        Some(Value::Array(signatures)) => signatures,
        Some(_) => {
            return Verdict::Invalid {
                reason: "`signatures` is not a list".into(),
            }
        }
    };
    let published_at = published_at.and_then(parse_timestamp);
    let mut unknown = Vec::new();
    let mut failures = Vec::new();
    let mut retired = None;
    for signature in signatures {
        let Some(key_id) = signature.get("keyId").and_then(Value::as_str) else {
            failures.push("a signature has no keyId".to_string());
            continue;
        };
        if !is_valid_key_id(key_id) {
            failures.push(format!("invalid key id '{key_id}'"));
            continue;
        }
        let bytes = signature
            .get("signature")
            .and_then(Value::as_str)
            .and_then(|text| base64::engine::general_purpose::STANDARD.decode(text).ok())
            .and_then(|bytes| <[u8; 64]>::try_from(bytes).ok());
        let Some(bytes) = bytes else {
            failures.push(format!(
                "the signature by key '{key_id}' is not 64 bytes of base64"
            ));
            continue;
        };
        let Some(trusted) = keys.keys.get(key_id) else {
            unknown.push(key_id.to_string());
            continue;
        };
        let message = signed_message(key_id, identity);
        if trusted
            .key
            .verify_strict(message.as_bytes(), &Signature::from_bytes(&bytes))
            .is_err()
        {
            failures.push(format!("the signature by key '{key_id}' does not verify"));
            continue;
        }
        match (trusted.retired_at, published_at) {
            (None, _) => {
                return Verdict::Verified {
                    key_id: key_id.to_string(),
                }
            }
            (Some(retired_at), Some(published)) if published < retired_at => {
                retired = retired.or_else(|| Some(key_id.to_string()));
            }
            (Some(_), Some(_)) => failures.push(format!(
                "key '{key_id}' was retired before this release was published"
            )),
            (Some(_), None) => retired = retired.or_else(|| Some(key_id.to_string())),
        }
    }
    if let Some(key_id) = retired {
        return Verdict::VerifiedRetired { key_id };
    }
    if !failures.is_empty() {
        return Verdict::Invalid {
            reason: failures.join("; "),
        };
    }
    Verdict::UnknownKeys { key_ids: unknown }
}

/// Where package release entries sit in a registry response.
#[derive(Debug, Clone, Copy, PartialEq, Eq)]
pub enum ReleaseShape {
    /// `POST /api/registry/v1/resolve`: `dependencies[]`.
    ResolveResponse,
    /// One resolved dependency, or a protocol install descriptor.
    Dependency,
    /// A stack install descriptor: its programs' `programPackage`.
    StackInstall,
    /// A program install descriptor (or a stack's program): `programPackage`.
    ProgramInstall,
}

fn release_object(object: &mut Map<String, Value>, f: &mut dyn FnMut(&mut Map<String, Value>)) {
    if object
        .get("packageReleaseHash")
        .is_some_and(Value::is_string)
    {
        f(object);
    }
}

fn each_mut(value: &mut Value, key: &str, mut f: impl FnMut(&mut Value)) {
    if let Some(items) = value.get_mut(key).and_then(Value::as_array_mut) {
        for item in items {
            f(item);
        }
    }
}

/// Call `f` on every package release entry of `value`.
fn for_each_release(
    value: &mut Value,
    shape: ReleaseShape,
    f: &mut dyn FnMut(&mut Map<String, Value>),
) {
    match shape {
        ReleaseShape::ResolveResponse => each_mut(value, "dependencies", |dependency| {
            for_each_release(dependency, ReleaseShape::Dependency, f)
        }),
        ReleaseShape::Dependency => {
            let kind = value.get("kind").and_then(Value::as_str).map(str::to_owned);
            if let Some(object) = value.as_object_mut() {
                release_object(object, f);
            }
            match kind.as_deref() {
                Some("program") => {
                    if let Some(install) = value.get_mut("install") {
                        for_each_release(install, ReleaseShape::ProgramInstall, f);
                    }
                }
                Some("protocol") => {
                    each_mut(value, "stacks", |stack| {
                        for_each_release(stack, ReleaseShape::Dependency, f)
                    });
                    each_mut(value, "programs", |program| {
                        for_each_release(program, ReleaseShape::ProgramInstall, f)
                    });
                }
                _ => each_mut(value, "programs", |program| {
                    for_each_release(program, ReleaseShape::ProgramInstall, f)
                }),
            }
        }
        ReleaseShape::StackInstall => each_mut(value, "programs", |program| {
            for_each_release(program, ReleaseShape::ProgramInstall, f)
        }),
        ReleaseShape::ProgramInstall => {
            if let Some(object) = value
                .get_mut("programPackage")
                .and_then(Value::as_object_mut)
            {
                release_object(object, f);
            }
        }
    }
}

/// One package release entry of a response, with its signatures.
#[derive(Debug, Clone, PartialEq)]
pub struct ReleaseEntry {
    /// `package@version` when the entry names them, else the identity.
    pub label: String,
    pub identity: String,
    pub signatures: Option<Value>,
    pub published_at: Option<String>,
}

/// The package release entries of `value`, with their `signatures` removed
/// so the response still matches the typed contract it is read into.
pub fn take_release_entries(value: &mut Value, shape: ReleaseShape) -> Vec<ReleaseEntry> {
    let mut entries = Vec::new();
    for_each_release(value, shape, &mut |object| {
        let identity = object
            .get("packageReleaseHash")
            .and_then(Value::as_str)
            .unwrap_or_default()
            .to_string();
        let label = match (
            object.get("package").and_then(Value::as_str),
            object.get("version").and_then(Value::as_str),
        ) {
            (Some(package), Some(version)) => format!("{package}@{version}"),
            (Some(package), None) => package.to_string(),
            _ => identity.clone(),
        };
        entries.push(ReleaseEntry {
            label,
            identity,
            signatures: object.remove("signatures"),
            published_at: object
                .get("publishedAt")
                .and_then(Value::as_str)
                .map(str::to_owned),
        });
    });
    entries
}

/// One checked release.
#[derive(Debug, Clone, PartialEq, Eq)]
pub struct ReleaseCheck {
    pub label: String,
    pub identity: String,
    pub verdict: Verdict,
}

/// Check every entry. Keys are loaded only when an entry is signed; when a
/// signature names a key the cached list lacks, the list is fetched again
/// once.
pub fn check_entries(
    entries: Vec<ReleaseEntry>,
    load_keys: &mut dyn FnMut(bool) -> KeySet,
) -> Vec<ReleaseCheck> {
    let signed = entries.iter().any(|entry| {
        entry
            .signatures
            .as_ref()
            .is_some_and(|signatures| !signatures.is_null())
    });
    let mut keys = if signed {
        load_keys(false)
    } else {
        KeySet::default()
    };
    let verify = |keys: &KeySet| -> Vec<ReleaseCheck> {
        entries
            .iter()
            .map(|entry| ReleaseCheck {
                label: entry.label.clone(),
                identity: entry.identity.clone(),
                verdict: verify_release(
                    &entry.identity,
                    entry.signatures.as_ref(),
                    entry.published_at.as_deref(),
                    keys,
                ),
            })
            .collect()
    };
    let mut checks = verify(&keys);
    let unknown = checks
        .iter()
        .any(|check| matches!(check.verdict, Verdict::UnknownKeys { .. }));
    if unknown && keys.from_cache {
        keys = load_keys(true);
        checks = verify(&keys);
    }
    if let Some(problem) = keys.problem.as_deref() {
        for check in &mut checks {
            if let Verdict::UnknownKeys { key_ids } = &mut check.verdict {
                key_ids.push(format!("({problem})"));
            }
        }
    }
    checks
}

/// The warnings for `checks`, or, when `require` is set, an error naming
/// every release without a current valid signature. Retired keys require
/// re-signing with an active authority, even for allegedly historical releases.
pub fn enforce(checks: &[ReleaseCheck], require: bool) -> Result<Vec<String>> {
    let mut unsigned = Vec::new();
    let mut refusals = Vec::new();
    let mut warnings = Vec::new();
    for check in checks {
        match &check.verdict {
            Verdict::Verified { .. } => {}
            Verdict::VerifiedRetired { key_id } => {
                let message = format!("{} is signed only by retired registry key '{key_id}'; re-sign with a current key", check.label);
                if require {
                    refusals.push(message);
                } else {
                    warnings.push(message);
                }
            }
            Verdict::Unsigned => unsigned.push(check.label.clone()),
            Verdict::UnknownKeys { key_ids } => refusals.push(format!(
                "{} is signed only by registry keys this a4 does not know: {}",
                check.label,
                key_ids.join(", ")
            )),
            Verdict::Invalid { reason } => refusals.push(format!(
                "{} has an invalid registry signature: {reason}",
                check.label
            )),
        }
    }
    if !unsigned.is_empty() {
        refusals.insert(
            0,
            format!("the registry sent no signature for {}", unsigned.join(", ")),
        );
    }
    if require && !refusals.is_empty() {
        bail!(
            "Refusing registry releases without a valid signature ({REQUIRE_SIGNATURES_ENV}=1):\n  - {}",
            refusals.join("\n  - ")
        );
    }
    refusals.extend(warnings);
    Ok(refusals)
}

/// Print each warning once per process, on stderr so `--json` output stays
/// clean.
pub fn emit_warnings(warnings: &[String]) {
    static PRINTED: OnceLock<Mutex<HashSet<String>>> = OnceLock::new();
    let printed = PRINTED.get_or_init(|| Mutex::new(HashSet::new()));
    let Ok(mut printed) = printed.lock() else {
        return;
    };
    for warning in warnings {
        if printed.insert(warning.clone()) {
            eprintln!(
                "{} Registry signature: {warning}",
                crate::ui::symbols::WARNING.yellow().bold()
            );
        }
    }
}

// ---------------------------------------------------------------------------
// Key cache
// ---------------------------------------------------------------------------

#[derive(Debug, Serialize, Deserialize)]
#[serde(rename_all = "camelCase")]
struct KeysCache {
    schema: String,
    api_url: String,
    fetched_at: u64,
    keys: Value,
}

fn now_secs() -> u64 {
    SystemTime::now()
        .duration_since(UNIX_EPOCH)
        .map(|duration| duration.as_secs())
        .unwrap_or_default()
}

/// `~/.arete/cache/registry-keys/<sha256(api url)[..16]>.json`.
pub fn keys_cache_path(api_url: &str) -> Result<PathBuf> {
    use sha2::Digest;
    let digest = format!("{:x}", sha2::Sha256::digest(api_url.as_bytes()));
    Ok(crate::arete_home::arete_home()?
        .join("cache")
        .join("registry-keys")
        .join(format!("{}.json", &digest[..16])))
}

fn read_cache(path: &std::path::Path, api_url: &str) -> Option<KeysCache> {
    let bytes = std::fs::read(path).ok()?;
    let cache: KeysCache = serde_json::from_slice(&bytes).ok()?;
    (cache.schema == KEYS_CACHE_SCHEMA && cache.api_url == api_url).then_some(cache)
}

fn write_cache(path: &std::path::Path, api_url: &str, keys: &Value) -> Result<()> {
    let parent = path
        .parent()
        .ok_or_else(|| anyhow::anyhow!("invalid key cache path"))?;
    std::fs::create_dir_all(parent)
        .with_context(|| format!("Failed to create {}", parent.display()))?;
    let cache = KeysCache {
        schema: KEYS_CACHE_SCHEMA.into(),
        api_url: api_url.into(),
        fetched_at: now_secs(),
        keys: keys.clone(),
    };
    let temporary = path.with_extension(format!("json.{}.tmp", uuid::Uuid::new_v4()));
    std::fs::write(&temporary, serde_json::to_vec_pretty(&cache)?)
        .with_context(|| format!("Failed to write {}", temporary.display()))?;
    std::fs::rename(&temporary, path)
        .with_context(|| format!("Failed to write {}", path.display()))?;
    Ok(())
}

/// The keys to check `api_url`'s signatures against: the compiled-in keys
/// plus the registry's own list, from the cache while it is fresh (and
/// `refresh` is not set), else from `fetch`. `fetch` answers `None` when
/// the registry has no key list. A failed fetch falls back to a stale
/// cache.
pub fn load_keys(
    api_url: &str,
    refresh: bool,
    fetch: &dyn Fn() -> Result<Option<Value>>,
) -> KeySet {
    #[cfg(test)]
    if let Some(file) = TEST_CACHE_FILE.with(|file| file.borrow().clone()) {
        return load_keys_with_cache(Some(&file), api_url, refresh, fetch);
    }
    // The cache lives in the owner-only Arete home directory.
    let cache = crate::arete_home::ensure_arete_home()
        .ok()
        .and_then(|_| keys_cache_path(api_url).ok());
    load_keys_with_cache(cache.as_deref(), api_url, refresh, fetch)
}

/// [`load_keys`] with the cache file at `cache` (none: no cache).
fn load_keys_with_cache(
    cache: Option<&std::path::Path>,
    api_url: &str,
    refresh: bool,
    fetch: &dyn Fn() -> Result<Option<Value>>,
) -> KeySet {
    let mut keys = match trusted_keys_file() {
        Some(path) => match std::fs::read(path)
            .context("Cannot read configured registry trust file")
            .and_then(|bytes| serde_json::from_slice(&bytes).context("Invalid registry trust file"))
            .and_then(|value| KeySet::from_json(&value))
        {
            Ok(keys) => keys,
            Err(error) => KeySet {
                problem: Some(format!(
                    "Configured registry trust file is invalid: {error}"
                )),
                ..KeySet::default()
            },
        },
        None => KeySet::embedded(),
    };
    let cached = cache.and_then(|path| read_cache(path, api_url));
    if !refresh {
        if let Some(cache) = cached
            .as_ref()
            .filter(|cache| now_secs().saturating_sub(cache.fetched_at) < KEYS_TTL.as_secs())
        {
            if let Ok(mut fetched) = KeySet::from_json(&cache.keys) {
                fetched.from_cache = true;
                keys.merge(fetched);
                return keys;
            }
        }
    }
    let fetched = match fetch() {
        Ok(Some(value)) => match KeySet::from_json(&value) {
            Ok(fetched) => {
                // Best effort: an unwritable cache only means fetching again.
                if let Some(path) = cache {
                    let _ = write_cache(path, api_url, &value);
                }
                fetched
            }
            Err(error) => KeySet {
                problem: Some(format!("{error:#}")),
                ..KeySet::default()
            },
        },
        Ok(None) => KeySet {
            problem: Some("the registry publishes no signing keys".into()),
            ..KeySet::default()
        },
        Err(error) => {
            let problem = format!("could not fetch the registry signing keys: {error:#}");
            match cached.and_then(|cache| KeySet::from_json(&cache.keys).ok()) {
                Some(stale) => KeySet {
                    problem: Some(problem),
                    ..stale
                },
                None => KeySet {
                    problem: Some(problem),
                    ..KeySet::default()
                },
            }
        }
    };
    keys.merge(fetched);
    keys
}

#[cfg(test)]
pub(crate) mod tests {
    use super::*;
    use ed25519_dalek::{Signer, SigningKey};
    use serde_json::json;

    pub(crate) fn signing_key(seed: u8) -> SigningKey {
        SigningKey::from_bytes(&[seed; 32])
    }

    pub(crate) fn key_entry(key_id: &str, key: &SigningKey, retired_at: Option<i64>) -> Value {
        let mut entry = json!({
            "keyId": key_id,
            "publicKey": bs58::encode(key.verifying_key().to_bytes()).into_string(),
        });
        if let Some(retired_at) = retired_at {
            entry["retiredAt"] = json!(retired_at);
        }
        entry
    }

    pub(crate) fn keys_document(entries: Vec<Value>) -> Value {
        json!({ "schema": KEYS_SCHEMA, "keys": entries })
    }

    pub(crate) fn sign(key_id: &str, key: &SigningKey, identity: &str) -> Value {
        let signature = key.sign(signed_message(key_id, identity).as_bytes());
        json!({
            "keyId": key_id,
            "signature": base64::engine::general_purpose::STANDARD.encode(signature.to_bytes()),
        })
    }

    const IDENTITY: &str = "arete:registry-package-release:v2:sha256:abc";

    fn keys(entries: Vec<Value>) -> KeySet {
        KeySet::from_json(&keys_document(entries)).unwrap()
    }

    #[test]
    fn the_compiled_in_key_list_is_valid() {
        let embedded = KeySet::embedded();
        assert!(embedded.problem.is_none(), "{:?}", embedded.problem);
    }

    #[test]
    fn production_registry_pin_requires_signatures_by_default() {
        let pins = KeySet::embedded();
        assert!(pins.keys.contains_key("registry-prod-1"));
        TEST_REQUIRE.with(|required| required.set(None));
        let required = require_signatures();
        TEST_REQUIRE.with(|required| required.set(Some(false)));
        assert!(required);
    }

    #[test]
    fn the_signed_message_is_domain_key_and_identity_on_three_lines() {
        assert_eq!(
            signed_message("arete-2026", IDENTITY),
            format!("arete.registry-package-release/v1\narete-2026\n{IDENTITY}")
        );
    }

    #[test]
    fn key_ids_follow_the_contract_pattern() {
        for valid in ["a", "0", "arete-2026-a", &"a".repeat(64)] {
            assert!(is_valid_key_id(valid), "{valid}");
        }
        for invalid in ["", "-a", "A", "a_b", "a.b", &"a".repeat(65)] {
            assert!(!is_valid_key_id(invalid), "{invalid}");
        }
    }

    #[test]
    fn a_signature_by_a_current_key_verifies() {
        let key = signing_key(1);
        let set = keys(vec![key_entry("k1", &key, None)]);
        let signatures = json!([sign("k1", &key, IDENTITY)]);
        assert_eq!(
            verify_release(IDENTITY, Some(&signatures), None, &set),
            Verdict::Verified {
                key_id: "k1".into()
            }
        );
    }

    #[test]
    fn missing_and_empty_signatures_are_unsigned() {
        let set = KeySet::default();
        assert_eq!(
            verify_release(IDENTITY, None, None, &set),
            Verdict::Unsigned
        );
        assert_eq!(
            verify_release(IDENTITY, Some(&json!([])), None, &set),
            Verdict::Unsigned
        );
    }

    #[test]
    fn a_signature_over_another_identity_or_key_id_is_invalid() {
        let key = signing_key(1);
        let set = keys(vec![
            key_entry("k1", &key, None),
            key_entry("k2", &key, None),
        ]);
        let other = json!([sign(
            "k1",
            &key,
            "arete:registry-package-release:v2:sha256:def"
        )]);
        assert!(matches!(
            verify_release(IDENTITY, Some(&other), None, &set),
            Verdict::Invalid { .. }
        ));
        // Signed for k1, presented as k2: the key id is part of the message.
        let mut moved = sign("k1", &key, IDENTITY);
        moved["keyId"] = json!("k2");
        assert!(matches!(
            verify_release(IDENTITY, Some(&json!([moved])), None, &set),
            Verdict::Invalid { .. }
        ));
    }

    #[test]
    fn malformed_signatures_are_invalid() {
        let set = keys(vec![key_entry("k1", &signing_key(1), None)]);
        for signatures in [
            json!("nope"),
            json!([{ "signature": "AAAA" }]),
            json!([{ "keyId": "K1", "signature": "AAAA" }]),
            json!([{ "keyId": "k1", "signature": "not base64!" }]),
            json!([{ "keyId": "k1", "signature": "AAAA" }]),
        ] {
            assert!(
                matches!(
                    verify_release(IDENTITY, Some(&signatures), None, &set),
                    Verdict::Invalid { .. }
                ),
                "{signatures}"
            );
        }
    }

    #[test]
    fn a_signature_by_an_unknown_key_is_reported_as_such() {
        let key = signing_key(1);
        let signatures = json!([sign("k9", &key, IDENTITY)]);
        assert_eq!(
            verify_release(IDENTITY, Some(&signatures), None, &KeySet::default()),
            Verdict::UnknownKeys {
                key_ids: vec!["k9".into()]
            }
        );
    }

    #[test]
    fn a_retired_key_cannot_become_current_through_backdating() {
        let key = signing_key(1);
        let retired_at = 1_760_000_000;
        let set = keys(vec![key_entry("old", &key, Some(retired_at))]);
        let signatures = json!([sign("old", &key, IDENTITY)]);
        assert_eq!(
            verify_release(
                IDENTITY,
                Some(&signatures),
                Some("2025-01-01T00:00:00Z"),
                &set
            ),
            Verdict::VerifiedRetired {
                key_id: "old".into()
            }
        );
        assert!(matches!(
            verify_release(
                IDENTITY,
                Some(&signatures),
                Some("2026-01-01T00:00:00Z"),
                &set
            ),
            Verdict::Invalid { .. }
        ));
        assert_eq!(
            verify_release(IDENTITY, Some(&signatures), None, &set),
            Verdict::VerifiedRetired {
                key_id: "old".into()
            }
        );
    }

    #[test]
    fn invalid_key_lists_are_rejected() {
        for document in [
            json!({ "schema": "other", "keys": [] }),
            keys_document(vec![
                json!({ "keyId": "Bad", "publicKey": "11111111111111111111111111111111" }),
            ]),
            keys_document(vec![json!({ "keyId": "k1", "publicKey": "abc" })]),
            keys_document(vec![
                key_entry("k1", &signing_key(1), None),
                key_entry("k1", &signing_key(2), None),
            ]),
        ] {
            assert!(KeySet::from_json(&document).is_err(), "{document}");
        }
    }

    fn resolve_response(signatures: Option<Value>) -> Value {
        let mut program_package = json!({
            "package": "ore-program",
            "version": "1.0.0",
            "packageReleaseHash": "arete:registry-package-release:v2:sha256:p",
        });
        let mut stack = json!({
            "kind": "stack",
            "alias": "ore",
            "package": "ore",
            "version": "1.1.0",
            "packageReleaseHash": IDENTITY,
            "stackManifest": { "signatures": "not a release entry" },
            "programs": [ { "programPackage": program_package.clone() } ],
        });
        if let Some(signatures) = signatures {
            stack["signatures"] = signatures.clone();
            program_package["signatures"] = signatures;
            stack["programs"][0]["programPackage"] = program_package;
        }
        json!({ "resolverContract": "x", "dependencies": [stack] })
    }

    #[test]
    fn release_entries_are_found_and_their_signatures_removed() {
        let mut value = resolve_response(Some(json!([])));
        let entries = take_release_entries(&mut value, ReleaseShape::ResolveResponse);
        let labels: Vec<&str> = entries.iter().map(|entry| entry.label.as_str()).collect();
        assert_eq!(labels, ["ore@1.1.0", "ore-program@1.0.0"]);
        let stack = &value["dependencies"][0];
        assert!(stack.get("signatures").is_none());
        assert!(stack["programs"][0]["programPackage"]
            .get("signatures")
            .is_none());
        // Content that is not a release entry is left alone.
        assert_eq!(
            stack["stackManifest"]["signatures"],
            json!("not a release entry")
        );
    }

    #[test]
    fn protocol_descriptors_include_their_hoisted_stacks_and_programs() {
        let mut value = json!({
            "kind": "protocol",
            "package": "tip-jar",
            "version": "1.0.0",
            "packageReleaseHash": "arete:registry-package-release:v2:sha256:t",
            "stacks": [ { "kind": "stack", "package": "tips", "version": "1.0.0", "packageReleaseHash": "arete:registry-package-release:v2:sha256:s", "programs": [] } ],
            "programs": [ { "programPackage": { "package": "system", "version": "1.0.0", "packageReleaseHash": "arete:registry-package-release:v2:sha256:y" } } ],
        });
        let labels: Vec<String> = take_release_entries(&mut value, ReleaseShape::Dependency)
            .into_iter()
            .map(|entry| entry.label)
            .collect();
        assert_eq!(labels, ["tip-jar@1.0.0", "tips@1.0.0", "system@1.0.0"]);
    }

    #[test]
    fn unsigned_releases_are_one_warning_and_keys_are_not_loaded() {
        let mut value = resolve_response(None);
        let entries = take_release_entries(&mut value, ReleaseShape::ResolveResponse);
        let checks = check_entries(entries, &mut |_| panic!("no keys are needed"));
        let warnings = enforce(&checks, false).unwrap();
        assert_eq!(
            warnings,
            ["the registry sent no signature for ore@1.1.0, ore-program@1.0.0"]
        );
        let error = enforce(&checks, true).unwrap_err().to_string();
        assert!(error.contains(REQUIRE_SIGNATURES_ENV), "{error}");
        assert!(error.contains("ore@1.1.0"), "{error}");
    }

    #[test]
    fn signed_releases_pass_and_an_unknown_key_refreshes_the_cached_list_once() {
        let key = signing_key(3);
        let mut value = resolve_response(None);
        value["dependencies"][0]["signatures"] = json!([sign("k3", &key, IDENTITY)]);
        let entries = take_release_entries(&mut value, ReleaseShape::ResolveResponse);
        let mut loads = Vec::new();
        let checks = check_entries(entries, &mut |refresh| {
            loads.push(refresh);
            if refresh {
                keys(vec![key_entry("k3", &key, None)])
            } else {
                KeySet {
                    from_cache: true,
                    ..KeySet::default()
                }
            }
        });
        assert_eq!(loads, [false, true]);
        assert_eq!(
            checks[0].verdict,
            Verdict::Verified {
                key_id: "k3".into()
            }
        );
        // The program package is still unsigned.
        assert_eq!(checks[1].verdict, Verdict::Unsigned);
    }

    #[test]
    fn retired_keys_warn_in_legacy_mode_but_strict_verification_refuses() {
        let checks = [ReleaseCheck {
            label: "ore@1.1.0".into(),
            identity: IDENTITY.into(),
            verdict: Verdict::VerifiedRetired {
                key_id: "old".into(),
            },
        }];
        assert!(enforce(&checks, true).is_err());
        let warnings = enforce(&checks, false).unwrap();
        assert_eq!(warnings.len(), 1);
        assert!(warnings[0].contains("retired"), "{}", warnings[0]);
    }

    #[test]
    fn the_key_list_is_cached_and_refetched_when_stale_or_refreshed() {
        let anchors = KeySet::embedded().len();
        let home = tempfile::tempdir().unwrap();
        let cache_of = |api: &str| home.path().join(format!("{}.json", api.len()));
        let load = |api: &str, refresh: bool, fetch: &dyn Fn() -> Result<Option<Value>>| {
            load_keys_with_cache(Some(&cache_of(api)), api, refresh, fetch)
        };
        let api = "http://registry.test";
        let key = signing_key(4);
        let document = keys_document(vec![key_entry("k4", &key, None)]);
        let fetches = std::cell::Cell::new(0);
        let fetch = || -> Result<Option<Value>> {
            fetches.set(fetches.get() + 1);
            Ok(Some(document.clone()))
        };

        let first = load(api, false, &fetch);
        assert_eq!(
            (first.len(), first.from_cache, fetches.get()),
            (anchors, false, 1)
        );
        let second = load(api, false, &fetch);
        assert_eq!(
            (second.len(), second.from_cache, fetches.get()),
            (anchors, true, 1)
        );
        let refreshed = load(api, true, &fetch);
        assert_eq!((refreshed.from_cache, fetches.get()), (false, 2));

        // Another API has its own cache entry.
        load("http://other.test/x", false, &fetch);
        assert_eq!(fetches.get(), 3);

        // A stale cache is fetched again; a failed fetch falls back to it.
        let path = cache_of(api);
        let mut cache: Value = serde_json::from_slice(&std::fs::read(&path).unwrap()).unwrap();
        cache["fetchedAt"] = json!(0);
        std::fs::write(&path, serde_json::to_vec(&cache).unwrap()).unwrap();
        let failing = || -> Result<Option<Value>> { bail!("offline") };
        let stale = load(api, false, &failing);
        assert_eq!(stale.len(), anchors);
        assert!(stale.problem.as_deref().unwrap().contains("offline"));

        // A registry without the route publishes no keys.
        let none = load("http://none.test/xy", false, &|| Ok(None));
        assert_eq!(none.len(), anchors);
        assert!(none.problem.as_deref().unwrap().contains("no signing keys"));

        // The cache is keyed by API URL.
        assert!(keys_cache_path(api).unwrap() != keys_cache_path("http://other.test").unwrap());
    }

    #[test]
    fn configured_trust_file_requires_signatures_and_invalid_files_fail_closed() {
        let dir = tempfile::tempdir().unwrap();
        let path = dir.path().join("trust.json");
        let trusted = signing_key(4);
        let document = keys_document(vec![key_entry("trusted", &trusted, None)]);
        std::fs::write(&path, document.to_string()).unwrap();
        TEST_TRUST_FILE.with(|file| *file.borrow_mut() = Some(path.clone()));
        TEST_REQUIRE.with(|required| required.set(None));
        let required = require_signatures();
        TEST_REQUIRE.with(|required| required.set(Some(false)));
        let loaded =
            load_keys_with_cache(None, "http://test", false, &|| Ok(Some(document.clone())));
        std::fs::write(&path, "invalid").unwrap();
        let invalid =
            load_keys_with_cache(None, "http://test", false, &|| Ok(Some(document.clone())));
        TEST_TRUST_FILE.with(|file| *file.borrow_mut() = None);
        assert!(required);
        assert_eq!(loaded.len(), 1);
        assert!(invalid.is_empty());
        assert!(invalid.problem.unwrap().contains("trust file is invalid"));
    }

    #[test]
    fn registry_metadata_cannot_replace_pins_or_introduce_signing_authorities() {
        let trusted = signing_key(4);
        let attacker = signing_key(5);
        let mut pins = keys(vec![key_entry("trusted", &trusted, None)]);
        pins.merge(keys(vec![
            key_entry("trusted", &attacker, None),
            key_entry("new", &attacker, None),
        ]));
        assert_eq!(pins.len(), 1);
        assert!(matches!(
            verify_release(
                IDENTITY,
                Some(&json!([sign("trusted", &trusted, IDENTITY)])),
                None,
                &pins
            ),
            Verdict::Verified { .. }
        ));
        assert!(matches!(
            verify_release(
                IDENTITY,
                Some(&json!([sign("new", &attacker, IDENTITY)])),
                None,
                &pins
            ),
            Verdict::UnknownKeys { .. }
        ));
        assert!(matches!(
            verify_release(
                IDENTITY,
                Some(&json!([sign("trusted", &attacker, IDENTITY)])),
                None,
                &pins
            ),
            Verdict::Invalid { .. }
        ));
        let mut no_pins = KeySet::default();
        no_pins.merge(keys(vec![key_entry("new", &attacker, None)]));
        assert!(no_pins.is_empty());
    }
}