BREP_app 0.2.1

//! Toolbar — a top `Panel` strip of primary actions above the viewport:
//! Undo / Redo, a Wireframe toggle, and Zoom-to-fit, plus the File-actions
//! SEAM (owned by the concurrent file panel). Standard views live on the
//! ViewCube navigation gizmo, not here.
//!
//! Follows the panel pattern (a small state struct + a `show(&mut self, ui,
//! state, store)` the shell calls once), but unlike the left-column sections it
//! creates its OWN top panel — so the shell just calls `self.toolbar.show(…)`
//! FIRST in `App::ui` (before the left panel + viewport) to reserve the strip.
//!
//! The MODEL is engine-owned: the toolbar only TRIGGERS engine methods
//! (`state.undo()` / `state.redo()` / `state.zoom_to_fit()`) and drives the
//! wireframe through the existing
//! settings-apply path (`apply_settings_json` → bumps generation + dirty). It
//! owns only the per-frame `hits` map (widget screen rects) the headed verifier
//! reads to drive real clicks, exactly like the history panel.
//!
//! The File buttons don't touch storage here: a click returns a [`FileAction`]
//! from [`ToolbarPanel::show`] and the shell hands it to the reusable
//! [`crate::panels::file::FileDialog`].
//!
//! Buttons draw their artwork from `assets/glyphs/*.svg`, with the text label in
//! the hover tooltip. The COLOUR icons are single SVGs from the icon catalog
//! (see [`crate::icons`]), painted by [`toolbar_button`] whenever a glyph
//! resolves to colour artwork — they replaced the private-use glyph STACKS this
//! file used to assemble by hand, one layer per colour. Neither depends on an OS
//! font or a bitmap asset. All styling/sizing goes through the shared
//! [`crate::panels::toolbar_button`] helpers (the ONE place toolbar-button style
//! lives), so a change lands globally. Glyph per button:
//!   New        U+E010 (doc)                     colour
//!   Open       U+E011 (folder)                  colour
//!   Save       U+E012 (disk)                    colour
//!   Save As    U+E013 (disk + badge)            colour
//!   Import     U+E014 (tray + down arrow)       colour
//!   Export     U+E015 (tray + up arrow)         colour
//!   Undo       U+E016 (curved arrow)            colour
//!   Redo       U+E017 (curved arrow)            colour
//!   Projctn    U+E018 (camera)                  colour
//!   Submit Bug U+1F41E (bug)                    colour
//!   Wireframe  U+1F578 (single glyph)
//!   Fit        U+26F6  (single glyph)
//!   Settings   U+2699  (single glyph)
//!   Docs       U+2139  (single glyph)
//!
//! There is NO Info/Properties button here: entity inspection is opened from the
//! selection-driven CONTEXT bar (see [`crate::panels::context_bar`]), which spawns
//! a pinned per-entity window (see [`crate::panels::info_windows`]).

use crate::panels::file::FileAction;
use crate::panels::toolbar_button;
use crate::store::{ModelStore, SETTINGS_KEY};
use crate::workbench;
use brep_render::engine_state::EngineState;
use eframe::egui;
#[cfg(target_arch = "wasm32")]
use serde_json::Value;
use std::collections::HashMap;


/// What one frame of the toolbar produced for the shell to act on. Extends the
/// old `Option<FileAction>` return so a clicked WORKBENCH button can flow its id
/// out the SAME way a File button flows a [`FileAction`] — the shell matches on
/// the id. Phase 1 declares no workbench buttons, so `workbench_button` is always
/// `None`, but the return path is wired for Phase 2.
#[derive(Default)]
pub struct ToolbarOutcome {
    /// A File button click (New / Open / Save / …), dispatched to the file dialog.
    pub file: Option<FileAction>,
    /// A workbench toolbar button click, surfaced by its `WorkbenchButton::id`.
    pub workbench_button: Option<&'static str>,
    /// The "Submit Bug" button was clicked this frame — the shell begins the
    /// screenshot-capture + report flow (see [`crate::panels::bug_report`]).
    pub bug_report: bool,
}

/// The toolbar's own state: the per-frame map of egui widget screen rects,
/// published to JS for the headed verifier to drive real clicks. Rebuilt each
/// frame (there is no DOM — egui is drawn on the canvas).
#[derive(Default)]
pub struct ToolbarPanel {
    hits: HashMap<String, egui::Rect>,
}

impl ToolbarPanel {
    pub fn new() -> Self {
        Self::default()
    }

    /// Draw the toolbar as a top panel of primary actions. Called FIRST in the
    /// shell's `App::ui` so the strip reserves the top before the left panel and
    /// the central viewport. Rebuilds `hits` each frame as it draws. Returns the
    /// [`FileAction`] a clicked File button requests (the shell dispatches it to
    /// the file dialog), or `None`.
    ///
    /// `settings_open` is the shell-owned open flag of the floating Settings window
    /// (see [`crate::panels::settings`]): the gear button reflects it (highlighted
    /// while open) and toggles it on click.
    pub fn show(
        &mut self,
        ui: &mut egui::Ui,
        state: &mut EngineState,
        store: &dyn ModelStore,
        settings_open: &mut bool,
    ) -> ToolbarOutcome {
        self.hits.clear();
        let mut outcome = ToolbarOutcome::default();
        egui::containers::panel::Panel::top("brep-toolbar")
            .resizable(false)
            .show(ui, |ui| {
                ui.add_space(3.0);
                ui.horizontal_wrapped(|ui| {
                    // Workbench selector FIRST (top-left). It is a UI FILTER, not a
                    // mode switch — it only trims the feature-creation palette /
                    // offers. Its extra BUTTONS render LAST (after the normal icons).
                    self.workbench_selector(ui, state, store);
                    ui.separator();
                    outcome.file = self.file_actions(ui);
                    ui.separator();
                    self.edit_actions(ui, state);
                    ui.separator();
                    self.view_actions(ui, state, store);
                    ui.separator();
                    self.settings_action(ui, settings_open);
                    self.docs_action(ui);
                    outcome.bug_report = self.bug_action(ui);
                    // The active workbench's extra buttons go at the END of the
                    // toolbar, after the standard icons (a leading separator draws
                    // only when the active workbench actually declares buttons).
                    let current = state.settings.workbench.clone();
                    outcome.workbench_button = self.workbench_buttons_row(ui, &current);
                });
                ui.add_space(3.0);
            });
        outcome
    }

    /// The WORKBENCH dropdown: iterates the per-file registry
    /// ([`workbench::WORKBENCHES`]) so labels/order are never hardcoded, shows the
    /// current selection (`state.settings.workbench`), and on change writes the id
    /// through the SAME apply+save path the wireframe/projection toggles use here
    /// (`apply_settings_json` + `store.write`), so it persists across a reload.
    /// Publishes the header + per-item hit-rects for the headed verifier.
    fn workbench_selector(
        &mut self,
        ui: &mut egui::Ui,
        state: &mut EngineState,
        store: &dyn ModelStore,
    ) {
        let current = state.settings.workbench.clone();
        let options: Vec<(&str, &str)> =
            workbench::WORKBENCHES.iter().map(|w| (w.label, w.id)).collect();
        let result = toolbar_button::select(ui, "workbench", &current, &options);
        self.hits.insert("workbench".into(), result.header_rect);
        for (id, rect) in &result.item_rects {
            self.hits.insert(format!("workbench:item:{id}"), *rect);
        }
        if let Some(next) = result.changed {
            let json = serde_json::json!({ "workbench": next }).to_string();
            let _ = state.apply_settings_json(&json);
            // Persist through the same seam wireframe/projection use so the choice
            // survives a reload and the settings blob agrees.
            let _ = store.write(SETTINGS_KEY, &state.settings_json());
        }
    }

    /// Render the ACTIVE workbench's extra toolbar buttons generically. Phase 1:
    /// every workbench declares no buttons, so this draws nothing and returns
    /// `None`.
    fn workbench_buttons_row(&mut self, ui: &mut egui::Ui, current: &str) -> Option<&'static str> {
        let buttons = workbench::workbench_buttons(current);
        // A leading separator only when there is at least one button, so an
        // empty-button workbench (e.g. Modeling) leaves no dangling separator at
        // the toolbar's end.
        if !buttons.is_empty() {
            ui.separator();
        }
        self.draw_workbench_buttons(ui, &buttons)
    }

    /// Draw an explicit list of workbench buttons via the shared button helper,
    /// publishing each hit-rect and surfacing the clicked button's `id` (the
    /// toolbar RETURN PATH — the shell dispatches on it, exactly like a
    /// [`FileAction`]). Split out from [`Self::workbench_buttons_row`] so the
    /// mechanism can be unit-tested with a synthetic button while the real
    /// registry ships none in Phase 1.
    fn draw_workbench_buttons(
        &mut self,
        ui: &mut egui::Ui,
        buttons: &[&workbench::WorkbenchButton],
    ) -> Option<&'static str> {
        let mut clicked = None;
        for button in buttons {
            let resp = toolbar_button::button(ui, button.glyph, button.tooltip);
            self.hits.insert(format!("workbench:btn:{}", button.id), resp.rect);
            if resp.clicked() {
                clicked = Some(button.id);
            }
        }
        clicked
    }

    /// The Docs button: opens the generated help site (`brep-docs` writes it to
    /// `web/help/` next to the served page) in a new tab. Info glyph (U+2139),
    /// matching the old app's toolbar entry.
    fn docs_action(&mut self, ui: &mut egui::Ui) {
        let btn = toolbar_button::button(ui, "\u{2139}", "Docs");
        self.hits.insert("docs".into(), btn.rect);
        if btn.clicked() {
            ui.ctx().open_url(egui::OpenUrl::new_tab("help/index.html"));
        }
    }

    /// The Submit Bug button: opens the in-app problem-report flow, which first
    /// grabs a screenshot of the app (UI + 3D model) BEFORE its dialog appears,
    /// then collects a description + optional email and posts the report.
    /// `bug_report` Material Symbol (base glyph U+1F41E) — `toolbar_button`
    /// auto-renders it from the icon catalog: U+1F41E is COLOUR artwork, so the
    /// button paints the SVG rather than the font glyph.
    /// Returns whether it was clicked.
    fn bug_action(&mut self, ui: &mut egui::Ui) -> bool {
        let btn = toolbar_button::button(ui, "\u{1F41E}", "Submit Bug");
        self.hits.insert("bug".into(), btn.rect);
        btn.clicked()
    }

    /// The Settings toggle: opens / closes the floating Settings window. A
    /// selectable gear glyph (U+2699, bundled DejaVu font) reflecting the live
    /// open state; the label lives in the tooltip, matching the other buttons.
    fn settings_action(&mut self, ui: &mut egui::Ui, open: &mut bool) {
        // Gear (U+2699) — renders in the bundled DejaVu font (no tofu). A toggle
        // reflecting the live open state.
        let btn = toolbar_button::toggle(ui, *open, "\u{2699}", "Settings");
        self.hits.insert("settings".into(), btn.rect);
        if btn.clicked() {
            *open = !*open;
        }
    }

    /// The published widget hit-rects (egui points) for the headed verifier.
    #[cfg(target_arch = "wasm32")]
    pub fn hits_json(&self) -> String {
        let map: serde_json::Map<String, Value> = self
            .hits
            .iter()
            .map(|(k, r)| {
                (
                    k.clone(),
                    serde_json::json!([r.min.x, r.min.y, r.width(), r.height()]),
                )
            })
            .collect();
        Value::Object(map).to_string()
    }

    /// File actions (New / Open / Save / Save As) as glyph buttons. Each returns
    /// the matching [`FileAction`] on click; the shell hands it to the file
    /// dialog (which owns all storage). Glyph → label in the tooltip.
    fn file_actions(&mut self, ui: &mut egui::Ui) -> Option<FileAction> {
        let mut action = None;
        // New — page (U+1F4C4, the previous-app glyph).
        let new = toolbar_button::button(ui, "\u{E010}", "New");
        self.hits.insert("file:new".into(), new.rect);
        if new.clicked() {
            action = Some(FileAction::New);
        }
        // Open — open folder (U+1F5C1). Kept: the previous app had no Open.
        let open = toolbar_button::button(ui, "\u{E011}", "Open");
        self.hits.insert("file:open".into(), open.rect);
        if open.clicked() {
            action = Some(FileAction::Open);
        }
        // Save — floppy disk (U+1F4BE, the previous-app glyph).
        let save = toolbar_button::button(ui, "\u{E012}", "Save");
        self.hits.insert("file:save".into(), save.rect);
        if save.clicked() {
            action = Some(FileAction::Save);
        }
        // Save As has a dedicated custom-font glyph so its plus badge shares
        // the disk's weight, alignment, and square advance.
        let save_as = toolbar_button::button(ui, "\u{E013}", "Save As");
        self.hits.insert("file:saveas".into(), save_as.rect);
        if save_as.clicked() {
            action = Some(FileAction::SaveAs);
        }
        ui.separator();
        // Import — neutral CAD files use their native readers; meshes run through
        // RANSAC reconstruction before being appended as an IMPORT3D feature.
        let import = toolbar_button::button(ui, "\u{E014}", "Import STEP / IGES / STL / OBJ\u{2026}");
        self.hits.insert("file:import".into(), import.rect);
        if import.clicked() {
            action = Some(FileAction::Import);
        }
        // Export — outbox tray (U+1F4E4): write the model OUT as STEP / IGES / STL.
        let export = toolbar_button::button(ui, "\u{E015}", "Export\u{2026} (STEP / IGES / STL)");
        self.hits.insert("file:export".into(), export.rect);
        if export.clicked() {
            action = Some(FileAction::Export);
        }
        action
    }

    /// Undo / Redo — trigger the engine-owned undo history. Buttons enable only
    /// when a step is available so the affordance reflects the real stack. Glyph
    /// only; the label lives in the tooltip.
    ///
    /// While a sketch is open these SAME buttons drive the per-session SKETCH
    /// history instead of the model-level undo — the sketch has no undo/redo of
    /// its own; it shares this toolbar pair (matching the Ctrl+Z / Ctrl+Shift+Z
    /// keyboard router in `app.rs`).
    fn edit_actions(&mut self, ui: &mut egui::Ui, state: &mut EngineState) {
        let sketch = state.sketch_mode();
        let can_undo = if sketch { state.sketch_can_undo() } else { state.can_undo() };
        let undo = toolbar_button::button_enabled(
            ui,
            can_undo,
            "\u{E016}",
            if sketch { "Undo sketch edit (Ctrl+Z)" } else { "Undo" },
        );
        self.hits.insert("undo".into(), undo.rect);
        if undo.clicked() {
            if sketch {
                state.sketch_undo();
            } else {
                state.undo();
            }
        }
        let can_redo = if sketch { state.sketch_can_redo() } else { state.can_redo() };
        let redo = toolbar_button::button_enabled(
            ui,
            can_redo,
            "\u{E017}",
            if sketch { "Redo sketch edit (Ctrl+Y)" } else { "Redo" },
        );
        self.hits.insert("redo".into(), redo.rect);
        if redo.clicked() {
            if sketch {
                state.sketch_redo();
            } else {
                state.redo();
            }
        }
    }

    /// View actions: the Wireframe toggle (drives `settings.wireframe` through the
    /// settings-apply path + persists it like the settings panel), the Projection
    /// toggle (orthographic ↔ perspective via `set_projection`), Zoom-to-fit, and
    /// quick standard-view buttons.
    fn view_actions(&mut self, ui: &mut egui::Ui, state: &mut EngineState, store: &dyn ModelStore) {
        // Wireframe: reflect the LIVE engine value so the toggle is always honest,
        // and flip it via the same apply-path the settings panel uses (bumps
        // settings_generation + dirty so the GPU re-derives styles).
        let wire = state.settings.wireframe;
        // Spider web (U+1F578, Symbols 2) — the previous-app wireframe glyph.
        let wf = toolbar_button::toggle(ui, wire, "\u{1F578}", "Wireframe");
        self.hits.insert("wireframe".into(), wf.rect);
        if wf.clicked() {
            let next = !wire;
            let _ = state.apply_settings_json(&format!("{{\"wireframe\": {next}}}"));
            // Persist the full settings through the same seam the settings panel
            // uses, so the toggle survives a reload and both views agree.
            let _ = store.write(SETTINGS_KEY, &state.settings_json());
        }

        // Projection: reflect the LIVE camera mode — the toggle is highlighted while
        // in perspective. Flip it through the SAME settings-apply path wireframe uses
        // (`apply_settings_json` reads `orthographic` and drives the camera), then
        // persist the full settings — so, like wireframe, the projection is now a
        // real setting that survives a reload and agrees with the settings panel.
        let is_persp =
            matches!(state.camera.projection, brep_render::view::Projection::Perspective { .. });
        // Still-camera icon artwork — the ortho ↔ perspective
        // toggle. The tooltip names the CURRENT mode.
        let proj_tip = if is_persp {
            "Perspective projection"
        } else {
            "Orthographic projection"
        };
        let proj = toolbar_button::toggle(ui, is_persp, "\u{E018}", proj_tip);
        self.hits.insert("projection".into(), proj.rect);
        if proj.clicked() {
            let want_ortho = is_persp; // currently perspective → switch to orthographic
            let _ = state.apply_settings_json(&format!("{{\"orthographic\": {want_ortho}}}"));
            let _ = store.write(SETTINGS_KEY, &state.settings_json());
        }

        // Square-with-four-corners (U+26F6) — the previous-app zoom-to-fit glyph.
        let fit = toolbar_button::button(ui, "\u{26F6}", "Zoom to fit");
        self.hits.insert("fit".into(), fit.rect);
        if fit.clicked() {
            state.zoom_to_fit();
        }
    }
}

#[cfg(test)]
mod tests {
    use super::*;
    use brep_render::engine_state::EngineState;
    use brep_render::view::Projection;

    /// A no-op `ModelStore`: `view_actions` only touches the store on a wireframe
    /// click, and this headless draw injects no pointer input, so nothing is
    /// clicked and the store is never read/written.
    struct NullStore;
    impl ModelStore for NullStore {
        fn read(&self, _key: &str) -> Option<String> {
            None
        }
        fn write(&self, _key: &str, _val: &str) -> Result<(), String> {
            Ok(())
        }
    }

    fn is_perspective(state: &EngineState) -> bool {
        matches!(state.camera.projection, Projection::Perspective { .. })
    }

    /// The new projection toggle must (a) publish a `projection` hit-rect each
    /// frame (the headed verifier drives it by that rect) and (b) flip the camera
    /// mode through the exact `set_projection` strings the button passes — which
    /// marks the view dirty so the viewport re-renders.
    #[test]
    fn projection_toggle_publishes_hit_and_flips_mode() {
        let mut panel = ToolbarPanel::new();
        let mut state = EngineState::new();
        let store = NullStore;

        // The seed camera is orthographic (view.rs `Default`).
        assert!(!is_perspective(&state), "seed camera should be orthographic");

        // Draw one headless egui frame of the view actions; layout records the
        // per-frame hit-rects (no pointer input → nothing is clicked).
        let ctx = egui::Context::default();
        let _ = ctx.run_ui(egui::RawInput::default(), |ui| {
            panel.view_actions(ui, &mut state, &store);
        });
        assert!(
            panel.hits.contains_key("projection"),
            "toolbar must publish a `projection` hit-rect, got {:?}",
            panel.hits.keys().collect::<Vec<_>>()
        );

        // The toggle path round-trips the camera projection and marks it dirty.
        state.dirty = false;
        state.set_projection("perspective");
        assert!(is_perspective(&state), "set_projection(perspective) → perspective");
        assert!(state.dirty, "a projection flip must mark the view dirty for a redraw");
        state.set_projection("orthographic");
        assert!(!is_perspective(&state), "set_projection(orthographic) → orthographic");
    }

    /// A synthetic workbench button (test-only, since Phase 1 ships no real
    /// buttons): drawing it publishes a hit-rect, and a real press+release click
    /// surfaces its `id` through the toolbar return path.
    #[test]
    fn workbench_button_click_surfaces_its_id() {
        let button = workbench::WorkbenchButton {
            id: "test:flat",
            glyph: "\u{2699}",
            tooltip: "Flat pattern (test)",
        };
        let buttons: Vec<&workbench::WorkbenchButton> = vec![&button];
        let ctx = egui::Context::default();

        let draw = |panel: &mut ToolbarPanel, events: Vec<egui::Event>| -> Option<&'static str> {
            let raw = egui::RawInput {
                screen_rect: Some(egui::Rect::from_min_size(
                    egui::pos2(0.0, 0.0),
                    egui::vec2(400.0, 120.0),
                )),
                events,
                ..Default::default()
            };
            let mut out = None;
            let _ = ctx.run_ui(raw, |ui| {
                out = panel.draw_workbench_buttons(ui, &buttons);
            });
            out
        };

        // Frame 1: lay out, capture the button rect, no click yet.
        let mut panel = ToolbarPanel::new();
        assert!(draw(&mut panel, vec![]).is_none(), "a passive render is not a click");
        let rect = *panel
            .hits
            .get("workbench:btn:test:flat")
            .expect("the button publishes a hit-rect");
        let pos = rect.center();

        // Frame 2: press.
        draw(
            &mut panel,
            vec![
                egui::Event::PointerMoved(pos),
                egui::Event::PointerButton {
                    pos,
                    button: egui::PointerButton::Primary,
                    pressed: true,
                    modifiers: egui::Modifiers::default(),
                },
            ],
        );
        // Frame 3: release → the click fires and the id flows out the return path.
        let clicked = draw(
            &mut panel,
            vec![egui::Event::PointerButton {
                pos,
                button: egui::PointerButton::Primary,
                pressed: false,
                modifiers: egui::Modifiers::default(),
            }],
        );
        assert_eq!(clicked, Some("test:flat"), "the clicked button's id surfaces via the return path");
    }

    /// Sanity: the Sheet Metal workbench now declares the real flat-pattern
    /// button (Phase 2), but a PASSIVE render (no pointer input) is not a click,
    /// so the row draws it and returns `None`.
    #[test]
    fn real_workbench_button_passive_render_no_click() {
        let mut panel = ToolbarPanel::new();
        let ctx = egui::Context::default();
        let mut clicked = Some("sentinel");
        let _ = ctx.run_ui(egui::RawInput::default(), |ui| {
            clicked = panel.workbench_buttons_row(ui, "sheetMetal");
        });
        assert_eq!(clicked, None, "a passive render is not a click");
        // The button was nonetheless laid out and published its hit-rect.
        assert!(panel.hits.contains_key("workbench:btn:sheetmetal.flat_pattern"));
    }
}