1use async_trait::async_trait;
2use bamboo_agent_core::{Tool, ToolCtx, ToolError, ToolOutcome, ToolResult};
3use serde::Deserialize;
4use serde_json::json;
5use std::collections::HashSet;
6use std::path::Path;
7
8use super::read_tracker::{BaselineAdvance, ReadState};
9use super::{content_diagnostics, file_change, read_tracker};
10
11const MAX_PATCH_BYTES: usize = 256 * 1024;
12const MAX_PATCH_BLOCKS: usize = 128;
13const MAX_PATCH_BLOCK_BYTES: usize = 64 * 1024;
14const MAX_SAFE_EDIT_SCOPE_LINES: usize = 120;
15const MAX_SAFE_REPLACE_ALL_OCCURRENCES: usize = 8;
16const MAX_SAFE_REPLACE_ALL_SCOPE_LINES: usize = 80;
17const MIN_REPLACE_ALL_NON_WHITESPACE_CHARS: usize = 2;
18const MIN_REPLACE_ALL_LINES: usize = 1;
19
20#[derive(Debug, Deserialize)]
21struct EditArgs {
22 file_path: String,
23 #[serde(default)]
24 old_string: Option<String>,
25 #[serde(default)]
26 new_string: Option<String>,
27 #[serde(default)]
28 replace_all: Option<bool>,
29 #[serde(default)]
30 patch: Option<String>,
31 #[serde(default)]
32 line_number: Option<usize>,
33}
34
35pub struct EditTool;
36
37#[derive(Debug, Clone)]
38struct ReplacementCandidate {
39 start: usize,
40 matched_len: usize,
41 replacement: String,
42 start_line: usize,
43 end_line: usize,
44}
45
46#[derive(Debug, Clone)]
47struct AppliedEdit {
48 updated: String,
49 replacements: usize,
50}
51
52impl EditTool {
53 pub fn new() -> Self {
54 Self
55 }
56
57 fn to_lf(value: &str) -> String {
58 value.replace("\r\n", "\n")
59 }
60
61 fn to_crlf(value: &str) -> String {
62 Self::to_lf(value).replace('\n', "\r\n")
63 }
64
65 fn has_meaningful_optional_text(value: Option<&str>) -> bool {
66 value.is_some_and(|text| !text.is_empty())
67 }
68
69 fn line_starts(content: &str) -> Vec<usize> {
70 let mut starts = vec![0usize];
71 for (idx, byte) in content.bytes().enumerate() {
72 if byte == b'\n' && idx + 1 < content.len() {
73 starts.push(idx + 1);
74 }
75 }
76 starts
77 }
78
79 fn line_for_offset(line_starts: &[usize], offset: usize) -> usize {
80 line_starts.partition_point(|line_start| *line_start <= offset)
81 }
82
83 fn has_candidate_containing_line(
84 candidates: &[ReplacementCandidate],
85 line_number: usize,
86 ) -> bool {
87 candidates.iter().any(|candidate| {
88 candidate.start_line <= line_number && line_number <= candidate.end_line
89 })
90 }
91
92 fn validate_replace_all_scope(old_string: &str) -> Result<(), ToolError> {
93 let non_whitespace_chars = old_string.chars().filter(|ch| !ch.is_whitespace()).count();
94 if non_whitespace_chars < MIN_REPLACE_ALL_NON_WHITESPACE_CHARS {
95 return Err(ToolError::InvalidArguments(format!(
96 "replace_all requires old_string to contain at least {} non-whitespace characters",
97 MIN_REPLACE_ALL_NON_WHITESPACE_CHARS
98 )));
99 }
100
101 let non_empty_lines = old_string
102 .lines()
103 .filter(|line| !line.trim().is_empty())
104 .count();
105 if non_empty_lines < MIN_REPLACE_ALL_LINES {
106 return Err(ToolError::InvalidArguments(
107 "replace_all requires old_string to contain at least one non-empty line"
108 .to_string(),
109 ));
110 }
111
112 Ok(())
113 }
114
115 fn ensure_safe_scope(
116 replace_all: bool,
117 replacements: usize,
118 touched_lines: usize,
119 ) -> Result<(), ToolError> {
120 if replace_all && replacements > MAX_SAFE_REPLACE_ALL_OCCURRENCES {
121 return Err(ToolError::Execution(format!(
122 "replace_all would modify {} occurrences, exceeding the safe limit of {}; provide a more specific old_string or use patch mode",
123 replacements, MAX_SAFE_REPLACE_ALL_OCCURRENCES
124 )));
125 }
126
127 let max_scope = if replace_all {
128 MAX_SAFE_REPLACE_ALL_SCOPE_LINES
129 } else {
130 MAX_SAFE_EDIT_SCOPE_LINES
131 };
132
133 if touched_lines > max_scope {
134 let guidance = if replace_all {
135 "provide a more specific old_string or use patch mode"
136 } else {
137 "split the change into smaller patches or use Write for intentional full-file rewrites"
138 };
139 return Err(ToolError::Execution(format!(
140 "Edit would touch {} diff lines, exceeding the safe limit of {}; {}",
141 touched_lines, max_scope, guidance
142 )));
143 }
144
145 Ok(())
146 }
147
148 fn replacement_variants(
149 content: &str,
150 old_text: &str,
151 new_text: &str,
152 ) -> Vec<(String, String)> {
153 let mut variants: Vec<(String, String)> = Vec::new();
154 let mut seen_variants: HashSet<(String, String)> = HashSet::new();
155 let mut push_variant = |search: String, replace: String| {
156 if seen_variants.insert((search.clone(), replace.clone())) {
157 variants.push((search, replace));
158 }
159 };
160
161 push_variant(old_text.to_string(), new_text.to_string());
162 push_variant(Self::to_lf(old_text), Self::to_lf(new_text));
163 if content.contains("\r\n") {
164 push_variant(Self::to_crlf(old_text), Self::to_crlf(new_text));
165 }
166
167 variants
168 }
169
170 fn collect_candidates(
171 content: &str,
172 old_text: &str,
173 new_text: &str,
174 ) -> Vec<ReplacementCandidate> {
175 let variants = Self::replacement_variants(content, old_text, new_text);
176 let line_starts = Self::line_starts(content);
177 let mut out: Vec<ReplacementCandidate> = Vec::new();
178 let mut seen_matches: HashSet<(usize, usize, String)> = HashSet::new();
179
180 for (search, replacement) in variants {
181 if search.is_empty() {
182 continue;
183 }
184 for (start, _) in content.match_indices(&search) {
185 let matched_len = search.len();
186 let end = start + matched_len - 1;
187 let candidate = ReplacementCandidate {
188 start,
189 matched_len,
190 replacement: replacement.clone(),
191 start_line: Self::line_for_offset(&line_starts, start),
192 end_line: Self::line_for_offset(&line_starts, end),
193 };
194 if seen_matches.insert((start, matched_len, candidate.replacement.clone())) {
195 out.push(candidate);
196 }
197 }
198 }
199
200 out.sort_by_key(|candidate| candidate.start);
201 out
202 }
203
204 fn candidate_line_summary(candidates: &[ReplacementCandidate]) -> String {
205 let mut lines = candidates
206 .iter()
207 .map(|candidate| candidate.start_line.to_string())
208 .collect::<Vec<_>>();
209 lines.sort();
210 lines.dedup();
211 lines.join(", ")
212 }
213
214 fn choose_candidate_with_line_hint(
215 candidates: &[ReplacementCandidate],
216 line_number: usize,
217 ) -> Option<ReplacementCandidate> {
218 let containing = candidates
219 .iter()
220 .filter(|candidate| {
221 candidate.start_line <= line_number && line_number <= candidate.end_line
222 })
223 .cloned()
224 .collect::<Vec<_>>();
225
226 if containing.is_empty() {
227 return None;
228 }
229
230 let mut best: Option<ReplacementCandidate> = None;
231 let mut best_distance = usize::MAX;
232 let mut tie = false;
233
234 for candidate in containing {
235 let distance = candidate.start_line.abs_diff(line_number);
236 if distance < best_distance {
237 best_distance = distance;
238 best = Some(candidate);
239 tie = false;
240 } else if distance == best_distance {
241 tie = true;
242 }
243 }
244
245 if tie {
246 None
247 } else {
248 best
249 }
250 }
251
252 fn apply_single_replacement(
253 content: &str,
254 old_string: &str,
255 new_string: &str,
256 replace_all: bool,
257 line_number: Option<usize>,
258 ) -> Result<AppliedEdit, ToolError> {
259 if old_string == new_string {
260 return Err(ToolError::InvalidArguments(
261 "new_string must be different from old_string".to_string(),
262 ));
263 }
264 if old_string.is_empty() {
265 return Err(ToolError::InvalidArguments(
266 "old_string must be non-empty".to_string(),
267 ));
268 }
269
270 if let Some(line) = line_number {
271 if line == 0 {
272 return Err(ToolError::InvalidArguments(
273 "line_number must be >= 1".to_string(),
274 ));
275 }
276 if replace_all {
277 return Err(ToolError::InvalidArguments(
278 "line_number cannot be combined with replace_all=true".to_string(),
279 ));
280 }
281 }
282
283 let candidates = Self::collect_candidates(content, old_string, new_string);
284
285 if candidates.is_empty() {
286 return Err(ToolError::Execution(
287 "old_string not found in target file".to_string(),
288 ));
289 }
290
291 if !replace_all && candidates.len() != 1 && line_number.is_none() {
292 return Err(ToolError::Execution(format!(
293 "old_string matched {} times; provide a more specific old_string, set line_number, or use patch mode with additional context",
294 candidates.len()
295 )));
296 }
297
298 if replace_all {
299 Self::validate_replace_all_scope(old_string)?;
300 let variants = Self::replacement_variants(content, old_string, new_string);
301 for (search, replacement) in variants {
302 let matches = content.match_indices(&search).count();
303 if matches > 0 {
304 return Ok(AppliedEdit {
305 updated: content.replace(&search, &replacement),
306 replacements: matches,
307 });
308 }
309 }
310
311 return Ok(AppliedEdit {
312 updated: content.to_string(),
313 replacements: 0,
314 });
315 }
316
317 let chosen = if let Some(line) = line_number {
318 match Self::choose_candidate_with_line_hint(&candidates, line) {
319 Some(candidate) => candidate,
320 None if Self::has_candidate_containing_line(&candidates, line) => {
321 return Err(ToolError::Execution(format!(
322 "old_string matched {} times and line_number={} was not unique among candidates containing that line; candidate start lines: {}. Provide a more specific old_string or patch context",
323 candidates.len(),
324 line,
325 Self::candidate_line_summary(&candidates),
326 )));
327 }
328 None => {
329 return Err(ToolError::Execution(format!(
330 "line_number={} did not match any old_string candidate; candidate start lines: {}. Provide a line_number within the target match or use patch context",
331 line,
332 Self::candidate_line_summary(&candidates),
333 )));
334 }
335 }
336 } else {
337 candidates[0].clone()
338 };
339
340 let mut next = String::with_capacity(
341 content.len().saturating_sub(chosen.matched_len) + chosen.replacement.len(),
342 );
343 next.push_str(&content[..chosen.start]);
344 next.push_str(&chosen.replacement);
345 next.push_str(&content[chosen.start + chosen.matched_len..]);
346
347 Ok(AppliedEdit {
348 updated: next,
349 replacements: 1,
350 })
351 }
352
353 fn parse_patch_blocks(patch: &str) -> Result<Vec<(String, String)>, ToolError> {
354 const SEARCH: &str = "<<<<<<< SEARCH\n";
355 const SEP: &str = "\n=======\n";
356 const REPLACE: &str = "\n>>>>>>> REPLACE";
357
358 let normalized = patch.replace("\r\n", "\n");
359 if normalized.trim().is_empty() {
360 return Err(ToolError::InvalidArguments(
361 "patch must be non-empty".to_string(),
362 ));
363 }
364 if normalized.len() > MAX_PATCH_BYTES {
365 return Err(ToolError::InvalidArguments(format!(
366 "patch exceeds max size of {} bytes",
367 MAX_PATCH_BYTES
368 )));
369 }
370
371 let mut cursor = 0usize;
372 let mut blocks = Vec::new();
373 while let Some(start_rel) = normalized[cursor..].find(SEARCH) {
374 if blocks.len() >= MAX_PATCH_BLOCKS {
375 return Err(ToolError::InvalidArguments(format!(
376 "patch exceeds max block count of {}",
377 MAX_PATCH_BLOCKS
378 )));
379 }
380 let search_start = cursor + start_rel + SEARCH.len();
381 let sep_rel = normalized[search_start..].find(SEP).ok_or_else(|| {
382 ToolError::InvalidArguments("Malformed patch block: missing =======".to_string())
383 })?;
384 let sep_idx = search_start + sep_rel;
385 let replace_start = sep_idx + SEP.len();
386 let replace_rel = normalized[replace_start..].find(REPLACE).ok_or_else(|| {
387 ToolError::InvalidArguments(
388 "Malformed patch block: missing >>>>>>> REPLACE".to_string(),
389 )
390 })?;
391 let replace_idx = replace_start + replace_rel;
392
393 let old_block = normalized[search_start..sep_idx].to_string();
394 let new_block = normalized[replace_start..replace_idx].to_string();
395 if old_block.is_empty() {
396 return Err(ToolError::InvalidArguments(
397 "Patch SEARCH block must be non-empty".to_string(),
398 ));
399 }
400 if old_block.len() > MAX_PATCH_BLOCK_BYTES || new_block.len() > MAX_PATCH_BLOCK_BYTES {
401 return Err(ToolError::InvalidArguments(format!(
402 "Patch block exceeds max block size of {} bytes",
403 MAX_PATCH_BLOCK_BYTES
404 )));
405 }
406 blocks.push((old_block, new_block));
407
408 cursor = replace_idx + REPLACE.len();
409 if normalized[cursor..].starts_with('\n') {
410 cursor += 1;
411 }
412 }
413
414 if blocks.is_empty() {
415 return Err(ToolError::InvalidArguments(
416 "patch must contain at least one SEARCH/REPLACE block".to_string(),
417 ));
418 }
419
420 Ok(blocks)
421 }
422
423 fn apply_patch_mode(
424 content: &str,
425 patch: &str,
426 line_number: Option<usize>,
427 ) -> Result<AppliedEdit, ToolError> {
428 if let Some(line) = line_number {
429 if line == 0 {
430 return Err(ToolError::InvalidArguments(
431 "line_number must be >= 1".to_string(),
432 ));
433 }
434 }
435 let blocks = Self::parse_patch_blocks(patch)?;
436 let mut updated = content.to_string();
437 let mut replacements = 0usize;
438
439 for (idx, (old_block, new_block)) in blocks.iter().enumerate() {
440 let candidates = Self::collect_candidates(&updated, old_block, new_block);
441
442 if candidates.is_empty() {
443 return Err(ToolError::Execution(format!(
444 "Patch block {} SEARCH content not found in target file",
445 idx + 1
446 )));
447 }
448
449 let chosen = if candidates.len() == 1 {
450 candidates[0].clone()
451 } else if let Some(line) = line_number {
452 match Self::choose_candidate_with_line_hint(&candidates, line) {
453 Some(candidate) => candidate,
454 None if Self::has_candidate_containing_line(&candidates, line) => {
455 return Err(ToolError::Execution(format!(
456 "Patch block {} SEARCH content matched {} times and line_number={} was not unique among candidates containing that line; candidate start lines: {}. Add more context to make it unique",
457 idx + 1,
458 candidates.len(),
459 line,
460 Self::candidate_line_summary(&candidates),
461 )));
462 }
463 None => {
464 return Err(ToolError::Execution(format!(
465 "Patch block {} line_number={} did not match any SEARCH candidate; candidate start lines: {}. Add more context or use a line within the target block",
466 idx + 1,
467 line,
468 Self::candidate_line_summary(&candidates),
469 )));
470 }
471 }
472 } else {
473 return Err(ToolError::Execution(format!(
474 "Patch block {} SEARCH content matched {} times; set line_number or add more context to make it unique",
475 idx + 1,
476 candidates.len()
477 )));
478 };
479
480 let mut next = String::with_capacity(
481 updated.len().saturating_sub(chosen.matched_len) + chosen.replacement.len(),
482 );
483 next.push_str(&updated[..chosen.start]);
484 next.push_str(&chosen.replacement);
485 next.push_str(&updated[chosen.start + chosen.matched_len..]);
486 updated = next;
487 replacements += 1;
488 }
489
490 Ok(AppliedEdit {
491 updated,
492 replacements,
493 })
494 }
495}
496
497impl Default for EditTool {
498 fn default() -> Self {
499 Self::new()
500 }
501}
502
503#[async_trait]
504impl Tool for EditTool {
505 fn name(&self) -> &str {
506 "Edit"
507 }
508
509 fn description(&self) -> &str {
510 "Edit existing files via exact replacements or SEARCH/REPLACE patch blocks. IMPORTANT: call Read first in this session or Edit will fail."
511 }
512
513 fn parameters_schema(&self) -> serde_json::Value {
514 json!({
515 "type": "object",
516 "properties": {
517 "file_path": {
518 "type": "string",
519 "description": "The absolute path to the file to modify"
520 },
521 "old_string": {
522 "type": "string",
523 "description": "Legacy mode only: exact text to replace. Do not send with patch mode."
524 },
525 "new_string": {
526 "type": "string",
527 "description": "Legacy mode only: replacement text. Do not send with patch mode."
528 },
529 "replace_all": {
530 "type": "boolean",
531 "default": false,
532 "description": "Legacy mode only: replace all occurrences. Do not send with patch mode."
533 },
534 "patch": {
535 "type": "string",
536 "description": "Patch mode: one or more blocks using <<<<<<< SEARCH / ======= / >>>>>>> REPLACE. Preferred mode. Do not combine with non-empty old_string/new_string or replace_all=true."
537 },
538 "line_number": {
539 "type": "integer",
540 "minimum": 1,
541 "description": "Optional 1-based line hint to disambiguate duplicate matches"
542 }
543 },
544 "required": ["file_path"],
545 "additionalProperties": false
546 })
547 }
548
549 async fn invoke(
550 &self,
551 args: serde_json::Value,
552 ctx: ToolCtx,
553 ) -> Result<ToolOutcome, ToolError> {
554 let parsed: EditArgs = serde_json::from_value(args)
555 .map_err(|e| ToolError::InvalidArguments(format!("Invalid Edit args: {}", e)))?;
556
557 let file_path = parsed.file_path.trim();
558 let path = Path::new(file_path);
559 if !path.is_absolute() {
560 return Err(ToolError::InvalidArguments(
561 "file_path must be an absolute path".to_string(),
562 ));
563 }
564
565 let session_id = ctx.session_id().map(str::to_owned);
566 let validated_read = if let Some(session_id) = session_id.as_deref() {
567 match read_tracker::read_if_fresh(session_id, file_path).await {
568 Ok(validated) => Some(validated),
569 Err(ReadState::Unread) => {
570 return Err(ToolError::Execution(
571 "Edit requires reading the target file first via Read".to_string(),
572 ));
573 }
574 Err(ReadState::Stale) => {
575 return Err(ToolError::Execution(
576 "Target file changed after last Read; call Read again before Edit"
577 .to_string(),
578 ));
579 }
580 Err(ReadState::Fresh) => unreachable!("Fresh is returned as a validated read"),
581 }
582 } else {
583 None
584 };
585
586 let content = if let Some(validated) = validated_read.as_ref() {
587 String::from_utf8(validated.bytes().to_vec())
588 .map_err(|e| ToolError::Execution(format!("Failed to read file: {}", e)))?
589 } else {
590 tokio::fs::read_to_string(path)
591 .await
592 .map_err(|e| ToolError::Execution(format!("Failed to read file: {}", e)))?
593 };
594
595 let patch = parsed
596 .patch
597 .as_deref()
598 .map(str::trim)
599 .filter(|value| !value.is_empty());
600 let old_string = parsed.old_string.as_deref();
601 let new_string = parsed.new_string.as_deref();
602
603 let requested_replace_all = parsed.replace_all.unwrap_or(false);
604 let line_number_hint = parsed.line_number;
605 let used_patch_mode = patch.is_some();
606
607 let AppliedEdit {
608 updated,
609 replacements,
610 } = if let Some(patch_text) = patch {
611 if Self::has_meaningful_optional_text(old_string)
612 || Self::has_meaningful_optional_text(new_string)
613 || requested_replace_all
614 {
615 return Err(ToolError::InvalidArguments(
616 "patch mode cannot be combined with old_string/new_string/replace_all"
617 .to_string(),
618 ));
619 }
620 Self::apply_patch_mode(&content, patch_text, parsed.line_number)?
621 } else {
622 let old = old_string.ok_or_else(|| {
623 ToolError::InvalidArguments(
624 "old_string is required unless patch mode is used".to_string(),
625 )
626 })?;
627 let new = new_string.ok_or_else(|| {
628 ToolError::InvalidArguments(
629 "new_string is required unless patch mode is used".to_string(),
630 )
631 })?;
632 Self::apply_single_replacement(
633 &content,
634 old,
635 new,
636 requested_replace_all,
637 parsed.line_number,
638 )?
639 };
640 let mode_label = if used_patch_mode { "patch" } else { "legacy" };
641 let touched_lines = file_change::touched_line_count(&content, &updated);
642
643 Self::ensure_safe_scope(requested_replace_all, replacements, touched_lines)?;
644
645 let checkpoint = file_change::create_checkpoint(path, Some(content.as_bytes())).await?;
646
647 let write_expectation = validated_read.as_ref().map_or(
648 file_change::AtomicWriteExpectation::Unchecked,
649 |validated| file_change::AtomicWriteExpectation::Exact(validated.bytes()),
650 );
651 file_change::atomic_write_text_with_expectation(path, &updated, write_expectation).await?;
652
653 if session_id.is_some() {
654 let validated = validated_read
655 .as_ref()
656 .expect("a session-scoped Edit always has a validated Read");
657 if read_tracker::advance_after_verified_write(
658 file_path,
659 validated.slot(),
660 updated.as_bytes(),
661 )
662 .await
663 == BaselineAdvance::Conflict
664 {
665 return Err(ToolError::Execution(
666 "Edit committed, but the target changed before it could be verified; call Read again"
667 .to_string(),
668 ));
669 }
670 }
671
672 let changed_bytes = updated.len().abs_diff(content.len());
673 let changed_lines = updated.lines().count().abs_diff(content.lines().count());
674
675 let mut payload = file_change::build_file_change_payload_value(
676 "Edit",
677 path,
678 format!(
679 "Edited file: {} (mode: {}, replacements: {})",
680 file_path, mode_label, replacements
681 ),
682 checkpoint,
683 &content,
684 &updated,
685 );
686 if let Some(obj) = payload.as_object_mut() {
687 obj.insert("edit_mode".to_string(), json!(mode_label));
688 obj.insert("replacements".to_string(), json!(replacements));
689 obj.insert(
690 "requested_replace_all".to_string(),
691 json!(requested_replace_all),
692 );
693 obj.insert("used_patch_mode".to_string(), json!(used_patch_mode));
694 obj.insert("line_number_hint".to_string(), json!(line_number_hint));
695 obj.insert("changed_bytes".to_string(), json!(changed_bytes));
696 obj.insert("changed_lines".to_string(), json!(changed_lines));
697 obj.insert("touched_lines".to_string(), json!(touched_lines));
698 }
699 content_diagnostics::attach_file_diagnostics(&mut payload, path, &updated);
700
701 Ok(ToolOutcome::Completed(ToolResult {
702 success: true,
703 result: payload.to_string(),
704 display_preference: Some("Default".to_string()),
705 images: Vec::new(),
706 }))
707 }
708}
709
710#[cfg(test)]
711mod tests {
712 use super::*;
713 use crate::tools::ReadTool;
714 use serde_json::json;
715
716 fn ctx(session_id: &str) -> ToolCtx {
717 ToolCtx {
718 executing_supervisor: None,
719 session_id: Some(std::sync::Arc::from(session_id)),
720 tool_call_id: std::sync::Arc::from("call_1"),
721 event_tx: None,
722 available_tool_schemas: std::sync::Arc::from(Vec::new()),
723 bypass_permissions: false,
724 auto_approve_permissions: false,
725 plan_read_only: false,
726 can_async_resume: false,
727 async_completion_sink: None,
728 bash_completion_sink: None,
729 }
730 }
731
732 async fn run(tool: &EditTool, args: serde_json::Value) -> Result<ToolResult, ToolError> {
733 match tool.invoke(args, ToolCtx::none("t")).await? {
734 ToolOutcome::Completed(r) => Ok(r),
735 _ => panic!("expected Completed"),
736 }
737 }
738
739 #[tokio::test]
740 async fn edit_requires_unique_match_without_replace_all() {
741 let file = tempfile::NamedTempFile::new().unwrap();
742 tokio::fs::write(file.path(), "foo\nfoo\n").await.unwrap();
743
744 let tool = EditTool::new();
745 let result = run(
746 &tool,
747 json!({
748 "file_path": file.path(),
749 "old_string": "foo",
750 "new_string": "bar"
751 }),
752 )
753 .await;
754
755 assert!(result.is_err());
756 }
757
758 #[tokio::test]
759 async fn edit_supports_replace_all() {
760 let file = tempfile::NamedTempFile::new().unwrap();
761 tokio::fs::write(file.path(), "foo\nfoo\n").await.unwrap();
762
763 let tool = EditTool::new();
764 let result = run(
765 &tool,
766 json!({
767 "file_path": file.path(),
768 "old_string": "foo",
769 "new_string": "bar",
770 "replace_all": true
771 }),
772 )
773 .await
774 .unwrap();
775
776 assert!(result.success);
777 let updated = tokio::fs::read_to_string(file.path()).await.unwrap();
778 assert_eq!(updated, "bar\nbar\n");
779 }
780
781 #[tokio::test]
782 async fn edit_replace_all_does_not_reprocess_newly_inserted_matches() {
783 let file = tempfile::NamedTempFile::new().unwrap();
784 tokio::fs::write(file.path(), "a\n").await.unwrap();
785
786 let tool = EditTool::new();
787 let result = run(
788 &tool,
789 json!({
790 "file_path": file.path(),
791 "old_string": "aa",
792 "new_string": "bb",
793 "replace_all": true
794 }),
795 )
796 .await;
797
798 assert!(matches!(
799 result,
800 Err(ToolError::Execution(_)) | Err(ToolError::InvalidArguments(_))
801 ));
802 }
803
804 #[tokio::test]
805 async fn edit_replace_all_rejects_excessive_occurrence_count() {
806 let file = tempfile::NamedTempFile::new().unwrap();
807 let content = (0..=MAX_SAFE_REPLACE_ALL_OCCURRENCES)
808 .map(|_| "foo")
809 .collect::<Vec<_>>()
810 .join("\n");
811 tokio::fs::write(file.path(), format!("{content}\n"))
812 .await
813 .unwrap();
814
815 let tool = EditTool::new();
816 let result = run(
817 &tool,
818 json!({
819 "file_path": file.path(),
820 "old_string": "foo",
821 "new_string": "bar",
822 "replace_all": true
823 }),
824 )
825 .await;
826
827 assert!(
828 matches!(result, Err(ToolError::Execution(msg)) if msg.contains("replace_all would modify"))
829 );
830 }
831
832 #[tokio::test]
833 async fn edit_replace_all_rejects_too_short_old_string() {
834 let file = tempfile::NamedTempFile::new().unwrap();
835 tokio::fs::write(file.path(), "a\na\n").await.unwrap();
836
837 let tool = EditTool::new();
838 let result = run(
839 &tool,
840 json!({
841 "file_path": file.path(),
842 "old_string": "a",
843 "new_string": "b",
844 "replace_all": true
845 }),
846 )
847 .await;
848
849 assert!(
850 matches!(result, Err(ToolError::InvalidArguments(msg)) if msg.contains("non-whitespace characters"))
851 );
852 }
853
854 #[tokio::test]
855 async fn edit_replace_all_rejects_whitespace_only_old_string() {
856 let file = tempfile::NamedTempFile::new().unwrap();
857 tokio::fs::write(file.path(), " \n \n").await.unwrap();
858
859 let tool = EditTool::new();
860 let result = run(
861 &tool,
862 json!({
863 "file_path": file.path(),
864 "old_string": " ",
865 "new_string": "x",
866 "replace_all": true
867 }),
868 )
869 .await;
870
871 assert!(
872 matches!(result, Err(ToolError::InvalidArguments(msg)) if msg.contains("non-whitespace characters") || msg.contains("non-empty line"))
873 );
874 }
875
876 #[tokio::test]
877 async fn edit_requires_read_first_when_session_context_exists() {
878 let file = tempfile::NamedTempFile::new().unwrap();
879 tokio::fs::write(file.path(), "hello world\n")
880 .await
881 .unwrap();
882 let call_id = "call_1";
883
884 let edit_tool = EditTool::new();
885 let read_tool = ReadTool::new();
886
887 let denied = edit_tool
888 .invoke(
889 json!({
890 "file_path": file.path(),
891 "old_string": "world",
892 "new_string": "rust"
893 }),
894 ToolCtx {
895 executing_supervisor: None,
896 session_id: Some(std::sync::Arc::from("session_1")),
897 tool_call_id: std::sync::Arc::from(call_id),
898 event_tx: None,
899 available_tool_schemas: std::sync::Arc::from(Vec::new()),
900 bypass_permissions: false,
901 auto_approve_permissions: false,
902 plan_read_only: false,
903 can_async_resume: false,
904 async_completion_sink: None,
905 bash_completion_sink: None,
906 },
907 )
908 .await;
909 assert!(denied.is_err());
910
911 let _ = read_tool
912 .invoke(
913 json!({"file_path": file.path()}),
914 ToolCtx {
915 executing_supervisor: None,
916 session_id: Some(std::sync::Arc::from("session_1")),
917 tool_call_id: std::sync::Arc::from(call_id),
918 event_tx: None,
919 available_tool_schemas: std::sync::Arc::from(Vec::new()),
920 bypass_permissions: false,
921 auto_approve_permissions: false,
922 plan_read_only: false,
923 can_async_resume: false,
924 async_completion_sink: None,
925 bash_completion_sink: None,
926 },
927 )
928 .await
929 .unwrap();
930
931 let allowed = edit_tool
932 .invoke(
933 json!({
934 "file_path": file.path(),
935 "old_string": "world",
936 "new_string": "rust"
937 }),
938 ToolCtx {
939 executing_supervisor: None,
940 session_id: Some(std::sync::Arc::from("session_1")),
941 tool_call_id: std::sync::Arc::from(call_id),
942 event_tx: None,
943 available_tool_schemas: std::sync::Arc::from(Vec::new()),
944 bypass_permissions: false,
945 auto_approve_permissions: false,
946 plan_read_only: false,
947 can_async_resume: false,
948 async_completion_sink: None,
949 bash_completion_sink: None,
950 },
951 )
952 .await
953 .unwrap();
954 let ToolOutcome::Completed(allowed) = allowed else {
955 panic!("expected Completed")
956 };
957
958 assert!(allowed.success);
959 }
960
961 #[tokio::test]
962 async fn read_edit_edit_succeeds_without_an_external_change() {
963 let file = tempfile::NamedTempFile::new().unwrap();
964 tokio::fs::write(file.path(), "alpha\nbeta\ngamma\n")
965 .await
966 .unwrap();
967 let session = format!("edit-twice-{}", uuid::Uuid::new_v4());
968 let read_tool = ReadTool::new();
969 let edit_tool = EditTool::new();
970
971 read_tool
972 .invoke(json!({"file_path": file.path()}), ctx(&session))
973 .await
974 .unwrap();
975 edit_tool
976 .invoke(
977 json!({
978 "file_path": file.path(),
979 "old_string": "alpha",
980 "new_string": "alpha-one"
981 }),
982 ctx(&session),
983 )
984 .await
985 .unwrap();
986 edit_tool
987 .invoke(
988 json!({
989 "file_path": file.path(),
990 "old_string": "beta",
991 "new_string": "beta-two"
992 }),
993 ctx(&session),
994 )
995 .await
996 .unwrap();
997
998 assert_eq!(
999 tokio::fs::read_to_string(file.path()).await.unwrap(),
1000 "alpha-one\nbeta-two\ngamma\n"
1001 );
1002 }
1003
1004 #[tokio::test]
1005 async fn concurrent_read_of_edited_version_is_idempotent() {
1006 let file = tempfile::NamedTempFile::new().unwrap();
1007 tokio::fs::write(file.path(), "alpha\nbeta\n")
1008 .await
1009 .unwrap();
1010 let path = file.path().to_path_buf();
1011 let path_str = path.to_string_lossy().into_owned();
1012 let session = format!("edit-concurrent-read-{}", uuid::Uuid::new_v4());
1013
1014 ReadTool::new()
1015 .invoke(json!({"file_path": path}), ctx(&session))
1016 .await
1017 .unwrap();
1018 let (advance_reached, resume_advance) =
1019 read_tracker::pause_next_advance_for_test(&session, &path_str).await;
1020
1021 let edit_path = path.clone();
1022 let edit_session = session.clone();
1023 let editor = tokio::spawn(async move {
1024 EditTool::new()
1025 .invoke(
1026 json!({
1027 "file_path": edit_path,
1028 "old_string": "alpha",
1029 "new_string": "ALPHA"
1030 }),
1031 ctx(&edit_session),
1032 )
1033 .await
1034 });
1035
1036 tokio::time::timeout(
1037 std::time::Duration::from_secs(5),
1038 advance_reached.notified(),
1039 )
1040 .await
1041 .expect("Edit did not reach post-write baseline advancement");
1042 ReadTool::new()
1043 .invoke(json!({"file_path": path}), ctx(&session))
1044 .await
1045 .unwrap();
1046 resume_advance.notify_one();
1047
1048 let first = tokio::time::timeout(std::time::Duration::from_secs(5), editor)
1049 .await
1050 .expect("Edit did not resume")
1051 .unwrap()
1052 .unwrap();
1053 assert!(matches!(first, ToolOutcome::Completed(result) if result.success));
1054
1055 EditTool::new()
1056 .invoke(
1057 json!({
1058 "file_path": path,
1059 "old_string": "beta",
1060 "new_string": "BETA"
1061 }),
1062 ctx(&session),
1063 )
1064 .await
1065 .unwrap();
1066 assert_eq!(
1067 tokio::fs::read_to_string(path).await.unwrap(),
1068 "ALPHA\nBETA\n"
1069 );
1070 }
1071
1072 #[tokio::test]
1073 async fn edit_rejects_external_change_after_a_successful_edit() {
1074 let file = tempfile::NamedTempFile::new().unwrap();
1075 tokio::fs::write(file.path(), "alpha\nbeta\n")
1076 .await
1077 .unwrap();
1078 let session = format!("edit-external-{}", uuid::Uuid::new_v4());
1079 let read_tool = ReadTool::new();
1080 let edit_tool = EditTool::new();
1081
1082 read_tool
1083 .invoke(json!({"file_path": file.path()}), ctx(&session))
1084 .await
1085 .unwrap();
1086 edit_tool
1087 .invoke(
1088 json!({
1089 "file_path": file.path(),
1090 "old_string": "alpha",
1091 "new_string": "ALPHA"
1092 }),
1093 ctx(&session),
1094 )
1095 .await
1096 .unwrap();
1097
1098 tokio::fs::write(file.path(), "ALPHA\nBETA\n")
1099 .await
1100 .unwrap();
1101 let stale = edit_tool
1102 .invoke(
1103 json!({
1104 "file_path": file.path(),
1105 "old_string": "ALPHA",
1106 "new_string": "alpha-two"
1107 }),
1108 ctx(&session),
1109 )
1110 .await;
1111
1112 assert!(matches!(stale, Err(ToolError::Execution(message)) if message.contains("changed")));
1113 assert_eq!(
1114 tokio::fs::read_to_string(file.path()).await.unwrap(),
1115 "ALPHA\nBETA\n"
1116 );
1117 }
1118
1119 #[tokio::test]
1120 async fn failed_edit_does_not_break_the_existing_fresh_baseline() {
1121 let file = tempfile::NamedTempFile::new().unwrap();
1122 tokio::fs::write(file.path(), "alpha\nbeta\n")
1123 .await
1124 .unwrap();
1125 let session = format!("edit-failure-{}", uuid::Uuid::new_v4());
1126 let read_tool = ReadTool::new();
1127 let edit_tool = EditTool::new();
1128
1129 read_tool
1130 .invoke(json!({"file_path": file.path()}), ctx(&session))
1131 .await
1132 .unwrap();
1133 let failed = edit_tool
1134 .invoke(
1135 json!({
1136 "file_path": file.path(),
1137 "old_string": "not-present",
1138 "new_string": "replacement"
1139 }),
1140 ctx(&session),
1141 )
1142 .await;
1143 assert!(failed.is_err());
1144
1145 edit_tool
1146 .invoke(
1147 json!({
1148 "file_path": file.path(),
1149 "old_string": "beta",
1150 "new_string": "beta-two"
1151 }),
1152 ctx(&session),
1153 )
1154 .await
1155 .unwrap();
1156 assert_eq!(
1157 tokio::fs::read_to_string(file.path()).await.unwrap(),
1158 "alpha\nbeta-two\n"
1159 );
1160 }
1161
1162 #[tokio::test]
1163 async fn edit_rejects_empty_old_string() {
1164 let file = tempfile::NamedTempFile::new().unwrap();
1165 tokio::fs::write(file.path(), "hello").await.unwrap();
1166
1167 let tool = EditTool::new();
1168 let result = run(
1169 &tool,
1170 json!({
1171 "file_path": file.path(),
1172 "old_string": "",
1173 "new_string": "x",
1174 "replace_all": true
1175 }),
1176 )
1177 .await;
1178
1179 assert!(matches!(result, Err(ToolError::InvalidArguments(_))));
1180 }
1181
1182 #[tokio::test]
1183 async fn edit_legacy_mode_handles_crlf_when_old_string_uses_lf() {
1184 let file = tempfile::NamedTempFile::new().unwrap();
1185 tokio::fs::write(file.path(), "alpha\r\nbeta\r\n")
1186 .await
1187 .unwrap();
1188
1189 let tool = EditTool::new();
1190 let result = run(
1191 &tool,
1192 json!({
1193 "file_path": file.path(),
1194 "old_string": "alpha\nbeta\n",
1195 "new_string": "gamma\ndelta\n"
1196 }),
1197 )
1198 .await
1199 .unwrap();
1200
1201 assert!(result.success);
1202 let updated = tokio::fs::read_to_string(file.path()).await.unwrap();
1203 assert_eq!(updated, "gamma\r\ndelta\r\n");
1204 }
1205
1206 #[tokio::test]
1207 async fn edit_legacy_mode_line_number_disambiguates_duplicates() {
1208 let file = tempfile::NamedTempFile::new().unwrap();
1209 tokio::fs::write(file.path(), "foo\nbar\nfoo\n")
1210 .await
1211 .unwrap();
1212
1213 let tool = EditTool::new();
1214 let result = run(
1215 &tool,
1216 json!({
1217 "file_path": file.path(),
1218 "old_string": "foo",
1219 "new_string": "baz",
1220 "line_number": 3
1221 }),
1222 )
1223 .await
1224 .unwrap();
1225 assert!(result.success);
1226
1227 let updated = tokio::fs::read_to_string(file.path()).await.unwrap();
1228 assert_eq!(updated, "foo\nbar\nbaz\n");
1229 }
1230
1231 #[tokio::test]
1232 async fn edit_legacy_mode_rejects_line_number_when_no_candidate_contains_it() {
1233 let file = tempfile::NamedTempFile::new().unwrap();
1234 tokio::fs::write(file.path(), "foo\nbar\nfoo\n")
1235 .await
1236 .unwrap();
1237
1238 let tool = EditTool::new();
1239 let result = run(
1240 &tool,
1241 json!({
1242 "file_path": file.path(),
1243 "old_string": "foo",
1244 "new_string": "baz",
1245 "line_number": 2
1246 }),
1247 )
1248 .await;
1249
1250 assert!(
1251 matches!(result, Err(ToolError::Execution(msg)) if msg.contains("did not match any old_string candidate"))
1252 );
1253 }
1254
1255 #[tokio::test]
1256 async fn edit_legacy_mode_rejects_line_number_with_replace_all() {
1257 let file = tempfile::NamedTempFile::new().unwrap();
1258 tokio::fs::write(file.path(), "foo\nfoo\n").await.unwrap();
1259
1260 let tool = EditTool::new();
1261 let result = run(
1262 &tool,
1263 json!({
1264 "file_path": file.path(),
1265 "old_string": "foo",
1266 "new_string": "bar",
1267 "replace_all": true,
1268 "line_number": 1
1269 }),
1270 )
1271 .await;
1272
1273 assert!(
1274 matches!(result, Err(ToolError::InvalidArguments(msg)) if msg.contains("line_number cannot be combined"))
1275 );
1276 }
1277
1278 #[tokio::test]
1279 async fn edit_patch_mode_can_target_second_duplicate_with_context() {
1280 let file = tempfile::NamedTempFile::new().unwrap();
1281 tokio::fs::write(
1282 file.path(),
1283 "fn a() {\n let v = 1;\n}\n\nfn b() {\n let v = 1;\n}\n",
1284 )
1285 .await
1286 .unwrap();
1287
1288 let tool = EditTool::new();
1289 let result = run(&tool,json!({
1290 "file_path": file.path(),
1291 "patch": "<<<<<<< SEARCH\nfn b() {\n let v = 1;\n}\n=======\nfn b() {\n let v = 2;\n}\n>>>>>>> REPLACE"
1292 }))
1293 .await
1294 .unwrap();
1295 assert!(result.success);
1296
1297 let updated = tokio::fs::read_to_string(file.path()).await.unwrap();
1298 assert!(updated.contains("fn a() {\n let v = 1;\n}"));
1299 assert!(updated.contains("fn b() {\n let v = 2;\n}"));
1300 }
1301
1302 #[tokio::test]
1303 async fn edit_patch_mode_handles_crlf_when_patch_uses_lf() {
1304 let file = tempfile::NamedTempFile::new().unwrap();
1305 tokio::fs::write(file.path(), "fn b() {\r\n let v = 1;\r\n}\r\n")
1306 .await
1307 .unwrap();
1308
1309 let tool = EditTool::new();
1310 let result = run(&tool,json!({
1311 "file_path": file.path(),
1312 "patch": "<<<<<<< SEARCH\nfn b() {\n let v = 1;\n}\n=======\nfn b() {\n let v = 2;\n}\n>>>>>>> REPLACE"
1313 }))
1314 .await
1315 .unwrap();
1316 assert!(result.success);
1317
1318 let updated = tokio::fs::read_to_string(file.path()).await.unwrap();
1319 assert_eq!(updated, "fn b() {\r\n let v = 2;\r\n}\r\n");
1320 }
1321
1322 #[tokio::test]
1323 async fn edit_patch_mode_line_number_disambiguates_duplicates() {
1324 let file = tempfile::NamedTempFile::new().unwrap();
1325 tokio::fs::write(file.path(), "x = 1;\nx = 1;\n")
1326 .await
1327 .unwrap();
1328
1329 let tool = EditTool::new();
1330 let result = run(
1331 &tool,
1332 json!({
1333 "file_path": file.path(),
1334 "line_number": 2,
1335 "patch": "<<<<<<< SEARCH\nx = 1;\n=======\nx = 2;\n>>>>>>> REPLACE"
1336 }),
1337 )
1338 .await
1339 .unwrap();
1340 assert!(result.success);
1341
1342 let updated = tokio::fs::read_to_string(file.path()).await.unwrap();
1343 assert_eq!(updated, "x = 1;\nx = 2;\n");
1344 }
1345
1346 #[tokio::test]
1347 async fn edit_patch_mode_rejects_line_number_when_no_candidate_contains_it() {
1348 let file = tempfile::NamedTempFile::new().unwrap();
1349 tokio::fs::write(file.path(), "x = 1;\ny = 0;\nx = 1;\n")
1350 .await
1351 .unwrap();
1352
1353 let tool = EditTool::new();
1354 let result = run(
1355 &tool,
1356 json!({
1357 "file_path": file.path(),
1358 "line_number": 2,
1359 "patch": "<<<<<<< SEARCH\nx = 1;\n=======\nx = 2;\n>>>>>>> REPLACE"
1360 }),
1361 )
1362 .await;
1363
1364 assert!(
1365 matches!(result, Err(ToolError::Execution(msg)) if msg.contains("did not match any SEARCH candidate"))
1366 );
1367 }
1368
1369 #[tokio::test]
1370 async fn edit_patch_mode_rejects_ambiguous_search_block() {
1371 let file = tempfile::NamedTempFile::new().unwrap();
1372 tokio::fs::write(file.path(), "x = 1;\nx = 1;\n")
1373 .await
1374 .unwrap();
1375
1376 let tool = EditTool::new();
1377 let result = run(
1378 &tool,
1379 json!({
1380 "file_path": file.path(),
1381 "patch": "<<<<<<< SEARCH\nx = 1;\n=======\nx = 2;\n>>>>>>> REPLACE"
1382 }),
1383 )
1384 .await;
1385
1386 assert!(
1387 matches!(result, Err(ToolError::Execution(msg)) if msg.contains("matched 2 times"))
1388 );
1389 }
1390
1391 #[tokio::test]
1392 async fn edit_patch_mode_rejects_large_scope_edits() {
1393 let file = tempfile::NamedTempFile::new().unwrap();
1394 let old_block = (0..70)
1395 .map(|idx| format!("line {idx}"))
1396 .collect::<Vec<_>>()
1397 .join("\n");
1398 let new_block = (0..70)
1399 .map(|idx| format!("updated {idx}"))
1400 .collect::<Vec<_>>()
1401 .join("\n");
1402 tokio::fs::write(file.path(), format!("{old_block}\n"))
1403 .await
1404 .unwrap();
1405
1406 let patch = format!("<<<<<<< SEARCH\n{old_block}\n=======\n{new_block}\n>>>>>>> REPLACE");
1407
1408 let tool = EditTool::new();
1409 let result = run(
1410 &tool,
1411 json!({
1412 "file_path": file.path(),
1413 "patch": patch
1414 }),
1415 )
1416 .await;
1417
1418 assert!(
1419 matches!(result, Err(ToolError::Execution(msg)) if msg.contains("exceeding the safe limit"))
1420 );
1421 }
1422
1423 #[tokio::test]
1424 async fn edit_rejects_mixed_patch_and_legacy_args() {
1425 let file = tempfile::NamedTempFile::new().unwrap();
1426 tokio::fs::write(file.path(), "hello").await.unwrap();
1427
1428 let tool = EditTool::new();
1429 let result = run(
1430 &tool,
1431 json!({
1432 "file_path": file.path(),
1433 "old_string": "hello",
1434 "new_string": "world",
1435 "patch": "<<<<<<< SEARCH\nhello\n=======\nworld\n>>>>>>> REPLACE"
1436 }),
1437 )
1438 .await;
1439
1440 assert!(
1441 matches!(result, Err(ToolError::InvalidArguments(msg)) if msg.contains("cannot be combined"))
1442 );
1443 }
1444
1445 #[tokio::test]
1446 async fn edit_patch_mode_ignores_empty_legacy_placeholders() {
1447 let file = tempfile::NamedTempFile::new().unwrap();
1448 tokio::fs::write(file.path(), "hello").await.unwrap();
1449
1450 let tool = EditTool::new();
1451 let result = run(
1452 &tool,
1453 json!({
1454 "file_path": file.path(),
1455 "old_string": "",
1456 "new_string": "",
1457 "replace_all": false,
1458 "patch": "<<<<<<< SEARCH\nhello\n=======\nworld\n>>>>>>> REPLACE"
1459 }),
1460 )
1461 .await
1462 .unwrap();
1463
1464 assert!(result.success);
1465 let updated = tokio::fs::read_to_string(file.path()).await.unwrap();
1466 assert_eq!(updated, "world");
1467 }
1468
1469 #[tokio::test]
1470 async fn edit_patch_rejects_oversized_patch_payload() {
1471 let file = tempfile::NamedTempFile::new().unwrap();
1472 tokio::fs::write(file.path(), "hello world").await.unwrap();
1473 let huge = "a".repeat(MAX_PATCH_BYTES + 1);
1474
1475 let tool = EditTool::new();
1476 let result = run(
1477 &tool,
1478 json!({
1479 "file_path": file.path(),
1480 "patch": huge
1481 }),
1482 )
1483 .await;
1484
1485 assert!(
1486 matches!(result, Err(ToolError::InvalidArguments(msg)) if msg.contains("max size"))
1487 );
1488 }
1489
1490 #[tokio::test]
1491 async fn edit_patch_rejects_excessive_block_count() {
1492 let file = tempfile::NamedTempFile::new().unwrap();
1493 tokio::fs::write(file.path(), "hello world").await.unwrap();
1494 let mut patch = String::new();
1495 for _ in 0..=MAX_PATCH_BLOCKS {
1496 patch.push_str("<<<<<<< SEARCH\nx\n=======\ny\n>>>>>>> REPLACE\n");
1497 }
1498
1499 let tool = EditTool::new();
1500 let result = run(
1501 &tool,
1502 json!({
1503 "file_path": file.path(),
1504 "patch": patch
1505 }),
1506 )
1507 .await;
1508
1509 assert!(
1510 matches!(result, Err(ToolError::InvalidArguments(msg)) if msg.contains("max block count"))
1511 );
1512 }
1513
1514 #[tokio::test]
1515 async fn edit_includes_json_diagnostics_after_change() {
1516 let file = tempfile::Builder::new().suffix(".json").tempfile().unwrap();
1517 tokio::fs::write(file.path(), r#"{"ok":true}"#)
1518 .await
1519 .unwrap();
1520
1521 let read_tool = ReadTool::new();
1522 let _ = read_tool
1523 .invoke(
1524 json!({ "file_path": file.path() }),
1525 ToolCtx {
1526 executing_supervisor: None,
1527 session_id: Some(std::sync::Arc::from("session_edit_diag")),
1528 tool_call_id: std::sync::Arc::from("call_1"),
1529 event_tx: None,
1530 available_tool_schemas: std::sync::Arc::from(Vec::new()),
1531 bypass_permissions: false,
1532 auto_approve_permissions: false,
1533 plan_read_only: false,
1534 can_async_resume: false,
1535 async_completion_sink: None,
1536 bash_completion_sink: None,
1537 },
1538 )
1539 .await
1540 .unwrap();
1541
1542 let tool = EditTool::new();
1543 let result = tool
1544 .invoke(
1545 json!({
1546 "file_path": file.path(),
1547 "old_string": r#"{"ok":true}"#,
1548 "new_string": "{"
1549 }),
1550 ToolCtx {
1551 executing_supervisor: None,
1552 session_id: Some(std::sync::Arc::from("session_edit_diag")),
1553 tool_call_id: std::sync::Arc::from("call_2"),
1554 event_tx: None,
1555 available_tool_schemas: std::sync::Arc::from(Vec::new()),
1556 bypass_permissions: false,
1557 auto_approve_permissions: false,
1558 plan_read_only: false,
1559 can_async_resume: false,
1560 async_completion_sink: None,
1561 bash_completion_sink: None,
1562 },
1563 )
1564 .await
1565 .unwrap();
1566 let ToolOutcome::Completed(result) = result else {
1567 panic!("expected Completed")
1568 };
1569
1570 assert!(result.success);
1571 let payload: serde_json::Value = serde_json::from_str(&result.result).unwrap();
1572 assert_eq!(payload["diagnostics"]["format"], "json");
1573 assert_eq!(payload["diagnostics"]["valid"], false);
1574 assert_eq!(payload["touched_lines"], 2);
1575 }
1576}