Skip to main content

znippy_plugin_git/
git_ops.rs

1//! **`GitOps` — ours, typed, and base znippy never sees it.**
2//!
3//! §13.2: `ArchiveTypePlugin` is base znippy's contract and
4//! [`crate::NativeGitPlugin`] implements it — base stores, the plugin annotates,
5//! exactly as maven, python, rust-toolchain and media already work. `GitOps` is
6//! the *other* trait: the one gunnar calls, with git's own vocabulary in it.
7//!
8//! §13.3: `ArchiveTypePlugin::run_command(cmd, args)` is **CLI-only string
9//! dispatch** and delegates here. A server's hot path does not go through
10//! stringly-typed dispatch, so nothing below takes a `&str` command or an
11//! `args: &[String]`.
12//!
13//! ```text
14//!   gunnar ──typed──► GitOps  (this file, twelve methods)
15//!                       │
16//!      ┌────────────────┼──────────────────┬─────────────┐
17//!      ▼                ▼                  ▼             ▼
18//!   ArchiveWrite    ObjectIndex          RefLog         Gc
19//!   SafeWriter      ObjectReadStack      push log       NewGeneration
20//!   (blob fsync,    (stree → Arrow       (Arrow IPC     (link, compact,
21//!    journal row)    → redb tail)         frame = tx)    verify, rename)
22//! ```
23//!
24//! Every arm under that diagram already existed and was already measured. This
25//! file adds no storage, no index and no durability mechanism of its own — if a
26//! method here looks like it is inventing one, that is a bug.
27//!
28//! # The one thing that is NOT here
29//!
30//! `run_command` still lives on the plugin in [`crate::lib`], and it now
31//! delegates. Nothing git-shaped went into base znippy for any of this.
32
33use std::collections::{BTreeMap, HashMap};
34use std::fs::File;
35use std::path::{Path, PathBuf};
36use std::sync::{Arc, Mutex, RwLock};
37
38use anyhow::{anyhow, bail, Context, Result};
39use znippy_common::ReservedSection;
40
41use crate::arms::StoreConfig;
42use crate::exploded::ExplodedStats;
43use crate::exploded_cache::ExplodedCache;
44use crate::gc::{Gc, GcReport};
45use crate::graph::{assign_generations, CommitNode};
46use crate::index_layout::{ObjectIndex, OneTableFourColumns};
47use crate::indexer::{IndexJob, ObjectAbsorb, PushPath};
48use crate::object::{GitHashKind, GitObjectKind};
49use crate::pack_walk::PackWalk;
50use crate::read_stack::{ObjectReadStack, RebuildTriggers};
51use crate::refs::{RefLog, RefUpdate};
52use crate::resolve::BaseSource;
53
54// ── the contract, now owned by `git-storage-trait` ────────────────────────────
55//
56// `GitOps` (the neutral ELEVEN) and its value types live in the
57// `git-storage-trait` crate at this repo's root, so a gix backend
58// (edda/storage-git-gix) can implement the same contract without linking Arrow
59// or OpenZL. The twelfth method, `seal()`, returns `znippy_common::
60// ReservedSection` (an Arrow type a gix backend has no analog for), so it is an
61// **inherent** method on [`GitStore`] / [`SelectedStore`], not part of the
62// trait. The re-exports below keep every existing path
63// (`znippy_plugin_git::git_ops::{GitOps, Oid, …}`) alive.
64pub use git_storage_trait::{Extent, GitOps, Oid, RefRow, Stored, TxId};
65
66
67// ── the batch shape, which is measured and must not be papered over ───────────
68
69/// Which path a lookup of `n` oids takes.
70///
71/// The number this dispatch was written for is `index_layout_bench`'s: on the bare
72/// Arrow arms, `lookup_batch` with a **single** element costs 818 ns against
73/// `lookup`'s 482 ns — 1.7x worse — because the batch path allocates a result
74/// vector, a key vector and a second pass over them to serve one oid.
75///
76/// **RE-MEASURED against the shipping read stack, and the magnitude does not
77/// carry over.** oden 2026-08-07, release, 1-min loadavg 4.94 (another tenant's
78/// work — see LAW: never measure on a busy box, and read these as a ratio rather
79/// than as absolutes), `ObjectReadStack<OneTableFourColumns>` over a real
80/// repository's 2687-object pack, 20 000 iterations
81/// ([`crate::store::tests::the_batch_of_one_really_is_slower_than_the_serial_path`]):
82///
83/// | call | per oid |
84/// |---|---:|
85/// | `lookup` | **628 ns** |
86/// | `lookup_batch` with 1 oid | **639 ns** — 1.02x worse |
87/// | `lookup_batch` with 100 oids | **161 ns** — 3.9x better |
88///
89/// So: the *direction* holds and the dispatch is right — a batch of one is never
90/// faster — but on this stack at this size it costs 2%, not 70%. The real finding
91/// is the third row: the batch path is worth **3.9x** at
92/// [`BATCH_SATURATES_AT`], which is a much stronger reason to keep the two paths
93/// apart than the batch-of-one penalty ever was. Both numbers are stated because
94/// quoting only the 1.7x would be quoting a figure this stack does not reproduce.
95///
96/// The dispatch is a named function with its own guard precisely so it cannot
97/// quietly become `lookup_batch` for every n.
98#[derive(Debug, Clone, Copy, PartialEq, Eq)]
99pub enum LookupPath {
100    /// One oid: `ObjectIndex::lookup`.
101    Serial,
102    /// Two or more: `ObjectIndex::lookup_batch`, one pass.
103    Batch,
104}
105
106/// Oids at which the batch path stops getting faster. Reported, not enforced:
107/// splitting a bigger batch would cost a pass and buy nothing.
108pub const BATCH_SATURATES_AT: usize = 100;
109
110/// The dispatch, in one place.
111pub fn lookup_path(n: usize) -> LookupPath {
112    if n == 1 {
113        LookupPath::Serial
114    } else {
115        LookupPath::Batch
116    }
117}
118
119// ── the store ─────────────────────────────────────────────────────────────────
120
121/// A pack whose bytes are durable but whose objects the index has not absorbed.
122///
123/// §13.12's `indexed` bit, in the form this store needs it: membership in
124/// [`PackState::pending`] *is* the bit being clear. A read that arrives while it
125/// is non-empty falls back to absorbing it — slower, never wrong.
126#[derive(Debug, Clone, Copy, PartialEq, Eq)]
127struct PendingPack {
128    pack_id: u64,
129    offset: u64,
130    len: u64,
131    /// The journal queued it on open (a restart), not a push in this process.
132    /// What makes the progress row say `resumed 0%` after a reboot.
133    resumed: bool,
134}
135
136impl PendingPack {
137    fn from_job(j: IndexJob) -> Self {
138        Self {
139            pack_id: j.pack_id,
140            offset: j.offset,
141            len: j.len,
142            resumed: false,
143        }
144    }
145}
146
147/// **§13.12's `indexed` bit — one bit per pack, indexed by pack ordinal.**
148///
149/// A plain bitset, and the two rejected alternatives say why:
150///
151/// * **not a hash set.** Pack ordinals are dense and small: they are assigned
152///   `0..N` within **one repository** (§13.14 scopes a negotiation, and therefore
153///   this store, to one repository — account-wide they would be sparse and the
154///   array would grow with the account's total packs). Dense means the bit is one
155///   shift and one AND with no hashing, and 10 000 packs is **1250 bytes** of
156///   `words`, which lives in L1.
157/// * **not a bloom filter.** A bloom's false positive would be *actively wrong*
158///   here: it would report a pack absorbed when it is not, the read path would
159///   stop falling back, and negotiation would be told `absent` about an object
160///   whose bytes are durable — which makes a client withhold objects and lose
161///   data. The bitset has no such mode. `1` means absorbed, `0` means fall back,
162///   and both are exact.
163///
164/// **The bit is never stored.** It is derived on open by diffing two facts that
165/// are already durable — the journal's extents against the index's rows — in
166/// [`Absorber::adopt_journal`]. There is nothing for a derived bit to drift from.
167///
168/// **Why the extents sit beside it.** A `0` bit is only actionable with the
169/// extent to absorb, so `extent[i]` carries it; `None` means "this store has not
170/// been told about ordinal `i`", which is not the same as "not absorbed" and must
171/// not be counted as work.
172///
173/// **Why `absorbed` is a separate fact from `extent`.** The ack path does two
174/// things in this order: record the pack pending, then hand its extent to the
175/// account's channel. The indexer's worker is a different thread and can reach
176/// `absorb` *before* the first of those returns. With only a pending list, that
177/// race ends in a bit that is set after the rows are already in and is never
178/// cleared, so every later read pays a pointless fallback for the life of the
179/// process. The bit is what the two writers agree on: [`PackState::note`] will
180/// not queue a pack that is already done, and `absorb` will not do the work
181/// twice.
182///
183/// Touched only under short critical sections — never across an absorb, which is
184/// what the separate [`Absorber::gate`] is for. **The ack path must never block
185/// behind index work.**
186#[derive(Default)]
187struct PackState {
188    /// One bit per pack ordinal, 64 to a word. `1` = its rows are in the index.
189    words: Vec<u64>,
190    /// The extent of each known ordinal, so a `0` bit can be acted on.
191    extent: Vec<Option<Extent>>,
192    /// Known ordinals whose bit is `0` — what [`GitStore::unindexed_packs`]
193    /// reports, kept as a count so the read path's check is a field load rather
194    /// than a scan.
195    unabsorbed: usize,
196}
197
198impl PackState {
199    /// The bit.
200    fn is_absorbed(&self, pack_id: u64) -> bool {
201        let i = pack_id as usize;
202        self.words
203            .get(i / 64)
204            .is_some_and(|w| w >> (i % 64) & 1 == 1)
205    }
206
207    /// Record a durable pack whose rows are not in yet. The bit **going clear**.
208    ///
209    /// **Idempotent, and the extent slot is the single thing that makes it so.**
210    /// A second `note` for an ordinal that already has one — the ack path
211    /// arriving after the drain has already absorbed the pack, or a re-queue on
212    /// open racing the same pack's push — finds the slot filled and counts no new
213    /// work. [`PackState::mark_absorbed`] fills that same slot, so a pack that is
214    /// already done cannot be queued behind its own completion, and there is no
215    /// second condition here that could disagree with the first.
216    fn note(&mut self, pack_id: u64, extent: Extent) {
217        let i = pack_id as usize;
218        self.grow_to(i);
219        if self.extent[i].is_none() {
220            self.extent[i] = Some(extent);
221            self.unabsorbed += 1;
222        }
223    }
224
225    /// Room for ordinal `i` in both arrays. Dense ordinals are what makes this a
226    /// `resize` and not an insert.
227    fn grow_to(&mut self, i: usize) {
228        if self.words.len() <= i / 64 {
229            self.words.resize(i / 64 + 1, 0);
230        }
231        if self.extent.len() <= i {
232            self.extent.resize(i + 1, None);
233        }
234    }
235
236    /// The bit **going up**: this pack's rows are in the index.
237    fn mark_absorbed(&mut self, pack_id: u64, extent: Extent) {
238        let i = pack_id as usize;
239        self.grow_to(i);
240        if self.words[i / 64] >> (i % 64) & 1 == 0 {
241            self.words[i / 64] |= 1 << (i % 64);
242            if self.extent[i].is_some() {
243                self.unabsorbed -= 1;
244            }
245        }
246        self.extent[i] = Some(extent);
247    }
248
249    /// Every known pack whose bit is clear, in ordinal order.
250    fn pending(&self) -> Vec<PendingPack> {
251        self.extent
252            .iter()
253            .enumerate()
254            .filter(|(i, e)| e.is_some() && !self.is_absorbed(*i as u64))
255            .map(|(i, e)| {
256                let (offset, len) = e.expect("filtered on Some");
257                PendingPack {
258                    pack_id: i as u64,
259                    offset,
260                    len,
261                    resumed: true,
262                }
263            })
264            .collect()
265    }
266}
267
268/// The derived tables: the commit graph, the tree payloads the reachability
269/// bitmaps are built from, and this store's own ordinal space.
270///
271/// **The ordinal space is this struct's, not the projection's.** An
272/// [`crate::index_layout::IndexRow::ordinal`] is a row address inside one
273/// projection generation and is re-derived by every rebuild, so a bitmap built
274/// over projection ordinals would silently address different objects after any
275/// rebuild. The bitmaps here are over `ordinal`, which is rebuilt in the same
276/// fold that rebuilds them — the two cannot drift because one call produces both.
277/// **Nothing in here is a source of truth.** Every field is folded from the
278/// `objects` table and §14's exploded table by [`Absorber::refold`], and both of
279/// those are on disk — which is what makes a clean reopen come back with the
280/// same graph it shut down with. Before the exploded table existed, `graph` and
281/// `trees` were *accumulated* here as packs were absorbed and stored nowhere, so
282/// a clean shutdown lost them silently: MEASURED on oden 2026-08-08, a reopened
283/// store over a fully absorbed 2687-object pack had all 2687 rows and **0 of 551
284/// commits**, with `reachable()` returning a commit alone instead of its closure
285/// and `gc` seeing an empty live set.
286#[derive(Default)]
287struct Derived {
288    /// Parents-before-children, generations assigned. Folded from the exploded
289    /// table's commit payloads at open, and **extended** after a push: the
290    /// previous rows plus the pushed commits, re-numbered by
291    /// [`crate::graph::assign_generations`]. The hex spelling is kept for the
292    /// sealed graph section and `graph_snapshot`; nothing that serves a request
293    /// reads it.
294    graph: Vec<CommitNode>,
295    /// [`Derived::graph`] in integers — rows, ordinals, parent rows — rebuilt
296    /// beside it at every fold with one hex decode per node, so no serving path
297    /// touches a hex string. Behind an `Arc` so a negotiation borrows it with a
298    /// refcount bump and a fold that lands mid-answer replaces the pointer, not
299    /// the rows under the reader.
300    ord_graph: Arc<crate::reach::OrdGraph>,
301    /// **The ordinal space, and it is append-only.**
302    ///
303    /// A sorted base laid down by the first fold, then every object a later
304    /// push brings in appended behind it ([`crate::reach::OrdinalTable`]). The
305    /// sorted space this replaced shifted every ordinal above the new oids on
306    /// every push, so every stored bitmap had to be rewritten bit by bit
307    /// (`carry_reach`: 512 entries × every object of the repository, after a
308    /// one-commit push — that is the 4 s of CPU GUN-PERF's Z-2 measured behind
309    /// a 3-object fetch on git.git). Here a push appends and the table stands.
310    ///
311    /// The space is re-sorted only when the appended part outgrows
312    /// [`ORDINAL_COMPACT_FRACTION`] of the base or the store seals, and then
313    /// through ONE remap table ([`crate::reach::OrdinalTable::remap_to`]) —
314    /// one lookup per object, one array index per bit.
315    ordinals: crate::reach::OrdinalTable,
316    /// The live reachability table over `ordinals`, or empty if nothing has
317    /// needed it yet. Behind an `Arc` (2026-08-14, a measurement, not a
318    /// tidy-up: the negotiation used to deep-copy every bitmap twice per
319    /// request). Survives every fold; see [`Absorber::refold`].
320    reach: Arc<crate::reach::ReachTable>,
321    /// row → entry index into [`Derived::reach`], rebuilt with `ord_graph` at
322    /// every fold so the pair can never be out of step.
323    reach_by_row: Arc<Vec<u32>>,
324    /// blake3 over the sorted oid list the last fold saw — the token the
325    /// persisted `objects.graph` is validated against.
326    token: [u8; 32],
327    /// Verbatim packs, so any absorbed object's content can be re-derived from
328    /// the truth on demand. `(archive offset, len)`.
329    packs: Vec<(u64, u64)>,
330}
331
332/// **The compaction rule**: a fold re-sorts the ordinal space when the appended
333/// part is larger than this fraction of the base (and than
334/// [`ORDINAL_COMPACT_MIN`] objects), renumbering the reachability table once
335/// through one remap table. Until then every push appends and touches no
336/// bitmap. A quarter keeps the appended index small (it is searched separately,
337/// through a sorted index) and the renumbering rare.
338pub(crate) const ORDINAL_COMPACT_FRACTION: usize = 4;
339/// The floor under the rule: a tiny repository is never compacted for a
340/// handful of objects.
341pub(crate) const ORDINAL_COMPACT_MIN: usize = 4096;
342/// **How often an extended table is written back.** The persisted table stays
343/// valid across pushes it does not know about — a load `follow`s the store's
344/// current oid list and extends for the commits it lacks — so writing it after
345/// every push would buy nothing but the write. A full build and a compaction
346/// always persist; an extension persists every this-many folds, and the drop
347/// of the store persists whatever is left.
348pub(crate) const REACH_PERSIST_EVERY: u64 = 16;
349/// The delta-chain memo a full reachability build reads its trees through
350/// ([`crate::resolve::ChainCache`]): bounded, FIFO by bytes, dropped with the
351/// build. 128 MiB holds the last few thousand materialised trees of a packed
352/// repository, which is where the next chain's base is.
353pub(crate) const REACH_BUILD_CHAIN_CACHE_BYTES: usize = 128 << 20;
354/// …and no more than this per object the store holds (floor 8 MiB), so a
355/// small repository's build does not reserve a large repository's memo.
356pub(crate) const REACH_BUILD_CHAIN_CACHE_PER_OBJECT: usize = 512;
357
358/// **The object-level index, and the one thing that writes into it.**
359///
360/// Its own allocation rather than a field group inside [`GitStore`], and §13.9-12
361/// is the only reason: the drain runs on the account indexer's worker thread, so
362/// whatever it absorbs into cannot be reachable solely through a `&GitStore`.
363/// Splitting it out is what lets the background worker and a falling-back read
364/// call **the same** absorb instead of two copies of it (LAW 5) — the alternative
365/// was a second implementation on the worker side, which is precisely the
366/// twinning that law forbids.
367///
368/// It is a **leaf**: nothing in here points back at the store, so the worker's
369/// `Arc` closes no cycle and the store still drops (and joins its worker)
370/// normally.
371/// Entries below which [`GitStore::resolve_emit_payloads`] does **not** fan out.
372///
373/// A `std::thread::scope` spawn is ~10–20 µs a worker and the per-entry work it
374/// would divide is a bounds check plus a varint; a 100-object fetch would pay
375/// four spawns to save four microseconds of parsing. The threshold is what keeps
376/// `crate::serve`'s "one core's worth per transfer" true for every request that
377/// is not a bulk clone — and a bulk clone is the only request the copy this
378/// replaces was ever measured on.
379const FAN_OUT_AT: usize = 4096;
380
381/// The folded commit graph, cached beside the verbatim pack so a reopen *reads*
382/// it instead of re-deriving it from every commit payload (S-065).
383const GRAPH_CACHE_FILE: &str = "objects.graph";
384/// `objects.graph` framing: 4-byte magic + 1-byte version + 32-byte token, then
385/// the Arrow IPC commit graph.
386const GRAPH_CACHE_MAGIC: &[u8; 4] = b"GRPH";
387const GRAPH_CACHE_HEADER: usize = 4 + 1 + 32;
388
389/// The live reachability table and its ordinal space, cached beside the
390/// verbatim pack so a reopen *reads* them instead of walking every tree again
391/// (GUN-PERF Z-1: 85 to 150 s on git.git after every start). See
392/// [`Absorber::load_persisted_reach`] for the frame.
393const REACH_CACHE_FILE: &str = "objects.reach";
394const REACH_CACHE_MAGIC: &[u8; 4] = b"RECH";
395/// magic (4) + version (1) + oid_len (u32) + base bytes (u64) + extra bytes (u64).
396const REACH_CACHE_HEADER: usize = 4 + 1 + 4 + 8 + 8;
397
398/// **`objects.ordinal` is no longer written, and an existing one is removed at
399/// open.** It was S-082's memo of the ordinal space — every oid in sorted order,
400/// with a `(epoch, count)` header validated against the redb tail — so that a
401/// cold open could *read* the space instead of scanning the whole redb tail to
402/// rebuild it. Since 2026-09-04 the read stack persists its projection
403/// (`objects.index`) and the sorted oid list IS that index's oid column, mapped;
404/// [`ObjectReadStack::oids_raw`] hands it back with a merge of the few redb rows
405/// since the last fold. The scan the memo spared no longer exists, and a second
406/// file carrying the same bytes under a bespoke header is exactly the kind of
407/// file this store should not have. On the kernel mirror it was 278 964 902 B —
408/// 20.0 B/object, the oid column to the byte. The name is kept only so the
409/// stale file can be found and deleted.
410const ORDINAL_CACHE_FILE: &str = "objects.ordinal";
411
412/// The validity token for a persisted commit graph: blake3 over the sorted raw
413/// oids of **every** object in the store.
414///
415/// It is both necessary and sufficient. The graph is a pure, deterministic
416/// function of the commit payloads, which are content-addressed by their oids,
417/// so an identical object set yields a byte-identical graph — and this hashes
418/// the whole object set, in the one order `refold` already sorts it into, with
419/// no read the fold did not already make. A mismatch (any push, any gc) forces a
420/// recompute; a 256-bit blake3 makes an accidental match of two different object
421/// sets not a case worth engineering against.
422/// **`seen − live`: what a GC may drop.** `seen` is every oid the index held
423/// when the GC started (`oids_in_order`), `live` the reachable set computed
424/// after it. The difference is the dead set, and it is a POSITIVE set on
425/// purpose: `retain(|o| live.contains(o))` would also drop every row that
426/// arrived between the snapshot and the drop — a push in flight, whose refs
427/// are not updated yet — because to `live` those are simply unknown. A row in
428/// neither set is kept. `live` is hex, `seen` raw; the decode happens once
429/// here rather than once per row in the retain predicate.
430pub(crate) fn dead_oids(
431    seen: Vec<Vec<u8>>,
432    live: &std::collections::HashSet<String>,
433) -> std::collections::HashSet<Vec<u8>> {
434    let live_raw: std::collections::HashSet<Vec<u8>> =
435        live.iter().filter_map(|h| hex::decode(h).ok()).collect();
436    seen.into_iter().filter(|o| !live_raw.contains(o)).collect()
437}
438
439fn graph_token(oids_raw: &[u8]) -> [u8; 32] {
440    let mut h = znippy_common::blake3::Hasher::new();
441    h.update(oids_raw);
442    *h.finalize().as_bytes()
443}
444
445/// Commits that get a reachability bitmap on the **live** selection path.
446///
447/// # It was `usize::MAX`, and that was the single most expensive line in a fetch
448///
449/// The comment that stood here said a sampled table *"is for the sealed archive
450/// where the cost is disk"* and that every commit must be bitmapped on the live
451/// path. That was not a preference, it was forced:
452/// [`GitStore::reachable_oids`] had no walk, so a `want` with no bitmap could
453/// only contribute itself — a silent under-send — and `crate::serve`'s `select`
454/// therefore had to refuse unless *"in the graph"* and *"has a bitmap"* were the
455/// same fact.
456///
457/// MEASURED on oden 2026-08-14, one 4-object negotiated fetch out of the
458/// znippy-served `nornir` mirror (1 581 commits, 12 455 objects): the
459/// `select.bitmap` stage was **75 % of the request's CPU**, and **530 218 of its
460/// 575 349 allocations were this build** — which `refold` throws away again on
461/// the next push. The gix arm answered the identical fetch in 6.8 ms because it
462/// *reads* a `.bitmap` instead of building one.
463///
464/// [`crate::reach::accumulate`] is the walk that makes the cap legal, and 512 is
465/// the number [`crate::reach::ReachPolicy::default`] already uses for the sealed
466/// archive — the same figure git's own bitmap selection is of the order of, and
467/// deliberately not a second, different constant to keep in step.
468const LIVE_REACH_COMMITS: usize = 512;
469
470/// [`LIVE_REACH_COMMITS`], or `ZNIPPY_GIT_REACH_COMMITS`.
471///
472/// **An operator knob, not an arm.** It selects no implementation and changes no
473/// byte of any answer: the walk covers whatever the table does not, so the cap
474/// trades build cost against walk cost and nothing else. That property is the
475/// whole subject of
476/// `the_bounded_walk_answers_exactly_what_a_full_bitmap_table_answers`, which
477/// drives this very knob to its two extremes over one store.
478///
479/// Read **once per process** through [`crate::arms::read_env`], so it is
480/// counted with every other environment read this crate makes, and so a
481/// reachability request does not cost a `getenv` — until 2026-08-21 it did,
482/// once per `reach_bitmaps`/`reachable_oids` call, uncounted.
483pub(crate) fn live_reach_policy() -> crate::reach::ReachPolicy {
484    static MAX: std::sync::OnceLock<usize> = std::sync::OnceLock::new();
485    let max_commits = *MAX.get_or_init(|| {
486        crate::arms::read_env(crate::arms::ENV_REACH_COMMITS)
487            .and_then(|v| v.parse::<usize>().ok())
488            .unwrap_or(LIVE_REACH_COMMITS)
489    });
490    crate::reach::ReachPolicy { max_commits }
491}
492
493/// Ceiling on phase-1 workers **per request**.
494///
495/// The serving tier admits ~32 concurrent transfers, and the fan-out primitive
496/// has no reentrancy detection, so an uncapped `gatling_for_each` here is
497/// 32 × ncores threads on a 128-core box. Four is a bound that leaves the
498/// admission gate in charge of the machine.
499const MAX_RESOLVE_WORKERS: usize = 4;
500
501/// Workers for phase 1: [`MAX_RESOLVE_WORKERS`], or `ZNIPPY_GIT_EMIT_WORKERS`.
502///
503/// **An operator knob, not an arm.** It selects no implementation and changes no
504/// byte of the emitted pack — a pack emitted at one worker and at sixteen is
505/// byte-identical, because phase 1 only decides *where each entry's bytes are*
506/// and phase 2 writes them in one serial order either way. `0` is read as "as
507/// many as this box has cores", which is `gatling_for_each`'s own convention.
508///
509/// Read **once per process** through [`crate::arms::read_env`] — see
510/// [`live_reach_policy`] for why; this one was a `getenv` per emitted request
511/// until 2026-08-21.
512fn emit_workers() -> usize {
513    static WORKERS: std::sync::OnceLock<usize> = std::sync::OnceLock::new();
514    *WORKERS.get_or_init(|| {
515        crate::arms::read_env(crate::arms::ENV_EMIT_WORKERS)
516            .and_then(|v| v.parse::<usize>().ok())
517            .unwrap_or(MAX_RESOLVE_WORKERS)
518    })
519}
520
521pub(crate) struct Absorber<S: ObjectIndex = OneTableFourColumns> {
522    blobs: PathBuf,
523    /// Read handle on the verbatim packs, for `pread` of an extent.
524    ///
525    /// The **fallback**, since 2026-08-14, not the ordinary path: `map` below
526    /// answers every extent the mapping covers, and this reads the ones past its
527    /// end (a push that landed after the snapshot was taken).
528    ///
529    /// **It is the writer's own open file description** (2026-08-30, lane AH),
530    /// not a second `File::open`: this reads with `pread` at an explicit offset
531    /// and shares no cursor with `append`, so a private descriptor bought a
532    /// kernel object and a page-cache alias per open repository and no
533    /// isolation. See [`crate::archive_write::open_blobs`] and
534    /// `tests/fd_per_store.rs`.
535    reader: Arc<File>,
536    /// The same file, mapped read-only. See [`crate::archive_map`] for why an
537    /// append-only file `gc` never rewrites is safe to map, and for the ~20 % of
538    /// serve cycles the `pread`-per-object shape was spending on copies.
539    map: crate::archive_map::ArchiveMap,
540    hash: GitHashKind,
541    /// The `objects` table: stree → Arrow → redb tail.
542    ///
543    /// `S` is the payload layout the projection is built in
544    /// ([`crate::arms::IndexArm`]) and it is a **type parameter, not a field**:
545    /// this is the hot path, every lookup goes through it, and the whole reason
546    /// the arms exist is to measure the differences between them. A `dyn` here
547    /// would put a virtual call on every single oid.
548    objects: ObjectReadStack<S>,
549    /// **§14's exploded objects table** — oid → resolved type and content, built
550    /// eagerly by this absorb and by nothing else.
551    ///
552    /// Beside the `objects` table rather than inside it because the two have
553    /// different lifetimes: `objects` is the index and losing it loses the
554    /// repository's addressing, while this one is derived, verifiable against the
555    /// verbatim bytes and deletable at any time. They are separate files so that
556    /// "droppable" is a `rm`, not a schema migration.
557    ///
558    /// SWAPPED 2026-08-13 from the redb `ExplodedTable` to **one Arrow IPC
559    /// table**, payload in the row. redb held 16.8 GB of kernel payload in a
560    /// 204 GB file — 12× — and serialised the gatling fan-out behind its one
561    /// writer at 96.8% of a single core. See [`crate::exploded_arrow`].
562    ///
563    /// **BUDGETED AND EVICTABLE since lane Q (2026-08-30)**: the two-pool
564    /// [`ExplodedCache`] — the indexer's eager pool (commits and tags) beside a
565    /// lazy pool the FIRST reader of a blob or tree fills and a byte budget
566    /// empties. The unbounded eager tier it replaces MEASURED **141.7 GiB** for
567    /// the 8.12 GiB `torvalds/linux` pack on the rig, 17× the pack, which is
568    /// more than one appliance holds for all its repositories together.
569    exploded: Arc<ExplodedCache>,
570    derived: RwLock<Derived>,
571    /// How many folds since open read the persisted commit graph off disk vs
572    /// recomputed it from the exploded table. Counters, not clocks — the only
573    /// thing that can say which path a fold took (LAW 2). See
574    /// [`Absorber::graph_source_stats`].
575    graph_read: std::sync::atomic::AtomicU64,
576    graph_recomputed: std::sync::atomic::AtomicU64,
577    /// **Is `objects.graph` read and written at all** ([`crate::arms::ENV_GRAPH_CACHE`],
578    /// read once at open). `false` folds from the exploded table every time and
579    /// leaves no file: a store that serves no reads holds no derived memo.
580    graph_cache: std::sync::atomic::AtomicBool,
581    /// How many folds CARRIED the reachability table across (renumbered, no
582    /// tree opened) vs how many reads had to build it from scratch. The only
583    /// witness that the carry ran — the bytes a carried and a rebuilt table
584    /// answer with are identical by construction (LAW 2). See
585    /// [`Absorber::reach_source_stats`].
586    reach_carried: std::sync::atomic::AtomicU64,
587    reach_rebuilt: std::sync::atomic::AtomicU64,
588    /// How many folds READ the persisted table (`objects.reach`), how many
589    /// EXTENDED it for pushed commits, and how many extensions are not written
590    /// back yet. See [`Absorber::reach_stats`].
591    reach_loaded: std::sync::atomic::AtomicU64,
592    reach_extended: std::sync::atomic::AtomicU64,
593    reach_unpersisted: std::sync::atomic::AtomicU64,
594    /// Where the last fold's **ordinal space** came from: how many oids straight
595    /// off the persisted index's column, how many off a scan of the redb tail.
596    /// The same shape as [`Self::graph_read`]/[`Self::graph_recomputed`], and for
597    /// the same reason: which source produced the space is not visible in the
598    /// (identical) bytes, only in a counter (LAW 2). See
599    /// [`Absorber::ordinal_source_stats`].
600    ordinal_folded: std::sync::atomic::AtomicU64,
601    ordinal_tail: std::sync::atomic::AtomicU64,
602    packs: Mutex<PackState>,
603    /// Serialises **absorption**, which is long. Held across a whole pack.
604    ///
605    /// Two absorbs of one pack are duplicated *work* and nothing worse: every
606    /// writer under it is keyed by oid — [`ObjectReadStack::append`] swallows an
607    /// identical second row, the exploded table overwrites its own key, and the
608    /// commit graph is folded from that table rather than pushed at, so it cannot
609    /// double. (It could before §14's table existed, when the graph was a `Vec`
610    /// accumulated per absorb; that is why this paragraph used to say the gate
611    /// was load-bearing for correctness and now does not.) The gate is still what
612    /// makes the ordering below hold: **the rows go in, and only then is the bit
613    /// cleared**, so a read either finds the bit still clear (and waits here) or
614    /// finds the rows. Neither order can produce "absent".
615    gate: Mutex<()>,
616    /// **The progress counter** ([`crate::progress`]) a dashboard or a stats
617    /// call reads. One per store, registered process-wide.
618    progress: Arc<crate::progress::IndexProgress>,
619    /// Set by [`GitStore::cancel_index`]: the repository is being deleted. The
620    /// resolver checks it every few thousand objects and aborts the pack; the
621    /// drain skips every pack still queued.
622    cancel: std::sync::atomic::AtomicBool,
623    /// Names the store in log lines: its root directory.
624    label: String,
625    /// The memory watchdog this store's worker pauses on. The process-wide one
626    /// unless a test hands in a fake ([`GitStore::set_mem_watchdog`]).
627    watchdog: RwLock<Arc<crate::memguard::MemWatchdog>>,
628    /// **Pending packs a reader has already scanned**, keyed by pack offset:
629    /// the walk and an oid-sorted row table, built by ONE read-only pass and
630    /// kept until the pack is absorbed. Every later lookup into that pack is
631    /// a binary search; a content read inflates one chain. Without this,
632    /// every `has` during the index window re-resolved the whole pack —
633    /// MEASURED on the rig 2026-08-30: a `push --mirror` of linux stalled
634    /// pre-ack, ~800 ref updates × one 8 GiB resolve each.
635    scanned: Mutex<HashMap<u64, Arc<ScannedPack>>>,
636    /// One scan build at a time: a second reader waits for the first reader's
637    /// pass rather than starting its own. That is waiting on a *reader*, not
638    /// on the indexer.
639    scan_build: Mutex<()>,
640    /// **Packs this store has stopped trying to index**, by ordinal, with how
641    /// many attempts it took to stop and the reason the last one gave.
642    ///
643    /// 🔴 The state this replaces was *no state*. A pack whose absorb failed
644    /// stayed pending, every absorb loop hit it FIRST (they run in ordinal
645    /// order) and aborted on it with `?`, so the packs behind it were never
646    /// reached — and the next push, and the one after that, re-did the same
647    /// doomed resolve and was refused for it. MEASURED on oden 2026-08-30
648    /// (lane AI): one pack that could not be absorbed refused **every** push to
649    /// that repository from then on, 21 of 140, and lane AD's standby re-asked
650    /// for it every 300 s for 21 minutes. Work that cannot succeed has to stop
651    /// and say why; see [`MAX_ABSORB_ATTEMPTS`] and [`Absorber::absorb_each`].
652    unindexable: Mutex<HashMap<u64, Unindexable>>,
653}
654
655/// A pack this store will not try to index again, and why.
656#[derive(Debug, Clone)]
657pub struct Unindexable {
658    /// The pack's ordinal.
659    pub pack_id: u64,
660    /// Its extent in the verbatim archive. The bytes are still there.
661    pub extent: Extent,
662    /// How many absorbs were spent before it stopped.
663    pub attempts: u32,
664    /// The last attempt's root cause — the backend's own sentence, which is
665    /// what a client and an operator both get told.
666    pub reason: String,
667}
668
669/// How many times one pack's absorb is attempted before the store stops.
670///
671/// Three, and the reason it is not one: an absorb can fail for a reason outside
672/// the pack — the memory watchdog gave up, the repository was being deleted, a
673/// transient read error — and a single bad moment must not condemn durable
674/// bytes. It is not thirty either, because the resolve is deterministic in the
675/// store's own state: a pack that failed three times with nothing else changing
676/// fails the fourth time for the same reason, and every one of those attempts
677/// is paid for by a client waiting on a push.
678pub const MAX_ABSORB_ATTEMPTS: u32 = 3;
679
680// **The pack this thread is inside an absorb of**, if any.
681//
682// `absorb_gated` holds `Absorber::gate` for the whole pack, and the resolver it
683// runs asks this very store for delta bases through `BaseSource::content`. That
684// re-entry must not take the gate again — a `std::sync::Mutex` is not
685// reentrant, so it would not be a wait, it would be a deadlock — and it must
686// not treat the pack it is halfway through as something it can absorb. One
687// `Cell` answers both questions, and it is the same guard shape
688// `scan_pending`'s `SCANNING` uses for the same reason.
689thread_local! {
690    static IN_ABSORB: std::cell::Cell<Option<u64>> = const { std::cell::Cell::new(None) };
691}
692
693/// Sets [`IN_ABSORB`] for the duration of one absorb and restores whatever was
694/// there before — absorbs nest (a pack whose base is in another pending pack).
695struct InAbsorb(Option<u64>);
696
697impl InAbsorb {
698    fn enter(pack_id: u64) -> Self {
699        InAbsorb(IN_ABSORB.with(|c| c.replace(Some(pack_id))))
700    }
701}
702
703impl Drop for InAbsorb {
704    fn drop(&mut self) {
705        IN_ABSORB.with(|c| c.set(self.0));
706    }
707}
708
709/// One pending pack, scanned read-only: what a lookup needs and nothing that
710/// the index will hold. O(objects) memory — for linux ~56 B of walk + 32 B of
711/// row per object, ~1.2 GB — and gone when the pack's bit goes up.
712///
713/// **Nothing on the production read path builds one of these any more.** A
714/// reader that needs an un-indexed pack indexes it instead
715/// ([`Absorber::index_pending_now`]); this remains for the one caller that
716/// cannot — a resolver already inside `absorb_gated`, which may consult a scan
717/// somebody else already built but must never start one.
718struct ScannedPack {
719    walk: crate::pack_walk::PackWalk,
720    /// `(oid, entry index, resolved size)`, sorted by oid.
721    rows: Vec<(Vec<u8>, u32, u64)>,
722    archive_offset: u64,
723}
724
725impl ScannedPack {
726    fn find(&self, oid: &[u8]) -> Option<(usize, u64)> {
727        self.rows
728            .binary_search_by(|(o, _, _)| o.as_slice().cmp(oid))
729            .ok()
730            .map(|i| (self.rows[i].1 as usize, self.rows[i].2))
731    }
732
733    fn row(&self, oid: &[u8]) -> Option<crate::index_layout::IndexRow> {
734        let (entry, size) = self.find(oid)?;
735        let e = &self.walk.entries[entry];
736        Some(crate::index_layout::IndexRow {
737            // Not ranked: the row is not in the index yet.
738            ordinal: u32::MAX,
739            offset: e.offset + self.archive_offset,
740            len: e.len,
741            obj_type: e.obj_type,
742            uncompressed_size: size,
743            delta_base: match &e.delta_base {
744                crate::pack_walk::DeltaBase::Offset(o) => o + self.archive_offset,
745                _ => 0,
746            },
747        })
748    }
749}
750
751/// One repository's git store.
752///
753/// | on disk | what it is | who owns the format |
754/// |---|---|---|
755/// | `<root>/objects.pack` | the verbatim pack bytes, appended | [`SafeWriter`] |
756/// | `<root>/objects.pack.journal` | the durable extent rows | [`SafeWriter`] |
757/// | `<root>/objects.tail` | the un-sealed index tail | [`ObjectReadStack`] (redb) |
758/// | `<root>/objects.exploded` | §14's resolved content, **droppable** | [`ExplodedArchive`] (one Arrow IPC table) |
759/// | `<root>/refs.log` | the ref transaction log | [`RefLog`] (Arrow IPC frames) |
760/// | `<root>/<name>.znippy` | the sealed archive GC compacts | base znippy |
761///
762/// Nothing in that table is new. The store is the composition, not a fifth
763/// format.
764/// # Which implementation of each trait, and how a caller picks
765///
766/// Three of the four boxes in the diagram at the top of this file have more than
767/// one implementation. [`StoreConfig`] is the choice, [`crate::arms`] documents
768/// what each arm promises, and the dispatch is split deliberately:
769///
770/// | trait | selected by | dispatch | cost |
771/// |---|---|---|---|
772/// | [`ObjectIndex`] | the type parameter `S` | **static** | none — the hot path is monomorphised |
773/// | [`ArchiveWrite`](crate::archive_write::ArchiveWrite) | [`StoreConfig::writer`] | `dyn`, inside [`PushPath`] as it already was | one virtual call **per pack append**, not per object |
774/// | [`Gc`] | [`StoreConfig::gc`] | `dyn` | one virtual call per `gc()` run |
775///
776/// `S` defaults to [`OneTableFourColumns`], so `GitStore` still names exactly
777/// what it named before and every existing caller compiles unchanged.
778pub struct GitStore<S: ObjectIndex = OneTableFourColumns> {
779    root: PathBuf,
780    /// The verbatim pack bytes. The **truth** (§14).
781    blobs: PathBuf,
782    /// The sealed znippy archive `gc` compacts. Only GC and `seal` touch it.
783    archive: PathBuf,
784    /// The selected [`ArchiveWrite`](crate::archive_write::ArchiveWrite) arm
785    /// plus the per-account index channel. The ack path.
786    push: PushPath,
787    account: String,
788    hash: GitHashKind,
789    /// The object-level index and the absorb behind it — **shared with the
790    /// account indexer's worker**, which is how a push ends in object rows
791    /// without a read having to ask for them.
792    absorber: Arc<Absorber<S>>,
793    refs: RefLog,
794    /// Serialises the ref log's read-compare-append. A CAS that read the
795    /// namespace, then appended, without holding this could be overtaken between
796    /// the two and would overwrite the update it did not see.
797    ref_gate: Mutex<()>,
798    /// The selected [`Gc`] arm. Built once, here, and run by
799    /// [`GitOps::gc`] — a `Box<dyn>` because a GC is a whole-archive
800    /// compaction that happens on a maintenance timer, so one virtual call
801    /// against it is unmeasurable and a third type parameter on every signature
802    /// in the crate is not free to read.
803    gc: Box<dyn Gc + Send + Sync>,
804    /// What this store was built with, for a bench row or a config dump. A
805    /// description of the arms already constructed — **nothing consults it on a
806    /// serving path**.
807    arms: StoreConfig,
808}
809
810impl GitStore<OneTableFourColumns> {
811    /// Open (creating) the store for one repository under `root`.
812    ///
813    /// **The default arms, and it reads no environment to get them.** An
814    /// operator who exported `ZNIPPY_GIT_WRITER=fast` does not change what this
815    /// builds — a caller that never asked for a selector must not have its
816    /// durability contract moved out from under it. Use
817    /// [`open_from_env`] when the selection is wanted.
818    ///
819    /// ⚠ One variable *is* read here, and it is not an arm:
820    /// `ZNIPPY_GIT_REDB_CACHE_BYTES` (see
821    /// [`crate::arms::redb_cache_bytes`]). It selects no implementation,
822    /// changes no durability contract and leaves the bytes on disk identical —
823    /// it caps redb's page cache, whose own default is 1 GiB *per database*, of
824    /// which this store opens two. The sentence above is about arms, and a
825    /// memory ceiling is not one.
826    pub fn open(root: &Path, account: &str) -> Result<Self> {
827        Self::open_with(root, account, GitHashKind::Sha1)
828    }
829
830    /// Same, with an explicit oid width. sha256 repositories exist and the store
831    /// does not get to assume otherwise; every oid it stores is
832    /// [`GitHashKind::oid_len`] bytes wide and the tail refuses a mixed batch.
833    ///
834    /// # What a reopen recovers, and why nothing had to be stored for it
835    ///
836    /// A store opened over an `objects.pack` some earlier process was still
837    /// indexing has to end up in the same state that process would have reached.
838    /// §13.12's `indexed` bit is what says so, and it is **derived here rather
839    /// than persisted**: a pack is unabsorbed *iff* its extent is in the journal
840    /// and its rows are not in the index, and both of those are already durable
841    /// (see [`Absorber::adopt_journal`]). The packs that come back clear are put
842    /// straight onto the account's channel, so the drain finishes the interrupted
843    /// work with no read having to ask — and until it does, every read falls back
844    /// exactly as it would have before the crash. **Slower, never wrong**, across
845    /// a restart as well as within one.
846    ///
847    /// The bits are set **before** the channel is fed, which is the same ordering
848    /// the ack path uses for the same reason: a read that arrives in between finds
849    /// the bit clear and waits, never an index that does not mention the pack.
850    ///
851    /// # What a reopen recovers of the DERIVED tables, and how that was fixed
852    ///
853    /// [`Derived::graph`] and [`Derived::trees`] come back **in full**, for every
854    /// pack, whether or not anything is re-queued. They are folded from §14's
855    /// exploded table ([`Absorber::refold`]), which is on disk, so a clean
856    /// shutdown carries them across.
857    ///
858    /// This was a live correctness hole until 2026-08-08 and it is recorded
859    /// rather than quietly repaired. The graph was *accumulated in RAM* as packs
860    /// were absorbed and stored nowhere; a store killed mid-absorb got it back
861    /// because the interrupted pack was re-queued and re-resolved, but a store
862    /// that shut down **cleanly** re-queued nothing and came back with an empty
863    /// graph. MEASURED on oden 2026-08-08: 2687 rows and **0 of 551 commits**,
864    /// `reachable` on a commit returning that commit alone instead of its
865    /// closure — a *quiet* wrong answer — and `gc` seeing an empty live set. The
866    /// fix is the table, because the payloads the graph is folded from had no
867    /// home; [`tests::a_clean_shutdown_and_reopen_keeps_the_graph_and_reachable`]
868    /// is what proves it, over a real process that exits normally.
869    ///
870    /// The exploded table is still **droppable**: if its row count is short of
871    /// the `objects` table's, [`Absorber::adopt_journal`] declares no pack
872    /// absorbed and every one of them is re-queued and re-exploded. Absent means
873    /// rebuild, never wrong (§13.12, applied unchanged to a derived table).
874    ///
875    /// **Also the default arms, and also no environment read** — see
876    /// [`open`](GitStore::open).
877    pub fn open_with(root: &Path, account: &str, hash: GitHashKind) -> Result<Self> {
878        // The default ARMS, and the environment's CEILING: the one variable
879        // this constructor reads, because an operator capping a server's
880        // footprint must not have to pick a different constructor to do it.
881        // See [`crate::arms::redb_cache_bytes`].
882        Self::open_with_arms(
883            root,
884            account,
885            hash,
886            StoreConfig::DEFAULT.with_redb_cache_bytes(crate::arms::redb_cache_bytes()?),
887        )
888    }
889}
890
891/// Where a stored entry's delta base sits, relative to the request being served.
892///
893/// The `Outside` arm carries the base in **both** namings because the two delta
894/// forms know only one each — an `OFS_DELTA` its archive offset, a `REF_DELTA`
895/// its oid — and [`GitStore::emit_set`]'s thin arm has to ask "does the client
896/// hold this" in whichever one the entry speaks.
897enum BaseOf {
898    /// Not a delta at all. There is nothing to place it after and nothing to
899    /// re-head; the stored entry is copied as it stands.
900    Whole,
901    /// A delta whose base **is** in the request, at this archive offset.
902    ///
903    /// The offset is carried rather than recomputed because a `REF_DELTA` does
904    /// not know it — it names its base by oid, and its own `delta_base` column
905    /// is `0` by construction — and the emitter needs it twice: as the
906    /// `EmitEntry::delta_base` that [`crate::pack_walk::topological_order`]
907    /// orders on, and as the base an in-pack ref-delta is re-headed to point at.
908    Inside { at: u64 },
909    /// A delta whose base the request does not carry.
910    Outside {
911        /// The base's archive offset, `0` when the entry named an oid instead.
912        offset: u64,
913        /// The base's oid, `None` when the entry named an offset instead — or
914        /// when the entry is too short to read one out of.
915        oid: Option<Vec<u8>>,
916    },
917}
918
919/// The bases a **thin** pack may name without carrying them: what the receiver
920/// already held before this transfer, keyed both ways.
921///
922/// Built by [`GitStore::client_bases`], which is where the argument for trusting
923/// it is written down.
924struct ExternalBases {
925    /// The held object's oid, keyed by its archive offset — the coordinate an
926    /// `OFS_DELTA` names its base in, and the only reason this map exists.
927    by_offset: HashMap<u64, OidKey>,
928    /// The same objects keyed the way a `REF_DELTA` names them.
929    held: std::collections::HashSet<OidKey>,
930}
931
932/// **A raw oid as a fixed-size, `Copy` hash key — 20 bytes for SHA-1, 32 for
933/// SHA-256, and no heap allocation either way.**
934///
935/// The two maps in [`ExternalBases`] are repository-sized: the client's `have`
936/// closure on an incremental fetch is very nearly every object in the store.
937/// Keying them by `Vec<u8>` is one heap allocation per entry per request —
938/// 12 112 of them for a 69-object fetch, measured on oden 2026-08-15 — for a
939/// question (*does the client hold this base?*) that never looks at more than
940/// `oid_len` bytes.
941///
942/// Padded to the widest hash rather than parameterised by width: a store holds
943/// exactly one hash kind, so every key in one set has the same real length and
944/// two different oids can never collide through the padding. The length is
945/// carried anyway, because a key that silently compared equal across widths is
946/// the kind of wrong that only shows up in a mixed-hash mirror.
947#[derive(Debug, Clone, Copy, PartialEq, Eq, Hash)]
948struct OidKey {
949    bytes: [u8; 32],
950    len: u8,
951}
952
953impl OidKey {
954    /// The key for `oid`, or a refusal for one wider than any git hash.
955    fn new(oid: &[u8]) -> Result<Self> {
956        let len = oid.len();
957        if len == 0 || len > 32 {
958            bail!("{len} is not the width of any git object id (1..=32 bytes)");
959        }
960        let mut bytes = [0u8; 32];
961        bytes[..len].copy_from_slice(oid);
962        Ok(OidKey {
963            bytes,
964            len: len as u8,
965        })
966    }
967
968    /// The oid back, at its real width.
969    fn as_slice(&self) -> &[u8] {
970        &self.bytes[..self.len as usize]
971    }
972}
973
974impl<S: ObjectIndex + 'static> GitStore<S> {
975    /// **The one constructor**, with every arm named.
976    ///
977    /// `S` picks the [`ObjectIndex`] layout at compile time; `arms` picks the
978    /// [`ArchiveWrite`](crate::archive_write::ArchiveWrite) and [`Gc`]
979    /// implementations at run time. [`open`](GitStore::open) and
980    /// [`open_with`](GitStore::open_with) are this function with
981    /// [`StoreConfig::DEFAULT`], which is why nothing about them moved.
982    ///
983    /// `arms.index` is **not** consulted here — `S` is the index arm, and a
984    /// value that disagreed with the type would be a second source of truth.
985    /// [`open_from_env`] is the one place the two are tied together, and it does
986    /// it by choosing `S` from the value.
987    ///
988    /// ```no_run
989    /// use znippy_plugin_git::arms::{GcArm, StoreConfig, WriterArm};
990    /// use znippy_plugin_git::index_layout::PackedPayload;
991    /// use znippy_plugin_git::{GitHashKind, GitStore};
992    ///
993    /// // A rebuildable import mirror: the ceiling writer, the packed payload
994    /// // layout, and an in-place compaction.
995    /// let arms = StoreConfig::DEFAULT
996    ///     .with_writer(WriterArm::Fast)
997    ///     .with_gc(GcArm::CompactInPlace);
998    /// let store = GitStore::<PackedPayload>::open_with_arms(
999    ///     std::path::Path::new("/srv/repo"),
1000    ///     "alice",
1001    ///     GitHashKind::Sha1,
1002    ///     arms,
1003    /// )?;
1004    /// # Ok::<(), anyhow::Error>(())
1005    /// ```
1006    pub fn open_with_arms(
1007        root: &Path,
1008        account: &str,
1009        hash: GitHashKind,
1010        arms: StoreConfig,
1011    ) -> Result<Self> {
1012        std::fs::create_dir_all(root)
1013            .with_context(|| format!("creating the store root {}", root.display()))?;
1014        let blobs = root.join("objects.pack");
1015        let writer = arms.writer.create(&blobs)?;
1016        // `None` for an arm that keeps no durable ack log — see
1017        // [`crate::arms::WriterArm::journal`]. Everything below that touches the
1018        // journal is written against that `Option` rather than assuming one.
1019        let journal = arms.writer.journal(&blobs);
1020        // **The redb ceiling**, carried in on the config rather
1021        // than read here: `StoreConfig::from_env` reads it with the arms, and
1022        // `open`/`open_with` put the environment's value on `DEFAULT` before
1023        // getting here, so every constructor still honours the variable and
1024        // `arms.to_string()` prints what was actually applied. Not an arm — see
1025        // [`crate::arms::redb_cache_bytes`] — redb's own default is 1 GiB *per
1026        // database*, and this store opens exactly ONE of them, the
1027        // `ObjectReadStack` below. The `let _ = cache_bytes` two lines down is
1028        // what is left of the second.
1029        let cache_bytes = arms.redb_cache_bytes;
1030        let objects = ObjectReadStack::<S>::open(
1031            &root.join("objects.tail"),
1032            RebuildTriggers::default(),
1033            cache_bytes,
1034        )?;
1035        let _ = cache_bytes; // no page cache to size: the blob is pread, the index is a slice
1036        // A store written before 2026-09-04 carries `objects.ordinal`, the memo
1037        // of the sorted oid list the read stack's persisted index now IS. Its
1038        // bytes are never read again, so it goes on the first open by this
1039        // build — 278 964 902 B on the kernel mirror. Absent is the normal case
1040        // and not an event; anything else that stops the delete is logged, not
1041        // fatal, because the store does not depend on the file being gone.
1042        match std::fs::remove_file(root.join(ORDINAL_CACHE_FILE)) {
1043            Ok(()) => tracing::info!(
1044                target: "znippy.git",
1045                path = %root.join(ORDINAL_CACHE_FILE).display(),
1046                "removed a stale objects.ordinal — the persisted index's oid column is the \
1047                 ordinal space now"
1048            ),
1049            Err(e) if e.kind() == std::io::ErrorKind::NotFound => {}
1050            Err(e) => tracing::warn!(
1051                target: "znippy.git",
1052                path = %root.join(ORDINAL_CACHE_FILE).display(),
1053                error = %e,
1054                "could not remove a stale objects.ordinal; it is dead weight, not a fault"
1055            ),
1056        }
1057        let exploded = Arc::new(ExplodedCache::open(
1058            &root.join("objects.exploded"),
1059            crate::exploded_arrow::ExplodePolicy::from_env()?,
1060            crate::exploded_cache::budget_from_env(root)?,
1061        )?)
1062        .registered();
1063        // **One descriptor on the blob file, not three.** The writer opened it
1064        // read/write and `flock`ed it; the absorber's `pread` fallback and the
1065        // index workers' `read_exact_at` both address it positionally, so they
1066        // take the same open file description rather than two more of their
1067        // own. 5 descriptors per open store → 3, which is the divisor of
1068        // gunnar's `open_repo_budget` (`tests/fd_per_store.rs`).
1069        let absorber = Arc::new(Absorber::<S>::open(
1070            &blobs,
1071            writer.blobs_shared(),
1072            hash,
1073            objects,
1074            exploded,
1075        )?);
1076
1077        // **The `indexed` bit, derived.** Every extent this archive has ever
1078        // acked, diffed against the rows the index holds. `SafeWriter::create`
1079        // above appends to that journal and never truncates it, which is what
1080        // makes the older extents still be here to diff against.
1081        //
1082        // An arm with no journal has nothing to derive the bit from, and that is
1083        // the honest consequence of choosing it rather than a gap: a
1084        // `FastWriter` store has no durable record that a pack was acked, so a
1085        // reopen re-queues nothing and there is nothing for it to re-queue.
1086        let acked = match journal.as_deref() {
1087            Some(p) if p.exists() => crate::archive_write::read_journal(p).with_context(|| {
1088                format!(
1089                    "reading {} — it is the durable half of the indexed bit and a store \
1090                         cannot be opened without knowing which packs it owes index work for",
1091                    p.display()
1092                )
1093            })?,
1094            _ => Vec::new(),
1095        };
1096        let requeue = absorber.adopt_journal(&acked)?;
1097
1098        // **The wiring.** The absorber goes into the push path, which hands it to
1099        // every account indexer it starts, so the drain behind `push_pack` ends
1100        // in object rows instead of one pack row. Nothing about the ack changes:
1101        // `append` still returns after the two fsyncs and this is all downstream
1102        // of that (§13.9).
1103        let push = PushPath::with_absorber(
1104            writer,
1105            &blobs,
1106            journal,
1107            absorber.clone() as Arc<dyn ObjectAbsorb>,
1108        )?;
1109        let refs = RefLog::new(root.join("refs.log"));
1110        let archive = root.join("repository.znippy");
1111
1112        let store = Self {
1113            root: root.to_path_buf(),
1114            blobs,
1115            archive,
1116            push,
1117            account: account.to_string(),
1118            hash,
1119            absorber,
1120            refs,
1121            ref_gate: Mutex::new(()),
1122            gc: arms.gc.create(),
1123            arms,
1124        };
1125        // The interrupted work, back on the channel it fell off. Nothing reads
1126        // here and nothing blocks: this is the same 24-byte handoff a push makes,
1127        // and the drain picks it up on its own thread (§13.9-11).
1128        let indexer = store.push.indexer(&store.account);
1129        for p in &requeue {
1130            indexer.submit(IndexJob {
1131                pack_id: p.pack_id,
1132                offset: p.offset,
1133                len: p.len,
1134            })?;
1135        }
1136        // A store reopened over an existing tail already knows its objects; the
1137        // derived tables are rebuilt from them rather than from a side-car,
1138        // because a side-car is a second truth.
1139        store.refold()?;
1140        Ok(store)
1141    }
1142
1143    /// The arms this store was built with. A description of what was
1144    /// constructed, not a switch — nothing on a serving path reads it.
1145    pub fn arms(&self) -> StoreConfig {
1146        self.arms
1147    }
1148
1149    /// The selected writer's name, as it goes on a bench row.
1150    pub fn writer_name(&self) -> &'static str {
1151        self.push.name()
1152    }
1153
1154    /// What the selected writer's `append` actually promises. Printed next to a
1155    /// throughput, because a throughput without it is not a comparison.
1156    pub fn writer_durability(&self) -> &'static str {
1157        self.push.durability()
1158    }
1159
1160    /// The selected [`Gc`] arm.
1161    pub(crate) fn gc_arm(&self) -> &dyn Gc {
1162        self.gc.as_ref()
1163    }
1164
1165    /// Where the verbatim packs are.
1166    pub fn blobs_path(&self) -> &Path {
1167        &self.blobs
1168    }
1169
1170    /// The sealed archive GC operates on.
1171    pub fn archive_path(&self) -> &Path {
1172        &self.archive
1173    }
1174
1175    pub fn root(&self) -> &Path {
1176        &self.root
1177    }
1178
1179    pub fn hash_kind(&self) -> GitHashKind {
1180        self.hash
1181    }
1182
1183    /// The `objects` table, for a caller that wants the index directly (the
1184    /// bench does).
1185    pub fn index(&self) -> &ObjectReadStack<S> {
1186        &self.absorber.objects
1187    }
1188
1189    /// Objects in the `objects` table.
1190    pub fn object_count(&self) -> usize {
1191        self.absorber.objects.len()
1192    }
1193
1194    /// Commits in the graph.
1195    pub fn commit_count(&self) -> usize {
1196        self.absorber
1197            .derived
1198            .read()
1199            .expect("derived lock")
1200            .graph
1201            .len()
1202    }
1203
1204    /// `(graph_read_from_disk, graph_recomputed)` since this store was opened —
1205    /// how many folds read the persisted `objects.graph` vs re-derived it.
1206    pub fn graph_source_stats(&self) -> (u64, u64) {
1207        self.absorber.graph_source_stats()
1208    }
1209
1210    /// `(reach_carried, reach_rebuilt)` since this store was opened — how many
1211    /// folds carried the reachability table across (renumbered, no tree
1212    /// opened) vs how many reads built it from scratch. The witness for the
1213    /// clone-after-push lever; see `REACH_CARRY_MAX_FRACTION`.
1214    pub fn reach_source_stats(&self) -> (u64, u64) {
1215        self.absorber.reach_source_stats()
1216    }
1217
1218    /// `(folded_rows, tail_rows)` of the ordinal space the last fold built — how
1219    /// many oids came off the persisted index's oid column and how many off a
1220    /// scan of the redb tail. Replaces S-082's `(read, recomputed)`: there is no
1221    /// memo to read any more, the index IS the space.
1222    pub fn ordinal_source_stats(&self) -> (u64, u64) {
1223        self.absorber.ordinal_source_stats()
1224    }
1225
1226    /// The folded ordinal space — every oid in ordinal order, hex. For the tests
1227    /// that assert a memo read reproduces the scanned space exactly (same oids,
1228    /// same order, same ordinals — the ordinal is the index into this vector).
1229    ///
1230    /// Formatted on demand from `oids_raw`: there is no resident hex `Vec` any
1231    /// more (S-082), and a test that wants hex encodes the flat buffer here
1232    /// rather than the store carrying a second copy for it.
1233    #[cfg(test)]
1234    pub(crate) fn ordinal_oids(&self) -> Vec<String> {
1235        let oid_len = self.hash.oid_len();
1236        self.absorber
1237            .derived
1238            .read()
1239            .expect("derived lock")
1240            .ordinals
1241            .view()
1242            .concat()
1243            .chunks_exact(oid_len)
1244            .map(hex::encode)
1245            .collect()
1246    }
1247
1248    /// **One object's resolved content** — §14's exploded table, in one lookup.
1249    ///
1250    /// Not one of the twelve and deliberately not on [`GitOps`]: the twelve are
1251    /// the wire vocabulary and they hand back **stored** bytes ([`GitOps::get`]),
1252    /// which for a delta entry is a delta. This is the other question — *what
1253    /// does this object contain* — and it is the one §14's table exists to make
1254    /// a point lookup instead of a chain walk.
1255    ///
1256    /// It absorbs any pending pack first, for the same reason
1257    /// [`GitOps::has`] does: a store with durable bytes it has not indexed cannot
1258    /// answer "absent" without lying.
1259    pub fn content(&self, oid: Oid<'_>) -> Result<Option<(GitObjectKind, Vec<u8>)>> {
1260        // No absorb here any more: a pack the worker has not reached is read
1261        // for this one oid by `Absorber::resolved`'s third arm — on this thread,
1262        // from the mmapped pack, without waiting for the worker.
1263        self.absorber.resolved(oid)
1264    }
1265
1266    /// **One object, with the bill for producing it.**
1267    ///
1268    /// [`Self::content`] plus what the read cost: `None` for a cost when the
1269    /// exploded pools answered (nothing was rebuilt), `Some(cost)` when the
1270    /// object was inflated out of the pack. What a measurement needs and a
1271    /// server does not — the cache admission decision is made inside, not by
1272    /// the caller.
1273    pub fn content_costed(
1274        &self,
1275        oid: Oid<'_>,
1276    ) -> Result<Option<(GitObjectKind, Vec<u8>, Option<crate::resolve::ReadCost>)>> {
1277        self.absorber.resolved_costed(oid)
1278    }
1279
1280    /// §14's table, counted: rows, rows written, reads it served, reads that fell
1281    /// through to re-deriving from the verbatim truth.
1282    ///
1283    /// Applied output. Both content paths return identical bytes, so `served`
1284    /// against `rederived` is the only thing that can say which one ran.
1285    pub fn exploded_stats(&self) -> ExplodedStats {
1286        self.absorber.exploded.engine_stats()
1287    }
1288
1289    /// **What the exploded tier is holding and what it is allowed to hold** —
1290    /// the row a dashboard prints (`explode 3.1G/8G`) and `Admin.StorageInfo`
1291    /// carries, per repository.
1292    pub fn explode_cache_use(&self) -> crate::exploded_cache::CacheUse {
1293        self.absorber.exploded.use_now()
1294    }
1295
1296    /// Rows in the EAGER pool only — the graph the push wrote, with nothing a
1297    /// reader has since cached. What `adopt_journal` compares against the index
1298    /// and what a test asking "did the push explode the graph" must ask,
1299    /// because [`Self::exploded_stats`]'s `rows` counts both pools and a read
1300    /// moves it.
1301    pub fn exploded_eager_rows(&self) -> Result<u64> {
1302        self.absorber.exploded.eager_rows()
1303    }
1304
1305    /// **Set this repository's explode budget** — what the control plane calls
1306    /// when an account's quota changes. Takes effect at the next rotation; it
1307    /// never refuses a read, never refuses a write and never deletes on the
1308    /// caller's thread. A bigger budget buys a bigger cache and therefore faster
1309    /// first reads; a smaller one costs re-inflation, never an error.
1310    pub fn set_explode_budget(&self, bytes: u64) {
1311        self.absorber.exploded.set_budget(bytes);
1312    }
1313
1314    /// Flush the lazy pool, rotate it and evict it back under budget — on
1315    /// **this** thread. What a test and a `gc` call; a reader never does, it
1316    /// starts a write-back thread and walks away.
1317    pub fn explode_cache_maintain(&self) -> Result<u64> {
1318        self.absorber.exploded.maintain()
1319    }
1320
1321    /// **`repo gc` reclaims the cache**: every lazy segment unlinked, the graph
1322    /// pool kept. Returns the bytes that left the filesystem.
1323    pub fn drop_explode_cache(&self) -> Result<u64> {
1324        self.absorber.exploded.drop_cache()
1325    }
1326
1327    /// Where §14's table lives. Deleting this file while no store holds it is the
1328    /// sanctioned way to drop it; the next open re-explodes every pack.
1329    pub fn exploded_path(&self) -> &Path {
1330        self.absorber.exploded.path()
1331    }
1332
1333    /// Every live row of one kind, with its payload — what the graph fold reads,
1334    /// exposed so a measurement can ask **the table** how many bytes it holds
1335    /// rather than dividing a file size by what the pack claimed.
1336    pub fn exploded_of_kind(&self, kind: GitObjectKind) -> Result<Vec<(Vec<u8>, Vec<u8>)>> {
1337        self.absorber.exploded.of_kind(kind)
1338    }
1339
1340    /// The commit graph as it stands, generations included. A snapshot: the
1341    /// caller holds no lock and the next fold replaces it wholesale.
1342    pub fn graph_snapshot(&self) -> Vec<CommitNode> {
1343        self.absorber
1344            .derived
1345            .read()
1346            .expect("derived lock")
1347            .graph
1348            .clone()
1349    }
1350
1351    /// Packs whose objects are not in the index yet — §13.12's bit, counted.
1352    pub fn unindexed_packs(&self) -> usize {
1353        self.absorber.unindexed_packs()
1354    }
1355
1356    /// This account's indexer: the thread that drains the channel a push queues
1357    /// on. `is_indexed(pack_id)` on it is §13.12's bit at the pack level, and it
1358    /// is set only once that pack's **objects** are in the index.
1359    pub fn indexer(&self) -> std::sync::Arc<crate::indexer::AccountIndexer> {
1360        self.push.indexer(&self.account)
1361    }
1362
1363    /// Block until the background drain has absorbed everything this store has
1364    /// pushed. What a maintenance tick, a seal or a test uses instead of racing
1365    /// it.
1366    pub fn wait_indexed(&self) {
1367        self.push.pool().wait_caught_up();
1368    }
1369
1370    /// **Stop this store's index work — the repository is being deleted.**
1371    ///
1372    /// Sets the cancel flag the resolver polls every few thousand objects and
1373    /// the drain checks before every pack. The pack in flight is **aborted at
1374    /// its next checkpoint** (milliseconds), not finished: its rows are keyed
1375    /// by oid and the exploded tier is droppable, and the whole directory is
1376    /// about to be removed anyway. Every pack still queued is skipped. After
1377    /// this the store can be dropped without the drop joining a worker that is
1378    /// hours into a kernel pack — which is what `Drop for AccountIndexer` would
1379    /// otherwise do.
1380    pub fn cancel_index(&self) {
1381        self.absorber.cancel.store(true, std::sync::atomic::Ordering::SeqCst);
1382        self.push.pool().cancel_all();
1383    }
1384
1385    /// Put a different memory watchdog under this store's worker — a test's
1386    /// fake `/proc/meminfo`. Takes effect from the next pack.
1387    pub fn set_mem_watchdog(&self, dog: Arc<crate::memguard::MemWatchdog>) {
1388        *self.absorber.watchdog.write().unwrap_or_else(|e| e.into_inner()) = dog;
1389    }
1390
1391    /// Has [`cancel_index`](Self::cancel_index) been called?
1392    pub fn index_cancelled(&self) -> bool {
1393        self.absorber.cancel.load(std::sync::atomic::Ordering::SeqCst)
1394    }
1395
1396    /// This store's index progress counter, for a dashboard or a stats call.
1397    pub fn index_progress(&self) -> crate::progress::Snapshot {
1398        self.absorber.progress.snapshot()
1399    }
1400
1401    /// **The indexer's half of the split**, and not one of the twelve.
1402    ///
1403    /// Runs on the account indexer's worker (§13.9), and on a read that arrives
1404    /// before that worker got there — the same function either way, which is why
1405    /// there is no such thing as a background index that behaves differently from
1406    /// the fallback one.
1407    pub fn absorb_pending(&self) -> Result<usize> {
1408        self.absorber.absorb_pending()
1409    }
1410
1411    /// **Make every durable object addressable, on this thread, now** —
1412    /// [`git_storage_trait::GitServe::index_now`]'s implementation and the ack
1413    /// path's one call. See [`Absorber::index_pending_now`] for why the
1414    /// connectivity check is the only caller allowed to wait here.
1415    pub fn index_now(&self) -> Result<usize> {
1416        self.absorber.index_pending_now()
1417    }
1418
1419    /// **The packs this store has stopped trying to index**, with the reason
1420    /// each one stopped for.
1421    ///
1422    /// Empty is the ordinary answer and the only good one. A non-empty list is
1423    /// a repository that is missing objects whose bytes are durable, and it is
1424    /// the fact an operator needs before wondering why a push was refused or a
1425    /// standby is behind — see [`MAX_ABSORB_ATTEMPTS`].
1426    pub fn unindexable_packs(&self) -> Vec<Unindexable> {
1427        self.absorber.unindexable_packs()
1428    }
1429
1430    /// **The object ids a stored pack introduced**, and not one of the twelve.
1431    ///
1432    /// [`GitOps::put_pack`] cannot answer this and never will: the walk it does
1433    /// reads pack *entries*, and a pack entry does not carry its oid — that is
1434    /// why [`crate::pack_walk::Closure`] can only name the `REF_DELTA` bases and
1435    /// says so. The oids exist once the indexer has absorbed the pack, so this
1436    /// absorbs first rather than racing the drain, and is therefore the one
1437    /// caller that deliberately pays §13.9's deferral back.
1438    ///
1439    /// **Only call it when something needs the set.** A push whose policy has no
1440    /// gate over objects must not pay this, which is the whole reason it is a
1441    /// separate call and not a field on `TxId`.
1442    ///
1443    /// The extent *is* the identity: §14 stores a pack verbatim as one
1444    /// contiguous append, so "introduced by this pack" and "indexed at an offset
1445    /// inside this pack's extent" are the same set, with no pack column to keep
1446    /// in step. Bases the push deltas against live in *other* extents and are
1447    /// excluded by construction — which is what a thin push needs, and what
1448    /// reading a written `.idx` back could never do.
1449    ///
1450    /// Cost is one pass over the index, so it is O(objects in the repository),
1451    /// not O(objects pushed). Recorded rather than hidden: a per-pack ordinal
1452    /// range would make it O(pushed), and needs the indexer to keep one.
1453    pub fn oids_in_extent(&self, extent: Extent) -> Result<Vec<Vec<u8>>> {
1454        let (start, len) = extent;
1455        // **Never waits on the indexer.** If the gate is free this thread
1456        // absorbs the pending packs (the same work, done now, by the caller
1457        // that needs it); if the worker holds it, the extent is resolved
1458        // read-only on this thread and its oids are the answer — the same
1459        // resolver, no sink, no rows written.
1460        if self.try_absorb_pending()?.is_none() {
1461            let snap = self.archive_snapshot()?;
1462            let bytes = self.extent(&snap, start, len)?;
1463            let walked = crate::pack_walk::walk(&bytes, self.hash.oid_len())?;
1464            let mut oids: Vec<Vec<u8>> = Vec::with_capacity(walked.entries.len());
1465            let limits = crate::resolve::ResolveLimits {
1466                base_budget: (crate::resolve::base_budget_from_env() / 4).max(1),
1467                ..crate::resolve::ResolveLimits::none()
1468            };
1469            crate::resolve::resolve_streaming(
1470                &bytes,
1471                &walked,
1472                self.hash,
1473                start,
1474                &*self.absorber,
1475                &crate::exploded::NoSink,
1476                limits,
1477                &mut |rows| {
1478                    oids.extend(rows.drain(..).map(|r| r.oid));
1479                    Ok(())
1480                },
1481            )
1482            .context("resolving the pushed pack read-only to enumerate its objects")?;
1483            return Ok(oids);
1484        }
1485        let end = start.saturating_add(len);
1486        let all = self.index().oids_in_order()?;
1487        let refs: Vec<&[u8]> = all.iter().map(Vec::as_slice).collect();
1488        let extents = self.index().extents_batch(&refs);
1489        Ok(all
1490            .into_iter()
1491            .zip(extents)
1492            .filter_map(|(oid, at)| match at {
1493                Some((offset, _)) if offset >= start && offset < end => Some(oid),
1494                _ => None,
1495            })
1496            .collect())
1497    }
1498
1499    /// **Everything needed to emit a pack for EXACTLY `oids`** — nothing added,
1500    /// nothing dropped.
1501    ///
1502    /// Not one of the twelve. It sits beside [`absorb_pending`](Self::absorb_pending)
1503    /// for the same reason those do: it is about how storage is *shaped*, not
1504    /// about what a caller stores or reads.
1505    ///
1506    /// # 🔴 It used to add the delta bases, and that shipped broken clones
1507    ///
1508    /// Until 2026-08-11 this closed the request over its delta bases: an
1509    /// `OFS_DELTA` names its base by position, so a base outside the set cannot
1510    /// be encoded, and *adding the base* looked like the answer that is always
1511    /// safe. It is not, and the failure is silent on the server:
1512    ///
1513    /// ```text
1514    /// git clone --bare --single-branch --branch base <url>
1515    ///     fatal: did not receive expected object 8601ec33920b7d701c9887fa04916501136d6e90
1516    ///     fatal: fetch-pack: invalid index-pack output
1517    /// event="git.upload_pack.served" objects=33773      ← the server said SUCCESS
1518    /// ```
1519    ///
1520    /// Measured on the `h2h-linear-sha1-2048c-1024f-16k` fixture: `base` reaches
1521    /// **31 805** objects, the delta-base closure added **1 968** more — 33 773,
1522    /// exactly the count the server logged — and 507 of those additions were
1523    /// **trees**. A tree that is not reachable from the wants drags its own
1524    /// children in as a *requirement*, because `git index-pack
1525    /// --check-self-contained-and-connected` (which is what a clone runs, and
1526    /// which sets `strict`) walks every received object's links and then demands
1527    /// each one exist. Those 507 trees named **204** objects the pack did not
1528    /// contain. `8601ec33…` is one of them.
1529    ///
1530    /// So a delta base pulled into a narrowed request is not free: it satisfies
1531    /// the *pack format* and violates *connectivity*. Closing over the added
1532    /// bases' children in turn does terminate — the same fixture reaches a fixed
1533    /// point at 34 534 objects — but it is an over-send by construction, and on
1534    /// a `--filter=blob:none` fetch it adds back exactly the blobs the filter
1535    /// excluded, which is the defect
1536    /// `emit_pack_emits_exactly_the_set_it_is_given_and_never_its_closure`
1537    /// exists to forbid.
1538    ///
1539    /// # What it does instead: the base decides how the entry is encoded
1540    ///
1541    /// The set is never widened. For each requested object:
1542    ///
1543    /// * **base inside the request** → the stored entry is copied byte for byte,
1544    ///   which is the whole point of this engine and is what a full clone does
1545    ///   for every single object;
1546    /// * **base outside the request** → the entry is **rebuilt** from §14's
1547    ///   resolved content and marked
1548    ///   [`EmitEntry::recompressed`](crate::pack_walk::EmitEntry::recompressed) —
1549    ///   as a computed delta against a base the request *does* carry where one
1550    ///   can be found (see [`Self::in_request_chain_ancestor`] and
1551    ///   [`crate::delta`]), and whole where it cannot.
1552    ///
1553    /// That is what stock `pack-objects` does — it reuses a stored delta only
1554    /// when the base is also being packed — and it keeps the receipt a fact:
1555    /// `copied` and `recompressed` add up to the objects written, and
1556    /// `recompressed` is **0 for a whole-repository clone** because such a
1557    /// selection contains every base. The cost lands on the boundary a narrowed
1558    /// request cuts through and nowhere else: 1 968 of 33 773 entries, 5.9 %, on
1559    /// the fixture above.
1560    ///
1561    /// `ofs_delta_ok` is the client's `ofs-delta` capability. An old client that
1562    /// cannot parse one is not refused any more: the entry is re-headed as a
1563    /// `REF_DELTA` naming its base by oid, **carrying the same compressed delta
1564    /// payload**, so that arm stays a copy too. Only a base outside the request
1565    /// costs a rebuild.
1566    ///
1567    /// # `thin_haves` — the boundary entry that does NOT have to be rebuilt
1568    ///
1569    /// `Some(tips)` says the client consented to a thin pack *and* the
1570    /// negotiation found common ground; [`crate::serve::GitStore::emit_oids`] is
1571    /// where the two halves are required together, because either alone is a
1572    /// failed fetch rather than a smaller one. Given it, a base outside the
1573    /// request is checked against [`the client's own objects`](GitStore::client_bases),
1574    /// and one the client already holds is named by oid in a `REF_DELTA` that
1575    /// carries the **stored delta stream unchanged**. That entry counts as
1576    /// `copied`, because it is: nothing was inflated and nothing was deflated.
1577    ///
1578    /// `None` — a clone, or a client that did not ask for a thin pack — behaves
1579    /// exactly as before, and a **full clone is byte-identical either way**,
1580    /// because a whole-repository request has no base outside itself for any of
1581    /// this to apply to.
1582    ///
1583    /// It does nothing for the *clone* half of the boundary cost, and cannot: a
1584    /// clone's receiver holds nothing, so there is no external base to name.
1585    /// That half is the arm below it — [`crate::delta`] computes a delta against
1586    /// something the pack **does** carry, which is the only move left when there
1587    /// is no receiver to lean on. The two do not overlap: `thin_haves` reaches a
1588    /// boundary entry first and costs nothing when it fires, so a fetch stays a
1589    /// pure copy and only a clone pays for a computed delta.
1590    ///
1591    /// # An oid this repository does not hold is REFUSED
1592    ///
1593    /// It used to be skipped, which is the same silent-under-send shape as the
1594    /// closure defect above wearing a different hat: N asked, N-1 emitted,
1595    /// `PackStats` reporting success, and the client the first to know. gunnar's
1596    /// in-memory arm has always refused it, so the skip also meant the two
1597    /// engines behind one contract disagreed about what a missing object means.
1598    /// A partial-clone filter does not depend on the skip and cannot: a filter
1599    /// *removes* oids from the selection, it never adds one the store lacks.
1600    ///
1601    /// # Cost
1602    ///
1603    /// O(objects requested). The previous shape read `oids_in_order()` and
1604    /// `lookup_batch` over the **whole repository** on every call, to build an
1605    /// offset→oid map it needed only for the closure; with no closure the
1606    /// selection's own offsets answer "is this base in the request", so that
1607    /// scan is gone and no reverse index has to exist.
1608    pub fn emit_set(
1609        &self,
1610        oids: &[Oid<'_>],
1611        ofs_delta_ok: bool,
1612        thin_haves: Option<&[Oid<'_>]>,
1613    ) -> Result<Vec<crate::pack_walk::EmitEntry>> {
1614        use crate::index_layout::ObjType;
1615        use std::collections::hash_map::Entry;
1616
1617        // If the gate is free, absorb now; if the worker holds it, the rows
1618        // come from the index plus a read-only pass over the pending packs
1619        // (`lookup_batch_never_wait` below). Never a wait.
1620        let _ = self
1621            .try_absorb_pending()
1622            .context("absorbing pending index work before emitting a pack")?;
1623
1624        // Deduplicate, preserving the caller's order. A repeated oid in the
1625        // request must not become a repeated entry in the pack.
1626        //
1627        // **A map and not a set**, keyed oid → position in `asked` (which is the
1628        // position in `rows`). The membership question is the one it always was;
1629        // what the position buys is the base's *archive offset* for a
1630        // `REF_DELTA`, which names its base by oid and can learn where that base
1631        // sits no other way. It is a `usize` per requested object on a vector
1632        // this function already builds — not a second pass and not a second
1633        // index lookup.
1634        let mut asked: Vec<&[u8]> = Vec::with_capacity(oids.len());
1635        let mut seen: HashMap<&[u8], usize> = HashMap::with_capacity(oids.len());
1636        for oid in oids {
1637            if let Entry::Vacant(slot) = seen.entry(*oid) {
1638                slot.insert(asked.len());
1639                asked.push(*oid);
1640            }
1641        }
1642
1643        let rows = self.lookup_batch_never_wait(&asked)?;
1644
1645        // **One mapping for the whole emit set.** Only the header probes below
1646        // read through it — the entries themselves are recorded as extents and
1647        // resolved by [`Self::resolve_emit_payloads`], which takes its own
1648        // snapshot of the same [`ArchiveMap`](crate::archive_map::ArchiveMap) and
1649        // therefore the same `Arc` unless a push landed in between.
1650        let snap = self.archive_snapshot()?;
1651
1652        // The two questions "is this base in the request" are asked in the two
1653        // coordinate systems the two delta forms use, and both are answered off
1654        // the request itself rather than off the index.
1655        //
1656        // **Offset → position in the request**, not a bare set of offsets. The
1657        // membership question is the same one it always was; what the position
1658        // buys is the base's *oid*, which the re-delta arm below needs in order
1659        // to read the base's content. It is the same single pass over `rows`
1660        // that built the set, so it costs a `usize` per requested object and no
1661        // extra work — and it is emphatically not the whole-repository
1662        // offset→oid scan the old delta-base closure used to do.
1663        let in_set_offsets: HashMap<u64, usize> = rows
1664            .iter()
1665            .enumerate()
1666            .filter_map(|(i, r)| r.as_ref().map(|r| (r.offset, i)))
1667            .collect();
1668        let oid_len = self.hash_kind().oid_len();
1669
1670        // The base of the last boundary entry that was re-deltified, kept so a
1671        // run of entries hanging off one ancestor inflates it once. One slot and
1672        // not an LRU: measured on `h2h-linear-sha1-2048c-1024f-16k`, 961
1673        // boundary entries name 855 distinct stored bases, so there is no reuse
1674        // worth a cache that could hold a repository's worth of objects — and
1675        // this crate is under a live RSS budget.
1676        let mut base_content: Option<(u64, Vec<u8>)> = None;
1677
1678        // What the client already holds, built **lazily and at most once**. A
1679        // clone never asks for it (`thin_haves` is `None`), and a fetch every one
1680        // of whose bases is inside the request never reaches the line that builds
1681        // it either — only a request that actually cuts a delta chain pays, which
1682        // is the only request it can help.
1683        let mut client_bases: Option<ExternalBases> = None;
1684
1685        let mut out = Vec::with_capacity(asked.len());
1686        for (oid, row) in asked.iter().zip(rows.iter()) {
1687            // **An oid this repository does not hold is REFUSED, not dropped.**
1688            //
1689            // This used to `continue`, and that is the same silent-under-send
1690            // shape as the closure defect above: the request asks for N objects,
1691            // the pack carries N-1, the receipt says success and the client is
1692            // the first to find out. It also made the two engines disagree about
1693            // what a missing object *means* — gunnar's in-memory arm has always
1694            // said *"emit_pack was asked for X, which this store does not hold;
1695            // a pack emitter that skipped it would send a pack no client can
1696            // close"* — so a benchmark across the two was comparing two
1697            // contracts.
1698            //
1699            // No legitimate caller relies on the skip. Every set that reaches
1700            // here is built out of this store's own index: `select` answers from
1701            // the reachability bitmaps, and gunnar's own walk resolves each id
1702            // against the store before it selects it. A partial-clone filter is
1703            // no exception and is the case worth naming, because it is the one
1704            // that *looks* like it might be: `--filter=blob:none` **removes**
1705            // oids from the selection, it never adds one the store lacks, so a
1706            // filtered request is a smaller set of objects that are all present
1707            // and this refusal never fires on it.
1708            let Some(row) = row.as_ref() else {
1709                bail!(
1710                    "this pack was asked for {}, which this repository does not hold; emitting \
1711                     the rest would be a short pack reported as a success, so this refuses \
1712                     instead",
1713                    hex::encode(oid)
1714                );
1715            };
1716
1717            // Which base this entry names, if any, and whether the request holds
1718            // it. A `REF_DELTA`'s `delta_base` column is 0 by construction —
1719            // `DeltaBase::as_offset` reports 0 for a ref base and 0 is also the
1720            // no-base sentinel — so its base is read out of the entry's own
1721            // bytes, directly after the type/size varint.
1722            //
1723            // A base that is *outside* the request is carried in **both**
1724            // coordinate systems rather than as a bare `false`, because that is
1725            // what the thin arm below needs: an `OFS_DELTA` knows only where its
1726            // base sits, a `REF_DELTA` knows only what it is called, and
1727            // "does the client hold it" has to be asked in whichever one the
1728            // entry speaks.
1729            let base = match row.obj_type {
1730                ObjType::OfsDelta => match in_set_offsets.get(&row.delta_base) {
1731                    Some(_) => BaseOf::Inside {
1732                        at: row.delta_base,
1733                    },
1734                    None => BaseOf::Outside {
1735                        offset: row.delta_base,
1736                        oid: None,
1737                    },
1738                },
1739                ObjType::RefDelta => {
1740                    let head = self.extent(&snap, row.offset, row.len.min(64))?;
1741                    let (_, _, n) = crate::pack_walk::type_and_size_of(&head)?;
1742                    match head.get(n..n + oid_len) {
1743                        // In the request — **and where**. `rows[i]` is `None`
1744                        // only for an oid this store does not hold, which the
1745                        // refusal above turns into an error the moment the loop
1746                        // reaches it; until then the base is treated as outside,
1747                        // which is the answer that cannot be wrong.
1748                        Some(b) => match seen
1749                            .get(b)
1750                            .and_then(|i| rows[*i].as_ref())
1751                            .map(|r| r.offset)
1752                        {
1753                            Some(at) => BaseOf::Inside { at },
1754                            None => BaseOf::Outside {
1755                                offset: 0,
1756                                oid: Some(b.to_vec()),
1757                            },
1758                        },
1759                        // A truncated entry names no base this can read. It is
1760                        // not "inside", and it is not offered to the client
1761                        // either — it falls through to the whole rebuild, which
1762                        // is the answer that cannot be wrong.
1763                        None => BaseOf::Outside {
1764                            offset: 0,
1765                            oid: None,
1766                        },
1767                    }
1768                }
1769                _ => BaseOf::Whole,
1770            };
1771
1772            if let BaseOf::Whole | BaseOf::Inside { .. } = base {
1773                let inside_at = match base {
1774                    BaseOf::Inside { at } => Some(at),
1775                    _ => None,
1776                };
1777                // **The whole-clone arm, and it reads not one byte here.** The
1778                // entry is recorded as its address in the archive; the bytes are
1779                // resolved against the mapping at emit time and go straight from
1780                // the page cache to the wire. This line used to be a `pread`
1781                // into a fresh `Vec` — 13.8 M of each on a `linux.git` clone, all
1782                // of them held at once, which is the 2314 MB peak RSS
1783                // [`crate::pack_walk::EntryBytes`] documents.
1784                let extent = crate::pack_walk::EntryBytes::Extent {
1785                    offset: row.offset,
1786                    len: row.len,
1787                };
1788                let (stored, obj_type, delta_base) = match (row.obj_type, inside_at) {
1789                    // An `OFS_DELTA` for a client that cannot read one: re-head it
1790                    // as a `REF_DELTA` naming the same base by oid. The compressed
1791                    // payload is the delta stream either way, so this is still a
1792                    // copy in the `recompressed` sense — nothing is inflated — but
1793                    // the concatenation of a new header and an old payload exists
1794                    // nowhere on disk, so it cannot be an extent and is `Owned`.
1795                    (ObjType::OfsDelta, Some(_)) if !ofs_delta_ok => {
1796                        let base_oid = self.oid_at_offset(row.delta_base, &asked, &rows)?;
1797                        let bytes = self.extent(&snap, row.offset, row.len)?;
1798                        (
1799                            crate::pack_walk::EntryBytes::Owned(Self::as_ref_delta(
1800                                &bytes, &base_oid,
1801                            )?),
1802                            ObjType::RefDelta,
1803                            0,
1804                        )
1805                    }
1806                    // 🚨 **A stored `REF_DELTA` whose base is IN THIS PACK is
1807                    // re-headed as an `OFS_DELTA`, and that is not an
1808                    // optimisation.**
1809                    //
1810                    // gitoxide — which is `gunnar_client`, `gunnar`'s own
1811                    // `receive-pack`, and every other gix-based receiver — reads
1812                    // every `OBJ_REF_DELTA` in an incoming pack as naming an
1813                    // object *the receiver already has*.
1814                    // `gix_pack::data::input::LookupRefDeltaObjectsIter` consults
1815                    // the local object database and the bases it has already
1816                    // spliced in, and **nowhere else**: never inside the pack it
1817                    // is reading. A base that is in the pack and not in the
1818                    // receiver's store is `input::Error::NotFound`, and the fetch
1819                    // dies with `The object <base> could not be decoded or wasn't
1820                    // found` — with the whole pack rejected, on a clone whose
1821                    // target is empty by definition, so *every* such entry is
1822                    // fatal. That is `S-003` / gitoxide#2882, and `gunnar-wire`'s
1823                    // `Selection::client_has` carries the same rule for gunnar's
1824                    // own emitter.
1825                    //
1826                    // Stock git resolves it happily, which is why this survived
1827                    // five green `git clone` runs against the store that could
1828                    // not serve one `gunnar_client` fetch (`gunnar.rewrite`
1829                    // round 0 and `gunnar.year` week 0, all four znippy columns,
1830                    // 2026-08-14 — the server logged the same request `served`).
1831                    //
1832                    // The entry keeps its compressed delta stream byte for byte;
1833                    // only the header changes, from "base named by oid" to "base
1834                    // named by distance", which is the naming every receiver in
1835                    // existence resolves inside the pack. This is where such an
1836                    // entry comes from in the first place: `git index-pack
1837                    // --fix-thin` appends the base into the pack and leaves the
1838                    // ref-delta naming it by oid, so any repository pushed to
1839                    // more than once holds them.
1840                    //
1841                    // # What it costs, stated rather than glossed
1842                    //
1843                    // `Owned`, so this is the one arm that gives up the zero-copy
1844                    // property for an entry it does **not** rebuild: the
1845                    // compressed delta stream is memcpy'd once, because a new
1846                    // header concatenated with an old payload exists nowhere on
1847                    // disk and no extent can address it. Bounded by the
1848                    // compressed size of the ref-deltas whose base is in the
1849                    // request — not by the repository, and not by the pack.
1850                    //
1851                    // It could be avoided: `emit_pack` re-encodes every header
1852                    // from `EmitEntry::obj_type` while `header_len` finds the
1853                    // payload from the STORED bytes' own type, so an `Extent`
1854                    // over the untouched ref-delta declared as an `OfsDelta`
1855                    // would emit the identical pack with no copy at all. That is
1856                    // deliberately not done: it makes an `EmitEntry` disagree
1857                    // with the bytes it points at, and the entry model being
1858                    // trustworthy is worth more than the memcpy. If the RSS
1859                    // budget ever says otherwise, the honest form is a third
1860                    // `EntryBytes` variant that carries the new header beside
1861                    // the extent, not a silent disagreement.
1862                    (ObjType::RefDelta, Some(at)) if ofs_delta_ok => {
1863                        let bytes = self.extent(&snap, row.offset, row.len)?;
1864                        (
1865                            crate::pack_walk::EntryBytes::Owned(Self::as_ofs_delta(
1866                                &bytes, oid_len, row.offset, at,
1867                            )?),
1868                            ObjType::OfsDelta,
1869                            at,
1870                        )
1871                    }
1872                    // Everything else copies. A `REF_DELTA` left as one here is
1873                    // the `!ofs_delta_ok` client, which cannot be handed a
1874                    // distance at all — and which is stock git older than 1.4.4,
1875                    // never a gix receiver, since gix has always advertised
1876                    // `ofs-delta`.
1877                    _ => (extent, row.obj_type, row.delta_base),
1878                };
1879                out.push(crate::pack_walk::EmitEntry {
1880                    oid: oid.to_vec(),
1881                    stored,
1882                    obj_type,
1883                    uncompressed_size: row.uncompressed_size,
1884                    delta_base,
1885                    offset: row.offset,
1886                    recompressed: false,
1887                    deltified: false,
1888                });
1889                continue;
1890            }
1891
1892            // ── the base is outside the request ──────────────────────────────
1893            //
1894            // **Thin first.** If the client consented to a thin pack and the
1895            // negotiation vouches that it already holds this base, the entry
1896            // goes out as a `REF_DELTA` naming that base by oid, carrying the
1897            // **same compressed delta stream**. Nothing is inflated, nothing is
1898            // deflated, and the pack is smaller than the whole object by exactly
1899            // the margin the delta was worth. That is what `caps.thin` has always
1900            // been the allowance for.
1901            //
1902            // An `OFS_DELTA` cannot survive this: it names its base by a
1903            // backwards distance *within the pack*, and the base is not in the
1904            // pack. Re-heading it as a `REF_DELTA` is the same header swap the
1905            // no-`ofs-delta` client path does, over an unchanged payload.
1906            if let Some(haves) = thin_haves {
1907                if client_bases.is_none() {
1908                    client_bases = Some(self.client_bases(haves)?);
1909                }
1910                let ext = client_bases
1911                    .as_ref()
1912                    .expect("the client's bases were just built");
1913                let base_oid: Option<Vec<u8>> = match &base {
1914                    // Unreachable: the arm above `continue`s on both. Matched
1915                    // rather than `unreachable!()` so that a future arm falling
1916                    // through here declines the thin path instead of panicking
1917                    // inside a serving thread.
1918                    BaseOf::Whole | BaseOf::Inside { .. } => None,
1919                    BaseOf::Outside {
1920                        oid: Some(named), ..
1921                    } => ext
1922                        .held
1923                        .contains(&OidKey::new(named)?)
1924                        .then(|| named.clone()),
1925                    BaseOf::Outside {
1926                        offset,
1927                        oid: None,
1928                    } => ext.by_offset.get(offset).map(|k| k.as_slice().to_vec()),
1929                };
1930                if let Some(base_oid) = base_oid {
1931                    // A stored `REF_DELTA` already names its base by oid, so its
1932                    // bytes go out untouched and stay an extent. An `OFS_DELTA`
1933                    // has to be re-headed, and the result is new bytes.
1934                    let stored = if row.obj_type == ObjType::OfsDelta {
1935                        let bytes = self.extent(&snap, row.offset, row.len)?;
1936                        crate::pack_walk::EntryBytes::Owned(Self::as_ref_delta(&bytes, &base_oid)?)
1937                    } else {
1938                        crate::pack_walk::EntryBytes::Extent {
1939                            offset: row.offset,
1940                            len: row.len,
1941                        }
1942                    };
1943                    out.push(crate::pack_walk::EmitEntry {
1944                        oid: oid.to_vec(),
1945                        stored,
1946                        obj_type: ObjType::RefDelta,
1947                        uncompressed_size: row.uncompressed_size,
1948                        // The base is NOT in this pack, so nothing may be ordered
1949                        // after it: `topological_order` reads 0 as "names no base
1950                        // in here", which for an external base is the truth.
1951                        delta_base: 0,
1952                        offset: row.offset,
1953                        // Copied. The payload never left the archive's bytes.
1954                        recompressed: false,
1955                        deltified: false,
1956                    });
1957                    continue;
1958                }
1959            }
1960
1961            // The base is not being sent and the client cannot supply it, so the
1962            // stored bytes cannot go out as they are. Two answers remain, and
1963            // the first is worth ~4× the second on the wire.
1964            let (kind, body) = self.content(oid)?.ok_or_else(|| {
1965                anyhow!(
1966                    "{} is a delta whose base is outside this request, so it must be sent whole, \
1967                     and this repository cannot produce its content — neither §14's exploded \
1968                     table nor a re-derivation from the verbatim packs answered",
1969                    hex::encode(oid)
1970                )
1971            })?;
1972
1973            // ── re-delta against a base the request DOES carry ────────────────
1974            //
1975            // The candidate comes from the entry's own stored delta chain: the
1976            // nearest ancestor that is inside the request. That is the packer's
1977            // original similarity judgement, already made and already written
1978            // down — no window, no sort, no scan of the repository.
1979            let candidate = if crate::delta::enabled() {
1980                self.in_request_chain_ancestor(row.delta_base, row.offset, &in_set_offsets)?
1981            } else {
1982                None
1983            };
1984            if let Some(base_at) = candidate {
1985                let at = *in_set_offsets
1986                    .get(&base_at)
1987                    .expect("the ancestor was found by lookup in this very map");
1988                // Reuse the last base if this entry hangs off the same one.
1989                if base_content.as_ref().is_none_or(|(o, _)| *o != base_at) {
1990                    let base_oid = asked[at];
1991                    let (_, base_body) = self.content(base_oid)?.ok_or_else(|| {
1992                        anyhow!(
1993                            "{} is in this request and is the delta base chosen for {}, and this \
1994                             repository cannot produce its content",
1995                            hex::encode(base_oid),
1996                            hex::encode(oid)
1997                        )
1998                    })?;
1999                    base_content = Some((base_at, base_body));
2000                }
2001                let (_, base_body) = base_content.as_ref().expect("just filled");
2002
2003                // `None` is the encoder declining — an unrelated base, or a
2004                // delta that came out no smaller than the object. Falling
2005                // through to the whole rebuild is then strictly right.
2006                if let Some(d) = crate::delta::delta(base_body, &body)? {
2007                    let stored = Self::ofs_delta_entry(&d, row.offset, base_at)?;
2008                    // A client with no `ofs-delta` is served the same computed
2009                    // delta under a `REF_DELTA` head naming the base by oid —
2010                    // the identical header swap the base-inside arm above does,
2011                    // over a payload that is already built.
2012                    // **The `Owned` exception, in its primary shape.** These
2013                    // bytes were computed here and exist on no disk, so no
2014                    // extent addresses them; carrying them on the entry is
2015                    // correct and is bounded by the boundary a narrowed request
2016                    // cuts through (961 of 33 773 entries on the fixture below),
2017                    // never by the repository.
2018                    let (stored, obj_type, delta_base) = if ofs_delta_ok {
2019                        (
2020                            crate::pack_walk::EntryBytes::Owned(stored),
2021                            ObjType::OfsDelta,
2022                            base_at,
2023                        )
2024                    } else {
2025                        (
2026                            crate::pack_walk::EntryBytes::Owned(Self::as_ref_delta(
2027                                &stored, asked[at],
2028                            )?),
2029                            ObjType::RefDelta,
2030                            0,
2031                        )
2032                    };
2033                    out.push(crate::pack_walk::EmitEntry {
2034                        oid: oid.to_vec(),
2035                        stored,
2036                        obj_type,
2037                        uncompressed_size: row.uncompressed_size,
2038                        delta_base,
2039                        offset: row.offset,
2040                        // Inflated and re-deflated, so NOT a copy — and the
2041                        // receipt says which of the two rebuilds ran.
2042                        recompressed: true,
2043                        deltified: true,
2044                    });
2045                    continue;
2046                }
2047            }
2048
2049            // Ship the object whole rather than dragging an unreachable base —
2050            // and its children — into a clone.
2051            out.push(crate::pack_walk::EmitEntry {
2052                oid: oid.to_vec(),
2053                // Inflated and re-deflated from §14's resolved content: the
2054                // `Owned` exception again, and again bounded by the boundary.
2055                stored: crate::pack_walk::EntryBytes::Owned(Self::whole_entry(kind, &body)?),
2056                obj_type: crate::serve::resolved_type(kind),
2057                uncompressed_size: body.len() as u64,
2058                // Whole: it names no base, and nothing may order it after one.
2059                delta_base: 0,
2060                offset: row.offset,
2061                recompressed: true,
2062                deltified: false,
2063            });
2064        }
2065        Ok(out)
2066    }
2067
2068    /// **PHASE 1 of emitting: resolve every entry's stored bytes, in parallel.**
2069    ///
2070    /// Emission splits in two, and the split is not a preference — it is where
2071    /// the ordering dependency actually is:
2072    ///
2073    /// | phase | what it does | why |
2074    /// |---|---|---|
2075    /// | 1, **here**, parallel | address → bytes for every entry | the archive is immutable, so N workers over disjoint (or shared) extents need **no lock at all** |
2076    /// | 2, [`crate::pack_walk::emit_pack`], serial | assign output offsets, encode `OFS_DELTA` distances, write, hash | an `OFS_DELTA` names its base by **distance back in the output pack**, so entry *n* cannot be encoded until every earlier entry's byte length is known |
2077    ///
2078    /// Phase 2 is not parallelisable and no attempt is made: the distance chain
2079    /// is a genuine serial dependency, and a running sha1 is another.
2080    ///
2081    /// # No lock, and why that is a fact rather than an intention
2082    ///
2083    /// [`Self::adopt_journal`] states the storage property this rests on — *"the
2084    /// blob file is append-only and `gc` truncates nothing, so a retired pack's
2085    /// bytes are still exactly where the journal says they are"*. Every byte a
2086    /// snapshot covers is therefore immutable for the life of the file, so the
2087    /// workers below share one `&Mapped` and read it concurrently with no
2088    /// synchronisation of any kind. There is no mutex here; if one were needed
2089    /// the data model would be wrong.
2090    ///
2091    /// # 🚨 This is a fan-out inside the serving tier, and `crate::serve`'s
2092    /// header says that tier is serial
2093    ///
2094    /// It did, and the reason it gave is still true and still respected: the
2095    /// constellation's fan-out primitive has no reentrancy detection, so an
2096    /// unbounded fan-out per request inside an admission gate that already runs
2097    /// 32 transfers spawns W² threads. That is why this is **bounded twice**:
2098    ///
2099    ///  * it does not fan out at all below [`FAN_OUT_AT`] entries, so every fetch
2100    ///    small enough for thread-spawn to dominate runs on the calling thread
2101    ///    exactly as before, and
2102    ///  * it never exceeds [`MAX_RESOLVE_WORKERS`] (override with
2103    ///    `ZNIPPY_GIT_EMIT_WORKERS`), so the worst case is 32 × 4 and not
2104    ///    32 × ncores.
2105    ///
2106    /// # What the fan-out is worth — stated honestly
2107    ///
2108    /// Resolving a mapped extent is a bounds check and a pointer, so the work
2109    /// this parallelises is **not** the resolve itself. It is the two things
2110    /// beside it: the first-touch **page fault** on each entry's header (the
2111    /// grammar is parsed here, which is what forces that fault, and it validates
2112    /// the entry before phase 2 commits a byte to the wire), and the `pread`
2113    /// fallback for any extent the mapping does not cover. On a warm page cache
2114    /// with the whole archive mapped, phase 1 is nearly free and the fan-out
2115    /// buys correspondingly little — the 20 % of cycles this change is aimed at
2116    /// is recovered by *not copying*, not by threads. I could not measure the
2117    /// fan-out's own contribution separately: oden was at loadavg 25.9 while
2118    /// this was written (2026-08-14), and a shared box cannot answer a question
2119    /// that fine.
2120    pub(crate) fn resolve_emit_payloads<'a>(
2121        &self,
2122        entries: &'a [crate::pack_walk::EmitEntry],
2123        snap: &'a crate::archive_map::Mapped,
2124    ) -> Result<Vec<std::borrow::Cow<'a, [u8]>>>
2125    where
2126        Self: Sync,
2127    {
2128        let workers = if entries.len() < FAN_OUT_AT {
2129            1
2130        } else {
2131            emit_workers()
2132        };
2133        self.resolve_with(entries, snap, workers)
2134    }
2135
2136    /// [`Self::resolve_emit_payloads`] with the worker count named rather than
2137    /// decided — `1` runs inline on the calling thread.
2138    ///
2139    /// Split out so the fan-out is **testable at a size a test fixture can
2140    /// reach**. The production threshold is 4096 entries and the corpus these
2141    /// guards run on holds 2687, so a test that went through the front door
2142    /// would exercise the serial arm every time and the gatling arm never;
2143    /// `the_fan_out_resolves_the_identical_bytes_the_serial_pass_does` calls
2144    /// this with 1 and with 4 over the same set and requires the two to agree
2145    /// byte for byte.
2146    pub(crate) fn resolve_with<'a>(
2147        &self,
2148        entries: &'a [crate::pack_walk::EmitEntry],
2149        snap: &'a crate::archive_map::Mapped,
2150        workers: usize,
2151    ) -> Result<Vec<std::borrow::Cow<'a, [u8]>>>
2152    where
2153        Self: Sync,
2154    {
2155        use znippy_zoomies::gatling_forkjoin::gatling_for_each;
2156
2157        let one = |i: usize| -> Result<std::borrow::Cow<'a, [u8]>> {
2158            let e = &entries[i];
2159            let bytes = match &e.stored {
2160                // The bytes live on the entry — the rebuilt-delta exception.
2161                // Borrowed, never cloned: `EntryBytes::Owned` is already the
2162                // only allocation this path makes and copying it would double it.
2163                crate::pack_walk::EntryBytes::Owned(v) => std::borrow::Cow::Borrowed(v.as_slice()),
2164                crate::pack_walk::EntryBytes::Extent { offset, len } => {
2165                    self.extent(snap, *offset, *len)?
2166                }
2167            };
2168            // Parse the entry's own header now. Two things fall out: a malformed
2169            // entry is refused **before** phase 2 has written any of the pack,
2170            // and the first cache line of every entry is touched here — on
2171            // whichever worker got it — rather than one at a time on the serial
2172            // writer.
2173            crate::pack_walk::type_and_size_of(&bytes).with_context(|| {
2174                format!(
2175                    "resolving the stored bytes of {} for emission",
2176                    hex::encode(&e.oid)
2177                )
2178            })?;
2179            Ok(bytes)
2180        };
2181
2182        if workers <= 1 {
2183            return (0..entries.len()).map(one).collect();
2184        }
2185        gatling_for_each(entries.len(), workers, one)
2186            .into_iter()
2187            .collect()
2188    }
2189
2190    /// **Both phases, one call** — the only way a caller in this crate turns an
2191    /// ordered emit set into pack bytes.
2192    ///
2193    /// It is three lines, and it is a function rather than three lines because
2194    /// LAW 5's *fix by construction* applies exactly here: the snapshot has to
2195    /// outlive the slices taken from it, and a caller that took its own snapshot
2196    /// per entry, or dropped it between the phases, would be writing a pack out
2197    /// of a mapping that no longer exists. Routing `emit_oids` and every test
2198    /// through one writer makes that impossible to get wrong twice.
2199    pub(crate) fn emit_ordered(
2200        &self,
2201        ordered: &[crate::pack_walk::EmitEntry],
2202        out: &mut dyn std::io::Write,
2203    ) -> Result<crate::pack_walk::EmitReport>
2204    where
2205        Self: Sync,
2206    {
2207        let snap = self
2208            .archive_snapshot()
2209            .context("mapping the archive to emit")?;
2210        let payloads = self
2211            .resolve_emit_payloads(ordered, &snap)
2212            .context("resolving the emit set's stored bytes")?;
2213        crate::pack_walk::emit_pack(
2214            ordered,
2215            self.hash_kind(),
2216            out,
2217            &|i| Ok(payloads[i].as_ref()),
2218        )
2219    }
2220
2221    /// **The nearest ancestor of `from`'s stored delta chain that is inside the
2222    /// request**, or `None` when the chain leaves the request and never comes
2223    /// back.
2224    ///
2225    /// `from` is the archive offset of a base already known to be *outside* the
2226    /// request; `entry_at` is the offset of the entry that named it.
2227    ///
2228    /// # Why this cannot make a cycle, and why that is not a comment but an
2229    /// invariant
2230    ///
2231    /// The answer is required to satisfy `answer < entry_at`. In a well-formed
2232    /// pack a base always precedes the delta that names it, so every edge in the
2233    /// stored graph already points from a higher offset to a lower one; a new
2234    /// edge with the same property keeps the emitted graph a DAG **by
2235    /// construction**, whatever else the request contains. That matters because
2236    /// the obvious better candidate — the entry's own delta *children*, one
2237    /// revision away instead of two to nine — is exactly the set that would
2238    /// close a cycle: a child's stored base is this entry, so pointing this
2239    /// entry at the child makes `topological_order` unable to order either, and
2240    /// `emit_pack` refuses the set. Measured cost of the restriction on
2241    /// `h2h-linear-sha1-2048c-1024f-16k`: ~1 470 bytes per boundary entry
2242    /// against ~314 for the cyclic candidate, and 5 800 for shipping it whole.
2243    ///
2244    /// An `OFS_DELTA` decreases the offset every hop, so the bound is free
2245    /// there; a `REF_DELTA` names its base by oid and could point anywhere, so
2246    /// the comparison is made rather than assumed.
2247    ///
2248    /// # Cost
2249    ///
2250    /// One 64-byte `pread` per hop, no inflate, no allocation sized by an
2251    /// object — the same walk and the same ceiling as
2252    /// [`crate::serve::GitStore::resolved_type_at`], for the same reason: a
2253    /// pushed pack's back-references are not under this server's control, so a
2254    /// cycle must terminate rather than spin. Measured hop counts on the fixture
2255    /// above: 2 for 392 of the 859 that resolve, 3 for 260, and 9 at the worst.
2256    fn in_request_chain_ancestor(
2257        &self,
2258        from: u64,
2259        entry_at: u64,
2260        in_request: &HashMap<u64, usize>,
2261    ) -> Result<Option<u64>> {
2262        use crate::index_layout::{ObjType, ObjectIndex as _};
2263
2264        /// git's own `pack.depth` ceiling, doubled — the same bound
2265        /// `resolved_type_at` carries and for the same reason.
2266        const MAX_LINKS: usize = 100;
2267        /// Enough of an entry to read its type/size varint plus either an
2268        /// `OFS_DELTA` distance or a `REF_DELTA` oid.
2269        const HEADER_PROBE: u64 = 64;
2270
2271        let oid_len = self.hash_kind().oid_len();
2272        let snap = self.archive_snapshot()?;
2273        let mut at = from;
2274        for _ in 0..MAX_LINKS {
2275            if at != 0 && at < entry_at && in_request.contains_key(&at) {
2276                return Ok(Some(at));
2277            }
2278            if at == 0 {
2279                return Ok(None);
2280            }
2281            // Clamped, not `read_extent`: a short entry at the archive's end
2282            // has fewer than HEADER_PROBE bytes after it (FORGE-SHALLOW).
2283            let head = self.header_probe(&snap, at, HEADER_PROBE)?;
2284            let (t, _, n) = crate::pack_walk::type_and_size_of(&head)?;
2285            at = match t {
2286                // A whole object with no base: the chain ends here, and it was
2287                // not in the request.
2288                ObjType::Commit | ObjType::Tree | ObjType::Blob | ObjType::Tag => {
2289                    return Ok(None)
2290                }
2291                ObjType::OfsDelta => {
2292                    let (distance, _) = crate::pack_walk::ofs_distance_of(&head[n..])?;
2293                    match at.checked_sub(distance) {
2294                        Some(next) if next != 0 => next,
2295                        // A base before the start of the archive is a corrupt
2296                        // back-reference. The whole rebuild is always a correct
2297                        // answer, so this declines rather than failing a clone
2298                        // over an entry it was only ever going to optimise.
2299                        _ => return Ok(None),
2300                    }
2301                }
2302                ObjType::RefDelta => {
2303                    let Some(base_oid) = head.get(n..n + oid_len) else {
2304                        return Ok(None);
2305                    };
2306                    match self.index().lookup(base_oid) {
2307                        Some(row) => row.offset,
2308                        None => return Ok(None),
2309                    }
2310                }
2311            };
2312        }
2313        Ok(None)
2314    }
2315
2316    /// An `OFS_DELTA` pack entry carrying `d`, deflated.
2317    ///
2318    /// The distance written here is the **archive** distance, which is the same
2319    /// coordinate every stored entry's distance is in;
2320    /// [`crate::pack_walk::emit_pack`] rewrites it into output coordinates for
2321    /// every entry it emits, copied or not, so this only has to be well-formed
2322    /// and self-consistent — [`crate::pack_walk::header_len`] parses it back to
2323    /// find where the payload starts.
2324    ///
2325    /// `Compression::fast` for the same reason [`Self::whole_entry`] uses it,
2326    /// and the trade is far better here: the buffer being deflated is the delta,
2327    /// which on the measured fixture is ~1.4 KB against the object's 16 KiB, so
2328    /// this path deflates roughly a **tenth** of the bytes the whole rebuild it
2329    /// replaces does.
2330    fn ofs_delta_entry(d: &[u8], entry_at: u64, base_at: u64) -> Result<Vec<u8>> {
2331        use crate::index_layout::ObjType;
2332        use std::io::Write as _;
2333
2334        let distance = entry_at.checked_sub(base_at).ok_or_else(|| {
2335            anyhow!(
2336                "a computed delta at archive offset {entry_at} names a base at {base_at}, which \
2337                 is after it — an ofs-delta distance is backwards and this would not encode"
2338            )
2339        })?;
2340        let mut out = Vec::with_capacity(d.len() / 2 + 32);
2341        crate::pack_walk::encode_type_and_size(&mut out, ObjType::OfsDelta, d.len() as u64);
2342        crate::pack_walk::encode_ofs_distance(&mut out, distance);
2343        let mut z = flate2::write::ZlibEncoder::new(out, flate2::Compression::fast());
2344        z.write_all(d)?;
2345        Ok(z.finish()?)
2346    }
2347
2348    /// **The objects the receiver already held before this transfer**, in both
2349    /// coordinate systems a delta can name a base in.
2350    ///
2351    /// `haves` is the negotiated common **tips**, exactly as
2352    /// [`git_storage_trait::GitServe::emit_pack`] defines them, and the closure
2353    /// over them is this store's own — the contract deliberately passes tips
2354    /// rather than the walk's exclusion set, because the closure is
2355    /// repository-sized and the engine can rebuild it from its own bitmaps.
2356    ///
2357    /// # This is a VOUCHER, and the caller has to be able to stand behind it
2358    ///
2359    /// Every object named here may be pointed at by a delta the pack does not
2360    /// carry. If the receiver turns out **not** to hold one, its
2361    /// `index-pack --fix-thin` dies with `pack has N unresolved deltas`, so a
2362    /// caller that cannot vouch must not pass `caps.thin`. The case that matters
2363    /// is a **partial clone**: a `blob:none` client's `have` tips reach blobs it
2364    /// was deliberately never sent, so the closure over-states what it holds and
2365    /// a filtered fetch must not be marked thin.
2366    ///
2367    /// # Cost
2368    ///
2369    /// One bitmap union plus one point lookup per held object, and it happens at
2370    /// most once per request — and only on a request that has a base outside
2371    /// itself to place. The `by_offset` map exists because an `OFS_DELTA` knows
2372    /// its base only as an archive offset; building it over what the *client*
2373    /// holds rather than over the repository is what keeps this off the
2374    /// whole-repository scan the closure used to do.
2375    ///
2376    /// **And it is spent in raw bytes now, end to end.** This used to ask
2377    /// [`GitOps::reachable`] — hex out of the ordinal space, `hex::decode`d
2378    /// straight back to bytes, then a third `to_vec` per object to key the
2379    /// offset map, three heap allocations per held object for a set the size of
2380    /// the client's history. It asks [`GitStore::reachable_raw`] instead: one
2381    /// buffer for the closure, one hash table of [`OidKey`]s over it, and
2382    /// nothing per object.
2383    fn client_bases(&self, haves: &[Oid<'_>]) -> Result<ExternalBases> {
2384        use crate::index_layout::ObjectIndex as _;
2385
2386        let held = self.reachable_raw(haves, &[]).context(
2387            "closing over the negotiated common tips, to learn which bases the client can supply \
2388             for itself",
2389        )?;
2390        let refs: Vec<&[u8]> = held.iter().collect();
2391        let rows = self.index().lookup_batch(&refs);
2392        let mut by_offset = HashMap::with_capacity(refs.len());
2393        let mut keys = std::collections::HashSet::with_capacity(refs.len());
2394        for (oid, row) in refs.iter().zip(rows.iter()) {
2395            let key = OidKey::new(oid)?;
2396            if let Some(row) = row {
2397                by_offset.insert(row.offset, key);
2398            }
2399            keys.insert(key);
2400        }
2401        Ok(ExternalBases {
2402            by_offset,
2403            held: keys,
2404        })
2405    }
2406
2407    /// The oid of the entry at `offset`, looked up **in the request** — which is
2408    /// the only place it can be, because this is called for a base the request
2409    /// was just shown to contain.
2410    ///
2411    /// Linear over the request rather than a map, because it runs only on the
2412    /// `ofs-delta`-less client path: a capability no git since 1.4.4 omits, and
2413    /// one that has to be *advertised absent* to reach here at all.
2414    fn oid_at_offset(
2415        &self,
2416        offset: u64,
2417        asked: &[&[u8]],
2418        rows: &[Option<crate::index_layout::IndexRow>],
2419    ) -> Result<Vec<u8>> {
2420        asked
2421            .iter()
2422            .zip(rows)
2423            .find(|(_, r)| r.as_ref().is_some_and(|r| r.offset == offset))
2424            .map(|(oid, _)| oid.to_vec())
2425            .ok_or_else(|| {
2426                anyhow!(
2427                    "the entry at archive offset {offset} was checked to be in this request and \
2428                     then could not be found in it"
2429                )
2430            })
2431    }
2432
2433    /// Re-head a stored `OFS_DELTA` as a `REF_DELTA` naming `base_oid`.
2434    ///
2435    /// The compressed delta stream is copied unchanged; only the header differs,
2436    /// because the two forms differ in **how the base is named** and in nothing
2437    /// else. This is why a client without `ofs-delta` costs bytes and not CPU.
2438    fn as_ref_delta(stored: &[u8], base_oid: &[u8]) -> Result<Vec<u8>> {
2439        use crate::index_layout::ObjType;
2440        let (t, stated_size, n) = crate::pack_walk::type_and_size_of(stored)?;
2441        if t != ObjType::OfsDelta {
2442            bail!("only an ofs-delta can be re-headed as a ref-delta, this entry is {t:?}");
2443        }
2444        let (_, d) = crate::pack_walk::ofs_distance_of(stored.get(n..).unwrap_or(&[]))?;
2445        let mut out = Vec::with_capacity(stored.len() + base_oid.len());
2446        crate::pack_walk::encode_type_and_size(&mut out, ObjType::RefDelta, stated_size);
2447        out.extend_from_slice(base_oid);
2448        out.extend_from_slice(stored.get(n + d..).unwrap_or(&[]));
2449        Ok(out)
2450    }
2451
2452    /// Re-head a stored `REF_DELTA` as an `OFS_DELTA` naming the base that sits
2453    /// at `base_at` — **the inverse of [`Self::as_ref_delta`]**, and the fix for
2454    /// the one pack shape gitoxide cannot read.
2455    ///
2456    /// The compressed delta stream is copied unchanged; only the header differs,
2457    /// because the two forms differ in how the base is *named* and in nothing
2458    /// else. The reason this has to exist is in the caller: a `REF_DELTA` whose
2459    /// base is inside the same pack is resolved by stock git and refused by
2460    /// every gix-based receiver.
2461    ///
2462    /// # The distance written here is a placeholder, and that is by design
2463    ///
2464    /// Exactly as [`Self::ofs_delta_entry`] documents: the distance an
2465    /// `OFS_DELTA` carries is relative to a position in the pack it is *in*, so
2466    /// [`crate::pack_walk::emit_pack`] re-encodes it for every entry from the
2467    /// output offsets it is assigning, and [`crate::pack_walk::header_len`]
2468    /// parses whatever is written here only to find where the payload starts. It
2469    /// therefore has to be well-formed and self-consistent, and nothing more.
2470    ///
2471    /// It cannot simply be `entry_at - base_at`: a `REF_DELTA` is allowed to
2472    /// name a base that comes **after** it in the pack, and `git index-pack
2473    /// --fix-thin` produces exactly that — it appends the base at the end. So a
2474    /// forward reference encodes as `1`, and `emit_pack` writes the real
2475    /// backwards distance once `topological_order` has put the base first.
2476    fn as_ofs_delta(
2477        stored: &[u8],
2478        oid_len: usize,
2479        entry_at: u64,
2480        base_at: u64,
2481    ) -> Result<Vec<u8>> {
2482        use crate::index_layout::ObjType;
2483        let (t, stated_size, n) = crate::pack_walk::type_and_size_of(stored)?;
2484        if t != ObjType::RefDelta {
2485            bail!("only a ref-delta can be re-headed as an ofs-delta, this entry is {t:?}");
2486        }
2487        let payload = stored.get(n + oid_len..).ok_or_else(|| {
2488            anyhow!(
2489                "a ref-delta entry at archive offset {entry_at} is {} bytes, which is not even its \
2490                 header plus a {oid_len}-byte base oid",
2491                stored.len()
2492            )
2493        })?;
2494        let mut out = Vec::with_capacity(payload.len() + 32);
2495        crate::pack_walk::encode_type_and_size(&mut out, ObjType::OfsDelta, stated_size);
2496        crate::pack_walk::encode_ofs_distance(
2497            &mut out,
2498            entry_at.checked_sub(base_at).filter(|d| *d > 0).unwrap_or(1),
2499        );
2500        out.extend_from_slice(payload);
2501        Ok(out)
2502    }
2503
2504    /// A whole (non-delta) pack entry for `body`: type/size header, then the
2505    /// body deflated.
2506    ///
2507    /// The **only** place in this crate that deflates on a serving path, and the
2508    /// only reason it exists is a delta whose base the request does not contain.
2509    /// `Compression::fast` deliberately: these bytes are re-compressed because
2510    /// they *cannot* be copied, so the trade is wire size against a clone's
2511    /// latency, and the entries this runs on are a small boundary fraction of any
2512    /// real request.
2513    fn whole_entry(kind: crate::object::GitObjectKind, body: &[u8]) -> Result<Vec<u8>> {
2514        use std::io::Write as _;
2515        let mut out = Vec::with_capacity(body.len() / 2 + 32);
2516        crate::pack_walk::encode_type_and_size(
2517            &mut out,
2518            crate::serve::resolved_type(kind),
2519            body.len() as u64,
2520        );
2521        let mut z = flate2::write::ZlibEncoder::new(out, flate2::Compression::fast());
2522        z.write_all(body)?;
2523        Ok(z.finish()?)
2524    }
2525
2526    /// Take the absorb gate and hold it.
2527    ///
2528    /// The only way to observe "a read that arrived before the drain" as a
2529    /// **state** rather than as a race: with this held, the worker is parked at
2530    /// the top of its absorb, so the pack is provably durable, provably queued
2531    /// and provably not indexed. Its guard is in this module's tests, and nothing
2532    /// on a serving path takes it.
2533    #[cfg(test)]
2534    pub(crate) fn hold_absorb_gate(&self) -> std::sync::MutexGuard<'_, ()> {
2535        self.absorber.gate.lock().expect("absorb gate poisoned")
2536    }
2537
2538    /// `pread` an extent out of the verbatim archive, into a fresh `Vec`.
2539    ///
2540    /// **The fallback and the owning path.** A caller that can hold a borrow
2541    /// wants [`Self::archive_snapshot`] plus [`Self::extent`] instead: this one
2542    /// costs a syscall, an allocation and a kernel→user copy, which is the shape
2543    /// [`crate::archive_map`] exists to get off the emit path.
2544    pub(crate) fn read_extent(&self, offset: u64, len: u64) -> Result<Vec<u8>> {
2545        self.absorber.read_extent(offset, len)
2546    }
2547
2548    /// One mapping of the verbatim archive, to be taken **once per operation**
2549    /// and sliced N times. See [`crate::archive_map::ArchiveMap::snapshot`].
2550    pub(crate) fn archive_snapshot(&self) -> Result<Arc<crate::archive_map::Mapped>> {
2551        self.absorber.map.snapshot()
2552    }
2553
2554    /// **The one resolver**: an extent's bytes, borrowed from `snap` when it
2555    /// covers them and `pread` into a fresh buffer when it does not.
2556    ///
2557    /// `Cow::Borrowed` is the ordinary answer and the whole point — no syscall,
2558    /// no allocation, no copy, just a bounds-checked slice of the page cache.
2559    /// `Cow::Owned` happens for an extent past the mapped end, which means the
2560    /// blob file grew after the snapshot was taken (a push landed mid-clone).
2561    /// `Mapped::get` returning `None` is *"go and pread it"* and never *"there
2562    /// are no bytes"*, so the two arms return the **same bytes** and differ only
2563    /// in what they cost — which is the property
2564    /// `an_extent_past_the_mapping_falls_back_and_returns_the_same_bytes`
2565    /// asserts.
2566    pub(crate) fn extent<'m>(
2567        &self,
2568        snap: &'m crate::archive_map::Mapped,
2569        offset: u64,
2570        len: u64,
2571    ) -> Result<std::borrow::Cow<'m, [u8]>> {
2572        match snap.get(offset, len) {
2573            Some(b) => Ok(std::borrow::Cow::Borrowed(b)),
2574            None => Ok(std::borrow::Cow::Owned(self.read_extent(offset, len)?)),
2575        }
2576    }
2577
2578    /// **A header probe: AT MOST `len` bytes at `offset`, fewer at the archive's end.**
2579    ///
2580    /// [`Self::extent`] is for an extent the index vouches for and refuses a
2581    /// short read, which is right there: a short extent is a truncated archive.
2582    /// A header probe is not such an extent. It asks for a fixed ceiling
2583    /// ([`crate::serve`]'s `HEADER_PROBE`) to cover the longest header, and an
2584    /// entry shorter than that at the END of the archive has fewer bytes after
2585    /// it. That is not truncation and refusing it cost a live repository every
2586    /// shallow clone (FORGE-SHALLOW, git.gunnar.rs 2026-10-28: edda's 41-byte
2587    /// ref-delta, `short read at (16843881, 64)`). The parsers read a grammar,
2588    /// not a fixed width, so they take what is there. The same clamp
2589    /// [`ArchiveWindow`] gives [`crate::resolve::materialize_at`].
2590    pub(crate) fn header_probe<'m>(
2591        &self,
2592        snap: &'m crate::archive_map::Mapped,
2593        offset: u64,
2594        len: u64,
2595    ) -> Result<std::borrow::Cow<'m, [u8]>> {
2596        clamped_window(&self.absorber, snap, offset, len)
2597    }
2598
2599    /// Record a durable pack as pending index work.
2600    ///
2601    /// The **bit going clear**, and the ack path's last act before it returns.
2602    pub(crate) fn queue(&self, pack_id: u64, extent: Extent) -> Result<()> {
2603        self.absorber.queue(pack_id, extent)
2604    }
2605
2606    fn reach_bitmaps(&self) -> Result<Arc<crate::reach::ReachTable>> {
2607        self.absorber.reach_bitmaps()
2608    }
2609
2610    /// [`Absorber::reach_bitmaps_with`], for the differential guard.
2611    #[cfg(test)]
2612    pub(crate) fn reach_bitmaps_with(
2613        &self,
2614        policy: crate::reach::ReachPolicy,
2615        cache: bool,
2616    ) -> Result<Arc<crate::reach::ReachTable>> {
2617        self.absorber.reach_bitmaps_with(policy, cache)
2618    }
2619
2620    /// `(loaded, extended, unpersisted)` — how many folds read the persisted
2621    /// reachability table, how many extended it for pushed commits, and how
2622    /// many extensions have not been written back yet. The witnesses for the
2623    /// persisted and incremental paths (LAW 2): the bytes a loaded, an extended
2624    /// and a rebuilt table answer with are identical by construction.
2625    pub fn reach_stats(&self) -> (u64, u64, u64) {
2626        self.absorber.reach_stats()
2627    }
2628    pub(crate) fn refold(&self) -> Result<()> {
2629        self.absorber.refold()
2630    }
2631}
2632
2633impl<S: ObjectIndex> Absorber<S> {
2634    /// `shared` is the writer's descriptor on the same file
2635    /// ([`crate::archive_write::ArchiveWrite::blobs_shared`]); `None` opens one,
2636    /// which is what a caller with no writer does.
2637    fn open(
2638        blobs: &Path,
2639        shared: Option<Arc<File>>,
2640        hash: GitHashKind,
2641        objects: ObjectReadStack<S>,
2642        exploded: Arc<ExplodedCache>,
2643    ) -> Result<Self> {
2644        let reader = match shared {
2645            Some(f) => f,
2646            None => Arc::new(
2647                File::open(blobs)
2648                    .with_context(|| format!("opening {} for reads", blobs.display()))?,
2649            ),
2650        };
2651        let label = blobs
2652            .parent()
2653            .map(|p| p.display().to_string())
2654            .unwrap_or_else(|| blobs.display().to_string());
2655        let graph_cache = crate::arms::graph_cache_from_env()?;
2656        if !graph_cache {
2657            // A memo left by an earlier open with the cache on: this store keeps none.
2658            let stale = blobs.with_file_name(GRAPH_CACHE_FILE);
2659            match std::fs::remove_file(&stale) {
2660                Ok(()) => {}
2661                Err(e) if e.kind() == std::io::ErrorKind::NotFound => {}
2662                Err(e) => tracing::warn!(
2663                    target: "znippy.git",
2664                    path = %stale.display(),
2665                    error = %e,
2666                    "the graph cache is off but a stale objects.graph could not be removed"
2667                ),
2668            }
2669        }
2670        Ok(Self {
2671            blobs: blobs.to_path_buf(),
2672            reader,
2673            map: crate::archive_map::ArchiveMap::new(blobs),
2674            hash,
2675            objects,
2676            exploded,
2677            derived: RwLock::new(Derived::default()),
2678            graph_read: std::sync::atomic::AtomicU64::new(0),
2679            graph_recomputed: std::sync::atomic::AtomicU64::new(0),
2680            graph_cache: std::sync::atomic::AtomicBool::new(graph_cache),
2681            reach_carried: std::sync::atomic::AtomicU64::new(0),
2682            reach_rebuilt: std::sync::atomic::AtomicU64::new(0),
2683            reach_loaded: std::sync::atomic::AtomicU64::new(0),
2684            reach_extended: std::sync::atomic::AtomicU64::new(0),
2685            reach_unpersisted: std::sync::atomic::AtomicU64::new(0),
2686            ordinal_folded: std::sync::atomic::AtomicU64::new(0),
2687            ordinal_tail: std::sync::atomic::AtomicU64::new(0),
2688            packs: Mutex::new(PackState::default()),
2689            gate: Mutex::new(()),
2690            progress: crate::progress::IndexProgress::new(&label),
2691            cancel: std::sync::atomic::AtomicBool::new(false),
2692            label,
2693            watchdog: RwLock::new(crate::memguard::global()),
2694            scanned: Mutex::new(HashMap::new()),
2695            scan_build: Mutex::new(()),
2696            unindexable: Mutex::new(HashMap::new()),
2697        })
2698    }
2699
2700    /// **Tree payloads, on demand** — [`crate::reach::TreeSource`] over this
2701    /// store.
2702    ///
2703    /// One lookup per tree the walk actually visits, instead of a resident map
2704    /// of every tree in the repository. Where the bytes come from is
2705    /// [`Absorber::resolved`]'s business and nobody else's: the exploded cache
2706    /// if the tree is in it, its own delta chain out of the mmapped pack if it
2707    /// is not — and the read then writes it back, so a second walk finds it
2708    /// warm.
2709    ///
2710    /// It must not take the `derived` lock, and it does not: `resolved` reads
2711    /// the exploded pools, the `objects` index and the pending packs, none of
2712    /// which is `derived`. Both callers build one of these **inside** their
2713    /// `derived.write()` section, and that is only sound because of this
2714    /// sentence.
2715    fn tree_source(&self) -> TreesFromStore<'_, S> {
2716        TreesFromStore { abs: self, chains: None }
2717    }
2718
2719    /// [`Self::tree_source`] with a [`crate::resolve::ChainCache`] of
2720    /// [`REACH_BUILD_CHAIN_CACHE_BYTES`] behind it — for the one reader that
2721    /// walks every tree: the full reachability build. Dropped with the build.
2722    fn tree_source_for_build(&self, objects: usize) -> TreesFromStore<'_, S> {
2723        // Sized to the repository: a small one must not pay the full memo
2724        // (MEASURED: a 28 251-object repository peaked at 274 MB with the full
2725        // 128 MiB memo against 121 MB without — the memo was most of it).
2726        let cap = objects
2727            .saturating_mul(REACH_BUILD_CHAIN_CACHE_PER_OBJECT)
2728            .clamp(8 << 20, REACH_BUILD_CHAIN_CACHE_BYTES);
2729        TreesFromStore {
2730            abs: self,
2731            chains: Some(Mutex::new(crate::resolve::ChainCache::new(cap))),
2732        }
2733    }
2734
2735    /// Packs whose objects are not in the index yet — §13.12's bit, counted.
2736    fn unindexed_packs(&self) -> usize {
2737        self.packs.lock().expect("pack state lock").unabsorbed
2738    }
2739
2740    /// **Index everything durable, here, now — the ack path's half of §13.9.**
2741    ///
2742    /// # The two hours, in one function
2743    ///
2744    /// MEASURED by lane P2 on the oden rig 2026-08-30. `git.receive_pack.checking`
2745    /// fired at 07:43:49; its very first `peel` of a pushed tip missed the
2746    /// exploded table and missed the `objects` index (the worker was minutes
2747    /// into a 13 948 244-object pack), and fell into [`Self::scan_pending`],
2748    /// which ran **a second, read-only, throw-away resolve of the whole 8.12 GiB
2749    /// pack on the connection thread**:
2750    ///
2751    /// ```text
2752    /// 09:20:21  index.scanned  "a reader scanned a pending pack for itself:
2753    ///                           13948244 objects in 5792442 ms"
2754    /// ```
2755    ///
2756    /// 1h36m32s on the 16 GB box and 1h44m14s on the 8 GB one, for rows it then
2757    /// threw away with the comment *"keeping them would be the index, and the
2758    /// worker is building that"*. That sentence is the defect: two resolvers
2759    /// over the same bytes, each holding its own O(pack) `PackWalk::entries` and
2760    /// oid table, on four vCPUs — which is also **why the watchdog paused**. The
2761    /// reader's second copy is what ate the `MemAvailable` the indexer tripped
2762    /// over, and neither pass ever finished the check.
2763    ///
2764    /// # Who may call this
2765    ///
2766    /// **The ack path, and nothing else.** It takes [`Absorber::gate`], so it
2767    /// waits for whoever is absorbing — and *"nobody waits on the indexer"* is a
2768    /// law with its own red test
2769    /// (`a_read_before_the_drain_is_served_from_the_pack_and_never_waits`): a
2770    /// clone, an `ls-remote`, a `control status` must be answered while the
2771    /// drain is parked, and they still are, through [`Self::scan_pending`].
2772    ///
2773    /// The connectivity check is the one caller for which that is the wrong
2774    /// trade. It has to prove that every object reachable from 2874 new tips is
2775    /// present, which means reading them; an entry's oid exists only once its
2776    /// delta chain has been applied; so the pack must be resolved before the
2777    /// check can answer, and the only question is whether it is resolved **once
2778    /// or twice**. This makes it once. `git receive-pack` makes the same choice
2779    /// and calls it `index-pack`.
2780    ///
2781    /// If the account worker already holds the gate, this blocks on it and then
2782    /// finds `is_absorbed` set and returns: whoever got there first did the work.
2783    ///
2784    /// Returns how many packs this call absorbed; `0` means it could not (it is
2785    /// nested inside an absorb of the only pending pack, or there was nothing
2786    /// to do).
2787    fn index_pending_now(&self) -> Result<usize> {
2788        if self.unindexed_packs() == 0 {
2789            return Ok(0);
2790        }
2791        // **Nested**: this thread is already inside `absorb_gated` and holds the
2792        // gate, so taking it again is a deadlock, not a wait. The other pending
2793        // packs are still ours to absorb inline — that is lane U's case, a thin
2794        // push whose base sits in a pack pushed a moment earlier — and the one
2795        // we are in the middle of is not.
2796        if let Some(current) = IN_ABSORB.with(|c| c.get()) {
2797            let jobs: Vec<PendingPack> = {
2798                let s = self.packs.lock().map_err(|_| anyhow!("pack state poisoned"))?;
2799                s.pending()
2800            };
2801            return self.absorb_each(&jobs, Some(current));
2802        }
2803        let _gate = self.gate.lock().map_err(|_| anyhow!("absorb gate poisoned"))?;
2804        let jobs: Vec<PendingPack> = {
2805            let s = self.packs.lock().map_err(|_| anyhow!("pack state poisoned"))?;
2806            s.pending()
2807        };
2808        // `absorb_gated` is a no-op for a pack somebody absorbed while we were
2809        // queued on the gate, so the loser of the race pays nothing.
2810        self.absorb_each(&jobs, None)
2811    }
2812
2813    /// **Absorb the pending packs only if nobody else is absorbing.**
2814    ///
2815    /// `Some(n)` = the gate was free and this caller did the work; `None` = the
2816    /// worker (or another reader) holds the gate — possibly paused by the
2817    /// memory watchdog for as long as the box is short — and this caller did
2818    /// **not** wait for it. The owner's rule, 2026-08-30: *nobody waits on the
2819    /// indexer.* A read that needs the index now answers from the pack for
2820    /// itself ([`Self::scan_pending`]) and a read that needs the whole graph
2821    /// says so by name rather than blocking behind a kernel pack.
2822    fn try_absorb_pending(&self) -> Result<Option<usize>> {
2823        if self.unindexed_packs() == 0 {
2824            return Ok(Some(0));
2825        }
2826        let _gate = match self.gate.try_lock() {
2827            Ok(g) => g,
2828            Err(std::sync::TryLockError::WouldBlock) => return Ok(None),
2829            Err(std::sync::TryLockError::Poisoned(_)) => bail!("absorb gate poisoned"),
2830        };
2831        let jobs: Vec<PendingPack> = {
2832            let s = self
2833                .packs
2834                .lock()
2835                .map_err(|_| anyhow!("pack state poisoned"))?;
2836            s.pending()
2837        };
2838        self.absorb_each(&jobs, None).map(Some)
2839    }
2840
2841    /// **A read served from the pack on the reader's own request, never by
2842    /// waiting for the worker.**
2843    ///
2844    /// Every oid in `wants` is looked up in the `objects` table first — the
2845    /// rows the worker has already landed, batch by batch, are visible there
2846    /// with no lock in common with it. The ones still missing, if any pack is
2847    /// still un-indexed, are found by **resolving the pending packs read-only
2848    /// on this thread**: the same resolver the worker runs
2849    /// ([`crate::resolve::resolve_streaming`]), over the same mmapped bytes,
2850    /// with a bounded base set, but with **no sink, no gate and no rows
2851    /// written** — it produces rows for the caller and nothing else. The pass
2852    /// stops the moment every wanted oid has been seen.
2853    ///
2854    /// `capture` names one oid whose **content** the caller wants as well (a
2855    /// [`GitStore::content`] read); it rides through a
2856    /// [`crate::exploded::CaptureOne`] sink and comes back in the second slot.
2857    ///
2858    /// # Cost, stated
2859    ///
2860    /// An oid that is in a pending pack costs one read-only pass up to where it
2861    /// sits; an oid that is **absent** costs a full pass over every pending
2862    /// pack — for a kernel pack, minutes of one core. That is the price of
2863    /// never answering "absent" for an object whose bytes are durable, paid by
2864    /// the reader that asked and by nobody else. The rows it computes are not
2865    /// kept: keeping them would be the index, and the worker is building that.
2866    fn scan_pending(
2867        &self,
2868        wants: &[&[u8]],
2869        capture: Option<&[u8]>,
2870    ) -> Result<(Vec<Option<crate::index_layout::IndexRow>>, Option<(GitObjectKind, Vec<u8>)>)> {
2871        use crate::index_layout::IndexRow;
2872        let mut out: Vec<Option<IndexRow>> = vec![None; wants.len()];
2873        let mut missing: HashMap<&[u8], Vec<usize>> = HashMap::with_capacity(wants.len());
2874        for (i, w) in wants.iter().enumerate() {
2875            missing.entry(*w).or_default().push(i);
2876        }
2877        if missing.is_empty() && capture.is_none() {
2878            return Ok((out, None));
2879        }
2880        // **No nested BUILD.** The resolver asks this absorber (as its
2881        // `BaseSource`) for a thin pack's external base, and that base may
2882        // itself be un-indexed — a second *scan build* started from inside the
2883        // first, and a third from inside that, without end.
2884        //
2885        // The guard used to answer `None` outright when re-entered, and that
2886        // was wider than the recursion it was written for: a base sitting in
2887        // **another pack that is already scanned** is one binary search away,
2888        // and refusing it made a thin push on top of a just-acked one fail
2889        // `[remote rejected] … missing necessary objects` — lane U's rig
2890        // finding, 2026-08-30. So a nested call now consults the scans that
2891        // exist and builds none: a lookup terminates, a build is what does not.
2892        thread_local! { static SCANNING: std::cell::Cell<bool> = const { std::cell::Cell::new(false) }; }
2893        let nested = SCANNING.with(|s| s.get());
2894        struct Unset(bool);
2895        impl Drop for Unset {
2896            fn drop(&mut self) {
2897                if !self.0 {
2898                    SCANNING.with(|s| s.set(false));
2899                }
2900            }
2901        }
2902        SCANNING.with(|s| s.set(true));
2903        let _unset = Unset(nested);
2904        let pending: Vec<PendingPack> = {
2905            let s = self
2906                .packs
2907                .lock()
2908                .map_err(|_| anyhow!("pack state poisoned"))?;
2909            s.pending()
2910        };
2911        if pending.is_empty() {
2912            return Ok((out, None));
2913        }
2914        let snap = self.map.snapshot()?;
2915        let mut content: Option<(GitObjectKind, Vec<u8>)> = None;
2916        for job in &pending {
2917            if missing.is_empty() && (capture.is_none() || content.is_some()) {
2918                break;
2919            }
2920            let scanned = match self.cached_scan(job.offset) {
2921                Some(s) => s,
2922                // Inside another scan: no build, so the recursion the guard
2923                // exists for cannot happen, and a pack nobody has scanned yet
2924                // is simply not consulted for this base.
2925                None if nested => continue,
2926                None => self.scanned_pack(&snap, job)?,
2927            };
2928            missing.retain(|oid, slots| match scanned.row(oid) {
2929                Some(r) => {
2930                    for &i in slots.iter() {
2931                        out[i] = Some(r.clone());
2932                    }
2933                    false
2934                }
2935                None => true,
2936            });
2937            if let Some(want) = capture
2938                && content.is_none()
2939                && let Some((entry, _)) = scanned.find(want)
2940            {
2941                let bytes: std::borrow::Cow<'_, [u8]> = match snap.get(job.offset, job.len) {
2942                    Some(b) => std::borrow::Cow::Borrowed(b),
2943                    None => std::borrow::Cow::Owned(self.read_extent(job.offset, job.len)?),
2944                };
2945                let sp = scanned.clone();
2946                let offset_of = move |oid: &[u8]| sp.find(oid).map(|(e, _)| sp.walk.entries[e].offset);
2947                content = Some(crate::resolve::materialize_entry(
2948                    &bytes,
2949                    &scanned.walk,
2950                    entry,
2951                    self.hash.oid_len(),
2952                    &offset_of,
2953                    self,
2954                )?);
2955            }
2956        }
2957        Ok((out, content))
2958    }
2959
2960    /// The scan of one pending pack **if it is already built** — a lookup, and
2961    /// nothing that could recurse. What a nested `scan_pending` is allowed.
2962    fn cached_scan(&self, offset: u64) -> Option<Arc<ScannedPack>> {
2963        self.scanned
2964            .lock()
2965            .unwrap_or_else(|e| e.into_inner())
2966            .get(&offset)
2967            .cloned()
2968    }
2969
2970    /// The scan of one pending pack: cached, or built now by one read-only
2971    /// pass (the same resolver, bounded bases, no sink, no rows written).
2972    fn scanned_pack(&self, snap: &crate::archive_map::Mapped, job: &PendingPack) -> Result<Arc<ScannedPack>> {
2973        if let Some(s) = self.scanned.lock().unwrap_or_else(|e| e.into_inner()).get(&job.offset) {
2974            return Ok(s.clone());
2975        }
2976        let _one_at_a_time = self.scan_build.lock().unwrap_or_else(|e| e.into_inner());
2977        if let Some(s) = self.scanned.lock().unwrap_or_else(|e| e.into_inner()).get(&job.offset) {
2978            return Ok(s.clone());
2979        }
2980        let t0 = std::time::Instant::now();
2981        let bytes: std::borrow::Cow<'_, [u8]> = match snap.get(job.offset, job.len) {
2982            Some(b) => std::borrow::Cow::Borrowed(b),
2983            None => std::borrow::Cow::Owned(self.read_extent(job.offset, job.len)?),
2984        };
2985        let walk = crate::pack_walk::walk(&bytes, self.hash.oid_len())?;
2986        let mut rows: Vec<(Vec<u8>, u32, u64)> = Vec::with_capacity(walk.entries.len());
2987        // A reader's own budget: a quarter of the worker's, no watchdog —
2988        // the pause is the worker's and only the worker's.
2989        let limits = crate::resolve::ResolveLimits {
2990            base_budget: (crate::resolve::base_budget_from_env() / 4).max(1),
2991            cancel: Some(&self.cancel),
2992            label: &self.label,
2993            ..crate::resolve::ResolveLimits::none()
2994        };
2995        // Entry index = position in offset order; the rows come out in
2996        // resolution order, so map offset → index by binary search.
2997        let report = crate::resolve::resolve_streaming(
2998            &bytes,
2999            &walk,
3000            self.hash,
3001            job.offset,
3002            self,
3003            &crate::exploded::NoSink,
3004            limits,
3005            &mut |batch| {
3006                for r in batch.drain(..) {
3007                    let pack_off = r.offset - job.offset;
3008                    let idx = walk
3009                        .entries
3010                        .binary_search_by_key(&pack_off, |e| e.offset)
3011                        .map_err(|_| anyhow!("resolved row at {pack_off} has no walk entry"))?;
3012                    rows.push((r.oid, idx as u32, r.uncompressed_size));
3013                }
3014                Ok(())
3015            },
3016        )
3017        .context("resolving a pending pack read-only for lookups")?;
3018        rows.sort_unstable_by(|a, b| a.0.cmp(&b.0));
3019        let scanned = Arc::new(ScannedPack {
3020            walk,
3021            rows,
3022            archive_offset: job.offset,
3023        });
3024        tracing::info!(
3025            target: "gunnar::index",
3026            event = "index.scanned",
3027            repo = %self.label,
3028            pack_id = job.pack_id,
3029            objects = scanned.rows.len(),
3030            reinflations = report.reinflations,
3031            elapsed_ms = t0.elapsed().as_millis() as u64,
3032            "a reader scanned a pending pack for itself: {} objects in {} ms",
3033            scanned.rows.len(),
3034            t0.elapsed().as_millis()
3035        );
3036        self.scanned
3037            .lock()
3038            .unwrap_or_else(|e| e.into_inner())
3039            .insert(job.offset, scanned.clone());
3040        Ok(scanned)
3041    }
3042
3043    /// **Drop everything this store holds that can be rebuilt** — what the
3044    /// watchdog's flush reaches: the readers' scanned packs (`scanned`, ~1.2
3045    /// GB on linux, rebuilt by the next lookup's pass) and the exploded
3046    /// table's oid tree and batch cache. The rows on disk are untouched.
3047    ///
3048    /// **Returns the rows it actually dropped**, and that number is the point.
3049    /// Lane P2's rig logged this event 190 and 627 times with
3050    /// `scanned_rows_dropped=0` on every single one and kept waiting anyway,
3051    /// because the caller could not tell a spill that freed a gigabyte from one
3052    /// that freed nothing. Three zeros in a row now end the pause
3053    /// ([`crate::memguard::PauseEnd::NothingToGive`]).
3054    ///
3055    /// The exploded table's own caches are an mmap index and a small batch
3056    /// cache; they are dropped here too and deliberately not counted, because
3057    /// they are not where a kernel-sized pack's memory is.
3058    fn spill(&self) -> u64 {
3059        let dropped = {
3060            let mut s = self.scanned.lock().unwrap_or_else(|e| e.into_inner());
3061            let n: usize = s.values().map(|p| p.rows.len()).sum();
3062            s.clear();
3063            n
3064        };
3065        self.exploded.drop_caches();
3066        tracing::info!(
3067            target: "gunnar::index",
3068            event = "index.spilled",
3069            repo = %self.label,
3070            scanned_rows_dropped = dropped,
3071            "the store dropped its rebuildable caches for the memory watchdog"
3072        );
3073        dropped as u64
3074    }
3075
3076    /// This store's watchdog (see the field).
3077    fn watchdog(&self) -> Arc<crate::memguard::MemWatchdog> {
3078        self.watchdog.read().unwrap_or_else(|e| e.into_inner()).clone()
3079    }
3080
3081    /// One oid, never waiting: the index, then the pending packs.
3082    fn lookup_never_wait(&self, oid: &[u8]) -> Result<Option<crate::index_layout::IndexRow>> {
3083        if let Some(r) = self.objects.lookup(oid) {
3084            return Ok(Some(r));
3085        }
3086        // **Check-then-act, and the answer is to look again, not to wait.**
3087        // The index miss above and the bit read below are two reads with the
3088        // drain running between them: the pack's rows can land AND its bit
3089        // clear after the miss, and "no pending pack, so absent" was then a
3090        // lie about a durable object — the one answer §13.12 forbids
3091        // (`no_read_is_told_absent_while_the_drain_is_running` caught it,
3092        // 1 absent answer in 1352, 2 of 10 full-suite runs under load,
3093        // 2026-09-28). The bit clears only AFTER the rows go in, so once it
3094        // reads clear a second index read is authoritative.
3095        if self.unindexed_packs() == 0 {
3096            return Ok(self.objects.lookup(oid));
3097        }
3098        let (mut rows, _) = self.scan_pending(&[oid], None)?;
3099        if let Some(r) = rows.pop().flatten() {
3100            return Ok(Some(r));
3101        }
3102        // The same window one step later: the pack was absorbed and left the
3103        // pending list between the bit read and the scan.
3104        Ok(self.objects.lookup(oid))
3105    }
3106
3107    /// Many oids, never waiting: one index pass, then one read-only pass over
3108    /// the pending packs for whatever the index did not have.
3109    fn lookup_batch_never_wait(&self, oids: &[&[u8]]) -> Result<Vec<Option<crate::index_layout::IndexRow>>> {
3110        let mut rows = self.objects.lookup_batch(oids);
3111        if rows.iter().all(Option::is_some) {
3112            return Ok(rows);
3113        }
3114        // See `lookup_never_wait`: a miss followed by a clear bit is re-read,
3115        // because the drain may have landed the rows between the two.
3116        if self.unindexed_packs() == 0 {
3117            return Ok(self.objects.lookup_batch(oids));
3118        }
3119        let missing: Vec<&[u8]> = oids
3120            .iter()
3121            .zip(&rows)
3122            .filter(|(_, r)| r.is_none())
3123            .map(|(o, _)| *o)
3124            .collect();
3125        let (found, _) = self.scan_pending(&missing, None)?;
3126        let mut by_oid: HashMap<&[u8], crate::index_layout::IndexRow> = HashMap::with_capacity(found.len());
3127        for (o, r) in missing.iter().zip(found) {
3128            if let Some(r) = r {
3129                by_oid.insert(*o, r);
3130            }
3131        }
3132        for (o, slot) in oids.iter().zip(rows.iter_mut()) {
3133            if slot.is_none()
3134                && let Some(r) = by_oid.get(*o)
3135            {
3136                *slot = Some(r.clone());
3137            }
3138        }
3139        // Absorbed between the bit read and the scan: whatever is still
3140        // missing gets one more index read.
3141        if rows.iter().any(Option::is_none) {
3142            for (o, slot) in oids.iter().zip(rows.iter_mut()) {
3143                if slot.is_none() {
3144                    *slot = self.objects.lookup(o);
3145                }
3146            }
3147        }
3148        Ok(rows)
3149    }
3150
3151    /// The bit going clear: this pack is durable and its objects are not in.
3152    ///
3153    /// Skips a pack the drain already absorbed — the ack path queues *after* it
3154    /// has handed the extent to the channel, so the worker can legitimately be
3155    /// finished before this runs, and clearing a bit for a pack that is already
3156    /// indexed would leave it clear for ever.
3157    fn queue(&self, pack_id: u64, extent: Extent) -> Result<()> {
3158        let mut s = self
3159            .packs
3160            .lock()
3161            .map_err(|_| anyhow!("pack state poisoned"))?;
3162        s.note(pack_id, extent);
3163        Ok(())
3164    }
3165
3166    /// **The bit, derived from the two durable facts, on open.**
3167    ///
3168    /// `journal` is every row this archive's journal holds, in append order.
3169    /// [`acked_packs`](crate::archive_write::acked_packs) is what turns that into
3170    /// the packs: its index *is* the pack ordinal — dense by construction, and
3171    /// re-derived the same way by every later open. For each one, the question is
3172    /// only *does this pack have any rows in the index*, which
3173    /// [`ObjectReadStack::extents_with_rows`] answers in one early-terminating
3174    /// scan rather than per pack.
3175    ///
3176    /// Returns the packs whose bit came up **clear**: durable bytes, no rows. The
3177    /// caller re-queues them on the account's channel, which is what makes a
3178    /// pack that was mid-absorb when the process died get absorbed by the next
3179    /// one instead of being durable-but-invisible for ever.
3180    ///
3181    /// The verbatim extents are also handed to [`Derived::packs`] — *all* of
3182    /// them, not only the unabsorbed ones. That is what lets [`BaseSource`]
3183    /// re-derive a delta base's content from the truth after a restart; without
3184    /// it a reopened store knows the rows of a pack it can no longer find the
3185    /// bytes of.
3186    ///
3187    /// # The one case where "no rows" does not mean "never absorbed" — and the
3188    /// third durable fact that now tells them apart
3189    ///
3190    /// [`GitOps::gc`] is the only thing that removes rows. A pack **all** of
3191    /// whose objects it finds dead therefore ends with a journal extent and no
3192    /// rows, which is byte for byte the state a pack that was in flight when the
3193    /// machine died leaves behind. This diff cannot tell them apart, and it must
3194    /// not guess: re-queueing the first resurrects every dead object, and *not*
3195    /// re-queueing the second loses a pack whose bytes were acked.
3196    ///
3197    /// So `gc` says which it is, durably, before it drops a row:
3198    /// [`retire_packs`](crate::archive_write::retire_packs) appends a tombstone
3199    /// naming the retired pack's offset, and a pack named by one is never
3200    /// re-queued here. The bit is still derived from durable facts only — there
3201    /// are now three of them (the journal's pack rows, the journal's tombstones,
3202    /// the index's rows) and none of them is a cache of another.
3203    ///
3204    /// A **partly** dead pack is not tombstoned and still has rows, so it takes
3205    /// the `absorbed` branch exactly as it always did.
3206    ///
3207    /// A tombstoned pack that *does* still have rows is a `gc` that was killed
3208    /// between the tombstone and the drop. It is treated as absorbed, which is
3209    /// what its rows say: nothing is lost, and the next `gc` finishes the job.
3210    ///
3211    /// Its extent still goes to [`Derived::packs`] either way. The blob file is
3212    /// append-only and `gc` truncates nothing, so a retired pack's bytes are
3213    /// still exactly where the journal says they are — and a live object may
3214    /// legitimately be a delta against a base that is itself unreachable, so
3215    /// dropping the extent from that list would break the resolve rather than
3216    /// tidy it.
3217    ///
3218    /// # The second durable fact: §14's exploded table
3219    ///
3220    /// A pack counts as absorbed only if the exploded table is **whole**, which
3221    /// is `exploded.rows() >= objects.len()` — one row per object, because §14's
3222    /// table is eager and skips nothing. If it is short, the table has been
3223    /// dropped (or a process died between the two commits) and **no** pack counts
3224    /// as absorbed: every one is re-queued and re-exploded from the verbatim
3225    /// truth. That is the whole of "droppable": deleting the file is a supported
3226    /// operation whose only cost is one re-ingest, and §13.12's rule holds
3227    /// unchanged over it — absent means fall back, never means wrong.
3228    ///
3229    /// `>=` and not `==` on purpose. A resolve that failed part way leaves rows
3230    /// for the objects it got to, and a `gc` retires both tables together, so the
3231    /// table can legitimately hold *more* than the index names; only being
3232    /// **short** is evidence of a gap.
3233    fn adopt_journal(&self, journal: &[Extent]) -> Result<Vec<PendingPack>> {
3234        if journal.is_empty() {
3235            return Ok(Vec::new());
3236        }
3237        // The packs, in ordinal order, and the offsets a `gc` retired. A
3238        // tombstone is a row and not a pack, so it holds no ordinal.
3239        let packs = crate::archive_write::acked_packs(journal);
3240        let retired = crate::archive_write::retired_offsets(journal);
3241        if packs.is_empty() {
3242            return Ok(Vec::new());
3243        }
3244        // Under `Graph` the table is short **by design** — commits and trees
3245        // only — so the row-count comparison would call every store dropped and
3246        // re-queue every pack on every open. It is weakened to "not empty",
3247        // which still catches the case this rule exists for (the file deleted),
3248        // and is stated rather than hidden: making it exact needs a durable
3249        // commit-and-tree count, which the index does not publish today.
3250        // Only `Full` explodes one row per object, so only `Full` can compare
3251        // counts. Under `Commits` (the shipped default) and `Graph` the eager
3252        // pool is short **by design**, and the comparison would call every store
3253        // dropped and re-queue every pack on every open — a Linux-sized re-index
3254        // per restart. The weakened test still catches what the rule exists for
3255        // (the file deleted) and is stated rather than hidden: making it exact
3256        // needs a durable per-kind count, which the index does not publish.
3257        //
3258        // The LAZY pool is deliberately not consulted. Its size is a function of
3259        // what has been READ, so it says nothing about whether a pack was
3260        // absorbed, and an eviction must never look like a lost index.
3261        let exploded_is_whole = match self.exploded.policy() {
3262            crate::exploded_arrow::ExplodePolicy::Full => {
3263                self.exploded.eager_rows()? >= self.objects.len() as u64
3264            }
3265            crate::exploded_arrow::ExplodePolicy::Off => true,
3266            _ => self.objects.len() == 0 || self.exploded.eager_rows()? > 0,
3267        };
3268        let has_rows = if exploded_is_whole {
3269            self.objects.extents_with_rows(&packs)?
3270        } else {
3271            vec![false; packs.len()]
3272        };
3273        {
3274            let mut d = self
3275                .derived
3276                .write()
3277                .map_err(|_| anyhow!("derived poisoned"))?;
3278            d.packs = packs.clone();
3279        }
3280        let mut s = self
3281            .packs
3282            .lock()
3283            .map_err(|_| anyhow!("pack state poisoned"))?;
3284        let mut requeue = Vec::new();
3285        for (i, (&extent, &absorbed)) in packs.iter().zip(&has_rows).enumerate() {
3286            let pack_id = i as u64;
3287            if absorbed {
3288                s.mark_absorbed(pack_id, extent);
3289            } else if retired.contains(&extent.0) {
3290                // A `gc` dropped every row this pack had and said so durably
3291                // *before* dropping them. There is no index work owed for it,
3292                // ever: re-queueing it is precisely how its dead objects would
3293                // come back. The bit goes **up** rather than being left clear,
3294                // because a clear bit is what makes a read fall back to
3295                // absorbing — which is the same resurrection by another door.
3296                s.mark_absorbed(pack_id, extent);
3297            } else {
3298                s.note(pack_id, extent);
3299                requeue.push(PendingPack {
3300                    pack_id,
3301                    offset: extent.0,
3302                    len: extent.1,
3303                    resumed: true,
3304                });
3305            }
3306        }
3307        Ok(requeue)
3308    }
3309
3310    /// **The indexer's half of the split**, and not one of the twelve.
3311    ///
3312    /// Reads each pending pack's verbatim bytes back out of the archive,
3313    /// resolves them to oids ([`crate::resolve`]), appends the rows to the
3314    /// `objects` table and re-folds the derived tables. This is what §13.9-12
3315    /// puts behind the channel; it runs after the ack, never before one.
3316    ///
3317    /// Two callers, one function: the account indexer's worker (through
3318    /// [`ObjectAbsorb`]) and a read that arrived before that worker did. The
3319    /// second is §13.12's fallback in its literal form — *slower, never wrong*.
3320    fn absorb_pending(&self) -> Result<usize> {
3321        // Nothing to do, and — this is the point — **no gate taken**: the common
3322        // case is a store whose drain has kept up, and it must not queue behind
3323        // one that is running.
3324        if self.unindexed_packs() == 0 {
3325            return Ok(0);
3326        }
3327        let _gate = self
3328            .gate
3329            .lock()
3330            .map_err(|_| anyhow!("absorb gate poisoned"))?;
3331        let jobs: Vec<PendingPack> = {
3332            let s = self
3333                .packs
3334                .lock()
3335                .map_err(|_| anyhow!("pack state poisoned"))?;
3336            s.pending()
3337        };
3338        self.absorb_each(&jobs, None)
3339    }
3340
3341    /// **Every pack it can, skipping the ones it has already given up on.**
3342    ///
3343    /// The one loop all four absorb entry points run (LAW 5): they were four
3344    /// copies of `for job in &jobs { self.absorb_gated(job)?; }`, and that `?`
3345    /// is the bug this function exists to remove. Two rules, and both are
3346    /// consequences of the same sentence — *work that can never succeed must
3347    /// stop and say why*:
3348    ///
3349    /// 1. **A failure does not abandon the packs behind it.** The loop runs to
3350    ///    the end and reports the FIRST failure afterwards, so a pack that
3351    ///    cannot be indexed no longer stops the push that arrived after it from
3352    ///    being indexed and acked.
3353    /// 2. **A pack that has been given up on is not attempted again.** After
3354    ///    [`MAX_ABSORB_ATTEMPTS`] it is recorded in
3355    ///    [`Absorber::unindexable`] with the reason, logged once as
3356    ///    `index.unindexable`, and skipped from then on. Its objects are then
3357    ///    genuinely absent from the index, which every read path already knows
3358    ///    how to say — a push that needs one is refused by name at
3359    ///    `external_bases_exist`, and a clone that needs one fails the
3360    ///    connectivity check. What no longer happens is the store re-resolving
3361    ///    it on every request for the rest of the process's life.
3362    ///
3363    /// `skip` is the pack this thread is standing inside an absorb of
3364    /// ([`IN_ABSORB`]).
3365    fn absorb_each(&self, jobs: &[PendingPack], skip: Option<u64>) -> Result<usize> {
3366        let mut absorbed = 0usize;
3367        let mut first: Option<anyhow::Error> = None;
3368        for job in jobs {
3369            if skip == Some(job.pack_id) || self.given_up_on(job.pack_id) {
3370                continue;
3371            }
3372            match self.absorb_gated(job) {
3373                Ok(()) => absorbed += 1,
3374                Err(e) => {
3375                    // Cancellation is the repository being deleted: there is no
3376                    // queue left worth draining and nothing to record.
3377                    if self.cancel.load(std::sync::atomic::Ordering::Relaxed) {
3378                        return Err(e);
3379                    }
3380                    self.note_absorb_failure(job, &e);
3381                    if first.is_none() {
3382                        first = Some(e);
3383                    }
3384                }
3385            }
3386        }
3387        match first {
3388            None => Ok(absorbed),
3389            Some(e) => Err(e),
3390        }
3391    }
3392
3393    /// Every pack this store has given up on, ordinal order.
3394    fn unindexable_packs(&self) -> Vec<Unindexable> {
3395        let mut v: Vec<Unindexable> = self
3396            .unindexable
3397            .lock()
3398            .unwrap_or_else(|e| e.into_inner())
3399            .values()
3400            .cloned()
3401            .collect();
3402        v.sort_by_key(|u| u.pack_id);
3403        v
3404    }
3405
3406    /// Has this store stopped trying to index that pack?
3407    fn given_up_on(&self, pack_id: u64) -> bool {
3408        self.unindexable
3409            .lock()
3410            .unwrap_or_else(|e| e.into_inner())
3411            .contains_key(&pack_id)
3412    }
3413
3414    /// Count one failed absorb, and stop at [`MAX_ABSORB_ATTEMPTS`].
3415    ///
3416    /// The reason recorded is `root_cause`, not the outermost wrapper: that is
3417    /// the sentence the backend actually has to offer, and lane Z's rule is that
3418    /// the client gets it verbatim rather than a layer's paraphrase of it.
3419    fn note_absorb_failure(&self, job: &PendingPack, err: &anyhow::Error) {
3420        let giving_up;
3421        {
3422            let mut map = self.unindexable.lock().unwrap_or_else(|e| e.into_inner());
3423            // A pack already given up on is not attempted, so an entry here is
3424            // always a fresh count.
3425            let e = map.entry(job.pack_id).or_insert_with(|| Unindexable {
3426                pack_id: job.pack_id,
3427                extent: (job.offset, job.len),
3428                attempts: 0,
3429                reason: String::new(),
3430            });
3431            e.attempts += 1;
3432            e.reason = format!("{}", err.root_cause());
3433            if e.attempts < MAX_ABSORB_ATTEMPTS {
3434                let attempts = e.attempts;
3435                map.remove(&job.pack_id);
3436                tracing::warn!(
3437                    target: "znippy.git",
3438                    store = %self.label,
3439                    pack = job.pack_id,
3440                    attempts,
3441                    max = MAX_ABSORB_ATTEMPTS,
3442                    error = %err.root_cause(),
3443                    "a pack could not be indexed; it stays pending and will be tried again"
3444                );
3445                return;
3446            }
3447            giving_up = Some(e.clone());
3448        }
3449        if let Some(u) = giving_up {
3450            tracing::error!(
3451                target: "znippy.git",
3452                store = %self.label,
3453                event = "index.unindexable",
3454                pack = u.pack_id,
3455                offset = u.extent.0,
3456                len = u.extent.1,
3457                attempts = u.attempts,
3458                error = %u.reason,
3459                "this store has STOPPED trying to index this pack after {} attempts. Its bytes \
3460                 are durable and untouched, and every object it introduced is absent from the \
3461                 index — a push that deltas against one is refused by name and a clone that \
3462                 needs one fails its connectivity check, both immediately. Nothing will retry \
3463                 it: re-push the pack, or delete and re-create the repository.",
3464                u.attempts
3465            );
3466        }
3467    }
3468
3469    /// One pack, **with [`Absorber::gate`] already held**.
3470    ///
3471    /// The order at the end is the correctness argument: the rows are in the
3472    /// index *before* the bit is cleared. A read that finds the bit still clear
3473    /// blocks on the gate and then finds the rows; a read that finds it set finds
3474    /// the rows too. There is no interleaving in which a durable object answers
3475    /// "absent" — which during negotiation would make a client withhold objects
3476    /// and lose data.
3477    fn absorb_gated(&self, job: &PendingPack) -> Result<()> {
3478        if self.cancel.load(std::sync::atomic::Ordering::Relaxed) {
3479            // The repository is being deleted: no pack still queued is worth a
3480            // byte of work, and the drain must get through its queue fast so
3481            // the store can be dropped and the directory removed.
3482            return Err(crate::resolve::ResolveError::cancelled());
3483        }
3484        {
3485            let s = self
3486                .packs
3487                .lock()
3488                .map_err(|_| anyhow!("pack state poisoned"))?;
3489            if s.is_absorbed(job.pack_id) {
3490                // Already in, by whoever reached it first. Re-resolving is now
3491                // *correct* — the exploded table is keyed by oid and the graph is
3492                // folded from it rather than pushed at, so a second absorb of one
3493                // pack changes nothing (that idempotence is what makes dropping
3494                // the table and re-queueing every pack a safe operation). It is
3495                // still a whole pack re-read, re-inflated and re-hashed for
3496                // nothing, so it is skipped.
3497                return Ok(());
3498            }
3499        }
3500        // From here to the end of `absorb_one` this thread holds the gate, and
3501        // the resolver is about to ask this same store for delta bases. See
3502        // [`IN_ABSORB`]: the re-entry must not take the gate again and must not
3503        // try to absorb the pack it is standing in.
3504        let _in = InAbsorb::enter(job.pack_id);
3505        self.absorb_one(job).map_err(|e| {
3506            // The entry stays pending by construction — it was never removed —
3507            // so the bytes are durable, the pack is still un-indexed, and reads
3508            // keep falling back rather than answering absent.
3509            e.context(format!(
3510                "absorbing pack {} at ({}, {}) — its bytes are durable and it stays \
3511                 un-indexed; reads will keep falling back rather than answer absent",
3512                job.pack_id, job.offset, job.len
3513            ))
3514        })?;
3515        let mut s = self
3516            .packs
3517            .lock()
3518            .map_err(|_| anyhow!("pack state poisoned"))?;
3519        s.mark_absorbed(job.pack_id, (job.offset, job.len));
3520        drop(s);
3521        // The index answers for it now; the reader's scan is dead weight.
3522        self.scanned.lock().unwrap_or_else(|e| e.into_inner()).remove(&job.offset);
3523        Ok(())
3524    }
3525
3526    /// One pack: verbatim bytes in, `objects` rows **and** §14's exploded rows
3527    /// out, from **one** walk and **one** resolve.
3528    ///
3529    /// The exploded rows are not a second pass and not a second resolver (LAW 5):
3530    /// [`crate::resolve::resolve_walked`] hands every object it produces to the
3531    /// sink as it produces it, including the blob payloads it is about to drop,
3532    /// so the side table falls out of the pass that was already being made.
3533    ///
3534    /// Ordering is the correctness argument, and it is the same one the drain
3535    /// makes one level up: **the exploded rows are committed before the fold that
3536    /// reads them**, and the fold runs before this returns, so there is no
3537    /// interleaving in which the graph is folded over a table that does not yet
3538    /// hold this pack's commits.
3539    fn absorb_one(&self, job: &PendingPack) -> Result<()> {
3540        let t0 = std::time::Instant::now();
3541        self.progress.begin(job.pack_id, job.len, job.resumed);
3542        // **A live row every 10 s for as long as this pack takes**, carrying
3543        // `peak_rss` and the re-inflation count. Those two rode only on
3544        // `index.finished`, so lane P2's two rig boxes — which ran for 2h14m
3545        // and 2h12m and never finished a pack — produced neither, in exactly
3546        // the failure they were built for. The ticker is a thread and not a
3547        // hook inside the resolve loop on purpose: it prints while the resolver
3548        // is PAUSED too, which is when an operator most needs it.
3549        let _tick = crate::progress::ProgressTicker::start(self.progress.clone());
3550        let result = self.absorb_one_inner(job, t0);
3551        self.progress.sample_memory();
3552        self.progress.finish();
3553        result
3554    }
3555
3556    /// The body of [`absorb_one`](Self::absorb_one), so `finish` runs on every
3557    /// exit and the progress row never sticks at 99 %.
3558    fn absorb_one_inner(&self, job: &PendingPack, t0: std::time::Instant) -> Result<()> {
3559        use crate::progress::Phase;
3560        let progress = &self.progress;
3561        // **The pack is read where it already is.** `read_extent` was a
3562        // `pread` of the whole extent into a fresh `Vec` — 8.12 GiB of
3563        // anonymous heap for torvalds/linux, before one byte was inflated, on a
3564        // 16 GB box. The mapping costs nothing the kernel cannot reclaim
3565        // ([`crate::archive_map`]), and `MemAvailable` — what the watchdog
3566        // reads — knows that.
3567        let snap = self.map.snapshot()?;
3568        let bytes: std::borrow::Cow<'_, [u8]> = match snap.get(job.offset, job.len) {
3569            Some(b) => std::borrow::Cow::Borrowed(b),
3570            // Past the mapping: the file grew after the snapshot. Same bytes,
3571            // one `pread` — the exception, not the shape.
3572            None => std::borrow::Cow::Owned(self.read_extent(job.offset, job.len)?),
3573        };
3574        progress.set_phase(Phase::Walk);
3575        let walked = crate::pack_walk::walk(&bytes, self.hash.oid_len())?;
3576        let t_walk = t0.elapsed();
3577        let dog = self.watchdog();
3578        let spill = || self.spill();
3579        let limits = crate::resolve::ResolveLimits::for_indexer(
3580            &self.label,
3581            &self.cancel,
3582            progress,
3583            dog,
3584            &spill,
3585        );
3586        let mut batches = 0u64;
3587        let mut appended = 0u64;
3588        let mut entries: Vec<crate::index_layout::IndexEntry> = Vec::with_capacity(limits.row_batch);
3589        let report = crate::resolve::resolve_streaming(
3590            &bytes,
3591            &walked,
3592            self.hash,
3593            job.offset,
3594            self,
3595            &*self.exploded,
3596            limits,
3597            &mut |rows| {
3598                // **One batch of rows lands, then the next.** The exploded
3599                // tier already flushed itself every 64 MiB; the index rows
3600                // used to wait for the whole pack. Now the batch is the unit:
3601                // rows go to the `objects` table as they are produced, and the
3602                // pack's own "indexed" bit still goes up only after the LAST
3603                // batch — `mark_absorbed` is the caller's, after this returns.
3604                entries.clear();
3605                entries.extend(rows.iter().map(|r| r.index_entry()));
3606                rows.clear();
3607                self.objects.append(&entries)?;
3608                appended += entries.len() as u64;
3609                batches += 1;
3610                Ok(())
3611            },
3612        )?;
3613        drop(entries);
3614        let t_resolve = t0.elapsed() - t_walk;
3615        progress.set_phase(Phase::Flush);
3616        // Down before anything folds over it.
3617        self.exploded.flush()?;
3618        // A push is what fills the disk, so the push is what asks the cache to
3619        // give space back (the disk line, `exploded_cache::DISK_LINE_PERCENT`).
3620        // Until 2026-09-28 only a reader's write-back started the maintenance
3621        // thread, so a store nobody read never looked at the disk. `kick`
3622        // spawns and returns: the indexer does not wait for an unlink.
3623        self.exploded.kick();
3624
3625        {
3626            let mut d = self
3627                .derived
3628                .write()
3629                .map_err(|_| anyhow!("derived poisoned"))?;
3630            // A reopen already listed every acked extent (`adopt_journal`), so
3631            // this is the first absorb of a pack pushed in *this* process — or a
3632            // re-queued one that is already listed. `find` is what reads this
3633            // list, so a duplicate would not be wrong, only unbounded.
3634            if !d.packs.contains(&(job.offset, job.len)) {
3635                d.packs.push((job.offset, job.len));
3636            }
3637        }
3638        progress.set_phase(Phase::Fold);
3639        let t_fold0 = std::time::Instant::now();
3640        // The graph and the tree payloads are folded from the exploded table, not
3641        // pushed at from here. That is what makes a re-absorb idempotent — which
3642        // it has to be, because dropping the table re-queues every pack.
3643        self.refold()?;
3644        let _ = self.objects.maybe_rebuild()?;
3645        let t_fold = t_fold0.elapsed();
3646        // **The audit line**: every number is applied output of this absorb.
3647        // `peak_rss` is the process's VmHWM off /proc/self/status — the high
3648        // water mark of the whole server, which on the appliance is the box.
3649        tracing::info!(
3650            target: "gunnar::index",
3651            event = "index.finished",
3652            repo = %self.label,
3653            pack_id = job.pack_id,
3654            pack_bytes = job.len,
3655            peak_rss = crate::memguard::peak_rss_bytes(),
3656            mem_available = self.watchdog().available().unwrap_or(0),
3657            objects = report.rows,
3658            batches = batches,
3659            rows_appended = appended,
3660            reinflations = report.reinflations,
3661            evictions = report.evictions,
3662            watchdog_drops = report.watchdog_drops,
3663            peak_base_bytes = report.peak_base_bytes,
3664            pauses = report.pauses,
3665            paused_ms = report.paused_ms,
3666            walk_ms = t_walk.as_millis() as u64,
3667            resolve_ms = t_resolve.as_millis() as u64,
3668            fold_ms = t_fold.as_millis() as u64,
3669            total_ms = t0.elapsed().as_millis() as u64,
3670            resumed = job.resumed,
3671            "indexed {} objects in {} batches: walk {} ms, resolve {} ms, fold {} ms; peak bases {}, {} evictions, {} re-inflations, {} pauses ({} ms); peak rss {}",
3672            report.rows,
3673            batches,
3674            t_walk.as_millis(),
3675            t_resolve.as_millis(),
3676            t_fold.as_millis(),
3677            crate::memguard::fmt_bytes(report.peak_base_bytes),
3678            report.evictions,
3679            report.reinflations,
3680            report.pauses,
3681            report.paused_ms,
3682            crate::memguard::fmt_bytes(crate::memguard::peak_rss_bytes())
3683        );
3684        Ok(())
3685    }
3686
3687    /// Recompute everything derived from the object set: the commit graph, the
3688    /// tree payloads, the ordinal space, the generation numbers, and (lazily) the
3689    /// bitmaps.
3690    ///
3691    /// **The graph is folded from §14's exploded table, not accumulated.** That
3692    /// is the whole fix for the clean-reopen hole: commit and tree payloads are
3693    /// on disk, so this call produces the same graph after a restart as before
3694    /// one, and it is called at the end of [`GitStore::open_with_arms`] for
3695    /// exactly that reason. It also makes a re-absorb idempotent — the old
3696    /// accumulate-into-a-`Vec` shape doubled every commit if a pack was absorbed
3697    /// twice, which is why dropping the table and re-queueing everything was not
3698    /// a safe operation before this.
3699    ///
3700    /// **Generations are stored and must be recomputed in any fold** (§13,
3701    /// decided). A generation number is `1 + max(parents)`, so it is invalidated
3702    /// the moment history's shape changes — which is exactly what absorbing a
3703    /// pack does. [`assign_generations`] is the one writer of that number and it
3704    /// is called here, over the whole graph, rather than incrementally: an
3705    /// incremental update would have to know which descendants moved, and being
3706    /// wrong about that produces an ancestry cutoff that skips real ancestors.
3707    ///
3708    /// # Cost
3709    ///
3710    /// One range scan of the exploded table's commits and one of its trees, per
3711    /// absorbed pack. It is the same order as the `tail_oids` scan below, which
3712    /// this function already made on every absorb, and it reads **no blob
3713    /// payload** — that is what the kind index in
3714    /// [`crate::exploded`] is for.
3715    ///
3716    /// ## And that order is the whole repository, on every push
3717    ///
3718    /// Said plainly, because "the same order as the scan below" reads like a
3719    /// reassurance and is not one: **nothing here is proportional to the push.**
3720    /// Every call rebuilds every tree payload, every commit node, every
3721    /// generation number, a `HashMap<String, u32>` over every oid in the
3722    /// repository and a sorted `Vec<String>` of the same — for a push of one
3723    /// commit exactly as for a push of ten thousand.
3724    ///
3725    /// MEASURED on oden 2026-08-11, release, quiet box (`some avg10` 0.00). The
3726    /// **same** 100-commit increment, pushed onto the same history seeded to
3727    /// four different depths, server CPU for the push:
3728    ///
3729    /// | objects already in the repository | CPU |
3730    /// |---:|---:|
3731    /// | 9 614 | 0.12 s |
3732    /// | 35 350 | 0.23 s |
3733    /// | 103 988 | 0.45 s |
3734    /// | 206 925 | 0.77 s |
3735    ///
3736    /// That is a straight line: **≈88 ms fixed, plus ≈3.3 µs per object already
3737    /// stored**, and the fit predicts the four points to within 20 ms. It is
3738    /// also why a push is slower than the ack path suggests — §13.9 puts the
3739    /// index behind a channel, but `put_refs` checks every ref target with
3740    /// `has`, `has` calls `lookup_one`, and `lookup_one` absorbs pending packs
3741    /// first. The drain is off the *ack* and squarely on the *push*.
3742    ///
3743    /// This is not fixed here and the numbers are recorded so the next attempt
3744    /// starts from them rather than from a guess. The obvious lever — fold
3745    /// incrementally — is the one the paragraph above rules out for
3746    /// generations, so it needs its own argument and its own gate.
3747    fn refold(&self) -> Result<()> {
3748        // Everything derived is computed **before** the write lock, which is then
3749        // held only for the swap: the fold is the long part and nothing that
3750        // reads `derived` should queue behind it.
3751        //
3752        // Ordinals first — **read, not re-scanned, when the tail has not moved.**
3753        // S-082's fix, mirroring the commit-graph memo one paragraph down:
3754        // `objects.ordinal` beside the pack holds `oids_raw` (every oid in the
3755        // store, in ordinal = sorted-raw order), and a cold open reads its couple
3756        // of megabytes back sequentially in milliseconds instead of walking the
3757        // whole redb B-tree — REFOLD measured that scan at ~65% (0.45 s) of a
3758        // 136k-object reopen, and proved a flat buffer measured the same, so the
3759        // cost is the SCAN, not the allocation. It is a memo, not a second truth:
3760        // the redb tail stays authoritative and the file is discarded unless its
3761        // (epoch, count) both match the live tail, so a push, a gc or a torn
3762        // write all fall back to the scan and re-persist.
3763        //
3764        // The raw concatenation is BOTH the ordinal space and the validity token
3765        // for the commit graph below, so the graph is read whenever the object
3766        // set is unchanged; the hex form and the ordinal map fold out of the same
3767        // bytes, so ordinal `o` names the same object in every representation by
3768        // construction rather than by agreeing computations (LAW 5). The tail
3769        // hands oids in oid order, which is byte order over fixed-width oids and
3770        // therefore already the sorted concatenation the memo stores.
3771        //
3772        // **2026-09-04: the memo is gone, because the scan it spared is gone.**
3773        // The read stack persists its projection now (`objects.index`), and the
3774        // sorted oid list IS that index's oid column — one contiguous copy out
3775        // of a mapped buffer, plus a merge of the few rows redb still holds
3776        // since the last fold. No file of its own, no header, no epoch to
3777        // validate: the projection is current by construction. What is kept is
3778        // the provenance — how many oids came off the index and how many off
3779        // the tail — because that is the only thing that can prove the space
3780        // was not a scan (both paths yield identical bytes).
3781        let space = self.objects.oids_raw()?;
3782        self.ordinal_folded
3783            .store(space.folded_rows, std::sync::atomic::Ordering::Relaxed);
3784        self.ordinal_tail
3785            .store(space.tail_rows, std::sync::atomic::Ordering::Relaxed);
3786        let oids_raw = space.raw;
3787        let token = graph_token(&oids_raw);
3788
3789        // The commit graph — **read, not recomputed, when the object set has not
3790        // moved.** S-065's fix: `objects.graph` beside the pack holds the folded
3791        // graph with generations, written by this same call at derive time and
3792        // read here. It is not a second truth — it is a memoized projection
3793        // validated on every read against the authoritative object set (the
3794        // token is a blake3 over every oid in the store), and an absent file, a
3795        // stale token or a decode failure all fall back to the fold and
3796        // re-persist. Same shape as lane REFCAS persisting a tag's peeled target.
3797        //
3798        // On a fold, commit payloads are read out of §14's exploded table (no
3799        // tree payload — that was lane Q's 28.24 GB and most of the 50.9 GiB RSS
3800        // on `torvalds/linux`), parsed, and generation-numbered. That is the
3801        // whole of the O(commits) open cost this persistence removes.
3802        let oid_len = self.hash.oid_len();
3803        let cached = if self.graph_cache.load(std::sync::atomic::Ordering::Relaxed) {
3804            self.load_persisted_graph(&token)?
3805        } else {
3806            None
3807        };
3808
3809        // The whole fold runs under the write lock. It is the short part now:
3810        // after a push the graph is extended by the pushed commits, the ordinal
3811        // space appends, and the reachability table gets entries for the new
3812        // tips — all O(pushed), whatever the repository's size. The one long
3813        // fold is the first one of a store with no memo, and nothing reads a
3814        // store before its open returns.
3815        let mut d = self
3816            .derived
3817            .write()
3818            .map_err(|_| anyhow!("derived poisoned"))?;
3819
3820        // ── the ordinal space: follow the store, never renumber ───────────
3821        //
3822        // `appended` is the range of ordinals this fold added. `None` means the
3823        // space was (re)built from the sorted list — the first fold, or an
3824        // object removed under the table (gc, retain) — and every entry of the
3825        // reachability table was dropped with it.
3826        let mut space_loaded = false;
3827        if d.ordinals.is_empty() && d.reach.is_empty() {
3828            // A cold open: the persisted table, if it is still exact.
3829            if let Some((ordinals, table)) = self.load_persisted_reach(oid_len)? {
3830                d.ordinals = ordinals;
3831                d.reach = Arc::new(table);
3832                space_loaded = true;
3833            }
3834        }
3835        let appended: Option<std::ops::Range<u32>> = if d.ordinals.is_empty() {
3836            None
3837        } else {
3838            d.ordinals.follow(&oids_raw)
3839        };
3840        if appended.is_none() {
3841            d.ordinals = crate::reach::OrdinalTable::from_sorted(oids_raw.clone(), oid_len);
3842            d.reach = Arc::default();
3843            space_loaded = false;
3844        }
3845        if space_loaded {
3846            self.reach_loaded
3847                .fetch_add(1, std::sync::atomic::Ordering::Relaxed);
3848        }
3849
3850        // ── the commit graph ──────────────────────────────────────────────
3851        let graph: Vec<CommitNode> = match cached {
3852            Some(g) => {
3853                self.graph_read.fetch_add(1, std::sync::atomic::Ordering::Relaxed);
3854                g
3855            }
3856            None => {
3857                self.graph_recomputed
3858                    .fetch_add(1, std::sync::atomic::Ordering::Relaxed);
3859                let g = match &appended {
3860                    // **Extend, do not re-derive.** The previous fold's rows are
3861                    // exact (a commit is immutable); only the objects this fold
3862                    // appended can be new commits, and the exploded table says
3863                    // which of them are, without resolving a single delta.
3864                    Some(r) if !d.graph.is_empty() => {
3865                        let mut nodes = std::mem::take(&mut d.graph);
3866                        let space = d.ordinals.view();
3867                        for o in r.clone() {
3868                            let Some(oid) = space.oid(o) else { continue };
3869                            if let Some((GitObjectKind::Commit, payload)) = self.exploded.content(oid)? {
3870                                let h = crate::object::parse_commit(&payload);
3871                                nodes.push(CommitNode {
3872                                    oid: hex::encode(oid),
3873                                    parents: h.parents,
3874                                    tree: h.tree,
3875                                    committer_time: h.committer_time,
3876                                    generation: 0,
3877                                });
3878                            }
3879                        }
3880                        assign_generations(nodes)
3881                    }
3882                    _ => {
3883                        let commits = self.exploded.of_kind(GitObjectKind::Commit)?;
3884                        let g: Vec<CommitNode> = commits
3885                            .iter()
3886                            .map(|(oid, payload)| {
3887                                let h = crate::object::parse_commit(payload);
3888                                CommitNode {
3889                                    oid: hex::encode(oid),
3890                                    parents: h.parents,
3891                                    tree: h.tree,
3892                                    committer_time: h.committer_time,
3893                                    generation: 0,
3894                                }
3895                            })
3896                            .collect();
3897                        assign_generations(g)
3898                    }
3899                };
3900                // Persist for the next open. A write failure is not fatal to the
3901                // fold — the graph is correct in memory and the next open simply
3902                // recomputes — so it is logged, not propagated.
3903                if !self.graph_cache.load(std::sync::atomic::Ordering::Relaxed) {
3904                    // Switched off: no memo on this disk.
3905                } else if let Err(e) = self.persist_graph(&token, &g) {
3906                    tracing::warn!(store = %self.label, "could not persist objects.graph: {e:#}");
3907                }
3908                g
3909            }
3910        };
3911        let mut ord_graph = crate::reach::OrdGraph::from_nodes(&graph, &d.ordinals.view());
3912
3913        // ── the reachability table: extend for the pushed commits ─────────
3914        //
3915        // Entries describe immutable commits over a space that just appended,
3916        // so every one of them stands. What is new is the pushed commits; the
3917        // new tips (and a sample of a long pushed branch) get entries by the
3918        // bounded walk, inside this fold, so the first fetch after the push
3919        // pays nothing. See `crate::reach::extend_reach_table`.
3920        let mut reach_changed = false;
3921        if !d.reach.is_empty() {
3922            if let Some(r) = &appended {
3923                let new_rows: Vec<u32> = (0..ord_graph.len() as u32)
3924                    .filter(|&row| {
3925                        let o = ord_graph.ords[row as usize];
3926                        o != crate::reach::NONE && o >= r.start
3927                    })
3928                    .collect();
3929                if !new_rows.is_empty() {
3930                    let trees = self.tree_source();
3931                    let facts = crate::reach::ObjectFacts {
3932                        ordinal: d.ordinals.view(),
3933                        trees: &trees,
3934                        oid_len,
3935                    };
3936                    let started = std::time::Instant::now();
3937                    let extended = crate::reach::extend_reach_table(
3938                        &d.reach,
3939                        &ord_graph,
3940                        &facts,
3941                        &new_rows,
3942                        live_reach_policy(),
3943                    );
3944                    tracing::info!(
3945                        store = %self.label,
3946                        new_commits = new_rows.len(),
3947                        entries = extended.len(),
3948                        elapsed_ms = started.elapsed().as_millis() as u64,
3949                        "fold: extended the reachability table for the pushed commits"
3950                    );
3951                    d.reach = Arc::new(extended);
3952                    self.reach_extended
3953                        .fetch_add(1, std::sync::atomic::Ordering::Relaxed);
3954                    reach_changed = true;
3955                }
3956            }
3957            self.reach_carried
3958                .fetch_add(1, std::sync::atomic::Ordering::Relaxed);
3959        }
3960
3961        // ── compaction: re-sort the space once it has grown enough ────────
3962        let mut compacted = false;
3963        if d.ordinals.extra_len() > d.ordinals.base_len() / ORDINAL_COMPACT_FRACTION
3964            && d.ordinals.extra_len() > ORDINAL_COMPACT_MIN
3965        {
3966            let fresh = crate::reach::OrdinalTable::from_sorted(oids_raw, oid_len);
3967            let remap = d.ordinals.remap_to(&fresh.view());
3968            let kept = d.reach.remapped(&remap).unwrap_or_default();
3969            tracing::info!(
3970                store = %self.label,
3971                appended = d.ordinals.extra_len(),
3972                base = d.ordinals.base_len(),
3973                entries = kept.len(),
3974                "fold: compacted the ordinal space (re-sorted, table renumbered once)"
3975            );
3976            d.ordinals = fresh;
3977            d.reach = Arc::new(kept);
3978            ord_graph = crate::reach::OrdGraph::from_nodes(&graph, &d.ordinals.view());
3979            compacted = true;
3980            reach_changed = true;
3981        }
3982
3983        d.graph = graph;
3984        d.reach_by_row = Arc::new(d.reach.by_row(&ord_graph));
3985        d.ord_graph = Arc::new(ord_graph);
3986        d.token = token;
3987        tracing::info!(
3988            store = %self.label,
3989            graph_len = d.graph.len(),
3990            space_len = d.ordinals.len(),
3991            appended = appended.as_ref().map(|r| r.len()).unwrap_or(0),
3992            space_rebuilt = appended.is_none(),
3993            reach_entries = d.reach.len(),
3994            reach_loaded = space_loaded,
3995            "fold: derived tables"
3996        );
3997        if reach_changed && !d.reach.is_empty() {
3998            let due = self
3999                .reach_unpersisted
4000                .fetch_add(1, std::sync::atomic::Ordering::Relaxed)
4001                + 1;
4002            if compacted || due >= REACH_PERSIST_EVERY {
4003                self.persist_reach_locked(&d);
4004            }
4005        }
4006        Ok(())
4007    }
4008
4009    /// Write the live reachability table and its space, if the memo is on.
4010    /// A failure is logged, never propagated: the table is right in memory and
4011    /// the next open rebuilds.
4012    fn persist_reach_locked(&self, d: &Derived) {
4013        if !self.graph_cache.load(std::sync::atomic::Ordering::Relaxed) || d.reach.is_empty() {
4014            return;
4015        }
4016        match self.persist_reach(&d.ordinals, &d.reach) {
4017            Ok(()) => {
4018                self.reach_unpersisted
4019                    .store(0, std::sync::atomic::Ordering::Relaxed);
4020            }
4021            Err(e) => tracing::warn!(store = %self.label, "could not persist objects.reach: {e:#}"),
4022        }
4023    }
4024    /// `(reach_carried, reach_rebuilt)` — how many folds since open carried the
4025    /// reachability table across (renumbered) vs how many reads built it from
4026    /// scratch. See [`tests::a_push_carries_the_reach_table_across_the_fold`].
4027    fn reach_source_stats(&self) -> (u64, u64) {
4028        (
4029            self.reach_carried.load(std::sync::atomic::Ordering::Relaxed),
4030            self.reach_rebuilt.load(std::sync::atomic::Ordering::Relaxed),
4031        )
4032    }
4033
4034    /// `(loaded, extended, unpersisted)`; see [`GitStore::reach_stats`].
4035    fn reach_stats(&self) -> (u64, u64, u64) {
4036        (
4037            self.reach_loaded.load(std::sync::atomic::Ordering::Relaxed),
4038            self.reach_extended.load(std::sync::atomic::Ordering::Relaxed),
4039            self.reach_unpersisted.load(std::sync::atomic::Ordering::Relaxed),
4040        )
4041    }
4042
4043    /// Where the folded commit graph is cached, beside the verbatim pack:
4044    /// `<root>/objects.graph`.
4045    fn graph_cache_path(&self) -> PathBuf {
4046        self.blobs.with_file_name(GRAPH_CACHE_FILE)
4047    }
4048
4049    /// The persisted graph and the token it was written under, or `None` when
4050    /// the cache is absent, truncated, an unknown version, or fails to decode —
4051    /// every one of which is a signal to recompute and re-persist rather than an
4052    /// error, because the cache is a memo and the exploded table is the truth.
4053    fn load_persisted_graph(&self, token: &[u8; 32]) -> Result<Option<Vec<CommitNode>>> {
4054        let bytes = match std::fs::read(self.graph_cache_path()) {
4055            Ok(b) => b,
4056            Err(e) if e.kind() == std::io::ErrorKind::NotFound => return Ok(None),
4057            Err(e) => {
4058                return Err(e).with_context(|| {
4059                    format!("reading {}", self.graph_cache_path().display())
4060                });
4061            }
4062        };
4063        // Frame: b"GRPH" (4) + version (1) + token (32) + Arrow IPC graph.
4064        //
4065        // **The token is checked BEFORE the decode.** It used to be after: every
4066        // fold read and fully decoded the old graph — a `String` per commit and
4067        // per parent — and then threw it away, because after any push the token
4068        // cannot match. The miss is now one 32-byte compare.
4069        if bytes.len() < GRAPH_CACHE_HEADER || &bytes[..4] != GRAPH_CACHE_MAGIC || bytes[4] != 1 {
4070            return Ok(None);
4071        }
4072        if &bytes[5..GRAPH_CACHE_HEADER] != token {
4073            return Ok(None);
4074        }
4075        match crate::graph::decode_graph(&bytes[GRAPH_CACHE_HEADER..]) {
4076            Ok(g) => Ok(Some(g)),
4077            Err(_) => Ok(None),
4078        }
4079    }
4080
4081    fn reach_cache_path(&self) -> PathBuf {
4082        self.blobs.with_file_name(REACH_CACHE_FILE)
4083    }
4084
4085    /// **The persisted reachability table**: its ordinal space (base and the
4086    /// appended part, raw) and the entries as Arrow IPC. `Ok(None)` when absent,
4087    /// stale or malformed — all three mean "build it again", never a panic:
4088    /// the IPC part goes through znippy-common's guard and the raw parts are
4089    /// length-checked before a single slice is taken.
4090    ///
4091    /// Frame: b"RECH" (4) + version (1) + oid_len (u32) + base bytes (u64) +
4092    /// extra bytes (u64) + base + extra + Arrow IPC `(commit_ordinal, bitmap)`.
4093    fn load_persisted_reach(&self, oid_len: usize) -> Result<Option<(crate::reach::OrdinalTable, crate::reach::ReachTable)>> {
4094        if !self.graph_cache.load(std::sync::atomic::Ordering::Relaxed) {
4095            return Ok(None);
4096        }
4097        let bytes = match std::fs::read(self.reach_cache_path()) {
4098            Ok(b) => b,
4099            Err(e) if e.kind() == std::io::ErrorKind::NotFound => return Ok(None),
4100            Err(e) => {
4101                return Err(e).with_context(|| format!("reading {}", self.reach_cache_path().display()));
4102            }
4103        };
4104        if bytes.len() < REACH_CACHE_HEADER || &bytes[..4] != REACH_CACHE_MAGIC || bytes[4] != 1 {
4105            return Ok(None);
4106        }
4107        let w = u32::from_le_bytes(bytes[5..9].try_into().expect("4 bytes")) as usize;
4108        let base_len = u64::from_le_bytes(bytes[9..17].try_into().expect("8 bytes")) as usize;
4109        let extra_len = u64::from_le_bytes(bytes[17..25].try_into().expect("8 bytes")) as usize;
4110        if w != oid_len {
4111            return Ok(None);
4112        }
4113        let Some(ipc_at) = REACH_CACHE_HEADER.checked_add(base_len).and_then(|a| a.checked_add(extra_len)) else {
4114            return Ok(None);
4115        };
4116        if ipc_at > bytes.len() {
4117            return Ok(None);
4118        }
4119        let base = &bytes[REACH_CACHE_HEADER..REACH_CACHE_HEADER + base_len];
4120        let extra = &bytes[REACH_CACHE_HEADER + base_len..ipc_at];
4121        let Some(ordinals) = crate::reach::OrdinalTable::from_base_and_extra(base.to_vec(), extra.to_vec(), oid_len) else {
4122            return Ok(None);
4123        };
4124        match crate::reach::decode_live_table(&bytes[ipc_at..], ordinals.len() as u32) {
4125            Ok(table) if !table.is_empty() => Ok(Some((ordinals, table))),
4126            Ok(_) => Ok(None),
4127            Err(e) => {
4128                tracing::warn!(store = %self.label, "objects.reach is unreadable, rebuilding: {e:#}");
4129                Ok(None)
4130            }
4131        }
4132    }
4133
4134    /// Write the live table and its space durably: encode, write a temp file,
4135    /// fsync it, then rename over the cache — the rename is the atomic publish.
4136    fn persist_reach(&self, ordinals: &crate::reach::OrdinalTable, table: &crate::reach::ReachTable) -> Result<()> {
4137        use std::io::Write as _;
4138        let ipc = crate::reach::encode_live_table(table)?;
4139        let (base, extra) = (ordinals.base_raw(), ordinals.extra_raw());
4140        let mut out = Vec::with_capacity(REACH_CACHE_HEADER + base.len() + extra.len() + ipc.len());
4141        out.extend_from_slice(REACH_CACHE_MAGIC);
4142        out.push(1);
4143        out.extend_from_slice(&(ordinals.oid_len() as u32).to_le_bytes());
4144        out.extend_from_slice(&(base.len() as u64).to_le_bytes());
4145        out.extend_from_slice(&(extra.len() as u64).to_le_bytes());
4146        out.extend_from_slice(base);
4147        out.extend_from_slice(extra);
4148        out.extend_from_slice(&ipc);
4149        let path = self.reach_cache_path();
4150        let tmp = path.with_extension("reach.tmp");
4151        {
4152            let mut f = File::create(&tmp).with_context(|| format!("creating {}", tmp.display()))?;
4153            f.write_all(&out).with_context(|| format!("writing {}", tmp.display()))?;
4154            f.sync_all().with_context(|| format!("fsync {}", tmp.display()))?;
4155        }
4156        std::fs::rename(&tmp, &path).with_context(|| format!("publishing {}", path.display()))?;
4157        Ok(())
4158    }
4159    /// Write the folded graph and its token durably: encode, write a temp file,
4160    /// fsync it, then rename over the cache — the rename is the atomic publish,
4161    /// so a reader never sees a half-written graph.
4162    fn persist_graph(&self, token: &[u8; 32], nodes: &[CommitNode]) -> Result<()> {
4163        use std::io::Write as _;
4164        let ipc = crate::graph::encode_graph(nodes)?;
4165        let mut out = Vec::with_capacity(GRAPH_CACHE_HEADER + ipc.len());
4166        out.extend_from_slice(GRAPH_CACHE_MAGIC);
4167        out.push(1);
4168        out.extend_from_slice(token);
4169        out.extend_from_slice(&ipc);
4170
4171        let path = self.graph_cache_path();
4172        let tmp = path.with_extension("graph.tmp");
4173        {
4174            let mut f = File::create(&tmp)
4175                .with_context(|| format!("creating {}", tmp.display()))?;
4176            f.write_all(&out)
4177                .with_context(|| format!("writing {}", tmp.display()))?;
4178            f.sync_all()
4179                .with_context(|| format!("fsync {}", tmp.display()))?;
4180        }
4181        std::fs::rename(&tmp, &path)
4182            .with_context(|| format!("publishing {}", path.display()))?;
4183        Ok(())
4184    }
4185
4186    /// `(graph_read_from_disk, graph_recomputed)` — how many folds since open
4187    /// read the persisted graph vs recomputed it. The only thing that can prove
4188    /// the persisted path ran; see
4189    /// [`tests::a_reopen_reads_the_persisted_graph_it_does_not_recompute`].
4190    fn graph_source_stats(&self) -> (u64, u64) {
4191        (
4192            self.graph_read.load(std::sync::atomic::Ordering::Relaxed),
4193            self.graph_recomputed
4194                .load(std::sync::atomic::Ordering::Relaxed),
4195        )
4196    }
4197
4198    /// `(folded_rows, tail_rows)` of the ordinal space the last fold built — how
4199    /// many oids came straight off the persisted index's oid column and how many
4200    /// off a scan of the redb tail. The only thing that can prove the space was
4201    /// not a scan (LAW 2), because both sources yield identical bytes; see
4202    /// [`tests::the_ordinal_space_comes_off_the_index_not_a_scan`].
4203    fn ordinal_source_stats(&self) -> (u64, u64) {
4204        (
4205            self.ordinal_folded.load(std::sync::atomic::Ordering::Relaxed),
4206            self.ordinal_tail.load(std::sync::atomic::Ordering::Relaxed),
4207        )
4208    }
4209
4210    /// The table, built on first use after a fold that could not carry one
4211    /// (the first fold, a gc) and kept across every fold after that.
4212    fn reach_bitmaps(&self) -> Result<Arc<crate::reach::ReachTable>> {
4213        self.reach_bitmaps_with(live_reach_policy(), true)
4214    }
4215
4216    /// [`Absorber::reach_bitmaps`] with the policy **named** and the cache
4217    /// optional. The table alone; [`Absorber::reach_table_with`] is the one
4218    /// the negotiation calls, because it needs the row index too.
4219    fn reach_bitmaps_with(
4220        &self,
4221        policy: crate::reach::ReachPolicy,
4222        cache: bool,
4223    ) -> Result<Arc<crate::reach::ReachTable>> {
4224        Ok(self.reach_table_with(policy, cache)?.0)
4225    }
4226
4227    /// **The table and its row index, as one pair that is always in step.**
4228    ///
4229    /// `cache` is false for the differential guard, which builds the table at
4230    /// two very different caps over one store and requires the two to answer
4231    /// identically; letting either poison `d.reach` would make the second arm
4232    /// read the first one's table and the comparison would be of a thing
4233    /// against itself.
4234    fn reach_table_with(
4235        &self,
4236        policy: crate::reach::ReachPolicy,
4237        cache: bool,
4238    ) -> Result<(Arc<crate::reach::ReachTable>, Arc<Vec<u32>>)> {
4239        {
4240            let d = self
4241                .derived
4242                .read()
4243                .map_err(|_| anyhow!("derived poisoned"))?;
4244            if cache && !d.reach.is_empty() {
4245                // Two refcount bumps, nothing copied.
4246                return Ok((Arc::clone(&d.reach), Arc::clone(&d.reach_by_row)));
4247            }
4248            if d.graph.is_empty() {
4249                return Ok((Arc::default(), Arc::default()));
4250            }
4251        }
4252        let mut d = self
4253            .derived
4254            .write()
4255            .map_err(|_| anyhow!("derived poisoned"))?;
4256        // Built before the facts so it outlives them, and deliberately NOT
4257        // holding the `derived` guard: `Absorber::resolved` does not take that
4258        // lock, which is what makes a live tree lookup legal from inside this
4259        // write section at all.
4260        let trees = self.tree_source_for_build(d.ordinals.len());
4261        let oid_len = self.hash.oid_len();
4262        let facts = crate::reach::ObjectFacts {
4263            ordinal: d.ordinals.view(),
4264            trees: &trees,
4265            oid_len,
4266        };
4267        // The build reads (nearly) every tree in the repository once, and the
4268        // lazy exploded cache writes each one back for the next reader.
4269        // MEASURED on git.git (dwarf, 330 535 tree reads): suppressing the
4270        // write-back changed nothing (27.1 s of reads against 25.2 s with it,
4271        // noise on a shared box); the cost is the delta chain each tree is
4272        // inflated out of, not the cache. So the cache is kept warm — the
4273        // bounded walks a later fetch makes read trees through it.
4274        let started = std::time::Instant::now();
4275        let built = crate::reach::build_reach_table(&d.ord_graph, &facts, policy);
4276        let by_row = built.by_row(&d.ord_graph);
4277        self.reach_rebuilt
4278            .fetch_add(1, std::sync::atomic::Ordering::Relaxed);
4279        let chains = trees.chain_stats();
4280        tracing::info!(
4281            store = %self.label,
4282            entries = built.len(),
4283            commits = d.graph.len(),
4284            objects = d.ordinals.len(),
4285            elapsed_ms = started.elapsed().as_millis() as u64,
4286            chain_hits = chains.map(|c| c.0).unwrap_or(0),
4287            chain_misses = chains.map(|c| c.1).unwrap_or(0),
4288            chain_bytes = chains.map(|c| c.2).unwrap_or(0),
4289            cache,
4290            "built the reachability table from scratch"
4291        );
4292        if std::env::var_os(crate::arms::ENV_REACH_TIMING).is_some() {
4293            eprintln!("reach build chain memo: {chains:?} (hits, misses, bytes)");
4294        }
4295        let built = Arc::new(built);
4296        let by_row = Arc::new(by_row);
4297        if cache {
4298            d.reach = Arc::clone(&built);
4299            d.reach_by_row = Arc::clone(&by_row);
4300            // A full build is always worth writing down: it is the one cost a
4301            // restart would otherwise pay again.
4302            self.persist_reach_locked(&d);
4303        }
4304        Ok((built, by_row))
4305    }
4306    // `ordinal_space()` lived here: `d.oids.clone()`, a fresh `Vec<String>` of
4307    // every oid in the store, handed to `reachable_oids` twice per request. It
4308    // is gone, and so is `d.oids` itself (S-082): the serve path borrows
4309    // `d.oids_raw` as an `OrdinalSpace` under the read guard it was already
4310    // going to take, and reads oid ⇄ ordinal straight off it.
4311
4312    /// `pread` an extent out of the verbatim archive, **into uninitialised
4313    /// capacity** — no zero-fill before the read.
4314    ///
4315    /// This used to be `vec![0u8; len]` + `read_exact_at`, and under emit
4316    /// concurrency the zeroing was not a detail: profiled on oden 2026-08-12
4317    /// (gunnar serving 32 concurrent clones, perf on the server pid), ~44 % of
4318    /// serve CPU was memory zeroing/copying — `memset` 18.1 % plus kernel
4319    /// page-zeroing 7.8 % — against ~12 % for one clone, because 32 threads
4320    /// churning pack-scale buffers recycle mimalloc freelist blocks that must
4321    /// each be memset before `pread` immediately overwrites every byte.
4322    ///
4323    /// Soundness: no reference to uninitialised memory is ever formed. The
4324    /// bytes are written through a raw pointer into the `Vec`'s spare
4325    /// capacity, `EINTR` retries, a short read refuses, and `set_len` runs
4326    /// only after every one of `len` bytes has been written.
4327    fn read_extent(&self, offset: u64, len: u64) -> Result<Vec<u8>> {
4328        use std::os::fd::AsRawFd;
4329        let want = usize::try_from(len).context("extent length overflows usize")?;
4330        let mut buf: Vec<u8> = Vec::with_capacity(want);
4331        let fd = self.reader.as_raw_fd();
4332        let mut filled = 0usize;
4333        while filled < want {
4334            let n = unsafe {
4335                libc::pread(
4336                    fd,
4337                    buf.as_mut_ptr().add(filled).cast(),
4338                    want - filled,
4339                    i64::try_from(offset + filled as u64).context("extent offset overflows off_t")?,
4340                )
4341            };
4342            if n < 0 {
4343                let err = std::io::Error::last_os_error();
4344                if err.kind() == std::io::ErrorKind::Interrupted {
4345                    continue;
4346                }
4347                return Err(err).with_context(|| {
4348                    format!("reading ({offset}, {len}) out of {}", self.blobs.display())
4349                });
4350            }
4351            if n == 0 {
4352                bail!(
4353                    "short read at ({offset}, {len}) out of {}: {filled} of {want} bytes before \
4354                     EOF — the archive is truncated relative to its index",
4355                    self.blobs.display()
4356                );
4357            }
4358            filled += n as usize;
4359        }
4360        // Every byte of `want` is now initialised.
4361        unsafe { buf.set_len(want) };
4362        Ok(buf)
4363    }
4364}
4365
4366/// **The drain's object-level ingress**, and the reason a push ends in object
4367/// rows without anybody reading first.
4368///
4369/// The account indexer holds this as an `Arc<dyn ObjectAbsorb>` and calls it once
4370/// per drained job, on its own thread, after the ack. It is the *same* absorb a
4371/// falling-back read takes, gate and all (LAW 5): there is no background copy of
4372/// this logic to drift.
4373impl<S: ObjectIndex> ObjectAbsorb for Absorber<S> {
4374    fn absorb(&self, job: IndexJob) -> Result<()> {
4375        // **The memory watchdog, BEFORE the pack and BEFORE the gate**
4376        // ([`crate::memguard`]). Inside the pack the resolver checks again
4377        // every few thousand objects; this is the check that keeps a burst of
4378        // packs from starting one more absorb on a box that is already short.
4379        // Taken before the gate on purpose: a paused worker holds nothing —
4380        // not the gate, not a row, not a base — so a reader that wants to
4381        // absorb for itself can, and every other reader scans the pack.
4382        if self.cancel.load(std::sync::atomic::Ordering::Relaxed) {
4383            return Err(crate::resolve::ResolveError::cancelled());
4384        }
4385        let dog = self.watchdog();
4386        if dog.breached().is_some() {
4387            self.progress.begin(job.pack_id, job.len, false);
4388            self.progress.set_phase(crate::progress::Phase::Paused);
4389            self.progress.add_pause();
4390            let r = dog.pause_until_ok(&self.label, Some(&self.cancel), &mut || Ok(self.spill()));
4391            self.progress.finish();
4392            let paused = r?;
4393            // The pause before the pack has the same rule as the one inside it:
4394            // a give-up is not a resume. Starting an 8 GiB pack on a box that
4395            // just told us it has nothing left is how the parked hours began.
4396            if paused.end.gave_up() {
4397                return Err(crate::resolve::ResolveError::out_of_memory(
4398                    paused.end.as_str(),
4399                    paused.available,
4400                    paused.budget,
4401                    0,
4402                    0,
4403                ));
4404            }
4405        }
4406        let _gate = self
4407            .gate
4408            .lock()
4409            .map_err(|_| anyhow!("absorb gate poisoned"))?;
4410        self.absorb_gated(&PendingPack::from_job(job))
4411    }
4412}
4413
4414impl<S: ObjectIndex + 'static> GitStore<S> {
4415    /// The push path, for the two `put` halves.
4416    pub(crate) fn push_path(&self) -> &PushPath {
4417        &self.push
4418    }
4419
4420    pub(crate) fn account(&self) -> &str {
4421        &self.account
4422    }
4423
4424    pub(crate) fn ref_log(&self) -> &RefLog {
4425        &self.refs
4426    }
4427
4428    pub(crate) fn ref_gate(&self) -> &Mutex<()> {
4429        &self.ref_gate
4430    }
4431
4432    /// The closure check's index half: a `REF_DELTA`'s base has to exist —
4433    /// **in the store, or in this very pack**.
4434    ///
4435    /// This is the one part of receive-pack that reads `objects.oid` (§13's
4436    /// table), and on the path a real push takes it reads nothing else.
4437    ///
4438    /// # The second half of that sentence used to be missing, and it refused
4439    /// packs git itself writes
4440    ///
4441    /// [`crate::pack_walk::PackWalk::closure`] cannot do better on its own:
4442    /// a walk reports what the bytes say, and the bytes of a `REF_DELTA` name a
4443    /// base by **oid**, which is a fact about resolved content that no walk can
4444    /// know. So every ref base came back on `external_refs` and every one of
4445    /// them was required to be in the store already.
4446    ///
4447    /// A `REF_DELTA` naming a base *inside the same pack* is ordinary and git
4448    /// writes it constantly: `git index-pack --fix-thin` completes a pushed thin
4449    /// pack by **appending the base object to the pack** and leaving the delta
4450    /// naming it by oid. Every such pack was refused with *"this pack deltas
4451    /// against X, which this repository does not have"*, on a store that was
4452    /// being handed a perfectly ordinary, self-contained packfile — the base was
4453    /// entry 1 of 25 in the pack's own `.idx` (`gunnar.multi_pack_serve`,
4454    /// 2026-08-14). The same missing check is `S-003` / gitoxide#2882 in
4455    /// `LookupRefDeltaObjectsIter`; it is the same defect wearing the receiving
4456    /// hat instead of the sending one.
4457    ///
4458    /// # What it costs, and where
4459    ///
4460    /// **Nothing on any push that was going to succeed before.** Every base
4461    /// found in the store short-circuits exactly as it did, and a pack with no
4462    /// ref-delta at all never gets past the first loop.
4463    ///
4464    /// The pack is resolved only when the alternative is *refusing it*, and then
4465    /// the resolve is the cheapest honest answer available: an entry's oid is
4466    /// knowable only by applying its delta chain, which is precisely what
4467    /// [`crate::resolve::resolve_walked`] does — the same resolver the absorb is
4468    /// about to run over the same pack anyway, reused rather than twinned
4469    /// (LAW 5). A push that is genuinely thin against a base nobody has still
4470    /// fails, one resolve later, and still names the oid.
4471    pub(crate) fn external_bases_exist(&self, bytes: &[u8], w: &PackWalk) -> Result<()> {
4472        let c = w.closure();
4473        if !c.broken_offsets.is_empty() {
4474            bail!(
4475                "this pack is corrupt: {} delta base offset(s) do not land on an entry — first {}",
4476                c.broken_offsets.len(),
4477                c.broken_offsets[0]
4478            );
4479        }
4480        // The fast path, unchanged: a base the store already holds is settled
4481        // without reading one byte of the pack.
4482        let mut unheld: Vec<&[u8]> = Vec::new();
4483        for oid in &c.external_refs {
4484            if self.lookup_one(oid)?.is_none() {
4485                unheld.push(oid.as_slice());
4486            }
4487        }
4488        if unheld.is_empty() {
4489            return Ok(());
4490        }
4491
4492        // Only now, and only because the alternative is refusing the push: does
4493        // the pack supply these itself? `resolve_walked` answers with the
4494        // store behind it, so a base that really is external is still found the
4495        // cheap way and only a genuinely absent one fails.
4496        let resolved = crate::resolve::resolve_walked(
4497            bytes,
4498            w,
4499            self.hash_kind(),
4500            0,
4501            &*self.absorber,
4502            &crate::exploded::NoSink,
4503        )
4504        .with_context(|| {
4505            format!(
4506                "this pack deltas against {} object(s) this repository does not have, so it was \
4507                 resolved to find out whether the pack carries them itself — first {}",
4508                unheld.len(),
4509                hex::encode(unheld[0])
4510            )
4511        })?;
4512        let in_pack: std::collections::HashSet<&[u8]> =
4513            resolved.iter().map(|r| r.oid.as_slice()).collect();
4514        for oid in unheld {
4515            if !in_pack.contains(oid) {
4516                bail!(
4517                    "this pack deltas against {}, which this repository does not have and which \
4518                     the pack does not carry either — the push is refused rather than stored with \
4519                     a dangling base",
4520                    hex::encode(oid)
4521                );
4522            }
4523        }
4524        Ok(())
4525    }
4526
4527    /// One oid, on the **serial** path. See [`lookup_path`].
4528    pub(crate) fn lookup_one(&self, oid: Oid<'_>) -> Result<Option<crate::index_layout::IndexRow>> {
4529        // **Never waits on the indexer.** The rows the worker has landed so far
4530        // are in the index; an oid it has not reached is resolved from the
4531        // pending pack on this thread (`Absorber::scan_pending`).
4532        self.absorber.lookup_never_wait(oid)
4533    }
4534
4535    /// Many oids, on the **batch** path, never waiting on the indexer.
4536    pub(crate) fn lookup_batch_never_wait(
4537        &self,
4538        oids: &[Oid<'_>],
4539    ) -> Result<Vec<Option<crate::index_layout::IndexRow>>> {
4540        self.absorber.lookup_batch_never_wait(oids)
4541    }
4542
4543    /// Absorb the pending packs on this thread **if the gate is free**;
4544    /// `None` = the worker holds it and this caller did not wait. See
4545    /// `Absorber::try_absorb_pending`.
4546    pub fn try_absorb_pending(&self) -> Result<Option<usize>> {
4547        self.absorber.try_absorb_pending()
4548    }
4549
4550    /// The named refusal for a request that needs the whole derived graph
4551    /// while a pack is still being indexed: `reachable` cannot be answered
4552    /// from a graph that does not hold the pack's commits yet, and waiting for
4553    /// the worker is forbidden. The message carries the progress row's
4554    /// numbers so the client knows when to come back.
4555    fn index_in_progress(&self) -> anyhow::Error {
4556        let p = self.index_progress();
4557        anyhow!(
4558            "index in progress for this repository: pack {} {}% ({}/{} objects, {}) — reachability \
4559             needs the whole graph; retry when the index row reaches 100 %",
4560            p.pack_id,
4561            p.percent(),
4562            p.objects_done,
4563            p.objects_total,
4564            p.phase.as_str()
4565        )
4566    }
4567
4568    /// The current ref namespace, as the log folds to it. The whole-snapshot
4569    /// accessor; [`ref_get`](Self::ref_get) is the keyed one.
4570    pub(crate) fn ref_state(&self) -> Result<BTreeMap<String, crate::refs::RefState>> {
4571        self.refs.current()
4572    }
4573
4574    /// One ref by name, O(log r), without cloning the namespace — for `head`
4575    /// and a single-ref CAS. See [`crate::refs::RefLog::get`].
4576    pub(crate) fn ref_get(&self, name: &str) -> Result<Option<crate::refs::RefState>> {
4577        self.refs.get(name)
4578    }
4579
4580    /// Reachability over the graph, as roaring bitmaps, in **this store's**
4581    /// ordinal space.
4582    ///
4583    /// Returns `(want ∪ closure) − (have ∪ closure)` as oid hex. Every object —
4584    /// commit, tree and blob — is in the bitmaps, because
4585    /// [`crate::reach::build_reach`] walks the trees; that is why this can answer
4586    /// with objects rather than only with commits.
4587    ///
4588    /// **Hex is for the maintenance path, not the serving one.** The answer is
4589    /// computed in raw bytes by [`GitStore::reachable_raw_with`] and encoded
4590    /// here, at one `String` per object; every caller that serves a request asks
4591    /// for the raw form instead. See [`Derived::oids_raw`] for what that cost.
4592    pub(crate) fn reachable_oids(&self, want: &[Oid<'_>], have: &[Oid<'_>]) -> Result<Vec<String>> {
4593        Ok(self
4594            .reachable_raw_with(want, have, live_reach_policy(), true)?
4595            .iter()
4596            .map(hex::encode)
4597            .collect())
4598    }
4599
4600    /// [`GitStore::reachable_oids`] with the bitmap policy **named** and the
4601    /// cache optional.
4602    ///
4603    /// One body, not two (LAW 5): both are [`GitStore::reachable_raw_with`], so
4604    /// the guarded path and the shipped path are the same code.
4605    #[cfg(test)]
4606    pub(crate) fn reachable_oids_with(
4607        &self,
4608        want: &[Oid<'_>],
4609        have: &[Oid<'_>],
4610        policy: crate::reach::ReachPolicy,
4611        cache: bool,
4612    ) -> Result<Vec<String>> {
4613        Ok(self
4614            .reachable_raw_with(want, have, policy, cache)?
4615            .iter()
4616            .map(hex::encode)
4617            .collect())
4618    }
4619
4620    /// `(want ∪ closure) − (have ∪ closure)`, in **raw oid bytes**, in one
4621    /// allocation.
4622    ///
4623    /// The answer every serving caller wants and the one the bitmaps naturally
4624    /// produce: an ordinal indexes straight into [`Derived::oids_raw`], so
4625    /// nothing is encoded, decoded or allocated per object on the way out.
4626    pub(crate) fn reachable_raw(
4627        &self,
4628        want: &[Oid<'_>],
4629        have: &[Oid<'_>],
4630    ) -> Result<git_storage_trait::OidList> {
4631        self.reachable_raw_with(want, have, live_reach_policy(), true)
4632    }
4633
4634    /// [`GitStore::reachable_raw`] with the bitmap policy **named** and the
4635    /// cache optional.
4636    ///
4637    /// It exists because the answer is defined to be **independent of the
4638    /// policy** — [`crate::reach::accumulate`] covers whatever the table does
4639    /// not — and a property like that can only be tested by driving the policy.
4640    /// A test that could not reach it would be asserting that one code path
4641    /// equals itself. `cache: false` keeps one arm's table from being read by
4642    /// the next, which is the same trap in a different hat.
4643    pub(crate) fn reachable_raw_with(
4644        &self,
4645        want: &[Oid<'_>],
4646        have: &[Oid<'_>],
4647        policy: crate::reach::ReachPolicy,
4648        cache: bool,
4649    ) -> Result<git_storage_trait::OidList> {
4650        Ok(self
4651            .select_with(want, have, policy, cache, false)?
4652            .map(|s| s.objects)
4653            .unwrap_or_default())
4654    }
4655
4656    /// **`select`, in integers, under one read guard** — the whole answer
4657    /// [`crate::serve::GitServe::select`] hands back, computed once: `want −
4658    /// have` (raw, one allocation), the commits among them (a bitmap AND, not a
4659    /// hash probe per object) and the closure of `have` (which this already
4660    /// computed to subtract it — it used to be computed a second time to hand
4661    /// back as `client_has`).
4662    ///
4663    /// `require_commit_tips` is `select`'s refusal: a `want` that is not a
4664    /// commit row declines the whole request (`Ok(None)`) rather than
4665    /// under-sending. Without it (the `reachable` contract) a non-commit want
4666    /// contributes itself and what it peels to, and a want the store does not
4667    /// hold at all is an error.
4668    pub(crate) fn select_with(
4669        &self,
4670        want: &[Oid<'_>],
4671        have: &[Oid<'_>],
4672        policy: crate::reach::ReachPolicy,
4673        cache: bool,
4674        require_commit_tips: bool,
4675    ) -> Result<Option<Selected>> {
4676        // The graph is folded by the absorb, so a pending pack has to be
4677        // absorbed before reachability can be right. If the gate is free this
4678        // thread does it; if the worker holds it — hours into a kernel pack,
4679        // or paused by the watchdog — this is refused by name, not waited on.
4680        if self.try_absorb_pending()?.is_none() {
4681            return Err(self.index_in_progress());
4682        }
4683        // `reach_table_with` may take the derived WRITE lock to build, so it
4684        // runs to completion before the read guard below is taken. Getting that
4685        // order wrong is a self-deadlock, not a slow path.
4686        let (table, by_row) = self.absorber.reach_table_with(policy, cache)?;
4687        // **One read guard, held across the whole answer, and nothing cloned
4688        // out of it.** Borrowing is not a lock held longer than the work: the
4689        // guard is a reader, folds take the writer, and a fold that lands
4690        // mid-answer would invalidate the rows this is translating.
4691        let d = self
4692            .absorber
4693            .derived
4694            .read()
4695            .map_err(|_| anyhow!("derived poisoned"))?;
4696        let space = d.ordinals.view();
4697        let oid_len = self.hash.oid_len();
4698        let graph: &crate::reach::OrdGraph = &d.ord_graph;
4699        let view = crate::reach::ReachView {
4700            table: &table,
4701            by_row: &by_row,
4702            graph,
4703        };
4704        let trees = self.absorber.tree_source();
4705        let facts = crate::reach::ObjectFacts {
4706            ordinal: space,
4707            trees: &trees,
4708            oid_len,
4709        };
4710
4711        if require_commit_tips {
4712            if graph.is_empty() {
4713                return Ok(None);
4714            }
4715            for oid in want {
4716                let Some(o) = space.ordinal_of_raw(oid) else { return Ok(None) };
4717                if !graph.is_commit(o) {
4718                    return Ok(None);
4719                }
4720            }
4721        }
4722
4723        let mut union = roaring::RoaringBitmap::new();
4724        // **The bitmapped wants first, in one pass, then the rest.** The union
4725        // is closed after every step, so a want whose commit is already in it
4726        // is answered by `accumulate`'s first check and walks nothing — and on
4727        // a clone of git.git, 1 006 wants, that is nearly every tag once the
4728        // branch tips are in. Union is commutative, so the order is free.
4729        let mut later: Vec<&[u8]> = Vec::new();
4730        for oid in want {
4731            if let Some(o) = space.ordinal_of_raw(oid) {
4732                if let Some(bm) = graph.row_of(o).and_then(|row| view.bitmap_of_row(row)) {
4733                    union |= bm;
4734                    continue;
4735                }
4736            }
4737            later.push(oid);
4738        }
4739        for oid in later {
4740            let Some(o) = space.ordinal_of_raw(oid) else {
4741                bail!(
4742                    "want {} is not in this repository — a negotiation must not be answered from a \
4743                     partial set",
4744                    hex::encode(oid)
4745                );
4746            };
4747            match graph.row_of(o) {
4748                // A commit: its whole closure, in one OR — or the bounded walk
4749                // down to the first commit that has one. A commit the graph
4750                // holds is always answerable; only a want the store does not
4751                // hold at all is refused, above.
4752                Some(row) => match view.bitmap_of_row(row) {
4753                    Some(bm) => union |= bm,
4754                    None => crate::reach::accumulate(row, &view, &facts, &mut union),
4755                },
4756                // Not a commit: a TAG or a blob asked for directly. It
4757                // contributes itself and — since 2026-08-31 — what it points
4758                // at: the bitmaps are built over the commit graph and no tree
4759                // points at a tag, so a tag is in nobody's closure and this is
4760                // the only place its target can enter. A tag object is only
4761                // ever reachable as a REF TIP, so peeling here is complete.
4762                None => {
4763                    union.insert(o);
4764                    peel_tag_into(self.absorber.as_ref(), o, &view, &facts, &mut union);
4765                }
4766            }
4767        }
4768        let mut had = roaring::RoaringBitmap::new();
4769        let mut later: Vec<&[u8]> = Vec::new();
4770        for oid in have {
4771            if let Some(o) = space.ordinal_of_raw(oid) {
4772                if let Some(bm) = graph.row_of(o).and_then(|row| view.bitmap_of_row(row)) {
4773                    had |= bm;
4774                    continue;
4775                }
4776            }
4777            later.push(oid);
4778        }
4779        for oid in later {
4780            // An unknown `have` is normal: the client may have objects we do
4781            // not. It contributes nothing, which is the safe direction — we
4782            // send more, never less.
4783            let Some(o) = space.ordinal_of_raw(oid) else { continue };
4784            match graph.row_of(o) {
4785                // The same walk on the exclude side, and it must be the same
4786                // walk: an under-counted `have` over-sends (harmless, wasteful)
4787                // but an under-counted `want` under-sends, and answering the
4788                // two sides by different rules is how a `want − have` stops
4789                // being a subtraction of like for like.
4790                Some(row) => match view.bitmap_of_row(row) {
4791                    Some(bm) => had |= bm,
4792                    None => crate::reach::accumulate(row, &view, &facts, &mut had),
4793                },
4794                None => {
4795                    had.insert(o);
4796                }
4797            }
4798        }
4799
4800        let delta = &union - &had;
4801        let commits = &delta & graph.commits();
4802        // One allocation per list, sized before the loop. The ordinal space is
4803        // a flat buffer, so each object is a `copy_from_slice` of `oid_len`
4804        // bytes into it and nothing else.
4805        let to_list = |bm: &roaring::RoaringBitmap| -> Result<git_storage_trait::OidList> {
4806            let mut out = git_storage_trait::OidList::with_capacity(bm.len() as usize, oid_len);
4807            for o in bm {
4808                let raw = space
4809                    .oid(o)
4810                    .ok_or_else(|| anyhow!("ordinal {o} is outside this store's ordinal space"))?;
4811                out.push(raw)?;
4812            }
4813            Ok(out)
4814        };
4815        let objects = to_list(&delta)?;
4816        // The trait's `ReachSet::commits` is a `Vec<Vec<u8>>`; one allocation
4817        // per selected commit, never per object.
4818        let commits: Vec<Vec<u8>> = commits
4819            .iter()
4820            .map(|o| space.oid(o).map(<[u8]>::to_vec).ok_or_else(|| anyhow!("ordinal {o} is outside this store's ordinal space")))
4821            .collect::<Result<_>>()?;
4822        // What the client held BEFORE this transfer: the closure of `have`, and
4823        // only it. Empty for a clone, which is the request with no excludes at
4824        // all and therefore the one that pays nothing for this.
4825        let client_has = if have.is_empty() { git_storage_trait::OidList::new() } else { to_list(&had)? };
4826        Ok(Some(Selected {
4827            objects,
4828            commits,
4829            client_has,
4830        }))
4831    }
4832
4833}
4834
4835/// What [`GitStore::select_with`] answers: the three lists of
4836/// [`git_storage_trait::ReachSet`], with `objects` still in one allocation.
4837pub(crate) struct Selected {
4838    pub objects: git_storage_trait::OidList,
4839    pub commits: Vec<Vec<u8>>,
4840    pub client_has: git_storage_trait::OidList,
4841}
4842
4843impl<S: ObjectIndex + 'static> GitStore<S> {
4844    /// Every object reachable from every ref: what a GC must keep.
4845    pub(crate) fn live_set(&self) -> Result<std::collections::HashSet<String>> {
4846        let refs = self.ref_state()?;
4847        let tips: Vec<Vec<u8>> = refs
4848            .values()
4849            .filter_map(|s| s.target.as_deref())
4850            .filter_map(|t| hex::decode(t).ok())
4851            .collect();
4852        if tips.is_empty() {
4853            bail!(
4854                "this repository has no ref pointing at an object, so every object in it would be \
4855                 dead. A GC that would delete everything is refused: name a ref first"
4856            );
4857        }
4858        let borrowed: Vec<Oid<'_>> = tips.iter().map(|t| t.as_slice()).collect();
4859        let mut live: std::collections::HashSet<String> =
4860            self.reachable_oids(&borrowed, &[])?.into_iter().collect();
4861        // The peeled targets of annotated tags are reachable too, and a tag
4862        // object is not a commit so it has no bitmap of its own.
4863        for s in refs.values() {
4864            if let Some(p) = &s.peeled {
4865                live.insert(p.clone());
4866            }
4867            if let Some(t) = &s.target {
4868                live.insert(t.clone());
4869            }
4870        }
4871        Ok(live)
4872    }
4873
4874    /// Drop every row the live set does not name. The index is append-only for
4875    /// everything except this.
4876    ///
4877    /// **Both tables, in one call.** §14's exploded table is retired with the
4878    /// `objects` table because its row count against that one's is what says
4879    /// whether it is whole ([`Absorber::adopt_journal`]): dropping from one and
4880    /// not the other would leave every later open re-exploding the entire
4881    /// repository. The count returned is still the index's — that is what a
4882    /// [`GcReport`] means by a dropped row.
4883    /// Drop exactly the rows in `dead` — a set the GC computed as "seen at its
4884    /// start and not reachable", never "not in `live`". The distinction is a
4885    /// row that arrived after the GC took its snapshot: it is in neither set,
4886    /// and the predicate below keeps it. See [`dead_oids`].
4887    pub(crate) fn drop_dead_rows(&self, dead: &std::collections::HashSet<Vec<u8>>) -> Result<u64> {
4888        let dropped = self
4889            .absorber
4890            .objects
4891            .retain(&|oid: &[u8]| !dead.contains(oid))?;
4892        self.absorber
4893            .exploded
4894            .retain(&|oid: &[u8]| !dead.contains(oid))?;
4895        // **Everything folded from those two tables, refolded.** The commit
4896        // graph, the tree payloads, the ordinal space and the bitmaps are all
4897        // derivations of the rows that just went, and a derivation that still
4898        // names a dropped oid is *wrong* rather than merely stale — a `reachable`
4899        // over a graph holding dead commits selects objects the index can no
4900        // longer serve. This is the same [`Absorber::refold`] every absorb and
4901        // every open already calls, over the table this call just changed;
4902        // nothing about how the graph is rebuilt is touched here.
4903        //
4904        // The bitmaps go with it: they address **ordinals**, and dropping rows
4905        // renumbers the ordinal space, so `refold` clears them and the next
4906        // `reach_bitmaps()` builds them over the new numbering. Carrying them
4907        // across would be carrying an index into a different array.
4908        self.absorber.refold()?;
4909        Ok(dropped)
4910    }
4911
4912    /// **The journal's half of a GC: retire every pack whose objects are now all
4913    /// dead, before a single row is dropped.**
4914    ///
4915    /// Returns the offsets retired.
4916    ///
4917    /// # Why this exists
4918    ///
4919    /// §13.12's `indexed` bit is derived on open as *extent in the journal, rows
4920    /// not in the index* ([`Absorber::adopt_journal`]). Dropping every row of a
4921    /// pack produces that state exactly, so without this call the next open
4922    /// re-queues the pack and re-absorbs the objects a GC just decided were dead.
4923    /// A **partly** dead pack keeps rows and was never affected; this is only
4924    /// about the all-dead case.
4925    ///
4926    /// # What it does not do
4927    ///
4928    /// It does not truncate `objects.pack`. The blob file is append-only and a
4929    /// pack in the middle of it cannot be cut out without moving every extent
4930    /// after it — which would invalidate every index row in the archive. The dead
4931    /// pack's bytes stay; what changes is that nothing will ever index them
4932    /// again. Reclaiming those bytes is a rewrite of the blob file, and it is not
4933    /// this function.
4934    ///
4935    /// An arm with no journal ([`FastWriter`](crate::archive_write::FastWriter))
4936    /// has nothing to retire and nothing that re-queues, so it returns empty.
4937    ///
4938    /// # Cost
4939    ///
4940    /// One [`ObjectReadStack::extents_with_rows`] scan plus one batch lookup of
4941    /// the live set. Both are already the shape a GC pays elsewhere, and both run
4942    /// once per `gc()`, not per pack.
4943    /// Where the journal's acked extents end right now — the GC's snapshot of
4944    /// "packs that existed when I started". A pack acked past this point during
4945    /// the GC belongs to a push in flight and is not the GC's to judge.
4946    pub(crate) fn acked_end(&self) -> Result<u64> {
4947        let Some(journal) = self.arms.writer.journal(&self.blobs) else {
4948            return Ok(u64::MAX);
4949        };
4950        if !journal.exists() {
4951            return Ok(0);
4952        }
4953        let rows = crate::archive_write::read_journal(&journal)?;
4954        Ok(crate::archive_write::acked_packs(&rows)
4955            .iter()
4956            .map(|(o, l)| o + l)
4957            .max()
4958            .unwrap_or(0))
4959    }
4960
4961    /// Tombstone every acked pack that holds no live object — among the packs
4962    /// whose extent ends at or before `acked_end`, the GC's snapshot from
4963    /// [`acked_end`](Self::acked_end). A pack pushed after that snapshot has
4964    /// objects `live` never saw, and without the bound it would be retired for
4965    /// being unknown, which is how a GC would delete a push in flight.
4966    pub(crate) fn retire_dead_packs(
4967        &self,
4968        live: &std::collections::HashSet<String>,
4969        acked_end: u64,
4970    ) -> Result<Vec<u64>> {
4971        let Some(journal) = self.arms.writer.journal(&self.blobs) else {
4972            return Ok(Vec::new());
4973        };
4974        if !journal.exists() {
4975            return Ok(Vec::new());
4976        }
4977        let rows = crate::archive_write::read_journal(&journal)?;
4978        let packs: Vec<(u64, u64)> = crate::archive_write::acked_packs(&rows)
4979            .into_iter()
4980            .filter(|(o, l)| o + l <= acked_end)
4981            .collect();
4982        let already = crate::archive_write::retired_offsets(&rows);
4983        if packs.is_empty() {
4984            return Ok(Vec::new());
4985        }
4986
4987        // Which packs hold any row at all right now. A pack with none is either
4988        // already retired or was never absorbed — neither is this call's
4989        // business, and calling the second one dead would lose it.
4990        let occupied = self.absorber.objects.extents_with_rows(&packs)?;
4991
4992        // Which packs hold a row that survives. Placed by binary search over the
4993        // pack starts, the same way the scan above places a row.
4994        let mut order: Vec<usize> = (0..packs.len()).filter(|&i| packs[i].1 > 0).collect();
4995        order.sort_unstable_by_key(|&i| packs[i].0);
4996        let starts: Vec<u64> = order.iter().map(|&i| packs[i].0).collect();
4997        let live_oids: Vec<Vec<u8>> = live.iter().filter_map(|h| hex::decode(h).ok()).collect();
4998        let borrowed: Vec<&[u8]> = live_oids.iter().map(|o| o.as_slice()).collect();
4999        let mut has_live = vec![false; packs.len()];
5000        for (offset, _) in self
5001            .absorber
5002            .objects
5003            .extents_batch(&borrowed)
5004            .into_iter()
5005            .flatten()
5006        {
5007            let p = starts.partition_point(|&s| s <= offset);
5008            if p == 0 {
5009                continue;
5010            }
5011            let i = order[p - 1];
5012            if offset < packs[i].0 + packs[i].1 {
5013                has_live[i] = true;
5014            }
5015        }
5016
5017        let dead: Vec<u64> = (0..packs.len())
5018            .filter(|&i| occupied[i] && !has_live[i] && !already.contains(&packs[i].0))
5019            .map(|i| packs[i].0)
5020            .collect();
5021        // Durable before the rows go. The one ordering this function has.
5022        crate::archive_write::retire_packs(&journal, &dead)?;
5023        Ok(dead)
5024    }
5025
5026    /// **Write generation 0** at [`archive_path`](Self::archive_path), carrying
5027    /// the verbatim packs this store has acked plus `reserved`.
5028    ///
5029    /// The whole of the decision-making lives in
5030    /// [`seal_generation_zero`](crate::archive_write::seal_generation_zero); this
5031    /// is the three paths it needs, taken off the same fields the push path and
5032    /// the GC read, so a seal cannot address a different blob file or a different
5033    /// journal from the one that acked the packs.
5034    pub(crate) fn seal_archive(
5035        &self,
5036        reserved: Vec<ReservedSection>,
5037    ) -> Result<crate::archive_write::SealReport> {
5038        crate::archive_write::seal_generation_zero(
5039            &self.blobs,
5040            self.arms.writer.journal(&self.blobs).as_deref(),
5041            &self.archive,
5042            reserved,
5043        )
5044    }
5045
5046    /// The sections a sealed archive carries: the ref log, the commit graph and
5047    /// the bitmaps.
5048    ///
5049    /// The sealed archive numbers its objects in **sorted** order, the live
5050    /// table in the store's append-only order, so the table is renumbered once
5051    /// here through one remap table (one lookup per object, one index per bit)
5052    /// — the one place the two spaces meet.
5053    pub(crate) fn reserved_sections(&self) -> Result<Vec<ReservedSection>> {
5054        use znippy_common::{GUNNAR_GRAPH_MODULE, GUNNAR_REACH_MODULE};
5055        let mut out = vec![self.refs.seal_section()?];
5056        // May take the derived WRITE lock to build: before the read guard.
5057        let _ = self.reach_bitmaps()?;
5058        let d = self
5059            .absorber
5060            .derived
5061            .read()
5062            .map_err(|_| anyhow!("derived poisoned"))?;
5063        if !d.graph.is_empty() {
5064            out.push(ReservedSection::arrow(
5065                GUNNAR_GRAPH_MODULE,
5066                crate::graph::graph_schema(),
5067                vec![crate::graph::build_graph_batch(&d.graph)?],
5068            ));
5069        }
5070        if !d.reach.is_empty() {
5071            let sorted = self.absorber.objects.oids_raw()?.raw;
5072            let oid_len = self.hash.oid_len();
5073            let target = crate::reach::OrdinalSpace::new(&sorted, oid_len);
5074            let remap = d.ordinals.remap_to(&target);
5075            if let Some(entries) = d.reach.to_entries(&target, Some(&remap)) {
5076                out.push(ReservedSection::arrow(
5077                    GUNNAR_REACH_MODULE,
5078                    crate::reach::reach_schema(),
5079                    vec![crate::reach::build_reach_batch(&entries)?],
5080                ));
5081            } else {
5082                tracing::warn!(
5083                    store = %self.absorber.label,
5084                    "seal: the live reachability table names an object the sorted space lacks; \
5085                     no __gunnar_reach__ section is written"
5086                );
5087            }
5088        }
5089        Ok(out)
5090    }
5091}
5092
5093// ── the runtime selector ──────────────────────────────────────────────────────
5094
5095/// **A [`GitStore`] whose index arm was chosen at run time.**
5096///
5097/// The [`ObjectIndex`] arm is a *type*, so a value can only choose it by naming
5098/// every monomorphisation. This enum is that list, and it is an enum rather than
5099/// a `Box<dyn GitOps>` for two reasons:
5100///
5101/// * a boxed trait object can only offer the twelve, and the arms differ in
5102///   things the twelve deliberately do not expose — how many Arrow bytes the
5103///   projection actually materialised, which writer is on the ack path. A bench
5104///   or an operator dump needs those, and a guard needs them to assert that the
5105///   selector selected **on applied output** rather than on a label;
5106/// * there is no allocation and no vtable: the `match` is one predictable branch
5107///   at the top of a call, and everything under it — the `stree` probe, the
5108///   Arrow gather, the redb tail — is the same fully static code
5109///   [`GitStore::<S>::open_with_arms`](GitStore::open_with_arms) produces,
5110///   because `S` is known inside each arm.
5111///
5112/// # What it costs, stated rather than hidden
5113///
5114/// One branch per [`GitOps`] call — **not per object**. `extents(&[1000 oids])`
5115/// is one branch and a thousand monomorphised lookups behind it. The binary
5116/// carries three copies of the store, which is the price of picking a type at
5117/// run time and there is no version of this that does not pay it.
5118///
5119/// A caller that knows its arm at compile time should **not** come through here:
5120/// [`GitStore::open`] and [`GitStore::open_with_arms`] hand back a concrete
5121/// store with no branch at all, and that includes every caller that wants the
5122/// default.
5123pub enum SelectedStore {
5124    OneTableFourColumns(GitStore<OneTableFourColumns>),
5125    FourTables(GitStore<crate::index_layout::FourTables>),
5126    PackedPayload(GitStore<crate::index_layout::PackedPayload>),
5127}
5128
5129/// One expression, evaluated against whichever concrete store this is. The
5130/// delegation below is generated from it so there is no second copy of any
5131/// method body (LAW 5).
5132macro_rules! on_arm {
5133    ($self:ident, $s:ident => $body:expr) => {
5134        match $self {
5135            SelectedStore::OneTableFourColumns($s) => $body,
5136            SelectedStore::FourTables($s) => $body,
5137            SelectedStore::PackedPayload($s) => $body,
5138        }
5139    };
5140}
5141
5142impl SelectedStore {
5143    /// The arms this store was built with.
5144    pub fn arms(&self) -> StoreConfig {
5145        on_arm!(self, s => s.arms())
5146    }
5147
5148    /// **The explode band** — bytes held in each pool, the budget, and what has
5149    /// been evicted since this store was opened. `Admin.StorageInfo` and the
5150    /// dashboard's `explode 3.1G/8G` cell.
5151    pub fn explode_cache_use(&self) -> crate::exploded_cache::CacheUse {
5152        on_arm!(self, s => s.explode_cache_use())
5153    }
5154
5155    /// **This repository's explode quota, set live.** What the control plane
5156    /// calls when an account's plan changes. It never refuses a read and never
5157    /// deletes on the caller's thread: over budget evicts at the next rotation,
5158    /// and an account at its limit still serves every object — from the pack,
5159    /// which is slower and never wrong.
5160    pub fn set_explode_budget(&self, bytes: u64) {
5161        on_arm!(self, s => s.set_explode_budget(bytes))
5162    }
5163
5164    /// **`repo gc` reclaims the cache**: every lazy segment unlinked, the graph
5165    /// pool kept. Returns the bytes that left the filesystem.
5166    pub fn drop_explode_cache(&self) -> anyhow::Result<u64> {
5167        on_arm!(self, s => s.drop_explode_cache())
5168    }
5169
5170    /// The selected writer's name, as it goes on a bench row.
5171    pub fn writer_name(&self) -> &'static str {
5172        on_arm!(self, s => s.writer_name())
5173    }
5174
5175    /// What the selected writer's `append` promises.
5176    pub fn writer_durability(&self) -> &'static str {
5177        on_arm!(self, s => s.writer_durability())
5178    }
5179
5180    /// **Arrow IPC bytes the selected index arm actually materialised.**
5181    ///
5182    /// The applied output that distinguishes one layout from another: a packed
5183    /// 25-byte column, four columns in one section and four independent
5184    /// sections are three different numbers for the same objects. This is what
5185    /// a guard reads to prove the selector selected, because a *name* would
5186    /// prove only that a name was copied.
5187    pub fn index_ipc_bytes(&self) -> usize {
5188        on_arm!(self, s => s.index().ipc_bytes())
5189    }
5190
5191    /// **The name the built projection reports about itself** —
5192    /// `OneTableFourColumns`, `FourTables` or `PackedPayload`.
5193    ///
5194    /// The other half of the applied-output pair [`index_ipc_bytes`] starts:
5195    /// the byte count separates the arms once objects are in the store, and
5196    /// this separates them from the instant it is built, including on an empty
5197    /// store where all three materialise nothing. It is the value
5198    /// [`crate::arms::IndexArm::projection_name`] exists to be compared with —
5199    /// what the layout calls itself, never what the selector asked for — so a
5200    /// server logging it is stating what it built rather than repeating its own
5201    /// environment back.
5202    ///
5203    /// [`index_ipc_bytes`]: SelectedStore::index_ipc_bytes
5204    pub fn index_name(&self) -> &'static str {
5205        on_arm!(self, s => s.index().projection_name())
5206    }
5207
5208    /// The oids a pushed extent introduced — [`GitStore::oids_in_extent`],
5209    /// delegated.
5210    ///
5211    /// Not one of the twelve (a pack's extent is a znippy concept), so it does
5212    /// not arrive with the [`GitOps`] impl below and has to be forwarded by
5213    /// hand. A server that reports the objects a push introduced needs it, and
5214    /// a server that picked its index arm at run time still needs it.
5215    pub fn oids_in_extent(&self, extent: Extent) -> Result<Vec<Vec<u8>>> {
5216        on_arm!(self, s => s.oids_in_extent(extent))
5217    }
5218
5219    /// Objects in the `objects` table.
5220    pub fn object_count(&self) -> usize {
5221        on_arm!(self, s => s.object_count())
5222    }
5223
5224    /// Block until the background drain has absorbed everything pushed.
5225    pub fn wait_indexed(&self) {
5226        on_arm!(self, s => s.wait_indexed())
5227    }
5228
5229    /// Stop this store's index work; see [`GitStore::cancel_index`].
5230    pub fn cancel_index(&self) {
5231        on_arm!(self, s => s.cancel_index())
5232    }
5233
5234    /// This store's index progress; see [`GitStore::index_progress`].
5235    pub fn index_progress(&self) -> crate::progress::Snapshot {
5236        on_arm!(self, s => s.index_progress())
5237    }
5238
5239    /// Rebuild the projection, so the layout under test is what answers rather
5240    /// than the redb tail.
5241    pub fn rebuild_projection(&self) -> Result<()> {
5242        on_arm!(self, s => s.index().rebuild())
5243    }
5244
5245    /// The twelfth method — inherent, not on [`GitOps`], because it returns
5246    /// Arrow `ReservedSection`s a gix backend has no analog for.
5247    pub fn seal(&self) -> Result<Vec<ReservedSection>> {
5248        on_arm!(self, s => s.seal())
5249    }
5250}
5251
5252impl GitOps for SelectedStore {
5253    fn put(&self, pack: &[u8], refs: &[RefUpdate]) -> Result<TxId> {
5254        on_arm!(self, s => s.put(pack, refs))
5255    }
5256    fn put_pack(&self, bytes: &[u8]) -> Result<TxId> {
5257        on_arm!(self, s => s.put_pack(bytes))
5258    }
5259    // Delegated like every other method, and that is the point: without these
5260    // two lines a `SelectedStore` would silently inherit the trait's *default*
5261    // `put_pack_observed` — the one that publishes nothing — and every store
5262    // gunnar actually opens goes through this enum. The count would have been
5263    // implemented in `store.rs` and unreachable in production.
5264    fn put_pack_observed(
5265        &self,
5266        bytes: &[u8],
5267        progress: &dyn git_storage_trait::PackProgress,
5268    ) -> Result<TxId> {
5269        on_arm!(self, s => s.put_pack_observed(bytes, progress))
5270    }
5271    fn publishes_pack_progress(&self) -> bool {
5272        on_arm!(self, s => s.publishes_pack_progress())
5273    }
5274    fn put_refs(&self, updates: &[RefUpdate]) -> Result<TxId> {
5275        on_arm!(self, s => s.put_refs(updates))
5276    }
5277    fn get(&self, oid: Oid<'_>) -> Result<Option<Stored>> {
5278        on_arm!(self, s => s.get(oid))
5279    }
5280    fn has(&self, oid: Oid<'_>) -> Result<bool> {
5281        on_arm!(self, s => s.has(oid))
5282    }
5283    fn size(&self, oid: Oid<'_>) -> Result<Option<u64>> {
5284        on_arm!(self, s => s.size(oid))
5285    }
5286    fn extents(&self, oids: &[Oid<'_>]) -> Result<Vec<Option<Extent>>> {
5287        on_arm!(self, s => s.extents(oids))
5288    }
5289    fn refs(&self) -> Result<Vec<RefRow>> {
5290        on_arm!(self, s => s.refs())
5291    }
5292    fn update_ref(&self, name: &str, old: Option<Oid<'_>>, new: Option<Oid<'_>>) -> Result<TxId> {
5293        on_arm!(self, s => s.update_ref(name, old, new))
5294    }
5295    fn put_refs_cas(&self, edits: &[git_storage_trait::RefCas<'_>]) -> Result<TxId> {
5296        on_arm!(self, s => s.put_refs_cas(edits))
5297    }
5298    fn reachable(&self, want: &[Oid<'_>], have: &[Oid<'_>]) -> Result<Vec<Vec<u8>>> {
5299        on_arm!(self, s => s.reachable(want, have))
5300    }
5301    fn gc(&self) -> Result<GcReport> {
5302        on_arm!(self, s => s.gc())
5303    }
5304}
5305
5306/// The reading contract, delegated the same way [`GitOps`] is.
5307///
5308/// Every method is one predictable branch over a monomorphised body — the same
5309/// arrangement, and the same cost argument, [`SelectedStore`] makes for the
5310/// eleven. It is here rather than in [`crate::serve`] only because the macro
5311/// that generates it lives in this module.
5312impl crate::serve::GitServe for SelectedStore {
5313    fn read(&self, oid: Oid<'_>) -> Result<Option<(crate::index_layout::ObjType, Vec<u8>)>> {
5314        on_arm!(self, s => crate::serve::GitServe::read(s, oid))
5315    }
5316    fn header(&self, oid: Oid<'_>) -> Result<Option<(crate::index_layout::ObjType, u64)>> {
5317        on_arm!(self, s => crate::serve::GitServe::header(s, oid))
5318    }
5319    fn sizes(&self, oids: &[Oid<'_>]) -> Result<Vec<Option<u64>>> {
5320        on_arm!(self, s => crate::serve::GitServe::sizes(s, oids))
5321    }
5322    fn index_now(&self) -> Result<usize> {
5323        on_arm!(self, s => crate::serve::GitServe::index_now(s))
5324    }
5325    fn head(&self) -> Result<Option<RefRow>> {
5326        on_arm!(self, s => crate::serve::GitServe::head(s))
5327    }
5328    fn set_head(&self, target: &str) -> Result<TxId> {
5329        on_arm!(self, s => crate::serve::GitServe::set_head(s, target))
5330    }
5331    /// `objects` is the **exact set to emit**, not tips to close over — the
5332    /// contract's word, and this forwarder uses it so that the name cannot drift
5333    /// back into `want` one arm at a time. See [`crate::serve::GitServe::emit_pack`].
5334    fn emit_pack(
5335        &self,
5336        objects: &[Oid<'_>],
5337        have: &[Oid<'_>],
5338        caps: &git_storage_trait::Caps,
5339        out: &mut dyn std::io::Write,
5340    ) -> Result<git_storage_trait::PackStats> {
5341        on_arm!(self, s => crate::serve::GitServe::emit_pack(s, objects, have, caps, out))
5342    }
5343    fn select(
5344        &self,
5345        want: &[Oid<'_>],
5346        have: &[Oid<'_>],
5347    ) -> Result<Option<git_storage_trait::ReachSet>> {
5348        on_arm!(self, s => crate::serve::GitServe::select(s, want, have))
5349    }
5350}
5351
5352/// **Open a store with all three arms chosen at run time.**
5353///
5354/// The one place [`crate::arms::IndexArm`] — a value — is turned into `S` — a
5355/// type. See [`SelectedStore`] for what the resulting handle costs.
5356pub fn open_selected(
5357    root: &Path,
5358    account: &str,
5359    hash: GitHashKind,
5360    arms: StoreConfig,
5361) -> Result<SelectedStore> {
5362    use crate::arms::IndexArm;
5363    use crate::index_layout::{FourTables, PackedPayload};
5364    Ok(match arms.index {
5365        IndexArm::OneTableFourColumns => {
5366            SelectedStore::OneTableFourColumns(GitStore::<OneTableFourColumns>::open_with_arms(
5367                root, account, hash, arms,
5368            )?)
5369        }
5370        IndexArm::FourTables => SelectedStore::FourTables(GitStore::<FourTables>::open_with_arms(
5371            root, account, hash, arms,
5372        )?),
5373        IndexArm::PackedPayload => SelectedStore::PackedPayload(
5374            GitStore::<PackedPayload>::open_with_arms(root, account, hash, arms)?,
5375        ),
5376    })
5377}
5378
5379/// **The env-driven front door**: read the three variables **once**, here, and
5380/// build the store they name.
5381///
5382/// This is the whole runtime selector a server or a bench needs — one call, one
5383/// triple of `getenv`s, and from then on the store holds built objects and reads
5384/// nothing. There is deliberately no per-operation lookup of any kind: a
5385/// `std::env::var` inside a serving loop would be one syscall per object served,
5386/// which is a real defect that was found and fixed in gunnar the day before this
5387/// was written. [`crate::arms::env_reads`] counts every read this crate makes so
5388/// that "once, at construction" is an assertion rather than a claim.
5389///
5390/// An unset variable takes the shipping default, so a process with a clean
5391/// environment gets exactly [`GitStore::open`]'s combination.
5392pub fn open_from_env(root: &Path, account: &str, hash: GitHashKind) -> Result<SelectedStore> {
5393    let arms = StoreConfig::from_env()?;
5394    open_selected(root, account, hash, arms)
5395}
5396
5397impl<S: ObjectIndex> Absorber<S> {
5398    /// **One object's resolved content, and §14's table is what answers.**
5399    ///
5400    /// Two paths, and they are not interchangeable even though they return
5401    /// identical bytes:
5402    ///
5403    /// 1. **the exploded table** — one point lookup, no inflate, no delta chain;
5404    /// 2. **re-derived from the verbatim truth** — find which pack holds the
5405    ///    object, read the whole pack back, resolve it. Correct and slow, and it
5406    ///    exists because the table is droppable: a store whose table has been
5407    ///    deleted, or whose re-explosion has not caught up, must still answer.
5408    ///
5409    /// The counters are the only way to tell them apart. Identical bytes come
5410    /// back either way, so a byte comparison proves nothing about which path ran
5411    /// — that is the identity-value trap in its exact form, and it is why
5412    /// [`crate::exploded::ExplodedStats::rederived`] is bumped here rather than
5413    /// inferred.
5414    ///
5415    /// On the [`Absorber`] rather than on [`GitStore`] because that is where the
5416    /// absorb runs: the background worker has no store handle, and a base lookup
5417    /// that needed one would put the whole store behind the drain.
5418    fn resolved(&self, oid: &[u8]) -> Result<Option<(GitObjectKind, Vec<u8>)>> {
5419        Ok(self
5420            .resolved_costed(oid)?
5421            .map(|(kind, payload, _)| (kind, payload)))
5422    }
5423
5424    /// [`Self::resolved`] through a [`crate::resolve::ChainCache`]: the
5425    /// reachability builder's read, which materialises neighbouring chains by
5426    /// the hundred thousand.
5427    fn resolved_cached(
5428        &self,
5429        oid: &[u8],
5430        cache: &mut crate::resolve::ChainCache,
5431    ) -> Result<Option<(GitObjectKind, Vec<u8>)>> {
5432        Ok(self
5433            .resolved_costed_with(oid, Some(cache))?
5434            .map(|(kind, payload, _)| (kind, payload)))
5435    }
5436
5437    /// [`Self::resolved`] and the bill. `None` for the cost means a pool
5438    /// answered and nothing was rebuilt.
5439    #[allow(clippy::type_complexity)]
5440    fn resolved_costed(
5441        &self,
5442        oid: &[u8],
5443    ) -> Result<Option<(GitObjectKind, Vec<u8>, Option<crate::resolve::ReadCost>)>> {
5444        self.resolved_costed_with(oid, None)
5445    }
5446
5447    #[allow(clippy::type_complexity)]
5448    fn resolved_costed_with(
5449        &self,
5450        oid: &[u8],
5451        cache: Option<&mut crate::resolve::ChainCache>,
5452    ) -> Result<Option<(GitObjectKind, Vec<u8>, Option<crate::resolve::ReadCost>)>> {
5453        // (1) §14's table.
5454        if let Some((kind, payload)) = self.exploded.content(oid)? {
5455            return Ok(Some((kind, payload, None)));
5456        }
5457        // (2) the verbatim truth, re-derived.
5458        let Some(row) = self.objects.lookup(oid) else {
5459            // (3) not indexed yet: the pending packs, read-only, on this
5460            // reader's own thread — never by waiting for the worker.
5461            //
5462            // **This arm is the ack path's trap and it is not the ack path's
5463            // fix.** `a_read_before_the_drain_is_served_from_the_pack_and_never_waits`
5464            // is the law here: a clone must be answered while the drain is
5465            // parked, so a read may not take the absorb gate. What must not
5466            // happen is the ACK arriving here, and it no longer does —
5467            // `GitServe::index_now` runs before the connectivity check, so by
5468            // the time the check reads there is nothing pending to scan. See
5469            // [`Absorber::index_pending_now`].
5470            if self.unindexed_packs() == 0 {
5471                return Ok(None);
5472            }
5473            self.exploded.note_rederived();
5474            let (_, content) = self.scan_pending(&[], Some(oid))?;
5475            // The pending scan resolves through a `PackWalk` rather than a
5476            // chain walk, so it does not produce a bill. `None` is honest here
5477            // and is not "it was free".
5478            return Ok(content.map(|(k, p)| (k, p, None)));
5479        };
5480        // ── ONE CHAIN, not one pack ─────────────────────────────────────
5481        //
5482        // The row's `offset` addresses the entry in the archive directly, so the
5483        // object is materialised by following its own delta chain out of the
5484        // mapping — `d` inflates and `d − 1` delta applications, nothing else
5485        // touched. This used to `read_extent` the WHOLE containing pack and
5486        // re-resolve it: for `torvalds/linux` an 8.12 GiB read and a 13.9 M
5487        // object resolve **per object served**, which is the cost that forced
5488        // the exploded tier to be built eagerly at push time — and that tier
5489        // MEASURED 141.7 GiB for an 8.12 GiB pack (17×). Lazy explode is only
5490        // affordable because of this function
5491        // (`ideas/lazy-explode-index-only-at-push.md`).
5492        //
5493        // It also does not care whether the containing pack has been ABSORBED:
5494        // the bytes were fsynced before the ack, so an object whose row is in
5495        // the index is readable the instant the row is. The pending-pack scan
5496        // below is for the window before the row exists at all.
5497        self.exploded.note_rederived();
5498        let snap = self.map.snapshot()?;
5499        let src = ArchiveWindow { abs: self, snap: &snap };
5500        let offset_of = |base: &[u8]| self.objects.lookup(base).map(|r| r.offset);
5501        match crate::resolve::materialize_at_with(
5502            &src,
5503            row.offset,
5504            self.hash.oid_len(),
5505            &offset_of,
5506            self,
5507            cache,
5508        ) {
5509            Ok((kind, payload, cost)) => {
5510                self.keep_for_the_next_reader(oid, kind, &payload, cost);
5511                Ok(Some((kind, payload, Some(cost))))
5512            }
5513            Err(e) => {
5514                // A chain that cannot be followed out of the mapping is not a
5515                // wrong answer to hand back: fall through to the pending scan,
5516                // which re-derives from the pack the row came in on.
5517                //
5518                // **And if that finds nothing either, the ORIGINAL error is
5519                // what comes back — never `Ok(None)`.** The row says this store
5520                // holds the object; a failed read of an object we hold is a
5521                // store defect, and answering "absent" for it turned that defect
5522                // into a refusal of somebody else's push (lane AI, 2026-08-30 —
5523                // see `crate::resolve::MAX_DELTA_LINKS`). Absence is a fact the
5524                // index states, not a shape an error decays into.
5525                if self.unindexed_packs() == 0 {
5526                    return Err(e);
5527                }
5528                match self.scan_pending(&[], Some(oid))? {
5529                    (_, Some((k, p))) => Ok(Some((k, p, None))),
5530                    (_, None) => Err(e),
5531                }
5532            }
5533        }
5534    }
5535}
5536
5537impl<S: ObjectIndex> Absorber<S> {
5538    /// **The write-back, and it is off the reader's path.**
5539    ///
5540    /// The reader has its bytes already — this buffers a copy into the lazy
5541    /// pool's newest segment (a `memcpy` under one lock, no I/O, no fsync, no
5542    /// eviction) and, once 4 MiB have accumulated, starts a thread to do the
5543    /// writing. That is the owner's law from the design note in one function:
5544    /// *nobody waits*. A failure here is not the read's failure — the bytes
5545    /// were correct before the cache was consulted and are correct after it
5546    /// refuses — so it is counted and swallowed rather than propagated.
5547    ///
5548    /// **It does not always write.** A shallow, small object is cheaper to
5549    /// inflate again than to keep — a whole object is one `inflate` of one zlib
5550    /// stream at one offset — so the cache declines it and counts the read as
5551    /// `direct_reads` (`exploded_cache::worth_caching`). That is the owner's
5552    /// refinement, 2026-08-30: *do not explode uniformly*. The reader that just
5553    /// paid the bill is the only thing that knows what it was, which is why the
5554    /// cost comes back out of [`crate::resolve::materialize_at`] rather than
5555    /// being predicted from an index column.
5556    ///
5557    /// Two readers racing on one oid is benign: identical bytes, and the table
5558    /// keeps the first row it filed under that key.
5559    fn keep_for_the_next_reader(
5560        &self,
5561        oid: &[u8],
5562        kind: GitObjectKind,
5563        payload: &[u8],
5564        cost: crate::resolve::ReadCost,
5565    ) {
5566        match self.exploded.write_back(oid, kind, payload, cost) {
5567            Ok(true) => self.exploded.kick(),
5568            Ok(false) => {}
5569            Err(e) => {
5570                tracing::debug!(
5571                    target: "znippy.git",
5572                    store = %self.label,
5573                    error = %e,
5574                    "the exploded cache would not take a write-back; the read is unaffected"
5575                );
5576            }
5577        }
5578    }
5579}
5580
5581/// [`crate::reach::TreeSource`] over a live store — see
5582/// [`Absorber::tree_source`].
5583/// The oid a tag object points at, out of its header, **raw**.
5584///
5585/// A tag object's payload begins `object <hex>\n` — that is the format, not a
5586/// heuristic, and it is the whole parse. Deliberately NOT reached for with a
5587/// git object library: this crate is a shipped archiver and `gix-object` is a
5588/// dev-dependency here, so pulling it into the read path to read one line would
5589/// put the pack pipeline back in an archive-only build (S-071). Exactly the
5590/// hash width this store uses, and hex: a shorter or longer field is a
5591/// malformed tag, and guessing at one would put a wrong oid into a
5592/// reachability answer — the one place a wrong answer is silent.
5593fn tag_target_raw(payload: &[u8], oid_len: usize) -> Option<[u8; 32]> {
5594    let line = payload.split(|b| *b == b'\n').next()?;
5595    let rest = line.strip_prefix(b"object ")?;
5596    if rest.len() != oid_len * 2 || oid_len > 32 {
5597        return None;
5598    }
5599    let mut out = [0u8; 32];
5600    hex::decode_to_slice(rest, &mut out[..oid_len]).ok()?;
5601    Some(out)
5602}
5603
5604/// Add what a tag points at — and what THAT reaches — to a reachability union.
5605///
5606/// A tag may point at a commit (its closure, by bitmap or bounded walk), at
5607/// another tag (followed, bounded), at a tree (every object under it — a tree
5608/// alone would be the same bug one level down) or at a blob (itself). An
5609/// unreadable object makes the closure SHORT, and a short closure is refused
5610/// downstream by name (`missing necessary objects`) rather than served as
5611/// though it were complete — the same contract `TreesFromStore::tree`
5612/// documents.
5613fn peel_tag_into<S: ObjectIndex>(
5614    abs: &Absorber<S>,
5615    tag: u32,
5616    view: &crate::reach::ReachView<'_>,
5617    facts: &crate::reach::ObjectFacts<'_>,
5618    union: &mut roaring::RoaringBitmap,
5619) {
5620    const MAX_TAG_HOPS: usize = 8;
5621    let oid_len = facts.oid_len;
5622    let mut cursor = tag;
5623    for _ in 0..MAX_TAG_HOPS {
5624        let Some(raw) = facts.ordinal.oid(cursor) else { return };
5625        let Ok(Some((GitObjectKind::Tag, payload))) = abs.resolved(raw) else { return };
5626        let Some(target) = tag_target_raw(&payload, oid_len) else { return };
5627        let target = &target[..oid_len];
5628        let Some(t) = facts.ordinal.ordinal_of_raw(target) else { return };
5629        if let Some(row) = view.graph.row_of(t) {
5630            match view.bitmap_of_row(row) {
5631                Some(bm) => *union |= bm,
5632                None => crate::reach::accumulate(row, view, facts, union),
5633            }
5634            return;
5635        }
5636        match abs.resolved(target) {
5637            // `fill_tree` sets the tree's own bit and everything under it; it
5638            // must see the bit CLEAR, so the tree is not inserted first.
5639            Ok(Some((GitObjectKind::Tree, _))) => {
5640                crate::reach::fill_tree(t, facts, union);
5641                return;
5642            }
5643            Ok(Some((GitObjectKind::Tag, _))) => {
5644                union.insert(t);
5645                cursor = t;
5646            }
5647            // A blob, or unreadable: it is in, and it has no closure.
5648            _ => {
5649                union.insert(t);
5650                return;
5651            }
5652        }
5653    }
5654}
5655
5656struct TreesFromStore<'a, S: ObjectIndex> {
5657    abs: &'a Absorber<S>,
5658    /// The delta-chain memo of a full build; `None` for the bounded walks.
5659    chains: Option<Mutex<crate::resolve::ChainCache>>,
5660}
5661
5662impl<S: ObjectIndex> TreesFromStore<'_, S> {
5663    /// `(hits, misses, bytes)` of the chain memo, if there is one.
5664    fn chain_stats(&self) -> Option<(u64, u64, usize)> {
5665        let c = self.chains.as_ref()?.lock().ok()?;
5666        let (h, m) = c.stats();
5667        Some((h, m, c.bytes()))
5668    }
5669}
5670
5671impl<S: ObjectIndex> crate::reach::TreeSource for TreesFromStore<'_, S> {
5672    fn tree(&self, oid: &[u8]) -> Option<std::borrow::Cow<'_, [u8]>> {
5673        // A read that fails is `None`, which is what an object this archive
5674        // does not hold has always answered here — the walk stops at it. It is
5675        // NOT silently dropping an error that matters: an unreadable tree makes
5676        // the closure short, and a short closure is refused downstream by name
5677        // (`missing necessary objects`) rather than served as if it were
5678        // complete.
5679        let read = match &self.chains {
5680            Some(m) => match m.lock() {
5681                Ok(mut c) => self.abs.resolved_cached(oid, &mut c),
5682                Err(_) => self.abs.resolved(oid),
5683            },
5684            None => self.abs.resolved(oid),
5685        };
5686        match read {
5687            Ok(Some((GitObjectKind::Tree, payload))) => Some(std::borrow::Cow::Owned(payload)),
5688            // A blob, a tag, a gitlink, or absent: all "not a tree here".
5689            Ok(_) => None,
5690            Err(e) => {
5691                tracing::debug!(
5692                    target: "znippy.git",
5693                    store = %self.abs.label,
5694                    oid = %hex::encode(oid),
5695                    error = %e,
5696                    "a reachability walk could not read a tree; the walk stops there"
5697                );
5698                None
5699            }
5700        }
5701    }
5702}
5703/// The verbatim archive as [`crate::resolve::ArchiveBytes`]: **the mapping
5704/// where it reaches, a `pread` past its end.**
5705///
5706/// One snapshot is taken per read and sliced as many times as the chain is
5707/// deep, which is [`crate::archive_map::ArchiveMap::snapshot`]'s contract. The
5708/// `pread` arm is the one a push that landed after the snapshot takes; both
5709/// arms return the same bytes and differ only in what they cost.
5710struct ArchiveWindow<'a, S: ObjectIndex> {
5711    abs: &'a Absorber<S>,
5712    snap: &'a crate::archive_map::Mapped,
5713}
5714
5715impl<S: ObjectIndex> crate::resolve::ArchiveBytes for ArchiveWindow<'_, S> {
5716    fn at(&self, at: u64, len: u64) -> Result<std::borrow::Cow<'_, [u8]>> {
5717        clamped_window(self.abs, self.snap, at, len)
5718    }
5719}
5720
5721/// At most `len` bytes of the archive at `at`: the mapping where it reaches, a
5722/// `pread` past its end, and **fewer bytes at the end of the file** instead of
5723/// a refusal. A probe near the end of the archive legitimately gets fewer bytes
5724/// than it asked for, so the window is clamped rather than refused — the
5725/// parsers read a grammar, not a fixed width.
5726fn clamped_window<'m, S: ObjectIndex>(
5727    abs: &Absorber<S>,
5728    snap: &'m crate::archive_map::Mapped,
5729    at: u64,
5730    len: u64,
5731) -> Result<std::borrow::Cow<'m, [u8]>> {
5732    let mapped = snap.len();
5733    if at < mapped {
5734        let have = (mapped - at).min(len);
5735        if let Some(b) = snap.get(at, have) {
5736            return Ok(std::borrow::Cow::Borrowed(b));
5737        }
5738    }
5739    let end = abs.reader.metadata().map(|m| m.len()).unwrap_or(mapped);
5740    if at >= end {
5741        return Ok(std::borrow::Cow::Owned(Vec::new()));
5742    }
5743    let have = (end - at).min(len);
5744    Ok(std::borrow::Cow::Owned(abs.read_extent(at, have)?))
5745}
5746
5747/// A thin pack's external delta base, answered from §14's exploded table.
5748///
5749/// Before that table existed this had to read and re-resolve a whole pack per
5750/// base, and it deliberately cached nothing — because a cache here *would* have
5751/// been the undecided table. It is decided now (eager, 2026-08-08), so the cache
5752/// is the table and this is one point lookup.
5753///
5754/// **`None` means absent and `Err` means unreadable, and they are not the same
5755/// answer.** A base this store does not hold still comes back `Ok(None)` and
5756/// [`crate::resolve::ResolveError::missing_base`] refuses the pack by name.
5757///
5758/// # 🔴 This was `.ok().flatten()`
5759///
5760/// A store that HELD the base and could not reconstruct it answered exactly
5761/// like one that never had it, so the resolver blamed the pushed pack: *"this
5762/// repository genuinely does not have that object"*, about an object one index
5763/// lookup away. That sentence went to the client on the `ng` line and to the
5764/// operator in the log, and it named the wrong party — lane AI, 2026-08-30, 21
5765/// of 140 ordinary pushes. The error travels now.
5766impl<S: ObjectIndex> BaseSource for Absorber<S> {
5767    fn content(&self, oid: &[u8]) -> Result<Option<(GitObjectKind, Vec<u8>)>> {
5768        self.resolved(oid).with_context(|| {
5769            format!(
5770                "reading the delta base {} out of this store — it is not absent, it could not \
5771                 be reconstructed",
5772                hex::encode(oid)
5773            )
5774        })
5775    }
5776}
5777
5778/// **A table that was extended and not yet written back is written on drop.**
5779/// The extension persists every [`REACH_PERSIST_EVERY`] folds, so a clean
5780/// shutdown would otherwise leave the last few pushes' entries to be walked
5781/// again at the next open. Bounded and best-effort: a failure is logged.
5782impl<S: ObjectIndex> Drop for Absorber<S> {
5783    fn drop(&mut self) {
5784        if self.reach_unpersisted.load(std::sync::atomic::Ordering::Relaxed) == 0 {
5785            return;
5786        }
5787        if let Ok(d) = self.derived.read() {
5788            self.persist_reach_locked(&d);
5789        }
5790    }
5791}
5792
5793#[cfg(test)]
5794mod tests {
5795    use super::*;
5796    use crate::archive_write::{read_journal, SafeWriter};
5797    use crate::object::GitObjectKind;
5798    use crate::store::tests::{one_blob_pack, corpus_pack, tmpdir};
5799    use std::collections::HashSet;
5800    use std::sync::atomic::{AtomicBool, AtomicU64, Ordering as AtomicOrdering};
5801    use std::time::{Duration, Instant};
5802    use znippy_zoomies::background::Job;
5803    use znippy_zoomies::gatling_forkjoin::gatling_for_each;
5804
5805    fn loadavg() -> String {
5806        std::fs::read_to_string("/proc/loadavg")
5807            .unwrap_or_default()
5808            .split_whitespace()
5809            .take(3)
5810            .collect::<Vec<_>>()
5811            .join(" ")
5812    }
5813
5814    /// **The one representation answers exactly what the two it replaced did.**
5815    ///
5816    /// Before S-082 the store carried the ordinal space three times: `oids_raw`
5817    /// (flat bytes), `oids` (hex `Vec<String>`) and `ordinal`
5818    /// (`HashMap<String, u32>`). The last two are gone; oid ⇄ ordinal is now a
5819    /// slice and a binary search over `oids_raw`, through
5820    /// [`crate::reach::OrdinalSpace`]. This rebuilds those two OLD tables inline
5821    /// from the SAME `oids_raw` the store folded, and asserts the new lookups
5822    /// return the identical answer **for every oid in a real corpus** — the
5823    /// property that lets the field be removed without a server ever naming the
5824    /// wrong object in a pack, which no exit code could see.
5825    ///
5826    /// Seen RED by an off-by-one binary search (`Equal => Some(mid as u32 + 1)`
5827    /// in [`crate::reach::OrdinalSpace::ordinal_of_raw`]): every
5828    /// `ordinal_of_raw` / `ordinal_of_hex` below disagreed with the old
5829    /// `HashMap`, and the closure comparison at the end disagreed as well.
5830    #[test]
5831    fn the_one_ordinal_space_answers_what_the_two_it_replaced_did() {
5832        let dir = tmpdir("ordinal-space-one-representation");
5833        let (pack, rows) = corpus_pack();
5834        let store = GitStore::open(&dir, "alice").unwrap();
5835        store.put_pack(&pack).unwrap();
5836        store.wait_indexed();
5837
5838        let oid_len = store.hash_kind().oid_len();
5839        let raw = {
5840            let d = store.absorber.derived.read().unwrap();
5841            d.ordinals.view().concat()
5842        };
5843        // The two tables `refold` used to build, rebuilt here from the same
5844        // bytes — this IS the "old" answer the new lookups must equal.
5845        let old_oids: Vec<String> = raw.chunks_exact(oid_len).map(hex::encode).collect();
5846        let old_ordinal: std::collections::HashMap<String, u32> = old_oids
5847            .iter()
5848            .enumerate()
5849            .map(|(i, o)| (o.clone(), i as u32))
5850            .collect();
5851
5852        assert!(
5853            !old_oids.is_empty(),
5854            "the fixture pack ({} entries) folded to an EMPTY ordinal space, so every \
5855             comparison below would hold vacuously",
5856            rows.len()
5857        );
5858        assert_eq!(
5859            raw.len(),
5860            old_oids.len() * oid_len,
5861            "the raw ordinal space is {} bytes for {} oids of {oid_len} bytes",
5862            raw.len(),
5863            old_oids.len()
5864        );
5865
5866        let space = crate::reach::OrdinalSpace::new(&raw, oid_len);
5867        assert_eq!(space.len(), old_oids.len(), "the space holds a different count");
5868        let mut checked = 0usize;
5869        for (o, h) in old_oids.iter().enumerate() {
5870            let want_ord = old_ordinal[h];
5871            // oid → ordinal, hex and raw, both == the old HashMap answer.
5872            assert_eq!(
5873                space.ordinal_of_hex(h),
5874                Some(want_ord),
5875                "ordinal_of_hex({h}) != the old HashMap answer {want_ord}"
5876            );
5877            let raw_oid = hex::decode(h).unwrap();
5878            assert_eq!(
5879                space.ordinal_of_raw(&raw_oid),
5880                Some(want_ord),
5881                "ordinal_of_raw disagrees with the old HashMap at {h}"
5882            );
5883            // ordinal → oid == the old hex Vec's slice, in both spellings.
5884            assert_eq!(
5885                space.oid(o as u32),
5886                Some(raw_oid.as_slice()),
5887                "oid({o}) != the old oids_raw slice"
5888            );
5889            assert_eq!(
5890                space.oid(o as u32).map(hex::encode).as_deref(),
5891                Some(h.as_str()),
5892                "oid({o}) hex != the old hex Vec entry {h}"
5893            );
5894            checked += 1;
5895        }
5896        assert_eq!(checked, old_oids.len());
5897
5898        // A non-member answers None both ways, exactly as `HashMap::get` did for
5899        // an absent key — the binary search must not land on a neighbour.
5900        let absent = vec![0xffu8; oid_len];
5901        assert_eq!(space.ordinal_of_raw(&absent), None, "an absent oid resolved to an ordinal");
5902        assert_eq!(
5903            space.ordinal_of_hex(&hex::encode(&absent)),
5904            None,
5905            "an absent hex oid resolved to an ordinal"
5906        );
5907        // A wrong-width key is absent, not a panic.
5908        assert_eq!(space.ordinal_of_raw(&absent[..oid_len - 1]), None);
5909        assert_eq!(space.oid(old_oids.len() as u32), None, "an out-of-range ordinal named an oid");
5910
5911        // And the answer built out of it: the raw closure IS the hex closure,
5912        // for a real tip rather than for an empty request.
5913        let tip = store
5914            .graph_snapshot()
5915            .into_iter()
5916            .max_by_key(|c| c.generation)
5917            .expect("a graph");
5918        let tip_raw = hex::decode(&tip.oid).unwrap();
5919        let flat = store.reachable_raw(&[&tip_raw], &[]).unwrap();
5920        let hexed = store.reachable_oids(&[&tip_raw], &[]).unwrap();
5921        assert!(
5922            flat.len() > 1,
5923            "the tip's closure is {} object(s) — too small to tell an ordering bug from a \
5924             coincidence",
5925            flat.len()
5926        );
5927        assert_eq!(
5928            flat.iter().map(hex::encode).collect::<Vec<_>>(),
5929            hexed,
5930            "the serving answer and the maintenance answer name different objects"
5931        );
5932        assert!(flat.contains(&tip_raw), "a closure without its own tip");
5933        eprintln!(
5934            "load {}; {} ordinals agree in both spellings, tip closure {} objects",
5935            loadavg(),
5936            checked,
5937            flat.len()
5938        );
5939    }
5940
5941    /// Distinct commits in a resolved pack — what the graph must hold exactly
5942    /// once.
5943    fn commits_in(rows: &[crate::resolve::Resolved]) -> usize {
5944        rows.iter()
5945            .filter(|r| r.kind == GitObjectKind::Commit)
5946            .map(|r| r.oid.clone())
5947            .collect::<HashSet<Vec<u8>>>()
5948            .len()
5949    }
5950
5951    /// **A push ends in object rows, and no read asked for them.**
5952    ///
5953    /// This is the seam this file wires: before it, `put` produced a *pack* row
5954    /// on the account indexer's channel and the object rows appeared only when
5955    /// somebody read (or called `absorb_pending` by hand). Here nothing is read
5956    /// between `put_pack` and `wait_indexed` — the only thing that could have
5957    /// built the rows is the drain.
5958    ///
5959    /// Asserted on applied output: one row per pack entry, every oid resolving
5960    /// out of the index, and the pack's indexed bit up. `absorb_failures` is
5961    /// asserted too, because a drain that absorbed nothing and recorded the
5962    /// failure would otherwise look like a drain that was never called.
5963    ///
5964    /// Seen RED by making the drain skip the absorber
5965    /// (`match absorber.as_deref()` → `match None::<&dyn ObjectAbsorb>` in
5966    /// `indexer::index_worker`): "the drain built no object rows: 0 of 2687".
5967    /// Restored.
5968    ///
5969    /// MEASURED on oden, 2026-08-08, release, three runs at **1-minute loadavg
5970    /// 5.77** (another tenant's work — oden is shared, so this is not an idle
5971    /// box): 2687 objects out of a 5 653 302-byte real pack absorbed in
5972    /// 161–164 ms, **16 421–16 673 object rows/s**, behind an ack of 29.1–29.4 ms.
5973    /// An earlier set at loadavg 16.94 gave 15 528 rows/s, so the figure moves
5974    /// about 7% with the box.
5975    ///
5976    /// Read it as a *floor* rather than as the engine's speed: the drain here is
5977    /// one pack, so it never uses more than one absorb, and the 162 ms covers a
5978    /// full inflate-and-delta-apply of every entry, a SHA-1 per object, the redb
5979    /// append and a whole-tail re-fold. Nothing about it has been optimised and
5980    /// no arm of it has been isolated. The rate is printed with the loadavg of
5981    /// its own run so a later number is never compared against a different
5982    /// machine state by accident.
5983    #[test]
5984    fn a_push_ends_in_object_rows_and_no_read_asked_for_them() {
5985        let dir = tmpdir("drain-rows");
5986        let store = GitStore::open(&dir, "alice").unwrap();
5987        let (pack, rows) = corpus_pack();
5988
5989        let t = Instant::now();
5990        let tx = store.put_pack(&pack).unwrap();
5991        let ack = t.elapsed();
5992        let pack_id = tx.pack_id.expect("a pack push assigns an id");
5993
5994        // Nothing is read here. The drain is the only thing that can move.
5995        store.wait_indexed();
5996        let drained = t.elapsed();
5997
5998        assert_eq!(
5999            store.object_count(),
6000            rows.len(),
6001            "the drain built no object rows: {} of {}",
6002            store.object_count(),
6003            rows.len()
6004        );
6005        assert_eq!(store.unindexed_packs(), 0, "the bit is still clear");
6006        assert!(
6007            store.indexer().is_indexed(pack_id),
6008            "the pack's indexed bit is not up after the drain"
6009        );
6010        assert_eq!(
6011            store.indexer().absorb_failures(),
6012            0,
6013            "the drain recorded an absorb failure: {:?}",
6014            store.indexer().last_absorb_error()
6015        );
6016
6017        // Every oid answers **out of the rows**, not out of a fallback: the
6018        // index is asked directly, so nothing can absorb behind this loop.
6019        for (i, r) in rows.iter().enumerate() {
6020            let row = store
6021                .index()
6022                .lookup(&r.oid)
6023                .unwrap_or_else(|| panic!("object {i} {} has no row", hex::encode(&r.oid)));
6024            assert_eq!(
6025                (row.offset, row.len),
6026                (tx.extent.unwrap().0 + r.offset, r.len)
6027            );
6028            assert_eq!(row.uncompressed_size, r.uncompressed_size);
6029        }
6030        assert_eq!(
6031            store.absorb_pending().unwrap(),
6032            0,
6033            "the drain left work for a read to do"
6034        );
6035        assert_eq!(
6036            store.commit_count(),
6037            commits_in(&rows),
6038            "the commit graph does not match the pack"
6039        );
6040
6041        let secs = (drained - ack).as_secs_f64();
6042        eprintln!(
6043            "load {}; {} objects in {} bytes: ack {:.0} µs, drain {:.1} ms, {:.0} object rows/s",
6044            loadavg(),
6045            rows.len(),
6046            pack.len(),
6047            ack.as_secs_f64() * 1e6,
6048            (drained - ack).as_secs_f64() * 1e3,
6049            rows.len() as f64 / secs.max(1e-9),
6050        );
6051    }
6052
6053    // ── the bit across a restart ─────────────────────────────────────────────
6054
6055    /// Where the child of the kill guard finds its fixture and leaves its marker.
6056    const KILL_DIR: &str = "GUNNAR_KILL_MID_ABSORB_DIR";
6057
6058    /// **The other half of [`a_store_reopened_after_a_kill_mid_absorb_requeues_the_pack`]:
6059    /// the process that dies.**
6060    ///
6061    /// It runs as a child of that test and it **aborts on purpose**, which is why
6062    /// it is `#[ignore]`d: `SIGABRT` from inside a test binary is a failing test
6063    /// run, and the point is for the *parent* to see the signal.
6064    ///
6065    /// The kill lands where it has to land — after `put_pack` has returned, so
6066    /// the bytes and the journal row are on the platter, and before any row is in
6067    /// the index, which the held absorb gate makes a **state** rather than a
6068    /// hope. Nothing is simulated: no injected error, no fault flag, no early
6069    /// return. The process is gone.
6070    #[test]
6071    #[ignore = "spawned by a_store_reopened_after_a_kill_mid_absorb_requeues_the_pack; it aborts on purpose"]
6072    fn the_child_that_dies_between_durable_bytes_and_indexed_rows() {
6073        let Ok(dir) = std::env::var(KILL_DIR) else {
6074            // Run by hand with `--ignored` and no fixture: there is nothing to
6075            // kill over, so do nothing rather than abort somebody's test run.
6076            return;
6077        };
6078        let dir = PathBuf::from(dir);
6079        let pack = std::fs::read(dir.join("fixture.pack")).expect("the parent's fixture");
6080
6081        let store = GitStore::open(&dir, "alice").expect("open");
6082        // The drain is parked in front of its absorb for as long as this lives,
6083        // so no row can land before the abort below.
6084        let _gate = store.hold_absorb_gate();
6085        let tx = store.put_pack(&pack).expect("the ack path");
6086        assert_eq!(tx.pack_id, Some(0), "a fresh archive starts at ordinal 0");
6087        assert_eq!(store.unindexed_packs(), 1, "the pack is not queued");
6088        assert_eq!(store.index().len(), 0, "a row landed before the kill");
6089        std::fs::write(dir.join("ready"), b"durable, not indexed").expect("marker");
6090
6091        // Not `panic!`, not `exit`: the process stops here with a live gate, a
6092        // live worker and a live redb handle, which is what a machine that dies
6093        // mid-absorb leaves behind.
6094        std::process::abort();
6095    }
6096
6097    /// **A store reopened over a pack that was still being absorbed re-queues
6098    /// it, answers correctly the whole way through, and gets its derived tables
6099    /// back.**
6100    ///
6101    /// The interruption is a **real** one: a child process is spawned, pushes the
6102    /// pack, and is killed by `SIGABRT` between "bytes durable" and "rows
6103    /// indexed". The parent then asserts what the kill left on disk — one journal
6104    /// row, the pack verbatim, **zero** index rows — before opening a store over
6105    /// it, so the recovery is being tested against the state it claims to
6106    /// recover from and not against a lucky one.
6107    ///
6108    /// Three things are then asserted, all on applied output:
6109    ///
6110    /// 1. **the pack is re-queued** — the account indexer of the *new* process
6111    ///    publishes ordinal 0, which it can only do for a job somebody submitted;
6112    /// 2. **a read is correct throughout** — `has` is asked the instant the store
6113    ///    is open, before any drain has been waited for, and must answer `true`;
6114    /// 3. **`commit_count()` and `reachable()` come back** — the derived tables
6115    ///    are rebuilt by the same absorb, so the graph holds exactly the pack's
6116    ///    commits and a tip's closure is non-empty.
6117    ///
6118    /// Seen RED by making `open_with` re-queue nothing (`absorber
6119    /// .adopt_journal(&acked)?` → an empty `Vec`, which is what this store did
6120    /// before this change): "a durable object read `absent` from a store reopened
6121    /// over the pack that holds it — the crash-recovery bit did not re-queue
6122    /// anything". Restored.
6123    ///
6124    /// Seen RED a second time by inverting the diff in
6125    /// [`Absorber::adopt_journal`] (`if absorbed` → `if !absorbed`), so a pack
6126    /// with **no** rows has its bit set and a pack with rows is re-queued: the
6127    /// same first assertion fires, because a set bit over an empty index is
6128    /// exactly the wrong answer a bloom filter's false positive would have
6129    /// produced — the read stops falling back and says `absent` about an object
6130    /// whose bytes are durable. Restored.
6131    ///
6132    /// **Why the assertions are not immediately after the reopen.** The trap the
6133    /// drain guards already record applies here too, mirrored: right after
6134    /// `GitStore::open` the drain may legitimately have finished the re-queued
6135    /// pack already, so `unindexed_packs() == 1` is not assertable and is not
6136    /// asserted. What *is* assertable at that instant is the answer to a read,
6137    /// which must be `true` whichever side of the drain it lands on — and that is
6138    /// exactly the property §13.12 promises.
6139    ///
6140    /// **And it still holds now that a `gc` can retire a pack's journal row.**
6141    /// The tombstone tells "indexed then garbage-collected" from "never
6142    /// indexed", and this pack is the second: nothing retired it, so it must
6143    /// still be re-queued. Seen RED by making `adopt_journal` treat *every* pack
6144    /// as retired (`retired.contains(&extent.0)` → `true`): "a durable object
6145    /// read `absent` from a store reopened over the pack that holds it — the
6146    /// crash-recovery bit did not re-queue anything". Restored.
6147    #[test]
6148    fn a_store_reopened_after_a_kill_mid_absorb_requeues_the_pack() {
6149        use std::os::unix::process::ExitStatusExt;
6150
6151        let dir = tmpdir("kill-mid-absorb");
6152        let (pack, rows) = corpus_pack();
6153        std::fs::write(dir.join("fixture.pack"), &pack).unwrap();
6154
6155        let status = std::process::Command::new(std::env::current_exe().unwrap())
6156            .args([
6157                "--exact",
6158                "--ignored",
6159                "--nocapture",
6160                "git_ops::tests::the_child_that_dies_between_durable_bytes_and_indexed_rows",
6161            ])
6162            .env(KILL_DIR, &dir)
6163            .status()
6164            .expect("spawn the child that dies");
6165        assert_eq!(
6166            status.signal(),
6167            Some(6),
6168            "the child did not die by SIGABRT — it {status:?}, so nothing was interrupted"
6169        );
6170        assert!(
6171            dir.join("ready").exists(),
6172            "the child never reached the kill point"
6173        );
6174
6175        // ── what the kill left on disk ───────────────────────────────────────
6176        let blobs = dir.join("objects.pack");
6177        let acked = read_journal(&SafeWriter::journal_path(&blobs)).unwrap();
6178        assert_eq!(
6179            acked.len(),
6180            1,
6181            "the pack's extent is not durable: {acked:?}"
6182        );
6183        assert_eq!(acked[0].1, pack.len() as u64);
6184        let on_disk = std::fs::read(&blobs).unwrap();
6185        assert_eq!(
6186            &on_disk[acked[0].0 as usize..(acked[0].0 + acked[0].1) as usize],
6187            &pack[..],
6188            "the verbatim bytes did not survive the kill"
6189        );
6190        {
6191            // Opened and dropped before the store takes redb's file lock.
6192            let tail = ObjectReadStack::<OneTableFourColumns>::open(
6193                &dir.join("objects.tail"),
6194                RebuildTriggers::default(),
6195                crate::arms::DEFAULT_REDB_CACHE_BYTES,
6196            )
6197            .unwrap();
6198            assert_eq!(
6199                tail.len(),
6200                0,
6201                "the kill landed after the rows were indexed, not between the bytes and the rows \
6202                 — this guard would then be testing nothing"
6203            );
6204        }
6205
6206        // ── the reopen ───────────────────────────────────────────────────────
6207        let store = GitStore::open(&dir, "alice").unwrap();
6208        assert!(
6209            store.has(&rows[0].oid).unwrap(),
6210            "a durable object read `absent` from a store reopened over the pack that holds it — \
6211             the crash-recovery bit did not re-queue anything"
6212        );
6213
6214        store.wait_indexed();
6215        assert_eq!(
6216            store.object_count(),
6217            rows.len(),
6218            "the re-queued pack's objects never reached the index — left: {}, right: {}",
6219            store.object_count(),
6220            rows.len()
6221        );
6222        assert!(
6223            store.indexer().is_indexed(0),
6224            "the re-queued pack's indexed bit never went up in the new process"
6225        );
6226        assert_eq!(store.unindexed_packs(), 0);
6227        assert_eq!(store.absorb_pending().unwrap(), 0);
6228        for r in rows.iter().take(512) {
6229            let row = store
6230                .index()
6231                .lookup(&r.oid)
6232                .unwrap_or_else(|| panic!("{} has no row after recovery", hex::encode(&r.oid)));
6233            assert_eq!((row.offset, row.len), (acked[0].0 + r.offset, r.len));
6234        }
6235
6236        // ── the derived tables, which were the second symptom ────────────────
6237        assert_eq!(
6238            store.commit_count(),
6239            commits_in(&rows),
6240            "the commit graph did not come back: {} of {}",
6241            store.commit_count(),
6242            commits_in(&rows)
6243        );
6244        let tip = store
6245            .graph_snapshot()
6246            .into_iter()
6247            .max_by_key(|c| c.generation)
6248            .expect("a graph");
6249        let tip_raw = hex::decode(&tip.oid).unwrap();
6250        let closure = store.reachable(&[&tip_raw], &[]).unwrap();
6251        assert!(
6252            !closure.is_empty(),
6253            "reachable() came back empty after the reopen"
6254        );
6255        assert!(closure.contains(&tip_raw));
6256        eprintln!(
6257            "load {}; killed mid-absorb: {} journal extent(s) recovered {} object rows, {} \
6258             commits, closure of the tip {} objects",
6259            loadavg(),
6260            acked.len(),
6261            store.object_count(),
6262            store.commit_count(),
6263            closure.len(),
6264        );
6265    }
6266
6267    /// **A clean reopen re-queues nothing, and the next push gets a fresh
6268    /// ordinal.**
6269    ///
6270    /// The other side of the diff. A store whose pack was fully absorbed before
6271    /// it closed must come back with the bit **set**: re-absorbing would be a
6272    /// whole pack re-resolved for nothing, and — because the commit graph is a
6273    /// `Vec` — it is the same doubling the drain's own guard exists to prevent.
6274    ///
6275    /// "Re-queued nothing" is asserted deterministically rather than by a timing
6276    /// window: the account indexer in this process publishes a pack only for a
6277    /// job somebody submitted, so `is_indexed(0)` being **false** after
6278    /// `wait_indexed` is proof that open submitted none.
6279    ///
6280    /// The second half is the ordinal. Pack ids are the journal's row numbers, so
6281    /// a reopened store must resume after them. Asserted on applied output rather
6282    /// than on the id alone: the newly pushed pack's object has to be findable,
6283    /// and it is exactly what goes missing when a fresh pack is handed an
6284    /// absorbed pack's ordinal — `queue` skips it, the drain skips it, and its
6285    /// durable bytes are never indexed by anybody.
6286    ///
6287    /// Seen RED by making `Absorber::adopt_journal` treat every journal extent as
6288    /// unabsorbed (`let has_rows = vec![false; journal.len()]`): "a fully
6289    /// absorbed pack was re-queued on open — the diff is not exact".
6290    ///
6291    /// Seen RED a second time by `AtomicU64::new(packs_already_acked(...)?)` →
6292    /// `AtomicU64::new(0)` in `PushPath::with_absorber`: "a reopened store handed
6293    /// a fresh pack the ordinal of an absorbed one — left: Some(0), right:
6294    /// Some(1)". With that same edit **and the id assertion deleted**, the
6295    /// applied-output one goes too — "the second push's object never reached the
6296    /// index — its ordinal collided with an absorbed pack's, so every writer
6297    /// skipped it" — which is what says this guard is about the objects and not
6298    /// about a counter. Restored.
6299    #[test]
6300    fn a_clean_reopen_requeues_nothing_and_the_next_push_gets_a_fresh_ordinal() {
6301        let dir = tmpdir("clean-reopen");
6302        let (pack, rows) = corpus_pack();
6303        let (second, blob_oid) = one_blob_pack(b"a push that arrives after the restart");
6304
6305        {
6306            let store = GitStore::open(&dir, "alice").unwrap();
6307            store.put_pack(&pack).unwrap();
6308            store.wait_indexed();
6309            assert_eq!(
6310                store.object_count(),
6311                rows.len(),
6312                "the first run did not index"
6313            );
6314        }
6315
6316        let store = GitStore::open(&dir, "alice").unwrap();
6317        store.wait_indexed();
6318        assert!(
6319            !store.indexer().is_indexed(0),
6320            "a fully absorbed pack was re-queued on open — the diff is not exact"
6321        );
6322        assert_eq!(store.unindexed_packs(), 0);
6323        assert_eq!(
6324            store.absorb_pending().unwrap(),
6325            0,
6326            "the reopen left index work"
6327        );
6328        assert_eq!(
6329            store.object_count(),
6330            rows.len(),
6331            "the reopened store lost rows"
6332        );
6333        assert!(store.has(&rows[0].oid).unwrap());
6334
6335        let tx = store.put_pack(&second).unwrap();
6336        assert_eq!(
6337            tx.pack_id,
6338            Some(1),
6339            "a reopened store handed a fresh pack the ordinal of an absorbed one"
6340        );
6341        store.wait_indexed();
6342        assert!(
6343            store.has(&blob_oid).unwrap(),
6344            "the second push's object never reached the index — its ordinal collided with an \
6345             absorbed pack's, so every writer skipped it"
6346        );
6347        assert_eq!(store.object_count(), rows.len() + 1);
6348        assert!(store.indexer().is_indexed(1));
6349        // And the journal is a log: both packs' extents are in it, in order.
6350        let acked = read_journal(&SafeWriter::journal_path(store.blobs_path())).unwrap();
6351        assert_eq!(
6352            acked.len(),
6353            2,
6354            "the reopen truncated the journal: {acked:?}"
6355        );
6356        assert_eq!(acked[1], tx.extent.unwrap());
6357    }
6358
6359    /// **What the derive-on-open diff costs at a realistic pack count.**
6360    ///
6361    /// Not a guard — a measurement, with two assertions on it that keep it from
6362    /// measuring the wrong thing: every absorbed pack must come back `true`, and
6363    /// the one pack that has no rows must come back `false`.
6364    ///
6365    /// Both cases are timed because they are different algorithms in practice.
6366    /// The **clean reopen** — every pack absorbed — terminates as soon as each
6367    /// extent has been hit once, which happens after a few rows per pack because
6368    /// the tail is in oid order and an oid says nothing about which pack its
6369    /// object came from. The **crash** case has one pack with no rows at all, and
6370    /// proving an absence means reading the tail to the end.
6371    ///
6372    /// MEASURED on oden 2026-08-08, release, 1000 real pushed packs / 3686 object
6373    /// rows, 1-minute loadavg 2.77: **0.38 ms** clean and 0.39 ms with one pack
6374    /// un-absorbed (0.40 / 0.39 ms at loadavg 13.06, so the figure barely moves
6375    /// with the box). At this row count the two cases are the same, because a
6376    /// 3686-row tail is scanned to the end faster than the early exit saves
6377    /// anything; they diverge with the object count, and the table on
6378    /// [`ObjectReadStack::extents_with_rows`] carries that at a million rows
6379    /// (0.74 ms against 109 ms).
6380    ///
6381    /// The printed line carries the loadavg of its own run, the pack count and
6382    /// the row count, because none of the three is comparable across machines or
6383    /// across a busy box.
6384    #[test]
6385    fn the_derive_on_open_diff_costs_milliseconds_at_a_realistic_pack_count() {
6386        const PACKS: usize = 1000;
6387        let dir = tmpdir("diff-cost");
6388        let (real, rows) = corpus_pack();
6389
6390        {
6391            let store = GitStore::open(&dir, "alice").unwrap();
6392            store.put_pack(&real).unwrap();
6393            for i in 0..PACKS - 1 {
6394                let (p, _) = one_blob_pack(format!("pack number {i}").as_bytes());
6395                store.put_pack(&p).unwrap();
6396            }
6397            store.wait_indexed();
6398            assert_eq!(
6399                store.object_count(),
6400                rows.len() + PACKS - 1,
6401                "the fixture did not absorb"
6402            );
6403        }
6404
6405        let acked = read_journal(&SafeWriter::journal_path(&dir.join("objects.pack"))).unwrap();
6406        assert_eq!(acked.len(), PACKS, "one journal row per pack");
6407        // The tail on its own, so what is timed is the diff rather than redb's
6408        // open and the projection build that a store's open also pays for.
6409        let tail = ObjectReadStack::<OneTableFourColumns>::open(
6410            &dir.join("objects.tail"),
6411            RebuildTriggers::default(),
6412            crate::arms::DEFAULT_REDB_CACHE_BYTES,
6413        )
6414        .unwrap();
6415
6416        let t = Instant::now();
6417        let hit = tail.extents_with_rows(&acked).unwrap();
6418        let clean = t.elapsed();
6419        assert!(
6420            hit.iter().all(|&h| h),
6421            "an absorbed pack was reported unabsorbed"
6422        );
6423
6424        // One pack in flight when the machine died: durable bytes, no rows.
6425        let mut in_flight = acked.clone();
6426        let end = acked[PACKS - 1].0 + acked[PACKS - 1].1;
6427        in_flight.push((end, 4096));
6428        let t = Instant::now();
6429        let hit = tail.extents_with_rows(&in_flight).unwrap();
6430        let crashed = t.elapsed();
6431        assert_eq!(
6432            hit.iter().filter(|h| !**h).count(),
6433            1,
6434            "the pack with no rows is not the only one reported unabsorbed"
6435        );
6436
6437        eprintln!(
6438            "load {}; {PACKS} packs / {} object rows: derive-on-open diff {:.2} ms clean \
6439             (early exit), {:.2} ms with one pack un-absorbed (full tail scan)",
6440            loadavg(),
6441            tail.len(),
6442            clean.as_secs_f64() * 1e3,
6443            crashed.as_secs_f64() * 1e3,
6444        );
6445    }
6446
6447    /// **The bit is a bitset over dense ordinals, and one bit is one pack.**
6448    ///
6449    /// Ordinals that straddle word boundaries (63, 64, 65) are the whole point:
6450    /// a shift that ignores the word split, or a word index that does not, sets
6451    /// a neighbour's bit — and a neighbour's bit set means a durable pack is
6452    /// declared absorbed with no rows behind it.
6453    ///
6454    /// Seen RED by `>> (i % 64) & 1` → `>> (i % 63) & 1` in
6455    /// `PackState::is_absorbed`: "the bit for ordinal 64 did not go up". Restored.
6456    ///
6457    /// Seen RED a second time by `if self.extent[i].is_none()` → `if
6458    /// self.extent[i].is_none() || true` in `PackState::note`, i.e. letting a
6459    /// re-queue of a pack that is already recorded count as new work — which is
6460    /// the race the ack path really produces, since the drain can absorb before
6461    /// `queue` runs: "an absorbed pack was queued again — left: 6, right: 5".
6462    /// Restored.
6463    #[test]
6464    fn the_indexed_bit_is_a_bitset_over_dense_pack_ordinals() {
6465        let ids = [0u64, 1, 63, 64, 65, 4095];
6466        let mut s = PackState::default();
6467        for id in ids {
6468            s.note(id, (id * 4096 + 12, 4096));
6469        }
6470        assert_eq!(s.unabsorbed, ids.len());
6471        assert!(
6472            ids.iter().all(|&i| !s.is_absorbed(i)),
6473            "a bit is up already"
6474        );
6475
6476        s.mark_absorbed(64, (64 * 4096 + 12, 4096));
6477        assert!(s.is_absorbed(64), "the bit for ordinal 64 did not go up");
6478        for other in [0u64, 1, 63, 65, 4095] {
6479            assert!(
6480                !s.is_absorbed(other),
6481                "setting ordinal 64 also set ordinal {other} — one bit spilled onto a neighbour"
6482            );
6483        }
6484        assert_eq!(s.unabsorbed, ids.len() - 1);
6485        assert_eq!(
6486            s.pending().iter().map(|p| p.pack_id).collect::<Vec<_>>(),
6487            vec![0, 1, 63, 65, 4095],
6488            "the pending list is not the clear bits"
6489        );
6490        assert_eq!(
6491            s.pending()[0],
6492            PendingPack {
6493                pack_id: 0,
6494                offset: 12,
6495                len: 4096,
6496                resumed: true,
6497            },
6498            "a pending pack lost the extent it must be absorbed from"
6499        );
6500
6501        // Both writers are idempotent, because both of them race.
6502        s.mark_absorbed(64, (64 * 4096 + 12, 4096));
6503        s.note(64, (64 * 4096 + 12, 4096));
6504        assert!(s.is_absorbed(64));
6505        assert_eq!(
6506            s.unabsorbed,
6507            ids.len() - 1,
6508            "an absorbed pack was queued again"
6509        );
6510
6511        // One bit per pack, and that is the whole cost: 4096 ordinals is 64
6512        // words. A hash set of the same ordinals is an order of magnitude more,
6513        // and a bloom would be smaller and wrong.
6514        assert_eq!(s.words.len(), 64);
6515        assert_eq!(s.words.len() * 8, 512, "4096 packs is 512 bytes of bits");
6516    }
6517
6518    /// **A read that arrives before the drain is served from the pack, on its
6519    /// own thread, and never waits for the worker.**
6520    ///
6521    /// The owner's rule, 2026-08-30: *nobody waits on the indexer.* Until then
6522    /// this test asserted the opposite — that a read parked behind the absorb
6523    /// gate stayed unanswered until the drain released it, which on a kernel
6524    /// pack is hours, and under the memory watchdog is *as long as the box is
6525    /// short*. Now the gate is the absorbers' and only the absorbers': the read
6526    /// finds no row, sees a pending pack, and resolves that pack read-only
6527    /// from the mmapped bytes for the one oid it wants
6528    /// (`Absorber::scan_pending`). The drain is still parked, the index is
6529    /// still empty, and the answer is **present** — from the verbatim truth.
6530    ///
6531    /// Seen RED by making `lookup_never_wait` return `Ok(None)` when the index
6532    /// misses: "a read with the drain parked answered absent for a durable
6533    /// object". And by putting `self.gate.lock()` back in front of it: the
6534    /// 2-second bound below trips with the reader still parked.
6535    #[test]
6536    fn a_read_before_the_drain_is_served_from_the_pack_and_never_waits() {
6537        let dir = tmpdir("drain-before");
6538        let store = Arc::new(GitStore::open(&dir, "alice").unwrap());
6539        let (pack, rows) = corpus_pack();
6540        let (second, blob_oid) = one_blob_pack(b"a second push while the drain is parked");
6541
6542        // The drain is parked here, before it can absorb anything.
6543        let gate = store.hold_absorb_gate();
6544        let tx = store.put_pack(&pack).unwrap();
6545        let pack_id = tx.pack_id.unwrap();
6546        assert_eq!(store.unindexed_packs(), 1, "the pack is not queued");
6547        assert_eq!(store.index().len(), 0, "the index already holds rows");
6548        assert!(!store.indexer().is_indexed(pack_id), "the bit is already up");
6549
6550        // (1) a second push does not wait either: the ack path never meets the gate.
6551        let t = Instant::now();
6552        let tx2 = store.put_pack(&second).unwrap();
6553        assert_eq!(tx2.pack_id, Some(pack_id + 1));
6554        assert!(t.elapsed() < Duration::from_secs(2), "the push waited on the parked drain");
6555
6556        // (2) reads into exactly that state: present, from the pack, bounded.
6557        let oid = rows[0].oid.clone();
6558        let last = rows[rows.len() - 1].oid.clone();
6559        let t = Instant::now();
6560        assert!(store.has(&oid).unwrap(), "a read with the drain parked answered absent for a durable object");
6561        assert!(store.has(&last).unwrap(), "the last object of the pack answered absent");
6562        assert!(store.has(&blob_oid).unwrap(), "the second (still pending) pack's object answered absent");
6563        let (kind, body) = store.content(&blob_oid).unwrap().expect("content from the pending pack");
6564        assert_eq!(kind, GitObjectKind::Blob);
6565        assert_eq!(body, b"a second push while the drain is parked");
6566        let stored = store.get(&oid).unwrap().expect("get from the pending pack");
6567        assert_eq!(stored.extent.0, rows[0].offset + tx.extent.unwrap().0);
6568        assert_eq!(
6569            store.size(&last).unwrap(),
6570            Some(rows[rows.len() - 1].uncompressed_size),
6571            "size from the pending pack"
6572        );
6573        let absent = vec![0xEEu8; 20];
6574        assert!(!store.has(&absent).unwrap(), "an oid in no pack must still be absent");
6575        let elapsed = t.elapsed();
6576        assert!(elapsed < Duration::from_secs(20), "reads took {elapsed:?} with the drain parked");
6577        // The drain is STILL parked and the index STILL empty: nothing above
6578        // absorbed anything, and nothing waited.
6579        assert_eq!(store.index().len(), 0, "a read absorbed the pack behind the parked gate");
6580        assert!(!store.indexer().is_indexed(pack_id));
6581        assert_eq!(store.unindexed_packs(), 2);
6582        eprintln!("{} reads served from two pending packs with the drain parked, in {elapsed:?}", 6);
6583
6584        // (3) a whole-graph request is refused by name, not waited on.
6585        let err = store.reachable(&[oid.as_slice()], &[]).unwrap_err();
6586        assert!(err.to_string().contains("index in progress"), "{err:#}");
6587
6588        drop(gate);
6589        // And afterwards it is served from the rows.
6590        store.wait_indexed();
6591        assert_eq!(store.unindexed_packs(), 0);
6592        assert!(store.indexer().is_indexed(pack_id));
6593        assert_eq!(store.index().len(), rows.len() + 1);
6594        assert_eq!(store.absorb_pending().unwrap(), 0);
6595        for r in rows.iter().take(256) {
6596            assert!(
6597                store.index().lookup(&r.oid).is_some(),
6598                "{} is not in the rows after the drain",
6599                hex::encode(&r.oid)
6600            );
6601        }
6602        assert!(store.reachable(&[oid.as_slice()], &[]).is_ok(), "reachable after the drain");
6603    }
6604
6605    /// **The memory watchdog pauses the indexer worker and nobody else.**
6606    ///
6607    /// A fake `/proc/meminfo` under the floor is put under the process-wide
6608    /// watchdog; the worker parks in front of its batch (`index_worker`'s
6609    /// pre-batch check) and stays parked. Meanwhile a push is acked, every
6610    /// kind of read answers from the pack, and the progress snapshot returns —
6611    /// all bounded, none of them behind the pause. Then the fake is raised,
6612    /// the worker resumes, and the pack is indexed normally.
6613    ///
6614    /// Seen RED with the pre-batch check taking the absorb gate before pausing
6615    /// (the reads' scan does not need the gate, but `absorb_pending`-based
6616    /// reads did): every read parked for the length of the pause.
6617    #[test]
6618    fn a_paused_indexer_blocks_no_push_and_no_read() {
6619        let dir = tmpdir("paused-indexer");
6620        let meminfo = dir.join("meminfo");
6621        let write = |avail_kib: u64| {
6622            std::fs::write(&meminfo, format!("MemTotal:       16000000 kB\nMemAvailable:   {avail_kib} kB\n"))
6623                .unwrap()
6624        };
6625        write(1_000_000);
6626        let dog = Arc::new(crate::memguard::MemWatchdog::with(
6627            &meminfo,
6628            3_200_000 * 1024,
6629            Duration::from_millis(10),
6630        ));
6631        let store = Arc::new(GitStore::open(&dir, "alice").unwrap());
6632        // This store's worker only: every other store in the process keeps
6633        // the real watchdog.
6634        store.set_mem_watchdog(dog.clone());
6635        let (pack, rows) = corpus_pack();
6636        let (second, blob_oid) = one_blob_pack(b"pushed while the indexer is paused");
6637
6638        let t_push = Instant::now();
6639        let tx = store.put_pack(&pack).unwrap();
6640        let pack_id = tx.pack_id.unwrap();
6641        // Give the worker time to reach its pre-batch check and park.
6642        let mut parked = false;
6643        for _ in 0..200 {
6644            if dog.is_paused() {
6645                parked = true;
6646                break;
6647            }
6648            std::thread::sleep(Duration::from_millis(10));
6649        }
6650        assert!(parked, "the worker never paused under a meminfo 1 GB < 3.2 GB");
6651        assert!(!store.indexer().is_indexed(pack_id), "indexed while paused");
6652        assert_eq!(store.index().len(), 0);
6653
6654        // The ack path: a push while paused.
6655        let tx2 = store.put_pack(&second).unwrap();
6656        assert_eq!(tx2.pack_id, Some(pack_id + 1));
6657        assert!(t_push.elapsed() < Duration::from_secs(5), "a push waited on the paused worker");
6658
6659        // Reads while paused: present, from the pack.
6660        let t = Instant::now();
6661        assert!(store.has(&rows[0].oid).unwrap());
6662        assert!(store.has(&blob_oid).unwrap());
6663        let (kind, body) = store.content(&blob_oid).unwrap().unwrap();
6664        assert_eq!((kind, body.as_slice()), (GitObjectKind::Blob, &b"pushed while the indexer is paused"[..]));
6665        assert_eq!(
6666            store.extents(&[rows[0].oid.as_slice(), rows[1].oid.as_slice(), blob_oid.as_slice()])
6667                .unwrap()
6668                .iter()
6669                .filter(|e| e.is_some())
6670                .count(),
6671            3,
6672            "the batch path answered absent while paused"
6673        );
6674        assert!(t.elapsed() < Duration::from_secs(20), "reads waited on the paused worker");
6675        // The progress row: information, never a gate.
6676        let snap = store.index_progress();
6677        assert_eq!(snap.root, store.root().display().to_string());
6678        assert!(dog.is_paused(), "the worker resumed on its own — the fake still says 1 GB");
6679        assert!(!store.indexer().is_indexed(pack_id), "indexed while still paused");
6680
6681        // A whole-graph request while the worker is paused: the gate is free
6682        // (a paused worker holds nothing), so the READER absorbs the pending
6683        // packs on its own thread and answers — the worker is still parked.
6684        let reach = store.reachable(&[rows[0].oid.as_slice()], &[]).unwrap();
6685        assert!(!reach.is_empty());
6686        assert_eq!(store.unindexed_packs(), 0, "the reader did not absorb for itself");
6687        assert!(dog.is_paused(), "the worker is still parked; the reader did the work");
6688        assert_eq!(store.index().len(), rows.len() + 1);
6689
6690        // Memory comes back: the worker resumes, finds nothing to do, and the
6691        // bits go up through the ordinary drain.
6692        write(9_000_000);
6693        store.wait_indexed();
6694        assert!(store.indexer().is_indexed(pack_id));
6695        assert!(store.indexer().is_indexed(pack_id + 1));
6696        assert_eq!(dog.pauses(), 1, "one pause, one resume");
6697        assert!(!dog.is_paused());
6698    }
6699
6700    /// **The bit is cleared after the rows go in, never before.**
6701    ///
6702    /// The ordering inside `absorb_gated` is the whole reason a read cannot be
6703    /// told "absent" while the drain is running, and the only way to see it is to
6704    /// read *during* one. Four gatling workers (LAW 3 — never rayon, and never a
6705    /// raw thread pool) hammer `has` over the pack's oids from the moment
6706    /// `put_pack` returns until the pack's bit is up.
6707    ///
6708    /// Asserted on applied output: not one of those reads may answer absent for
6709    /// an object whose bytes are already durable.
6710    ///
6711    /// Seen RED by clearing the bit *before* absorbing (a
6712    /// `s.pending.retain(|p| p.pack_id != job.pack_id)` added in `absorb_gated`
6713    /// above the `self.absorb_one(job)` call): "4 reader(s) were told a durable
6714    /// object was absent — **32 865 593** absent answers over 2687 objects".
6715    /// Restored. The count is that large because the readers spin until the bit
6716    /// goes up and, with the bit cleared first, every pass over the sample missed
6717    /// for the whole length of the absorb.
6718    ///
6719    /// The honest limit: this is a race, so a green run proves the window was not
6720    /// hit, not that no window exists. That is why the printed line carries how
6721    /// many of the reads actually landed while the pack was still un-indexed —
6722    /// **a run where that number is 0 proved nothing**, and it is reported rather
6723    /// than asserted because forcing it would mean pausing the drain, which is
6724    /// the one thing this test must not do. MEASURED 2026-08-08 on oden at
6725    /// loadavg 16.94: 336 of 336 reads landed early.
6726    #[test]
6727    fn no_read_is_told_absent_while_the_drain_is_running() {
6728        let dir = tmpdir("drain-during");
6729        let store = GitStore::open(&dir, "alice").unwrap();
6730        let (pack, rows) = corpus_pack();
6731        let oids: Vec<&[u8]> = rows.iter().map(|r| r.oid.as_slice()).collect();
6732
6733        let tx = store.put_pack(&pack).unwrap();
6734        let pack_id = tx.pack_id.unwrap();
6735
6736        let early = AtomicU64::new(0);
6737        let absent = AtomicU64::new(0);
6738        let reads = AtomicU64::new(0);
6739        let workers = 4usize;
6740        gatling_for_each(workers, workers, |w| loop {
6741            let still_pending = store.unindexed_packs() > 0;
6742            for oid in oids.iter().skip(w).step_by(workers * 8) {
6743                if still_pending {
6744                    early.fetch_add(1, AtomicOrdering::Relaxed);
6745                }
6746                reads.fetch_add(1, AtomicOrdering::Relaxed);
6747                if !store.has(oid).unwrap() {
6748                    absent.fetch_add(1, AtomicOrdering::Relaxed);
6749                }
6750            }
6751            if store.indexer().is_indexed(pack_id) {
6752                break;
6753            }
6754        });
6755
6756        let absent = absent.load(AtomicOrdering::Acquire);
6757        assert_eq!(
6758            absent,
6759            0,
6760            "{workers} reader(s) were told a durable object was absent — {absent} absent answers \
6761             over {} objects",
6762            rows.len()
6763        );
6764        assert_eq!(store.object_count(), rows.len());
6765        eprintln!(
6766            "load {}; {} reads across {workers} gatling workers, {} of them while the pack was \
6767             still un-indexed",
6768            loadavg(),
6769            reads.load(AtomicOrdering::Acquire),
6770            early.load(AtomicOrdering::Acquire),
6771        );
6772    }
6773
6774    /// **One pack is absorbed once, whichever of the two callers gets there
6775    /// first.**
6776    ///
6777    /// Both callers are made to attempt it, deterministically: with the gate
6778    /// held, the drain is parked inside `ObjectAbsorb::absorb` and a reader is
6779    /// parked inside `absorb_pending`, both past their own early exits. Releasing
6780    /// the gate lets exactly one do the work; the other must take the skip.
6781    ///
6782    /// The observable is the **commit graph**, not the object table:
6783    /// `ObjectReadStack::append` is keyed by oid and would swallow a second
6784    /// identical row, but the graph is a `Vec` and a second absorb pushes every
6785    /// commit into it again — which silently doubles the fold every reachability
6786    /// bitmap is built from.
6787    ///
6788    /// Seen RED by disabling the `s.absorbed.contains(&job.pack_id)` skip in
6789    /// `absorb_gated`: "the commit graph carries **1102** commits, the pack has
6790    /// **551**" — exactly double, both callers having done the whole fold.
6791    /// Restored.
6792    #[test]
6793    fn a_pack_is_absorbed_once_even_when_both_callers_race_for_it() {
6794        let dir = tmpdir("drain-once");
6795        let store = Arc::new(GitStore::open(&dir, "alice").unwrap());
6796        let (pack, rows) = corpus_pack();
6797
6798        let gate = store.hold_absorb_gate();
6799        store.put_pack(&pack).unwrap();
6800
6801        let s = store.clone();
6802        let reader = Job::spawn(move || s.absorb_pending().unwrap());
6803        // Both are now blocked on the gate: the drain inside `absorb`, the reader
6804        // inside `absorb_pending`, each having already decided there is work.
6805        std::thread::sleep(Duration::from_millis(100));
6806        drop(gate);
6807
6808        let by_read = reader.join().unwrap();
6809        store.wait_indexed();
6810
6811        assert_eq!(
6812            store.commit_count(),
6813            commits_in(&rows),
6814            "the commit graph carries {} commits, the pack has {}",
6815            store.commit_count(),
6816            commits_in(&rows)
6817        );
6818        assert_eq!(store.object_count(), rows.len());
6819        assert_eq!(store.unindexed_packs(), 0);
6820        eprintln!(
6821            "load {}; the read absorbed {by_read} pack(s), the drain absorbed the rest",
6822            loadavg()
6823        );
6824    }
6825
6826    // ── §14's exploded table ─────────────────────────────────────────────────
6827
6828    /// **A push produces an exploded row for every object in the pack, and each
6829    /// one hashes back to its own oid.**
6830    ///
6831    /// Eager, decided 2026-08-08: no threshold, no size cap, no type skipped —
6832    /// so the row count is the *object* count and not some subset of it. Nothing
6833    /// is read between `put_pack` and `wait_indexed`, so the only thing that
6834    /// could have built the rows is the background drain, which is the half of
6835    /// §14 that says "built by the same background indexer".
6836    ///
6837    /// The assertion is applied output in its strongest available form: every
6838    /// object's content is read back out of the table, re-serialised canonically
6839    /// and **re-hashed**, and the hash has to be the oid it was filed under. A
6840    /// row count alone could be satisfied by 2687 rows of the wrong bytes; a
6841    /// re-hash cannot.
6842    ///
6843    /// Seen RED by deleting the `sink.explode(&oid, kind, &payload)?` call in
6844    /// `resolve::resolve_walked`: "the drain built no exploded rows: 0 of 2687".
6845    /// Restored.
6846    ///
6847    /// Seen RED a second time by making the sink skip blobs in
6848    /// `ExplodedTable::explode` (`if kind == GitObjectKind::Blob { return Ok(()) }`
6849    /// at the top — which is what a *lazy* or size-capped table would look like
6850    /// from here): "the drain built no exploded rows: 1420 of 2687". Restored,
6851    /// because §14's open question was closed EAGER and disk is explicitly not a
6852    /// consideration — and because the 1267 rows that edit removes are exactly
6853    /// the blobs a content read wants most.
6854    #[test]
6855    fn a_push_produces_an_exploded_row_for_every_object_in_the_pack() {
6856        let dir = tmpdir("exploded-every-object");
6857        let store = GitStore::open(&dir, "alice").unwrap();
6858        let (pack, rows) = corpus_pack();
6859
6860        let t = Instant::now();
6861        store.put_pack(&pack).unwrap();
6862        let ack = t.elapsed();
6863        store.wait_indexed();
6864        // **Drain, printed beside ack**, because the two answer different
6865        // questions and only one of them was ever in doubt. Ack is unchanged by
6866        // construction — nothing on it touches this table. Drain is where the
6867        // eager resolve and the sink both live, and it is the column redb's
6868        // 2026-08-08 measurement recorded as 316.2–329.8 ms against 166.7–168.6
6869        // ms with the sink stubbed out. Without it here, "did the medium buy
6870        // anything but disk" has no answer in this repository.
6871        let drain = t.elapsed();
6872
6873        let distinct: HashSet<Vec<u8>> = rows.iter().map(|r| r.oid.clone()).collect();
6874        let stats = store.exploded_stats();
6875        // **The push explodes the GRAPH, not the content.** Under the shipped
6876        // policy the drain writes commits and trees and leaves blobs in the
6877        // pack; the assertion is therefore two-sided, because "some rows" would
6878        // pass on a table that wrote one row and on one that wrote all of them,
6879        // and it is exactly the second that costs 17× the pack.
6880        let graph_rows = store.exploded_of_kind(GitObjectKind::Commit).unwrap().len();
6881        assert_eq!(
6882            store.exploded_eager_rows().unwrap(),
6883            graph_rows as u64,
6884            "the drain wrote {} eager rows and there are {} commits — the eager pool \
6885             holds something other than the graph",
6886            store.exploded_eager_rows().unwrap(),
6887            graph_rows
6888        );
6889        assert!(
6890            stats.rows > 0 && stats.rows < distinct.len() as u64,
6891            "the eager pool holds {} of {} objects; lazy explode means neither 0 \
6892             (the graph would be blind) nor all of them (that is the 22.4x tier)",
6893            stats.rows,
6894            distinct.len()
6895        );
6896
6897        // Every one of them, re-hashed. Bytes that came back wrong cannot pass.
6898        let hash = store.hash_kind();
6899        let mut checked = 0usize;
6900        for oid in &distinct {
6901            let (kind, payload) = store
6902                .content(oid)
6903                .unwrap()
6904                .unwrap_or_else(|| panic!("{} has no exploded row", hex::encode(oid)));
6905            let rehashed = hash.oid_of(&crate::object::canonical(kind, &payload));
6906            assert_eq!(
6907                &rehashed,
6908                oid,
6909                "the exploded row filed under {} contains an object that hashes to {}",
6910                hex::encode(oid),
6911                hex::encode(&rehashed)
6912            );
6913            checked += 1;
6914        }
6915        assert_eq!(checked, distinct.len());
6916        // **Every object came back byte-correct**, and the ones the eager pool
6917        // does not hold came back by inflating their own delta chain out of the
6918        // mapped pack ([`crate::resolve::materialize_at`]). So the re-derivation
6919        // count is the blob count and not zero — asserting zero here is what a
6920        // test written for the eager tier does, and it would now be asserting
6921        // that lazy explode is off.
6922        let after_reads = store.exploded_stats();
6923        assert!(
6924            after_reads.rederived > 0,
6925            "no read re-derived anything, so either every object is eager or the \
6926             lazy path never ran"
6927        );
6928        assert_eq!(
6929            after_reads.rederived + after_reads.served,
6930            checked as u64,
6931            "reads {} = served {} + rederived {} must account for every object",
6932            checked,
6933            after_reads.served,
6934            after_reads.rederived
6935        );
6936        // **What it costs on disk, measured rather than assumed.** §14 says the
6937        // price is "both copies are held" and the decision was taken with "we
6938        // don't care if disk is tripled" — so the real multiple belongs in the
6939        // output where anybody can read it, not in a sentence. It is not 3x on a
6940        // real pack: the verbatim bytes are deflated *and* delta-encoded, the
6941        // table holds raw inflated content, and redb pages it.
6942        let inflated: u64 = rows.iter().map(|r| r.uncompressed_size).sum();
6943        let table = std::fs::metadata(store.exploded_path())
6944            .map(|m| m.len())
6945            .unwrap_or(0);
6946        eprintln!(
6947            "load {}; {} pack entries → {} exploded rows, all {} re-hashed to their own oid; \
6948             ack {:.1} ms, drain {:.1} ms, {:.0} rows/s; disk: pack {:.1} MiB verbatim, objects \
6949             inflate to {:.1} MiB, table file {:.1} MiB ({:.0}x the pack, {:.3}x the payload)",
6950            loadavg(),
6951            rows.len(),
6952            stats.rows,
6953            checked,
6954            ack.as_secs_f64() * 1e3,
6955            drain.as_secs_f64() * 1e3,
6956            stats.rows as f64 / drain.as_secs_f64(),
6957            pack.len() as f64 / (1 << 20) as f64,
6958            inflated as f64 / (1 << 20) as f64,
6959            table as f64 / (1 << 20) as f64,
6960            table as f64 / pack.len() as f64,
6961            table as f64 / inflated.max(1) as f64,
6962        );
6963    }
6964
6965    /// **The amplification measurement, at whatever scale you point it at.**
6966    ///
6967    /// [`a_push_produces_an_exploded_row_for_every_object_in_the_pack`] prints
6968    /// the same ratio on a 5.4 MiB fixture and is a *guard*, so it has to stay
6969    /// fast. This is the same arithmetic with no assertion about size and no
6970    /// fixture of its own: give it a pack and it reports what the table cost.
6971    ///
6972    /// ```text
6973    /// ZNIPPY_EXPLODE_BENCH_PACK=/path/to/pack-….pack \
6974    ///   cargo test -p znippy-plugin-git --lib the_table_costs_what_it_holds \
6975    ///   -- --ignored --nocapture
6976    /// ```
6977    ///
6978    /// It exists because the 12× figure that killed redb — 16.8 GB of resolved
6979    /// `linux.git` content in a 204 GB file — was taken by hand off a bench run
6980    /// that no longer exists, and a number nobody can re-take is a number that
6981    /// rots. `#[ignore]`d and pack-less by default: with no pack named it
6982    /// returns, so it never fails a suite for the absence of a corpus nobody
6983    /// promised to keep.
6984    #[test]
6985    #[ignore = "needs a pack: ZNIPPY_EXPLODE_BENCH_PACK=<path> cargo test … -- --ignored --nocapture"]
6986    fn the_table_costs_what_it_holds() {
6987        let Ok(path) = std::env::var("ZNIPPY_EXPLODE_BENCH_PACK") else {
6988            eprintln!("no ZNIPPY_EXPLODE_BENCH_PACK named; nothing measured");
6989            return;
6990        };
6991        let pack = std::fs::read(&path).unwrap_or_else(|e| panic!("reading {path}: {e}"));
6992        let dir = tmpdir("exploded-cost");
6993        let store = GitStore::open(&dir, "alice").unwrap();
6994
6995        let t = Instant::now();
6996        store.put_pack(&pack).unwrap();
6997        let ack = t.elapsed();
6998        store.wait_indexed();
6999        let drain = t.elapsed();
7000
7001        let stats = store.exploded_stats();
7002        let table = std::fs::metadata(store.exploded_path())
7003            .map(|m| m.len())
7004            .unwrap_or(0);
7005        // The payload the table actually holds, asked of the table rather than
7006        // of the pack — a pack entry's `uncompressed_size` is what git recorded,
7007        // and this is what we stored. Only the second one can be divided into
7008        // the file size and mean anything.
7009        let mut held = 0u64;
7010        for kind in [
7011            GitObjectKind::Commit,
7012            GitObjectKind::Tree,
7013            GitObjectKind::Blob,
7014            GitObjectKind::Tag,
7015        ] {
7016            held += store
7017                .exploded_of_kind(kind)
7018                .unwrap()
7019                .iter()
7020                .map(|(_, p)| p.len() as u64)
7021                .sum::<u64>();
7022        }
7023        let mib = |n: u64| n as f64 / (1 << 20) as f64;
7024        eprintln!(
7025            "load {}; pack {} — {:.1} MiB verbatim → {} rows holding {:.1} MiB, table file \
7026             {:.1} MiB = {:.3}x the payload and {:.1}x the pack; ack {:.0} ms, drain {:.0} ms",
7027            loadavg(),
7028            path,
7029            mib(pack.len() as u64),
7030            stats.rows,
7031            mib(held),
7032            mib(table),
7033            table as f64 / held.max(1) as f64,
7034            table as f64 / pack.len() as f64,
7035            ack.as_secs_f64() * 1e3,
7036            drain.as_secs_f64() * 1e3,
7037        );
7038    }
7039
7040    /// Where the child of the clean-shutdown guard finds its fixture and leaves
7041    /// its markers.
7042    const CLEAN_DIR: &str = "GUNNAR_CLEAN_SHUTDOWN_DIR";
7043
7044    /// **The other half of
7045    /// [`a_clean_shutdown_and_reopen_keeps_the_graph_and_reachable`]: the process
7046    /// that exits normally.**
7047    ///
7048    /// A real process, a real push, a real drain, and then a real `drop` — every
7049    /// worker joined, every redb handle closed, no signal, exit status 0. That is
7050    /// what makes the parent's reopen a *clean* reopen rather than a recovery,
7051    /// and it is the case the crash guard cannot reach: after a clean shutdown
7052    /// every pack's bit is legitimately set and **nothing is re-queued**, so the
7053    /// derived tables have to have been on disk or they are gone.
7054    ///
7055    /// `#[ignore]`d because it is a fixture, not a guard — run on its own it has
7056    /// no directory to work in and returns.
7057    #[test]
7058    #[ignore = "spawned by a_clean_shutdown_and_reopen_keeps_the_graph_and_reachable"]
7059    fn the_child_that_pushes_and_shuts_down_cleanly() {
7060        let Ok(dir) = std::env::var(CLEAN_DIR) else {
7061            return;
7062        };
7063        let dir = PathBuf::from(dir);
7064        let pack = std::fs::read(dir.join("fixture.pack")).expect("the parent's fixture");
7065
7066        let store = GitStore::open(&dir, "alice").expect("open");
7067        store.put_pack(&pack).expect("the ack path");
7068        store.wait_indexed();
7069        assert_eq!(store.unindexed_packs(), 0, "the child shut down mid-index");
7070
7071        let tip = store
7072            .graph_snapshot()
7073            .into_iter()
7074            .max_by_key(|c| c.generation)
7075            .expect("the child built no graph at all");
7076        let tip_raw = hex::decode(&tip.oid).unwrap();
7077        let closure = store.reachable(&[&tip_raw], &[]).unwrap();
7078        assert!(!closure.is_empty(), "the child's own reachable() was empty");
7079
7080        std::fs::write(dir.join("tip"), &tip.oid).expect("marker");
7081        std::fs::write(dir.join("closure"), closure.len().to_string()).expect("marker");
7082        std::fs::write(dir.join("commits"), store.commit_count().to_string()).expect("marker");
7083        std::fs::write(dir.join("objects"), store.object_count().to_string()).expect("marker");
7084
7085        // **The clean shutdown.** Not a signal and not an abort: the store drops,
7086        // which closes the channel, joins the account indexer's worker and closes
7087        // redb. The process then returns normally with status 0.
7088        drop(store);
7089        std::fs::write(dir.join("clean"), b"closed").expect("marker");
7090    }
7091
7092    /// **`commit_count()` and `reachable()` are correct after a CLEAN shutdown
7093    /// and reopen.** This is the guard the exploded table exists to make pass.
7094    ///
7095    /// It was the live bug: the commit graph was folded from commit and tree
7096    /// *payloads* which were stored nowhere, accumulated in RAM as packs were
7097    /// absorbed. A store killed mid-absorb got them back only because the
7098    /// interrupted pack was re-queued and re-resolved
7099    /// ([`a_store_reopened_after_a_kill_mid_absorb_requeues_the_pack`]); a store
7100    /// that shut down **cleanly** re-queued nothing, and MEASURED on oden
7101    /// 2026-08-08 came back with 2687 rows and **0 of 551 commits** —
7102    /// `reachable()` returning a commit alone instead of its closure, and `gc`
7103    /// seeing an empty live set. Both are quiet wrong answers.
7104    ///
7105    /// The shape is the crash guard's: a **real** child process, which here exits
7106    /// normally, and the parent asserts against what is on disk. Two assertions
7107    /// carry it and they have to be in this order:
7108    ///
7109    /// 1. **`commit_count()` immediately after `open`**, before anything is
7110    ///    waited on — so the graph can only have come from the fold over the
7111    ///    exploded table that `open` performs, not from a re-absorb;
7112    /// 2. **`is_indexed(0)` is false after `wait_indexed()`** — the account
7113    ///    indexer in *this* process publishes a pack only for a job somebody
7114    ///    submitted, so a clear bit proves open re-queued nothing and the graph
7115    ///    above is not a recovery artefact.
7116    ///
7117    /// `reachable()` is then asserted against the closure the child computed on
7118    /// the same tip, so it is the same answer and not merely a non-empty one.
7119    ///
7120    /// Seen RED by deleting `store.refold()?` from the end of
7121    /// `GitStore::open_with_arms`, so nothing folds the table on open: "the
7122    /// commit graph did not survive a clean shutdown: 0 of 551 commits — the
7123    /// exploded table is a warm cache, not a durable table", left 0 right 551.
7124    /// That is the recorded bug's own number, reproduced. Restored.
7125    ///
7126    /// Seen RED a second time by deleting `self.exploded.flush()?` from
7127    /// `Absorber::absorb_one`, which is the **durability** edit: the rows then
7128    /// live only in the un-flushed buffer, which answers perfectly inside the
7129    /// child and is gone when the process ends. It fires assertion (2) rather
7130    /// than (1) — "the reopen re-queued the pack, so the graph above is a
7131    /// recovery artefact rather than the table's" — and that is worth writing
7132    /// down, because assertion (1) *passed*: the 64 MiB flush threshold had
7133    /// tripped once mid-pack, leaving 1798 of 2687 rows on disk which happened
7134    /// to include all 551 commits. A guard with only assertion (1) would have
7135    /// called that edit green. Restored.
7136    /// **An annotated tag reaches the commit it points at.**
7137    ///
7138    /// # The bug this is the guard for
7139    ///
7140    /// Reachability bitmaps are built over the commit graph, and no tree points
7141    /// at a tag, so a tag is in nobody's closure. `reachable`'s `want` loop had
7142    /// one arm for "not a commit": insert the object itself, and stop. So a
7143    /// `want` that was an annotated tag answered with **one object** — the tag —
7144    /// and the commit it names, plus that commit's whole history, was left out.
7145    ///
7146    /// It stayed invisible because a tag is nearly always pushed alongside the
7147    /// branch that carries the same commit, and then the branch's closure
7148    /// covers it. It surfaces the moment a tag is the ONLY thing naming a
7149    /// commit — which is what gunnar's replication does, one ref at a time. Six
7150    /// repositories on the live fleet could not replicate on 2026-08-31, one of
7151    /// them with 25 tags hanging off a single commit no branch carried, all
7152    /// refused by the far end as `missing necessary objects … (peeling a tag)`.
7153    ///
7154    /// So the fixture asserts the premise it needs: the tag is the only `want`.
7155    ///
7156    /// # 🔴 Seen red
7157    ///
7158    /// Against the arm as it was (`union.insert(o)` and nothing more):
7159    /// `the tag's closure is 1 object, so it carries the tag and nothing it
7160    /// points at`. With the peel: the commit, its trees and its blobs.
7161    #[test]
7162    fn an_annotated_tag_reaches_the_commit_it_points_at() {
7163        let dir = tmpdir("tag-peel");
7164        let store = GitStore::open(&dir, "alice").unwrap();
7165        let (pack, rows) = corpus_pack();
7166        store.put(&pack, &[]).unwrap();
7167        store.wait_indexed();
7168
7169        // Any commit will do: the tag is the only `want`, so nothing else can
7170        // pull this commit's closure in behind our backs.
7171        let commit = rows
7172            .iter()
7173            .find(|r| r.kind == GitObjectKind::Commit)
7174            .expect("the corpus has commits");
7175        let commit_hex = hex::encode(&commit.oid);
7176        let commit_closure = store.reachable(&[&commit.oid], &[]).unwrap();
7177        assert!(
7178            commit_closure.len() > 1,
7179            "the fixture's commit closes over nothing, so this test could not tell a peel from a              no-op"
7180        );
7181
7182        let (tag_pack, tag_oid) = crate::store::tests::one_tag_pack(&commit_hex, "v1.0");
7183        store.put(&tag_pack, &[]).unwrap();
7184        store.wait_indexed();
7185
7186        let closure = store.reachable(&[&tag_oid], &[]).unwrap();
7187        assert!(
7188            closure.contains(&tag_oid),
7189            "the tag itself is not in its own closure"
7190        );
7191        assert!(
7192            closure.contains(&commit.oid),
7193            "the tag's closure is {} object(s), so it carries the tag and nothing it points at —              the commit {} it names is missing and a mirror built from this answer cannot be              read",
7194            closure.len(),
7195            &commit_hex[..12]
7196        );
7197        // Not merely the commit: everything the commit reaches, or a clone from
7198        // this answer is short by a tree.
7199        for oid in &commit_closure {
7200            assert!(
7201                closure.contains(oid),
7202                "the tag's closure is missing {} which the commit it points at reaches",
7203                hex::encode(oid)
7204            );
7205        }
7206    }
7207
7208    #[test]
7209    fn a_clean_shutdown_and_reopen_keeps_the_graph_and_reachable() {
7210        let dir = tmpdir("clean-shutdown-graph");
7211        let (pack, rows) = corpus_pack();
7212        std::fs::write(dir.join("fixture.pack"), &pack).unwrap();
7213
7214        let status = std::process::Command::new(std::env::current_exe().unwrap())
7215            .args([
7216                "--exact",
7217                "--ignored",
7218                "--nocapture",
7219                "git_ops::tests::the_child_that_pushes_and_shuts_down_cleanly",
7220            ])
7221            .env(CLEAN_DIR, &dir)
7222            .status()
7223            .expect("spawn the child that shuts down cleanly");
7224        assert!(
7225            status.success(),
7226            "the child did not exit cleanly — it {status:?}, so this is a crash guard and not a \
7227             clean-shutdown one"
7228        );
7229        assert!(
7230            dir.join("clean").exists(),
7231            "the child never reached its clean shutdown"
7232        );
7233
7234        let tip_hex = std::fs::read_to_string(dir.join("tip")).unwrap();
7235        let closure_before: usize = std::fs::read_to_string(dir.join("closure"))
7236            .unwrap()
7237            .parse()
7238            .unwrap();
7239        let commits_before: usize = std::fs::read_to_string(dir.join("commits"))
7240            .unwrap()
7241            .parse()
7242            .unwrap();
7243        assert_eq!(
7244            commits_before,
7245            commits_in(&rows),
7246            "the child's own graph was already wrong, so the reopen proves nothing"
7247        );
7248
7249        // ── the reopen, and (1): the graph before anything is waited on ──────
7250        let store = GitStore::open(&dir, "alice").unwrap();
7251        assert_eq!(
7252            store.commit_count(),
7253            commits_in(&rows),
7254            "the commit graph did not survive a clean shutdown: {} of {} commits — the exploded \
7255             table is a warm cache, not a durable table",
7256            store.commit_count(),
7257            commits_in(&rows)
7258        );
7259        let tip_raw = hex::decode(&tip_hex).unwrap();
7260        let closure = store.reachable(&[&tip_raw], &[]).unwrap();
7261        assert_eq!(
7262            closure.len(),
7263            closure_before,
7264            "reachable() answers differently after a clean reopen: {} objects against the {} the \
7265             same tip closed over before the shutdown",
7266            closure.len(),
7267            closure_before
7268        );
7269        assert!(closure.contains(&tip_raw));
7270
7271        // ── (2): and none of it came from a re-absorb ────────────────────────
7272        store.wait_indexed();
7273        assert!(
7274            !store.indexer().is_indexed(0),
7275            "the reopen re-queued the pack, so the graph above is a recovery artefact rather \
7276             than the table's"
7277        );
7278        assert_eq!(store.unindexed_packs(), 0);
7279        assert_eq!(
7280            store.absorb_pending().unwrap(),
7281            0,
7282            "the reopen left index work"
7283        );
7284        assert_eq!(store.object_count(), rows.len());
7285        assert_eq!(
7286            store.exploded_stats().written,
7287            0,
7288            "this process wrote exploded rows, so the table was rebuilt rather than read"
7289        );
7290
7291        eprintln!(
7292            "load {}; clean shutdown → reopen: {} rows, {} commits, tip closure {} objects \
7293             (rebuilt nothing)",
7294            loadavg(),
7295            store.object_count(),
7296            store.commit_count(),
7297            closure.len(),
7298        );
7299    }
7300
7301    /// **A reopen READS `objects.graph`; it does not recompute it — and the
7302    /// read graph equals the recomputed one.** This is S-065's fix, and the only
7303    /// thing that can say which path a fold took is a counter, so the assertion
7304    /// is on [`GitStore::graph_source_stats`], not on the (identical) graph
7305    /// bytes — the identity-value trap, since both paths yield the same graph.
7306    ///
7307    /// One test exercises **both** arms so the counter cannot be blindly stuck:
7308    ///
7309    /// 1. A first store builds the graph, persists it, and shuts down cleanly.
7310    /// 2. `objects.graph` is deleted, so the reopen has no cache: it **recomputes**
7311    ///    (`(read, recomputed) == (0, 1)`) and re-persists. Its graph and its
7312    ///    `reachable()` are captured — this is the recomputed truth.
7313    /// 3. A second reopen finds the cache the step above wrote: it **reads**
7314    ///    (`(1, 0)`), and its graph and `reachable()` must equal step 2's exactly
7315    ///    — read == recomputed.
7316    ///
7317    /// # 🔴 Seen red
7318    ///
7319    /// With the persistence removed (open always folds), step 3 is `(0, 1)`:
7320    /// "the reopen recomputed the graph instead of reading objects.graph", left
7321    /// `(0, 1)` right `(1, 0)`. With the token check inverted so a stale cache is
7322    /// accepted, step 3's `reachable()` diverges from step 2's and the read==
7323    /// recomputed assertion fires. Restored.
7324    #[test]
7325    fn a_reopen_reads_the_persisted_graph_it_does_not_recompute() {
7326        let dir = tmpdir("persisted-graph");
7327        let (pack, rows) = corpus_pack();
7328        let tip_hex;
7329        {
7330            let store = GitStore::open(&dir, "alice").unwrap();
7331            store.put_pack(&pack).unwrap();
7332            store.wait_indexed();
7333            tip_hex = store
7334                .graph_snapshot()
7335                .into_iter()
7336                .max_by_key(|c| c.generation)
7337                .expect("a graph")
7338                .oid;
7339            assert!(
7340                dir.join("objects.graph").exists(),
7341                "an absorb never persisted the graph, so a reopen has nothing to read"
7342            );
7343        }
7344        let tip_raw = hex::decode(&tip_hex).unwrap();
7345
7346        // ── (2) no cache → recompute, and capture the recomputed truth ───────
7347        std::fs::remove_file(dir.join("objects.graph")).unwrap();
7348        let (recomputed_graph, recomputed_closure) = {
7349            let store = GitStore::open(&dir, "alice").unwrap();
7350            assert_eq!(
7351                store.graph_source_stats(),
7352                (0, 1),
7353                "with no objects.graph the reopen should have recomputed the graph"
7354            );
7355            assert_eq!(store.commit_count(), commits_in(&rows));
7356            let g = store.graph_snapshot();
7357            let c = store.reachable(&[&tip_raw], &[]).unwrap();
7358            assert!(!c.is_empty());
7359            (g, c)
7360        };
7361
7362        // ── (3) cache present → read, and it must equal the recomputed truth ──
7363        let store = GitStore::open(&dir, "alice").unwrap();
7364        assert_eq!(
7365            store.graph_source_stats(),
7366            (1, 0),
7367            "the reopen recomputed the graph instead of reading objects.graph"
7368        );
7369        assert_eq!(
7370            store.graph_snapshot(),
7371            recomputed_graph,
7372            "the graph READ from objects.graph differs from the one refold RECOMPUTES"
7373        );
7374        assert_eq!(
7375            store.reachable(&[&tip_raw], &[]).unwrap(),
7376            recomputed_closure,
7377            "reachable() over the persisted graph differs from reachable() over the recomputed one"
7378        );
7379        assert_eq!(store.commit_count(), commits_in(&rows));
7380    }
7381
7382    /// **The graph cache switched off leaves no `objects.graph`** — and the store
7383    /// still answers the same graph and closure, folded from the exploded table.
7384    /// The switch is flipped on the absorber directly: `ZNIPPY_GIT_GRAPH_CACHE`
7385    /// is read at open, and setting it process-wide would race the test above.
7386    ///
7387    /// Seen red with the persist guard removed: "the graph cache is off and
7388    /// objects.graph was written anyway".
7389    #[test]
7390    fn with_the_graph_cache_off_no_objects_graph_is_written_and_the_graph_is_the_same() {
7391        let on_dir = tmpdir("graph-cache-on");
7392        let off_dir = tmpdir("graph-cache-off");
7393        let (pack, rows) = corpus_pack();
7394        let on = GitStore::open(&on_dir, "alice").unwrap();
7395        on.put_pack(&pack).unwrap();
7396        on.wait_indexed();
7397        let off = GitStore::open(&off_dir, "alice").unwrap();
7398        off.absorber.graph_cache.store(false, std::sync::atomic::Ordering::Relaxed);
7399        std::fs::remove_file(off_dir.join("objects.graph")).ok();
7400        off.put_pack(&pack).unwrap();
7401        off.wait_indexed();
7402        assert!(on_dir.join("objects.graph").exists(), "the default still persists the graph");
7403        assert!(
7404            !off_dir.join("objects.graph").exists(),
7405            "the graph cache is off and objects.graph was written anyway"
7406        );
7407        assert_eq!(off.graph_source_stats().0, 0, "a store with the cache off never reads one");
7408        assert_eq!(on.graph_snapshot(), off.graph_snapshot());
7409        assert_eq!(off.commit_count(), commits_in(&rows));
7410    }
7411
7412    /// **The token gates the read: a cache whose token does not match the
7413    /// object set is rejected and the graph is recomputed.** This is what makes
7414    /// `objects.graph` a memo rather than a second truth — and a push, a gc, or
7415    /// a torn write all reach the store through exactly this door.
7416    ///
7417    /// The object set is left unchanged and the token in the cache is corrupted
7418    /// directly, so the ONE thing under test is the token comparison and not
7419    /// some incidental object-count difference.
7420    ///
7421    /// # 🔴 Seen red
7422    ///
7423    /// With the token comparison dropped (`Some((_, g)) => g`), the corrupted
7424    /// cache is read and the reopen is `(1, 0)`: "a cache with the wrong token
7425    /// was trusted". Restored.
7426    #[test]
7427    fn a_graph_whose_token_does_not_match_is_rejected() {
7428        let dir = tmpdir("wrong-token-graph");
7429        let (pack, _rows) = corpus_pack();
7430        {
7431            let store = GitStore::open(&dir, "alice").unwrap();
7432            store.put_pack(&pack).unwrap();
7433            store.wait_indexed();
7434        }
7435        // Flip a byte inside the 32-byte token (offset 5..37) without touching
7436        // the graph body, so only the token is wrong.
7437        let path = dir.join("objects.graph");
7438        let mut bytes = std::fs::read(&path).unwrap();
7439        assert!(bytes.len() > 37 && &bytes[..4] == b"GRPH");
7440        bytes[6] ^= 0xff;
7441        std::fs::write(&path, &bytes).unwrap();
7442
7443        let store = GitStore::open(&dir, "alice").unwrap();
7444        assert_eq!(
7445            store.graph_source_stats(),
7446            (0, 1),
7447            "a cache with the wrong token was trusted instead of being recomputed"
7448        );
7449    }
7450
7451    /// **The ordinal space comes off the persisted index, not off a scan — and
7452    /// no `objects.ordinal` is ever written.** This replaces S-082's memo test:
7453    /// the memo spared a cold open the redb scan that rebuilt the sorted oid
7454    /// list, and since 2026-09-04 that list IS the persisted index's oid column,
7455    /// so there is nothing to spare and no file to validate. What is asserted:
7456    ///
7457    /// 1. A first store absorbs the corpus; its ordinal space equals the tail in
7458    ///    oid order and every oid is accounted to one of the two sources. Then
7459    ///    it folds explicitly, so redb is empty and the index holds everything.
7460    /// 2. The reopen is warm: its space comes **entirely off the index** —
7461    ///    `(folded, tail) == (n, 0)` — and equals step 1's space, closure and
7462    ///    counts exactly. `objects.ordinal` does not exist after either session.
7463    ///
7464    /// # 🔴 Seen red
7465    ///
7466    /// With `ObjectReadStack::oids_raw` returning only the redb tail on a
7467    /// persisting stack, step 2's space is empty (redb holds nothing after the
7468    /// fold) and `reachable()` over it is empty: "the ordinal space after the
7469    /// warm reopen is not the tail in oid order". Restored.
7470    #[test]
7471    fn the_ordinal_space_comes_off_the_index_not_a_scan() {
7472        let dir = tmpdir("ordinal-off-the-index");
7473        let (pack, rows) = corpus_pack();
7474        let tip_hex;
7475        let (first_oids, first_closure, first_objects, first_commits);
7476        {
7477            let store = GitStore::open(&dir, "alice").unwrap();
7478            store.put_pack(&pack).unwrap();
7479            store.wait_indexed();
7480            tip_hex = store
7481                .graph_snapshot()
7482                .into_iter()
7483                .max_by_key(|c| c.generation)
7484                .expect("a graph")
7485                .oid;
7486            let tip_raw = hex::decode(&tip_hex).unwrap();
7487            let n = store.object_count() as u64;
7488            let (folded, tail) = store.ordinal_source_stats();
7489            assert_eq!(folded + tail, n, "every oid is accounted to the index or the tail");
7490            let oids = store.ordinal_oids();
7491            let scanned: Vec<String> =
7492                store.index().oids_in_order().unwrap().iter().map(hex::encode).collect();
7493            assert_eq!(oids, scanned, "the ordinal space is not the repository in oid order");
7494            assert!(
7495                !dir.join("objects.ordinal").exists(),
7496                "no memo may be written: the index's oid column is the ordinal space"
7497            );
7498            // Fold, so the reopen has everything on the index and nothing in redb.
7499            store.index().rebuild().unwrap();
7500            first_closure = store.reachable(&[&tip_raw], &[]).unwrap();
7501            assert!(!first_closure.is_empty());
7502            first_oids = oids;
7503            first_objects = store.object_count();
7504            first_commits = store.commit_count();
7505        }
7506        let tip_raw = hex::decode(&tip_hex).unwrap();
7507
7508        let store = GitStore::open(&dir, "alice").unwrap();
7509        let n = store.object_count() as u64;
7510        assert_eq!(
7511            store.ordinal_source_stats(),
7512            (n, 0),
7513            "after a fold the warm reopen's ordinal space must come entirely off the index"
7514        );
7515        assert_eq!(
7516            store.ordinal_oids(),
7517            first_oids,
7518            "the ordinal space after the warm reopen is not the tail in oid order"
7519        );
7520        assert_eq!(
7521            store.reachable(&[&tip_raw], &[]).unwrap(),
7522            first_closure,
7523            "reachable() over the index's ordinal space differs from the first session's"
7524        );
7525        assert_eq!(store.object_count(), first_objects);
7526        assert_eq!(store.commit_count(), first_commits);
7527        assert_eq!(store.commit_count(), commits_in(&rows));
7528        assert!(!dir.join("objects.ordinal").exists(), "still no memo after the reopen");
7529    }
7530
7531    /// **A stale `objects.ordinal` left by an older binary is removed at open.**
7532    /// The file is dead weight now (279 MB on the kernel mirror) and its
7533    /// contents are never read, so a store that carries one loses it the first
7534    /// time this build opens it — and keeps working.
7535    ///
7536    /// # 🔴 Seen red
7537    ///
7538    /// With the `remove_file` in `open_with_arms` dropped, the file survives the
7539    /// open: "a stale objects.ordinal must be removed at open". Restored.
7540    #[test]
7541    fn a_stale_objects_ordinal_from_an_older_binary_is_removed_at_open() {
7542        let dir = tmpdir("stale-ordinal");
7543        let (pack, _rows) = corpus_pack();
7544        {
7545            let store = GitStore::open(&dir, "alice").unwrap();
7546            store.put_pack(&pack).unwrap();
7547            store.wait_indexed();
7548        }
7549        // The old memo's shape: magic, version, oid_len, epoch, count, oids.
7550        let path = dir.join("objects.ordinal");
7551        let mut bytes = b"ORDL".to_vec();
7552        bytes.push(1);
7553        bytes.push(20);
7554        bytes.extend_from_slice(&7u64.to_le_bytes());
7555        bytes.extend_from_slice(&1u64.to_le_bytes());
7556        bytes.extend_from_slice(&[0xabu8; 20]);
7557        std::fs::write(&path, &bytes).unwrap();
7558        assert!(path.exists(), "precondition");
7559
7560        let store = GitStore::open(&dir, "alice").unwrap();
7561        assert!(!path.exists(), "a stale objects.ordinal must be removed at open");
7562        assert!(store.object_count() > 0, "and the store still answers");
7563    }
7564
7565    /// **A content read is served from the table, not re-derived** — and the only
7566    /// thing that can say so is a counter.
7567    ///
7568    /// Both paths return the **identical** bytes: the table hands back what the
7569    /// resolver produced, and the fallback re-resolves the same pack and produces
7570    /// it again. A byte comparison therefore proves nothing at all about which
7571    /// one ran — this is the identity-value trap in its exact form, and it fired
7572    /// on this codebase once already. So the assertion is on
7573    /// [`ExplodedStats::served`] against [`ExplodedStats::rederived`], both of
7574    /// which are bumped where the work happens.
7575    ///
7576    /// The fallback is not asserted away: it is exercised in the same test, on a
7577    /// store whose table has been dropped, and the counters move the other way.
7578    /// A guard that only saw the fast path could not tell a working counter from
7579    /// one that is never incremented.
7580    ///
7581    /// Seen RED by deleting the `if let Some(hit) = self.exploded.content(oid)?`
7582    /// early return in `Absorber::resolved`, so every read re-derives: "512 content
7583    /// reads re-resolved a whole pack instead of hitting the table — served 0,
7584    /// rederived 512". The bytes were still correct on every one of them, which
7585    /// is the point. Restored.
7586    ///
7587    /// Seen RED a second time by bumping `served` unconditionally at the top of
7588    /// `ExplodedTable::content`, before the `pending`/redb probe — the counter
7589    /// then reports a hit whether or not the table had the object. The first half
7590    /// fires on the double count, "512 content reads re-resolved a whole pack
7591    /// instead of hitting the table — served 1024, rederived 0", and
7592    /// `exploded::tests::a_row_round_trips_and_the_kind_index_finds_it` fires with
7593    /// it ("a content read was not counted", left 5 right 2). Restored — a
7594    /// counter that cannot be wrong about a miss is the only kind worth
7595    /// asserting on.
7596    #[test]
7597    fn a_content_read_is_served_from_the_table_and_not_re_derived() {
7598        const READS: usize = 512;
7599        let dir = tmpdir("exploded-served");
7600        let (pack, rows) = corpus_pack();
7601        let oids: Vec<Vec<u8>> = rows
7602            .iter()
7603            .map(|r| r.oid.clone())
7604            .collect::<HashSet<Vec<u8>>>()
7605            .into_iter()
7606            .take(READS)
7607            .collect();
7608
7609        {
7610            let store = GitStore::open(&dir, "alice").unwrap();
7611            store.put_pack(&pack).unwrap();
7612            store.wait_indexed();
7613
7614            // ── FIRST read: the lazy path, timed ────────────────────────
7615            let before = store.exploded_stats();
7616            let t = Instant::now();
7617            let mut first: Vec<(GitObjectKind, Vec<u8>)> = Vec::with_capacity(oids.len());
7618            for oid in &oids {
7619                first.push(
7620                    store
7621                        .content(oid)
7622                        .unwrap()
7623                        .expect("the store lost an object"),
7624                );
7625            }
7626            let cold = t.elapsed();
7627            let after = store.exploded_stats();
7628            let rederived = after.rederived - before.rederived;
7629            assert_eq!(
7630                rederived + (after.served - before.served),
7631                oids.len() as u64,
7632                "{} reads = served {} + rederived {} must account for every one",
7633                oids.len(),
7634                after.served - before.served,
7635                rederived
7636            );
7637            assert!(
7638                rederived > 0,
7639                "not one read re-derived: either every object is eager or the lazy \
7640                 path never ran, and this test then proves nothing about either"
7641            );
7642
7643            // The write-back is off the read path, so it has to be waited for
7644            // HERE and only here — a reader never does.
7645            store.explode_cache_maintain().unwrap();
7646            // **How many of those reads the cache DECLINED.** A shallow, small
7647            // object is cheaper to inflate again than to keep, so it is read
7648            // directly and nothing is written
7649            // (`exploded_cache::worth_caching`). Those objects are re-derived
7650            // on every read for ever, on purpose, and the second pass below
7651            // has to expect exactly that many — not zero, which is what this
7652            // test asserted before the admission policy existed and would now
7653            // be asserting that the policy is off.
7654            let declined = store.explode_cache_use().direct_reads;
7655            assert!(
7656                declined > 0,
7657                "not one of {} reads was declined as cheap; either every object in \
7658                 this corpus is expensive or the admission policy is not running",
7659                oids.len()
7660            );
7661
7662            // ── SECOND read: the design note's "= today" column ──────────
7663            let mid = store.exploded_stats();
7664            let t = Instant::now();
7665            for (i, oid) in oids.iter().enumerate() {
7666                let again = store.content(oid).unwrap().expect("the store lost an object");
7667                assert_eq!(again, first[i], "the second read of an object disagreed with the first");
7668            }
7669            let warm = t.elapsed();
7670            let end = store.exploded_stats();
7671            assert_eq!(
7672                end.rederived - mid.rederived,
7673                declined,
7674                "the second pass re-derived {} objects and the cache declined {declined} — \
7675                 every EXPENSIVE object must come out of the table the second time, and \
7676                 every cheap one must be read directly again",
7677                end.rederived - mid.rederived
7678            );
7679            assert_eq!(
7680                end.served - mid.served,
7681                oids.len() as u64 - declined,
7682                "the expensive objects did not come out of the table on the second pass"
7683            );
7684            eprintln!(
7685                "load {}; {} content reads: FIRST {:.1} ms ({:.1} µs/read, {} re-derived from \
7686                 the pack, {declined} of them too cheap to cache) → SECOND {:.1} ms \
7687                 ({:.1} µs/read) = {:.1}x",
7688                loadavg(),
7689                oids.len(),
7690                cold.as_secs_f64() * 1e3,
7691                cold.as_secs_f64() * 1e6 / oids.len() as f64,
7692                rederived,
7693                warm.as_secs_f64() * 1e3,
7694                warm.as_secs_f64() * 1e6 / oids.len() as f64,
7695                cold.as_secs_f64() / warm.as_secs_f64().max(f64::MIN_POSITIVE),
7696            );
7697        }
7698
7699        // ── and the fallback, so the counter is not a constant ───────────────
7700        //
7701        // The table is dropped and the *drain* is what would rebuild it, so the
7702        // reads have to happen before it gets there. `absorb_pending` is called
7703        // by hand first so the fallback under test is the content path's and not
7704        // the index's.
7705        std::fs::remove_file(dir.join("objects.exploded")).unwrap();
7706        // **And the lazy pool with it.** Dropping only the eager table leaves
7707        // the write-backs of the pass above sitting in `objects.exploded.cN`,
7708        // and those would answer — the fallback would then be measured on a
7709        // store that still has a cache, which is the exact shape of a test that
7710        // cannot fail. One `drop_explode_cache` is the sanctioned door, and it
7711        // is what `repo gc` calls.
7712        for e in std::fs::read_dir(&dir).unwrap().flatten() {
7713            if e.file_name().to_string_lossy().starts_with("objects.exploded.c") {
7714                std::fs::remove_file(e.path()).unwrap();
7715            }
7716        }
7717        let store = GitStore::open(&dir, "alice").unwrap();
7718        let gate = store.hold_absorb_gate();
7719        let before = store.exploded_stats();
7720        let mut rederived = 0u64;
7721        for oid in oids.iter().take(8) {
7722            // Straight at the absorber: the store's `content` would absorb the
7723            // re-queued pack first and rebuild the very table this is testing
7724            // the absence of.
7725            assert!(
7726                store.absorber.resolved(oid).unwrap().is_some(),
7727                "the verbatim truth could not re-derive {}",
7728                hex::encode(oid)
7729            );
7730            rederived += 1;
7731        }
7732        let after = store.exploded_stats();
7733        // The drain starts the instant the store opens; on a loaded box it can
7734        // rebuild the small corpus's table before the gate above is taken, and
7735        // then the reads are legitimately served from it. Seen 2026-08-30 under
7736        // a parallel suite. That run proves nothing about the fallback and says
7737        // so, rather than failing on a race the test does not control.
7738        let drain_won = store.unindexed_packs() == 0;
7739        drop(gate);
7740        if drain_won {
7741            eprintln!("the drain rebuilt the table before the gate was held; the fallback was not observed this run");
7742            return;
7743        }
7744        assert_eq!(
7745            after.served - before.served,
7746            0,
7747            "a dropped table still reported {} reads served",
7748            after.served - before.served
7749        );
7750        assert_eq!(
7751            after.rederived - before.rederived,
7752            rederived,
7753            "the fallback ran but was not counted"
7754        );
7755    }
7756
7757    /// ★ **THE READ-AFTER-ACK GAP (lane U → lane Q): every read path answers
7758    /// with the indexer PAUSED, and none of them waits for it.**
7759    ///
7760    /// MEASURED on the rig 2026-08-30 (lane U, both ISOs, timing-dependent):
7761    /// right after an ACKED push a `clone` came back
7762    /// `remote error: object … is not in this repository (peeling a tag)` and a
7763    /// `push --mirror` on top got `[remote rejected] … missing necessary
7764    /// objects`. Both of those are gunnar's `Graph::load` — `GitServe::read` —
7765    /// answering `None` for an object whose bytes were fsynced before the client
7766    /// was told the push had landed. §13.12 says an index miss falls back to the
7767    /// journal; the tag-peel and connectivity-check paths were not observed to.
7768    ///
7769    /// So this holds the absorb gate — the indexer paused, exactly the state
7770    /// lane P's watchdog puts it in — and requires **`has`, `header` and `read`
7771    /// to answer for every object of a just-acked pack**, byte-correct, and to
7772    /// do it inside a deadline. The deadline is not decoration: "nobody waits"
7773    /// (the design note's rule) is violated by a read that blocks on the gate
7774    /// just as badly as by one that answers absent, and a blocking read looks
7775    /// exactly like a correct one to an assertion that has no clock.
7776    ///
7777    /// Seen RED by returning `Ok(None)` from `Absorber::resolved`'s pending arm:
7778    /// 1352 of 1352 objects report "the store said absent for an object it had
7779    /// already acked".
7780    #[test]
7781    fn every_read_path_answers_a_just_acked_push_with_the_indexer_paused() {
7782        use crate::serve::GitServe as _;
7783        let dir = tmpdir("read-after-ack");
7784        let store = Arc::new(GitStore::open(&dir, "alice").unwrap());
7785        let (pack, rows) = corpus_pack();
7786
7787        // The ack: `put_pack` returning is what the client is told.
7788        store.put_pack(&pack).unwrap();
7789
7790        // The indexer, paused. A watchdog pause (lane P) pauses the indexer and
7791        // nothing else, so this is the shape the appliance is really in.
7792        let gate = store.hold_absorb_gate();
7793        assert!(
7794            store.unindexed_packs() > 0,
7795            "the drain absorbed the pack before the gate was taken, so this run \
7796             read an INDEXED store and proves nothing about the window"
7797        );
7798
7799        let distinct: Vec<Vec<u8>> = rows
7800            .iter()
7801            .map(|r| r.oid.clone())
7802            .collect::<HashSet<Vec<u8>>>()
7803            .into_iter()
7804            .collect();
7805        let hash = store.hash_kind();
7806        let n = distinct.len();
7807
7808        // On another thread, so the deadline measures the reads and not this
7809        // test's own patience.
7810        let (tx, rx) = std::sync::mpsc::channel::<Result<(usize, usize, usize)>>();
7811        let reader = {
7812            let store = store.clone();
7813            let distinct = distinct.clone();
7814            std::thread::spawn(move || {
7815                let mut had = 0usize;
7816                let mut headed = 0usize;
7817                let mut readback = 0usize;
7818                let r = (|| -> Result<()> {
7819                    for oid in &distinct {
7820                        if store.has(oid)? {
7821                            had += 1;
7822                        }
7823                        if crate::serve::GitServe::header(&*store, oid)?.is_some() {
7824                            headed += 1;
7825                        }
7826                        // The tag-peel / connectivity-check path, byte for byte.
7827                        let Some((kind, payload)) = crate::serve::GitServe::read(&*store, oid)? else {
7828                            continue;
7829                        };
7830                        let k = match kind {
7831                            crate::index_layout::ObjType::Commit => GitObjectKind::Commit,
7832                            crate::index_layout::ObjType::Tree => GitObjectKind::Tree,
7833                            crate::index_layout::ObjType::Blob => GitObjectKind::Blob,
7834                            crate::index_layout::ObjType::Tag => GitObjectKind::Tag,
7835                            // A read resolves the chain, so a delta type coming
7836                            // back out of it is the store contradicting itself.
7837                            other => anyhow::bail!("`read` answered with a {other:?}"),
7838                        };
7839                        let rehashed = hash.oid_of(&crate::object::canonical(k, &payload));
7840                        if &rehashed == oid {
7841                            readback += 1;
7842                        }
7843                    }
7844                    Ok(())
7845                })();
7846                let _ = tx.send(r.map(|_| (had, headed, readback)));
7847            })
7848        };
7849
7850        // The deadline. Generous — a cold pending scan of the corpus is
7851        // milliseconds — and it is against a WALL clock while the gate is held,
7852        // so a read that parks on the absorber trips it.
7853        let out = rx
7854            .recv_timeout(Duration::from_secs(20))
7855            .expect(
7856                "a read path blocked on the paused indexer for 20 s: 'nobody waits' is the \
7857                 design note's rule and a read that waits for the drain is a bug by definition",
7858            );
7859        let (had, headed, readback) = out.expect("a read path errored inside the index window");
7860        drop(gate);
7861        let _ = reader.join();
7862
7863        assert_eq!(
7864            (had, headed, readback),
7865            (n, n, n),
7866            "the store answered for {had}/{n} `has`, {headed}/{n} `header` and {readback}/{n} \
7867             byte-correct `read`s of a pack it had already ACKED — an object the client was \
7868             told had landed must never read as absent"
7869        );
7870    }
7871
7872    /// ★ **An account at its explode budget serves EVERY object, correctly —
7873    /// only slower.**
7874    ///
7875    /// The quota is a cache size, not a storage limit: over budget the server
7876    /// EVICTS, it does not refuse. So a repository squeezed to a budget far
7877    /// under what it holds must still answer every read byte-for-byte, and the
7878    /// only thing that may change is where the bytes came from — the table, or
7879    /// the pack via [`crate::resolve::materialize_at`].
7880    ///
7881    /// This is requirement (c) of the quota: *"an account at its budget must
7882    /// still serve every read correctly, only slower"*. The `rederived`
7883    /// counter is what proves the eviction really happened, because identical
7884    /// bytes come back either way and a byte comparison cannot tell a working
7885    /// cache from a dead one — the identity-value trap in its exact form.
7886    ///
7887    /// Seen RED by having `write_back` return the payload's bytes from a
7888    /// half-written segment (`out.truncate(1)`): "the store returned the wrong
7889    /// bytes for an object under a squeezed budget".
7890    #[test]
7891    fn an_account_at_its_budget_serves_every_object_only_slower() {
7892        let dir = tmpdir("explode-budget");
7893        let store = GitStore::open(&dir, "alice").unwrap();
7894        let (pack, rows) = corpus_pack();
7895        store.put_pack(&pack).unwrap();
7896        store.wait_indexed();
7897
7898        let oids: Vec<Vec<u8>> = rows
7899            .iter()
7900            .map(|r| r.oid.clone())
7901            .collect::<HashSet<Vec<u8>>>()
7902            .into_iter()
7903            .collect();
7904
7905        // Every object once, unsqueezed: the truth to compare against.
7906        let mut truth: Vec<(GitObjectKind, Vec<u8>)> = Vec::with_capacity(oids.len());
7907        for oid in &oids {
7908            truth.push(store.content(oid).unwrap().expect("the store lost an object"));
7909        }
7910        store.explode_cache_maintain().unwrap();
7911
7912        // Now the plan changes: a budget far under what this repository holds.
7913        store.set_explode_budget(64 << 10);
7914        let before = store.exploded_stats();
7915        for _ in 0..3 {
7916            for (i, oid) in oids.iter().enumerate() {
7917                let got = store
7918                    .content(oid)
7919                    .unwrap()
7920                    .expect("an object went absent when the budget was lowered");
7921                assert_eq!(
7922                    got, truth[i],
7923                    "the store returned the wrong bytes for an object under a squeezed budget"
7924                );
7925            }
7926            store.explode_cache_maintain().unwrap();
7927        }
7928        let after = store.exploded_stats();
7929        let band = store.explode_cache_use();
7930
7931        assert!(
7932            band.evicted_bytes > 0 || band.lazy_bytes <= 64 << 10,
7933            "the budget was lowered to 64 KiB and the lazy pool holds {} B with nothing \\
7934             evicted — the quota is not enforced, so this run proves nothing about reading \\
7935             under one: {band:?}",
7936            band.lazy_bytes
7937        );
7938        assert!(
7939            after.rederived > before.rederived,
7940            "not one read re-derived from the pack under a 64 KiB budget, so the cache was \\
7941             never squeezed and 'only slower' was never tested"
7942        );
7943        eprintln!(
7944            "load {}; {} objects read 3x under a 64 KiB budget: {} re-derived, {} served, \
7945{} evicted bytes over {} segments; every byte identical",
7946            loadavg(),
7947            oids.len(),
7948            after.rederived - before.rederived,
7949            after.served - before.served,
7950            band.evicted_bytes,
7951            band.evicted_segments,
7952        );
7953    }
7954
7955    /// ★ **A THIN push on top of a just-acked one is accepted with the indexer
7956    /// PAUSED** — lane U's second rig symptom.
7957    ///
7958    /// MEASURED on the rig 2026-08-30 (lane U): right after an acked push,
7959    /// `git push --mirror` of the next pack came back
7960    /// `[remote rejected] … missing necessary objects`, on a varying set of
7961    /// repositories run to run — a race, not a repository. A thin pack names
7962    /// its delta bases by oid and expects the server to have them; the server
7963    /// **did** have them, in a pack it had acked and not yet indexed, and
7964    /// `scan_pending`'s re-entrancy guard answered `None` for every base looked
7965    /// up from inside a scan rather than only for the ones that would have
7966    /// started a second scan.
7967    ///
7968    /// Seen RED by restoring that guard (`if nested { return Ok((out, None)) }`):
7969    /// *"reading the thin pack's object errored inside the index window:
7970    /// resolving a pending pack read-only for lookups — this pack is thin: it
7971    /// deltas against 42088154… which is not in it, and no base source could
7972    /// produce that object's content"*. The **push** is accepted either way —
7973    /// `external_bases_exist` finds the base with a top-level `lookup_one`
7974    /// before it ever resolves — so the assertion that discriminates is the
7975    /// READ with the gate still held, and an earlier draft of this test that
7976    /// dropped the gate first passed under both arms.
7977    #[test]
7978    fn a_thin_push_on_top_of_an_unindexed_one_is_accepted() {
7979        let dir = tmpdir("thin-on-unindexed");
7980        let store = GitStore::open(&dir, "alice").unwrap();
7981        let (pack, rows) = corpus_pack();
7982        store.put_pack(&pack).unwrap();
7983
7984        // The indexer, paused — so the base can only be found in the pack that
7985        // was acked a moment ago.
7986        let gate = store.hold_absorb_gate();
7987        assert!(
7988            store.unindexed_packs() > 0,
7989            "the drain absorbed the first pack before the gate was taken; this run \
7990             pushed onto an INDEXED store and proves nothing"
7991        );
7992
7993        // A base with a payload, and its real size: a `REF_DELTA` declares the
7994        // source size and the resolver checks it, so a made-up number would fail
7995        // for a reason that has nothing to do with the window under test.
7996        let base = rows
7997            .iter()
7998            .find(|r| r.kind == GitObjectKind::Blob && r.uncompressed_size > 0)
7999            .expect("the corpus has a blob");
8000        let thin = crate::pack_fixture::thin_ref_delta_pack(
8001            &base.oid,
8002            base.uncompressed_size,
8003            b"lane Q was here\n",
8004        );
8005
8006        let tx = store.put_pack(&thin).unwrap_or_else(|e| {
8007            panic!("the thin push was refused: {e:#}");
8008        });
8009        assert!(tx.pack_id.is_some(), "the thin pack was not stored");
8010
8011        // **And its object reads back with the gate STILL HELD.** This is the
8012        // nested case and the one the guard was too wide for: the read scans
8013        // pack B, B's entry is a ref-delta, its base is in pack A, and
8014        // resolving it is a second `scan_pending` from inside the first. A
8015        // lookup into A's already-built scan terminates; only a *build* would
8016        // not.
8017        let hash = store.hash_kind();
8018        let oid = hash.oid_of(&crate::object::canonical(
8019            GitObjectKind::Blob,
8020            b"lane Q was here\n",
8021        ));
8022        let got = store.content(&oid);
8023        drop(gate);
8024        let (kind, payload) = got
8025            .expect("reading the thin pack's object errored inside the index window")
8026            .expect("the thin pack's own object is absent after its push was acked");
8027        assert_eq!(kind, GitObjectKind::Blob);
8028        assert_eq!(payload, b"lane Q was here\n");
8029    }
8030
8031    /// **Dropping the table and reopening still answers correctly — fall back,
8032    /// then rebuild.**
8033    ///
8034    /// §14 calls the resolved table *droppable*: derived, verifiable against the
8035    /// verbatim truth, and deletable at any time without consulting a client.
8036    /// This is that sentence as an operation — `rm objects.exploded` between two
8037    /// opens — and §13.12's rule applied to it unchanged: **absent means fall
8038    /// back, never means wrong.**
8039    ///
8040    /// Three things are asserted, in this order:
8041    ///
8042    /// 1. the file really is gone and the reopened store really does start with
8043    ///    an empty table — otherwise the rest is testing a warm one;
8044    /// 2. **`reachable()` is already correct**, asked before any drain has been
8045    ///    waited on: the fall-back absorb runs inline and rebuilds what the
8046    ///    answer needs;
8047    /// 3. the table is **rebuilt** — one row per object again, the graph back,
8048    ///    and the rows written by *this* process, which is what says a rebuild
8049    ///    happened rather than a survival.
8050    ///
8051    /// Seen RED by `let exploded_is_whole = self.exploded.rows()? >= self.objects.len()
8052    /// as u64;` → `= true;` in `Absorber::adopt_journal`, so a dropped table is
8053    /// never noticed and nothing is re-queued. Assertion (2) fires first:
8054    /// **"reachable() after dropping the table: 1 objects, against 2683
8055    /// before"** — one object, the tip alone, which is the recorded bug's exact
8056    /// symptom ("`reachable` on a commit returns that commit alone rather than
8057    /// its closure") arrived at from the other direction. Restored.
8058    ///
8059    /// Seen RED a second time by `>=` → `>` in the same expression, which makes a
8060    /// *whole* table look short. This guard stays green — the rebuild is
8061    /// correct — and two others fire instead:
8062    /// [`a_clean_shutdown_and_reopen_keeps_the_graph_and_reachable`]'s "the
8063    /// reopen re-queued the pack, so the graph above is a recovery artefact
8064    /// rather than the table's", and the pre-existing
8065    /// [`a_clean_reopen_requeues_nothing_and_the_next_push_gets_a_fresh_ordinal`]'s
8066    /// "a fully absorbed pack was re-queued on open — the diff is not exact".
8067    /// That pair is the point: one guard catches the table not being rebuilt when
8068    /// it should be, the others catch it being rebuilt when it should not.
8069    /// Restored.
8070    #[test]
8071    fn dropping_the_exploded_table_and_reopening_still_answers() {
8072        let dir = tmpdir("exploded-dropped");
8073        let (pack, rows) = corpus_pack();
8074        let tip_hex;
8075        let closure_before;
8076        {
8077            let store = GitStore::open(&dir, "alice").unwrap();
8078            store.put_pack(&pack).unwrap();
8079            store.wait_indexed();
8080            let tip = store
8081                .graph_snapshot()
8082                .into_iter()
8083                .max_by_key(|c| c.generation)
8084                .expect("a graph");
8085            let tip_raw = hex::decode(&tip.oid).unwrap();
8086            closure_before = store.reachable(&[&tip_raw], &[]).unwrap().len();
8087            tip_hex = tip.oid;
8088        }
8089
8090        // (1) — the drop.
8091        let table = dir.join("objects.exploded");
8092        assert!(table.exists(), "the store never built an exploded table");
8093        std::fs::remove_file(&table).unwrap();
8094        {
8095            let fresh = crate::exploded_arrow::ExplodedArchive::open(&table).unwrap();
8096            assert_eq!(fresh.rows().unwrap(), 0, "the drop did not drop anything");
8097        }
8098        // Opening an absent table does not create one — so this only has
8099        // anything to remove if the assertion above was inspecting a live file.
8100        let _ = std::fs::remove_file(&table);
8101
8102        // (2) — a correct answer with the table gone.
8103        let store = GitStore::open(&dir, "alice").unwrap();
8104        let tip_raw = hex::decode(&tip_hex).unwrap();
8105        let closure = store.reachable(&[&tip_raw], &[]).unwrap();
8106        assert_eq!(
8107            closure.len(),
8108            closure_before,
8109            "reachable() after dropping the table: {} objects, against {} before",
8110            closure.len(),
8111            closure_before
8112        );
8113        assert!(store.has(&rows[0].oid).unwrap());
8114
8115        // (3) — and it is back. The GRAPH is what comes back at push time; a
8116        // blob comes back when somebody reads it, which is the whole of lazy
8117        // explode, so the count to compare against is the graph's and not the
8118        // pack's.
8119        store.wait_indexed();
8120        let stats = store.exploded_stats();
8121        let distinct: HashSet<Vec<u8>> = rows.iter().map(|r| r.oid.clone()).collect();
8122        // Commits, and NOT `of_kind(Tree)`: under the shipped policy a tree is
8123        // lazy, so the trees this test's own reads cached are in the lazy pool
8124        // and `of_kind` unions both.
8125        let graph_rows = store.exploded_of_kind(GitObjectKind::Commit).unwrap().len();
8126        // The EAGER pool, not `stats.rows`: step (2) above read objects through
8127        // the store, and every one of those reads wrote its object back into the
8128        // lazy pool, which `stats.rows` also counts. Comparing the sum against
8129        // the graph would be comparing "what the push wrote" against "what the
8130        // push wrote plus what this test happened to read".
8131        let eager = store.exploded_eager_rows().unwrap();
8132        assert_eq!(
8133            eager, graph_rows as u64,
8134            "the dropped table came back holding {eager} rows against a {}-object graph",
8135            graph_rows
8136        );
8137        assert!(
8138            eager > 0 && eager < distinct.len() as u64,
8139            "the rebuilt pool holds {eager} of {} objects — neither 0 nor all of them is \
8140             the lane Q shape",
8141            distinct.len()
8142        );
8143        assert!(
8144            stats.written > 0,
8145            "the table came back without this process writing a row — it was never dropped"
8146        );
8147        assert_eq!(
8148            store.commit_count(),
8149            commits_in(&rows),
8150            "the graph did not come back with the table: {} of {}",
8151            store.commit_count(),
8152            commits_in(&rows)
8153        );
8154        assert_eq!(
8155            store.object_count(),
8156            rows.len(),
8157            "the rebuild lost index rows"
8158        );
8159        eprintln!(
8160            "load {}; dropped and rebuilt: {} rows written, {} commits, tip closure {} objects",
8161            loadavg(),
8162            stats.written,
8163            store.commit_count(),
8164            closure.len(),
8165        );
8166    }
8167
8168    // ─────────────────────────────────────────────────────────────────────
8169    // lane ENGINE-OPT scaffold: a graded linear-history generator, the O(C)
8170    // negotiation timing test, and the cross-push memo-invalidation guard.
8171    // ─────────────────────────────────────────────────────────────────────
8172
8173    /// A linear commit history of `n` commits as a clone pack, optionally
8174    /// chained onto `start_parent` (an oid already in the store). Each commit
8175    /// carries its own one-entry tree and one unique blob, so the object count
8176    /// is `3n` and the graph is a single parent chain `n` deep — the shape that
8177    /// makes a negotiation's cost O(commits), which is what this lane memoizes.
8178    fn linear_history_pack_from(
8179        n: usize,
8180        start_parent: Option<&[u8]>,
8181    ) -> (Vec<u8>, Vec<Vec<u8>>) {
8182        use crate::object::canonical;
8183        use crate::pack_fixture::{build_pack, Item};
8184        let hash = GitHashKind::Sha1;
8185        let mut items: Vec<Item> = Vec::with_capacity(n * 3);
8186        let mut commits: Vec<Vec<u8>> = Vec::with_capacity(n);
8187        let mut prev: Option<Vec<u8>> = start_parent.map(|p| p.to_vec());
8188        for c in 0..n {
8189            let body = format!("blob for commit {c} of {n}, parent {prev:?}\n").into_bytes();
8190            let blob_oid = hash.oid_of(&canonical(GitObjectKind::Blob, &body));
8191            items.push(Item::Whole(GitObjectKind::Blob, body));
8192
8193            let mut tpayload = Vec::new();
8194            tpayload.extend_from_slice(b"100644 f.bin\0");
8195            tpayload.extend_from_slice(&blob_oid);
8196            let tree_oid = hash.oid_of(&canonical(GitObjectKind::Tree, &tpayload));
8197            items.push(Item::Whole(GitObjectKind::Tree, tpayload));
8198
8199            let mut cbody = format!("tree {}\n", hex::encode(&tree_oid));
8200            if let Some(parent) = &prev {
8201                cbody.push_str(&format!("parent {}\n", hex::encode(parent)));
8202            }
8203            cbody.push_str(
8204                "author A U Thor <a@example.com> 1700000000 +0000\n\
8205                 committer A U Thor <a@example.com> 1700000000 +0000\n\n\
8206                 commit\n",
8207            );
8208            let cbody = cbody.into_bytes();
8209            let commit_oid = hash.oid_of(&canonical(GitObjectKind::Commit, &cbody));
8210            items.push(Item::Whole(GitObjectKind::Commit, cbody));
8211            prev = Some(commit_oid.clone());
8212            commits.push(commit_oid);
8213        }
8214        (build_pack(&items), commits)
8215    }
8216
8217    /// The O(commits) negotiation cost, graded. `reachable` rebuilt the
8218    /// `by_commit` and graph maps on every call — O(C) regardless of how few
8219    /// objects the request touched — so the `root` query (closure ~1) isolates
8220    /// that map-build cost from the walk, and the `tip` query (full closure)
8221    /// pays both. Median of nine, min–max, with the loadavg of its own run.
8222    #[test]
8223    #[ignore = "perf measurement; run with --release --ignored --nocapture"]
8224    fn bench_reachable_negotiation() {
8225        for &n in &[48usize, 2_000, 20_000] {
8226            let dir = tmpdir(&format!("bench-reach-{n}"));
8227            let (pack, commits) = linear_history_pack_from(n, None);
8228            let store = GitStore::open(&dir, "alice").unwrap();
8229            store.put_pack(&pack).unwrap();
8230            store.wait_indexed();
8231            let root = commits.first().unwrap().clone();
8232            let tip = commits.last().unwrap().clone();
8233            // warm the reach bitmaps once so the loop times the negotiation, not
8234            // the one-time bitmap build.
8235            let _ = store.reachable(&[&tip], &[]).unwrap();
8236
8237            let reps = 9usize;
8238            let (mut root_t, mut tip_t) = (Vec::new(), Vec::new());
8239            for _ in 0..reps {
8240                let t = Instant::now();
8241                let _ = store.reachable(&[&root], &[]).unwrap();
8242                root_t.push(t.elapsed());
8243                let t = Instant::now();
8244                let _ = store.reachable(&[&tip], &[]).unwrap();
8245                tip_t.push(t.elapsed());
8246            }
8247            root_t.sort();
8248            tip_t.sort();
8249            let tip_closure = store.reachable(&[&tip], &[]).unwrap().len();
8250            eprintln!(
8251                "load {}; n={n}: reachable(root, closure~1) med {:?} [{:?}..{:?}]  |  \
8252                 reachable(tip, closure {}) med {:?} [{:?}..{:?}]",
8253                loadavg(),
8254                root_t[reps / 2],
8255                root_t[0],
8256                root_t[reps - 1],
8257                tip_closure,
8258                tip_t[reps / 2],
8259                tip_t[0],
8260                tip_t[reps - 1],
8261            );
8262        }
8263    }
8264
8265    /// **A negotiation answered from the memoized reach view is the answer a
8266    /// cold fold gives — including across a push that changes the fold.**
8267    ///
8268    /// Lane ENGINE-OPT memoizes the `by_commit` and graph lookup maps that
8269    /// `reachable` used to rebuild on every call, in `Derived`, folded by the
8270    /// same call that folds `commit_raw`. The bug this discipline exists to
8271    /// catch is a memo that SURVIVES a fold it should not: after a push adds
8272    /// commits, the warm store must answer with the new closure, byte-identical
8273    /// (order included — both spaces sort the same oids) to a fresh store
8274    /// opened cold on the same bytes.
8275    ///
8276    /// Seen RED by skipping the memo rebuild in `refold` (leaving `graph_index`
8277    /// from before the push): the post-push tip is then not a known commit,
8278    /// `reachable` contributes it alone, and the warm answer is a handful of
8279    /// objects where the cold fold gives the whole chain — the assertion names
8280    /// both lengths.
8281    #[test]
8282    fn reachable_memo_matches_a_cold_fold_across_a_push() {
8283        let dir = tmpdir("reach-memo-across-push");
8284        let (pack_a, commits_a) = linear_history_pack_from(40, None);
8285        let store = GitStore::open(&dir, "alice").unwrap();
8286        store.put_pack(&pack_a).unwrap();
8287        store.wait_indexed();
8288        let tip_a = commits_a.last().unwrap().clone();
8289        let warm_a = store.reachable(&[&tip_a], &[]).unwrap();
8290        assert!(
8291            warm_a.len() > 10,
8292            "A's closure is too small to tell a stale memo from a coincidence: {}",
8293            warm_a.len()
8294        );
8295
8296        // Push B: a second linear history chained ONTO A's tip, so B's tip
8297        // closes over A too. This is a fold that genuinely grows the graph.
8298        let (pack_b, commits_b) = linear_history_pack_from(40, Some(&tip_a));
8299        store.put_pack(&pack_b).unwrap();
8300        store.wait_indexed();
8301        let tip_b = commits_b.last().unwrap().clone();
8302        let warm_b_full = store.reachable(&[&tip_b], &[]).unwrap();
8303        let warm_b_minus_a = store.reachable(&[&tip_b], &[&tip_a]).unwrap();
8304        assert!(
8305            warm_b_full.len() > warm_a.len(),
8306            "the push did not grow the closure ({} !> {}), so the memo could be \
8307             stale and this test would not know",
8308            warm_b_full.len(),
8309            warm_a.len()
8310        );
8311
8312        // The cold oracle: a fresh handle on the same bytes, folded from disk.
8313        drop(store);
8314        let cold = GitStore::open(&dir, "alice").unwrap();
8315        cold.wait_indexed();
8316        let cold_b_full = cold.reachable(&[&tip_b], &[]).unwrap();
8317        let cold_b_minus_a = cold.reachable(&[&tip_b], &[&tip_a]).unwrap();
8318
8319        assert_eq!(
8320            warm_b_full, cold_b_full,
8321            "warm memo != cold fold for want=tip_b (a memo that survived the push)"
8322        );
8323        assert_eq!(
8324            warm_b_minus_a, cold_b_minus_a,
8325            "warm memo != cold fold for want=tip_b have=tip_a"
8326        );
8327        // tip_a is still answered identically after the push (its closure did
8328        // not change; only the store grew around it).
8329        let cold_a = cold.reachable(&[&tip_a], &[]).unwrap();
8330        assert_eq!(
8331            warm_a, cold_a,
8332            "tip_a's closure changed across the push"
8333        );
8334        eprintln!(
8335            "load {}; A closure {}, B closure {}, B−A {}",
8336            loadavg(),
8337            warm_a.len(),
8338            warm_b_full.len(),
8339            warm_b_minus_a.len(),
8340        );
8341    }
8342
8343    /// **The clone-after-push lever, witnessed.** A push folds; the fold used
8344    /// to drop the reachability table and the next reader rebuilt it by
8345    /// walking every commit's trees — 0.2 ms per object, 10 s on a 51k-object
8346    /// repository, measured 2026-09-05. Now the fold CARRIES the table
8347    /// (renumbered) when the graph grew by no more than the carry rule allows.
8348    /// RED before the carry: `reach_rebuilt` went 1 → 2 across the push.
8349    #[test]
8350    fn a_push_carries_the_reach_table_across_the_fold() {
8351        let dir = tmpdir("reach-carry-across-push");
8352        let (pack_a, commits_a) = linear_history_pack_from(40, None);
8353        let store = GitStore::open(&dir, "alice").unwrap();
8354        store.put_pack(&pack_a).unwrap();
8355        store.wait_indexed();
8356        let tip_a = commits_a.last().unwrap().clone();
8357        let warm_a = store.reachable(&[&tip_a], &[]).unwrap();
8358        assert_eq!(store.reach_source_stats(), (0, 1), "the first read builds the table once");
8359
8360        // A push of 30 commits onto A's tip: within the carry rule (64 or a
8361        // tenth of 40, whichever is larger), so the fold carries.
8362        let (pack_b, commits_b) = linear_history_pack_from(30, Some(&tip_a));
8363        store.put_pack(&pack_b).unwrap();
8364        store.wait_indexed();
8365        let tip_b = commits_b.last().unwrap().clone();
8366        let warm_b = store.reachable(&[&tip_b], &[]).unwrap();
8367        let warm_b_minus_a = store.reachable(&[&tip_b], &[&tip_a]).unwrap();
8368        assert_eq!(
8369            store.reach_source_stats(),
8370            (1, 1),
8371            "the fold carried the table; no read rebuilt it"
8372        );
8373        assert!(warm_b.len() > warm_a.len(), "the push grew the closure");
8374        assert_eq!(warm_b_minus_a.len(), warm_b.len() - warm_a.len(), "tip_b − tip_a is exactly the pushed objects");
8375        assert_eq!(store.reachable(&[&tip_a], &[]).unwrap(), warm_a, "tip_a's closure survived the renumbering");
8376
8377        // The cold oracle: the same bytes folded from disk with a fresh table.
8378        drop(store);
8379        let cold = GitStore::open(&dir, "alice").unwrap();
8380        cold.wait_indexed();
8381        assert_eq!(cold.reachable(&[&tip_b], &[]).unwrap(), warm_b, "carried != rebuilt for want=tip_b");
8382        assert_eq!(
8383            cold.reachable(&[&tip_b], &[&tip_a]).unwrap(),
8384            warm_b_minus_a,
8385            "carried != rebuilt for want=tip_b have=tip_a"
8386        );
8387        // The cold handle READ the table the warm one's drop wrote back
8388        // (extended for the push), followed the space (nothing to append) and
8389        // had nothing to extend — nothing was built from scratch.
8390        assert_eq!(cold.reach_source_stats(), (1, 0), "the cold handle kept the persisted table and rebuilt nothing");
8391        let (loaded, extended, _) = cold.reach_stats();
8392        assert_eq!((loaded, extended), (1, 0), "loaded once, nothing left to extend");
8393    }
8394
8395    /// **A push of any size extends the table; nothing is rebuilt.** Under
8396    /// the sorted ordinal space a push past the carry allowance (a tenth of
8397    /// the history) dropped the table and the next read walked every tree in
8398    /// the repository again; under the append-only space the fold gives the
8399    /// pushed tip an entry by the bounded walk and the table stands. RED on the
8400    /// old code: `reach_source_stats` went (0, 1) → (0, 2) across the push.
8401    #[test]
8402    fn a_push_of_any_size_extends_the_reach_table_and_rebuilds_nothing() {
8403        let dir = tmpdir("reach-extend-not-rebuild");
8404        let (pack_a, commits_a) = linear_history_pack_from(20, None);
8405        let store = GitStore::open(&dir, "alice").unwrap();
8406        store.put_pack(&pack_a).unwrap();
8407        store.wait_indexed();
8408        let tip_a = commits_a.last().unwrap().clone();
8409        let warm_a = store.reachable(&[&tip_a], &[]).unwrap();
8410        assert_eq!(store.reach_source_stats(), (0, 1));
8411        // 100 commits onto 20: five times the history, far past the old allowance.
8412        let (pack_b, commits_b) = linear_history_pack_from(100, Some(&tip_a));
8413        store.put_pack(&pack_b).unwrap();
8414        store.wait_indexed();
8415        let tip_b = commits_b.last().unwrap().clone();
8416        let warm_b = store.reachable(&[&tip_b], &[]).unwrap();
8417        assert_eq!(store.reach_source_stats(), (1, 1), "the fold kept the table; no read rebuilt it");
8418        let (_, extended, unpersisted) = store.reach_stats();
8419        assert_eq!(extended, 1, "the fold extended the table for the pushed commits");
8420        assert_eq!(unpersisted, 1, "one extension since the last write-back");
8421        assert_eq!(warm_b.len(), warm_a.len() + 300, "100 commits × (commit, tree, blob)");
8422        assert_eq!(store.reachable(&[&tip_a], &[]).unwrap(), warm_a, "tip_a's closure is untouched");
8423        drop(store);
8424        let cold = GitStore::open(&dir, "alice").unwrap();
8425        cold.wait_indexed();
8426        assert_eq!(cold.reachable(&[&tip_b], &[]).unwrap(), warm_b, "extended warm != cold");
8427        // The drop wrote the extended table back; the cold open read it whole
8428        // and had nothing to extend.
8429        let (loaded, extended, _) = cold.reach_stats();
8430        assert_eq!((loaded, extended), (1, 0), "read back the table the drop persisted; nothing to extend");
8431        assert_eq!(cold.reach_source_stats(), (1, 0));
8432    }
8433
8434    /// **A reopen reads the table it built; it does not walk every tree
8435    /// again.** GUN-PERF Z-1: the first read after every start of a git.git
8436    /// store rebuilt the bitmaps, 85 to 150 s. The table (and the ordinal space
8437    /// it is over) is persisted beside the graph and read back. RED: the cold
8438    /// handle reported one rebuild and nothing kept.
8439    #[test]
8440    fn a_reopen_reads_the_persisted_reach_table_and_rebuilds_nothing() {
8441        let dir = tmpdir("reach-persisted-reopen");
8442        let (pack, commits) = linear_history_pack_from(12, None);
8443        let store = GitStore::open(&dir, "alice").unwrap();
8444        store.put_pack(&pack).unwrap();
8445        store.wait_indexed();
8446        let tip = commits.last().unwrap().clone();
8447        let root = commits.first().unwrap().clone();
8448        let warm = store.reachable(&[&tip], &[]).unwrap();
8449        let warm_delta = store.reachable(&[&tip], &[&root]).unwrap();
8450        assert_eq!(store.reach_source_stats(), (0, 1));
8451        drop(store);
8452        assert!(dir.join("objects.reach").is_file(), "the build persisted objects.reach");
8453        let cold = GitStore::open(&dir, "alice").unwrap();
8454        cold.wait_indexed();
8455        assert_eq!(cold.reachable(&[&tip], &[]).unwrap(), warm);
8456        assert_eq!(cold.reachable(&[&tip], &[&root]).unwrap(), warm_delta);
8457        assert_eq!(cold.reach_source_stats(), (1, 0), "read back, nothing rebuilt");
8458    }
8459
8460    /// **The persisted table refuses hostile bytes and falls back to a build.**
8461    /// `objects.reach` is bytes off a disk: a torn write, a truncation or a
8462    /// foreign file must come back as "build it again", never a panic.
8463    #[test]
8464    fn a_hostile_persisted_reach_table_is_rebuilt_not_trusted() {
8465        let dir = tmpdir("reach-hostile-persisted");
8466        let (pack, commits) = linear_history_pack_from(12, None);
8467        let store = GitStore::open(&dir, "alice").unwrap();
8468        store.put_pack(&pack).unwrap();
8469        store.wait_indexed();
8470        let tip = commits.last().unwrap().clone();
8471        let warm = store.reachable(&[&tip], &[]).unwrap();
8472        drop(store);
8473        let path = dir.join("objects.reach");
8474        let bytes = std::fs::read(&path).expect("the build persisted objects.reach");
8475        for (name, hostile) in [
8476            ("truncated", bytes[..bytes.len() / 2].to_vec()),
8477            ("garbage", b"RECH\x01not a table at all, not even a header".to_vec()),
8478            ("bitflipped", {
8479                let mut b = bytes.clone();
8480                let at = b.len() - 7;
8481                b[at] ^= 0xff;
8482                b
8483            }),
8484        ] {
8485            std::fs::write(&path, &hostile).unwrap();
8486            let cold = GitStore::open(&dir, "alice").unwrap();
8487            cold.wait_indexed();
8488            assert_eq!(cold.reachable(&[&tip], &[]).unwrap(), warm, "{name}: the answer must not change");
8489            let (loaded, _, _) = cold.reach_stats();
8490            let (_, rebuilt) = cold.reach_source_stats();
8491            assert!(
8492                loaded == 0 || rebuilt == 0,
8493                "{name}: either refused and rebuilt (loaded 0) or decoded exactly (rebuilt 0); got loaded {loaded} rebuilt {rebuilt}"
8494            );
8495            drop(cold);
8496        }
8497    }
8498
8499    /// ★ **A push alone makes the cache give space back at the disk line.**
8500    /// Owner 2026-09-28: the indexing thread should also de-cache.
8501    ///
8502    /// The lazy pool is filled into several segments under a 10 % disk, then
8503    /// the disk reads 85 % and a pack is pushed. No reader touches the store
8504    /// after that, so only the indexer can have started the cleanup.
8505    ///
8506    /// Seen RED by removing `self.exploded.kick()` from `absorb_one_inner`:
8507    /// the pool kept every segment after the push.
8508    #[test]
8509    fn a_push_past_the_disk_line_evicts_the_oldest_cache_without_a_read() {
8510        let dir = tmpdir("push-disk-line");
8511        let store = GitStore::open(&dir, "rickard").unwrap();
8512        let c = store.absorber.exploded.clone();
8513        c.set_global_line(0);
8514        c.set_segment_bytes_for_test(256 << 10);
8515        c.set_disk_reading_for_test(10);
8516        // Incompressible, deep enough to be admitted: the cache must hold it.
8517        let mut x: u32 = 0x9E37_79B9;
8518        let big: Vec<u8> = (0..64 << 10)
8519            .map(|_| {
8520                x = x.wrapping_mul(1_664_525).wrapping_add(1_013_904_223);
8521                (x >> 24) as u8
8522            })
8523            .collect();
8524        let cost = crate::resolve::ReadCost {
8525            depth: crate::exploded_cache::CHEAP_DEPTH + 8,
8526            inflated: big.len() as u64,
8527            external_base: false,
8528        };
8529        for i in 0..24u32 {
8530            let mut oid = vec![0u8; 20];
8531            oid[..4].copy_from_slice(&i.to_be_bytes());
8532            c.write_back(&oid, GitObjectKind::Blob, &big, cost).unwrap();
8533            c.maintain().unwrap();
8534        }
8535        let before = c.use_now();
8536        assert!(before.segments >= 4, "precondition: rotated into segments, has {}", before.segments);
8537        assert_eq!(before.evicted_segments, 0, "precondition: nothing evicted under a 10 % disk");
8538
8539        c.set_disk_reading_for_test(85);
8540        let (pack, _) = one_blob_pack(b"pushed after the disk crossed its line\n");
8541        store.put(&pack, &[]).unwrap();
8542        store.wait_indexed();
8543        let deadline = Instant::now() + Duration::from_secs(10);
8544        while c.use_now().evicted_segments == 0 && Instant::now() < deadline {
8545            std::thread::sleep(Duration::from_millis(20));
8546        }
8547        let after = c.use_now();
8548        assert!(after.evicted_segments > 0, "the push did not make the cache give anything back");
8549        assert_eq!(after.segments, 1, "past the line the pool keeps only its live segment");
8550    }
8551}