zeph_core/agent/
session_config.rs

1// SPDX-FileCopyrightText: 2026 Andrei G <bug-ops>
2// SPDX-License-Identifier: MIT OR Apache-2.0
3
4use std::sync::Arc;
5
6use crate::config::{
7    Config, DebugConfig, DocumentConfig, GraphConfig, LearningConfig, OrchestrationConfig,
8    PersonaConfig, SecurityConfig, TimeoutConfig,
9};
10use crate::vault::Secret;
11
12/// Reserve ratio for `with_context_budget`: fraction of budget reserved for LLM reply.
13///
14/// Extracted from the hardcoded `0.20` literal used in both `spawn_acp_agent` and `runner.rs`.
15pub const CONTEXT_BUDGET_RESERVE_RATIO: f32 = 0.20;
16
17/// All config-derived fields needed to configure an `Agent` session.
18///
19/// This is the single source of truth for config → agent wiring.
20/// Adding a new config field requires exactly three changes:
21///
22/// 1. Add the field here.
23/// 2. Map it in [`AgentSessionConfig::from_config`].
24/// 3. Apply it in [`super::Agent::apply_session_config`] (destructure triggers a compile error if
25///    you forget step 3 — see the S4 note in the critic handoff).
26///
27/// ## What is NOT here
28///
29/// - **Shared runtime objects** (`provider`, `registry`, `memory`, `mcp_manager`, etc.) — these
30///   are expensive to create and shared across sessions; they stay in `SharedAgentDeps`.
31/// - **ACP-specific fields** (`acp_max_sessions`, bearer token, etc.) — transport-level, not
32///   agent-level.
33/// - **Optional runtime providers** (`summary_provider`, `judge_provider`,
34///   `quarantine_provider`) — these contain HTTP client pools (`AnyProvider`) that carry runtime
35///   state; callers wire them separately via `with_summary_provider` / `with_judge_provider` /
36///   `apply_quarantine_provider`.
37/// - **`mcp_config`** — passed alongside runtime MCP objects in `with_mcp()`; separating it
38///   from `mcp_tools` / `mcp_manager` would make the call site awkward.
39/// - **Runner-only fields** (`compression`, `routing`, `autosave`, `hybrid_search`,
40///   `logging_config`, `subagent`, `experiment`, `instruction`, `lsp_hooks`, `response_cache`,
41///   `cost_tracker`) — not used in ACP sessions; keeping them out avoids unused-field noise and
42///   prevents inadvertent ACP behavior changes. Neither `disambiguation_threshold` nor
43///   `trust_config` (#5920) belong in this category — both ARE used in ACP sessions, just wired
44///   via their own standalone builder call (`with_skill_matching_config` /
45///   `with_trust_config`) rather than through this bundle.
46/// - **Scheduler runtime objects** (`scheduler_executor`, broadcast senders) — runtime state,
47///   not config-derived values.
48#[derive(Clone)]
49#[allow(clippy::struct_excessive_bools)] // independent boolean flags; bitflags or enum would obscure semantics without reducing complexity
50pub struct AgentSessionConfig {
51    // Tool behavior
52    pub max_tool_iterations: usize,
53    pub max_tool_retries: usize,
54    pub max_retry_duration_secs: u64,
55    pub retry_base_ms: u64,
56    pub retry_max_ms: u64,
57    pub parameter_reformat_provider: String,
58    pub tool_repeat_threshold: usize,
59    pub tool_summarization: bool,
60    pub tool_call_cutoff: usize,
61    pub max_tool_calls_per_session: Option<u32>,
62    pub overflow_config: zeph_tools::OverflowConfig,
63    pub permission_policy: zeph_tools::PermissionPolicy,
64
65    // Model
66    pub model_name: String,
67    pub embed_model: String,
68
69    // Semantic cache
70    pub semantic_cache_enabled: bool,
71    pub semantic_cache_threshold: f32,
72    pub semantic_cache_max_candidates: u32,
73
74    // Memory / compaction
75    pub budget_tokens: usize,
76    pub soft_compaction_threshold: f32,
77    pub hard_compaction_threshold: f32,
78    pub compaction_preserve_tail: usize,
79    pub compaction_cooldown_turns: u8,
80    pub prune_protect_tokens: usize,
81    pub redact_credentials: bool,
82
83    // Security
84    pub security: SecurityConfig,
85    pub timeouts: TimeoutConfig,
86
87    // Feature configs
88    pub learning: LearningConfig,
89    pub document_config: DocumentConfig,
90    pub graph_config: GraphConfig,
91    pub persona_config: PersonaConfig,
92    pub trajectory_config: crate::config::TrajectoryConfig,
93    pub category_config: crate::config::CategoryConfig,
94    pub reasoning_config: zeph_config::ReasoningConfig,
95    pub memcot_config: zeph_config::MemCotConfig,
96    pub tree_config: crate::config::TreeConfig,
97    pub microcompact_config: crate::config::MicrocompactConfig,
98    pub autodream_config: crate::config::AutoDreamConfig,
99    pub magic_docs_config: crate::config::MagicDocsConfig,
100    /// Acon tool-result compression configuration (#4021).
101    pub acon_config: zeph_config::AconConfig,
102    /// ARC agent-initiated compaction configuration (#4020).
103    pub arc_config: zeph_config::ArcCompactionConfig,
104    pub anomaly_config: zeph_tools::AnomalyConfig,
105    pub result_cache_config: zeph_tools::ResultCacheConfig,
106    pub utility_config: zeph_tools::UtilityScoringConfig,
107    pub orchestration_config: OrchestrationConfig,
108    /// Cross-thread store config (spec-080, `[memory.store]`, GitHub #6363). Read by
109    /// `scheduler_loop.rs`'s Command-handoff produce-side seam to gate the feature and
110    /// bound written-value size — `orchestration_config.command` carries the sibling
111    /// `[orchestration.command]` section and is already threaded above.
112    pub store_config: zeph_config::CrossThreadStoreConfig,
113    pub debug_config: DebugConfig,
114    pub server_compaction: bool,
115
116    /// Inject `<budget>` XML into the volatile system prompt section (#2267).
117    pub budget_hint_enabled: bool,
118
119    /// Inject a `<current_time>` reminder into the volatile system prompt every N agent turns
120    /// (#6361).
121    pub time_reminder_enabled: bool,
122    /// Turn interval between `<current_time>` reminder injections (#6361).
123    pub time_reminder_interval_requests: u32,
124
125    /// Token budget for skill bodies injected into a sub-agent's one-shot system prompt
126    /// at spawn time (#6421). See `SkillsConfig::subagent_skill_token_budget`.
127    pub subagent_skill_token_budget: usize,
128
129    /// Session recap settings (#3064).
130    pub recap: zeph_config::RecapConfig,
131
132    /// Resume-visibility banner and `/history` bound settings (spec-068 §13, §18, #6420).
133    pub resume: zeph_config::ResumeConfig,
134
135    /// Minimum allowed `/loop` tick interval in seconds. From `[cli.loop] min_interval_secs`.
136    pub loop_min_interval_secs: u64,
137
138    /// Long-horizon goal lifecycle configuration.
139    pub goal_config: zeph_config::GoalConfig,
140
141    /// Custom secrets from config.
142    ///
143    /// Stored as `Arc` because `Secret` intentionally does not implement `Clone` —
144    /// the wrapper prevents accidental duplication. Iteration produces new `Secret`
145    /// values via `Secret::new(v.expose())` on the consumption side.
146    pub secrets: Arc<[(String, Secret)]>,
147
148    /// CAM fidelity scoring configuration (#4547). `None` → scoring disabled.
149    pub fidelity_config: Option<zeph_config::FidelityConfig>,
150
151    /// Global caps for MCP image passthrough (spec-072), used by the vision-tier
152    /// emission gate in `process_one_tool_result` to enforce `max_images_per_turn`.
153    pub mcp_media: zeph_config::McpMediaConfig,
154
155    /// `true` when at least one configured `[[mcp.servers]]` entry has
156    /// `media_passthrough = true` (spec-072 FR-011). Gates the static untrusted-image
157    /// caveat line added once at session-assembly time in `assemble_final_system_prompt`.
158    pub media_passthrough_note_enabled: bool,
159
160    /// Install-time plugin/skill name-similarity typosquat check config (spec-043, #5864).
161    /// Read by the `/plugins add` slash-command handler so it applies the same
162    /// `plugins.reputation` policy as `zeph plugin add` and the bootstrap auto-update path.
163    pub plugins_reputation: zeph_config::plugins::ReputationConfig,
164}
165
166impl AgentSessionConfig {
167    /// Build from a resolved [`Config`] snapshot and a pre-computed `budget_tokens`.
168    ///
169    /// `budget_tokens` is passed as a parameter because its computation (`auto_budget_tokens`)
170    /// depends on the active provider and must happen before `AgentSessionConfig` is constructed.
171    #[must_use]
172    pub fn from_config(config: &Config, budget_tokens: usize) -> Self {
173        Self {
174            max_tool_iterations: config.agent.max_tool_iterations,
175            max_tool_retries: config.tools.retry.max_attempts,
176            max_retry_duration_secs: config.tools.retry.budget_secs,
177            retry_base_ms: config.tools.retry.base_ms,
178            retry_max_ms: config.tools.retry.max_ms,
179            parameter_reformat_provider: config.tools.retry.parameter_reformat_provider.to_string(),
180            tool_repeat_threshold: config.agent.tool_repeat_threshold,
181            tool_summarization: config.tools.summarize_output,
182            tool_call_cutoff: config.memory.tool_call_cutoff,
183            max_tool_calls_per_session: config.tools.max_tool_calls_per_session,
184            overflow_config: config.tools.overflow.clone(),
185            permission_policy: zeph_tools::build_permission_policy(
186                &config.tools,
187                config.security.autonomy_level,
188            ),
189            model_name: config.llm.effective_model().to_owned(),
190            embed_model: config.llm.stable_skill_embedding_model(),
191            semantic_cache_enabled: config.llm.semantic_cache_enabled,
192            semantic_cache_threshold: config.llm.semantic_cache_threshold,
193            semantic_cache_max_candidates: config.llm.semantic_cache_max_candidates,
194            budget_tokens,
195            soft_compaction_threshold: config.memory.soft_compaction_threshold,
196            hard_compaction_threshold: config.memory.hard_compaction_threshold,
197            compaction_preserve_tail: config.memory.compaction_preserve_tail,
198            compaction_cooldown_turns: config.memory.compaction_cooldown_turns,
199            prune_protect_tokens: config.memory.prune_protect_tokens,
200            redact_credentials: config.memory.redact_credentials,
201            security: config.security.clone(),
202            timeouts: config.timeouts,
203            learning: config.skills.learning.clone(),
204            document_config: config.memory.documents.clone(),
205            graph_config: config.memory.graph.clone(),
206            persona_config: config.memory.persona.clone(),
207            trajectory_config: config.memory.trajectory.clone(),
208            category_config: config.memory.category.clone(),
209            reasoning_config: config.memory.reasoning.clone(),
210            memcot_config: config.memory.memcot.clone(),
211            tree_config: config.memory.tree.clone(),
212            microcompact_config: config.memory.microcompact.clone(),
213            autodream_config: config.memory.autodream.clone(),
214            magic_docs_config: config.magic_docs.clone(),
215            acon_config: config.memory.compression.acon.clone(),
216            arc_config: config.memory.compression.arc.clone(),
217            anomaly_config: config.tools.anomaly.clone(),
218            result_cache_config: config.tools.result_cache.clone(),
219            utility_config: config.tools.utility.clone(),
220            orchestration_config: config.orchestration.clone(),
221            store_config: config.memory.store.clone(),
222            debug_config: config.debug.clone(),
223            server_compaction: config.llm.providers.iter().any(|e| e.server_compaction),
224            budget_hint_enabled: config.agent.budget_hint_enabled,
225            time_reminder_enabled: config.agent.time_reminder_enabled,
226            time_reminder_interval_requests: config.agent.time_reminder_interval_requests,
227            subagent_skill_token_budget: config.skills.subagent_skill_token_budget.get(),
228            secrets: config
229                .secrets
230                .custom
231                .iter()
232                .map(|(k, v)| (k.clone(), Secret::new(v.expose().to_owned())))
233                .collect::<Vec<_>>()
234                .into(),
235            recap: config.session.recap.clone(),
236            resume: config.session.resume.clone(),
237            loop_min_interval_secs: config.cli.loop_.min_interval_secs,
238            goal_config: config.goals.clone(),
239            fidelity_config: {
240                let fc = config.memory.fidelity.clone();
241                if let Some(ref cfg) = fc
242                    && let Err(e) = cfg.validate()
243                {
244                    tracing::warn!("fidelity config invalid, scoring disabled: {e}");
245                }
246                fc
247            },
248            mcp_media: config.mcp.media.clone(),
249            media_passthrough_note_enabled: config.mcp.servers.iter().any(|s| s.media_passthrough),
250            plugins_reputation: config.plugins.reputation.clone(),
251        }
252    }
253}
254
255#[cfg(test)]
256mod tests {
257    use super::*;
258
259    #[test]
260    #[allow(clippy::too_many_lines)]
261    fn from_config_maps_all_fields() {
262        let config = Config::default();
263        let budget = 100_000;
264        let sc = AgentSessionConfig::from_config(&config, budget);
265
266        assert_eq!(sc.max_tool_iterations, config.agent.max_tool_iterations);
267        assert_eq!(sc.max_tool_retries, config.tools.retry.max_attempts);
268        assert_eq!(sc.max_retry_duration_secs, config.tools.retry.budget_secs);
269        assert_eq!(sc.retry_base_ms, config.tools.retry.base_ms);
270        assert_eq!(sc.retry_max_ms, config.tools.retry.max_ms);
271        assert_eq!(
272            sc.parameter_reformat_provider,
273            config.tools.retry.parameter_reformat_provider.as_str()
274        );
275        assert_eq!(sc.tool_repeat_threshold, config.agent.tool_repeat_threshold);
276        assert_eq!(sc.tool_summarization, config.tools.summarize_output);
277        assert_eq!(sc.tool_call_cutoff, config.memory.tool_call_cutoff);
278        assert_eq!(sc.model_name, config.llm.effective_model());
279        assert_eq!(sc.embed_model, config.llm.stable_skill_embedding_model());
280        assert_eq!(sc.semantic_cache_enabled, config.llm.semantic_cache_enabled);
281        assert!(
282            (sc.semantic_cache_threshold - config.llm.semantic_cache_threshold).abs()
283                < f32::EPSILON
284        );
285        assert_eq!(
286            sc.semantic_cache_max_candidates,
287            config.llm.semantic_cache_max_candidates
288        );
289        assert_eq!(sc.budget_tokens, budget);
290        assert!(
291            (sc.soft_compaction_threshold - config.memory.soft_compaction_threshold).abs()
292                < f32::EPSILON
293        );
294        assert!(
295            (sc.hard_compaction_threshold - config.memory.hard_compaction_threshold).abs()
296                < f32::EPSILON
297        );
298        assert_eq!(
299            sc.compaction_preserve_tail,
300            config.memory.compaction_preserve_tail
301        );
302        assert_eq!(
303            sc.compaction_cooldown_turns,
304            config.memory.compaction_cooldown_turns
305        );
306        assert_eq!(sc.prune_protect_tokens, config.memory.prune_protect_tokens);
307        assert_eq!(sc.redact_credentials, config.memory.redact_credentials);
308        assert_eq!(sc.graph_config.enabled, config.memory.graph.enabled);
309        assert_eq!(
310            sc.orchestration_config.enabled,
311            config.orchestration.enabled
312        );
313        assert_eq!(
314            sc.orchestration_config.max_tasks,
315            config.orchestration.max_tasks
316        );
317        assert_eq!(sc.store_config.enabled, config.memory.store.enabled);
318        assert_eq!(
319            sc.store_config.max_value_bytes,
320            config.memory.store.max_value_bytes
321        );
322        assert_eq!(sc.anomaly_config.enabled, config.tools.anomaly.enabled);
323        assert_eq!(
324            sc.result_cache_config.enabled,
325            config.tools.result_cache.enabled
326        );
327        assert_eq!(
328            sc.result_cache_config.ttl_secs,
329            config.tools.result_cache.ttl_secs
330        );
331        assert_eq!(sc.debug_config.enabled, config.debug.enabled);
332        assert_eq!(
333            sc.document_config.rag_enabled,
334            config.memory.documents.rag_enabled
335        );
336        assert_eq!(
337            sc.overflow_config.threshold,
338            config.tools.overflow.threshold
339        );
340        assert_eq!(
341            sc.permission_policy.autonomy_level(),
342            config.security.autonomy_level
343        );
344        assert_eq!(sc.security.autonomy_level, config.security.autonomy_level);
345        assert_eq!(sc.timeouts.llm_seconds, config.timeouts.llm_seconds);
346        assert_eq!(sc.learning.enabled, config.skills.learning.enabled);
347        assert_eq!(
348            sc.server_compaction,
349            config.llm.providers.iter().any(|e| e.server_compaction)
350        );
351        assert_eq!(sc.secrets.len(), config.secrets.custom.len());
352        assert_eq!(sc.recap.on_resume, config.session.recap.on_resume);
353        assert_eq!(sc.recap.max_tokens, config.session.recap.max_tokens);
354        assert_eq!(sc.goal_config.enabled, config.goals.enabled);
355        assert_eq!(sc.goal_config.max_text_chars, config.goals.max_text_chars);
356        assert_eq!(
357            sc.fidelity_config.is_some(),
358            config.memory.fidelity.is_some()
359        );
360        assert_eq!(
361            sc.subagent_skill_token_budget,
362            config.skills.subagent_skill_token_budget.get()
363        );
364        assert_eq!(
365            sc.plugins_reputation.enabled,
366            config.plugins.reputation.enabled
367        );
368        assert!(
369            (sc.plugins_reputation.similarity_threshold
370                - config.plugins.reputation.similarity_threshold)
371                .abs()
372                < f32::EPSILON
373        );
374    }
375}
zeph_core/agent/session_config.rs

zeph_core/agent/
session_config.rs
