1use crate::catalog::{Catalog, Kind};
8use crate::core::source::Span;
9use crate::settings::SettingsNode;
10use crate::settings::table;
11use crate::wir::{Action, Program, Value};
12
13#[derive(Debug, Clone, Copy, PartialEq, Eq)]
14pub enum IncompletenessKind {
15 RawSetting,
16 UnknownAction,
17 UnknownValue,
18 OpaqueAction,
19}
20
21#[derive(Debug, Clone, Copy, PartialEq, Eq)]
22pub enum ResidualClassification {
23 ProjectDefinedConstruct,
24 SourceDeclaredVariable,
25 ProducerExtension,
26 LegacyOpaque,
27 UnresolvedIdentifier,
28}
29
30impl ResidualClassification {
31 pub fn as_str(self) -> &'static str {
32 match self {
33 Self::ProjectDefinedConstruct => "project-defined-construct",
34 Self::SourceDeclaredVariable => "source-declared-variable",
35 Self::ProducerExtension => "producer-extension",
36 Self::LegacyOpaque => "legacy-opaque-construct",
37 Self::UnresolvedIdentifier => "truly-unresolved-identifier",
38 }
39 }
40
41 pub fn evidence(self) -> &'static str {
42 match self {
43 Self::ProjectDefinedConstruct => {
44 "source settings or construct was preserved without a canonical catalog identity"
45 }
46 Self::SourceDeclaredVariable => {
47 "the identifier matches a variable declaration in the parsed source program"
48 }
49 Self::ProducerExtension => {
50 "the source uses an action-shaped identity outside the canonical catalog and no declaration resolves it"
51 }
52 Self::LegacyOpaque => {
53 "the parser preserved a legacy raw construct without a canonical contract"
54 }
55 Self::UnresolvedIdentifier => {
56 "the identifier matches neither a source declaration nor a canonical catalog identity"
57 }
58 }
59 }
60}
61
62#[derive(Debug, Clone, PartialEq, Eq)]
63#[non_exhaustive]
64pub struct SemanticIssue {
65 pub kind: IncompletenessKind,
66 pub name: String,
67 pub span: Option<Span>,
68 pub classification: ResidualClassification,
69}
70
71pub fn inspect(program: &crate::Program, catalog: &Catalog) -> Vec<SemanticIssue> {
74 let Ok(storage) = program.to_wir() else {
75 return Vec::new();
76 };
77 inspect_wir(&storage, catalog)
78}
79
80#[doc(hidden)]
81pub(crate) fn inspect_wir(program: &Program, catalog: &Catalog) -> Vec<SemanticIssue> {
82 let mut issues = Vec::new();
83 if let Some(settings) = &program.settings {
84 for node in &settings.children {
85 inspect_setting(node, &mut issues);
86 }
87 }
88 for action in program.actions.iter() {
89 inspect_action(action, program, catalog, &mut issues);
90 }
91 for value in program.values.iter() {
92 inspect_value(value, program, catalog, &mut issues);
93 }
94 issues
95}
96
97fn inspect_setting(node: &SettingsNode, issues: &mut Vec<SemanticIssue>) {
98 match node {
99 SettingsNode::Workshop { .. } => {}
100 SettingsNode::Group { children, .. } => {
101 for child in children {
102 inspect_setting(child, issues);
103 }
104 }
105 SettingsNode::Raw { name, span, .. } => issues.push(SemanticIssue {
106 kind: IncompletenessKind::RawSetting,
107 name: name.clone(),
108 span: *span,
109 classification: ResidualClassification::ProjectDefinedConstruct,
110 }),
111 SettingsNode::List {
112 name,
113 elements,
114 span,
115 } => {
116 let known = match name.as_str() {
117 "enabledMaps" | "disabledMaps" => elements
118 .iter()
119 .all(|element| table::map_name(&element.value).is_some()),
120 "enabledHeroes" | "disabledHeroes" => elements
121 .iter()
122 .all(|element| table::hero_name(&element.value).is_some()),
123 _ => true,
124 };
125 if !known {
126 issues.push(SemanticIssue {
127 kind: IncompletenessKind::RawSetting,
128 name: name.clone(),
129 span: *span,
130 classification: ResidualClassification::ProjectDefinedConstruct,
131 });
132 }
133 }
134 SettingsNode::Number { .. }
135 | SettingsNode::Bool { .. }
136 | SettingsNode::Flag { .. }
137 | SettingsNode::String { .. } => {}
138 }
139}
140
141fn inspect_action(
142 action: &Action,
143 program: &Program,
144 catalog: &Catalog,
145 issues: &mut Vec<SemanticIssue>,
146) {
147 match action {
148 Action::Call { name, span, .. } => {
149 let kind = if name == "rawWorkshopAction" {
150 Some(IncompletenessKind::OpaqueAction)
151 } else if catalog.entry(Kind::Action, name).is_none() {
152 Some(IncompletenessKind::UnknownAction)
153 } else {
154 None
155 };
156 if let Some(kind) = kind {
157 let classification = if kind == IncompletenessKind::OpaqueAction {
158 ResidualClassification::LegacyOpaque
159 } else {
160 ResidualClassification::ProducerExtension
161 };
162 issues.push(SemanticIssue {
163 kind,
164 name: name.clone(),
165 span: *span,
166 classification,
167 });
168 }
169 }
170 Action::If {
171 branches,
172 else_body,
173 ..
174 } => {
175 for branch in branches {
176 inspect_action_id(branch.body.as_slice(), program, catalog, issues);
177 }
178 if let Some(body) = else_body {
179 inspect_action_id(body.as_slice(), program, catalog, issues);
180 }
181 }
182 Action::While { body, .. }
183 | Action::ForGlobalVariable { body, .. }
184 | Action::ForPlayerVariable { body, .. } => {
185 inspect_action_id(body.as_slice(), program, catalog, issues);
186 }
187 Action::Disabled { action, .. } => {
188 inspect_action_id(std::slice::from_ref(action), program, catalog, issues);
189 }
190 Action::SetGlobalVariable { .. }
191 | Action::ModifyGlobalVariable { .. }
192 | Action::SetPlayerVariable { .. }
193 | Action::ModifyPlayerVariable { .. }
194 | Action::AssignMember { .. }
195 | Action::CallSubroutine { .. } => {}
196 }
197}
198
199fn inspect_action_id(
200 ids: &[crate::wir::ActionId],
201 program: &Program,
202 catalog: &Catalog,
203 issues: &mut Vec<SemanticIssue>,
204) {
205 for id in ids {
206 if let Some(action) = program.actions.get(*id) {
207 inspect_action(action, program, catalog, issues);
208 }
209 }
210}
211
212fn inspect_value(
213 node: &crate::wir::ValueNode,
214 program: &Program,
215 catalog: &Catalog,
216 issues: &mut Vec<SemanticIssue>,
217) {
218 if let Value::Call { name, args } = &node.value {
219 let canonical_helper = name == crate::wir::AMBIGUOUS_ENUM_CALL
223 || crate::wir::is_canonical_helper_call(name, args.len());
224 if canonical_helper {
225 return;
226 }
227 if catalog.entry(Kind::Value, name).is_none()
228 && catalog.entry(Kind::Operator, name).is_none()
229 {
230 issues.push(SemanticIssue {
231 kind: IncompletenessKind::UnknownValue,
232 name: name.clone(),
233 span: node.span,
234 classification: if program
235 .global_variables
236 .iter()
237 .any(|variable| variable.name == *name)
238 || program
239 .player_variables
240 .iter()
241 .any(|variable| variable.name == *name)
242 {
243 ResidualClassification::SourceDeclaredVariable
244 } else {
245 ResidualClassification::UnresolvedIdentifier
246 },
247 });
248 }
249 }
250}
251
252#[cfg(test)]
253mod tests {
254 use super::*;
255 use crate::settings::{Settings, SettingsNode};
256
257 #[test]
258 fn reports_preserved_and_unknown_nodes() {
259 let catalog = Catalog::builtin().expect("builtin catalog");
260 let mut program = Program {
261 settings: Some(Settings {
262 span: None,
263 children: vec![SettingsNode::Raw {
264 name: "Future Setting".to_string(),
265 value: "opaque".to_string(),
266 span: None,
267 }],
268 }),
269 ..Program::default()
270 };
271 program.actions.push(Action::Call {
272 name: "rawWorkshopAction".to_string(),
273 args: Vec::new(),
274 span: None,
275 });
276 program.actions.push(Action::Call {
277 name: "futureAction".to_string(),
278 args: Vec::new(),
279 span: None,
280 });
281 program.values.push(crate::wir::ValueNode::new(
282 Value::Call {
283 name: "futureValue".to_string(),
284 args: Vec::new(),
285 },
286 None,
287 ));
288
289 let issues = inspect_wir(&program, &catalog);
290 assert!(
291 issues
292 .iter()
293 .any(|issue| issue.kind == IncompletenessKind::RawSetting)
294 );
295 assert!(
296 issues
297 .iter()
298 .any(|issue| issue.kind == IncompletenessKind::OpaqueAction)
299 );
300 assert!(
301 issues
302 .iter()
303 .any(|issue| issue.kind == IncompletenessKind::UnknownAction)
304 );
305 assert!(
306 issues
307 .iter()
308 .any(|issue| issue.kind == IncompletenessKind::UnknownValue)
309 );
310 assert!(issues.iter().any(|issue| {
311 issue.kind == IncompletenessKind::RawSetting
312 && issue.classification == ResidualClassification::ProjectDefinedConstruct
313 }));
314 assert!(issues.iter().any(|issue| {
315 issue.kind == IncompletenessKind::OpaqueAction
316 && issue.classification == ResidualClassification::LegacyOpaque
317 }));
318 assert!(issues.iter().any(|issue| {
319 issue.kind == IncompletenessKind::UnknownValue
320 && issue.classification == ResidualClassification::UnresolvedIdentifier
321 }));
322 }
323}