vtcode_core/core/agent/

runner.rs

//! Agent runner for executing individual agent instances

use crate::config::VTCodeConfig;
use crate::config::constants::tools;
use crate::config::loader::ConfigManager;
use crate::config::models::{ModelId, Provider as ModelProvider};
use crate::config::types::ReasoningEffortLevel;
use crate::core::agent::types::AgentType;
use crate::gemini::{Content, Part, Tool};
use crate::llm::factory::create_provider_for_model;
use crate::llm::provider as uni_provider;
use crate::llm::provider::{FunctionDefinition, LLMRequest, Message, MessageRole, ToolDefinition};
use crate::llm::{AnyClient, make_client};
use crate::mcp_client::McpClient;
use crate::tools::{ToolRegistry, build_function_declarations};
use anyhow::{Result, anyhow};
use console::style;
use serde::{Deserialize, Serialize};
use serde_json::Value;
use std::path::PathBuf;
use std::sync::Arc;
use tokio::time::{Duration, timeout};
use tracing::{info, warn};

/// Individual agent runner for executing specialized agent tasks
pub struct AgentRunner {
    /// Agent type and configuration
    agent_type: AgentType,
    /// LLM client for this agent
    client: AnyClient,
    /// Unified provider client (OpenAI/Anthropic/Gemini) for tool-calling
    provider_client: Box<dyn uni_provider::LLMProvider>,
    /// Tool registry with restricted access
    tool_registry: ToolRegistry,
    /// System prompt content
    system_prompt: String,
    /// Session information
    _session_id: String,
    /// Workspace path
    _workspace: PathBuf,
    /// Model identifier
    model: String,
    /// API key (for provider client construction in future flows)
    _api_key: String,
    /// Reasoning effort level for models that support it
    reasoning_effort: Option<ReasoningEffortLevel>,
}

impl AgentRunner {
    fn print_compact_response(agent: AgentType, text: &str) {
        use console::style;
        const MAX_CHARS: usize = 1200;
        const HEAD_CHARS: usize = 800;
        const TAIL_CHARS: usize = 200;
        let clean = text.trim();
        if clean.chars().count() <= MAX_CHARS {
            println!(
                "{} [{}]: {}",
                style("[RESPONSE]").cyan().bold(),
                agent,
                clean
            );
            return;
        }
        let mut out = String::new();
        let mut count = 0;
        for ch in clean.chars() {
            if count >= HEAD_CHARS {
                break;
            }
            out.push(ch);
            count += 1;
        }
        out.push_str("\n…\n");
        // tail
        let total = clean.chars().count();
        let start_tail = total.saturating_sub(TAIL_CHARS);
        let tail: String = clean.chars().skip(start_tail).collect();
        out.push_str(&tail);
        println!("{} [{}]: {}", style("[RESPONSE]").cyan().bold(), agent, out);
        println!(
            "{} truncated long response ({} chars).",
            style("[NOTE]").dim(),
            total
        );
    }
    /// Create informative progress message based on operation type
    fn create_progress_message(&self, operation: &str, details: Option<&str>) -> String {
        match operation {
            "thinking" => "Analyzing request and planning approach...".to_string(),
            "processing" => format!("Processing turn with {} model", self.client.model_id()),
            "tool_call" => {
                if let Some(tool) = details {
                    format!("Executing {} tool for task completion", tool)
                } else {
                    "Executing tool to gather information".to_string()
                }
            }
            "file_read" => {
                if let Some(file) = details {
                    format!("Reading {} to understand structure", file)
                } else {
                    "Reading file to analyze content".to_string()
                }
            }
            "file_write" => {
                if let Some(file) = details {
                    format!("Writing changes to {}", file)
                } else {
                    "Writing file with requested changes".to_string()
                }
            }
            "search" => {
                if let Some(pattern) = details {
                    format!("Searching codebase for '{}'", pattern)
                } else {
                    "Searching codebase for relevant information".to_string()
                }
            }
            "terminal" => {
                if let Some(cmd) = details {
                    format!(
                        "Running terminal command: {}",
                        cmd.split(' ').next().unwrap_or(cmd)
                    )
                } else {
                    "Executing terminal command".to_string()
                }
            }
            "completed" => "Task completed successfully!".to_string(),
            "error" => {
                if let Some(err) = details {
                    format!("Error encountered: {}", err)
                } else {
                    "An error occurred during execution".to_string()
                }
            }
            _ => format!("{}...", operation),
        }
    }

    /// Create a new agent runner
    pub fn new(
        agent_type: AgentType,
        model: ModelId,
        api_key: String,
        workspace: PathBuf,
        session_id: String,
        reasoning_effort: Option<ReasoningEffortLevel>,
    ) -> Result<Self> {
        // Create client based on model
        let client: AnyClient = make_client(api_key.clone(), model.clone());

        // Create unified provider client for tool calling
        let provider_client = create_provider_for_model(model.as_str(), api_key.clone(), None)
            .map_err(|e| anyhow!("Failed to create provider client: {}", e))?;

        // Create system prompt for single agent
        let system_prompt = crate::prompts::read_system_prompt_from_md()
            .unwrap_or_else(|_| crate::prompts::system::default_system_prompt().to_string());

        Ok(Self {
            agent_type,
            client,
            provider_client,
            tool_registry: ToolRegistry::new(workspace.clone()),
            system_prompt,
            _session_id: session_id,
            _workspace: workspace,
            model: model.as_str().to_string(),
            _api_key: api_key,
            reasoning_effort,
        })
    }

    /// Enable full-auto execution with the provided allow-list.
    pub fn enable_full_auto(&mut self, allowed_tools: &[String]) {
        self.tool_registry.enable_full_auto_mode(allowed_tools);
    }

    /// Apply workspace configuration to the tool registry, including tool policies and MCP setup.
    pub async fn apply_workspace_configuration(&mut self, vt_cfg: &VTCodeConfig) -> Result<()> {
        self.tool_registry.initialize_async().await?;

        if let Err(err) = self.tool_registry.apply_config_policies(&vt_cfg.tools) {
            eprintln!(
                "Warning: Failed to apply tool policies from config: {}",
                err
            );
        }

        if vt_cfg.mcp.enabled {
            let mut mcp_client = McpClient::new(vt_cfg.mcp.clone());
            match timeout(Duration::from_secs(30), mcp_client.initialize()).await {
                Ok(Ok(())) => {
                    let mcp_client = Arc::new(mcp_client);
                    self.tool_registry.set_mcp_client(Arc::clone(&mcp_client));
                    if let Err(err) = self.tool_registry.refresh_mcp_tools().await {
                        warn!("Failed to refresh MCP tools: {}", err);
                    }
                }
                Ok(Err(err)) => {
                    warn!("MCP client initialization failed: {}", err);
                }
                Err(_) => {
                    warn!("MCP client initialization timed out after 30 seconds");
                }
            }
        }

        Ok(())
    }

    /// Execute a task with this agent
    pub async fn execute_task(
        &mut self,
        task: &Task,
        contexts: &[ContextItem],
    ) -> Result<TaskResults> {
        // Agent execution status
        let agent_prefix = format!("[{}]", self.agent_type);
        println!(
            "{} {}",
            agent_prefix,
            self.create_progress_message("thinking", None)
        );

        println!(
            "{} Executing {} task: {}",
            style("[AGENT]").blue().bold().on_black(),
            self.agent_type,
            task.title
        );

        // Prepare conversation with task context
        let mut conversation = Vec::new();

        // Add system instruction as the first message
        let system_content = self.build_system_instruction(task, contexts)?;
        conversation.push(Content::user_text(system_content));

        // Add task description
        conversation.push(Content::user_text(format!(
            "Task: {}\nDescription: {}",
            task.title, task.description
        )));

        if let Some(instructions) = task.instructions.as_ref() {
            conversation.push(Content::user_text(instructions.clone()));
        }

        // Add context items if any
        if !contexts.is_empty() {
            let context_content: Vec<String> = contexts
                .iter()
                .map(|ctx| format!("Context [{}]: {}", ctx.id, ctx.content))
                .collect();
            conversation.push(Content::user_text(format!(
                "Relevant Context:\n{}",
                context_content.join("\n")
            )));
        }

        // Build available tools for this agent
        let gemini_tools = self.build_agent_tools()?;

        // Convert Gemini tools to universal ToolDefinition format
        let tools: Vec<ToolDefinition> = gemini_tools
            .into_iter()
            .flat_map(|tool| tool.function_declarations)
            .map(|decl| ToolDefinition {
                tool_type: "function".to_string(),
                function: FunctionDefinition {
                    name: decl.name,
                    description: decl.description,
                    parameters: decl.parameters,
                },
            })
            .collect();

        // Track execution results
        let created_contexts = Vec::new();
        let mut modified_files = Vec::new();
        let mut executed_commands = Vec::new();
        let mut warnings = Vec::new();
        let mut has_completed = false;

        // Determine max loops via configuration
        let cfg = ConfigManager::load()
            .or_else(|_| ConfigManager::load_from_workspace("."))
            .or_else(|_| ConfigManager::load_from_file("vtcode.toml"))
            .map(|cm| cm.config().clone())
            .unwrap_or_default();
        let max_tool_loops = cfg.tools.max_tool_loops.max(1);

        // Agent execution loop uses global tool loop guard
        for turn in 0..max_tool_loops {
            if has_completed {
                break;
            }

            println!(
                "{} {} is processing turn {}...",
                agent_prefix,
                style("(PROC)").yellow().bold(),
                turn + 1
            );

            let request = LLMRequest {
                messages: conversation
                    .iter()
                    .map(|content| {
                        // Convert Gemini Content to LLM Message
                        let role = match content.role.as_str() {
                            "user" => MessageRole::User,
                            "model" => MessageRole::Assistant,
                            _ => MessageRole::User,
                        };
                        let content_text = content
                            .parts
                            .iter()
                            .filter_map(|part| match part {
                                crate::gemini::Part::Text { text } => Some(text.clone()),
                                _ => None,
                            })
                            .collect::<Vec<_>>()
                            .join("\n");
                        Message {
                            role,
                            content: content_text,
                            tool_calls: None,
                            tool_call_id: None,
                        }
                    })
                    .collect(),
                system_prompt: None,
                tools: Some(tools.clone()),
                model: self.model.clone(),
                max_tokens: Some(2000),
                temperature: Some(0.7),
                stream: false,
                tool_choice: None,
                parallel_tool_calls: None,
                parallel_tool_config: Some(
                    crate::llm::provider::ParallelToolConfig::anthropic_optimized(),
                ),
                reasoning_effort: if self.provider_client.supports_reasoning_effort(&self.model) {
                    self.reasoning_effort
                } else {
                    None
                },
            };

            // Use provider-specific client for OpenAI/Anthropic (and generic support for others)
            // Prepare for provider-specific vs Gemini handling
            #[allow(unused_assignments)]
            let mut response_opt: Option<crate::llm::types::LLMResponse> = None;
            let provider_kind = self
                .model
                .parse::<ModelId>()
                .map(|m| m.provider())
                .unwrap_or(ModelProvider::Gemini);

            if matches!(
                provider_kind,
                ModelProvider::OpenAI | ModelProvider::Anthropic | ModelProvider::DeepSeek
            ) {
                let resp = self
                    .provider_client
                    .generate(request.clone())
                    .await
                    .map_err(|e| {
                        println!(
                            "{} {} Failed",
                            agent_prefix,
                            style("(ERROR)").red().bold().on_black()
                        );
                        anyhow!(
                            "Agent {} execution failed at turn {}: {}",
                            self.agent_type,
                            turn,
                            e
                        )
                    })?;

                // Update progress for successful response
                println!(
                    "{} {}",
                    agent_prefix,
                    format!(
                        "{} {} received response, processing...",
                        self.agent_type,
                        style("(RECV)").green().bold()
                    )
                );

                let mut had_tool_call = false;

                if let Some(tool_calls) = resp.tool_calls.as_ref() {
                    if !tool_calls.is_empty() {
                        had_tool_call = true;
                        for call in tool_calls {
                            let name = call.function.name.as_str();
                            println!(
                                "{} [{}] Calling tool: {}",
                                style("[TOOL_CALL]").blue().bold(),
                                self.agent_type,
                                name
                            );
                            let args = call
                                .parsed_arguments()
                                .unwrap_or_else(|_| serde_json::json!({}));
                            match self.execute_tool(name, &args).await {
                                Ok(result) => {
                                    println!(
                                        "{} {}",
                                        agent_prefix,
                                        format!(
                                            "{} {} tool executed successfully",
                                            style("(OK)").green(),
                                            name
                                        )
                                    );
                                    let tool_result = serde_json::to_string(&result)?;
                                    conversation.push(Content {
                                        role: "user".to_string(),
                                        parts: vec![Part::Text {
                                            text: format!("Tool {} result: {}", name, tool_result),
                                        }],
                                    });
                                    executed_commands.push(name.to_string());
                                    if name == tools::WRITE_FILE {
                                        if let Some(filepath) =
                                            args.get("path").and_then(|p| p.as_str())
                                        {
                                            modified_files.push(filepath.to_string());
                                        }
                                    }
                                }
                                Err(e) => {
                                    println!(
                                        "{} {}",
                                        agent_prefix,
                                        format!(
                                            "{} {} tool failed: {}",
                                            style("(ERR)").red(),
                                            name,
                                            e
                                        )
                                    );
                                    warnings.push(format!("Tool {} failed: {}", name, e));
                                    conversation.push(Content {
                                        role: "user".to_string(),
                                        parts: vec![Part::Text {
                                            text: format!("Tool {} failed: {}", name, e),
                                        }],
                                    });
                                }
                            }
                        }
                    }
                }

                // If no tool calls, treat as regular content
                let response_text = resp.content.clone().unwrap_or_default();
                if !had_tool_call {
                    if !response_text.trim().is_empty() {
                        Self::print_compact_response(self.agent_type, &response_text);
                        conversation.push(Content {
                            role: "model".to_string(),
                            parts: vec![Part::Text {
                                text: response_text.clone(),
                            }],
                        });
                    }
                }

                // Completion detection
                if !has_completed {
                    let response_lower = response_text.to_lowercase();
                    let completion_indicators = [
                        "task completed",
                        "task done",
                        "finished",
                        "complete",
                        "summary",
                        "i have successfully",
                        "i've completed",
                        "i have finished",
                        "task accomplished",
                        "mission accomplished",
                        "objective achieved",
                        "work is done",
                        "all done",
                        "completed successfully",
                        "task execution complete",
                        "operation finished",
                    ];
                    let is_completed = completion_indicators
                        .iter()
                        .any(|&indicator| response_lower.contains(indicator));
                    let has_explicit_completion = response_lower.contains("the task is complete")
                        || response_lower.contains("task has been completed")
                        || response_lower.contains("i am done")
                        || response_lower.contains("that's all")
                        || response_lower.contains("no more actions needed");
                    if is_completed || has_explicit_completion {
                        has_completed = true;
                        println!(
                            "{} {}",
                            agent_prefix,
                            format!(
                                "{} {} completed task successfully",
                                self.agent_type,
                                style("(SUCCESS)").green().bold()
                            )
                        );
                    }
                }

                let should_continue = had_tool_call || (!has_completed && turn < 9);
                if !should_continue {
                    if has_completed {
                        println!(
                            "{} {}",
                            agent_prefix,
                            format!(
                                "{} {} finished - task completed",
                                self.agent_type,
                                style("(SUCCESS)").green().bold()
                            )
                        );
                    } else if turn >= 9 {
                        println!(
                            "{} {}",
                            agent_prefix,
                            format!(
                                "{} {} finished - maximum turns reached",
                                self.agent_type,
                                style("(TIME)").yellow().bold()
                            )
                        );
                    } else {
                        println!(
                            "{} {}",
                            agent_prefix,
                            format!(
                                "{} {} finished",
                                self.agent_type,
                                style("(FINISH)").blue().bold()
                            )
                        );
                    }
                    break;
                }

                // Continue loop for tool results
                continue;
            } else {
                // Gemini path (existing flow)
                let response = self
                    .client
                    .generate(&serde_json::to_string(&request)?)
                    .await
                    .map_err(|e| {
                        println!(
                            "{} {} Failed",
                            agent_prefix,
                            style("(ERROR)").red().bold().on_black()
                        );
                        anyhow!(
                            "Agent {} execution failed at turn {}: {}",
                            self.agent_type,
                            turn,
                            e
                        )
                    })?;
                response_opt = Some(response);
            }

            // For Gemini path: use original response handling
            let response = response_opt.expect("response should be set for Gemini path");

            // Update progress for successful response
            println!(
                "{} {}",
                agent_prefix,
                format!(
                    "{} {} received response, processing...",
                    self.agent_type,
                    style("(RECV)").green().bold()
                )
            );

            // Use response content directly
            if !response.content.is_empty() {
                // Try to parse the response as JSON to check for tool calls
                let mut had_tool_call = false;

                // Try to parse as a tool call response
                if let Ok(tool_call_response) = serde_json::from_str::<Value>(&response.content) {
                    // Check for standard tool_calls format
                    if let Some(tool_calls) = tool_call_response
                        .get("tool_calls")
                        .and_then(|tc| tc.as_array())
                    {
                        had_tool_call = true;

                        // Process each tool call
                        for tool_call in tool_calls {
                            if let Some(function) = tool_call.get("function") {
                                if let (Some(name), Some(arguments)) = (
                                    function.get("name").and_then(|n| n.as_str()),
                                    function.get("arguments"),
                                ) {
                                    println!(
                                        "{} [{}] Calling tool: {}",
                                        style("[TOOL_CALL]").blue().bold(),
                                        self.agent_type,
                                        name
                                    );

                                    // Execute the tool
                                    match self.execute_tool(name, &arguments.clone()).await {
                                        Ok(result) => {
                                            println!(
                                                "{} {}",
                                                agent_prefix,
                                                format!(
                                                    "{} {} tool executed successfully",
                                                    style("(OK)").green(),
                                                    name
                                                )
                                            );

                                            // Add tool result to conversation
                                            let tool_result = serde_json::to_string(&result)?;
                                            conversation.push(Content {
                                                role: "user".to_string(), // Gemini API only accepts "user" and "model"
                                                parts: vec![Part::Text {
                                                    text: format!(
                                                        "Tool {} result: {}",
                                                        name, tool_result
                                                    ),
                                                }],
                                            });

                                            // Track what the agent did
                                            executed_commands.push(name.to_string());

                                            // Special handling for certain tools
                                            if name == tools::WRITE_FILE {
                                                if let Some(filepath) =
                                                    arguments.get("path").and_then(|p| p.as_str())
                                                {
                                                    modified_files.push(filepath.to_string());
                                                }
                                            }
                                        }
                                        Err(e) => {
                                            println!(
                                                "{} {}",
                                                agent_prefix,
                                                format!(
                                                    "{} {} tool failed: {}",
                                                    style("(ERR)").red(),
                                                    name,
                                                    e
                                                )
                                            );
                                            warnings.push(format!("Tool {} failed: {}", name, e));
                                            conversation.push(Content {
                                                role: "user".to_string(), // Gemini API only accepts "user" and "model"
                                                parts: vec![Part::Text {
                                                    text: format!("Tool {} failed: {}", name, e),
                                                }],
                                            });
                                        }
                                    }
                                }
                            }
                        }
                    }
                    // Check for Gemini functionCall format
                    else if let Some(function_call) = tool_call_response.get("functionCall") {
                        had_tool_call = true;

                        if let (Some(name), Some(args)) = (
                            function_call.get("name").and_then(|n| n.as_str()),
                            function_call.get("args"),
                        ) {
                            println!(
                                "{} [{}] Calling tool: {}",
                                style("[TOOL_CALL]").blue().bold(),
                                self.agent_type,
                                name
                            );

                            // Execute the tool
                            match self.execute_tool(name, args).await {
                                Ok(result) => {
                                    println!(
                                        "{} {}",
                                        agent_prefix,
                                        format!(
                                            "{} {} tool executed successfully",
                                            style("(OK)").green(),
                                            name
                                        )
                                    );

                                    // Add tool result to conversation
                                    let tool_result = serde_json::to_string(&result)?;
                                    conversation.push(Content {
                                        role: "user".to_string(), // Gemini API only accepts "user" and "model"
                                        parts: vec![Part::Text {
                                            text: format!("Tool {} result: {}", name, tool_result),
                                        }],
                                    });

                                    // Track what the agent did
                                    executed_commands.push(name.to_string());

                                    // Special handling for certain tools
                                    if name == tools::WRITE_FILE {
                                        if let Some(filepath) =
                                            args.get("path").and_then(|p| p.as_str())
                                        {
                                            modified_files.push(filepath.to_string());
                                        }
                                    }
                                }
                                Err(e) => {
                                    println!(
                                        "{} {}",
                                        agent_prefix,
                                        format!(
                                            "{} {} tool failed: {}",
                                            style("(ERR)").red().bold(),
                                            name,
                                            e
                                        )
                                    );
                                    warnings.push(format!("Tool {} failed: {}", name, e));
                                    conversation.push(Content {
                                        role: "user".to_string(), // Gemini API only accepts "user" and "model"
                                        parts: vec![Part::Text {
                                            text: format!("Tool {} failed: {}", name, e),
                                        }],
                                    });
                                }
                            }
                        }
                    }
                    // Check for tool_code format (what agents are actually producing)
                    else if let Some(tool_code) = tool_call_response
                        .get("tool_code")
                        .and_then(|tc| tc.as_str())
                    {
                        had_tool_call = true;

                        println!(
                            "{} [{}] Executing tool code: {}",
                            style("[TOOL_EXEC]").cyan().bold().on_black(),
                            self.agent_type,
                            tool_code
                        );

                        // Try to parse the tool_code as a function call
                        // This is a simplified parser for the format: function_name(args)
                        if let Some((func_name, args_str)) = parse_tool_code(tool_code) {
                            println!(
                                "{} [{}] Parsed tool: {} with args: {}",
                                style("[TOOL_PARSE]").yellow().bold().on_black(),
                                self.agent_type,
                                func_name,
                                args_str
                            );

                            // Parse arguments as JSON
                            match serde_json::from_str::<Value>(&args_str) {
                                Ok(arguments) => {
                                    // Execute the tool
                                    match self.execute_tool(&func_name, &arguments).await {
                                        Ok(result) => {
                                            println!(
                                                "{} {}",
                                                agent_prefix,
                                                format!(
                                                    "{} {} tool executed successfully",
                                                    style("(OK)").green(),
                                                    func_name
                                                )
                                            );

                                            // Add tool result to conversation
                                            let tool_result = serde_json::to_string(&result)?;
                                            conversation.push(Content {
                                                role: "user".to_string(), // Gemini API only accepts "user" and "model"
                                                parts: vec![Part::Text {
                                                    text: format!(
                                                        "Tool {} result: {}",
                                                        func_name, tool_result
                                                    ),
                                                }],
                                            });

                                            // Track what the agent did
                                            executed_commands.push(func_name.to_string());

                                            // Special handling for certain tools
                                            if func_name == tools::WRITE_FILE {
                                                if let Some(filepath) =
                                                    arguments.get("path").and_then(|p| p.as_str())
                                                {
                                                    modified_files.push(filepath.to_string());
                                                }
                                            }
                                        }
                                        Err(e) => {
                                            println!(
                                                "{} {}",
                                                agent_prefix,
                                                format!(
                                                    "{} {} tool failed: {}",
                                                    style("(ERROR)").red().bold(),
                                                    func_name,
                                                    e
                                                )
                                            );
                                            warnings
                                                .push(format!("Tool {} failed: {}", func_name, e));
                                            conversation.push(Content {
                                                role: "user".to_string(), // Gemini API only accepts "user" and "model"
                                                parts: vec![Part::Text {
                                                    text: format!(
                                                        "Tool {} failed: {}",
                                                        func_name, e
                                                    ),
                                                }],
                                            });
                                        }
                                    }
                                }
                                Err(e) => {
                                    let error_msg = format!(
                                        "Failed to parse tool arguments '{}': {}",
                                        args_str, e
                                    );
                                    warnings.push(error_msg.clone());
                                    conversation.push(Content {
                                        role: "user".to_string(), // Gemini API only accepts "user" and "model"
                                        parts: vec![Part::Text { text: error_msg }],
                                    });
                                }
                            }
                        } else {
                            let error_msg = format!("Failed to parse tool code: {}", tool_code);
                            warnings.push(error_msg.clone());
                            conversation.push(Content {
                                role: "user".to_string(), // Gemini API only accepts "user" and "model"
                                parts: vec![Part::Text { text: error_msg }],
                            });
                        }
                    }
                    // Check for tool_name format (alternative format)
                    else if let Some(tool_name) = tool_call_response
                        .get("tool_name")
                        .and_then(|tn| tn.as_str())
                    {
                        had_tool_call = true;

                        println!(
                            "{} [{}] Calling tool: {}",
                            style("[TOOL_CALL]").blue().bold().on_black(),
                            self.agent_type,
                            tool_name
                        );

                        if let Some(parameters) = tool_call_response.get("parameters") {
                            // Execute the tool
                            match self.execute_tool(tool_name, parameters).await {
                                Ok(result) => {
                                    println!(
                                        "{} {}",
                                        agent_prefix,
                                        format!(
                                            "{} {} tool executed successfully",
                                            style("(SUCCESS)").green().bold(),
                                            tool_name
                                        )
                                    );

                                    // Add tool result to conversation
                                    let tool_result = serde_json::to_string(&result)?;
                                    conversation.push(Content {
                                        role: "user".to_string(), // Gemini API only accepts "user" and "model"
                                        parts: vec![Part::Text {
                                            text: format!(
                                                "Tool {} result: {}",
                                                tool_name, tool_result
                                            ),
                                        }],
                                    });

                                    // Track what the agent did
                                    executed_commands.push(tool_name.to_string());

                                    // Special handling for certain tools
                                    if tool_name == tools::WRITE_FILE {
                                        if let Some(filepath) =
                                            parameters.get("path").and_then(|p| p.as_str())
                                        {
                                            modified_files.push(filepath.to_string());
                                        }
                                    }
                                }
                                Err(e) => {
                                    println!(
                                        "{} {}",
                                        agent_prefix,
                                        format!(
                                            "{} {} tool failed: {}",
                                            style("(ERROR)").red().bold(),
                                            tool_name,
                                            e
                                        )
                                    );
                                    warnings.push(format!("Tool {} failed: {}", tool_name, e));
                                    conversation.push(Content {
                                        role: "user".to_string(), // Gemini API only accepts "user" and "model"
                                        parts: vec![Part::Text {
                                            text: format!("Tool {} failed: {}", tool_name, e),
                                        }],
                                    });
                                }
                            }
                        }
                    } else {
                        // Regular content response
                        Self::print_compact_response(self.agent_type, response.content.trim());
                        conversation.push(Content {
                            role: "model".to_string(),
                            parts: vec![Part::Text {
                                text: response.content.clone(),
                            }],
                        });
                    }
                } else {
                    // Regular text response
                    Self::print_compact_response(self.agent_type, response.content.trim());
                    conversation.push(Content {
                        role: "model".to_string(),
                        parts: vec![Part::Text {
                            text: response.content.clone(),
                        }],
                    });
                }

                // Check for task completion indicators in the response
                if !has_completed {
                    let response_lower = response.content.to_lowercase();

                    // More comprehensive completion detection
                    let completion_indicators = [
                        "task completed",
                        "task done",
                        "finished",
                        "complete",
                        "summary",
                        "i have successfully",
                        "i've completed",
                        "i have finished",
                        "task accomplished",
                        "mission accomplished",
                        "objective achieved",
                        "work is done",
                        "all done",
                        "completed successfully",
                        "task execution complete",
                        "operation finished",
                    ];

                    // Check if any completion indicator is present
                    let is_completed = completion_indicators
                        .iter()
                        .any(|&indicator| response_lower.contains(indicator));

                    // Also check for explicit completion statements
                    let has_explicit_completion = response_lower.contains("the task is complete")
                        || response_lower.contains("task has been completed")
                        || response_lower.contains("i am done")
                        || response_lower.contains("that's all")
                        || response_lower.contains("no more actions needed");

                    if is_completed || has_explicit_completion {
                        has_completed = true;
                        println!(
                            "{} {}",
                            agent_prefix,
                            format!(
                                "{} {} completed task successfully",
                                self.agent_type,
                                style("(SUCCESS)").green().bold()
                            )
                        );
                    }
                }

                // Improved loop termination logic
                // Continue if: we had tool calls, task is not completed, and we haven't exceeded max turns
                let should_continue = had_tool_call || (!has_completed && turn < 9);

                if !should_continue {
                    if has_completed {
                        println!(
                            "{} {}",
                            agent_prefix,
                            format!(
                                "{} {} finished - task completed",
                                self.agent_type,
                                style("(SUCCESS)").green().bold()
                            )
                        );
                    } else if turn >= 9 {
                        println!(
                            "{} {}",
                            agent_prefix,
                            format!(
                                "{} {} finished - maximum turns reached",
                                self.agent_type,
                                style("(TIME)").yellow().bold()
                            )
                        );
                    } else {
                        println!(
                            "{} {}",
                            agent_prefix,
                            format!(
                                "{} {} finished - no more actions needed",
                                self.agent_type,
                                style("(FINISH)").blue().bold()
                            )
                        );
                    }
                    break;
                }
            } else {
                // Empty response - check if we should continue or if task is actually complete
                if has_completed {
                    println!(
                        "{} {}",
                        agent_prefix,
                        format!(
                            "{} {} finished - task was completed earlier",
                            self.agent_type,
                            style("(SUCCESS)").green().bold()
                        )
                    );
                    break;
                } else if turn >= 9 {
                    println!(
                        "{} {}",
                        agent_prefix,
                        format!(
                            "{} {} finished - maximum turns reached with empty response",
                            self.agent_type,
                            style("(TIME)").yellow().bold()
                        )
                    );
                    break;
                } else {
                    // Empty response but task not complete - this might indicate an issue
                    println!(
                        "{} {}",
                        agent_prefix,
                        format!(
                            "{} {} received empty response, continuing...",
                            self.agent_type,
                            style("(EMPTY)").yellow()
                        )
                    );
                    // Don't break here, let the loop continue to give the agent another chance
                }
            }
        }

        // Agent execution completed
        println!("{} Done", agent_prefix);

        // Generate meaningful summary based on agent actions
        let summary = self.generate_task_summary(
            &modified_files,
            &executed_commands,
            &warnings,
            &conversation,
        );

        // Return task results
        Ok(TaskResults {
            created_contexts,
            modified_files,
            executed_commands,
            summary,
            warnings,
        })
    }

    /// Build system instruction for agent based on task and contexts
    fn build_system_instruction(&self, task: &Task, contexts: &[ContextItem]) -> Result<String> {
        let mut instruction = self.system_prompt.clone();

        // Add task-specific information
        instruction.push_str(&format!("\n\nTask: {}\n{}", task.title, task.description));

        // Add context information if any
        if !contexts.is_empty() {
            instruction.push_str("\n\nRelevant Context:");
            for ctx in contexts {
                instruction.push_str(&format!("\n[{}] {}", ctx.id, ctx.content));
            }
        }

        Ok(instruction)
    }

    /// Build available tools for this agent type
    fn build_agent_tools(&self) -> Result<Vec<Tool>> {
        // Build function declarations based on available tools
        let declarations = build_function_declarations();

        // Filter tools based on agent type and permissions
        let allowed_tools: Vec<Tool> = declarations
            .into_iter()
            .filter(|decl| self.is_tool_allowed(&decl.name))
            .map(|decl| Tool {
                function_declarations: vec![decl],
            })
            .collect();

        Ok(allowed_tools)
    }

    /// Check if a tool is allowed for this agent
    fn is_tool_allowed(&self, tool_name: &str) -> bool {
        if let Ok(policy_manager) = self.tool_registry.policy_manager() {
            match policy_manager.get_policy(tool_name) {
                crate::tool_policy::ToolPolicy::Allow | crate::tool_policy::ToolPolicy::Prompt => {
                    true
                }
                crate::tool_policy::ToolPolicy::Deny => false,
            }
        } else {
            true
        }
    }

    /// Execute a tool by name with given arguments
    async fn execute_tool(&self, tool_name: &str, args: &Value) -> Result<Value> {
        // Enforce per-agent shell policies for RUN_TERMINAL_CMD/BASH
        let is_shell = tool_name == tools::RUN_TERMINAL_CMD || tool_name == tools::BASH;
        if is_shell {
            let cfg = ConfigManager::load()
                .or_else(|_| ConfigManager::load_from_workspace("."))
                .or_else(|_| ConfigManager::load_from_file("vtcode.toml"))
                .map(|cm| cm.config().clone())
                .unwrap_or_default();

            let cmd_text = if let Some(cmd_val) = args.get("command") {
                if cmd_val.is_array() {
                    cmd_val
                        .as_array()
                        .unwrap()
                        .iter()
                        .filter_map(|v| v.as_str())
                        .collect::<Vec<_>>()
                        .join(" ")
                } else {
                    cmd_val.as_str().unwrap_or("").to_string()
                }
            } else {
                String::new()
            };

            let agent_prefix = format!(
                "VTCODE_{}_COMMANDS_",
                self.agent_type.to_string().to_uppercase()
            );

            let mut deny_regex = cfg.commands.deny_regex.clone();
            if let Ok(extra) = std::env::var(format!("{}DENY_REGEX", agent_prefix)) {
                deny_regex.extend(extra.split(',').map(|s| s.trim().to_string()));
            }
            for pat in &deny_regex {
                if regex::Regex::new(pat)
                    .ok()
                    .map(|re| re.is_match(&cmd_text))
                    .unwrap_or(false)
                {
                    return Err(anyhow!("Shell command denied by regex: {}", pat));
                }
            }

            let mut deny_glob = cfg.commands.deny_glob.clone();
            if let Ok(extra) = std::env::var(format!("{}DENY_GLOB", agent_prefix)) {
                deny_glob.extend(extra.split(',').map(|s| s.trim().to_string()));
            }
            for pat in &deny_glob {
                let re = format!("^{}$", regex::escape(pat).replace(r"\*", ".*"));
                if regex::Regex::new(&re)
                    .ok()
                    .map(|re| re.is_match(&cmd_text))
                    .unwrap_or(false)
                {
                    return Err(anyhow!("Shell command denied by glob: {}", pat));
                }
            }
            info!(target = "policy", agent = ?self.agent_type, tool = tool_name, cmd = %cmd_text, "shell_policy_checked");
        }
        // Clone the tool registry for this execution
        let mut registry = self.tool_registry.clone();

        // Initialize async components
        registry.initialize_async().await?;

        // Try with simple adaptive retry (up to 2 retries)
        let mut delay = std::time::Duration::from_millis(200);
        for attempt in 0..3 {
            match registry.execute_tool(tool_name, args.clone()).await {
                Ok(result) => return Ok(result),
                Err(_e) if attempt < 2 => {
                    tokio::time::sleep(delay).await;
                    delay = delay.saturating_mul(2);
                    continue;
                }
                Err(e) => {
                    return Err(anyhow!(
                        "Tool '{}' not found or failed to execute: {}",
                        tool_name,
                        e
                    ));
                }
            }
        }
        unreachable!()
    }

    /// Generate a meaningful summary of the task execution
    fn generate_task_summary(
        &self,
        modified_files: &[String],
        executed_commands: &[String],
        warnings: &[String],
        conversation: &[Content],
    ) -> String {
        let mut summary = vec![];

        // Add task title and agent type
        summary.push(format!(
            "Task: {}",
            conversation
                .get(0)
                .and_then(|c| c.parts.get(0))
                .and_then(|p| p.as_text())
                .unwrap_or(&"".to_string())
        ));
        summary.push(format!("Agent Type: {:?}", self.agent_type));

        // Add executed commands
        if !executed_commands.is_empty() {
            summary.push("Executed Commands:".to_string());
            for command in executed_commands {
                summary.push(format!(" - {}", command));
            }
        }

        // Add modified files
        if !modified_files.is_empty() {
            summary.push("Modified Files:".to_string());
            for file in modified_files {
                summary.push(format!(" - {}", file));
            }
        }

        // Add warnings if any
        if !warnings.is_empty() {
            summary.push("Warnings:".to_string());
            for warning in warnings {
                summary.push(format!(" - {}", warning));
            }
        }

        // Add final status
        let final_status = if conversation.last().map_or(false, |c| {
            c.role == "model"
                && c.parts.iter().any(|p| {
                    p.as_text().map_or(false, |t| {
                        t.contains("completed") || t.contains("done") || t.contains("finished")
                    })
                })
        }) {
            "Task completed successfully".to_string()
        } else {
            "Task did not complete as expected".to_string()
        };
        summary.push(final_status);

        // Join all parts with new lines
        summary.join("\n")
    }
}

/// Parse tool code in the format: function_name(arg1=value1, arg2=value2)
fn parse_tool_code(tool_code: &str) -> Option<(String, String)> {
    // Remove any markdown code blocks
    let code = tool_code.trim();
    let code = if code.starts_with("```") && code.ends_with("```") {
        code.trim_start_matches("```")
            .trim_end_matches("```")
            .trim()
    } else {
        code
    };

    // Try to match function call pattern: name(args)
    if let Some(open_paren) = code.find('(') {
        if let Some(close_paren) = code.rfind(')') {
            let func_name = code[..open_paren].trim().to_string();
            let args_str = &code[open_paren + 1..close_paren];

            // Convert Python-style arguments to JSON
            let json_args = convert_python_args_to_json(args_str)?;
            return Some((func_name, json_args));
        }
    }

    None
}

/// Convert Python-style function arguments to JSON
fn convert_python_args_to_json(args_str: &str) -> Option<String> {
    if args_str.trim().is_empty() {
        return Some("{}".to_string());
    }

    let mut json_parts = Vec::new();

    for arg in args_str.split(',').map(|s| s.trim()) {
        if arg.is_empty() {
            continue;
        }

        // Handle key=value format
        if let Some(eq_pos) = arg.find('=') {
            let key = arg[..eq_pos].trim().trim_matches('"').trim_matches('\'');
            let value = arg[eq_pos + 1..].trim();

            // Convert value to JSON format
            let json_value = if value.starts_with('"') && value.ends_with('"') {
                value.to_string()
            } else if value.starts_with('\'') && value.ends_with('\'') {
                format!("\"{}\"", value.trim_matches('\''))
            } else if value == "True" || value == "true" {
                "true".to_string()
            } else if value == "False" || value == "false" {
                "false".to_string()
            } else if value == "None" || value == "null" {
                "null".to_string()
            } else if let Ok(num) = value.parse::<f64>() {
                num.to_string()
            } else {
                // Assume it's a string that needs quotes
                format!("\"{}\"", value)
            };

            json_parts.push(format!("\"{}\": {}", key, json_value));
        } else {
            // Handle positional arguments (not supported well, but try)
            return None;
        }
    }

    Some(format!("{{{}}}", json_parts.join(", ")))
}

/// Task specification consumed by the benchmark/autonomous runner.
#[derive(Debug, Clone, Serialize, Deserialize)]
pub struct Task {
    /// Stable identifier for reporting.
    pub id: String,
    /// Human-readable task title displayed in progress messages.
    pub title: String,
    /// High-level description of the task objective.
    pub description: String,
    /// Optional explicit instructions appended to the conversation.
    #[serde(default, skip_serializing_if = "Option::is_none")]
    pub instructions: Option<String>,
}

impl Task {
    /// Construct a task with the provided metadata.
    pub fn new(id: String, title: String, description: String) -> Self {
        Self {
            id,
            title,
            description,
            instructions: None,
        }
    }
}

/// Context entry supplied alongside the benchmark task.
#[derive(Debug, Clone, Serialize, Deserialize)]
pub struct ContextItem {
    /// Identifier used when referencing the context in prompts.
    pub id: String,
    /// Raw textual content exposed to the agent.
    pub content: String,
}

/// Aggregated results returned by the autonomous agent runner.
#[derive(Debug, Clone, Serialize, Deserialize)]
pub struct TaskResults {
    /// Identifiers of any contexts created during execution.
    #[serde(default)]
    pub created_contexts: Vec<String>,
    /// File paths modified during the task.
    #[serde(default)]
    pub modified_files: Vec<String>,
    /// Terminal commands executed while solving the task.
    #[serde(default)]
    pub executed_commands: Vec<String>,
    /// Natural-language summary of the run assembled by the agent.
    pub summary: String,
    /// Collected warnings emitted while processing the task.
    #[serde(default)]
    pub warnings: Vec<String>,
}