vortex_scalar/decimal/

value.rs

// SPDX-License-Identifier: Apache-2.0
// SPDX-FileCopyrightText: Copyright the Vortex contributors

//! Additional trait implementations for decimal types to ensure consistency.

use std::cmp::Ordering;
use std::fmt;
use std::hash::Hash;

use num_traits::CheckedAdd;
use num_traits::CheckedDiv;
use num_traits::CheckedMul;
use num_traits::CheckedSub;
use vortex_dtype::DType;
use vortex_dtype::DecimalDType;
use vortex_dtype::NativeDecimalType;
use vortex_dtype::Nullability;
use vortex_dtype::ToI256;
use vortex_dtype::i256;
use vortex_dtype::match_each_decimal_value;
use vortex_error::VortexError;
use vortex_error::VortexExpect;
use vortex_error::vortex_err;

use crate::DecimalScalar;
use crate::InnerScalarValue;
use crate::Scalar;
use crate::ScalarValue;

impl Scalar {
    /// Creates a new decimal scalar with the given value, precision, scale, and nullability.
    pub fn decimal(
        value: DecimalValue,
        decimal_type: DecimalDType,
        nullability: Nullability,
    ) -> Self {
        Self::new(
            DType::Decimal(decimal_type, nullability),
            ScalarValue(InnerScalarValue::Decimal(value)),
        )
    }
}

/// A decimal value that can be stored in various integer widths.
///
/// This enum represents decimal values with different storage sizes,
/// from 8-bit to 256-bit integers.
#[derive(Debug, Clone, Copy)]
pub enum DecimalValue {
    /// 8-bit signed decimal value.
    I8(i8),
    /// 16-bit signed decimal value.
    I16(i16),
    /// 32-bit signed decimal value.
    I32(i32),
    /// 64-bit signed decimal value.
    I64(i64),
    /// 128-bit signed decimal value.
    I128(i128),
    /// 256-bit signed decimal value.
    I256(i256),
}

impl DecimalValue {
    /// Cast `self` to T using the respective `ToPrimitive` method.
    /// If the value cannot be represented by `T`, `None` is returned.
    pub fn cast<T: NativeDecimalType>(&self) -> Option<T> {
        match_each_decimal_value!(self, |value| { T::from(*value) })
    }

    /// Check if this decimal value fits within the precision constraints of the given decimal type.
    ///
    /// The precision defines the total number of significant digits that can be represented.
    /// The stored value (regardless of scale) must fit within the range defined by precision.
    /// For precision P, the maximum absolute stored value is 10^P - 1.
    ///
    /// Returns `None` if the value is too large for the precision, `Some(true)` if it fits.
    pub fn fits_in_precision(&self, decimal_type: DecimalDType) -> Option<bool> {
        // Convert to i256 for comparison
        let value_i256 = match_each_decimal_value!(self, |v| {
            v.to_i256()
                .vortex_expect("upcast to i256 must always succeed")
        });

        // Calculate the maximum stored value that can be represented with this precision
        // For precision P, the max stored value is 10^P - 1
        // This is independent of scale - scale only affects how we interpret the value
        let ten = i256::from_i128(10);
        let max_value = ten
            .checked_pow(decimal_type.precision() as _)
            .vortex_expect("precision must exist in i256");
        let min_value = -max_value;

        Some(value_i256 > min_value && value_i256 < max_value)
    }

    /// Helper function to perform a checked binary operation on two decimal values.
    ///
    /// Both values are upcast to i256 before the operation, and the result is returned as I256.
    fn checked_binary_op<F>(&self, other: &Self, op: F) -> Option<Self>
    where
        F: FnOnce(i256, i256) -> Option<i256>,
    {
        let self_upcast = match_each_decimal_value!(self, |v| {
            v.to_i256()
                .vortex_expect("upcast to i256 must always succeed")
        });
        let other_upcast = match_each_decimal_value!(other, |v| {
            v.to_i256()
                .vortex_expect("upcast to i256 must always succeed")
        });

        op(self_upcast, other_upcast).map(DecimalValue::I256)
    }

    /// Checked addition. Returns `None` on overflow.
    pub fn checked_add(&self, other: &Self) -> Option<Self> {
        self.checked_binary_op(other, |a, b| a.checked_add(&b))
    }

    /// Checked subtraction. Returns `None` on overflow.
    pub fn checked_sub(&self, other: &Self) -> Option<Self> {
        self.checked_binary_op(other, |a, b| a.checked_sub(&b))
    }

    /// Checked multiplication. Returns `None` on overflow.
    pub fn checked_mul(&self, other: &Self) -> Option<Self> {
        self.checked_binary_op(other, |a, b| a.checked_mul(&b))
    }

    /// Checked division. Returns `None` on overflow or division by zero.
    pub fn checked_div(&self, other: &Self) -> Option<Self> {
        self.checked_binary_op(other, |a, b| a.checked_div(&b))
    }
}

// Comparisons between DecimalValue types should upcast to i256 and operate in the upcast space.
// Decimal values can take on any signed scalar type, but so long as their values are the same
// they are considered the same.
// DecimalScalar handles ensuring that both values being compared have the same precision/scale.
impl PartialEq for DecimalValue {
    fn eq(&self, other: &Self) -> bool {
        let self_upcast = match_each_decimal_value!(self, |v| {
            v.to_i256()
                .vortex_expect("upcast to i256 must always succeed")
        });
        let other_upcast = match_each_decimal_value!(other, |v| {
            v.to_i256()
                .vortex_expect("upcast to i256 must always succeed")
        });

        self_upcast == other_upcast
    }
}

impl Eq for DecimalValue {}

impl PartialOrd for DecimalValue {
    fn partial_cmp(&self, other: &Self) -> Option<Ordering> {
        let self_upcast = match_each_decimal_value!(self, |v| {
            v.to_i256()
                .vortex_expect("upcast to i256 must always succeed")
        });
        let other_upcast = match_each_decimal_value!(other, |v| {
            v.to_i256()
                .vortex_expect("upcast to i256 must always succeed")
        });

        self_upcast.partial_cmp(&other_upcast)
    }
}

// Hashing works in the upcast space similar to the other comparison and equality operators.
impl Hash for DecimalValue {
    fn hash<H: std::hash::Hasher>(&self, state: &mut H) {
        let self_upcast = match_each_decimal_value!(self, |v| {
            v.to_i256()
                .vortex_expect("upcast to i256 must always succeed")
        });
        self_upcast.hash(state);
    }
}

use super::macros::decimal_scalar_pack;
use super::macros::decimal_scalar_unpack;

decimal_scalar_unpack!(i8, I8);
decimal_scalar_unpack!(i16, I16);
decimal_scalar_unpack!(i32, I32);
decimal_scalar_unpack!(i64, I64);
decimal_scalar_unpack!(i128, I128);
decimal_scalar_unpack!(i256, I256);

decimal_scalar_pack!(i8, i8, I8);
decimal_scalar_pack!(i16, i16, I16);
decimal_scalar_pack!(i32, i32, I32);
decimal_scalar_pack!(i64, i64, I64);
decimal_scalar_pack!(i128, i128, I128);
decimal_scalar_pack!(i256, i256, I256);

decimal_scalar_pack!(u8, i16, I16);
decimal_scalar_pack!(u16, i32, I32);
decimal_scalar_pack!(u32, i64, I64);
decimal_scalar_pack!(u64, i128, I128);

impl From<DecimalValue> for ScalarValue {
    fn from(value: DecimalValue) -> Self {
        Self(InnerScalarValue::Decimal(value))
    }
}

// Add From<DecimalValue> for Scalar to match other types
impl From<DecimalValue> for Scalar {
    fn from(value: DecimalValue) -> Self {
        // Default to a reasonable precision and scale
        // This matches how primitive types work - they get a default nullability
        let dtype = match &value {
            DecimalValue::I8(_) => DecimalDType::new(3, 0),
            DecimalValue::I16(_) => DecimalDType::new(5, 0),
            DecimalValue::I32(_) => DecimalDType::new(10, 0),
            DecimalValue::I64(_) => DecimalDType::new(19, 0),
            DecimalValue::I128(_) => DecimalDType::new(38, 0),
            DecimalValue::I256(_) => DecimalDType::new(76, 0),
        };
        Scalar::decimal(value, dtype, Nullability::NonNullable)
    }
}

// Add TryFrom<&Scalar> for DecimalValue
impl TryFrom<&Scalar> for DecimalValue {
    type Error = VortexError;

    fn try_from(scalar: &Scalar) -> Result<Self, Self::Error> {
        let decimal_scalar = DecimalScalar::try_from(scalar)?;
        decimal_scalar
            .decimal_value()
            .as_ref()
            .cloned()
            .ok_or_else(|| vortex_err!("Cannot extract DecimalValue from null decimal"))
    }
}

// Add TryFrom<Scalar> for DecimalValue (delegates to &Scalar)
impl TryFrom<Scalar> for DecimalValue {
    type Error = VortexError;

    fn try_from(scalar: Scalar) -> Result<Self, Self::Error> {
        DecimalValue::try_from(&scalar)
    }
}

// Add TryFrom<&Scalar> for Option<DecimalValue>
impl TryFrom<&Scalar> for Option<DecimalValue> {
    type Error = VortexError;

    fn try_from(scalar: &Scalar) -> Result<Self, Self::Error> {
        let decimal_scalar = DecimalScalar::try_from(scalar)?;
        Ok(decimal_scalar.decimal_value())
    }
}

// Add TryFrom<Scalar> for Option<DecimalValue> (delegates to &Scalar)
impl TryFrom<Scalar> for Option<DecimalValue> {
    type Error = VortexError;

    fn try_from(scalar: Scalar) -> Result<Self, Self::Error> {
        Option::<DecimalValue>::try_from(&scalar)
    }
}

impl fmt::Display for DecimalValue {
    fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
        match self {
            DecimalValue::I8(v8) => write!(f, "decimal8({v8})"),
            DecimalValue::I16(v16) => write!(f, "decimal16({v16})"),
            DecimalValue::I32(v32) => write!(f, "decimal32({v32})"),
            DecimalValue::I64(v32) => write!(f, "decimal64({v32})"),
            DecimalValue::I128(v128) => write!(f, "decimal128({v128})"),
            DecimalValue::I256(v256) => write!(f, "decimal256({v256})"),
        }
    }
}

#[cfg(test)]
mod tests {
    use rstest::rstest;
    use vortex_dtype::DType;
    use vortex_utils::aliases::hash_set::HashSet;

    use super::*;

    #[test]
    fn test_decimal_value_from_scalar() {
        let value = DecimalValue::I32(12345);
        let scalar = Scalar::from(value);

        // Test extraction
        let extracted: DecimalValue = DecimalValue::try_from(&scalar).unwrap();
        assert_eq!(extracted, value);

        // Test owned extraction
        let extracted_owned: DecimalValue = DecimalValue::try_from(scalar).unwrap();
        assert_eq!(extracted_owned, value);
    }

    #[test]
    fn test_decimal_value_option_from_scalar() {
        // Non-null case
        let value = DecimalValue::I64(999999);
        let scalar = Scalar::from(value);

        let extracted: Option<DecimalValue> = Option::try_from(&scalar).unwrap();
        assert_eq!(extracted, Some(value));

        // Null case
        let null_scalar = Scalar::null(DType::Decimal(
            DecimalDType::new(10, 2),
            Nullability::Nullable,
        ));

        let extracted_null: Option<DecimalValue> = Option::try_from(&null_scalar).unwrap();
        assert_eq!(extracted_null, None);
    }

    #[test]
    fn test_decimal_value_from_conversion() {
        // Test that From<DecimalValue> creates reasonable defaults
        let values = vec![
            DecimalValue::I8(127),
            DecimalValue::I16(32767),
            DecimalValue::I32(1000000),
            DecimalValue::I64(1000000000000),
            DecimalValue::I128(123456789012345678901234567890),
            DecimalValue::I256(i256::from_i128(987654321)),
        ];

        for value in values {
            let scalar = Scalar::from(value);
            assert!(!scalar.is_null());

            // Verify we can extract it back
            let extracted: DecimalValue = DecimalValue::try_from(&scalar).unwrap();
            assert_eq!(extracted, value);
        }
    }

    #[rstest]
    #[case(DecimalValue::I8(100), DecimalValue::I8(100))]
    #[case(DecimalValue::I16(0), DecimalValue::I256(i256::ZERO))]
    #[case(DecimalValue::I8(100), DecimalValue::I128(100))]
    fn test_decimal_value_eq(#[case] left: DecimalValue, #[case] right: DecimalValue) {
        assert_eq!(left, right);
    }

    #[rstest]
    #[case(DecimalValue::I128(10), DecimalValue::I8(11))]
    #[case(DecimalValue::I256(i256::ZERO), DecimalValue::I16(10))]
    #[case(DecimalValue::I128(-1_000), DecimalValue::I8(1))]
    fn test_decimal_value_cmp(#[case] lower: DecimalValue, #[case] upper: DecimalValue) {
        assert!(lower < upper, "expected {lower} < {upper}");
    }

    #[test]
    fn test_hash() {
        let mut set = HashSet::new();
        set.insert(DecimalValue::I8(100));
        set.insert(DecimalValue::I16(100));
        set.insert(DecimalValue::I32(100));
        set.insert(DecimalValue::I64(100));
        set.insert(DecimalValue::I128(100));
        set.insert(DecimalValue::I256(i256::from_i128(100)));
        assert_eq!(set.len(), 1);
    }

    #[test]
    fn test_decimal_value_checked_add() {
        let a = DecimalValue::I64(100);
        let b = DecimalValue::I64(200);
        let result = a.checked_add(&b).unwrap();
        assert_eq!(result, DecimalValue::I256(i256::from_i128(300)));
    }

    #[test]
    fn test_decimal_value_checked_sub() {
        let a = DecimalValue::I64(500);
        let b = DecimalValue::I64(200);
        let result = a.checked_sub(&b).unwrap();
        assert_eq!(result, DecimalValue::I256(i256::from_i128(300)));
    }

    #[test]
    fn test_decimal_value_checked_mul() {
        let a = DecimalValue::I32(50);
        let b = DecimalValue::I32(10);
        let result = a.checked_mul(&b).unwrap();
        assert_eq!(result, DecimalValue::I256(i256::from_i128(500)));
    }

    #[test]
    fn test_decimal_value_checked_div() {
        let a = DecimalValue::I64(1000);
        let b = DecimalValue::I64(10);
        let result = a.checked_div(&b).unwrap();
        assert_eq!(result, DecimalValue::I256(i256::from_i128(100)));
    }

    #[test]
    fn test_decimal_value_checked_div_by_zero() {
        let a = DecimalValue::I64(1000);
        let b = DecimalValue::I64(0);
        let result = a.checked_div(&b);
        assert_eq!(result, None);
    }

    #[test]
    fn test_decimal_value_mixed_types() {
        // Test operations with different underlying types
        let a = DecimalValue::I8(10);
        let b = DecimalValue::I128(20);
        let result = a.checked_add(&b).unwrap();
        assert_eq!(result, DecimalValue::I256(i256::from_i128(30)));
    }

    #[test]
    fn test_fits_in_precision_exact_boundary() {
        use vortex_dtype::DecimalDType;

        // Precision 3 means max value is 10^3 - 1 = 999
        let dtype = DecimalDType::new(3, 0);

        // Test exact upper boundary: 999 should fit
        let value = DecimalValue::I16(999);
        assert_eq!(value.fits_in_precision(dtype), Some(true));

        // Test just beyond upper boundary: 1000 should NOT fit
        let value = DecimalValue::I16(1000);
        assert_eq!(value.fits_in_precision(dtype), Some(false));

        // Test exact lower boundary: -999 should fit
        let value = DecimalValue::I16(-999);
        assert_eq!(value.fits_in_precision(dtype), Some(true));

        // Test just beyond lower boundary: -1000 should NOT fit
        let value = DecimalValue::I16(-1000);
        assert_eq!(value.fits_in_precision(dtype), Some(false));
    }

    #[test]
    fn test_fits_in_precision_zero() {
        use vortex_dtype::DecimalDType;

        let dtype = DecimalDType::new(5, 2);

        // Zero should always fit
        let value = DecimalValue::I8(0);
        assert_eq!(value.fits_in_precision(dtype), Some(true));
    }

    #[test]
    fn test_fits_in_precision_small_precision() {
        use vortex_dtype::DecimalDType;

        // Precision 1 means max value is 10^1 - 1 = 9
        let dtype = DecimalDType::new(1, 0);

        // Test values within range
        for i in -9..=9 {
            let value = DecimalValue::I8(i);
            assert_eq!(
                value.fits_in_precision(dtype),
                Some(true),
                "value {} should fit in precision 1",
                i
            );
        }

        // Test values outside range
        let value = DecimalValue::I8(10);
        assert_eq!(value.fits_in_precision(dtype), Some(false));
        let value = DecimalValue::I8(-10);
        assert_eq!(value.fits_in_precision(dtype), Some(false));
    }

    #[test]
    fn test_fits_in_precision_large_precision() {
        use vortex_dtype::DecimalDType;

        // Precision 38 means max value is 10^38 - 1
        let dtype = DecimalDType::new(38, 0);

        // Test i128::MAX which is approximately 1.7e38
        // This should NOT fit because 10^38 - 1 < i128::MAX
        let value = DecimalValue::I128(i128::MAX);
        assert_eq!(value.fits_in_precision(dtype), Some(false));

        // Test a large value that should fit: 10^37
        let value = DecimalValue::I128(10_i128.pow(37));
        assert_eq!(value.fits_in_precision(dtype), Some(true));

        // Test 10^38 - 1 (the exact maximum)
        let max_val = i256::from_i128(10).wrapping_pow(38) - i256::from_i128(1);
        let value = DecimalValue::I256(max_val);
        assert_eq!(value.fits_in_precision(dtype), Some(true));

        // Test 10^38 (just over the maximum)
        let over_max = i256::from_i128(10).wrapping_pow(38);
        let value = DecimalValue::I256(over_max);
        assert_eq!(value.fits_in_precision(dtype), Some(false));
    }

    #[test]
    fn test_fits_in_precision_max_precision() {
        use vortex_dtype::DecimalDType;

        // Maximum precision is 76
        let dtype = DecimalDType::new(76, 0);

        // Test that reasonable i256 values fit
        let value = DecimalValue::I256(i256::from_i128(i128::MAX));
        assert_eq!(value.fits_in_precision(dtype), Some(true));

        // Test negative
        let value = DecimalValue::I256(i256::from_i128(i128::MIN));
        assert_eq!(value.fits_in_precision(dtype), Some(true));
    }

    #[test]
    fn test_fits_in_precision_different_scales() {
        use vortex_dtype::DecimalDType;

        // Scale doesn't affect the precision check - it's only about the stored value
        let value = DecimalValue::I32(12345);

        // Precision 5 with different scales
        assert_eq!(value.fits_in_precision(DecimalDType::new(5, 0)), Some(true));
        assert_eq!(value.fits_in_precision(DecimalDType::new(5, 2)), Some(true));
        assert_eq!(
            value.fits_in_precision(DecimalDType::new(5, -2)),
            Some(true)
        );

        // Precision 4 should fail (max value 9999, we have 12345)
        assert_eq!(
            value.fits_in_precision(DecimalDType::new(4, 0)),
            Some(false)
        );
        assert_eq!(
            value.fits_in_precision(DecimalDType::new(4, 2)),
            Some(false)
        );
    }

    #[test]
    fn test_fits_in_precision_negative_values() {
        use vortex_dtype::DecimalDType;

        let dtype = DecimalDType::new(4, 2);

        // Test negative values at boundaries
        // Precision 4 means max magnitude is 9999
        let value = DecimalValue::I16(-9999);
        assert_eq!(value.fits_in_precision(dtype), Some(true));

        let value = DecimalValue::I16(-10000);
        assert_eq!(value.fits_in_precision(dtype), Some(false));

        let value = DecimalValue::I16(-1);
        assert_eq!(value.fits_in_precision(dtype), Some(true));
    }

    #[test]
    fn test_fits_in_precision_mixed_decimal_value_types() {
        use vortex_dtype::DecimalDType;

        let dtype = DecimalDType::new(5, 0);

        // Test that different DecimalValue types work correctly
        assert_eq!(DecimalValue::I8(99).fits_in_precision(dtype), Some(true));
        assert_eq!(DecimalValue::I16(9999).fits_in_precision(dtype), Some(true));
        assert_eq!(
            DecimalValue::I32(99999).fits_in_precision(dtype),
            Some(true)
        );
        assert_eq!(
            DecimalValue::I64(100000).fits_in_precision(dtype),
            Some(false)
        );
        assert_eq!(
            DecimalValue::I128(99999).fits_in_precision(dtype),
            Some(true)
        );
        assert_eq!(
            DecimalValue::I256(i256::from_i128(100000)).fits_in_precision(dtype),
            Some(false)
        );
    }
}