vortex_array/arrays/decimal/compute/
fill_null.rs

1// SPDX-License-Identifier: Apache-2.0
2// SPDX-FileCopyrightText: Copyright the Vortex contributors
3
4use std::cmp::max;
5use std::ops::Not;
6
7use vortex_buffer::BitBuffer;
8use vortex_error::VortexExpect;
9use vortex_error::VortexResult;
10
11use super::cast::upcast_decimal_values;
12use crate::ArrayRef;
13use crate::ExecutionCtx;
14use crate::IntoArray;
15use crate::array::ArrayView;
16use crate::arrays::BoolArray;
17use crate::arrays::Decimal;
18use crate::arrays::DecimalArray;
19use crate::dtype::NativeDecimalType;
20use crate::match_each_decimal_value_type;
21use crate::scalar::DecimalValue;
22use crate::scalar::Scalar;
23use crate::scalar_fn::fns::fill_null::FillNullKernel;
24use crate::validity::Validity;
25
26impl FillNullKernel for Decimal {
27    fn fill_null(
28        array: ArrayView<'_, Decimal>,
29        fill_value: &Scalar,
30        ctx: &mut ExecutionCtx,
31    ) -> VortexResult<Option<ArrayRef>> {
32        let result_validity = Validity::from(fill_value.dtype().nullability());
33
34        Ok(Some(match array.validity()? {
35            Validity::Array(is_valid) => {
36                let is_invalid = is_valid.execute::<BoolArray>(ctx)?.into_bit_buffer().not();
37                let decimal_scalar = fill_value.as_decimal();
38                let decimal_value = decimal_scalar
39                    .decimal_value()
40                    .vortex_expect("fill_null requires a non-null fill value");
41                match_each_decimal_value_type!(array.values_type(), |T| {
42                    fill_invalid_positions::<T>(
43                        array,
44                        &is_invalid,
45                        &decimal_value,
46                        result_validity,
47                    )?
48                })
49            }
50            _ => unreachable!("checked in entry point"),
51        }))
52    }
53}
54
55fn fill_invalid_positions<T: NativeDecimalType>(
56    array: ArrayView<'_, Decimal>,
57    is_invalid: &BitBuffer,
58    decimal_value: &DecimalValue,
59    result_validity: Validity,
60) -> VortexResult<ArrayRef> {
61    match decimal_value.cast::<T>() {
62        Some(fill_val) => fill_buffer::<T>(array, is_invalid, fill_val, result_validity),
63        None => {
64            let target = max(array.values_type(), decimal_value.decimal_type());
65            let upcasted = upcast_decimal_values(array, target)?;
66            match_each_decimal_value_type!(upcasted.values_type(), |U| {
67                let upcasted = upcasted.as_view();
68                fill_invalid_positions::<U>(upcasted, is_invalid, decimal_value, result_validity)
69            })
70        }
71    }
72}
73
74fn fill_buffer<T: NativeDecimalType>(
75    array: ArrayView<'_, Decimal>,
76    is_invalid: &BitBuffer,
77    fill_val: T,
78    result_validity: Validity,
79) -> VortexResult<ArrayRef> {
80    let mut buffer = array.buffer::<T>().into_mut();
81    for invalid_index in is_invalid.set_indices() {
82        buffer[invalid_index] = fill_val;
83    }
84    Ok(DecimalArray::new(buffer.freeze(), array.decimal_dtype(), result_validity).into_array())
85}
86
87#[cfg(test)]
88mod tests {
89    use vortex_buffer::buffer;
90
91    use crate::IntoArray;
92    use crate::LEGACY_SESSION;
93    use crate::VortexSessionExecute;
94    use crate::arrays::DecimalArray;
95    use crate::assert_arrays_eq;
96    use crate::builtins::ArrayBuiltins;
97    #[expect(deprecated)]
98    use crate::canonical::ToCanonical as _;
99    use crate::dtype::DecimalDType;
100    use crate::dtype::Nullability;
101    use crate::scalar::DecimalValue;
102    use crate::scalar::Scalar;
103    use crate::validity::Validity;
104
105    #[test]
106    fn fill_null_leading_none() {
107        let decimal_dtype = DecimalDType::new(19, 2);
108        let arr = DecimalArray::from_option_iter(
109            [None, Some(800i128), None, Some(1000i128), None],
110            decimal_dtype,
111        );
112        #[expect(deprecated)]
113        let p = arr
114            .into_array()
115            .fill_null(Scalar::decimal(
116                DecimalValue::I128(4200i128),
117                DecimalDType::new(19, 2),
118                Nullability::NonNullable,
119            ))
120            .unwrap()
121            .to_decimal();
122        assert_arrays_eq!(
123            p,
124            DecimalArray::from_iter([4200, 800, 4200, 1000, 4200], decimal_dtype)
125        );
126        assert_eq!(
127            p.buffer::<i128>().as_slice(),
128            vec![4200, 800, 4200, 1000, 4200]
129        );
130        assert!(
131            p.as_ref()
132                .validity()
133                .unwrap()
134                .execute_mask(p.as_ref().len(), &mut LEGACY_SESSION.create_execution_ctx())
135                .unwrap()
136                .all_true()
137        );
138    }
139
140    #[test]
141    fn fill_null_all_none() {
142        let decimal_dtype = DecimalDType::new(19, 2);
143
144        let arr = DecimalArray::from_option_iter(
145            [Option::<i128>::None, None, None, None, None],
146            decimal_dtype,
147        );
148
149        #[expect(deprecated)]
150        let p = arr
151            .into_array()
152            .fill_null(Scalar::decimal(
153                DecimalValue::I128(25500i128),
154                DecimalDType::new(19, 2),
155                Nullability::NonNullable,
156            ))
157            .unwrap()
158            .to_decimal();
159        assert_arrays_eq!(
160            p,
161            DecimalArray::from_iter([25500, 25500, 25500, 25500, 25500], decimal_dtype)
162        );
163    }
164
165    /// fill_null with a value that overflows the array's storage type should upcast the array.
166    #[test]
167    fn fill_null_overflow_upcasts() {
168        let decimal_dtype = DecimalDType::new(3, 0);
169        let arr = DecimalArray::from_option_iter([None, Some(10i8), None], decimal_dtype);
170        // i8 max is 127, so 200 doesn't fit — the array should be widened to i16.
171        #[expect(deprecated)]
172        let result = arr
173            .into_array()
174            .fill_null(Scalar::decimal(
175                DecimalValue::I128(200i128),
176                DecimalDType::new(3, 0),
177                Nullability::NonNullable,
178            ))
179            .unwrap()
180            .to_decimal();
181        assert_arrays_eq!(
182            result,
183            DecimalArray::from_iter([200i16, 10, 200], decimal_dtype)
184        );
185    }
186
187    #[test]
188    fn fill_null_non_nullable() {
189        let decimal_dtype = DecimalDType::new(19, 2);
190
191        let arr = DecimalArray::new(
192            buffer![800i128, 1000i128, 1200i128, 1400i128, 1600i128],
193            decimal_dtype,
194            Validity::NonNullable,
195        );
196        #[expect(deprecated)]
197        let p = arr
198            .into_array()
199            .fill_null(Scalar::decimal(
200                DecimalValue::I128(25500i128),
201                DecimalDType::new(19, 2),
202                Nullability::NonNullable,
203            ))
204            .unwrap()
205            .to_decimal();
206        assert_arrays_eq!(
207            p,
208            DecimalArray::from_iter([800i128, 1000, 1200, 1400, 1600], decimal_dtype)
209        );
210    }
211}
vortex_array/arrays/decimal/compute/fill_null.rs

vortex_array/arrays/decimal/compute/
fill_null.rs
