1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
mod path_resolver;

use crate::file::{DirEntry, File, Metadata, OpenOptions};
use crate::physical_fs::path_resolver::{
    PathResolver, SandboxedPathResolver, UnrestrictedPathResolver,
};
use crate::util::invalid_path;
use crate::FileSystem;
use normalize_path::NormalizePath;
use std::fs;
use std::marker::PhantomData;
use std::path::{Path, PathBuf};

/// The physical filesystem, backed by a root on the drive.
pub struct PhysicalFSImpl<R: PathResolver> {
    root: PathBuf,
    _marker: PhantomData<R>,
}

/// The physical filesystem, backed by a root on the drive. This filesystem will not protect against
/// directory traversal and very simply appends the target path to the root.
pub type PhysicalFS = PhysicalFSImpl<UnrestrictedPathResolver>;
/// The physical filesystem, backed by a root on the drive. This filesystem will perform basic
/// protections against directory traversal in the form of returning an error if a user tries to
/// escape the current directory.
pub type SandboxedPhysicalFS = PhysicalFSImpl<SandboxedPathResolver>;

impl<R: PathResolver> PhysicalFSImpl<R> {
    /// Creates a new physical file system at the given root.
    pub fn new<P: AsRef<Path>>(root: P) -> Self {
        Self {
            root: root.as_ref().normalize(),
            _marker: PhantomData,
        }
    }
}

impl<R: PathResolver> FileSystem for PhysicalFSImpl<R> {
    fn create_dir(&self, path: &str) -> crate::Result<()> {
        fs::create_dir(R::resolve_path(&self.root, path)?)
    }

    fn metadata(&self, path: &str) -> crate::Result<Metadata> {
        fs::metadata(R::resolve_path(&self.root, path)?).map(Metadata::from)
    }

    fn open_file_options(&self, path: &str, options: &OpenOptions) -> crate::Result<Box<dyn File>> {
        fs::OpenOptions::from(options)
            .open(R::resolve_path(&self.root, path)?)
            .map::<Box<dyn File>, _>(|file| Box::new(file))
    }

    fn read_dir(
        &self,
        path: &str,
    ) -> crate::Result<Box<dyn Iterator<Item = crate::Result<DirEntry>>>> {
        Ok(Box::new(
            fs::read_dir(R::resolve_path(&self.root, path)?)?.map({
                let root = self.root.clone();
                move |entry| {
                    entry.and_then({
                        |entry| {
                            Ok(DirEntry {
                                // strip the root
                                path: entry
                                    .path()
                                    .strip_prefix(&root)
                                    .map_err(|_| invalid_path())?
                                    .into(),
                                metadata: entry.metadata()?.into(),
                            })
                        }
                    })
                }
            }),
        ))
    }

    fn remove_dir(&self, path: &str) -> crate::Result<()> {
        fs::remove_dir(R::resolve_path(&self.root, path)?)
    }

    fn remove_file(&self, path: &str) -> crate::Result<()> {
        fs::remove_file(R::resolve_path(&self.root, path)?)
    }
}

impl File for fs::File {
    fn metadata(&self) -> crate::Result<Metadata> {
        self.metadata().map(Metadata::from)
    }
}

#[cfg(test)]
mod test {
    use crate::file::FileType;
    use crate::physical_fs::{PhysicalFS, SandboxedPhysicalFS};
    use crate::FileSystem;
    use std::path::Path;

    fn physical_fs<P: AsRef<Path>>(root: P) -> (PhysicalFS, SandboxedPhysicalFS) {
        (
            PhysicalFS::new(root.as_ref()),
            SandboxedPhysicalFS::new(root.as_ref()),
        )
    }

    #[test]
    fn read_dir() {
        let (unrestricted_fs, sandboxed_fs) = physical_fs("test");

        // basic traversal
        let dir = sandboxed_fs.read_dir(".").unwrap();
        assert!(dir.count() > 0);
        let dir = unrestricted_fs.read_dir(".").unwrap();
        assert!(dir.count() > 0);

        // project root traversal
        assert!(sandboxed_fs.read_dir("..").is_err());
        let dir = unrestricted_fs.read_dir("..").unwrap();
        assert!(dir.count() > 0);

        // fancy project root traversal
        assert!(sandboxed_fs.read_dir("test/something/../../..").is_err());
        let dir = unrestricted_fs.read_dir("test/something/../../..").unwrap();
        assert!(dir.count() > 0);
    }

    #[test]
    fn metadata() {
        let (unrestricted_fs, sandboxed_fs) = physical_fs("test/folder_a");

        // basic traversal
        let md = sandboxed_fs.metadata(".").unwrap();
        assert_eq!(md.file_type, FileType::Directory);
        assert_eq!(md.len, 0);
        let md = unrestricted_fs.metadata(".").unwrap();
        assert_eq!(md.file_type, FileType::Directory);
        assert_eq!(md.len, 0);
        let md = sandboxed_fs.metadata("file_a").unwrap();
        assert_eq!(md.file_type, FileType::File);
        assert_eq!(md.len, 6);
        let md = unrestricted_fs.metadata("file_a").unwrap();
        assert_eq!(md.file_type, FileType::File);
        assert_eq!(md.len, 6);

        // project root traversal
        assert!(sandboxed_fs.metadata("../deep_fs.zip").is_err());
        let md = unrestricted_fs.metadata("../deep_fs.zip").unwrap();
        assert_eq!(md.file_type, FileType::File);
        assert_eq!(md.len, 2691);

        // fancy project root traversal
        assert!(sandboxed_fs.metadata("test/../../deep_fs.zip").is_err());
        let md = unrestricted_fs.metadata("test/../../deep_fs.zip").unwrap();
        assert_eq!(md.file_type, FileType::File);
        assert_eq!(md.len, 2691);
    }

    #[test]
    fn open_file() {
        let (unrestricted_fs, sandboxed_fs) = physical_fs("test/folder_a");

        // basic traversal
        let mut file = sandboxed_fs.open_file("file_a").unwrap();
        let md = file.metadata().unwrap();
        assert_eq!(md.file_type, FileType::File);
        assert_eq!(md.len, 6);
        assert_eq!(file.read_into_string().unwrap(), "file a");
        let mut file = unrestricted_fs.open_file("file_a").unwrap();
        let md = file.metadata().unwrap();
        assert_eq!(md.file_type, FileType::File);
        assert_eq!(md.len, 6);
        assert_eq!(file.read_into_string().unwrap(), "file a");

        // project root traversal
        assert!(sandboxed_fs.read_dir("../bad.tar.xz").is_err());
        let mut file = unrestricted_fs.open_file("../bad.tar.xz").unwrap();
        let md = file.metadata().unwrap();
        assert_eq!(md.file_type, FileType::File);
        assert_eq!(md.len, 4);
        assert_eq!(file.read_into_string().unwrap(), "abcd");

        // fancy project root traversal
        assert!(sandboxed_fs.read_dir("test/../../bad.tar.xz").is_err());
        let mut file = unrestricted_fs.open_file("test/../../bad.tar.xz").unwrap();
        let md = file.metadata().unwrap();
        assert_eq!(md.file_type, FileType::File);
        assert_eq!(md.len, 4);
        assert_eq!(file.read_into_string().unwrap(), "abcd");
    }

    #[test]
    fn exists() {
        let (unrestricted_fs, sandboxed_fs) = physical_fs("test");

        assert!(unrestricted_fs.exists("").unwrap());
        assert!(sandboxed_fs.exists("").unwrap());
        assert!(unrestricted_fs.exists(".").unwrap());
        assert!(sandboxed_fs.exists(".").unwrap());
        assert!(unrestricted_fs.exists("///").unwrap());
        assert!(sandboxed_fs.exists("///").unwrap());
        assert!(unrestricted_fs.exists("\\\\").unwrap());
        assert!(sandboxed_fs.exists("\\\\").unwrap());
        assert!(unrestricted_fs.exists("folder_a").unwrap());
        assert!(sandboxed_fs.exists("folder_a").unwrap());
        assert!(!unrestricted_fs.exists("folder_c").unwrap());
        assert!(!sandboxed_fs.exists("folder_c").unwrap());
        assert!(unrestricted_fs.exists("bad.tar.xz").unwrap());
        assert!(sandboxed_fs.exists("bad.tar.xz").unwrap());
        assert!(unrestricted_fs.exists("../Cargo.toml").unwrap());
        assert!(sandboxed_fs.exists("../Cargo.toml").is_err());
        assert!(!unrestricted_fs.exists("../Cargo.toml2").unwrap());
        // TODO: fix this case
        // assert!(sandboxed_fs.exists("../Cargo.toml2").is_err());
        assert!(unrestricted_fs.exists("folder_a/../../Cargo.toml").unwrap());
        assert!(sandboxed_fs.exists("folder_a/../../Cargo.toml").is_err());
    }
}