uqa_sql/binding/

correlation.rs

//
// Unified Query Algebra
//
// Copyright (c) 2023-2026 Cognica, Inc.
//

//! Physical-plan correlation analysis for scalar subquery initialization.

use std::collections::{BTreeMap, BTreeSet};

use crate::plan::{ComputePlan, ProjectionPlan, QueryPlan, RelationalPlan, SourcePlan};
use crate::SQLError;
use crate::{ScalarExpr, ScalarFrameBound};

use crate::catalog::{analysis::AnalysisCatalog, resolution::RelationNameResolution};
use crate::semantics::projection_columns;

/// A single immutable namespace and catalog view used throughout correlation analysis.
#[derive(Clone, Copy)]
pub struct CorrelationContext<'a> {
    pub catalog: &'a dyn AnalysisCatalog,
    pub resolution: &'a RelationNameResolution,
}

#[derive(Clone, Default)]
struct RelationColumns {
    names: BTreeSet<String>,
    ordered: Vec<String>,
    complete: bool,
}

impl RelationColumns {
    fn known(ordered: Vec<String>) -> Self {
        Self {
            names: ordered.iter().cloned().collect(),
            ordered,
            complete: true,
        }
    }

    fn empty_known() -> Self {
        Self::known(Vec::new())
    }

    fn apply_positional_aliases(&mut self, aliases: &[String]) {
        for (column, alias) in self.ordered.iter_mut().zip(aliases) {
            column.clone_from(alias);
        }
        self.names = self.ordered.iter().cloned().collect();
    }
}

#[derive(Clone, Default)]
struct QueryScope {
    qualifiers: BTreeSet<String>,
    internal_relations: BTreeSet<crate::ast::InternalRelationId>,
    columns: RelationColumns,
}

pub struct DecorrelatedExistsPlan {
    pub inner: QueryPlan,
    pub outer_keys: Vec<ScalarExpr>,
}

/// Turn a simple correlated equality EXISTS into an uncorrelated key query.
///
/// The caller materializes the returned inner key rows once and probes them
/// with `outer_keys`, which is the physical equivalent of a hash semi-join.
pub fn decorrelate_exists(
    context: CorrelationContext<'_>,
    plan: &QueryPlan,
) -> Result<Option<DecorrelatedExistsPlan>, SQLError> {
    if !plan.ctes.is_empty() {
        return Ok(None);
    }
    let RelationalPlan::QueryBlock(block) = &plan.root else {
        return Ok(None);
    };
    let Some(source) = block.from.as_ref() else {
        return Ok(None);
    };
    if !matches!(block.compute, ComputePlan::Project)
        || !block.group_by.is_empty()
        || !block.grouping_sets.is_empty()
        || block.having.is_some()
        || block.limit.is_some()
        || block.offset.is_some()
        || block.distinct
        || !block.distinct_on.is_empty()
        || !block.subqueries.is_empty()
    {
        return Ok(None);
    }

    let scope = source_scope(context, source, &BTreeMap::new())?;
    let mut source_scopes = vec![scope.clone()];
    if source_has_external_reference(context, source, &mut source_scopes)? {
        return Ok(None);
    }
    let Some(predicate) = block.r#where.as_ref() else {
        return Ok(None);
    };
    let conjuncts = match predicate {
        ScalarExpr::And(items) => items.as_slice(),
        expression => std::slice::from_ref(expression),
    };
    let mut inner_keys = Vec::new();
    let mut outer_keys = Vec::new();
    let mut residual = Vec::new();
    for conjunct in conjuncts {
        if let ScalarExpr::Binary {
            op: crate::ast::BinaryOp::Equal,
            lhs,
            rhs,
        } = conjunct
        {
            let lhs_scope = correlation_column_scope(lhs, &scope);
            let rhs_scope = correlation_column_scope(rhs, &scope);
            match (lhs_scope, rhs_scope) {
                (Some(ColumnScope::Inner), Some(ColumnScope::Outer)) => {
                    inner_keys.push((**lhs).clone());
                    outer_keys.push((**rhs).clone());
                    continue;
                }
                (Some(ColumnScope::Outer), Some(ColumnScope::Inner)) => {
                    inner_keys.push((**rhs).clone());
                    outer_keys.push((**lhs).clone());
                    continue;
                }
                _ => {}
            }
        }
        if expression_has_external_reference(conjunct, std::slice::from_ref(&scope)) {
            return Ok(None);
        }
        residual.push(conjunct.clone());
    }
    if inner_keys.is_empty() {
        return Ok(None);
    }

    let mut inner = plan.clone();
    let RelationalPlan::QueryBlock(inner_block) = &mut inner.root else {
        unreachable!("query-block shape checked above");
    };
    inner_block.projections = inner_keys
        .into_iter()
        .map(|expr| ProjectionPlan { expr, alias: None })
        .collect();
    inner_block.r#where = match residual.len() {
        0 => None,
        1 => residual.pop(),
        _ => Some(ScalarExpr::And(residual)),
    };
    inner_block.order_by.clear();
    Ok(Some(DecorrelatedExistsPlan { inner, outer_keys }))
}

#[derive(Clone, Copy, PartialEq, Eq)]
enum ColumnScope {
    Inner,
    Outer,
}

fn correlation_column_scope(expression: &ScalarExpr, scope: &QueryScope) -> Option<ColumnScope> {
    match expression {
        ScalarExpr::Column(column) => {
            if scope
                .columns
                .names
                .iter()
                .any(|local| local.eq_ignore_ascii_case(column))
                || scope
                    .qualifiers
                    .iter()
                    .any(|local| local.eq_ignore_ascii_case(column))
            {
                Some(ColumnScope::Inner)
            } else if scope.columns.complete {
                Some(ColumnScope::Outer)
            } else {
                None
            }
        }
        ScalarExpr::QualifiedColumn { qualifier, .. } => {
            if scope
                .qualifiers
                .iter()
                .any(|local| local.eq_ignore_ascii_case(qualifier))
            {
                Some(ColumnScope::Inner)
            } else {
                Some(ColumnScope::Outer)
            }
        }
        ScalarExpr::InternalColumn(column) => {
            if scope.internal_relations.contains(&column.relation()) {
                Some(ColumnScope::Inner)
            } else {
                Some(ColumnScope::Outer)
            }
        }
        ScalarExpr::Cast { expr, .. } | ScalarExpr::Collated { expr, .. } => {
            correlation_column_scope(expr, scope)
        }
        _ => None,
    }
}

pub fn query_depends_on_outer_row(
    context: CorrelationContext<'_>,
    plan: &QueryPlan,
) -> Result<bool, SQLError> {
    query_has_external_reference(context, plan, &mut Vec::new())
}

/// Whether a subquery refers to the caller's own row. Seed enclosing identities so references beyond that row are not mistaken for level-zero variables.
pub(crate) fn query_depends_on_current_row(
    context: CorrelationContext<'_>,
    plan: &QueryPlan,
    input: &crate::RowSchema,
) -> Result<bool, SQLError> {
    let mut enclosing = QueryScope {
        columns: RelationColumns::empty_known(),
        ..QueryScope::default()
    };
    for (identity, _) in input.typed_physical_alias_identities() {
        if !input.resolves_local_column(identity.qualifier(), identity.column()) {
            if let Some(qualifier) = identity.qualifier() {
                enclosing.qualifiers.insert(qualifier.to_owned());
            } else {
                enclosing.columns.names.insert(identity.column().to_owned());
            }
        }
    }
    for (column, slot) in input.internal_identities() {
        if !input.slot_is_local(slot) {
            enclosing.internal_relations.insert(column.relation());
        }
    }
    query_has_external_reference(context, plan, &mut vec![enclosing])
}

#[expect(
    clippy::too_many_lines,
    reason = "preserves scope and subquery identity"
)]
fn query_has_external_reference(
    context: CorrelationContext<'_>,
    plan: &QueryPlan,
    scopes: &mut Vec<QueryScope>,
) -> Result<bool, SQLError> {
    let mut ctes = BTreeMap::new();
    if plan.ctes.iter().any(|cte| cte.recursive) {
        for cte in &plan.ctes {
            let columns = if cte.columns.is_empty() {
                cte.body
                    .query()
                    .map_or_else(RelationColumns::default, query_output_columns)
            } else {
                RelationColumns::known(cte.columns.clone())
            };
            ctes.insert(cte.name.clone(), columns);
        }
    }
    for cte in &plan.ctes {
        let columns = if cte.columns.is_empty() {
            cte.body
                .query()
                .map_or_else(RelationColumns::default, query_output_columns)
        } else {
            RelationColumns::known(cte.columns.clone())
        };
        if cte.recursive {
            ctes.insert(cte.name.clone(), columns.clone());
        }
        if cte.body.query().map_or(Ok(true), |query| {
            query_has_external_reference(context, query, scopes)
        })? {
            return Ok(true);
        }
        ctes.insert(cte.name.clone(), columns);
    }

    match &plan.root {
        RelationalPlan::QueryBlock(block) => {
            let scope = match block.from.as_ref() {
                Some(source) => source_scope(context, source, &ctes)?,
                None => QueryScope {
                    qualifiers: BTreeSet::new(),
                    internal_relations: BTreeSet::new(),
                    columns: RelationColumns::empty_known(),
                },
            };
            scopes.push(scope);
            let result = (|| {
                for expression in block.expressions() {
                    if expression_has_external_reference(expression, scopes) {
                        return Ok(true);
                    }
                }
                if let Some(source) = block.from.as_ref() {
                    if source_has_external_reference(context, source, scopes)? {
                        return Ok(true);
                    }
                }
                for subquery in &block.subqueries {
                    if query_has_external_reference(context, subquery, scopes)? {
                        return Ok(true);
                    }
                }
                Ok(false)
            })();
            scopes.pop();
            result
        }
        RelationalPlan::SetOp {
            left,
            right,
            order_by,
            limit,
            offset,
            subqueries,
            ..
        } => {
            if query_has_external_reference(context, left, scopes)?
                || query_has_external_reference(context, right, scopes)?
            {
                return Ok(true);
            }
            scopes.push(QueryScope {
                qualifiers: BTreeSet::new(),
                internal_relations: BTreeSet::new(),
                columns: query_output_columns(left),
            });
            let result = (|| {
                for expression in order_by.iter().map(|order| &order.expr) {
                    if expression_has_external_reference(expression, scopes) {
                        return Ok(true);
                    }
                }
                if limit
                    .as_deref()
                    .is_some_and(|expr| expression_has_external_reference(expr, scopes))
                    || offset
                        .as_deref()
                        .is_some_and(|expr| expression_has_external_reference(expr, scopes))
                {
                    return Ok(true);
                }
                for subquery in subqueries {
                    if query_has_external_reference(context, subquery, scopes)? {
                        return Ok(true);
                    }
                }
                Ok(false)
            })();
            scopes.pop();
            result
        }
        RelationalPlan::Values { rows, subqueries } => {
            scopes.push(QueryScope {
                qualifiers: BTreeSet::new(),
                internal_relations: BTreeSet::new(),
                columns: RelationColumns::empty_known(),
            });
            let result = (|| {
                for expression in rows.iter().flatten() {
                    if expression_has_external_reference(expression, scopes) {
                        return Ok(true);
                    }
                }
                for subquery in subqueries {
                    if query_has_external_reference(context, subquery, scopes)? {
                        return Ok(true);
                    }
                }
                Ok(false)
            })();
            scopes.pop();
            result
        }
    }
}

#[expect(
    clippy::too_many_lines,
    reason = "preserves scope and subquery identity"
)]
fn source_scope(
    context: CorrelationContext<'_>,
    source: &SourcePlan,
    ctes: &BTreeMap<String, RelationColumns>,
) -> Result<QueryScope, SQLError> {
    match source {
        SourcePlan::Table {
            bound_columns,
            name,
            qualifier,
            alias,
            column_aliases,
            ..
        } => {
            let mut qualifiers = BTreeSet::new();
            qualifiers.insert(alias.as_ref().unwrap_or(qualifier).clone());
            let mut columns = match bound_columns {
                Some(columns) => RelationColumns::known(columns.clone()),
                None => relation_columns(context, name, ctes)?,
            };
            columns.apply_positional_aliases(column_aliases);
            Ok(QueryScope {
                qualifiers,
                internal_relations: BTreeSet::new(),
                columns,
            })
        }
        SourcePlan::Join {
            left,
            right,
            alias,
            column_aliases,
            ..
        } => {
            let left = source_scope(context, left, ctes)?;
            let right = source_scope(context, right, ctes)?;
            let complete = left.columns.complete && right.columns.complete;
            let mut names = left.columns.names;
            names.extend(right.columns.names);
            let mut ordered = left.columns.ordered;
            ordered.extend(right.columns.ordered);
            let mut internal_relations = left.internal_relations;
            internal_relations.extend(right.internal_relations);
            if let Some(alias) = alias {
                if !column_aliases.is_empty() {
                    names = column_aliases.iter().cloned().collect();
                    ordered.clone_from(column_aliases);
                }
                return Ok(QueryScope {
                    qualifiers: [alias.clone()].into_iter().collect(),
                    internal_relations,
                    columns: RelationColumns {
                        names,
                        ordered,
                        complete: complete && column_aliases.is_empty(),
                    },
                });
            }
            let mut qualifiers = left.qualifiers;
            qualifiers.extend(right.qualifiers);
            Ok(QueryScope {
                qualifiers,
                internal_relations,
                columns: RelationColumns {
                    names,
                    ordered,
                    complete,
                },
            })
        }
        SourcePlan::Values {
            rows,
            alias,
            column_aliases,
            internal_relation,
            ..
        } => {
            if let Some(internal_relation) = internal_relation {
                return Ok(QueryScope {
                    qualifiers: BTreeSet::new(),
                    internal_relations: [*internal_relation].into_iter().collect(),
                    columns: RelationColumns::empty_known(),
                });
            }
            let qualifiers = alias.iter().cloned().collect();
            let columns = if column_aliases.is_empty() {
                (0..rows.first().map_or(0, Vec::len))
                    .map(|index| format!("column{}", index + 1))
                    .collect::<Vec<_>>()
            } else {
                column_aliases.clone()
            };
            Ok(QueryScope {
                qualifiers,
                internal_relations: BTreeSet::new(),
                columns: RelationColumns::known(columns),
            })
        }
        SourcePlan::Function {
            name,
            output_name,
            alias,
            column_aliases,
            ..
        } => {
            let qualifiers = [alias.as_ref().unwrap_or(output_name).clone()]
                .into_iter()
                .collect();
            let mut names: BTreeSet<String> = column_aliases.iter().cloned().collect();
            let complete = !column_aliases.is_empty()
                || matches!(
                    name.to_ascii_lowercase().as_str(),
                    "generate_series" | "unnest" | "regexp_split_to_table" | "string_to_table"
                );
            if names.is_empty() && complete {
                names.insert(output_name.clone());
            }
            Ok(QueryScope {
                qualifiers,
                internal_relations: BTreeSet::new(),
                columns: RelationColumns {
                    ordered: names.iter().cloned().collect(),
                    names,
                    complete,
                },
            })
        }
        SourcePlan::FunctionGroup {
            functions,
            alias,
            column_aliases,
            ordinality,
        } => {
            let qualifier = alias.clone().or_else(|| {
                functions
                    .first()
                    .map(|function| function.output_name.clone())
            });
            let qualifiers = qualifier.into_iter().collect();
            let mut names = Vec::new();
            let mut complete = true;
            for function in functions {
                if function.column_aliases.is_empty() {
                    let local = crate::semantics::builtin_function_dispatch_name(&function.name);
                    if matches!(
                        local.as_str(),
                        "generate_series" | "unnest" | "regexp_split_to_table" | "string_to_table"
                    ) {
                        names.push(function.output_name.clone());
                    } else {
                        complete = false;
                    }
                } else {
                    names.extend(function.column_aliases.iter().cloned());
                }
            }
            if *ordinality {
                names.push("ordinality".into());
            }
            for (name, alias) in names.iter_mut().zip(column_aliases) {
                name.clone_from(alias);
            }
            let column_names = names.iter().cloned().collect();
            Ok(QueryScope {
                qualifiers,
                internal_relations: BTreeSet::new(),
                columns: RelationColumns {
                    names: column_names,
                    ordered: names,
                    complete,
                },
            })
        }
        SourcePlan::Subquery {
            body,
            alias,
            column_aliases,
        } => {
            let qualifiers = alias.iter().cloned().collect();
            let columns = if column_aliases.is_empty() {
                query_output_columns(body)
            } else {
                RelationColumns {
                    names: column_aliases.iter().cloned().collect(),
                    ordered: column_aliases.clone(),
                    complete: true,
                }
            };
            Ok(QueryScope {
                qualifiers,
                internal_relations: BTreeSet::new(),
                columns,
            })
        }
    }
}

fn relation_columns(
    context: CorrelationContext<'_>,
    name: &str,
    ctes: &BTreeMap<String, RelationColumns>,
) -> Result<RelationColumns, SQLError> {
    if let Some(columns) = ctes
        .iter()
        .find(|(cte, _)| cte.eq_ignore_ascii_case(name))
        .map(|(_, columns)| columns)
    {
        return Ok(columns.clone());
    }
    let catalog = context.catalog;
    let resolution = context.resolution;
    if let Some(columns) = catalog.virtual_relation_schema(resolution, name)? {
        return Ok(RelationColumns::known(
            columns.into_iter().map(|(name, _)| name).collect(),
        ));
    }
    if let Ok(Some(table)) = catalog.table_resolved(resolution, name) {
        return Ok(RelationColumns::known(
            table
                .columns
                .iter()
                .map(|column| column.name.clone())
                .collect(),
        ));
    }
    if let Some(view) = catalog.view_resolved(resolution, name)? {
        return Ok(if view.materialized {
            RelationColumns::known(view.output_columns.unwrap_or_default())
        } else {
            query_output_columns(&view.query)
        });
    }
    if let Ok(Some(table)) = catalog.foreign_table_resolved(resolution, name) {
        return Ok(RelationColumns::known(
            table
                .columns
                .iter()
                .map(|column| column.name.clone())
                .collect(),
        ));
    }
    Ok(RelationColumns::default())
}

fn source_has_external_reference(
    context: CorrelationContext<'_>,
    source: &SourcePlan,
    scopes: &mut Vec<QueryScope>,
) -> Result<bool, SQLError> {
    match source {
        SourcePlan::Join {
            left, right, on, ..
        } => Ok(source_has_external_reference(context, left, scopes)?
            || source_has_external_reference(context, right, scopes)?
            || on
                .as_ref()
                .is_some_and(|expr| expression_has_external_reference(expr, scopes))),
        SourcePlan::Values { rows, .. } => Ok(rows
            .iter()
            .flatten()
            .any(|expr| expression_has_external_reference(expr, scopes))),
        SourcePlan::Function { args, .. } => Ok(args
            .iter()
            .any(|expr| expression_has_external_reference(expr, scopes))),
        SourcePlan::FunctionGroup { functions, .. } => Ok(functions.iter().any(|function| {
            function
                .args
                .iter()
                .any(|expr| expression_has_external_reference(expr, scopes))
        })),
        SourcePlan::Subquery { body, .. } => query_has_external_reference(context, body, scopes),
        SourcePlan::Table { .. } => Ok(false),
    }
}

fn query_output_columns(plan: &QueryPlan) -> RelationColumns {
    match &plan.root {
        RelationalPlan::QueryBlock(block) => {
            let ordered = projection_columns(&block.projections);
            RelationColumns {
                names: ordered.iter().cloned().collect(),
                ordered,
                complete: !block
                    .projections
                    .iter()
                    .any(|projection| matches!(projection.expr, ScalarExpr::Star)),
            }
        }
        RelationalPlan::SetOp { left, .. } => query_output_columns(left),
        RelationalPlan::Values { rows, .. } => RelationColumns::known(
            (0..rows.first().map_or(0, Vec::len))
                .map(|index| format!("column{}", index + 1))
                .collect(),
        ),
    }
}

fn expression_has_external_reference(expr: &ScalarExpr, scopes: &[QueryScope]) -> bool {
    match expr {
        ScalarExpr::Column(column) => !resolves_unqualified(column, scopes),
        ScalarExpr::QualifiedColumn { qualifier, .. } => !scopes.iter().rev().any(|scope| {
            scope
                .qualifiers
                .iter()
                .any(|local| local.eq_ignore_ascii_case(qualifier))
        }),
        ScalarExpr::QualifiedStar(qualifier) => !scopes.iter().rev().any(|scope| {
            scope
                .qualifiers
                .iter()
                .any(|local| local.eq_ignore_ascii_case(qualifier))
        }),
        ScalarExpr::InternalColumn(column) => !scopes
            .iter()
            .rev()
            .any(|scope| scope.internal_relations.contains(&column.relation())),
        ScalarExpr::Func {
            binding,
            args,
            order_by,
            filter,
            ..
        } => {
            binding
                .as_ref()
                .and_then(crate::semantics::function_implicit_row_input)
                .is_some_and(|column| {
                    expression_has_external_reference(&ScalarExpr::InternalColumn(column), scopes)
                })
                || args
                    .iter()
                    .any(|expr| expression_has_external_reference(expr, scopes))
                || order_by
                    .iter()
                    .any(|order| expression_has_external_reference(&order.expr, scopes))
                || filter
                    .as_deref()
                    .is_some_and(|expr| expression_has_external_reference(expr, scopes))
        }
        ScalarExpr::Array(items)
        | ScalarExpr::Row(items)
        | ScalarExpr::CompositeRow { items, .. }
        | ScalarExpr::And(items)
        | ScalarExpr::Or(items) => items
            .iter()
            .any(|expr| expression_has_external_reference(expr, scopes)),
        ScalarExpr::Binary { lhs, rhs, .. } => {
            expression_has_external_reference(lhs, scopes)
                || expression_has_external_reference(rhs, scopes)
        }
        ScalarExpr::Not(inner)
        | ScalarExpr::UnaryMinus(inner)
        | ScalarExpr::IsNull { expr: inner, .. }
        | ScalarExpr::Cast { expr: inner, .. }
        | ScalarExpr::Collated { expr: inner, .. } => {
            expression_has_external_reference(inner, scopes)
        }
        ScalarExpr::Between { expr, low, high } => {
            expression_has_external_reference(expr, scopes)
                || expression_has_external_reference(low, scopes)
                || expression_has_external_reference(high, scopes)
        }
        ScalarExpr::InList { expr, list, .. } => {
            expression_has_external_reference(expr, scopes)
                || list
                    .iter()
                    .any(|item| expression_has_external_reference(item, scopes))
        }
        ScalarExpr::WindowCall {
            args, spec, filter, ..
        } => window_has_external_reference(args, filter.as_deref(), spec, scopes),
        ScalarExpr::Case {
            base,
            when,
            else_branch,
        } => {
            base.as_deref()
                .is_some_and(|expr| expression_has_external_reference(expr, scopes))
                || when.iter().any(|(condition, result)| {
                    expression_has_external_reference(condition, scopes)
                        || expression_has_external_reference(result, scopes)
                })
                || else_branch
                    .as_deref()
                    .is_some_and(|expr| expression_has_external_reference(expr, scopes))
        }
        ScalarExpr::InSubquery { expr, .. } => expression_has_external_reference(expr, scopes),
        ScalarExpr::Default
        | ScalarExpr::Star
        | ScalarExpr::Position(_)
        | ScalarExpr::Literal(_)
        | ScalarExpr::TypedLiteral { .. }
        | ScalarExpr::Param(_)
        | ScalarExpr::ScalarSubquery(_)
        | ScalarExpr::Exists { .. } => false,
    }
}

fn resolves_unqualified(column: &str, scopes: &[QueryScope]) -> bool {
    for scope in scopes.iter().rev() {
        if scope
            .columns
            .names
            .iter()
            .any(|local| local.eq_ignore_ascii_case(column))
            || scope
                .qualifiers
                .iter()
                .any(|local| local.eq_ignore_ascii_case(column))
        {
            return true;
        }
        if !scope.columns.complete {
            return false;
        }
    }
    false
}

/// Whether a window call's arguments, `FILTER`, keys or frame offsets refer outside the query scopes.
fn window_has_external_reference(
    args: &[ScalarExpr],
    filter: Option<&ScalarExpr>,
    spec: &crate::ScalarWindowSpec,
    scopes: &[QueryScope],
) -> bool {
    args.iter()
        .chain(filter)
        .chain(&spec.partition_by)
        .chain(spec.order_by.iter().map(|order| &order.expr))
        .any(|expr| expression_has_external_reference(expr, scopes))
        || spec.frame.as_ref().is_some_and(|frame| {
            frame_bound_has_external_reference(&frame.start, scopes)
                || frame_bound_has_external_reference(&frame.end, scopes)
        })
}

fn frame_bound_has_external_reference(bound: &ScalarFrameBound, scopes: &[QueryScope]) -> bool {
    match bound {
        ScalarFrameBound::Preceding(expr) | ScalarFrameBound::Following(expr) => {
            expression_has_external_reference(expr, scopes)
        }
        ScalarFrameBound::UnboundedPreceding
        | ScalarFrameBound::UnboundedFollowing
        | ScalarFrameBound::CurrentRow => false,
    }
}

#[cfg(test)]
mod tests {
    use super::*;

    #[test]
    fn implicit_action_inputs_preserve_their_enclosing_row_identity() {
        let binding = crate::binding::fixture::empty_binding_context();
        let context = CorrelationContext {
            catalog: binding.catalog.as_ref(),
            resolution: &binding.resolution,
        };
        for (sql, expected) in [
            ("SELECT merge_action()", true),
            ("SELECT lower(merge_action())", true),
            ("SELECT (SELECT merge_action())", true),
            ("SELECT public.merge_action()", false),
            ("SELECT \"merge_action\"()", false),
            ("SELECT lower('constant')", false),
        ] {
            let crate::plan::UnifiedPlan::Query(query) =
                crate::plan::UnifiedPlan::lower(crate::compile(sql).unwrap().remove(0))
            else {
                panic!("query")
            };
            assert_eq!(
                query_depends_on_outer_row(context, &query).unwrap(),
                expected,
                "{sql}"
            );
            let mut enclosing = QueryScope::default();
            enclosing
                .internal_relations
                .insert(crate::semantics::merge_action_attribute().relation());
            assert!(
                !query_has_external_reference(context, &query, &mut vec![enclosing]).unwrap(),
                "{sql}"
            );
        }
    }

    #[test]
    fn table_range_aliases_replace_physical_correlation_names() {
        let crate::ast::Statement::CreateTable(definition) =
            crate::compile("CREATE TABLE correlation_alias_source(id INTEGER, label TEXT)")
                .unwrap()
                .remove(0)
        else {
            panic!("expected table definition")
        };
        let catalog = crate::binding::fixture::catalog(BTreeMap::from([(
            crate::RelationIdentity::from_legacy_name("public.correlation_alias_source").unwrap(),
            crate::binding::fixture::table_definition(definition.columns),
        )]));
        let resolution =
            crate::binding::fixture::resolution(vec!["public".into()], "pg_temp_1".into());
        let context = CorrelationContext {
            catalog: catalog.as_ref(),
            resolution: &resolution,
        };
        let source = SourcePlan::Table {
            bound_columns: None,
            name: "correlation_alias_source".into(),
            qualifier: "correlation_alias_source".into(),
            alias: Some("source".into()),
            column_aliases: vec!["key".into(), "value".into()],
            include_descendants: true,
        };
        let scope = source_scope(context, &source, &BTreeMap::new()).unwrap();
        assert_eq!(
            scope.columns.names,
            BTreeSet::from(["key".to_string(), "value".to_string()])
        );
    }
}