1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531
use std::collections::HashMap;
use crate::types::validator_power_and_pledge::ValidatorPowerAndPledge;
use crate::types::ValidatorId;
use borsh::{BorshDeserialize, BorshSerialize};
use rand::{seq::SliceRandom, Rng};
use unc_primitives_core::types::Balance;
/// Represents the configuration of [`ValidatorMandates`]. Its parameters are expected to remain
/// valid for one epoch.
#[derive(
BorshSerialize, BorshDeserialize, Default, Copy, Clone, Debug, PartialEq, Eq, serde::Serialize,
)]
pub struct ValidatorMandatesConfig {
/// The amount of pledge that corresponds to one mandate.
pledge_per_mandate: Balance,
/// The minimum number of mandates required per shard.
min_mandates_per_shard: usize,
/// The number of shards for the referenced epoch.
num_shards: usize,
}
impl ValidatorMandatesConfig {
/// Constructs a new configuration.
///
/// # Panics
///
/// Panics in the following cases:
///
/// - If `pledge_per_mandate` is 0 as this would lead to division by 0.
/// - If `num_shards` is zero.
pub fn new(
pledge_per_mandate: Balance,
min_mandates_per_shard: usize,
num_shards: usize,
) -> Self {
assert!(pledge_per_mandate > 0, "pledge_per_mandate of 0 would lead to division by 0");
assert!(num_shards > 0, "there should be at least one shard");
Self { pledge_per_mandate, min_mandates_per_shard, num_shards }
}
}
/// The mandates for a set of validators given a [`ValidatorMandatesConfig`].
///
/// A mandate is a liability for a validator to validate a shard. Depending on its pledge and the
/// `pledge_per_mandate` specified in `ValidatorMandatesConfig`, a validator may hold multiple
/// mandates. Each mandate may be assigned to a different shard. The assignment of mandates to
/// shards is calculated with [`Self::sample`], typically at every height.
///
/// See #9983 for context and links to resources that introduce mandates.
#[derive(
BorshSerialize, BorshDeserialize, Default, Clone, Debug, PartialEq, Eq, serde::Serialize,
)]
pub struct ValidatorMandates {
/// The configuration applied to the mandates.
config: ValidatorMandatesConfig,
/// Each element represents a validator mandate held by the validator with the given id.
///
/// The id of a validator who holds `n >= 0` mandates occurs `n` times in the vector.
mandates: Vec<ValidatorId>,
/// Each element represents a partial validator mandate held by the validator with the given id.
/// For example, an element `(1, 42)` represents the partial mandate of the validator with id 1
/// which has a weight of 42.
///
/// Validators whose pledge can be distributed across mandates without remainder are not
/// represented in this vector.
partials: Vec<(ValidatorId, Balance)>,
}
impl ValidatorMandates {
/// Initiates mandates corresponding to the provided `validators`. The validators must be sorted
/// by id in ascending order, so the validator with `ValidatorId` equal to `i` is given by
/// `validators[i]`.
///
/// Only full mandates are assigned, partial mandates are dropped. For example, when the pledge
/// required for a mandate is 5 and a validator has pledging 12, then it will obtain 2 mandates.
pub fn new(config: ValidatorMandatesConfig, validators: &[ValidatorPowerAndPledge]) -> Self {
let num_mandates_per_validator: Vec<u16> =
validators.iter().map(|v| v.num_mandates(config.pledge_per_mandate)).collect();
let num_total_mandates =
num_mandates_per_validator.iter().map(|&num| usize::from(num)).sum();
let mut mandates: Vec<ValidatorId> = Vec::with_capacity(num_total_mandates);
for i in 0..validators.len() {
for _ in 0..num_mandates_per_validator[i] {
// Each validator's position corresponds to its id.
mandates.push(i as ValidatorId);
}
}
let required_mandates = config.min_mandates_per_shard * config.num_shards;
if mandates.len() < required_mandates {
// TODO(#10014) dynamically lower `pledge_per_mandate` to reach enough mandates
panic!(
"not enough validator mandates: got {}, need {}",
mandates.len(),
required_mandates
);
}
// Not counting partials towards `required_mandates` as the weight of partials and its
// distribution across shards may vary widely.
//
// Construct vector with capacity as most likely some validators' pledge will not be evenly
// divided by `config.pledge_per_mandate`, i.e. some validators will have partials.
let mut partials = Vec::with_capacity(validators.len());
for i in 0..validators.len() {
let partial_weight = validators[i].partial_mandate_weight(config.pledge_per_mandate);
if partial_weight > 0 {
partials.push((i as ValidatorId, partial_weight));
}
}
Self { config, mandates, partials }
}
/// Returns a validator assignment obtained by shuffling mandates and assigning them to shards.
/// Shard ids are shuffled as well in this process to avoid a bias lower shard ids, see
/// [`ShuffledShardIds`].
///
/// It clones mandates since [`ValidatorMandates`] is supposed to be valid for an epoch, while a
/// new assignment is calculated at every height.
pub fn sample<R>(&self, rng: &mut R) -> ValidatorMandatesAssignment
where
R: Rng + ?Sized,
{
// Shuffling shard ids to avoid a bias towards lower ids, see [`ShuffledShardIds`]. We
// do two separate shuffes for full and partial mandates to reduce the likelihood of
// assigning fewer full _and_ partial mandates to the _same_ shard.
let shard_ids_for_mandates = ShuffledShardIds::new(rng, self.config.num_shards);
let shard_ids_for_partials = ShuffledShardIds::new(rng, self.config.num_shards);
let shuffled_mandates = self.shuffled_mandates(rng);
let shuffled_partials = self.shuffled_partials(rng);
// Distribute shuffled mandates and partials across shards. For each shard with `shard_id`
// in `[0, num_shards)`, we take the elements of the vector with index `i` such that `i %
// num_shards == shard_id`.
//
// Assume, for example, there are 10 mandates and 4 shards. Then for `shard_id = 1` we
// collect the mandates with indices 1, 5, and 9.
let mut mandates_per_shard: ValidatorMandatesAssignment =
vec![HashMap::new(); self.config.num_shards];
for shard_id in 0..self.config.num_shards {
// Achieve shard id shuffling by writing to the position of the alias of `shard_id`.
let mandates_assignment =
&mut mandates_per_shard[shard_ids_for_mandates.get_alias(shard_id)];
// For the current `shard_id`, collect mandates with index `i` such that
// `i % num_shards == shard_id`.
for idx in (shard_id..shuffled_mandates.len()).step_by(self.config.num_shards) {
let validator_id = shuffled_mandates[idx];
mandates_assignment
.entry(validator_id)
.and_modify(|assignment_weight| {
assignment_weight.num_mandates += 1;
})
.or_insert(AssignmentWeight::new(1, 0));
}
// Achieve shard id shuffling by writing to the position of the alias of `shard_id`.
let partials_assignment =
&mut mandates_per_shard[shard_ids_for_partials.get_alias(shard_id)];
// For the current `shard_id`, collect partials with index `i` such that
// `i % num_shards == shard_id`.
for idx in (shard_id..shuffled_partials.len()).step_by(self.config.num_shards) {
let (validator_id, partial_weight) = shuffled_partials[idx];
partials_assignment
.entry(validator_id)
.and_modify(|assignment_weight| {
assignment_weight.partial_weight += partial_weight;
})
.or_insert(AssignmentWeight::new(0, partial_weight));
}
}
mandates_per_shard
}
/// Clones the contained mandates and shuffles them. Cloning is required as a shuffle happens at
/// every height while the `ValidatorMandates` are to be valid for an epoch.
fn shuffled_mandates<R>(&self, rng: &mut R) -> Vec<ValidatorId>
where
R: Rng + ?Sized,
{
let mut shuffled_mandates = self.mandates.clone();
shuffled_mandates.shuffle(rng);
shuffled_mandates
}
/// Clones the contained partials and shuffles them. Cloning is required as a shuffle happens at
/// every height while the `ValidatorMandates` are to be valid for an epoch.
fn shuffled_partials<R>(&self, rng: &mut R) -> Vec<(ValidatorId, Balance)>
where
R: Rng + ?Sized,
{
let mut shuffled_partials = self.partials.clone();
shuffled_partials.shuffle(rng);
shuffled_partials
}
}
/// Represents an assignment of [`ValidatorMandates`] for a specific height.
///
/// Contains one map per shard, with the position in the vector corresponding to `shard_id` in
/// `0..num_shards`. Each `HashMap` maps `ValidatorId`s to the number of mandates they have in the
/// corresponding shards. A validator whose id is not in a map has not been assigned to the shard.
///
/// For example, `mandates_per_shard[0][1]` maps to the [`AssignmentWeights`] validator with
/// `ValidatorId` 1 holds in shard with id 0.
pub type ValidatorMandatesAssignment = Vec<HashMap<ValidatorId, AssignmentWeight>>;
#[derive(Default, Clone, Debug, PartialEq, Eq)]
pub struct AssignmentWeight {
pub num_mandates: u16,
/// Pledge assigned to this partial mandate.
pub partial_weight: Balance,
}
impl AssignmentWeight {
pub fn new(num_mandates: u16, partial_weight: Balance) -> Self {
Self { num_mandates, partial_weight }
}
}
/// When assigning mandates first to shards with lower ids, the shards with higher ids might end up
/// with fewer assigned mandates.
///
/// Assumes shard ids are in `[0, num_shards)`.
///
/// # Example
///
/// Assume there are 3 shards and 5 mandates. Assigning to shards with lower ids first, the first
/// two shards get 2 mandates each. For the third shard only 1 mandate remains.
///
/// # Shuffling to avoid bias
///
/// When mandates cannot be distributed evenly across shards, some shards will be assigned one
/// mandata less than others. Shuffling shard ids prevents a bias towards lower shard ids, as it is
/// no longer predictable which shard(s) will be assigned one mandate less.
#[derive(Default, Clone, Debug, PartialEq, Eq)]
struct ShuffledShardIds {
/// Contains the shard ids `[0, num_shards)` in shuffled order.
shuffled_ids: Vec<usize>,
}
impl ShuffledShardIds {
fn new<R>(rng: &mut R, num_shards: usize) -> Self
where
R: Rng + ?Sized,
{
let mut shuffled_ids = (0..num_shards).collect::<Vec<_>>();
shuffled_ids.shuffle(rng);
Self { shuffled_ids }
}
/// Gets the alias of `shard_id` corresponding to the current shuffling.
///
/// # Panics
///
/// Panics if `shard_id >= num_shards`.
fn get_alias(&self, shard_id: usize) -> usize {
self.shuffled_ids[shard_id]
}
}
#[cfg(test)]
mod tests {
use std::collections::HashMap;
use rand::SeedableRng;
use rand_chacha::ChaCha8Rng;
use unc_crypto::PublicKey;
use unc_primitives_core::types::{Balance, Power};
use crate::{
types::{validator_power_and_pledge::ValidatorPowerAndPledge, ValidatorId},
validator_mandates::ValidatorMandatesConfig,
};
use super::{
AssignmentWeight, ShuffledShardIds, ValidatorMandates, ValidatorMandatesAssignment,
};
/// Returns a new, fixed RNG to be used only in tests. Using a fixed RNG facilitates testing as
/// it makes outcomes based on that RNG deterministic.
fn new_fixed_rng() -> ChaCha8Rng {
ChaCha8Rng::seed_from_u64(42)
}
#[test]
fn test_validator_mandates_config_new() {
let pledge_per_mandate = 10;
let min_mandates_per_shard = 400;
let num_shards = 4;
assert_eq!(
ValidatorMandatesConfig::new(pledge_per_mandate, min_mandates_per_shard, num_shards),
ValidatorMandatesConfig { pledge_per_mandate, min_mandates_per_shard, num_shards },
)
}
/// Constructs some `ValidatorPledges` for usage in tests.
///
/// # Properties of the corresponding `ValidatorMandates`
///
/// The mandates are (verified in [`test_validator_mandates_new`]):
/// `vec![0, 0, 0, 1, 1, 3, 4, 4, 4]`
///
/// The partials are (verified in [`test_validator_mandates_new`]):
/// `vec![(1, 7), (2, 9), (3, 2), (4, 5), (5, 4), (6, 6)]`
fn new_validator_power_and_pledges() -> Vec<ValidatorPowerAndPledge> {
let new_vs =
|account_id: &str, power: Power, balance: Balance| -> ValidatorPowerAndPledge {
ValidatorPowerAndPledge::new(
account_id.parse().unwrap(),
PublicKey::empty(unc_crypto::KeyType::ED25519),
power,
balance,
)
};
vec![
new_vs("account_0", 30, 30),
new_vs("account_1", 27, 27),
new_vs("account_2", 9, 9),
new_vs("account_3", 12, 12),
new_vs("account_4", 35, 35),
new_vs("account_5", 4, 4),
new_vs("account_6", 6, 6),
]
}
#[test]
fn test_validator_mandates_new() {
let validators = new_validator_power_and_pledges();
let config = ValidatorMandatesConfig::new(10, 1, 4);
let mandates = ValidatorMandates::new(config, &validators);
// At 10 pledge per mandate, the first validator holds three mandates, and so on.
// Note that "account_2" holds no mandate as its pledge is below the threshold.
let expected_mandates: Vec<ValidatorId> = vec![0, 0, 0, 1, 1, 3, 4, 4, 4];
assert_eq!(mandates.mandates, expected_mandates);
// At 10 pledge per mandate, the first validator holds no partial mandate, the second
// validator holds a partial mandate with weight 7, and so on.
let expected_partials: Vec<(ValidatorId, Balance)> =
vec![(1, 7), (2, 9), (3, 2), (4, 5), (5, 4), (6, 6)];
assert_eq!(mandates.partials, expected_partials);
}
#[test]
fn test_validator_mandates_shuffled_mandates() {
// Testing with different `num_shards` values to verify the shuffles used in other tests.
assert_validator_mandates_shuffled_mandates(3, vec![0, 1, 4, 4, 3, 1, 4, 0, 0]);
assert_validator_mandates_shuffled_mandates(4, vec![0, 4, 1, 1, 0, 0, 4, 3, 4]);
}
fn assert_validator_mandates_shuffled_mandates(
num_shards: usize,
expected_assignment: Vec<ValidatorId>,
) {
let validators = new_validator_power_and_pledges();
let config = ValidatorMandatesConfig::new(10, 1, num_shards);
let mandates = ValidatorMandates::new(config, &validators);
let mut rng = new_fixed_rng();
// Call methods that modify `rng` before shuffling mandates to emulate what happens in
// [`ValidatorMandates::sample`]. Then `expected_assignment` below equals the shuffled
// mandates assigned to shards in `test_validator_mandates_sample_*`.
let _shard_ids_for_mandates = ShuffledShardIds::new(&mut rng, config.num_shards);
let _shard_ids_for_partials = ShuffledShardIds::new(&mut rng, config.num_shards);
let assignment = mandates.shuffled_mandates(&mut rng);
assert_eq!(
assignment, expected_assignment,
"Unexpected shuffling for num_shards = {num_shards}"
);
}
#[test]
fn test_validator_mandates_shuffled_partials() {
// Testing with different `num_shards` values to verify the shuffles used in other tests.
assert_validator_mandates_shuffled_partials(
3,
vec![(3, 2), (4, 5), (1, 7), (2, 9), (5, 4), (6, 6)],
);
assert_validator_mandates_shuffled_partials(
4,
vec![(5, 4), (4, 5), (1, 7), (3, 2), (2, 9), (6, 6)],
);
}
fn assert_validator_mandates_shuffled_partials(
num_shards: usize,
expected_assignment: Vec<(ValidatorId, Balance)>,
) {
let validators = new_validator_power_and_pledges();
let config = ValidatorMandatesConfig::new(10, 1, num_shards);
let mandates = ValidatorMandates::new(config, &validators);
let mut rng = new_fixed_rng();
// Call methods that modify `rng` before shuffling mandates to emulate what happens in
// [`ValidatorMandates::sample`]. Then `expected_assignment` below equals the shuffled
// partials assigned to shards in `test_validator_mandates_sample_*`.
let _shard_ids_for_mandates = ShuffledShardIds::new(&mut rng, config.num_shards);
let _shard_ids_for_partials = ShuffledShardIds::new(&mut rng, config.num_shards);
let _ = mandates.shuffled_mandates(&mut rng);
let assignment = mandates.shuffled_partials(&mut rng);
assert_eq!(
assignment, expected_assignment,
"Unexpected shuffling for num_shards = {num_shards}"
);
}
/// Test mandates per shard are collected correctly for `num_mandates % num_shards == 0` and
/// `num_partials % num_shards == 0`.
#[test]
fn test_validator_mandates_sample_even() {
// Choosing `num_shards` such that mandates and partials are distributed evenly.
// Assignments in `test_validator_mandates_shuffled_*` can be used to construct
// `expected_assignment` below.
// Note that shard ids are shuffled too, see `test_shuffled_shard_ids_new`.
let config = ValidatorMandatesConfig::new(10, 1, 3);
let expected_assignment: ValidatorMandatesAssignment = vec![
HashMap::from([
(4, AssignmentWeight::new(1, 0)),
(1, AssignmentWeight::new(1, 7)),
(0, AssignmentWeight::new(1, 0)),
(6, AssignmentWeight::new(0, 6)),
]),
HashMap::from([
(1, AssignmentWeight::new(1, 0)),
(3, AssignmentWeight::new(1, 0)),
(0, AssignmentWeight::new(1, 0)),
(4, AssignmentWeight::new(0, 5)),
(5, AssignmentWeight::new(0, 4)),
]),
HashMap::from([
(0, AssignmentWeight::new(1, 0)),
(4, AssignmentWeight::new(2, 0)),
(3, AssignmentWeight::new(0, 2)),
(2, AssignmentWeight::new(0, 9)),
]),
];
assert_validator_mandates_sample(config, expected_assignment);
}
/// Test mandates per shard are collected correctly for `num_mandates % num_shards != 0` and
/// `num_partials % num_shards != 0`.
#[test]
fn test_validator_mandates_sample_uneven() {
// Choosing `num_shards` such that mandates and partials are distributed unevenly.
// Assignments in `test_validator_mandates_shuffled_*` can be used to construct
// `expected_assignment` below.
// Note that shard ids are shuffled too, see `test_shuffled_shard_ids_new`.
let config = ValidatorMandatesConfig::new(10, 1, 4);
let expected_mandates_per_shards: ValidatorMandatesAssignment = vec![
HashMap::from([
(0, AssignmentWeight::new(2, 0)),
(4, AssignmentWeight::new(1, 0)),
(1, AssignmentWeight::new(0, 7)),
]),
HashMap::from([
(1, AssignmentWeight::new(1, 0)),
(4, AssignmentWeight::new(1, 0)),
(3, AssignmentWeight::new(0, 2)),
]),
HashMap::from([
(4, AssignmentWeight::new(1, 5)),
(0, AssignmentWeight::new(1, 0)),
(6, AssignmentWeight::new(0, 6)),
]),
HashMap::from([
(1, AssignmentWeight::new(1, 0)),
(3, AssignmentWeight::new(1, 0)),
(5, AssignmentWeight::new(0, 4)),
(2, AssignmentWeight::new(0, 9)),
]),
];
assert_validator_mandates_sample(config, expected_mandates_per_shards);
}
/// Asserts mandates per shard are collected correctly.
fn assert_validator_mandates_sample(
config: ValidatorMandatesConfig,
expected_assignment: ValidatorMandatesAssignment,
) {
let validators = new_validator_power_and_pledges();
let mandates = ValidatorMandates::new(config, &validators);
let mut rng = new_fixed_rng();
let assignment = mandates.sample(&mut rng);
assert_eq!(assignment, expected_assignment);
}
#[test]
fn test_shuffled_shard_ids_new() {
// Testing with different `num_shards` values to verify the shuffles used in other tests.
// Doing two shuffles for each `num_shards` with the same RNG since shard ids are shuffled
// twice (once for full and once for partial mandates).
let mut rng_3_shards = new_fixed_rng();
assert_shuffled_shard_ids(&mut rng_3_shards, 3, vec![2, 1, 0], "3 shards, 1st shuffle");
assert_shuffled_shard_ids(&mut rng_3_shards, 3, vec![2, 1, 0], "3 shards, 2nd shuffle");
let mut rng_4_shards = new_fixed_rng();
assert_shuffled_shard_ids(&mut rng_4_shards, 4, vec![0, 2, 1, 3], "4 shards, 1st shuffle");
assert_shuffled_shard_ids(&mut rng_4_shards, 4, vec![3, 2, 0, 1], "4 shards, 2nd shuffle");
}
fn assert_shuffled_shard_ids(
rng: &mut ChaCha8Rng,
num_shards: usize,
expected_shuffling: Vec<usize>,
test_descriptor: &str,
) {
let shuffled_ids_full_mandates = ShuffledShardIds::new(rng, num_shards);
assert_eq!(
shuffled_ids_full_mandates,
ShuffledShardIds { shuffled_ids: expected_shuffling },
"Unexpected shuffling for {test_descriptor}",
);
}
#[test]
fn test_shuffled_shard_ids_get_alias() {
let mut rng = new_fixed_rng();
let shuffled_ids = ShuffledShardIds::new(&mut rng, 4);
// See [`test_shuffled_shard_ids_new`] for the result of this shuffling.
assert_eq!(shuffled_ids.get_alias(1), 2);
}
}