Skip to main content

testing_conventions/
lib.rs

1pub mod agents;
2pub mod co_change;
3pub mod colocated_test;
4pub mod config;
5pub mod coverage;
6pub mod e2e;
7pub mod isolation;
8pub mod lint;
9pub mod mutation;
10pub mod packaging;
11pub mod patch_coverage;
12pub mod ts;
13pub mod violation;
14pub mod workflow;
15
16use std::path::{Path, PathBuf};
17
18use clap::{CommandFactory, Parser, Subcommand};
19
20#[derive(Parser, Debug)]
21#[command(
22    name = "testing-conventions",
23    version,
24    about = "Enforce testing conventions in libraries (Python, TypeScript, and Rust).",
25    long_about = None,
26)]
27pub struct Cli {
28    #[command(subcommand)]
29    command: Option<Command>,
30}
31
32#[derive(Subcommand, Debug)]
33enum Command {
34    /// Check the repository against its testing-conventions config.
35    Check,
36    /// Write the testing contract into the repository's agent context file
37    /// (#232): a marker-delimited, hash-versioned block in `AGENTS.md` that a
38    /// coding agent reads before writing code. Idempotent — re-running
39    /// refreshes the owned region and touches nothing outside it.
40    Install {
41        /// The agent context file to manage.
42        #[arg(default_value = "AGENTS.md")]
43        path: PathBuf,
44    },
45    /// Unit-test conventions.
46    Unit {
47        #[command(subcommand)]
48        rule: UnitRule,
49    },
50    /// Integration-test conventions.
51    Integration {
52        #[command(subcommand)]
53        rule: IntegrationRule,
54    },
55    /// Packaging conventions: test files must not ship in the built artifact.
56    Packaging {
57        /// Root of the built artifact to inspect (e.g. an unpacked wheel or `dist/`).
58        path: PathBuf,
59        /// Language convention to enforce (required).
60        #[arg(long, value_enum)]
61        language: colocated_test::Language,
62    },
63    /// Workflow guard (private — hidden from `--help`, #191): every `testing-conventions`
64    /// invocation in a CI workflow must name a subcommand this binary still exposes
65    /// (guards the `@v0` path, #92). Run from our own CI, not a documented consumer command;
66    /// it stays in the binary because the guard needs the in-process command tree.
67    #[command(hide = true)]
68    Workflow {
69        /// Workflow file (or a directory of them) to scan.
70        path: PathBuf,
71    },
72    /// End-to-end-test conventions.
73    E2e {
74        #[command(subcommand)]
75        command: E2eCommand,
76    },
77}
78
79/// Rules enforced on the unit-test suite (the README's "Unit" taxonomy).
80#[derive(Subcommand, Debug)]
81enum UnitRule {
82    /// Check that every source file has a colocated, matching-named unit test
83    /// (tree-wide presence). With `--base`, additionally run the commit-scoped
84    /// `co-change` check over `<base>...HEAD` (#33): a modified or deleted source
85    /// whose colocated test is not in the diff fails. Presence always runs;
86    /// `--base` *adds* the diff-scoped check.
87    ColocatedTest {
88        /// Directory to scan recursively.
89        path: PathBuf,
90        /// Language convention to enforce (required).
91        #[arg(long, value_enum)]
92        language: colocated_test::Language,
93        /// Opt-in commit-scoped co-change check (#33): diff `<base>...HEAD` and
94        /// also flag a modified or deleted source whose colocated test didn't
95        /// co-change. Absent means presence-only — there is no default. Python /
96        /// TypeScript only: `--base --language rust` is rejected (inline
97        /// `#[cfg(test)]` units have no sibling test to go stale).
98        #[arg(long)]
99        base: Option<String>,
100        /// testing-conventions config file providing the `exempt` list. Optional:
101        /// if the file is absent, no files are exempt.
102        #[arg(long, default_value = "testing-conventions.toml")]
103        config: PathBuf,
104    },
105    /// Check that the unit suite meets the configured coverage floor. With
106    /// `--base`, the same configured floor is measured over the `<base>...HEAD`
107    /// diff (the changed lines) instead of the whole tree (#162) — a changed line
108    /// below the floor fails, no matter how small the diff.
109    Coverage {
110        /// Directory whose unit suite is run and measured.
111        path: PathBuf,
112        /// Language convention to enforce (required).
113        #[arg(long, value_enum)]
114        language: colocated_test::Language,
115        /// Opt-in diff-scoped coverage (#162): diff `<base>...HEAD` and measure the
116        /// configured floor over only the changed lines, instead of the whole tree.
117        /// Absent means whole-tree — there is no default. This is the patch-scoped
118        /// check the old `unit patch-coverage` command did, re-homed onto the floor
119        /// it shares.
120        #[arg(long)]
121        base: Option<String>,
122        /// testing-conventions config file with the coverage thresholds and
123        /// `exempt` list. Optional: if the file — or its `[<language>].coverage`
124        /// table — is absent, the language's sane default floor is used and
125        /// nothing is exempt.
126        #[arg(long, default_value = "testing-conventions.toml")]
127        config: PathBuf,
128    },
129    /// Lint unit test files for isolation: mock every collaborator (Python, TypeScript, Rust).
130    Lint {
131        /// Crate root / source dir to scan recursively.
132        path: PathBuf,
133        /// Language convention to enforce (required).
134        #[arg(long, value_enum)]
135        language: isolation::Language,
136        /// testing-conventions config file providing the `exempt` list (waivers).
137        /// Optional: if the file is absent, nothing is waived.
138        #[arg(long, default_value = "testing-conventions.toml")]
139        config: PathBuf,
140    },
141    /// Run mutation testing over the unit suite and fail on any surviving mutant not
142    /// lifted by a `mutation` exemption — the rung above coverage (#201). The gate is
143    /// on by default (no report-only mode). All three languages (Python, TypeScript,
144    /// Rust) are at parity and wired into the reusable workflow as a diff-scoped,
145    /// PR-only job (#204).
146    Mutation {
147        /// Crate whose unit suite is mutated.
148        path: PathBuf,
149        /// Language convention to enforce (required): `python`, `typescript`, or `rust`.
150        #[arg(long, value_enum)]
151        language: colocated_test::Language,
152        /// Opt-in diff-scoping (#201): restrict to mutants on lines a `<base>...HEAD`
153        /// diff added or modified, via cargo-mutants' `--in-diff`. Absent means the
154        /// whole crate (slower).
155        #[arg(long)]
156        base: Option<String>,
157        /// testing-conventions config file providing the `exempt` list. Optional:
158        /// absent means nothing is exempt (every survivor must be killed).
159        #[arg(long, default_value = "testing-conventions.toml")]
160        config: PathBuf,
161        /// Path to the bundled TypeScript mutation adapter (`dist/mutation/main.js`), used
162        /// only by `--language typescript`. The npm launcher appends it; hidden because a
163        /// consumer never sets it by hand.
164        #[arg(long = "ts-mutation-adapter", hide = true)]
165        ts_adapter: Option<PathBuf>,
166    },
167}
168
169/// Languages the integration-test lints support — its own set (Python,
170/// TypeScript, Rust), distinct from the file-pairing `colocated_test::Language`,
171/// so adding Rust here doesn't touch the colocated-test/coverage rules.
172#[derive(Debug, Clone, Copy, PartialEq, Eq, clap::ValueEnum)]
173pub enum IntegrationLintLanguage {
174    /// Python test files (`*_test.py`, `test_*.py`, `conftest.py`).
175    #[value(name = "python")]
176    Python,
177    /// TypeScript test files (`*.test.{ts,tsx,mts,cts}`).
178    #[value(name = "typescript")]
179    TypeScript,
180    /// Rust integration crates under `tests/`.
181    #[value(name = "rust")]
182    Rust,
183}
184
185/// Lints enforced on integration tests (mocking mechanism & style, and more to
186/// come). The README's "Integration" taxonomy.
187#[derive(Subcommand, Debug)]
188enum IntegrationRule {
189    /// Lint integration test files for mocking mechanism & style (Python, TypeScript, Rust).
190    Lint {
191        /// Directory to scan recursively for test files.
192        path: PathBuf,
193        /// Language convention to enforce (required).
194        #[arg(long, value_enum)]
195        language: IntegrationLintLanguage,
196        /// testing-conventions config file providing the `exempt` list (waivers).
197        /// Optional: if the file is absent, nothing is waived.
198        #[arg(long, default_value = "testing-conventions.toml")]
199        config: PathBuf,
200    },
201}
202
203/// E2E attestation commands (#17): record a local e2e run and (later, #68)
204/// verify in CI that the latest code commit is attested.
205#[derive(Subcommand, Debug)]
206enum E2eCommand {
207    /// Run the e2e suite and write a committed attestation naming the current commit.
208    Attest {
209        /// The e2e command to run (e.g. `pnpm run e2e`), executed via the shell.
210        command: String,
211    },
212    /// Verify the committed attestation names the latest code commit (the CI gate).
213    Verify,
214}
215
216pub fn run<I, T>(args: I) -> anyhow::Result<i32>
217where
218    I: IntoIterator<Item = T>,
219    T: Into<std::ffi::OsString> + Clone,
220{
221    let cli = Cli::try_parse_from(args)?;
222    match cli.command {
223        // The config-driven `check` umbrella isn't wired yet; the scaffold
224        // proves the wiring while individual rules land under their test-kind
225        // group (e.g. `unit colocated-test`).
226        Some(Command::Check) | None => Ok(0),
227        Some(Command::Unit { rule }) => match rule {
228            UnitRule::ColocatedTest {
229                path,
230                language,
231                base,
232                config,
233            } => run_unit_colocated_test(&path, language, base.as_deref(), &config),
234            UnitRule::Coverage {
235                path,
236                language,
237                base,
238                config,
239            } => run_unit_coverage(&path, language, base.as_deref(), &config),
240            UnitRule::Lint {
241                path,
242                language,
243                config,
244            } => run_unit_lint(&path, language, &config),
245            UnitRule::Mutation {
246                path,
247                language,
248                base,
249                config,
250                ts_adapter,
251            } => run_unit_mutation(
252                &path,
253                language,
254                base.as_deref(),
255                &config,
256                ts_adapter.as_deref(),
257            ),
258        },
259        Some(Command::Integration { rule }) => match rule {
260            IntegrationRule::Lint {
261                path,
262                language,
263                config,
264            } => run_integration_lint(&path, language, &config),
265        },
266        Some(Command::Packaging { path, language }) => run_packaging(&path, language),
267        Some(Command::Workflow { path }) => run_workflow(&path),
268        Some(Command::E2e { command }) => match command {
269            E2eCommand::Attest { command } => run_e2e_attest(&command),
270            E2eCommand::Verify => run_e2e_verify(),
271        },
272        Some(Command::Install { path }) => {
273            agents::install(&path)?;
274            Ok(0)
275        }
276    }
277}
278
279/// The binary's own clap command tree — the source of truth for which subcommands
280/// it exposes. The `workflow` guard (#92) checks a workflow's invocations against
281/// it, so a renamed or removed subcommand is caught the moment they diverge.
282pub fn command() -> clap::Command {
283    Cli::command()
284}
285
286/// Run the unit colocated-test check over `root` for `language`. Always runs the
287/// tree-wide **presence** check (every source file has its colocated test; Rust:
288/// an inline `#[cfg(test)]` module). When `base` is `Some`, *additionally* runs the
289/// commit-scoped **co-change** check (#33) over `<base>...HEAD` — a modified or
290/// deleted source whose colocated test didn't co-change — and the run fails if
291/// either check does. Returns `0` only when both pass.
292///
293/// Presence loads the `colocated-test`-rule exemptions and co-change the
294/// `co-change`-rule exemptions from the config at `config_path` (no config file →
295/// no exemptions). `--base` rejects `--language rust`: Rust units are inline
296/// `#[cfg(test)]` in the same file, so a sibling test can't go stale (presence,
297/// without `--base`, still supports Rust).
298fn run_unit_colocated_test(
299    root: &Path,
300    language: colocated_test::Language,
301    base: Option<&str>,
302    config_path: &Path,
303) -> anyhow::Result<i32> {
304    // `--base` carries the co-change check, which rejects Rust the same way the
305    // standalone `unit co-change` did — before any work, so the message matches.
306    if base.is_some() && language == colocated_test::Language::Rust {
307        anyhow::bail!(
308            "`unit colocated-test --base` supports `--language python` / `typescript`; Rust \
309             units are inline `#[cfg(test)]` in the same file, so a sibling test can't go stale"
310        );
311    }
312    let presence_clean = report_colocated_presence(root, language, config_path)?;
313    let co_change_clean = match base {
314        Some(base) => report_co_change(root, base, language, config_path)?,
315        None => true,
316    };
317    Ok(if presence_clean && co_change_clean {
318        0
319    } else {
320        1
321    })
322}
323
324/// The tree-wide colocated-test **presence** check: every source file under `root`
325/// has its colocated unit test (Rust: an inline `#[cfg(test)]` module). Prints each
326/// orphan to stderr and returns `Ok(false)` when any are found, `Ok(true)` when the
327/// tree is clean. The `colocated-test`-rule exemptions from the config at
328/// `config_path` lift a file (no config file → nothing exempt).
329fn report_colocated_presence(
330    root: &Path,
331    language: colocated_test::Language,
332    config_path: &Path,
333) -> anyhow::Result<bool> {
334    let exempt = colocated_test_exemptions(root, language, config_path)?;
335    let orphans = match language {
336        // Rust units are inline `#[cfg(test)]` modules, so "colocated" means a test
337        // module in the same file, not a sibling file (#40).
338        colocated_test::Language::Rust => colocated_test::missing_inline_tests(root, &exempt)?,
339        _ => colocated_test::missing_unit_tests(root, language, &exempt)?,
340    };
341    if orphans.is_empty() {
342        return Ok(true);
343    }
344    let (label, summary) = match language {
345        colocated_test::Language::Rust => (
346            "missing inline `#[cfg(test)]` tests",
347            "source file(s) with testable code but no inline `#[cfg(test)]` module \
348             (add an inline test module, or an `exempt` entry with a reason)",
349        ),
350        _ => (
351            "missing colocated unit test",
352            "source file(s) missing a colocated unit test \
353             (add a colocated test, or an `exempt` entry with a reason)",
354        ),
355    };
356    for orphan in &orphans {
357        eprintln!("{label}: {}", orphan.display());
358    }
359    eprintln!("error: {} {summary}", orphans.len());
360    Ok(false)
361}
362
363/// The `colocated-test`-rule exempt paths for `language`, resolved (and validated)
364/// from the config at `config_path`. A missing config file means no exemptions —
365/// the check still runs, just with nothing exempted.
366fn colocated_test_exemptions(
367    root: &Path,
368    language: colocated_test::Language,
369    config_path: &Path,
370) -> anyhow::Result<std::collections::BTreeSet<String>> {
371    if !config_path.exists() {
372        return Ok(std::collections::BTreeSet::new());
373    }
374    let config = config::load_config(config_path)?;
375    config::resolve_exempt(
376        root,
377        config.exemptions(language),
378        config::Rule::ColocatedTest,
379    )
380}
381
382/// The commit-scoped **co-change** check (#33) over `root`, diffing `<base>...HEAD`:
383/// every modified or deleted source whose colocated test didn't co-change. Prints
384/// each stale source to stderr and returns `Ok(false)` when any are found,
385/// `Ok(true)` when clean.
386///
387/// Loads the `co-change`-rule exemptions from the config at `config_path` (no
388/// config file → no exemptions); an exempt source needn't co-change. The caller
389/// rejects `--language rust` before this runs: Rust units are inline `#[cfg(test)]`
390/// in the same file, so a sibling test can't go stale.
391fn report_co_change(
392    root: &Path,
393    base: &str,
394    language: colocated_test::Language,
395    config_path: &Path,
396) -> anyhow::Result<bool> {
397    let exempt = co_change_exemptions(root, language, config_path)?;
398    let stale = co_change::stale_sources(root, base, language, &exempt)?;
399    if stale.is_empty() {
400        return Ok(true);
401    }
402    for source in &stale {
403        eprintln!(
404            "source changed without its colocated test: {}",
405            source.display()
406        );
407    }
408    eprintln!(
409        "error: {} source file(s) changed without their colocated test co-changing \
410         (update the test, or add an `exempt` entry with a reason)",
411        stale.len()
412    );
413    Ok(false)
414}
415
416/// The `co-change`-rule exempt paths for `language`, resolved (and validated)
417/// from the config at `config_path`. A missing config file means no exemptions —
418/// every changed source must co-change its test.
419fn co_change_exemptions(
420    root: &Path,
421    language: colocated_test::Language,
422    config_path: &Path,
423) -> anyhow::Result<std::collections::BTreeSet<String>> {
424    if !config_path.exists() {
425        return Ok(std::collections::BTreeSet::new());
426    }
427    let config = config::load_config(config_path)?;
428    config::resolve_exempt(root, config.exemptions(language), config::Rule::CoChange)
429}
430
431/// Split a resolved exempt-scope map (#226) into the whole-file paths and the
432/// line-scoped sets — the two shapes the `coverage` / `mutation` measure functions
433/// take. A [`config::LineScope::WholeFile`] becomes a path in the first vec; a
434/// [`config::LineScope::Lines`] a `path → lines` entry in the second map.
435fn split_scopes(
436    scopes: std::collections::BTreeMap<String, config::LineScope>,
437) -> (
438    Vec<String>,
439    std::collections::BTreeMap<String, std::collections::BTreeSet<u32>>,
440) {
441    let mut whole_file = Vec::new();
442    let mut line_scoped = std::collections::BTreeMap::new();
443    for (path, scope) in scopes {
444        match scope {
445            config::LineScope::WholeFile => whole_file.push(path),
446            config::LineScope::Lines(lines) => {
447                line_scoped.insert(path, lines);
448            }
449        }
450    }
451    (whole_file, line_scoped)
452}
453
454/// Run the unit-test coverage check over `root` for `language`, enforcing the
455/// floor from the config at `config_path`. Returns `0` when the floor is met,
456/// `1` otherwise.
457///
458/// With `base` set, the same configured floor is measured over the
459/// `<base>...HEAD` diff (the changed lines) rather than the whole tree (#162),
460/// via the diff-scoped [`patch_coverage::measure`] / `measure_typescript` /
461/// `measure_rust`; without it, the whole-tree [`coverage::measure`] family runs.
462///
463/// Coverage is zero-config by default for Python and TypeScript (#80): a missing
464/// config file — or a config with no `[<language>].coverage` table — falls back to
465/// the language's sane default floor ([`config::PythonCoverage::default`] /
466/// [`config::TypeScriptCoverage::default`]), the same way `unit colocated-test` and
467/// `integration lint` treat an absent config as "nothing exempt". A present
468/// `coverage` table overrides the default; `coverage`-rule exemptions still apply.
469/// Rust (#206) is zero-config too: a missing `[rust].coverage` table falls back to
470/// [`config::RustCoverage::default`] (`lines = 100`, `regions` opt-in, no branch).
471fn run_unit_coverage(
472    root: &Path,
473    language: colocated_test::Language,
474    base: Option<&str>,
475    config_path: &Path,
476) -> anyhow::Result<i32> {
477    let config = if config_path.exists() {
478        config::load_config(config_path)?
479    } else {
480        config::Config::default()
481    };
482    let outcome = match language {
483        colocated_test::Language::Python => {
484            let python = config.python.unwrap_or_default();
485            let coverage = python.coverage.unwrap_or_default();
486            let thresholds = coverage::Thresholds {
487                fail_under: coverage.fail_under,
488                branch: coverage.branch,
489            };
490            let (omit, exempt_lines) = split_scopes(config::resolve_exempt_scoped(
491                root,
492                &python.exempt,
493                config::Rule::Coverage,
494            )?);
495            match base {
496                Some(base) => {
497                    patch_coverage::measure(root, base, thresholds, &omit, &exempt_lines)?
498                }
499                None if exempt_lines.is_empty() => coverage::measure(root, thresholds, &omit)?,
500                None => {
501                    patch_coverage::measure_line_exempt(root, thresholds, &omit, &exempt_lines)?
502                }
503            }
504        }
505        colocated_test::Language::TypeScript => {
506            let typescript = config.typescript.unwrap_or_default();
507            let coverage = typescript.coverage.unwrap_or_default();
508            let thresholds = coverage::TypeScriptThresholds {
509                lines: coverage.lines,
510                branches: coverage.branches,
511                functions: coverage.functions,
512                statements: coverage.statements,
513            };
514            let (exclude, exempt_lines) = split_scopes(config::resolve_exempt_scoped(
515                root,
516                &typescript.exempt,
517                config::Rule::Coverage,
518            )?);
519            match base {
520                Some(base) => patch_coverage::measure_typescript(
521                    root,
522                    base,
523                    thresholds,
524                    &exclude,
525                    &exempt_lines,
526                )?,
527                None if exempt_lines.is_empty() => {
528                    coverage::measure_typescript(root, thresholds, &exclude)?
529                }
530                None => patch_coverage::measure_line_exempt_typescript(
531                    root,
532                    thresholds,
533                    &exclude,
534                    &exempt_lines,
535                )?,
536            }
537        }
538        colocated_test::Language::Rust => {
539            let rust = config.rust.unwrap_or_default();
540            // Zero-config (#206): a missing `[rust].coverage` table falls back to the
541            // default Rust floor (`lines = 100`, with `regions` opt-in and no branch
542            // component) — matching Python/TypeScript — rather than erroring for a
543            // required table. A present table overrides it.
544            let coverage = rust.coverage.unwrap_or_default();
545            let thresholds = coverage::RustThresholds {
546                regions: coverage.regions,
547                lines: coverage.lines,
548            };
549            let (ignore, exempt_lines) = split_scopes(config::resolve_exempt_scoped(
550                root,
551                &rust.exempt,
552                config::Rule::Coverage,
553            )?);
554            match base {
555                Some(base) => {
556                    patch_coverage::measure_rust(root, base, thresholds, &ignore, &exempt_lines)?
557                }
558                None if exempt_lines.is_empty() => {
559                    coverage::measure_rust(root, thresholds, &ignore)?
560                }
561                None => patch_coverage::measure_line_exempt_rust(
562                    root,
563                    thresholds,
564                    &ignore,
565                    &exempt_lines,
566                )?,
567            }
568        }
569    };
570    match outcome {
571        coverage::Outcome::Pass => Ok(0),
572        coverage::Outcome::Fail(reason) => {
573            eprintln!("error: coverage check failed — {reason}");
574            Ok(1)
575        }
576    }
577}
578
579/// Run `unit mutation` over `root` (#201, #202): run the per-language engine and fail
580/// on any surviving mutant not lifted by a `mutation` exemption.
581///
582/// The gate is **on by default and binary** — "no *unexplained* surviving mutant":
583/// every survivor must be killed with an assertion, or lifted by a reason-required
584/// `[[<language>.exempt]] rules = ["mutation"]` for an equivalent / deliberately-defensive
585/// mutation. There is no percentage floor (equivalent mutants make one unreachable)
586/// and no report-only mode — the only loosening is a reasoned, per-file exemption.
587/// All three languages are wired: Rust (cargo-mutants), TypeScript (Stryker), and
588/// Python (cosmic-ray). `--base` scopes the run to the diff.
589fn run_unit_mutation(
590    root: &Path,
591    language: colocated_test::Language,
592    base: Option<&str>,
593    config_path: &Path,
594    ts_adapter: Option<&Path>,
595) -> anyhow::Result<i32> {
596    let config = if config_path.exists() {
597        config::load_config(config_path)?
598    } else {
599        config::Config::default()
600    };
601    let survivors = match language {
602        colocated_test::Language::Rust => {
603            let rust = config.rust.unwrap_or_default();
604            let (exempt, exempt_lines) = split_scopes(config::resolve_exempt_scoped(
605                root,
606                &rust.exempt,
607                config::Rule::Mutation,
608            )?);
609            mutation::measure_rust(root, &exempt, &exempt_lines, base)?
610        }
611        colocated_test::Language::TypeScript => {
612            let typescript = config.typescript.unwrap_or_default();
613            let (exempt, exempt_lines) = split_scopes(config::resolve_exempt_scoped(
614                root,
615                &typescript.exempt,
616                config::Rule::Mutation,
617            )?);
618            // The npm launcher appends `--ts-mutation-adapter`; its absence means the binary
619            // was run directly, not through the published CLI.
620            let adapter = ts_adapter.ok_or_else(|| {
621                anyhow::anyhow!(
622                    "the TypeScript mutation adapter path is required: pass \
623                     `--ts-mutation-adapter <path>`. The npm `testing-conventions` CLI appends it \
624                     automatically — run the rule through that CLI, not the raw binary."
625                )
626            })?;
627            mutation::measure_typescript(root, &exempt, &exempt_lines, base, adapter)?
628        }
629        colocated_test::Language::Python => {
630            let python = config.python.unwrap_or_default();
631            let (exempt, exempt_lines) = split_scopes(config::resolve_exempt_scoped(
632                root,
633                &python.exempt,
634                config::Rule::Mutation,
635            )?);
636            mutation::measure_python(root, &exempt, &exempt_lines, base)?
637        }
638    };
639    if survivors.is_empty() {
640        println!("unit mutation: no surviving mutants — every mutation was caught");
641        return Ok(0);
642    }
643
644    eprintln!(
645        "error: {} unexplained surviving mutant(s) — kill each with an assertion, or lift an \
646         equivalent/defensive one with a reason-required `[[<language>.exempt]] rules = [\"mutation\"]`:",
647        survivors.len()
648    );
649    for survivor in &survivors {
650        eprintln!(
651            "  {}:{}: {}",
652            survivor.file, survivor.line, survivor.description
653        );
654    }
655    Ok(1)
656}
657
658/// Run the `unit lint` check over `root` for `language` — the unit-suite
659/// isolation lints (`unmocked-collaborator`, `untyped-mock`, `no-out-of-module-call`,
660/// `no-out-of-module-import`) — printing each violation to stderr as
661/// `path:line: rule — message` and returning `1` when any are found, `0` otherwise.
662fn run_unit_lint(
663    root: &Path,
664    language: isolation::Language,
665    config_path: &Path,
666) -> anyhow::Result<i32> {
667    let (raw, select): (Vec<lint::Violation>, ExemptSelect) = match language {
668        isolation::Language::Rust => (isolation::find_violations(root)?, |c| c.rust_exemptions()),
669        isolation::Language::TypeScript => (ts::find_unit_violations(root)?, |c| {
670            c.exemptions(colocated_test::Language::TypeScript)
671        }),
672        isolation::Language::Python => (lint::find_unit_isolation_violations(root)?, |c| {
673            c.exemptions(colocated_test::Language::Python)
674        }),
675    };
676    let violations = apply_waivers(raw, root, config_path, select)?;
677    if violations.is_empty() {
678        return Ok(0);
679    }
680    for v in &violations {
681        eprintln!(
682            "{}:{}: {} — {}",
683            v.file.display(),
684            v.line,
685            v.rule,
686            v.message
687        );
688    }
689    eprintln!("error: {} isolation violation(s)", violations.len());
690    Ok(1)
691}
692
693/// Run the integration-test lints over `root` for `language`, printing each
694/// violation to stderr as `path:line: rule — message` and returning `1` when any
695/// are found, `0` otherwise.
696fn run_integration_lint(
697    root: &Path,
698    language: IntegrationLintLanguage,
699    config_path: &Path,
700) -> anyhow::Result<i32> {
701    let (raw, select): (Vec<lint::Violation>, ExemptSelect) = match language {
702        IntegrationLintLanguage::Python => (lint::find_violations(root)?, |c| {
703            c.exemptions(colocated_test::Language::Python)
704        }),
705        IntegrationLintLanguage::TypeScript => (ts::find_integration_violations(root)?, |c| {
706            c.exemptions(colocated_test::Language::TypeScript)
707        }),
708        IntegrationLintLanguage::Rust => (isolation::find_integration_violations(root)?, |c| {
709            c.rust_exemptions()
710        }),
711    };
712    let violations = apply_waivers(raw, root, config_path, select)?;
713    if violations.is_empty() {
714        return Ok(0);
715    }
716    for v in &violations {
717        eprintln!(
718            "{}:{}: {} — {}",
719            v.file.display(),
720            v.line,
721            v.rule,
722            v.message
723        );
724    }
725    eprintln!("error: {} lint violation(s)", violations.len());
726    Ok(1)
727}
728
729/// Selects a language's `[[<lang>.exempt]]` table from a loaded config — the one
730/// varying piece between the `unit lint` and `integration lint` waiver paths.
731type ExemptSelect = fn(&config::Config) -> &[config::Exemption];
732
733/// Drop the violations waived by the config's `exempt` list (#32/#102). A
734/// violation is waived when its `rule` is a known [`config::Rule`] and its
735/// `root`-relative path is exempt for that rule. `exemptions` selects the
736/// language's `[[<lang>.exempt]]` table from the loaded config. A missing config
737/// file waives nothing; a reason-less or stale entry errors (via `load_config` /
738/// `resolve_exempt`), so the escape hatch can't silently rot.
739fn apply_waivers(
740    violations: Vec<lint::Violation>,
741    root: &Path,
742    config_path: &Path,
743    exemptions: ExemptSelect,
744) -> anyhow::Result<Vec<lint::Violation>> {
745    use std::collections::hash_map::Entry;
746
747    if !config_path.exists() {
748        return Ok(violations);
749    }
750    let config = config::load_config(config_path)?;
751    let exempt = exemptions(&config);
752    // Resolve each rule's exempt set once (and surface a stale entry as an error).
753    let mut resolved: std::collections::HashMap<config::Rule, std::collections::BTreeSet<String>> =
754        std::collections::HashMap::new();
755    let mut kept = Vec::new();
756    for violation in violations {
757        let waived = match config::Rule::from_id(violation.rule) {
758            Some(rule) => {
759                let exempt_paths = match resolved.entry(rule) {
760                    Entry::Occupied(entry) => entry.into_mut(),
761                    Entry::Vacant(entry) => {
762                        entry.insert(config::resolve_exempt(root, exempt, rule)?)
763                    }
764                };
765                violation
766                    .file
767                    .strip_prefix(root)
768                    .ok()
769                    .map(|rel| rel.to_string_lossy().replace('\\', "/"))
770                    .is_some_and(|rel| exempt_paths.contains(&rel))
771            }
772            None => false,
773        };
774        if !waived {
775            kept.push(violation);
776        }
777    }
778    Ok(kept)
779}
780
781/// Run the packaging check: inspect the built artifact at `artifact` for test
782/// files that must not ship (README "Packaging"), per `language`'s test-file
783/// globs.
784///
785/// `artifact` is either an already-unpacked directory or a packed artifact the
786/// rule unpacks itself — a Python wheel (`.whl`) today; the TypeScript (#73) and
787/// Rust (#74) archives follow. Returns `0` when no test file is present, `1`
788/// otherwise (after printing each offending path, relative to the artifact root).
789fn run_packaging(artifact: &Path, language: colocated_test::Language) -> anyhow::Result<i32> {
790    let globs = match language {
791        colocated_test::Language::Python => vec!["*_test.py".to_string()],
792        colocated_test::Language::TypeScript => vec!["*.test.*".to_string()],
793        // `#[cfg(test)]` units compile out for free; the only thing to keep out of
794        // the `.crate` source tarball is the crate-root integration `tests/` dir.
795        colocated_test::Language::Rust => vec!["tests/".to_string()],
796    };
797    let offenders = packaging::inspect(artifact, &globs)?;
798    if offenders.is_empty() {
799        return Ok(0);
800    }
801    for offender in &offenders {
802        eprintln!("test file in built artifact: {}", offender.display());
803    }
804    eprintln!(
805        "error: {} test file(s) present in the built artifact \
806         (they must be excluded from packaging)",
807        offenders.len()
808    );
809    Ok(1)
810}
811
812/// Run the workflow guard over `path` (a workflow file or directory): flag every
813/// `testing-conventions` invocation that names a subcommand this binary no longer
814/// exposes, printing each as `path:line: rule — message` and returning `1` when any
815/// are found, `0` otherwise.
816fn run_workflow(path: &Path) -> anyhow::Result<i32> {
817    let violations = workflow::check(path, &command())?;
818    if violations.is_empty() {
819        return Ok(0);
820    }
821    for v in &violations {
822        eprintln!(
823            "{}:{}: {} — {}",
824            v.file.display(),
825            v.line,
826            v.rule,
827            v.message
828        );
829    }
830    eprintln!(
831        "error: {} workflow invocation(s) name a subcommand this binary no longer exposes",
832        violations.len()
833    );
834    Ok(1)
835}
836
837/// Run `command` as an e2e suite and write a committed attestation naming the
838/// current commit (#67). Force-runs: the attestation is written regardless of
839/// the command's exit code, so this exits `0` once the attestation is recorded.
840fn run_e2e_attest(command: &str) -> anyhow::Result<i32> {
841    let repo = std::env::current_dir()?;
842    let attestation = e2e::attest(&repo, command)?;
843    println!(
844        "e2e attestation recorded for commit {} (command exited {})",
845        attestation.commit, attestation.exit_code
846    );
847    Ok(0)
848}
849
850/// Verify the committed e2e attestation names the latest code commit (#68) — the
851/// CI side of the nudge. Exits `0` when fresh; otherwise prints the actionable
852/// hint and exits `1`. Never runs e2e, never judges the recorded run.
853fn run_e2e_verify() -> anyhow::Result<i32> {
854    let repo = std::env::current_dir()?;
855    match e2e::verify(&repo)? {
856        e2e::Verification::Fresh => Ok(0),
857        e2e::Verification::Missing => {
858            eprintln!(
859                "e2e attestation missing — run `testing-conventions e2e attest '<your e2e command>'`"
860            );
861            Ok(1)
862        }
863        e2e::Verification::Stale { attested, latest } => {
864            eprintln!(
865                "e2e attestation out of date: attested {}, latest code commit {} — \
866                 run `testing-conventions e2e attest '<your e2e command>'`",
867                &attested[..attested.len().min(7)],
868                &latest[..latest.len().min(7)]
869            );
870            Ok(1)
871        }
872    }
873}
874
875#[cfg(test)]
876mod tests {
877    use super::*;
878
879    #[test]
880    fn no_args_returns_ok_zero() {
881        assert_eq!(run(["testing-conventions"]).unwrap(), 0);
882    }
883
884    #[test]
885    fn check_returns_ok_zero() {
886        assert_eq!(run(["testing-conventions", "check"]).unwrap(), 0);
887    }
888
889    #[test]
890    fn unknown_flag_errors() {
891        assert!(run(["testing-conventions", "--bogus"]).is_err());
892    }
893
894    #[test]
895    fn help_flag_returns_clap_display_help() {
896        let err = run(["testing-conventions", "--help"]).expect_err("--help should bubble");
897        let clap_err = err
898            .downcast_ref::<clap::Error>()
899            .expect("error should be a clap::Error");
900        assert_eq!(clap_err.kind(), clap::error::ErrorKind::DisplayHelp);
901    }
902
903    #[test]
904    fn version_flag_returns_clap_display_version() {
905        let err = run(["testing-conventions", "--version"]).expect_err("--version should bubble");
906        let clap_err = err
907            .downcast_ref::<clap::Error>()
908            .expect("error should be a clap::Error");
909        assert_eq!(clap_err.kind(), clap::error::ErrorKind::DisplayVersion);
910    }
911}