systemprompt_runtime/startup_validation/
mcp_validator.rs

1//! MCP deployment manifest validation folded into the startup report.
2//!
3//! Copyright (c) systemprompt.io — Business Source License 1.1.
4//! See <https://systemprompt.io> for licensing details.
5
6use std::path::Path;
7use systemprompt_loader::ExtensionRegistry as McpExtensionRegistry;
8use systemprompt_models::mcp::McpServerType;
9use systemprompt_models::{Config, ServicesConfig};
10use systemprompt_traits::validation_report::ValidationError;
11use systemprompt_traits::{StartupValidationReport, ValidationReport};
12
13pub(super) fn validate_mcp_manifests(
14    config: &Config,
15    services_config: &ServicesConfig,
16    report: &mut StartupValidationReport,
17) {
18    let registry = McpExtensionRegistry::build(
19        Path::new(&config.system_path),
20        config.is_cloud,
21        &config.bin_path,
22    );
23
24    let mcp_errors = collect_manifest_errors(services_config, config.is_cloud, |binary| {
25        registry
26            .get_path(binary)
27            .map(|_| ())
28            .map_err(|e| e.to_string())
29    });
30
31    merge_mcp_errors(report, mcp_errors);
32}
33
34pub fn collect_manifest_errors<F>(
35    services_config: &ServicesConfig,
36    is_cloud: bool,
37    resolve: F,
38) -> Vec<ValidationError>
39where
40    F: Fn(&str) -> Result<(), String>,
41{
42    let mut mcp_errors: Vec<ValidationError> = Vec::new();
43
44    for (name, deployment) in &services_config.mcp_servers {
45        if !deployment.enabled {
46            continue;
47        }
48        if deployment.dev_only && is_cloud {
49            continue;
50        }
51        if !matches!(deployment.server_type, McpServerType::Internal) {
52            continue;
53        }
54
55        if let Err(e) = resolve(&deployment.binary) {
56            mcp_errors.push(
57                ValidationError::new(
58                    format!("mcp_servers.{}.binary", name),
59                    format!(
60                        "Manifest not found for binary '{}': {}",
61                        deployment.binary, e
62                    ),
63                )
64                .with_suggestion(format!(
65                    "Ensure manifest.yaml exists at extensions/mcp/{}/manifest.yaml",
66                    deployment.binary
67                )),
68            );
69        }
70    }
71
72    mcp_errors
73}
74
75pub fn merge_mcp_errors(report: &mut StartupValidationReport, mcp_errors: Vec<ValidationError>) {
76    if mcp_errors.is_empty() {
77        return;
78    }
79
80    if let Some(mcp_report) = report.domains.iter_mut().find(|d| d.domain == "mcp") {
81        for error in mcp_errors {
82            mcp_report.add_error(error);
83        }
84    } else {
85        let mut mcp_report = ValidationReport::new("mcp");
86        for error in mcp_errors {
87            mcp_report.add_error(error);
88        }
89        report.add_domain(mcp_report);
90    }
91}
systemprompt_runtime/startup_validation/mcp_validator.rs

systemprompt_runtime/startup_validation/
mcp_validator.rs
