Skip to main content

synth_backend/
arm_backend.rs

1//! ARM Backend — wraps the instruction selector + optimizer + encoder as a Backend
2//!
3//! This is Synth's custom ARM compiler targeting Cortex-M (Thumb-2).
4//! It's the only backend that supports per-rule formal verification (ASIL D path).
5
6use crate::ArmEncoder;
7use synth_core::backend::{
8    Backend, BackendCapabilities, BackendError, CodeRelocation, CompilationResult, CompileConfig,
9    CompiledFunction, LineMap, SafetyBounds,
10};
11use synth_core::target::{IsaVariant, TargetSpec};
12use synth_core::wasm_decoder::DecodedModule;
13use synth_core::wasm_op::WasmOp;
14use synth_synthesis::{
15    ArmInstruction, ArmOp, BoundsCheckConfig, InstructionSelector, OptimizationConfig,
16    OptimizerBridge, RuleDatabase, validate_instructions,
17};
18
19/// ARM Cortex-M backend using Synth's custom compiler pipeline
20pub struct ArmBackend;
21
22impl ArmBackend {
23    pub fn new() -> Self {
24        Self
25    }
26}
27
28impl Default for ArmBackend {
29    fn default() -> Self {
30        Self::new()
31    }
32}
33
34impl Backend for ArmBackend {
35    fn name(&self) -> &str {
36        "arm"
37    }
38
39    fn capabilities(&self) -> BackendCapabilities {
40        BackendCapabilities {
41            produces_elf: false,
42            supports_rule_verification: true,
43            supports_binary_verification: true,
44            is_external: false,
45        }
46    }
47
48    fn supported_targets(&self) -> Vec<TargetSpec> {
49        vec![
50            TargetSpec::cortex_m3(),
51            TargetSpec::cortex_m4(),
52            TargetSpec::cortex_m4f(),
53            TargetSpec::cortex_m7(),
54            TargetSpec::cortex_m7dp(),
55        ]
56    }
57
58    fn compile_module(
59        &self,
60        module: &DecodedModule,
61        config: &CompileConfig,
62    ) -> Result<CompilationResult, BackendError> {
63        let exports: Vec<_> = module
64            .functions
65            .iter()
66            .filter(|f| f.export_name.is_some())
67            .collect();
68
69        if exports.is_empty() {
70            return Err(BackendError::CompilationFailed(
71                "no exported functions found".into(),
72            ));
73        }
74
75        let mut functions = Vec::new();
76        for func in &exports {
77            let name = func.export_name.clone().unwrap();
78            // #359: copy THIS function's declared param widths into the config so
79            // `compile_function` (which carries no function index) can refuse a
80            // 64-bit param on the AAPCS stack-argument path. Cheap clone only when
81            // a signature table is present and this function has a width entry —
82            // otherwise reuse the shared config (every existing module unchanged).
83            // #509: same per-function pattern for the blocktype-arity side-table
84            // (value-carrying-branch lowering).
85            let params = config
86                .func_params_i64
87                .get(func.index as usize)
88                .filter(|p| !p.is_empty());
89            // #457: THIS function's DECLARED param count (imports-first full
90            // index), so the backend can cap the access-pattern inference that
91            // mistook a read-before-write local for a param. `None` when the
92            // driver supplied no arg-count table (hand-built modules).
93            let declared_params = config.func_arg_counts.get(func.index as usize).copied();
94            let func_config =
95                if params.is_some() || !func.block_arity.is_empty() || declared_params.is_some() {
96                    Some(CompileConfig {
97                        current_func_params_i64: params.cloned().unwrap_or_default(),
98                        current_func_block_arity: func.block_arity.clone(),
99                        current_func_param_count: declared_params,
100                        ..config.clone()
101                    })
102                } else {
103                    None
104                };
105            let cfg = func_config.as_ref().unwrap_or(config);
106            let compiled = self.compile_function(&name, &func.ops, cfg)?;
107            functions.push(compiled);
108        }
109
110        Ok(CompilationResult {
111            functions,
112            elf: None,
113            backend_name: self.name().to_string(),
114        })
115    }
116
117    fn compile_function(
118        &self,
119        name: &str,
120        ops: &[WasmOp],
121        config: &CompileConfig,
122    ) -> Result<CompiledFunction, BackendError> {
123        let (code, relocations, line_map) =
124            compile_wasm_to_arm(ops, config).map_err(BackendError::CompilationFailed)?;
125
126        Ok(CompiledFunction {
127            name: name.to_string(),
128            code,
129            wasm_ops: ops.to_vec(),
130            relocations,
131            line_map,
132        })
133    }
134
135    fn is_available(&self) -> bool {
136        true // Always available — it's a library backend
137    }
138}
139
140/// Count the number of function parameters by analyzing LocalGet patterns
141fn count_params(wasm_ops: &[WasmOp]) -> u32 {
142    let mut first_access: std::collections::HashMap<u32, bool> = std::collections::HashMap::new();
143    for op in wasm_ops {
144        match op {
145            WasmOp::LocalGet(idx) => {
146                first_access.entry(*idx).or_insert(true);
147            }
148            WasmOp::LocalSet(idx) | WasmOp::LocalTee(idx) => {
149                first_access.entry(*idx).or_insert(false);
150            }
151            _ => {}
152        }
153    }
154
155    first_access
156        .iter()
157        .filter_map(
158            |(&idx, &is_read_first)| {
159                if is_read_first { Some(idx + 1) } else { None }
160            },
161        )
162        .max()
163        .unwrap_or(0)
164}
165
166/// #539: fold the `i32.const 0; memory.grow m` idiom to `memory.size m`.
167/// `memory.grow(0)` always succeeds and returns the current page count (WASM
168/// Core §4.4.7), which is exactly `memory.size`; the fixed-memory backend
169/// otherwise emits a constant `-1` for every `memory.grow`, so the legal
170/// `memory.grow(0)` "read/validate current size" idiom wrongly reported failure.
171/// Only the ADJACENT const-0 delta is folded (a non-zero delta keeps the sound
172/// `-1` — fixed memory genuinely cannot grow; a runtime-computed 0 is a
173/// documented follow-up). Backend- and path-agnostic: `memory.size` reads the
174/// runtime memory-size register on every selector, so this fixes the optimized
175/// and direct paths at once.
176fn rewrite_memory_grow_zero(wasm_ops: &[WasmOp]) -> Vec<WasmOp> {
177    let mut out = Vec::with_capacity(wasm_ops.len());
178    let mut i = 0;
179    while i < wasm_ops.len() {
180        if matches!(wasm_ops[i], WasmOp::I32Const(0))
181            && let Some(WasmOp::MemoryGrow(m)) = wasm_ops.get(i + 1)
182        {
183            out.push(WasmOp::MemorySize(*m));
184            i += 2;
185        } else {
186            out.push(wasm_ops[i].clone());
187            i += 1;
188        }
189    }
190    out
191}
192
193/// #509: does the op stream contain a `br`/`br_if`/`br_table` that CARRIES a
194/// value — i.e. one targeting a result-typed block/if (forward edge with
195/// results > 0) or a parameterized loop header (backward edge with loop
196/// params > 0)?
197///
198/// The optimized path's wasm→IR lowering drops the carried value on such
199/// edges (the taken arm returns the fall-through result — same class as the
200/// #507 `br_table` drop, observed on `pick_br`/`pick_br_fall`), so — like
201/// #507 — the shape is detected on the raw op stream and routed to the direct
202/// selector, whose #509 designated-result-register lowering lands the value
203/// correctly. `block_arity` is the decoder's ordinal blocktype-arity
204/// side-table; when it is empty (hand-built op streams) every block reads as
205/// void and this never fires, keeping the optimized path byte-identical for
206/// every existing caller. Frozen-safe for the same reason as #507: the frozen
207/// fixtures compile `--relocatable` (already direct), and no optimized-path
208/// fixture branches to a result-typed block.
209fn has_value_carrying_branch(wasm_ops: &[WasmOp], block_arity: &[(u8, u8)]) -> bool {
210    // Open control constructs: (is_loop, params, results), innermost last.
211    let mut open: Vec<(bool, u8, u8)> = Vec::new();
212    let mut ctrl_ord = 0usize;
213    // A branch edge carries a value when its target is a result-typed forward
214    // join (block/if) or a parameterized loop header.
215    let carries = |open: &[(bool, u8, u8)], depth: u32| -> bool {
216        let Some(&(is_loop, params, results)) = open
217            .len()
218            .checked_sub(1 + depth as usize)
219            .and_then(|i| open.get(i))
220        else {
221            return false; // function-level target — handled by Return lowering
222        };
223        if is_loop { params > 0 } else { results > 0 }
224    };
225    for op in wasm_ops {
226        match op {
227            WasmOp::Block | WasmOp::If => {
228                let (p, r) = block_arity.get(ctrl_ord).copied().unwrap_or((0, 0));
229                ctrl_ord += 1;
230                open.push((false, p, r));
231            }
232            WasmOp::Loop => {
233                let (p, r) = block_arity.get(ctrl_ord).copied().unwrap_or((0, 0));
234                ctrl_ord += 1;
235                open.push((true, p, r));
236            }
237            WasmOp::End => {
238                open.pop(); // None only at the function-level end — harmless
239            }
240            WasmOp::Br(d) | WasmOp::BrIf(d) if carries(&open, *d) => return true,
241            WasmOp::BrTable { targets, default }
242                if targets
243                    .iter()
244                    .chain(std::iter::once(default))
245                    .any(|d| carries(&open, *d)) =>
246            {
247                return true;
248            }
249            _ => {}
250        }
251    }
252    false
253}
254
255/// Core compilation: WASM ops → ARM machine code bytes + relocations
256///
257/// Returns (code_bytes, relocations) where relocations record BL instructions
258/// that target external symbols (e.g., `__meld_dispatch_import` for import calls).
259fn compile_wasm_to_arm(
260    wasm_ops: &[WasmOp],
261    config: &CompileConfig,
262) -> Result<(Vec<u8>, Vec<CodeRelocation>, LineMap), String> {
263    // #539: `memory.grow(0)` must return the CURRENT page count, not the
264    // fixed-memory `-1` sentinel — growing by zero pages can never fail (WASM
265    // Core §4.4.7), so a guest doing `if (memory.grow(0) < 0) trap;` wrongly
266    // faulted. Every lowering path emitted a delta-agnostic `-1`. `memory.grow(0)`
267    // is semantically identical to `memory.size`, which the backend already
268    // computes from the runtime memory-size register (R10 >> 16 = pages), so fold
269    // the `i32.const 0; memory.grow` idiom to `memory.size` up front — backend-
270    // and path-agnostic. A non-zero delta keeps `-1` (fixed memory genuinely
271    // cannot grow); a runtime delta that happens to be 0 is the documented
272    // follow-up.
273    let rewritten = rewrite_memory_grow_zero(wasm_ops);
274    // #494 phase 2b: the fact-spec guard-elision marks are keyed by op index
275    // into the stream the DRIVER handed us. The memory.grow(0) fold above can
276    // only shift indices AT OR AFTER a `memory.grow` — an op the fact-spec
277    // walk never crosses (it stops at the first untracked op, so no mark can
278    // follow one). Defense in depth: if the fold fired at all, drop the marks
279    // loudly rather than risk keying a guard elision to the wrong op.
280    let (fact_div_zero_elide, fact_div_ovf_elide): (&[usize], &[usize]) = if rewritten.len()
281        == wasm_ops.len()
282    {
283        (&config.fact_div_zero_elide, &config.fact_div_ovf_elide)
284    } else {
285        if !config.fact_div_zero_elide.is_empty() || !config.fact_div_ovf_elide.is_empty() {
286            eprintln!(
287                "fact-spec: DECLINE div-guard elision marks dropped — the                      memory.grow(0) fold shifted op indices (#494 defensive gate);                      general lowering emitted"
288            );
289        }
290        (&[], &[])
291    };
292    let wasm_ops: &[WasmOp] = &rewritten;
293
294    // #457: `count_params` INFERS the param count from access patterns (a local
295    // whose first access is a read is assumed to be a param), so a
296    // read-before-write NON-PARAM local — which WASM zero-initializes — was
297    // indistinguishable from a param: it got homed in a parameter register and
298    // read caller garbage instead of 0. When the driver supplied the DECLARED
299    // count (`current_func_param_count`, from the module's type section), cap
300    // the inference with it. `min` (not a plain override) keeps every function
301    // whose inference is <= declared byte-identical: the inferred count can only
302    // EXCEED the declared one via a read-first local index >= the declared count
303    // — i.e. exactly the read-before-write locals this issue is about.
304    let inferred_params = count_params(wasm_ops);
305    let num_params = match config.current_func_param_count {
306        Some(declared) => inferred_params.min(declared),
307        None => inferred_params,
308    };
309    // A read-before-write non-param local exists iff the capped count dropped.
310    // Such locals need the wasm-mandated zero-init, which only the direct
311    // selector emits — the optimized path's `ir_to_arm` maps a non-param
312    // local's vreg onto an r4+ temp with no initialization (caller garbage).
313    let has_rbw_local = num_params < inferred_params;
314
315    let bounds_config = match config.effective_safety_bounds() {
316        SafetyBounds::None => BoundsCheckConfig::None,
317        SafetyBounds::Mpu => BoundsCheckConfig::Mpu,
318        SafetyBounds::Software => BoundsCheckConfig::Software,
319        SafetyBounds::Mask => {
320            // #651 (mirroring the RISC-V backend's compile-time decline):
321            // index masking wraps `ea & (size-1)` — a modulo only when the
322            // linear-memory size is a power of two. With a non-power-of-two
323            // size the AND would silently REMAP in-bounds addresses (e.g.
324            // 0x18000 & 0x2FFFF = 0x8000 for a 192 KiB memory). Decline
325            // loudly rather than miscompile. `linear_memory_bytes == 0`
326            // means "unknown" (plain per-function path, no module context)
327            // — the startup default of one 64 KiB page is a power of two.
328            let bytes = config.linear_memory_bytes;
329            if bytes != 0 && !bytes.is_power_of_two() {
330                return Err(format!(
331                    "--safety-bounds mask requires a power-of-two linear-memory \
332                     size, got {bytes} bytes — switch to --safety-bounds software \
333                     for the deterministic check (#651)"
334                ));
335            }
336            BoundsCheckConfig::Masking
337        }
338    };
339
340    // The non-optimized (direct) instruction-selection path. Handles f32 via
341    // VFP/FPU. Used directly when `--no-optimize` is set, and as the fallback
342    // when the optimized path declines a module (see issue #120 below).
343    //
344    // VCR-RA-001 step 3b-lite (#242): a FRESH selector per attempt, with
345    // `spill_on_exhaustion` set only on the retry — the first pass is the
346    // unmodified default, so every function that compiles today is selected by
347    // exactly the code that compiled it yesterday (bit-identity is structural,
348    // not behavioural).
349    let select_direct_attempt = |spill_on_exhaustion: bool,
350                                 param_backing_on_exhaustion: bool,
351                                 local_promote: bool,
352                                 i64_spill_slots: Option<usize>|
353     -> Result<Vec<ArmInstruction>, synth_core::Error> {
354        let db = RuleDatabase::with_standard_rules();
355        let mut selector =
356            InstructionSelector::with_bounds_check(db.rules().to_vec(), bounds_config);
357        selector.set_target(config.target.fpu, &config.target.triple);
358        if config.num_imports > 0 {
359            selector.set_num_imports(config.num_imports);
360        }
361        // #195: plumb the callee argument-count tables so the direct selector can
362        // marshal call arguments into R0–R3 per AAPCS.
363        selector.set_func_arg_counts(
364            config.func_arg_counts.clone(),
365            config.type_arg_counts.clone(),
366        );
367        // #197: in relocatable host-link mode, emit direct `func_N` BLs for
368        // imports (rewritten to the wasm field name by build_relocatable_elf)
369        // instead of `__meld_dispatch_import`.
370        selector.set_relocatable(config.relocatable);
371        // #642: call_indirect guard inputs (compile-time table size for the
372        // bounds guard + closed-world type verdicts). Without them, every
373        // call_indirect lowering declines loudly.
374        selector.set_call_indirect_guards(config.call_indirect_guards.clone());
375        // #237: native-pointer ABI — wasm statics become __synth_wasm_data-relative.
376        selector.set_native_pointer_abi(config.native_pointer_abi, config.linear_memory_bytes);
377        // #311: i64 call results are register PAIRS — tag them.
378        selector.set_result_types(config.func_ret_i64.clone(), config.type_ret_i64.clone());
379        // #359: declared param widths of THIS function, so the AAPCS stack-arg
380        // path can refuse 64-bit params (Ok-or-Err). Empty ⇒ assume i32.
381        selector.set_params_i64(config.current_func_params_i64.clone());
382        // #509: blocktype-arity side-table of THIS function, so value-carrying
383        // br/br_if/br_table land the carried value in the target block's
384        // designated result register instead of dropping it. Empty ⇒ legacy
385        // void-block lowering.
386        selector.set_block_arity(config.current_func_block_arity.clone());
387        // Stack-pointer promotion is meaningful only under the native-pointer ABI;
388        // gating here keeps every non-native compile (all frozen fixtures) on the
389        // legacy R9 globals-table path, bit-identical.
390        if config.native_pointer_abi
391            && let Some((sp_idx, sp_init)) = config.stack_pointer_global
392        {
393            selector.set_native_pointer_stack(sp_idx, sp_init);
394        }
395        // #643: per-global slot widths — i64/f64 globals occupy 8-byte slots
396        // (register-pair store/load) and shift every later global's offset.
397        // Empty for i32-only modules ⇒ the legacy `idx * 4` layout, unchanged.
398        selector.set_global_widths(config.global_widths.clone());
399        selector.set_spill_on_exhaustion(spill_on_exhaustion);
400        selector.set_param_backing_on_exhaustion(param_backing_on_exhaustion);
401        // #587 pool-grow rung: a larger i64 spill-slot pool, set ONLY on the
402        // retry after an attempt failed with the slot-pool-exhausted Err —
403        // functions that compile with the default pool keep their frame
404        // byte-identical by construction.
405        if let Some(slots) = i64_spill_slots {
406            selector.set_i64_spill_slots(slots);
407        }
408        // VCR-RA local promotion (#390, #242): keep eligible non-param i32 locals
409        // in callee-saved registers instead of frame slots — the structural lever
410        // toward native parity. DEFAULT-ON as of v0.14.0: gale's G474RE DWT gate
411        // cleared it as a net win (gust_mix dissolved 58→50 cyc/call −14%, all 5
412        // stack spill/reloads eliminated, correctness bit-identical over [0,2047],
413        // 2.00×→1.72× vs LLVM). Escape hatch: `SYNTH_NO_LOCAL_PROMOTE=1` restores
414        // the frame-slot path. Leaf-only / i32-only / ARM-only (see
415        // compute_local_promotion); the leaf-only lift + i64 locals are follow-ons.
416        // #474: `local_promote` is now a per-attempt parameter so the retry ladder
417        // can drop promotion as an exhaustion-recovery rung (promotion pins r4-r8,
418        // which on a dense function leaves the spill allocator with nothing to
419        // free → the frame-slot path is the escape that restores compilability).
420        selector.set_local_promote(local_promote);
421        // #494 phase 2b: certificate-discharged div/rem trap-guard elision
422        // marks (empty in every compile without SYNTH_FACT_SPEC + facts).
423        selector
424            .set_fact_div_guard_elisions(fact_div_zero_elide.to_vec(), fact_div_ovf_elide.to_vec());
425        selector.select_with_stack(wasm_ops, num_params)
426    };
427    let select_direct = || -> Result<Vec<ArmInstruction>, String> {
428        const SINGLE_EXHAUSTION: &str = "all allocatable registers are live on the stack";
429        const PAIR_EXHAUSTION: &str = "no consecutive pair of free registers for i64";
430        const SLOT_EXHAUSTION: &str = "i64 spill-slot pool exhausted";
431        // The full exhaustion-recovery ladder, parameterized on whether local
432        // promotion is enabled. Each rung is reached only when the previous one
433        // returned a recoverable register-exhaustion Err, so a function that
434        // compiles on the first attempt is untouched by the later rungs. Returns
435        // the result AND which rung produced it (for the #242 measurement below).
436        let recovery_ladder =
437            |promote: bool,
438             i64_spill_slots: Option<usize>|
439             -> (Result<Vec<ArmInstruction>, synth_core::Error>, &'static str) {
440                let mut attempt = select_direct_attempt(false, false, promote, i64_spill_slots);
441                let mut rung = "base";
442                // VCR-RA-001 step 3b-lite (#242): the i32 register-exhaustion
443                // hard-fail is recoverable — retry with spill-on-exhaustion, which
444                // reserves the spill area and spills the deepest stack value when
445                // the pool is full.
446                if let Err(e) = &attempt
447                    && e.to_string().contains(SINGLE_EXHAUSTION)
448                {
449                    attempt = select_direct_attempt(true, false, promote, i64_spill_slots);
450                    rung = "spill";
451                }
452                // VCR-RA-001 acceptance increment (#242): the i64 consecutive-PAIR
453                // exhaustion is recoverable too — not by stack spilling (the pair
454                // allocator already spills stack values, #171) but by frame-backing
455                // the params (#204) so they stop pinning R0-R3, with spill kept on.
456                if let Err(e) = &attempt
457                    && e.to_string().contains(PAIR_EXHAUSTION)
458                {
459                    attempt = select_direct_attempt(true, true, promote, i64_spill_slots);
460                    rung = "param-backing";
461                }
462                (attempt, rung)
463            };
464        // #474: local promotion (default-on since v0.14.0) is an OPTIMIZATION — it
465        // must never be the reason a function fails to compile. Run the full ladder
466        // with promotion first (so every function that compiles today is
467        // bit-identical), and if it still ends in register exhaustion, fall back to
468        // the promotion-off ladder (the v0.12.0 frame-slot lowering — exactly what
469        // the `SYNTH_NO_LOCAL_PROMOTE=1` workaround does, now automatic). Promotion
470        // pins r4-r8 for the locals; on a dense function that leaves the allocator
471        // with nothing to free, so dropping it restores compilability. The fallback
472        // is reached ONLY by functions that exhaust WITH promotion, so promotion-on
473        // output is untouched by construction (frozen byte gate stays green).
474        let promote = std::env::var("SYNTH_NO_LOCAL_PROMOTE").is_err();
475        // The full pre-#587 recovery sequence (promotion-on ladder, then the
476        // #474 promotion-off fallback), parameterized on the pool size so the
477        // pool-grow retry below reruns it verbatim.
478        let full_sequence = |slots: Option<usize>| -> (
479            Result<Vec<ArmInstruction>, synth_core::Error>,
480            &'static str,
481            bool,
482        ) {
483            let (mut attempt, mut rung) = recovery_ladder(promote, slots);
484            let mut promotion_dropped = false;
485            if promote
486                && attempt
487                    .as_ref()
488                    .err()
489                    .is_some_and(|e| e.to_string().contains("register exhaustion"))
490            {
491                let (rescued, off_rung) = recovery_ladder(false, slots);
492                if rescued.is_ok() {
493                    attempt = rescued;
494                    rung = off_rung;
495                    promotion_dropped = true;
496                }
497            }
498            (attempt, rung, promotion_dropped)
499        };
500        let (mut attempt, mut rung, mut promotion_dropped) = full_sequence(None);
501        // #587 pool-grow retry (the falcon func_60/func_73 remainder): the fixed
502        // 8-slot i64 spill pool can exhaust while spilling is otherwise working —
503        // an i64-dense function simply has more values simultaneously live than
504        // the pool holds. Rerun the ENTIRE sequence (every rung, both promotion
505        // modes) with the pool sized from a conservative operand-stack-depth
506        // bound: the number of simultaneously spilled values can never exceed
507        // the operand-stack depth, plus a few transient slots (the arg-move
508        // cycle resolver and call-result parking each borrow one). The selector
509        // clamps the request to its 12-bit-friendly cap; a function that still
510        // exhausts stays an honest loud skip. Deliberately LAST — after the #474
511        // promotion-off fallback — so any function that compiled yesterday
512        // (through any rung or fallback) is produced by exactly yesterday's
513        // path, byte-identical; the grown pool only ever fires for functions
514        // whose every existing escape ended in the slot-pool Err.
515        if attempt
516            .as_ref()
517            .err()
518            .is_some_and(|e| e.to_string().contains(SLOT_EXHAUSTION))
519        {
520            let depth = synth_core::wasm_stack_check::max_depth_bound(wasm_ops) as usize;
521            let (grown, _, grown_dropped) = full_sequence(Some(depth.saturating_add(4)));
522            if grown.is_ok() {
523                attempt = grown;
524                rung = "pool-grow";
525                promotion_dropped = grown_dropped;
526            }
527        }
528        // VCR-RA measurement (#242): log which recovery rung produced the result,
529        // so the per-rung distribution across a corpus can be measured — the size
530        // of the failure surface a verified allocator must subsume (see
531        // scripts/repro/register_exhaustion_recovery_ladder.md). Logging only:
532        // emitted bytes are unchanged, so the frozen byte gate is unaffected.
533        if std::env::var("SYNTH_RECOVERY_STATS").is_ok() {
534            eprintln!(
535                "[recovery-stats] rung={rung}{} result={}",
536                if promotion_dropped {
537                    " promotion-off"
538                } else {
539                    ""
540                },
541                if attempt.is_ok() { "ok" } else { "exhausted" },
542            );
543        }
544        attempt.map_err(|e| format!("instruction selection failed: {}", e))
545    };
546
547    // Instruction selection: optimized or direct.
548    //
549    // #197: `--relocatable` (host-link ET_REL) forces the direct selector. The
550    // optimized path materializes an absolute linmem base (0x20000100) and does
551    // not preserve caller-saved registers across calls — both wrong for a
552    // host-linked object, where the linmem base arrives via `fp` at runtime and
553    // callees follow AAPCS. `select_with_stack` (now i64-spill capable after
554    // #171) handles fp-relative memory + caller-saved preservation correctly.
555    //
556    // #507: `br_table` is DROPPED during the optimized path's wasm→IR lowering
557    // (`optimize_full`), so `ir_to_arm` never sees the dispatch — it emits the
558    // arm bodies in fall-through sequence with no `cmp`/branch on the selector, a
559    // SILENT miscompile (every input hits the last arm). The selector value isn't
560    // even loaded. Because the drop happens before `ir_to_arm`, there's no `Err`
561    // to fall back on; detect it on the raw wasm op stream here and force the
562    // direct selector (`select_with_stack` lowers `br_table` correctly as a
563    // cmp-chain — confirmed on the `--relocatable` path). Same honest-degradation
564    // contract as the issue-#120 f32 decline: the function still compiles
565    // correctly, just without IR-level optimization. Frozen-safe: the frozen
566    // fixtures compile `--relocatable` (already direct), and no optimized-path
567    // fixture (control_step, flight_algo) contains `br_table`.
568    let has_br_table = wasm_ops
569        .iter()
570        .any(|op| matches!(op, WasmOp::BrTable { .. }));
571    // #509: the optimized path also drops the value carried by a `br`/`br_if`
572    // to a result-typed block (the taken edge returns the wrong arm's value —
573    // same silent-miscompile class as the #507 br_table drop). Route the shape
574    // to the direct selector, whose designated-result-register lowering (#509)
575    // lands the carried value at the join. Never fires for void-block control
576    // flow (all frozen/optimized fixtures), so those stay byte-identical.
577    let has_value_carry = has_value_carrying_branch(wasm_ops, &config.current_func_block_arity);
578    // #503-i64/#518: route any signature with a 64-bit (i64/f64) param to the
579    // direct selector. The optimized path's param homing is width-naive — its
580    // #518 decline covers only functions that READ an i64 param (an `I64Load`
581    // from a param index), so a function that reads an i32 param whose AAPCS
582    // home a preceding wide param SHIFTED (e.g. p1 of `(i64 i32)` lives in R2,
583    // not R1; p3 of `(i64 i32 i32 i32)` lives on the stack, not in R3) was
584    // silently miscompiled rather than falling back. The direct selector's
585    // `aapcs_param_layout` homing handles every such shape (i64-param READS
586    // already fell back to it via the ir_to_arm Err, so those functions emit
587    // the same bytes as before). `num_params` counts read-first locals, so a
588    // function that never touches any param keeps the optimized path.
589    let has_wide_param = config
590        .current_func_params_i64
591        .iter()
592        .take(num_params as usize)
593        .any(|&w| w);
594    // #494 phase 2b: div/rem guard-elision marks are consumed by the DIRECT
595    // selector only — the optimized path's IR passes (const-fold/CSE/DCE)
596    // renumber instructions, so an op-index-keyed mark cannot soundly survive
597    // them. Route marked functions direct (the #507/#509 honest-degradation
598    // pattern). Never fires without SYNTH_FACT_SPEC + facts + a discharged
599    // obligation, so every existing compile keeps its path byte-identical.
600    let has_fact_div_elide = !fact_div_zero_elide.is_empty() || !fact_div_ovf_elide.is_empty();
601    // #643: the optimized path's global lowering is width-naive — `GlobalGet`/
602    // `GlobalSet` are single-word `[R9, idx*4]` accesses, which (a) silently
603    // dropped the high word of every i64 global and (b) mis-address every
604    // global whose offset an earlier wide (i64/f64) slot shifted. When the
605    // module has any wide global, route every global-touching function to the
606    // direct selector, whose type-aware summed layout pairs the access (or
607    // declines loudly). Modules with only 4-byte globals — every existing
608    // fixture — keep the optimized path byte-identical.
609    let has_wide_global_module = config.global_widths.iter().any(|&w| w > 4);
610    let has_global_access = has_wide_global_module
611        && wasm_ops
612            .iter()
613            .any(|op| matches!(op, WasmOp::GlobalGet(_) | WasmOp::GlobalSet(_)));
614    // VCR-VER-001 (#242): `post_exhaust` scopes the post-exhaustion cleanup
615    // extensions to functions whose bytes the #580 spill-on-exhaustion
616    // machinery actually shaped (bridge-reported). Everything else — the
617    // direct path, non-exhausted optimized functions — stays byte-identical
618    // flag-on (the `vcr_ver_001_gate_242` lock's contract).
619    let (arm_instrs, post_exhaust) = if config.no_optimize
620        || config.relocatable
621        || has_br_table
622        || has_value_carry
623        || has_wide_param
624        || has_global_access
625        || has_fact_div_elide
626        // #457: route read-before-write non-param locals to the direct
627        // selector, whose prologue zero-init lands the wasm-mandated 0.
628        || has_rbw_local
629    {
630        if std::env::var("SYNTH_PATH_DEBUG").is_ok() {
631            eprintln!("[path-debug] direct (pre-gate)");
632        }
633        (select_direct()?, false)
634    } else {
635        let opt_config = if config.loom_compat {
636            OptimizationConfig::loom_compat()
637        } else {
638            OptimizationConfig::all()
639        };
640
641        let mut bridge = OptimizerBridge::with_config(opt_config);
642        // #188: tell the bridge how many imports there are so it declines only
643        // LOCAL calls (and leaves import calls on the optimized path, keeping
644        // the #173 field-name relocation rewrite intact).
645        bridge.set_num_imports(config.num_imports);
646        // #543 Phase 2: thread the integrator-marked volatile DMA-window ranges
647        // (`--volatile-segment <base>:<len>`) to the bridge's address-caching
648        // levers — base-CSE (#468) excludes any access inside a marked range
649        // from its fold set, and the bridge-level const-CSE declines wholesale
650        // while any range is marked. Empty (the default) ⇒ byte-identical.
651        bridge.set_volatile_segments(config.volatile_segments.clone());
652        // #377: thread `--safety-bounds` to the bridge. Pre-fix the optimized
653        // path ignored it — `software`/`mask` were SILENT NO-OPS on the path
654        // that lowers the bulk of a flight loop's i32 loads/stores (byte-
655        // identical to `none`, while the safety manifest claimed otherwise).
656        // `Software` now emits the inline guard per access; `Masking` declines
657        // memory-accessing functions to the direct selector; `None`/`Mpu` are
658        // byte-identical to before.
659        bridge.set_bounds_check(bounds_config);
660        // #687: thread the absolute linear-memory base the optimized path
661        // materializes. Defaults to 0x2000_0100 (byte-identical);
662        // `--stack-layout=low` shifts it up by the reserved stack size so
663        // const-address accesses follow the moved linear memory.
664        bridge.set_linmem_base(config.linmem_base);
665        // `ir_to_arm` now returns `Result` — an `Err` means the optimized path
666        // hit an unmapped vreg (issue-#93-class). Treat it identically to an
667        // `optimize_full` failure: fall back to the direct selector rather
668        // than propagating, so the function still compiles correctly.
669        match bridge
670            .optimize_full(wasm_ops)
671            .and_then(|(opt_ir, _cfg, _stats)| bridge.ir_to_arm(&opt_ir, num_params as usize))
672        {
673            Ok(arm_ops) => {
674                if std::env::var("SYNTH_PATH_DEBUG").is_ok() {
675                    eprintln!("[path-debug] optimized (ir_to_arm ok)");
676                }
677                (
678                    arm_ops
679                        .into_iter()
680                        .map(|op| ArmInstruction {
681                            op,
682                            source_line: None,
683                        })
684                        .collect(),
685                    bridge.spill_on_exhaust_fired(),
686                )
687            }
688            // Issue #120: the optimized path declines modules it cannot lower
689            // (notably scalar f32/f64 ops — the IR has no float opcodes). Fall
690            // back to the direct instruction selector, which handles f32 via
691            // VFP/FPU. This is honest degradation: the function still compiles
692            // correctly, just without IR-level optimization.
693            Err(e) => {
694                if std::env::var("SYNTH_PATH_DEBUG").is_ok() {
695                    eprintln!("[path-debug] direct (fallback: {e})");
696                }
697                (select_direct()?, false)
698            }
699        }
700    };
701
702    // #257/#277: `mul`+`add`→`mla` fusion is intentionally NOT wired here.
703    // The transform is correct and ready (`synth_synthesis::liveness::fuse_mul_add`,
704    // fully tested), but it is **register-allocation-coupled**: over the current
705    // greedy single-pass selector, folding `mul rM,..; add rD,rM,rX` → `mla`
706    // extends the live ranges of the mul inputs to the mla point, and the added
707    // pressure (extra moves/spills) costs more than the single-cycle MLA saves —
708    // gale measured a +2 cyc on-target REGRESSION (flat_flight 255→257, G474RE)
709    // even though it removes 2 instructions and the seam stays 0x07FDF307. So the
710    // fusion stays unwired until the spill-aware allocator (VCR-RA-001) chooses
711    // registers, at which point it becomes net-positive (per #272's plan and the
712    // wiring design note). Lesson (#277): a register-pressure-affecting transform
713    // needs an on-target/allocator-aware gate, not a byte-count gate, before it
714    // can default on.
715
716    // VCR-RA-001 const-CSE / rematerialization-avoidance (#209): moved to run
717    // LAST, after the immediate-folds — see the apply_const_cse call below
718    // (#242). Earlier it ran here (before range-realloc and the folds), which is
719    // what let it grow gale's --relocatable `gust_mix` 90→92 B (#242 burndown,
720    // 2026-06-26): retargeting a read defeated a *downstream* immediate-fold that
721    // would otherwise have absorbed the constant. Running CSE-last makes those
722    // foldable consts already-folded-and-gone, so CSE only ever touches genuinely
723    // redundant materializations.
724
725    // VCR-RA-001 RANGE RE-ALLOCATION (#209/#242, wiring step 3a) — the first
726    // CONSEQUENTIAL allocator pass: re-colour each maximal straight-line
727    // segment over the R0-R8 pool with value ranges as the allocation unit
728    // (segment inputs + per-register live-outs pinned to their original
729    // registers, reserved R9-R12/SP identity-assigned — each segment is
730    // independently sound, no cross-segment liveness assumed). Renames
731    // registers only: never adds, removes, or reorders instructions, so
732    // labels/branch offsets are unaffected.
733    //
734    // DEFAULT-ON since v0.11.36: gale cleared the gate on-target (G474RE,
735    // #209 2026-06-10) — flag-on output byte-identical to flag-off on
736    // flat_flight/controller/control_step, fires on the filter family with
737    // zero cycle delta and a small size win, all selfchecks green on silicon.
738    // Opt out with `SYNTH_RANGE_REALLOC=0`; per-function stats with
739    // `SYNTH_REALLOC_STATS=1`.
740    //
741    // The companion dead callee-saved-save elimination (gale's "next
742    // consequential lever", same issue comment) then shrinks the prologue
743    // `push {r4-r8,lr}` / epilogue `pop {r4-r8,pc}` to the callee-saved
744    // registers the re-allocated body still touches (leaf-only,
745    // SP-untouched, even-count-padded — see shrink_callee_saved_saves):
746    // ~12 cycles of pure save/restore overhead removed on small leaves.
747    let realloc_on = std::env::var("SYNTH_RANGE_REALLOC").map_or(true, |v| v != "0");
748    let arm_instrs = if realloc_on {
749        use synth_synthesis::rules::Reg;
750        const POOL: [Reg; 9] = [
751            Reg::R0,
752            Reg::R1,
753            Reg::R2,
754            Reg::R3,
755            Reg::R4,
756            Reg::R5,
757            Reg::R6,
758            Reg::R7,
759            Reg::R8,
760        ];
761        // VCR-VER-001 (#242): on a function the spill-on-exhaustion machinery
762        // shaped, the terminal segment gets relaxed live-out pinning (only
763        // R0/R1 are observable past `bx lr` at this pre-prologue position) so
764        // the colourer can lower R4-R8-homed tails into caller-saved R0-R3 —
765        // shrinking the `push {r4-r8,lr}` the #580 exhaustion shapes pay for.
766        // `post_exhaust == false` selects the shipping pass bit for bit.
767        let (out, stats) = synth_synthesis::liveness::reallocate_function_post_exhaust(
768            &arm_instrs,
769            &POOL,
770            post_exhaust,
771        );
772        if std::env::var("SYNTH_REALLOC_STATS").is_ok() {
773            eprintln!(
774                "[range-realloc] {} segments: {} reallocated, {} declined ({} validator-rejected), {} need spill (step 4)",
775                stats.segments,
776                stats.reallocated,
777                stats.declined,
778                stats.validator_rejects,
779                stats.needs_spill
780            );
781        }
782        // VCR-RA-002 (#390, epic #242): eliminate a provably-dead stack frame
783        // (`sub sp,#N`/`add sp,#N` reserved by `compute_local_layout` for locals
784        // that promotion homed in registers, never accessed). Removing it saves
785        // the two instructions AND restores the SP-untouched precondition that
786        // `shrink_callee_saved_saves` requires — so it must run FIRST.
787        // DEFAULT-ON (#242 flag audit flip-wave, #592 audit item): evidence
788        // basis was the 2-path × repro-corpus sweep — 0 functions grow, 58
789        // shrink (flight_seam controller_step 250→242 −8 / filter_step 180→168
790        // −12, native_pointer frame_roundtrip 46→34 −12), locked by the
791        // `dead_frame_elim_no_grow_corpus_242` cargo gate; execution
792        // differentials re-run green on the new default bytes BEFORE the
793        // frozen ARM anchors were re-pinned (leaf_dead_frame, flight_seam,
794        // frame_slot_dce — see the flip PR). Escape hatch:
795        // `SYNTH_DEAD_FRAME_ELIM=0` opts out and restores the pre-flip bytes
796        // (CI-gated in `frozen_codegen_bytes.rs`).
797        let out = if !std::env::var("SYNTH_DEAD_FRAME_ELIM").is_ok_and(|v| v == "0") {
798            synth_synthesis::liveness::elide_dead_frame(&out).unwrap_or(out)
799        } else {
800            out
801        };
802        // #490 (epic #242): the optimized selector uses r4-r8 as scratch /
803        // promoted locals but emits no prologue, silently clobbering a caller's
804        // callee-saved registers. Add the missing `push {r4-r8,lr}` /
805        // `pop {r4-r8,pc}` HERE — on the post-realloc body, where realloc has
806        // lowered low-pressure r4-r8 scratch back to r0-r3, so a save is added
807        // only for registers genuinely clobbered. `shrink_callee_saved_saves`
808        // (next) then trims it to the used set. No-op on the direct path (it
809        // already has its own prologue) and on callee-saved-free leaves.
810        let out = synth_synthesis::liveness::ensure_callee_saved_prologue(&out);
811        synth_synthesis::liveness::shrink_callee_saved_saves(&out).unwrap_or(out)
812    } else {
813        // Range-realloc off (`SYNTH_RANGE_REALLOC=0`): the optimized path still
814        // must preserve the callee-saved registers it clobbers (#490). No shrink
815        // (it is coupled to the realloc lever), so the conservative full save
816        // stays — correct, just not minimised in this debug configuration.
817        synth_synthesis::liveness::ensure_callee_saved_prologue(&arm_instrs)
818    };
819
820    // VCR-RA-001 SHADOW ALLOCATION (#209/#242): run the register allocator on
821    // the selected stream and LOG what it finds — without changing a single
822    // emitted byte. This is the measure-only bridge between the built analysis
823    // layer and the eventual virtual-register wiring: it shows, per real
824    // function, whether the allocator can colour it within the R0–R8 pool and
825    // how much const-CSE / rematerialization headroom exists (#209). Enable with
826    // `SYNTH_SHADOW_ALLOC=1`; off by default and side-effect-free either way.
827    if std::env::var("SYNTH_SHADOW_ALLOC").is_ok() {
828        use synth_synthesis::liveness::{
829            AllocationOutcome, allocate_function, function_peak_pressure,
830        };
831        // R9 globals / R10 mem-size / R11 mem-base / R12 IP-scratch are reserved;
832        // pin them above the 0..9 allocatable pool so the colourer keeps R0–R8.
833        let precolored = std::collections::BTreeMap::from([
834            (synth_synthesis::rules::Reg::R9, 9usize),
835            (synth_synthesis::rules::Reg::R10, 10),
836            (synth_synthesis::rules::Reg::R11, 11),
837            (synth_synthesis::rules::Reg::R12, 12),
838        ]);
839        // True VALUE pressure (one node per value, not per reused physical reg):
840        // a NeedsSpill with peak ≤ 9 is a SPURIOUS physical-register spill — the
841        // function fits once virtually allocated.
842        let peak = function_peak_pressure(&arm_instrs);
843        match allocate_function(&arm_instrs, 9, &precolored) {
844            AllocationOutcome::Allocated {
845                remat_opportunities,
846                coloring,
847            } => eprintln!(
848                "[shadow-alloc] OK: {} pregs coloured within R0-R8 pool, peak value-pressure {}, {} const-CSE/remat opportunities",
849                coloring.len(),
850                peak,
851                remat_opportunities
852            ),
853            AllocationOutcome::NeedsSpill(s) => eprintln!(
854                "[shadow-alloc] physical-graph would spill {:?}, but peak value-pressure is {} (≤9 ⇒ spurious; fits once virtually allocated)",
855                s, peak
856            ),
857            AllocationOutcome::Declined => {
858                eprintln!(
859                    "[shadow-alloc] declined (unmodeled construct — calls/i64/fp/offset-branch)"
860                )
861            }
862        }
863    }
864
865    // VCR-SEL-004 cmp→select → IT-block predication fusion (#242). The selector
866    // lowers a `select` whose condition is a comparison to a *materialize then
867    // re-test* sequence (`cmp a,b; SetCond D,c; cmp D,#0; movne dst,v1; moveq
868    // dst,v2`); this collapses it onto the comparison's own flags — deleting the
869    // `SetCond` and the `cmp D,#0` and retargeting the predicated moves to `c` /
870    // `invert(c)` — yielding the textbook predicated clamp (`cmp a,b; movc dst,v1;
871    // mov{!c} dst,v2`). −2 instructions per fused select. gale #428 measured this
872    // as the #1 hot-path size/cycle lever on the gust_mix clamp chain.
873    //
874    // Run LATE: after range re-allocation (so the dead-D proof sees final register
875    // identities) and before encode. Removal-only + rename-only ⇒ no spill
876    // regression and labels/branch offsets are unaffected. Each fusion is proven
877    // sound (flags reused only when nothing clobbers them in the window; the
878    // boolean deleted only when provably dead) — see `fuse_cmp_select`.
879    //
880    // DEFAULT-ON as of v0.13.0 (#428): cmp→select fusion ships by default. The
881    // byte-changing flip is validated by (a) the unicorn execution oracle that runs
882    // the two-move `mov{invert(c)}` arm (cmp_select_two_move_differential.py), (b)
883    // gale's gale_decider_diff 10,596-case sweep across all 8 verified primitives
884    // (native ≡ flag-off ≡ flag-on = 0x88e73178d232bcf5), and (c) the named-anchor
885    // differentials re-run with fusion ON — control_step still 0x00210A55, flat+
886    // inlined flight_algo still 0x07FDF307 (results preserved; bytes deliberately
887    // changed, re-frozen on this commit). Escape hatch: `SYNTH_NO_CMP_SELECT_FUSE=1`
888    // reverts to the pre-fusion lowering. The on-silicon G474RE DWT no-regression
889    // check is a tracked post-ship follow-up (gale owns it).
890    let arm_instrs = if std::env::var("SYNTH_NO_CMP_SELECT_FUSE").is_err() {
891        // The rewritten stream is identical to `fuse_cmp_select`'s 2-tuple form;
892        // the extra `two_move` count is diagnostic only (the fusion census /
893        // blast-radius datum — #7 made that arm reachable).
894        let (out, fused, two_move) =
895            synth_synthesis::liveness::fuse_cmp_select_with_stats(&arm_instrs);
896        if std::env::var("SYNTH_FUSE_STATS").is_ok() {
897            let in_place = fused - two_move;
898            eprintln!(
899                "[cmp-select-fuse] {fused} select(s) fused to predicated moves \
900                 ({two_move} two-move, {in_place} in-place)"
901            );
902        }
903        out
904    } else {
905        arm_instrs
906    };
907
908    // Perf lever 1 toward native parity (#390): redundant stack-reload elimination.
909    // synth lowers every wasm local to a frame slot, so `local.set; local.get` emits
910    // `str rX,[sp,#N]; … ; ldr rY,[sp,#N]`; when rX still holds the value the reload
911    // (a ~2-cycle M4 load) becomes `mov rY,rX`. Removal-of-a-load + rename only ⇒ no
912    // new instruction form and no label/offset change. DEFAULT-ON (#242 feature
913    // loop): validated bit-identical RESULTS on every frozen anchor (control_step
914    // 0x00210A55 13/13, flat+inlined flight_algo 0x07FDF307) with .text reduced on
915    // the shipped --relocatable path, plus 8 unit tests + the frame_slot_dce
916    // execution differential — the same gated path cmp→select took to default-on in
917    // v0.13.0 (G474RE silicon confirms perf post-ship). Escape hatch:
918    // `SYNTH_NO_STACK_FWD=1` restores the frame-resident bytes (frozen-old goldens).
919    let stack_fwd = std::env::var("SYNTH_NO_STACK_FWD").is_err();
920    let arm_instrs = if stack_fwd {
921        let (out, fwd) = synth_synthesis::liveness::forward_stack_reloads(&arm_instrs);
922        if std::env::var("SYNTH_FUSE_STATS").is_ok() {
923            eprintln!("[stack-fwd] {fwd} stack reload(s) forwarded to register moves");
924        }
925        out
926    } else {
927        arm_instrs
928    };
929
930    // VCR-RA frame-slot DCE (#242): once `forward_stack_reloads` has turned the
931    // reloads of a spill slot into register moves, the `str rX,[sp,#N]` that fed
932    // them is a dead store — its slot is never loaded again. Remove it. Pairs
933    // with (and only pays after) stack-reload forwarding, so it shares the flag.
934    let arm_instrs = if stack_fwd {
935        let (out, n) = synth_synthesis::liveness::eliminate_dead_frame_stores(&arm_instrs);
936        if std::env::var("SYNTH_FUSE_STATS").is_ok() {
937            eprintln!("[frame-slot-dce] {n} dead frame store(s) removed");
938        }
939        out
940    } else {
941        arm_instrs
942    };
943
944    // VCR-RA-001 spill re-choice (#242), two stages behind one flag.
945    // Stage 1 (the #569 spike): slot-value forwarding BETWEEN reloads.
946    // `forward_stack_reloads` (above) forwards only from a spill store's
947    // SOURCE register, so when register pressure clobbers that source its
948    // reloads survive; this stage tracks which registers provably still hold
949    // a frame slot's value (through earlier reloads and reg-reg moves) and
950    // turns reload #2..#n into a 1-cycle `mov` (or deletes it when the target
951    // already holds the value). Stage 2 (the Belady re-choice): where NO
952    // register still holds the value — the genuine-spill case, flat_flight's
953    // peak-11 hot segment — the value was usually evicted while a dead
954    // register existed; the clobbering def(s) are renamed onto a provably-dead
955    // register (`spill_rechoice_segment`) so the value stays resident and the
956    // reload dissolves outright. A dissolved reload can leave the feeding
957    // store dead, so the frame-slot DCE sweep runs once more behind the same
958    // flag. Per-segment commit gates: executable same-value-flow trace
959    // equality, strict shrink, pool-pressure fit, sub-word/unknown-slot
960    // conservatism (see `apply_spill_realloc` / `spill_rechoice_segment`).
961    // Stage 3 (whole-function slot liveness): the segment-local DCE keeps a
962    // store whose slot reaches function end ("reach-end ≠ dead" — it cannot
963    // see other segments); `eliminate_unread_frame_stores` walks the whole
964    // function (labels/branches/loops, SP-displacement tracked) and drops a
965    // store whose slot NO reachable instruction can read — flat_flight's two
966    // surviving stores (#576), completing Belady's 0-load side with a 0-store
967    // side. Same flag: the three stages are one lever, flipped together.
968    // DEFAULT-ON (#242 feature loop, the v0.14.0 local-promotion pattern):
969    // Belady spilling ships by default. Evidence basis for the flip: three
970    // landed flag-off increments (#569 forwarding, #576 Belady re-choice,
971    // #579 whole-fn slot liveness), 40+ functions shrink / 0 grow across the
972    // 68-fixture × 2-path sweep, per-segment executable value-trace equality
973    // guards, and the unicorn-vs-wasmtime execution differentials re-run
974    // green on the new default bytes (flat+inlined flight_algo 0x07FDF307,
975    // const_cse, frame_slot_dce, spill_rung_581, r12_spill_496 — which covers
976    // control_step_decide vs wasmtime; control_step's .text is byte-identical
977    // under the flip) BEFORE the frozen goldens were re-pinned. Escape hatch:
978    // `SYNTH_SPILL_REALLOC=0` is the OPT-OUT — it disables all three stages
979    // and restores the pre-flip bytes (CI-gated by
980    // `frozen_fixtures_spill_realloc_escape_hatch_restores_old_bytes`). Any
981    // other value (or unset) runs the pass.
982    // VCR-VER-001 post-exhaustion extensions (#242, the PR #659 verdict): with
983    // `SYNTH_SPILL_ON_EXHAUST` active the #580 allocation-time Belady spill
984    // keeps exhausted functions on the optimized path, and its slots present
985    // shapes the shipping pass structurally cannot fire on (fresh-monotonic
986    // slots defeat the overwrite-only DCE; the eviction store's source is
987    // redefined immediately, defeating store→reload forwarding; R2/R3 are
988    // never touched again, so the rename-target deadness proof declines them).
989    // `post_exhaust` (bridge-scoped, see above) enables const
990    // rematerialization of spilled constants, R2/R3 exit-dead rename targets,
991    // and per-pair pressure commit — see `apply_spill_realloc_post_exhaust`.
992    // Flag off (the default): `false` selects the shipping behavior bit for
993    // bit.
994    let arm_instrs = if !std::env::var("SYNTH_SPILL_REALLOC").is_ok_and(|v| v == "0") {
995        let (out, n) =
996            synth_synthesis::liveness::apply_spill_realloc_post_exhaust(&arm_instrs, post_exhaust);
997        let (out, d) = synth_synthesis::liveness::eliminate_dead_frame_stores(&out);
998        let (mut out, u) = synth_synthesis::liveness::eliminate_unread_frame_stores(&out);
999        let (mut tn, mut td, mut tu) = (n, d, u);
1000        // Post-exhaustion only: iterate the triple to a bounded fixpoint. Each
1001        // dissolved spill pair frees registers and removes stores, exposing
1002        // rename windows and holder chains the previous iteration could not
1003        // prove — the allocation-time Belady slots (#580) routinely need two
1004        // or three rounds where the shipping single round suffices for the
1005        // default path's slots. Every iteration is individually gate-proven
1006        // (value-trace equality, pool pressure, strict shrink), so iterating
1007        // composes soundly; the bound keeps compile time deterministic.
1008        if post_exhaust {
1009            let mut progress = n + d + u > 0;
1010            for _ in 0..3 {
1011                if !progress {
1012                    break;
1013                }
1014                let (o, n) =
1015                    synth_synthesis::liveness::apply_spill_realloc_post_exhaust(&out, true);
1016                let (o, d) = synth_synthesis::liveness::eliminate_dead_frame_stores(&o);
1017                let (o, u) = synth_synthesis::liveness::eliminate_unread_frame_stores(&o);
1018                progress = n + d + u > 0;
1019                (tn, td, tu) = (tn + n, td + d, tu + u);
1020                out = o;
1021            }
1022            // The cleanup can leave the spill frame with zero surviving
1023            // accesses (every reload rematerialized/dissolved, every store
1024            // swept) — the balanced `sub sp,#K`/`add sp,#K` is then pure
1025            // overhead. `elide_dead_frame` proves that and removes the pair;
1026            // its early run (post-realloc) could not, because the spill
1027            // traffic was still in the stream at that point.
1028            out = synth_synthesis::liveness::elide_dead_frame(&out).unwrap_or(out);
1029        }
1030        if std::env::var("SYNTH_FUSE_STATS").is_ok() {
1031            eprintln!(
1032                "[spill-realloc] {tn} reload(s) forwarded/eliminated, {td} newly-dead frame store(s) removed, {tu} unread-slot store(s) removed"
1033            );
1034        }
1035        out
1036    } else {
1037        arm_instrs
1038    };
1039
1040    // VCR-RA immediate-shift folding (#390, #242): a constant shift amount the
1041    // stack selector materialized into a scratch register (`movw rM,#C; lsl rD,rN,rM`)
1042    // folds to the immediate form (`lsl rD,rN,#C`), removing the dead `movw` — −1
1043    // instruction, −1 live register. Removal-only (offset-neutral before branch
1044    // resolution, like the dead-store pass). DEFAULT-ON as of v0.15.0: validated
1045    // bit-identical results + a net cycle win on the dissolved hot path (−2
1046    // cyc/call, .text 100→90 B on gust_mix). Escape hatch: `SYNTH_NO_IMM_SHIFT_FOLD=1`.
1047    let arm_instrs = if std::env::var("SYNTH_NO_IMM_SHIFT_FOLD").is_err() {
1048        let (out, folds) = synth_synthesis::liveness::fold_immediate_shifts(&arm_instrs);
1049        if std::env::var("SYNTH_FUSE_STATS").is_ok() {
1050            eprintln!(
1051                "[imm-shift-fold] {folds} register shift(s) folded to immediate, movw dropped"
1052            );
1053        }
1054        out
1055    } else {
1056        arm_instrs
1057    };
1058
1059    // #686: elide the #682 mod-32 shift-amount mask (`and r12,rK,#31` before
1060    // every register-controlled i32 shl/shr) when the amount is STATICALLY
1061    // provable < 32 — a const amount folds to the immediate-shift form
1062    // (reduced mod 32, so >= 32 shrinks too), and an already-masked amount
1063    // (`rK = rX & c`, c < 32) drops the redundant re-mask. gale measured the
1064    // unconditional mask at ~12% cyc/call (+14 B) on gust_mix, whose Q8
1065    // fixed-point shifts are all constants (#686). The mask stays wherever
1066    // the bound is unproven — elision is an optimization, the mask is the
1067    // sound default (`liveness::elide_shift_masks` has the proof
1068    // obligations). Runs after `fold_immediate_shifts` (whose movw→shift
1069    // window the #682 mask intercepts, so it declines every masked const
1070    // shift) and before branch resolution (removal/rewrite-only ⇒
1071    // offset-neutral).
1072    //
1073    // FLAG-OFF (opt-in via `SYNTH_SHIFT_MASK_ELIDE=1`) because the elision
1074    // moves the frozen anchors: const-amount shifts in control_step (−20 B),
1075    // flight_seam (−164 B) and flight_seam_flat (−168 B) fold back to the
1076    // immediate form — byte-shapes the corpus had BEFORE the #682 mask, now
1077    // with the mask soundly kept for every unproven amount. Flipping
1078    // default-on is a deliberate byte-changing refreeze (all differentials
1079    // re-run on the new bytes, goldens re-pinned) owned by the maintainer.
1080    let arm_instrs = if std::env::var("SYNTH_SHIFT_MASK_ELIDE").is_ok_and(|v| v != "0") {
1081        let (out, elisions) = synth_synthesis::liveness::elide_shift_masks(&arm_instrs);
1082        if std::env::var("SYNTH_FUSE_STATS").is_ok() {
1083            eprintln!(
1084                "[shift-mask-elide] {elisions} provably-<32 shift-amount mask(s) elided (#686)"
1085            );
1086        }
1087        out
1088    } else {
1089        arm_instrs
1090    };
1091
1092    // VCR-RA uxth/uxtb fold (#428, #242): `movw rM,#0xffff; and rD,rN,rM` →
1093    // `uxth rD,rN` (and the 0xff/uxtb form), removing the dead `movw` — −1
1094    // instruction, −1 live register per 16/8-bit mask. 0xffff/0xff are not Thumb-2
1095    // modified immediates so the selector materializes them into a register; the
1096    // dedicated zero-extend expresses the same masking inline. Removal-only +
1097    // rewrite-in-place (offset-neutral). DEFAULT-ON (#242 flag audit flip-wave,
1098    // #592 audit item): evidence basis was the 2-path × repro-corpus sweep —
1099    // 0 functions grow, 13 shrink (control_step 300→294 −6, gust_mix 38→32 −6,
1100    // uxth_fold pack 36→24 −12), locked by the `uxth_fold_no_grow_corpus_242`
1101    // cargo gate; execution differentials re-run green on the new default
1102    // bytes BEFORE the frozen ARM anchors were re-pinned (uxth_fold,
1103    // control_step — see the flip PR). Escape hatch: `SYNTH_UXTH_FOLD=0` opts
1104    // out and restores the pre-flip bytes (CI-gated in
1105    // `frozen_codegen_bytes.rs`).
1106    let arm_instrs = if !std::env::var("SYNTH_UXTH_FOLD").is_ok_and(|v| v == "0") {
1107        let (out, folds) = synth_synthesis::liveness::fold_uxth(&arm_instrs);
1108        if std::env::var("SYNTH_FUSE_STATS").is_ok() {
1109            eprintln!("[uxth-fold] {folds} mask-and folded to uxth/uxtb, movw dropped");
1110        }
1111        out
1112    } else {
1113        arm_instrs
1114    };
1115
1116    // VCR-RA-001 const-CSE / rematerialization-avoidance (#209, #242). Drops a
1117    // `movw`/`mov #imm` that re-materializes a constant already resident in
1118    // another register and retargets the reads — every rewrite proven by the
1119    // liveness analysis. Runs LAST, after every immediate-fold (shift, uxth) and
1120    // range-realloc, but BEFORE branch resolution/encoding (it removes
1121    // instructions, shifting byte offsets). CSE-last is the #242 no-regression
1122    // fix: the folds have already absorbed every foldable constant, so CSE can no
1123    // longer defeat one (the gust_mix 90→92 mechanism). The pass additionally
1124    // size-guards each segment via the byte-estimator — it commits a segment's
1125    // rewrites only if they do not grow its estimated size — so a retarget that
1126    // would flip a 16-bit encoding to 32-bit (higher base register) is declined.
1127    // DEFAULT-ON (#242 flip-wave, the SYNTH_SPILL_REALLOC/SYNTH_BASE_CSE
1128    // template): const-CSE ships by default. The flip prerequisites recorded in
1129    // `const_cse_reduction_242.rs` were retired first — the bridge-level INLINE
1130    // aliasing (the alias-eviction spill-bijection hazard) was DELETED from
1131    // `optimizer_bridge::ir_to_arm`, so this post-hoc, liveness-proven pass is
1132    // the flag's ONLY effect. Evidence basis: 152 fixture×path corpus sweep — 0
1133    // functions grow (size-guarded per segment), 40 shrink (const_cse::spill12
1134    // 236→148 B), total −536 B — and the execution differentials re-run green
1135    // on the new default bytes BEFORE the frozen goldens were re-pinned
1136    // (const_cse, frame_slot_dce, flight_seam 0x07FDF307, spill_rung_581,
1137    // volatile_segment_543, control_step 0x00210A55). Escape hatch:
1138    // `SYNTH_CONST_CSE=0` is the OPT-OUT — it restores the pre-flip bytes
1139    // (CI-gated by `const_cse_escape_hatch_restores_old_bytes_242` and the
1140    // frozen-anchor escape-hatch gate). Any other value (or unset) runs the pass.
1141    //
1142    // #543 Phase 2: const-CSE declines WHOLESALE while any volatile DMA range
1143    // (`--volatile-segment`) is marked. At the ArmOp level a cached constant
1144    // cannot be classified as address-vs-data (a retargeted read may be a
1145    // memory-access base carrying a per-use immediate offset), so the
1146    // conservative stance for statically-unknown addressing is to decline every
1147    // aliasing rewrite — each constant is re-materialized at each occurrence,
1148    // the documented volatile contract (`CompileConfig::volatile_segments`).
1149    let arm_instrs = if !std::env::var("SYNTH_CONST_CSE").is_ok_and(|v| v == "0")
1150        && config.volatile_segments.is_empty()
1151    {
1152        let (out, removed) = synth_synthesis::liveness::apply_const_cse(&arm_instrs);
1153        if std::env::var("SYNTH_FUSE_STATS").is_ok() {
1154            eprintln!("[const-cse] {removed} redundant constant materialization(s) removed");
1155        }
1156        out
1157    } else {
1158        arm_instrs
1159    };
1160
1161    // VCR-RA-001 spill-choice REPORT (#242): measure-only, like SYNTH_SHADOW_ALLOC.
1162    // Per straight-line segment, the frame-slot traffic actually emitted vs the
1163    // reload/store count a farthest-next-use (Belady) allocation over the R0-R8
1164    // pool would need — the measured headroom for the full spill-choice rewrite.
1165    // Printed on the FINAL stream (post all rewrite passes), so a flag-off run
1166    // reports the greedy baseline and a flag-on run reports what remains.
1167    if std::env::var("SYNTH_SPILL_REPORT").is_ok() {
1168        for seg in synth_synthesis::liveness::spill_choice_report(&arm_instrs, 9) {
1169            if seg.actual_reloads + seg.actual_spill_stores > 0 || seg.peak_pressure > 9 {
1170                eprintln!(
1171                    "[spill-report] seg@{} len={} peak={} actual={}ld+{}st belady(k=9)={}ld+{}st",
1172                    seg.start,
1173                    seg.len,
1174                    seg.peak_pressure,
1175                    seg.actual_reloads,
1176                    seg.actual_spill_stores,
1177                    seg.belady_reloads,
1178                    seg.belady_spill_stores
1179                );
1180            }
1181        }
1182    }
1183
1184    // ISA feature gate: validate that all generated instructions are supported
1185    // by the target. This catches FPU instructions on no-FPU targets, double-precision
1186    // instructions on single-precision targets, etc.
1187    validate_instructions(&arm_instrs, config.target.fpu, &config.target.triple)
1188        .map_err(|e| format!("ISA validation failed: {}", e))?;
1189
1190    // Encode to binary — use Thumb-2 for Cortex-M targets
1191    let use_thumb2 = matches!(config.target.isa, IsaVariant::Thumb2 | IsaVariant::Thumb);
1192
1193    let encoder = if use_thumb2 {
1194        ArmEncoder::new_thumb2_with_fpu(config.target.fpu)
1195    } else {
1196        ArmEncoder::new_arm32()
1197    };
1198
1199    // #202: resolve local label branches (Bcc/B/Bhs/Blo) to byte-accurate
1200    // offsets before encoding. `select_with_stack` emits them as label
1201    // placeholders and never resolves them — without this they encode as
1202    // `bne.n #0` and land mid-instruction whenever a 32-bit Thumb-2 instruction
1203    // sits between the branch and its target (UsageFault on real hardware).
1204    // Only meaningful for Thumb-2 (the offset units are halfword/PC+4).
1205    let arm_instrs = if use_thumb2 {
1206        resolve_label_branches(arm_instrs, &encoder)?
1207    } else {
1208        arm_instrs
1209    };
1210
1211    let mut code = Vec::new();
1212    let mut relocations = Vec::new();
1213
1214    // #345: literal-pool address loads. Each `LdrSym` was encoded as a placeholder
1215    // `LDR.W rd,[pc,#0]`; record where its instruction sits and what it loads so
1216    // we can append a pooled word (carrying the symbol address via R_ARM_ABS32)
1217    // and patch the PC-relative offset once the pool position is known.
1218    struct PendingLiteral {
1219        ldr_offset: u32,
1220        symbol: String,
1221        addend: i32,
1222    }
1223    let mut pending_literals: Vec<PendingLiteral> = Vec::new();
1224
1225    // VCR-DBG-001: per-instruction source map for DWARF `.debug_line`. Captured
1226    // here because `code.len()` immediately before `encode()` is the final
1227    // machine offset of the instruction within this function's `.text` — nothing
1228    // after the loop shifts earlier instructions (the literal pool is appended at
1229    // the end; the LDR patch below is in-place/length-preserving). Purely
1230    // additive: it does not touch `code`, so `.text` is byte-identical.
1231    let mut line_map: LineMap = Vec::new();
1232
1233    for instr in &arm_instrs {
1234        // Record a relocation for every BL: the encoder emits `bl #0` and
1235        // relies on a relocation to patch the target. This covers BOTH import
1236        // dispatch stubs (`__meld_*`, undefined externals) AND internal calls
1237        // (`func_N`, defined in this object). Previously only `__meld_*` was
1238        // recorded, so internal `BL func_N` calls were left as unpatched
1239        // `bl #0` placeholders branching to a garbage address (#167).
1240        if let ArmOp::Bl { label } = &instr.op {
1241            relocations.push(CodeRelocation {
1242                offset: code.len() as u32,
1243                symbol: label.clone(),
1244                kind: synth_core::backend::RelocKind::ThmCall,
1245            });
1246        }
1247        // #237: symbol-relative MOVW/MOVT (the `--native-pointer-abi` static-data
1248        // addressing). The encoder writes the addend in place; record the matching
1249        // R_ARM_MOVW_ABS_NC / R_ARM_MOVT_ABS so the linker adds the symbol address.
1250        if let ArmOp::MovwSym { symbol, .. } = &instr.op {
1251            relocations.push(CodeRelocation {
1252                offset: code.len() as u32,
1253                symbol: symbol.clone(),
1254                kind: synth_core::backend::RelocKind::MovwAbs,
1255            });
1256        }
1257        if let ArmOp::MovtSym { symbol, .. } = &instr.op {
1258            relocations.push(CodeRelocation {
1259                offset: code.len() as u32,
1260                symbol: symbol.clone(),
1261                kind: synth_core::backend::RelocKind::MovtAbs,
1262            });
1263        }
1264        // #345: defer the literal-pool word + reloc + offset patch to the
1265        // post-loop pass (the pool address is not yet known).
1266        if let ArmOp::LdrSym { symbol, addend, .. } = &instr.op {
1267            pending_literals.push(PendingLiteral {
1268                ldr_offset: code.len() as u32,
1269                symbol: symbol.clone(),
1270                addend: *addend,
1271            });
1272        }
1273
1274        // The machine offset of this instruction is the current code length,
1275        // captured before the bytes are appended.
1276        line_map.push((code.len() as u32, instr.source_line));
1277
1278        let encoded = encoder
1279            .encode(&instr.op)
1280            .map_err(|e| format!("ARM encoding failed: {}", e))?;
1281        code.extend_from_slice(&encoded);
1282    }
1283
1284    // #345: place the literal pool at the end of this function's `.text`. Gated on
1285    // there being at least one `LdrSym` — functions without one are byte-identical
1286    // to before (no trailing padding, so downstream `func_offsets` are unchanged
1287    // and the frozen differential fixtures stay bit-for-bit equal).
1288    if !pending_literals.is_empty() {
1289        if !use_thumb2 {
1290            return Err("LdrSym literal-pool addressing requires Thumb-2".to_string());
1291        }
1292        // 4-byte align the pool start (Thumb-2 word loads require it, and
1293        // `Align(PC,4)` in the LDR-literal semantics assumes a word-aligned pool).
1294        while code.len() % 4 != 0 {
1295            code.push(0x00);
1296        }
1297        // One distinct pooled word per LdrSym (no dedup: different sites carry
1298        // different addends, and the REL addend lives in the word).
1299        for lit in &pending_literals {
1300            let word_offset = code.len() as u32;
1301
1302            // REL semantics: the linker computes `S + A`, where A is the in-place
1303            // value of the relocated word. Initialize the word to the addend so
1304            // the final loaded address is `symbol + addend`.
1305            code.extend_from_slice(&(lit.addend as u32).to_le_bytes());
1306            relocations.push(CodeRelocation {
1307                offset: word_offset,
1308                symbol: lit.symbol.clone(),
1309                kind: synth_core::backend::RelocKind::Abs32,
1310            });
1311
1312            // Patch the placeholder `LDR.W rd,[pc,#imm12]`. Thumb-2 LDR (literal):
1313            // address = Align(PC,4) + imm12, with PC = ldr_offset + 4. The pool is
1314            // always after the LDR, so U=1 (already set in hw1 = 0xF8DF).
1315            let pc = lit.ldr_offset + 4;
1316            let aligned_pc = pc & !3u32;
1317            let imm12 = word_offset - aligned_pc;
1318            if imm12 > 0xFFF {
1319                // Wide LDR-literal range is ±4 KB; these function bodies are far
1320                // smaller, but fail cleanly rather than miscompile if exceeded.
1321                return Err(format!(
1322                    "LdrSym literal pool out of range (#345): imm12={} > 4095 \
1323                     for symbol {}",
1324                    imm12, lit.symbol
1325                ));
1326            }
1327            let hw2_off = (lit.ldr_offset + 2) as usize;
1328            let mut hw2 = u16::from_le_bytes([code[hw2_off], code[hw2_off + 1]]);
1329            hw2 = (hw2 & 0xF000) | (imm12 as u16); // keep Rt, set imm12
1330            let hw2_bytes = hw2.to_le_bytes();
1331            code[hw2_off] = hw2_bytes[0];
1332            code[hw2_off + 1] = hw2_bytes[1];
1333        }
1334    }
1335
1336    Ok((code, relocations, line_map))
1337}
1338
1339/// Resolve local label branches to byte-accurate offsets (#202).
1340///
1341/// `select_with_stack` emits conditional/unconditional branches as label
1342/// placeholders (`Bcc`/`B`/`Bhs`/`Blo` + `Label`) and never resolves them; the
1343/// encoder then emits a `0xD000`/`0xE000` placeholder with offset 0. Before #197
1344/// this path only ran for `--no-optimize`/declined functions, so the latent bug
1345/// stayed hidden — routing relocatable code through it surfaced branches that
1346/// land mid-instruction (a Cortex-M UsageFault) whenever a 32-bit Thumb-2
1347/// instruction sits between the branch and its target.
1348///
1349/// This pass encodes each instruction to learn its real byte length (so 16- vs
1350/// 32-bit forms and multi-instruction expansions are exact), maps each `Label`
1351/// to its byte position, and rewrites every label branch to the displacement
1352/// the encoder consumes: `(target - branch - 4) / 2` halfwords. A bounded
1353/// fixed-point handles an offset growing a branch from 16- to 32-bit (which
1354/// shifts later positions). `BCondOffset`/`BOffset` already produced inline by
1355/// the optimized path carry no label and are left untouched.
1356fn resolve_label_branches(
1357    arm_instrs: Vec<ArmInstruction>,
1358    encoder: &ArmEncoder,
1359) -> Result<Vec<ArmInstruction>, String> {
1360    use std::collections::HashMap;
1361    use synth_synthesis::Condition;
1362
1363    enum BKind {
1364        Cond(Condition),
1365        Uncond,
1366    }
1367    // Record each label branch ONCE — indices are stable across iterations.
1368    let mut branches: Vec<(usize, BKind, String)> = Vec::new();
1369    for (i, instr) in arm_instrs.iter().enumerate() {
1370        match &instr.op {
1371            ArmOp::Bcc { cond, label } => branches.push((i, BKind::Cond(*cond), label.clone())),
1372            ArmOp::Bhs { label } => branches.push((i, BKind::Cond(Condition::HS), label.clone())),
1373            ArmOp::Blo { label } => branches.push((i, BKind::Cond(Condition::LO), label.clone())),
1374            ArmOp::B { label } => branches.push((i, BKind::Uncond, label.clone())),
1375            _ => {}
1376        }
1377    }
1378    if branches.is_empty() {
1379        return Ok(arm_instrs);
1380    }
1381
1382    let mut resolved = arm_instrs;
1383    // Sizes only grow (16→32-bit), so this converges quickly; cap for safety.
1384    for _ in 0..16 {
1385        // 1. Byte position of each instruction (Label encodes to 0 bytes).
1386        let mut positions = Vec::with_capacity(resolved.len());
1387        let mut pos: i64 = 0;
1388        for instr in &resolved {
1389            positions.push(pos);
1390            pos += encoder
1391                .encode(&instr.op)
1392                .map_err(|e| format!("branch-resolve size probe failed: {}", e))?
1393                .len() as i64;
1394        }
1395        // 2. Label name -> byte position (owned keys so the borrow ends here).
1396        let mut labels: HashMap<String, i64> = HashMap::new();
1397        for (i, instr) in resolved.iter().enumerate() {
1398            if let ArmOp::Label { name } = &instr.op {
1399                labels.insert(name.clone(), positions[i]);
1400            }
1401        }
1402        // 3. Rewrite each branch to its byte-accurate offset.
1403        let mut changed = false;
1404        for (idx, kind, label) in &branches {
1405            // A label not defined locally is an EXTERNAL target (e.g.
1406            // `Trap_Handler` resolved by a relocation / the vector table). Leave
1407            // such branches as their placeholder for the existing relocation
1408            // path — only local control-flow labels are byte-resolved here.
1409            let Some(&target) = labels.get(label) else {
1410                continue;
1411            };
1412            // Encoder consumes the field as (target - branch - 4) / 2 halfwords.
1413            // Positions are always even, so this division is exact.
1414            let halfword_offset = ((target - positions[*idx] - 4) / 2) as i32;
1415            let new_op = match kind {
1416                BKind::Cond(c) => ArmOp::BCondOffset {
1417                    cond: *c,
1418                    offset: halfword_offset,
1419                },
1420                BKind::Uncond => ArmOp::BOffset {
1421                    offset: halfword_offset,
1422                },
1423            };
1424            if resolved[*idx].op != new_op {
1425                resolved[*idx].op = new_op;
1426                changed = true;
1427            }
1428        }
1429        if !changed {
1430            break;
1431        }
1432    }
1433    Ok(resolved)
1434}
1435
1436#[cfg(test)]
1437mod tests {
1438    use super::*;
1439
1440    /// #539: `i32.const 0; memory.grow m` folds to `memory.size m`; other deltas
1441    /// (const non-zero, runtime) are left as `memory.grow` (→ the sound fixed-
1442    /// memory -1). Non-grow ops are untouched, so functions without the idiom are
1443    /// byte-identical.
1444    #[test]
1445    fn test_rewrite_memory_grow_zero_539() {
1446        // the idiom -> memory.size
1447        assert_eq!(
1448            rewrite_memory_grow_zero(&[WasmOp::I32Const(0), WasmOp::MemoryGrow(0)]),
1449            vec![WasmOp::MemorySize(0)]
1450        );
1451        // const non-zero delta: NOT folded
1452        assert_eq!(
1453            rewrite_memory_grow_zero(&[WasmOp::I32Const(2), WasmOp::MemoryGrow(0)]),
1454            vec![WasmOp::I32Const(2), WasmOp::MemoryGrow(0)]
1455        );
1456        // runtime delta (no preceding const): NOT folded
1457        assert_eq!(
1458            rewrite_memory_grow_zero(&[WasmOp::LocalGet(0), WasmOp::MemoryGrow(0)]),
1459            vec![WasmOp::LocalGet(0), WasmOp::MemoryGrow(0)]
1460        );
1461        // a bare const-0 not feeding a grow is untouched
1462        assert_eq!(
1463            rewrite_memory_grow_zero(&[WasmOp::I32Const(0), WasmOp::I32Add]),
1464            vec![WasmOp::I32Const(0), WasmOp::I32Add]
1465        );
1466        // fold is local: surrounding ops preserved, indices past the fold intact
1467        assert_eq!(
1468            rewrite_memory_grow_zero(&[
1469                WasmOp::LocalGet(0),
1470                WasmOp::I32Const(0),
1471                WasmOp::MemoryGrow(0),
1472                WasmOp::I32Add,
1473            ]),
1474            vec![WasmOp::LocalGet(0), WasmOp::MemorySize(0), WasmOp::I32Add]
1475        );
1476    }
1477
1478    #[test]
1479    fn test_arm_backend_name() {
1480        let backend = ArmBackend::new();
1481        assert_eq!(backend.name(), "arm");
1482        assert!(backend.is_available());
1483    }
1484
1485    #[test]
1486    fn test_arm_backend_capabilities() {
1487        let backend = ArmBackend::new();
1488        let caps = backend.capabilities();
1489        assert!(!caps.produces_elf);
1490        assert!(caps.supports_rule_verification);
1491        assert!(!caps.is_external);
1492    }
1493
1494    #[test]
1495    fn test_compile_add_function() {
1496        let backend = ArmBackend::new();
1497        let ops = vec![WasmOp::LocalGet(0), WasmOp::LocalGet(1), WasmOp::I32Add];
1498        let config = CompileConfig::default();
1499
1500        let result = backend.compile_function("add", &ops, &config);
1501        assert!(result.is_ok());
1502
1503        let func = result.unwrap();
1504        assert_eq!(func.name, "add");
1505        assert!(!func.code.is_empty());
1506        assert_eq!(func.wasm_ops, ops);
1507    }
1508
1509    /// VCR-DBG-001: the per-instruction source map must cover the function with
1510    /// monotonic, in-bounds machine offsets, and must not perturb the emitted
1511    /// code (it is captured at encode time, never serialized here).
1512    #[test]
1513    fn test_line_map_is_wellformed_dbg001() {
1514        let backend = ArmBackend::new();
1515        let ops = vec![
1516            WasmOp::LocalGet(0),
1517            WasmOp::LocalGet(1),
1518            WasmOp::I32Add,
1519            WasmOp::End,
1520        ];
1521        let config = CompileConfig::default();
1522        let func = backend.compile_function("add", &ops, &config).unwrap();
1523
1524        // Non-empty, and the first instruction starts at machine offset 0.
1525        assert!(
1526            !func.line_map.is_empty(),
1527            "a non-trivial function captures a source map"
1528        );
1529        assert_eq!(func.line_map[0].0, 0, "first instruction at offset 0");
1530
1531        // Offsets strictly increase by at least one ARM/Thumb instruction (>= 2
1532        // bytes) and every mapped offset lies inside the emitted `.text`.
1533        for w in func.line_map.windows(2) {
1534            assert!(w[1].0 > w[0].0, "instruction offsets strictly increase");
1535            assert!(
1536                w[1].0 - w[0].0 >= 2,
1537                "each ARM/Thumb instruction is >= 2 bytes"
1538            );
1539        }
1540        let last = func.line_map.last().unwrap().0 as usize;
1541        assert!(
1542            last < func.code.len(),
1543            "every mapped offset lies inside .text"
1544        );
1545
1546        // The side-table is additive: recompiling is deterministic and the map is
1547        // consistent with that exact code (capturing it does not alter output).
1548        let again = backend.compile_function("add", &ops, &config).unwrap();
1549        assert_eq!(
1550            again.code, func.code,
1551            "compilation deterministic; map is additive"
1552        );
1553        assert_eq!(again.line_map, func.line_map);
1554    }
1555
1556    #[test]
1557    fn test_count_params() {
1558        let ops = vec![WasmOp::LocalGet(0), WasmOp::LocalGet(1), WasmOp::I32Add];
1559        assert_eq!(count_params(&ops), 2);
1560
1561        let no_params = vec![WasmOp::I32Const(5), WasmOp::I32Const(3), WasmOp::I32Add];
1562        assert_eq!(count_params(&no_params), 0);
1563    }
1564
1565    /// #457: the declared param count caps the access-pattern inference. The
1566    /// repro shape `(param i32)(local i32) → p0 + local1` reads local 1 before
1567    /// any write, so `count_params` infers 2 — with the declared count (1) the
1568    /// local is reclassified onto the zero-inited frame path instead of being
1569    /// read from R1 (caller garbage).
1570    #[test]
1571    fn declared_param_count_caps_inference_457() {
1572        let ops = vec![
1573            WasmOp::LocalGet(0),
1574            WasmOp::LocalGet(1),
1575            WasmOp::I32Add,
1576            WasmOp::End,
1577        ];
1578        // The inference alone still says 2 (the misclassification this caps).
1579        assert_eq!(count_params(&ops), 2);
1580
1581        let backend = ArmBackend::new();
1582        let inferred = backend
1583            .compile_function("rbw", &ops, &CompileConfig::default())
1584            .unwrap();
1585        let declared = backend
1586            .compile_function(
1587                "rbw",
1588                &ops,
1589                &CompileConfig {
1590                    current_func_param_count: Some(1),
1591                    ..CompileConfig::default()
1592                },
1593            )
1594            .unwrap();
1595        // The cap is consumed: the declared-count compile reclassifies local 1
1596        // and must emit different code than the param-misclassified one.
1597        assert_ne!(
1598            inferred.code, declared.code,
1599            "declared param count must reach the selector"
1600        );
1601        // The zero-init is present: a 16-bit Thumb `movs rN, #0`
1602        // (0x2000 | rd<<8 → LE bytes [0x00, 0x20+rd]) somewhere in the body.
1603        let has_movs_zero = declared
1604            .code
1605            .chunks_exact(2)
1606            .any(|h| h[0] == 0x00 && (0x20..=0x27).contains(&h[1]));
1607        assert!(
1608            has_movs_zero,
1609            "declared-count compile must zero-init the read-before-write local; code: {:02x?}",
1610            declared.code
1611        );
1612        // A declared count that matches (or exceeds) the inference changes
1613        // nothing — byte-identity for every function without rbw locals.
1614        let matching = backend
1615            .compile_function(
1616                "rbw",
1617                &ops,
1618                &CompileConfig {
1619                    current_func_param_count: Some(2),
1620                    ..CompileConfig::default()
1621                },
1622            )
1623            .unwrap();
1624        assert_eq!(
1625            matching.code, inferred.code,
1626            "declared >= inferred must stay byte-identical"
1627        );
1628    }
1629
1630    #[test]
1631    fn test_arm_backend_register() {
1632        let mut registry = synth_core::BackendRegistry::new();
1633        registry.register(Box::new(ArmBackend::new()));
1634        assert!(registry.get("arm").is_some());
1635        assert_eq!(registry.available().len(), 1);
1636    }
1637
1638    #[test]
1639    fn test_compile_import_call_produces_relocations() {
1640        let backend = ArmBackend::new();
1641        // Simulate a WASM module where func index 0 is an import.
1642        // Call(0) should generate MOV R0, #0; BL __meld_dispatch_import
1643        let ops = vec![WasmOp::Call(0)];
1644        let config = CompileConfig {
1645            num_imports: 1,
1646            no_optimize: true, // Direct instruction selection to preserve Call semantics
1647            ..CompileConfig::default()
1648        };
1649
1650        let result = backend.compile_function("caller", &ops, &config);
1651        assert!(result.is_ok());
1652
1653        let func = result.unwrap();
1654        assert!(!func.code.is_empty());
1655        assert_eq!(func.relocations.len(), 1);
1656        assert_eq!(func.relocations[0].symbol, "__meld_dispatch_import");
1657        // The BL is the second instruction (after MOV R0, #0), so offset should be > 0
1658        assert!(func.relocations[0].offset > 0);
1659    }
1660
1661    /// Regression test for #197: in `relocatable` mode, an import call must
1662    /// relocate against the direct `func_N` symbol (rewritten to the wasm field
1663    /// name by `build_relocatable_elf`), NOT `__meld_dispatch_import`. This is
1664    /// the ABI half of the #197 fix — without it, a host linker cannot resolve
1665    /// the call to the real kernel symbol (e.g. `k_spin_lock`).
1666    #[test]
1667    fn test_compile_relocatable_import_uses_direct_func_symbol_197() {
1668        let backend = ArmBackend::new();
1669        let ops = vec![WasmOp::Call(0)]; // func 0 is an import
1670        let config = CompileConfig {
1671            num_imports: 1,
1672            relocatable: true,
1673            ..CompileConfig::default()
1674        };
1675
1676        let func = backend
1677            .compile_function("caller", &ops, &config)
1678            .expect("relocatable import call compiles");
1679
1680        assert_eq!(func.relocations.len(), 1);
1681        assert_eq!(
1682            func.relocations[0].symbol, "func_0",
1683            "#197: relocatable import must relocate against func_0 (→ field name), not Meld dispatch"
1684        );
1685    }
1686
1687    #[test]
1688    fn test_compile_no_imports_no_relocations() {
1689        let backend = ArmBackend::new();
1690        let ops = vec![WasmOp::LocalGet(0), WasmOp::LocalGet(1), WasmOp::I32Add];
1691        let config = CompileConfig::default();
1692
1693        let func = backend.compile_function("add", &ops, &config).unwrap();
1694        assert!(func.relocations.is_empty());
1695    }
1696
1697    /// Regression test for #167: a call to an INTERNAL function
1698    /// (index `>= num_imports`) must record a relocation against `func_{index}`.
1699    /// Before the fix, only `__meld_*` (import) BLs were relocated, so
1700    /// internal `BL func_N` was emitted as an unpatched `bl #0` branching
1701    /// to a garbage address — making the object non-linkable. This test
1702    /// would have caught that regression.
1703    #[test]
1704    fn test_compile_internal_call_produces_relocation_167() {
1705        let backend = ArmBackend::new();
1706        // num_imports = 1, so Call(2) is an INTERNAL call → `BL func_2`.
1707        let ops = vec![WasmOp::Call(2)];
1708        let config = CompileConfig {
1709            num_imports: 1,
1710            no_optimize: true,
1711            ..CompileConfig::default()
1712        };
1713
1714        let func = backend
1715            .compile_function("caller", &ops, &config)
1716            .expect("internal call compiles");
1717
1718        assert_eq!(
1719            func.relocations.len(),
1720            1,
1721            "an internal call must emit exactly one relocation (#167)"
1722        );
1723        assert_eq!(
1724            func.relocations[0].symbol, "func_2",
1725            "internal call must relocate against the callee's func_{{index}} symbol (#167)"
1726        );
1727    }
1728
1729    // ─── Phase 1 safety-bounds plumbing for ARM ──────────────────────────
1730
1731    #[test]
1732    fn arm_safety_bounds_mpu_emits_same_code_as_none() {
1733        // Mpu mode must not introduce any inline check on ARM — the MPU
1734        // handles faults via hardware. The encoded bytes for an i32.load
1735        // should be identical between None and Mpu.
1736        let backend = ArmBackend::new();
1737        let ops = vec![
1738            WasmOp::LocalGet(0),
1739            WasmOp::I32Load {
1740                offset: 0,
1741                align: 2,
1742            },
1743        ];
1744        let cfg_none = CompileConfig {
1745            no_optimize: true,
1746            ..Default::default()
1747        };
1748        let cfg_mpu = CompileConfig {
1749            no_optimize: true,
1750            safety_bounds: SafetyBounds::Mpu,
1751            ..Default::default()
1752        };
1753        let n = backend.compile_function("ld", &ops, &cfg_none).unwrap();
1754        let m = backend.compile_function("ld", &ops, &cfg_mpu).unwrap();
1755        assert_eq!(
1756            n.code, m.code,
1757            "Mpu and None should produce identical ARM bytes (Mpu relies on hardware)"
1758        );
1759    }
1760
1761    #[test]
1762    fn arm_legacy_bounds_check_still_emits_software_check() {
1763        // Legacy CLI users with `--bounds-check` should keep getting the
1764        // software path even though the new SafetyBounds field defaults to None.
1765        let backend = ArmBackend::new();
1766        let ops = vec![
1767            WasmOp::LocalGet(0),
1768            WasmOp::I32Load {
1769                offset: 0,
1770                align: 2,
1771            },
1772        ];
1773        let cfg_legacy = CompileConfig {
1774            no_optimize: true,
1775            bounds_check: true,
1776            ..Default::default()
1777        };
1778        let cfg_software = CompileConfig {
1779            no_optimize: true,
1780            safety_bounds: SafetyBounds::Software,
1781            ..Default::default()
1782        };
1783        let l = backend.compile_function("ld", &ops, &cfg_legacy).unwrap();
1784        let s = backend.compile_function("ld", &ops, &cfg_software).unwrap();
1785        assert_eq!(
1786            l.code, s.code,
1787            "--bounds-check should produce the same bytes as --safety-bounds=software"
1788        );
1789    }
1790
1791    /// #377: `--safety-bounds software` must be enforced on the OPTIMIZED path
1792    /// too. Pre-fix, `software` was byte-identical to `none` there (a silent
1793    /// no-op while the safety manifest claimed enforcement). The compiled
1794    /// bytes must now (a) differ from `none` and (b) contain the inline
1795    /// `CMP ip, sl` + `UDF` guard.
1796    #[test]
1797    fn arm_safety_bounds_software_enforced_on_optimized_path_377() {
1798        let backend = ArmBackend::new();
1799        // Dynamic-address store+load: the optimized path accepts this shape
1800        // (no calls, no i64 params, ≤4 params).
1801        let ops = vec![
1802            WasmOp::LocalGet(0),
1803            WasmOp::LocalGet(1),
1804            WasmOp::I32Store {
1805                offset: 4,
1806                align: 2,
1807            },
1808            WasmOp::LocalGet(0),
1809            WasmOp::I32Load {
1810                offset: 0,
1811                align: 2,
1812            },
1813        ];
1814        // no_optimize NOT set — this exercises the optimized path.
1815        let cfg_none = CompileConfig::default();
1816        let cfg_sw = CompileConfig {
1817            safety_bounds: SafetyBounds::Software,
1818            ..Default::default()
1819        };
1820        let n = backend.compile_function("st", &ops, &cfg_none).unwrap();
1821        let s = backend.compile_function("st", &ops, &cfg_sw).unwrap();
1822        assert_ne!(
1823            n.code, s.code,
1824            "#377: software bounds must CHANGE optimized-path codegen (was a silent no-op)"
1825        );
1826        // Thumb-2 `UDF #0` is 0xDE00 (LE bytes: 00 DE); `CMP ip, sl` (T2
1827        // high-reg) is 0x45D4 (LE: D4 45). Both must appear — one guard per
1828        // access, trap inline.
1829        let has_udf = s.code.windows(2).any(|w| w == [0x00, 0xDE]);
1830        let has_cmp_ip_sl = s.code.windows(2).any(|w| w == [0xD4, 0x45]);
1831        assert!(has_udf, "#377: inline UDF trap missing from optimized path");
1832        assert!(
1833            has_cmp_ip_sl,
1834            "#377: CMP ip, sl bounds compare missing from optimized path"
1835        );
1836        // And `none` must contain NO UDF (the function has no other trap).
1837        assert!(
1838            !n.code.windows(2).any(|w| w == [0x00, 0xDE]),
1839            "none must not contain a UDF for this function"
1840        );
1841    }
1842
1843    /// #377: `mpu` on the optimized path is codegen-passthrough — identical
1844    /// bytes to `none` on BOTH paths (hardware enforcement is target-level;
1845    /// synth does not emit MPU region programming — tracked separately in
1846    /// #377's fix-direction discussion). This pins path-parity for `mpu`.
1847    #[test]
1848    fn arm_safety_bounds_mpu_optimized_path_parity_377() {
1849        let backend = ArmBackend::new();
1850        let ops = vec![
1851            WasmOp::LocalGet(0),
1852            WasmOp::I32Load {
1853                offset: 0,
1854                align: 2,
1855            },
1856        ];
1857        let cfg_none = CompileConfig::default();
1858        let cfg_mpu = CompileConfig {
1859            safety_bounds: SafetyBounds::Mpu,
1860            ..Default::default()
1861        };
1862        let n = backend.compile_function("ld", &ops, &cfg_none).unwrap();
1863        let m = backend.compile_function("ld", &ops, &cfg_mpu).unwrap();
1864        assert_eq!(
1865            n.code, m.code,
1866            "Mpu and None must produce identical bytes on the optimized path too"
1867        );
1868    }
1869
1870    /// #377: `mask` on the optimized path declines to the direct selector
1871    /// (honest degradation) — the compiled function must equal the
1872    /// `--no-optimize` masking bytes, i.e. the flag is honored, never dropped.
1873    #[test]
1874    fn arm_safety_bounds_mask_optimized_path_declines_to_direct_377() {
1875        let backend = ArmBackend::new();
1876        let ops = vec![
1877            WasmOp::LocalGet(0),
1878            WasmOp::LocalGet(1),
1879            WasmOp::I32Store {
1880                offset: 0,
1881                align: 2,
1882            },
1883        ];
1884        let cfg_mask_opt = CompileConfig {
1885            safety_bounds: SafetyBounds::Mask,
1886            ..Default::default()
1887        };
1888        let cfg_mask_direct = CompileConfig {
1889            no_optimize: true,
1890            safety_bounds: SafetyBounds::Mask,
1891            ..Default::default()
1892        };
1893        let o = backend.compile_function("st", &ops, &cfg_mask_opt).unwrap();
1894        let d = backend
1895            .compile_function("st", &ops, &cfg_mask_direct)
1896            .unwrap();
1897        assert_eq!(
1898            o.code, d.code,
1899            "#377: mask on the optimized path must fall back to the direct selector's masking"
1900        );
1901    }
1902
1903    // ========================================================================
1904    // ISA feature gate tests — ensure the compiler never emits unsupported
1905    // instructions for a given target
1906    // ========================================================================
1907
1908    #[test]
1909    fn test_f32_rejected_on_cortex_m3_no_fpu() {
1910        let backend = ArmBackend::new();
1911        let ops = vec![WasmOp::F32Const(1.0), WasmOp::F32Const(2.0), WasmOp::F32Add];
1912        let config = CompileConfig {
1913            target: TargetSpec::cortex_m3(),
1914            no_optimize: true,
1915            ..CompileConfig::default()
1916        };
1917
1918        let result = backend.compile_function("fadd", &ops, &config);
1919        assert!(
1920            result.is_err(),
1921            "f32 operations should fail on Cortex-M3 (no FPU)"
1922        );
1923    }
1924
1925    #[test]
1926    fn test_f32_accepted_on_cortex_m4f() {
1927        let backend = ArmBackend::new();
1928        let ops = vec![WasmOp::F32Const(1.0), WasmOp::F32Const(2.0), WasmOp::F32Add];
1929        let config = CompileConfig {
1930            target: TargetSpec::cortex_m4f(),
1931            no_optimize: true,
1932            ..CompileConfig::default()
1933        };
1934
1935        let result = backend.compile_function("fadd", &ops, &config);
1936        assert!(
1937            result.is_ok(),
1938            "f32 operations should succeed on Cortex-M4F, got: {:?}",
1939            result.unwrap_err()
1940        );
1941    }
1942
1943    #[test]
1944    fn test_i32_works_on_all_targets() {
1945        let backend = ArmBackend::new();
1946        let ops = vec![WasmOp::LocalGet(0), WasmOp::LocalGet(1), WasmOp::I32Add];
1947
1948        // Cortex-M3 (no FPU)
1949        let config_m3 = CompileConfig {
1950            target: TargetSpec::cortex_m3(),
1951            no_optimize: true,
1952            ..CompileConfig::default()
1953        };
1954        assert!(
1955            backend.compile_function("add", &ops, &config_m3).is_ok(),
1956            "i32 ops should work on Cortex-M3"
1957        );
1958
1959        // Cortex-M4F (single FPU)
1960        let config_m4f = CompileConfig {
1961            target: TargetSpec::cortex_m4f(),
1962            no_optimize: true,
1963            ..CompileConfig::default()
1964        };
1965        assert!(
1966            backend.compile_function("add", &ops, &config_m4f).is_ok(),
1967            "i32 ops should work on Cortex-M4F"
1968        );
1969
1970        // Cortex-M7DP (double FPU)
1971        let config_m7dp = CompileConfig {
1972            target: TargetSpec::cortex_m7dp(),
1973            no_optimize: true,
1974            ..CompileConfig::default()
1975        };
1976        assert!(
1977            backend.compile_function("add", &ops, &config_m7dp).is_ok(),
1978            "i32 ops should work on Cortex-M7DP"
1979        );
1980    }
1981
1982    #[test]
1983    fn test_f32_rejected_on_cortex_m4_no_fpu() {
1984        // Cortex-M4 (without F suffix) has no FPU
1985        let backend = ArmBackend::new();
1986        let ops = vec![WasmOp::F32Const(1.5), WasmOp::F32Const(2.5), WasmOp::F32Mul];
1987        let config = CompileConfig {
1988            target: TargetSpec::cortex_m4(),
1989            no_optimize: true,
1990            ..CompileConfig::default()
1991        };
1992
1993        let result = backend.compile_function("fmul", &ops, &config);
1994        assert!(
1995            result.is_err(),
1996            "f32 operations should fail on Cortex-M4 (no FPU)"
1997        );
1998    }
1999
2000    // ========================================================================
2001    // Issue #120 — f32 ops in the optimized lowering path
2002    //
2003    // `OptimizerBridge::wasm_to_ir` has no handlers for f32/f64 ops, so a
2004    // value-producing float op fell through to `Opcode::Nop`, leaving a
2005    // downstream consumer with an unmapped vreg and tripping the PR #101
2006    // defensive panic in `ir_to_arm`. Customer reproducer: `compiler_builtins
2007    // float::div` and `gale_compute_ipi_mask` in the `falcon-rate-component`
2008    // module.
2009    //
2010    // Fix: `optimize_full` declines float modules with a typed `Err`;
2011    // `compile_wasm_to_arm` falls back to the non-optimized `select_with_stack`
2012    // path, which handles f32 via VFP/FPU. These tests use the *default*
2013    // (optimized) config — `no_optimize` is NOT set — which is the exact
2014    // configuration that panicked pre-fix.
2015    // ========================================================================
2016
2017    /// Pre-fix: this panicked with "vreg vN has no assigned ARM register and
2018    /// no spill slot" inside `ir_to_arm`. Post-fix: the optimized path declines
2019    /// the module and the backend falls back to direct selection, producing a
2020    /// non-empty f32.div lowering on a Cortex-M4F.
2021    #[test]
2022    fn test_issue120_f32_div_compiles_via_optimized_default() {
2023        let backend = ArmBackend::new();
2024        let ops = vec![WasmOp::LocalGet(0), WasmOp::LocalGet(1), WasmOp::F32Div];
2025        let config = CompileConfig {
2026            target: TargetSpec::cortex_m4f(),
2027            // no_optimize NOT set — this exercises the optimized path that
2028            // panicked in issue #120, then the fallback to direct selection.
2029            ..CompileConfig::default()
2030        };
2031
2032        let result = backend.compile_function("fdiv", &ops, &config);
2033        assert!(
2034            result.is_ok(),
2035            "f32.div must compile on Cortex-M4F via the optimized->direct \
2036             fallback (issue #120), got: {:?}",
2037            result.as_ref().err()
2038        );
2039        assert!(
2040            !result.unwrap().code.is_empty(),
2041            "f32.div must produce non-empty machine code"
2042        );
2043    }
2044
2045    /// A spread of f32 ops, all through the optimized (default) config, must
2046    /// compile via the fallback on an FPU target without panicking.
2047    #[test]
2048    fn test_issue120_assorted_f32_ops_compile_via_optimized_default() {
2049        let backend = ArmBackend::new();
2050        let config = CompileConfig {
2051            target: TargetSpec::cortex_m4f(),
2052            ..CompileConfig::default()
2053        };
2054
2055        let cases: Vec<(&str, Vec<WasmOp>)> = vec![
2056            (
2057                "fadd",
2058                vec![WasmOp::LocalGet(0), WasmOp::LocalGet(1), WasmOp::F32Add],
2059            ),
2060            (
2061                "fmul",
2062                vec![WasmOp::LocalGet(0), WasmOp::LocalGet(1), WasmOp::F32Mul],
2063            ),
2064            (
2065                "fsub",
2066                vec![WasmOp::LocalGet(0), WasmOp::LocalGet(1), WasmOp::F32Sub],
2067            ),
2068        ];
2069
2070        for (name, ops) in cases {
2071            let result = backend.compile_function(name, &ops, &config);
2072            assert!(
2073                result.is_ok(),
2074                "{name} must compile via the optimized->direct fallback \
2075                 (issue #120), got: {:?}",
2076                result.as_ref().err()
2077            );
2078            assert!(
2079                !result.unwrap().code.is_empty(),
2080                "{name} must produce non-empty machine code"
2081            );
2082        }
2083    }
2084
2085    /// The fallback must still honor the ISA feature gate: f32 on a no-FPU
2086    /// target must fail cleanly (not panic) even on the optimized path.
2087    #[test]
2088    fn test_issue120_f32_div_rejected_on_no_fpu_via_optimized() {
2089        let backend = ArmBackend::new();
2090        let ops = vec![WasmOp::LocalGet(0), WasmOp::LocalGet(1), WasmOp::F32Div];
2091        let config = CompileConfig {
2092            target: TargetSpec::cortex_m3(),
2093            ..CompileConfig::default()
2094        };
2095
2096        let result = backend.compile_function("fdiv", &ops, &config);
2097        assert!(
2098            result.is_err(),
2099            "f32.div must be rejected on Cortex-M3 (no FPU), not panic"
2100        );
2101    }
2102
2103    /// #507: a `br_table` function compiled via the DEFAULT (optimized) config
2104    /// must produce the SAME bytes as the direct (`no_optimize`) selector —
2105    /// i.e. the optimized path declined it to direct, lowering the dispatch as a
2106    /// real cmp-chain instead of silently dropping it (which left all arms in
2107    /// fall-through). Pre-fix the two outputs differed (the optimized one had no
2108    /// selector compare). Execution correctness is gated by
2109    /// `scripts/repro/br_table_507_differential.py`.
2110    #[test]
2111    fn test_507_br_table_declines_to_direct() {
2112        let backend = ArmBackend::new();
2113        // dispatch(sel): br_table over 3 blocks, each storing a marker to mem[0].
2114        let ops = vec![
2115            WasmOp::Block,
2116            WasmOp::Block,
2117            WasmOp::Block,
2118            WasmOp::LocalGet(0),
2119            WasmOp::BrTable {
2120                targets: vec![0, 1, 2],
2121                default: 2,
2122            },
2123            WasmOp::End,
2124            WasmOp::I32Const(0),
2125            WasmOp::I32Const(10),
2126            WasmOp::I32Store {
2127                offset: 0,
2128                align: 2,
2129            },
2130            WasmOp::Return,
2131            WasmOp::End,
2132            WasmOp::I32Const(0),
2133            WasmOp::I32Const(20),
2134            WasmOp::I32Store {
2135                offset: 0,
2136                align: 2,
2137            },
2138            WasmOp::Return,
2139            WasmOp::End,
2140            WasmOp::I32Const(0),
2141            WasmOp::I32Const(30),
2142            WasmOp::I32Store {
2143                offset: 0,
2144                align: 2,
2145            },
2146        ];
2147        let opt = CompileConfig {
2148            target: TargetSpec::cortex_m4(),
2149            ..CompileConfig::default()
2150        };
2151        let direct = CompileConfig {
2152            target: TargetSpec::cortex_m4(),
2153            no_optimize: true,
2154            ..CompileConfig::default()
2155        };
2156        let a = backend
2157            .compile_function("dispatch", &ops, &opt)
2158            .expect("optimized-default must compile br_table (via decline)");
2159        let b = backend
2160            .compile_function("dispatch", &ops, &direct)
2161            .expect("direct must compile br_table");
2162        assert_eq!(
2163            a.code, b.code,
2164            "#507: optimized-default br_table output must be byte-identical to the \
2165             direct selector (i.e. declined to direct), not a dropped dispatch"
2166        );
2167    }
2168
2169    /// Issue #94: end-to-end byte-size check for the canonical u64-packed
2170    /// FFI-return hi32 extract pattern. Compiles two near-identical
2171    /// functions — one with the optimized shift-by-32, one with a generic
2172    /// shift-by-7 — and asserts the optimized form is meaningfully smaller.
2173    #[test]
2174    fn test_issue94_hi32_extract_is_smaller_than_generic_shift() {
2175        let backend = ArmBackend::new();
2176        let config = CompileConfig {
2177            target: TargetSpec::cortex_m4f(),
2178            ..CompileConfig::default()
2179        };
2180
2181        // #518: the i64 value must NOT come from an i64 PARAM — the optimized
2182        // path now declines i64-param functions to the direct selector (it homed
2183        // an i64 param in R4:R5 instead of R0:R1, a silent miscompile this test's
2184        // byte-size-only assertion masked). The canonical #94 case is a u64 from
2185        // an FFI return, not a param, anyway. Source the i64 from a sign-extended
2186        // i32 param (`extend_i32_s`): a runtime, non-constant-foldable i64 that
2187        // stays on the optimized path, so the shift-by-32 hi-extract peephole is
2188        // still exercised on CORRECT code.
2189        // Optimized path: `(i64.extend_i32_s (local.get 0)) >>> 32; wrap_i64`
2190        let ops_hi32 = vec![
2191            WasmOp::LocalGet(0), // i32 param in R0
2192            WasmOp::I64ExtendI32S,
2193            WasmOp::I64Const(32),
2194            WasmOp::I64ShrU,
2195            WasmOp::I32WrapI64,
2196        ];
2197        let func_hi32 = backend
2198            .compile_function("hi32_extract", &ops_hi32, &config)
2199            .unwrap();
2200
2201        // Generic path: `... >>> 7; wrap_i64` — same shape, but the shift amount
2202        // is not a multiple of 32, so it falls through to the runtime shift.
2203        let ops_generic = vec![
2204            WasmOp::LocalGet(0),
2205            WasmOp::I64ExtendI32S,
2206            WasmOp::I64Const(7),
2207            WasmOp::I64ShrU,
2208            WasmOp::I32WrapI64,
2209        ];
2210        let func_generic = backend
2211            .compile_function("generic_shr", &ops_generic, &config)
2212            .unwrap();
2213
2214        let bytes_hi32 = func_hi32.code.len();
2215        let bytes_generic = func_generic.code.len();
2216        println!(
2217            "\n[issue #94] hi32 extract: {} bytes (vs generic shift: {} bytes; saved {})",
2218            bytes_hi32,
2219            bytes_generic,
2220            bytes_generic.saturating_sub(bytes_hi32)
2221        );
2222        let hex: String = func_hi32
2223            .code
2224            .iter()
2225            .map(|b| format!("{:02x}", b))
2226            .collect::<Vec<_>>()
2227            .join(" ");
2228        println!("[issue #94] hi32 bytes: {}", hex);
2229        // We expect the optimized form to be at least 30 bytes smaller than
2230        // the generic 64-bit shift sequence. (Empirically: 14 vs 50 bytes.)
2231        assert!(
2232            bytes_hi32 + 30 <= bytes_generic,
2233            "issue #94: hi32 extract = {} bytes, generic shift = {} bytes; \
2234             expected optimized form to be at least 30 bytes smaller",
2235            bytes_hi32,
2236            bytes_generic,
2237        );
2238    }
2239}