1use serde_json::{json, Value};
17use ssp2::segment::{decode_rows_segment, encode_rows_segment};
18use ssp2::{
19 decode_message, encode_message, parse_control, render_message, render_rows_segment,
20 ControlMessage,
21};
22use syncular_client::previous_version::{PreviousVersionContextConfig, PreviousVersionReadSpec};
23use syncular_client::{
24 ClientError, ClientLimits, CommandEffects, CommitOutcomeQuery, LocalDataPurgeInput,
25 LocalDataRebootstrapInput, Mutation, QueryOwner, QueryReadFailure, RealtimePolicy,
26 ResolveCommitOutcomeInput, SyncClient, Transport, TransportError, UnitScopes, WindowBase,
27 WindowCoverage, LOCAL_AUTHORITY_UNCONFIGURED_CODE,
28};
29
30pub fn bytes_to_hex(bytes: &[u8]) -> String {
33 syncular_client::values::bytes_to_hex(bytes)
34}
35
36pub fn hex_to_bytes(hex: &str) -> Result<Vec<u8>, String> {
37 syncular_client::values::hex_to_bytes(hex)
38}
39
40pub fn bytes_value(bytes: &[u8]) -> Value {
41 Value::Object(serde_json::Map::from_iter([(
42 "$bytes".to_owned(),
43 Value::from(bytes_to_hex(bytes)),
44 )]))
45}
46
47pub fn value_bytes(value: Option<&Value>) -> Result<Vec<u8>, String> {
48 let hex = value
49 .and_then(|v| v.get("$bytes"))
50 .and_then(Value::as_str)
51 .ok_or_else(|| "expected a {\"$bytes\": hex} value".to_owned())?;
52 hex_to_bytes(hex)
53}
54
55#[derive(Debug, Clone)]
59pub struct CommandError {
60 pub code: String,
61 pub message: String,
62 pub details: Option<Value>,
63 pub retryable: bool,
64}
65
66impl CommandError {
67 pub fn new(code: impl Into<String>, message: impl Into<String>) -> Self {
68 Self {
69 code: code.into(),
70 message: message.into(),
71 details: None,
72 retryable: false,
73 }
74 }
75
76 pub fn from_client(error: ClientError) -> Self {
78 Self {
79 code: error.code,
80 message: error.message,
81 details: error.details,
82 retryable: error.retryable,
83 }
84 }
85}
86
87impl From<(String, String)> for CommandError {
88 fn from((code, message): (String, String)) -> Self {
89 Self {
90 code,
91 message,
92 details: None,
93 retryable: false,
94 }
95 }
96}
97
98#[derive(Debug, Default, Clone)]
102pub struct CreateEffects {
103 pub signed_urls: bool,
106 pub security_preflight_pending: bool,
122}
123
124fn read_command_error(failure: QueryReadFailure) -> CommandError {
127 let details = failure.details();
128 let retryable = failure.retryable();
129 CommandError {
130 code: failure.code.unwrap_or("client.failed").to_owned(),
131 message: failure.message,
132 details,
133 retryable,
134 }
135}
136
137fn client_err(message: String) -> CommandError {
141 let code = ClientError::from(message.clone()).code;
142 let retryable = code == "client.storage_busy";
143 CommandError {
144 code,
145 message,
146 details: None,
147 retryable,
148 }
149}
150
151fn optional<'a, T>(
155 value: Option<&'a Value>,
156 field: &str,
157 read: impl FnOnce(&'a Value) -> Option<T>,
158) -> Result<Option<T>, String> {
159 match value {
160 None | Some(Value::Null) => Ok(None),
161 Some(value) => read(value)
162 .map(Some)
163 .ok_or_else(|| format!("sync.invalid_request: {field} has the wrong type")),
164 }
165}
166
167fn transport_command_error(error: TransportError) -> CommandError {
170 CommandError {
171 code: error.code,
172 message: error.message,
173 details: error.details,
174 retryable: false,
175 }
176}
177
178fn need_client(client: &mut Option<SyncClient>) -> Result<&mut SyncClient, CommandError> {
179 client
180 .as_mut()
181 .ok_or_else(|| client_err("no client instance created".to_owned()))
182}
183
184pub fn parse_previous_version_context(
189 value: Option<&Value>,
190) -> Result<Option<PreviousVersionContextConfig>, CommandError> {
191 let Some(value) = value else {
192 return Ok(None);
193 };
194 let object = value.as_object().ok_or_else(|| {
195 client_err("sync.invalid_request: previousVersionContext must be an object".to_owned())
196 })?;
197 let enabled = match object.get("enabled") {
198 None => false,
199 Some(Value::Bool(enabled)) => *enabled,
200 Some(_) => {
201 return Err(client_err(
202 "sync.invalid_request: previousVersionContext.enabled must be a boolean".to_owned(),
203 ))
204 }
205 };
206 let mut config = PreviousVersionContextConfig {
207 enabled,
208 ..PreviousVersionContextConfig::default()
209 };
210 for (key, slot) in [
211 ("maxBytes", &mut config.max_bytes),
212 ("maxRows", &mut config.max_rows),
213 ("maxTables", &mut config.max_tables),
214 ("maxRowBytes", &mut config.max_row_bytes),
215 ("maxAgeMs", &mut config.max_age_ms),
216 ] {
217 if let Some(raw) = object.get(key) {
218 *slot = raw.as_i64().ok_or_else(|| {
219 client_err(format!(
220 "sync.invalid_request: previousVersionContext.{key} must be a positive safe integer"
221 ))
222 })?;
223 }
224 }
225 config.validate().map_err(client_err)?;
226 Ok(Some(config))
227}
228
229fn parse_previous_version_snapshot_spec(
231 params: &Value,
232) -> Result<PreviousVersionReadSpec, CommandError> {
233 let table = params.get("table").and_then(Value::as_str).ok_or_else(|| {
234 client_err("sync.invalid_request: previousVersionSnapshot missing table".to_owned())
235 })?;
236 let row_ids = match params.get("rowIds") {
237 None | Some(Value::Null) => Vec::new(),
238 Some(Value::Array(ids)) => ids
239 .iter()
240 .map(|id| match id {
241 Value::String(id) => Ok(id.clone()),
242 Value::Number(number) => Ok(number.to_string()),
243 Value::Bool(boolean) => Ok(boolean.to_string()),
244 _ => Err(client_err(
245 "sync.invalid_request: previousVersionSnapshot rowIds must be strings"
246 .to_owned(),
247 )),
248 })
249 .collect::<Result<Vec<_>, _>>()?,
250 Some(_) => {
251 return Err(client_err(
252 "sync.invalid_request: previousVersionSnapshot rowIds must be an array".to_owned(),
253 ))
254 }
255 };
256 let limit = match params.get("limit") {
257 None | Some(Value::Null) => None,
258 Some(value) => Some(value.as_i64().ok_or_else(|| {
259 client_err(
260 "sync.invalid_request: previousVersionSnapshot limit must be a positive number"
261 .to_owned(),
262 )
263 })?),
264 };
265 Ok(PreviousVersionReadSpec {
266 table: table.to_owned(),
267 row_ids,
268 limit,
269 })
270}
271
272pub fn parse_limits(value: Option<&Value>) -> Result<ClientLimits, CommandError> {
273 let mut limits = ClientLimits::default();
274 let Some(object) = optional(value, "limits", Value::as_object).map_err(client_err)? else {
275 return Ok(limits);
276 };
277 let i32_field = |key: &str| {
278 optional(object.get(key), key, |v| {
279 v.as_i64().and_then(|n| i32::try_from(n).ok())
280 })
281 .map_err(client_err)
282 };
283 limits.limit_commits = i32_field("limitCommits")?;
284 limits.limit_snapshot_rows = i32_field("limitSnapshotRows")?;
285 limits.max_snapshot_pages = i32_field("maxSnapshotPages")?;
286 limits.accept = optional(object.get("accept"), "limits.accept", |v| {
287 v.as_u64().and_then(|n| u8::try_from(n).ok())
288 })
289 .map_err(client_err)?;
290 limits.blob_cache_max_bytes = optional(
291 object.get("blobCacheMaxBytes"),
292 "limits.blobCacheMaxBytes",
293 Value::as_i64,
294 )
295 .map_err(client_err)?;
296 limits.outcome_retention_max_entries = optional(
297 object.get("outcomeRetentionMaxEntries"),
298 "limits.outcomeRetentionMaxEntries",
299 |v| v.as_u64().and_then(|n| usize::try_from(n).ok()),
300 )
301 .map_err(client_err)?;
302 limits.max_push_commits_per_request = parse_push_limit(object, "maxPushCommitsPerRequest")?;
303 limits.max_push_operations_per_request =
304 parse_push_limit(object, "maxPushOperationsPerRequest")?;
305 limits.max_push_request_bytes = parse_push_limit(object, "maxPushRequestBytes")?;
306 Ok(limits)
307}
308
309fn parse_push_limit(
312 object: &serde_json::Map<String, Value>,
313 key: &str,
314) -> Result<Option<usize>, CommandError> {
315 match object.get(key) {
316 None | Some(Value::Null) => Ok(None),
317 Some(value) => value
318 .as_u64()
319 .and_then(|n| usize::try_from(n).ok())
320 .filter(|n| *n >= 1 && *n <= u32::MAX as usize)
321 .map(Some)
322 .ok_or_else(|| CommandError {
323 code: "sync.invalid_request".to_owned(),
324 message: "push limit must be an integer in 1..=4294967295".to_owned(),
325 details: Some(serde_json::json!({ "limit": key })),
326 retryable: false,
327 }),
328 }
329}
330
331fn parse_realtime_policy(value: Option<&Value>) -> Result<RealtimePolicy, CommandError> {
333 match value {
334 None => Ok(RealtimePolicy::Optional),
335 Some(Value::String(text)) => match text.as_str() {
336 "required" => Ok(RealtimePolicy::Required),
337 "optional" => Ok(RealtimePolicy::Optional),
338 "off" => Ok(RealtimePolicy::Off),
339 other => Err(client_err(format!(
340 "sync.invalid_request: realtimePolicy must be 'required', 'optional', or 'off', got {other:?}"
341 ))),
342 },
343 Some(_) => Err(client_err(
344 "sync.invalid_request: realtimePolicy must be a string".to_owned(),
345 )),
346 }
347}
348
349pub fn parse_encryption(
354 value: &Value,
355) -> Result<syncular_client::values::EncryptionConfig, String> {
356 let mut config = syncular_client::values::EncryptionConfig::default();
357 let keys = optional(value.get("keys"), "encryption.keys", Value::as_object)?;
358 for (key_id, key_val) in keys.into_iter().flatten() {
359 let bytes =
360 value_bytes(Some(key_val)).map_err(|e| format!("encryption key {key_id:?}: {e}"))?;
361 if bytes.len() != 32 {
362 return Err(format!(
363 "encryption key {key_id:?} must be 32 bytes, got {}",
364 bytes.len()
365 ));
366 }
367 config.keys.insert(key_id.clone(), bytes);
368 }
369 if let Some(columns) = value.get("keyIdColumns") {
370 let columns = columns
371 .as_object()
372 .ok_or_else(|| "encryption keyIdColumns must be an object".to_owned())?;
373 for (table, column) in columns {
374 let column = column.as_str().ok_or_else(|| {
375 format!("encryption keyIdColumns entry for {table:?} must be a string")
376 })?;
377 if column.is_empty() {
378 return Err(format!(
379 "encryption keyIdColumns entry for {table:?} must not be empty"
380 ));
381 }
382 config
383 .key_id_columns
384 .insert(table.clone(), column.to_owned());
385 }
386 }
387 config.missing_key = match value.get("missingKey") {
388 None | Some(Value::Null) => syncular_client::values::MissingKey::Fail,
389 Some(Value::String(mode)) if mode == "fail" => syncular_client::values::MissingKey::Fail,
390 Some(Value::String(mode)) if mode == "seal" => syncular_client::values::MissingKey::Seal,
391 Some(_) => return Err("encryption missingKey must be 'fail' or 'seal'".to_owned()),
392 };
393 Ok(config)
394}
395
396pub fn parse_headers(value: &Value) -> Result<Vec<(String, String)>, String> {
401 let object = value.as_object().ok_or_else(|| {
402 "sync.invalid_request: headers must be an object of string values".to_owned()
403 })?;
404 let mut headers = Vec::with_capacity(object.len());
405 for (name, value) in object {
406 let value = value
407 .as_str()
408 .ok_or_else(|| format!("sync.invalid_request: header {name:?} must be a string"))?;
409 headers.push((name.clone(), value.to_owned()));
410 }
411 Ok(headers)
412}
413
414pub fn parse_mutations(value: Option<&Value>) -> Result<Vec<Mutation>, String> {
415 let list = value
416 .and_then(Value::as_array)
417 .ok_or_else(|| "mutations must be a list".to_owned())?;
418 let mut out = Vec::with_capacity(list.len());
419 for entry in list {
420 let op = entry
421 .get("op")
422 .and_then(Value::as_str)
423 .ok_or_else(|| "mutation missing op".to_owned())?;
424 let table = entry
425 .get("table")
426 .and_then(Value::as_str)
427 .ok_or_else(|| "mutation missing table".to_owned())?
428 .to_owned();
429 let base_version = optional(entry.get("baseVersion"), "baseVersion", Value::as_i64)?;
430 match op {
431 "upsert" | "patch" => {
432 let mut values = entry
433 .get("values")
434 .and_then(Value::as_object)
435 .cloned()
436 .ok_or_else(|| "upsert missing values".to_owned())?;
437 decode_bigint_members(&mut values)?;
438 out.push(if op == "patch" {
439 Mutation::Patch {
440 table,
441 values,
442 base_version,
443 }
444 } else {
445 Mutation::Upsert {
446 table,
447 values,
448 base_version,
449 }
450 });
451 }
452 "delete" => {
453 let row_id = entry
454 .get("rowId")
455 .and_then(Value::as_str)
456 .ok_or_else(|| "delete missing rowId".to_owned())?
457 .to_owned();
458 out.push(Mutation::Delete {
459 table,
460 row_id,
461 base_version,
462 });
463 }
464 other => return Err(format!("unknown mutation op {other:?}")),
465 }
466 }
467 Ok(out)
468}
469
470fn decode_bigint_members(values: &mut serde_json::Map<String, Value>) -> Result<(), String> {
471 for value in values.values_mut() {
472 let Some(decimal) = value.get("$bigint").and_then(Value::as_str) else {
473 continue;
474 };
475 let integer = decimal
476 .parse::<i64>()
477 .map_err(|_| format!("bigint value {decimal:?} is outside SQLite's i64 range"))?;
478 *value = Value::from(integer);
479 }
480 Ok(())
481}
482
483fn unit_scopes(value: Option<&Value>) -> Result<UnitScopes, String> {
485 serde_json::from_value(value.cloned().unwrap_or(Value::Null)).map_err(|_| {
486 "sync.invalid_request: a unit scope map is an object of string values".to_owned()
487 })
488}
489
490fn window_base_from_params(value: Option<&Value>) -> Result<WindowBase, String> {
493 let object = value
494 .and_then(Value::as_object)
495 .ok_or_else(|| "sync.invalid_request: window base must be an object".to_owned())?;
496 let variable = object
497 .get("variable")
498 .and_then(Value::as_str)
499 .ok_or_else(|| "sync.invalid_request: window base missing variable".to_owned())?
500 .to_owned();
501 Ok(WindowBase {
502 variable,
503 fixed_scopes: match object.get("fixedScopes") {
504 None | Some(Value::Null) => UnitScopes::new(),
505 scopes => unit_scopes(scopes)?,
506 },
507 })
508}
509
510pub fn parse_window_coverage(value: Option<&Value>) -> Result<Vec<WindowCoverage>, String> {
515 let entries = match value {
516 None | Some(Value::Null) => return Ok(Vec::new()),
517 Some(Value::Array(entries)) => entries,
518 Some(_) => return Err("sync.invalid_request: coverage must be a list".to_owned()),
519 };
520 let mut coverage = Vec::with_capacity(entries.len());
521 for entry in entries {
522 let units = match entry.get("units") {
523 None | Some(Value::Null) => Vec::new(),
524 Some(Value::Array(values)) => values
525 .iter()
526 .map(|value| value.as_str().map(str::to_owned))
527 .collect::<Option<Vec<_>>>()
528 .ok_or_else(|| {
529 "sync.invalid_request: coverage units must be a list of strings".to_owned()
530 })?,
531 Some(_) => {
532 return Err(
533 "sync.invalid_request: coverage units must be a list of strings".to_owned(),
534 )
535 }
536 };
537 coverage.push(WindowCoverage {
538 base: window_base_from_params(entry.get("base"))?,
539 units,
540 });
541 }
542 Ok(coverage)
543}
544
545fn parse_query_owner<'a>(
548 params: &'a Value,
549 method: &str,
550) -> Result<Option<(&'a str, Vec<&'a str>)>, CommandError> {
551 match params.get("owner") {
552 None | Some(Value::Null) => Ok(None),
553 Some(value) => {
554 let id = value
555 .get("id")
556 .and_then(Value::as_str)
557 .filter(|id| !id.is_empty());
558 let tables = value
559 .get("tables")
560 .and_then(Value::as_array)
561 .and_then(|list| {
562 list.iter()
563 .map(Value::as_str)
564 .collect::<Option<Vec<&str>>>()
565 });
566 match (id, tables) {
567 (Some(id), Some(tables)) => Ok(Some((id, tables))),
568 _ => Err(client_err(format!(
569 "sync.invalid_request: {method} owner must be {{id: non-empty string, tables: string[]}}"
570 ))),
571 }
572 }
573 }
574}
575
576fn snapshot_string_list(value: Option<&Value>) -> Result<Vec<String>, CommandError> {
579 match value {
580 None | Some(Value::Null) => Ok(Vec::new()),
581 Some(Value::Array(items)) => items
582 .iter()
583 .map(|item| item.as_str().map(str::to_owned))
584 .collect::<Option<Vec<String>>>()
585 .ok_or_else(|| {
586 client_err(
587 "sync.invalid_request: snapshotRead list must contain strings".to_owned(),
588 )
589 }),
590 Some(_) => Err(client_err(
591 "sync.invalid_request: snapshotRead list must be a list of strings".to_owned(),
592 )),
593 }
594}
595
596#[cfg(feature = "crdt-yjs")]
600fn crdt_target(params: &Value) -> Result<(String, String, String, String), CommandError> {
601 let table = params
602 .get("table")
603 .and_then(Value::as_str)
604 .ok_or_else(|| client_err("crdt command missing table".to_owned()))?
605 .to_owned();
606 let row_id = params
607 .get("rowId")
608 .and_then(Value::as_str)
609 .ok_or_else(|| client_err("crdt command missing rowId".to_owned()))?
610 .to_owned();
611 let column = params
612 .get("column")
613 .and_then(Value::as_str)
614 .ok_or_else(|| client_err("crdt command missing column".to_owned()))?
615 .to_owned();
616 let name = optional(params.get("name"), "crdt name", Value::as_str)
617 .map_err(client_err)?
618 .unwrap_or("text")
619 .to_owned();
620 Ok((table, row_id, column, name))
621}
622
623pub fn dispatch<T: Transport>(
633 transport: &mut T,
634 client: &mut Option<SyncClient>,
635 effects: &mut CreateEffects,
636 method: &str,
637 params: &Value,
638) -> Result<Value, CommandError> {
639 if method == "create" {
640 let requests_preflight = optional(
647 params.get("securityPreflight"),
648 "securityPreflight",
649 Value::as_bool,
650 )
651 .map_err(client_err)?
652 .unwrap_or(false);
653 let preflight_engaged = client.as_ref().map_or(
654 effects.security_preflight_pending,
655 SyncClient::security_preflight,
656 );
657 if preflight_engaged && !requests_preflight {
658 return Err(CommandError::new(
659 syncular_client::SECURITY_PREFLIGHT_REQUIRED_CODE,
660 "the local replica is in security preflight; a replacement create must itself request securityPreflight, and protected data opens only after activateSecurity",
661 ));
662 }
663 } else {
664 let allowed_during_preflight = matches!(
665 method,
666 "authoritySnapshot"
667 | "securityLifecycle"
668 | "beginSecurityPreflight"
669 | "activateSecurity"
670 | "setTransportEnabled"
671 | "disconnectRealtime"
672 | "purgeLocalData"
673 | "previousVersionDiscard"
674 | "localRevision"
675 | "statusSnapshot"
676 | "localAuthorityState"
677 | "drainRealtime"
678 | "shutdown"
679 );
680 if client
681 .as_ref()
682 .is_some_and(|running| running.security_preflight())
683 && !allowed_during_preflight
684 {
685 return Err(CommandError::new(
686 syncular_client::SECURITY_PREFLIGHT_REQUIRED_CODE,
687 "the local replica is in security preflight; complete quarantine checks and call activateSecurity before accessing protected data",
688 ));
689 }
690 }
691 let mut result = match method {
692 "create" => {
693 let client_id = optional(params.get("clientId"), "clientId", Value::as_str)
694 .map_err(client_err)?
695 .map(str::to_owned);
696 let db_path =
697 optional(params.get("dbPath"), "dbPath", Value::as_str).map_err(client_err)?;
698 let schema = params
699 .get("schema")
700 .ok_or_else(|| client_err("create missing schema".to_owned()))?;
701 let limits = parse_limits(params.get("limits"))?;
702 let previous_version_context =
706 parse_previous_version_context(params.get("previousVersionContext"))?;
707 let mut limits = limits;
708 limits.previous_version_context = previous_version_context;
709 if let Some(reads) = params.get("authorityReads") {
710 limits.authority_reads = serde_json::from_value(reads.clone()).map_err(|_| {
711 client_err(
712 "client.authority_read_forbidden: invalid authority declaration".into(),
713 )
714 })?;
715 }
716 transport
719 .open_local_authority(schema, db_path)
720 .map_err(transport_command_error)?;
721 let mut instance = match db_path {
725 Some(path) => SyncClient::open_path_with_identity(client_id, schema, limits, path)
726 .map_err(client_err)?,
727 None => {
728 SyncClient::new_with_identity(client_id, schema, limits).map_err(client_err)?
729 }
730 };
731 instance
732 .set_retain_failed_commits(
733 optional(
734 params.get("retainFailedCommits"),
735 "retainFailedCommits",
736 Value::as_bool,
737 )
738 .map_err(client_err)?
739 .unwrap_or(false),
740 )
741 .map_err(client_err)?;
742 let realtime_policy = parse_realtime_policy(params.get("realtimePolicy"))?;
745 instance
746 .set_realtime_policy(realtime_policy)
747 .map_err(client_err)?;
748 if let Some(now_ms) =
750 optional(params.get("nowMs"), "nowMs", Value::as_i64).map_err(client_err)?
751 {
752 instance.set_now_ms(now_ms);
753 }
754 effects.signed_urls = optional(params.get("signedUrls"), "signedUrls", Value::as_bool)
757 .map_err(client_err)?
758 .unwrap_or(false);
759 let security_preflight = optional(
764 params.get("securityPreflight"),
765 "securityPreflight",
766 Value::as_bool,
767 )
768 .map_err(client_err)?
769 .unwrap_or(false);
770 if instance.security_preflight() && !security_preflight {
778 return Err(CommandError::new(
779 syncular_client::SECURITY_PREFLIGHT_REQUIRED_CODE,
780 "the local replica is in security preflight; a replacement create must itself request securityPreflight, and protected data opens only after activateSecurity",
781 ));
782 }
783 if security_preflight && params.get("encryption").is_some() {
784 return Err(client_err(
785 "sync.invalid_request: securityPreflight and encryption are mutually exclusive; install keys with activateSecurity after preflight"
786 .to_owned(),
787 ));
788 }
789 if let Some(enc) = params.get("encryption") {
790 let config = parse_encryption(enc).map_err(client_err)?;
791 instance.set_encryption(config);
792 }
793 if security_preflight {
794 instance.begin_security_preflight().map_err(client_err)?;
795 }
796 if let Some(enabled) = params.get("transportEnabled") {
797 let enabled = enabled.as_bool().ok_or_else(|| {
798 client_err("sync.invalid_request: transportEnabled must be a boolean".into())
799 })?;
800 instance.set_transport_enabled(transport, enabled);
801 }
802 effects.security_preflight_pending = security_preflight;
803 *client = Some(instance);
804 Ok(json!({}))
805 }
806 "securityLifecycle" => Ok(json!({
807 "state": need_client(client)?.security_lifecycle()
808 })),
809 "beginSecurityPreflight" => {
810 let running = need_client(client)?;
811 running.disconnect_realtime(transport);
812 running.begin_security_preflight().map_err(client_err)?;
813 effects.security_preflight_pending = true;
814 Ok(json!({}))
815 }
816 "authoritySnapshot" => {
817 if !params.as_object().is_some_and(|p| p.is_empty()) {
818 return Err(client_err(
819 "client.authority_read_forbidden: authoritySnapshot accepts no arguments"
820 .into(),
821 ));
822 }
823 client
824 .as_ref()
825 .ok_or_else(|| client_err("client.closed: no authority client is open".into()))?
826 .authority_snapshot()
827 .map_err(client_err)
828 }
829 "activateSecurity" => {
830 let encryption = match params.get("encryption") {
831 Some(value) => parse_encryption(value).map_err(client_err)?,
832 None => syncular_client::values::EncryptionConfig::default(),
833 };
834 if let Some(headers) = params.get("headers") {
840 parse_headers(headers).map_err(client_err)?;
841 }
842 need_client(client)?
843 .activate_security(encryption)
844 .map_err(client_err)?;
845 effects.security_preflight_pending = false;
846 Ok(json!({}))
847 }
848 "setTransportEnabled" => {
849 let enabled = params
850 .get("enabled")
851 .and_then(Value::as_bool)
852 .ok_or_else(|| {
853 client_err(
854 "sync.invalid_request: setTransportEnabled.enabled must be a boolean"
855 .into(),
856 )
857 })?;
858 need_client(client)?.set_transport_enabled(transport, enabled);
859 Ok(json!({}))
860 }
861 "setHeaders" => {
862 let headers = params
863 .get("headers")
864 .ok_or_else(|| client_err("setHeaders missing headers".to_owned()))?;
865 parse_headers(headers).map_err(client_err)?;
866 Ok(json!({}))
867 }
868 "shutdown" => {
869 if let Some(running) = client.as_mut() {
870 effects.security_preflight_pending = running.security_preflight();
875 running.disconnect_realtime(transport);
876 running.seal_security_on_teardown();
880 }
881 *client = None;
882 Ok(json!({}))
883 }
884 "subscribe" => {
885 let scopes = unit_scopes(params.get("scopes")).map_err(client_err)?;
886 let id = need_client(client)?.subscribe(scopes).map_err(client_err)?;
887 Ok(json!({ "id": id }))
888 }
889 "subscribeMany" => {
890 let units = params
891 .get("units")
892 .and_then(Value::as_array)
893 .ok_or_else(|| {
894 client_err(
895 "sync.invalid_request: subscribeMany units must be a list".to_owned(),
896 )
897 })?
898 .iter()
899 .map(|scopes| unit_scopes(Some(scopes)))
900 .collect::<Result<Vec<_>, _>>()
901 .map_err(client_err)?;
902 let ids = need_client(client)?
903 .subscribe_many(units)
904 .map_err(client_err)?;
905 Ok(json!({ "ids": ids }))
906 }
907 "unsubscribe" => {
908 let id = params
909 .get("id")
910 .and_then(Value::as_str)
911 .ok_or_else(|| client_err("unsubscribe missing id".to_owned()))?;
912 need_client(client)?.unsubscribe(id).map_err(client_err)?;
913 Ok(json!({}))
914 }
915 "setWindow" => {
916 let base = window_base_from_params(params.get("base")).map_err(client_err)?;
917 let units: Vec<String> = optional(params.get("units"), "setWindow units", |v| {
918 v.as_array()?
919 .iter()
920 .map(|unit| unit.as_str().map(str::to_owned))
921 .collect()
922 })
923 .map_err(client_err)?
924 .unwrap_or_default();
925 let command_effects = need_client(client)?
926 .set_window(&base, &units)
927 .map_err(client_err)?;
928 Ok(json!({ "effects": command_effects }))
929 }
930 "windowState" => {
931 let base = window_base_from_params(params.get("base")).map_err(client_err)?;
932 let state = need_client(client)?
933 .window_state(&base)
934 .map_err(client_err)?;
935 Ok(json!({ "units": state.units, "pending": state.pending }))
936 }
937 "timeWindowSugar" => {
938 let created_at_ms = params
939 .get("createdAtMs")
940 .and_then(Value::as_i64)
941 .ok_or_else(|| client_err("timeWindowSugar missing createdAtMs".to_owned()))?;
942 let count = params
943 .get("count")
944 .and_then(Value::as_u64)
945 .and_then(|value| usize::try_from(value).ok())
946 .ok_or_else(|| client_err("timeWindowSugar missing count".to_owned()))?;
947 let now_ms = params
948 .get("nowMs")
949 .and_then(Value::as_i64)
950 .ok_or_else(|| client_err("timeWindowSugar missing nowMs".to_owned()))?;
951 if params.get("unit").and_then(Value::as_str) != Some("month") {
952 return Err(client_err(
953 "sync.invalid_request: timeWindowSugar requires the month unit".to_owned(),
954 ));
955 }
956 let unit = syncular_client::TimeBucketUnit::Month;
957 Ok(json!({
958 "bucket": syncular_client::creation_time_bucket(created_at_ms, unit)
959 .map_err(client_err)?,
960 "units": syncular_client::last(count, unit, now_ms).map_err(client_err)?,
961 }))
962 }
963 "mutate" => {
964 let mutations = parse_mutations(params.get("mutations")).map_err(client_err)?;
965 let client_commit_id = match params.get("clientCommitId") {
967 None | Some(Value::Null) => None,
968 Some(Value::String(id)) => Some(id.clone()),
969 Some(_) => {
970 return Err(client_err(
971 "sync.invalid_request: clientCommitId must be a string".to_owned(),
972 ))
973 }
974 };
975 let id = need_client(client)?
976 .mutate_with_commit_id(mutations, client_commit_id)
977 .map_err(CommandError::from_client)?;
978 Ok(json!({
979 "clientCommitId": id,
980 "effects": CommandEffects::interactive()
981 }))
982 }
983 "patch" => {
984 let table = params
985 .get("table")
986 .and_then(Value::as_str)
987 .ok_or_else(|| client_err("patch missing table".to_owned()))?;
988 let row_id = params
989 .get("rowId")
990 .and_then(Value::as_str)
991 .ok_or_else(|| client_err("patch missing rowId".to_owned()))?;
992 let mut partial = params
993 .get("partial")
994 .and_then(Value::as_object)
995 .cloned()
996 .ok_or_else(|| client_err("patch missing partial object".to_owned()))?;
997 decode_bigint_members(&mut partial).map_err(client_err)?;
998 let base_version = optional(params.get("baseVersion"), "baseVersion", Value::as_i64)
999 .map_err(client_err)?;
1000 let id = need_client(client)?
1001 .patch(table, row_id, partial, base_version)
1002 .map_err(CommandError::from_client)?;
1003 Ok(json!({
1004 "clientCommitId": id,
1005 "effects": CommandEffects::interactive()
1006 }))
1007 }
1008 "purgeLocalData" => {
1009 let input: LocalDataPurgeInput =
1010 serde_json::from_value(params.get("input").cloned().ok_or_else(|| {
1011 client_err("sync.invalid_request: purgeLocalData missing input".to_owned())
1012 })?)
1013 .map_err(|error| {
1014 client_err(format!(
1015 "sync.invalid_request: invalid purgeLocalData input: {error}"
1016 ))
1017 })?;
1018 let result = need_client(client)?
1019 .purge_local_data(&input)
1020 .map_err(client_err)?;
1021 serde_json::to_value(result).map_err(|error| client_err(error.to_string()))
1022 }
1023 "rebootstrapLocalData" => {
1024 let input: LocalDataRebootstrapInput =
1025 serde_json::from_value(params.get("input").cloned().ok_or_else(|| {
1026 client_err(
1027 "sync.invalid_request: rebootstrapLocalData missing input".to_owned(),
1028 )
1029 })?)
1030 .map_err(|error| {
1031 client_err(format!(
1032 "sync.invalid_request: invalid rebootstrapLocalData input: {error}"
1033 ))
1034 })?;
1035 let result = need_client(client)?
1036 .rebootstrap_local_data(&input)
1037 .map_err(client_err)?;
1038 Ok(json!({
1039 "alreadyApplied": result.already_applied,
1040 "retainedCommits": result.retained_commits,
1041 "resetSubscriptions": result.reset_subscriptions,
1042 "effects": if result.already_applied {
1043 CommandEffects::none()
1044 } else {
1045 CommandEffects::interactive()
1046 }
1047 }))
1048 }
1049 "sync" => {
1050 let outcome = need_client(client)?.sync(transport);
1051 Ok(outcome.to_json())
1052 }
1053 "resetClientId" | "reset_client_id" => {
1054 let client_id = need_client(client)?
1055 .reset_client_id(transport)
1056 .map_err(client_err)?;
1057 Ok(json!({ "clientId": client_id }))
1058 }
1059 "syncUntilIdle" => {
1060 let max_rounds = match params.get("maxRounds") {
1061 None | Some(Value::Null) => None,
1062 Some(value) => Some(
1063 value
1064 .as_u64()
1065 .and_then(|n| u32::try_from(n).ok())
1066 .filter(|n| *n >= 1)
1067 .ok_or_else(|| {
1068 client_err(
1069 "sync.invalid_request: maxRounds must be a positive integer"
1070 .to_owned(),
1071 )
1072 })?,
1073 ),
1074 };
1075 let timeout_ms = match params.get("timeoutMs") {
1076 None | Some(Value::Null) => None,
1077 Some(value) => Some(value.as_u64().filter(|ms| *ms >= 1).ok_or_else(|| {
1078 client_err(
1079 "sync.invalid_request: timeoutMs must be a positive integer".to_owned(),
1080 )
1081 })?),
1082 };
1083 let client = need_client(client)?;
1084 let outcome = match timeout_ms {
1085 Some(timeout_ms) => {
1086 client.sync_until_idle_with_deadline(transport, max_rounds, Some(timeout_ms))
1087 }
1088 None => client.sync_until_idle(transport, max_rounds),
1089 };
1090 Ok(outcome.to_json())
1091 }
1092 "proveCurrentBase" => {
1093 let outcome = params
1094 .get("outcome")
1095 .and_then(Value::as_object)
1096 .ok_or_else(|| client_err("proveCurrentBase missing outcome".to_owned()))?;
1097 let id = outcome
1098 .get("clientCommitId")
1099 .and_then(Value::as_str)
1100 .ok_or_else(|| client_err("proveCurrentBase missing clientCommitId".to_owned()))?;
1101 let sequence = outcome
1102 .get("sequence")
1103 .and_then(Value::as_i64)
1104 .ok_or_else(|| client_err("proveCurrentBase missing sequence".to_owned()))?;
1105 let max_rounds = match params.get("maxRounds") {
1106 None | Some(Value::Null) => None,
1107 Some(value) => Some(
1108 value
1109 .as_u64()
1110 .and_then(|n| u32::try_from(n).ok())
1111 .filter(|n| *n >= 1)
1112 .ok_or_else(|| {
1113 client_err(
1114 "sync.invalid_request: maxRounds must be a positive integer"
1115 .to_owned(),
1116 )
1117 })?,
1118 ),
1119 };
1120 Ok(json!(
1121 need_client(client)?.prove_current_base(transport, id, sequence, max_rounds)
1122 ))
1123 }
1124 "readRows" => {
1125 let table = params
1126 .get("table")
1127 .and_then(Value::as_str)
1128 .ok_or_else(|| client_err("readRows missing table".to_owned()))?;
1129 let rows = need_client(client)?.read_rows(table).map_err(client_err)?;
1130 Ok(json!({ "rows": rows }))
1131 }
1132 "query" => {
1133 let sql = params
1137 .get("sql")
1138 .and_then(Value::as_str)
1139 .ok_or_else(|| client_err("query missing sql".to_owned()))?;
1140 let bind = match params.get("params") {
1141 Some(Value::Array(list)) => list.as_slice(),
1142 None | Some(Value::Null) => &[],
1143 Some(_) => return Err(client_err("query params must be a list".to_owned())),
1144 };
1145 let rows = need_client(client)?.query(sql, bind).map_err(client_err)?;
1146 Ok(Value::Object(serde_json::Map::from_iter([(
1147 "rows".to_owned(),
1148 Value::Array(rows.into_iter().map(Value::Object).collect()),
1149 )])))
1150 }
1151 "querySnapshot" => {
1152 let sql = params
1153 .get("sql")
1154 .and_then(Value::as_str)
1155 .ok_or_else(|| client_err("querySnapshot missing sql".to_owned()))?;
1156 let bind = match params.get("params") {
1157 Some(Value::Array(list)) => list.as_slice(),
1158 None | Some(Value::Null) => &[],
1159 Some(_) => {
1160 return Err(client_err("querySnapshot params must be a list".to_owned()))
1161 }
1162 };
1163 let coverage = parse_window_coverage(params.get("coverage")).map_err(client_err)?;
1164 let owner = parse_query_owner(params, "querySnapshot")?;
1165 let mut snapshot = need_client(client)?
1166 .query_snapshot(
1167 sql,
1168 bind,
1169 &coverage,
1170 owner.as_ref().map(|(id, tables)| QueryOwner { id, tables }),
1171 )
1172 .map_err(client_err)?;
1173 let rows = std::mem::take(&mut snapshot.rows);
1174 let mut result = serde_json::to_value(snapshot).expect("snapshot serializes");
1175 result["rows"] = Value::Array(rows.into_iter().map(Value::Object).collect());
1176 Ok(result)
1177 }
1178 "localRevision" => {
1179 let read = need_client(client)?
1183 .snapshot_read(&syncular_client::SnapshotReadRequest::default(), None)
1184 .map_err(read_command_error)?;
1185 Ok(json!({ "revision": read.revision }))
1186 }
1187 "snapshotRead" => {
1188 let mut statement_sql: Vec<String> = Vec::new();
1189 let mut statement_params: Vec<Vec<Value>> = Vec::new();
1190 match params.get("statements") {
1191 None | Some(Value::Null) => {}
1192 Some(Value::Array(items)) => {
1193 for item in items {
1194 let Some(sql) = item.get("sql").and_then(Value::as_str) else {
1195 return Err(client_err(
1196 "sync.invalid_request: snapshotRead statements need a sql string"
1197 .to_owned(),
1198 ));
1199 };
1200 let bind = match item.get("params") {
1201 None | Some(Value::Null) => Vec::new(),
1202 Some(Value::Array(values)) => values.clone(),
1203 Some(_) => {
1204 return Err(client_err(
1205 "sync.invalid_request: snapshotRead statement params must be a list"
1206 .to_owned(),
1207 ))
1208 }
1209 };
1210 statement_sql.push(sql.to_owned());
1211 statement_params.push(bind);
1212 }
1213 }
1214 Some(_) => {
1215 return Err(client_err(
1216 "sync.invalid_request: snapshotRead statements must be a list".to_owned(),
1217 ))
1218 }
1219 }
1220 let units = snapshot_string_list(params.get("units"))?;
1221 let commit_ids = snapshot_string_list(params.get("commitIds"))?;
1222 let coverage = parse_window_coverage(params.get("coverage")).map_err(client_err)?;
1223 let owner = parse_query_owner(params, "snapshotRead")?;
1224 let statements: Vec<syncular_client::SnapshotStatement<'_>> = statement_sql
1225 .iter()
1226 .zip(&statement_params)
1227 .map(|(sql, params)| syncular_client::SnapshotStatement { sql, params })
1228 .collect();
1229 let read = need_client(client)?
1230 .snapshot_read(
1231 &syncular_client::SnapshotReadRequest {
1232 statements,
1233 coverage: &coverage,
1234 units,
1235 commit_ids,
1236 },
1237 owner.as_ref().map(|(id, tables)| QueryOwner { id, tables }),
1238 )
1239 .map_err(read_command_error)?;
1240 serde_json::to_value(read).map_err(|error| client_err(error.to_string()))
1241 }
1242 "previousVersionSnapshot" | "previous_version_snapshot" => {
1243 let spec = parse_previous_version_snapshot_spec(params)?;
1244 let snapshot = need_client(client)?
1245 .previous_version_snapshot(&spec)
1246 .map_err(client_err)?;
1247 serde_json::to_value(snapshot).map_err(|error| client_err(error.to_string()))
1248 }
1249 "previousVersionAudit" | "previous_version_audit" => Ok(
1250 match need_client(client)?
1251 .previous_version_audit()
1252 .map_err(client_err)?
1253 {
1254 Some(audit) => {
1255 serde_json::to_value(audit).map_err(|error| client_err(error.to_string()))?
1256 }
1257 None => Value::Null,
1258 },
1259 ),
1260 "previousVersionDiscard" | "previous_version_discard" => {
1261 let outcome = need_client(client)?
1262 .previous_version_discard()
1263 .map_err(client_err)?;
1264 Ok(json!({
1265 "present": outcome.present,
1266 "discarded": outcome.discarded,
1267 }))
1268 }
1269 "statusSnapshot" => Ok(serde_json::to_value(need_client(client)?.status_snapshot())
1270 .expect("status serializes")),
1271 "diagnosticsSnapshot" => {
1272 let snapshot = need_client(client)?
1273 .diagnostics_snapshot()
1274 .map_err(client_err)?;
1275 Ok(serde_json::to_value(snapshot).expect("diagnostics serialize"))
1276 }
1277 "progressSnapshot" => Ok(
1282 serde_json::to_value(need_client(client)?.progress().snapshot())
1283 .expect("progress JSON"),
1284 ),
1285 "drainChangeBatches" => Ok(json!({
1286 "batches": need_client(client)?.drain_change_batches()
1287 })),
1288 "drainSyncIntents" => Ok(json!({
1289 "intents": need_client(client)?.drain_sync_intents()
1290 })),
1291 #[cfg(feature = "crdt-yjs")]
1297 "crdtText" => {
1298 let (table, row_id, column, name) = crdt_target(params)?;
1299 let text = need_client(client)?
1300 .crdt_text(&table, &row_id, &column, &name)
1301 .map_err(client_err)?;
1302 Ok(json!({ "text": text }))
1303 }
1304 #[cfg(feature = "crdt-yjs")]
1305 "crdtInsertText" => {
1306 let (table, row_id, column, name) = crdt_target(params)?;
1307 let index = params
1308 .get("index")
1309 .and_then(Value::as_u64)
1310 .and_then(|n| u32::try_from(n).ok())
1311 .ok_or_else(|| {
1312 client_err(
1313 "sync.invalid_request: crdtInsertText index must be a u32".to_owned(),
1314 )
1315 })?;
1316 let value = params
1317 .get("value")
1318 .and_then(Value::as_str)
1319 .ok_or_else(|| client_err("crdtInsertText missing value".to_owned()))?;
1320 let id = need_client(client)?
1321 .crdt_insert_text(&table, &row_id, &column, &name, index, value)
1322 .map_err(CommandError::from_client)?;
1323 Ok(json!({ "clientCommitId": id }))
1324 }
1325 #[cfg(feature = "crdt-yjs")]
1326 "crdtDeleteText" => {
1327 let (table, row_id, column, name) = crdt_target(params)?;
1328 let index = params
1329 .get("index")
1330 .and_then(Value::as_u64)
1331 .and_then(|n| u32::try_from(n).ok())
1332 .ok_or_else(|| {
1333 client_err(
1334 "sync.invalid_request: crdtDeleteText index must be a u32".to_owned(),
1335 )
1336 })?;
1337 let len = params
1338 .get("len")
1339 .and_then(Value::as_u64)
1340 .and_then(|n| u32::try_from(n).ok())
1341 .ok_or_else(|| {
1342 client_err("sync.invalid_request: crdtDeleteText len must be a u32".to_owned())
1343 })?;
1344 let id = need_client(client)?
1345 .crdt_delete_text(&table, &row_id, &column, &name, index, len)
1346 .map_err(CommandError::from_client)?;
1347 Ok(json!({ "clientCommitId": id }))
1348 }
1349 #[cfg(feature = "crdt-yjs")]
1350 "crdtApplyUpdate" => {
1351 let (table, row_id, column, _name) = crdt_target(params)?;
1352 let update = value_bytes(params.get("update")).map_err(client_err)?;
1353 let id = need_client(client)?
1354 .crdt_apply_update(&table, &row_id, &column, &update)
1355 .map_err(CommandError::from_client)?;
1356 Ok(json!({ "clientCommitId": id }))
1357 }
1358 #[cfg(not(feature = "crdt-yjs"))]
1359 "crdtText" | "crdtInsertText" | "crdtDeleteText" | "crdtApplyUpdate" => {
1360 Err(CommandError::new(
1361 "client.crdt_unavailable",
1362 "native CRDT support requires the `crdt-yjs` feature (§5.10.5)",
1363 ))
1364 }
1365
1366 "uploadBlob" => {
1367 let bytes = value_bytes(params.get("bytes")).map_err(client_err)?;
1368 let media_type = optional(params.get("mediaType"), "mediaType", Value::as_str)
1369 .map_err(client_err)?
1370 .map(str::to_owned);
1371 let name = optional(params.get("name"), "blob name", Value::as_str)
1372 .map_err(client_err)?
1373 .map(str::to_owned);
1374 let reference = need_client(client)?
1375 .upload_blob(&bytes, media_type, name)
1376 .map_err(client_err)?;
1377 Ok(json!({ "ref": reference }))
1378 }
1379 "fetchBlob" => {
1380 let blob = params
1381 .get("blob")
1382 .and_then(Value::as_str)
1383 .ok_or_else(|| client_err("fetchBlob missing blob".to_owned()))?
1384 .to_owned();
1385 let blob = need_client(client)?.fetch_blob_bytes(transport, &blob)?;
1389 let mut value = serde_json::Map::new();
1390 value.insert("blobId".to_owned(), Value::from(blob.blob_id));
1391 value.insert("byteLength".to_owned(), Value::from(blob.byte_length));
1392 value.insert("bytes".to_owned(), bytes_value(&blob.bytes));
1393 if let Some(media_type) = blob.media_type {
1394 value.insert("mediaType".to_owned(), Value::from(media_type));
1395 }
1396 Ok(Value::Object(serde_json::Map::from_iter([(
1397 "blob".to_owned(),
1398 Value::Object(value),
1399 )])))
1400 }
1401 "conflicts" => {
1402 let conflicts = need_client(client)?.conflicts().to_vec();
1403 Ok(json!({ "conflicts": conflicts }))
1404 }
1405 "rejections" => {
1406 let rejections = need_client(client)?.rejections().to_vec();
1407 Ok(json!({ "rejections": rejections }))
1408 }
1409 "commitOutcome" => {
1410 let client_commit_id = params
1411 .get("clientCommitId")
1412 .and_then(Value::as_str)
1413 .ok_or_else(|| {
1414 client_err(
1415 "sync.invalid_request: commitOutcome missing clientCommitId".to_owned(),
1416 )
1417 })?;
1418 let outcome = need_client(client)?
1419 .commit_outcome(client_commit_id)
1420 .map_err(client_err)?;
1421 Ok(json!({ "outcome": outcome }))
1422 }
1423 "commitOutcomes" => {
1424 let query = serde_json::from_value::<CommitOutcomeQuery>(
1425 params.get("query").cloned().unwrap_or_else(|| json!({})),
1426 )
1427 .map_err(|error| {
1428 client_err(format!(
1429 "sync.invalid_request: invalid commit outcome query: {error}"
1430 ))
1431 })?;
1432 let outcomes = need_client(client)?
1433 .commit_outcomes(query)
1434 .map_err(client_err)?;
1435 Ok(json!({ "outcomes": outcomes }))
1436 }
1437 "resolveCommitOutcome" => {
1438 let input = serde_json::from_value::<ResolveCommitOutcomeInput>(
1439 params.get("input").cloned().ok_or_else(|| {
1440 client_err(
1441 "sync.invalid_request: resolveCommitOutcome missing input".to_owned(),
1442 )
1443 })?,
1444 )
1445 .map_err(|error| {
1446 client_err(format!(
1447 "sync.invalid_request: invalid outcome resolution: {error}"
1448 ))
1449 })?;
1450 let outcome = need_client(client)?
1451 .resolve_commit_outcome(input)
1452 .map_err(client_err)?;
1453 Ok(json!({ "outcome": outcome }))
1454 }
1455 "pendingCommitIds" => {
1456 let ids = need_client(client)?.pending_commit_ids();
1457 Ok(json!({ "ids": ids }))
1458 }
1459 "pendingPayloads" => {
1460 let payloads = need_client(client)?
1461 .pending_payloads()
1462 .map_err(client_err)?;
1463 Ok(json!({
1464 "payloads": payloads.iter().map(|p| bytes_value(p)).collect::<Vec<_>>()
1465 }))
1466 }
1467 "units" => Ok(json!({ "units": need_client(client)?.units().map_err(client_err)? })),
1468 "unit" => {
1469 let id = params
1470 .get("id")
1471 .and_then(Value::as_str)
1472 .ok_or_else(|| client_err("unit missing id".to_owned()))?;
1473 Ok(json!({ "unit": need_client(client)?.unit(id).map_err(client_err)? }))
1474 }
1475 "recreateWithSchema" => {
1476 let schema = params
1480 .get("schema")
1481 .ok_or_else(|| client_err("recreateWithSchema missing schema".to_owned()))?;
1482 need_client(client)?
1483 .recreate_with_schema(schema)
1484 .map_err(client_err)?;
1485 Ok(json!({}))
1486 }
1487 "localAuthorityState" => Ok(json!({ "state": transport.local_authority_state() })),
1488 "drainRealtime" => Ok(json!({})),
1492 "attachLocalAuthority" | "abandonLocalAuthorityAttach" => {
1493 let running = need_client(client)?;
1494 if transport.local_authority_state().is_none() {
1495 return Err(CommandError::new(
1496 LOCAL_AUTHORITY_UNCONFIGURED_CODE,
1497 "the host configured no localAuthorityPath",
1498 ));
1499 }
1500 let enabled = running.transport_enabled();
1503 running.set_transport_enabled(transport, false);
1504 let outcome = if method == "attachLocalAuthority" {
1505 transport.attach_local_authority()
1506 } else {
1507 transport.abandon_local_authority_attach()
1508 };
1509 running.set_transport_enabled(transport, enabled);
1510 outcome.map_err(transport_command_error)?;
1511 Ok(json!({ "effects": CommandEffects::interactive() }))
1512 }
1513 "connectRealtime" => {
1514 need_client(client)?
1515 .connect_realtime(transport)
1516 .map_err(client_err)?;
1517 Ok(json!({}))
1518 }
1519 "disconnectRealtime" => {
1520 if let Some(running) = client.as_mut() {
1522 running.disconnect_realtime(transport);
1523 }
1524 Ok(json!({}))
1525 }
1526 "setPresence" => {
1527 let scope_key = params
1528 .get("scopeKey")
1529 .and_then(Value::as_str)
1530 .ok_or_else(|| client_err("setPresence missing scopeKey".to_owned()))?
1531 .to_owned();
1532 let doc = params.get("doc");
1534 let doc_ref = match doc {
1535 None | Some(Value::Null) => None,
1536 Some(v) => Some(v),
1537 };
1538 need_client(client)?
1539 .set_presence(transport, &scope_key, doc_ref)
1540 .map_err(client_err)?;
1541 Ok(json!({}))
1542 }
1543 "presence" => {
1544 let scope_key = params
1545 .get("scopeKey")
1546 .and_then(Value::as_str)
1547 .ok_or_else(|| client_err("presence missing scopeKey".to_owned()))?;
1548 let peers = need_client(client)?.presence(scope_key);
1549 Ok(json!({ "peers": peers }))
1550 }
1551
1552 "messageRoundtrip" => {
1554 let bytes = value_bytes(params.get("bytes")).map_err(client_err)?;
1555 match decode_message(&bytes) {
1556 Ok(message) => Ok(json!({
1557 "ok": true,
1558 "bytes": bytes_value(&encode_message(&message)),
1559 "renderedJson": render_message(&message).to_string(),
1560 })),
1561 Err(error) => Ok(json!({ "ok": false, "errorCode": error.code.as_str() })),
1562 }
1563 }
1564 "segmentRoundtrip" => {
1565 let bytes = value_bytes(params.get("bytes")).map_err(client_err)?;
1566 match decode_rows_segment(&bytes) {
1567 Ok(segment) => Ok(json!({
1568 "ok": true,
1569 "bytes": bytes_value(&encode_rows_segment(&segment)),
1570 "renderedJson": render_rows_segment(&segment).to_string(),
1571 })),
1572 Err(error) => Ok(json!({ "ok": false, "errorCode": error.code.as_str() })),
1573 }
1574 }
1575 "realtimeKnown" => {
1576 let text = params
1577 .get("text")
1578 .and_then(Value::as_str)
1579 .ok_or_else(|| client_err("realtimeKnown missing text".to_owned()))?;
1580 let known = matches!(
1581 parse_control(text),
1582 Ok(ControlMessage::Hello { .. })
1583 | Ok(ControlMessage::Wake { .. })
1584 | Ok(ControlMessage::Heartbeat { .. })
1585 | Ok(ControlMessage::Presence { .. })
1586 );
1587 Ok(json!({ "value": known }))
1588 }
1589
1590 other => Err(client_err(format!("unknown method {other:?}"))),
1591 };
1592 if client
1593 .as_ref()
1594 .is_some_and(|running| !running.transport_enabled())
1595 {
1596 if let Ok(value) = &mut result {
1597 if let Some(effects) = value.get_mut("effects").and_then(Value::as_object_mut) {
1598 effects.remove("sync");
1599 }
1600 }
1601 }
1602 result
1603}
1604
1605#[cfg(test)]
1606mod tests {
1607 use serde_json::{json, Value};
1608 use syncular_client::{
1609 Mutation, SegmentRequest, SyncClient, Transport, TransportError,
1610 SECURITY_PREFLIGHT_REQUIRED_CODE,
1611 };
1612
1613 use super::{
1614 client_err, dispatch, parse_encryption, parse_headers, parse_previous_version_context,
1615 parse_window_coverage, CreateEffects, UnitScopes,
1616 };
1617
1618 #[derive(Default)]
1619 struct NoNetwork {
1620 realtime_connects: usize,
1621 realtime_closes: usize,
1622 }
1623
1624 impl Transport for NoNetwork {
1625 fn sync(&mut self, _request: &[u8]) -> Result<Vec<u8>, TransportError> {
1626 Err(TransportError::new("sync.transport_failed", "offline"))
1627 }
1628
1629 fn realtime_sync(&mut self, _request: &[u8]) -> Result<Vec<u8>, TransportError> {
1630 Err(TransportError::new("sync.transport_failed", "offline"))
1631 }
1632
1633 fn download_segment(
1634 &mut self,
1635 _request: &SegmentRequest,
1636 _on_progress: &mut dyn FnMut(u64),
1637 ) -> Result<Vec<u8>, TransportError> {
1638 Err(TransportError::new("sync.transport_failed", "offline"))
1639 }
1640
1641 fn realtime_connect(&mut self) -> Result<(), TransportError> {
1642 self.realtime_connects += 1;
1643 Ok(())
1644 }
1645
1646 fn realtime_send(&mut self, _text: &str) -> Result<(), TransportError> {
1647 Ok(())
1648 }
1649
1650 fn realtime_close(&mut self) -> Result<(), TransportError> {
1651 self.realtime_closes += 1;
1652 Ok(())
1653 }
1654 }
1655
1656 fn schema() -> Value {
1657 json!({
1658 "version": 1,
1659 "tables": [{
1660 "name": "todos",
1661 "columns": [
1662 { "name": "id", "type": "string", "nullable": false },
1663 { "name": "list_id", "type": "string", "nullable": false }
1664 ],
1665 "primaryKey": "id",
1666 "scopes": [{ "pattern": "list:{list_id}", "column": "list_id" }]
1667 }]
1668 })
1669 }
1670
1671 #[test]
1672 fn native_command_realtime_connection_is_idempotent() {
1673 let mut transport = NoNetwork::default();
1674 let mut client: Option<SyncClient> = None;
1675 let mut effects = CreateEffects::default();
1676 dispatch(
1677 &mut transport,
1678 &mut client,
1679 &mut effects,
1680 "create",
1681 &json!({ "schema": schema() }),
1682 )
1683 .expect("create client");
1684
1685 for _ in 0..2 {
1686 dispatch(
1687 &mut transport,
1688 &mut client,
1689 &mut effects,
1690 "connectRealtime",
1691 &json!({}),
1692 )
1693 .expect("idempotent connect command");
1694 }
1695 assert_eq!(transport.realtime_connects, 1);
1696
1697 dispatch(
1698 &mut transport,
1699 &mut client,
1700 &mut effects,
1701 "disconnectRealtime",
1702 &json!({}),
1703 )
1704 .expect("disconnect command");
1705 dispatch(
1706 &mut transport,
1707 &mut client,
1708 &mut effects,
1709 "disconnectRealtime",
1710 &json!({}),
1711 )
1712 .expect("idempotent disconnect command");
1713 assert_eq!(transport.realtime_closes, 1);
1714 dispatch(
1715 &mut transport,
1716 &mut client,
1717 &mut effects,
1718 "connectRealtime",
1719 &json!({}),
1720 )
1721 .expect("deliberate reconnect command");
1722 assert_eq!(transport.realtime_connects, 2);
1723 }
1724
1725 #[test]
1726 fn local_authority_commands_without_one_report_the_unconfigured_code() {
1727 let mut transport = NoNetwork::default();
1728 let mut client: Option<SyncClient> = None;
1729 let mut effects = CreateEffects::default();
1730 let state = dispatch(
1731 &mut transport,
1732 &mut client,
1733 &mut effects,
1734 "localAuthorityState",
1735 &json!({}),
1736 )
1737 .expect("state without a client");
1738 assert_eq!(state, json!({ "state": null }));
1739 dispatch(
1740 &mut transport,
1741 &mut client,
1742 &mut effects,
1743 "create",
1744 &json!({ "schema": schema() }),
1745 )
1746 .expect("create client");
1747 for method in ["attachLocalAuthority", "abandonLocalAuthorityAttach"] {
1748 let error = dispatch(
1749 &mut transport,
1750 &mut client,
1751 &mut effects,
1752 method,
1753 &json!({}),
1754 )
1755 .expect_err("no local authority");
1756 assert_eq!(error.code, "client.local_authority_unconfigured");
1757 }
1758 let running = client.as_mut().expect("client");
1759 assert!(running.transport_enabled());
1760 assert!(
1761 running.drain_sync_intents().is_empty(),
1762 "the gate never toggled"
1763 );
1764 }
1765
1766 struct ScriptedAuthority {
1768 opened: Vec<(Value, Option<String>)>,
1769 open_error: Option<TransportError>,
1770 attach_error: Option<TransportError>,
1771 abandons: usize,
1772 }
1773
1774 impl Transport for ScriptedAuthority {
1775 fn sync(&mut self, _request: &[u8]) -> Result<Vec<u8>, TransportError> {
1776 Err(TransportError::new("sync.transport_failed", "offline"))
1777 }
1778 fn realtime_sync(&mut self, _request: &[u8]) -> Result<Vec<u8>, TransportError> {
1779 Err(TransportError::new("sync.transport_failed", "offline"))
1780 }
1781 fn download_segment(
1782 &mut self,
1783 _request: &SegmentRequest,
1784 _on_progress: &mut dyn FnMut(u64),
1785 ) -> Result<Vec<u8>, TransportError> {
1786 Err(TransportError::new("sync.transport_failed", "offline"))
1787 }
1788 fn realtime_connect(&mut self) -> Result<(), TransportError> {
1789 Ok(())
1790 }
1791 fn realtime_send(&mut self, _text: &str) -> Result<(), TransportError> {
1792 Ok(())
1793 }
1794 fn realtime_close(&mut self) -> Result<(), TransportError> {
1795 Ok(())
1796 }
1797 fn open_local_authority(
1798 &mut self,
1799 schema: &Value,
1800 replica_path: Option<&str>,
1801 ) -> Result<(), TransportError> {
1802 self.opened
1803 .push((schema.clone(), replica_path.map(str::to_owned)));
1804 self.open_error.take().map_or(Ok(()), Err)
1805 }
1806 fn local_authority_state(&self) -> Option<&'static str> {
1807 (!self.opened.is_empty()).then_some("local")
1808 }
1809 fn attach_local_authority(&mut self) -> Result<(), TransportError> {
1810 self.attach_error.take().map_or(Ok(()), Err)
1811 }
1812 fn abandon_local_authority_attach(&mut self) -> Result<(), TransportError> {
1813 self.abandons += 1;
1814 Ok(())
1815 }
1816 }
1817
1818 #[test]
1819 fn local_authority_opens_at_create_and_attach_errors_keep_code_and_details() {
1820 let mut transport = ScriptedAuthority {
1821 opened: Vec::new(),
1822 open_error: Some(TransportError::new("sync.internal_error", "open failed")),
1823 attach_error: Some(TransportError {
1824 code: "sync.attach_rejected".to_owned(),
1825 message: "the remote server refused an attach commit".to_owned(),
1826 details: Some(json!({ "reason": "commit_rejected", "opIndex": 0 })),
1827 }),
1828 abandons: 0,
1829 };
1830 let mut client: Option<SyncClient> = None;
1831 let mut effects = CreateEffects::default();
1832 let error = dispatch(
1833 &mut transport,
1834 &mut client,
1835 &mut effects,
1836 "create",
1837 &json!({ "schema": schema() }),
1838 )
1839 .expect_err("an authority that fails to open fails create");
1840 assert_eq!(error.code, "sync.internal_error");
1841 assert!(client.is_none());
1842
1843 dispatch(
1844 &mut transport,
1845 &mut client,
1846 &mut effects,
1847 "create",
1848 &json!({ "schema": schema() }),
1849 )
1850 .expect("create client");
1851 assert_eq!(transport.opened.len(), 2);
1852 assert_eq!(transport.opened[1], (schema(), None));
1853 let state = dispatch(
1854 &mut transport,
1855 &mut client,
1856 &mut effects,
1857 "localAuthorityState",
1858 &json!({}),
1859 )
1860 .expect("state");
1861 assert_eq!(state, json!({ "state": "local" }));
1862
1863 let error = dispatch(
1864 &mut transport,
1865 &mut client,
1866 &mut effects,
1867 "attachLocalAuthority",
1868 &json!({}),
1869 )
1870 .expect_err("scripted rejection");
1871 assert_eq!(error.code, "sync.attach_rejected");
1872 assert_eq!(
1873 error.details,
1874 Some(json!({ "reason": "commit_rejected", "opIndex": 0 }))
1875 );
1876 assert!(client.as_ref().expect("client").transport_enabled());
1877
1878 let abandoned = dispatch(
1879 &mut transport,
1880 &mut client,
1881 &mut effects,
1882 "abandonLocalAuthorityAttach",
1883 &json!({}),
1884 )
1885 .expect("abandon");
1886 assert_eq!(abandoned["effects"]["sync"]["kind"], "interactive");
1887 assert_eq!(transport.abandons, 1);
1888
1889 dispatch(
1891 &mut transport,
1892 &mut client,
1893 &mut effects,
1894 "setTransportEnabled",
1895 &json!({ "enabled": false }),
1896 )
1897 .expect("go offline");
1898 let attached = dispatch(
1899 &mut transport,
1900 &mut client,
1901 &mut effects,
1902 "attachLocalAuthority",
1903 &json!({}),
1904 )
1905 .expect("attach");
1906 assert!(attached["effects"].get("sync").is_none());
1907 assert!(!client.as_ref().expect("client").transport_enabled());
1908 }
1909
1910 #[test]
1911 fn schema_downgrade_has_structured_code_at_create_and_recreate_boundaries() {
1912 let path = temp_db_path("schema-downgrade");
1913 let mut newer = schema();
1914 newer["version"] = json!(3);
1915 let mut older = schema();
1916 older["version"] = json!(2);
1917 let mut transport = NoNetwork::default();
1918 let mut client = None;
1919 let mut effects = CreateEffects::default();
1920 dispatch(
1921 &mut transport,
1922 &mut client,
1923 &mut effects,
1924 "create",
1925 &json!({ "schema": newer, "dbPath": path }),
1926 )
1927 .expect("v3 create");
1928 let error = dispatch(
1929 &mut transport,
1930 &mut client,
1931 &mut effects,
1932 "recreateWithSchema",
1933 &json!({ "schema": older }),
1934 )
1935 .expect_err("refuse recreation");
1936 assert_eq!(error.code, "client.schema_downgrade");
1937 assert_eq!(
1938 error.message,
1939 "client.schema_downgrade: persisted local schema is newer than the requested schema"
1940 );
1941 dispatch(
1942 &mut transport,
1943 &mut client,
1944 &mut effects,
1945 "shutdown",
1946 &json!({}),
1947 )
1948 .expect("shutdown");
1949 let error = dispatch(
1950 &mut transport,
1951 &mut client,
1952 &mut effects,
1953 "create",
1954 &json!({ "schema": older, "dbPath": path }),
1955 )
1956 .expect_err("refuse open");
1957 assert_eq!(error.code, "client.schema_downgrade");
1958 assert!(client.is_none());
1959 dispatch(
1960 &mut transport,
1961 &mut client,
1962 &mut effects,
1963 "create",
1964 &json!({ "schema": newer, "dbPath": path }),
1965 )
1966 .expect("compatible reopen");
1967 dispatch(
1968 &mut transport,
1969 &mut client,
1970 &mut effects,
1971 "shutdown",
1972 &json!({}),
1973 )
1974 .expect("shutdown");
1975 let _ = std::fs::remove_file(path);
1976 }
1977
1978 #[test]
1979 fn native_command_realtime_policy_rides_create_and_refuses_http() {
1980 let mut transport = NoNetwork::default();
1981 let mut client: Option<SyncClient> = None;
1982 let mut effects = CreateEffects::default();
1983 dispatch(
1984 &mut transport,
1985 &mut client,
1986 &mut effects,
1987 "create",
1988 &json!({ "schema": schema(), "realtimePolicy": "required" }),
1989 )
1990 .expect("create client with a required realtime policy");
1991 let result = dispatch(
1992 &mut transport,
1993 &mut client,
1994 &mut effects,
1995 "sync",
1996 &json!({}),
1997 )
1998 .expect("sync command");
1999 assert_eq!(result["ok"], json!(false));
2000 assert_eq!(result["errorCode"], json!("sync.realtime_unavailable"));
2001 assert_eq!(result["realtimeState"], json!("disconnected"));
2002 assert_eq!(result["retryDelayMs"], json!(250));
2003 let snapshot = dispatch(
2004 &mut transport,
2005 &mut client,
2006 &mut effects,
2007 "diagnosticsSnapshot",
2008 &json!({}),
2009 )
2010 .expect("diagnostics command");
2011 assert_eq!(snapshot["host"]["realtime"], json!("disconnected"));
2012 assert_eq!(snapshot["host"]["realtimePolicy"], json!("required"));
2013 assert_eq!(snapshot["host"]["realtimeRetryDelayMs"], json!(250));
2014
2015 let mut second: Option<SyncClient> = None;
2016 let error = dispatch(
2017 &mut transport,
2018 &mut second,
2019 &mut effects,
2020 "create",
2021 &json!({ "schema": schema(), "realtimePolicy": "always" }),
2022 )
2023 .expect_err("an unknown policy is refused");
2024 assert_eq!(error.code, "sync.invalid_request");
2025 }
2026
2027 #[test]
2028 fn parses_portable_encryption_keyring_and_key_id_columns() {
2029 let key_hex = "2a".repeat(32);
2030 let config = parse_encryption(&json!({
2031 "keys": { "practice-key-v1": { "$bytes": key_hex } },
2032 "keyIdColumns": { "patients": "encryption_key_id" }
2033 }))
2034 .expect("portable keyring parses");
2035 assert_eq!(config.keys["practice-key-v1"], vec![0x2a; 32]);
2036 assert_eq!(config.key_id_columns["patients"], "encryption_key_id");
2037 }
2038
2039 #[test]
2040 fn parses_missing_key_mode_with_fail_as_default() {
2041 use syncular_client::values::MissingKey;
2042 let mode = |value: Value| parse_encryption(&value).map(|config| config.missing_key);
2043 assert_eq!(mode(json!({})), Ok(MissingKey::Fail));
2044 assert_eq!(mode(json!({ "missingKey": "fail" })), Ok(MissingKey::Fail));
2045 assert_eq!(mode(json!({ "missingKey": "seal" })), Ok(MissingKey::Seal));
2046 assert!(mode(json!({ "missingKey": "skip" }))
2047 .expect_err("an unknown mode is refused")
2048 .contains("missingKey"));
2049 }
2050
2051 #[test]
2052 fn rejects_non_string_key_id_columns() {
2053 let error = parse_encryption(&json!({
2054 "keys": {},
2055 "keyIdColumns": { "patients": 7 }
2056 }))
2057 .expect_err("invalid selector must fail");
2058 assert!(error.contains("must be a string"), "{error}");
2059 }
2060
2061 #[test]
2062 fn subscribe_many_registers_every_unit() {
2063 let mut transport = NoNetwork::default();
2064 let mut client: Option<SyncClient> = None;
2065 let mut effects = CreateEffects::default();
2066 let mut run = |command: &str, params: Value| {
2067 dispatch(&mut transport, &mut client, &mut effects, command, ¶ms)
2068 };
2069 run("create", json!({ "schema": schema() })).expect("create client");
2070 let ids = run(
2071 "subscribeMany",
2072 json!({ "units": [{ "list_id": "list-1" }, { "list_id": "list-2" }] }),
2073 )
2074 .expect("register units")["ids"]
2075 .clone();
2076 let single = run("subscribe", json!({ "scopes": { "list_id": "list-1" } }))
2077 .expect("re-register a unit");
2078 assert_eq!(single["id"], ids[0], "a unit id derives from its scope map");
2079 let units = run("units", json!({})).expect("units");
2080 assert_eq!(units["units"].as_array().map(Vec::len), Some(2));
2081 for (index, list) in ["list-1", "list-2"].into_iter().enumerate() {
2082 let unit = run("unit", json!({ "id": ids[index] })).expect("unit");
2083 assert_eq!(unit["unit"]["scopes"], json!({ "list_id": list }));
2084 assert_eq!(unit["unit"]["cursor"], -1);
2085 }
2086 assert_eq!(
2087 run("unit", json!({ "id": "absent" })).expect("unit")["unit"],
2088 Value::Null
2089 );
2090 for scopes in [json!({ "list_id": "*" }), json!({ "other": "x" })] {
2091 let error = run("subscribe", json!({ "scopes": scopes }))
2092 .expect_err("a unit names a non-wildcard value per covered variable");
2093 assert_eq!(error.code, "sync.invalid_subscription", "{scopes}");
2094 }
2095 }
2096
2097 #[test]
2098 fn window_coverage_parser_reads_the_generated_descriptor_and_rejects_malformed_units() {
2099 let parsed = parse_window_coverage(Some(&json!([{
2100 "base": { "variable": "project_id", "fixedScopes": { "tenant_id": "one" } },
2101 "units": ["a", "b"]
2102 }])))
2103 .expect("parse coverage");
2104 assert_eq!(parsed[0].base.variable, "project_id");
2105 assert_eq!(
2106 parsed[0].base.fixed_scopes,
2107 UnitScopes::from([("tenant_id".to_owned(), "one".to_owned())])
2108 );
2109 assert_eq!(parsed[0].units, ["a", "b"]);
2110 for coverage in [
2111 json!({}),
2112 json!([{ "base": { "variable": "project_id" }, "units": ["a", 1] }]),
2113 json!([{ "base": { "fixedScopes": {} }, "units": [] }]),
2114 ] {
2115 let error = parse_window_coverage(Some(&coverage)).expect_err("malformed coverage");
2116 assert!(error.starts_with("sync.invalid_request: "), "{error}");
2117 }
2118 }
2119
2120 #[test]
2121 fn subscribe_and_unsubscribe_queue_an_interactive_sync_intent() {
2122 let mut transport = NoNetwork::default();
2123 let mut client: Option<SyncClient> = None;
2124 let mut effects = CreateEffects::default();
2125 let mut run = |command: &str, params: Value| {
2126 dispatch(&mut transport, &mut client, &mut effects, command, ¶ms)
2127 .expect("command succeeds")
2128 };
2129 run("create", json!({ "schema": schema() }));
2130 run("drainSyncIntents", json!({}));
2131 let id = run("subscribe", json!({ "scopes": { "list_id": "list-1" } }))["id"].clone();
2132 let intents = run("drainSyncIntents", json!({}));
2133 assert_eq!(intents["intents"], json!([{ "kind": "interactive" }]));
2134 run("unsubscribe", json!({ "id": id }));
2135 let intents = run("drainSyncIntents", json!({}));
2136 assert_eq!(intents["intents"], json!([{ "kind": "interactive" }]));
2137 }
2138
2139 #[test]
2140 fn security_preflight_is_fail_closed_until_exact_activation() {
2141 let mut transport = NoNetwork::default();
2142 let mut client: Option<SyncClient> = None;
2143 let mut effects = CreateEffects::default();
2144 dispatch(
2145 &mut transport,
2146 &mut client,
2147 &mut effects,
2148 "create",
2149 &json!({ "schema": schema(), "securityPreflight": true }),
2150 )
2151 .expect("preflight create");
2152
2153 let lifecycle = dispatch(
2154 &mut transport,
2155 &mut client,
2156 &mut effects,
2157 "securityLifecycle",
2158 &json!({}),
2159 )
2160 .expect("lifecycle");
2161 assert_eq!(lifecycle, json!({ "state": "preflight" }));
2162
2163 let query_error = dispatch(
2164 &mut transport,
2165 &mut client,
2166 &mut effects,
2167 "query",
2168 &json!({ "sql": "SELECT id FROM todos", "params": [] }),
2169 )
2170 .expect_err("protected query must fail");
2171 assert_eq!(query_error.code, SECURITY_PREFLIGHT_REQUIRED_CODE);
2172 let diagnostics_error = dispatch(
2173 &mut transport,
2174 &mut client,
2175 &mut effects,
2176 "diagnosticsSnapshot",
2177 &json!({}),
2178 )
2179 .expect_err("diagnostics unit evidence remains protected");
2180 assert_eq!(diagnostics_error.code, SECURITY_PREFLIGHT_REQUIRED_CODE);
2181
2182 dispatch(
2183 &mut transport,
2184 &mut client,
2185 &mut effects,
2186 "purgeLocalData",
2187 &json!({
2188 "input": {
2189 "purgeId": "directive-1",
2190 "targets": [{
2191 "table": "todos",
2192 "selectors": { "list_id": ["list-1"] }
2193 }]
2194 }
2195 }),
2196 )
2197 .expect("authorized local purge remains available");
2198
2199 let repair_error = dispatch(
2200 &mut transport,
2201 &mut client,
2202 &mut effects,
2203 "rebootstrapLocalData",
2204 &json!({ "input": { "rebootstrapId": "blocked-repair" } }),
2205 )
2206 .expect_err("projection repair must remain protected during preflight");
2207 assert_eq!(repair_error.code, SECURITY_PREFLIGHT_REQUIRED_CODE);
2208
2209 dispatch(
2210 &mut transport,
2211 &mut client,
2212 &mut effects,
2213 "activateSecurity",
2214 &json!({}),
2215 )
2216 .expect("activation");
2217 let rows = dispatch(
2218 &mut transport,
2219 &mut client,
2220 &mut effects,
2221 "query",
2222 &json!({ "sql": "SELECT id FROM todos", "params": [] }),
2223 )
2224 .expect("active query");
2225 assert_eq!(rows, json!({ "rows": [] }));
2226
2227 dispatch(
2228 &mut transport,
2229 &mut client,
2230 &mut effects,
2231 "beginSecurityPreflight",
2232 &json!({}),
2233 )
2234 .expect("re-enter preflight");
2235 let blocked = dispatch(
2236 &mut transport,
2237 &mut client,
2238 &mut effects,
2239 "mutate",
2240 &json!({ "mutations": [] }),
2241 )
2242 .expect_err("mutation must be gated");
2243 assert_eq!(blocked.code, SECURITY_PREFLIGHT_REQUIRED_CODE);
2244 }
2245
2246 #[test]
2247 fn mutate_and_patch_forward_typed_storage_failures() {
2248 let path = temp_db_path("busy-authoring");
2249 let schema = json!({
2250 "version": 1,
2251 "tables": [{
2252 "name": "todos",
2253 "columns": [
2254 { "name": "id", "type": "string", "nullable": false },
2255 { "name": "list_id", "type": "string", "nullable": false },
2256 { "name": "title", "type": "string", "nullable": false }
2257 ],
2258 "primaryKey": "id",
2259 "scopes": [{ "pattern": "list:{list_id}", "column": "list_id" }]
2260 }]
2261 });
2262 let mut transport = NoNetwork::default();
2263 let mut client: Option<SyncClient> = None;
2264 let mut effects = CreateEffects::default();
2265 dispatch(
2266 &mut transport,
2267 &mut client,
2268 &mut effects,
2269 "create",
2270 &json!({ "schema": schema, "dbPath": path }),
2271 )
2272 .expect("create file-backed client");
2273 let upsert = |id: &str| {
2274 json!({ "mutations": [{ "op": "upsert", "table": "todos", "values": {
2275 "id": id, "list_id": "l1", "title": "first" } }] })
2276 };
2277 dispatch(
2278 &mut transport,
2279 &mut client,
2280 &mut effects,
2281 "mutate",
2282 &upsert("t1"),
2283 )
2284 .expect("seed row");
2285
2286 let locker = rusqlite::Connection::open(&path).expect("second connection");
2287 locker.execute_batch("BEGIN IMMEDIATE").unwrap();
2288 let busy = dispatch(
2289 &mut transport,
2290 &mut client,
2291 &mut effects,
2292 "mutate",
2293 &upsert("t2"),
2294 )
2295 .expect_err("busy mutate");
2296 assert_eq!(busy.code, "client.storage_busy");
2297 assert!(busy.retryable);
2298 assert_eq!(busy.details.as_ref().unwrap()["sqliteCode"], 5);
2299
2300 let busy_patch = dispatch(
2301 &mut transport,
2302 &mut client,
2303 &mut effects,
2304 "patch",
2305 &json!({ "table": "todos", "rowId": "t1", "partial": { "title": "second" } }),
2306 )
2307 .expect_err("busy patch");
2308 assert_eq!(busy_patch.code, "client.storage_busy");
2309 assert!(busy_patch.retryable);
2310 assert_eq!(busy_patch.details.as_ref().unwrap()["sqliteCode"], 5);
2311
2312 locker.execute_batch("ROLLBACK").unwrap();
2313 let retried = dispatch(
2314 &mut transport,
2315 &mut client,
2316 &mut effects,
2317 "mutate",
2318 &upsert("t2"),
2319 )
2320 .expect("retry after busy");
2321 assert!(retried.get("clientCommitId").is_some());
2322 let _ = std::fs::remove_file(&path);
2323 }
2324
2325 #[test]
2326 fn read_command_error_preserves_code_details_and_retryability() {
2327 let corrupt = super::read_command_error(syncular_client::QueryReadFailure {
2328 code: Some("sync.local_corrupt"),
2329 sqlite_code: None,
2330 sqlite_message: None,
2331 rollback_failure: None,
2332 message: "persisted local revision is invalid".to_owned(),
2333 });
2334 assert_eq!(corrupt.code, "sync.local_corrupt");
2335 assert!(!corrupt.retryable);
2336 assert!(corrupt.details.is_none());
2337
2338 let busy = super::read_command_error(syncular_client::QueryReadFailure {
2339 code: Some("client.storage_busy"),
2340 sqlite_code: Some(5),
2341 sqlite_message: Some("database is locked".to_owned()),
2342 rollback_failure: None,
2343 message: "local SQLite storage is busy".to_owned(),
2344 });
2345 assert_eq!(busy.code, "client.storage_busy");
2346 assert!(busy.retryable);
2347 assert_eq!(
2348 busy.details.expect("busy details")["sqliteCode"],
2349 serde_json::json!(5)
2350 );
2351 }
2352
2353 #[test]
2354 fn mutate_and_patch_report_caller_value_failures_as_invalid_request() {
2355 let path = temp_db_path("caller-values");
2356 let schema = json!({
2357 "version": 1,
2358 "tables": [{
2359 "name": "todos",
2360 "columns": [
2361 { "name": "id", "type": "string", "nullable": false },
2362 { "name": "list_id", "type": "string", "nullable": false },
2363 { "name": "title", "type": "string", "nullable": false },
2364 { "name": "priority", "type": "integer", "nullable": false }
2365 ],
2366 "primaryKey": "id",
2367 "scopes": [{ "pattern": "list:{list_id}", "column": "list_id" }]
2368 }]
2369 });
2370 let mut transport = NoNetwork::default();
2371 let mut client: Option<SyncClient> = None;
2372 let mut effects = CreateEffects::default();
2373 dispatch(
2374 &mut transport,
2375 &mut client,
2376 &mut effects,
2377 "create",
2378 &json!({ "schema": schema, "dbPath": path }),
2379 )
2380 .expect("create file-backed client");
2381 let seed = dispatch(
2382 &mut transport,
2383 &mut client,
2384 &mut effects,
2385 "mutate",
2386 &json!({ "mutations": [{ "op": "upsert", "table": "todos", "values": {
2387 "id": "t1", "list_id": "l1", "title": "first", "priority": 1 } }] }),
2388 )
2389 .expect("seed row");
2390 let seed_id = seed["clientCommitId"].clone();
2391
2392 let unknown = dispatch(
2395 &mut transport,
2396 &mut client,
2397 &mut effects,
2398 "mutate",
2399 &json!({ "mutations": [{ "op": "upsert", "table": "todos", "values": {
2400 "id": "t2", "list_id": "l1", "title": "second", "priority": 1,
2401 "missing_column": 1 } }] }),
2402 )
2403 .expect_err("unknown column");
2404 assert_eq!(unknown.code, "sync.invalid_request");
2405 assert_eq!(unknown.message, "the authoring request is invalid");
2406 assert!(!unknown.retryable);
2407 assert!(unknown.details.as_ref().unwrap()["legacyCause"]
2408 .as_str()
2409 .unwrap()
2410 .contains("unknown column"));
2411
2412 let bad_patch = dispatch(
2413 &mut transport,
2414 &mut client,
2415 &mut effects,
2416 "patch",
2417 &json!({ "table": "todos", "rowId": "t1", "partial": { "priority": "high" } }),
2418 )
2419 .expect_err("bad patch value");
2420 assert_eq!(bad_patch.code, "sync.invalid_request");
2421 assert_eq!(bad_patch.message, "the authoring request is invalid");
2422 assert!(bad_patch.details.as_ref().unwrap()["legacyCause"]
2423 .as_str()
2424 .unwrap()
2425 .contains("priority"));
2426
2427 let pending = dispatch(
2429 &mut transport,
2430 &mut client,
2431 &mut effects,
2432 "pendingCommitIds",
2433 &json!({}),
2434 )
2435 .expect("pending commit ids");
2436 assert_eq!(pending["ids"], json!([seed_id]));
2437 let rows = dispatch(
2438 &mut transport,
2439 &mut client,
2440 &mut effects,
2441 "query",
2442 &json!({ "sql": "SELECT id, priority FROM todos ORDER BY id" }),
2443 )
2444 .expect("visible rows");
2445 assert_eq!(rows["rows"], json!([{ "id": "t1", "priority": 1 }]));
2446
2447 let accepted = dispatch(
2449 &mut transport,
2450 &mut client,
2451 &mut effects,
2452 "mutate",
2453 &json!({ "mutations": [{ "op": "upsert", "table": "todos", "values": {
2454 "id": "t2", "list_id": "l1", "title": "second", "priority": 2 } }] }),
2455 )
2456 .expect("retry after rejection");
2457 assert!(accepted.get("clientCommitId").is_some());
2458 let _ = std::fs::remove_file(&path);
2459 }
2460
2461 #[test]
2462 fn client_err_preserves_retryable_for_storage_busy() {
2463 let busy = client_err("client.storage_busy: local SQLite storage is busy".to_owned());
2464 assert_eq!(busy.code, "client.storage_busy");
2465 assert!(busy.retryable);
2466 assert_eq!(
2468 busy.message,
2469 "client.storage_busy: local SQLite storage is busy"
2470 );
2471 let full = client_err("client.storage_full: local SQLite storage is full".to_owned());
2472 assert_eq!(full.code, "client.storage_full");
2473 assert!(!full.retryable);
2474 }
2475
2476 #[test]
2477 fn client_err_keeps_a_colon_less_code_identity() {
2478 let error = client_err("sync.unknown_table".to_owned());
2479 assert_eq!(error.code, "sync.unknown_table");
2480 let error = client_err("no client instance created".to_owned());
2481 assert_eq!(error.code, "client.failed");
2482 }
2483
2484 #[cfg(feature = "crdt-yjs")]
2485 #[test]
2486 fn crdt_offsets_outside_u32_are_invalid_requests() {
2487 let mut transport = NoNetwork::default();
2488 let mut client: Option<SyncClient> = None;
2489 let mut effects = CreateEffects::default();
2490 dispatch(
2491 &mut transport,
2492 &mut client,
2493 &mut effects,
2494 "create",
2495 &json!({ "schema": schema() }),
2496 )
2497 .expect("create");
2498 let target = json!({ "table": "todos", "rowId": "t1", "column": "body" });
2499 for (method, extra) in [
2500 (
2501 "crdtInsertText",
2502 json!({ "index": 4_294_967_296u64, "value": "x" }),
2503 ),
2504 ("crdtInsertText", json!({ "index": "0", "value": "x" })),
2505 (
2506 "crdtDeleteText",
2507 json!({ "index": 0, "len": 4_294_967_296u64 }),
2508 ),
2509 ] {
2510 let mut params = target.clone();
2511 params
2512 .as_object_mut()
2513 .unwrap()
2514 .extend(extra.as_object().unwrap().clone());
2515 let error = dispatch(&mut transport, &mut client, &mut effects, method, ¶ms)
2516 .expect_err("out-of-range offset");
2517 assert_eq!(error.code, "sync.invalid_request", "{method} {params}");
2518 }
2519 }
2520
2521 #[test]
2522 fn wrong_typed_optional_fields_are_invalid_requests() {
2523 let created = || {
2524 let mut transport = NoNetwork::default();
2525 let mut client: Option<SyncClient> = None;
2526 let mut effects = CreateEffects::default();
2527 dispatch(
2528 &mut transport,
2529 &mut client,
2530 &mut effects,
2531 "create",
2532 &json!({ "schema": schema() }),
2533 )
2534 .expect("create");
2535 (transport, client, effects)
2536 };
2537 for params in [
2538 json!({ "schema": schema(), "limits": "x" }),
2539 json!({ "schema": schema(), "limits": { "accept": 256 } }),
2540 json!({ "schema": schema(), "limits": { "accept": "15" } }),
2541 json!({ "schema": schema(), "limits": { "limitCommits": 4_294_967_296i64 } }),
2542 json!({ "schema": schema(), "limits": { "outcomeRetentionMaxEntries": -1 } }),
2543 json!({ "schema": schema(), "clientId": 7 }),
2544 json!({ "schema": schema(), "nowMs": "1" }),
2545 json!({ "schema": schema(), "signedUrls": "true" }),
2546 json!({ "schema": schema(), "securityPreflight": 1 }),
2547 json!({ "schema": schema(), "encryption": { "keys": "k" } }),
2548 ] {
2549 let mut transport = NoNetwork::default();
2550 let mut client: Option<SyncClient> = None;
2551 let mut effects = CreateEffects::default();
2552 let error = dispatch(&mut transport, &mut client, &mut effects, "create", ¶ms)
2553 .expect_err("wrong-typed create field");
2554 assert_eq!(error.code, "sync.invalid_request", "{params}");
2555 }
2556 let base = json!({ "variable": "list_id" });
2557 for (method, params) in [
2558 ("setWindow", json!({ "base": base, "units": [1] })),
2559 ("setWindow", json!({ "base": base, "units": "l1" })),
2560 (
2561 "setWindow",
2562 json!({ "base": { "variable": "list_id", "fixedScopes": ["x"] }, "units": [] }),
2563 ),
2564 ("windowState", json!({ "base": {} })),
2565 (
2566 "mutate",
2567 json!({ "mutations": [{ "op": "delete", "table": "todos", "rowId": "t1", "baseVersion": "7" }] }),
2568 ),
2569 (
2570 "patch",
2571 json!({ "table": "todos", "rowId": "t1", "partial": { "title": "x" }, "baseVersion": "7" }),
2572 ),
2573 ("subscribe", json!({ "scopes": { "list_id": ["l1"] } })),
2574 (
2575 "subscribeMany",
2576 json!({ "units": [{ "list_id": "l1" }, 7] }),
2577 ),
2578 (
2579 "uploadBlob",
2580 json!({ "bytes": { "$bytes": "00" }, "mediaType": 1 }),
2581 ),
2582 ] {
2583 let (mut transport, mut client, mut effects) = created();
2584 let error = dispatch(&mut transport, &mut client, &mut effects, method, ¶ms)
2585 .expect_err("wrong-typed field");
2586 assert_eq!(error.code, "sync.invalid_request", "{method} {params}");
2587 }
2588 let (mut transport, mut client, mut effects) = created();
2590 dispatch(
2591 &mut transport,
2592 &mut client,
2593 &mut effects,
2594 "mutate",
2595 &json!({ "mutations": [{ "op": "delete", "table": "todos", "rowId": "t1", "baseVersion": null }] }),
2596 )
2597 .expect("null baseVersion is absent");
2598 }
2599
2600 #[test]
2601 fn sync_until_idle_rejects_an_invalid_max_rounds_budget() {
2602 for value in [json!(0), json!(-1), json!(1.5), json!(4_294_967_296u64)] {
2603 let mut transport = NoNetwork::default();
2604 let mut client: Option<SyncClient> = None;
2605 let mut effects = CreateEffects::default();
2606 dispatch(
2607 &mut transport,
2608 &mut client,
2609 &mut effects,
2610 "create",
2611 &json!({ "schema": schema() }),
2612 )
2613 .expect("create");
2614 let error = dispatch(
2615 &mut transport,
2616 &mut client,
2617 &mut effects,
2618 "syncUntilIdle",
2619 &json!({ "maxRounds": value }),
2620 )
2621 .expect_err("invalid budget");
2622 assert_eq!(error.code, "sync.invalid_request", "{value}");
2623 }
2624 }
2625
2626 #[test]
2627 fn sync_until_idle_rejects_an_invalid_timeout() {
2628 for value in [json!(0), json!(-1), json!(1.5)] {
2629 let mut transport = NoNetwork::default();
2630 let mut client: Option<SyncClient> = None;
2631 let mut effects = CreateEffects::default();
2632 dispatch(
2633 &mut transport,
2634 &mut client,
2635 &mut effects,
2636 "create",
2637 &json!({ "schema": schema() }),
2638 )
2639 .expect("create");
2640 let error = dispatch(
2641 &mut transport,
2642 &mut client,
2643 &mut effects,
2644 "syncUntilIdle",
2645 &json!({ "timeoutMs": value }),
2646 )
2647 .expect_err("invalid timeout");
2648 assert_eq!(error.code, "sync.invalid_request", "{value}");
2649 }
2650 }
2651
2652 #[test]
2653 fn create_rejects_invalid_push_limits() {
2654 for value in [json!(0), json!(-1), json!(1.5), json!(4_294_967_296u64)] {
2655 let mut transport = NoNetwork::default();
2656 let mut client: Option<SyncClient> = None;
2657 let mut effects = CreateEffects::default();
2658 let error = dispatch(
2659 &mut transport,
2660 &mut client,
2661 &mut effects,
2662 "create",
2663 &json!({
2664 "schema": schema(),
2665 "limits": { "maxPushRequestBytes": value }
2666 }),
2667 )
2668 .expect_err("invalid push limit");
2669 assert_eq!(error.code, "sync.invalid_request", "{value}");
2670 assert_eq!(
2671 error.details.as_ref().unwrap()["limit"],
2672 json!("maxPushRequestBytes")
2673 );
2674 }
2675 }
2676
2677 #[test]
2678 fn preflight_allows_only_the_authorized_previous_version_discard() {
2679 let mut transport = NoNetwork::default();
2680 let mut client: Option<SyncClient> = None;
2681 let mut effects = CreateEffects::default();
2682 dispatch(
2683 &mut transport,
2684 &mut client,
2685 &mut effects,
2686 "create",
2687 &json!({ "schema": schema(), "securityPreflight": true }),
2688 )
2689 .expect("preflight create");
2690
2691 for method in ["previousVersionSnapshot", "previousVersionAudit"] {
2693 let error = dispatch(
2694 &mut transport,
2695 &mut client,
2696 &mut effects,
2697 method,
2698 &json!({}),
2699 )
2700 .expect_err("previous-version reads stay gated during preflight");
2701 assert_eq!(error.code, SECURITY_PREFLIGHT_REQUIRED_CODE);
2702 }
2703 let discarded = dispatch(
2706 &mut transport,
2707 &mut client,
2708 &mut effects,
2709 "previousVersionDiscard",
2710 &json!({}),
2711 )
2712 .expect("authorized cleanup is allowed during preflight");
2713 assert_eq!(discarded, json!({ "present": false, "discarded": false }));
2714 dispatch(
2716 &mut transport,
2717 &mut client,
2718 &mut effects,
2719 "disconnectRealtime",
2720 &json!({}),
2721 )
2722 .expect("disconnect is allowed during preflight");
2723 assert!(client.as_ref().is_some_and(SyncClient::security_preflight));
2724 }
2725
2726 #[test]
2727 fn disconnect_without_a_client_succeeds() {
2728 let mut transport = NoNetwork::default();
2729 let mut client: Option<SyncClient> = None;
2730 let mut effects = CreateEffects::default();
2731 dispatch(
2732 &mut transport,
2733 &mut client,
2734 &mut effects,
2735 "disconnectRealtime",
2736 &json!({}),
2737 )
2738 .expect("a missing client holds no socket");
2739 dispatch(
2740 &mut transport,
2741 &mut client,
2742 &mut effects,
2743 "create",
2744 &json!({ "schema": schema() }),
2745 )
2746 .expect("create");
2747 dispatch(
2748 &mut transport,
2749 &mut client,
2750 &mut effects,
2751 "shutdown",
2752 &json!({}),
2753 )
2754 .expect("shutdown");
2755 dispatch(
2756 &mut transport,
2757 &mut client,
2758 &mut effects,
2759 "disconnectRealtime",
2760 &json!({}),
2761 )
2762 .expect("a shut-down client holds no socket");
2763 }
2764
2765 #[test]
2766 fn preflight_refuses_a_replacement_create_without_the_flag() {
2767 let mut transport = NoNetwork::default();
2768 let mut client: Option<SyncClient> = None;
2769 let mut effects = CreateEffects::default();
2770 dispatch(
2771 &mut transport,
2772 &mut client,
2773 &mut effects,
2774 "create",
2775 &json!({ "schema": schema(), "securityPreflight": true }),
2776 )
2777 .expect("preflight create");
2778
2779 let escape = dispatch(
2781 &mut transport,
2782 &mut client,
2783 &mut effects,
2784 "create",
2785 &json!({ "schema": schema() }),
2786 )
2787 .expect_err("plain create must be refused during preflight");
2788 assert_eq!(escape.code, SECURITY_PREFLIGHT_REQUIRED_CODE);
2789 let query_error = dispatch(
2791 &mut transport,
2792 &mut client,
2793 &mut effects,
2794 "query",
2795 &json!({ "sql": "SELECT id FROM todos", "params": [] }),
2796 )
2797 .expect_err("protected query stays gated");
2798 assert_eq!(query_error.code, SECURITY_PREFLIGHT_REQUIRED_CODE);
2799
2800 dispatch(
2802 &mut transport,
2803 &mut client,
2804 &mut effects,
2805 "create",
2806 &json!({ "schema": schema(), "securityPreflight": true }),
2807 )
2808 .expect("preflighted replacement create");
2809 let still_gated = dispatch(
2810 &mut transport,
2811 &mut client,
2812 &mut effects,
2813 "query",
2814 &json!({ "sql": "SELECT id FROM todos", "params": [] }),
2815 )
2816 .expect_err("replacement stays gated");
2817 assert_eq!(still_gated.code, SECURITY_PREFLIGHT_REQUIRED_CODE);
2818
2819 dispatch(
2821 &mut transport,
2822 &mut client,
2823 &mut effects,
2824 "activateSecurity",
2825 &json!({}),
2826 )
2827 .expect("activation");
2828 dispatch(
2829 &mut transport,
2830 &mut client,
2831 &mut effects,
2832 "create",
2833 &json!({ "schema": schema() }),
2834 )
2835 .expect("plain create after activation");
2836 let rows = dispatch(
2837 &mut transport,
2838 &mut client,
2839 &mut effects,
2840 "query",
2841 &json!({ "sql": "SELECT id FROM todos", "params": [] }),
2842 )
2843 .expect("active query");
2844 assert_eq!(rows, json!({ "rows": [] }));
2845 }
2846
2847 fn temp_db_path(tag: &str) -> String {
2850 std::env::temp_dir()
2851 .join(format!(
2852 "syncular-command-{tag}-{}-{:?}.db",
2853 std::process::id(),
2854 std::time::SystemTime::now()
2855 .duration_since(std::time::UNIX_EPOCH)
2856 .expect("clock")
2857 .as_nanos()
2858 ))
2859 .to_string_lossy()
2860 .into_owned()
2861 }
2862
2863 #[test]
2864 fn an_activated_replica_reopens_plainly_after_shutdown() {
2865 let path = temp_db_path("activated-reopen");
2871 let mut transport = NoNetwork::default();
2872 let mut client: Option<SyncClient> = None;
2873 let mut effects = CreateEffects::default();
2874
2875 dispatch(
2876 &mut transport,
2877 &mut client,
2878 &mut effects,
2879 "create",
2880 &json!({ "schema": schema(), "securityPreflight": true, "dbPath": path }),
2881 )
2882 .expect("preflight create");
2883 dispatch(
2884 &mut transport,
2885 &mut client,
2886 &mut effects,
2887 "activateSecurity",
2888 &json!({}),
2889 )
2890 .expect("activation clears the gate");
2891 dispatch(
2892 &mut transport,
2893 &mut client,
2894 &mut effects,
2895 "shutdown",
2896 &json!({}),
2897 )
2898 .expect("shutdown after activation");
2899
2900 dispatch(
2902 &mut transport,
2903 &mut client,
2904 &mut effects,
2905 "create",
2906 &json!({ "schema": schema(), "dbPath": path }),
2907 )
2908 .expect("an activated replica must reopen plainly after shutdown");
2909 let state = dispatch(
2910 &mut transport,
2911 &mut client,
2912 &mut effects,
2913 "securityLifecycle",
2914 &json!({}),
2915 )
2916 .expect("lifecycle");
2917 assert_eq!(state, json!({ "state": "active" }));
2918
2919 let _ = std::fs::remove_file(&path);
2920 }
2921
2922 #[test]
2923 fn an_unactivated_replica_stays_quarantined_across_shutdown_on_disk() {
2924 let path = temp_db_path("quarantined-reopen");
2929 let mut transport = NoNetwork::default();
2930 let mut client: Option<SyncClient> = None;
2931 let mut effects = CreateEffects::default();
2932
2933 dispatch(
2934 &mut transport,
2935 &mut client,
2936 &mut effects,
2937 "create",
2938 &json!({ "schema": schema(), "securityPreflight": true, "dbPath": path }),
2939 )
2940 .expect("preflight create");
2941 dispatch(
2942 &mut transport,
2943 &mut client,
2944 &mut effects,
2945 "shutdown",
2946 &json!({}),
2947 )
2948 .expect("shutdown during preflight");
2949
2950 let mut rebuilt = CreateEffects::default();
2953 let escape = dispatch(
2954 &mut transport,
2955 &mut client,
2956 &mut rebuilt,
2957 "create",
2958 &json!({ "schema": schema(), "dbPath": path }),
2959 )
2960 .expect_err("a quarantined replica must refuse a plain re-create");
2961 assert_eq!(escape.code, SECURITY_PREFLIGHT_REQUIRED_CODE);
2962
2963 let _ = std::fs::remove_file(&path);
2964 }
2965
2966 #[test]
2967 fn preflight_gate_survives_shutdown_before_replacement_creates() {
2968 let mut transport = NoNetwork::default();
2969 let mut client: Option<SyncClient> = None;
2970 let mut effects = CreateEffects::default();
2971 dispatch(
2972 &mut transport,
2973 &mut client,
2974 &mut effects,
2975 "create",
2976 &json!({ "schema": schema(), "securityPreflight": true }),
2977 )
2978 .expect("preflight create");
2979 dispatch(
2980 &mut transport,
2981 &mut client,
2982 &mut effects,
2983 "shutdown",
2984 &json!({}),
2985 )
2986 .expect("shutdown during preflight");
2987 assert!(client.is_none());
2988
2989 let escape = dispatch(
2991 &mut transport,
2992 &mut client,
2993 &mut effects,
2994 "create",
2995 &json!({ "schema": schema() }),
2996 )
2997 .expect_err("shutdown + plain create must stay refused");
2998 assert_eq!(escape.code, SECURITY_PREFLIGHT_REQUIRED_CODE);
2999
3000 dispatch(
3001 &mut transport,
3002 &mut client,
3003 &mut effects,
3004 "create",
3005 &json!({ "schema": schema(), "securityPreflight": true }),
3006 )
3007 .expect("preflighted re-create");
3008 dispatch(
3009 &mut transport,
3010 &mut client,
3011 &mut effects,
3012 "activateSecurity",
3013 &json!({}),
3014 )
3015 .expect("activation");
3016
3017 dispatch(
3019 &mut transport,
3020 &mut client,
3021 &mut effects,
3022 "shutdown",
3023 &json!({}),
3024 )
3025 .expect("shutdown after activation");
3026 dispatch(
3027 &mut transport,
3028 &mut client,
3029 &mut effects,
3030 "create",
3031 &json!({ "schema": schema() }),
3032 )
3033 .expect("plain create after an activated shutdown");
3034 }
3035
3036 #[test]
3037 fn activate_security_validates_optional_headers_atomically() {
3038 let mut transport = NoNetwork::default();
3039 let mut client: Option<SyncClient> = None;
3040 let mut effects = CreateEffects::default();
3041 dispatch(
3042 &mut transport,
3043 &mut client,
3044 &mut effects,
3045 "create",
3046 &json!({ "schema": schema(), "securityPreflight": true }),
3047 )
3048 .expect("preflight create");
3049
3050 let invalid = dispatch(
3052 &mut transport,
3053 &mut client,
3054 &mut effects,
3055 "activateSecurity",
3056 &json!({ "headers": { "authorization": 7 } }),
3057 )
3058 .expect_err("non-string header must fail");
3059 assert_eq!(invalid.code, "sync.invalid_request");
3060 let lifecycle = dispatch(
3061 &mut transport,
3062 &mut client,
3063 &mut effects,
3064 "securityLifecycle",
3065 &json!({}),
3066 )
3067 .expect("lifecycle");
3068 assert_eq!(lifecycle, json!({ "state": "preflight" }));
3069
3070 dispatch(
3072 &mut transport,
3073 &mut client,
3074 &mut effects,
3075 "activateSecurity",
3076 &json!({ "headers": { "authorization": "Bearer fresh" } }),
3077 )
3078 .expect("activation with fresh headers");
3079 let lifecycle = dispatch(
3080 &mut transport,
3081 &mut client,
3082 &mut effects,
3083 "securityLifecycle",
3084 &json!({}),
3085 )
3086 .expect("lifecycle");
3087 assert_eq!(lifecycle, json!({ "state": "active" }));
3088 }
3089
3090 #[test]
3091 fn parse_headers_reads_the_full_replacement_set() {
3092 let parsed = parse_headers(&json!({
3093 "authorization": "Bearer fresh",
3094 "x-tenant": "t1"
3095 }))
3096 .expect("valid headers parse");
3097 assert_eq!(
3098 parsed,
3099 vec![
3100 ("authorization".to_owned(), "Bearer fresh".to_owned()),
3101 ("x-tenant".to_owned(), "t1".to_owned())
3102 ]
3103 );
3104 assert!(parse_headers(&json!(["authorization"])).is_err());
3105 assert!(parse_headers(&json!({ "authorization": null })).is_err());
3106 }
3107
3108 #[test]
3109 fn set_headers_validates_replacement_and_respects_preflight() {
3110 let mut transport = NoNetwork::default();
3111 let mut client: Option<SyncClient> = None;
3112 let mut effects = CreateEffects::default();
3113 dispatch(
3114 &mut transport,
3115 &mut client,
3116 &mut effects,
3117 "create",
3118 &json!({ "schema": schema() }),
3119 )
3120 .expect("create");
3121 dispatch(
3122 &mut transport,
3123 &mut client,
3124 &mut effects,
3125 "setHeaders",
3126 &json!({ "headers": { "authorization": "Bearer fresh" } }),
3127 )
3128 .expect("valid replacement");
3129 let invalid = dispatch(
3130 &mut transport,
3131 &mut client,
3132 &mut effects,
3133 "setHeaders",
3134 &json!({ "headers": { "authorization": 7 } }),
3135 )
3136 .expect_err("invalid replacement");
3137 assert_eq!(invalid.code, "sync.invalid_request");
3138
3139 dispatch(
3140 &mut transport,
3141 &mut client,
3142 &mut effects,
3143 "beginSecurityPreflight",
3144 &json!({}),
3145 )
3146 .expect("preflight");
3147 let gated = dispatch(
3148 &mut transport,
3149 &mut client,
3150 &mut effects,
3151 "setHeaders",
3152 &json!({ "headers": {} }),
3153 )
3154 .expect_err("direct rotation must respect preflight");
3155 assert_eq!(gated.code, SECURITY_PREFLIGHT_REQUIRED_CODE);
3156 }
3157
3158 fn schema_v2() -> Value {
3159 json!({
3160 "version": 2,
3161 "tables": [{
3162 "name": "todos",
3163 "columns": [
3164 { "name": "id", "type": "string", "nullable": false },
3165 { "name": "list_id", "type": "string", "nullable": false },
3166 { "name": "note", "type": "string", "nullable": true }
3167 ],
3168 "primaryKey": "id",
3169 "scopes": [{ "pattern": "list:{list_id}", "column": "list_id" }]
3170 }]
3171 })
3172 }
3173
3174 fn previous_version_enabled() -> Value {
3175 json!({ "enabled": true })
3176 }
3177
3178 fn container_path(db_path: &str) -> String {
3179 format!("{db_path}.prev-context")
3180 }
3181
3182 #[test]
3183 fn previous_version_config_parser_matches_ts_keys_and_defaults() {
3184 assert_eq!(parse_previous_version_context(None).expect("absent"), None);
3185 let defaults = parse_previous_version_context(Some(&json!({})))
3186 .expect("empty")
3187 .expect("present");
3188 assert!(!defaults.enabled);
3189 assert_eq!(defaults.max_bytes, 8 * 1024 * 1024);
3190 assert_eq!(defaults.max_rows, 20_000);
3191 assert_eq!(defaults.max_tables, 32);
3192 assert_eq!(defaults.max_row_bytes, 1024 * 1024);
3193 assert_eq!(defaults.max_age_ms, 24 * 60 * 60 * 1000);
3194
3195 let configured = parse_previous_version_context(Some(&json!({
3196 "enabled": true,
3197 "maxBytes": 1024,
3198 "maxRows": 3,
3199 "maxTables": 2,
3200 "maxRowBytes": 5,
3201 "maxAgeMs": 7
3202 })))
3203 .expect("configured")
3204 .expect("present");
3205 assert!(configured.enabled);
3206 assert_eq!(configured.max_bytes, 1024);
3207 assert_eq!(configured.max_rows, 3);
3208 assert_eq!(configured.max_tables, 2);
3209 assert_eq!(configured.max_row_bytes, 5);
3210 assert_eq!(configured.max_age_ms, 7);
3211
3212 for (value, expected) in [
3214 (json!([]), "must be an object"),
3215 (json!({ "enabled": "yes" }), "enabled must be a boolean"),
3216 (
3217 json!({ "maxBytes": 0 }),
3218 "maxBytes must be a positive safe integer",
3219 ),
3220 (
3221 json!({ "maxRows": -1 }),
3222 "maxRows must be a positive safe integer",
3223 ),
3224 (
3225 json!({ "maxTables": 1.5 }),
3226 "maxTables must be a positive safe integer",
3227 ),
3228 (
3229 json!({ "maxRowBytes": "1" }),
3230 "maxRowBytes must be a positive safe integer",
3231 ),
3232 (
3233 json!({ "maxAgeMs": 0 }),
3234 "maxAgeMs must be a positive safe integer",
3235 ),
3236 ] {
3237 let error = parse_previous_version_context(Some(&value)).expect_err("must fail");
3238 assert_eq!(error.code, "sync.invalid_request", "{value}");
3239 assert!(
3240 error.message.contains(expected),
3241 "{value}: {}",
3242 error.message
3243 );
3244 }
3245 }
3246
3247 #[test]
3248 fn invalid_previous_version_config_fails_create_loudly() {
3249 let mut transport = NoNetwork::default();
3250 let mut client: Option<SyncClient> = None;
3251 let mut effects = CreateEffects::default();
3252 let error = dispatch(
3253 &mut transport,
3254 &mut client,
3255 &mut effects,
3256 "create",
3257 &json!({ "schema": schema(), "previousVersionContext": { "enabled": true, "maxRows": 0 } }),
3258 )
3259 .expect_err("invalid config must fail the create");
3260 assert_eq!(error.code, "sync.invalid_request");
3261 assert!(error.message.contains("maxRows"), "{}", error.message);
3262 assert!(client.is_none(), "no client may be installed");
3263 }
3264
3265 #[test]
3266 fn previous_version_snapshot_reports_not_configured_by_default() {
3267 let mut transport = NoNetwork::default();
3268 let mut client: Option<SyncClient> = None;
3269 let mut effects = CreateEffects::default();
3270 dispatch(
3271 &mut transport,
3272 &mut client,
3273 &mut effects,
3274 "create",
3275 &json!({ "schema": schema() }),
3276 )
3277 .expect("create");
3278 let snapshot = dispatch(
3279 &mut transport,
3280 &mut client,
3281 &mut effects,
3282 "previousVersionSnapshot",
3283 &json!({ "table": "todos" }),
3284 )
3285 .expect("snapshot");
3286 assert_eq!(snapshot["state"], json!("previousVersion"));
3287 assert_eq!(snapshot["available"], json!(false));
3288 assert_eq!(snapshot["reason"], json!("not-configured"));
3289 assert_eq!(snapshot["rows"], json!([]));
3290 assert_eq!(snapshot["truncated"], json!(false));
3291 assert_eq!(snapshot["currentVersion"], json!(1));
3292 let discarded = dispatch(
3293 &mut transport,
3294 &mut client,
3295 &mut effects,
3296 "previousVersionDiscard",
3297 &json!({}),
3298 )
3299 .expect("discard");
3300 assert_eq!(discarded, json!({ "present": false, "discarded": false }));
3301 assert_eq!(
3302 dispatch(
3303 &mut transport,
3304 &mut client,
3305 &mut effects,
3306 "previousVersionAudit",
3307 &json!({}),
3308 )
3309 .expect("audit"),
3310 Value::Null
3311 );
3312 }
3313
3314 #[test]
3315 fn previous_version_commands_round_trip_through_the_dispatcher() {
3316 let path = temp_db_path("previous-version");
3317 let mut transport = NoNetwork::default();
3318 let mut client: Option<SyncClient> = None;
3319 let mut effects = CreateEffects::default();
3320
3321 dispatch(
3323 &mut transport,
3324 &mut client,
3325 &mut effects,
3326 "create",
3327 &json!({
3328 "schema": schema(),
3329 "dbPath": path,
3330 "previousVersionContext": previous_version_enabled()
3331 }),
3332 )
3333 .expect("create v1");
3334 client
3335 .as_mut()
3336 .expect("client")
3337 .mutate(vec![Mutation::Upsert {
3338 table: "todos".to_owned(),
3339 values: serde_json::Map::from_iter([
3340 ("id".to_owned(), json!("t1")),
3341 ("list_id".to_owned(), json!("l1")),
3342 ]),
3343 base_version: None,
3344 }])
3345 .expect("seed a local row");
3346 dispatch(
3347 &mut transport,
3348 &mut client,
3349 &mut effects,
3350 "shutdown",
3351 &json!({}),
3352 )
3353 .expect("shutdown");
3354
3355 dispatch(
3357 &mut transport,
3358 &mut client,
3359 &mut effects,
3360 "create",
3361 &json!({
3362 "schema": schema_v2(),
3363 "dbPath": path,
3364 "previousVersionContext": previous_version_enabled()
3365 }),
3366 )
3367 .expect("create v2");
3368 assert!(
3369 std::path::Path::new(&container_path(&path)).exists(),
3370 "the bump must leave a container file"
3371 );
3372 let status = dispatch(
3373 &mut transport,
3374 &mut client,
3375 &mut effects,
3376 "statusSnapshot",
3377 &json!({}),
3378 )
3379 .expect("status");
3380 assert_eq!(
3381 status["previousVersionContext"]["present"],
3382 json!(true),
3383 "{status}"
3384 );
3385 assert!(
3386 status["previousVersionContext"]["createdAtMs"].is_i64(),
3387 "{status}"
3388 );
3389
3390 let snapshot = dispatch(
3391 &mut transport,
3392 &mut client,
3393 &mut effects,
3394 "previousVersionSnapshot",
3395 &json!({ "table": "todos" }),
3396 )
3397 .expect("snapshot");
3398 assert_eq!(snapshot["state"], json!("previousVersion"));
3399 assert_eq!(snapshot["available"], json!(true));
3400 assert_eq!(snapshot["previousVersion"], json!(1));
3401 assert_eq!(snapshot["currentVersion"], json!(2));
3402 assert_eq!(snapshot["truncated"], json!(false));
3403 assert_eq!(snapshot["rows"][0]["id"], json!("t1"));
3404 assert_eq!(snapshot["rows"][0]["list_id"], json!("l1"));
3405
3406 let unknown = dispatch(
3408 &mut transport,
3409 &mut client,
3410 &mut effects,
3411 "previousVersionSnapshot",
3412 &json!({ "table": "absent" }),
3413 )
3414 .expect_err("unknown previous table");
3415 assert_eq!(unknown.code, "sync.invalid_request");
3416 let bad_limit = dispatch(
3417 &mut transport,
3418 &mut client,
3419 &mut effects,
3420 "previousVersionSnapshot",
3421 &json!({ "table": "todos", "limit": 0 }),
3422 )
3423 .expect_err("bad limit");
3424 assert_eq!(bad_limit.code, "sync.invalid_request");
3425
3426 let audit = dispatch(
3429 &mut transport,
3430 &mut client,
3431 &mut effects,
3432 "previousVersionAudit",
3433 &json!({}),
3434 )
3435 .expect("audit");
3436 assert_eq!(audit["v"], json!(1));
3437 assert_eq!(audit["fromVersion"], json!(1));
3438 assert_eq!(audit["toVersion"], json!(2));
3439 assert_eq!(audit["pending"], json!(1));
3440 assert_eq!(audit["encodable"], json!(1));
3441 assert_eq!(audit["incompatible"], json!([]));
3442 assert!(audit.get("operations").is_none());
3443
3444 let discarded = dispatch(
3446 &mut transport,
3447 &mut client,
3448 &mut effects,
3449 "previousVersionDiscard",
3450 &json!({}),
3451 )
3452 .expect("discard");
3453 assert_eq!(discarded, json!({ "present": true, "discarded": true }));
3454 assert!(!std::path::Path::new(&container_path(&path)).exists());
3455 let again = dispatch(
3456 &mut transport,
3457 &mut client,
3458 &mut effects,
3459 "previousVersionDiscard",
3460 &json!({}),
3461 )
3462 .expect("idempotent discard");
3463 assert_eq!(again, json!({ "present": false, "discarded": false }));
3464
3465 let inspect = rusqlite::Connection::open(&path).expect("inspect replica");
3467 let remaining: i64 = inspect
3468 .query_row(
3469 "SELECT COUNT(*) FROM _syncular_meta WHERE key IN (?1, ?2)",
3470 rusqlite::params!["previousVersionContext", "previousVersionAudit"],
3471 |row| row.get(0),
3472 )
3473 .expect("count meta");
3474 assert_eq!(remaining, 0);
3475
3476 let _ = std::fs::remove_file(&path);
3477 }
3478
3479 #[test]
3480 fn previous_version_ttl_expires_at_read_through_the_dispatcher() {
3481 let path = temp_db_path("previous-version-ttl");
3482 let mut transport = NoNetwork::default();
3483 let mut client: Option<SyncClient> = None;
3484 let mut effects = CreateEffects::default();
3485 dispatch(
3486 &mut transport,
3487 &mut client,
3488 &mut effects,
3489 "create",
3490 &json!({
3491 "schema": schema(),
3492 "dbPath": path,
3493 "previousVersionContext": previous_version_enabled()
3494 }),
3495 )
3496 .expect("create v1");
3497 dispatch(
3498 &mut transport,
3499 &mut client,
3500 &mut effects,
3501 "shutdown",
3502 &json!({}),
3503 )
3504 .expect("shutdown");
3505
3506 let now_ms = std::time::SystemTime::now()
3510 .duration_since(std::time::UNIX_EPOCH)
3511 .expect("clock")
3512 .as_millis() as i64
3513 + 2_000;
3514 dispatch(
3515 &mut transport,
3516 &mut client,
3517 &mut effects,
3518 "create",
3519 &json!({
3520 "schema": schema_v2(),
3521 "dbPath": path,
3522 "nowMs": now_ms,
3523 "previousVersionContext": { "enabled": true, "maxAgeMs": 500 }
3524 }),
3525 )
3526 .expect("create v2");
3527 assert!(std::path::Path::new(&container_path(&path)).exists());
3528 let snapshot = dispatch(
3529 &mut transport,
3530 &mut client,
3531 &mut effects,
3532 "previousVersionSnapshot",
3533 &json!({ "table": "todos" }),
3534 )
3535 .expect("snapshot");
3536 assert_eq!(snapshot["available"], json!(false));
3537 assert_eq!(snapshot["reason"], json!("expired"));
3538 assert_eq!(snapshot["rows"], json!([]));
3539 assert!(!std::path::Path::new(&container_path(&path)).exists());
3541
3542 let _ = std::fs::remove_file(&path);
3543 }
3544}