syncable_cli/analyzer/k8s_optimize/rules/
k8s_opt_005.rs

1//! K8S-OPT-005: CPU request exceeds threshold for workload type.
2
3use super::{OptimizationRule, RuleContext, codes};
4use crate::analyzer::k8s_optimize::config::K8sOptimizeConfig;
5use crate::analyzer::k8s_optimize::parser::parse_cpu_to_millicores;
6use crate::analyzer::k8s_optimize::types::{
7    OptimizationIssue, ResourceRecommendation, ResourceSpec, RuleCode, Severity, WorkloadType,
8};
9
10/// Rule: CPU request exceeds threshold.
11pub struct HighCpuRequestRule;
12
13impl OptimizationRule for HighCpuRequestRule {
14    fn code(&self) -> &'static str {
15        codes::HIGH_CPU_REQUEST
16    }
17
18    fn description(&self) -> &'static str {
19        "CPU request exceeds threshold for workload type"
20    }
21
22    fn default_severity(&self) -> Severity {
23        Severity::High
24    }
25
26    fn check(
27        &self,
28        ctx: &RuleContext,
29        config: &K8sOptimizeConfig,
30    ) -> Option<ResourceRecommendation> {
31        // Exclude batch/ML workloads from this check (they legitimately need more resources)
32        if matches!(
33            ctx.workload_type,
34            WorkloadType::Batch | WorkloadType::MachineLearning
35        ) {
36            return None;
37        }
38
39        let cpu_request = ctx.current.cpu_request.as_ref()?;
40        let millicores = parse_cpu_to_millicores(cpu_request)?;
41
42        // Check if exceeds threshold
43        if millicores <= config.max_cpu_request_millicores as u64 {
44            return None;
45        }
46
47        let defaults = ctx.workload_type.default_resources();
48        let recommended = ResourceSpec {
49            cpu_request: Some(defaults.cpu_request.to_string()),
50            cpu_limit: Some(defaults.cpu_limit.to_string()),
51            memory_request: None,
52            memory_limit: None,
53        };
54
55        Some(ResourceRecommendation {
56            resource_kind: ctx.resource_kind.clone(),
57            resource_name: ctx.resource_name.clone(),
58            namespace: ctx.namespace.clone(),
59            container: ctx.container_name.clone(),
60            file_path: ctx.file_path.clone(),
61            line: ctx.line,
62            issue: OptimizationIssue::OverProvisioned,
63            severity: self.default_severity(),
64            message: format!(
65                "CPU request ({}) exceeds {}m threshold for {} workload. This is likely over-provisioned.",
66                cpu_request, config.max_cpu_request_millicores, ctx.workload_type
67            ),
68            workload_type: ctx.workload_type,
69            current: ctx.current.clone(),
70            actual_usage: None,
71            recommended: recommended.clone(),
72            savings: None,
73            fix_yaml: recommended.to_yaml(),
74            rule_code: RuleCode::new(self.code()),
75        })
76    }
77}
syncable_cli/analyzer/k8s_optimize/rules/k8s_opt_005.rs

syncable_cli/analyzer/k8s_optimize/rules/
k8s_opt_005.rs
