surrealdb_expr/val/value/convert/

coerce.rs

use std::collections::{BTreeMap, HashMap};
use std::fmt;
use std::hash::BuildHasher;

use geo::Point;
use rust_decimal::Decimal;
use surrealdb_types::ToSql;

use crate::expr::Kind;
use crate::expr::kind::{GeometryKind, HasKind, KindLiteral};
use crate::val::{
	Array, Bytes, Closure, Datetime, Duration, File, Geometry, Null, Number, Object, Range,
	RecordId, Regex, Set, SqlNone, Strand, TableName, Uuid, Value,
};

/// Identifies which element of a collection caused a coercion failure.
#[derive(Clone, Debug, PartialEq)]
pub enum ElementPosition {
	/// Zero-based index into an array or set.
	Index(usize),
	/// Key of an object field.
	Key(String),
}

#[derive(Clone, Debug)]
pub enum CoerceError {
	// Coercion error at the end.
	InvalidKind {
		from: Value,
		into: String,
	},
	InvalidLength {
		len: usize,
		into: String,
	},
	// Coerce failed because element of type didn't match.
	ElementOf {
		inner: Box<CoerceError>,
		into: String,
		position: Option<ElementPosition>,
	},
}
impl std::error::Error for CoerceError {}
impl fmt::Display for CoerceError {
	fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
		match self {
			CoerceError::InvalidKind {
				from,
				into,
			} => {
				write!(f, "Expected `{into}` but found `{from}`", from = from.to_sql())
			}
			CoerceError::ElementOf {
				inner,
				into,
				position,
			} => {
				inner.fmt(f)?;
				match position {
					Some(ElementPosition::Index(i)) => {
						write!(f, " when coercing element at index {i} of `{into}`")
					}
					Some(ElementPosition::Key(k)) => {
						write!(f, " when coercing value for key '{k}' of `{into}`")
					}
					None => write!(f, " when coercing an element of `{into}`"),
				}
			}
			CoerceError::InvalidLength {
				len,
				into,
			} => {
				write!(f, "Expected `{into}` but found a collection of length `{len}`")
			}
		}
	}
}

pub trait CoerceErrorExt {
	fn with_element_of<F>(self, f: F) -> Self
	where
		F: Fn() -> String;

	fn with_element_of_at_index<F>(self, index: usize, f: F) -> Self
	where
		F: Fn() -> String;
}

impl<T> CoerceErrorExt for Result<T, CoerceError> {
	fn with_element_of<F>(self, f: F) -> Self
	where
		F: Fn() -> String,
	{
		match self {
			Ok(x) => Ok(x),
			Err(e) => Err(CoerceError::ElementOf {
				inner: Box::new(e),
				into: f(),
				position: None,
			}),
		}
	}

	fn with_element_of_at_index<F>(self, index: usize, f: F) -> Self
	where
		F: Fn() -> String,
	{
		match self {
			Ok(x) => Ok(x),
			Err(e) => Err(CoerceError::ElementOf {
				inner: Box::new(e),
				into: f(),
				position: Some(ElementPosition::Index(index)),
			}),
		}
	}
}

/// Trait for converting the value using coercion rules.
///
/// Coercion rules are applied whenever a Value needs to be of a specific
/// [`Kind`]. This happens when a value is applied to a place with a type like
/// table fields and function parameters.
///
/// Coercion rules are more strict then casting rules.
/// Calling this method will succeed if the value can be unified with the kind
/// of the target
pub trait Coerce: Sized {
	/// Returns if calling coerce on the value will succeed or not.
	///
	/// If `T::can_coerce(&v)` returns `false` then `T::coerce(v) should not
	fn can_coerce(v: &Value) -> bool;

	/// Coerce a value.
	fn coerce(v: Value) -> Result<Self, CoerceError>;
}

impl Coerce for Value {
	fn can_coerce(_: &Value) -> bool {
		true
	}

	fn coerce(v: Value) -> Result<Self, CoerceError> {
		Ok(v)
	}
}

impl Coerce for SqlNone {
	fn can_coerce(v: &Value) -> bool {
		matches!(v, Value::None)
	}

	fn coerce(v: Value) -> Result<Self, CoerceError> {
		match v {
			Value::None => Ok(SqlNone),
			x => Err(CoerceError::InvalidKind {
				from: x,
				into: "none".to_string(),
			}),
		}
	}
}

impl Coerce for Null {
	fn can_coerce(v: &Value) -> bool {
		matches!(v, Value::Null)
	}

	fn coerce(v: Value) -> Result<Null, CoerceError> {
		match v {
			// Allow any null value
			Value::Null => Ok(Null),
			// Anything else raises an error
			_ => Err(CoerceError::InvalidKind {
				from: v,
				into: "null".into(),
			}),
		}
	}
}

impl Coerce for i64 {
	fn can_coerce(v: &Value) -> bool {
		let Value::Number(n) = v else {
			return false;
		};
		match n {
			Number::Int(_) => true,
			Number::Float(f) => f.fract() == 0.0,
			Number::Decimal(d) => i64::try_from(*d).is_ok(),
		}
	}

	fn coerce(val: Value) -> Result<Self, CoerceError> {
		match val {
			// Allow any int number
			Value::Number(Number::Int(v)) => Ok(v),
			// Attempt to convert an float number
			Value::Number(Number::Float(v)) if v.fract() == 0.0 => Ok(v as i64),
			// Attempt to convert a decimal number
			Value::Number(Number::Decimal(v)) if v.is_integer() => match v.try_into() {
				// The Decimal can be represented as an i64
				Ok(v) => Ok(v),
				// The Decimal is out of bounds
				_ => Err(CoerceError::InvalidKind {
					from: val,
					into: "int".into(),
				}),
			},
			// Anything else raises an error
			_ => Err(CoerceError::InvalidKind {
				from: val,
				into: "int".into(),
			}),
		}
	}
}

impl Coerce for f64 {
	fn can_coerce(v: &Value) -> bool {
		let Value::Number(n) = v else {
			return false;
		};
		match n {
			Number::Int(_) | Number::Float(_) => true,
			Number::Decimal(d) => f64::try_from(*d).is_ok(),
		}
	}

	/// Try to coerce this value to an `f64`
	fn coerce(val: Value) -> Result<f64, CoerceError> {
		match val {
			// Allow any float number
			Value::Number(Number::Float(v)) => Ok(v),
			// Attempt to convert an int number
			Value::Number(Number::Int(v)) => Ok(v as f64),
			// Attempt to convert a decimal number
			Value::Number(Number::Decimal(v)) => match v.try_into() {
				// The Decimal can be represented as a f64
				Ok(v) => Ok(v),
				// This Decimal loses precision
				_ => Err(CoerceError::InvalidKind {
					from: val,
					into: "float".into(),
				}),
			},
			// Anything else raises an error
			_ => Err(CoerceError::InvalidKind {
				from: val,
				into: "float".into(),
			}),
		}
	}
}

impl Coerce for Decimal {
	fn can_coerce(v: &Value) -> bool {
		let Value::Number(n) = v else {
			return false;
		};
		match n {
			Number::Int(_) | Number::Decimal(_) => true,
			Number::Float(f) => Decimal::try_from(*f).is_ok(),
		}
	}

	fn coerce(val: Value) -> Result<Self, CoerceError> {
		match val {
			// Allow any decimal number
			Value::Number(Number::Decimal(x)) => Ok(x),
			// Attempt to convert an int number
			Value::Number(Number::Int(v)) => Ok(Decimal::from(v)),
			// Attempt to convert an float number
			Value::Number(Number::Float(v)) => match Decimal::try_from(v).ok() {
				// The Float can be represented as a Decimal
				Some(v) => Ok(v),
				// This Float does not convert to a Decimal
				None => Err(CoerceError::InvalidKind {
					from: val,
					into: "decimal".into(),
				}),
			},
			// Anything else raises an error
			_ => Err(CoerceError::InvalidKind {
				from: val,
				into: "decimal".into(),
			}),
		}
	}
}

impl Coerce for File {
	fn can_coerce(v: &Value) -> bool {
		matches!(v, Value::File(_))
	}

	fn coerce(v: Value) -> Result<Self, CoerceError> {
		if let Value::File(x) = v {
			Ok(x)
		} else {
			Err(CoerceError::InvalidKind {
				from: v,
				into: "file".to_string(),
			})
		}
	}
}

impl Coerce for Point<f64> {
	fn can_coerce(v: &Value) -> bool {
		matches!(v, Value::Geometry(Geometry::Point(_)))
	}

	fn coerce(v: Value) -> Result<Self, CoerceError> {
		if let Value::Geometry(Geometry::Point(x)) = v {
			Ok(x)
		} else {
			Err(CoerceError::InvalidKind {
				from: v,
				into: "point".to_string(),
			})
		}
	}
}

impl<T: Coerce + HasKind> Coerce for Option<T> {
	fn can_coerce(v: &Value) -> bool {
		if let Value::None = v {
			return true;
		}
		T::can_coerce(v)
	}

	fn coerce(v: Value) -> Result<Self, CoerceError> {
		match v {
			Value::None => Ok(None),
			x => Ok(Some(T::coerce(x)?)),
		}
	}
}

impl<T: Coerce + HasKind> Coerce for Vec<T> {
	fn can_coerce(v: &Value) -> bool {
		let Value::Array(a) = v else {
			return false;
		};
		a.iter().all(T::can_coerce)
	}

	fn coerce(v: Value) -> Result<Self, CoerceError> {
		if !v.is_array() {
			return Err(CoerceError::InvalidKind {
				from: v,
				into: <Self as HasKind>::kind().to_sql(),
			});
		}
		// checked above
		let array = v.into_array().expect("value type checked above");

		let mut res = Vec::with_capacity(array.0.len());
		for (i, x) in array.0.into_iter().enumerate() {
			res.push(
				x.coerce_to::<T>()
					.with_element_of_at_index(i, || <Self as HasKind>::kind().to_sql())?,
			);
		}
		Ok(res)
	}
}

impl<T: Coerce + HasKind> Coerce for BTreeMap<String, T> {
	fn can_coerce(v: &Value) -> bool {
		let Value::Object(a) = v else {
			return false;
		};
		a.values().all(T::can_coerce)
	}

	fn coerce(v: Value) -> Result<Self, CoerceError> {
		if !v.is_object() {
			return Err(CoerceError::InvalidKind {
				from: v,
				into: Object::kind().to_sql(),
			});
		};
		// checked above
		let obj = v.into_object().expect("value type checked above");

		let mut res = BTreeMap::new();
		for (k, v) in obj.0 {
			// object<T> kinds don't actually exist in surql.
			let key = k.into_string();
			let value = match v.coerce_to::<T>() {
				Ok(v) => v,
				Err(e) => {
					return Err(CoerceError::ElementOf {
						inner: Box::new(e),
						into: format!("object<{}>", <T as HasKind>::kind().to_sql()),
						position: Some(ElementPosition::Key(key)),
					});
				}
			};
			res.insert(key, value);
		}
		Ok(res)
	}
}

impl<T: Coerce + HasKind, S: BuildHasher + Default> Coerce for HashMap<String, T, S> {
	fn can_coerce(v: &Value) -> bool {
		let Value::Object(a) = v else {
			return false;
		};
		a.values().all(T::can_coerce)
	}

	fn coerce(v: Value) -> Result<Self, CoerceError> {
		if !v.is_object() {
			return Err(CoerceError::InvalidKind {
				from: v,
				into: Kind::of::<Object>().to_sql(),
			});
		};
		// checked above
		let obj = v.into_object().expect("value type checked above");

		let mut res = HashMap::default();
		for (k, v) in obj.0 {
			// object<T> kinds don't actually exist in surql.
			let key = k.into_string();
			let value = match v.coerce_to::<T>() {
				Ok(v) => v,
				Err(e) => {
					return Err(CoerceError::ElementOf {
						inner: Box::new(e),
						into: format!("object<{}>", <T as HasKind>::kind().to_sql()),
						position: Some(ElementPosition::Key(key)),
					});
				}
			};
			res.insert(key, value);
		}
		Ok(res)
	}
}

macro_rules! impl_direct {
	($($name:ident => $inner:ty $(= $kind:ident)?),*$(,)?) => {
		$(
		impl Coerce for $inner {
			fn can_coerce(v: &Value) -> bool{
				matches!(v, Value::$name(_))
			}

			fn coerce(v: Value) -> Result<Self, CoerceError> {
				if let Value::$name(x) = v {
					return Ok(x);
				} else {
					return Err(CoerceError::InvalidKind{
						from: v,
						into: impl_direct!(@kindof $inner $(= $kind)?),
					});
				}
			}
		}
		)*
	};

	(@kindof $inner:ty = $kind:ident) => {
		Kind::of::<$kind>().to_sql()
	};

	(@kindof $inner:ty) => {
		Kind::of::<$inner>().to_sql()
	};
}

// Types which directly match one enum variant or fail
impl_direct! {
	Bool => bool,
	Number => Number,
	Uuid => Uuid,
	Closure => Box<Closure> = Closure,
	Range => Box<Range> = Range,
	Datetime => Datetime,
	Duration => Duration,
	Bytes => Bytes,
	Object => Object,
	Array => Array,
	RecordId => RecordId,
	String => Strand = String,
	Geometry => Geometry,
	Regex => Regex,
	Table => TableName,
}

impl Coerce for Set {
	fn can_coerce(v: &Value) -> bool {
		matches!(v, Value::Set(_) | Value::Array(_))
	}

	fn coerce(v: Value) -> Result<Self, CoerceError> {
		match v {
			Value::Set(x) => Ok(x),
			Value::Array(x) => Ok(Set::from(x.0)),
			v => Err(CoerceError::InvalidKind {
				from: v,
				into: Kind::of::<Set>().to_sql(),
			}),
		}
	}
}

/// `String` coercion delegates to `Strand` and converts on success
/// so existing `coerce_to::<String>()` call sites keep working.
impl Coerce for String {
	fn can_coerce(v: &Value) -> bool {
		matches!(v, Value::String(_))
	}

	fn coerce(v: Value) -> Result<Self, CoerceError> {
		match v {
			Value::String(s) => Ok(s.into_string()),
			v => Err(CoerceError::InvalidKind {
				from: v,
				into: Kind::of::<String>().to_sql(),
			}),
		}
	}
}

// Coerce to runtime value implementations
impl Value {
	pub fn can_coerce_to<T: Coerce>(&self) -> bool {
		T::can_coerce(self)
	}

	pub fn can_coerce_to_kind(&self, kind: &Kind) -> bool {
		match kind {
			Kind::Any => true,
			Kind::None => self.can_coerce_to::<SqlNone>(),
			Kind::Null => self.can_coerce_to::<Null>(),
			Kind::Bool => self.can_coerce_to::<bool>(),
			Kind::Int => self.can_coerce_to::<i64>(),
			Kind::Float => self.can_coerce_to::<f64>(),
			Kind::Decimal => self.can_coerce_to::<Decimal>(),
			Kind::Number => self.can_coerce_to::<Number>(),
			Kind::String => self.can_coerce_to::<String>(),
			Kind::Datetime => self.can_coerce_to::<Datetime>(),
			Kind::Duration => self.can_coerce_to::<Duration>(),
			Kind::Object => self.can_coerce_to::<crate::val::Object>(),
			Kind::Bytes => self.can_coerce_to::<Bytes>(),
			Kind::Uuid => self.can_coerce_to::<Uuid>(),
			Kind::Regex => self.can_coerce_to::<Regex>(),
			Kind::Range => self.can_coerce_to::<Box<Range>>(),
			Kind::Function(_, _) => self.can_coerce_to::<Box<Closure>>(),
			Kind::Set(t, l) => match l {
				Some(l) => self.can_coerce_to_set_len(t, *l),
				None => self.can_coerce_to_set(t),
			},
			Kind::Array(t, l) => match l {
				Some(l) => self.can_coerce_to_array_len(t, *l),
				None => self.can_coerce_to_array(t),
			},
			Kind::Table(t) => {
				if t.is_empty() {
					self.can_coerce_to::<String>()
				} else {
					self.can_coerce_to_table(t)
				}
			}
			Kind::Record(t) => {
				if t.is_empty() {
					self.can_coerce_to::<RecordId>()
				} else {
					self.can_coerce_to_record(t)
				}
			}
			Kind::Geometry(t) => {
				if t.is_empty() {
					self.can_coerce_to::<Geometry>()
				} else {
					self.can_coerce_to_geometry(t)
				}
			}
			Kind::Either(k) => k.iter().any(|x| self.can_coerce_to_kind(x)),
			Kind::Literal(lit) => self.can_coerce_to_literal(lit),
			Kind::File(buckets) => {
				if buckets.is_empty() {
					self.can_coerce_to::<File>()
				} else {
					self.can_coerce_to_file_buckets(buckets)
				}
			}
		}
	}

	fn can_coerce_to_array_len(&self, kind: &Kind, len: u64) -> bool {
		match self {
			Value::Array(a) => {
				a.len() as u64 == len && a.iter().all(|x| x.can_coerce_to_kind(kind))
			}
			_ => false,
		}
	}

	fn can_coerce_to_array(&self, kind: &Kind) -> bool {
		match self {
			Value::Array(a) => a.iter().all(|x| x.can_coerce_to_kind(kind)),
			_ => false,
		}
	}

	fn can_coerce_to_set_len(&self, kind: &Kind, len: u64) -> bool {
		match self {
			Value::Set(s) => s.len() as u64 == len && s.iter().all(|x| x.can_coerce_to_kind(kind)),
			Value::Array(a) => {
				a.len() as u64 == len && a.iter().all(|x| x.can_coerce_to_kind(kind))
			}
			_ => false,
		}
	}

	fn can_coerce_to_set(&self, kind: &Kind) -> bool {
		match self {
			Value::Set(s) => s.iter().all(|x| x.can_coerce_to_kind(kind)),
			Value::Array(a) => a.iter().all(|x| x.can_coerce_to_kind(kind)),
			_ => false,
		}
	}

	fn can_coerce_to_table(&self, val: &[TableName]) -> bool {
		match self {
			Value::Table(t) => val.is_empty() || val.contains(t),
			Value::String(s) => {
				// Allow strings to be coerced to tables
				if val.is_empty() {
					true
				} else {
					let s = TableName::from(s.clone());
					val.contains(&s)
				}
			}
			_ => false,
		}
	}

	fn can_coerce_to_record(&self, val: &[TableName]) -> bool {
		match self {
			Value::RecordId(t) => val.is_empty() || val.contains(&t.table),
			_ => false,
		}
	}

	fn can_coerce_to_geometry(&self, val: &[GeometryKind]) -> bool {
		self.is_geometry_type(val)
	}

	fn can_coerce_to_literal(&self, val: &KindLiteral) -> bool {
		val.validate_value(self)
	}

	fn can_coerce_to_file_buckets(&self, buckets: &[String]) -> bool {
		matches!(self, Value::File(f) if f.is_bucket_type(buckets))
	}

	/// Convert the value using coercion rules.
	///
	/// Coercion rules are more strict then coverting rules.
	/// Calling this method will succeed if the value can by unified with the
	/// kind of the target
	///
	/// This method is a shorthand for `T::coerce(self)`
	pub fn coerce_to<T: Coerce>(self) -> Result<T, CoerceError> {
		T::coerce(self)
	}

	/// Try to coerce this value to the specified `Kind`
	pub fn coerce_to_kind(self, kind: &Kind) -> Result<Value, CoerceError> {
		// Attempt to convert to the desired type
		match kind {
			Kind::Any => Ok(self),
			Kind::None => self.coerce_to::<SqlNone>().map(|_| Value::None),
			Kind::Null => self.coerce_to::<Null>().map(Value::from),
			Kind::Bool => self.coerce_to::<bool>().map(Value::from),
			Kind::Int => self.coerce_to::<i64>().map(Value::from),
			Kind::Float => self.coerce_to::<f64>().map(Value::from),
			Kind::Decimal => self.coerce_to::<Decimal>().map(Value::from),
			Kind::Number => self.coerce_to::<Number>().map(Value::from),
			Kind::String => self.coerce_to::<String>().map(Value::from),
			Kind::Datetime => self.coerce_to::<Datetime>().map(Value::from),
			Kind::Duration => self.coerce_to::<Duration>().map(Value::from),
			Kind::Object => self.coerce_to::<crate::val::Object>().map(Value::from),
			Kind::Bytes => self.coerce_to::<Bytes>().map(Value::from),
			Kind::Uuid => self.coerce_to::<Uuid>().map(Value::from),
			Kind::Regex => self.coerce_to::<Regex>().map(Value::from),
			Kind::Range => self.coerce_to::<Box<Range>>().map(Value::from),
			Kind::Function(_, _) => self.coerce_to::<Box<Closure>>().map(Value::from),
			Kind::Set(t, l) => match l {
				Some(l) => self.coerce_to_set_kind_len(t, *l).map(Value::from),
				None => self.coerce_to_set_kind(t).map(Value::from),
			},
			Kind::Array(t, l) => match l {
				Some(l) => self.coerce_to_array_type_len(t, *l).map(Value::from),
				None => self.coerce_to_array_type(t).map(Value::from),
			},
			Kind::Table(t) => {
				if t.is_empty() {
					self.coerce_to::<String>()
						.map(|s| Value::Table(surrealdb_strand::TableName::new(s)))
				} else {
					self.coerce_to_table_kind(t).map(Value::from)
				}
			}
			Kind::Record(t) => {
				if t.is_empty() {
					self.coerce_to::<RecordId>().map(Value::from)
				} else {
					self.coerce_to_record_kind(t).map(Value::from)
				}
			}
			Kind::Geometry(t) => {
				if t.is_empty() {
					self.coerce_to::<Geometry>().map(Value::from)
				} else {
					self.coerce_to_geometry_kind(t).map(Value::from)
				}
			}
			Kind::Either(k) => {
				// Check first for valid kind, then convert to not consume the value
				let Some(k) = k.iter().find(|x| self.can_coerce_to_kind(x)) else {
					return Err(CoerceError::InvalidKind {
						from: self,
						into: kind.to_sql(),
					});
				};

				Ok(self.coerce_to_kind(k).expect(
					"If can_coerce_to_kind returns true then coerce_to_kind must not error",
				))
			}
			Kind::Literal(lit) => self.coerce_to_literal(lit),
			Kind::File(buckets) => {
				if buckets.is_empty() {
					self.coerce_to::<File>().map(Value::from)
				} else {
					self.coerce_to_file_buckets(buckets).map(Value::from)
				}
			}
		}
	}

	/// Try to coerce this value to a Literal, returns a `Value` with the
	/// coerced value
	pub fn coerce_to_literal(self, literal: &KindLiteral) -> Result<Value, CoerceError> {
		if literal.validate_value(&self) {
			Ok(self)
		} else {
			Err(CoerceError::InvalidKind {
				from: self,
				into: literal.to_sql(),
			})
		}
	}

	/// Try to coerce this value to a Table of a certain type
	pub fn coerce_to_table_kind(
		self,
		val: &[TableName],
	) -> Result<surrealdb_strand::TableName, CoerceError> {
		let this = match self {
			// Tables are allowed if correct type
			Value::Table(v) => {
				if val.is_empty() || val.contains(&v) {
					return Ok(v);
				} else {
					Value::Table(v)
				}
			}
			// Allow strings to be coerced to tables
			Value::String(s) => {
				if val.is_empty() {
					return Ok(surrealdb_strand::TableName::new(s));
				}

				let t = TableName::from(s);
				if val.contains(&t) {
					return Ok(t);
				}

				Value::String(t.into())
			}
			x => x,
		};

		let mut kind = "table<".to_string();
		for (idx, t) in val.iter().enumerate() {
			if idx != 0 {
				kind.push('|');
			}
			kind.push_str(t.as_str())
		}
		kind.push('>');
		Err(CoerceError::InvalidKind {
			from: this,
			into: kind,
		})
	}

	/// Try to coerce this value to a Record of a certain type
	pub fn coerce_to_record_kind(self, val: &[TableName]) -> Result<RecordId, CoerceError> {
		let this = match self {
			// Records are allowed if correct type
			Value::RecordId(v) => {
				if val.is_empty() || val.contains(&v.table) {
					return Ok(v);
				} else {
					Value::RecordId(v)
				}
			}
			x => x,
		};

		let mut kind = "record<".to_string();
		for (idx, t) in val.iter().enumerate() {
			if idx != 0 {
				kind.push('|');
			}
			kind.push_str(t.as_str())
		}
		kind.push('>');
		Err(CoerceError::InvalidKind {
			from: this,
			into: kind,
		})
	}

	/// Try to coerce this value to a `Geometry` of a certain type
	pub fn coerce_to_geometry_kind(self, val: &[GeometryKind]) -> Result<Geometry, CoerceError> {
		if self.is_geometry_type(val) {
			let Value::Geometry(x) = self else {
				// Checked above in is_geometry_type
				unreachable!()
			};
			Ok(x)
		} else {
			Err(CoerceError::InvalidKind {
				from: self,
				into: "geometry".into(),
			})
		}
	}

	/// Try to coerce this value to an `Array` of a certain type
	pub fn coerce_to_array_type(self, kind: &Kind) -> Result<Array, CoerceError> {
		self.coerce_to::<Array>()?
			.into_iter()
			.enumerate()
			.map(|(i, value)| {
				value
					.coerce_to_kind(kind)
					.with_element_of_at_index(i, || format!("array<{}>", kind.to_sql()))
			})
			.collect::<Result<Array, CoerceError>>()
	}

	/// Try to coerce this value to an `Array` of a certain type, and length
	pub fn coerce_to_array_type_len(self, kind: &Kind, len: u64) -> Result<Array, CoerceError> {
		let array = self.coerce_to::<Array>()?;

		if array.len() as u64 != len {
			return Err(CoerceError::InvalidLength {
				len: array.len(),
				into: format!("array<{},{}>", kind.to_sql(), len),
			});
		}

		array
			.into_iter()
			.enumerate()
			.map(|(i, value)| {
				value
					.coerce_to_kind(kind)
					.with_element_of_at_index(i, || format!("array<{}>", kind.to_sql()))
			})
			.collect::<Result<Array, CoerceError>>()
	}

	/// Try to coerce this value to a `Set` of a certain type
	pub fn coerce_to_set_kind(self, kind: &Kind) -> Result<Set, CoerceError> {
		self.coerce_to::<Set>()?
			.into_iter()
			.enumerate()
			.map(|(i, value)| {
				value
					.coerce_to_kind(kind)
					.with_element_of_at_index(i, || format!("set<{}>", kind.to_sql()))
			})
			.collect::<Result<Set, CoerceError>>()
	}

	/// Try to coerce this value to a `Set` of a certain type and length
	pub fn coerce_to_set_kind_len(self, kind: &Kind, len: u64) -> Result<Set, CoerceError> {
		let set = self
			.coerce_to::<Set>()?
			.into_iter()
			.enumerate()
			.map(|(i, value)| {
				value
					.coerce_to_kind(kind)
					.with_element_of_at_index(i, || format!("set<{}>", kind.to_sql()))
			})
			.collect::<Result<Set, CoerceError>>()?;

		if set.len() as u64 != len {
			return Err(CoerceError::InvalidLength {
				into: format!("set<{},{}>", kind.to_sql(), len),
				len: set.len(),
			});
		}

		Ok(set)
	}

	pub fn coerce_to_file_buckets(self, buckets: &[String]) -> Result<File, CoerceError> {
		let v = self.coerce_to::<File>()?;

		if v.is_bucket_type(buckets) {
			return Ok(v);
		}

		let mut kind = "file<".to_owned();
		for (idx, t) in buckets.iter().enumerate() {
			if idx != 0 {
				kind.push('|');
			}
			kind.push_str(t.as_str())
		}
		kind.push('>');
		Err(CoerceError::InvalidKind {
			from: v.into(),
			into: kind,
		})
	}
}

#[cfg(test)]
mod tests {
	use surrealdb_strand::Strand;

	use super::*;

	#[test]
	fn test_coerce_array_element_position_in_error() {
		// An array where the second element (index 1) is the wrong type.
		let value = Value::Array(Array(vec![
			Value::Number(1.into()),
			Value::String(Strand::new_static("bad")),
			Value::Number(3.into()),
		]));
		let kind = Kind::Int;
		let err = value.coerce_to_array_type(&kind).unwrap_err();
		let msg = err.to_string();
		assert!(msg.contains("index 1"), "error message should mention index 1, got: {msg}");
	}

	#[test]
	fn test_coerce_object_key_position_in_error() {
		use std::collections::BTreeMap;

		let mut map = BTreeMap::new();
		map.insert(surrealdb_strand::Strand::new_static("valid"), Value::Number(1.into()));
		map.insert(
			surrealdb_strand::Strand::new_static("bad_field"),
			Value::String(Strand::new_static("not_an_int")),
		);
		let value = Value::Object(Object(map.into()));

		let err = value.coerce_to::<BTreeMap<String, i64>>().unwrap_err();
		let msg = err.to_string();
		assert!(
			msg.contains("bad_field"),
			"error message should mention the key 'bad_field', got: {msg}"
		);
	}

	#[test]
	fn test_coerce_vec_element_position_in_error() {
		let value = Value::Array(Array(vec![
			Value::Number(1.into()),
			Value::Number(2.into()),
			Value::String(Strand::new_static("oops")),
		]));

		let err = value.coerce_to::<Vec<i64>>().unwrap_err();
		let msg = err.to_string();
		assert!(msg.contains("index 2"), "error message should mention index 2, got: {msg}");
	}

	#[test]
	fn test_coerce_to_table_generic() {
		// Test coercing string to generic table type
		let value = Value::String(Strand::new_static("users"));
		let kind = Kind::Table(vec![]);
		let result = value.coerce_to_kind(&kind);
		assert!(result.is_ok());
		if let Ok(Value::Table(table)) = result {
			assert_eq!(table.as_str(), "users");
		}
	}

	#[test]
	fn test_coerce_to_table_specific() {
		// Coercion should fail for wrong table name (more strict than cast)
		let value = Value::String(Strand::new_static("posts"));
		let kind = Kind::Table(vec!["users".into()]);
		let result = value.coerce_to_kind(&kind);
		// Coercion from string to specific table type should fail because
		// coercion is stricter and only allows exact matches
		assert!(result.is_err());
	}

	#[test]
	fn test_coerce_table_to_table() {
		// Test coercing table value to matching table type
		let value = Value::Table("users".into());
		let kind = Kind::Table(vec!["users".into()]);
		let result = value.coerce_to_kind(&kind);
		assert!(result.is_ok());

		// Test coercing table value to non-matching table type
		let value = Value::Table("posts".into());
		let kind = Kind::Table(vec!["users".into()]);
		let result = value.coerce_to_kind(&kind);
		assert!(result.is_err());
	}

	#[test]
	fn test_can_coerce_to_table() {
		// Test can_coerce_to_kind for tables
		let value = Value::Table("users".into());
		let kind = Kind::Table(vec!["users".into()]);
		assert!(value.can_coerce_to_kind(&kind));

		// Wrong table name
		let value = Value::Table("posts".into());
		let kind = Kind::Table(vec!["users".into()]);
		assert!(!value.can_coerce_to_kind(&kind));

		// Wrong type
		let value = Value::Number(42.into());
		let kind = Kind::Table(vec![]);
		assert!(!value.can_coerce_to_kind(&kind));
	}

	#[test]
	fn test_coerce_table_empty_tables_list() {
		// Test with empty tables list (should accept any table)
		let value = Value::Table("anything".into());
		let kind = Kind::Table(vec![]);
		let result = value.coerce_to_kind(&kind);
		assert!(result.is_err()); // Coercion from string is strict
	}
}