subx_cli/

lib.rs

//! SubX: Intelligent Subtitle Processing Library
//!
//! SubX is a comprehensive Rust library for intelligent subtitle file processing,
//! featuring AI-powered matching, format conversion, audio synchronization,
//! and advanced encoding detection capabilities.
//!
//! # Key Features
//!
//! - **AI-Powered Matching**: Intelligent subtitle file matching and renaming
//! - **Format Conversion**: Support for multiple subtitle formats (SRT, ASS, VTT, etc.)
//! - **Audio Synchronization**: Advanced audio-subtitle timing adjustment
//! - **Encoding Detection**: Automatic character encoding detection and conversion
//! - **Parallel Processing**: High-performance batch operations
//! - **Configuration Management**: Flexible multi-source configuration system
//!
//! # Architecture Overview
//!
//! The library is organized into several key modules:
//!
//! - [`cli`] - Command-line interface and argument parsing
//! - [`commands`] - Implementation of all SubX commands
//!
//! The [`config`], [`core`], [`error`] and [`services`] modules are owned by
//! the `subx_core` crate — the library half of the SubX two-crate split, a
//! git submodule mounted at `subx-core/` and a member of this Cargo
//! workspace. They are re-exported below under their pre-split paths so
//! existing consumers keep compiling; `subx_core::` is the canonical path.
//!
//! # Quick Start
//!
//! ```rust,no_run
//! use subx_cli::config::{TestConfigService, ConfigService};
//!
//! // Create a configuration service
//! let config_service = TestConfigService::with_defaults();
//! let config = config_service.config();
//!
//! // Use the configuration for processing...
//! ```
//!
//! # Error Handling
//!
//! All operations return a [`Result<T>`] type that wraps [`error::SubXError`]:
//!
//! ```rust
//! use subx_cli::{Result, error::SubXError};
//!
//! fn example_operation() -> Result<String> {
//!     // This could fail with various error types
//!     Err(SubXError::config("Missing configuration"))
//! }
//! ```
//!
//! # Configuration
//!
//! SubX supports dependency injection-based configuration:
//!
//! ```rust,no_run
//! use subx_cli::config::{TestConfigService, Config};
//!
//! // Create configuration service with AI settings
//! let config_service = TestConfigService::with_ai_settings("openai", "gpt-4.1");
//! let config = config_service.config();
//!
//! // Access configuration values
//! println!("AI Provider: {}", config.ai.provider);
//! println!("AI Model: {}", config.ai.model);
//! ```
//!
//! # Performance Considerations
//!
//! - Use [`core::parallel`] for batch operations on large file sets
//! - Configure appropriate cache settings for repeated operations
//! - Consider memory usage when processing large audio files
//!
//! # Thread Safety
//!
//! The library is designed to be thread-safe where appropriate:
//! - Configuration manager uses `Arc<RwLock<T>>` for shared state
//! - File operations include rollback capabilities for atomicity
//! - Parallel processing uses safe concurrency patterns
//!
//! # Feature Flags
//!
//! Both optional features of this crate are pass-throughs that enable the
//! matching gate in the `subx-core` crate (where the gated sources live) and
//! nothing else:
//! ```text
//! - archive-rar - enable RAR archive extraction (optional unrar dependency)
//! - slow-tests  - compile long-running tests in both crates
//! ```

#![allow(
    clippy::new_without_default,
    clippy::manual_clamp,
    clippy::useless_vec,
    clippy::items_after_test_module,
    clippy::needless_borrow,
    clippy::uninlined_format_args,
    clippy::collapsible_if
)]
#![warn(missing_docs)]
#![warn(rustdoc::missing_crate_level_docs)]

/// Library version string.
///
/// This constant provides the current version of the SubX library,
/// automatically populated from `Cargo.toml` at compile time.
///
/// # Examples
///
/// ```rust
/// use subx_cli::VERSION;
///
/// println!("SubX version: {}", VERSION);
/// ```
pub const VERSION: &str = env!("CARGO_PKG_VERSION");

/// Version of the `subx-core` library this build is linked against.
///
/// This constant reports the version of the [`subx_core`] crate resolved at
/// build time (the git submodule mounted at `subx-core/`), and is distinct
/// from [`VERSION`], which reports this CLI crate's own version. The two
/// crates carry independent version lines related only by the caret
/// requirement in `Cargo.toml`.
///
/// # Examples
///
/// ```rust
/// use subx_cli::CORE_VERSION;
///
/// assert!(!CORE_VERSION.is_empty());
/// println!("Linked subx-core version: {}", CORE_VERSION);
/// ```
pub const CORE_VERSION: &str = subx_core::VERSION;

pub mod cli;
pub mod commands;

// ── Legacy back-compat re-exports of the subx-core crate ──────────────────
//
// `config`, `core`, `error` and `services` moved to the `subx-core` crate
// (the library half of the SubX two-crate split). Their canonical paths are
// now `subx_core::{config, core, error, services}`; the re-exports below
// exist only so consumers written against the pre-split `subx_cli::` paths
// keep compiling, and they will be deleted once every out-of-tree consumer
// (the Tauri GUI first) has migrated. Code inside this crate names
// `subx_core::…` directly and never resolves through them.
//
// Documentation: `docs.rs/subx-core` is the canonical rustdoc for these
// four modules and everything under them. The re-exported pages that
// appear on `docs.rs/subx-cli` are generated by the `--workspace` doc
// build and merely forward there; readers of the library API should go to
// the `subx-core` documentation directly.

/// Configuration management and validation.
///
/// Legacy re-export: the module now lives in the `subx-core` crate; the
/// canonical path is [`subx_core::config`]. This alias exists for consumers
/// that have not yet migrated and will be removed once they have.
pub use subx_core::config;
/// Core processing engines (formats, matching, sync).
///
/// Legacy re-export: the module now lives in the `subx-core` crate; the
/// canonical path is [`subx_core::core`]. This alias exists for consumers
/// that have not yet migrated and will be removed once they have.
pub use subx_core::core;
/// Comprehensive error handling system.
///
/// Legacy re-export: the module now lives in the `subx-core` crate; the
/// canonical path is [`subx_core::error`]. This alias exists for consumers
/// that have not yet migrated and will be removed once they have.
pub use subx_core::error;
/// External service integrations (AI, audio processing).
///
/// Legacy re-export: the module now lives in the `subx-core` crate; the
/// canonical path is [`subx_core::services`]. This alias exists for
/// consumers that have not yet migrated and will be removed once they have.
pub use subx_core::services;

/// Root configuration types.
///
/// Legacy re-exports: these types now live in the `subx-core` crate, where
/// the canonical paths are `subx_core::Config` and `subx_core::ConfigService`
/// and so on. They exist for consumers that have not yet migrated and will
/// be removed once they have.
pub use subx_core::Config;
pub use subx_core::{
    ConfigService, EnvironmentProvider, ProductionConfigService, SystemEnvironmentProvider,
    TestConfigBuilder, TestConfigService, TestEnvironmentProvider,
};

/// All twelve `#[macro_export]` configuration test macros, re-exported from
/// the `subx-core` crate.
///
/// `#[macro_export]` places a macro at its defining crate's root, so
/// `pub use subx_core::config;` above cannot reach them; they are listed
/// individually. Legacy re-exports for consumers that have not yet migrated
/// to `subx_core::` paths, and will be removed once they have.
pub use subx_core::{
    create_default_test_config_service, create_production_config_service_with_empty_env,
    create_production_config_service_with_env, create_test_config_service,
    test_production_config_with_env, test_production_config_with_openai_env, test_with_ai_config,
    test_with_ai_config_and_key, test_with_config, test_with_default_config,
    test_with_parallel_config, test_with_sync_config,
};

/// Convenient type alias for `Result<T, SubXError>`.
///
/// Denotes the same type as before the crate split: the error type now lives
/// in the `subx-core` crate, and this alias is the legacy `subx_cli::Result`
/// path kept for consumers that have not yet migrated to
/// [`subx_core::Result`].
pub type Result<T> = subx_core::error::SubXResult<T>;

/// Main application structure with dependency injection support.
///
/// The `App` struct provides a programmatic interface to SubX functionality,
/// designed for embedding SubX in other Rust applications or for advanced
/// use cases requiring fine-grained control over configuration and execution.
///
/// # Use Cases
///
/// - **Embedding**: Use SubX as a library component in larger applications
/// - **Testing**: Programmatic testing of SubX functionality with custom configurations
/// - **Automation**: Scripted execution of SubX operations without shell commands
/// - **Custom Workflows**: Building complex workflows that combine multiple SubX operations
///
/// # vs CLI Interface
///
/// | Feature | CLI (`subx` command) | App (Library API) |
/// |---------|---------------------|-------------------|
/// | Usage | Command line tool | Embedded in Rust code |
/// | Config | Files + Environment | Programmatic injection |
/// | Output | Terminal/stdout | Programmatic control |
/// | Error Handling | Exit codes | Result types |
///
/// # Examples
///
/// ## Basic Usage
///
/// ```rust,no_run
/// use subx_cli::{App, config::ProductionConfigService};
/// use std::sync::Arc;
///
/// # async fn example() -> subx_cli::Result<()> {
/// let config_service = Arc::new(ProductionConfigService::new()?);
/// let app = App::new(config_service);
///
/// // Execute operations programmatically
/// app.match_files("/movies", true).await?; // dry run
/// app.convert_files("/subs", "srt", Some("/output")).await?;
/// # Ok(())
/// # }
/// ```
///
/// ## With Custom Configuration
///
/// ```rust,no_run
/// use subx_cli::{App, config::{TestConfigService, Config}};
/// use std::sync::Arc;
///
/// # async fn example() -> subx_cli::Result<()> {
/// let mut config_service = TestConfigService::with_ai_settings("openai", "gpt-4");
///
/// let app = App::new(Arc::new(config_service));
/// app.match_files("/path", false).await?;
/// # Ok(())
/// # }
/// ```
pub struct App {
    config_service: std::sync::Arc<dyn config::ConfigService>,
}

impl App {
    /// Create a new application instance with the provided configuration service.
    ///
    /// # Arguments
    ///
    /// * `config_service` - The configuration service to use
    ///
    /// # Examples
    ///
    /// ```rust,no_run
    /// use subx_cli::{App, config::TestConfigService};
    /// use std::sync::Arc;
    ///
    /// let config_service = Arc::new(TestConfigService::with_defaults());
    /// let app = App::new(config_service);
    /// ```
    pub fn new(config_service: std::sync::Arc<dyn config::ConfigService>) -> Self {
        Self { config_service }
    }

    /// Create a new application instance with the production configuration service.
    ///
    /// This is the default way to create an application instance for production use.
    ///
    /// # Examples
    ///
    /// ```rust,no_run
    /// use subx_cli::App;
    ///
    /// # async fn example() -> subx_cli::Result<()> {
    /// let app = App::new_with_production_config()?;
    /// // Ready to use with production configuration
    /// # Ok(())
    /// # }
    /// ```
    ///
    /// # Errors
    ///
    /// Returns an error if the production configuration service cannot be created.
    pub fn new_with_production_config() -> Result<Self> {
        let config_service = std::sync::Arc::new(config::ProductionConfigService::new()?);
        Ok(Self::new(config_service))
    }

    /// Run the application with command-line argument parsing.
    ///
    /// This method provides a programmatic way to run SubX with CLI-style
    /// arguments, useful for embedding SubX in other Rust applications.
    ///
    /// # Examples
    ///
    /// ```rust,no_run
    /// use subx_cli::{App, config::ProductionConfigService};
    /// use std::sync::Arc;
    ///
    /// # async fn example() -> subx_cli::Result<()> {
    /// let config_service = Arc::new(ProductionConfigService::new()?);
    /// let app = App::new(config_service);
    ///
    /// // This parses std::env::args() just like the CLI
    /// app.run().await?;
    /// # Ok(())
    /// # }
    /// ```
    ///
    /// # Errors
    ///
    /// Returns an error if command execution fails.
    pub async fn run(&self) -> Result<()> {
        let cli = <cli::Cli as clap::Parser>::parse();
        self.handle_command(cli.command).await
    }

    /// Handle a specific command with the current configuration.
    ///
    /// This method allows programmatic execution of specific SubX commands
    /// without parsing command-line arguments.
    ///
    /// # Examples
    ///
    /// ```rust,no_run
    /// use subx_cli::{App, cli::{Commands, MatchArgs}, config::TestConfigService};
    /// use std::sync::Arc;
    ///
    /// # async fn example() -> subx_cli::Result<()> {
    /// let config_service = Arc::new(TestConfigService::with_defaults());
    /// let app = App::new(config_service);
    ///
    /// let match_args = MatchArgs {
    ///     path: Some("/path/to/files".into()),
    ///     input_paths: vec![],
    ///     dry_run: true,
    ///     confidence: 80,
    ///     recursive: false,
    ///     backup: false,
    ///     copy: false,
    ///     move_files: false,
    ///     no_extract: false,
    /// };
    ///
    /// app.handle_command(Commands::Match(match_args)).await?;
    /// # Ok(())
    /// # }
    /// ```
    ///
    /// # Arguments
    ///
    /// * `command` - The command to execute
    ///
    /// # Errors
    ///
    /// Returns an error if command execution fails.
    pub async fn handle_command(&self, command: cli::Commands) -> Result<()> {
        // Use the centralized dispatcher to eliminate code duplication
        crate::commands::dispatcher::dispatch_command(command, self.config_service.clone()).await
    }

    /// Execute a match operation programmatically.
    ///
    /// This is a convenience method for programmatic usage without
    /// needing to construct the Commands enum manually.
    ///
    /// # Examples
    ///
    /// ```rust,no_run
    /// use subx_cli::{App, config::TestConfigService};
    /// use std::sync::Arc;
    ///
    /// # async fn example() -> subx_cli::Result<()> {
    /// let config_service = Arc::new(TestConfigService::with_defaults());
    /// let app = App::new(config_service);
    ///
    /// // Match files programmatically
    /// app.match_files("/path/to/files", true).await?; // dry_run = true
    /// # Ok(())
    /// # }
    /// ```
    ///
    /// # Arguments
    ///
    /// * `input_path` - Path to the directory or file to process
    /// * `dry_run` - Whether to perform a dry run (no actual changes)
    ///
    /// # Errors
    ///
    /// Returns an error if the match operation fails.
    pub async fn match_files(&self, input_path: &str, dry_run: bool) -> Result<()> {
        let args = cli::MatchArgs {
            path: Some(input_path.into()),
            input_paths: vec![],
            dry_run,
            confidence: 80,
            recursive: false,
            backup: false,
            copy: false,
            move_files: false,
            no_extract: false,
        };
        self.handle_command(cli::Commands::Match(args)).await
    }

    /// Convert subtitle files programmatically.
    ///
    /// # Examples
    ///
    /// ```rust,no_run
    /// use subx_cli::{App, config::TestConfigService};
    /// use std::sync::Arc;
    ///
    /// # async fn example() -> subx_cli::Result<()> {
    /// let config_service = Arc::new(TestConfigService::with_defaults());
    /// let app = App::new(config_service);
    ///
    /// // Convert to SRT format
    /// app.convert_files("/path/to/subtitles", "srt", Some("/output/path")).await?;
    /// # Ok(())
    /// # }
    /// ```
    ///
    /// # Arguments
    ///
    /// * `input_path` - Path to subtitle files to convert
    /// * `output_format` - Target format ("srt", "ass", "vtt", etc.)
    /// * `output_path` - Optional output directory path
    ///
    /// # Errors
    ///
    /// Returns an error if the conversion fails.
    pub async fn convert_files(
        &self,
        input_path: &str,
        output_format: &str,
        output_path: Option<&str>,
    ) -> Result<()> {
        let format = match output_format.to_lowercase().as_str() {
            "srt" => cli::OutputSubtitleFormat::Srt,
            "ass" => cli::OutputSubtitleFormat::Ass,
            "vtt" => cli::OutputSubtitleFormat::Vtt,
            "sub" => cli::OutputSubtitleFormat::Sub,
            _ => {
                return Err(error::SubXError::CommandExecution(format!(
                    "Unsupported output format: {output_format}. Supported formats: srt, ass, vtt, sub"
                )));
            }
        };

        let args = cli::ConvertArgs {
            input: Some(input_path.into()),
            input_paths: vec![],
            recursive: false,
            format: Some(format),
            output: output_path.map(Into::into),
            keep_original: false,
            encoding: "utf-8".to_string(),
            no_extract: false,
        };
        self.handle_command(cli::Commands::Convert(args)).await
    }

    /// Synchronize subtitle files programmatically.
    ///
    /// # Examples
    ///
    /// ```rust,no_run
    /// use subx_cli::{App, config::TestConfigService};
    /// use std::sync::Arc;
    ///
    /// # async fn example() -> subx_cli::Result<()> {
    /// let config_service = Arc::new(TestConfigService::with_defaults());
    /// let app = App::new(config_service);
    ///
    /// // Synchronize using VAD method
    /// app.sync_files("/path/to/video.mp4", "/path/to/subtitle.srt", "vad").await?;
    /// # Ok(())
    /// # }
    /// ```
    ///
    /// # Arguments
    ///
    /// * `video_path` - Path to video file for audio analysis
    /// * `subtitle_path` - Path to subtitle file to synchronize
    /// * `method` - Synchronization method ("vad", "manual")
    ///
    /// # Errors
    ///
    /// Returns an error if synchronization fails.
    pub async fn sync_files(
        &self,
        video_path: &str,
        subtitle_path: &str,
        method: &str,
    ) -> Result<()> {
        let sync_method = match method.to_lowercase().as_str() {
            "vad" => Some(cli::SyncMethodArg::Vad),
            "manual" => Some(cli::SyncMethodArg::Manual),
            _ => {
                return Err(error::SubXError::CommandExecution(format!(
                    "Unsupported sync method: {method}. Supported methods: vad, manual"
                )));
            }
        };

        let args = cli::SyncArgs {
            positional_paths: Vec::new(),
            video: Some(video_path.into()),
            subtitle: Some(subtitle_path.into()),
            input_paths: vec![],
            recursive: false,
            offset: None,
            method: sync_method,
            window: 30,
            vad_sensitivity: None,
            output: None,
            verbose: false,
            dry_run: false,
            force: false,
            batch: None,
            no_extract: false,
        };
        self.handle_command(cli::Commands::Sync(args)).await
    }

    /// Synchronize subtitle files with manual offset.
    ///
    /// # Examples
    ///
    /// ```rust,no_run
    /// use subx_cli::{App, config::TestConfigService};
    /// use std::sync::Arc;
    ///
    /// # async fn example() -> subx_cli::Result<()> {
    /// let config_service = Arc::new(TestConfigService::with_defaults());
    /// let app = App::new(config_service);
    ///
    /// // Apply +2.5 second offset to subtitles
    /// app.sync_files_with_offset("/path/to/subtitle.srt", 2.5).await?;
    /// # Ok(())
    /// # }
    /// ```
    ///
    /// # Arguments
    ///
    /// * `subtitle_path` - Path to subtitle file to synchronize
    /// * `offset` - Time offset in seconds (positive delays, negative advances)
    ///
    /// # Errors
    ///
    /// Returns an error if synchronization fails.
    pub async fn sync_files_with_offset(&self, subtitle_path: &str, offset: f32) -> Result<()> {
        let args = cli::SyncArgs {
            positional_paths: Vec::new(),
            video: None,
            subtitle: Some(subtitle_path.into()),
            input_paths: vec![],
            recursive: false,
            offset: Some(offset),
            method: None,
            window: 30,
            vad_sensitivity: None,
            output: None,
            verbose: false,
            dry_run: false,
            force: false,
            batch: None,
            no_extract: false,
        };
        self.handle_command(cli::Commands::Sync(args)).await
    }

    /// Get a reference to the configuration service.
    ///
    /// This allows access to the configuration service for testing or
    /// advanced use cases.
    pub fn config_service(&self) -> &std::sync::Arc<dyn config::ConfigService> {
        &self.config_service
    }

    /// Get the current configuration.
    ///
    /// This is a convenience method that retrieves the configuration
    /// from the configured service.
    ///
    /// # Errors
    ///
    /// Returns an error if configuration loading fails.
    pub fn get_config(&self) -> Result<config::Config> {
        self.config_service.get_config()
    }
}

#[cfg(test)]
mod tests {
    use super::*;
    use std::sync::Arc;

    fn is_expected_test_error(e: &error::SubXError) -> bool {
        let msg = format!("{e:?}");
        msg.contains("NotFound")
            || msg.contains("No subtitle files found")
            || msg.contains("No video files found")
            || msg.contains("Config")
            || msg.contains("no such file")
            || msg.contains("cannot find")
            || msg.contains("No input")
            || msg.contains("No files")
            || msg.contains("FileNotFound")
            || msg.contains("IoError")
            || msg.contains("PathNotFound")
            || msg.contains("InvalidInput")
            || msg.contains("CommandExecution")
            || msg.contains("NoInputSpecified")
    }

    #[test]
    fn test_version_is_not_empty() {
        assert!(!VERSION.is_empty());
    }

    #[test]
    fn test_version_matches_cargo_pkg_version() {
        assert_eq!(VERSION, env!("CARGO_PKG_VERSION"));
    }

    #[test]
    fn core_version_matches_declared_requirement() {
        // Inside the workspace, `path` resolution wins outright and the
        // `version = "1.0"` key in the subx-core dependency declaration is
        // never consulted. This is the only local guard against the pinned
        // submodule drifting outside the declared caret requirement.
        assert!(!CORE_VERSION.is_empty());
        assert_eq!(CORE_VERSION.split('.').next(), Some("1"));
    }

    #[test]
    fn test_app_new_stores_config_service() {
        let config_service = Arc::new(TestConfigService::with_defaults());
        let app = App::new(config_service.clone());
        // Verify config_service() returns a valid Arc
        let _ = app.config_service();
    }

    #[test]
    fn test_app_get_config_returns_config() {
        let config_service = Arc::new(TestConfigService::with_defaults());
        let app = App::new(config_service);
        let config = app.get_config().expect("get_config should succeed");
        // Just verify we got a config object with a valid AI provider field
        let _ = config.ai.provider;
    }

    #[test]
    fn test_app_get_config_with_ai_settings() {
        let config_service = Arc::new(TestConfigService::with_ai_settings("openai", "gpt-4.1"));
        let app = App::new(config_service);
        let config = app.get_config().expect("get_config should succeed");
        assert_eq!(config.ai.provider, "openai");
        assert_eq!(config.ai.model, "gpt-4.1");
    }

    #[test]
    fn test_app_config_service_getter() {
        let config_service = Arc::new(TestConfigService::with_defaults());
        let app = App::new(config_service);
        // The returned Arc should be usable (get_config succeeds)
        let svc = app.config_service();
        assert!(svc.get_config().is_ok());
    }

    #[tokio::test]
    async fn test_convert_files_unknown_format_returns_error() {
        let config_service = Arc::new(TestConfigService::with_defaults());
        let app = App::new(config_service);
        let result = app.convert_files("/nonexistent", "xyz_unknown", None).await;
        assert!(result.is_err());
        let err_msg = format!("{:?}", result.unwrap_err());
        assert!(
            err_msg.contains("Unsupported output format"),
            "Error should mention unsupported format, got: {err_msg}"
        );
    }

    #[tokio::test]
    async fn test_convert_files_srt_format_accepted() {
        let config_service = Arc::new(TestConfigService::with_defaults());
        let app = App::new(config_service);
        let result = app.convert_files("/nonexistent_path", "srt", None).await;
        match result {
            Ok(_) => {}
            Err(e) => assert!(
                is_expected_test_error(&e),
                "Unexpected error for srt format: {e:?}"
            ),
        }
    }

    #[tokio::test]
    async fn test_convert_files_ass_format_accepted() {
        let config_service = Arc::new(TestConfigService::with_defaults());
        let app = App::new(config_service);
        let result = app.convert_files("/nonexistent_path", "ass", None).await;
        match result {
            Ok(_) => {}
            Err(e) => assert!(
                is_expected_test_error(&e),
                "Unexpected error for ass format: {e:?}"
            ),
        }
    }

    #[tokio::test]
    async fn test_convert_files_vtt_format_accepted() {
        let config_service = Arc::new(TestConfigService::with_defaults());
        let app = App::new(config_service);
        let result = app.convert_files("/nonexistent_path", "vtt", None).await;
        match result {
            Ok(_) => {}
            Err(e) => assert!(
                is_expected_test_error(&e),
                "Unexpected error for vtt format: {e:?}"
            ),
        }
    }

    #[tokio::test]
    async fn test_convert_files_sub_format_accepted() {
        let config_service = Arc::new(TestConfigService::with_defaults());
        let app = App::new(config_service);
        let result = app.convert_files("/nonexistent_path", "sub", None).await;
        match result {
            Ok(_) => {}
            Err(e) => assert!(
                is_expected_test_error(&e),
                "Unexpected error for sub format: {e:?}"
            ),
        }
    }

    #[tokio::test]
    async fn test_convert_files_format_case_insensitive() {
        let config_service = Arc::new(TestConfigService::with_defaults());
        let app = App::new(config_service);
        // Uppercase format should be treated the same as lowercase
        let result = app.convert_files("/nonexistent_path", "SRT", None).await;
        match result {
            Ok(_) => {}
            Err(e) => assert!(
                is_expected_test_error(&e),
                "Unexpected error for uppercase SRT: {e:?}"
            ),
        }
    }

    #[tokio::test]
    async fn test_sync_files_unknown_method_returns_error() {
        let config_service = Arc::new(TestConfigService::with_defaults());
        let app = App::new(config_service);
        let result = app
            .sync_files("/video.mp4", "/subtitle.srt", "unknown_method")
            .await;
        assert!(result.is_err());
        let err_msg = format!("{:?}", result.unwrap_err());
        assert!(
            err_msg.contains("Unsupported sync method"),
            "Error should mention unsupported method, got: {err_msg}"
        );
    }

    #[tokio::test]
    async fn test_sync_files_vad_method_accepted() {
        let config_service = Arc::new(TestConfigService::with_defaults());
        let app = App::new(config_service);
        let result = app
            .sync_files("/nonexistent_video.mp4", "/nonexistent_sub.srt", "vad")
            .await;
        match result {
            Ok(_) => {}
            Err(e) => assert!(
                is_expected_test_error(&e),
                "Unexpected error for vad method: {e:?}"
            ),
        }
    }

    #[tokio::test]
    async fn test_sync_files_manual_method_accepted() {
        let config_service = Arc::new(TestConfigService::with_defaults());
        let app = App::new(config_service);
        let result = app
            .sync_files("/nonexistent_video.mp4", "/nonexistent_sub.srt", "manual")
            .await;
        match result {
            Ok(_) => {}
            Err(e) => assert!(
                is_expected_test_error(&e),
                "Unexpected error for manual method: {e:?}"
            ),
        }
    }

    #[tokio::test]
    async fn test_sync_files_method_case_insensitive() {
        let config_service = Arc::new(TestConfigService::with_defaults());
        let app = App::new(config_service);
        let result = app
            .sync_files("/nonexistent_video.mp4", "/nonexistent_sub.srt", "VAD")
            .await;
        match result {
            Ok(_) => {}
            Err(e) => assert!(
                is_expected_test_error(&e),
                "Uppercase VAD should not give format error, got: {e:?}"
            ),
        }
    }

    #[tokio::test]
    async fn test_sync_files_with_offset_accepted() {
        let config_service = Arc::new(TestConfigService::with_defaults());
        let app = App::new(config_service);
        let result = app
            .sync_files_with_offset("/nonexistent_sub.srt", 2.5)
            .await;
        match result {
            Ok(_) => {}
            Err(e) => assert!(
                is_expected_test_error(&e),
                "Unexpected error for sync with offset: {e:?}"
            ),
        }
    }

    #[tokio::test]
    async fn test_sync_files_with_negative_offset() {
        let config_service = Arc::new(TestConfigService::with_defaults());
        let app = App::new(config_service);
        let result = app
            .sync_files_with_offset("/nonexistent_sub.srt", -1.5)
            .await;
        match result {
            Ok(_) => {}
            Err(e) => assert!(
                is_expected_test_error(&e),
                "Unexpected error for sync with negative offset: {e:?}"
            ),
        }
    }

    #[tokio::test]
    async fn test_match_files_dry_run() {
        let config_service = Arc::new(TestConfigService::with_ai_settings(
            "test_provider",
            "test_model",
        ));
        let app = App::new(config_service);
        let result = app.match_files("/nonexistent_subx_test_path", true).await;
        match result {
            Ok(_) => {}
            Err(e) => assert!(
                is_expected_test_error(&e),
                "Unexpected error for match dry run: {e:?}"
            ),
        }
    }

    #[test]
    fn test_result_type_alias_ok() {
        let r: Result<i32> = Ok(42);
        assert_eq!(r.unwrap(), 42);
    }

    #[test]
    fn test_result_type_alias_err() {
        let r: Result<i32> = Err(error::SubXError::config("test error"));
        assert!(r.is_err());
    }
}