stratum_apps/monitoring/

snapshot_cache.rs

//! Snapshot cache for monitoring data
//!
//! This module provides a cache layer that decouples monitoring API requests
//! from the business logic locks (e.g., `ChannelManagerData`).
//!
//! ## Problem
//!
//! Without caching, every monitoring request acquires the same lock used by
//! share validation and job distribution. An attacker can spam monitoring
//! endpoints to cause lock contention, degrading mining performance.
//!
//! ## Solution
//!
//! The `SnapshotCache` periodically copies monitoring data from the source
//! (via the monitoring traits) into a cache. API requests read from the cache
//! without acquiring the business logic lock.
//!
//! ```text
//! Business Logic                    Monitoring
//! ──────────────                    ──────────
//!     │                                  │
//!     │ (holds lock for                  │
//!     │  share validation)               │
//!     │                                  │
//!     └──────────────────────────────────┤
//!                                        │
//!                              ┌─────────▼─────────┐
//!                              │  SnapshotCache    │
//!                              │  (RwLock, fast)   │
//!                              └─────────┬─────────┘
//!                                        │
//!                    ┌───────────────────┼───────────────────┐
//!                    │                   │                   │
//!              ┌─────▼─────┐       ┌─────▼─────┐       ┌─────▼─────┐
//!              │ /metrics  │       │ /api/v1/* │       │ /health   │
//!              └───────────┘       └───────────┘       └───────────┘
//! ```

use std::{
    collections::HashSet,
    sync::{Arc, Mutex, RwLock},
    time::{Duration, Instant},
};

use stratum_core::mining_sv2::{
    ERROR_CODE_SUBMIT_SHARES_BAD_EXTRANONCE_SIZE, ERROR_CODE_SUBMIT_SHARES_DIFFICULTY_TOO_LOW,
    ERROR_CODE_SUBMIT_SHARES_DUPLICATE_SHARE, ERROR_CODE_SUBMIT_SHARES_INVALID_CHANNEL_ID,
    ERROR_CODE_SUBMIT_SHARES_INVALID_JOB_ID,
    ERROR_CODE_SUBMIT_SHARES_INVALID_NON_ROLLABLE_VERSION_BIT,
    ERROR_CODE_SUBMIT_SHARES_INVALID_SHARE, ERROR_CODE_SUBMIT_SHARES_STALE_SHARE,
};
use tracing::debug;

use super::{
    client::{Sv2ClientInfo, Sv2ClientsMonitoring, Sv2ClientsSummary},
    prometheus_metrics::PrometheusMetrics,
    server::{ServerInfo, ServerMonitoring, ServerSummary},
    sv1::{Sv1ClientInfo, Sv1ClientsMonitoring, Sv1ClientsSummary},
};

/// All `SubmitSharesError.error_code` values defined by `mining_sv2`.
///
/// Pre-seeding these labels with `0` on every refresh ensures the
/// `sv2_*_shares_rejected_total` GaugeVec emits its series even before
/// the first rejection — so Grafana panels and alerting rules that
/// reference the metric never see "no data".
const SHARE_REJECTION_CODES: &[&str] = &[
    ERROR_CODE_SUBMIT_SHARES_INVALID_CHANNEL_ID,
    ERROR_CODE_SUBMIT_SHARES_INVALID_SHARE,
    ERROR_CODE_SUBMIT_SHARES_STALE_SHARE,
    ERROR_CODE_SUBMIT_SHARES_INVALID_JOB_ID,
    ERROR_CODE_SUBMIT_SHARES_DIFFICULTY_TOO_LOW,
    ERROR_CODE_SUBMIT_SHARES_DUPLICATE_SHARE,
    ERROR_CODE_SUBMIT_SHARES_BAD_EXTRANONCE_SIZE,
    ERROR_CODE_SUBMIT_SHARES_INVALID_NON_ROLLABLE_VERSION_BIT,
];

/// Tracks which label combinations were set on the previous refresh so we can
/// remove only stale series instead of calling `.reset()` (which would create a
/// gap where all label series momentarily disappear).
#[derive(Default)]
struct PreviousPrometheusLabelSets {
    /// Labels for server per-channel GaugeVecs: [channel_id, user_identity]
    server_channel_labels: HashSet<[String; 2]>,
    /// Labels for server per-rejection GaugeVecs: [channel_id, user_identity, error_code]
    server_rejected_share_labels: HashSet<[String; 3]>,
    /// Labels for client per-channel GaugeVecs: [client_id, channel_id, user_identity]
    client_channel_labels: HashSet<[String; 3]>,
    /// Labels for client per-rejection GaugeVecs: [client_id, channel_id, user_identity,
    /// error_code]
    client_rejected_share_labels: HashSet<[String; 4]>,
}

/// Cached snapshot of monitoring data.
///
/// This struct holds a point-in-time copy of all monitoring data,
/// allowing API requests to read without acquiring business logic locks.
#[derive(Debug, Clone, Default)]
pub struct MonitoringSnapshot {
    pub timestamp: Option<Instant>,
    pub server_info: Option<ServerInfo>,
    pub server_summary: Option<ServerSummary>,
    pub sv2_clients: Option<Vec<Sv2ClientInfo>>,
    pub sv2_clients_summary: Option<Sv2ClientsSummary>,
    pub sv1_clients: Option<Vec<Sv1ClientInfo>>,
    pub sv1_clients_summary: Option<Sv1ClientsSummary>,
}

/// A cache that holds monitoring snapshots and refreshes them periodically.
///
/// When `PrometheusMetrics` are attached, the cache also updates Prometheus
/// gauges during each refresh, keeping metric values in lockstep with the
/// snapshot data. This means the `/metrics` handler never needs to compute
/// values — it only gathers and encodes.
pub struct SnapshotCache {
    snapshot: RwLock<MonitoringSnapshot>,
    refresh_interval: Duration,
    server_source: Option<Arc<dyn ServerMonitoring + Send + Sync>>,
    sv2_clients_source: Option<Arc<dyn Sv2ClientsMonitoring + Send + Sync>>,
    sv1_clients_source: Option<Arc<dyn Sv1ClientsMonitoring + Send + Sync>>,
    metrics: Option<PrometheusMetrics>,
    previous_metrics_labels: Mutex<PreviousPrometheusLabelSets>,
}

impl Clone for SnapshotCache {
    fn clone(&self) -> Self {
        // Clone creates a new cache with the same sources and current snapshot.
        // previous_metrics_labels is cloned so the new cache can correctly detect
        // stale label combinations on its first refresh.
        let current_snapshot = self.snapshot.read().unwrap().clone();
        // Recovering from a poisoned mutex is safe here: the inner sets only
        // track which Prometheus label combinations were populated last refresh,
        // used solely to compute stale-label removals. The data has no
        // cross-field invariants, and worst-case drift (a stale label surviving
        // one cycle, or an idempotent remove that we already log at debug) is
        // harmless. Panicking here would crash the monitoring server.
        let previous_metrics_labels = self
            .previous_metrics_labels
            .lock()
            .unwrap_or_else(|e| e.into_inner());
        Self {
            snapshot: RwLock::new(current_snapshot),
            refresh_interval: self.refresh_interval,
            server_source: self.server_source.clone(),
            sv2_clients_source: self.sv2_clients_source.clone(),
            sv1_clients_source: self.sv1_clients_source.clone(),
            metrics: self.metrics.clone(),
            previous_metrics_labels: Mutex::new(PreviousPrometheusLabelSets {
                server_channel_labels: previous_metrics_labels.server_channel_labels.clone(),
                server_rejected_share_labels: previous_metrics_labels
                    .server_rejected_share_labels
                    .clone(),
                client_channel_labels: previous_metrics_labels.client_channel_labels.clone(),
                client_rejected_share_labels: previous_metrics_labels
                    .client_rejected_share_labels
                    .clone(),
            }),
        }
    }
}

impl SnapshotCache {
    /// Create a new snapshot cache with the given refresh interval.
    ///
    /// # Arguments
    ///
    /// * `refresh_interval` - How often to refresh the cache (e.g., 15 seconds)
    /// * `server_source` - Optional server monitoring trait object
    /// * `sv2_clients_source` - Optional Sv2 clients monitoring trait object
    pub fn new(
        refresh_interval: Duration,
        server_source: Option<Arc<dyn ServerMonitoring + Send + Sync>>,
        sv2_clients_source: Option<Arc<dyn Sv2ClientsMonitoring + Send + Sync>>,
    ) -> Self {
        Self {
            snapshot: RwLock::new(MonitoringSnapshot::default()),
            refresh_interval,
            server_source,
            sv2_clients_source,
            sv1_clients_source: None,
            metrics: None,
            previous_metrics_labels: Mutex::new(PreviousPrometheusLabelSets::default()),
        }
    }

    /// Add SV1 monitoring source (for Tproxy)
    pub fn with_sv1_clients_source(
        mut self,
        sv1_source: Arc<dyn Sv1ClientsMonitoring + Send + Sync>,
    ) -> Self {
        self.sv1_clients_source = Some(sv1_source);
        self
    }

    /// Attach (or replace) Prometheus metrics so they are updated during each `refresh()`.
    ///
    /// This is called once in `MonitoringServer::new` and may be called again in
    /// `with_sv1_monitoring` which re-creates the metrics with SV1 gauges enabled.
    pub fn with_metrics(mut self, metrics: PrometheusMetrics) -> Self {
        self.metrics = Some(metrics);
        self
    }

    /// Get the current snapshot.
    ///
    /// This is a fast read that does NOT acquire any business logic locks.
    /// The returned snapshot may be up to `refresh_interval` old.
    pub fn get_snapshot(&self) -> MonitoringSnapshot {
        self.snapshot.read().unwrap().clone()
    }

    /// Refresh the cache by reading from the data sources.
    ///
    /// This method DOES acquire the business logic locks (via the trait methods),
    /// but it's only called periodically by a background task, not on every request.
    ///
    /// When Prometheus metrics are attached, they are updated atomically alongside
    /// the snapshot — eliminating any gap where metrics could be missing or stale
    /// relative to the snapshot data.
    pub fn refresh(&self) {
        let mut new_snapshot = MonitoringSnapshot {
            timestamp: Some(Instant::now()),
            ..Default::default()
        };

        // Collect server data
        if let Some(ref source) = self.server_source {
            new_snapshot.server_info = Some(source.get_server());
            new_snapshot.server_summary = Some(source.get_server_summary());
        }

        // Collect Sv2 clients data
        if let Some(ref source) = self.sv2_clients_source {
            new_snapshot.sv2_clients = Some(source.get_sv2_clients());
            new_snapshot.sv2_clients_summary = Some(source.get_sv2_clients_summary());
        }

        // Collect Sv1 clients data
        if let Some(ref source) = self.sv1_clients_source {
            new_snapshot.sv1_clients = Some(source.get_sv1_clients());
            new_snapshot.sv1_clients_summary = Some(source.get_sv1_clients_summary());
        }

        // Update Prometheus gauges from the new snapshot data
        if let Some(ref metrics) = self.metrics {
            self.update_metrics(metrics, &new_snapshot);
        }

        // Update the cache
        *self.snapshot.write().unwrap() = new_snapshot;
    }

    /// Update all Prometheus gauges from the given snapshot, then remove stale
    /// label combinations that are no longer present.
    fn update_metrics(&self, metrics: &PrometheusMetrics, snapshot: &MonitoringSnapshot) {
        let mut current_server_labels: HashSet<[String; 2]> = HashSet::new();
        let mut current_server_rejected_labels: HashSet<[String; 3]> = HashSet::new();
        let mut current_client_labels: HashSet<[String; 3]> = HashSet::new();
        let mut current_client_rejected_labels: HashSet<[String; 4]> = HashSet::new();

        // Server metrics
        if let Some(ref summary) = snapshot.server_summary {
            if let Some(ref m) = metrics.sv2_server_channels {
                m.with_label_values(&["extended"])
                    .set(summary.extended_channels as f64);
                m.with_label_values(&["standard"])
                    .set(summary.standard_channels as f64);
            }
            if let Some(ref m) = metrics.sv2_server_hashrate_total {
                m.set(summary.total_hashrate as f64);
            }
        }

        if let Some(ref server) = snapshot.server_info {
            for channel in &server.extended_channels {
                let channel_id = channel.channel_id.to_string();
                let user = &channel.user_identity;
                let labels = [channel_id.clone(), user.clone()];

                if let Some(ref m) = metrics.sv2_server_shares_accepted_total {
                    m.with_label_values(&[&channel_id, user])
                        .set(channel.shares_acknowledged as f64);
                }
                if let Some(ref m) = metrics.sv2_server_shares_rejected_total {
                    // Pre-seed spec-defined rejection codes so the metric is always emitted
                    // (avoids GaugeVec lazy-loading hiding the series until first rejection).
                    for &reason in SHARE_REJECTION_CODES {
                        m.with_label_values(&[&channel_id, user, reason]).set(0.0);
                        current_server_rejected_labels.insert([
                            channel_id.clone(),
                            user.clone(),
                            reason.to_string(),
                        ]);
                    }
                    for (error_code, count) in &channel.shares_rejected_by_reason {
                        m.with_label_values(&[&channel_id, user, error_code])
                            .set(*count as f64);
                        current_server_rejected_labels.insert([
                            channel_id.clone(),
                            user.clone(),
                            error_code.clone(),
                        ]);
                    }
                }
                if let (Some(m), Some(hashrate)) = (
                    &metrics.sv2_server_channel_hashrate,
                    channel.nominal_hashrate,
                ) {
                    m.with_label_values(&[&channel_id, user])
                        .set(hashrate as f64);
                }
                current_server_labels.insert(labels);
            }

            for channel in &server.standard_channels {
                let channel_id = channel.channel_id.to_string();
                let user = &channel.user_identity;
                let labels = [channel_id.clone(), user.clone()];

                if let Some(ref m) = metrics.sv2_server_shares_accepted_total {
                    m.with_label_values(&[&channel_id, user])
                        .set(channel.shares_acknowledged as f64);
                }
                if let Some(ref m) = metrics.sv2_server_shares_rejected_total {
                    // Pre-seed spec-defined rejection codes so the metric is always emitted
                    // (avoids GaugeVec lazy-loading hiding the series until first rejection).
                    for &reason in SHARE_REJECTION_CODES {
                        m.with_label_values(&[&channel_id, user, reason]).set(0.0);
                        current_server_rejected_labels.insert([
                            channel_id.clone(),
                            user.clone(),
                            reason.to_string(),
                        ]);
                    }
                    for (error_code, count) in &channel.shares_rejected_by_reason {
                        m.with_label_values(&[&channel_id, user, error_code])
                            .set(*count as f64);
                        current_server_rejected_labels.insert([
                            channel_id.clone(),
                            user.clone(),
                            error_code.clone(),
                        ]);
                    }
                }
                if let (Some(m), Some(hashrate)) = (
                    &metrics.sv2_server_channel_hashrate,
                    channel.nominal_hashrate,
                ) {
                    m.with_label_values(&[&channel_id, user])
                        .set(hashrate as f64);
                }
                current_server_labels.insert(labels);
            }

            if let Some(ref m) = metrics.sv2_server_blocks_found_total {
                let total: u64 = server
                    .extended_channels
                    .iter()
                    .map(|c| c.blocks_found as u64)
                    .chain(
                        server
                            .standard_channels
                            .iter()
                            .map(|c| c.blocks_found as u64),
                    )
                    .sum();
                m.set(total as f64);
            }
        }

        // Sv2 clients metrics
        if let Some(ref summary) = snapshot.sv2_clients_summary {
            if let Some(ref m) = metrics.sv2_clients_total {
                m.set(summary.total_clients as f64);
            }
            if let Some(ref m) = metrics.sv2_client_channels {
                m.with_label_values(&["extended"])
                    .set(summary.extended_channels as f64);
                m.with_label_values(&["standard"])
                    .set(summary.standard_channels as f64);
            }
            if let Some(ref m) = metrics.sv2_client_hashrate_total {
                m.set(summary.total_hashrate as f64);
            }

            let mut client_blocks_total: u64 = 0;

            for client in snapshot.sv2_clients.as_deref().unwrap_or(&[]) {
                let client_id = client.client_id.to_string();

                for channel in &client.extended_channels {
                    let channel_id = channel.channel_id.to_string();
                    let user = &channel.user_identity;
                    let labels = [client_id.clone(), channel_id.clone(), user.clone()];

                    if let Some(ref m) = metrics.sv2_client_shares_accepted_total {
                        m.with_label_values(&[&client_id, &channel_id, user])
                            .set(channel.shares_accepted as f64);
                    }
                    if let Some(ref m) = metrics.sv2_client_shares_rejected_total {
                        // Pre-seed spec-defined rejection codes so the metric is always emitted
                        // (avoids GaugeVec lazy-loading hiding the series until first rejection).
                        for &reason in SHARE_REJECTION_CODES {
                            m.with_label_values(&[&client_id, &channel_id, user, reason])
                                .set(0.0);
                            current_client_rejected_labels.insert([
                                client_id.clone(),
                                channel_id.clone(),
                                user.clone(),
                                reason.to_string(),
                            ]);
                        }
                        for (error_code, count) in &channel.shares_rejected_by_reason {
                            m.with_label_values(&[&client_id, &channel_id, user, error_code])
                                .set(*count as f64);
                            current_client_rejected_labels.insert([
                                client_id.clone(),
                                channel_id.clone(),
                                user.clone(),
                                error_code.clone(),
                            ]);
                        }
                    }
                    if let Some(ref m) = metrics.sv2_client_channel_hashrate {
                        m.with_label_values(&[&client_id, &channel_id, user])
                            .set(channel.nominal_hashrate as f64);
                    }
                    current_client_labels.insert(labels);
                    client_blocks_total += channel.blocks_found as u64;
                }

                for channel in &client.standard_channels {
                    let channel_id = channel.channel_id.to_string();
                    let user = &channel.user_identity;
                    let labels = [client_id.clone(), channel_id.clone(), user.clone()];

                    if let Some(ref m) = metrics.sv2_client_shares_accepted_total {
                        m.with_label_values(&[&client_id, &channel_id, user])
                            .set(channel.shares_accepted as f64);
                    }
                    if let Some(ref m) = metrics.sv2_client_shares_rejected_total {
                        // Pre-seed spec-defined rejection codes so the metric is always emitted
                        // (avoids GaugeVec lazy-loading hiding the series until first rejection).
                        for &reason in SHARE_REJECTION_CODES {
                            m.with_label_values(&[&client_id, &channel_id, user, reason])
                                .set(0.0);
                            current_client_rejected_labels.insert([
                                client_id.clone(),
                                channel_id.clone(),
                                user.clone(),
                                reason.to_string(),
                            ]);
                        }
                        for (error_code, count) in &channel.shares_rejected_by_reason {
                            m.with_label_values(&[&client_id, &channel_id, user, error_code])
                                .set(*count as f64);
                            current_client_rejected_labels.insert([
                                client_id.clone(),
                                channel_id.clone(),
                                user.clone(),
                                error_code.clone(),
                            ]);
                        }
                    }
                    if let Some(ref m) = metrics.sv2_client_channel_hashrate {
                        m.with_label_values(&[&client_id, &channel_id, user])
                            .set(channel.nominal_hashrate as f64);
                    }
                    current_client_labels.insert(labels);
                    client_blocks_total += channel.blocks_found as u64;
                }
            }

            if let Some(ref m) = metrics.sv2_client_blocks_found_total {
                m.set(client_blocks_total as f64);
            }
        }

        // SV1 client metrics
        if let Some(ref summary) = snapshot.sv1_clients_summary {
            if let Some(ref m) = metrics.sv1_clients_total {
                m.set(summary.total_clients as f64);
            }
            if let Some(ref m) = metrics.sv1_hashrate_total {
                m.set(summary.total_hashrate as f64);
            }
        }

        // Remove stale label combinations that are no longer in the snapshot
        let mut previous_metrics_labels = self
            .previous_metrics_labels
            .lock()
            .unwrap_or_else(|e| e.into_inner());

        for stale in previous_metrics_labels
            .server_channel_labels
            .difference(&current_server_labels)
        {
            let label_refs: Vec<&str> = stale.iter().map(|s| s.as_str()).collect();
            if let Some(ref m) = metrics.sv2_server_shares_accepted_total {
                if let Err(e) = m.remove_label_values(&label_refs) {
                    debug!(labels = ?label_refs, error = %e, "failed to remove stale server shares label");
                }
            }
            if let Some(ref m) = metrics.sv2_server_channel_hashrate {
                if let Err(e) = m.remove_label_values(&label_refs) {
                    debug!(labels = ?label_refs, error = %e, "failed to remove stale server hashrate label");
                }
            }
        }

        for stale in previous_metrics_labels
            .server_rejected_share_labels
            .difference(&current_server_rejected_labels)
        {
            let label_refs: Vec<&str> = stale.iter().map(|s| s.as_str()).collect();
            if let Some(ref m) = metrics.sv2_server_shares_rejected_total {
                if let Err(e) = m.remove_label_values(&label_refs) {
                    debug!(labels = ?label_refs, error = %e, "failed to remove stale server rejected shares label");
                }
            }
        }

        for stale in previous_metrics_labels
            .client_channel_labels
            .difference(&current_client_labels)
        {
            let label_refs: Vec<&str> = stale.iter().map(|s| s.as_str()).collect();
            if let Some(ref m) = metrics.sv2_client_shares_accepted_total {
                if let Err(e) = m.remove_label_values(&label_refs) {
                    debug!(labels = ?label_refs, error = %e, "failed to remove stale client shares label");
                }
            }
            if let Some(ref m) = metrics.sv2_client_channel_hashrate {
                if let Err(e) = m.remove_label_values(&label_refs) {
                    debug!(labels = ?label_refs, error = %e, "failed to remove stale client hashrate label");
                }
            }
        }

        for stale in previous_metrics_labels
            .client_rejected_share_labels
            .difference(&current_client_rejected_labels)
        {
            let label_refs: Vec<&str> = stale.iter().map(|s| s.as_str()).collect();
            if let Some(ref m) = metrics.sv2_client_shares_rejected_total {
                if let Err(e) = m.remove_label_values(&label_refs) {
                    debug!(labels = ?label_refs, error = %e, "failed to remove stale client rejected shares label");
                }
            }
        }

        previous_metrics_labels.server_channel_labels = current_server_labels;
        previous_metrics_labels.server_rejected_share_labels = current_server_rejected_labels;
        previous_metrics_labels.client_channel_labels = current_client_labels;
        previous_metrics_labels.client_rejected_share_labels = current_client_rejected_labels;
    }

    /// Get the refresh interval
    pub fn refresh_interval(&self) -> Duration {
        self.refresh_interval
    }
}

#[cfg(test)]
mod tests {
    use super::*;

    struct MockServerMonitoring;
    impl ServerMonitoring for MockServerMonitoring {
        fn get_server(&self) -> ServerInfo {
            ServerInfo {
                extended_channels: vec![],
                standard_channels: vec![],
            }
        }
    }

    struct MockSv2ClientsMonitoring;
    impl Sv2ClientsMonitoring for MockSv2ClientsMonitoring {
        fn get_sv2_clients(&self) -> Vec<Sv2ClientInfo> {
            vec![]
        }
    }

    #[test]
    fn test_snapshot_cache_creation() {
        let cache = SnapshotCache::new(
            Duration::from_secs(5),
            Some(Arc::new(MockServerMonitoring)),
            Some(Arc::new(MockSv2ClientsMonitoring)),
        );

        // Before refresh, snapshot has no timestamp
        let snapshot = cache.get_snapshot();
        assert!(snapshot.timestamp.is_none());
        assert_eq!(cache.refresh_interval(), Duration::from_secs(5));
    }

    #[test]
    fn test_snapshot_refresh() {
        let cache = SnapshotCache::new(
            Duration::from_secs(5),
            Some(Arc::new(MockServerMonitoring)),
            Some(Arc::new(MockSv2ClientsMonitoring)),
        );

        // Before refresh, snapshot has no data
        let snapshot = cache.get_snapshot();
        assert!(snapshot.timestamp.is_none());
        assert!(snapshot.server_info.is_none());

        // After refresh, snapshot has data
        cache.refresh();
        let snapshot = cache.get_snapshot();
        assert!(snapshot.timestamp.is_some());
        assert!(snapshot.server_info.is_some());
        assert!(snapshot.sv2_clients.is_some());
        assert!(snapshot.sv2_clients_summary.is_some());
    }

    /// Mock monitoring that simulates lock contention with business logic.
    ///
    /// This is used to verify that the snapshot cache eliminates lock contention
    /// between monitoring API requests and business logic operations.
    struct ContendedMonitoring {
        lock_hold_duration: Duration,
        monitoring_lock_acquisitions: std::sync::atomic::AtomicU64,
        business_lock: std::sync::Mutex<()>,
    }

    impl ContendedMonitoring {
        fn new(lock_hold_duration: Duration) -> Self {
            Self {
                lock_hold_duration,
                monitoring_lock_acquisitions: std::sync::atomic::AtomicU64::new(0),
                business_lock: std::sync::Mutex::new(()),
            }
        }

        fn simulate_business_logic(&self) {
            let _guard = self.business_lock.lock().unwrap();
            std::thread::sleep(self.lock_hold_duration);
        }

        fn get_monitoring_acquisitions(&self) -> u64 {
            self.monitoring_lock_acquisitions
                .load(std::sync::atomic::Ordering::SeqCst)
        }
    }

    impl Sv2ClientsMonitoring for ContendedMonitoring {
        fn get_sv2_clients(&self) -> Vec<Sv2ClientInfo> {
            let _guard = self.business_lock.lock().unwrap();
            self.monitoring_lock_acquisitions
                .fetch_add(1, std::sync::atomic::Ordering::SeqCst);
            // Minimal sleep to simulate lock acquisition overhead
            std::thread::sleep(Duration::from_micros(10));
            vec![]
        }
    }

    impl ServerMonitoring for ContendedMonitoring {
        fn get_server(&self) -> ServerInfo {
            let _guard = self.business_lock.lock().unwrap();
            self.monitoring_lock_acquisitions
                .fetch_add(1, std::sync::atomic::Ordering::SeqCst);
            // Minimal sleep to simulate lock acquisition overhead
            std::thread::sleep(Duration::from_micros(10));
            ServerInfo {
                extended_channels: vec![],
                standard_channels: vec![],
            }
        }
    }

    /// Verifies that the snapshot cache eliminates lock contention.
    ///
    /// Without the cache, monitoring API requests would acquire the same lock
    /// used by business logic (share validation, job distribution), causing
    /// performance degradation. The cache decouples these operations by
    /// periodically refreshing a snapshot that API requests read from.
    #[test]
    fn test_snapshot_cache_eliminates_lock_contention() {
        let real_monitoring = Arc::new(ContendedMonitoring::new(Duration::from_millis(1)));

        let cache = Arc::new(SnapshotCache::new(
            Duration::from_secs(5),
            None,
            Some(real_monitoring.clone() as Arc<dyn Sv2ClientsMonitoring + Send + Sync>),
        ));

        cache.refresh();

        // Simulate business logic running concurrently
        let business_mon = Arc::clone(&real_monitoring);
        let business_handle = std::thread::spawn(move || {
            let start = std::time::Instant::now();
            let mut ops = 0u64;
            while start.elapsed() < Duration::from_millis(100) {
                business_mon.simulate_business_logic();
                ops += 1;
            }
            ops
        });

        // Simulate rapid API requests via cache (16 threads for higher throughput)
        let mut monitoring_handles = vec![];
        for _ in 0..16 {
            let cache_ref = Arc::clone(&cache);
            monitoring_handles.push(std::thread::spawn(move || {
                let start = std::time::Instant::now();
                let mut requests = 0u64;
                // Tight loop - cache reads are extremely fast
                while start.elapsed() < Duration::from_millis(100) {
                    let _ = cache_ref.get_snapshot();
                    requests += 1;
                }
                requests
            }));
        }

        let _business_ops = business_handle.join().unwrap();
        let total_cache_requests: u64 = monitoring_handles
            .into_iter()
            .map(|h| h.join().unwrap())
            .sum();

        let real_lock_acquisitions = real_monitoring.get_monitoring_acquisitions();

        // Cache should only acquire lock during refresh (1-2 times), not per request
        assert!(
            real_lock_acquisitions <= 2,
            "Cache acquired lock {} times, expected ≤2 (refresh only)",
            real_lock_acquisitions
        );

        // Cache should enable high throughput without acquiring business logic locks
        assert!(
            total_cache_requests > 2,
            "Cache should have processed requests",
        );
    }
}