stm32_hal2/

adc.rs

//! Support for the ADC (Analog to Digital Converter) peripheral.

use core::ptr;

use cfg_if::cfg_if;
use cortex_m::asm;
use paste::paste;

#[cfg(any(feature = "f3", feature = "l4"))]
use crate::dma::DmaInput;
#[cfg(not(any(feature = "f4", feature = "l552", feature = "h5")))]
use crate::dma::{self, ChannelCfg, DmaChannel};
use crate::{
    clocks::Clocks,
    error::{Error, Result},
    pac::{self, RCC},
    util::{bounded_loop, rcc_en_reset},
};

// Address of the ADCinterval voltage reference. This address is found in the User manual. It appears
// to be the same for most STM32s. The voltage this is measured at my vary by variant; eg 3.0 vice 3.3.
// So far, it seems it's always on ADC1, but the channel depends on variant.
// G474 manual implies you can use *any* ADC on ch 18. G491 shows ADC 1 and 3, ch 18 on both.
// L4x2 implies ADC1 only.
cfg_if! {
    if #[cfg(feature = "h7")] {
        // These values are from the H723 User manual
        const VREFINT_ADDR: u32 = 0x1FF1_E860;
        const VREFINT_VOLTAGE: f32 = 3.3;
        const VREFINT_CH: u8 = 0; // todo: Unknown. What is it?
    } else if #[cfg(feature = "g4")] {
        const VREFINT_ADDR: u32 = 0x1FFF_75AA;
        const VREFINT_VOLTAGE: f32 = 3.0;
        const VREFINT_CH: u8 = 18; // G491, G431
    } else {
        const VREFINT_ADDR: u32 = 0x1FFF_75AA;
        const VREFINT_VOLTAGE: f32 = 3.0;
        const VREFINT_CH: u8 = 0; // L412
    }
}

const MAX_ADVREGEN_STARTUP_US: u32 = 10;

#[derive(Clone, Copy, PartialEq)]
pub enum AdcDevice {
    One,
    Two,
    Three,
    #[cfg(feature = "g4")] // todo: Check the specifics.
    Four,
    #[cfg(feature = "g4")]
    Five,
}

cfg_if! {
    if #[cfg(feature = "g4")] {
        /// Select a trigger. Sets CFGR reg, EXTSEL field. See G4 RM, table 163: ADC1/2 - External
        /// triggers for regular channels.
        #[derive(Clone, Copy)]
        #[repr(u8)]
        pub enum Trigger {
            // todo: Injected.
            Tim1Cc1 = 0b00000,
            Tim1Cc2 = 0b00001,
            Tim1Cc3 = 0b00010,
            Tim2Cc2 = 0b00011,
            Tim3Trgo = 0b00100,
            Tim4Cc4 = 0b00101,
            Exti11 = 0b00110,
            Tim8Trgo = 0b00111,
            Tim8Trgo2 = 0b01000,
            Tim1Trgo = 0b01001,
            Tim1Trgo2 = 0b01010,
            Tim2Trgo = 0b01011,
            Tim4Trgo = 0b01100,
            Tim6Trgo = 0b01101,
            Tim15Trgo = 0b01110,
            Tim3Cc4 = 0b01111,
            // todo: Fill in remaining ones.
            Tim7Trgo = 0b11110,
        }
    } else if #[cfg(any(feature = "f3", feature = "f4", feature = "wb"))] {
        /// Select a trigger. Sets CFGR reg, EXTSEL field. See F4 RM, table 69: External trigger for regular channels
        #[derive(Clone, Copy)]
        #[repr(u8)]
        pub enum Trigger {
            Tim1Cc1  = 0b0000,
            Tim1Cc2  = 0b0001,
            Tim1Cc3  = 0b0010,
            Tim2Cc2  = 0b0011,
            Tim2Cc3  = 0b0100,
            Tim2Cc4  = 0b0101,
            Tim2Trgo = 0b0110,
            Tim3Cc1  = 0b0111,
            Tim3Trgo = 0b1000,
            Tim4Cc4  = 0b1001,
            Tim5Cc1  = 0b1010,
            Tim5Cc2  = 0b1011,
            Tim5Cc3  = 0b1100,
            Tim8Cc1  = 0b1101,
            Tim8Trgo = 0b1110,
            Exti11   = 0b1111,
        }
    } else {
        pub enum Trigger {}
    }
}

#[derive(Clone, Copy)]
#[repr(u8)]
/// Select a trigger. Sets CFGR reg, EXTEN field. See G4 RM, table 161:
/// Configuring the trigger polarity for regular external triggers
/// (Also applies for injected)
pub enum TriggerEdge {
    /// Hardware Trigger detection disabled, software trigger detection enabled
    Software = 0b00,
    /// Hardware Trigger with detection on the rising edge
    HardwareRising = 0b01,
    /// Hardware Trigger with detection on the falling edge
    HardwareFalling = 0b10,
    /// Hardware Trigger with detection on both the rising and falling edges
    HardwareBoth = 0b11,
}

#[derive(Copy, Clone)]
#[repr(u8)]
/// ADC interrupts. See L44 RM, section 16.5: ADC interrupts. Set in the IER register, and cleared
/// in the ISR register.
pub enum AdcInterrupt {
    /// ADC ready (ADRDYIE field)
    Ready,
    /// End of regular conversion interrupt enable (EOCIE field)
    EndOfConversion,
    /// End of regular sequence of conversions (EOSIE field)
    EndOfSequence,
    /// End of injected conversion (JEOCIE field)
    EndofConversionInjected,
    /// End of injected sequence of conversions (JEOSIE field)
    EndOfSequenceInjected,
    /// Analog watchdog 1 interrupt (AWD1IE field)
    Watchdog1,
    /// Analog watchdog 2 interrupt (AWD2IE field)
    Watchdog2,
    /// Analog watchdog 3 interrupt (AWD3IE field)
    Watchdog3,
    /// End of sampling flag interrupt enable for regular conversions (EOSMPIE field)
    EndOfSamplingPhase,
    /// Overrun (OVRIE field)
    Overrun,
    /// Injected Context Queue Overflow (JQOVFIE field)
    InjectedOverflow,
}

// todo: Adc sampling time below depends on the STM32 family. Eg the numbers below
// todo are wrong for L4, but the idea is the same.
/// ADC sampling time. Sets ADC_SMPRx register, SMPy field.
///
/// Each channel can be sampled with a different sample time.
/// There is always an overhead of 13 ADC clock cycles.
/// E.g. For Sampletime T_19 the total conversion time (in ADC clock cycles) is
/// 13 + 19 = 32 ADC Clock Cycles
#[derive(Clone, Copy)]
#[repr(u8)]
pub enum SampleTime {
    /// 1.5 ADC clock cycles (2.5 on G4)
    T1 = 0b000,
    /// 2.5 ADC clock cycles (6.5 on G4)
    T2 = 0b001,
    /// 4.5 ADC clock cycles (12.5 on G4)
    T4 = 0b010,
    /// 7.5 ADC clock cycles (24.5 on G4)
    T7 = 0b011,
    /// 19.5 ADC clock cycles (47.5 on G4)
    T19 = 0b100,
    /// 61.5 ADC clock cycles (92.5 on G4)
    T61 = 0b101,
    /// 181.5 ADC clock cycles (247.5 on G4)
    T181 = 0b110,
    /// 601.5 ADC clock cycles (640.5 on G4 and H7)
    T601 = 0b111,
}

impl Default for SampleTime {
    /// T_1 is the reset value; pick a higher one, as the lower values may cause significantly
    /// lower-than-accurate readings.
    fn default() -> Self {
        SampleTime::T181
    }
}

#[derive(Clone, Copy)]
#[repr(u8)]
/// Select single-ended, or differential inputs. Sets bits in the ADC\[x\]_DIFSEL register.
pub enum InputType {
    SingleEnded = 0,
    Differential = 1,
}

#[derive(Clone, Copy)]
#[repr(u8)]
/// ADC operation mode
pub enum OperationMode {
    /// OneShot Mode
    OneShot = 0,
    Continuous = 1,
}

// todo: Check the diff ways of configuring clock; i don't think teh enum below covers all.(?)

#[derive(Clone, Copy, PartialEq)]
#[repr(u8)]
/// ADC Clock mode
/// (L44 RM, Section 16.4.3) The input clock is the same for the three ADCs and can be selected between two different
/// clock sources (see Figure 40: ADC clock scheme):
/// 1. The ADC clock can be a specific clock source. It can be derived from the following
/// clock sources:
/// – The system clock
/// – PLLSAI1 (single ADC implementation)
/// Refer to RCC Section for more information on how to generate ADC dedicated clock.
/// To select this scheme, bits CKMODE\[1:0\] of the ADCx_CCR register must be reset.
/// 2. The ADC clock can be derived from the AHB clock of the ADC bus interface, divided by
/// a programmable factor (1, 2 or 4). In this mode, a programmable divider factor can be
/// selected (/1, 2 or 4 according to bits CKMODE\[1:0\]).
/// To select this scheme, bits CKMODE\[1:0\] of the ADCx_CCR register must be different
/// from “00”.
pub enum ClockMode {
    /// Use Kernel Clock adc_ker_ck_input divided by PRESC. Asynchronous to AHB clock
    Async = 0b00,
    /// Use AHB clock rcc_hclk3 (or just hclk depending on variant).
    /// "For option 2), a prescaling factor of 1 (CKMODE\[1:0\]=01) can be used only if the AHB
    /// prescaler is set to 1 (HPRE\[3:0\] = 0xxx in RCC_CFGR register)."
    SyncDiv1 = 0b01,
    /// Use AHB clock rcc_hclk3 (or just hclk depending on variant) divided by 2
    SyncDiv2 = 0b10,
    /// Use AHB clock rcc_hclk3 (or just hclk depending on variant) divided by 4
    SyncDiv4 = 0b11,
}

/// Sets ADC clock prescaler; ADCx_CCR register, PRESC field.
#[derive(Clone, Copy)]
#[repr(u8)]
pub enum Prescaler {
    D1 = 0b0000,
    D2 = 0b0001,
    D4 = 0b0010,
    D6 = 0b0011,
    D8 = 0b0100,
    D10 = 0b0101,
    D12 = 0b0110,
    D16 = 0b0111,
    D32 = 0b1000,
    D64 = 0b1001,
    D128 = 0b1010,
    D256 = 0b1011,
}

#[cfg(not(feature = "h7"))]
/// ADC data register alignment
#[derive(Clone, Copy)]
#[repr(u8)]
pub enum Align {
    /// Right alignment of output data
    Right = 0,
    /// Left alignment of output data
    Left = 1,
}

#[cfg(not(feature = "h7"))]
impl Default for Align {
    fn default() -> Self {
        Align::Right
    }
}

#[cfg(feature = "h7")]
/// ADC data register alignment
#[derive(Clone, Copy)]
#[repr(u8)]
pub enum Align {
    NoShift = 0,
    L1 = 1,
    L2 = 2,
    L3 = 3,
    L4 = 4,
    L5 = 5,
    L6 = 6,
    L7 = 7,
    L8 = 8,
    L9 = 9,
    L10 = 10,
    L11 = 11,
    L12 = 12,
    L13 = 13,
    L14 = 14,
    L15 = 15,
}

#[cfg(feature = "h7")]
impl Default for Align {
    fn default() -> Self {
        Align::NoShift
    }
}

// todo impl
// /// Ratio options for oversampling.
#[derive(Clone, Copy)]
#[repr(u8)]
pub enum OversamplingRatio {
    Times2 = 0b000,
    Times4 = 0b001,
    Times8 = 0b010,
    Times16 = 0b011,
    Times32 = 0b100,
    Times64 = 0b101,
    Times128 = 0b110,
    Times256 = 0b111,
}

/// Shift options for oversampling.
#[derive(Clone, Copy)]
#[repr(u8)]
pub enum OversamplingShift {
    None = 0b0000,
    Bits1 = 0b0001,
    Bits2 = 0b0010,
    Bits3 = 0b0011,
    Bits4 = 0b0100,
    Bits5 = 0b0101,
    Bits6 = 0b0110,
    Bits7 = 0b0111,
    Bits8 = 0b1000,
}

/// Initial configuration data for the ADC peripheral.
#[derive(Clone)]
pub struct AdcConfig {
    /// ADC clock mode. Defaults to AHB clock rcc_hclk3 (or hclk) divided by 2.
    pub clock_mode: ClockMode,
    /// ADC sample time. See the `SampleTime` enum for details. Higher values
    ///  result in more accurate readings.
    pub sample_time: SampleTime,
    /// ADC clock prescaler. Defaults to no division.
    pub prescaler: Prescaler,
    /// One-shot, or continuous measurements. Defaults to one-shot.
    pub operation_mode: OperationMode,
    // Most families use u8 values for calibration, but H7 uses u16.
    /// Optional calibration data for single-ended measurements.
    pub cal_single_ended: Option<u16>,
    /// Optional calibration data for differential measurements.
    pub cal_differential: Option<u16>,
}

impl Default for AdcConfig {
    fn default() -> Self {
        Self {
            // todo: What should this be? Async seems to be having trouble.
            // clock_mode: ClockMode::Async,
            clock_mode: ClockMode::SyncDiv1,
            sample_time: Default::default(),
            prescaler: Prescaler::D1,
            operation_mode: OperationMode::OneShot,
            cal_single_ended: None,
            cal_differential: None,
        }
    }
}

/// Represents an Analog to Digital Converter (ADC) peripheral.
pub struct Adc<R> {
    /// ADC Register
    pub regs: R,
    // Note: We don't own the common regs; pass them mutably where required, since they may be used
    // by a different ADC.
    device: AdcDevice,
    pub cfg: AdcConfig,
    /// This field is managed internally, and is set up on init.
    pub vdda_calibrated: f32,
}

// todo: Remove this macro, and replace using a `regs` fn like you use in GPIO.
macro_rules! hal {
    ($ADC:ident, $ADC_COMMON:ident, $adc:ident, $rcc_num:tt) => {
        impl Adc<pac::$ADC> {
            paste! {
                /// Initialize an ADC peripheral, including configuration register writes, enabling and resetting
                /// its RCC peripheral clock, and calibrtation.
                ///
                /// If used with ADC1, this also performs VDDA measurement,
                /// used for converting raw output to voltage. If using an ADC other than ADC1, this measurement
                /// is skipped, and 3.3V is assumed. In this case, it's recommended to setup ADC1, read
                /// it's VDDA value (`vdda_calibrated` field), and update the ADC in question with it.
                pub fn [<new_ $adc>](
                    regs: pac::$ADC,
                    device: AdcDevice,
                    cfg: AdcConfig,
                    ahb_freq: u32, // Used for blocking delays in init.
                ) -> Result<Self> {
                    let mut adc = Self {
                        regs,
                        device,
                        cfg,
                        vdda_calibrated: 0.
                    };

                    let rcc = unsafe { &(*RCC::ptr()) };
                    let common_regs = unsafe { &*pac::$ADC_COMMON::ptr() };

                    // Note: We only perform RCC enabling, not resetingg; resetting will
                    // cause ADCs that share RCC en/reset registers (eg ADC1/2 on G4) that
                    // were previously set up to stop working.
                    paste! {
                        cfg_if! {
                            if #[cfg(feature = "f3")] {
                                rcc_en_reset!(ahb1, [<adc $rcc_num>], rcc);
                            } else if #[cfg(feature = "f4")] {
                                rcc_en_reset!(2, [<adc $rcc_num>], rcc);
                            } else if #[cfg(feature = "h7")] {
                                match device {
                                    AdcDevice::One | AdcDevice::Two => {
                                        rcc.ahb1enr().modify(|_, w| w.adc12en().bit(true));
                                    }
                                    AdcDevice::Three => {
                                        rcc.ahb4enr().modify(|_, w| w.adc3en().bit(true));
                                    }
                                }
                            } else if #[cfg(any(feature = "g4"))] {
                                rcc.ahb2enr().modify(|_, w| w.adc12en().bit(true));
                                // rcc_en_reset!(ahb2, [<adc $rcc_num>], rcc);
                            } else {  // ie L4, L5, G0(?)
                                rcc_en_reset!(ahb2, adc, rcc);
                            }
                        }
                    }

                    common_regs.ccr().modify(|_, w| unsafe {
                        #[cfg(not(any(feature = "f3", feature = "l4x5")))] // PAC ommission l4x5?
                        w.presc().bits(adc.cfg.prescaler as u8);
                        return w.ckmode().bits(adc.cfg.clock_mode as u8);
                    });

                    adc.set_align(Align::default());


                    adc.advregen_enable(ahb_freq);

                    adc.calibrate(InputType::SingleEnded, ahb_freq)?;
                    adc.calibrate(InputType::Differential, ahb_freq)?;

                    // Reference Manual: "ADEN bit cannot be set during ADCAL=1
                    // and 4 ADC clock cycle after the ADCAL
                    // bit is cleared by hardware."
                    let adc_per_cpu_cycles = match adc.cfg.clock_mode {
                        ClockMode::Async => 1,
                        ClockMode::SyncDiv1 => 1,
                        ClockMode::SyncDiv2 => 2,
                        ClockMode::SyncDiv4 => 4,
                    };
                    asm::delay(adc_per_cpu_cycles * 4 * 2); // additional x2 is a pad;

                    // "Must be used when ADC clock > 20 MHz
                    // ...The software is allowed to write this bit only when ADSTART=0 and JADSTART=0 (which
                    // ensures that no conversion is ongoing)."
                    // todo: On H7, allow disabling boost, either manually, or by checking the clock speed.
                    #[cfg(all(feature = "h7", not(any(feature = "h743", feature = "h753", feature = "h735"))))]
                    adc.regs.cr().modify(|_, w| unsafe { w.boost().bits(1)});

                    #[cfg(any(feature = "h743", feature = "h753"))]
                    adc.regs.cr().modify(|_, w| w.boost().bit(true));

                    // #[cfg(feature = "h735")]
                    // result.regs.cr().modify(|_, w| w.boost().bits(1));

                    adc.enable()?;

                    // Set up VDDA only after the ADC is otherwise enabled.
                    adc.setup_vdda(ahb_freq)?;

                    // Don't set continuous mode until after configuring VDDA, since it needs
                    // to take a oneshot reading.
                    adc.regs.cfgr().modify(|_, w| w.cont().bit(adc.cfg.operation_mode as u8 != 0));

                    for ch in 1..10 {
                        adc.set_sample_time(ch, adc.cfg.sample_time)?;
                    }
                    // Note: We are getting a hardfault on G431 when setting this for channel 10.
                    for ch in 11..19 {
                        adc.set_sample_time(ch, adc.cfg.sample_time)?;
                    }

                    Ok(adc)
                }
            }

            // /// Get the current ADC effective clock speed, in Mhz.
            // pub fn speed(clocks: &ClockCfg) -> u32 {
            //     0 // todo
            // }

            /// Set the ADC conversion sequence length, between 1 and 16.
            pub fn set_sequence_len(&mut self, len: u8) {
                if len - 1 >= 16 {
                    panic!("ADC sequence length must be in 1..=16")
                }

                self.regs.sqr1().modify(|_, w| unsafe { w.l().bits(len - 1) });
            }

            /// Set the alignment mode.
            pub fn set_align(&self, align: Align) {
                #[cfg(all(feature = "h7", not(feature = "h735")))]
                self.regs.cfgr2().modify(|_, w| unsafe { w.lshift().bits(align as u8)});
                // todo: How to do on H735?

                #[cfg(not(feature = "h7"))]
                self.regs.cfgr().modify(|_, w| w.align().bit(align as u8 != 0));
            }

            /// Enable the ADC.
            /// ADEN=1 enables the ADC. The flag ADRDY will be set once the ADC is ready for
            /// operation.
            pub fn enable(&mut self) -> Result<()> {
                // 1. Clear the ADRDY bit in the ADC_ISR register by writing ‘1’.
                self.regs.isr().modify(|_, w| w.adrdy().bit(true));
                // 2. Set ADEN=1.
                self.regs.cr().modify(|_, w| w.aden().bit(true));  // Enable
                // 3. Wait until ADRDY=1 (ADRDY is set after the ADC startup time). This can be done
                // using the associated interrupt (setting ADRDYIE=1).
                // Wait until ready
                bounded_loop!(self.regs.isr().read().adrdy().bit_is_clear(), Error::RegisterUnchanged);
                // 4. Clear the ADRDY bit in the ADC_ISR register by writing ‘1’ (optional).
                self.regs.isr().modify(|_, w| w.adrdy().bit(true));

                Ok(())
            }

            /// Disable the ADC.
            /// ADDIS=1 disables the ADC. ADEN and ADDIS are then automatically cleared by
            /// hardware as soon as the analog ADC is effectively disabled
            pub fn disable(&mut self) -> Result<()> {
                // 1. Check that both ADSTART=0 and JADSTART=0 to ensure that no conversion is
                // ongoing. If required, stop any regular and injected conversion ongoing by setting
                // ADSTP=1 and JADSTP=1 and then wait until ADSTP=0 and JADSTP=0.
                self.stop_conversions()?;

                // 2. Set ADDIS=1.
                self.regs.cr().modify(|_, w| w.addis().bit(true)); // Disable

                // 3. If required by the application, wait until ADEN=0, until the analog
                // ADC is effectively disabled (ADDIS will automatically be reset once ADEN=0)
                bounded_loop!(self.regs.cr().read().aden().bit_is_set(), Error::RegisterUnchanged);

                Ok(())
            }

            /// If any conversions are in progress, stop them. This is a step listed in the RMs
            /// for disable, and calibration procedures. See L4 RM: 16.4.17.
            /// When the ADSTP bit is set by software, any ongoing regular conversion is aborted with
            /// partial result discarded (ADC_DR register is not updated with the current conversion).
            /// When the JADSTP bit is set by software, any ongoing injected conversion is aborted with
            /// partial result discarded (ADC_JDRy register is not updated with the current conversion).
            /// The scan sequence is also aborted and reset (meaning that relaunching the ADC would
            /// restart a new sequence).
            pub fn stop_conversions(&mut self) -> Result<()> {
                // The software can decide to stop regular conversions ongoing by setting ADSTP=1 and
                // injected conversions ongoing by setting JADSTP=1.
                // Stopping conversions will reset the ongoing ADC operation. Then the ADC can be
                // reconfigured (ex: changing the channel selection or the trigger) ready for a new operation.
                let cr_val = self.regs.cr().read();
                if cr_val.adstart().bit_is_set() || self.regs.cr().read().jadstart().bit_is_set() {
                    self.regs.cr().modify(|_, w| {
                        w.adstp().bit(true);
                        w.jadstp().bit(true)
                    });
                    bounded_loop!(
                        self.regs.cr().read().adstart().bit_is_set() || self.regs.cr().read().jadstart().bit_is_set(),
                        Error::RegisterUnchanged
                    );
                }
                Ok(())
            }

            /// Check if the ADC is enabled.
            pub fn is_enabled(&self) -> bool {
                self.regs.cr().read().aden().bit_is_set()
            }

            /// Check if the ADC voltage regulator is enabled.
            pub fn is_advregen_enabled(&self) -> bool {
                cfg_if! {
                    if #[cfg(feature = "f3")] {
                        self.regs.cr().read().advregen().bits() == 1
                    } else {
                        self.regs.cr().read().advregen().bit_is_set()
                    }
                }
            }

            /// Enable the ADC voltage regulator, and exit deep sleep mode (some MCUs)
            pub fn advregen_enable(&mut self, ahb_freq: u32) {
                cfg_if! {
                    if #[cfg(feature = "f3")] {
                        // `F303 RM, 15.3.6:
                        // 1. Change ADVREGEN\[1:0\] bits from ‘10’ (disabled state, reset state) into ‘00’.
                        // 2. Change ADVREGEN\[1:0\] bits from ‘00’ into ‘01’ (enabled state).
                        self.regs.cr().modify(|_, w| unsafe { w.advregen().bits(0b00)});
                        self.regs.cr().modify(|_, w| unsafe { w.advregen().bits(0b01)});
                    } else {
                        // L443 RM, 16.4.6; G4 RM, section 21.4.6: Deep-power-down mode (DEEPPWD) and ADC voltage
                        // regulator (ADVREGEN)
                        //
                        // "By default, the ADC is in Deep-power-down mode where its supply is internally switched off
                        // to reduce the leakage currents (the reset state of bit DEEPPWD is 1 in the ADC_CR
                        // register).
                        // To start ADC operations, it is first needed to exit Deep-power-down mode by setting bit
                        // DEEPPWD=0.""
                        self.regs.cr().modify(|_, w| {
                            w.deeppwd().clear_bit();   // Exit deep sleep mode.
                            w.advregen().bit(true)   // Enable voltage regulator.

                        });
                    }
                }

                self.wait_advregen_startup(ahb_freq)
            }

            /// Disable power, eg to save power in low power modes. Inferred from RM,
            /// we should run this before entering `STOP` mode, in conjunction with with
            /// disabling the ADC.
            pub fn advregen_disable(&mut self) {
                cfg_if! {
                    if #[cfg(feature = "f3")] {
                        // `F303 RM, 15.3.6:
                        // 1. Change ADVREGEN\[1:0\] bits from ‘01’ (enabled state) into ‘00’.
                        // 2. Change ADVREGEN\[1:0\] bits from ‘00’ into ‘10’ (disabled state)
                        self.regs.cr().modify(|_, w| unsafe { w.advregen().bits(0b00) });
                        self.regs.cr().modify(|_, w| unsafe { w.advregen().bits(0b10) });
                    } else {
                        // L4 RM, 16.4.6: Writing DEEPPWD=1 automatically disables the ADC voltage
                        // regulator and bit ADVREGEN is automatically cleared.
                        // When the internal voltage regulator is disabled (ADVREGEN=0), the internal analog
                        // calibration is kept.
                        // In ADC Deep-power-down mode (DEEPPWD=1), the internal analog calibration is lost and
                        // it is necessary to either relaunch a calibration or re-apply the calibration factor which was
                        // previously saved (
                        self.regs.cr().modify(|_, w| w.deeppwd().bit(true));
                        // todo: We could offer an option to disable advregen without setting deeppwd,
                        // todo, which would keep calibration.
                    }
                }
            }

            /// Wait for the advregen to startup.
            ///
            /// This is based on the MAX_ADVREGEN_STARTUP_US of the device.
            fn wait_advregen_startup(&self, ahb_freq: u32) {
                crate::delay_us(MAX_ADVREGEN_STARTUP_US, ahb_freq)
            }

            /// Calibrate. See L4 RM, 16.5.8, or F404 RM, section 15.3.8.
            /// Stores calibration values, which can be re-inserted later,
            /// eg after entering ADC deep sleep mode, or MCU STANDBY or VBAT.
            pub fn calibrate(&mut self, input_type: InputType, ahb_freq: u32) -> Result<()> {
                // 1. Ensure DEEPPWD=0, ADVREGEN=1 and that ADC voltage regulator startup time has
                // elapsed.
                if !self.is_advregen_enabled() {
                    self.advregen_enable(ahb_freq);
                }

                let was_enabled = self.is_enabled();
                // Calibration can only be initiated when the ADC is disabled (when ADEN=0).
                // 2. Ensure that ADEN=0
                if was_enabled {
                    self.disable()?;
                }

                self.regs.cr().modify(|_, w| w
                    // RM:
                    // The calibration factor to be applied for single-ended input conversions is different from the
                    // factor to be applied for differential input conversions:
                    // • Write ADCALDIF=0 before launching a calibration which will be applied for singleended input conversions.
                    // • Write ADCALDIF=1 before launching a calibration which will be applied for differential
                    // input conversions.
                    // 3. Select the input mode for this calibration by setting ADCALDIF=0 (single-ended input)
                    // or ADCALDIF=1 (differential input).
                    .adcaldif().bit(input_type as u8 != 0)
                    // The calibration is then initiated by software by setting bit ADCAL=1.
                    // 4. Set ADCAL=1.
                    .adcal().bit(true)); // start calibration.

                // ADCAL bit stays at 1 during all the
                // calibration sequence. It is then cleared by hardware as soon the calibration completes. At
                // this time, the associated calibration factor is stored internally in the analog ADC and also in
                // the bits CALFACT_S\[6:0\] or CALFACT_D\[6:0\] of ADC_CALFACT register (depending on
                // single-ended or differential input calibration)
                // 5. Wait until ADCAL=0.
                bounded_loop!(
                    self.regs.cr().read().adcal().bit_is_set(),
                    Error::RegisterUnchanged
                );

                // 6. The calibration factor can be read from ADC_CALFACT register.
                match input_type {
                    InputType::SingleEnded => {
                        let val = self.regs.calfact().read().calfact_s().bits();
                        #[cfg(not(feature = "h7"))]
                        let val = val as u16;
                        #[cfg(feature = "h735")]
                        let val = val as u16;
                        self.cfg.cal_single_ended = Some(val);
                    }
                    InputType::Differential => {
                         let val = self.regs.calfact().read().calfact_d().bits();
                         #[cfg(not(feature = "h7"))]
                         let val = val as u16;
                         #[cfg(feature = "h735")]
                         let val = val as u16;
                         self.cfg.cal_differential = Some(val);
                    }
                }

                if was_enabled {
                    self.enable()?;
                }

                Ok(())
            }

            /// Insert a previously-saved calibration value into the ADC.
            /// Se L4 RM, 16.4.8.
            pub fn inject_calibration(&mut self) -> Result<()> {
                // 1. Ensure ADEN=1 and ADSTART=0 and JADSTART=0 (ADC enabled and no
                // conversion is ongoing).
                if !self.is_enabled() {
                    self.enable()?;
                }
                self.stop_conversions()?;


                // 2. Write CALFACT_S and CALFACT_D with the new calibration factors.
                if let Some(cal) = self.cfg.cal_single_ended {
                    #[cfg(not(feature = "h7"))]
                    let cal = cal as u8;
                    self.regs.calfact().modify(|_, w| unsafe { w.calfact_s().bits(cal.try_into().unwrap()) });
                }
                if let Some(cal) = self.cfg.cal_differential {
                    #[cfg(not(feature = "h7"))]
                    let cal = cal as u8;
                    self.regs.calfact().modify(|_, w| unsafe { w.calfact_d().bits(cal.try_into().unwrap()) });
                }

                // 3. When a conversion is launched, the calibration factor will be injected into the analog
                // ADC only if the internal analog calibration factor differs from the one stored in bits
                // CALFACT_S for single-ended input channel or bits CALFACT_D for differential input
                // channel.
                Ok(())
            }

            /// Select single-ended, or differential conversions for a given channel.
            pub fn set_input_type(&mut self, channel: u8, input_type: InputType) -> Result<()> {
                // L44 RM, 16.4.7:
                // Channels can be configured to be either single-ended input or differential input by writing
                // into bits DIFSEL\[15:1\] in the ADC_DIFSEL register. This configuration must be written while
                // the ADC is disabled (ADEN=0). Note that DIFSEL\[18:16,0\] are fixed to single ended
                // channels and are always read as 0.
                let was_enabled = self.is_enabled();
                if was_enabled {
                    self.disable()?;
                }

                // Note that we don't use the `difsel` PAC accessor here, due to its varying
                // implementations across different PACs.
                // todo: 1 offset? Experiment in firmware.
                let val = self.regs.difsel().read().bits();

                let val_new = match input_type {
                    InputType::SingleEnded => val & !(1 << channel),
                    InputType::Differential => val | (1 << channel),
                };
                self.regs.difsel().write(|w| unsafe { w.bits(val_new)});

                // The commented code below is for some PAC variants taht support a method to
                // choose the diffsel field.

                // let v = input_type as u8 != 0;
                // self.regs.difsel().modify(|_, w| {
                //     match channel {
                //         // todo: Do these need to be offset by 1??
                //         0 => w.difsel_0().bit(v),
                //         1 => w.difsel_1().bit(v),
                //         2 => w.difsel_2().bit(v),
                //         3 => w.difsel_3().bit(v),
                //         4 => w.difsel_4().bit(v),
                //         5 => w.difsel_5().bit(v),
                //         6 => w.difsel_6().bit(v),
                //         7 => w.difsel_7().bit(v),
                //         8 => w.difsel_8().bit(v),
                //         9 => w.difsel_9().bit(v),
                //         10 => w.difsel_10().bit(v),
                //         11 => w.difsel_11().bit(v),
                //         12 => w.difsel_12().bit(v),
                //         13 => w.difsel_13().bit(v),
                //         14 => w.difsel_14().bit(v),
                //         15 => w.difsel_15().bit(v),
                //         16 => w.difsel_16().bit(v),
                //         17 => w.difsel_17().bit(v),
                //         18 => w.difsel_18().bit(v),
                //         _ => panic!(),
                //     }
                // });

                if was_enabled {
                    self.enable()?;
                }
                Ok(())
            }

            /// Select a sequence to sample, by inputting a single channel and position.
            pub fn set_sequence(&mut self, chan: u8, position: u8) {
                match position {
                    1 => self.regs.sqr1().modify(|_, w| unsafe { w.sq1().bits(chan) }),
                    2 => self.regs.sqr1().modify(|_, w| unsafe { w.sq2().bits(chan) }),
                    3 => self.regs.sqr1().modify(|_, w| unsafe { w.sq3().bits(chan) }),
                    4 => self.regs.sqr1().modify(|_, w| unsafe { w.sq4().bits(chan) }),
                    5 => self.regs.sqr2().modify(|_, w| unsafe { w.sq5().bits(chan) }),
                    6 => self.regs.sqr2().modify(|_, w| unsafe { w.sq6().bits(chan) }),
                    7 => self.regs.sqr2().modify(|_, w| unsafe { w.sq7().bits(chan) }),
                    8 => self.regs.sqr2().modify(|_, w| unsafe { w.sq8().bits(chan) }),
                    9 => self.regs.sqr2().modify(|_, w| unsafe { w.sq9().bits(chan) }),
                    10 => self.regs.sqr3().modify(|_, w| unsafe { w.sq10().bits(chan) }),
                    11 => self.regs.sqr3().modify(|_, w| unsafe { w.sq11().bits(chan) }),
                    12 => self.regs.sqr3().modify(|_, w| unsafe { w.sq12().bits(chan) }),
                    13 => self.regs.sqr3().modify(|_, w| unsafe { w.sq13().bits(chan) }),
                    14 => self.regs.sqr3().modify(|_, w| unsafe { w.sq14().bits(chan) }),
                    15 => self.regs.sqr4().modify(|_, w| unsafe { w.sq15().bits(chan) }),
                    16 => self.regs.sqr4().modify(|_, w| unsafe { w.sq16().bits(chan) }),
                    _ => panic!("Sequence out of bounds. Only 16 positions are available, starting at 1."),
                };

                #[cfg(all(feature = "h7", not(feature = "h735")))]
                self.regs.pcsel().modify(|r, w| unsafe { w.pcsel().bits(r.pcsel().bits() | (1 << chan)) });

                // todo: Figure this out, and put back (July 2025/pack 0.16)
                // #[cfg(feature = "h735")]
                // match chan {
                //     0 => self.regs.pcsel().modify(|r, w| w.pcsel0().bit(true)),
                //     1 => self.regs.pcsel().modify(|r, w| w.pcsel1().bit(true)),
                //     2 => self.regs.pcsel().modify(|r, w| w.pcsel2().bit(true)),
                //     3 => self.regs.pcsel().modify(|r, w| w.pcsel3().bit(true)),
                //     4 => self.regs.pcsel().modify(|r, w| w.pcsel4().bit(true)),
                //     5 => self.regs.pcsel().modify(|r, w| w.pcsel5().bit(true)),
                //     6 => self.regs.pcsel().modify(|r, w| w.pcsel6().bit(true)),
                //     7 => self.regs.pcsel().modify(|r, w| w.pcsel7().bit(true)),
                //     8 => self.regs.pcsel().modify(|r, w| w.pcsel8().bit(true)),
                //     9 => self.regs.pcsel().modify(|r, w| w.pcsel9().bit(true)),
                //     10 => self.regs.pcsel().modify(|r, w| w.pcsel10().bit(true)),
                //     11 => self.regs.pcsel().modify(|r, w| w.pcsel11().bit(true)),
                //     12 => self.regs.pcsel().modify(|r, w| w.pcsel12().bit(true)),
                //     13 => self.regs.pcsel().modify(|r, w| w.pcsel13().bit(true)),
                //     14 => self.regs.pcsel().modify(|r, w| w.pcsel14().bit(true)),
                //     15 => self.regs.pcsel().modify(|r, w| w.pcsel15().bit(true)),
                //     16 => self.regs.pcsel().modify(|r, w| w.pcsel16().bit(true)),
                //     17 => self.regs.pcsel().modify(|r, w| w.pcsel17().bit(true)),
                //     18 => self.regs.pcsel().modify(|r, w| w.pcsel18().bit(true)),
                //     19=> self.regs.pcsel().modify(|r, w| w.pcsel19().bit(true)),
                //     _ => ()
                // };
            }

            /// Select the sample time for a given channel.
            pub fn set_sample_time(&mut self, chan: u8, smp: SampleTime) -> Result<()> {
                // Channel is the ADC channel to use.

                // RM: Note: only allowed when ADSTART = 0 and JADSTART = 0.
                self.stop_conversions()?;

                // self.disable();
                // while self.regs.cr().read().adstart().bit_is_set() || self.regs.cr().read().jadstart().bit_is_set() {}

                unsafe {
                    match chan {
                        #[cfg(not(feature = "f3"))]
                        0 => self.regs.smpr1().modify(|_, w| w.smp0().bits(smp as u8)),
                        1 => self.regs.smpr1().modify(|_, w| w.smp1().bits(smp as u8)),
                        2 => self.regs.smpr1().modify(|_, w| w.smp2().bits(smp as u8)),
                        3 => self.regs.smpr1().modify(|_, w| w.smp3().bits(smp as u8)),
                        4 => self.regs.smpr1().modify(|_, w| w.smp4().bits(smp as u8)),
                        5 => self.regs.smpr1().modify(|_, w| w.smp5().bits(smp as u8)),
                        6 => self.regs.smpr1().modify(|_, w| w.smp6().bits(smp as u8)),
                        7 => self.regs.smpr1().modify(|_, w| w.smp7().bits(smp as u8)),
                        8 => self.regs.smpr1().modify(|_, w| w.smp8().bits(smp as u8)),
                        9 => self.regs.smpr1().modify(|_, w| w.smp9().bits(smp as u8)),
                        11 => self.regs.smpr2().modify(|_, w| w.smp10().bits(smp as u8)),
                        12 => self.regs.smpr2().modify(|_, w| w.smp12().bits(smp as u8)),
                        13 => self.regs.smpr2().modify(|_, w| w.smp13().bits(smp as u8)),
                        14 => self.regs.smpr2().modify(|_, w| w.smp14().bits(smp as u8)),
                        15 => self.regs.smpr2().modify(|_, w| w.smp15().bits(smp as u8)),
                        16 => self.regs.smpr2().modify(|_, w| w.smp16().bits(smp as u8)),
                        17 => self.regs.smpr2().modify(|_, w| w.smp17().bits(smp as u8)),
                        18 => self.regs.smpr2().modify(|_, w| w.smp18().bits(smp as u8)),
                        // 19 => self.regs.smpr2().modify(|_, w| w.smp19().bits(smp as u8)),
                        // 20 => self.regs.smpr2().modify(|_, w| w.smp20().bits(smp as u8)),
                        _ => unreachable!(),
                    };
                }

                Ok(())
                // self.enable();
            }


            /// Find and store the internal voltage reference, to improve conversion from reading
            /// to voltage accuracy. See L44 RM, section 16.4.34: "Monitoring the internal voltage reference"
            fn setup_vdda(&mut self, ahb_freq: u32) -> Result<()> {
                let common_regs = unsafe { &*pac::$ADC_COMMON::ptr() };
                // RM: It is possible to monitor the internal voltage reference (VREFINT) to have a reference point for
                // evaluating the ADC VREF+ voltage level.
                // The internal voltage reference is internally connected to the input channel 0 of the ADC1
                // (ADC1_INP0).

                // todo: On H7, you may need to use ADC3 for this...

                // Regardless of which ADC we're on, we take this reading using ADC1.
                self.vdda_calibrated = if self.device != AdcDevice::One {
                    // todo: What if ADC1 is already enabled and configured differently?
                    // todo: Either way, if you're also using ADC1, this will screw things up⋅.

                    // let dp = unsafe { pac::Peripherals::steal() };
                    //
                    // #[cfg(feature = "l5")]
                    // let dp_adc = dp.ADC;
                    // #[cfg(not(feature = "l5"))]
                    // let dp_adc = dp.ADC1;

                    // If we're currently using ADC1 (and this is a different ADC), skip this step for now;
                    // VDDA will be wrong,
                    // and all readings using voltage conversion will be wrong.
                    // todo: Take an ADC1 reading if this is the case, or let the user pass in VDDA from there.
                    // if dp_adc.cr().read().aden().bit_is_set() {
                    //     self.vdda_calibrated = 3.3; // A guess.
                    //     return
                    // }

                    // todo: Get this working.
                    // let mut adc1 = Adc::new_adc1(
                    //     dp_adc,
                    //     AdcDevice::One,
                    //     // We use self cfg, in case ADC1 is on the same common regs as this; we don't
                    //     // want it overwriting prescaler and clock cfg.
                    //     self.cfg.clone(),
                    //     ahb_freq,
                    // );
                    // adc1.disable();

                    // This fn will be called recursively for ADC1, generating the vdda value we need.
                    // adc1.vdda_calibrated
                    3.3
                } else {
                    // "Table 24. Embedded internal voltage reference" states that the sample time needs to be
                    // at a minimum 4 us. With 640.5 ADC cycles we have a minimum of 8 us at 80 MHz, leaving
                    // some headroom.

                    common_regs.ccr().modify(|_, w| w.vrefen().bit(true));
                    // User manual table: "Embedded internal voltage reference" states that it takes a maximum of 12 us
                    // to stabilize the internal voltage reference, we wait a little more.

                    // todo: Not sure what to set this delay to and how to change it based on variant, so picking
                    // todo something conservative.
                    crate::delay_us(100, ahb_freq);

                    // This sample time is overkill.
                    // Note that you will need to reset the sample time if you use this channel on this
                    // ADC for something other than reading vref later.
                    self.set_sample_time(VREFINT_CH, SampleTime::T601)?;
                    let reading = self.read(VREFINT_CH)?;
                    self.stop_conversions()?;

                    common_regs.ccr().modify(|_, w| w.vrefen().clear_bit());

                    // The VDDA power supply voltage applied to the microcontroller may be subject to variation or
                    // not precisely known. The embedded internal voltage reference (VREFINT) and its calibration
                    // data acquired by the ADC during the manufacturing process at VDDA = 3.0 V can be used to
                    // evaluate the actual VDDA voltage level.
                    // The following formula gives the actual VDDA voltage supplying the device:
                    // VDDA = 3.0 V x VREFINT_CAL / VREFINT_DATA
                    // where:
                    // • VREFINT_CAL is the VREFINT calibration value
                    // • VREFINT_DATA is the actual VREFINT output value converted by ADC

                    // todo: This address may be different on different MCUs, even within the same family.
                    // Although, it seems relatively consistent. Check User Manuals.
                    let vrefint_cal: u16 = unsafe { ptr::read_volatile(&*(VREFINT_ADDR as *const _)) };
                    VREFINT_VOLTAGE * vrefint_cal as f32 / reading as f32
                };

                Ok(())
            }

            /// Convert a raw measurement into a voltage in Volts, using the calibrated VDDA.
            /// See RM0394, section 16.4.34
            pub fn reading_to_voltage(&self, reading: u16) -> f32 {
                // RM:
                // Converting a supply-relative ADC measurement to an absolute voltage value
                // The ADC is designed to deliver a digital value corresponding to the ratio between the analog
                // power supply and the voltage applied on the converted channel. For most application use
                // cases, it is necessary to convert this ratio into a voltage independent of VDDA. For
                // applications where VDDA is known and ADC converted values are right-aligned you can use
                // the following formula to get this absolute value:

                // V_CHANNELx = V_DDA / FULL_SCALE x ADCx_DATA

                // Where:
                // • VREFINT_CAL is the VREFINT calibration value
                // • ADC_DATA is the value measured by the ADC on channel x (right-aligned)
                // • VREFINT_DATA is the actual VREFINT output value converted by the ADC
                // • FULL_SCALE is the maximum digital value of the ADC output. For example with 12-bit
                // resolution, it will be 212 − 1 = 4095 or with 8-bit resolution, 28 − 1 = 255
                // todo: FULL_SCALE will be different for 16-bit. And differential?

                self.vdda_calibrated / 4_096. * reading as f32
            }

            /// Start a conversion: Either a single measurement, or continuous conversions.
            /// Blocks until the conversion is complete.
            /// See L4 RM 16.4.15 for details.
            pub fn start_conversion(&mut self, sequence: &[u8]) -> Result<()> {
                // todo: You should call this elsewhere, once, to prevent unneded reg writes.
                for (i, channel) in sequence.iter().enumerate() {
                    self.set_sequence(*channel, i as u8 + 1); // + 1, since sequences start at 1.
                }

                // L4 RM: In Single conversion mode, the ADC performs once all the conversions of the channels.
                // This mode is started with the CONT bit at 0 by either:
                // • Setting the ADSTART bit in the ADC_CR register (for a regular channel)
                // • Setting the JADSTART bit in the ADC_CR register (for an injected channel)
                // • External hardware trigger event (for a regular or injected channel)
                // (Here, we assume a regular channel)
                self.regs.cr().modify(|_, w| w.adstart().bit(true));  // Start

                // After the regular sequence is complete, after each conversion is complete,
                // the EOC (end of regular conversion) flag is set.
                // After the regular sequence is complete: The EOS (end of regular sequence) flag is set.
                // wait until complete.
                bounded_loop!(
                    self.regs.isr().read().eos().bit_is_clear(),
                    Error::RegisterUnchanged
                );

                Ok(())
            }

            #[cfg(feature = "h7")]
            /// Read data from a conversion. In OneShot mode, this will generally be run right
            /// after `start_conversion`.
            pub fn read_result(&mut self, ch: u8) -> u16 {
                #[cfg(not(feature = "h735"))]
                self.regs.pcsel().modify(|r, w| unsafe { w.pcsel().bits(r.pcsel().bits() & !(1 << ch)) });

                // todo: Figure this out, and put back (July 2025/pack 0.16)
                // #[cfg(feature = "h735")]
                // match ch {
                //     0 => self.regs.pcsel().modify(|r, w| w.pcsel0().bit(true)),
                //     1 => self.regs.pcsel().modify(|r, w| w.pcsel1().bit(true)),
                //     2 => self.regs.pcsel().modify(|r, w| w.pcsel2().bit(true)),
                //     3 => self.regs.pcsel().modify(|r, w| w.pcsel3().bit(true)),
                //     4 => self.regs.pcsel().modify(|r, w| w.pcsel4().bit(true)),
                //     5 => self.regs.pcsel().modify(|r, w| w.pcsel5().bit(true)),
                //     6 => self.regs.pcsel().modify(|r, w| w.pcsel6().bit(true)),
                //     7 => self.regs.pcsel().modify(|r, w| w.pcsel7().bit(true)),
                //     8 => self.regs.pcsel().modify(|r, w| w.pcsel8().bit(true)),
                //     9 => self.regs.pcsel().modify(|r, w| w.pcsel9().bit(true)),
                //     10 => self.regs.pcsel().modify(|r, w| w.pcsel10().bit(true)),
                //     11 => self.regs.pcsel().modify(|r, w| w.pcsel11().bit(true)),
                //     12 => self.regs.pcsel().modify(|r, w| w.pcsel12().bit(true)),
                //     13 => self.regs.pcsel().modify(|r, w| w.pcsel13().bit(true)),
                //     14 => self.regs.pcsel().modify(|r, w| w.pcsel14().bit(true)),
                //     15 => self.regs.pcsel().modify(|r, w| w.pcsel15().bit(true)),
                //     16 => self.regs.pcsel().modify(|r, w| w.pcsel16().bit(true)),
                //     17 => self.regs.pcsel().modify(|r, w| w.pcsel17().bit(true)),
                //     18 => self.regs.pcsel().modify(|r, w| w.pcsel18().bit(true)),
                //     19=> self.regs.pcsel().modify(|r, w| w.pcsel19().bit(true)),
                //     _ => ()
                // }

                return self.regs.dr().read().bits() as u16;
                return self.regs.dr().read().rdata().bits() as u16;
            }

            #[cfg(not(feature = "h7"))]
            /// Read data from a conversion. In OneShot mode, this will generally be run right
            /// after `start_conversion`.
            pub fn read_result(&mut self) -> u16 {
                #[cfg(feature = "l4")]
                return self.regs.dr().read().bits() as u16;
                #[cfg(not(feature = "l4"))]
                return self.regs.dr().read().rdata().bits() as u16;
            }

            /// Take a single reading; return a raw integer value.
            pub fn read(&mut self, channel: u8) -> Result<u16> {
                self.start_conversion(&[channel])?;
                #[cfg(feature = "h7")]
                return Ok(self.read_result(channel));
                #[cfg(not(feature = "h7"))]
                return Ok(self.read_result());
            }

            /// Take a single reading; return a voltage.
            pub fn read_voltage(&mut self, channel: u8) -> Result<f32> {
                let reading = self.read(channel)?;
                Ok(self.reading_to_voltage(reading))
            }

            /// Select and activate a trigger. See G4 RM, section 21.4.18:
            /// Conversion on external trigger and trigger polarit
            pub fn set_trigger(&mut self, trigger: Trigger, edge: TriggerEdge) {
                self.regs.cfgr().modify(|_, w| unsafe {
                    w.exten().bits(edge as u8);
                    w.extsel().bits(trigger as u8)
                });
            }

            #[cfg(not(any(feature = "f4", feature = "l552", feature = "h5")))]
            /// Take a reading, using DMA. Sets conversion sequence; no need to set it directly.
            /// Note that the `channel` argument is unused on F3 and L4, since it is hard-coded,
            /// and can't be configured using the DMAMUX peripheral. (`dma::mux()` fn).
            pub unsafe fn read_dma(
                &mut self, buf: &mut [u16],
                adc_channels: &[u8],
                dma_channel: DmaChannel,
                channel_cfg: ChannelCfg,
                dma_periph: dma::DmaPeriph,
            ) -> Result<()> {
                let (ptr, len) = (buf.as_mut_ptr(), buf.len());
                // The software is allowed to write (dmaen and dmacfg) only when ADSTART=0 and JADSTART=0 (which
                // ensures that no conversion is ongoing)
                self.stop_conversions()?;

                #[cfg(not(feature = "h7"))]
                self.regs.cfgr().modify(|_, w| {
                    w.dmacfg().bit(channel_cfg.circular == dma::Circular::Enabled);
                    w.dmaen().bit(true)
                });

                #[cfg(all(feature = "h7", not(feature = "h735")))]
                self.regs.cfgr().modify(|_, w| {
                    // Note: To use non-DMA after this has been set, need to configure manually.
                    // ie set back to 0b00.
                    w.dmngt().bits(if channel_cfg.circular == dma::Circular::Enabled { 0b11 } else { 0b01 })
                });

                // todo: How to do in H735? Pac 0.16 change? Jully 2025.

                // L44 RM, Table 41. "DMA1 requests for each channel
                // todo: DMA2 support.
                #[cfg(any(feature = "f3", feature = "l4"))]
                let dma_channel = match self.device {
                    AdcDevice::One => DmaInput::Adc1.dma1_channel(),
                    AdcDevice::Two => DmaInput::Adc2.dma1_channel(),
                    _ => panic!("DMA on ADC beyond 2 is not supported. If it is for your MCU, please submit an issue \
                or PR on Github.")
                };

                #[cfg(feature = "l4")]
                match dma_periph {
                    dma::DmaPeriph::Dma1 => {
                        let mut regs = unsafe { &(*pac::DMA1::ptr()) };
                        match self.device {
                            AdcDevice::One => dma::channel_select(&mut regs, DmaInput::Adc1),
                            AdcDevice::Two => dma::channel_select(&mut regs, DmaInput::Adc2),
                            _ => unimplemented!(),
                        }
                    }
                    dma::DmaPeriph::Dma2 => {
                        let mut regs = unsafe { &(*pac::DMA2::ptr()) };
                        match self.device {
                            AdcDevice::One => dma::channel_select(&mut regs, DmaInput::Adc1),
                            AdcDevice::Two => dma::channel_select(&mut regs, DmaInput::Adc2),
                            _ => unimplemented!(),
                        }
                    }
                }

                let mut seq_len = 0;
                for (i, ch) in adc_channels.iter().enumerate() {
                    self.set_sequence(*ch, i as u8 + 1);
                    seq_len += 1;
                }
                self.set_sequence_len(seq_len);

                self.regs.cr().modify(|_, w| w.adstart().bit(true));  // Start

                // Since converted channel values are stored into a unique data register, it is useful to use
                // DMA for conversion of more than one channel. This avoids the loss of the data already
                // stored in the ADC_DR register.
                // When the DMA mode is enabled (DMAEN bit set to 1 in the ADC_CFGR register in single
                // ADC mode or MDMA different from 0b00 in dual ADC mode), a DMA request is generated
                // after each conversion of a channel. This allows the transfer of the converted data from the
                // ADC_DR register to the destination location selected by the software.
                // Despite this, if an overrun occurs (OVR=1) because the DMA could not serve the DMA
                // transfer request in time, the ADC stops generating DMA requests and the data
                // corresponding to the new conversion is not transferred by the DMA. Which means that all
                // the data transferred to the RAM can be considered as valid.
                // Depending on the configuration of OVRMOD bit, the data is either preserved or overwritten
                // (refer to Section : ADC overrun (OVR, OVRMOD)).
                // The DMA transfer requests are blocked until the software clears the OVR bit.
                // Two different DMA modes are proposed depending on the application use and are
                // configured with bit DMACFG of the ADC_CFGR register in single ADC mode, or with bit
                // DMACFG of the ADC_CCR register in dual ADC mode:
                // • DMA one shot mode (DMACFG=0).
                // This mode is suitable when the DMA is programmed to transfer a fixed number of data.
                // • DMA circular mode (DMACFG=1)
                // This mode is suitable when programming the DMA in circular mode.


                // In [DMA one shot mode], the ADC generates a DMA transfer request each time a new conversion data
                // is available and stops generating DMA requests once the DMA has reached the last DMA
                // transfer (when DMA_EOT interrupt occurs - refer to DMA paragraph) even if a conversion
                // has been started again.
                // When the DMA transfer is complete (all the transfers configured in the DMA controller have
                // been done):
                // • The content of the ADC data register is frozen.
                // • Any ongoing conversion is aborted with partial result discarded.
                // • No new DMA request is issued to the DMA controller. This avoids generating an
                // overrun error if there are still conversions which are started.
                // • Scan sequence is stopped and reset.
                // • The DMA is stopped.

                let num_data = len as u32;

                match dma_periph {
                    dma::DmaPeriph::Dma1 => {
                        let mut regs = unsafe { &(*pac::DMA1::ptr()) };
                        dma::cfg_channel(
                            &mut regs,
                            dma_channel,
                            self.regs.dr().as_ptr() as u32,
                            ptr as u32,
                            num_data,
                            dma::Direction::ReadFromPeriph,
                            dma::DataSize::S16,
                            dma::DataSize::S16,
                            channel_cfg,
                        )
                    }
                    #[cfg(dma2)]
                    dma::DmaPeriph::Dma2 => {
                        let mut regs = unsafe { &(*pac::DMA2::ptr()) };
                        dma::cfg_channel(
                            &mut regs,
                            dma_channel,
                            self.regs.dr().as_ptr() as u32,
                            ptr as u32,
                            num_data,
                            dma::Direction::ReadFromPeriph,
                            dma::DataSize::S16,
                            dma::DataSize::S16,
                            channel_cfg,
                        )
                    }
                }
            }

            /// Enable a specific type of ADC interrupt.
            pub fn enable_interrupt(&mut self, interrupt: AdcInterrupt) {
                self.regs.ier().modify(|_, w| match interrupt {
                    AdcInterrupt::Ready => w.adrdyie().bit(true),
                    AdcInterrupt::EndOfConversion => w.eocie().bit(true),
                    AdcInterrupt::EndOfSequence => w.eosie().bit(true),
                    AdcInterrupt::EndofConversionInjected => w.jeocie().bit(true),
                    AdcInterrupt::EndOfSequenceInjected => w.jeosie().bit(true),
                    AdcInterrupt::Watchdog1 => w.awd1ie().bit(true),
                    AdcInterrupt::Watchdog2 => w.awd2ie().bit(true),
                    AdcInterrupt::Watchdog3 => w.awd3ie().bit(true),
                    AdcInterrupt::EndOfSamplingPhase => w.eosmpie().bit(true),
                    AdcInterrupt::Overrun => w.ovrie().bit(true),
                    AdcInterrupt::InjectedOverflow => w.jqovfie().bit(true),
                });
            }

            /// Clear an interrupt flag of the specified type. Consider running this in the
            /// corresponding ISR.
            pub fn clear_interrupt(&mut self, interrupt: AdcInterrupt) {
                self.regs.isr().write(|w| match interrupt {
                    AdcInterrupt::Ready => w.adrdy().bit(true),
                    AdcInterrupt::EndOfConversion => w.eoc().bit(true),
                    AdcInterrupt::EndOfSequence => w.eos().bit(true),
                    AdcInterrupt::EndofConversionInjected => w.jeoc().bit(true),
                    AdcInterrupt::EndOfSequenceInjected => w.jeos().bit(true),
                    AdcInterrupt::Watchdog1 => w.awd1().bit(true),
                    AdcInterrupt::Watchdog2 => w.awd2().bit(true),
                    AdcInterrupt::Watchdog3 => w.awd3().bit(true),
                    AdcInterrupt::EndOfSamplingPhase => w.eosmp().bit(true),
                    AdcInterrupt::Overrun => w.ovr().bit(true),
                    AdcInterrupt::InjectedOverflow => w.jqovf().bit(true),
                });
                // match interrupt {
                //     AdcInterrupt::Ready => self.regs.icr().write(|_w| w.adrdy().bit(true)),
                //     AdcInterrupt::EndOfConversion => self.regs.icr().write(|w| w.eoc().bit(true)),
                //     AdcInterrupt::EndOfSequence => self.regs.icr().write(|_w| w.eos().bit(true)),
                //     AdcInterrupt::EndofConversionInjected => self.regs.icr().write(|_w| w.jeoc().bit(true)),
                //     AdcInterrupt::EndOfSequenceInjected => self.regs.icr().write(|_w| w.jeos().bit(true)),
                //     AdcInterrupt::Watchdog1 => self.regs.icr().write(|_w| w.awd1().bit(true)),
                //     AdcInterrupt::Watchdog2 => self.regs.icr().write(|_w| w.awd2().bit(true)),
                //     AdcInterrupt::Watchdog3 => self.regs.icr().write(|_w| w.awd3().bit(true)),
                //     AdcInterrupt::EndOfSamplingPhase => self.regs.icr().write(|_w| w.eosmp().bit(true)),
                //     AdcInterrupt::Overrun => self.regs.icr().write(|_w| w.ovr().bit(true)),
                //     AdcInterrupt::InjectedOverflow => self.regs.icr().write(|_w| w.jqovf().bit(true)),
                // }
            }


        /// Print the (raw) contents of the status register.
    pub fn read_status(&self) -> u32 {
        unsafe { self.regs.isr().read().bits() }
    }
        }
    }
}

#[cfg(any(feature = "f301", feature = "f302", feature = "f303",))]
hal!(ADC1, ADC1_2, adc1, 12);

#[cfg(any(feature = "f302", feature = "f303",))]
hal!(ADC2, ADC1_2, adc2, 12);

#[cfg(any(feature = "f303"))]
hal!(ADC3, ADC3_4, adc3, 34);

#[cfg(any(feature = "f303"))]
hal!(ADC4, ADC3_4, adc4, 34);

#[cfg(any(feature = "l4", feature = "l5"))]
hal!(ADC1, ADC_COMMON, adc1, _);

#[cfg(any(feature = "wb"))]
hal!(ADC1, ADC_COMMON, adc1, _);

#[cfg(any(
    feature = "l4x1",
    feature = "l4x2",
    feature = "l412",
    feature = "l4x5",
    feature = "l4x6",
))]
hal!(ADC2, ADC_COMMON, adc2, _);

#[cfg(any(feature = "l4x5", feature = "l4x6",))]
hal!(ADC3, ADC_COMMON, adc3, _);

// todo Implement ADC3 on H7. The issue is the enable / reset being on ahb4.
cfg_if! {
    if #[cfg(feature = "h7")] {
        hal!(ADC1, ADC12_COMMON, adc1, 12);
        hal!(ADC2, ADC12_COMMON, adc2, 12);
        hal!(ADC3, ADC3_COMMON, adc3, 3);
    }
}

cfg_if! {
    if #[cfg(feature = "g4")] {
        hal!(ADC1, ADC12_COMMON, adc1, 12);
        hal!(ADC2, ADC12_COMMON, adc2, 12);
    }
}

#[cfg(all(feature = "g4", not(any(feature = "g431", feature = "g441"))))]
hal!(ADC3, ADC345_COMMON, adc3, 345);

cfg_if! {
    if #[cfg(any(feature = "g473", feature = "g474", feature = "g483", feature = "g484"))] {
        hal!(ADC4, ADC345_COMMON, adc4, 345);
        hal!(ADC5, ADC345_COMMON, adc5, 345);
    }
}

// todo F4 as (depending on variant?) ADC 1, 2, 3