stm32_hal2/

dma.rs

//! Support for the Direct Memory Access (DMA) peripheral. This module handles initialization, and transfer
//! configuration for DMA. The `dma::cfg_channel` method is called by modules that use DMA.

use core::{
    ops::Deref,
    sync::atomic::{self, Ordering},
};

use cfg_if::cfg_if;

use crate::{
    error::{Error, Result},
    pac::RCC,
    util::bounded_loop,
};

cfg_if! {
    if #[cfg(any(
        feature = "f3x4",
        feature = "f301",
        all(feature = "g0", not(any(feature = "g0b0", feature = "g0b1", feature = "g0c1")))
    ))] {
        use crate::{pac::{dma1, DMA1}, util::rcc_en_reset};
    } else if #[cfg(feature = "c0")] { // pac bug?
        use crate::{pac::{dma as dma1, DMA as DMA1}, util::rcc_en_reset};
    } else {
        use crate::{pac::{dma1, dma2, DMA1, DMA2}, util::rcc_en_reset};
    }
}
// #[cfg(any(feature = "g0", feature = "wb", feature = "f3"))]
// F4 family does not have a multipexer infront of the DMA.
#[cfg(any(feature = "g0", feature = "g4", feature = "wl"))]
use crate::pac::DMAMUX;
// todo: DMAMUX2 support (Not sure if WB has it, but H7 has both).
#[cfg(any(feature = "l5", feature = "wb", feature = "h7"))]
use crate::pac::DMAMUX1 as DMAMUX;
#[cfg(feature = "h7")]
use crate::pac::DMAMUX2;

// todo: Several sections of this are only correct for DMA1.

/// Errors that can occur when performing DMA.
#[non_exhaustive]
#[derive(Debug, Clone, Copy, Eq, PartialEq, defmt::Format)]
pub enum DmaError {
    TransferError,
    #[cfg(any(feature = "h7", feature = "f4"))]
    FifoError,
    #[cfg(any(feature = "h7", feature = "f4"))]
    DirectModeError,
}

#[derive(Clone, Copy)]
pub enum DmaPeriph {
    Dma1,
    #[cfg(dma2)]
    Dma2,
}

#[derive(Copy, Clone)]
#[repr(usize)]
#[cfg(not(any(feature = "h7", feature = "wl", feature = "wb", feature = "g0")))]
/// A list of DMA input sources. The integer values represent their DMAMUX register value, on
/// MCUs that use this. G4 RM, Table 91: DMAMUX: Assignment of multiplexer inputs to resources.
pub enum DmaInput {
    // This (on G4) goes up to 115. For now, just implement things we're likely
    // to use in this HAL. Make sure this is compatible beyond G4.
    Adc1 = 5,
    Dac1Ch1 = 6,
    Dac1Ch2 = 7,
    Tim6Up = 8,
    Tim7Up = 9,
    Spi1Rx = 10,
    Spi1Tx = 11,
    Spi2Rx = 12,
    Spi2Tx = 13,
    Spi3Rx = 14,
    Spi3Tx = 15,
    I2c1Rx = 16,
    I2c1Tx = 17,
    I2c2Rx = 18,
    I2c2Tx = 19,
    I2c3Rx = 20,
    I2c3Tx = 21,
    I2c4Rx = 22,
    I2c4Tx = 23,
    Usart1Rx = 24,
    Usart1Tx = 25,
    Usart2Rx = 26,
    Usart2Tx = 27,
    Usart3Rx = 28,
    Usart3Tx = 29,
    Uart4Rx = 30,
    Uart4Tx = 31,
    Uart5Rx = 32,
    Uart5Tx = 33,
    Lpuart1Rx = 34,
    Lpuart1Tx = 35,
    Adc2 = 36,
    Adc3 = 37,
    Adc4 = 38,
    Adc5 = 39,
    Quadspi = 40,
    Dac2Ch1 = 41,
    Tim1Ch1 = 42,
    Tim1Ch2 = 43,
    Tim1Ch3 = 44,
    Tim1Ch4 = 45,
    TimUp = 46,
    Tim1Trig = 47,
    Tim1Com = 48,
    Tim8Ch1 = 49,
    Tim8Ch2 = 50,
    Tim8Ch3 = 51,
    Tim8Ch4 = 52,
    Tim8Up = 53,
    Tim8Trig = 54,
    Tim8Com = 55,
    Tim2Ch1 = 56,
    Tim2Ch2 = 57,
    Tim2Ch3 = 58,
    Tim2Ch4 = 59,
    Tim2Up = 60,
    Tim3Ch1 = 61,
    Tim3Ch2 = 62,
    Tim3Ch3 = 63,
    Tim3Ch4 = 64,
    Tim3Up = 65,
    Tim3Trig = 66,
    Tim4Ch1 = 67,
    Tim4Ch2 = 68,
    Tim4Ch3 = 69,
    Tim4Ch4 = 70,
    Tim4Up = 71,
    Sai1A = 108,
    Sai1B = 109,
    // todo: These SAI2 values are bogus; can't find on G4 DMA mux.
    Sai2A = 203,
    Sai2B = 204,
    // todo: Can't find DFSDM periph on G4 rm: These assigned values are bogus.
    Dfsdm1F0 = 200,
    Dfsdm1F1 = 201,
    Dfsdm1F2 = 205,
    Dfsdm1F3 = 206,
}

#[derive(Copy, Clone)]
#[repr(usize)]
#[cfg(feature = "g0")]
/// G0x0 RM, 10.3.2: DMAMUX mapping
/// G0x1 RM, 11.3.2: DMAMUX mapping
pub enum DmaInput {
    Adc = 5,
    AesIn = 6,
    AesOut = 7,
    Dac1Ch1 = 8,
    Dac1Ch2 = 9,
    I2c1Rx = 10,
    I2c1Tx = 11,
    I2c2Rx = 12,
    I2c2Tx = 13,
    Lpuart1Rx = 14,
    Lpuart1Tx = 15,
    Spi1Rx = 16,
    Spi1Tx = 17,
    Spi2Rx = 18,
    Spi2Tx = 19,
    Tim1Ch1 = 20,
    Tim1Ch2 = 21,
    Tim1Ch3 = 22,
    Tim1Ch4 = 23,
    Tim1TrigCom = 24,
    Tim1Up = 25,
    Tim2Ch1 = 26,
    Tim2Ch2 = 27,
    Tim2Ch3 = 28,
    Tim2Ch4 = 29,
    Tim2Trig = 30,
    Tim2Up = 31,
    Tim3Ch1 = 32,
    Tim3Ch2 = 33,
    Tim3Ch3 = 34,
    Tim3Ch4 = 35,
    Tim3Trig = 36,
    Tim3Up = 37,
    Tim6Up = 38,
    Tim7Up = 39,
    Tim15Ch1 = 40,
    Tim15Ch2 = 41,
    Tim15TrigCom = 42,
    Tim15Up = 43,
    Tim16Ch1 = 44,
    Tim16Com = 45,
    Tim16Up = 46,
    Tim17Ch1 = 47,
    Tim17Com = 48,
    Tim17Up = 49,
    Usart1Rx = 50,
    Usart1Tx = 51,
    Usart2Rx = 52,
    Usart2Tx = 53,
    Usart3Rx = 54,
    Usart3Tx = 55,
    Usart4Rx = 56,
    Usart4Tx = 57,
    Ucpd1Rx = 58,
    Ucpd1Tx = 59,
    Ucpd2Rx = 60,
    Ucpd2Tx = 61,
    I2c3Rx = 62,
    I2c3Tx = 63,
    Lpuart2Rx = 64,
    Lpuart2Tx = 65,
    Spi3Rx = 66,
    Spi3Tx = 67,
    Tim4Ch1 = 68,
    Tim4Ch2 = 69,
    Tim4Ch3 = 70,
    Tim4Ch4 = 71,
    Tim4Trig = 72,
    Tim4Up = 73,
    Usart5Rx = 74,
    Usart5Tx = 75,
    Usart6Rx = 76,
    Usart6Tx = 77,
}

#[derive(Copy, Clone)]
#[repr(usize)]
#[cfg(feature = "wl")]
/// WL RM, 14.3.2: DMAMUX1 mapping
pub enum DmaInput {
    Adc = 5,
    DacOut1 = 6,
    // Dac1Ch2 = 7,
    Spi1Rx = 7,
    Spi1Tx = 8,
    Spi2Rx = 9,
    Spi2Tx = 10,
    I2c1Rx = 11,
    I2c1Tx = 12,
    I2c2Rx = 13,
    I2c2Tx = 14,
    I2c3Rx = 15,
    I2c3Tx = 16,
    Usart1Rx = 17,
    Usart1Tx = 18,
    Usart2Rx = 19,
    Usart2Tx = 20,
    Lpuart1Rx = 21,
    Lpuart1Tx = 22,
    Tim1Ch1 = 23,
    Tim1Ch2 = 24,
    Tim1Ch3 = 25,
    Tim1Ch4 = 26,
    TimUp = 27,
    Tim1Trig = 28,
    Tim1Com = 29,
    Tim2Ch1 = 30,
    Tim2Ch2 = 31,
    Tim2Ch3 = 32,
    Tim2Ch4 = 33,
    Tim2Up = 34,
    Tim16Ch1 = 35,
    Tim16Up = 36,
    Tim17Ch1 = 37,
    Tim17Up = 38,
    AesIn = 39,
    AesOut = 40,
    SubghzSpiRx = 41,
    SubghzSpiTx = 42,
}

#[derive(Copy, Clone)]
#[repr(usize)]
#[cfg(feature = "wb")]
/// WB RM, 12.3.2: DMAMUX mapping
pub enum DmaInput {
    Adc1 = 5,
    Spi1Rx = 6,
    Spi1Tx = 7,
    Spi2Rx = 8,
    Spi2Tx = 9,
    I2c1Rx = 10,
    I2c1Tx = 11,
    I2c3Rx = 12,
    I2c3Tx = 13,
    Usart1Rx = 14,
    Usart1Tx = 15,
    Lpuart1Rx = 16,
    Lpuart1Tx = 17,
    Sai1A = 18,
    Sai1B = 19,
    Quadspi = 20,
    Tim1Ch1 = 21,
    Tim1Ch2 = 22,
    Tim1Ch3 = 23,
    Tim1Ch4 = 24,
    TimUp = 25,
    Tim1Trig = 26,
    Tim1Com = 27,
    Tim2Ch1 = 28,
    Tim2Ch2 = 29,
    Tim2Ch3 = 30,
    Tim2Ch4 = 31,
    Tim2Up = 32,
    Tim16Ch1 = 33,
    Tim16Up = 34,
    Tim17Ch1 = 35,
    Tim17Up = 36,
    Aes1In = 37,
    Aes1Out = 38,
    Aes2In = 39,
    Aes2Out = 40,
}

// todo: Trigger, synchronization etc mappings. Perhaps DmaTrigger, DmaSync enums etc.

#[derive(Copy, Clone)]
#[repr(usize)]
#[cfg(feature = "h7")]
/// A list of DMA input sources. The integer values represent their DMAMUX register value, on
/// MCUs that use this. H743 RM, Table 121: DMAMUX1: Assignment of multiplexer inputs to resources.
/// (Table 118 in RM0468)
/// Note that this is only for DMAMUX1
pub enum DmaInput {
    Adc1 = 9,
    Adc2 = 10,
    Tim1Ch1 = 11,
    Tim1Ch2 = 12,
    Tim1Ch3 = 13,
    Tim1Ch4 = 14,
    Tim1Up = 15,
    Tim1Trig = 16,
    Tim1Com = 17,
    Tim2Ch1 = 18,
    Tim2Ch2 = 19,
    Tim2Ch3 = 20,
    Tim2Ch4 = 21,
    Tim2Up = 22,
    Tim3Ch1 = 23,
    Tim3Ch2 = 24,
    Tim3Ch3 = 25,
    Tim3Ch4 = 26,
    Tim3Up = 27,
    Tim3Trig = 28,
    Tim4Ch1 = 29,
    Tim4Ch2 = 30,
    Tim4Ch3 = 31,
    Tim4Up = 32,
    I2c1Rx = 33,
    I2c1Tx = 34,
    I2c2Rx = 35,
    I2c2Tx = 36,
    Spi1Rx = 37,
    Spi1Tx = 38,
    Spi2Rx = 39,
    Spi2Tx = 40,
    Usart1Rx = 41,
    Usart1Tx = 42,
    Usart2Rx = 43,
    Usart2Tx = 44,
    Usart3Rx = 45,
    Usart3Tx = 46,
    Tim8Ch1 = 47,
    Tim8Ch2 = 48,
    Tim8Ch3 = 49,
    Tim8Ch4 = 50,
    Tim8Up = 51,
    Tim8Trig = 52,
    Tim8Com = 53,
    Tim5Ch1 = 55,
    Tim5Ch2 = 56,
    Tim5Ch3 = 57,
    Tim5Ch4 = 58,
    Tim5Up = 59,
    Tim5Trig = 60,
    Spi3Rx = 61,
    Spi3Tx = 62,
    Uart4Rx = 63,
    Uart4Tx = 64,
    Uart5Rx = 65,
    Uart5Tx = 66,
    DacCh1 = 67,
    DacCh2 = 68,
    Tim6Up = 69,
    Tim7Up = 70,
    Uart6Rx = 71,
    Uart6Tx = 72,
    I2c3Rx = 73,
    I2c3Tx = 74,
    Dcmi = 75,
    CrypIn = 76,
    CrypOut = 77,
    HashIn = 78,
    Uart7Rx = 79,
    Uart7Tx = 80,
    Uart8Rx = 81,
    Uart8Tx = 82,
    Sai1A = 87,
    Sai1B = 88,
    Sai2A = 89,
    Sai2B = 90,
    Dfsdm1F0 = 101,
    Dfsdm1F1 = 102,
    Dfsdm1F2 = 103,
    Dfsdm1F3 = 104,
    Sai3A = 113,
    Sai3B = 114,
    Adc3 = 115,
    Uart9Rx = 116,
    Uart9Tx = 117,
    Uart10Rx = 118,
    Uart10Tx = 119,
}

#[derive(Copy, Clone)]
#[repr(usize)]
#[cfg(feature = "h7")]
/// A list of DMA input sources for DMAMUX2. Used for BDMA. See H742 RM, Table 124.
pub enum DmaInput2 {
    Lpuart1Rx = 9,
    Lpuart1Tx = 10,
    Spi6Rx = 11,
    Spi6Tx = 12,
    I2c4Rx = 13,
    I3crTx = 14,
    Sai4A = 15,
    Sai4B = 16,
}

impl DmaInput {
    #[cfg(any(feature = "f3", feature = "l4"))]
    /// Select the hard set channel associated with a given input source. See L44 RM, Table 41.
    pub fn dma1_channel(&self) -> DmaChannel {
        match self {
            Self::Adc1 => DmaChannel::C1,
            Self::Dac1Ch1 => DmaChannel::C3,
            Self::Dac1Ch2 => DmaChannel::C4,
            // Self::Tim6Up => 8,
            // Self::Tim7Up => 9,
            Self::Spi1Rx => DmaChannel::C2,
            Self::Spi1Tx => DmaChannel::C3,
            Self::Spi2Rx => DmaChannel::C4,
            Self::Spi2Tx => DmaChannel::C5,
            // Self::Spi3Rx => 14,
            // Self::Spi3Tx => 15,
            Self::I2c1Rx => DmaChannel::C7,
            Self::I2c1Tx => DmaChannel::C6,
            Self::I2c2Rx => DmaChannel::C5,
            Self::I2c2Tx => DmaChannel::C4,
            Self::I2c3Rx => DmaChannel::C3,
            // Self::I2c3Tx => 21,
            // Self::I2c4Rx => 22,
            // Self::I2c4Tx => 23,
            Self::Usart1Rx => DmaChannel::C5,
            Self::Usart1Tx => DmaChannel::C4,
            Self::Usart2Rx => DmaChannel::C6,
            Self::Usart2Tx => DmaChannel::C7,
            Self::Usart3Rx => DmaChannel::C3,
            Self::Usart3Tx => DmaChannel::C2,
            // Self::Uart4Rx => 30,
            // Self::Uart4Tx => 31,
            // Self::Uart5Rx => 32,
            // Self::Uart5Tx => 33,
            // Self::Lpuart1Rx => 34,
            // Self::Lpuart1Tx => 35,
            Self::Adc2 => DmaChannel::C2,
            // Self::Adc3 => 37,
            // Self::Adc4 => 38,
            // Self::Adc5 => 39,
            // Note: Sai1 appears to be DMA2 only.
            Self::Sai2A => DmaChannel::C6,
            Self::Sai2B => DmaChannel::C7,
            Self::Dfsdm1F0 => DmaChannel::C4,
            Self::Dfsdm1F1 => DmaChannel::C5,
            Self::Dfsdm1F2 => DmaChannel::C6,
            Self::Dfsdm1F3 => DmaChannel::C7,
            _ => unimplemented!(),
        }
    }

    #[cfg(feature = "l4")]
    /// Find the value to set in the DMA_CSELR register, for L4. Ie, channel select value for a given DMA input.
    /// See L44 RM, Table 41.
    pub fn dma1_channel_select(&self) -> u8 {
        match self {
            Self::Adc1 => 0b000,
            Self::Dac1Ch1 => 0b0110,
            Self::Dac1Ch2 => 0b0101,
            // Self::Tim6Up => 8,
            // Self::Tim7Up => 9,
            Self::Spi1Rx => 0b001,
            Self::Spi1Tx => 0b001,
            Self::Spi2Rx => 0b001,
            Self::Spi2Tx => 0b001,
            // Self::Spi3Rx => 14,
            // Self::Spi3Tx => 15,
            Self::I2c1Rx => 0b011,
            Self::I2c1Tx => 0b011,
            Self::I2c2Rx => 0b011,
            Self::I2c2Tx => 0b011,
            Self::I2c3Rx => 0b011,
            // Self::I2c3Tx => 21,
            // Self::I2c4Rx => 22,
            // Self::I2c4Tx => 23,
            Self::Usart1Rx => 0b010,
            Self::Usart1Tx => 0b010,
            Self::Usart2Rx => 0b010,
            Self::Usart2Tx => 0b010,
            Self::Usart3Rx => 0b010,
            Self::Usart3Tx => 0b010,
            // Self::Uart4Rx => 30,
            // Self::Uart4Tx => 31,
            // Self::Uart5Rx => 32,
            // Self::Uart5Tx => 33,
            // Self::Lpuart1Rx => 34,
            // Self::Lpuart1Tx => 35,
            Self::Adc2 => 0b000,
            // Self::Adc3 => 37,
            // Self::Adc4 => 38,
            // Self::Adc5 => 39,
            Self::Dfsdm1F0 => 0b0000,
            Self::Dfsdm1F1 => 0b0000,
            Self::Dfsdm1F2 => 0b0000, // todo: QC?
            Self::Dfsdm1F3 => 0b0000,
            _ => unimplemented!(),
        }
    }
}

#[derive(Copy, Clone)]
#[repr(u8)]
/// L4 RM, 11.4.3, "DMA arbitration":
/// The priorities are managed in two stages:
/// • software: priority of each channel is configured in the DMA_CCRx register, to one of
/// the four different levels:
/// – very high
/// – high
/// – medium
/// – low
/// • hardware: if two requests have the same software priority level, the channel with the
/// lowest index gets priority. For example, channel 2 gets priority over channel 4.
/// Only write to this when the channel is disabled.
pub enum Priority {
    Low = 0b00,
    Medium = 0b01,
    High = 0b10,
    VeryHigh = 0b11,
}

// Note: L5 also uses the 0 - 7 scheme, but the PAC doesn't reflect this.
#[derive(Copy, Clone)]
#[repr(u8)]
#[cfg(feature = "h7")]
/// Represents a DMA channel to select, eg when configuring for use with a peripheral.
/// u8 representation is used to index registers on H7 PAC (And hopefully on future PACs if they
/// adopt H7's approach)
pub enum DmaChannel {
    // H7 calls these Streams. We use the `Channel` name for consistency.
    #[cfg(feature = "h7")]
    C0 = 0,
    C1 = 1,
    C2 = 2,
    C3 = 3,
    #[cfg(not(any(feature = "c011", feature = "c031")))]
    C4 = 4,
    #[cfg(not(any(feature = "c011", feature = "c031")))]
    C5 = 5,
    // todo: Some G0 variants have channels 6 and 7 and DMA1. (And up to 5 channels on DMA2)
    //todo: Same for C0: Some variants have these channels.
    #[cfg(not(any(feature = "g0", feature = "c0")))]
    C6 = 6,
    #[cfg(not(any(feature = "g0", feature = "c0")))]
    C7 = 7,
}

// todo: Experimenting with offset ch
#[derive(Copy, Clone)]
#[repr(u8)]
#[cfg(not(feature = "h7"))]
/// Represents a DMA channel to select, eg when configuring for use with a peripheral.
/// u8 representation is used to index registers on H7 PAC (And hopefully on future PACs if they
/// adopt H7's approach)
pub enum DmaChannel {
    C1 = 0,
    C2 = 1,
    C3 = 2,
    #[cfg(not(any(feature = "c011", feature = "c031")))]
    C4 = 3,
    #[cfg(not(any(feature = "c011", feature = "c031")))]
    C5 = 4,
    // todo: Some G0 variants have channels 6 and 7 and DMA1. (And up to 5 channels on DMA2)
    //todo: Same for C0: Some variants have these channels.
    #[cfg(not(any(feature = "g0", feature = "c0")))]
    C6 = 5,
    #[cfg(not(any(feature = "g0", feature = "c0")))]
    C7 = 6,
    // todo: Which else have 8? Also, note that some have diff amounts on dma1 vs 2.
    #[cfg(any(feature = "l5", feature = "g4"))]
    C8 = 7,
}

#[derive(Copy, Clone)]
#[repr(u8)]
/// Set in ccr().
/// Can only be set when channel is disabled.
pub enum Direction {
    /// DIR = 0 defines typically a peripheral-to-memory transfer
    ReadFromPeriph = 0,
    /// DIR = 1 defines typically a memory-to-peripheral transfer.
    ReadFromMem = 1,
    MemToMem = 2,
}

#[derive(Copy, Clone, PartialEq)]
#[repr(u8)]
/// Set in ccr().
/// Can only be set when channel is disabled.
pub enum Circular {
    Disabled = 0,
    Enabled = 1,
}

#[derive(Copy, Clone)]
#[repr(u8)]
/// Peripheral and memory increment mode. (CCR PINC and MINC bits)
/// Can only be set when channel is disabled.
pub enum IncrMode {
    // Can only be set when channel is disabled.
    Disabled = 0,
    Enabled = 1,
}

#[derive(Copy, Clone)]
#[repr(u8)]
/// Peripheral and memory increment mode. (CCR PSIZE and MSIZE bits)
/// Can only be set when channel is disabled.
pub enum DataSize {
    S8 = 0b00, // ie 8 bits
    S16 = 0b01,
    S32 = 0b10,
}

#[derive(Copy, Clone)]
/// Interrupt type. Set in CCR using TEIE, HTIE, and TCIE bits.
/// Can only be set when channel is disabled.
pub enum DmaInterrupt {
    TransferError,
    HalfTransfer,
    TransferComplete,
    #[cfg(feature = "h7")]
    DirectModeError,
    #[cfg(feature = "h7")]
    FifoError,
}

/// Reduce DRY over channels when configuring a channel's ccr().
/// We must use a macro here, since match arms balk at the incompatible
/// types of `CCR1`, `CCR2` etc.
#[cfg(not(feature = "h7"))]
macro_rules! set_ccr {
    ($ccr:expr, $priority:expr, $direction:expr, $circular:expr, $periph_incr:expr, $mem_incr:expr, $periph_size:expr, $mem_size:expr) => {
        // "The register fields/bits MEM2MEM, PL[1:0], MSIZE[1:0], PSIZE[1:0], MINC, PINC, and DIR
        // are read-only when EN = 1"
        let originally_enabled = $ccr().read().en().bit_is_set();

        if originally_enabled {
            $ccr().modify(|_, w| w.en().clear_bit());
            bounded_loop!(
                $ccr().read().en().bit_is_set(),
                Error::RegisterUnchanged
            );
        }

        if let Circular::Enabled = $circular {
            $ccr().modify(|_, w| w.mem2mem().clear_bit());
        }

        $ccr().modify(|_, w| unsafe {
            // – the channel priority
            w.pl().bits($priority as u8);
            // – the data transfer direction
            // This bit [DIR] must be set only in memory-to-peripheral and peripheral-to-memory modes.
            // 0: read from peripheral
            w.dir().bit($direction as u8 != 0);
            // – the circular mode
            w.circ().bit($circular as u8 != 0);
            // – the peripheral and memory incremented mode
            w.pinc().bit($periph_incr as u8 != 0);
            w.minc().bit($mem_incr as u8 != 0);
            // – the peripheral and memory data size
            w.psize().bits($periph_size as u8);
            w.msize().bits($mem_size as u8);
            // – the interrupt enable at half and/or full transfer and/or transfer error
            w.tcie().bit(true);
            // (See `Step 5` above.)
            w.en().bit(true)
        });

        if originally_enabled {
            $ccr().modify(|_, w| w.en().bit(true));
            bounded_loop!($ccr().read().en().bit_is_clear(), Error::RegisterUnchanged);
        }
    };
}

/// Reduce DRY over channels when configuring a channel's interrupts.
#[cfg(not(feature = "h7"))]
macro_rules! enable_interrupt {
    ($ccr:expr, $interrupt_type:expr) => {
        // "It must not be written when the channel is enabled (EN = 1)."
        let originally_enabled = $ccr().read().en().bit_is_set();
        if originally_enabled {
            $ccr().modify(|_, w| w.en().clear_bit());
            bounded_loop!($ccr().read().en().bit_is_set(), Error::RegisterUnchanged);
        }

        $ccr().modify(|_, w| match $interrupt_type {
            DmaInterrupt::TransferError => w.teie().bit(true),
            DmaInterrupt::HalfTransfer => w.htie().bit(true),
            DmaInterrupt::TransferComplete => w.tcie().bit(true),
        });

        if originally_enabled {
            $ccr().modify(|_, w| w.en().bit(true));
            bounded_loop!($ccr().read().en().bit_is_clear(), Error::RegisterUnchanged);
        }
    };
}

/// Reduce DRY over channels when configuring a channel's interrupts.
#[cfg(not(feature = "h7"))]
macro_rules! disable_interrupt {
    ($ccr:expr, $interrupt_type:expr) => {
        // "It must not be written when the channel is disabled (EN = 1)."
        let originally_disabled = $ccr().read().en().bit_is_set();
        if originally_disabled {
            $ccr().modify(|_, w| w.en().clear_bit());
            bounded_loop!($ccr().read().en().bit_is_set(), Error::RegisterUnchanged);
        }

        $ccr().modify(|_, w| match $interrupt_type {
            DmaInterrupt::TransferError => w.teie().clear_bit(),
            DmaInterrupt::HalfTransfer => w.htie().clear_bit(),
            DmaInterrupt::TransferComplete => w.tcie().clear_bit(),
        });

        if originally_disabled {
            $ccr().modify(|_, w| w.en().bit(true));
            bounded_loop!($ccr().read().en().bit_is_clear(), Error::RegisterUnchanged);
        }
    };
}

/// This struct is used to pass common (non-peripheral and non-use-specific) data when configuring
/// a channel.
#[derive(Clone)]
pub struct ChannelCfg {
    /// Channel priority compared to other channels; can be low, medium, high, or very high. Defaults
    /// to medium.
    pub priority: Priority,
    /// Enable or disable circular DMA. If enabled, the transfer continues after reaching the end of
    /// the buffer, looping to the beginning. A TC interrupt first each time the end is reached, if
    /// set. Defaults to disabled.
    pub circular: Circular,
    /// Whether we increment the peripheral address on data word transfer; generally (and by default)
    /// disabled.
    pub periph_incr: IncrMode,
    /// Whether we increment the buffer address on data word transfer; generally (and by default)
    /// enabled.
    pub mem_incr: IncrMode,
}

impl Default for ChannelCfg {
    fn default() -> Self {
        Self {
            priority: Priority::Medium,
            circular: Circular::Disabled,
            // Increment the buffer address, not the peripheral address.
            periph_incr: IncrMode::Disabled,
            mem_incr: IncrMode::Enabled,
        }
    }
}

/// Represents a Direct Memory Access (DMA) peripheral.
pub struct Dma<D> {
    pub regs: D,
}

impl<D> Deref for Dma<D>
where
    D: Deref<Target = dma1::RegisterBlock>,
{
    type Target = dma1::RegisterBlock;
    fn deref(&self) -> &Self::Target {
        &self.regs
    }
}

impl<D> Dma<D>
where
    D: Deref<Target = dma1::RegisterBlock>,
{
    /// Initialize a DMA peripheral, including enabling and resetting
    /// its RCC peripheral clock.
    pub fn new(regs: D) -> Self {
        // todo: Enable RCC for DMA 2 etc!
        let rcc = unsafe { &(*RCC::ptr()) };
        cfg_if! {
            if #[cfg(feature = "f3")] {
                rcc.ahbenr().modify(|_, w| w.dma1en().bit(true)); // no dmarst on F3.
            } else if #[cfg(any(feature = "g031", feature = "g041", feature = "g051", feature = "g061", feature = "g071", feature = "g081"))] {
                rcc_en_reset!(ahb1, dma, rcc);
            } else {
                rcc_en_reset!(ahb1, dma1, rcc);
            }
        }

        Self { regs }
    }

    // #[cfg(not(feature = "h7"))] // due to num_data size diff
    // /// Configure a DMA channel. See L4 RM 0394, section 11.4.4. Sets the Transfer Complete
    // /// interrupt. Note that this fn has been (perhaps) depreciated by the standalone fn.
    // pub fn cfg_channel(
    //     &mut self,
    //     channel: DmaChannel,
    //     periph_addr: u32,
    //     mem_addr: u32,
    //     num_data: u16,
    //     direction: Direction,
    //     periph_size: DataSize,
    //     mem_size: DataSize,
    //     cfg: ChannelCfg,
    // ) {
    //     cfg_channel(
    //         &mut self.regs,
    //         channel,
    //         periph_addr,
    //         mem_addr,
    //         num_data,
    //         direction,
    //         periph_size,
    //         mem_size,
    //         cfg,
    //     )
    // }

    // #[cfg(feature = "h7")]
    /// Configure a DMA channel. See L4 RM 0394, section 11.4.4. Sets the Transfer Complete
    /// interrupt. Note that this fn has been (perhaps) depreciated by the standalone fn.
    pub fn cfg_channel(
        &mut self,
        channel: DmaChannel,
        periph_addr: u32,
        mem_addr: u32,
        num_data: u32,
        direction: Direction,
        periph_size: DataSize,
        mem_size: DataSize,
        cfg: ChannelCfg,
    ) -> Result<()> {
        cfg_channel(
            &mut self.regs,
            channel,
            periph_addr,
            mem_addr,
            num_data,
            direction,
            periph_size,
            mem_size,
            cfg,
        )
    }

    #[cfg(feature = "l4")]
    pub(crate) fn channel_select(&mut self, input: DmaInput) {
        channel_select(&mut self.regs, input);
    }

    /// Stop a DMA transfer, if in progress.
    pub fn stop(&mut self, channel: DmaChannel) -> Result<()> {
        stop_internal(&mut self.regs, channel)
    }

    /// Clear an interrupt flag.
    pub fn clear_interrupt(&mut self, channel: DmaChannel, interrupt: DmaInterrupt) -> Result<()> {
        clear_interrupt_internal(&mut self.regs, channel, interrupt)
    }

    // todo: G0 removed from this fn due to a bug introduced in PAC 0.13
    #[cfg(not(any(feature = "h7")))]
    pub fn transfer_is_complete(&mut self, channel: DmaChannel) -> bool {
        let isr_val = self.regs.isr().read();
        match channel {
            DmaChannel::C1 => isr_val.tcif1().bit_is_set(),
            DmaChannel::C2 => isr_val.tcif2().bit_is_set(),
            DmaChannel::C3 => isr_val.tcif3().bit_is_set(),
            #[cfg(not(any(feature = "c011", feature = "c031")))]
            DmaChannel::C4 => isr_val.tcif4().bit_is_set(),
            #[cfg(not(any(feature = "c011", feature = "c031")))]
            DmaChannel::C5 => isr_val.tcif5().bit_is_set(),
            #[cfg(not(any(feature = "g0", feature = "c0")))]
            DmaChannel::C6 => isr_val.tcif6().bit_is_set(),
            #[cfg(not(any(feature = "g0", feature = "c0")))]
            DmaChannel::C7 => isr_val.tcif7().bit_is_set(),
            #[cfg(any(feature = "l5", feature = "g4"))]
            DmaChannel::C8 => isr_val.tcif8().bit_is_set(),
        }
    }

    #[cfg(feature = "h7")]
    pub fn transfer_is_complete(&mut self, channel: DmaChannel) -> bool {
        match channel {
            DmaChannel::C0 => self.regs.lisr().read().tcif0().bit_is_set(),
            DmaChannel::C1 => self.regs.lisr().read().tcif1().bit_is_set(),
            DmaChannel::C2 => self.regs.lisr().read().tcif2().bit_is_set(),
            DmaChannel::C3 => self.regs.lisr().read().tcif3().bit_is_set(),
            DmaChannel::C4 => self.regs.hisr().read().tcif4().bit_is_set(),
            DmaChannel::C5 => self.regs.hisr().read().tcif5().bit_is_set(),
            DmaChannel::C6 => self.regs.hisr().read().tcif6().bit_is_set(),
            DmaChannel::C7 => self.regs.hisr().read().tcif7().bit_is_set(),
        }
    }

    /// Enable a specific type of interrupt.
    pub fn enable_interrupt(&mut self, channel: DmaChannel, interrupt: DmaInterrupt) -> Result<()> {
        enable_interrupt_internal(&mut self.regs, channel, interrupt)
    }

    /// Disable a specific type of interrupt.
    /// todo: Non-H7 version too!
    // #[cfg(feature = "h7")]
    pub fn disable_interrupt(
        &mut self,
        channel: DmaChannel,
        interrupt: DmaInterrupt,
    ) -> Result<()> {
        // Can only be set when the channel is disabled.
        // todo: Is this true for disabling interrupts true, re the channel must be disabled?
        #[cfg(feature = "h7")]
        let cr = &self.regs.st(channel as usize).cr();
        #[cfg(not(feature = "h7"))]
        let cr = &self.regs.ch(channel as usize).cr();

        let originally_enabled = cr.read().en().bit_is_set();

        if originally_enabled {
            cr.modify(|_, w| w.en().clear_bit());
            bounded_loop!(cr.read().en().bit_is_set(), Error::RegisterUnchanged);
        }

        match interrupt {
            DmaInterrupt::TransferError => cr.modify(|_, w| w.teie().clear_bit()),
            DmaInterrupt::HalfTransfer => cr.modify(|_, w| w.htie().clear_bit()),
            DmaInterrupt::TransferComplete => cr.modify(|_, w| w.tcie().clear_bit()),
            #[cfg(feature = "h7")]
            DmaInterrupt::DirectModeError => cr.modify(|_, w| w.dmeie().clear_bit()),
            #[cfg(feature = "h7")]
            DmaInterrupt::FifoError => self
                .regs
                .st(channel as usize)
                .fcr()
                .modify(|_, w| w.feie().clear_bit()),
        };

        if originally_enabled {
            cr.modify(|_, w| w.en().bit(true));
            bounded_loop!(cr.read().en().bit_is_clear(), Error::RegisterUnchanged);
        }

        Ok(())
    }
}

/// Configure a DMA channel. See L4 RM 0394, section 11.4.4. Sets the Transfer Complete
/// interrupt. This is the function called by various module `read_dma` and `write_dma` functions.
// #[cfg(feature = "h7")]
pub fn cfg_channel<D>(
    regs: &mut D,
    channel: DmaChannel,
    periph_addr: u32,
    mem_addr: u32,
    num_data: u32,
    direction: Direction,
    periph_size: DataSize,
    mem_size: DataSize,
    cfg: ChannelCfg,
) -> Result<()>
where
    D: Deref<Target = dma1::RegisterBlock>,
{
    cfg_if! {
        if #[cfg(feature = "h7")] {
            let mut channel = regs.st(channel as usize);
        } else {
            let mut channel = regs.ch(channel as usize);
        }
    }
    // todo: The H7 sections are different, but we consolidated the comments. Figure out
    // todo what's different and fix it by following the steps
    // FIXME: Something is not right here.

    let originally_enabled = channel.cr().read().en().bit_is_set();

    channel.cr().modify(|_, w| w.en().clear_bit());
    bounded_loop!(
        channel.cr().read().en().bit_is_set(),
        Error::RegisterUnchanged
    );

    // H743 RM Section 15.3.19 The following sequence is needed to configure a DMA stream x:
    // 1. Set the peripheral register address in the DMA_CPARx register.
    // The data is moved from/to this address to/from the memory after the peripheral event,
    // or after the channel is enabled in memory-to-memory mode.
    channel.par().write(|w| unsafe { w.bits(periph_addr) });

    // See the [Embedonomicon section on DMA](https://docs.rust-embedded.org/embedonomicon/dma.html)
    // for info on why we use `compiler_fence` here:
    // "We use Ordering::Release to prevent all preceding memory operations from being moved
    // after [starting DMA], which performs a volatile write."

    atomic::compiler_fence(Ordering::SeqCst);

    // 2. Set the memory address in the DMA_CMARx register.
    // The data is written to/read from the memory after the peripheral event or after the
    // channel is enabled in memory-to-memory mode.
    #[cfg(any(feature = "h7", feature = "l5"))]
    channel.m0ar().write(|w| unsafe { w.bits(mem_addr) });

    #[cfg(not(any(feature = "h7", feature = "l5")))]
    channel.mar().write(|w| unsafe { w.bits(mem_addr) });

    // todo: m1ar too, if in double-buffer mode.

    // 3. Configure the total number of data to transfer in the DMA_CNDTRx register.
    // After each data transfer, this value is decremented.
    channel.ndtr().write(|w| unsafe { w.bits(num_data) });

    // (later): The circular mode must not be used in memory-to-memory mode. Before enabling a
    // channel in circular mode (CIRC = 1), the software must clear the MEM2MEM bit of the
    // DMA_CCRx register. When the circular mode is activated, the amount of data to transfer is
    // automatically reloaded with the initial value programmed during the channel configuration
    // phase, and the DMA requests continue to be served

    // (See remainder of steps in `set_ccr()!` macro.

    // todo: Let user set mem2mem mode?

    if originally_enabled {
        channel.cr().modify(|_, w| w.en().clear_bit());
        bounded_loop!(
            channel.cr().read().en().bit_is_set(),
            Error::RegisterUnchanged
        );
    }

    // 4. Configure the parameters listed below in the DMA_CCRx register:
    // (These are listed below by their corresponding reg write code)
    //
    // todo: See note about sep reg writes to disable channel, and when you need to do this.

    channel.cr().modify(|_, w| unsafe {
        // – the channel priority
        w.pl().bits(cfg.priority as u8);
        // – the data transfer direction
        // This bit [DIR] must be set only in memory-to-peripheral and peripheral-to-memory modes.
        // 0: read from peripheral
        #[cfg(feature = "h7")]
        w.dir().bits(direction as u8);
        #[cfg(not(feature = "h7"))]
        w.dir().bit((direction as u8) != 0);
        // – the circular mode
        w.circ().bit(cfg.circular as u8 != 0);
        // – the peripheral and memory incremented mode
        w.pinc().bit(cfg.periph_incr as u8 != 0);
        w.minc().bit(cfg.mem_incr as u8 != 0);
        // – the peripheral and memory data size
        w.psize().bits(periph_size as u8);
        w.msize().bits(mem_size as u8);
        // – the interrupt enable at half and/or full transfer and/or transfer error
        w.tcie().bit(true);
        // (See `Step 5` above.)
        w.en().bit(true)
    });

    // 5. Activate the channel by setting the EN bit in the DMA_CCRx register.
    // A channel, as soon as enabled, may serve any DMA request from the peripheral connected
    // to this channel, or may start a memory-to-memory block transfer.
    // Note: The two last steps of the channel configuration procedure may be merged into a single
    // access to the DMA_CCRx register, to configure and enable the channel.
    // When a channel is enabled and still active (not completed), the software must perform two
    // separate write accesses to the DMA_CCRx register, to disable the channel, then to
    // reprogram the channel for another next block transfer.
    // Some fields of the DMA_CCRx register are read-only when the EN bit is set to 1

    if originally_enabled {
        channel.cr().modify(|_, w| w.en().set_bit());
        bounded_loop!(
            channel.cr().read().en().bit_is_clear(),
            Error::RegisterUnchanged
        );
    }

    Ok(())
}

/// Stop a DMA transfer, if in progress.
fn stop_internal<D>(regs: &mut D, channel: DmaChannel) -> Result<()>
where
    D: Deref<Target = dma1::RegisterBlock>,
{
    // L4 RM:
    // Once the software activates a channel, it waits for the completion of the programmed
    // transfer. The DMA controller is not able to resume an aborted active channel with a possible
    // suspended bus transfer.
    // To correctly stop and disable a channel, the software clears the EN bit of the DMA_CCRx
    // register.

    // The software secures that no pending request from the peripheral is served by the
    // DMA controller before the transfer completion.
    // todo?

    #[cfg(feature = "h7")]
    let cr = &regs.st(channel as usize).cr();
    #[cfg(not(feature = "h7"))]
    let cr = &regs.ch(channel as usize).cr();

    cr.modify(|_, w| w.en().clear_bit());
    bounded_loop!(cr.read().en().bit_is_set(), Error::RegisterUnchanged);

    Ok(())

    // The software waits for the transfer complete or transfer error interrupt.
    // (Handed by calling code)

    // (todo: set ifcr().cficx bit to clear all interrupts?)

    // When a channel transfer error occurs, the EN bit of the DMA_CCRx register is cleared by
    // hardware. This EN bit can not be set again by software to re-activate the channel x, until the
    // TEIFx bit of the DMA_ISR register is set
}

/// Stop a DMA transfer, if in progress.
pub fn stop(periph: DmaPeriph, channel: DmaChannel) -> Result<()> {
    match periph {
        DmaPeriph::Dma1 => {
            let mut regs = unsafe { &(*DMA1::ptr()) };
            stop_internal(&mut regs, channel)
        }
        #[cfg(dma2)]
        DmaPeriph::Dma2 => {
            let mut regs = unsafe { &(*DMA2::ptr()) };
            stop_internal(&mut regs, channel)
        }
    }
}

fn clear_interrupt_internal<D>(
    regs: &mut D,
    channel: DmaChannel,
    interrupt: DmaInterrupt,
) -> Result<()>
where
    D: Deref<Target = dma1::RegisterBlock>,
{
    // todo: Add waiting on the set bit(s)?
    cfg_if! {
        if #[cfg(any(feature = "g4", feature = "wl"))] {
            regs.ifcr().write(|w| match channel {
                DmaChannel::C1 => match interrupt {
                    DmaInterrupt::TransferError => w.cteif1().bit(true),
                    DmaInterrupt::HalfTransfer => w.chtif1().bit(true),
                    DmaInterrupt::TransferComplete => w.ctcif1().bit(true),
                }
                DmaChannel::C2 => match interrupt {
                    DmaInterrupt::TransferError => w.cteif2().bit(true),
                    DmaInterrupt::HalfTransfer => w.chtif2().bit(true),
                    DmaInterrupt::TransferComplete => w.ctcif2().bit(true),
                }
                DmaChannel::C3 => match interrupt {
                    DmaInterrupt::TransferError => w.cteif3().bit(true),
                    DmaInterrupt::HalfTransfer => w.chtif3().bit(true),
                    DmaInterrupt::TransferComplete => w.ctcif3().bit(true),
                }
                DmaChannel::C4 => match interrupt {
                    DmaInterrupt::TransferError => w.cteif4().bit(true),
                    DmaInterrupt::HalfTransfer => w.chtif4().bit(true),
                    DmaInterrupt::TransferComplete => w.ctcif4().bit(true),
                }
                DmaChannel::C5 => match interrupt {
                    DmaInterrupt::TransferError => w.cteif5().bit(true),
                    DmaInterrupt::HalfTransfer => w.chtif5().bit(true),
                    DmaInterrupt::TransferComplete => w.ctcif5().bit(true),
                }
                DmaChannel::C6 => match interrupt {
                    DmaInterrupt::TransferError => w.cteif6().bit(true),
                    DmaInterrupt::HalfTransfer => w.chtif6().bit(true),
                    DmaInterrupt::TransferComplete => w.ctcif6().bit(true),
                }
                DmaChannel::C7 => match interrupt {
                    DmaInterrupt::TransferError => w.cteif7().bit(true),
                    DmaInterrupt::HalfTransfer => w.chtif7().bit(true),
                    DmaInterrupt::TransferComplete => w.ctcif7().bit(true),
                }
                #[cfg(not(feature = "wl"))]
                DmaChannel::C8 => match interrupt {
                    DmaInterrupt::TransferError => w.cteif8().bit(true),
                    DmaInterrupt::HalfTransfer => w.chtif8().bit(true),
                    DmaInterrupt::TransferComplete => w.ctcif8().bit(true),
                }
            });
        } else if #[cfg(feature = "h7")] {
            match channel {
                DmaChannel::C0 => match interrupt {
                    DmaInterrupt::TransferError => regs.lifcr().write(|w| w.cteif0().bit(true)),
                    DmaInterrupt::HalfTransfer => regs.lifcr().write(|w| w.chtif0().bit(true)),
                    DmaInterrupt::TransferComplete => regs.lifcr().write(|w| w.ctcif0().bit(true)),
                    DmaInterrupt::DirectModeError => regs.lifcr().write(|w| w.cdmeif0().bit(true)),
                    DmaInterrupt::FifoError => regs.lifcr().write(|w| w.cfeif0().bit(true)),
                }
                DmaChannel::C1 => match interrupt {
                    DmaInterrupt::TransferError => regs.lifcr().write(|w| w.cteif1().bit(true)),
                    DmaInterrupt::HalfTransfer => regs.lifcr().write(|w| w.chtif1().bit(true)),
                    DmaInterrupt::TransferComplete => regs.lifcr().write(|w| w.ctcif1().bit(true)),
                    DmaInterrupt::DirectModeError => regs.lifcr().write(|w| w.cdmeif1().bit(true)),
                    DmaInterrupt::FifoError => regs.lifcr().write(|w| w.cfeif1().bit(true)),
                }
                DmaChannel::C2 => match interrupt {
                    DmaInterrupt::TransferError => regs.lifcr().write(|w| w.cteif2().bit(true)),
                    DmaInterrupt::HalfTransfer => regs.lifcr().write(|w| w.chtif2().bit(true)),
                    DmaInterrupt::TransferComplete => regs.lifcr().write(|w| w.ctcif2().bit(true)),
                    DmaInterrupt::DirectModeError => regs.lifcr().write(|w| w.cdmeif2().bit(true)),
                    DmaInterrupt::FifoError => regs.lifcr().write(|w| w.cfeif2().bit(true)),
                }
                DmaChannel::C3 => match interrupt {
                    DmaInterrupt::TransferError => regs.lifcr().write(|w| w.cteif3().bit(true)),
                    DmaInterrupt::HalfTransfer => regs.lifcr().write(|w| w.chtif3().bit(true)),
                    DmaInterrupt::TransferComplete => regs.lifcr().write(|w| w.ctcif3().bit(true)),
                    DmaInterrupt::DirectModeError => regs.lifcr().write(|w| w.cdmeif3().bit(true)),
                    DmaInterrupt::FifoError => regs.lifcr().write(|w| w.cfeif3().bit(true)),
                }
                DmaChannel::C4 => match interrupt {
                    DmaInterrupt::TransferError => regs.hifcr().write(|w| w.cteif4().bit(true)),
                    DmaInterrupt::HalfTransfer => regs.hifcr().write(|w| w.chtif4().bit(true)),
                    DmaInterrupt::TransferComplete => regs.hifcr().write(|w| w.ctcif4().bit(true)),
                    DmaInterrupt::DirectModeError => regs.hifcr().write(|w| w.cdmeif4().bit(true)),
                    DmaInterrupt::FifoError => regs.hifcr().write(|w| w.cfeif4().bit(true)),
                }
                DmaChannel::C5 => match interrupt {
                    DmaInterrupt::TransferError => regs.hifcr().write(|w| w.cteif5().bit(true)),
                    DmaInterrupt::HalfTransfer => regs.hifcr().write(|w| w.chtif5().bit(true)),
                    DmaInterrupt::TransferComplete => regs.hifcr().write(|w| w.ctcif5().bit(true)),
                    DmaInterrupt::DirectModeError => regs.hifcr().write(|w| w.cdmeif5().bit(true)),
                    DmaInterrupt::FifoError => regs.hifcr().write(|w| w.cfeif5().bit(true)),
                }
                DmaChannel::C6 => match interrupt {
                    DmaInterrupt::TransferError => regs.hifcr().write(|w| w.cteif6().bit(true)),
                    DmaInterrupt::HalfTransfer => regs.hifcr().write(|w| w.chtif6().bit(true)),
                    DmaInterrupt::TransferComplete => regs.hifcr().write(|w| w.ctcif6().bit(true)),
                    DmaInterrupt::DirectModeError => regs.hifcr().write(|w| w.cdmeif6().bit(true)),
                    DmaInterrupt::FifoError => regs.hifcr().write(|w| w.cfeif6().bit(true)),
                }
                DmaChannel::C7 => match interrupt {
                    DmaInterrupt::TransferError => regs.hifcr().write(|w| w.cteif7().bit(true)),
                    DmaInterrupt::HalfTransfer => regs.hifcr().write(|w| w.chtif7().bit(true)),
                    DmaInterrupt::TransferComplete => regs.hifcr().write(|w| w.ctcif7().bit(true)),
                    DmaInterrupt::DirectModeError => regs.hifcr().write(|w| w.cdmeif7().bit(true)),
                    DmaInterrupt::FifoError => regs.hifcr().write(|w| w.cfeif7().bit(true)),
                }
            };
            // todo: G0 PAC 0.14 had a reversion where these flags used to work, but now don't.
        } else if #[cfg(not(feature = "g0"))] {
            regs.ifcr().write(|w| match channel {
                DmaChannel::C1 => match interrupt {
                    DmaInterrupt::TransferError => w.cteif1().bit(true),
                    DmaInterrupt::HalfTransfer => w.chtif1().bit(true),
                    DmaInterrupt::TransferComplete => w.ctcif1().bit(true),
                }
                DmaChannel::C2 => match interrupt {
                    DmaInterrupt::TransferError => w.cteif2().bit(true),
                    DmaInterrupt::HalfTransfer => w.chtif2().bit(true),
                    DmaInterrupt::TransferComplete => w.ctcif2().bit(true),
                }
                DmaChannel::C3 => match interrupt {
                    DmaInterrupt::TransferError => w.cteif3().bit(true),
                    DmaInterrupt::HalfTransfer => w.chtif3().bit(true),
                    DmaInterrupt::TransferComplete => w.ctcif3().bit(true),
                }
                #[cfg(not(any(feature = "c011", feature = "c031")))]
                DmaChannel::C4 => match interrupt {
                    DmaInterrupt::TransferError => w.cteif4().bit(true),
                    DmaInterrupt::HalfTransfer => w.chtif4().bit(true),
                    DmaInterrupt::TransferComplete => w.ctcif4().bit(true),
                }
                #[cfg(not(any(feature = "c011", feature = "c031")))]
                DmaChannel::C5 => match interrupt {
                    DmaInterrupt::TransferError => w.cteif5().bit(true),
                    DmaInterrupt::HalfTransfer => w.chtif5().bit(true),
                    DmaInterrupt::TransferComplete => w.ctcif5().bit(true),
                }
                #[cfg(not(any(feature = "g0", feature = "c0")))]
                DmaChannel::C6 => match interrupt {
                    DmaInterrupt::TransferError => w.cteif6().bit(true),
                    DmaInterrupt::HalfTransfer => w.chtif6().bit(true),
                    DmaInterrupt::TransferComplete => w.ctcif6().bit(true),
                }
                #[cfg(not(any(feature = "g0", feature = "c0")))]
                DmaChannel::C7 => match interrupt {
                    DmaInterrupt::TransferError => w.cteif7().bit(true),
                    DmaInterrupt::HalfTransfer => w.chtif7().bit(true),
                    DmaInterrupt::TransferComplete => w.ctcif7().bit(true),
                }
                #[cfg(any(feature = "l5", feature = "g4"))]
                DmaChannel::C8 => match interrupt {
                    DmaInterrupt::TransferError => w.cteif8().bit(true),
                    DmaInterrupt::HalfTransfer => w.chtif8().bit(true),
                    DmaInterrupt::TransferComplete => w.ctcif8().bit(true),
                }
            });
        }
    }
    Ok(())
}

fn enable_interrupt_internal<D>(
    regs: &mut D,
    channel: DmaChannel,
    interrupt: DmaInterrupt,
) -> Result<()>
where
    D: Deref<Target = dma1::RegisterBlock>,
{
    // Can only be set when the channel is disabled.
    #[cfg(feature = "h7")]
    let cr = &regs.st(channel as usize).cr();
    #[cfg(not(feature = "h7"))]
    let cr = &regs.ch(channel as usize).cr();

    match interrupt {
        DmaInterrupt::TransferError => cr.modify(|_, w| w.teie().bit(true)),
        DmaInterrupt::HalfTransfer => cr.modify(|_, w| w.htie().bit(true)),
        DmaInterrupt::TransferComplete => cr.modify(|_, w| w.tcie().bit(true)),
        #[cfg(feature = "h7")]
        DmaInterrupt::DirectModeError => cr.modify(|_, w| w.dmeie().bit(true)),
        #[cfg(feature = "h7")]
        DmaInterrupt::FifoError => regs
            .st(channel as usize)
            .fcr()
            .modify(|_, w| w.feie().bit(true)),
    };

    Ok(())
}

fn disable_interrupt_internal<D>(
    regs: &mut D,
    channel: DmaChannel,
    interrupt: DmaInterrupt,
) -> Result<()>
where
    D: Deref<Target = dma1::RegisterBlock>,
{
    // Can only be set when the channel is disabled.
    #[cfg(feature = "h7")]
    let cr = &regs.st(channel as usize).cr();
    #[cfg(not(feature = "h7"))]
    let cr = &regs.ch(channel as usize).cr();

    match interrupt {
        DmaInterrupt::TransferError => cr.modify(|_, w| w.teie().clear_bit()),
        DmaInterrupt::HalfTransfer => cr.modify(|_, w| w.htie().clear_bit()),
        DmaInterrupt::TransferComplete => cr.modify(|_, w| w.tcie().clear_bit()),
        #[cfg(feature = "h7")]
        DmaInterrupt::DirectModeError => cr.modify(|_, w| w.dmeie().clear_bit()),
        #[cfg(feature = "h7")]
        DmaInterrupt::FifoError => regs
            .st(channel as usize)
            .fcr()
            .modify(|_, w| w.feie().clear_bit()),
    };

    Ok(())
}

/// Enable a specific type of interrupt.
pub fn enable_interrupt(
    periph: DmaPeriph,
    channel: DmaChannel,
    interrupt: DmaInterrupt,
) -> Result<()> {
    match periph {
        DmaPeriph::Dma1 => {
            let mut regs = unsafe { &(*DMA1::ptr()) };
            enable_interrupt_internal(&mut regs, channel, interrupt)
        }
        #[cfg(dma2)]
        DmaPeriph::Dma2 => {
            let mut regs = unsafe { &(*DMA2::ptr()) };
            enable_interrupt_internal(&mut regs, channel, interrupt)
        }
    }
}

/// Disable a specific type of interrupt.
pub fn disable_interrupt(
    periph: DmaPeriph,
    channel: DmaChannel,
    interrupt: DmaInterrupt,
) -> Result<()> {
    match periph {
        DmaPeriph::Dma1 => {
            let mut regs = unsafe { &(*DMA1::ptr()) };
            disable_interrupt_internal(&mut regs, channel, interrupt)
        }
        #[cfg(dma2)]
        DmaPeriph::Dma2 => {
            let mut regs = unsafe { &(*DMA2::ptr()) };
            disable_interrupt_internal(&mut regs, channel, interrupt)
        }
    }
}

/// Clear an interrupt flag.
pub fn clear_interrupt(
    periph: DmaPeriph,
    channel: DmaChannel,
    interrupt: DmaInterrupt,
) -> Result<()> {
    match periph {
        DmaPeriph::Dma1 => {
            let mut regs = unsafe { &(*DMA1::ptr()) };
            clear_interrupt_internal(&mut regs, channel, interrupt)
        }
        #[cfg(dma2)]
        DmaPeriph::Dma2 => {
            let mut regs = unsafe { &(*DMA2::ptr()) };
            clear_interrupt_internal(&mut regs, channel, interrupt)
        }
    }
}

#[cfg(any(
    feature = "l5",
    feature = "g0",
    feature = "g4",
    feature = "h7",
    feature = "wb",
    feature = "wl",
))]
/// Configure a specific DMA channel to work with a specific peripheral.
pub fn mux(periph: DmaPeriph, channel: DmaChannel, input: DmaInput) {
    // Note: This is similar in API and purpose to `channel_select` above,
    // for different families. We're keeping it as a separate function instead
    // of feature-gating within the same function so the name can be recognizable
    // from the RM etc.

    // G4 example:
    // "The mapping of resources to DMAMUX is hardwired.
    // DMAMUX is used with DMA1 and DMA2:
    // For category 3 and category 4 devices:
    // • DMAMUX channels 0 to 7 are connected to DMA1 channels 1 to 8
    // • DMAMUX channels 8 to 15 are connected to DMA2 channels 1 to 8
    //
    // For category 2 devices:
    // • DMAMUX channels 0 to 5 are connected to DMA1 channels 1 to 6
    // • DMAMUX channels 6 to 11 are connected to DMA2 channels 1 to 6"
    //
    // H723/25/33/35"
    // DMAMUX1 is used with DMA1 and DMA2 in D2 domain
    // • DMAMUX1 channels 0 to 7 are connected to DMA1 channels 0 to 7
    // • DMAMUX1 channels 8 to 15 are connected to DMA2 channels 0 to 7
    // (Note: The H7 and G4 cat 3/4 mappings are the same, except for H7's use of 0-7, and G4's use of 1-8.)

    // todo: With this in mind, some of the mappings below are not correct on some G4 variants.

    unsafe {
        let mux = unsafe { &(*DMAMUX::ptr()) };

        #[cfg(feature = "g4")]
        let rcc = unsafe { &(*RCC::ptr()) };
        #[cfg(feature = "g4")]
        rcc.ahb1enr().modify(|_, w| w.dmamux1en().bit(true));

        // Note the offset by 1, due to mismatch in DMA channels starting at 1, and DMAMUX
        // channels starting at 0. Ops tested this is correct on G4.

        // G4 RM: "For category 3 and category 4 devices:
        // - DMAMUX channels 0 to 7 are connected to DMA1 channels 1 to 8
        // - DMAMUX channels 8 to 15 are connected to DMA2 channels 1 to 8"
        // For category 2 devices (G431 etc):
        // - DMAMUX channels 0 to 5 are connected to DMA1 channels 1 to 6
        // - DMAMUX channels 6 to 11 are connected to DMA2 channels 1 to 6

        // todo: Setting to +8 for G431 for now, while TS other issues; I believe
        // todo that's how it was set previously.

        // L5 RM: Same as cat 3/4 G4 devs above, but connected to DMA chs 0-7 respectively.
        #[cfg(feature = "g431")]
        let dma2_offset = 6;
        #[cfg(not(feature = "g431"))]
        let dma2_offset = 8;

        match periph {
            DmaPeriph::Dma1 => {
                mux.ccr(channel as usize)
                    .modify(|_, w| w.dmareq_id().bits(input as u8));
            }
            #[cfg(dma2)]
            DmaPeriph::Dma2 => {
                mux.ccr(channel as usize + dma2_offset)
                    .modify(|_, w| w.dmareq_id().bits(input as u8));
            }
        }
    }
}

#[cfg(feature = "h7")]
/// Configure a specific DMA channel to work with a specific peripheral, on DMAMUX2.
pub fn mux2(periph: DmaPeriph, channel: DmaChannel, input: DmaInput2, mux: &mut DMAMUX2) {
    mux.ccr(channel as usize)
        .modify(|_, w| unsafe { w.dmareq_id().bits(input as u8) });
}

// todo: Enable this for other MCUs as requried
/// Enable the DMA mux RCC clock. Applicable to some variants, but no others. (H7 and G0 don't use it,
/// for example)
#[cfg(any(feature = "g4", feature = "wb"))]
pub fn enable_mux1() {
    let rcc = unsafe { &(*RCC::ptr()) };

    cfg_if! {
        if #[cfg(feature = "g4")] {
            // Note inconsistency between `dmamux` and `dmamux`; can't use macro here.
            rcc.ahb1enr().modify(|_, w| w.dmamux1en().bit(true));
            rcc.ahb1rstr().modify(|_, w| w.dmamux1rst().bit(true));
            rcc.ahb1rstr().modify(|_, w| w.dmamux1rst().clear_bit());
        } else {
            rcc_en_reset!(ahb1, dmamux, rcc);
        }
    }
}

#[cfg(feature = "l4")] // Only required on L4
/// Select which peripheral on a given channel we're using.
/// See L44 RM, Table 41.
pub(crate) fn channel_select<D>(regs: &mut D, input: DmaInput)
where
    D: Deref<Target = dma1::RegisterBlock>,
{
    // todo: Allow selecting channels in pairs to save a write.
    let val = input.dma1_channel_select();

    unsafe {
        regs.cselr().modify(|_, w| match input.dma1_channel() {
            DmaChannel::C1 => w.c1s().bits(val),
            DmaChannel::C2 => w.c2s().bits(val),
            DmaChannel::C3 => w.c3s().bits(val),
            DmaChannel::C4 => w.c4s().bits(val),
            DmaChannel::C5 => w.c5s().bits(val),
            DmaChannel::C6 => w.c6s().bits(val),
            DmaChannel::C7 => w.c7s().bits(val),
        });
    }
}

// todo: Code below is for experimental struct-per-channel API
macro_rules! make_chan_struct {
    // ($Periph:ident, $PERIPH:ident, $periph:ident, $ch:expr) => {
    ($periph: expr, $ch:expr) => {
        paste::paste! {
            /// Experimental/WIP channel-based DMA struct.
            pub struct [<Dma $periph Ch $ch>] {
                // #[cfg(feature = "h7")]
                // regs: dma1::st // todo?
            }

            impl [<Dma $periph Ch $ch>] {
                /// Initialize a DMA peripheral, including enabling and resetting
                /// its RCC peripheral clock.
                /// Note that the clock may have already been enabled by a different channel's
                /// constructor.
                pub fn new() -> Self {
                    // todo: Enable RCC for DMA 2 etc!
                    let rcc = unsafe { &(*RCC::ptr()) };
                    cfg_if! {
                        if #[cfg(feature = "f3")] {
                            rcc.ahbenr().modify(|_, w| w.dma1en().bit(true)); // no dmarst on F3.
                        } else if #[cfg(feature = "g0")] {
                            rcc_en_reset!(ahb1, dma, rcc);
                        } else {
                            rcc_en_reset!(ahb1, [<dma $periph>], rcc);
                        }
                    }

                    Self { }
                }

                fn regs(&self) -> &[<dma $periph>]::RegisterBlock {
                    unsafe { &(*[<DMA $periph>]::ptr())}
                }

                // // #[cfg(feature = "h7")]
                // fn ccr(&self) -> &[<dma $periph>]::st::CR {
                // // fn ccr(&self) -> &u8 {
                //     #[cfg(feature = "h7")]
                //     &self.regs().st($ch).cr
                //     #[cfg(not(feature = "h7"))]
                //     &self.regs().ch($ch).cr
                // }z
                //
                // // #[cfg(not(any(feature = "h7", feature = "f3", feature = "g0")))]
                // // fn ccr(&self) -> &[<dma $periph>]::[<CCR $ch>] {
                // //     &self.regs().[<ccr $ch>]
                // // }
                //
                // #[cfg(any(feature = "f3", feature = "g0"))]
                // // fn ccr(&self) -> &[<dma $periph>]::ch::cr {
                //  fn ccr(&self) -> i8 {
                //     &self.regs().[<ch $ch>].cr
                // }

                // #[cfg(not(feature = "h7"))] // due to num_data size diff
                // /// Configure a DMA channel. See L4 RM 0394, section 11.4.4. Sets the Transfer Complete
                // /// interrupt. Note that this fn has been (perhaps) depreciated by the standalone fn.
                // pub fn cfg_channel(
                //     &mut self,
                //     periph_addr: u32,
                //     mem_addr: u32,
                //     // num_data: u16,
                //     num_data: u32,
                //     direction: Direction,
                //     periph_size: DataSize,
                //     mem_size: DataSize,
                //     cfg: ChannelCfg,
                // ) {
                //     cfg_channel(
                //         &mut self.regs(),
                //         DmaChannel::[<C $ch>],
                //         periph_addr,
                //         mem_addr,
                //         num_data,
                //         direction,
                //         periph_size,
                //         mem_size,
                //         cfg,
                //     )
                // }

                /// Configure a DMA channel. See L4 RM 0394, section 11.4.4. Sets the Transfer Complete
                /// interrupt. Note that this fn has been (perhaps) depreciated by the standalone fn.
                pub fn cfg_channel(
                    &mut self,
                    periph_addr: u32,
                    mem_addr: u32,
                    num_data: u32,
                    direction: Direction,
                    periph_size: DataSize,
                    mem_size: DataSize,
                    cfg: ChannelCfg,
                ) -> Result<()> {
                    cfg_channel(
                        &mut self.regs(),
                        DmaChannel::[<C $ch>],
                        periph_addr,
                        mem_addr,
                        num_data,
                        direction,
                        periph_size,
                        mem_size,
                        cfg,
                    )
                }

                /// Stop a DMA transfer, if in progress.
                pub fn stop(&mut self) -> Result<()> {
                    #[cfg(feature = "h7")]
                    let ccr = self.regs().st($ch).cr();
                    #[cfg(not(feature = "h7"))]
                    let ccr = self.regs().ch($ch).cr();

                    ccr.modify(|_, w| w.en().clear_bit());
                    bounded_loop!(ccr.read().en().bit_is_set(), Error::RegisterUnchanged);

                    Ok(())
                }

                /// Enable a specific type of interrupt.
                pub fn enable_interrupt(&mut self, interrupt: DmaInterrupt) {
                    enable_interrupt_internal(&mut self.regs(), DmaChannel::[<C $ch>], interrupt).unwrap()
                }

                /// Clear an interrupt flag.
                pub fn clear_interrupt(&mut self, interrupt: DmaInterrupt) {
                    clear_interrupt_internal(&mut self.regs(), DmaChannel::[<C $ch>], interrupt).unwrap()
                }
                // todo: Other methods.
            }
        }
    };
}

// Note: G0 is limited, eg for some variants only up to DMA1, ch5.
cfg_if! {
    if #[cfg(not(any(feature = "f3", feature = "g0")))] {
        #[cfg(feature = "h7")]
        make_chan_struct!(1, 0);
        make_chan_struct!(1, 1);
        make_chan_struct!(1, 2);
        make_chan_struct!(1, 3);
        #[cfg(not(any(feature = "c011", feature = "c031")))]
        make_chan_struct!(1, 4);
        #[cfg(not(any(feature = "c011", feature = "c031")))]
        make_chan_struct!(1, 5);
        #[cfg(not(any(feature = "g0", feature = "c0")))]
        make_chan_struct!(1, 6);
        #[cfg(not(any(feature = "g0", feature = "c0")))]
        make_chan_struct!(1, 7);
        #[cfg(any(feature = "l5", feature = "g4"))]
        make_chan_struct!(1, 8);

        #[cfg(feature = "h7")]
        make_chan_struct!(2, 0);
        #[cfg(not(any(feature = "g0", feature = "wb", feature = "c0")))]
        make_chan_struct!(2, 1);
        #[cfg(not(any(feature = "g0", feature = "wb", feature = "c0")))]
        make_chan_struct!(2, 2);
        #[cfg(not(any(feature = "g0", feature = "wb", feature = "c0")))]
        make_chan_struct!(2, 3);
        #[cfg(not(any(feature = "g0", feature = "wb", feature = "c0")))]
        make_chan_struct!(2, 4);
        #[cfg(not(any(feature = "g0", feature = "wb", feature = "c0")))]
        make_chan_struct!(2, 5);
        #[cfg(not(any(feature = "g0", feature = "wb", feature = "c0")))]
        make_chan_struct!(2, 6);
        #[cfg(not(any(feature = "g0", feature = "wb", feature = "c0")))]
        make_chan_struct!(2, 7);
        #[cfg(any(feature = "l5", feature = "g4"))]
        make_chan_struct!(2, 8);
    }
}