1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
use crate::core::config::Value;
use crate::core::parser::segments::base::{WhitespaceSegment, WhitespaceSegmentNewArgs};
use crate::core::parser::segments::keyword::KeywordSegment;
use crate::core::rules::base::{CloneRule, ErasedRule, LintFix, LintResult, Rule};
use crate::core::rules::context::RuleContext;
use crate::core::rules::crawlers::{Crawler, SegmentSeekerCrawler};
use crate::helpers::ToErasedSegment;

#[derive(Clone, Debug, Default)]
pub struct RuleAM02 {}

impl Rule for RuleAM02 {
    fn load_from_config(&self, _config: &ahash::AHashMap<String, Value>) -> ErasedRule {
        RuleAM02::default().erased()
    }

    fn name(&self) -> &'static str {
        "ambiguous.union"
    }

    fn description(&self) -> &'static str {
        "Look for UNION keyword not immediately followed by DISTINCT or ALL"
    }

    fn crawl_behaviour(&self) -> Crawler {
        SegmentSeekerCrawler::new(["set_operator"].into()).into()
    }

    fn eval(&self, rule_cx: RuleContext) -> Vec<LintResult> {
        let supported_dialects = ["ansi", "hive", "mysql", "redshift"];
        if !supported_dialects.contains(&rule_cx.dialect.name) {
            return Vec::new();
        }

        let raw = rule_cx.segment.get_raw().unwrap();
        let raw_upper = raw.to_uppercase();

        if rule_cx.segment.get_raw().unwrap().contains("union")
            && !(raw_upper.contains("ALL") || raw_upper.contains("DISTINCT"))
        {
            let edits = vec![
                KeywordSegment::new("union".to_owned(), None).to_erased_segment(),
                WhitespaceSegment::create(" ", &<_>::default(), WhitespaceSegmentNewArgs),
                KeywordSegment::new("distinct".to_owned(), None).to_erased_segment(),
            ];

            let segments = rule_cx.segment.clone();
            let fixes = vec![LintFix::replace(rule_cx.segment.segments()[0].clone(), edits, None)];

            return vec![LintResult::new(Some(segments), fixes, None, None, None)];
        } else if raw_upper.contains("UNION")
            && !(raw_upper.contains("ALL") || raw_upper.contains("DISTINCT"))
        {
            let edits = vec![
                KeywordSegment::new("UNION".to_owned(), None).to_erased_segment(),
                WhitespaceSegment::create(" ", &<_>::default(), WhitespaceSegmentNewArgs),
                KeywordSegment::new("DISTINCT".to_owned(), None).to_erased_segment(),
            ];

            let segments = rule_cx.segment.clone();
            let fixes = vec![LintFix::replace(rule_cx.segment.segments()[0].clone(), edits, None)];

            return vec![LintResult::new(Some(segments), fixes, None, None, None)];
        }

        Vec::new()
    }
}

#[cfg(test)]
mod tests {
    use pretty_assertions::assert_eq;

    use crate::api::simple::{fix, lint};
    use crate::core::rules::base::{Erased, ErasedRule};
    use crate::rules::ambiguous::AM02::RuleAM02;

    fn rules() -> Vec<ErasedRule> {
        vec![RuleAM02::default().erased()]
    }

    #[test]
    fn test_pass_union_all() {
        let sql = "SELECT
          a,
          b
        FROM tbl
          UNION ALL
        SELECT
          c,
          d
        FROM tbl1";

        let violations = lint(sql.into(), "ansi".into(), rules(), None, None).unwrap();
        assert_eq!(violations, []);
    }

    #[test]
    fn test_fail_bare_union() {
        let fail_str = "
            SELECT
              a,
              b
            FROM tbl
            UNION
            SELECT
              c,
              d
            FROM tbl1
        ";
        let fix_str = "
            SELECT
              a,
              b
            FROM tbl
            UNION DISTINCT
            SELECT
              c,
              d
            FROM tbl1
        ";

        let actual = fix(fail_str.into(), rules());
        assert_eq!(fix_str, actual);
    }

    #[test]
    fn test_pass_union_distinct() {
        let sql = "SELECT
          a,
          b
        FROM tbl
          UNION DISTINCT
        SELECT
          c,
          d
        FROM tbl1";

        let violations = lint(sql.into(), "ansi".into(), rules(), None, None).unwrap();
        assert_eq!(violations, []);
    }

    #[test]
    fn test_pass_union_distinct_with_comment() {
        let sql = "SELECT
          a,
          b
        FROM tbl

        --selecting a and b

        UNION DISTINCT

        SELECT
          c,
          d
        FROM tbl1";

        let violations = lint(sql.into(), "ansi".into(), rules(), None, None).unwrap();
        assert_eq!(violations, []);
    }

    #[test]
    fn test_fail_triple_join_with_one_bad() {
        let fail_str = "
            SELECT
              a,
              b
            FROM tbl
            UNION DISTINCT
            SELECT
              c,
              d
            FROM tbl1
            UNION
            SELECT
              e,
              f
            FROM tbl2
        ";
        let fix_str = "
            SELECT
              a,
              b
            FROM tbl
            UNION DISTINCT
            SELECT
              c,
              d
            FROM tbl1
            UNION DISTINCT
            SELECT
              e,
              f
            FROM tbl2
        ";

        let actual = fix(fail_str.into(), rules());
        assert_eq!(fix_str, actual);
    }

    #[test]
    fn test_fail_triple_join_with_one_bad_lowercase() {
        let fail_str = "
            select
              a,
              b
            from tbl
            union distinct
            select
              c,
              d
            from tbl1
            union
            select
              e,
              f
            from tbl2
        ";
        let fix_str = "
            select
              a,
              b
            from tbl
            union distinct
            select
              c,
              d
            from tbl1
            union distinct
            select
              e,
              f
            from tbl2
        ";

        let actual = fix(fail_str.into(), rules());
        assert_eq!(fix_str, actual);
    }
}