1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182

use crate::core::config::Value;
use crate::core::rules::base::{Erased, ErasedRule, LintFix, LintResult, Rule};
use crate::core::rules::context::RuleContext;
use crate::core::rules::crawlers::{Crawler, SegmentSeekerCrawler};
use crate::utils::functional::context::FunctionalContext;

#[derive(Default, Clone, Debug)]
pub struct RuleAL09 {}

impl Rule for RuleAL09 {
    fn name(&self) -> &'static str {
        "aliasing.self_alias.column"
    }

    fn description(&self) -> &'static str {
        "Find self-aliased columns and fix them"
    }

    fn load_from_config(&self, _config: &ahash::AHashMap<String, Value>) -> ErasedRule {
        RuleAL09::default().erased()
    }

    fn eval(&self, context: RuleContext) -> Vec<LintResult> {
        let mut violations = Vec::new();

        let children = FunctionalContext::new(context).segment().children(None);

        for clause_element in
            children.select(Some(|sp| sp.is_type("select_clause_element")), None, None, None)
        {
            let clause_element_raw_segment = clause_element.get_raw_segments();

            let column = clause_element.child(&["column_reference"]);
            let alias_expression = clause_element.child(&["alias_expression"]);

            if let Some(column) = column {
                if let Some(alias_expression) = alias_expression {
                    if column.child(&["identifier", "naked_identifier"]).is_some()
                        || column.child(&["quoted_identifier"]).is_some()
                    {
                        let whitespace = clause_element.child(&["whitespace"]).unwrap();

                        let column_identifier =
                            if let Some(quoted_identifier) = column.child(&["quoted_identifier"]) {
                                quoted_identifier.clone()
                            } else {
                                column
                                    .children(&["identifier", "naked_identifier"])
                                    .last()
                                    .expect("No naked_identifier found")
                                    .clone()
                            };

                        let alias_identifier = alias_expression
                            .child(&["naked_identifier"])
                            .or_else(|| alias_expression.child(&["quoted_identifier"]))
                            .expect("identifier is none");

                        if column_identifier.get_raw_upper() == alias_identifier.get_raw_upper() {
                            let fixes = vec![
                                LintFix::delete(whitespace),
                                LintFix::delete(alias_expression),
                            ];

                            violations.push(LintResult::new(
                                Some(clause_element_raw_segment[0].clone()),
                                fixes,
                                None,
                                Some("Column should not be self-aliased.".into()),
                                None,
                            ));
                        }
                    }
                }
            }
        }

        violations
    }

    fn crawl_behaviour(&self) -> Crawler {
        SegmentSeekerCrawler::new(["select_clause"].into()).into()
    }
}

#[cfg(test)]
mod tests {
    use pretty_assertions::assert_eq;

    use crate::api::simple::{fix, lint};
    use crate::core::rules::base::{Erased, ErasedRule};
    use crate::rules::aliasing::AL09::RuleAL09;

    fn rules() -> Vec<ErasedRule> {
        vec![RuleAL09::default().erased()]
    }

    #[test]
    pub fn test_pass_no_alias() {
        let sql = "SELECT col_a, col_b FROM foo";
        let violations = lint(sql.into(), "ansi".into(), rules(), None, None).unwrap();

        assert_eq!(violations, []);
    }

    #[test]
    pub fn test_pass_no_self_alias() {
        let sql = "select col_a, col_b as new_col_b from foo";
        let violations = lint(sql.into(), "ansi".into(), rules(), None, None).unwrap();

        assert_eq!(violations, []);
    }

    #[test]
    pub fn test_pass_no_self_alias_function() {
        let sql = "select max(sum) as max_sum from foo";
        let violations = lint(sql.into(), "ansi".into(), rules(), None, None).unwrap();

        assert_eq!(violations, []);
    }

    #[test]
    pub fn test_fail_self_alias() {
        let fail_str = "select col_a as col_a, col_b as new_col_b from foo";
        let fix_str = "select col_a, col_b as new_col_b from foo";

        let result = fix(fail_str.into(), rules());
        assert_eq!(fix_str, result);
    }

    #[test]
    pub fn test_fail_self_alias_upper() {
        let fail_str = "select col_a as COL_A, col_b as new_col_b from foo";
        let fix_str = "select col_a, col_b as new_col_b from foo";

        let result = fix(fail_str.into(), rules());
        assert_eq!(fix_str, result);
    }

    #[test]
    pub fn test_fail_self_alias_implicit() {
        let fail_str = "select col_a col_a, col_b AS new_col_b from foo";
        let fix_str = "select col_a, col_b AS new_col_b from foo";

        let result = fix(fail_str.into(), rules());
        assert_eq!(fix_str, result);
    }

    #[test]
    pub fn test_fail_self_alias_and_table_aliased() {
        let fail_str = "select a.col_a as col_a, a.col_b as new_col_b from foo as a";
        let fix_str = "select a.col_a, a.col_b as new_col_b from foo as a";

        let result = fix(fail_str.into(), rules());
        assert_eq!(fix_str, result);
    }

    #[test]
    pub fn test_fail_self_alias_quoted() {
        let fail_str = r#"select "col_a" as "col_a", col_b as new_col_b from foo"#;
        let fix_str = r#"select "col_a", col_b as new_col_b from foo"#;

        let result = fix(fail_str.into(), rules());
        assert_eq!(fix_str, result);
    }

    #[test]
    pub fn test_pass_self_alias_case_insensitive() {
        let sql = r#"select "col_a" as col_a, col_b as new_col_b from foo"#;
        let violations = lint(sql.into(), "ansi".into(), rules(), None, None).unwrap();

        assert_eq!(violations, []);
    }

    #[test]
    pub fn test_pass_self_alias_case_sensitive() {
        let sql = r#"SELECT col_a AS "col_a", col_b AS new_col_b FROM foo"#;
        let violations = lint(sql.into(), "ansi".into(), rules(), None, None).unwrap();

        assert_eq!(violations, []);
    }
}