1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
use std::collections::hash_map::Entry;

use ahash::AHashMap;

use crate::core::config::Value;
use crate::core::parser::segments::base::ErasedSegment;
use crate::core::rules::base::{Erased, ErasedRule, LintResult, Rule};
use crate::core::rules::context::RuleContext;
use crate::core::rules::crawlers::{Crawler, SegmentSeekerCrawler};

#[derive(Debug, Default, Clone)]
pub struct RuleAL08 {}

impl Rule for RuleAL08 {
    fn load_from_config(&self, _config: &AHashMap<String, Value>) -> ErasedRule {
        RuleAL08::default().erased()
    }

    fn name(&self) -> &'static str {
        "layout.cte_newline"
    }

    fn description(&self) -> &'static str {
        "Column aliases should be unique within each clause."
    }

    fn eval(&self, context: RuleContext) -> Vec<LintResult> {
        let mut used_aliases = AHashMap::new();
        let mut violations = Vec::new();

        for clause_element in context.segment.children(&["select_clause_element"]) {
            let mut column_alias = None;

            if let Some(alias_expression) = clause_element.child(&["alias_expression"]) {
                for it in alias_expression.segments() {
                    if !it.is_code() || it.get_raw_upper().unwrap() == "AS" {
                        continue;
                    }

                    column_alias = it.clone().into();
                    break;
                }
            } else if let Some(column_reference) = clause_element.child(&["column_reference"]) {
                column_alias = column_reference.segments().last().cloned();
            }

            let Some(column_alias) = column_alias else { continue };

            let key = column_alias.get_raw_upper().unwrap().replace(['\"', '\'', '`'], "");

            match used_aliases.entry(key) {
                Entry::Occupied(entry) => {
                    let previous: &ErasedSegment = entry.get();

                    let alias = column_alias.get_raw().unwrap();
                    let line_no = previous.get_position_marker().unwrap().source_position().0;

                    violations.push(LintResult::new(
                        column_alias.clone().into(),
                        vec![],
                        None,
                        format!("Reuse of column alias '{alias}' from line {line_no}.").into(),
                        None,
                    ))
                }
                Entry::Vacant(entry) => _ = entry.insert(clause_element),
            };
        }

        violations
    }

    fn crawl_behaviour(&self) -> Crawler {
        SegmentSeekerCrawler::new(["select_clause"].into()).into()
    }
}

#[cfg(test)]
mod tests {
    use crate::api::simple::lint;
    use crate::core::rules::base::Erased;
    use crate::rules::aliasing::AL08::RuleAL08;

    #[test]
    fn test_fail_references() {
        let sql = "select foo, foo";
        let result =
            lint(sql.to_string(), "ansi".into(), vec![RuleAL08::default().erased()], None, None)
                .unwrap();

        assert_eq!(result[0].desc(), "Reuse of column alias 'foo' from line 1.");
        assert_eq!(result.len(), 1);
    }

    #[test]
    fn test_fail_aliases() {
        let sql = "select a as foo, b as foo";
        let result =
            lint(sql.to_string(), "ansi".into(), vec![RuleAL08::default().erased()], None, None)
                .unwrap();

        assert_eq!(result[0].desc(), "Reuse of column alias 'foo' from line 1.");
        assert_eq!(result.len(), 1);
    }

    #[test]
    fn test_fail_alias_refs() {
        let sql = "select foo, b as foo";
        let result =
            lint(sql.to_string(), "ansi".into(), vec![RuleAL08::default().erased()], None, None)
                .unwrap();

        assert_eq!(result[0].desc(), "Reuse of column alias 'foo' from line 1.");
        assert_eq!(result.len(), 1);
    }

    #[test]
    fn test_fail_locs() {
        let sql = "select foo, b as foo, c as bar, bar, d foo";
        let result =
            lint(sql.to_string(), "ansi".into(), vec![RuleAL08::default().erased()], None, None)
                .unwrap();

        assert_eq!(result[0].desc(), "Reuse of column alias 'foo' from line 1.");
        assert_eq!(result[1].desc(), "Reuse of column alias 'bar' from line 1.");
        assert_eq!(result[2].desc(), "Reuse of column alias 'foo' from line 1.");
        assert_eq!(result.len(), 3);
    }

    #[test]
    #[ignore = "snowflake"]
    fn test_fail_alias_quoted() {
        let sql = "select foo, b as \"foo\"";
        let result = lint(
            sql.to_string(),
            "the snowflake dialect is not implemented".into(),
            vec![RuleAL08::default().erased()],
            None,
            None,
        )
        .unwrap();

        dbg!(result);
    }

    #[test]
    fn test_fail_alias_case() {
        let sql = "select foo, b as FOO";
        let result =
            lint(sql.to_string(), "ansi".into(), vec![RuleAL08::default().erased()], None, None)
                .unwrap();

        assert_eq!(result[0].desc(), "Reuse of column alias 'FOO' from line 1.");
        assert_eq!(result.len(), 1);
    }

    #[test]
    fn test_fail_qualified() {
        let sql = "select a.foo, b as foo from a";
        let result =
            lint(sql.to_string(), "ansi".into(), vec![RuleAL08::default().erased()], None, None)
                .unwrap();

        assert_eq!(result[0].desc(), "Reuse of column alias 'foo' from line 1.");
        assert_eq!(result.len(), 1);
    }

    #[test]
    fn test_pass_table_names() {
        let sql = "select a.b, b.c, c.d from a, b, c";
        let result =
            lint(sql.to_string(), "ansi".into(), vec![RuleAL08::default().erased()], None, None)
                .unwrap();

        assert_eq!(result, []);
    }
}