1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
use ahash::AHashMap;

use crate::core::config::Value;
use crate::core::parser::segments::base::ErasedSegment;
use crate::core::rules::base::{Erased, ErasedRule, LintResult, Rule};
use crate::core::rules::context::RuleContext;
use crate::core::rules::crawlers::{Crawler, SegmentSeekerCrawler};
use crate::utils::functional::context::FunctionalContext;
use crate::utils::functional::segments::Segments;

#[derive(Debug, Clone)]
pub struct RuleAL03 {
    allow_scalar: bool,
}

impl Default for RuleAL03 {
    fn default() -> Self {
        Self { allow_scalar: true }
    }
}

impl Rule for RuleAL03 {
    fn load_from_config(&self, config: &AHashMap<String, Value>) -> ErasedRule {
        RuleAL03 {
            allow_scalar: config.get("allow_scalar").and_then(Value::as_bool).unwrap_or_default(),
        }
        .erased()
    }

    fn name(&self) -> &'static str {
        "aliasing.expression"
    }

    fn description(&self) -> &'static str {
        "Column expression without alias. Use explicit `AS` clause."
    }

    fn eval(&self, context: RuleContext) -> Vec<LintResult> {
        let functional_context = FunctionalContext::new(context.clone());
        let segment = functional_context.segment();
        let children = segment.children(None);

        if children.any(Some(|it| it.get_type() == "alias_expression")) {
            return Vec::new();
        }

        // # Ignore if it's a function with EMITS clause as EMITS is equivalent to AS
        // if (
        //     children.select(sp.is_type("function"))
        //     .children()
        //     .select(sp.is_type("emits_segment"))
        // ):
        //     return None

        if !children
            .children(None)
            .select(Some(|it| it.is_type("cast_expression")), None, None, None)
            .is_empty()
            && !children
                .children(None)
                .select(Some(|it| it.is_type("cast_expression")), None, None, None)
                .children(None)
                .any(Some(|it| it.is_type("function")))
        {
            return Vec::new();
        }

        let parent_stack = functional_context.parent_stack();

        if parent_stack
            .find_last(Some(|it| it.is_type("common_table_expression")))
            .children(None)
            .any(Some(|it| it.is_type("cte_column_list")))
        {
            return Vec::new();
        }

        let select_clause_children =
            children.select(Some(|it| !it.is_type("star")), None, None, None);
        let is_complex_clause = recursively_check_is_complex(select_clause_children);

        if !is_complex_clause {
            return Vec::new();
        }

        if self.allow_scalar {
            let immediate_parent = parent_stack.find_last(None);
            let elements =
                immediate_parent.children(Some(|it| it.is_type("select_clause_element")));

            if elements.len() > 1 {
                return vec![LintResult::new(context.segment.into(), Vec::new(), None, None, None)];
            }
            return Vec::new();
        }

        vec![LintResult::new(context.segment.into(), Vec::new(), None, None, None)]
    }

    fn crawl_behaviour(&self) -> Crawler {
        SegmentSeekerCrawler::new(["select_clause_element"].into()).into()
    }
}

fn recursively_check_is_complex(select_clause_or_exp_children: Segments) -> bool {
    let selector: Option<fn(&ErasedSegment) -> bool> = Some(|it: &ErasedSegment| {
        !matches!(
            it.get_type(),
            "whitespace" | "newline" | "column_reference" | "wildcard_expression" | "bracketed"
        )
    });

    let filtered = select_clause_or_exp_children.select(selector, None, None, None);
    let remaining_count = filtered.len();

    if remaining_count == 0 {
        return false;
    }

    let first_el = filtered.find_first::<fn(&ErasedSegment) -> _>(None);

    if remaining_count > 1 || !first_el.all(Some(|it| it.is_type("expression"))) {
        return true;
    }

    recursively_check_is_complex(first_el.children(None))
}

#[cfg(test)]
mod tests {
    use crate::api::simple::lint;
    use crate::core::rules::base::{Erased, ErasedRule};
    use crate::rules::aliasing::AL03::RuleAL03;

    fn rules() -> Vec<ErasedRule> {
        vec![RuleAL03::default().erased()]
    }

    #[test]
    fn test_pass_column_exp_without_alias_1() {
        let violations = lint(
            "select ps.*, pandgs.blah from ps join pandgs using(moo)".into(),
            "ansi".into(),
            rules(),
            None,
            None,
        )
        .unwrap();
        assert_eq!(violations, []);
    }

    #[test]
    fn test_pass_column_exp_without_alias_allow_scalar_true() {
        let violations =
            lint("SELECT 1 from blah".into(), "ansi".into(), rules(), None, None).unwrap();
        assert_eq!(violations, []);
    }

    #[test]
    fn test_fail_column_exp_without_alias() {
        let violations =
            lint("SELECT upper(foo), bar from blah".into(), "ansi".into(), rules(), None, None)
                .unwrap();

        assert_eq!(violations.len(), 1);
        assert_eq!(violations[0].line_no, 1);
        assert_eq!(violations[0].line_pos, 8);
        assert_eq!(
            violations[0].desc(),
            "Column expression without alias. Use explicit `AS` clause."
        );
    }

    #[test]
    fn test_pass_column_exp_without_alias_if_only_cast() {
        let violations = lint(
            "SELECT foo_col::VARCHAR(28) , bar from blah".into(),
            "ansi".into(),
            rules(),
            None,
            None,
        )
        .unwrap();
        assert_eq!(violations, []);
    }

    #[test]
    fn test_pass_column_exp_without_alias_if_only_cast_inc_double_cast() {
        let violations = lint(
            "SELECT foo_col::INT::VARCHAR , bar from blah".into(),
            "ansi".into(),
            rules(),
            None,
            None,
        )
        .unwrap();
        assert_eq!(violations, []);
    }

    #[test]
    fn test_pass_column_exp_without_alias_if_bracketed() {
        let violations = lint(
            "SELECT (foo_col::INT)::VARCHAR , bar from blah".into(),
            "ansi".into(),
            rules(),
            None,
            None,
        )
        .unwrap();
        assert_eq!(violations, []);
    }

    #[test]
    fn test_fail_column_exp_without_alias_and_cast_fn() {
        let violations = lint(
            "SELECT CAST(foo_col AS INT)::VARCHAR , bar from blah".into(),
            "ansi".into(),
            rules(),
            None,
            None,
        )
        .unwrap();
        assert_ne!(violations, []);
    }

    #[test]
    #[ignore = "CONFIG"]
    fn test_fail_column_exp_without_alias_allow_scalar_false() {
        // Some(json!({ "rules": { "allow_scalar": false } }))

        let violations =
            lint("SELECT 1 from blah".into(), "ansi".into(), rules(), None, None).unwrap();
        assert_ne!(violations, []);
    }

    #[test]
    fn test_pass_column_exp_with_alias() {
        let violations = lint(
            "SELECT upper(foo) as foo_up, bar from blah".into(),
            "ansi".into(),
            rules(),
            None,
            None,
        )
        .unwrap();
        assert_eq!(violations, []);
    }
}