sqlite_graphrag/commands/

merge_entities.rs

//! Handler for the `merge-entities` CLI subcommand (GAP-19).
//!
//! Merges two or more source entities into a single target entity by:
//!   1. Retargeting all relationships pointing at any source to the target.
//!   2. Deduplicating relationships that become identical after the merge
//!      (same source_id + target_id + relation).
//!   3. Retargeting memory_entities bindings.
//!   4. Deleting the now-empty source entity rows.

use crate::errors::AppError;
use crate::i18n::errors_msg;
use crate::output::{self, OutputFormat};
use crate::paths::AppPaths;
use crate::storage::connection::open_rw;
use crate::storage::entities;
use rusqlite::params;
use serde::Serialize;

#[derive(clap::Args)]
#[command(after_long_help = "EXAMPLES:\n  \
    # Merge two source entities into a target\n  \
    sqlite-graphrag merge-entities --names auth,authentication --into auth-service\n\n  \
    # Merge three sources into one target across a namespace\n  \
    sqlite-graphrag merge-entities --names svc-a,svc-b,old-svc --into canonical-service --namespace my-project\n\n  \
    # Merge by ID (unambiguous when homonyms exist across namespaces)\n  \
    sqlite-graphrag merge-entities --ids 12,17 --into-id 3\n\n\
NOTE:\n  \
    --names is a comma-separated list of source entity names.\n  \
    --into is the target entity name and must already exist.\n  \
    --ids / --into-id select entities by ID; IDs are globally unique so they\n  \
    disambiguate homonyms. They conflict with --names / --into respectively\n  \
    and must belong to the resolved namespace.\n  \
    Source entities are deleted after the merge; the target is preserved.\n  \
    Duplicate relationships (same endpoints + relation) are removed automatically.\n  \
    Run `sqlite-graphrag cleanup-orphans` afterwards if sources had no other links.")]
/// Merge entities args.
pub struct MergeEntitiesArgs {
    /// Comma-separated list of source entity names to merge into the target.
    #[arg(
        long,
        value_delimiter = ',',
        value_name = "NAMES",
        required_unless_present = "ids",
        conflicts_with = "ids"
    )]
    pub names: Vec<String>,
    /// v1.1.1 (P5): comma-separated list of source entity IDs. IDs are
    /// globally unique, so they disambiguate homonyms across namespaces.
    /// Conflicts with --names; every ID must belong to the resolved namespace.
    #[arg(long, value_delimiter = ',', value_name = "IDS")]
    pub ids: Vec<i64>,
    /// Target entity name. Must already exist. All source relationships are redirected here.
    #[arg(
        long,
        value_name = "TARGET",
        required_unless_present = "into_id",
        conflicts_with = "into_id"
    )]
    pub into: Option<String>,
    /// v1.1.1 (P5): target entity ID. Unambiguous alternative to --into.
    #[arg(long, value_name = "TARGET_ID")]
    pub into_id: Option<i64>,
    /// Namespace scope.
    #[arg(long)]
    pub namespace: Option<String>,
    /// Output format.
    #[arg(long, value_enum, default_value = "json")]
    pub format: OutputFormat,
    /// Emit machine-readable JSON on stdout.
    #[arg(long, hide = true, help = "No-op; JSON is always emitted on stdout")]
    pub json: bool,
    /// Path to the SQLite database file.
    #[arg(long)]
    pub db: Option<String>,
    /// v1.1.03: allow merging source entities from OTHER namespaces into the
    /// target. Default false preserves same-namespace safety. When true, each
    /// --ids source is resolved by its own row (no namespace filter); target
    /// must still exist in the resolved namespace.
    #[arg(long, default_value_t = false, hide = false)]
    pub cross_namespace: bool,
}

#[derive(Serialize)]
struct MergeEntitiesResponse {
    action: String,
    sources: Vec<String>,
    target: String,
    namespace: String,
    /// v1.1.1 (P5): resolved target entity ID, echoed for unambiguous auditing.
    target_id: i64,
    relationships_moved: usize,
    entities_removed: usize,
    /// Total execution time in milliseconds from handler start to serialisation.
    elapsed_ms: u64,
}

/// v1.1.1 (P5): resolves an entity ID to its name. When `enforce_namespace`
/// is true (default behaviour, same-namespace safety), the lookup also enforces
/// that the entity belongs to `namespace` — IDs are global, so a bare existence
/// check could silently cross namespaces. When false (v1.1.03 cross-namespace
/// merge), the lookup resolves the entity by its own row and returns the
/// namespace it actually lives in, so callers can audit the cross-namespace move.
fn find_entity_name_by_id(
    conn: &rusqlite::Connection,
    namespace: &str,
    id: i64,
    enforce_namespace: bool,
) -> Result<(String, String), AppError> {
    let mut stmt = if enforce_namespace {
        conn.prepare_cached(
            "SELECT name, namespace FROM entities WHERE id = ?1 AND namespace = ?2",
        )?
    } else {
        conn.prepare_cached("SELECT name, namespace FROM entities WHERE id = ?1")?
    };
    let row = if enforce_namespace {
        stmt.query_row(params![id, namespace], |r| {
            Ok((r.get::<_, String>(0)?, r.get::<_, String>(1)?))
        })
    } else {
        stmt.query_row(params![id], |r| {
            Ok((r.get::<_, String>(0)?, r.get::<_, String>(1)?))
        })
    };
    match row {
        Ok((name, ns_actual)) => Ok((name, ns_actual)),
        Err(rusqlite::Error::QueryReturnedNoRows) => Err(AppError::NotFound(format!(
            "entity id={id} not found in namespace '{namespace}'"
        ))),
        Err(e) => Err(AppError::Database(e)),
    }
}

/// Run.
pub fn run(args: MergeEntitiesArgs) -> Result<(), AppError> {
    let inicio = std::time::Instant::now();

    if args.names.is_empty() && args.ids.is_empty() {
        return Err(AppError::Validation(
            "--names or --ids must contain at least one source entity".to_string(),
        ));
    }

    // v1.1.05 Bug 4: reject self-referential merge at the earliest possible
    // point (before any DB work), so shell word-splitting mistakes fail loud.
    if let Some(target_id) = args.into_id {
        if args.ids.contains(&target_id) {
            return Err(AppError::Validation(
                crate::i18n::validation::self_merge_id_in_ids(target_id),
            ));
        }
    }
    if let Some(ref target_name) = args.into {
        if args.names.iter().any(|n| n == target_name) {
            return Err(AppError::Validation(
                crate::i18n::validation::self_merge_name_in_names(target_name),
            ));
        }
    }

    let namespace = crate::namespace::resolve_namespace(args.namespace.as_deref())?;
    let paths = AppPaths::resolve(args.db.as_deref())?;

    crate::storage::connection::ensure_db_ready(&paths)?;

    let mut conn = open_rw(&paths.db)?;

    // Resolve target entity — by ID (v1.1.1 P5, unambiguous) or by name.
    // Existence is validated here, BEFORE any mutation.
    let (target_id, target_name) = match args.into_id {
        Some(id) => {
            // Target is always validated in the resolved namespace, even when
            // --cross-namespace is set: cross-namespace only relaxes SOURCES.
            let (name, _ns_actual) = find_entity_name_by_id(&conn, &namespace, id, true)?;
            (id, name)
        }
        None => {
            let Some(name) = args.into.clone() else {
                return Err(AppError::Validation(
                    "--into or --into-id is required".to_string(),
                ));
            };
            let id = entities::find_entity_id(&conn, &namespace, &name)?.ok_or_else(|| {
                AppError::NotFound(errors_msg::entity_not_found(&name, &namespace))
            })?;
            (id, name)
        }
    };

    // Resolve source entity IDs — reject self-referential merge (G21),
    // by ID (v1.1.1 P5) or by name. All lookups happen BEFORE the transaction.
    // Defense-in-depth: re-check even after early parse-time guard (Bug 4).
    let mut source_ids: Vec<i64> = Vec::with_capacity(args.names.len() + args.ids.len());
    let mut source_names: Vec<String> = Vec::with_capacity(source_ids.capacity());
    if !args.ids.is_empty() {
        for &id in &args.ids {
            if id == target_id {
                return Err(AppError::Validation(
                    crate::i18n::validation::self_merge_id(id, target_id),
                ));
            }
            // v1.1.03: when --cross-namespace is set, resolve each source by its
            // own row (no namespace filter) and warn on the cross-namespace move.
            // Default (false) preserves same-namespace safety.
            let (name, ns_actual) =
                find_entity_name_by_id(&conn, &namespace, id, !args.cross_namespace)?;
            if args.cross_namespace && ns_actual != namespace {
                tracing::warn!(
                    target: "merge_entities",
                    from_id = id,
                    from_namespace = %ns_actual,
                    to_namespace = %namespace,
                    "cross-namespace merge"
                );
            }
            if !source_ids.contains(&id) {
                source_ids.push(id);
                source_names.push(name);
            }
        }
    } else {
        for name in &args.names {
            if name == &target_name {
                return Err(AppError::Validation(
                    crate::i18n::validation::self_merge_name(name, &target_name),
                ));
            }
            let id = entities::find_entity_id(&conn, &namespace, name)?.ok_or_else(|| {
                AppError::NotFound(errors_msg::entity_not_found(name, &namespace))
            })?;
            if id == target_id {
                return Err(AppError::Validation(
                    crate::i18n::validation::self_merge_name_resolves_to_target(name, target_id),
                ));
            }
            if !source_ids.contains(&id) {
                source_ids.push(id);
                source_names.push(name.clone());
            }
        }
    }

    if source_ids.is_empty() {
        return Err(AppError::Validation(
            "no valid source entities to merge (all names equal the target or were duplicates)"
                .to_string(),
        ));
    }

    let tx = conn.transaction_with_behavior(rusqlite::TransactionBehavior::Immediate)?;

    let mut relationships_moved: usize = 0;

    for &src_id in &source_ids {
        // Step 1a: redirect source_id, ignoring UNIQUE conflicts.
        let moved_src = tx.execute(
            "UPDATE OR IGNORE relationships SET source_id = ?1 WHERE source_id = ?2",
            params![target_id, src_id],
        )?;
        tx.execute(
            "DELETE FROM relationships WHERE source_id = ?1",
            params![src_id],
        )?;
        // Step 1b: redirect target_id, ignoring UNIQUE conflicts.
        let moved_tgt = tx.execute(
            "UPDATE OR IGNORE relationships SET target_id = ?1 WHERE target_id = ?2",
            params![target_id, src_id],
        )?;
        tx.execute(
            "DELETE FROM relationships WHERE target_id = ?1",
            params![src_id],
        )?;
        relationships_moved += moved_src + moved_tgt;
    }

    // Step 2: remove self-loops introduced by the redirect (target → target).
    tx.execute("DELETE FROM relationships WHERE source_id = target_id", [])?;

    // Step 3: deduplicate relationships that now share (source, target, relation).
    // Safety net — UPDATE OR IGNORE should have handled most duplicates above.
    tx.execute(
        "DELETE FROM relationships
         WHERE id NOT IN (
             SELECT MIN(id)
             FROM relationships
             GROUP BY source_id, target_id, relation
         )",
        [],
    )?;

    // Step 4: retarget memory_entities bindings.
    // Use UPDATE OR IGNORE to skip conflicts when memory is already bound to
    // target entity. Then DELETE remaining source rows (the conflicting ones
    // that UPDATE OR IGNORE skipped). Same pattern as relationships (Step 1).
    for &src_id in &source_ids {
        tx.execute(
            "UPDATE OR IGNORE memory_entities SET entity_id = ?1 WHERE entity_id = ?2",
            params![target_id, src_id],
        )?;
        tx.execute(
            "DELETE FROM memory_entities WHERE entity_id = ?1",
            params![src_id],
        )?;
    }

    // Step 5: deduplicate memory_entities bindings (same memory + entity).
    tx.execute(
        "DELETE FROM memory_entities
         WHERE rowid NOT IN (
             SELECT MIN(rowid)
             FROM memory_entities
             GROUP BY memory_id, entity_id
         )",
        [],
    )?;

    // Step 6: delete source entities. v1.0.76: FK ON DELETE CASCADE on
    // entity_embeddings handles the vector row automatically.
    let mut entities_removed: usize = 0;
    for &src_id in &source_ids {
        let removed = tx.execute("DELETE FROM entities WHERE id = ?1", params![src_id])?;
        entities_removed += removed;
    }

    // Step 7: recalculate degree for target and all adjacent entities.
    let adjacent_ids: Vec<i64> = {
        let mut stmt = tx.prepare(
            "SELECT DISTINCT CASE WHEN source_id = ?1 THEN target_id ELSE source_id END
             FROM relationships WHERE source_id = ?1 OR target_id = ?1",
        )?;
        let ids: Vec<i64> = stmt
            .query_map(params![target_id], |r| r.get(0))?
            .collect::<Result<Vec<_>, _>>()?;
        ids
    };
    entities::recalculate_degree(&tx, target_id)?;
    for &adj_id in &adjacent_ids {
        entities::recalculate_degree(&tx, adj_id)?;
    }

    tx.commit()?;

    conn.execute_batch("PRAGMA wal_checkpoint(TRUNCATE);")?;

    let response = MergeEntitiesResponse {
        action: "merged".to_string(),
        sources: source_names,
        target: target_name,
        namespace: namespace.clone(),
        target_id,
        relationships_moved,
        entities_removed,
        elapsed_ms: inicio.elapsed().as_millis() as u64,
    };

    match args.format {
        OutputFormat::Json => output::emit_json(&response)?,
        OutputFormat::Text | OutputFormat::Markdown => {
            output::emit_text(&format!(
                "merged: {} sources into '{}' (relationships_moved={}, entities_removed={}) [{}]",
                response.sources.len(),
                response.target,
                response.relationships_moved,
                response.entities_removed,
                response.namespace
            ));
        }
    }

    Ok(())
}

#[cfg(test)]
mod tests {
    use super::*;

    // v1.1.1 (P5): ID resolution is namespace-scoped — a homonym in another
    // namespace must NOT be reachable through its ID from the wrong namespace.
    #[test]
    fn find_entity_name_by_id_disambiguates_homonyms_across_namespaces() {
        let conn = rusqlite::Connection::open_in_memory().unwrap();
        conn.execute_batch(
            "CREATE TABLE entities (
                id INTEGER PRIMARY KEY,
                namespace TEXT NOT NULL,
                name TEXT NOT NULL,
                UNIQUE(namespace, name)
            );",
        )
        .unwrap();
        conn.execute(
            "INSERT INTO entities (id, namespace, name)
             VALUES (1, 'ns-a', 'auth'), (2, 'ns-b', 'auth')",
            [],
        )
        .unwrap();

        // Same name in two namespaces: each ID resolves only in its own.
        assert_eq!(
            find_entity_name_by_id(&conn, "ns-a", 1, true).unwrap(),
            ("auth".to_string(), "ns-a".to_string())
        );
        assert_eq!(
            find_entity_name_by_id(&conn, "ns-b", 2, true).unwrap(),
            ("auth".to_string(), "ns-b".to_string())
        );
        let err = find_entity_name_by_id(&conn, "ns-a", 2, true).unwrap_err();
        assert_eq!(err.exit_code(), 4, "cross-namespace ID must be NotFound");
        assert!(err.to_string().contains("id=2"), "obtido: {err}");

        // v1.1.03: with enforce_namespace=false, id=2 resolves from any
        // namespace and reports the namespace it actually lives in.
        let (name, ns_actual) = find_entity_name_by_id(&conn, "ns-a", 2, false).unwrap();
        assert_eq!(name, "auth");
        assert_eq!(ns_actual, "ns-b");
    }

    #[test]
    fn find_entity_name_by_id_missing_id_is_not_found() {
        let conn = rusqlite::Connection::open_in_memory().unwrap();
        conn.execute_batch(
            "CREATE TABLE entities (
                id INTEGER PRIMARY KEY,
                namespace TEXT NOT NULL,
                name TEXT NOT NULL
            );",
        )
        .unwrap();
        let err = find_entity_name_by_id(&conn, "global", 99, true).unwrap_err();
        assert_eq!(err.exit_code(), 4);
    }

    // v1.1.1 (P5): clap-level exclusivity between name-based and ID-based
    // selectors, and requiredness of at least one selector per side.
    #[derive(clap::Parser)]
    struct TestCli {
        #[command(flatten)]
        args: MergeEntitiesArgs,
    }

    #[test]
    fn clap_rejects_names_combined_with_ids() {
        use clap::Parser;
        let err =
            match TestCli::try_parse_from(["t", "--names", "a,b", "--ids", "1,2", "--into", "tgt"])
            {
                Ok(_) => panic!("expected argument conflict"),
                Err(e) => e,
            };
        assert_eq!(err.kind(), clap::error::ErrorKind::ArgumentConflict);
    }

    #[test]
    fn clap_rejects_into_combined_with_into_id() {
        use clap::Parser;
        let err =
            match TestCli::try_parse_from(["t", "--names", "a", "--into", "tgt", "--into-id", "3"])
            {
                Ok(_) => panic!("expected argument conflict"),
                Err(e) => e,
            };
        assert_eq!(err.kind(), clap::error::ErrorKind::ArgumentConflict);
    }

    /// v1.1.05 Bug 4: clap value_delimiter must keep target id out of sources
    /// when the operator writes `--ids 35575,35340 --into-id 35340` — the
    /// early self-ref guard must fire without needing a live database.
    #[test]
    fn self_referential_ids_rejected_before_db() {
        let args = MergeEntitiesArgs {
            names: vec![],
            ids: vec![35575, 35340],
            into: None,
            into_id: Some(35340),
            namespace: Some("global".into()),
            format: OutputFormat::Json,
            json: false,
            db: Some("/nonexistent/no-db.sqlite".into()),
            cross_namespace: true,
        };
        let err = run(args).expect_err("self-ref must fail");
        assert_eq!(err.exit_code(), 1, "validation exit");
        let msg = err.to_string();
        assert!(
            msg.contains("self-referential") || msg.contains("35340"),
            "expected self-ref message, got: {msg}"
        );
    }

    #[test]
    fn clap_parses_ids_with_target_in_list() {
        use clap::Parser;
        let ok = TestCli::try_parse_from([
            "t",
            "--ids",
            "35575,35340",
            "--into-id",
            "35340",
            "--cross-namespace",
        ])
        .expect("must parse");
        assert_eq!(ok.args.ids, vec![35575, 35340]);
        assert_eq!(ok.args.into_id, Some(35340));
        assert!(ok.args.cross_namespace);
    }

    #[test]
    fn clap_requires_a_source_and_a_target_selector() {
        use clap::Parser;
        assert!(TestCli::try_parse_from(["t", "--into", "tgt"]).is_err());
        assert!(TestCli::try_parse_from(["t", "--names", "a"]).is_err());
        let ok = match TestCli::try_parse_from(["t", "--ids", "1,2", "--into-id", "3"]) {
            Ok(cli) => cli,
            Err(e) => panic!("expected successful parse: {e}"),
        };
        assert_eq!(ok.args.ids, vec![1, 2]);
        assert_eq!(ok.args.into_id, Some(3));
        assert!(ok.args.names.is_empty());
        assert!(ok.args.into.is_none());
    }

    #[test]
    fn merge_entities_response_serializes_all_fields() {
        let resp = MergeEntitiesResponse {
            action: "merged".to_string(),
            sources: vec!["auth".to_string(), "authentication".to_string()],
            target: "auth-service".to_string(),
            namespace: "global".to_string(),
            target_id: 1,
            relationships_moved: 7,
            entities_removed: 2,
            elapsed_ms: 15,
        };
        let json = serde_json::to_value(&resp).expect("serialization failed");
        assert_eq!(json["action"], "merged");
        assert_eq!(json["target"], "auth-service");
        assert_eq!(json["namespace"], "global");
        assert_eq!(json["relationships_moved"], 7);
        assert_eq!(json["entities_removed"], 2);
        let sources = json["sources"].as_array().expect("must be array");
        assert_eq!(sources.len(), 2);
        assert!(json["elapsed_ms"].is_number());
    }

    #[test]
    fn merge_entities_response_action_is_merged() {
        let resp = MergeEntitiesResponse {
            action: "merged".to_string(),
            sources: vec!["src".to_string()],
            target: "tgt".to_string(),
            namespace: "ns".to_string(),
            target_id: 1,
            relationships_moved: 0,
            entities_removed: 1,
            elapsed_ms: 0,
        };
        assert_eq!(resp.action, "merged");
    }

    #[test]
    fn merge_entities_response_empty_sources_serializes() {
        let resp = MergeEntitiesResponse {
            action: "merged".to_string(),
            sources: vec![],
            target: "target".to_string(),
            namespace: "global".to_string(),
            target_id: 1,
            relationships_moved: 0,
            entities_removed: 0,
            elapsed_ms: 1,
        };
        let json = serde_json::to_value(&resp).expect("serialization failed");
        let sources = json["sources"].as_array().expect("must be array");
        assert_eq!(sources.len(), 0);
    }

    #[test]
    fn merge_entities_response_with_zero_relationships_moved() {
        let resp = MergeEntitiesResponse {
            action: "merged".to_string(),
            sources: vec!["src-a".to_string()],
            target: "tgt".to_string(),
            namespace: "global".to_string(),
            target_id: 1,
            relationships_moved: 0,
            entities_removed: 1,
            elapsed_ms: 5,
        };
        let json = serde_json::to_value(&resp).expect("serialization failed");
        assert_eq!(json["relationships_moved"], 0);
        assert_eq!(json["entities_removed"], 1);
    }

    #[test]
    fn merge_entities_response_multiple_sources() {
        let resp = MergeEntitiesResponse {
            action: "merged".to_string(),
            sources: vec!["a".into(), "b".into(), "c".into()],
            target: "canonical".to_string(),
            namespace: "proj".to_string(),
            target_id: 1,
            relationships_moved: 12,
            entities_removed: 3,
            elapsed_ms: 42,
        };
        let json = serde_json::to_value(&resp).expect("serialization failed");
        assert_eq!(json["entities_removed"], 3);
        let sources = json["sources"].as_array().unwrap();
        assert_eq!(sources.len(), 3);
    }

    // v1.1.03: integration setup — a fully migrated DB on disk so run() can
    // open it via AppPaths + open_rw. Returns the tempdir (kept alive for the
    // test lifetime), the seeded connection, and the DB file path.
    fn setup_migrated_db_on_disk() -> (tempfile::TempDir, rusqlite::Connection, std::path::PathBuf)
    {
        crate::storage::connection::register_vec_extension();
        let tmp = tempfile::TempDir::new().expect("tempdir");
        let db_path = tmp.path().join("test.db");
        let mut conn = rusqlite::Connection::open(&db_path).expect("open");
        crate::migrations::runner().run(&mut conn).expect("migrate");
        (tmp, conn, db_path)
    }

    // v1.1.03 (Bug 3): --cross-namespace allows merging a source that lives in
    // a DIFFERENT namespace into the target. Relationships are retargeted and
    // the source row is deleted from its origin namespace.
    #[test]
    fn cross_namespace_merges_source_from_other_namespace() {
        let (_tmp, conn, db_path) = setup_migrated_db_on_disk();
        // Target lives in "global".
        conn.execute(
            "INSERT INTO entities (namespace, name, type) VALUES ('global','tgt','concept')",
            [],
        )
        .unwrap();
        let tgt_id = conn.last_insert_rowid();
        // Source lives in "ai-sdd" — a homonym in a different namespace.
        conn.execute(
            "INSERT INTO entities (namespace, name, type) VALUES ('ai-sdd','dup-src','concept')",
            [],
        )
        .unwrap();
        let src_id = conn.last_insert_rowid();
        // A third entity in "global" that the source points to, so the
        // retarget produces an observable relationship_moved > 0.
        conn.execute(
            "INSERT INTO entities (namespace, name, type) VALUES ('global','third','concept')",
            [],
        )
        .unwrap();
        let third_id = conn.last_insert_rowid();
        conn.execute(
            "INSERT INTO relationships (namespace, source_id, target_id, relation, weight) \
             VALUES ('ai-sdd', ?1, ?2, 'related', 0.5)",
            params![src_id, third_id],
        )
        .unwrap();
        // Drop the seeding connection so run() can open the DB exclusively.
        drop(conn);

        let args = MergeEntitiesArgs {
            names: vec![],
            ids: vec![src_id],
            into: None,
            into_id: Some(tgt_id),
            namespace: Some("global".to_string()),
            format: OutputFormat::Json,
            json: false,
            db: Some(db_path.to_string_lossy().into_owned()),
            cross_namespace: true,
        };
        run(args).expect("cross-namespace merge must succeed");

        // Reopen and verify: source deleted, relationship retargeted to target.
        let conn = rusqlite::Connection::open(&db_path).unwrap();
        let src_remaining: i64 = conn
            .query_row(
                "SELECT COUNT(*) FROM entities WHERE id = ?1",
                params![src_id],
                |r| r.get(0),
            )
            .unwrap();
        assert_eq!(src_remaining, 0, "cross-namespace source must be deleted");
        let moved: i64 = conn
            .query_row(
                "SELECT COUNT(*) FROM relationships WHERE source_id = ?1 AND target_id = ?2",
                params![tgt_id, third_id],
                |r| r.get(0),
            )
            .unwrap();
        assert!(
            moved > 0,
            "relationship must be retargeted to the target entity"
        );
    }

    // v1.1.03 (Bug 3): without --cross-namespace, a source ID from another
    // namespace is rejected with NotFound — preserves the same-namespace safety
    // (non-regression of the v1.1.1 P5 behaviour).
    #[test]
    fn cross_namespace_default_false_rejects_cross_id() {
        let (_tmp, conn, db_path) = setup_migrated_db_on_disk();
        conn.execute(
            "INSERT INTO entities (namespace, name, type) VALUES ('global','tgt','concept')",
            [],
        )
        .unwrap();
        let tgt_id = conn.last_insert_rowid();
        conn.execute(
            "INSERT INTO entities (namespace, name, type) VALUES ('ai-sdd','dup-src','concept')",
            [],
        )
        .unwrap();
        let src_id = conn.last_insert_rowid();
        drop(conn);

        let args = MergeEntitiesArgs {
            names: vec![],
            ids: vec![src_id],
            into: None,
            into_id: Some(tgt_id),
            namespace: Some("global".to_string()),
            format: OutputFormat::Json,
            json: false,
            db: Some(db_path.to_string_lossy().into_owned()),
            cross_namespace: false,
        };
        let err = run(args).expect_err("default must reject cross-namespace ID");
        assert_eq!(err.exit_code(), 4, "cross-namespace ID must be NotFound");
    }

    // v1.1.03 (Bug 3): even with --cross-namespace, the TARGET must still exist
    // in the resolved namespace — cross-namespace only relaxes SOURCES.
    #[test]
    fn cross_namespace_target_must_still_be_in_resolved_namespace() {
        let (_tmp, conn, db_path) = setup_migrated_db_on_disk();
        // Target lives in "ai-sdd", but we will resolve namespace to "global".
        conn.execute(
            "INSERT INTO entities (namespace, name, type) VALUES ('ai-sdd','tgt','concept')",
            [],
        )
        .unwrap();
        let tgt_id = conn.last_insert_rowid();
        conn.execute(
            "INSERT INTO entities (namespace, name, type) VALUES ('global','src','concept')",
            [],
        )
        .unwrap();
        let src_id = conn.last_insert_rowid();
        drop(conn);

        let args = MergeEntitiesArgs {
            names: vec![],
            ids: vec![src_id],
            into: None,
            into_id: Some(tgt_id),
            namespace: Some("global".to_string()),
            format: OutputFormat::Json,
            json: false,
            db: Some(db_path.to_string_lossy().into_owned()),
            cross_namespace: true,
        };
        let err = run(args).expect_err("target in wrong namespace must fail");
        assert_eq!(
            err.exit_code(),
            4,
            "target must still be NotFound in the resolved namespace"
        );
    }
}