sql_cli/sql/parser/expressions/
primary.rs

1// Primary expression parsing
2// Handles literals, identifiers, function calls, and parenthesized expressions
3
4use crate::sql::parser::ast::{ColumnRef, SqlExpression, WindowSpec};
5use crate::sql::parser::lexer::Token;
6use tracing::{debug, trace};
7
8use super::{log_parse_decision, trace_parse_entry, trace_parse_exit, ExpressionParser};
9
10/// Parser context for primary expressions
11pub struct PrimaryExpressionContext<'a> {
12    pub columns: &'a [String],
13    pub in_method_args: bool,
14}
15
16impl<'a> Default for PrimaryExpressionContext<'a> {
17    fn default() -> Self {
18        Self {
19            columns: &[],
20            in_method_args: false,
21        }
22    }
23}
24
25/// Parse a primary expression (literals, identifiers, functions, parentheses)
26/// This is the bottom of the expression hierarchy
27pub fn parse_primary<P>(
28    parser: &mut P,
29    ctx: &PrimaryExpressionContext,
30) -> Result<SqlExpression, String>
31where
32    P: ParsePrimary + ExpressionParser + ?Sized,
33{
34    trace_parse_entry("parse_primary", ExpressionParser::current_token(parser));
35
36    // Special case: check if a number literal could actually be a column name
37    // This handles cases where columns are named with pure numbers like "202204"
38    if let Token::NumberLiteral(num_str) = ExpressionParser::current_token(parser) {
39        if ctx.columns.iter().any(|col| col == num_str) {
40            log_parse_decision(
41                "parse_primary",
42                ExpressionParser::current_token(parser),
43                "Number literal matches column name, treating as column",
44            );
45            let expr = SqlExpression::Column(ColumnRef::unquoted(num_str.clone()));
46            ExpressionParser::advance(parser);
47            let result = Ok(expr);
48            trace_parse_exit("parse_primary", &result);
49            return result;
50        }
51    }
52
53    let result = match ExpressionParser::current_token(parser) {
54        Token::Case => {
55            debug!("Parsing CASE expression");
56            parser.parse_case_expression()
57        }
58
59        Token::DateTime => {
60            debug!("Parsing DateTime constructor");
61            parse_datetime_constructor(parser)
62        }
63
64        Token::Unnest => {
65            debug!("Parsing UNNEST expression");
66            parse_unnest(parser)
67        }
68
69        Token::Identifier(id) => {
70            let id_upper = id.to_uppercase();
71            let id_clone = id.clone();
72
73            // Check for boolean literals first
74            if id_upper == "TRUE" {
75                log_parse_decision(
76                    "parse_primary",
77                    ExpressionParser::current_token(parser),
78                    "Boolean literal TRUE",
79                );
80                ExpressionParser::advance(parser);
81                Ok(SqlExpression::BooleanLiteral(true))
82            } else if id_upper == "FALSE" {
83                log_parse_decision(
84                    "parse_primary",
85                    ExpressionParser::current_token(parser),
86                    "Boolean literal FALSE",
87                );
88                ExpressionParser::advance(parser);
89                Ok(SqlExpression::BooleanLiteral(false))
90            } else {
91                ExpressionParser::advance(parser);
92
93                // Check for table.column notation or method calls
94                if matches!(ExpressionParser::current_token(parser), Token::Dot) {
95                    ExpressionParser::advance(parser); // consume dot
96
97                    if let Token::Identifier(next_id) = ExpressionParser::current_token(parser) {
98                        let next_id = next_id.clone();
99                        ExpressionParser::advance(parser);
100
101                        // Check if this is a method call (followed by parentheses)
102                        if matches!(ExpressionParser::current_token(parser), Token::LeftParen) {
103                            debug!(object = %id_clone, method = %next_id, "Parsing method call");
104                            ExpressionParser::advance(parser); // consume (
105
106                            // Handle empty argument list
107                            let args = if matches!(
108                                ExpressionParser::current_token(parser),
109                                Token::RightParen
110                            ) {
111                                Vec::new()
112                            } else {
113                                parser.parse_expression_list()?
114                            };
115                            ExpressionParser::consume(parser, Token::RightParen)?;
116
117                            log_parse_decision(
118                                "parse_primary",
119                                &Token::Identifier(next_id.clone()),
120                                "Method call",
121                            );
122                            Ok(SqlExpression::MethodCall {
123                                object: id_clone,
124                                method: next_id,
125                                args,
126                            })
127                        } else {
128                            // It's a qualified column reference
129                            let col_ref = ColumnRef::qualified(id_clone, next_id.clone());
130                            log_parse_decision(
131                                "parse_primary",
132                                &Token::Identifier(next_id),
133                                "Qualified column reference",
134                            );
135                            Ok(SqlExpression::Column(col_ref))
136                        }
137                    } else {
138                        Err("Expected identifier after '.'".to_string())
139                    }
140                // Check if this is a function call
141                } else if matches!(ExpressionParser::current_token(parser), Token::LeftParen) {
142                    debug!(function = %id_upper, "Parsing function call");
143                    ExpressionParser::advance(parser); // consume (
144                    let (args, has_distinct) = parser.parse_function_args()?;
145                    ExpressionParser::consume(parser, Token::RightParen)?;
146
147                    // Check for OVER clause for window functions
148                    if matches!(ExpressionParser::current_token(parser), Token::Over) {
149                        debug!(function = %id_upper, "Window function detected");
150                        ExpressionParser::advance(parser); // consume OVER
151                        ExpressionParser::consume(parser, Token::LeftParen)?;
152                        let window_spec = parser.parse_window_spec()?;
153                        ExpressionParser::consume(parser, Token::RightParen)?;
154                        Ok(SqlExpression::WindowFunction {
155                            name: id_upper,
156                            args,
157                            window_spec,
158                        })
159                    } else {
160                        Ok(SqlExpression::FunctionCall {
161                            name: id_upper,
162                            args,
163                            distinct: has_distinct,
164                        })
165                    }
166                } else {
167                    // Otherwise treat as simple column
168                    log_parse_decision(
169                        "parse_primary",
170                        &Token::Identifier(id_clone.clone()),
171                        "Column reference",
172                    );
173                    Ok(SqlExpression::Column(ColumnRef::unquoted(id_clone)))
174                }
175            }
176        }
177
178        Token::QuotedIdentifier(id) => {
179            let expr = if ctx.in_method_args {
180                // In method arguments, treat quoted identifiers as string literals
181                log_parse_decision(
182                    "parse_primary",
183                    ExpressionParser::current_token(parser),
184                    "Quoted identifier in method args - treating as string",
185                );
186                SqlExpression::StringLiteral(id.clone())
187            } else {
188                // Otherwise it's a column name like "Customer Id"
189                log_parse_decision(
190                    "parse_primary",
191                    ExpressionParser::current_token(parser),
192                    "Quoted identifier as column name",
193                );
194                SqlExpression::Column(ColumnRef::quoted(id.clone()))
195            };
196            ExpressionParser::advance(parser);
197            Ok(expr)
198        }
199
200        Token::StringLiteral(s) => {
201            trace!("String literal: {}", s);
202            let expr = SqlExpression::StringLiteral(s.clone());
203            ExpressionParser::advance(parser);
204            Ok(expr)
205        }
206
207        Token::NumberLiteral(n) => {
208            trace!("Number literal: {}", n);
209            let expr = SqlExpression::NumberLiteral(n.clone());
210            ExpressionParser::advance(parser);
211            Ok(expr)
212        }
213
214        Token::Null => {
215            trace!("NULL literal");
216            ExpressionParser::advance(parser);
217            Ok(SqlExpression::Null)
218        }
219
220        // Handle LEFT and RIGHT as function names when followed by parentheses
221        Token::Left | Token::Right => {
222            let func_name = match ExpressionParser::current_token(parser) {
223                Token::Left => "LEFT".to_string(),
224                Token::Right => "RIGHT".to_string(),
225                _ => unreachable!(),
226            };
227
228            ExpressionParser::advance(parser);
229
230            // Check if this is a function call
231            if matches!(ExpressionParser::current_token(parser), Token::LeftParen) {
232                debug!(function = %func_name, "Parsing LEFT/RIGHT function call");
233                ExpressionParser::advance(parser); // consume (
234                let (args, _has_distinct) = parser.parse_function_args()?;
235                ExpressionParser::consume(parser, Token::RightParen)?;
236
237                Ok(SqlExpression::FunctionCall {
238                    name: func_name,
239                    args,
240                    distinct: false,
241                })
242            } else {
243                // If not followed by parenthesis, this is likely a JOIN keyword - error
244                Err(format!(
245                    "{} keyword unexpected in expression context",
246                    func_name
247                ))
248            }
249        }
250
251        Token::LeftParen => {
252            debug!("Parsing parenthesized expression or subquery");
253            ExpressionParser::advance(parser); // consume (
254
255            // Check if this is a subquery (starts with SELECT)
256            if matches!(ExpressionParser::current_token(parser), Token::Select) {
257                debug!("Detected subquery - parsing SELECT statement");
258                let subquery = parser.parse_subquery()?;
259                ExpressionParser::consume(parser, Token::RightParen)?;
260                Ok(SqlExpression::ScalarSubquery {
261                    query: Box::new(subquery),
262                })
263            } else {
264                // Regular parenthesized expression
265                debug!("Regular parenthesized expression");
266                let expr = parser.parse_logical_or()?;
267                ExpressionParser::consume(parser, Token::RightParen)?;
268                Ok(expr)
269            }
270        }
271
272        Token::Not => {
273            debug!("Parsing NOT expression");
274            parse_not_expression(parser)
275        }
276
277        Token::Star => {
278            // Handle * as a literal (like in COUNT(*))
279            trace!("Star token as literal");
280            ExpressionParser::advance(parser);
281            Ok(SqlExpression::StringLiteral("*".to_string()))
282        }
283
284        // Handle window-related keywords that can also be column names
285        Token::Row => {
286            trace!("ROW token treated as identifier in expression context");
287            ExpressionParser::advance(parser);
288            Ok(SqlExpression::Column(ColumnRef::unquoted(
289                "row".to_string(),
290            )))
291        }
292
293        Token::Rows => {
294            trace!("ROWS token treated as identifier in expression context");
295            ExpressionParser::advance(parser);
296            Ok(SqlExpression::Column(ColumnRef::unquoted(
297                "rows".to_string(),
298            )))
299        }
300
301        Token::Range => {
302            trace!("RANGE token treated as identifier in expression context");
303            ExpressionParser::advance(parser);
304            Ok(SqlExpression::Column(ColumnRef::unquoted(
305                "range".to_string(),
306            )))
307        }
308
309        _ => {
310            let err = format!(
311                "Unexpected token in primary expression: {:?}",
312                ExpressionParser::current_token(parser)
313            );
314            debug!(error = %err);
315            Err(err)
316        }
317    };
318
319    trace_parse_exit("parse_primary", &result);
320    result
321}
322
323/// Parse DateTime constructor
324fn parse_datetime_constructor<P>(parser: &mut P) -> Result<SqlExpression, String>
325where
326    P: ParsePrimary + ExpressionParser + ?Sized,
327{
328    ExpressionParser::advance(parser); // consume DateTime
329    ExpressionParser::consume(parser, Token::LeftParen)?;
330
331    // Check if empty parentheses for DateTime() - today's date
332    if matches!(ExpressionParser::current_token(parser), Token::RightParen) {
333        ExpressionParser::advance(parser); // consume )
334        debug!("DateTime() - today's date");
335        return Ok(SqlExpression::DateTimeToday {
336            hour: None,
337            minute: None,
338            second: None,
339        });
340    }
341
342    // Parse year
343    let year = if let Token::NumberLiteral(n) = ExpressionParser::current_token(parser) {
344        n.parse::<i32>().map_err(|_| "Invalid year")?
345    } else {
346        return Err("Expected year in DateTime constructor".to_string());
347    };
348    ExpressionParser::advance(parser);
349    ExpressionParser::consume(parser, Token::Comma)?;
350
351    // Parse month
352    let month = if let Token::NumberLiteral(n) = ExpressionParser::current_token(parser) {
353        n.parse::<u32>().map_err(|_| "Invalid month")?
354    } else {
355        return Err("Expected month in DateTime constructor".to_string());
356    };
357    ExpressionParser::advance(parser);
358    ExpressionParser::consume(parser, Token::Comma)?;
359
360    // Parse day
361    let day = if let Token::NumberLiteral(n) = ExpressionParser::current_token(parser) {
362        n.parse::<u32>().map_err(|_| "Invalid day")?
363    } else {
364        return Err("Expected day in DateTime constructor".to_string());
365    };
366    ExpressionParser::advance(parser);
367
368    // Check for optional time components
369    let mut hour = None;
370    let mut minute = None;
371    let mut second = None;
372
373    if matches!(ExpressionParser::current_token(parser), Token::Comma) {
374        ExpressionParser::advance(parser); // consume comma
375
376        // Parse hour
377        if let Token::NumberLiteral(n) = ExpressionParser::current_token(parser) {
378            hour = Some(n.parse::<u32>().map_err(|_| "Invalid hour")?);
379            ExpressionParser::advance(parser);
380
381            // Check for minute
382            if matches!(ExpressionParser::current_token(parser), Token::Comma) {
383                ExpressionParser::advance(parser); // consume comma
384
385                if let Token::NumberLiteral(n) = ExpressionParser::current_token(parser) {
386                    minute = Some(n.parse::<u32>().map_err(|_| "Invalid minute")?);
387                    ExpressionParser::advance(parser);
388
389                    // Check for second
390                    if matches!(ExpressionParser::current_token(parser), Token::Comma) {
391                        ExpressionParser::advance(parser); // consume comma
392
393                        if let Token::NumberLiteral(n) = ExpressionParser::current_token(parser) {
394                            second = Some(n.parse::<u32>().map_err(|_| "Invalid second")?);
395                            ExpressionParser::advance(parser);
396                        }
397                    }
398                }
399            }
400        }
401    }
402
403    ExpressionParser::consume(parser, Token::RightParen)?;
404
405    debug!(year = year, month = month, day = day, hour = ?hour, minute = ?minute, second = ?second, "DateTime constructor parsed");
406
407    Ok(SqlExpression::DateTimeConstructor {
408        year,
409        month,
410        day,
411        hour,
412        minute,
413        second,
414    })
415}
416
417/// Parse NOT expression
418fn parse_not_expression<P>(parser: &mut P) -> Result<SqlExpression, String>
419where
420    P: ParsePrimary + ExpressionParser + ?Sized,
421{
422    ExpressionParser::advance(parser); // consume NOT
423
424    // Check if this is a NOT IN expression
425    if let Ok(inner_expr) = parser.parse_comparison() {
426        // After parsing the inner expression, check if we're followed by IN
427        if matches!(ExpressionParser::current_token(parser), Token::In) {
428            debug!("NOT IN expression detected");
429            ExpressionParser::advance(parser); // consume IN
430            ExpressionParser::consume(parser, Token::LeftParen)?;
431            let values = parser.parse_expression_list()?;
432            ExpressionParser::consume(parser, Token::RightParen)?;
433
434            Ok(SqlExpression::NotInList {
435                expr: Box::new(inner_expr),
436                values,
437            })
438        } else {
439            // Regular NOT expression
440            debug!("Regular NOT expression");
441            Ok(SqlExpression::Not {
442                expr: Box::new(inner_expr),
443            })
444        }
445    } else {
446        Err("Expected expression after NOT".to_string())
447    }
448}
449
450/// Parse UNNEST expression
451/// Syntax: UNNEST(column_expr, 'delimiter')
452fn parse_unnest<P>(parser: &mut P) -> Result<SqlExpression, String>
453where
454    P: ParsePrimary + ExpressionParser + ?Sized,
455{
456    debug!("parse_unnest: starting");
457    ExpressionParser::advance(parser); // consume UNNEST
458    ExpressionParser::consume(parser, Token::LeftParen)?;
459
460    // Parse the column expression (first argument)
461    let column = parser.parse_logical_or()?;
462    debug!("parse_unnest: parsed column expression");
463
464    // Expect comma
465    ExpressionParser::consume(parser, Token::Comma)?;
466
467    // Parse the delimiter (second argument - must be a string literal)
468    let delimiter = match ExpressionParser::current_token(parser) {
469        Token::StringLiteral(s) => {
470            let delim = s.clone();
471            ExpressionParser::advance(parser);
472            delim
473        }
474        _ => {
475            return Err("UNNEST delimiter must be a string literal".to_string());
476        }
477    };
478
479    debug!(delimiter = %delimiter, "parse_unnest: parsed delimiter");
480
481    ExpressionParser::consume(parser, Token::RightParen)?;
482
483    debug!("parse_unnest: complete");
484    Ok(SqlExpression::Unnest {
485        column: Box::new(column),
486        delimiter,
487    })
488}
489
490/// Trait that parsers must implement to use primary expression parsing
491pub trait ParsePrimary {
492    fn current_token(&self) -> &Token;
493    fn advance(&mut self);
494    fn consume(&mut self, expected: Token) -> Result<(), String>;
495
496    // These methods are called from parse_primary
497    fn parse_case_expression(&mut self) -> Result<SqlExpression, String>;
498    fn parse_function_args(&mut self) -> Result<(Vec<SqlExpression>, bool), String>;
499    fn parse_window_spec(&mut self) -> Result<WindowSpec, String>;
500    fn parse_logical_or(&mut self) -> Result<SqlExpression, String>;
501    fn parse_comparison(&mut self) -> Result<SqlExpression, String>;
502    fn parse_expression_list(&mut self) -> Result<Vec<SqlExpression>, String>;
503
504    // For subquery parsing (without parenthesis balance validation)
505    fn parse_subquery(&mut self) -> Result<crate::sql::parser::ast::SelectStatement, String>;
506}
sql_cli/sql/parser/expressions/primary.rs

sql_cli/sql/parser/expressions/
primary.rs
