1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515
// Copyright 2019-2020 Parity Technologies (UK) Ltd. // This file is part of Substrate. // Substrate is free software: you can redistribute it and/or modify // it under the terms of the GNU General Public License as published by // the Free Software Foundation, either version 3 of the License, or // (at your option) any later version. // Substrate is distributed in the hope that it will be useful, // but WITHOUT ANY WARRANTY; without even the implied warranty of // MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the // GNU General Public License for more details. // You should have received a copy of the GNU General Public License // along with Substrate. If not, see <http://www.gnu.org/licenses/>. //! # Off-chain Storage Lock //! //! A storage-based lock with a defined expiry time. //! //! The lock is using Local Storage and allows synchronizing access to critical //! section of your code for concurrently running Off-chain Workers. Usage of //! `PERSISTENT` variant of the storage persists the lock value across a full node //! restart or re-orgs. //! //! A use case for the lock is to make sure that a particular section of the //! code is only run by one Off-chain Worker at a time. This may include //! performing a side-effect (i.e. an HTTP call) or alteration of single or //! multiple Local Storage entries. //! //! One use case would be collective updates of multiple data items or append / //! remove of i.e. sets, vectors which are stored in the off-chain storage DB. //! //! ## Example: //! //! ```rust //! # use codec::{Decode, Encode, Codec}; //! // in your off-chain worker code //! use sp_runtime::offchain::{ //! storage::StorageValueRef, //! storage_lock::{StorageLock, Time}, //! }; //! //! fn append_to_in_storage_vec<'a, T>(key: &'a [u8], _: T) where T: Codec { //! // `access::lock` defines the storage entry which is used for //! // persisting the lock in the underlying database. //! // The entry name _must_ be unique and can be interpreted as a //! // unique mutex instance reference tag. //! let mut lock = StorageLock::<Time>::new(b"access::lock"); //! { //! let _guard = lock.lock(); //! let acc = StorageValueRef::persistent(key); //! let v: Vec<T> = acc.get::<Vec<T>>().unwrap().unwrap(); //! // modify `v` as desired //! // i.e. perform some heavy computation with //! // side effects that should only be done once. //! acc.set(&v); //! // drop `_guard` implicitly at end of scope //! } //! } //! ``` use crate::offchain::storage::StorageValueRef; use crate::traits::AtLeast32Bit; use codec::{Codec, Decode, Encode}; use sp_core::offchain::{Duration, Timestamp}; use sp_io::offchain; /// Default expiry duration for time based locks in milliseconds. const STORAGE_LOCK_DEFAULT_EXPIRY_DURATION: Duration = Duration::from_millis(20_000); /// Default expiry duration for block based locks in blocks. const STORAGE_LOCK_DEFAULT_EXPIRY_BLOCKS: u32 = 4; /// Time between checks if the lock is still being held in milliseconds. const STORAGE_LOCK_PER_CHECK_ITERATION_SNOOZE_MIN: Duration = Duration::from_millis(100); const STORAGE_LOCK_PER_CHECK_ITERATION_SNOOZE_MAX: Duration = Duration::from_millis(10); /// Lockable item for use with a persisted storage lock. /// /// Bound for an item that has a stateful ordered meaning /// without explicitly requiring `Ord` trait in general. pub trait Lockable: Sized { /// An instant type specifying i.e. a point in time. type Deadline: Sized + Codec + Clone; /// Calculate the deadline based on a current state /// such as time or block number and derives the deadline. fn deadline(&self) -> Self::Deadline; /// Verify the deadline has not expired compared to the /// current state, i.e. time or block number. fn has_expired(deadline: &Self::Deadline) -> bool; /// Snooze at least until `deadline` is reached. /// /// Note that `deadline` is only passed to allow optimizations /// for `Lockables` which have a time based component. fn snooze(_deadline: &Self::Deadline) { sp_io::offchain::sleep_until( offchain::timestamp().add(STORAGE_LOCK_PER_CHECK_ITERATION_SNOOZE_MAX), ); } } /// Lockable based on the current timestamp with a configurable expiration time. #[derive(Encode, Decode)] pub struct Time { /// How long the lock will stay valid once `fn lock(..)` or /// `fn try_lock(..)` successfully acquire a lock. expiration_duration: Duration, } impl Default for Time { fn default() -> Self { Self { expiration_duration: STORAGE_LOCK_DEFAULT_EXPIRY_DURATION, } } } impl Lockable for Time { type Deadline = Timestamp; fn deadline(&self) -> Self::Deadline { offchain::timestamp().add(self.expiration_duration) } fn has_expired(deadline: &Self::Deadline) -> bool { offchain::timestamp() > *deadline } fn snooze(deadline: &Self::Deadline) { let now = offchain::timestamp(); let remainder: Duration = now.diff(&deadline); // do not snooze the full duration, but instead snooze max 100ms // it might get unlocked in another thread use core::cmp::{max, min}; let snooze = max( min(remainder, STORAGE_LOCK_PER_CHECK_ITERATION_SNOOZE_MAX), STORAGE_LOCK_PER_CHECK_ITERATION_SNOOZE_MIN, ); sp_io::offchain::sleep_until(now.add(snooze)); } } /// A deadline based on block number and time. #[derive(Encode, Decode, Eq, PartialEq)] pub struct BlockAndTimeDeadline<B: BlockNumberProvider> { /// The block number until which the lock is still valid _at least_. pub block_number: <B as BlockNumberProvider>::BlockNumber, /// The timestamp until which the lock is still valid _at least_. pub timestamp: Timestamp, } impl<B: BlockNumberProvider> Clone for BlockAndTimeDeadline<B> { fn clone(&self) -> Self { Self { block_number: self.block_number.clone(), timestamp: self.timestamp.clone(), } } } impl<B: BlockNumberProvider> Default for BlockAndTimeDeadline<B> { /// Provide the current state of block number and time. fn default() -> Self { Self { block_number: B::current_block_number() + STORAGE_LOCK_DEFAULT_EXPIRY_BLOCKS.into(), timestamp: offchain::timestamp().add(STORAGE_LOCK_DEFAULT_EXPIRY_DURATION), } } } /// Lockable based on block number and timestamp. /// /// Expiration is defined if both, block number _and_ timestamp /// expire. pub struct BlockAndTime<B: BlockNumberProvider> { /// Relative block number offset, which is used to determine /// the block number part of the deadline. expiration_block_number_offset: u32, /// Relative duration, used to derive the time based part of /// the deadline. expiration_duration: Duration, _phantom: core::marker::PhantomData<B>, } impl<B: BlockNumberProvider> Default for BlockAndTime<B> { fn default() -> Self { Self { expiration_block_number_offset: STORAGE_LOCK_DEFAULT_EXPIRY_BLOCKS, expiration_duration: STORAGE_LOCK_DEFAULT_EXPIRY_DURATION, _phantom: core::marker::PhantomData::<B>, } } } // derive not possible, since `B` does not necessarily implement `trait Clone` impl<B: BlockNumberProvider> Clone for BlockAndTime<B> { fn clone(&self) -> Self { Self { expiration_block_number_offset: self.expiration_block_number_offset.clone(), expiration_duration: self.expiration_duration, _phantom: core::marker::PhantomData::<B>, } } } impl<B: BlockNumberProvider> Lockable for BlockAndTime<B> { type Deadline = BlockAndTimeDeadline<B>; fn deadline(&self) -> Self::Deadline { let block_number = <B as BlockNumberProvider>::current_block_number() + self.expiration_block_number_offset.into(); BlockAndTimeDeadline { timestamp: offchain::timestamp().add(self.expiration_duration), block_number, } } fn has_expired(deadline: &Self::Deadline) -> bool { offchain::timestamp() > deadline.timestamp && <B as BlockNumberProvider>::current_block_number() > deadline.block_number } fn snooze(deadline: &Self::Deadline) { let now = offchain::timestamp(); let remainder: Duration = now.diff(&(deadline.timestamp)); use core::cmp::{max, min}; let snooze = max( min(remainder, STORAGE_LOCK_PER_CHECK_ITERATION_SNOOZE_MAX), STORAGE_LOCK_PER_CHECK_ITERATION_SNOOZE_MIN, ); sp_io::offchain::sleep_until(now.add(snooze)); } } /// Storage based lock. /// /// A lock that is persisted in the DB and provides the ability to guard against /// concurrent access in an off-chain worker, with a defined expiry deadline /// based on the concrete [`Lockable`](Lockable) implementation. pub struct StorageLock<'a, L = Time> { // A storage value ref which defines the DB entry representing the lock. value_ref: StorageValueRef<'a>, lockable: L, } impl<'a, L: Lockable + Default> StorageLock<'a, L> { /// Create a new storage lock with a `default()` instance of type `L`. pub fn new(key: &'a [u8]) -> Self { Self::with_lockable(key, Default::default()) } } impl<'a, L: Lockable> StorageLock<'a, L> { /// Create a new storage lock with an explicit instance of a lockable `L`. pub fn with_lockable(key: &'a [u8], lockable: L) -> Self { Self { value_ref: StorageValueRef::<'a>::persistent(key), lockable, } } /// Internal lock helper to avoid lifetime conflicts. fn try_lock_inner( &mut self, new_deadline: L::Deadline, ) -> Result<(), <L as Lockable>::Deadline> { let res = self.value_ref.mutate( |s: Option<Option<L::Deadline>>| -> Result<<L as Lockable>::Deadline, <L as Lockable>::Deadline> { match s { // no lock set, we can safely acquire it None => Ok(new_deadline), // write was good, but read failed Some(None) => Ok(new_deadline), // lock is set, but it is expired. We can re-acquire it. Some(Some(deadline)) if <L as Lockable>::has_expired(&deadline) => Ok(new_deadline), // lock is present and is still active Some(Some(deadline)) => Err(deadline), } }, ); match res { Ok(Ok(_)) => Ok(()), Ok(Err(deadline)) => Err(deadline), Err(e) => Err(e), } } /// A single attempt to lock using the storage entry. /// /// Returns a lock guard on success, otherwise an error containing the /// `<Self::Lockable>::Deadline` in for the currently active lock /// by another task `Err(<L as Lockable>::Deadline)`. pub fn try_lock(&mut self) -> Result<StorageLockGuard<'a, '_, L>, <L as Lockable>::Deadline> { self.try_lock_inner(self.lockable.deadline())?; Ok(StorageLockGuard::<'a, '_> { lock: Some(self) }) } /// Repeated lock attempts until the lock is successfully acquired. /// /// If one uses `fn forget(..)`, it is highly likely `fn try_lock(..)` /// is the correct API to use instead of `fn lock(..)`, since that might /// never unlock in the anticipated span i.e. when used with `BlockAndTime` /// during a certain block number span. pub fn lock(&mut self) -> StorageLockGuard<'a, '_, L> { while let Err(deadline) = self.try_lock_inner(self.lockable.deadline()) { L::snooze(&deadline); } StorageLockGuard::<'a, '_, L> { lock: Some(self) } } /// Explicitly unlock the lock. fn unlock(&mut self) { self.value_ref.clear(); } } /// RAII style guard for a lock. pub struct StorageLockGuard<'a, 'b, L: Lockable> { lock: Option<&'b mut StorageLock<'a, L>>, } impl<'a, 'b, L: Lockable> StorageLockGuard<'a, 'b, L> { /// Consume the guard but **do not** unlock the underlying lock. /// /// Can be used to implement a grace period after doing some /// heavy computations and sending a transaction to be included /// on-chain. By forgetting the lock, it will stay locked until /// its expiration deadline is reached while the off-chain worker /// can already exit. pub fn forget(mut self) { let _ = self.lock.take(); } } impl<'a, 'b, L: Lockable> Drop for StorageLockGuard<'a, 'b, L> { fn drop(&mut self) { if let Some(lock) = self.lock.take() { lock.unlock(); } } } impl<'a> StorageLock<'a, Time> { /// Explicitly create a time based storage lock with a non-default /// expiration timeout. pub fn with_deadline(key: &'a [u8], expiration_duration: Duration) -> Self { Self { value_ref: StorageValueRef::<'a>::persistent(key), lockable: Time { expiration_duration: expiration_duration, }, } } } impl<'a, B> StorageLock<'a, BlockAndTime<B>> where B: BlockNumberProvider, { /// Explicitly create a time and block number based storage lock with /// a non-default expiration duration and block number offset. pub fn with_block_and_time_deadline( key: &'a [u8], expiration_block_number_offset: u32, expiration_duration: Duration, ) -> Self { Self { value_ref: StorageValueRef::<'a>::persistent(key), lockable: BlockAndTime::<B> { expiration_block_number_offset, expiration_duration, _phantom: core::marker::PhantomData, }, } } /// Explicitly create a time and block number based storage lock with /// the default expiration duration and a non-default block number offset. pub fn with_block_deadline(key: &'a [u8], expiration_block_number_offset: u32) -> Self { Self { value_ref: StorageValueRef::<'a>::persistent(key), lockable: BlockAndTime::<B> { expiration_block_number_offset, expiration_duration: STORAGE_LOCK_DEFAULT_EXPIRY_DURATION, _phantom: core::marker::PhantomData, }, } } } /// Bound for a block number source /// used with [`BlockAndTime<BlockNumberProvider>`](BlockAndTime). pub trait BlockNumberProvider { /// Type of `BlockNumber` to provide. type BlockNumber: Codec + Clone + Ord + Eq + AtLeast32Bit; /// Returns the current block number. /// /// Provides an abstraction over an arbitrary way of providing the /// current block number. /// /// In case of using crate `sp_runtime` without the crate `frame` /// system, it is already implemented for /// `frame_system::Module<T: Trait>` as: /// /// ```ignore /// fn current_block_number() -> Self { /// frame_system::Module<Trait>::block_number() /// } /// ``` /// . fn current_block_number() -> Self::BlockNumber; } #[cfg(test)] mod tests { use super::*; use sp_core::offchain::{testing, OffchainExt, OffchainStorage}; use sp_io::TestExternalities; const VAL_1: u32 = 0u32; const VAL_2: u32 = 0xFFFF_FFFFu32; #[test] fn storage_lock_write_unlock_lock_read_unlock() { let (offchain, state) = testing::TestOffchainExt::new(); let mut t = TestExternalities::default(); t.register_extension(OffchainExt::new(offchain)); t.execute_with(|| { let mut lock = StorageLock::<'_, Time>::new(b"lock_1"); let val = StorageValueRef::persistent(b"protected_value"); { let _guard = lock.lock(); val.set(&VAL_1); assert_eq!(val.get::<u32>(), Some(Some(VAL_1))); } { let _guard = lock.lock(); val.set(&VAL_2); assert_eq!(val.get::<u32>(), Some(Some(VAL_2))); } }); // lock must have been cleared at this point assert_eq!(state.read().persistent_storage.get(b"", b"lock_1"), None); } #[test] fn storage_lock_and_forget() { let (offchain, state) = testing::TestOffchainExt::new(); let mut t = TestExternalities::default(); t.register_extension(OffchainExt::new(offchain)); t.execute_with(|| { let mut lock = StorageLock::<'_, Time>::new(b"lock_2"); let val = StorageValueRef::persistent(b"protected_value"); let guard = lock.lock(); val.set(&VAL_1); assert_eq!(val.get::<u32>(), Some(Some(VAL_1))); guard.forget(); }); // lock must have been cleared at this point let opt = state.read().persistent_storage.get(b"", b"lock_2"); assert!(opt.is_some()); } #[test] fn storage_lock_and_let_expire_and_lock_again() { let (offchain, state) = testing::TestOffchainExt::new(); let mut t = TestExternalities::default(); t.register_extension(OffchainExt::new(offchain)); t.execute_with(|| { let sleep_until = offchain::timestamp().add(Duration::from_millis(500)); let lock_expiration = Duration::from_millis(200); let mut lock = StorageLock::<'_, Time>::with_deadline(b"lock_3", lock_expiration); { let guard = lock.lock(); guard.forget(); } // assure the lock expires offchain::sleep_until(sleep_until); let mut lock = StorageLock::<'_, Time>::new(b"lock_3"); let res = lock.try_lock(); assert!(res.is_ok()); let guard = res.unwrap(); guard.forget(); }); // lock must have been cleared at this point let opt = state.read().persistent_storage.get(b"", b"lock_3"); assert!(opt.is_some()); } }