1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89

use osmium_libs_solidity_ast_extractor::{ImportPath, Item, Spanned};

use crate::linter::SolidFile;
use crate::rules::types::*;
use crate::types::*;

// global
pub const RULE_ID: &str = "no-global-import";

// specific
const DEFAULT_MESSAGE: &str = "Import should not be global. Specify names to import individually or bind all exports of the module into a name (import \"path\" as Name)";
const DEFAULT_SEVERITY: Severity = Severity::WARNING;

pub struct NoGlobalImport {
    data: RuleEntry,
}

impl RuleType for NoGlobalImport {
    fn diagnose(&self, _file: &SolidFile, _files: &[SolidFile]) -> Vec<LintDiag> {
        let mut res = Vec::new();

        let reports = check_global_import(_file);
        for report in reports.into_iter().flatten() {
            res.push(LintDiag {
                id: RULE_ID.to_string(),
                range: report,
                severity: self.data.severity,
                code: None,
                source: None,
                message: DEFAULT_MESSAGE.to_string(),
                uri: _file.path.clone(),
            });
        }
        res
    }
}

fn check_global_import(file: &SolidFile) -> Vec<Option<Range>> {
    let mut reports: Vec<Option<Range>> = Vec::new();

    file.data.items.iter().for_each(|item| {
        if let Item::Import(import) = item {
            if let ImportPath::Plain(plain) = &import.path {
                if plain.alias.is_none() {
                    reports.push(Some(Range {
                        start: Position {
                            line: plain.span().start().line,
                            character: plain.span().start().column,
                        },
                        end: Position {
                            line: plain.span().end().line,
                            character: plain.span().end().column,
                        },
                    }));
                }
            }
            if let ImportPath::Glob(glob) = &import.path {
                if glob.alias.is_none() {
                    reports.push(Some(Range {
                        start: Position {
                            line: glob.span().start().line,
                            character: glob.span().start().column,
                        },
                        end: Position {
                            line: glob.span().end().line,
                            character: glob.span().end().column,
                        },
                    }));
                }
            }
        }
    });
    reports
}

impl NoGlobalImport {
    pub(crate) fn create(data: RuleEntry) -> Box<dyn RuleType> {
        let rule = NoGlobalImport { data };
        Box::new(rule)
    }

    pub(crate) fn create_default() -> RuleEntry {
        RuleEntry {
            id: RULE_ID.to_string(),
            severity: DEFAULT_SEVERITY,
            data: None,
        }
    }
}