solana_vote_program/vote_state/

mod.rs

//! Vote state, vote program
//! Receive and processes votes from validators

pub mod handler;

pub use solana_vote_interface::state::{vote_state_versions::*, *};
use {
    crate::vote_state::handler::VoteStateVersionsInline,
    handler::{VoteStateHandler, VoteStateTargetVersion},
    log::*,
    solana_account::{AccountSharedData, WritableAccount},
    solana_bls_signatures::{VerifiableProofOfPossession, keypair::Keypair as BLSKeypair},
    solana_clock::{Clock, Epoch, Slot},
    solana_epoch_schedule::EpochSchedule,
    solana_hash::Hash,
    solana_instruction::error::InstructionError,
    solana_program_runtime::invoke_context::InvokeContext,
    solana_pubkey::Pubkey,
    solana_rent::Rent,
    solana_sdk_ids::system_program,
    solana_slot_hashes::SlotHash,
    solana_system_interface::instruction as system_instruction,
    solana_transaction_context::{
        IndexOfAccount, instruction::InstructionContext,
        instruction_accounts::BorrowedInstructionAccount,
    },
    solana_vote_interface::{error::VoteError, instruction::CommissionKind, program::id},
    std::{
        cmp::Ordering,
        collections::{HashSet, VecDeque},
    },
};

fn get_vote_state_handler_checked(
    vote_account: &BorrowedInstructionAccount,
    target_version: VoteStateTargetVersion,
) -> Result<VoteStateHandler, InstructionError> {
    match target_version {
        VoteStateTargetVersion::V4 => {
            // New flow after v4 feature gate activation:
            // 1. Deserialize as `VoteStateVersions`
            // 2. Check for uninitialized
            // 3. Convert
            let versioned = VoteStateVersionsInline::deserialize(vote_account.get_data())?;
            if versioned.is_uninitialized() {
                return Err(InstructionError::UninitializedAccount);
            }
            let vote_state =
                handler::try_convert_to_vote_state_v4(versioned, vote_account.get_key())?;
            Ok(VoteStateHandler::new_v4(vote_state))
        }
    }
}

/// Checks the proposed vote state with the current and
/// slot hashes, making adjustments to the root / filtering
/// votes as needed.
fn check_and_filter_proposed_vote_state(
    vote_state: &VoteStateHandler,
    proposed_lockouts: &mut VecDeque<Lockout>,
    proposed_root: &mut Option<Slot>,
    proposed_hash: Hash,
    slot_hashes: &[(Slot, Hash)],
) -> Result<(), VoteError> {
    if proposed_lockouts.is_empty() {
        return Err(VoteError::EmptySlots);
    }

    let last_proposed_slot = proposed_lockouts
        .back()
        .expect("must be nonempty, checked above")
        .slot();

    // If the proposed state is not new enough, return
    if let Some(last_vote_slot) = vote_state.votes().back().map(|lockout| lockout.slot())
        && last_proposed_slot <= last_vote_slot
    {
        return Err(VoteError::VoteTooOld);
    }

    if slot_hashes.is_empty() {
        return Err(VoteError::SlotsMismatch);
    }
    let earliest_slot_hash_in_history = slot_hashes.last().unwrap().0;

    // Check if the proposed vote state is too old to be in the SlotHash history
    if last_proposed_slot < earliest_slot_hash_in_history {
        // If this is the last slot in the vote update, it must be in SlotHashes,
        // otherwise we have no way of confirming if the hash matches
        return Err(VoteError::VoteTooOld);
    }

    // Overwrite the proposed root if it is too old to be in the SlotHash history
    if let Some(root) = *proposed_root {
        // If the new proposed root `R` is less than the earliest slot hash in the history
        // such that we cannot verify whether the slot was actually was on this fork, set
        // the root to the latest vote in the vote state that's less than R. If no
        // votes from the vote state are less than R, use its root instead.
        if root < earliest_slot_hash_in_history {
            // First overwrite the proposed root with the vote state's root
            *proposed_root = vote_state.root_slot();

            // Then try to find the latest vote in vote state that's less than R
            for vote in vote_state.votes().iter().rev() {
                if vote.slot() <= root {
                    *proposed_root = Some(vote.slot());
                    break;
                }
            }
        }
    }

    // Index into the new proposed vote state's slots, starting with the root if it exists then
    // we use this mutable root to fold checking the root slot into the below loop
    // for performance
    let mut root_to_check = *proposed_root;
    let mut proposed_lockouts_index = 0;

    // index into the slot_hashes, starting at the oldest known
    // slot hash
    let mut slot_hashes_index = slot_hashes.len();

    let mut proposed_lockouts_indices_to_filter = vec![];

    // Note:
    //
    // 1) `proposed_lockouts` is sorted from oldest/smallest vote to newest/largest
    // vote, due to the way votes are applied to the vote state (newest votes
    // pushed to the back).
    //
    // 2) Conversely, `slot_hashes` is sorted from newest/largest vote to
    // the oldest/smallest vote
    //
    // We check every proposed lockout because have to ensure that every slot is actually part of
    // the history, not just the most recent ones
    while proposed_lockouts_index < proposed_lockouts.len() && slot_hashes_index > 0 {
        let proposed_vote_slot = if let Some(root) = root_to_check {
            root
        } else {
            proposed_lockouts[proposed_lockouts_index].slot()
        };
        if root_to_check.is_none()
            && proposed_lockouts_index > 0
            && proposed_vote_slot
                <= proposed_lockouts[proposed_lockouts_index.checked_sub(1).expect(
                    "`proposed_lockouts_index` is positive when checking `SlotsNotOrdered`",
                )]
                .slot()
        {
            return Err(VoteError::SlotsNotOrdered);
        }
        let ancestor_slot = slot_hashes[slot_hashes_index
            .checked_sub(1)
            .expect("`slot_hashes_index` is positive when computing `ancestor_slot`")]
        .0;

        // Find if this slot in the proposed vote state exists in the SlotHashes history
        // to confirm if it was a valid ancestor on this fork
        match proposed_vote_slot.cmp(&ancestor_slot) {
            Ordering::Less => {
                if slot_hashes_index == slot_hashes.len() {
                    // The vote slot does not exist in the SlotHashes history because it's too old,
                    // i.e. older than the oldest slot in the history.
                    if proposed_vote_slot >= earliest_slot_hash_in_history {
                        return Err(VoteError::AssertionFailed);
                    }
                    if !vote_state.contains_slot(proposed_vote_slot) && root_to_check.is_none() {
                        // If the vote slot is both:
                        // 1) Too old
                        // 2) Doesn't already exist in vote state
                        //
                        // Then filter it out
                        proposed_lockouts_indices_to_filter.push(proposed_lockouts_index);
                    }
                    if let Some(new_proposed_root) = root_to_check {
                        // 1. Because `root_to_check.is_some()`, then we know that
                        // we haven't checked the root yet in this loop, so
                        // `proposed_vote_slot` == `new_proposed_root` == `proposed_root`.
                        assert_eq!(new_proposed_root, proposed_vote_slot);
                        // 2. We know from the assert earlier in the function that
                        // `proposed_vote_slot < earliest_slot_hash_in_history`,
                        // so from 1. we know that `new_proposed_root < earliest_slot_hash_in_history`.
                        if new_proposed_root >= earliest_slot_hash_in_history {
                            return Err(VoteError::AssertionFailed);
                        }
                        root_to_check = None;
                    } else {
                        proposed_lockouts_index = proposed_lockouts_index.checked_add(1).expect(
                            "`proposed_lockouts_index` is bounded by `MAX_LOCKOUT_HISTORY` when \
                             `proposed_vote_slot` is too old to be in SlotHashes history",
                        );
                    }
                    continue;
                } else {
                    // If the vote slot is new enough to be in the slot history,
                    // but is not part of the slot history, then it must belong to another fork,
                    // which means this proposed vote state is invalid.
                    if root_to_check.is_some() {
                        return Err(VoteError::RootOnDifferentFork);
                    } else {
                        return Err(VoteError::SlotsMismatch);
                    }
                }
            }
            Ordering::Greater => {
                // Decrement `slot_hashes_index` to find newer slots in the SlotHashes history
                slot_hashes_index = slot_hashes_index.checked_sub(1).expect(
                    "`slot_hashes_index` is positive when finding newer slots in SlotHashes \
                     history",
                );
                continue;
            }
            Ordering::Equal => {
                // Once the slot in `proposed_lockouts` is found, bump to the next slot
                // in `proposed_lockouts` and continue. If we were checking the root,
                // start checking the vote state instead.
                if root_to_check.is_some() {
                    root_to_check = None;
                } else {
                    proposed_lockouts_index = proposed_lockouts_index.checked_add(1).expect(
                        "`proposed_lockouts_index` is bounded by `MAX_LOCKOUT_HISTORY` when match \
                         is found in SlotHashes history",
                    );
                    slot_hashes_index = slot_hashes_index.checked_sub(1).expect(
                        "`slot_hashes_index` is positive when match is found in SlotHashes history",
                    );
                }
            }
        }
    }

    if proposed_lockouts_index != proposed_lockouts.len() {
        // The last vote slot in the proposed vote state did not exist in SlotHashes
        return Err(VoteError::SlotsMismatch);
    }

    // This assertion must be true at this point because we can assume by now:
    // 1) proposed_lockouts_index == proposed_lockouts.len()
    // 2) last_proposed_slot >= earliest_slot_hash_in_history
    // 3) !proposed_lockouts.is_empty()
    //
    // 1) implies that during the last iteration of the loop above,
    // `proposed_lockouts_index` was equal to `proposed_lockouts.len() - 1`,
    // and was then incremented to `proposed_lockouts.len()`.
    // This means in that last loop iteration,
    // `proposed_vote_slot ==
    //  proposed_lockouts[proposed_lockouts.len() - 1] ==
    //  last_proposed_slot`.
    //
    // Then we know the last comparison `match proposed_vote_slot.cmp(&ancestor_slot)`
    // is equivalent to `match last_proposed_slot.cmp(&ancestor_slot)`. The result
    // of this match to increment `proposed_lockouts_index` must have been either:
    //
    // 1) The Equal case ran, in which case then we know this assertion must be true
    // 2) The Less case ran, and more specifically the case
    // `proposed_vote_slot < earliest_slot_hash_in_history` ran, which is equivalent to
    // `last_proposed_slot < earliest_slot_hash_in_history`, but this is impossible
    // due to assumption 3) above.
    assert_eq!(last_proposed_slot, slot_hashes[slot_hashes_index].0);

    if slot_hashes[slot_hashes_index].1 != proposed_hash {
        // This means the newest vote in the slot has a match that
        // doesn't match the expected hash for that slot on this
        // fork
        warn!(
            "{} dropped vote {:?} root {:?} failed to match hash {} {}",
            vote_state.node_pubkey(),
            proposed_lockouts,
            proposed_root,
            proposed_hash,
            slot_hashes[slot_hashes_index].1
        );
        return Err(VoteError::SlotHashMismatch);
    }

    // Filter out the irrelevant votes
    let mut proposed_lockouts_index = 0;
    let mut filter_votes_index = 0;
    proposed_lockouts.retain(|_lockout| {
        let should_retain = if filter_votes_index == proposed_lockouts_indices_to_filter.len() {
            true
        } else if proposed_lockouts_index == proposed_lockouts_indices_to_filter[filter_votes_index]
        {
            filter_votes_index = filter_votes_index.checked_add(1).unwrap();
            false
        } else {
            true
        };

        proposed_lockouts_index = proposed_lockouts_index.checked_add(1).expect(
            "`proposed_lockouts_index` is bounded by `MAX_LOCKOUT_HISTORY` when filtering out \
             irrelevant votes",
        );
        should_retain
    });

    Ok(())
}

fn check_slots_are_valid(
    vote_state: &VoteStateHandler,
    vote_slots: &[Slot],
    vote_hash: &Hash,
    slot_hashes: &[(Slot, Hash)],
) -> Result<(), VoteError> {
    // index into the vote's slots, starting at the oldest
    // slot
    let mut i = 0;

    // index into the slot_hashes, starting at the oldest known
    // slot hash
    let mut j = slot_hashes.len();

    // Note:
    //
    // 1) `vote_slots` is sorted from oldest/smallest vote to newest/largest
    // vote, due to the way votes are applied to the vote state (newest votes
    // pushed to the back).
    //
    // 2) Conversely, `slot_hashes` is sorted from newest/largest vote to
    // the oldest/smallest vote
    while i < vote_slots.len() && j > 0 {
        // 1) increment `i` to find the smallest slot `s` in `vote_slots`
        // where `s` >= `last_voted_slot`
        if vote_state
            .last_voted_slot()
            .is_some_and(|last_voted_slot| vote_slots[i] <= last_voted_slot)
        {
            i = i
                .checked_add(1)
                .expect("`i` is bounded by `MAX_LOCKOUT_HISTORY` when finding larger slots");
            continue;
        }

        // 2) Find the hash for this slot `s`.
        if vote_slots[i] != slot_hashes[j.checked_sub(1).expect("`j` is positive")].0 {
            // Decrement `j` to find newer slots
            j = j
                .checked_sub(1)
                .expect("`j` is positive when finding newer slots");
            continue;
        }

        // 3) Once the hash for `s` is found, bump `s` to the next slot
        // in `vote_slots` and continue.
        i = i
            .checked_add(1)
            .expect("`i` is bounded by `MAX_LOCKOUT_HISTORY` when hash is found");
        j = j
            .checked_sub(1)
            .expect("`j` is positive when hash is found");
    }

    if j == slot_hashes.len() {
        // This means we never made it to steps 2) or 3) above, otherwise
        // `j` would have been decremented at least once. This means
        // there are not slots in `vote_slots` greater than `last_voted_slot`
        debug!(
            "{} dropped vote slots {:?}, vote hash: {:?} slot hashes:SlotHash {:?}, too old ",
            vote_state.node_pubkey(),
            vote_slots,
            vote_hash,
            slot_hashes
        );
        return Err(VoteError::VoteTooOld);
    }
    if i != vote_slots.len() {
        // This means there existed some slot for which we couldn't find
        // a matching slot hash in step 2)
        info!(
            "{} dropped vote slots {:?} failed to match slot hashes: {:?}",
            vote_state.node_pubkey(),
            vote_slots,
            slot_hashes,
        );
        return Err(VoteError::SlotsMismatch);
    }
    if &slot_hashes[j].1 != vote_hash {
        // This means the newest slot in the `vote_slots` has a match that
        // doesn't match the expected hash for that slot on this
        // fork
        warn!(
            "{} dropped vote slots {:?} failed to match hash {} {}",
            vote_state.node_pubkey(),
            vote_slots,
            vote_hash,
            slot_hashes[j].1
        );
        return Err(VoteError::SlotHashMismatch);
    }
    Ok(())
}

// Ensure `check_and_filter_proposed_vote_state(&)` runs on the slots in `new_state`
// before `process_new_vote_state()` is called

// This function should guarantee the following about `new_state`:
//
// 1) It's well ordered, i.e. the slots are sorted from smallest to largest,
// and the confirmations sorted from largest to smallest.
// 2) Confirmations `c` on any vote slot satisfy `0 < c <= MAX_LOCKOUT_HISTORY`
// 3) Lockouts are not expired by consecutive votes, i.e. for every consecutive
// `v_i`, `v_{i + 1}` satisfy `v_i.last_locked_out_slot() >= v_{i + 1}`.

// We also guarantee that compared to the current vote state, `new_state`
// introduces no rollback. This means:
//
// 1) The last slot in `new_state` is always greater than any slot in the
// current vote state.
//
// 2) From 1), this means that for every vote `s` in the current state:
//    a) If there exists an `s'` in `new_state` where `s.slot == s'.slot`, then
//    we must guarantee `s.confirmations <= s'.confirmations`
//
//    b) If there does not exist any such `s'` in `new_state`, then there exists
//    some `t` that is the smallest vote in `new_state` where `t.slot > s.slot`.
//    `t` must have expired/popped off s', so it must be guaranteed that
//    `s.last_locked_out_slot() < t`.

// Note these two above checks do not guarantee that the vote state being submitted
// is a vote state that could have been created by iteratively building a tower
// by processing one vote at a time. For instance, the tower:
//
// { slot 0, confirmations: 31 }
// { slot 1, confirmations: 30 }
//
// is a legal tower that could be submitted on top of a previously empty tower. However,
// there is no way to create this tower from the iterative process, because slot 1 would
// have to have at least one other slot on top of it, even if the first 30 votes were all
// popped off.
pub fn process_new_vote_state(
    vote_state: &mut VoteStateHandler,
    mut new_state: VecDeque<LandedVote>,
    new_root: Option<Slot>,
    timestamp: Option<i64>,
    epoch: Epoch,
    current_slot: Slot,
) -> Result<(), VoteError> {
    assert!(!new_state.is_empty());
    if new_state.len() > MAX_LOCKOUT_HISTORY {
        return Err(VoteError::TooManyVotes);
    }

    match (new_root, vote_state.root_slot()) {
        (Some(new_root), Some(current_root)) if new_root < current_root => {
            return Err(VoteError::RootRollBack);
        }
        (None, Some(_)) => {
            return Err(VoteError::RootRollBack);
        }
        _ => (),
    }

    let mut previous_vote: Option<&LandedVote> = None;

    // Check that all the votes in the new proposed state are:
    // 1) Strictly sorted from oldest to newest vote
    // 2) The confirmations are strictly decreasing
    // 3) Not zero confirmation votes
    for vote in &new_state {
        if vote.confirmation_count() == 0 {
            return Err(VoteError::ZeroConfirmations);
        } else if vote.confirmation_count() > MAX_LOCKOUT_HISTORY as u32 {
            return Err(VoteError::ConfirmationTooLarge);
        } else if let Some(new_root) = new_root
            && vote.slot() <= new_root
                &&
                // This check is necessary because
                // https://github.com/ryoqun/solana/blob/df55bfb46af039cbc597cd60042d49b9d90b5961/core/src/consensus.rs#L120
                // always sets a root for even empty towers, which is then hard unwrapped here
                // https://github.com/ryoqun/solana/blob/df55bfb46af039cbc597cd60042d49b9d90b5961/core/src/consensus.rs#L776
                new_root != Slot::default()
        {
            return Err(VoteError::SlotSmallerThanRoot);
        }

        if let Some(previous_vote) = previous_vote {
            if previous_vote.slot() >= vote.slot() {
                return Err(VoteError::SlotsNotOrdered);
            } else if previous_vote.confirmation_count() <= vote.confirmation_count() {
                return Err(VoteError::ConfirmationsNotOrdered);
            } else if vote.slot() > previous_vote.lockout.last_locked_out_slot() {
                return Err(VoteError::NewVoteStateLockoutMismatch);
            }
        }
        previous_vote = Some(vote);
    }

    // Find the first vote in the current vote state for a slot greater
    // than the new proposed root
    let mut current_vote_state_index: usize = 0;
    let mut new_vote_state_index = 0;

    // Accumulate credits earned by newly rooted slots
    let mut earned_credits = 0_u64;

    if let Some(new_root) = new_root {
        for current_vote in vote_state.votes() {
            // Find the first vote in the current vote state for a slot greater
            // than the new proposed root
            if current_vote.slot() <= new_root {
                earned_credits = earned_credits
                    .checked_add(vote_state.credits_for_vote_at_index(current_vote_state_index))
                    .expect("`earned_credits` does not overflow");
                current_vote_state_index = current_vote_state_index.checked_add(1).expect(
                    "`current_vote_state_index` is bounded by `MAX_LOCKOUT_HISTORY` when \
                     processing new root",
                );
                continue;
            }

            break;
        }
    }

    // For any slots newly added to the new vote state, the vote latency of that slot is not provided by the
    // vote instruction contents, but instead is computed from the actual latency of the vote
    // instruction. This prevents other validators from manipulating their own vote latencies within their vote states
    // and forcing the rest of the cluster to accept these possibly fraudulent latency values.  If the
    // timly_vote_credits feature is not enabled then vote latency is set to 0 for new votes.
    //
    // For any slot that is in both the new state and the current state, the vote latency of the new state is taken
    // from the current state.
    //
    // Thus vote latencies are set here for any newly vote-on slots when a vote instruction is received.
    // They are copied into the new vote state after every vote for already voted-on slots.
    // And when voted-on slots are rooted, the vote latencies stored in the vote state of all the rooted slots is used
    // to compute credits earned.
    // All validators compute the same vote latencies because all process the same vote instruction at the
    // same slot, and the only time vote latencies are ever computed is at the time that their slot is first voted on;
    // after that, the latencies are retained unaltered until the slot is rooted.

    // All the votes in our current vote state that are missing from the new vote state
    // must have been expired by later votes. Check that the lockouts match this assumption.
    while current_vote_state_index < vote_state.votes().len()
        && new_vote_state_index < new_state.len()
    {
        let current_vote = &vote_state.votes()[current_vote_state_index];
        let new_vote = &mut new_state[new_vote_state_index];

        // If the current slot is less than the new proposed slot, then the
        // new slot must have popped off the old slot, so check that the
        // lockouts are corrects.
        match current_vote.slot().cmp(&new_vote.slot()) {
            Ordering::Less => {
                if current_vote.lockout.last_locked_out_slot() >= new_vote.slot() {
                    return Err(VoteError::LockoutConflict);
                }
                current_vote_state_index = current_vote_state_index.checked_add(1).expect(
                    "`current_vote_state_index` is bounded by `MAX_LOCKOUT_HISTORY` when slot is \
                     less than proposed",
                );
            }
            Ordering::Equal => {
                // The new vote state should never have less lockout than
                // the previous vote state for the same slot
                if new_vote.confirmation_count() < current_vote.confirmation_count() {
                    return Err(VoteError::ConfirmationRollBack);
                }

                // Copy the vote slot latency in from the current state to the new state
                new_vote.latency = vote_state.votes()[current_vote_state_index].latency;

                current_vote_state_index = current_vote_state_index.checked_add(1).expect(
                    "`current_vote_state_index` is bounded by `MAX_LOCKOUT_HISTORY` when slot is \
                     equal to proposed",
                );
                new_vote_state_index = new_vote_state_index.checked_add(1).expect(
                    "`new_vote_state_index` is bounded by `MAX_LOCKOUT_HISTORY` when slot is \
                     equal to proposed",
                );
            }
            Ordering::Greater => {
                new_vote_state_index = new_vote_state_index.checked_add(1).expect(
                    "`new_vote_state_index` is bounded by `MAX_LOCKOUT_HISTORY` when slot is \
                     greater than proposed",
                );
            }
        }
    }

    // `new_vote_state` passed all the checks, finalize the change by rewriting
    // our state.

    // Now set the vote latencies on new slots not in the current state.  New slots not in the current vote state will
    // have had their latency initialized to 0 by the above loop.  Those will now be updated to their actual latency.
    for new_vote in new_state.iter_mut() {
        if new_vote.latency == 0 {
            new_vote.latency = handler::compute_vote_latency(new_vote.slot(), current_slot);
        }
    }

    if vote_state.root_slot() != new_root {
        // Award vote credits based on the number of slots that were voted on and have reached finality
        // For each finalized slot, there was one voted-on slot in the new vote state that was responsible for
        // finalizing it. Each of those votes is awarded 1 credit.
        vote_state.increment_credits(epoch, earned_credits);
    }
    if let Some(timestamp) = timestamp {
        let last_slot = new_state.back().unwrap().slot();
        vote_state.process_timestamp(last_slot, timestamp)?;
    }
    vote_state.set_root_slot(new_root);
    vote_state.set_votes(new_state);

    Ok(())
}

pub fn process_vote_unfiltered(
    vote_state: &mut VoteStateHandler,
    vote_slots: &[Slot],
    vote: &Vote,
    slot_hashes: &[SlotHash],
    epoch: Epoch,
    current_slot: Slot,
) -> Result<(), VoteError> {
    check_slots_are_valid(vote_state, vote_slots, &vote.hash, slot_hashes)?;
    vote_slots
        .iter()
        .for_each(|s| vote_state.process_next_vote_slot(*s, epoch, current_slot));
    Ok(())
}

pub fn process_vote(
    vote_state: &mut VoteStateHandler,
    vote: &Vote,
    slot_hashes: &[SlotHash],
    epoch: Epoch,
    current_slot: Slot,
) -> Result<(), VoteError> {
    if vote.slots.is_empty() {
        return Err(VoteError::EmptySlots);
    }
    let earliest_slot_in_history = slot_hashes.last().map(|(slot, _hash)| *slot).unwrap_or(0);
    let vote_slots = vote
        .slots
        .iter()
        .filter(|slot| **slot >= earliest_slot_in_history)
        .cloned()
        .collect::<Vec<Slot>>();
    if vote_slots.is_empty() {
        return Err(VoteError::VotesTooOldAllFiltered);
    }
    process_vote_unfiltered(
        vote_state,
        &vote_slots,
        vote,
        slot_hashes,
        epoch,
        current_slot,
    )
}

/// "unchecked" functions used by tests and Tower
pub fn process_vote_unchecked(
    vote_state: &mut VoteStateHandler,
    vote: Vote,
) -> Result<(), VoteError> {
    if vote.slots.is_empty() {
        return Err(VoteError::EmptySlots);
    }
    let slot_hashes: Vec<_> = vote.slots.iter().rev().map(|x| (*x, vote.hash)).collect();
    process_vote_unfiltered(
        vote_state,
        &vote.slots,
        &vote,
        &slot_hashes,
        vote_state.current_epoch(),
        0,
    )
}

#[cfg(test)]
pub fn process_slot_votes_unchecked(vote_state: &mut VoteStateHandler, slots: &[Slot]) {
    for slot in slots {
        process_slot_vote_unchecked(vote_state, *slot);
    }
}

pub fn process_slot_vote_unchecked(vote_state: &mut VoteStateHandler, slot: Slot) {
    let _ = process_vote_unchecked(vote_state, Vote::new(vec![slot], Hash::default()));
}

/// Authorize the given pubkey to withdraw or sign votes. This may be called multiple times,
/// but will implicitly withdraw authorization from the previously authorized
/// key
pub fn authorize<S: std::hash::BuildHasher, F>(
    vote_account: &mut BorrowedInstructionAccount,
    target_version: VoteStateTargetVersion,
    authorized: &Pubkey,
    vote_authorize: VoteAuthorize,
    signers: &HashSet<Pubkey, S>,
    clock: &Clock,
    is_vote_authorize_with_bls_enabled: bool,
    consume_pop_compute_units: F,
) -> Result<(), InstructionError>
where
    F: FnOnce() -> Result<(), InstructionError>,
{
    let mut vote_state = get_vote_state_handler_checked(vote_account, target_version)?;

    match vote_authorize {
        VoteAuthorize::Voter => {
            if is_vote_authorize_with_bls_enabled && vote_state.has_bls_pubkey() {
                return Err(InstructionError::InvalidInstructionData);
            }
            let authorized_withdrawer_signer =
                verify_authorized_signer(vote_state.authorized_withdrawer(), signers).is_ok();

            vote_state.set_new_authorized_voter(
                authorized,
                clock.epoch,
                clock
                    .leader_schedule_epoch
                    .checked_add(1)
                    .ok_or(InstructionError::InvalidAccountData)?,
                None,
                |epoch_authorized_voter| {
                    // current authorized withdrawer or authorized voter must say "yay"
                    if authorized_withdrawer_signer {
                        Ok(())
                    } else {
                        verify_authorized_signer(&epoch_authorized_voter, signers)
                    }
                },
            )?;
        }
        VoteAuthorize::Withdrawer => {
            // current authorized withdrawer must say "yay"
            verify_authorized_signer(vote_state.authorized_withdrawer(), signers)?;
            vote_state.set_authorized_withdrawer(*authorized);
        }
        VoteAuthorize::VoterWithBLS(args) => {
            if !is_vote_authorize_with_bls_enabled {
                return Err(InstructionError::InvalidInstructionData);
            }
            let authorized_withdrawer_signer =
                verify_authorized_signer(vote_state.authorized_withdrawer(), signers).is_ok();

            verify_bls_proof_of_possession(
                vote_account.get_key(),
                &args.bls_pubkey,
                &args.bls_proof_of_possession,
                consume_pop_compute_units,
            )?;

            vote_state.set_new_authorized_voter(
                authorized,
                clock.epoch,
                clock
                    .leader_schedule_epoch
                    .checked_add(1)
                    .ok_or(InstructionError::InvalidAccountData)?,
                Some(&args.bls_pubkey),
                |epoch_authorized_voter| {
                    // current authorized withdrawer or authorized voter must say "yay"
                    if authorized_withdrawer_signer {
                        Ok(())
                    } else {
                        verify_authorized_signer(&epoch_authorized_voter, signers)
                    }
                },
            )?;
        }
    }

    vote_state.set_vote_account_state(vote_account)
}

/// Update the node_pubkey, requires signature of the authorized voter
pub fn update_validator_identity<S: std::hash::BuildHasher>(
    vote_account: &mut BorrowedInstructionAccount,
    target_version: VoteStateTargetVersion,
    node_pubkey: &Pubkey,
    signers: &HashSet<Pubkey, S>,
    custom_commission_collector_enabled: bool,
) -> Result<(), InstructionError> {
    let mut vote_state = get_vote_state_handler_checked(vote_account, target_version)?;

    // current authorized withdrawer must say "yay"
    verify_authorized_signer(vote_state.authorized_withdrawer(), signers)?;

    // new node must say "yay"
    verify_authorized_signer(node_pubkey, signers)?;

    vote_state.set_node_pubkey(*node_pubkey);

    // Before SIMD-0232, block_revenue_collector is always synced with node_pubkey.
    // After SIMD-0232, the collector can be set independently.
    if !custom_commission_collector_enabled {
        vote_state.set_block_revenue_collector(*node_pubkey);
    }

    vote_state.set_vote_account_state(vote_account)
}

/// Update the vote account's commission
pub fn update_commission<S: std::hash::BuildHasher>(
    vote_account: &mut BorrowedInstructionAccount,
    target_version: VoteStateTargetVersion,
    commission: u8,
    signers: &HashSet<Pubkey, S>,
    epoch_schedule: &EpochSchedule,
    clock: &Clock,
    disable_commission_update_rule: bool,
) -> Result<(), InstructionError> {
    let vote_state_result = get_vote_state_handler_checked(vote_account, target_version);
    let enforce_commission_update_rule = !disable_commission_update_rule
        && match vote_state_result.as_ref() {
            Ok(decoded_vote_state) => commission > decoded_vote_state.commission(),
            Err(_) => true,
        };

    if enforce_commission_update_rule && !is_commission_update_allowed(clock.slot, epoch_schedule) {
        return Err(VoteError::CommissionUpdateTooLate.into());
    }

    let mut vote_state = vote_state_result?;

    // current authorized withdrawer must say "yay"
    verify_authorized_signer(vote_state.authorized_withdrawer(), signers)?;

    vote_state.set_commission(commission);

    vote_state.set_vote_account_state(vote_account)
}

/// Update the vote account's commission in basis points (SIMD-0291, SIMD-0123).
pub fn update_commission_bps<S: std::hash::BuildHasher>(
    vote_account: &mut BorrowedInstructionAccount,
    target_version: VoteStateTargetVersion,
    commission_bps: u16,
    kind: CommissionKind,
    signers: &HashSet<Pubkey, S>,
    block_revenue_sharing_enabled: bool,
) -> Result<(), InstructionError> {
    // Per SIMD-0291: BlockRevenue returns InvalidInstructionData unless
    // SIMD-0123 (block_revenue_sharing) is enabled.
    if matches!(kind, CommissionKind::BlockRevenue) && !block_revenue_sharing_enabled {
        return Err(InstructionError::InvalidInstructionData);
    }

    let mut vote_state = get_vote_state_handler_checked(vote_account, target_version)?;

    // No commission update rule, per SIMD-0249 and SIMD-0291.

    // Require authorized withdrawer to sign.
    verify_authorized_signer(vote_state.authorized_withdrawer(), signers)?;

    match kind {
        CommissionKind::InflationRewards => {
            vote_state.set_inflation_rewards_commission_bps(commission_bps);
        }
        CommissionKind::BlockRevenue => {
            vote_state.set_block_revenue_commission_bps(commission_bps);
        }
    }

    vote_state.set_vote_account_state(vote_account)
}

pub enum NewCommissionCollector<'a, 'b> {
    VoteAccount,
    NewAccount(BorrowedInstructionAccount<'a, 'b>),
}

impl NewCommissionCollector<'_, '_> {
    /// Validates the collector per SIMD-0232 and returns its pubkey.
    ///
    /// The designated commission collector must either be equal to the vote
    /// account's address OR satisfy ALL of the following constraints:
    ///
    /// 1. Must be a system program owned account.
    /// 2. Must be rent-exempt.
    /// 3. Must not be a reserved account (checked via writable flag).
    pub fn validate_and_resolve_key(
        &self,
        vote_account: &BorrowedInstructionAccount,
        rent: &Rent,
    ) -> Result<Pubkey, InstructionError> {
        match self {
            NewCommissionCollector::VoteAccount => Ok(*vote_account.get_key()),
            NewCommissionCollector::NewAccount(collector_account) => {
                // 1. Must be a system program owned account.
                if collector_account.get_owner() != &system_program::id() {
                    return Err(InstructionError::InvalidAccountOwner);
                }

                // 2. Must be rent-exempt.
                if !rent.is_exempt(
                    collector_account.get_lamports(),
                    collector_account.get_data().len(),
                ) {
                    return Err(InstructionError::InsufficientFunds);
                }

                // 3. Must not be a reserved account (checked via writable flag).
                if !collector_account.is_writable() {
                    return Err(InstructionError::InvalidArgument);
                }

                Ok(*collector_account.get_key())
            }
        }
    }
}

/// Update the vote account's commission collector (SIMD-0232).
pub fn update_commission_collector<S: std::hash::BuildHasher>(
    vote_account: &mut BorrowedInstructionAccount,
    target_version: VoteStateTargetVersion,
    new_collector: NewCommissionCollector,
    kind: CommissionKind,
    signers: &HashSet<Pubkey, S>,
    rent: &Rent,
) -> Result<(), InstructionError> {
    let mut vote_state = get_vote_state_handler_checked(vote_account, target_version)?;

    // Require authorized withdrawer to sign.
    verify_authorized_signer(vote_state.authorized_withdrawer(), signers)?;

    let new_collector_key = new_collector.validate_and_resolve_key(vote_account, rent)?;

    match kind {
        CommissionKind::InflationRewards => {
            vote_state.set_inflation_rewards_collector(new_collector_key);
        }
        CommissionKind::BlockRevenue => {
            vote_state.set_block_revenue_collector(new_collector_key);
        }
    }

    vote_state.set_vote_account_state(vote_account)
}

/// Deposit delegator rewards into a vote account (SIMD-0123).
pub fn deposit_delegator_rewards<S: std::hash::BuildHasher>(
    invoke_context: &mut InvokeContext,
    vote_account_index: IndexOfAccount,
    sender_account_index: IndexOfAccount,
    deposit: u64,
    signers: &HashSet<Pubkey, S>,
) -> Result<(), InstructionError> {
    let transaction_context = &invoke_context.transaction_context;
    let instruction_context = transaction_context.get_current_instruction_context()?;

    let vote_address = *instruction_context.get_key_of_instruction_account(vote_account_index)?;
    let source_address =
        *instruction_context.get_key_of_instruction_account(sender_account_index)?;

    // Source account must sign the transfer.
    verify_authorized_signer(&source_address, signers)?;

    // SIMD-0123 states we must validate the vote account deserializes to a v4
    // *before* attempting CPI, then update the `pending_delegator_rewards`
    // field *last*.
    // We can deserialize it, and hold onto the deserialized payload in-memory.
    // This way, we can drop the account borrow but avoid re-deserializing
    // later, since we know only lamports will change.
    let mut vote_state = {
        let vote_account =
            instruction_context.try_borrow_instruction_account(vote_account_index)?;

        // Can't use `get_vote_state_handler_checked`, since it will convert
        // the underlying vote state to v4.
        // SIMD-0123 requires an *initialized v4*.
        let versioned = VoteStateVersionsInline::deserialize(vote_account.get_data())?;
        if let VoteStateVersionsInline::V4(vote_state_v4) = versioned {
            Ok(VoteStateHandler::new_v4(vote_state_v4))
        } else {
            Err(InstructionError::InvalidAccountData)
        }
    }?;

    // CPI to System: Transfer from sender to vote account.
    invoke_context.native_invoke_signed(
        system_instruction::transfer(&source_address, &vote_address, deposit),
        &[],
    )?;

    // Update `pending_delegator_rewards`.
    let transaction_context = &invoke_context.transaction_context;
    let instruction_context = transaction_context.get_current_instruction_context()?;
    let mut vote_account =
        instruction_context.try_borrow_instruction_account(vote_account_index)?;

    vote_state.add_pending_delegator_rewards(deposit)?;
    vote_state.set_vote_account_state(&mut vote_account)
}

/// Given the current slot and epoch schedule, determine if a commission change
/// is allowed
pub fn is_commission_update_allowed(slot: Slot, epoch_schedule: &EpochSchedule) -> bool {
    // always allowed during warmup epochs
    if let Some(relative_slot) = slot
        .saturating_sub(epoch_schedule.first_normal_slot)
        .checked_rem(epoch_schedule.slots_per_epoch)
    {
        // allowed up to the midpoint of the epoch
        relative_slot.saturating_mul(2) <= epoch_schedule.slots_per_epoch
    } else {
        // no slots per epoch, just allow it, even though this should never happen
        true
    }
}

fn verify_authorized_signer<S: std::hash::BuildHasher>(
    authorized: &Pubkey,
    signers: &HashSet<Pubkey, S>,
) -> Result<(), InstructionError> {
    if signers.contains(authorized) {
        Ok(())
    } else {
        Err(InstructionError::MissingRequiredSignature)
    }
}

// The message size is fixed:
// "ALPENGLOW" (9) + Vote Pubkey (32) = 41 bytes
// Note: The BLS Pubkey (48 bytes) is appended dynamically by the
// solana-bls-signatures crate.
const POP_MESSAGE_SIZE: usize = 9 + size_of::<Pubkey>();

pub(crate) fn generate_pop_message(vote_account_pubkey: &Pubkey) -> [u8; POP_MESSAGE_SIZE] {
    const LABEL_LEN: usize = 9;
    const PUBKEY_LEN: usize = size_of::<Pubkey>();

    const LABEL_START: usize = 0;
    const LABEL_END: usize = LABEL_START + LABEL_LEN;

    const PUBKEY_START: usize = LABEL_END;
    const PUBKEY_END: usize = PUBKEY_START + PUBKEY_LEN;

    // Make sure POP_MESSAGE_SIZE matches the layout at compile time
    const _: () = assert!(PUBKEY_END == POP_MESSAGE_SIZE);

    let mut message = [0u8; POP_MESSAGE_SIZE];

    message[LABEL_START..LABEL_END].copy_from_slice(b"ALPENGLOW");
    message[PUBKEY_START..PUBKEY_END].copy_from_slice(vote_account_pubkey.as_ref());

    message
}

pub fn verify_bls_proof_of_possession<F>(
    vote_account_pubkey: &Pubkey,
    bls_pubkey_compressed_bytes: &[u8; BLS_PUBLIC_KEY_COMPRESSED_SIZE],
    bls_proof_of_possession_compressed_bytes: &[u8; BLS_PROOF_OF_POSSESSION_COMPRESSED_SIZE],
    consume_pop_compute_units: F,
) -> Result<(), InstructionError>
where
    F: FnOnce() -> Result<(), InstructionError>,
{
    // Consume CUs for BLS verification (SIMD-0387).
    consume_pop_compute_units()?;

    let message = generate_pop_message(vote_account_pubkey);
    bls_proof_of_possession_compressed_bytes
        .verify(bls_pubkey_compressed_bytes, Some(&message))
        .map_err(|_| InstructionError::InvalidArgument)
}

/// Withdraw funds from the vote account
pub fn withdraw<S: std::hash::BuildHasher>(
    instruction_context: &InstructionContext,
    vote_account_index: IndexOfAccount,
    target_version: VoteStateTargetVersion,
    lamports: u64,
    to_account_index: IndexOfAccount,
    signers: &HashSet<Pubkey, S>,
    rent_sysvar: &Rent,
    clock: &Clock,
) -> Result<(), InstructionError> {
    let mut vote_account =
        instruction_context.try_borrow_instruction_account(vote_account_index)?;
    let vote_state = get_vote_state_handler_checked(&vote_account, target_version)?;

    verify_authorized_signer(vote_state.authorized_withdrawer(), signers)?;

    let remaining_balance = vote_account
        .get_lamports()
        .checked_sub(lamports)
        .ok_or(InstructionError::InsufficientFunds)?;

    // Always zero until SIMD-0123 is activated.
    let pending_delegator_rewards = vote_state.pending_delegator_rewards();

    if remaining_balance == 0 {
        // SIMD-0123: vote account cannot be closed if
        // pending_delegator_rewards > 0.
        if pending_delegator_rewards > 0 {
            return Err(InstructionError::InsufficientFunds);
        }

        let reject_active_vote_account_close = vote_state
            .epoch_credits()
            .last()
            .map(|(last_epoch_with_credits, _, _)| {
                let current_epoch = clock.epoch;
                // if current_epoch - last_epoch_with_credits < 2 then the validator has received credits
                // either in the current epoch or the previous epoch. If it's >= 2 then it has been at least
                // one full epoch since the validator has received credits.
                current_epoch.saturating_sub(*last_epoch_with_credits) < 2
            })
            .unwrap_or(false);

        if reject_active_vote_account_close {
            return Err(VoteError::ActiveVoteAccountClose.into());
        } else {
            // Deinitialize upon zero-balance
            VoteStateHandler::deinitialize_vote_account_state(&mut vote_account, target_version)?;
        }
    } else {
        // SIMD-0123: withdrawable balance when pending_delegator_rewards > 0
        // is lamports - pending_delegator_rewards - rent_exempt_minimum.
        let min_rent_exempt_balance = rent_sysvar.minimum_balance(vote_account.get_data().len());
        let min_balance = min_rent_exempt_balance
            .checked_add(pending_delegator_rewards)
            .ok_or(InstructionError::ArithmeticOverflow)?;
        if remaining_balance < min_balance {
            return Err(InstructionError::InsufficientFunds);
        }
    }

    vote_account.checked_sub_lamports(lamports)?;
    drop(vote_account);
    let mut to_account = instruction_context.try_borrow_instruction_account(to_account_index)?;
    to_account.checked_add_lamports(lamports)?;
    Ok(())
}

/// Initialize the vote_state for a vote account using VoteInitV2
/// Assumes that the account is being init as part of a account creation or
/// balance transfer and that the transaction must be signed by the staker's
/// keys.
///
/// Also validates the inflation-rewards and block-revenue collector accounts
/// per SIMD-0464 (which delegates to the SIMD-0232 collector checks) and
/// verifies the BLS proof of possession for the authorized voter BLS pubkey.
pub fn initialize_account_v2<S: std::hash::BuildHasher, F>(
    vote_account: &mut BorrowedInstructionAccount,
    target_version: VoteStateTargetVersion,
    vote_init: &VoteInitV2,
    inflation_rewards_collector: NewCommissionCollector,
    block_revenue_collector: NewCommissionCollector,
    signers: &HashSet<Pubkey, S>,
    clock: &Clock,
    rent: &Rent,
    consume_pop_compute_units: F,
) -> Result<(), InstructionError>
where
    F: FnOnce() -> Result<(), InstructionError>,
{
    VoteStateHandler::check_vote_account_length(vote_account, target_version)?;
    let versioned = vote_account.get_state::<VoteStateVersions>()?;

    if !versioned.is_uninitialized() {
        return Err(InstructionError::AccountAlreadyInitialized);
    }

    // node must agree to accept this vote account
    verify_authorized_signer(&vote_init.node_pubkey, signers)?;

    // Per SIMD-0464, validate the collector accounts using the same checks as
    // `UpdateCommissionCollector` (SIMD-0232).
    let inflation_rewards_collector_key =
        inflation_rewards_collector.validate_and_resolve_key(vote_account, rent)?;
    let block_revenue_collector_key =
        block_revenue_collector.validate_and_resolve_key(vote_account, rent)?;

    // verify the BLS pubkey proof of possession
    verify_bls_proof_of_possession(
        vote_account.get_key(),
        &vote_init.authorized_voter_bls_pubkey,
        &vote_init.authorized_voter_bls_proof_of_possession,
        consume_pop_compute_units,
    )?;

    VoteStateHandler::init_vote_account_state_v2(
        vote_account,
        vote_init,
        &inflation_rewards_collector_key,
        &block_revenue_collector_key,
        clock,
        target_version,
    )
}

/// Initialize the vote_state for a vote account
/// Assumes that the account is being init as part of a account creation or balance transfer and
/// that the transaction must be signed by the staker's keys
pub fn initialize_account<S: std::hash::BuildHasher>(
    vote_account: &mut BorrowedInstructionAccount,
    target_version: VoteStateTargetVersion,
    vote_init: &VoteInit,
    signers: &HashSet<Pubkey, S>,
    clock: &Clock,
) -> Result<(), InstructionError> {
    VoteStateHandler::check_vote_account_length(vote_account, target_version)?;
    let versioned = vote_account.get_state::<VoteStateVersions>()?;

    if !versioned.is_uninitialized() {
        return Err(InstructionError::AccountAlreadyInitialized);
    }

    // node must agree to accept this vote account
    verify_authorized_signer(&vote_init.node_pubkey, signers)?;

    VoteStateHandler::init_vote_account_state(vote_account, vote_init, clock, target_version)
}

pub fn process_vote_with_account<S: std::hash::BuildHasher>(
    vote_account: &mut BorrowedInstructionAccount,
    target_version: VoteStateTargetVersion,
    slot_hashes: &[SlotHash],
    clock: &Clock,
    vote: &Vote,
    signers: &HashSet<Pubkey, S>,
) -> Result<(), InstructionError> {
    let mut vote_state = get_vote_state_handler_checked(vote_account, target_version)?;

    let authorized_voter = vote_state.get_and_update_authorized_voter(clock.epoch)?;
    verify_authorized_signer(&authorized_voter, signers)?;

    process_vote(&mut vote_state, vote, slot_hashes, clock.epoch, clock.slot)?;
    if let Some(timestamp) = vote.timestamp {
        vote.slots
            .iter()
            .max()
            .ok_or(VoteError::EmptySlots)
            .and_then(|slot| vote_state.process_timestamp(*slot, timestamp))?;
    }
    vote_state.set_vote_account_state(vote_account)
}

pub fn process_vote_state_update<S: std::hash::BuildHasher>(
    vote_account: &mut BorrowedInstructionAccount,
    target_version: VoteStateTargetVersion,
    slot_hashes: &[SlotHash],
    clock: &Clock,
    vote_state_update: VoteStateUpdate,
    signers: &HashSet<Pubkey, S>,
) -> Result<(), InstructionError> {
    let mut vote_state = get_vote_state_handler_checked(vote_account, target_version)?;

    let authorized_voter = vote_state.get_and_update_authorized_voter(clock.epoch)?;
    verify_authorized_signer(&authorized_voter, signers)?;

    do_process_vote_state_update(
        &mut vote_state,
        slot_hashes,
        clock.epoch,
        clock.slot,
        vote_state_update,
    )?;
    vote_state.set_vote_account_state(vote_account)
}

pub fn do_process_vote_state_update(
    vote_state: &mut VoteStateHandler,
    slot_hashes: &[SlotHash],
    epoch: u64,
    slot: u64,
    mut vote_state_update: VoteStateUpdate,
) -> Result<(), VoteError> {
    check_and_filter_proposed_vote_state(
        vote_state,
        &mut vote_state_update.lockouts,
        &mut vote_state_update.root,
        vote_state_update.hash,
        slot_hashes,
    )?;
    process_new_vote_state(
        vote_state,
        vote_state_update
            .lockouts
            .iter()
            .map(|lockout| LandedVote::from(*lockout))
            .collect(),
        vote_state_update.root,
        vote_state_update.timestamp,
        epoch,
        slot,
    )
}

pub fn process_tower_sync<S: std::hash::BuildHasher>(
    vote_account: &mut BorrowedInstructionAccount,
    target_version: VoteStateTargetVersion,
    slot_hashes: &[SlotHash],
    clock: &Clock,
    tower_sync: TowerSync,
    signers: &HashSet<Pubkey, S>,
) -> Result<(), InstructionError> {
    let mut vote_state = get_vote_state_handler_checked(vote_account, target_version)?;

    let authorized_voter = vote_state.get_and_update_authorized_voter(clock.epoch)?;
    verify_authorized_signer(&authorized_voter, signers)?;

    do_process_tower_sync(
        &mut vote_state,
        slot_hashes,
        clock.epoch,
        clock.slot,
        tower_sync,
    )?;
    vote_state.set_vote_account_state(vote_account)
}

fn do_process_tower_sync(
    vote_state: &mut VoteStateHandler,
    slot_hashes: &[SlotHash],
    epoch: u64,
    slot: u64,
    mut tower_sync: TowerSync,
) -> Result<(), VoteError> {
    check_and_filter_proposed_vote_state(
        vote_state,
        &mut tower_sync.lockouts,
        &mut tower_sync.root,
        tower_sync.hash,
        slot_hashes,
    )?;
    process_new_vote_state(
        vote_state,
        tower_sync
            .lockouts
            .iter()
            .map(|lockout| LandedVote::from(*lockout))
            .collect(),
        tower_sync.root,
        tower_sync.timestamp,
        epoch,
        slot,
    )
}

pub fn create_v4_account_with_authorized(
    node_pubkey: &Pubkey,
    authorized_voter: &Pubkey,
    authorized_voter_bls_pubkey: [u8; BLS_PUBLIC_KEY_COMPRESSED_SIZE],
    authorized_withdrawer: &Pubkey,
    inflation_rewards_commission_bps: u16,
    inflation_rewards_collector: &Pubkey,
    block_revenue_commission_bps: u16,
    block_revenue_collector: &Pubkey,
    lamports: u64,
) -> AccountSharedData {
    let mut vote_account = AccountSharedData::new(lamports, VoteStateV4::size_of(), &id());

    // PoP is stubbed here, since creation of an account assumes the account
    // was already initialized via `IntializeAccount` or `InitializeAccountV2`.
    let authorized_voter_bls_proof_of_possession = [0; BLS_PROOF_OF_POSSESSION_COMPRESSED_SIZE];

    let vote_state = VoteStateV4::new(
        &VoteInitV2 {
            node_pubkey: *node_pubkey,
            authorized_voter: *authorized_voter,
            authorized_voter_bls_pubkey,
            authorized_voter_bls_proof_of_possession,
            authorized_withdrawer: *authorized_withdrawer,
            inflation_rewards_commission_bps,
            block_revenue_commission_bps,
        },
        inflation_rewards_collector,
        block_revenue_collector,
        &Clock::default(),
    );

    VoteStateV4::serialize(
        &VoteStateVersions::V4(Box::new(vote_state)),
        vote_account.data_as_mut_slice(),
    )
    .unwrap();

    vote_account
}

pub fn create_bls_pubkey_and_proof_of_possession(
    vote_account_pubkey: &Pubkey,
) -> (
    [u8; BLS_PUBLIC_KEY_COMPRESSED_SIZE],
    [u8; BLS_PROOF_OF_POSSESSION_COMPRESSED_SIZE],
) {
    let bls_keypair = BLSKeypair::new();
    create_bls_proof_of_possession(vote_account_pubkey, &bls_keypair)
}

pub fn create_bls_proof_of_possession(
    vote_account_pubkey: &Pubkey,
    bls_keypair: &BLSKeypair,
) -> (
    [u8; BLS_PUBLIC_KEY_COMPRESSED_SIZE],
    [u8; BLS_PROOF_OF_POSSESSION_COMPRESSED_SIZE],
) {
    let bls_pubkey_bytes = bls_keypair.public.to_bytes_compressed();
    let message = generate_pop_message(vote_account_pubkey);

    let proof_of_possession = bls_keypair.proof_of_possession(Some(&message));
    let proof_of_possession_bytes = proof_of_possession.to_bytes_compressed();

    (bls_pubkey_bytes, proof_of_possession_bytes)
}

#[allow(clippy::arithmetic_side_effects)]
#[cfg(test)]
mod tests {
    use {
        super::*,
        assert_matches::assert_matches,
        solana_account::{AccountSharedData, ReadableAccount},
        solana_clock::DEFAULT_SLOTS_PER_EPOCH,
        solana_sha256_hasher::hash,
        solana_transaction_context::{
            instruction_accounts::InstructionAccount, transaction::TransactionContext,
        },
        solana_vote_interface::authorized_voters::AuthorizedVoters,
        test_case::{test_case, test_matrix},
    };

    const MAX_RECENT_VOTES: usize = 16;

    fn vote_state_new_for_test(
        vote_pubkey: &Pubkey,
        target_version: VoteStateTargetVersion,
    ) -> VoteStateHandler {
        let auth_pubkey = solana_pubkey::new_rand();
        let vote_init = VoteInit {
            node_pubkey: solana_pubkey::new_rand(),
            authorized_voter: auth_pubkey,
            authorized_withdrawer: auth_pubkey,
            commission: 0,
        };
        let clock = Clock::default();

        match target_version {
            VoteStateTargetVersion::V4 => VoteStateHandler::new_v4(VoteStateV4::new_with_defaults(
                vote_pubkey,
                &vote_init,
                &clock,
            )),
        }
    }

    #[test_case(VoteStateTargetVersion::V4 ; "VoteStateV4")]
    fn test_vote_state_upgrade_from_1_14_11(target_version: VoteStateTargetVersion) {
        let vote_pubkey = solana_pubkey::new_rand();
        let mut vote_state = vote_state_new_for_test(&vote_pubkey, target_version);

        // Simulate prior epochs completed with credits and each setting a new authorized voter
        vote_state.increment_credits(0, 100);
        assert_eq!(
            vote_state.set_new_authorized_voter(
                &solana_pubkey::new_rand(),
                0,
                1,
                None,
                |_pubkey| Ok(())
            ),
            Ok(())
        );
        vote_state.increment_credits(1, 200);
        assert_eq!(
            vote_state.set_new_authorized_voter(
                &solana_pubkey::new_rand(),
                1,
                2,
                None,
                |_pubkey| Ok(())
            ),
            Ok(())
        );
        vote_state.increment_credits(2, 300);
        assert_eq!(
            vote_state.set_new_authorized_voter(
                &solana_pubkey::new_rand(),
                2,
                3,
                None,
                |_pubkey| Ok(())
            ),
            Ok(())
        );

        // Simulate votes having occurred
        vec![
            100, 101, 102, 103, 104, 105, 106, 107, 108, 109, 110, 111, 112, 113, 114, 115, 116,
            117, 118, 119, 120, 121, 122, 123, 124, 125, 126, 127, 128, 129, 130, 131, 132, 133,
            134, 135,
        ]
        .into_iter()
        .for_each(|v| vote_state.process_next_vote_slot(v, 4, 0));

        // Create an initial vote account that is sized for the 1_14_11 version of vote state, and has only the
        // required lamports for rent exempt minimum at that size
        let vote_state_v1_14_11 = match target_version {
            VoteStateTargetVersion::V4 => {
                // v4 cannot be converted directly to V1_14_11.
                VoteState1_14_11 {
                    node_pubkey: *vote_state.node_pubkey(),
                    authorized_withdrawer: *vote_state.authorized_withdrawer(),
                    commission: vote_state.commission(),
                    votes: vote_state
                        .votes()
                        .iter()
                        .map(|landed_vote| (*landed_vote).into())
                        .collect(),
                    root_slot: vote_state.root_slot(),
                    authorized_voters: vote_state.authorized_voters().clone(),
                    epoch_credits: vote_state.epoch_credits().clone(),
                    last_timestamp: vote_state.last_timestamp().clone(),
                    prior_voters: CircBuf::default(), // v4 does not store prior_voters
                }
            }
        };
        let version1_14_11_serialized =
            bincode::serialize(&VoteStateVersions::V1_14_11(Box::new(vote_state_v1_14_11)))
                .unwrap();
        let version1_14_11_serialized_len = version1_14_11_serialized.len();
        let rent = Rent::default();
        let lamports = rent.minimum_balance(version1_14_11_serialized_len);
        let mut vote_account =
            AccountSharedData::new(lamports, version1_14_11_serialized_len, &id());
        vote_account.set_data_from_slice(&version1_14_11_serialized);

        // Create a fake TransactionContext with a fake InstructionContext with a single account which is the
        // vote account that was just created
        let processor_account = AccountSharedData::new(0, 0, &solana_sdk_ids::native_loader::id());
        let mut transaction_context = TransactionContext::new(
            vec![(id(), processor_account), (vote_pubkey, vote_account)],
            rent.clone(),
            0,
            0,
            1,
        );
        transaction_context
            .configure_top_level_instruction_for_tests(
                0,
                vec![InstructionAccount::new(1, false, true)],
                vec![],
            )
            .unwrap();
        let instruction_context = transaction_context.get_next_instruction_context().unwrap();

        // Get the BorrowedAccount from the InstructionContext which is what is used to manipulate and inspect account
        // state
        let mut borrowed_account = instruction_context
            .try_borrow_instruction_account(0)
            .unwrap();

        // Ensure that the vote state started out at 1_14_11
        let vote_state_version = borrowed_account.get_state::<VoteStateVersions>().unwrap();
        assert_matches!(vote_state_version, VoteStateVersions::V1_14_11(_));

        // Convert the vote state to current as would occur during vote instructions
        let converted_vote_state =
            get_vote_state_handler_checked(&borrowed_account, target_version).unwrap();

        // Check to make sure that the vote_state is unchanged
        assert!(vote_state == converted_vote_state);

        let vote_state = converted_vote_state;

        // Now re-set the vote account state, knowing the account only has
        // enough lamports for V1_14_11.
        match target_version {
            VoteStateTargetVersion::V4 => {
                // V4 will throw an error.
                assert_eq!(
                    vote_state
                        .clone()
                        .set_vote_account_state(&mut borrowed_account),
                    Err(InstructionError::AccountNotRentExempt)
                );
            }
        }

        // Convert the vote state to current as would occur during vote instructions
        let converted_vote_state =
            get_vote_state_handler_checked(&borrowed_account, target_version).unwrap();

        // Check to make sure that the vote_state is unchanged
        assert!(vote_state == converted_vote_state);

        let vote_state = converted_vote_state;

        // Now top-up the vote account's lamports to be rent exempt for the target version.
        let space = match target_version {
            VoteStateTargetVersion::V4 => VoteStateV4::size_of(),
        };
        assert_eq!(
            borrowed_account.set_lamports(rent.minimum_balance(space)),
            Ok(())
        );
        assert_eq!(
            vote_state
                .clone()
                .set_vote_account_state(&mut borrowed_account),
            Ok(())
        );

        // The vote state version should match the target version.
        let vote_state_version = borrowed_account.get_state::<VoteStateVersions>().unwrap();
        match target_version {
            VoteStateTargetVersion::V4 => {
                assert_matches!(vote_state_version, VoteStateVersions::V4(_));
            }
        }

        // Convert the vote state to current as would occur during vote instructions
        let converted_vote_state =
            get_vote_state_handler_checked(&borrowed_account, target_version).unwrap();

        // Check to make sure that the vote_state is unchanged
        assert_eq!(vote_state, converted_vote_state);
    }

    #[test_case(VoteStateTargetVersion::V4 ; "VoteStateV4")]
    fn test_vote_lockout(target_version: VoteStateTargetVersion) {
        let mut vote_state = vote_state_new_for_test(&solana_pubkey::new_rand(), target_version);

        for i in 0..(MAX_LOCKOUT_HISTORY + 1) {
            process_slot_vote_unchecked(&mut vote_state, (INITIAL_LOCKOUT * i) as u64);
        }

        // The last vote should have been popped b/c it reached a depth of MAX_LOCKOUT_HISTORY
        assert_eq!(vote_state.votes().len(), MAX_LOCKOUT_HISTORY);
        assert_eq!(vote_state.root_slot(), Some(0));
        check_lockouts(&vote_state);

        // One more vote that confirms the entire stack,
        // the root_slot should change to the
        // second vote
        let top_vote = vote_state.votes().front().unwrap().slot();
        let slot = vote_state.last_lockout().unwrap().last_locked_out_slot();
        process_slot_vote_unchecked(&mut vote_state, slot);
        assert_eq!(Some(top_vote), vote_state.root_slot());

        // Expire everything except the first vote
        let slot = vote_state
            .votes()
            .front()
            .unwrap()
            .lockout
            .last_locked_out_slot();
        process_slot_vote_unchecked(&mut vote_state, slot);
        // First vote and new vote are both stored for a total of 2 votes
        assert_eq!(vote_state.votes().len(), 2);
    }

    #[test_matrix(
        [VoteStateTargetVersion::V4],
        [true, false]
    )]
    fn test_update_commission(
        target_version: VoteStateTargetVersion,
        disable_commission_update_rule: bool,
    ) {
        let mut vote_state = vote_state_new_for_test(&solana_pubkey::new_rand(), target_version);
        let node_pubkey = *vote_state.node_pubkey();
        let withdrawer_pubkey = *vote_state.authorized_withdrawer();

        // Set commission to start.
        vote_state.set_commission(10);

        let serialized = vote_state.serialize();
        let serialized_len = serialized.len();
        let rent = Rent::default();
        let lamports = rent.minimum_balance(serialized_len);
        let mut vote_account = AccountSharedData::new(lamports, serialized_len, &id());
        vote_account.set_data_from_slice(&serialized);

        // Create a fake TransactionContext with a fake InstructionContext with a single account which is the
        // vote account that was just created
        let processor_account = AccountSharedData::new(0, 0, &solana_sdk_ids::native_loader::id());
        let mut transaction_context = TransactionContext::new(
            vec![(id(), processor_account), (node_pubkey, vote_account)],
            rent,
            0,
            0,
            1,
        );
        transaction_context
            .configure_top_level_instruction_for_tests(
                0,
                vec![InstructionAccount::new(1, false, true)],
                vec![],
            )
            .unwrap();
        let instruction_context = transaction_context.get_next_instruction_context().unwrap();

        // Get the BorrowedAccount from the InstructionContext which is what is used to manipulate and inspect account
        // state
        let mut borrowed_account = instruction_context
            .try_borrow_instruction_account(0)
            .unwrap();

        let epoch_schedule = std::sync::Arc::new(EpochSchedule::without_warmup());

        let first_half_clock = std::sync::Arc::new(Clock {
            slot: epoch_schedule.slots_per_epoch / 4,
            ..Clock::default()
        });

        let second_half_clock = std::sync::Arc::new(Clock {
            slot: (epoch_schedule.slots_per_epoch * 3) / 4,
            ..Clock::default()
        });

        let signers: HashSet<Pubkey> = vec![withdrawer_pubkey].into_iter().collect();

        // Increase commission in first half of epoch -- allowed
        assert_eq!(
            get_vote_state_handler_checked(&borrowed_account, target_version,)
                .unwrap()
                .commission(),
            10
        );
        assert_matches!(
            update_commission(
                &mut borrowed_account,
                target_version,
                11,
                &signers,
                &epoch_schedule,
                &first_half_clock,
                disable_commission_update_rule,
            ),
            Ok(())
        );
        assert_eq!(
            get_vote_state_handler_checked(&borrowed_account, target_version,)
                .unwrap()
                .commission(),
            11
        );

        // Increase commission in second half of epoch -- disallowed if update rule is enabled
        let result = update_commission(
            &mut borrowed_account,
            target_version,
            12,
            &signers,
            &epoch_schedule,
            &second_half_clock,
            disable_commission_update_rule,
        );
        let state_commission = get_vote_state_handler_checked(&borrowed_account, target_version)
            .unwrap()
            .commission();
        if disable_commission_update_rule {
            assert_matches!(result, Ok(()));
            assert_eq!(state_commission, 12);
        } else {
            assert_matches!(result, Err(_));
            assert_eq!(state_commission, 11);
        }

        // Decrease commission in first half of epoch -- always allowed
        assert_matches!(
            update_commission(
                &mut borrowed_account,
                target_version,
                10,
                &signers,
                &epoch_schedule,
                &first_half_clock,
                disable_commission_update_rule,
            ),
            Ok(())
        );
        assert_eq!(
            get_vote_state_handler_checked(&borrowed_account, target_version,)
                .unwrap()
                .commission(),
            10
        );

        assert_eq!(
            get_vote_state_handler_checked(&borrowed_account, target_version,)
                .unwrap()
                .commission(),
            10
        );

        // Decrease commission in second half of epoch -- always allowed
        assert_matches!(
            update_commission(
                &mut borrowed_account,
                target_version,
                9,
                &signers,
                &epoch_schedule,
                &second_half_clock,
                disable_commission_update_rule,
            ),
            Ok(())
        );
        assert_eq!(
            get_vote_state_handler_checked(&borrowed_account, target_version,)
                .unwrap()
                .commission(),
            9
        );
    }

    /// Test update_commission_bps (SIMD-0291).
    ///
    /// Unlike test_update_commission, SIMD-0291 has no timing restrictions
    /// (per SIMD-0249). Updates are always allowed regardless of epoch position.
    ///
    /// This test only uses V4 since SIMD-0291 depends on SIMD-0185 (VoteStateV4).
    #[test]
    fn test_update_commission_bps() {
        let target_version = VoteStateTargetVersion::V4;
        let mut vote_state = vote_state_new_for_test(&solana_pubkey::new_rand(), target_version);
        let withdrawer_pubkey = *vote_state.authorized_withdrawer();
        let node_pubkey = *vote_state.node_pubkey();

        // Set initial commission.
        vote_state.set_commission(10); // 10%

        let serialized = vote_state.serialize();
        let serialized_len = serialized.len();
        let rent = Rent::default();
        let lamports = rent.minimum_balance(serialized_len);
        let mut vote_account = AccountSharedData::new(lamports, serialized_len, &id());
        vote_account.set_data_from_slice(&serialized);

        let processor_account = AccountSharedData::new(0, 0, &solana_sdk_ids::native_loader::id());
        let mut transaction_context = TransactionContext::new(
            vec![(id(), processor_account), (node_pubkey, vote_account)],
            rent,
            0,
            0,
            1,
        );
        transaction_context
            .configure_top_level_instruction_for_tests(
                0,
                vec![InstructionAccount::new(1, false, true)],
                vec![],
            )
            .unwrap();
        let instruction_context = transaction_context.get_next_instruction_context().unwrap();
        let mut borrowed_account = instruction_context
            .try_borrow_instruction_account(0)
            .unwrap();

        let signers: HashSet<Pubkey> = vec![withdrawer_pubkey].into_iter().collect();
        let non_signers: HashSet<Pubkey> = HashSet::new();

        // `CommissionKind::BlockRevenue` returns `InvalidInstructionData` when
        // block_revenue_sharing is disabled.
        assert_eq!(
            update_commission_bps(
                &mut borrowed_account,
                target_version,
                500,
                CommissionKind::BlockRevenue,
                &signers,
                false, // block_revenue_sharing disabled
            ),
            Err(InstructionError::InvalidInstructionData)
        );

        // Missing signature returns `MissingRequiredSignature`.
        assert_eq!(
            update_commission_bps(
                &mut borrowed_account,
                target_version,
                500,
                CommissionKind::InflationRewards,
                &non_signers,
                false,
            ),
            Err(InstructionError::MissingRequiredSignature)
        );

        // Incorrect signature for withdraw authority returns `MissingRequiredSignature`.
        let wrong_signers: HashSet<Pubkey> = vec![Pubkey::new_unique()].into_iter().collect();
        assert_eq!(
            update_commission_bps(
                &mut borrowed_account,
                target_version,
                500,
                CommissionKind::InflationRewards,
                &wrong_signers,
                false,
            ),
            Err(InstructionError::MissingRequiredSignature)
        );

        let mut commission_bps_roundtrip = |new_commission_bps: u16| {
            update_commission_bps(
                &mut borrowed_account,
                target_version,
                new_commission_bps,
                CommissionKind::InflationRewards,
                &signers,
                false,
            )
            .unwrap();
            update_commission_bps(
                &mut borrowed_account,
                target_version,
                new_commission_bps,
                CommissionKind::BlockRevenue,
                &signers,
                true,
            )
            .unwrap();
            let handler =
                get_vote_state_handler_checked(&borrowed_account, target_version).unwrap();
            assert_eq!(
                handler.as_ref_v4().inflation_rewards_commission_bps,
                new_commission_bps
            );
            assert_eq!(
                handler.as_ref_v4().block_revenue_commission_bps,
                new_commission_bps
            );
        };

        // There's no timing check for SIMD-0291, so just go back and forth
        // with new values.

        commission_bps_roundtrip(1_100); // Increase to 11%
        commission_bps_roundtrip(5_000); // Increase to 50%
        commission_bps_roundtrip(4_400); // Decrease to 44%
        commission_bps_roundtrip(4_600); // Increase to 46%

        // Values > 10,000 bps are allowed at program level.
        commission_bps_roundtrip(15_000); // 150%
        commission_bps_roundtrip(50_000); // 500%
    }

    #[test_case(VoteStateTargetVersion::V4 ; "VoteStateV4")]
    fn test_vote_double_lockout_after_expiration(target_version: VoteStateTargetVersion) {
        let mut vote_state = vote_state_new_for_test(&solana_pubkey::new_rand(), target_version);

        for i in 0..3 {
            process_slot_vote_unchecked(&mut vote_state, i as u64);
        }

        check_lockouts(&vote_state);

        // Expire the third vote (which was a vote for slot 2). The height of the
        // vote stack is unchanged, so none of the previous votes should have
        // doubled in lockout
        process_slot_vote_unchecked(&mut vote_state, (2 + INITIAL_LOCKOUT + 1) as u64);
        check_lockouts(&vote_state);

        // Vote again, this time the vote stack depth increases, so the votes should
        // double for everybody
        process_slot_vote_unchecked(&mut vote_state, (2 + INITIAL_LOCKOUT + 2) as u64);
        check_lockouts(&vote_state);

        // Vote again, this time the vote stack depth increases, so the votes should
        // double for everybody
        process_slot_vote_unchecked(&mut vote_state, (2 + INITIAL_LOCKOUT + 3) as u64);
        check_lockouts(&vote_state);
    }

    #[test_case(VoteStateTargetVersion::V4 ; "VoteStateV4")]
    fn test_expire_multiple_votes(target_version: VoteStateTargetVersion) {
        let mut vote_state = vote_state_new_for_test(&solana_pubkey::new_rand(), target_version);

        for i in 0..3 {
            process_slot_vote_unchecked(&mut vote_state, i as u64);
        }

        assert_eq!(vote_state.votes()[0].confirmation_count(), 3);

        // Expire the second and third votes
        let expire_slot =
            vote_state.votes()[1].slot() + vote_state.votes()[1].lockout.lockout() + 1;
        process_slot_vote_unchecked(&mut vote_state, expire_slot);
        assert_eq!(vote_state.votes().len(), 2);

        // Check that the old votes expired
        assert_eq!(vote_state.votes()[0].slot(), 0);
        assert_eq!(vote_state.votes()[1].slot(), expire_slot);

        // Process one more vote
        process_slot_vote_unchecked(&mut vote_state, expire_slot + 1);

        // Confirmation count for the older first vote should remain unchanged
        assert_eq!(vote_state.votes()[0].confirmation_count(), 3);

        // The later votes should still have increasing confirmation counts
        assert_eq!(vote_state.votes()[1].confirmation_count(), 2);
        assert_eq!(vote_state.votes()[2].confirmation_count(), 1);
    }

    #[test_case(VoteStateTargetVersion::V4 ; "VoteStateV4")]
    fn test_vote_credits(target_version: VoteStateTargetVersion) {
        let mut vote_state = vote_state_new_for_test(&solana_pubkey::new_rand(), target_version);

        for i in 0..MAX_LOCKOUT_HISTORY {
            process_slot_vote_unchecked(&mut vote_state, i as u64);
        }

        assert_eq!(vote_state.credits(), 0);

        process_slot_vote_unchecked(&mut vote_state, MAX_LOCKOUT_HISTORY as u64 + 1);
        assert_eq!(vote_state.credits(), 1);
        process_slot_vote_unchecked(&mut vote_state, MAX_LOCKOUT_HISTORY as u64 + 2);
        assert_eq!(vote_state.credits(), 2);
        process_slot_vote_unchecked(&mut vote_state, MAX_LOCKOUT_HISTORY as u64 + 3);
        assert_eq!(vote_state.credits(), 3);
    }

    #[test_case(VoteStateTargetVersion::V4 ; "VoteStateV4")]
    fn test_duplicate_vote(target_version: VoteStateTargetVersion) {
        let mut vote_state = vote_state_new_for_test(&solana_pubkey::new_rand(), target_version);
        process_slot_vote_unchecked(&mut vote_state, 0);
        process_slot_vote_unchecked(&mut vote_state, 1);
        process_slot_vote_unchecked(&mut vote_state, 0);
        assert_eq!(vote_state.nth_recent_lockout(0).unwrap().slot(), 1);
        assert_eq!(vote_state.nth_recent_lockout(1).unwrap().slot(), 0);
        assert!(vote_state.nth_recent_lockout(2).is_none());
    }

    #[test_case(VoteStateTargetVersion::V4 ; "VoteStateV4")]
    fn test_nth_recent_lockout(target_version: VoteStateTargetVersion) {
        let mut vote_state = vote_state_new_for_test(&solana_pubkey::new_rand(), target_version);
        for i in 0..MAX_LOCKOUT_HISTORY {
            process_slot_vote_unchecked(&mut vote_state, i as u64);
        }
        for i in 0..(MAX_LOCKOUT_HISTORY - 1) {
            assert_eq!(
                vote_state.nth_recent_lockout(i).unwrap().slot() as usize,
                MAX_LOCKOUT_HISTORY - i - 1,
            );
        }
        assert!(vote_state.nth_recent_lockout(MAX_LOCKOUT_HISTORY).is_none());
    }

    fn check_lockouts(vote_state: &VoteStateHandler) {
        let votes = vote_state.votes();
        for (i, vote) in votes.iter().enumerate() {
            let num_votes = votes
                .len()
                .checked_sub(i)
                .expect("`i` is less than `vote_state.votes().len()`");
            assert_eq!(
                vote.lockout.lockout(),
                INITIAL_LOCKOUT.pow(num_votes as u32) as u64
            );
        }
    }

    fn recent_votes(vote_state: &VoteStateHandler) -> Vec<Vote> {
        let votes = vote_state.votes();
        let start = votes.len().saturating_sub(MAX_RECENT_VOTES);
        (start..votes.len())
            .map(|i| Vote::new(vec![votes.get(i).unwrap().slot()], Hash::default()))
            .collect()
    }

    /// check that two accounts with different data can be brought to the same state with one vote submission
    #[test_case(VoteStateTargetVersion::V4 ; "VoteStateV4")]
    fn test_process_missed_votes(target_version: VoteStateTargetVersion) {
        let mut vote_state_a = vote_state_new_for_test(&solana_pubkey::new_rand(), target_version);
        let mut vote_state_b = vote_state_new_for_test(&solana_pubkey::new_rand(), target_version);

        // process some votes on account a
        (0..5).for_each(|i| process_slot_vote_unchecked(&mut vote_state_a, i as u64));
        assert_ne!(recent_votes(&vote_state_a), recent_votes(&vote_state_b));

        // as long as b has missed less than "NUM_RECENT" votes both accounts should be in sync
        let slots = (0u64..MAX_RECENT_VOTES as u64).collect();
        let vote = Vote::new(slots, Hash::default());
        let slot_hashes: Vec<_> = vote.slots.iter().rev().map(|x| (*x, vote.hash)).collect();

        assert_eq!(
            process_vote(&mut vote_state_a, &vote, &slot_hashes, 0, 0),
            Ok(())
        );
        assert_eq!(
            process_vote(&mut vote_state_b, &vote, &slot_hashes, 0, 0),
            Ok(())
        );
        assert_eq!(recent_votes(&vote_state_a), recent_votes(&vote_state_b));
    }

    #[test_case(VoteStateHandler::default_v4() ; "VoteStateV4")]
    fn test_process_vote_skips_old_vote(mut vote_state: VoteStateHandler) {
        let vote = Vote::new(vec![0], Hash::default());
        let slot_hashes: Vec<_> = vec![(0, vote.hash)];
        assert_eq!(
            process_vote(&mut vote_state, &vote, &slot_hashes, 0, 0),
            Ok(())
        );
        let recent = recent_votes(&vote_state);
        assert_eq!(
            process_vote(&mut vote_state, &vote, &slot_hashes, 0, 0),
            Err(VoteError::VoteTooOld)
        );
        assert_eq!(recent, recent_votes(&vote_state));
    }

    #[test_case(VoteStateHandler::default_v4() ; "VoteStateV4")]
    fn test_check_slots_are_valid_vote_empty_slot_hashes(vote_state: VoteStateHandler) {
        let vote = Vote::new(vec![0], Hash::default());
        assert_eq!(
            check_slots_are_valid(&vote_state, &vote.slots, &vote.hash, &[]),
            Err(VoteError::VoteTooOld)
        );
    }

    #[test_case(VoteStateHandler::default_v4() ; "VoteStateV4")]
    fn test_check_slots_are_valid_new_vote(vote_state: VoteStateHandler) {
        let vote = Vote::new(vec![0], Hash::default());
        let slot_hashes: Vec<_> = vec![(*vote.slots.last().unwrap(), vote.hash)];
        assert_eq!(
            check_slots_are_valid(&vote_state, &vote.slots, &vote.hash, &slot_hashes),
            Ok(())
        );
    }

    #[test_case(VoteStateHandler::default_v4() ; "VoteStateV4")]
    fn test_check_slots_are_valid_bad_hash(vote_state: VoteStateHandler) {
        let vote = Vote::new(vec![0], Hash::default());
        let slot_hashes: Vec<_> = vec![(*vote.slots.last().unwrap(), hash(vote.hash.as_ref()))];
        assert_eq!(
            check_slots_are_valid(&vote_state, &vote.slots, &vote.hash, &slot_hashes),
            Err(VoteError::SlotHashMismatch)
        );
    }

    #[test_case(VoteStateHandler::default_v4() ; "VoteStateV4")]
    fn test_check_slots_are_valid_bad_slot(vote_state: VoteStateHandler) {
        let vote = Vote::new(vec![1], Hash::default());
        let slot_hashes: Vec<_> = vec![(0, vote.hash)];
        assert_eq!(
            check_slots_are_valid(&vote_state, &vote.slots, &vote.hash, &slot_hashes),
            Err(VoteError::SlotsMismatch)
        );
    }

    #[test_case(VoteStateHandler::default_v4() ; "VoteStateV4")]
    fn test_check_slots_are_valid_duplicate_vote(mut vote_state: VoteStateHandler) {
        let vote = Vote::new(vec![0], Hash::default());
        let slot_hashes: Vec<_> = vec![(*vote.slots.last().unwrap(), vote.hash)];
        assert_eq!(
            process_vote(&mut vote_state, &vote, &slot_hashes, 0, 0),
            Ok(())
        );
        assert_eq!(
            check_slots_are_valid(&vote_state, &vote.slots, &vote.hash, &slot_hashes),
            Err(VoteError::VoteTooOld)
        );
    }

    #[test_case(VoteStateHandler::default_v4() ; "VoteStateV4")]
    fn test_check_slots_are_valid_next_vote(mut vote_state: VoteStateHandler) {
        let vote = Vote::new(vec![0], Hash::default());
        let slot_hashes: Vec<_> = vec![(*vote.slots.last().unwrap(), vote.hash)];
        assert_eq!(
            process_vote(&mut vote_state, &vote, &slot_hashes, 0, 0),
            Ok(())
        );

        let vote = Vote::new(vec![0, 1], Hash::default());
        let slot_hashes: Vec<_> = vec![(1, vote.hash), (0, vote.hash)];
        assert_eq!(
            check_slots_are_valid(&vote_state, &vote.slots, &vote.hash, &slot_hashes),
            Ok(())
        );
    }

    #[test_case(VoteStateHandler::default_v4() ; "VoteStateV4")]
    fn test_check_slots_are_valid_next_vote_only(mut vote_state: VoteStateHandler) {
        let vote = Vote::new(vec![0], Hash::default());
        let slot_hashes: Vec<_> = vec![(*vote.slots.last().unwrap(), vote.hash)];
        assert_eq!(
            process_vote(&mut vote_state, &vote, &slot_hashes, 0, 0),
            Ok(())
        );

        let vote = Vote::new(vec![1], Hash::default());
        let slot_hashes: Vec<_> = vec![(1, vote.hash), (0, vote.hash)];
        assert_eq!(
            check_slots_are_valid(&vote_state, &vote.slots, &vote.hash, &slot_hashes),
            Ok(())
        );
    }

    #[test_case(VoteStateHandler::default_v4() ; "VoteStateV4")]
    fn test_process_vote_empty_slots(mut vote_state: VoteStateHandler) {
        let vote = Vote::new(vec![], Hash::default());
        assert_eq!(
            process_vote(&mut vote_state, &vote, &[], 0, 0),
            Err(VoteError::EmptySlots)
        );
    }

    pub fn process_new_vote_state_from_lockouts(
        vote_state: &mut VoteStateHandler,
        new_state: VecDeque<Lockout>,
        new_root: Option<Slot>,
        timestamp: Option<i64>,
        epoch: Epoch,
    ) -> Result<(), VoteError> {
        process_new_vote_state(
            vote_state,
            new_state.into_iter().map(LandedVote::from).collect(),
            new_root,
            timestamp,
            epoch,
            0,
        )
    }

    // Test vote credit updates after "one credit per slot" feature is enabled
    #[test_case(VoteStateHandler::default_v4() ; "VoteStateV4")]
    fn test_vote_state_update_increment_credits(mut vote_state: VoteStateHandler) {
        // Test data: a sequence of groups of votes to simulate having been cast, after each group a vote
        // state update is compared to "normal" vote processing to ensure that credits are earned equally
        let test_vote_groups: Vec<Vec<Slot>> = vec![
            // Initial set of votes that don't dequeue any slots, so no credits earned
            vec![1, 2, 3, 4, 5, 6, 7, 8],
            vec![
                9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21, 22, 23, 24, 25, 26, 27, 28, 29,
                30, 31,
            ],
            // Now a single vote which should result in the first root and first credit earned
            vec![32],
            // Now another vote, should earn one credit
            vec![33],
            // Two votes in sequence
            vec![34, 35],
            // 3 votes in sequence
            vec![36, 37, 38],
            // 30 votes in sequence
            vec![
                39, 40, 41, 42, 43, 44, 45, 46, 47, 48, 49, 50, 51, 52, 53, 54, 55, 56, 57, 58, 59,
                60, 61, 62, 63, 64, 65, 66, 67, 68,
            ],
            // 31 votes in sequence
            vec![
                69, 70, 71, 72, 73, 74, 75, 76, 77, 78, 79, 80, 81, 82, 83, 84, 85, 86, 87, 88, 89,
                90, 91, 92, 93, 94, 95, 96, 97, 98, 99,
            ],
            // Votes with expiry
            vec![100, 101, 106, 107, 112, 116, 120, 121, 122, 124],
            // More votes with expiry of a large number of votes
            vec![200, 201],
            vec![
                202, 203, 204, 205, 206, 207, 208, 209, 210, 211, 212, 213, 214, 215, 216, 217,
                218, 219, 220, 221, 222, 223, 224, 225, 226,
            ],
            vec![227, 228, 229, 230, 231, 232, 233, 234, 235, 236],
        ];

        for vote_group in test_vote_groups {
            // Duplicate vote_state so that the new vote can be applied
            let mut vote_state_after_vote = vote_state.clone();

            process_vote_unchecked(
                &mut vote_state_after_vote,
                Vote {
                    slots: vote_group.clone(),
                    hash: Hash::new_unique(),
                    timestamp: None,
                },
            )
            .unwrap();

            // Now use the resulting new vote state to perform a vote state update on vote_state
            assert_eq!(
                process_new_vote_state(
                    &mut vote_state,
                    vote_state_after_vote.votes().clone(),
                    vote_state_after_vote.root_slot(),
                    None,
                    0,
                    0,
                ),
                Ok(())
            );

            // And ensure that the credits earned were the same
            assert_eq!(
                vote_state.epoch_credits(),
                vote_state_after_vote.epoch_credits()
            );
        }
    }

    // Test vote credit updates after "timely vote credits" feature is enabled
    #[test_case(VoteStateTargetVersion::V4 ; "VoteStateV4")]
    fn test_timely_credits(target_version: VoteStateTargetVersion) {
        // Each of the following (Vec<Slot>, Slot, u32) tuples gives a set of slots to cast votes on, a slot in which
        // the vote was cast, and the number of credits that should have been earned by the vote account after this
        // and all prior votes were cast.
        let test_vote_groups: Vec<(Vec<Slot>, Slot, u32)> = vec![
            // Initial set of votes that don't dequeue any slots, so no credits earned
            (
                vec![1, 2, 3, 4, 5, 6, 7, 8],
                9,
                // root: none, no credits earned
                0,
            ),
            (
                vec![
                    9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21, 22, 23, 24, 25, 26, 27, 28,
                    29, 30, 31,
                ],
                34,
                // lockouts full
                // root: none, no credits earned
                0,
            ),
            // Now a single vote which should result in the first root and first credit earned
            (
                vec![32],
                35,
                // root: 1
                // when slot 1 was voted on in slot 9, it earned 10 credits
                10,
            ),
            // Now another vote, should earn one credit
            (
                vec![33],
                36,
                // root: 2
                // when slot 2 was voted on in slot 9, it earned 11 credits
                10 + 11, // 21
            ),
            // Two votes in sequence
            (
                vec![34, 35],
                37,
                // root: 4
                // when slots 3 and 4 were voted on in slot 9, they earned 12 and 13 credits
                21 + 12 + 13, // 46
            ),
            // 3 votes in sequence
            (
                vec![36, 37, 38],
                39,
                // root: 7
                // slots 5, 6, and 7 earned 14, 15, and 16 credits when voted in slot 9
                46 + 14 + 15 + 16, // 91
            ),
            (
                // 30 votes in sequence
                vec![
                    39, 40, 41, 42, 42, 43, 44, 45, 46, 47, 48, 49, 50, 51, 52, 53, 54, 55, 56, 57,
                    58, 59, 60, 61, 62, 63, 64, 65, 66, 67, 68,
                ],
                69,
                // root: 37
                // slot 8 was voted in slot 9, earning 16 credits
                // slots 9 - 25 earned 1, 1, 1, 1, 1, 1, 1, 1, 1, 2, 3, 4, 5, 6, 7, 8, and 9 credits when voted in
                //   slot 34
                // slot 26, 27, 28, 29, 30, 31 earned 10, 11, 12, 13, 14, 15 credits when voted in slot 34
                // slot 32 earned 15 credits when voted in slot 35
                // slot 33 earned 15 credits when voted in slot 36
                // slot 34 and 35 earned 15 and 16 credits when voted in slot 37
                // slot 36 and 37 earned 15 and 16 credits when voted in slot 39
                91 + 16
                    + 9 // * 1
                    + 2
                    + 3
                    + 4
                    + 5
                    + 6
                    + 7
                    + 8
                    + 9
                    + 10
                    + 11
                    + 12
                    + 13
                    + 14
                    + 15
                    + 15
                    + 15
                    + 15
                    + 16
                    + 15
                    + 16, // 327
            ),
            // 31 votes in sequence
            (
                vec![
                    69, 70, 71, 72, 73, 74, 75, 76, 77, 78, 79, 80, 81, 82, 83, 84, 85, 86, 87, 88,
                    89, 90, 91, 92, 93, 94, 95, 96, 97, 98, 99,
                ],
                100,
                // root: 68
                // slot 38 earned 16 credits when voted in slot 39
                // slot 39 - 60 earned 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 2, 3, 4, 5, 6, 7, 8, and 9 credits
                //   when voted in slot 69
                // slot 61, 62, 63, 64, 65, 66, 67, 68 earned 10, 11, 12, 13, 14, 15, 16, and 16 credits when
                //   voted in slot 69
                327 + 16
                    + 14 // * 1
                    + 2
                    + 3
                    + 4
                    + 5
                    + 6
                    + 7
                    + 8
                    + 9
                    + 10
                    + 11
                    + 12
                    + 13
                    + 14
                    + 15
                    + 16
                    + 16, // 508
            ),
            // Votes with expiry
            (
                vec![115, 116, 117, 118, 119, 120, 121, 122, 123, 124],
                130,
                // root: 74
                // slots 96 - 114 expire
                // slots 69 - 74 earned 1 credit when voted in slot 100
                508 + ((74 - 69) + 1), // 514
            ),
            // More votes with expiry of a large number of votes
            (
                vec![200, 201],
                202,
                // root: 74
                // slots 119 - 124 expire
                514,
            ),
            (
                vec![
                    202, 203, 204, 205, 206, 207, 208, 209, 210, 211, 212, 213, 214, 215, 216, 217,
                    218, 219, 220, 221, 222, 223, 224, 225, 226,
                ],
                227,
                // root: 95
                // slot 75 - 91 earned 1, 1, 1, 1, 1, 1, 1, 1, 1, 2, 3, 4, 5, 6, 7, 8, and 9 credits when voted in
                //   slot 100
                // slot 92, 93, 94, 95 earned 10, 11, 12, 13, credits when voted in slot 100
                514 + 9 + 2 + 3 + 4 + 5 + 6 + 7 + 8 + 9 + 10 + 11 + 12 + 13, // 613
            ),
            (
                vec![227, 228, 229, 230, 231, 232, 233, 234, 235, 236],
                237,
                // root: 205
                // slot 115 - 118 earned 3, 4, 5, and 6 credits when voted in slot 130
                // slot 200 and 201 earned 16 credits when voted in slot 202
                // slots 202 - 205 earned 1 credit when voted in slot 227
                613 + 3 + 4 + 5 + 6 + 16 + 16 + 1 + 1 + 1 + 1, // 667
            ),
        ];

        let new_vote_state = || match target_version {
            VoteStateTargetVersion::V4 => VoteStateHandler::default_v4(),
        };

        // For each vote group, process all vote groups leading up to it and it itself, and ensure that the number of
        // credits earned is correct for both regular votes and vote state updates
        for i in 0..test_vote_groups.len() {
            // Create a new VoteStateV3 for vote transaction
            let mut vote_state_1 = new_vote_state();
            // Create a new VoteStateV3 for vote state update transaction
            let mut vote_state_2 = new_vote_state();
            test_vote_groups.iter().take(i + 1).for_each(|vote_group| {
                let vote = Vote {
                    slots: vote_group.0.clone(), //vote_group.0 is the set of slots to cast votes on
                    hash: Hash::new_unique(),
                    timestamp: None,
                };
                let slot_hashes: Vec<_> =
                    vote.slots.iter().rev().map(|x| (*x, vote.hash)).collect();
                assert_eq!(
                    process_vote(
                        &mut vote_state_1,
                        &vote,
                        &slot_hashes,
                        0,
                        vote_group.1, // vote_group.1 is the slot in which the vote was cast
                    ),
                    Ok(())
                );

                assert_eq!(
                    process_new_vote_state(
                        &mut vote_state_2,
                        vote_state_1.votes().clone(),
                        vote_state_1.root_slot(),
                        None,
                        0,
                        vote_group.1, // vote_group.1 is the slot in which the vote was cast
                    ),
                    Ok(())
                );
            });

            // Ensure that the credits earned is correct for both vote states
            let vote_group = &test_vote_groups[i];
            assert_eq!(vote_state_1.credits(), vote_group.2 as u64); // vote_group.2 is the expected number of credits
            assert_eq!(vote_state_2.credits(), vote_group.2 as u64); // vote_group.2 is the expected number of credits
        }
    }

    #[test_case(VoteStateHandler::default_v4() ; "VoteStateV4")]
    fn test_retroactive_voting_timely_credits(mut vote_state: VoteStateHandler) {
        // Each of the following (Vec<(Slot, int)>, Slot, Option<Slot>, u32) tuples gives the following data:
        // Vec<(Slot, int)> -- the set of slots and confirmation_counts that is the proposed vote state
        // Slot -- the slot in which the proposed vote state landed
        // Option<Slot> -- the root after processing the proposed vote state
        // u32 -- the credits after processing the proposed vote state
        #[allow(clippy::type_complexity)]
        let test_vote_state_updates: Vec<(Vec<(Slot, u32)>, Slot, Option<Slot>, u32)> = vec![
            // proposed vote state to set initial vote state
            (
                vec![(7, 4), (8, 3), (9, 2), (10, 1)],
                11,
                // root: none
                None,
                // no credits earned
                0,
            ),
            // proposed vote state to include the missing slots *prior to previously included slots*
            (
                vec![
                    (1, 10),
                    (2, 9),
                    (3, 8),
                    (4, 7),
                    (5, 6),
                    (6, 5),
                    (7, 4),
                    (8, 3),
                    (9, 2),
                    (10, 1),
                ],
                12,
                // root: none
                None,
                // no credits earned
                0,
            ),
            // Now a single proposed vote state which roots all of the slots from 1 - 10
            (
                vec![
                    (11, 31),
                    (12, 30),
                    (13, 29),
                    (14, 28),
                    (15, 27),
                    (16, 26),
                    (17, 25),
                    (18, 24),
                    (19, 23),
                    (20, 22),
                    (21, 21),
                    (22, 20),
                    (23, 19),
                    (24, 18),
                    (25, 17),
                    (26, 16),
                    (27, 15),
                    (28, 14),
                    (29, 13),
                    (30, 12),
                    (31, 11),
                    (32, 10),
                    (33, 9),
                    (34, 8),
                    (35, 7),
                    (36, 6),
                    (37, 5),
                    (38, 4),
                    (39, 3),
                    (40, 2),
                    (41, 1),
                ],
                42,
                // root: 10
                Some(10),
                // when slots 1 - 6 were voted on in slot 12, they earned 7, 8, 9, 10, 11, and 12 credits
                // when slots 7 - 10 were voted on in slot 11, they earned 14, 15, 16, and 16 credits
                7 + 8 + 9 + 10 + 11 + 12 + 14 + 15 + 16 + 16,
            ),
        ];

        // Process the vote state updates in sequence and ensure that the credits earned after each is processed is
        // correct
        test_vote_state_updates
            .iter()
            .for_each(|proposed_vote_state| {
                let new_state = proposed_vote_state
                    .0 // proposed_vote_state.0 is the set of slots and confirmation_counts that is the proposed vote state
                    .iter()
                    .map(|(slot, confirmation_count)| LandedVote {
                        latency: 0,
                        lockout: Lockout::new_with_confirmation_count(*slot, *confirmation_count),
                    })
                    .collect::<VecDeque<LandedVote>>();
                assert_eq!(
                    process_new_vote_state(
                        &mut vote_state,
                        new_state,
                        proposed_vote_state.2, // proposed_vote_state.2 is root after processing the proposed vote state
                        None,
                        0,
                        proposed_vote_state.1, // proposed_vote_state.1 is the slot in which the proposed vote state was applied
                    ),
                    Ok(())
                );

                // Ensure that the credits earned is correct
                assert_eq!(vote_state.credits(), proposed_vote_state.3 as u64);
            });
    }

    #[test_case(VoteStateHandler::default_v4() ; "VoteStateV4")]
    fn test_process_new_vote_too_many_votes(mut vote_state1: VoteStateHandler) {
        let bad_votes: VecDeque<Lockout> = (0..=MAX_LOCKOUT_HISTORY)
            .map(|slot| {
                Lockout::new_with_confirmation_count(
                    slot as Slot,
                    (MAX_LOCKOUT_HISTORY - slot + 1) as u32,
                )
            })
            .collect();

        let current_epoch = vote_state1.current_epoch();
        assert_eq!(
            process_new_vote_state_from_lockouts(
                &mut vote_state1,
                bad_votes,
                None,
                None,
                current_epoch,
            ),
            Err(VoteError::TooManyVotes)
        );
    }

    #[test_case(VoteStateHandler::default_v4() ; "VoteStateV4")]
    fn test_process_new_vote_state_root_rollback(mut vote_state1: VoteStateHandler) {
        for i in 0..MAX_LOCKOUT_HISTORY + 2 {
            process_slot_vote_unchecked(&mut vote_state1, i as Slot);
        }
        assert_eq!(vote_state1.root_slot().unwrap(), 1);

        // Update vote_state2 with a higher slot so that `process_new_vote_state`
        // doesn't panic.
        let mut vote_state2 = vote_state1.clone();
        process_slot_vote_unchecked(&mut vote_state2, MAX_LOCKOUT_HISTORY as Slot + 3);

        // Trying to set a lesser root should error
        let lesser_root = Some(0);

        let current_epoch = vote_state2.current_epoch();
        assert_eq!(
            process_new_vote_state(
                &mut vote_state1,
                vote_state2.votes().clone(),
                lesser_root,
                None,
                current_epoch,
                0,
            ),
            Err(VoteError::RootRollBack)
        );

        // Trying to set root to None should error
        let none_root = None;
        assert_eq!(
            process_new_vote_state(
                &mut vote_state1,
                vote_state2.votes().clone(),
                none_root,
                None,
                current_epoch,
                0,
            ),
            Err(VoteError::RootRollBack)
        );
    }

    #[test_case(VoteStateHandler::default_v4() ; "VoteStateV4")]
    fn test_process_new_vote_state_zero_confirmations(mut vote_state1: VoteStateHandler) {
        let current_epoch = vote_state1.current_epoch();

        let bad_votes: VecDeque<Lockout> = vec![
            Lockout::new_with_confirmation_count(0, 0),
            Lockout::new_with_confirmation_count(1, 1),
        ]
        .into_iter()
        .collect();
        assert_eq!(
            process_new_vote_state_from_lockouts(
                &mut vote_state1,
                bad_votes,
                None,
                None,
                current_epoch,
            ),
            Err(VoteError::ZeroConfirmations)
        );

        let bad_votes: VecDeque<Lockout> = vec![
            Lockout::new_with_confirmation_count(0, 2),
            Lockout::new_with_confirmation_count(1, 0),
        ]
        .into_iter()
        .collect();
        assert_eq!(
            process_new_vote_state_from_lockouts(
                &mut vote_state1,
                bad_votes,
                None,
                None,
                current_epoch,
            ),
            Err(VoteError::ZeroConfirmations)
        );
    }

    #[test_case(VoteStateHandler::default_v4() ; "VoteStateV4")]
    fn test_process_new_vote_state_confirmations_too_large(initial_vote_state: VoteStateHandler) {
        let mut vote_state1 = initial_vote_state.clone();
        let current_epoch = vote_state1.current_epoch();

        let good_votes: VecDeque<Lockout> = vec![Lockout::new_with_confirmation_count(
            0,
            MAX_LOCKOUT_HISTORY as u32,
        )]
        .into_iter()
        .collect();

        process_new_vote_state_from_lockouts(
            &mut vote_state1,
            good_votes,
            None,
            None,
            current_epoch,
        )
        .unwrap();

        let mut vote_state1 = initial_vote_state;
        let bad_votes: VecDeque<Lockout> = vec![Lockout::new_with_confirmation_count(
            0,
            MAX_LOCKOUT_HISTORY as u32 + 1,
        )]
        .into_iter()
        .collect();
        assert_eq!(
            process_new_vote_state_from_lockouts(
                &mut vote_state1,
                bad_votes,
                None,
                None,
                current_epoch,
            ),
            Err(VoteError::ConfirmationTooLarge)
        );
    }

    #[test_case(VoteStateHandler::default_v4() ; "VoteStateV4")]
    fn test_process_new_vote_state_slot_smaller_than_root(mut vote_state1: VoteStateHandler) {
        let current_epoch = vote_state1.current_epoch();
        let root_slot = 5;

        let bad_votes: VecDeque<Lockout> = vec![
            Lockout::new_with_confirmation_count(root_slot, 2),
            Lockout::new_with_confirmation_count(root_slot + 1, 1),
        ]
        .into_iter()
        .collect();
        assert_eq!(
            process_new_vote_state_from_lockouts(
                &mut vote_state1,
                bad_votes,
                Some(root_slot),
                None,
                current_epoch,
            ),
            Err(VoteError::SlotSmallerThanRoot)
        );

        let bad_votes: VecDeque<Lockout> = vec![
            Lockout::new_with_confirmation_count(root_slot - 1, 2),
            Lockout::new_with_confirmation_count(root_slot + 1, 1),
        ]
        .into_iter()
        .collect();
        assert_eq!(
            process_new_vote_state_from_lockouts(
                &mut vote_state1,
                bad_votes,
                Some(root_slot),
                None,
                current_epoch,
            ),
            Err(VoteError::SlotSmallerThanRoot)
        );
    }

    #[test_case(VoteStateHandler::default_v4() ; "VoteStateV4")]
    fn test_process_new_vote_state_slots_not_ordered(mut vote_state1: VoteStateHandler) {
        let current_epoch = vote_state1.current_epoch();

        let bad_votes: VecDeque<Lockout> = vec![
            Lockout::new_with_confirmation_count(1, 2),
            Lockout::new_with_confirmation_count(0, 1),
        ]
        .into_iter()
        .collect();
        assert_eq!(
            process_new_vote_state_from_lockouts(
                &mut vote_state1,
                bad_votes,
                None,
                None,
                current_epoch,
            ),
            Err(VoteError::SlotsNotOrdered)
        );

        let bad_votes: VecDeque<Lockout> = vec![
            Lockout::new_with_confirmation_count(1, 2),
            Lockout::new_with_confirmation_count(1, 1),
        ]
        .into_iter()
        .collect();
        assert_eq!(
            process_new_vote_state_from_lockouts(
                &mut vote_state1,
                bad_votes,
                None,
                None,
                current_epoch,
            ),
            Err(VoteError::SlotsNotOrdered)
        );
    }

    #[test_case(VoteStateHandler::default_v4() ; "VoteStateV4")]
    fn test_process_new_vote_state_confirmations_not_ordered(mut vote_state1: VoteStateHandler) {
        let current_epoch = vote_state1.current_epoch();

        let bad_votes: VecDeque<Lockout> = vec![
            Lockout::new_with_confirmation_count(0, 1),
            Lockout::new_with_confirmation_count(1, 2),
        ]
        .into_iter()
        .collect();
        assert_eq!(
            process_new_vote_state_from_lockouts(
                &mut vote_state1,
                bad_votes,
                None,
                None,
                current_epoch,
            ),
            Err(VoteError::ConfirmationsNotOrdered)
        );

        let bad_votes: VecDeque<Lockout> = vec![
            Lockout::new_with_confirmation_count(0, 1),
            Lockout::new_with_confirmation_count(1, 1),
        ]
        .into_iter()
        .collect();
        assert_eq!(
            process_new_vote_state_from_lockouts(
                &mut vote_state1,
                bad_votes,
                None,
                None,
                current_epoch,
            ),
            Err(VoteError::ConfirmationsNotOrdered)
        );
    }

    #[test_case(VoteStateHandler::default_v4() ; "VoteStateV4")]
    fn test_process_new_vote_state_new_vote_state_lockout_mismatch(
        mut vote_state1: VoteStateHandler,
    ) {
        let current_epoch = vote_state1.current_epoch();

        let bad_votes: VecDeque<Lockout> = vec![
            Lockout::new_with_confirmation_count(0, 2),
            Lockout::new_with_confirmation_count(7, 1),
        ]
        .into_iter()
        .collect();

        // Slot 7 should have expired slot 0
        assert_eq!(
            process_new_vote_state_from_lockouts(
                &mut vote_state1,
                bad_votes,
                None,
                None,
                current_epoch,
            ),
            Err(VoteError::NewVoteStateLockoutMismatch)
        );
    }

    #[test_case(VoteStateHandler::default_v4() ; "VoteStateV4")]
    fn test_process_new_vote_state_confirmation_rollback(mut vote_state1: VoteStateHandler) {
        let current_epoch = vote_state1.current_epoch();
        let votes: VecDeque<Lockout> = vec![
            Lockout::new_with_confirmation_count(0, 4),
            Lockout::new_with_confirmation_count(1, 3),
        ]
        .into_iter()
        .collect();
        process_new_vote_state_from_lockouts(&mut vote_state1, votes, None, None, current_epoch)
            .unwrap();

        let votes: VecDeque<Lockout> = vec![
            Lockout::new_with_confirmation_count(0, 4),
            // Confirmation count lowered illegally
            Lockout::new_with_confirmation_count(1, 2),
            Lockout::new_with_confirmation_count(2, 1),
        ]
        .into_iter()
        .collect();
        // Should error because newer vote state should not have lower confirmation the same slot
        // 1
        assert_eq!(
            process_new_vote_state_from_lockouts(
                &mut vote_state1,
                votes,
                None,
                None,
                current_epoch,
            ),
            Err(VoteError::ConfirmationRollBack)
        );
    }

    #[test_case(VoteStateHandler::default_v4() ; "VoteStateV4")]
    fn test_process_new_vote_state_root_progress(mut vote_state1: VoteStateHandler) {
        for i in 0..MAX_LOCKOUT_HISTORY {
            process_slot_vote_unchecked(&mut vote_state1, i as u64);
        }

        assert!(vote_state1.root_slot().is_none());
        let mut vote_state2 = vote_state1.clone();

        // 1) Try to update `vote_state1` with no root,
        // to `vote_state2`, which has a new root, should succeed.
        //
        // 2) Then try to update`vote_state1` with an existing root,
        // to `vote_state2`, which has a newer root, which
        // should succeed.
        for new_vote in MAX_LOCKOUT_HISTORY + 1..=MAX_LOCKOUT_HISTORY + 2 {
            process_slot_vote_unchecked(&mut vote_state2, new_vote as Slot);
            assert_ne!(vote_state1.root_slot(), vote_state2.root_slot());

            process_new_vote_state(
                &mut vote_state1,
                vote_state2.votes().clone(),
                vote_state2.root_slot(),
                None,
                vote_state2.current_epoch(),
                0,
            )
            .unwrap();

            assert_eq!(vote_state1, vote_state2);
        }
    }

    #[test_case(VoteStateHandler::default_v4() ; "VoteStateV4")]
    fn test_process_new_vote_state_same_slot_but_not_common_ancestor(
        initial_vote_state: VoteStateHandler,
    ) {
        // It might be possible that during the switch from old vote instructions
        // to new vote instructions, new_state contains votes for slots LESS
        // than the current state, for instance:
        //
        // Current on-chain state: 1, 5
        // New state: 1, 2 (lockout: 4), 3, 5, 7
        //
        // Imagine the validator made two of these votes:
        // 1) The first vote {1, 2, 3} didn't land in the old state, but didn't
        // land on chain
        // 2) A second vote {1, 2, 5} was then submitted, which landed
        //
        //
        // 2 is not popped off in the local tower because 3 doubled the lockout.
        // However, 3 did not land in the on-chain state, so the vote {1, 2, 6}
        // will immediately pop off 2.

        // Construct on-chain vote state
        let mut vote_state1 = initial_vote_state.clone();
        process_slot_votes_unchecked(&mut vote_state1, &[1, 2, 5]);
        assert_eq!(
            vote_state1
                .votes()
                .iter()
                .map(|vote| vote.slot())
                .collect::<Vec<Slot>>(),
            vec![1, 5]
        );

        // Construct local tower state
        let mut vote_state2 = initial_vote_state;
        process_slot_votes_unchecked(&mut vote_state2, &[1, 2, 3, 5, 7]);
        assert_eq!(
            vote_state2
                .votes()
                .iter()
                .map(|vote| vote.slot())
                .collect::<Vec<Slot>>(),
            vec![1, 2, 3, 5, 7]
        );

        // See that on-chain vote state can update properly
        process_new_vote_state(
            &mut vote_state1,
            vote_state2.votes().clone(),
            vote_state2.root_slot(),
            None,
            vote_state2.current_epoch(),
            0,
        )
        .unwrap();

        assert_eq!(vote_state1, vote_state2);
    }

    #[test_case(VoteStateHandler::default_v4() ; "VoteStateV4")]
    fn test_process_new_vote_state_lockout_violation(initial_vote_state: VoteStateHandler) {
        // Construct on-chain vote state
        let mut vote_state1 = initial_vote_state.clone();
        process_slot_votes_unchecked(&mut vote_state1, &[1, 2, 4, 5]);
        assert_eq!(
            vote_state1
                .votes()
                .iter()
                .map(|vote| vote.slot())
                .collect::<Vec<Slot>>(),
            vec![1, 2, 4, 5]
        );

        // Construct conflicting tower state. Vote 4 is missing,
        // but 5 should not have popped off vote 4.
        let mut vote_state2 = initial_vote_state;
        process_slot_votes_unchecked(&mut vote_state2, &[1, 2, 3, 5, 7]);
        assert_eq!(
            vote_state2
                .votes()
                .iter()
                .map(|vote| vote.slot())
                .collect::<Vec<Slot>>(),
            vec![1, 2, 3, 5, 7]
        );

        // See that on-chain vote state can update properly
        assert_eq!(
            process_new_vote_state(
                &mut vote_state1,
                vote_state2.votes().clone(),
                vote_state2.root_slot(),
                None,
                vote_state2.current_epoch(),
                0,
            ),
            Err(VoteError::LockoutConflict)
        );
    }

    #[test_case(VoteStateHandler::default_v4() ; "VoteStateV4")]
    fn test_process_new_vote_state_lockout_violation2(initial_vote_state: VoteStateHandler) {
        // Construct on-chain vote state
        let mut vote_state1 = initial_vote_state.clone();
        process_slot_votes_unchecked(&mut vote_state1, &[1, 2, 5, 6, 7]);
        assert_eq!(
            vote_state1
                .votes()
                .iter()
                .map(|vote| vote.slot())
                .collect::<Vec<Slot>>(),
            vec![1, 5, 6, 7]
        );

        // Construct a new vote state. Violates on-chain state because 8
        // should not have popped off 7
        let mut vote_state2 = initial_vote_state;
        process_slot_votes_unchecked(&mut vote_state2, &[1, 2, 3, 5, 6, 8]);
        assert_eq!(
            vote_state2
                .votes()
                .iter()
                .map(|vote| vote.slot())
                .collect::<Vec<Slot>>(),
            vec![1, 2, 3, 5, 6, 8]
        );

        // Both vote states contain `5`, but `5` is not part of the common prefix
        // of both vote states. However, the violation should still be detected.
        assert_eq!(
            process_new_vote_state(
                &mut vote_state1,
                vote_state2.votes().clone(),
                vote_state2.root_slot(),
                None,
                vote_state2.current_epoch(),
                0,
            ),
            Err(VoteError::LockoutConflict)
        );
    }

    #[test_case(VoteStateHandler::default_v4() ; "VoteStateV4")]
    fn test_process_new_vote_state_expired_ancestor_not_removed(mut vote_state1: VoteStateHandler) {
        // Construct on-chain vote state
        process_slot_votes_unchecked(&mut vote_state1, &[1, 2, 3, 9]);
        assert_eq!(
            vote_state1
                .votes()
                .iter()
                .map(|vote| vote.slot())
                .collect::<Vec<Slot>>(),
            vec![1, 9]
        );

        // Example: {1: lockout 8, 9: lockout 2}, vote on 10 will not pop off 1
        // because 9 is not popped off yet
        let mut vote_state2 = vote_state1.clone();
        process_slot_vote_unchecked(&mut vote_state2, 10);

        // Slot 1 has been expired by 10, but is kept alive by its descendant
        // 9 which has not been expired yet.
        assert_eq!(vote_state2.votes()[0].slot(), 1);
        assert_eq!(vote_state2.votes()[0].lockout.last_locked_out_slot(), 9);
        assert_eq!(
            vote_state2
                .votes()
                .iter()
                .map(|vote| vote.slot())
                .collect::<Vec<Slot>>(),
            vec![1, 9, 10]
        );

        // Should be able to update vote_state1
        process_new_vote_state(
            &mut vote_state1,
            vote_state2.votes().clone(),
            vote_state2.root_slot(),
            None,
            vote_state2.current_epoch(),
            0,
        )
        .unwrap();
        assert_eq!(vote_state1, vote_state2,);
    }

    #[test_case(VoteStateHandler::default_v4() ; "VoteStateV4")]
    fn test_process_new_vote_current_state_contains_bigger_slots(
        mut vote_state1: VoteStateHandler,
    ) {
        process_slot_votes_unchecked(&mut vote_state1, &[6, 7, 8]);
        assert_eq!(
            vote_state1
                .votes()
                .iter()
                .map(|vote| vote.slot())
                .collect::<Vec<Slot>>(),
            vec![6, 7, 8]
        );

        // Try to process something with lockout violations
        let bad_votes: VecDeque<Lockout> = vec![
            Lockout::new_with_confirmation_count(2, 5),
            // Slot 14 could not have popped off slot 6 yet
            Lockout::new_with_confirmation_count(14, 1),
        ]
        .into_iter()
        .collect();
        let root = Some(1);

        let current_epoch = vote_state1.current_epoch();
        assert_eq!(
            process_new_vote_state_from_lockouts(
                &mut vote_state1,
                bad_votes,
                root,
                None,
                current_epoch,
            ),
            Err(VoteError::LockoutConflict)
        );

        let good_votes: VecDeque<LandedVote> = vec![
            Lockout::new_with_confirmation_count(2, 5).into(),
            Lockout::new_with_confirmation_count(15, 1).into(),
        ]
        .into_iter()
        .collect();

        let current_epoch = vote_state1.current_epoch();
        process_new_vote_state(
            &mut vote_state1,
            good_votes.clone(),
            root,
            None,
            current_epoch,
            0,
        )
        .unwrap();
        assert_eq!(*vote_state1.votes(), good_votes);
    }

    #[test_case(VoteStateHandler::default_v4() ; "VoteStateV4")]
    fn test_filter_old_votes(mut vote_state: VoteStateHandler) {
        let old_vote_slot = 1;
        let vote = Vote::new(vec![old_vote_slot], Hash::default());

        // Vote with all slots that are all older than the SlotHashes history should
        // error with `VotesTooOldAllFiltered`
        let slot_hashes = vec![(3, Hash::new_unique()), (2, Hash::new_unique())];
        assert_eq!(
            process_vote(&mut vote_state, &vote, &slot_hashes, 0, 0),
            Err(VoteError::VotesTooOldAllFiltered)
        );

        // Vote with only some slots older than the SlotHashes history should
        // filter out those older slots
        let vote_slot = 2;
        let vote_slot_hash = slot_hashes
            .iter()
            .find(|(slot, _hash)| *slot == vote_slot)
            .unwrap()
            .1;

        let vote = Vote::new(vec![old_vote_slot, vote_slot], vote_slot_hash);
        process_vote(&mut vote_state, &vote, &slot_hashes, 0, 0).unwrap();
        assert_eq!(
            vote_state
                .votes()
                .iter()
                .map(|vote| vote.lockout)
                .collect::<Vec<Lockout>>(),
            vec![Lockout::new_with_confirmation_count(vote_slot, 1)]
        );
    }

    fn build_slot_hashes(slots: Vec<Slot>) -> Vec<(Slot, Hash)> {
        slots
            .iter()
            .rev()
            .map(|x| (*x, Hash::new_unique()))
            .collect()
    }

    fn build_vote_state(
        target_version: VoteStateTargetVersion,
        vote_slots: Vec<Slot>,
        slot_hashes: &[(Slot, Hash)],
    ) -> VoteStateHandler {
        let mut vote_state = match target_version {
            VoteStateTargetVersion::V4 => VoteStateHandler::default_v4(),
        };

        if !vote_slots.is_empty() {
            let vote_hash = slot_hashes
                .iter()
                .find(|(slot, _hash)| slot == vote_slots.last().unwrap())
                .unwrap()
                .1;
            let vote = Vote::new(vote_slots, vote_hash);
            process_vote_unfiltered(&mut vote_state, &vote.slots, &vote, slot_hashes, 0, 0)
                .unwrap();
        }

        vote_state
    }

    #[test_case(VoteStateTargetVersion::V4 ; "VoteStateV4")]
    fn test_check_and_filter_proposed_vote_state_empty(target_version: VoteStateTargetVersion) {
        let empty_slot_hashes = build_slot_hashes(vec![]);
        let empty_vote_state = build_vote_state(target_version, vec![], &empty_slot_hashes);

        // Test with empty TowerSync, should return EmptySlots error
        let mut tower_sync = TowerSync::from(vec![]);
        assert_eq!(
            check_and_filter_proposed_vote_state(
                &empty_vote_state,
                &mut tower_sync.lockouts,
                &mut tower_sync.root,
                tower_sync.hash,
                &empty_slot_hashes
            ),
            Err(VoteError::EmptySlots),
        );

        // Test with non-empty TowerSync, should return SlotsMismatch since nothing exists in SlotHashes
        let mut tower_sync = TowerSync::from(vec![(0, 1)]);
        assert_eq!(
            check_and_filter_proposed_vote_state(
                &empty_vote_state,
                &mut tower_sync.lockouts,
                &mut tower_sync.root,
                tower_sync.hash,
                &empty_slot_hashes
            ),
            Err(VoteError::SlotsMismatch),
        );
    }

    #[test_case(VoteStateTargetVersion::V4 ; "VoteStateV4")]
    fn test_check_and_filter_proposed_vote_state_too_old(target_version: VoteStateTargetVersion) {
        let slot_hashes = build_slot_hashes(vec![1, 2, 3, 4]);
        let latest_vote = 4;
        let vote_state = build_vote_state(target_version, vec![1, 2, 3, latest_vote], &slot_hashes);

        // Test with a vote for a slot less than the latest vote in the vote_state,
        // should return error `VoteTooOld`
        let mut tower_sync = TowerSync::from(vec![(latest_vote, 1)]);
        assert_eq!(
            check_and_filter_proposed_vote_state(
                &vote_state,
                &mut tower_sync.lockouts,
                &mut tower_sync.root,
                tower_sync.hash,
                &slot_hashes
            ),
            Err(VoteError::VoteTooOld),
        );

        // Test with a vote state update where the latest slot `X` in the update is
        // 1) Less than the earliest slot in slot_hashes history, AND
        // 2) `X` > latest_vote
        let earliest_slot_in_history = latest_vote + 2;
        let slot_hashes = build_slot_hashes(vec![earliest_slot_in_history]);
        let mut tower_sync = TowerSync::from(vec![(earliest_slot_in_history - 1, 1)]);
        assert_eq!(
            check_and_filter_proposed_vote_state(
                &vote_state,
                &mut tower_sync.lockouts,
                &mut tower_sync.root,
                tower_sync.hash,
                &slot_hashes
            ),
            Err(VoteError::VoteTooOld),
        );
    }

    fn run_test_check_and_filter_proposed_vote_state_older_than_history_root(
        target_version: VoteStateTargetVersion,
        earliest_slot_in_history: Slot,
        current_vote_state_slots: Vec<Slot>,
        current_vote_state_root: Option<Slot>,
        proposed_slots_and_lockouts: Vec<(Slot, u32)>,
        proposed_root: Slot,
        expected_root: Option<Slot>,
        expected_vote_state: Vec<Lockout>,
    ) {
        assert!(proposed_root < earliest_slot_in_history);
        assert_eq!(
            expected_root,
            current_vote_state_slots
                .iter()
                .rev()
                .find(|slot| **slot <= proposed_root)
                .cloned()
        );
        let latest_slot_in_history = proposed_slots_and_lockouts
            .last()
            .unwrap()
            .0
            .max(earliest_slot_in_history);
        let mut slot_hashes = build_slot_hashes(
            (current_vote_state_slots.first().copied().unwrap_or(0)..=latest_slot_in_history)
                .collect::<Vec<Slot>>(),
        );

        let mut vote_state =
            build_vote_state(target_version, current_vote_state_slots, &slot_hashes);
        vote_state.set_root_slot(current_vote_state_root);

        slot_hashes.retain(|slot| slot.0 >= earliest_slot_in_history);
        assert!(!proposed_slots_and_lockouts.is_empty());
        let proposed_hash = slot_hashes
            .iter()
            .find(|(slot, _hash)| *slot == proposed_slots_and_lockouts.last().unwrap().0)
            .unwrap()
            .1;

        // Test with a `TowerSync` where the root is less than `earliest_slot_in_history`.
        // Root slot in the `TowerSync` should be updated to match the root slot in the
        // current vote state
        let mut tower_sync = TowerSync::from(proposed_slots_and_lockouts);
        tower_sync.hash = proposed_hash;
        tower_sync.root = Some(proposed_root);
        check_and_filter_proposed_vote_state(
            &vote_state,
            &mut tower_sync.lockouts,
            &mut tower_sync.root,
            tower_sync.hash,
            &slot_hashes,
        )
        .unwrap();
        assert_eq!(tower_sync.root, expected_root);

        // The proposed root slot should become the biggest slot in the current vote state less than
        // `earliest_slot_in_history`.
        assert!(
            do_process_tower_sync(&mut vote_state, &slot_hashes, 0, 0, tower_sync.clone(),).is_ok()
        );
        assert_eq!(vote_state.root_slot(), expected_root);
        assert_eq!(
            vote_state
                .votes()
                .iter()
                .map(|vote| vote.lockout)
                .collect::<Vec<Lockout>>(),
            expected_vote_state,
        );
    }

    #[test_case(VoteStateTargetVersion::V4 ; "VoteStateV4")]
    fn test_check_and_filter_proposed_vote_state_older_than_history_root(
        target_version: VoteStateTargetVersion,
    ) {
        // Test when `proposed_root` is in `current_vote_state_slots` but it's not the latest
        // slot
        let earliest_slot_in_history = 5;
        let current_vote_state_slots: Vec<Slot> = vec![1, 2, 3, 4];
        let current_vote_state_root = None;
        let proposed_slots_and_lockouts = vec![(5, 1)];
        let proposed_root = 4;
        let expected_root = Some(4);
        let expected_vote_state = vec![Lockout::new_with_confirmation_count(5, 1)];
        run_test_check_and_filter_proposed_vote_state_older_than_history_root(
            target_version,
            earliest_slot_in_history,
            current_vote_state_slots,
            current_vote_state_root,
            proposed_slots_and_lockouts,
            proposed_root,
            expected_root,
            expected_vote_state,
        );

        // Test when `proposed_root` is in `current_vote_state_slots` but it's not the latest
        // slot and the `current_vote_state_root.is_some()`.
        let earliest_slot_in_history = 5;
        let current_vote_state_slots: Vec<Slot> = vec![1, 2, 3, 4];
        let current_vote_state_root = Some(0);
        let proposed_slots_and_lockouts = vec![(5, 1)];
        let proposed_root = 4;
        let expected_root = Some(4);
        let expected_vote_state = vec![Lockout::new_with_confirmation_count(5, 1)];
        run_test_check_and_filter_proposed_vote_state_older_than_history_root(
            target_version,
            earliest_slot_in_history,
            current_vote_state_slots,
            current_vote_state_root,
            proposed_slots_and_lockouts,
            proposed_root,
            expected_root,
            expected_vote_state,
        );

        // Test when `proposed_root` is in `current_vote_state_slots` but it's not the latest
        // slot
        let earliest_slot_in_history = 5;
        let current_vote_state_slots: Vec<Slot> = vec![1, 2, 3, 4];
        let current_vote_state_root = Some(0);
        let proposed_slots_and_lockouts = vec![(4, 2), (5, 1)];
        let proposed_root = 3;
        let expected_root = Some(3);
        let expected_vote_state = vec![
            Lockout::new_with_confirmation_count(4, 2),
            Lockout::new_with_confirmation_count(5, 1),
        ];
        run_test_check_and_filter_proposed_vote_state_older_than_history_root(
            target_version,
            earliest_slot_in_history,
            current_vote_state_slots,
            current_vote_state_root,
            proposed_slots_and_lockouts,
            proposed_root,
            expected_root,
            expected_vote_state,
        );

        // Test when `proposed_root` is not in `current_vote_state_slots`
        let earliest_slot_in_history = 5;
        let current_vote_state_slots: Vec<Slot> = vec![1, 2, 4];
        let current_vote_state_root = Some(0);
        let proposed_slots_and_lockouts = vec![(4, 2), (5, 1)];
        let proposed_root = 3;
        let expected_root = Some(2);
        let expected_vote_state = vec![
            Lockout::new_with_confirmation_count(4, 2),
            Lockout::new_with_confirmation_count(5, 1),
        ];
        run_test_check_and_filter_proposed_vote_state_older_than_history_root(
            target_version,
            earliest_slot_in_history,
            current_vote_state_slots,
            current_vote_state_root,
            proposed_slots_and_lockouts,
            proposed_root,
            expected_root,
            expected_vote_state,
        );

        // Test when the `proposed_root` is smaller than all the slots in
        // `current_vote_state_slots`, no roots should be set.
        let earliest_slot_in_history = 4;
        let current_vote_state_slots: Vec<Slot> = vec![3, 4];
        let current_vote_state_root = None;
        let proposed_slots_and_lockouts = vec![(3, 3), (4, 2), (5, 1)];
        let proposed_root = 2;
        let expected_root = None;
        let expected_vote_state = vec![
            Lockout::new_with_confirmation_count(3, 3),
            Lockout::new_with_confirmation_count(4, 2),
            Lockout::new_with_confirmation_count(5, 1),
        ];
        run_test_check_and_filter_proposed_vote_state_older_than_history_root(
            target_version,
            earliest_slot_in_history,
            current_vote_state_slots,
            current_vote_state_root,
            proposed_slots_and_lockouts,
            proposed_root,
            expected_root,
            expected_vote_state,
        );

        // Test when `current_vote_state_slots` is empty, no roots should be set
        let earliest_slot_in_history = 4;
        let current_vote_state_slots: Vec<Slot> = vec![];
        let current_vote_state_root = None;
        let proposed_slots_and_lockouts = vec![(5, 1)];
        let proposed_root = 2;
        let expected_root = None;
        let expected_vote_state = vec![Lockout::new_with_confirmation_count(5, 1)];
        run_test_check_and_filter_proposed_vote_state_older_than_history_root(
            target_version,
            earliest_slot_in_history,
            current_vote_state_slots,
            current_vote_state_root,
            proposed_slots_and_lockouts,
            proposed_root,
            expected_root,
            expected_vote_state,
        );
    }

    #[test_case(VoteStateTargetVersion::V4 ; "VoteStateV4")]
    fn test_check_and_filter_proposed_vote_state_slots_not_ordered(
        target_version: VoteStateTargetVersion,
    ) {
        let slot_hashes = build_slot_hashes(vec![1, 2, 3, 4]);
        let vote_state = build_vote_state(target_version, vec![1], &slot_hashes);

        // Test with a `TowerSync` where the slots are out of order
        let vote_slot = 3;
        let vote_slot_hash = slot_hashes
            .iter()
            .find(|(slot, _hash)| *slot == vote_slot)
            .unwrap()
            .1;
        let mut tower_sync = TowerSync::from(vec![(2, 2), (1, 3), (vote_slot, 1)]);
        tower_sync.hash = vote_slot_hash;
        assert_eq!(
            check_and_filter_proposed_vote_state(
                &vote_state,
                &mut tower_sync.lockouts,
                &mut tower_sync.root,
                tower_sync.hash,
                &slot_hashes
            ),
            Err(VoteError::SlotsNotOrdered),
        );

        // Test with a `TowerSync` where there are multiples of the same slot
        let mut tower_sync = TowerSync::from(vec![(2, 2), (2, 2), (vote_slot, 1)]);
        tower_sync.hash = vote_slot_hash;
        assert_eq!(
            check_and_filter_proposed_vote_state(
                &vote_state,
                &mut tower_sync.lockouts,
                &mut tower_sync.root,
                tower_sync.hash,
                &slot_hashes
            ),
            Err(VoteError::SlotsNotOrdered),
        );
    }

    #[test_case(VoteStateTargetVersion::V4 ; "VoteStateV4")]
    fn test_check_and_filter_proposed_vote_state_older_than_history_slots_filtered(
        target_version: VoteStateTargetVersion,
    ) {
        let slot_hashes = build_slot_hashes(vec![1, 2, 3, 4]);
        let mut vote_state = build_vote_state(target_version, vec![1, 2, 3, 4], &slot_hashes);

        // Test with a `TowerSync` where there:
        // 1) Exists a slot less than `earliest_slot_in_history`
        // 2) This slot does not exist in the vote state already
        // This slot should be filtered out
        let earliest_slot_in_history = 11;
        let slot_hashes = build_slot_hashes(vec![earliest_slot_in_history, 12, 13, 14]);
        let vote_slot = 12;
        let vote_slot_hash = slot_hashes
            .iter()
            .find(|(slot, _hash)| *slot == vote_slot)
            .unwrap()
            .1;
        let missing_older_than_history_slot = earliest_slot_in_history - 1;
        let mut tower_sync = TowerSync::from(vec![
            (1, 4),
            (missing_older_than_history_slot, 2),
            (vote_slot, 3),
        ]);
        tower_sync.hash = vote_slot_hash;
        check_and_filter_proposed_vote_state(
            &vote_state,
            &mut tower_sync.lockouts,
            &mut tower_sync.root,
            tower_sync.hash,
            &slot_hashes,
        )
        .unwrap();

        // Check the earlier slot was filtered out
        assert_eq!(
            tower_sync
                .clone()
                .lockouts
                .into_iter()
                .collect::<Vec<Lockout>>(),
            vec![
                Lockout::new_with_confirmation_count(1, 4),
                Lockout::new_with_confirmation_count(vote_slot, 3)
            ]
        );
        assert!(do_process_tower_sync(&mut vote_state, &slot_hashes, 0, 0, tower_sync,).is_ok());
    }

    #[test_case(VoteStateTargetVersion::V4 ; "VoteStateV4")]
    fn test_check_and_filter_proposed_vote_state_older_than_history_slots_not_filtered(
        target_version: VoteStateTargetVersion,
    ) {
        let slot_hashes = build_slot_hashes(vec![4]);
        let mut vote_state = build_vote_state(target_version, vec![4], &slot_hashes);

        // Test with a `TowerSync` where there:
        // 1) Exists a slot less than `earliest_slot_in_history`
        // 2) This slot exists in the vote state already
        // This slot should *NOT* be filtered out
        let earliest_slot_in_history = 11;
        let slot_hashes = build_slot_hashes(vec![earliest_slot_in_history, 12, 13, 14]);
        let vote_slot = 12;
        let vote_slot_hash = slot_hashes
            .iter()
            .find(|(slot, _hash)| *slot == vote_slot)
            .unwrap()
            .1;
        let existing_older_than_history_slot = 4;
        let mut tower_sync =
            TowerSync::from(vec![(existing_older_than_history_slot, 3), (vote_slot, 2)]);
        tower_sync.hash = vote_slot_hash;
        check_and_filter_proposed_vote_state(
            &vote_state,
            &mut tower_sync.lockouts,
            &mut tower_sync.root,
            tower_sync.hash,
            &slot_hashes,
        )
        .unwrap();
        // Check the earlier slot was *NOT* filtered out
        assert_eq!(tower_sync.lockouts.len(), 2);
        assert_eq!(
            tower_sync
                .clone()
                .lockouts
                .into_iter()
                .collect::<Vec<Lockout>>(),
            vec![
                Lockout::new_with_confirmation_count(existing_older_than_history_slot, 3),
                Lockout::new_with_confirmation_count(vote_slot, 2)
            ]
        );
        assert!(do_process_tower_sync(&mut vote_state, &slot_hashes, 0, 0, tower_sync,).is_ok());
    }

    #[test_case(VoteStateTargetVersion::V4 ; "VoteStateV4")]
    fn test_check_and_filter_proposed_vote_state_older_than_history_slots_filtered_and_not_filtered(
        target_version: VoteStateTargetVersion,
    ) {
        let slot_hashes = build_slot_hashes(vec![6]);
        let mut vote_state = build_vote_state(target_version, vec![6], &slot_hashes);

        // Test with a `TowerSync` where there exists both a slot:
        // 1) Less than `earliest_slot_in_history`
        // 2) This slot exists in the vote state already
        // which should not be filtered
        //
        // AND a slot that
        //
        // 1) Less than `earliest_slot_in_history`
        // 2) This slot does not exist in the vote state already
        // which should be filtered
        let earliest_slot_in_history = 11;
        let slot_hashes = build_slot_hashes(vec![earliest_slot_in_history, 12, 13, 14]);
        let vote_slot = 14;
        let vote_slot_hash = slot_hashes
            .iter()
            .find(|(slot, _hash)| *slot == vote_slot)
            .unwrap()
            .1;

        let missing_older_than_history_slot = 4;
        let existing_older_than_history_slot = 6;

        let mut tower_sync = TowerSync::from(vec![
            (missing_older_than_history_slot, 4),
            (existing_older_than_history_slot, 3),
            (12, 2),
            (vote_slot, 1),
        ]);
        tower_sync.hash = vote_slot_hash;
        check_and_filter_proposed_vote_state(
            &vote_state,
            &mut tower_sync.lockouts,
            &mut tower_sync.root,
            tower_sync.hash,
            &slot_hashes,
        )
        .unwrap();
        assert_eq!(tower_sync.lockouts.len(), 3);
        assert_eq!(
            tower_sync
                .clone()
                .lockouts
                .into_iter()
                .collect::<Vec<Lockout>>(),
            vec![
                Lockout::new_with_confirmation_count(existing_older_than_history_slot, 3),
                Lockout::new_with_confirmation_count(12, 2),
                Lockout::new_with_confirmation_count(vote_slot, 1)
            ]
        );
        assert!(do_process_tower_sync(&mut vote_state, &slot_hashes, 0, 0, tower_sync,).is_ok());
    }

    #[test_case(VoteStateTargetVersion::V4 ; "VoteStateV4")]
    fn test_check_and_filter_proposed_vote_state_slot_not_on_fork(
        target_version: VoteStateTargetVersion,
    ) {
        let slot_hashes = build_slot_hashes(vec![2, 4, 6, 8]);
        let vote_state = build_vote_state(target_version, vec![2, 4, 6], &slot_hashes);

        // Test with a `TowerSync` where there:
        // 1) Exists a slot not in the slot hashes history
        // 2) The slot is greater than the earliest slot in the history
        // Thus this slot is not part of the fork and the update should be rejected
        // with error `SlotsMismatch`
        let missing_vote_slot = 3;

        // Have to vote for a slot greater than the last vote in the vote state to avoid VoteTooOld
        // errors
        let vote_slot = vote_state.votes().back().unwrap().slot() + 2;
        let vote_slot_hash = slot_hashes
            .iter()
            .find(|(slot, _hash)| *slot == vote_slot)
            .unwrap()
            .1;
        let mut tower_sync = TowerSync::from(vec![(missing_vote_slot, 2), (vote_slot, 3)]);
        tower_sync.hash = vote_slot_hash;
        assert_eq!(
            check_and_filter_proposed_vote_state(
                &vote_state,
                &mut tower_sync.lockouts,
                &mut tower_sync.root,
                tower_sync.hash,
                &slot_hashes
            ),
            Err(VoteError::SlotsMismatch),
        );

        // Test where some earlier vote slots exist in the history, but others don't
        let missing_vote_slot = 7;
        let mut tower_sync = TowerSync::from(vec![
            (2, 5),
            (4, 4),
            (6, 3),
            (missing_vote_slot, 2),
            (vote_slot, 1),
        ]);
        tower_sync.hash = vote_slot_hash;
        assert_eq!(
            check_and_filter_proposed_vote_state(
                &vote_state,
                &mut tower_sync.lockouts,
                &mut tower_sync.root,
                tower_sync.hash,
                &slot_hashes
            ),
            Err(VoteError::SlotsMismatch),
        );
    }

    #[test_case(VoteStateTargetVersion::V4 ; "VoteStateV4")]
    fn test_check_and_filter_proposed_vote_state_root_on_different_fork(
        target_version: VoteStateTargetVersion,
    ) {
        let slot_hashes = build_slot_hashes(vec![2, 4, 6, 8]);
        let vote_state = build_vote_state(target_version, vec![6], &slot_hashes);

        // Test with a `TowerSync` where:
        // 1) The root is not present in slot hashes history
        // 2) The slot is greater than the earliest slot in the history
        // Thus this slot is not part of the fork and the update should be rejected
        // with error `RootOnDifferentFork`
        let new_root = 3;

        // Have to vote for a slot greater than the last vote in the vote state to avoid VoteTooOld
        // errors, but also this slot must be present in SlotHashes
        let vote_slot = 8;
        assert_eq!(vote_slot, slot_hashes.first().unwrap().0);
        let vote_slot_hash = slot_hashes
            .iter()
            .find(|(slot, _hash)| *slot == vote_slot)
            .unwrap()
            .1;
        let mut tower_sync = TowerSync::from(vec![(vote_slot, 1)]);
        tower_sync.hash = vote_slot_hash;
        tower_sync.root = Some(new_root);
        assert_eq!(
            check_and_filter_proposed_vote_state(
                &vote_state,
                &mut tower_sync.lockouts,
                &mut tower_sync.root,
                tower_sync.hash,
                &slot_hashes
            ),
            Err(VoteError::RootOnDifferentFork),
        );
    }

    #[test_case(VoteStateTargetVersion::V4 ; "VoteStateV4")]
    fn test_check_and_filter_proposed_vote_state_slot_newer_than_slot_history(
        target_version: VoteStateTargetVersion,
    ) {
        let slot_hashes = build_slot_hashes(vec![2, 4, 6, 8, 10]);
        let vote_state = build_vote_state(target_version, vec![2, 4, 6], &slot_hashes);

        // Test with a `TowerSync` where there:
        // 1) The last slot in the update is a slot not in the slot hashes history
        // 2) The slot is greater than the newest slot in the slot history
        // Thus this slot is not part of the fork and the update should be rejected
        // with error `SlotsMismatch`
        let missing_vote_slot = slot_hashes.first().unwrap().0 + 1;
        let vote_slot_hash = Hash::new_unique();
        let mut tower_sync = TowerSync::from(vec![(8, 2), (missing_vote_slot, 3)]);
        tower_sync.hash = vote_slot_hash;
        assert_eq!(
            check_and_filter_proposed_vote_state(
                &vote_state,
                &mut tower_sync.lockouts,
                &mut tower_sync.root,
                tower_sync.hash,
                &slot_hashes
            ),
            Err(VoteError::SlotsMismatch),
        );
    }

    #[test_case(VoteStateTargetVersion::V4 ; "VoteStateV4")]
    fn test_check_and_filter_proposed_vote_state_slot_all_slot_hashes_in_update_ok(
        target_version: VoteStateTargetVersion,
    ) {
        let slot_hashes = build_slot_hashes(vec![2, 4, 6, 8]);
        let mut vote_state = build_vote_state(target_version, vec![2, 4, 6], &slot_hashes);

        // Test with a `TowerSync` where every slot in the history is
        // in the update

        // Have to vote for a slot greater than the last vote in the vote state to avoid VoteTooOld
        // errors
        let vote_slot = vote_state.votes().back().unwrap().slot() + 2;
        let vote_slot_hash = slot_hashes
            .iter()
            .find(|(slot, _hash)| *slot == vote_slot)
            .unwrap()
            .1;
        let mut tower_sync = TowerSync::from(vec![(2, 4), (4, 3), (6, 2), (vote_slot, 1)]);
        tower_sync.hash = vote_slot_hash;
        check_and_filter_proposed_vote_state(
            &vote_state,
            &mut tower_sync.lockouts,
            &mut tower_sync.root,
            tower_sync.hash,
            &slot_hashes,
        )
        .unwrap();

        // Nothing in the update should have been filtered out
        assert_eq!(
            tower_sync
                .clone()
                .lockouts
                .into_iter()
                .collect::<Vec<Lockout>>(),
            vec![
                Lockout::new_with_confirmation_count(2, 4),
                Lockout::new_with_confirmation_count(4, 3),
                Lockout::new_with_confirmation_count(6, 2),
                Lockout::new_with_confirmation_count(vote_slot, 1)
            ]
        );

        assert!(do_process_tower_sync(&mut vote_state, &slot_hashes, 0, 0, tower_sync,).is_ok());
    }

    #[test_case(VoteStateTargetVersion::V4 ; "VoteStateV4")]
    fn test_check_and_filter_proposed_vote_state_slot_some_slot_hashes_in_update_ok(
        target_version: VoteStateTargetVersion,
    ) {
        let slot_hashes = build_slot_hashes(vec![2, 4, 6, 8, 10]);
        let mut vote_state = build_vote_state(target_version, vec![6], &slot_hashes);

        // Test with a `TowerSync` where only some slots in the history are
        // in the update, and others slots in the history are missing.

        // Have to vote for a slot greater than the last vote in the vote state to avoid VoteTooOld
        // errors
        let vote_slot = vote_state.votes().back().unwrap().slot() + 2;
        let vote_slot_hash = slot_hashes
            .iter()
            .find(|(slot, _hash)| *slot == vote_slot)
            .unwrap()
            .1;
        let mut tower_sync = TowerSync::from(vec![(4, 2), (vote_slot, 1)]);
        tower_sync.hash = vote_slot_hash;
        check_and_filter_proposed_vote_state(
            &vote_state,
            &mut tower_sync.lockouts,
            &mut tower_sync.root,
            tower_sync.hash,
            &slot_hashes,
        )
        .unwrap();

        // Nothing in the update should have been filtered out
        assert_eq!(
            tower_sync
                .clone()
                .lockouts
                .into_iter()
                .collect::<Vec<Lockout>>(),
            vec![
                Lockout::new_with_confirmation_count(4, 2),
                Lockout::new_with_confirmation_count(vote_slot, 1)
            ]
        );

        // Because 6 from the original VoteStateV3
        // should not have been popped off in the proposed state,
        // we should get a lockout conflict
        assert_eq!(
            do_process_tower_sync(&mut vote_state, &slot_hashes, 0, 0, tower_sync,),
            Err(VoteError::LockoutConflict)
        );
    }

    #[test_case(VoteStateTargetVersion::V4 ; "VoteStateV4")]
    fn test_check_and_filter_proposed_vote_state_slot_hash_mismatch(
        target_version: VoteStateTargetVersion,
    ) {
        let slot_hashes = build_slot_hashes(vec![2, 4, 6, 8]);
        let vote_state = build_vote_state(target_version, vec![2, 4, 6], &slot_hashes);

        // Test with a `TowerSync` where the hash is mismatched

        // Have to vote for a slot greater than the last vote in the vote state to avoid VoteTooOld
        // errors
        let vote_slot = vote_state.votes().back().unwrap().slot() + 2;
        let vote_slot_hash = Hash::new_unique();
        let mut tower_sync = TowerSync::from(vec![(2, 4), (4, 3), (6, 2), (vote_slot, 1)]);
        tower_sync.hash = vote_slot_hash;
        assert_eq!(
            check_and_filter_proposed_vote_state(
                &vote_state,
                &mut tower_sync.lockouts,
                &mut tower_sync.root,
                tower_sync.hash,
                &slot_hashes,
            ),
            Err(VoteError::SlotHashMismatch),
        );
    }

    #[test_case(0, true; "first slot")]
    #[test_case(DEFAULT_SLOTS_PER_EPOCH / 2, true; "halfway through epoch")]
    #[test_case((DEFAULT_SLOTS_PER_EPOCH / 2).saturating_add(1), false; "halfway through epoch plus one")]
    #[test_case(DEFAULT_SLOTS_PER_EPOCH.saturating_sub(1), false; "last slot in epoch")]
    #[test_case(DEFAULT_SLOTS_PER_EPOCH, true; "first slot in second epoch")]
    fn test_epoch_half_check(slot: Slot, expected_allowed: bool) {
        let epoch_schedule = EpochSchedule::without_warmup();
        assert_eq!(
            is_commission_update_allowed(slot, &epoch_schedule),
            expected_allowed
        );
    }

    #[test]
    fn test_warmup_epoch_half_check_with_warmup() {
        let epoch_schedule = EpochSchedule::default();
        let first_normal_slot = epoch_schedule.first_normal_slot;
        // first slot works
        assert!(is_commission_update_allowed(0, &epoch_schedule));
        // right before first normal slot works, since all warmup slots allow
        // commission updates
        assert!(is_commission_update_allowed(
            first_normal_slot - 1,
            &epoch_schedule
        ));
    }

    #[test_case(0, true; "first slot")]
    #[test_case(DEFAULT_SLOTS_PER_EPOCH / 2, true; "halfway through epoch")]
    #[test_case((DEFAULT_SLOTS_PER_EPOCH / 2).saturating_add(1), false; "halfway through epoch plus one")]
    #[test_case(DEFAULT_SLOTS_PER_EPOCH.saturating_sub(1), false; "last slot in epoch")]
    #[test_case(DEFAULT_SLOTS_PER_EPOCH, true; "first slot in second epoch")]
    fn test_epoch_half_check_with_warmup(slot: Slot, expected_allowed: bool) {
        let epoch_schedule = EpochSchedule::default();
        let first_normal_slot = epoch_schedule.first_normal_slot;
        assert_eq!(
            is_commission_update_allowed(first_normal_slot.saturating_add(slot), &epoch_schedule),
            expected_allowed
        );
    }

    #[test]
    fn test_create_v4_account_with_authorized() {
        let node_pubkey = Pubkey::new_unique();
        let authorized_voter = Pubkey::new_unique();
        let authorized_withdrawer = Pubkey::new_unique();
        let bls_pubkey_compressed = [42; 48];
        let inflation_rewards_commission_bps = 10000;
        let lamports = 100;
        let vote_account = create_v4_account_with_authorized(
            &node_pubkey,
            &authorized_voter,
            bls_pubkey_compressed,
            &authorized_withdrawer,
            inflation_rewards_commission_bps,
            &authorized_withdrawer,
            0,
            &node_pubkey,
            lamports,
        );
        assert_eq!(vote_account.lamports(), lamports);
        assert_eq!(vote_account.owner(), &id());
        assert_eq!(vote_account.data().len(), VoteStateV4::size_of());
        let vote_state_v4 = VoteStateV4::deserialize(vote_account.data(), &node_pubkey).unwrap();
        assert_eq!(vote_state_v4.node_pubkey, node_pubkey);
        assert_eq!(
            vote_state_v4.authorized_voters,
            AuthorizedVoters::new(0, authorized_voter)
        );
        assert_eq!(vote_state_v4.authorized_withdrawer, authorized_withdrawer);
        assert_eq!(
            vote_state_v4.bls_pubkey_compressed,
            Some(bls_pubkey_compressed)
        );
        assert_eq!(
            vote_state_v4.inflation_rewards_commission_bps,
            inflation_rewards_commission_bps
        );
    }

    #[test]
    fn test_update_validator_identity_syncs_block_revenue_collector() {
        // Feature disabled; block revenue collector should always sync.
        let custom_commission_collector_enabled = false;

        let vote_state =
            vote_state_new_for_test(&solana_pubkey::new_rand(), VoteStateTargetVersion::V4);
        let node_pubkey = *vote_state.node_pubkey();
        let withdrawer_pubkey = *vote_state.authorized_withdrawer();

        let serialized = vote_state.serialize();
        let serialized_len = serialized.len();
        let rent = Rent::default();
        let lamports = rent.minimum_balance(serialized_len);
        let mut vote_account = AccountSharedData::new(lamports, serialized_len, &id());
        vote_account.set_data_from_slice(&serialized);

        let processor_account = AccountSharedData::new(0, 0, &solana_sdk_ids::native_loader::id());
        let mut transaction_context = TransactionContext::new(
            vec![(id(), processor_account), (node_pubkey, vote_account)],
            rent,
            0,
            0,
            1,
        );
        transaction_context
            .configure_top_level_instruction_for_tests(
                0,
                vec![InstructionAccount::new(1, false, true)],
                vec![],
            )
            .unwrap();
        let instruction_context = transaction_context.get_next_instruction_context().unwrap();
        let mut borrowed_account = instruction_context
            .try_borrow_instruction_account(0)
            .unwrap();

        let new_node_pubkey = solana_pubkey::new_rand();
        let signers: HashSet<Pubkey> = vec![withdrawer_pubkey, new_node_pubkey]
            .into_iter()
            .collect();

        update_validator_identity(
            &mut borrowed_account,
            VoteStateTargetVersion::V4,
            &new_node_pubkey,
            &signers,
            custom_commission_collector_enabled,
        )
        .unwrap();

        // Both `node_pubkey` and `block_revenue_collector` should be set to
        // the new node pubkey.
        let vote_state =
            VoteStateV4::deserialize(borrowed_account.get_data(), &new_node_pubkey).unwrap();
        assert_eq!(vote_state.node_pubkey, new_node_pubkey);
        assert_eq!(vote_state.block_revenue_collector, new_node_pubkey);

        // Run it again.
        let new_node_pubkey = solana_pubkey::new_rand();
        let signers: HashSet<Pubkey> = vec![withdrawer_pubkey, new_node_pubkey]
            .into_iter()
            .collect();

        update_validator_identity(
            &mut borrowed_account,
            VoteStateTargetVersion::V4,
            &new_node_pubkey,
            &signers,
            custom_commission_collector_enabled,
        )
        .unwrap();

        let vote_state =
            VoteStateV4::deserialize(borrowed_account.get_data(), &new_node_pubkey).unwrap();
        assert_eq!(vote_state.node_pubkey, new_node_pubkey);
        assert_eq!(vote_state.block_revenue_collector, new_node_pubkey);
    }

    #[test]
    fn test_update_validator_identity_preserves_custom_block_revenue_collector() {
        // SIMD-0232 enabled.
        //
        // Once a validator has set a custom block_revenue_collector, rotating
        // the validator identity via UpdateValidatorIdentity must NOT clobber
        // the custom collector.
        let custom_commission_collector_enabled = true;

        let vote_pubkey = solana_pubkey::new_rand();
        let mut vote_state = vote_state_new_for_test(&vote_pubkey, VoteStateTargetVersion::V4);
        let node_pubkey = *vote_state.node_pubkey();
        let withdrawer_pubkey = *vote_state.authorized_withdrawer();

        // Seed a custom block_revenue_collector distinct from the node identity.
        let custom_collector = solana_pubkey::new_rand();
        vote_state.set_block_revenue_collector(custom_collector);

        let serialized = vote_state.serialize();
        let serialized_len = serialized.len();
        let rent = Rent::default();
        let lamports = rent.minimum_balance(serialized_len);
        let mut vote_account = AccountSharedData::new(lamports, serialized_len, &id());
        vote_account.set_data_from_slice(&serialized);

        let processor_account = AccountSharedData::new(0, 0, &solana_sdk_ids::native_loader::id());
        let mut transaction_context = TransactionContext::new(
            vec![(id(), processor_account), (node_pubkey, vote_account)],
            rent,
            0,
            0,
            1,
        );
        transaction_context
            .configure_top_level_instruction_for_tests(
                0,
                vec![InstructionAccount::new(1, false, true)],
                vec![],
            )
            .unwrap();
        let instruction_context = transaction_context.get_next_instruction_context().unwrap();
        let mut borrowed_account = instruction_context
            .try_borrow_instruction_account(0)
            .unwrap();

        let new_node_pubkey = solana_pubkey::new_rand();
        let signers: HashSet<Pubkey> = vec![withdrawer_pubkey, new_node_pubkey]
            .into_iter()
            .collect();

        update_validator_identity(
            &mut borrowed_account,
            VoteStateTargetVersion::V4,
            &new_node_pubkey,
            &signers,
            custom_commission_collector_enabled,
        )
        .unwrap();

        // node_pubkey updated, but block_revenue_collector preserved.
        let vote_state =
            VoteStateV4::deserialize(borrowed_account.get_data(), &new_node_pubkey).unwrap();
        assert_eq!(vote_state.node_pubkey, new_node_pubkey);
        assert_eq!(vote_state.block_revenue_collector, custom_collector);
        assert_ne!(vote_state.block_revenue_collector, new_node_pubkey);
    }

    #[test]
    fn test_get_and_update_authorized_voter_v4_with_bls() {
        let vote_account_pubkey = Pubkey::new_unique();
        let (bls_pubkey, bls_proof_of_possession) =
            create_bls_pubkey_and_proof_of_possession(&vote_account_pubkey);
        let node_pubkey = Pubkey::new_unique();
        let authorized_voter = Pubkey::new_unique();
        let authorized_withdrawer = Pubkey::new_unique();
        let inflation_rewards_commission_bps = 10000;
        let rent = Rent::default();
        let lamports = rent.minimum_balance(VoteStateV4::size_of());
        // Create a VoteStateV4 account without BLS pubkey
        let vote_account = create_v4_account_with_authorized(
            &node_pubkey,
            &authorized_voter,
            [0u8; BLS_PUBLIC_KEY_COMPRESSED_SIZE],
            &authorized_withdrawer,
            inflation_rewards_commission_bps,
            &authorized_withdrawer,
            0,
            &node_pubkey,
            lamports,
        );
        assert_eq!(vote_account.lamports(), lamports);
        assert_eq!(vote_account.owner(), &id());
        assert_eq!(vote_account.data().len(), VoteStateV4::size_of());

        let processor_account = AccountSharedData::new(0, 0, &solana_sdk_ids::native_loader::id());
        let mut transaction_context = TransactionContext::new(
            vec![
                (id(), processor_account),
                (vote_account_pubkey, vote_account),
            ],
            rent,
            0,
            0,
            1,
        );
        transaction_context
            .configure_top_level_instruction_for_tests(
                0,
                vec![InstructionAccount::new(1, false, true)],
                vec![],
            )
            .unwrap();
        let instruction_context = transaction_context.get_next_instruction_context().unwrap();
        let mut borrowed_account = instruction_context
            .try_borrow_instruction_account(0)
            .unwrap();

        let new_node_pubkey = solana_pubkey::new_rand();
        let signers: HashSet<Pubkey> = vec![authorized_withdrawer, new_node_pubkey]
            .into_iter()
            .collect();
        let clock = Clock::default();
        assert!(
            authorize(
                &mut borrowed_account,
                VoteStateTargetVersion::V4,
                &new_node_pubkey,
                VoteAuthorize::VoterWithBLS(VoterWithBLSArgs {
                    bls_pubkey,
                    bls_proof_of_possession
                }),
                &signers,
                &clock,
                true,
                || Ok(()),
            )
            .is_ok()
        );
        let vote_state = VoteStateHandler::new_v4(
            VoteStateV4::deserialize(borrowed_account.get_data(), &new_node_pubkey).unwrap(),
        );
        assert_eq!(
            vote_state.as_ref_v4().bls_pubkey_compressed,
            Some(bls_pubkey)
        );
        assert!(vote_state.has_bls_pubkey());

        // Test replay attack, can't use someone else's BLS pubkey and PoP
        let clock = Clock {
            epoch: 3,
            ..Clock::default()
        };
        let (others_bls_pubkey, others_bls_proof_of_possession) =
            create_bls_pubkey_and_proof_of_possession(&Pubkey::new_unique());
        let new_node_pubkey = solana_pubkey::new_rand();
        let signers: HashSet<Pubkey> = vec![authorized_withdrawer, new_node_pubkey]
            .into_iter()
            .collect();
        assert_eq!(
            authorize(
                &mut borrowed_account,
                VoteStateTargetVersion::V4,
                &new_node_pubkey,
                VoteAuthorize::VoterWithBLS(VoterWithBLSArgs {
                    bls_pubkey: others_bls_pubkey,
                    bls_proof_of_possession: others_bls_proof_of_possession
                }),
                &signers,
                &clock,
                true,
                || Ok(()),
            ),
            Err(InstructionError::InvalidArgument),
        );

        // Test updating to a new BLS pubkey, can only do it in next epoch.
        let clock = Clock {
            epoch: 5,
            ..Clock::default()
        };
        let (new_bls_pubkey, new_bls_proof_of_possession) =
            create_bls_pubkey_and_proof_of_possession(&vote_account_pubkey);
        let new_authorized_voter = solana_pubkey::new_rand();
        let signers: HashSet<Pubkey> = vec![authorized_withdrawer, new_authorized_voter]
            .into_iter()
            .collect();
        assert_eq!(
            authorize(
                &mut borrowed_account,
                VoteStateTargetVersion::V4,
                &new_authorized_voter,
                VoteAuthorize::VoterWithBLS(VoterWithBLSArgs {
                    bls_pubkey: new_bls_pubkey,
                    bls_proof_of_possession: new_bls_proof_of_possession
                }),
                &signers,
                &clock,
                true,
                || Ok(()),
            ),
            Ok(())
        );
        let vote_state = VoteStateHandler::new_v4(
            VoteStateV4::deserialize(borrowed_account.get_data(), &new_authorized_voter).unwrap(),
        );
        assert_eq!(
            vote_state.as_ref_v4().bls_pubkey_compressed,
            Some(new_bls_pubkey)
        );
        assert!(vote_state.has_bls_pubkey());
    }

    fn new_transaction_context(
        accounts: Vec<(Pubkey, AccountSharedData)>,
        instruction_accounts: Vec<InstructionAccount>,
        rent: &Rent,
    ) -> TransactionContext<'_> {
        let mut transaction_context = TransactionContext::new(accounts, rent.clone(), 0, 0, 1);
        transaction_context
            .configure_top_level_instruction_for_tests(0, instruction_accounts, vec![])
            .unwrap();
        transaction_context
    }

    #[test]
    fn test_new_commission_collector_validate_and_resolve_key() {
        let rent = Rent::default();
        let processor_account = AccountSharedData::new(0, 0, &solana_sdk_ids::native_loader::id());
        let vote_pubkey = solana_pubkey::new_rand();
        let vote_account = AccountSharedData::new(1, 0, &id());
        let collector_pubkey = solana_pubkey::new_rand();
        let valid_collector =
            || AccountSharedData::new(rent.minimum_balance(0), 0, &system_program::id());

        // Success: VoteAccount variant returns the vote account's key.
        {
            let transaction_context = new_transaction_context(
                vec![
                    (id(), processor_account.clone()),
                    (vote_pubkey, vote_account.clone()),
                ],
                vec![InstructionAccount::new(1, false, true)],
                &rent,
            );
            let instruction_context = transaction_context.get_next_instruction_context().unwrap();
            let borrowed_vote = instruction_context
                .try_borrow_instruction_account(0)
                .unwrap();
            assert_eq!(
                NewCommissionCollector::VoteAccount.validate_and_resolve_key(&borrowed_vote, &rent),
                Ok(vote_pubkey),
            );
        }

        // Success: NewAccount (happy) path returns the collector's key.
        {
            let transaction_context = new_transaction_context(
                vec![
                    (id(), processor_account.clone()),
                    (vote_pubkey, vote_account.clone()),
                    (collector_pubkey, valid_collector()),
                ],
                vec![
                    InstructionAccount::new(1, false, true),
                    InstructionAccount::new(2, false, true),
                ],
                &rent,
            );
            let instruction_context = transaction_context.get_next_instruction_context().unwrap();
            let borrowed_vote = instruction_context
                .try_borrow_instruction_account(0)
                .unwrap();
            let borrowed_collector = instruction_context
                .try_borrow_instruction_account(1)
                .unwrap();
            assert_eq!(
                NewCommissionCollector::NewAccount(borrowed_collector)
                    .validate_and_resolve_key(&borrowed_vote, &rent),
                Ok(collector_pubkey),
            );
        }

        // Success: Incinerator is an accepted collector (SIMD-0232 explicitly
        // allows it — funds sent to the incinerator are burned at end-of-block).
        {
            // Imagine the incinerator is temporarily holding funds at the time
            // of the invocation.
            let incinerator_account =
                AccountSharedData::new(rent.minimum_balance(0), 0, &system_program::id());
            let transaction_context = new_transaction_context(
                vec![
                    (id(), processor_account.clone()),
                    (vote_pubkey, vote_account.clone()),
                    (solana_sdk_ids::incinerator::id(), incinerator_account),
                ],
                vec![
                    InstructionAccount::new(1, false, true),
                    InstructionAccount::new(2, false, true),
                ],
                &rent,
            );
            let instruction_context = transaction_context.get_next_instruction_context().unwrap();
            let borrowed_vote = instruction_context
                .try_borrow_instruction_account(0)
                .unwrap();
            let borrowed_collector = instruction_context
                .try_borrow_instruction_account(1)
                .unwrap();
            assert_eq!(
                NewCommissionCollector::NewAccount(borrowed_collector)
                    .validate_and_resolve_key(&borrowed_vote, &rent),
                Ok(solana_sdk_ids::incinerator::id()),
            );
        }

        // Fail: Collector account not system-owned.
        {
            let bad_owner =
                AccountSharedData::new(rent.minimum_balance(0), 0, &solana_pubkey::new_rand());
            let transaction_context = new_transaction_context(
                vec![
                    (id(), processor_account.clone()),
                    (vote_pubkey, vote_account.clone()),
                    (collector_pubkey, bad_owner),
                ],
                vec![
                    InstructionAccount::new(1, false, true),
                    InstructionAccount::new(2, false, true),
                ],
                &rent,
            );
            let instruction_context = transaction_context.get_next_instruction_context().unwrap();
            let borrowed_vote = instruction_context
                .try_borrow_instruction_account(0)
                .unwrap();
            let borrowed_collector = instruction_context
                .try_borrow_instruction_account(1)
                .unwrap();
            assert_eq!(
                NewCommissionCollector::NewAccount(borrowed_collector)
                    .validate_and_resolve_key(&borrowed_vote, &rent),
                Err(InstructionError::InvalidAccountOwner),
            );
        }

        // Fail: Collector account not rent-exempt.
        {
            let underfunded = AccountSharedData::new(0, 0, &system_program::id());
            let transaction_context = new_transaction_context(
                vec![
                    (id(), processor_account.clone()),
                    (vote_pubkey, vote_account.clone()),
                    (collector_pubkey, underfunded),
                ],
                vec![
                    InstructionAccount::new(1, false, true),
                    InstructionAccount::new(2, false, true),
                ],
                &rent,
            );
            let instruction_context = transaction_context.get_next_instruction_context().unwrap();
            let borrowed_vote = instruction_context
                .try_borrow_instruction_account(0)
                .unwrap();
            let borrowed_collector = instruction_context
                .try_borrow_instruction_account(1)
                .unwrap();
            assert_eq!(
                NewCommissionCollector::NewAccount(borrowed_collector)
                    .validate_and_resolve_key(&borrowed_vote, &rent),
                Err(InstructionError::InsufficientFunds),
            );
        }

        // Fail: Collector account not writable (reserved account check).
        {
            let transaction_context = new_transaction_context(
                vec![
                    (id(), processor_account),
                    (vote_pubkey, vote_account),
                    (collector_pubkey, valid_collector()),
                ],
                vec![
                    InstructionAccount::new(1, false, true),
                    InstructionAccount::new(2, false, false), // <-- Not writable
                ],
                &rent,
            );
            let instruction_context = transaction_context.get_next_instruction_context().unwrap();
            let borrowed_vote = instruction_context
                .try_borrow_instruction_account(0)
                .unwrap();
            let borrowed_collector = instruction_context
                .try_borrow_instruction_account(1)
                .unwrap();
            assert_eq!(
                NewCommissionCollector::NewAccount(borrowed_collector)
                    .validate_and_resolve_key(&borrowed_vote, &rent),
                Err(InstructionError::InvalidArgument),
            );
        }
    }

    /// Test update_commission_collector (SIMD-0232).
    ///
    /// This test only uses V4 since SIMD-0232 depends on SIMD-0185 (VoteStateV4).
    #[test]
    fn test_update_commission_collector() {
        let target_version = VoteStateTargetVersion::V4;
        let vote_pubkey = solana_pubkey::new_rand();
        let vote_state = vote_state_new_for_test(&vote_pubkey, target_version);
        let withdrawer_pubkey = *vote_state.authorized_withdrawer();
        let node_pubkey = *vote_state.node_pubkey();

        let signers: HashSet<Pubkey> = vec![withdrawer_pubkey].into_iter().collect();

        let serialized = vote_state.serialize();
        let serialized_len = serialized.len();
        let rent = Rent::default();
        let lamports = rent.minimum_balance(serialized_len);
        let mut vote_account = AccountSharedData::new(lamports, serialized_len, &id());
        vote_account.set_data_from_slice(&serialized);

        let get_commission_collector =
            |vote_account: &BorrowedInstructionAccount, kind: CommissionKind| {
                let handler = get_vote_state_handler_checked(vote_account, target_version).unwrap();
                let vote_state = handler.as_ref_v4();
                match kind {
                    CommissionKind::InflationRewards => vote_state.inflation_rewards_collector,
                    CommissionKind::BlockRevenue => vote_state.block_revenue_collector,
                }
            };

        let processor_account = AccountSharedData::new(0, 0, &solana_sdk_ids::native_loader::id());

        // Create a valid collector account (system-owned, rent-exempt).
        let new_collector = solana_pubkey::new_rand();
        let collector_lamports = rent.minimum_balance(0);
        let collector_account =
            AccountSharedData::new(collector_lamports, 0, &system_program::id());

        let original_inflation_collector = vote_pubkey;
        let original_block_revenue_collector = node_pubkey;

        // Should pass.
        {
            let transaction_context = new_transaction_context(
                vec![
                    (id(), processor_account.clone()),
                    (vote_pubkey, vote_account.clone()),
                    (new_collector, collector_account.clone()),
                ],
                vec![
                    InstructionAccount::new(1, false, true),
                    InstructionAccount::new(2, false, true),
                ],
                &rent,
            );
            let instruction_context = transaction_context.get_next_instruction_context().unwrap();
            let mut borrowed_vote_account = instruction_context
                .try_borrow_instruction_account(0)
                .unwrap();

            // InflationRewards kind.
            update_commission_collector(
                &mut borrowed_vote_account,
                target_version,
                NewCommissionCollector::NewAccount(
                    instruction_context
                        .try_borrow_instruction_account(1)
                        .unwrap(),
                ),
                CommissionKind::InflationRewards,
                &signers,
                &rent,
            )
            .unwrap();
            assert_eq!(
                get_commission_collector(&borrowed_vote_account, CommissionKind::InflationRewards),
                new_collector,
            );
            assert_eq!(
                get_commission_collector(&borrowed_vote_account, CommissionKind::BlockRevenue),
                original_block_revenue_collector, // Unchanged
            );

            // BlockRevenue kind.
            update_commission_collector(
                &mut borrowed_vote_account,
                target_version,
                NewCommissionCollector::NewAccount(
                    instruction_context
                        .try_borrow_instruction_account(1)
                        .unwrap(),
                ),
                CommissionKind::BlockRevenue,
                &signers,
                &rent,
            )
            .unwrap();
            assert_eq!(
                get_commission_collector(&borrowed_vote_account, CommissionKind::InflationRewards),
                new_collector,
            );
            assert_eq!(
                get_commission_collector(&borrowed_vote_account, CommissionKind::BlockRevenue),
                new_collector,
            );
        }

        // Should pass - setting collector to vote account.
        {
            let transaction_context = new_transaction_context(
                vec![
                    (id(), processor_account.clone()),
                    (vote_pubkey, vote_account.clone()),
                ],
                vec![
                    InstructionAccount::new(1, false, true),
                    InstructionAccount::new(1, false, true), // collector = vote account (aliased)
                ],
                &rent,
            );
            let instruction_context = transaction_context.get_next_instruction_context().unwrap();
            let mut borrowed_vote_account = instruction_context
                .try_borrow_instruction_account(0)
                .unwrap();

            // InflationRewards kind.
            update_commission_collector(
                &mut borrowed_vote_account,
                target_version,
                NewCommissionCollector::VoteAccount,
                CommissionKind::InflationRewards,
                &signers,
                &rent,
            )
            .unwrap();
            assert_eq!(
                get_commission_collector(&borrowed_vote_account, CommissionKind::InflationRewards),
                vote_pubkey,
            );
            assert_eq!(
                get_commission_collector(&borrowed_vote_account, CommissionKind::BlockRevenue),
                original_block_revenue_collector, // Unchanged
            );

            // BlockRevenue kind.
            update_commission_collector(
                &mut borrowed_vote_account,
                target_version,
                NewCommissionCollector::VoteAccount,
                CommissionKind::BlockRevenue,
                &signers,
                &rent,
            )
            .unwrap();
            assert_eq!(
                get_commission_collector(&borrowed_vote_account, CommissionKind::InflationRewards),
                vote_pubkey,
            );
            assert_eq!(
                get_commission_collector(&borrowed_vote_account, CommissionKind::BlockRevenue),
                vote_pubkey,
            );
        }

        // V3 -> V4 auto-conversion side-effect: updating one collector against a
        // V3-serialized account causes the "other" collector to be written as
        // its V4 default (inflation_rewards_collector = vote_pubkey,
        // block_revenue_collector = node_pubkey), per try_convert_to_vote_state_v4.
        {
            let v3 = get_max_sized_vote_state_v3();
            let v3_node_pubkey = v3.node_pubkey;
            let v3_withdrawer = v3.authorized_withdrawer;
            let v3_vote_pubkey = solana_pubkey::new_rand();

            let v4_size = VoteStateV4::size_of();
            let mut account_data = vec![0u8; v4_size];
            bincode::serialize_into(&mut account_data[..], &VoteStateVersions::V3(Box::new(v3)))
                .unwrap();
            let mut v3_vote_account =
                AccountSharedData::new(rent.minimum_balance(v4_size), v4_size, &id());
            v3_vote_account.set_data_from_slice(&account_data);

            let v3_signers: HashSet<Pubkey> = vec![v3_withdrawer].into_iter().collect();

            let transaction_context = new_transaction_context(
                vec![
                    (id(), processor_account.clone()),
                    (v3_vote_pubkey, v3_vote_account),
                    (new_collector, collector_account.clone()),
                ],
                vec![
                    InstructionAccount::new(1, false, true),
                    InstructionAccount::new(2, false, true),
                ],
                &rent,
            );
            let instruction_context = transaction_context.get_next_instruction_context().unwrap();
            let mut borrowed_vote_account = instruction_context
                .try_borrow_instruction_account(0)
                .unwrap();

            update_commission_collector(
                &mut borrowed_vote_account,
                target_version,
                NewCommissionCollector::NewAccount(
                    instruction_context
                        .try_borrow_instruction_account(1)
                        .unwrap(),
                ),
                CommissionKind::InflationRewards,
                &v3_signers,
                &rent,
            )
            .unwrap();

            // The updated field reflects the caller's new collector.
            assert_eq!(
                get_commission_collector(&borrowed_vote_account, CommissionKind::InflationRewards),
                new_collector,
            );
            // The *other* field was reset to its V4-conversion default
            // (block_revenue_collector = node_pubkey from the V3 source).
            assert_eq!(
                get_commission_collector(&borrowed_vote_account, CommissionKind::BlockRevenue),
                v3_node_pubkey,
            );
        }

        // Should fail - deserialization error paths.
        //
        // All four variants produce `InvalidAccountData`:
        // * V0_23_5 is explicitly unsupported
        // * V1_14_11, V3, and V4 fail if state is bad
        let run_with_account_data = |bytes: Vec<u8>| -> Result<(), InstructionError> {
            let mut bad_vote_account =
                AccountSharedData::new(rent.minimum_balance(bytes.len()), bytes.len(), &id());
            bad_vote_account.set_data_from_slice(&bytes);
            let transaction_context = new_transaction_context(
                vec![
                    (id(), processor_account.clone()),
                    (vote_pubkey, bad_vote_account),
                    (new_collector, collector_account.clone()),
                ],
                vec![
                    InstructionAccount::new(1, false, true),
                    InstructionAccount::new(2, false, true),
                ],
                &rent,
            );
            let instruction_context = transaction_context.get_next_instruction_context().unwrap();
            let mut borrowed_vote_account = instruction_context
                .try_borrow_instruction_account(0)
                .unwrap();
            update_commission_collector(
                &mut borrowed_vote_account,
                target_version,
                NewCommissionCollector::NewAccount(
                    instruction_context
                        .try_borrow_instruction_account(1)
                        .unwrap(),
                ),
                CommissionKind::InflationRewards,
                &signers,
                &rent,
            )
        };
        let variant_with_short_body = |variant: u32| -> Vec<u8> {
            let mut bytes = vec![0u8; 8];
            bytes[..4].copy_from_slice(&variant.to_le_bytes());
            bytes
        };

        // Should fail - V0_23_5 not supported.
        assert_eq!(
            run_with_account_data(variant_with_short_body(0)),
            Err(InstructionError::InvalidAccountData),
        );

        // Should fail - Invalid V1_14_11 state.
        assert_eq!(
            run_with_account_data(variant_with_short_body(1)),
            Err(InstructionError::InvalidAccountData),
        );

        // Should fail - Invalid V3 state.
        assert_eq!(
            run_with_account_data(variant_with_short_body(2)),
            Err(InstructionError::InvalidAccountData),
        );

        // Should fail - Invalid V4 state.
        assert_eq!(
            run_with_account_data(variant_with_short_body(3)),
            Err(InstructionError::InvalidAccountData),
        );

        // Should fail - authorized withdrawer didn't sign.
        {
            let non_signers: HashSet<Pubkey> = HashSet::new();
            let transaction_context = new_transaction_context(
                vec![
                    (id(), processor_account.clone()),
                    (vote_pubkey, vote_account.clone()),
                    (new_collector, collector_account.clone()),
                ],
                vec![
                    InstructionAccount::new(1, false, true),
                    InstructionAccount::new(2, false, true),
                ],
                &rent,
            );
            let instruction_context = transaction_context.get_next_instruction_context().unwrap();
            let mut borrowed_vote_account = instruction_context
                .try_borrow_instruction_account(0)
                .unwrap();

            assert_eq!(
                update_commission_collector(
                    &mut borrowed_vote_account,
                    target_version,
                    NewCommissionCollector::NewAccount(
                        instruction_context
                            .try_borrow_instruction_account(1)
                            .unwrap()
                    ),
                    CommissionKind::InflationRewards,
                    &non_signers,
                    &rent,
                ),
                Err(InstructionError::MissingRequiredSignature)
            );
            assert_eq!(
                get_commission_collector(&borrowed_vote_account, CommissionKind::InflationRewards),
                original_inflation_collector, // Unchanged
            );
            assert_eq!(
                get_commission_collector(&borrowed_vote_account, CommissionKind::BlockRevenue),
                original_block_revenue_collector, // Unchanged
            );
        }

        // Should fail - wrong signer (not the authorized withdrawer).
        {
            let wrong_signers: HashSet<Pubkey> = vec![Pubkey::new_unique()].into_iter().collect();
            let transaction_context = new_transaction_context(
                vec![
                    (id(), processor_account.clone()),
                    (vote_pubkey, vote_account.clone()),
                    (new_collector, collector_account),
                ],
                vec![
                    InstructionAccount::new(1, false, true),
                    InstructionAccount::new(2, false, true),
                ],
                &rent,
            );
            let instruction_context = transaction_context.get_next_instruction_context().unwrap();
            let mut borrowed_vote_account = instruction_context
                .try_borrow_instruction_account(0)
                .unwrap();

            assert_eq!(
                update_commission_collector(
                    &mut borrowed_vote_account,
                    target_version,
                    NewCommissionCollector::NewAccount(
                        instruction_context
                            .try_borrow_instruction_account(1)
                            .unwrap()
                    ),
                    CommissionKind::InflationRewards,
                    &wrong_signers,
                    &rent,
                ),
                Err(InstructionError::MissingRequiredSignature)
            );
            assert_eq!(
                get_commission_collector(&borrowed_vote_account, CommissionKind::InflationRewards),
                original_inflation_collector, // Unchanged
            );
            assert_eq!(
                get_commission_collector(&borrowed_vote_account, CommissionKind::BlockRevenue),
                original_block_revenue_collector, // Unchanged
            );
        }

        // Should fail - new collector not system program owned.
        {
            let bad_collector = solana_pubkey::new_rand();
            let non_system_owner = solana_pubkey::new_rand();
            let bad_collector_account =
                AccountSharedData::new(collector_lamports, 0, &non_system_owner);
            let transaction_context = new_transaction_context(
                vec![
                    (id(), processor_account.clone()),
                    (vote_pubkey, vote_account.clone()),
                    (bad_collector, bad_collector_account),
                ],
                vec![
                    InstructionAccount::new(1, false, true),
                    InstructionAccount::new(2, false, true),
                ],
                &rent,
            );
            let instruction_context = transaction_context.get_next_instruction_context().unwrap();
            let mut borrowed_vote_account = instruction_context
                .try_borrow_instruction_account(0)
                .unwrap();

            assert_eq!(
                update_commission_collector(
                    &mut borrowed_vote_account,
                    target_version,
                    NewCommissionCollector::NewAccount(
                        instruction_context
                            .try_borrow_instruction_account(1)
                            .unwrap()
                    ),
                    CommissionKind::InflationRewards,
                    &signers,
                    &rent,
                ),
                Err(InstructionError::InvalidAccountOwner)
            );
            assert_eq!(
                get_commission_collector(&borrowed_vote_account, CommissionKind::InflationRewards),
                original_inflation_collector, // Unchanged
            );
            assert_eq!(
                get_commission_collector(&borrowed_vote_account, CommissionKind::BlockRevenue),
                original_block_revenue_collector, // Unchanged
            );
        }

        // Should fail - new collector not rent-exempt.
        {
            let bad_collector = solana_pubkey::new_rand();
            let bad_collector_account = AccountSharedData::new(0, 0, &system_program::id());
            let transaction_context = new_transaction_context(
                vec![
                    (id(), processor_account.clone()),
                    (vote_pubkey, vote_account.clone()),
                    (bad_collector, bad_collector_account),
                ],
                vec![
                    InstructionAccount::new(1, false, true),
                    InstructionAccount::new(2, false, true),
                ],
                &rent,
            );
            let instruction_context = transaction_context.get_next_instruction_context().unwrap();
            let mut borrowed_vote_account = instruction_context
                .try_borrow_instruction_account(0)
                .unwrap();

            assert_eq!(
                update_commission_collector(
                    &mut borrowed_vote_account,
                    target_version,
                    NewCommissionCollector::NewAccount(
                        instruction_context
                            .try_borrow_instruction_account(1)
                            .unwrap()
                    ),
                    CommissionKind::InflationRewards,
                    &signers,
                    &rent,
                ),
                Err(InstructionError::InsufficientFunds)
            );
            assert_eq!(
                get_commission_collector(&borrowed_vote_account, CommissionKind::InflationRewards),
                original_inflation_collector, // Unchanged
            );
            assert_eq!(
                get_commission_collector(&borrowed_vote_account, CommissionKind::BlockRevenue),
                original_block_revenue_collector, // Unchanged
            );
        }

        // Should fail - new collector not writable (reserved account check).
        {
            let bad_collector = solana_pubkey::new_rand();
            let bad_collector_account =
                AccountSharedData::new(collector_lamports, 0, &system_program::id());
            let transaction_context = new_transaction_context(
                vec![
                    (id(), processor_account),
                    (vote_pubkey, vote_account.clone()),
                    (bad_collector, bad_collector_account),
                ],
                vec![
                    InstructionAccount::new(1, false, true),
                    InstructionAccount::new(2, false, false), // not writable
                ],
                &rent,
            );
            let instruction_context = transaction_context.get_next_instruction_context().unwrap();
            let mut borrowed_vote_account = instruction_context
                .try_borrow_instruction_account(0)
                .unwrap();

            assert_eq!(
                update_commission_collector(
                    &mut borrowed_vote_account,
                    target_version,
                    NewCommissionCollector::NewAccount(
                        instruction_context
                            .try_borrow_instruction_account(1)
                            .unwrap()
                    ),
                    CommissionKind::InflationRewards,
                    &signers,
                    &rent,
                ),
                Err(InstructionError::InvalidArgument)
            );
            assert_eq!(
                get_commission_collector(&borrowed_vote_account, CommissionKind::InflationRewards),
                original_inflation_collector, // Unchanged
            );
            assert_eq!(
                get_commission_collector(&borrowed_vote_account, CommissionKind::BlockRevenue),
                original_block_revenue_collector, // Unchanged
            );
        }
    }

    #[test]
    fn test_initialize_account_v2() {
        let target_version = VoteStateTargetVersion::V4;
        let rent = Rent::default();
        let processor_account = AccountSharedData::new(0, 0, &solana_sdk_ids::native_loader::id());

        let vote_pubkey = solana_pubkey::new_rand();
        let node_pubkey = solana_pubkey::new_rand();
        let authorized_voter = solana_pubkey::new_rand();
        let authorized_withdrawer = solana_pubkey::new_rand();
        let inflation_collector_pubkey = solana_pubkey::new_rand();
        let block_revenue_collector_pubkey = solana_pubkey::new_rand();

        let (bls_pubkey, bls_proof_of_possession) =
            create_bls_pubkey_and_proof_of_possession(&vote_pubkey);
        let vote_init = VoteInitV2 {
            node_pubkey,
            authorized_voter,
            authorized_voter_bls_pubkey: bls_pubkey,
            authorized_voter_bls_proof_of_possession: bls_proof_of_possession,
            authorized_withdrawer,
            inflation_rewards_commission_bps: 1_234,
            block_revenue_commission_bps: 5_678,
        };

        let signers: HashSet<Pubkey> = vec![node_pubkey].into_iter().collect();
        let clock = Clock::default();

        let v4_size = VoteStateV4::size_of();
        let lamports = rent.minimum_balance(v4_size);
        let make_uninit_vote_account = || AccountSharedData::new(lamports, v4_size, &id());
        let valid_collector_account =
            || AccountSharedData::new(rent.minimum_balance(0), 0, &system_program::id());

        let assert_v4_fields =
            |vote_account: &BorrowedInstructionAccount,
             expected_inflation_rewards_collector: Pubkey,
             expected_block_revenue_collector: Pubkey| {
                let VoteStateVersions::V4(v4) =
                    vote_account.get_state::<VoteStateVersions>().unwrap()
                else {
                    panic!("expected v4");
                };
                assert_eq!(v4.node_pubkey, node_pubkey);
                assert_eq!(
                    v4.authorized_voters.get_authorized_voter(clock.epoch),
                    Some(authorized_voter),
                );
                assert_eq!(v4.authorized_withdrawer, authorized_withdrawer);
                assert_eq!(v4.bls_pubkey_compressed, Some(bls_pubkey));
                assert_eq!(v4.inflation_rewards_commission_bps, 1_234);
                assert_eq!(v4.block_revenue_commission_bps, 5_678);
                assert_eq!(
                    v4.inflation_rewards_collector,
                    expected_inflation_rewards_collector
                );
                assert_eq!(v4.block_revenue_collector, expected_block_revenue_collector);
                assert_eq!(v4.pending_delegator_rewards, 0);
                assert!(v4.votes.is_empty());
                assert_eq!(v4.root_slot, None);
                assert!(v4.epoch_credits.is_empty());
            };

        let assert_still_uninitialized = |vote_account: &BorrowedInstructionAccount| {
            assert!(
                vote_account
                    .get_state::<VoteStateVersions>()
                    .unwrap()
                    .is_uninitialized()
            );
        };

        // Should pass - both collectors are separate accounts.
        {
            let transaction_context = new_transaction_context(
                vec![
                    (id(), processor_account.clone()),
                    (vote_pubkey, make_uninit_vote_account()),
                    (inflation_collector_pubkey, valid_collector_account()),
                    (block_revenue_collector_pubkey, valid_collector_account()),
                ],
                vec![
                    InstructionAccount::new(1, false, true),
                    InstructionAccount::new(2, false, true),
                    InstructionAccount::new(3, false, true),
                ],
                &rent,
            );
            let instruction_context = transaction_context.get_next_instruction_context().unwrap();
            let mut borrowed_vote_account = instruction_context
                .try_borrow_instruction_account(0)
                .unwrap();

            initialize_account_v2(
                &mut borrowed_vote_account,
                target_version,
                &vote_init,
                NewCommissionCollector::NewAccount(
                    instruction_context
                        .try_borrow_instruction_account(1)
                        .unwrap(),
                ),
                NewCommissionCollector::NewAccount(
                    instruction_context
                        .try_borrow_instruction_account(2)
                        .unwrap(),
                ),
                &signers,
                &clock,
                &rent,
                || Ok(()),
            )
            .unwrap();

            assert_v4_fields(
                &borrowed_vote_account,
                inflation_collector_pubkey,
                block_revenue_collector_pubkey,
            );
        }

        // Should pass - inflation collector aliased to vote account.
        {
            let transaction_context = new_transaction_context(
                vec![
                    (id(), processor_account.clone()),
                    (vote_pubkey, make_uninit_vote_account()),
                    (block_revenue_collector_pubkey, valid_collector_account()),
                ],
                vec![
                    InstructionAccount::new(1, false, true),
                    InstructionAccount::new(2, false, true),
                ],
                &rent,
            );
            let instruction_context = transaction_context.get_next_instruction_context().unwrap();
            let mut borrowed_vote_account = instruction_context
                .try_borrow_instruction_account(0)
                .unwrap();

            initialize_account_v2(
                &mut borrowed_vote_account,
                target_version,
                &vote_init,
                NewCommissionCollector::VoteAccount,
                NewCommissionCollector::NewAccount(
                    instruction_context
                        .try_borrow_instruction_account(1)
                        .unwrap(),
                ),
                &signers,
                &clock,
                &rent,
                || Ok(()),
            )
            .unwrap();

            assert_v4_fields(
                &borrowed_vote_account,
                vote_pubkey,
                block_revenue_collector_pubkey,
            );
        }

        // Should pass - block revenue collector aliased to vote account.
        {
            let transaction_context = new_transaction_context(
                vec![
                    (id(), processor_account.clone()),
                    (vote_pubkey, make_uninit_vote_account()),
                    (inflation_collector_pubkey, valid_collector_account()),
                ],
                vec![
                    InstructionAccount::new(1, false, true),
                    InstructionAccount::new(2, false, true),
                ],
                &rent,
            );
            let instruction_context = transaction_context.get_next_instruction_context().unwrap();
            let mut borrowed_vote_account = instruction_context
                .try_borrow_instruction_account(0)
                .unwrap();

            initialize_account_v2(
                &mut borrowed_vote_account,
                target_version,
                &vote_init,
                NewCommissionCollector::NewAccount(
                    instruction_context
                        .try_borrow_instruction_account(1)
                        .unwrap(),
                ),
                NewCommissionCollector::VoteAccount,
                &signers,
                &clock,
                &rent,
                || Ok(()),
            )
            .unwrap();

            assert_v4_fields(
                &borrowed_vote_account,
                inflation_collector_pubkey,
                vote_pubkey,
            );
        }

        // Should pass - both collectors aliased to vote account.
        {
            let transaction_context = new_transaction_context(
                vec![
                    (id(), processor_account.clone()),
                    (vote_pubkey, make_uninit_vote_account()),
                ],
                vec![InstructionAccount::new(1, false, true)],
                &rent,
            );
            let instruction_context = transaction_context.get_next_instruction_context().unwrap();
            let mut borrowed_vote_account = instruction_context
                .try_borrow_instruction_account(0)
                .unwrap();

            initialize_account_v2(
                &mut borrowed_vote_account,
                target_version,
                &vote_init,
                NewCommissionCollector::VoteAccount,
                NewCommissionCollector::VoteAccount,
                &signers,
                &clock,
                &rent,
                || Ok(()),
            )
            .unwrap();

            assert_v4_fields(&borrowed_vote_account, vote_pubkey, vote_pubkey);
        }

        // Should fail - vote account is the wrong size.
        {
            let oversized_vote_account =
                AccountSharedData::new(rent.minimum_balance(2 * v4_size), 2 * v4_size, &id());
            let transaction_context = new_transaction_context(
                vec![
                    (id(), processor_account.clone()),
                    (vote_pubkey, oversized_vote_account),
                    (inflation_collector_pubkey, valid_collector_account()),
                    (block_revenue_collector_pubkey, valid_collector_account()),
                ],
                vec![
                    InstructionAccount::new(1, false, true),
                    InstructionAccount::new(2, false, true),
                    InstructionAccount::new(3, false, true),
                ],
                &rent,
            );
            let instruction_context = transaction_context.get_next_instruction_context().unwrap();
            let mut borrowed_vote_account = instruction_context
                .try_borrow_instruction_account(0)
                .unwrap();

            assert_eq!(
                initialize_account_v2(
                    &mut borrowed_vote_account,
                    target_version,
                    &vote_init,
                    NewCommissionCollector::NewAccount(
                        instruction_context
                            .try_borrow_instruction_account(1)
                            .unwrap(),
                    ),
                    NewCommissionCollector::NewAccount(
                        instruction_context
                            .try_borrow_instruction_account(2)
                            .unwrap(),
                    ),
                    &signers,
                    &clock,
                    &rent,
                    || Ok(()),
                ),
                Err(InstructionError::InvalidAccountData),
            );
        }

        // Should fail - not a valid vote state.
        {
            let mut invalid_vote_account = AccountSharedData::new(lamports, v4_size, &id());
            invalid_vote_account.set_data_from_slice(&vec![0xFFu8; v4_size]);

            let transaction_context = new_transaction_context(
                vec![
                    (id(), processor_account.clone()),
                    (vote_pubkey, invalid_vote_account),
                    (inflation_collector_pubkey, valid_collector_account()),
                    (block_revenue_collector_pubkey, valid_collector_account()),
                ],
                vec![
                    InstructionAccount::new(1, false, true),
                    InstructionAccount::new(2, false, true),
                    InstructionAccount::new(3, false, true),
                ],
                &rent,
            );
            let instruction_context = transaction_context.get_next_instruction_context().unwrap();
            let mut borrowed_vote_account = instruction_context
                .try_borrow_instruction_account(0)
                .unwrap();

            assert_eq!(
                initialize_account_v2(
                    &mut borrowed_vote_account,
                    target_version,
                    &vote_init,
                    NewCommissionCollector::NewAccount(
                        instruction_context
                            .try_borrow_instruction_account(1)
                            .unwrap(),
                    ),
                    NewCommissionCollector::NewAccount(
                        instruction_context
                            .try_borrow_instruction_account(2)
                            .unwrap(),
                    ),
                    &signers,
                    &clock,
                    &rent,
                    || Ok(()),
                ),
                Err(InstructionError::InvalidAccountData),
            );
        }

        // Should fail - vote account already initialized.
        {
            let preexisting_handler = vote_state_new_for_test(&vote_pubkey, target_version);
            let preexisting_state = preexisting_handler.as_ref_v4().clone();
            let serialized = preexisting_handler.serialize();
            let serialized_len = serialized.len();
            let mut initialized_vote_account =
                AccountSharedData::new(rent.minimum_balance(serialized_len), serialized_len, &id());
            initialized_vote_account.set_data_from_slice(&serialized);

            let transaction_context = new_transaction_context(
                vec![
                    (id(), processor_account.clone()),
                    (vote_pubkey, initialized_vote_account),
                    (inflation_collector_pubkey, valid_collector_account()),
                    (block_revenue_collector_pubkey, valid_collector_account()),
                ],
                vec![
                    InstructionAccount::new(1, false, true),
                    InstructionAccount::new(2, false, true),
                    InstructionAccount::new(3, false, true),
                ],
                &rent,
            );
            let instruction_context = transaction_context.get_next_instruction_context().unwrap();
            let mut borrowed_vote_account = instruction_context
                .try_borrow_instruction_account(0)
                .unwrap();

            assert_eq!(
                initialize_account_v2(
                    &mut borrowed_vote_account,
                    target_version,
                    &vote_init,
                    NewCommissionCollector::NewAccount(
                        instruction_context
                            .try_borrow_instruction_account(1)
                            .unwrap(),
                    ),
                    NewCommissionCollector::NewAccount(
                        instruction_context
                            .try_borrow_instruction_account(2)
                            .unwrap(),
                    ),
                    &signers,
                    &clock,
                    &rent,
                    || Ok(()),
                ),
                Err(InstructionError::AccountAlreadyInitialized),
            );

            // Pre-existing state must be untouched - the new init payload must
            // not have been written.
            let handler =
                get_vote_state_handler_checked(&borrowed_vote_account, target_version).unwrap();
            assert_eq!(*handler.as_ref_v4(), preexisting_state);
        }

        // Should fail - node_pubkey didn't sign.
        {
            let non_signers: HashSet<Pubkey> = HashSet::new();
            let transaction_context = new_transaction_context(
                vec![
                    (id(), processor_account.clone()),
                    (vote_pubkey, make_uninit_vote_account()),
                    (inflation_collector_pubkey, valid_collector_account()),
                    (block_revenue_collector_pubkey, valid_collector_account()),
                ],
                vec![
                    InstructionAccount::new(1, false, true),
                    InstructionAccount::new(2, false, true),
                    InstructionAccount::new(3, false, true),
                ],
                &rent,
            );
            let instruction_context = transaction_context.get_next_instruction_context().unwrap();
            let mut borrowed_vote_account = instruction_context
                .try_borrow_instruction_account(0)
                .unwrap();

            assert_eq!(
                initialize_account_v2(
                    &mut borrowed_vote_account,
                    target_version,
                    &vote_init,
                    NewCommissionCollector::NewAccount(
                        instruction_context
                            .try_borrow_instruction_account(1)
                            .unwrap(),
                    ),
                    NewCommissionCollector::NewAccount(
                        instruction_context
                            .try_borrow_instruction_account(2)
                            .unwrap(),
                    ),
                    &non_signers,
                    &clock,
                    &rent,
                    || Ok(()),
                ),
                Err(InstructionError::MissingRequiredSignature),
            );
            assert_still_uninitialized(&borrowed_vote_account);
        }

        // Should fail - SIMD-0232 collector account checks, applied to both
        // account indices.
        {
            #[derive(Clone, Copy)]
            enum CollectorSlot {
                Inflation,
                BlockRevenue,
            }

            let test_bad_collector =
                |slot: CollectorSlot,
                 bad_collector: AccountSharedData,
                 bad_collector_is_writable: bool,
                 expected_error: InstructionError| {
                    let (
                        inflation_account,
                        inflation_writable,
                        block_revenue_account,
                        block_revenue_writable,
                    ) = match slot {
                        CollectorSlot::Inflation => (
                            bad_collector,
                            bad_collector_is_writable,
                            valid_collector_account(),
                            true,
                        ),
                        CollectorSlot::BlockRevenue => (
                            valid_collector_account(),
                            true,
                            bad_collector,
                            bad_collector_is_writable,
                        ),
                    };

                    let transaction_context = new_transaction_context(
                        vec![
                            (id(), processor_account.clone()),
                            (vote_pubkey, make_uninit_vote_account()),
                            (inflation_collector_pubkey, inflation_account),
                            (block_revenue_collector_pubkey, block_revenue_account),
                        ],
                        vec![
                            InstructionAccount::new(1, false, true),
                            InstructionAccount::new(2, false, inflation_writable),
                            InstructionAccount::new(3, false, block_revenue_writable),
                        ],
                        &rent,
                    );
                    let instruction_context =
                        transaction_context.get_next_instruction_context().unwrap();
                    let mut borrowed_vote_account = instruction_context
                        .try_borrow_instruction_account(0)
                        .unwrap();

                    assert_eq!(
                        initialize_account_v2(
                            &mut borrowed_vote_account,
                            target_version,
                            &vote_init,
                            NewCommissionCollector::NewAccount(
                                instruction_context
                                    .try_borrow_instruction_account(1)
                                    .unwrap(),
                            ),
                            NewCommissionCollector::NewAccount(
                                instruction_context
                                    .try_borrow_instruction_account(2)
                                    .unwrap(),
                            ),
                            &signers,
                            &clock,
                            &rent,
                            || Ok(()),
                        ),
                        Err(expected_error),
                    );
                    assert_still_uninitialized(&borrowed_vote_account);
                };

            for slot in [CollectorSlot::Inflation, CollectorSlot::BlockRevenue] {
                // 1. Not system-owned.
                test_bad_collector(
                    slot,
                    AccountSharedData::new(rent.minimum_balance(0), 0, &solana_pubkey::new_rand()),
                    true,
                    InstructionError::InvalidAccountOwner,
                );

                // 2. Not rent-exempt.
                test_bad_collector(
                    slot,
                    AccountSharedData::new(0, 0, &system_program::id()),
                    true,
                    InstructionError::InsufficientFunds,
                );

                // 3. Not writable.
                test_bad_collector(
                    slot,
                    valid_collector_account(),
                    false,
                    InstructionError::InvalidArgument,
                );
            }
        }

        // Should fail - BLS proof of possession does not verify.
        {
            let bad_vote_init = VoteInitV2 {
                authorized_voter_bls_pubkey: [1u8; BLS_PUBLIC_KEY_COMPRESSED_SIZE],
                authorized_voter_bls_proof_of_possession: [2u8;
                    BLS_PROOF_OF_POSSESSION_COMPRESSED_SIZE],
                ..vote_init
            };
            let transaction_context = new_transaction_context(
                vec![
                    (id(), processor_account),
                    (vote_pubkey, make_uninit_vote_account()),
                    (inflation_collector_pubkey, valid_collector_account()),
                    (block_revenue_collector_pubkey, valid_collector_account()),
                ],
                vec![
                    InstructionAccount::new(1, false, true),
                    InstructionAccount::new(2, false, true),
                    InstructionAccount::new(3, false, true),
                ],
                &rent,
            );
            let instruction_context = transaction_context.get_next_instruction_context().unwrap();
            let mut borrowed_vote_account = instruction_context
                .try_borrow_instruction_account(0)
                .unwrap();

            assert_eq!(
                initialize_account_v2(
                    &mut borrowed_vote_account,
                    target_version,
                    &bad_vote_init,
                    NewCommissionCollector::NewAccount(
                        instruction_context
                            .try_borrow_instruction_account(1)
                            .unwrap(),
                    ),
                    NewCommissionCollector::NewAccount(
                        instruction_context
                            .try_borrow_instruction_account(2)
                            .unwrap(),
                    ),
                    &signers,
                    &clock,
                    &rent,
                    || Ok(()),
                ),
                Err(InstructionError::InvalidArgument),
            );
            assert_still_uninitialized(&borrowed_vote_account);
        }
    }

    /// recipient at index 2.
    fn setup_withdraw_context(
        vote_pubkey: Pubkey,
        vote_account: AccountSharedData,
    ) -> TransactionContext<'static> {
        let rent = Rent::default();
        let recipient = solana_pubkey::new_rand();
        let program_account = AccountSharedData::new(0, 0, &solana_sdk_ids::native_loader::id());
        let mut transaction_context = TransactionContext::new(
            vec![
                (id(), program_account),
                (vote_pubkey, vote_account),
                (recipient, AccountSharedData::default()),
            ],
            rent,
            0,
            0,
            1,
        );
        transaction_context
            .configure_top_level_instruction_for_tests(
                0,
                vec![
                    InstructionAccount::new(1, false, true),
                    InstructionAccount::new(2, false, true),
                ],
                vec![],
            )
            .unwrap();
        transaction_context
    }

    #[test_case(VoteStateTargetVersion::V4 ; "VoteStateV4")]
    fn test_withdraw(target_version: VoteStateTargetVersion) {
        // Verify withdraw boundary conditions around the rent-exempt
        // minimum: partial withdraw, full deinit, and over-withdraw.
        let vote_pubkey = solana_pubkey::new_rand();
        let vote_state = vote_state_new_for_test(&vote_pubkey, target_version);
        let withdrawer = *vote_state.authorized_withdrawer();
        let signers: HashSet<Pubkey> = [withdrawer].into_iter().collect();
        let rent = Rent::default();
        let serialized = vote_state.clone().serialize();
        let serialized_len = serialized.len();
        let min_balance = rent.minimum_balance(serialized_len);
        let clock = Clock {
            epoch: 100,
            ..Clock::default()
        };

        // Account at exact rent-exempt minimum: withdraw 1 fails.
        {
            let mut acct = AccountSharedData::new(min_balance, serialized_len, &id());
            acct.set_data_from_slice(&serialized);
            let transaction_context = setup_withdraw_context(vote_pubkey, acct);
            let ix = transaction_context.get_next_instruction_context().unwrap();
            assert_eq!(
                withdraw(&ix, 0, target_version, 1, 1, &signers, &rent, &clock),
                Err(InstructionError::InsufficientFunds)
            );
        }

        // Account at exact rent-exempt minimum: withdraw all succeeds (deinit).
        {
            let mut acct = AccountSharedData::new(min_balance, serialized_len, &id());
            acct.set_data_from_slice(&serialized);
            let transaction_context = setup_withdraw_context(vote_pubkey, acct);
            let ix = transaction_context.get_next_instruction_context().unwrap();
            withdraw(
                &ix,
                0,
                target_version,
                min_balance,
                1,
                &signers,
                &rent,
                &clock,
            )
            .unwrap();
        }

        // Account at rent_exempt + 100: withdraw 100 succeeds.
        {
            let mut acct = AccountSharedData::new(min_balance + 100, serialized_len, &id());
            acct.set_data_from_slice(&serialized);
            let transaction_context = setup_withdraw_context(vote_pubkey, acct);
            let ix = transaction_context.get_next_instruction_context().unwrap();
            withdraw(&ix, 0, target_version, 100, 1, &signers, &rent, &clock).unwrap();
        }

        // Account at rent_exempt + 100: withdraw 101 fails.
        {
            let mut acct = AccountSharedData::new(min_balance + 100, serialized_len, &id());
            acct.set_data_from_slice(&serialized);
            let transaction_context = setup_withdraw_context(vote_pubkey, acct);
            let ix = transaction_context.get_next_instruction_context().unwrap();
            assert_eq!(
                withdraw(&ix, 0, target_version, 101, 1, &signers, &rent, &clock),
                Err(InstructionError::InsufficientFunds)
            );
        }
    }

    /// Helper to create a V4 vote account with a specific
    /// `pending_delegator_rewards` value.
    fn make_v4_account_with_pending(
        vote_pubkey: &Pubkey,
        pending: u64,
        extra_lamports: u64,
    ) -> (VoteStateHandler, AccountSharedData) {
        let vote_state = vote_state_new_for_test(vote_pubkey, VoteStateTargetVersion::V4);
        let mut v4 = vote_state.as_ref_v4().clone();
        v4.pending_delegator_rewards = pending;
        let handler = VoteStateHandler::new_v4(v4);
        let serialized = handler.clone().serialize();
        let rent = Rent::default();
        let lamports = rent.minimum_balance(serialized.len()) + extra_lamports;
        let mut account = AccountSharedData::new(lamports, serialized.len(), &id());
        account.set_data_from_slice(&serialized);
        (handler, account)
    }

    #[test]
    fn test_withdraw_with_pending_delegator_rewards() {
        // Verify withdraw protects pending_delegator_rewards: partial
        // withdrawals respect the pending reserve, and full close is
        // blocked when pending > 0.
        let vote_pubkey = solana_pubkey::new_rand();
        let rent = Rent::default();
        let clock = Clock {
            epoch: 100,
            ..Clock::default()
        };

        // pending = 1000, extra = 1000. withdrawable = 0.
        {
            let (handler, account) = make_v4_account_with_pending(&vote_pubkey, 1000, 1000);
            let withdrawer = *handler.authorized_withdrawer();
            let signers: HashSet<Pubkey> = [withdrawer].into_iter().collect();
            let tx = setup_withdraw_context(vote_pubkey, account);
            let ix = tx.get_next_instruction_context().unwrap();

            // Withdraw 1 fails (withdrawable = lamports - rent - pending = 0).
            assert_eq!(
                withdraw(
                    &ix,
                    0,
                    VoteStateTargetVersion::V4,
                    1,
                    1,
                    &signers,
                    &rent,
                    &clock
                ),
                Err(InstructionError::InsufficientFunds)
            );
        }

        // pending = 1000, extra = 1001. withdrawable = 1.
        {
            let (handler, account) = make_v4_account_with_pending(&vote_pubkey, 1000, 1001);
            let withdrawer = *handler.authorized_withdrawer();
            let signers: HashSet<Pubkey> = [withdrawer].into_iter().collect();
            let tx = setup_withdraw_context(vote_pubkey, account);
            let ix = tx.get_next_instruction_context().unwrap();

            // Withdraw 1 succeeds.
            withdraw(
                &ix,
                0,
                VoteStateTargetVersion::V4,
                1,
                1,
                &signers,
                &rent,
                &clock,
            )
            .unwrap();
        }

        // pending = 1000, extra = 1001. Withdraw 2 fails.
        {
            let (handler, account) = make_v4_account_with_pending(&vote_pubkey, 1000, 1001);
            let withdrawer = *handler.authorized_withdrawer();
            let signers: HashSet<Pubkey> = [withdrawer].into_iter().collect();
            let tx = setup_withdraw_context(vote_pubkey, account);
            let ix = tx.get_next_instruction_context().unwrap();

            assert_eq!(
                withdraw(
                    &ix,
                    0,
                    VoteStateTargetVersion::V4,
                    2,
                    1,
                    &signers,
                    &rent,
                    &clock
                ),
                Err(InstructionError::InsufficientFunds)
            );
        }

        // Full close blocked when pending > 0.
        {
            let (handler, account) = make_v4_account_with_pending(&vote_pubkey, 1, 1_000_000);
            let withdrawer = *handler.authorized_withdrawer();
            let signers: HashSet<Pubkey> = [withdrawer].into_iter().collect();
            let lamports = rent.minimum_balance(VoteStateV4::size_of()) + 1_000_000;
            let tx = setup_withdraw_context(vote_pubkey, account);
            let ix = tx.get_next_instruction_context().unwrap();

            assert_eq!(
                withdraw(
                    &ix,
                    0,
                    VoteStateTargetVersion::V4,
                    lamports,
                    1,
                    &signers,
                    &rent,
                    &clock
                ),
                Err(InstructionError::InsufficientFunds)
            );
        }

        // Full close succeeds when pending = 0.
        {
            let (handler, account) = make_v4_account_with_pending(&vote_pubkey, 0, 100);
            let withdrawer = *handler.authorized_withdrawer();
            let signers: HashSet<Pubkey> = [withdrawer].into_iter().collect();
            let lamports = rent.minimum_balance(VoteStateV4::size_of()) + 100;
            let tx = setup_withdraw_context(vote_pubkey, account);
            let ix = tx.get_next_instruction_context().unwrap();

            withdraw(
                &ix,
                0,
                VoteStateTargetVersion::V4,
                lamports,
                1,
                &signers,
                &rent,
                &clock,
            )
            .unwrap();
        }
    }

    /// Build a maximum-size V3 vote state with all variable-length
    /// collections at capacity (votes, epoch_credits, authorized_voters).
    fn get_max_sized_vote_state_v3() -> VoteStateV3 {
        let root_slot = 42u64;
        let votes: VecDeque<LandedVote> = (0..MAX_LOCKOUT_HISTORY)
            .map(|i| LandedVote {
                latency: i as u8,
                lockout: Lockout::new_with_confirmation_count(
                    root_slot + i as u64 + 1,
                    (MAX_LOCKOUT_HISTORY - i) as u32,
                ),
            })
            .collect();
        let epoch_credits: Vec<(u64, u64, u64)> = (0..MAX_EPOCH_CREDITS_HISTORY)
            .map(|i| (i as u64, (i as u64 + 1) * 100, i as u64 * 100))
            .collect();
        let mut authorized_voters = AuthorizedVoters::default();
        for i in 0..=solana_epoch_schedule::MAX_LEADER_SCHEDULE_EPOCH_OFFSET {
            authorized_voters.insert(i, solana_pubkey::new_rand());
        }

        VoteStateV3 {
            node_pubkey: solana_pubkey::new_rand(),
            authorized_withdrawer: solana_pubkey::new_rand(),
            commission: 42,
            votes,
            root_slot: Some(root_slot),
            epoch_credits,
            authorized_voters,
            ..Default::default()
        }
    }

    #[test]
    fn test_v3_to_v4_stale_trailing_bytes() {
        // V4 deserializer must ignore trailing bytes left over from a
        // V3 to V4 conversion in a fixed-size account buffer.
        //
        // The conversion and serialization is driven through the handler, ie.
        // `get_vote_state_handler_checked`/`try_convert_to_vote_state_v4`.
        //
        // We conduct this test through `get_vote_state_handler_checked` to
        // ensure we're testing program code.
        let vote_pubkey = solana_pubkey::new_rand();
        let v3 = get_max_sized_vote_state_v3();
        let node_pubkey = v3.node_pubkey;
        let authorized_withdrawer = v3.authorized_withdrawer;
        let commission = v3.commission;
        let root_slot = v3.root_slot;
        let votes = v3.votes.clone();
        let epoch_credits = v3.epoch_credits.clone();
        let authorized_voters = v3.authorized_voters.clone();
        let last_timestamp = v3.last_timestamp.clone();

        // Serialize V3 into a fixed-size account buffer.
        let buf_size = VoteStateV3::size_of();
        let v3_versioned = VoteStateVersions::V3(Box::new(v3));
        let v3_serialized_len = bincode::serialized_size(&v3_versioned).unwrap() as usize;
        let mut vote_account_data = vec![0u8; buf_size];
        bincode::serialize_into(&mut vote_account_data[..], &v3_versioned).unwrap();

        // Drive V3 to V4 conversion through the program handler.
        let rent = Rent::default();
        let lamports = rent.minimum_balance(buf_size) + 1_000_000;
        let mut vote_account = AccountSharedData::new(lamports, buf_size, &id());
        vote_account.set_data_from_slice(&vote_account_data);
        let program_account = AccountSharedData::new(0, 0, &solana_sdk_ids::native_loader::id());
        let transaction_context = new_transaction_context(
            vec![(id(), program_account), (vote_pubkey, vote_account)],
            vec![InstructionAccount::new(1, false, true)],
            &rent,
        );
        let ix = transaction_context.get_next_instruction_context().unwrap();
        let mut borrowed = ix.try_borrow_instruction_account(0).unwrap();

        // `get_vote_state_handler_checked` with V4 target triggers the full
        // deser -> conversion path; `set_vote_account_state` writes it back.
        let vote_state =
            get_vote_state_handler_checked(&borrowed, VoteStateTargetVersion::V4).unwrap();
        vote_state.set_vote_account_state(&mut borrowed).unwrap();

        // Inspect raw account data written by the handler.
        let account_data = borrowed.get_data();
        let v4_serialized_len = {
            let v4 = VoteStateV4::deserialize(account_data, &vote_pubkey).unwrap();
            bincode::serialized_size(&VoteStateVersions::new_v4(v4)).unwrap() as usize
        };
        assert!(
            v4_serialized_len < v3_serialized_len,
            "v4 ({v4_serialized_len}) should be smaller than v3 ({v3_serialized_len})",
        );

        // The V4 deserializer must produce the correct state despite
        // trailing bytes left from the larger V3 serialization.
        let deserialized = VoteStateV4::deserialize(account_data, &vote_pubkey).unwrap();
        assert_eq!(deserialized.node_pubkey, node_pubkey);
        assert_eq!(deserialized.authorized_withdrawer, authorized_withdrawer);
        assert_eq!(deserialized.root_slot, root_slot);
        assert_eq!(deserialized.votes, votes);
        assert_eq!(deserialized.epoch_credits, epoch_credits);
        assert_eq!(deserialized.authorized_voters, authorized_voters);
        assert_eq!(
            deserialized.inflation_rewards_commission_bps,
            commission as u16 * 100
        );
        assert_eq!(deserialized.last_timestamp, last_timestamp);

        // Fill the trailing region with non-zero garbage, then round-trip
        // through the handler again to verify the program handles it.
        borrowed.get_data_mut().unwrap()[v4_serialized_len..].fill(0xDE);

        let vote_state =
            get_vote_state_handler_checked(&borrowed, VoteStateTargetVersion::V4).unwrap();
        vote_state.set_vote_account_state(&mut borrowed).unwrap();

        let deserialized = VoteStateV4::deserialize(borrowed.get_data(), &vote_pubkey).unwrap();
        assert_eq!(deserialized.node_pubkey, node_pubkey);
        assert_eq!(deserialized.authorized_withdrawer, authorized_withdrawer);
        assert_eq!(deserialized.root_slot, root_slot);
        assert_eq!(deserialized.votes, votes);
        assert_eq!(deserialized.epoch_credits, epoch_credits);
        assert_eq!(deserialized.authorized_voters, authorized_voters);
        assert_eq!(
            deserialized.inflation_rewards_commission_bps,
            commission as u16 * 100
        );
        assert_eq!(deserialized.last_timestamp, last_timestamp);
    }

    #[test]
    fn test_v3_to_v4_trailing_bytes_shrink_and_regrow() {
        // Exercises the full lifecycle of trailing-byte behavior in a
        // fixed-size account buffer, driven through the program handlers
        // `get_vote_state_handler_checked` and `set_vote_account_state`:
        // * Step 1: Start with a max-size V3 state (all collections full).
        // * Step 2: Convert V3 -> V4 via the handler. V4's serialized form
        //           is smaller, leaving trailing garbage.
        // * Step 3: Clear all votes, simulating the extreme case of a
        //           validator whose entire tower has expired, which shrinks
        //           the v4 vote state.
        // * Step 4: Re-add votes incrementally, round-tripping through the
        //           handler each time to verify the program handles the
        //           growing serialized region over stale trailing bytes.

        let vote_pubkey = solana_pubkey::new_rand();
        let v3 = get_max_sized_vote_state_v3();
        let node_pubkey = v3.node_pubkey;
        let authorized_withdrawer = v3.authorized_withdrawer;
        let commission = v3.commission;
        let root_slot = v3.root_slot;
        let votes = v3.votes.clone();
        let epoch_credits = v3.epoch_credits.clone();
        let authorized_voters = v3.authorized_voters.clone();
        let last_timestamp = v3.last_timestamp.clone();

        // Step 1: Populate V3 account and record V3 serialized size.
        let buf_size = VoteStateV3::size_of();
        let v3_versioned = VoteStateVersions::V3(Box::new(v3));
        let v3_serialized_len = bincode::serialized_size(&v3_versioned).unwrap() as usize;
        let mut vote_account_data = vec![0u8; buf_size];
        bincode::serialize_into(&mut vote_account_data[..], &v3_versioned).unwrap();

        let rent = Rent::default();
        let lamports = rent.minimum_balance(buf_size) + 1_000_000;
        let mut vote_account = AccountSharedData::new(lamports, buf_size, &id());
        vote_account.set_data_from_slice(&vote_account_data);
        let program_account = AccountSharedData::new(0, 0, &solana_sdk_ids::native_loader::id());
        let transaction_context = new_transaction_context(
            vec![(id(), program_account), (vote_pubkey, vote_account)],
            vec![InstructionAccount::new(1, false, true)],
            &rent,
        );
        let ix = transaction_context.get_next_instruction_context().unwrap();
        let mut borrowed = ix.try_borrow_instruction_account(0).unwrap();

        // Step 2: V3 -> V4 conversion via the handler.
        let vote_state =
            get_vote_state_handler_checked(&borrowed, VoteStateTargetVersion::V4).unwrap();
        vote_state.set_vote_account_state(&mut borrowed).unwrap();

        let v4_after_convert = VoteStateV4::deserialize(borrowed.get_data(), &vote_pubkey).unwrap();
        let v4_serialized_len =
            bincode::serialized_size(&VoteStateVersions::new_v4(v4_after_convert.clone())).unwrap()
                as usize;

        assert!(
            v4_serialized_len < v3_serialized_len,
            "v4 ({v4_serialized_len}) should be smaller than v3 ({v3_serialized_len})",
        );
        let trailing_len_after_convert = buf_size - v4_serialized_len;
        assert!(
            trailing_len_after_convert > 0,
            "expected trailing bytes after v3 -> v4 conversion"
        );

        // Verify field-level correctness of the converted state.
        assert_eq!(v4_after_convert.node_pubkey, node_pubkey);
        assert_eq!(
            v4_after_convert.authorized_withdrawer,
            authorized_withdrawer
        );
        assert_eq!(v4_after_convert.root_slot, root_slot);
        assert_eq!(v4_after_convert.votes, votes);
        assert_eq!(v4_after_convert.epoch_credits, epoch_credits);
        assert_eq!(v4_after_convert.authorized_voters, authorized_voters);
        assert_eq!(
            v4_after_convert.inflation_rewards_commission_bps,
            commission as u16 * 100,
        );
        assert_eq!(v4_after_convert.last_timestamp, last_timestamp);

        // Step 3a: Clear all votes, round-trip with resulting stale bytes.
        let mut v4_empty_votes = v4_after_convert.clone();
        v4_empty_votes.votes.clear();
        let v4_empty_serialized_len =
            bincode::serialized_size(&VoteStateVersions::new_v4(v4_empty_votes.clone())).unwrap()
                as usize;
        assert!(
            v4_empty_serialized_len < v4_serialized_len,
            "empty-votes v4 ({v4_empty_serialized_len}) should be smaller than full v4 \
             ({v4_serialized_len})",
        );

        // Write the vote-cleared state. The trailing region now contains
        // stale bytes from the previous (larger) V4 serialization.
        borrowed
            .set_state(&VoteStateVersions::new_v4(v4_empty_votes.clone()))
            .unwrap();
        let trailing_len_after_clear = buf_size - v4_empty_serialized_len;
        assert!(
            trailing_len_after_clear > trailing_len_after_convert,
            "trailing region should grow after clearing votes: {trailing_len_after_clear} vs \
             {trailing_len_after_convert}",
        );

        // Round-trip through the handler with the stale bytes.
        let vote_state =
            get_vote_state_handler_checked(&borrowed, VoteStateTargetVersion::V4).unwrap();
        vote_state.set_vote_account_state(&mut borrowed).unwrap();

        let deserialized = VoteStateV4::deserialize(borrowed.get_data(), &vote_pubkey).unwrap();
        assert!(deserialized.votes.is_empty(),);
        assert_eq!(deserialized.epoch_credits.len(), MAX_EPOCH_CREDITS_HISTORY,);
        assert_eq!(deserialized.authorized_voters, authorized_voters,);
        assert_eq!(deserialized.last_timestamp, last_timestamp);

        // Step 3b: Fill trailing with explicit garbage and round-trip again.
        //
        // Overwrite the trailing region with a non-zero pattern to verify
        // the handler is not sensitive to arbitrary trailing content.
        borrowed.get_data_mut().unwrap()[v4_empty_serialized_len..].fill(0xCD);

        let vote_state =
            get_vote_state_handler_checked(&borrowed, VoteStateTargetVersion::V4).unwrap();
        vote_state.set_vote_account_state(&mut borrowed).unwrap();

        let deserialized = VoteStateV4::deserialize(borrowed.get_data(), &vote_pubkey).unwrap();
        assert!(deserialized.votes.is_empty());
        assert_eq!(deserialized.epoch_credits.len(), MAX_EPOCH_CREDITS_HISTORY);
        assert_eq!(deserialized.authorized_voters, authorized_voters);
        assert_eq!(deserialized.last_timestamp, last_timestamp);

        // Step 4: Re-add votes, growing the serialized region.
        //
        // Incrementally add votes back, writing each state and filling
        // trailing with garbage, then round-tripping through the handler
        // to verify it handles the growing data region correctly.
        let mut v4_regrowing = v4_empty_votes;
        for i in 0..MAX_LOCKOUT_HISTORY {
            v4_regrowing.votes.push_back(LandedVote {
                latency: (i % 256) as u8,
                lockout: Lockout::new_with_confirmation_count(
                    root_slot.unwrap() + 1000 + i as u64,
                    (MAX_LOCKOUT_HISTORY - i) as u32,
                ),
            });

            // Write the updated state, fill trailing with garbage.
            borrowed
                .set_state(&VoteStateVersions::new_v4(v4_regrowing.clone()))
                .unwrap();
            let current_serialized_len =
                bincode::serialized_size(&VoteStateVersions::new_v4(v4_regrowing.clone())).unwrap()
                    as usize;
            let current_trailing = buf_size - current_serialized_len;
            assert!(
                current_trailing < trailing_len_after_clear,
                "trailing region should shrink as votes are added"
            );
            if current_serialized_len < buf_size {
                borrowed.get_data_mut().unwrap()[current_serialized_len..].fill(0xEF);
            }

            // Round-trip through the handler to verify.
            let vote_state =
                get_vote_state_handler_checked(&borrowed, VoteStateTargetVersion::V4).unwrap();
            vote_state.set_vote_account_state(&mut borrowed).unwrap();

            let deserialized = VoteStateV4::deserialize(borrowed.get_data(), &vote_pubkey).unwrap();
            assert_eq!(
                deserialized.votes.len(),
                i + 1,
                "expected {} votes after re-adding",
                i + 1,
            );
            assert_eq!(deserialized, v4_regrowing);
        }

        // Final consistency check: all votes are back and all fields correct.
        let final_deserialized =
            VoteStateV4::deserialize(borrowed.get_data(), &vote_pubkey).unwrap();
        assert_eq!(final_deserialized.votes.len(), MAX_LOCKOUT_HISTORY);
        assert_eq!(final_deserialized.epoch_credits, epoch_credits);
        assert_eq!(final_deserialized.authorized_voters, authorized_voters);
        assert_eq!(final_deserialized.last_timestamp, last_timestamp);
    }

    #[test]
    fn test_bls_absent_after_v3_to_v4_migration() {
        // V3 to V4 migration via get_vote_state_handler_checked must
        // produce bls_pubkey_compressed = None.
        let vote_pubkey = solana_pubkey::new_rand();
        let v3 = VoteStateV3::new(
            &VoteInit {
                node_pubkey: solana_pubkey::new_rand(),
                authorized_voter: solana_pubkey::new_rand(),
                authorized_withdrawer: solana_pubkey::new_rand(),
                commission: 10,
            },
            &Clock::default(),
        );
        let last_timestamp = v3.last_timestamp.clone();

        // Serialize V3 into an account.
        let buf_size = VoteStateV3::size_of();
        let v3_versioned = VoteStateVersions::V3(Box::new(v3));
        let mut vote_account_data = vec![0u8; buf_size];
        bincode::serialize_into(&mut vote_account_data[..], &v3_versioned).unwrap();

        let rent = Rent::default();
        let lamports = rent.minimum_balance(buf_size) + 1_000_000;
        let mut vote_account = AccountSharedData::new(lamports, buf_size, &id());
        vote_account.set_data_from_slice(&vote_account_data);
        let program_account = AccountSharedData::new(0, 0, &solana_sdk_ids::native_loader::id());
        let transaction_context = new_transaction_context(
            vec![(id(), program_account), (vote_pubkey, vote_account)],
            vec![InstructionAccount::new(1, false, true)],
            &rent,
        );
        let ix = transaction_context.get_next_instruction_context().unwrap();
        let mut borrowed = ix.try_borrow_instruction_account(0).unwrap();

        // Drive conversion through the handler.
        let vote_state =
            get_vote_state_handler_checked(&borrowed, VoteStateTargetVersion::V4).unwrap();
        vote_state.set_vote_account_state(&mut borrowed).unwrap();

        let v4 = VoteStateHandler::new_v4(
            VoteStateV4::deserialize(borrowed.get_data(), &vote_pubkey).unwrap(),
        );
        assert_eq!(v4.as_ref_v4().bls_pubkey_compressed, None);
        assert!(!v4.has_bls_pubkey());
        assert_eq!(v4.as_ref_v4().last_timestamp, last_timestamp);
    }

    #[test]
    fn test_bls_overwrite_via_voter_with_bls() {
        // BLS pubkey set to A, then overwritten to B via VoterWithBLS.
        let vote_pubkey = Pubkey::new_unique();
        let (bls_a, pop_a) = create_bls_pubkey_and_proof_of_possession(&vote_pubkey);
        let (bls_b, pop_b) = create_bls_pubkey_and_proof_of_possession(&vote_pubkey);

        let vote_state = vote_state_new_for_test(&vote_pubkey, VoteStateTargetVersion::V4);
        let withdrawer = *vote_state.authorized_withdrawer();
        let node_pubkey = *vote_state.node_pubkey();
        let serialized = vote_state.serialize();
        let rent = Rent::default();
        let lamports = rent.minimum_balance(serialized.len());
        let mut vote_account = AccountSharedData::new(lamports, serialized.len(), &id());
        vote_account.set_data_from_slice(&serialized);
        let program_account = AccountSharedData::new(0, 0, &solana_sdk_ids::native_loader::id());
        let transaction_context = new_transaction_context(
            vec![(id(), program_account), (vote_pubkey, vote_account)],
            vec![InstructionAccount::new(1, false, true)],
            &rent,
        );
        let ix = transaction_context.get_next_instruction_context().unwrap();
        let mut borrowed = ix.try_borrow_instruction_account(0).unwrap();

        let signers: HashSet<Pubkey> = [withdrawer, Pubkey::new_unique()].into_iter().collect();

        // Set BLS A.
        authorize(
            &mut borrowed,
            VoteStateTargetVersion::V4,
            &Pubkey::new_unique(),
            VoteAuthorize::VoterWithBLS(VoterWithBLSArgs {
                bls_pubkey: bls_a,
                bls_proof_of_possession: pop_a,
            }),
            &signers,
            &Clock::default(),
            true,
            || Ok(()),
        )
        .unwrap();

        let v4 = VoteStateV4::deserialize(borrowed.get_data(), &node_pubkey).unwrap();
        assert_eq!(v4.bls_pubkey_compressed, Some(bls_a));

        // Overwrite with BLS B.
        let clock = Clock {
            epoch: 3,
            ..Clock::default()
        };
        authorize(
            &mut borrowed,
            VoteStateTargetVersion::V4,
            &Pubkey::new_unique(),
            VoteAuthorize::VoterWithBLS(VoterWithBLSArgs {
                bls_pubkey: bls_b,
                bls_proof_of_possession: pop_b,
            }),
            &signers,
            &clock,
            true,
            || Ok(()),
        )
        .unwrap();

        let v4 = VoteStateV4::deserialize(borrowed.get_data(), &node_pubkey).unwrap();
        assert_eq!(v4.bls_pubkey_compressed, Some(bls_b));
    }

    #[test]
    fn test_bls_pop_cryptographic_failures() {
        // Invalid PoP scenarios: zero bytes, garbage bytes, and
        // PoP bound to the wrong vote account.
        let vote_pubkey = Pubkey::new_unique();
        let vote_state = vote_state_new_for_test(&vote_pubkey, VoteStateTargetVersion::V4);
        let withdrawer = *vote_state.authorized_withdrawer();
        let serialized = vote_state.serialize();
        let rent = Rent::default();
        let lamports = rent.minimum_balance(serialized.len());
        let mut vote_account = AccountSharedData::new(lamports, serialized.len(), &id());
        vote_account.set_data_from_slice(&serialized);
        let program_account = AccountSharedData::new(0, 0, &solana_sdk_ids::native_loader::id());
        let transaction_context = new_transaction_context(
            vec![(id(), program_account), (vote_pubkey, vote_account)],
            vec![InstructionAccount::new(1, false, true)],
            &rent,
        );
        let ix = transaction_context.get_next_instruction_context().unwrap();
        let mut borrowed = ix.try_borrow_instruction_account(0).unwrap();
        let signers: HashSet<Pubkey> = [withdrawer, Pubkey::new_unique()].into_iter().collect();
        let clock = Clock::default();

        // All-zero BLS pubkey + PoP.
        assert_eq!(
            authorize(
                &mut borrowed,
                VoteStateTargetVersion::V4,
                &Pubkey::new_unique(),
                VoteAuthorize::VoterWithBLS(VoterWithBLSArgs {
                    bls_pubkey: [0u8; BLS_PUBLIC_KEY_COMPRESSED_SIZE],
                    bls_proof_of_possession: [0u8; BLS_PROOF_OF_POSSESSION_COMPRESSED_SIZE],
                }),
                &signers,
                &clock,
                true,
                || Ok(()),
            ),
            Err(InstructionError::InvalidArgument)
        );

        // Random garbage BLS pubkey + PoP.
        assert_eq!(
            authorize(
                &mut borrowed,
                VoteStateTargetVersion::V4,
                &Pubkey::new_unique(),
                VoteAuthorize::VoterWithBLS(VoterWithBLSArgs {
                    bls_pubkey: [0xAB; BLS_PUBLIC_KEY_COMPRESSED_SIZE],
                    bls_proof_of_possession: [0xCD; BLS_PROOF_OF_POSSESSION_COMPRESSED_SIZE],
                }),
                &signers,
                &clock,
                true,
                || Ok(()),
            ),
            Err(InstructionError::InvalidArgument)
        );

        // Valid BLS pubkey but PoP for wrong vote account.
        let other_vote = Pubkey::new_unique();
        let (bls_for_other, pop_for_other) = create_bls_pubkey_and_proof_of_possession(&other_vote);
        assert_eq!(
            authorize(
                &mut borrowed,
                VoteStateTargetVersion::V4,
                &Pubkey::new_unique(),
                VoteAuthorize::VoterWithBLS(VoterWithBLSArgs {
                    bls_pubkey: bls_for_other,
                    bls_proof_of_possession: pop_for_other,
                }),
                &signers,
                &clock,
                true,
                || Ok(()),
            ),
            Err(InstructionError::InvalidArgument)
        );
    }

    #[test]
    fn test_collector_fields_immutable_in_v4_only_scope() {
        // Verify `inflation_rewards_collector` and `block_revenue_collector`
        // are not modified by `Authorize` or `UpdateCommission` post-v4.
        let vote_pubkey = solana_pubkey::new_rand();
        let vote_state = vote_state_new_for_test(&vote_pubkey, VoteStateTargetVersion::V4);
        let withdrawer = *vote_state.authorized_withdrawer();
        let original_inflation_collector = vote_state.as_ref_v4().inflation_rewards_collector;
        let original_block_revenue_collector = vote_state.as_ref_v4().block_revenue_collector;

        let serialized = vote_state.clone().serialize();
        let rent = Rent::default();
        let lamports = rent.minimum_balance(serialized.len());
        let mut vote_account = AccountSharedData::new(lamports, serialized.len(), &id());
        vote_account.set_data_from_slice(&serialized);
        let program_account = AccountSharedData::new(0, 0, &solana_sdk_ids::native_loader::id());
        let transaction_context = new_transaction_context(
            vec![(id(), program_account), (vote_pubkey, vote_account)],
            vec![InstructionAccount::new(1, false, true)],
            &rent,
        );
        let instruction_context = transaction_context.get_next_instruction_context().unwrap();
        let mut borrowed = instruction_context
            .try_borrow_instruction_account(0)
            .unwrap();

        let signers: HashSet<Pubkey> = [withdrawer].into_iter().collect();
        let clock = Clock::default();

        // Authorize: should not change collectors.
        authorize(
            &mut borrowed,
            VoteStateTargetVersion::V4,
            &solana_pubkey::new_rand(),
            VoteAuthorize::Voter,
            &signers,
            &clock,
            false,
            || Ok(()),
        )
        .unwrap();

        let v4 = VoteStateV4::deserialize(borrowed.get_data(), &vote_state.as_ref_v4().node_pubkey)
            .unwrap();
        assert_eq!(v4.inflation_rewards_collector, original_inflation_collector);
        assert_eq!(v4.block_revenue_collector, original_block_revenue_collector);

        // UpdateCommission: should not change collectors.
        update_commission(
            &mut borrowed,
            VoteStateTargetVersion::V4,
            50,
            &signers,
            &solana_epoch_schedule::EpochSchedule::without_warmup(),
            &clock,
            false,
        )
        .unwrap();

        let v4 = VoteStateV4::deserialize(borrowed.get_data(), &vote_state.as_ref_v4().node_pubkey)
            .unwrap();
        assert_eq!(v4.inflation_rewards_collector, original_inflation_collector);
        assert_eq!(v4.block_revenue_collector, original_block_revenue_collector);
    }

    #[test]
    fn test_pending_delegator_rewards_zero_in_v4_only_scope() {
        // Verify `pending_delegator_rewards` stays 0 through post-v4
        // instructions (SIMD-0123 not active).
        let vote_pubkey = solana_pubkey::new_rand();
        let vote_state = vote_state_new_for_test(&vote_pubkey, VoteStateTargetVersion::V4);
        let withdrawer = *vote_state.authorized_withdrawer();

        let serialized = vote_state.clone().serialize();
        let rent = Rent::default();
        let lamports = rent.minimum_balance(serialized.len());
        let mut vote_account = AccountSharedData::new(lamports, serialized.len(), &id());
        vote_account.set_data_from_slice(&serialized);
        let program_account = AccountSharedData::new(0, 0, &solana_sdk_ids::native_loader::id());
        let transaction_context = new_transaction_context(
            vec![(id(), program_account), (vote_pubkey, vote_account)],
            vec![InstructionAccount::new(1, false, true)],
            &rent,
        );
        let instruction_context = transaction_context.get_next_instruction_context().unwrap();
        let mut borrowed = instruction_context
            .try_borrow_instruction_account(0)
            .unwrap();

        assert_eq!(
            VoteStateV4::deserialize(borrowed.get_data(), &vote_state.as_ref_v4().node_pubkey)
                .unwrap()
                .pending_delegator_rewards,
            0
        );

        // Authorize: pending should stay 0.
        let signers: HashSet<Pubkey> = [withdrawer].into_iter().collect();
        authorize(
            &mut borrowed,
            VoteStateTargetVersion::V4,
            &solana_pubkey::new_rand(),
            VoteAuthorize::Voter,
            &signers,
            &Clock::default(),
            false,
            || Ok(()),
        )
        .unwrap();

        assert_eq!(
            VoteStateV4::deserialize(borrowed.get_data(), &vote_state.as_ref_v4().node_pubkey)
                .unwrap()
                .pending_delegator_rewards,
            0
        );
    }
}