scope_cli/cli/

address_book.rs

//! # Address Book Command
//!
//! This module implements the `scope address-book` command for managing
//! watched addresses and viewing aggregated address book data.
//!
//! ## Usage
//!
//! ```bash
//! # Add an address to address book
//! scope address-book add 0x742d... --label "Main Wallet"
//!
//! # List watched addresses
//! scope address-book list
//!
//! # Remove an address
//! scope address-book remove 0x742d...
//!
//! # View address book summary
//! scope address-book summary
//! ```

use clap::{Args, Subcommand};
use scope::chains::{ChainClientFactory, native_symbol};
use scope::config::{Config, OutputFormat};
use scope::error::Result;
use std::collections::HashMap;
use std::path::PathBuf;

// Re-export domain types so existing `crate::cli::address_book::X` paths keep working.
pub use scope::domain::address_book::{
    AddressBook, AddressBookSummary, AddressSummary, ChainBalance, TokenSummary, WatchedAddress,
    resolve_address_book_input,
};

/// Arguments for the address book management command.
#[derive(Debug, Clone, Args)]
pub struct AddressBookArgs {
    /// AddressBook subcommand to execute.
    #[command(subcommand)]
    pub command: AddressBookCommands,

    /// Override output format.
    #[arg(short, long, global = true, value_name = "FORMAT")]
    pub format: Option<OutputFormat>,
}

/// AddressBook subcommands.
#[derive(Debug, Clone, Subcommand)]
pub enum AddressBookCommands {
    /// Add an address to the address book.
    Add(AddArgs),

    /// Remove an address from the address book.
    Remove(RemoveArgs),

    /// List all watched addresses.
    List,

    /// Show address book summary with balances.
    Summary(SummaryArgs),
}

/// Arguments for adding an address.
#[derive(Debug, Clone, Args)]
#[command(after_help = "\x1b[1mExamples:\x1b[0m
  scope address-book add 0x742d35Cc6634C0532925a3b844Bc9e7595f1b3c2 --label \"Main Wallet\"
  scope address-book add 0x742d... --chain ethereum --tags hot,trading
  scope ab add DRpbCBMx...TDt1v --chain solana --label \"SOL Vault\"")]
pub struct AddArgs {
    /// The address to add.
    #[arg(value_name = "ADDRESS")]
    pub address: String,

    /// Human-readable label for the address.
    #[arg(short, long)]
    pub label: Option<String>,

    /// Blockchain network for this address.
    #[arg(short, long, default_value = "ethereum")]
    pub chain: String,

    /// Tags for categorization.
    #[arg(short, long, value_delimiter = ',')]
    pub tags: Vec<String>,
}

/// Arguments for removing an address.
#[derive(Debug, Clone, Args)]
#[command(after_help = "\x1b[1mExamples:\x1b[0m
  scope address-book remove 0x742d35Cc6634C0532925a3b844Bc9e7595f1b3c2
  scope ab remove DRpbCBMx...TDt1v")]
pub struct RemoveArgs {
    /// The address to remove.
    #[arg(value_name = "ADDRESS")]
    pub address: String,
}

/// Arguments for address book summary.
#[derive(Debug, Clone, Args)]
#[command(after_help = "\x1b[1mExamples:\x1b[0m
  scope address-book summary
  scope address-book summary --chain ethereum --include-tokens
  scope ab summary --tag trading --report portfolio.md")]
pub struct SummaryArgs {
    /// Filter by chain.
    #[arg(short, long)]
    pub chain: Option<String>,

    /// Filter by tag.
    #[arg(short, long)]
    pub tag: Option<String>,

    /// Include token balances.
    #[arg(long)]
    pub include_tokens: bool,

    /// Generate and save a markdown report to the specified path.
    #[arg(long, value_name = "PATH")]
    pub report: Option<std::path::PathBuf>,
}

/// Executes the address book command.
pub async fn run(
    args: AddressBookArgs,
    config: &Config,
    clients: &dyn ChainClientFactory,
) -> Result<()> {
    let data_dir = config.data_dir();
    let format = args.format.unwrap_or(config.output.format);

    match args.command {
        AddressBookCommands::Add(add_args) => run_add(add_args, &data_dir).await,
        AddressBookCommands::Remove(remove_args) => run_remove(remove_args, &data_dir).await,
        AddressBookCommands::List => run_list(&data_dir, format).await,
        AddressBookCommands::Summary(summary_args) => {
            run_summary(summary_args, &data_dir, format, clients).await
        }
    }
}

async fn run_add(args: AddArgs, data_dir: &PathBuf) -> Result<()> {
    tracing::info!(address = %args.address, "Adding address to address book");

    let mut address_book = AddressBook::load(data_dir)?;

    let watched = WatchedAddress {
        address: args.address.clone(),
        label: args.label.clone(),
        chain: args.chain.clone(),
        tags: args.tags.clone(),
        added_at: std::time::SystemTime::now()
            .duration_since(std::time::UNIX_EPOCH)
            .unwrap_or_default()
            .as_secs(),
    };

    address_book.add_address(watched)?;
    address_book.save(data_dir)?;

    println!(
        "Added {} to address book{}",
        args.address,
        args.label
            .map(|l| format!(" as '{}'", l))
            .unwrap_or_default()
    );

    Ok(())
}

async fn run_remove(args: RemoveArgs, data_dir: &PathBuf) -> Result<()> {
    tracing::info!(address = %args.address, "Removing address from address book");

    let mut address_book = AddressBook::load(data_dir)?;
    let removed = address_book.remove_address(&args.address)?;

    if removed {
        address_book.save(data_dir)?;
        println!("Removed {} from address book", args.address);
    } else {
        println!("Address not found in address book: {}", args.address);
    }

    Ok(())
}

async fn run_list(data_dir: &std::path::Path, format: OutputFormat) -> Result<()> {
    let address_book = AddressBook::load(data_dir)?;

    if address_book.addresses.is_empty() {
        println!("Address book is empty. Add addresses with 'scope address-book add <address>'");
        return Ok(());
    }

    match format {
        OutputFormat::Json => {
            let json = serde_json::to_string_pretty(&address_book.addresses)?;
            println!("{}", json);
        }
        OutputFormat::Csv => {
            println!("address,label,chain,tags");
            for addr in &address_book.addresses {
                println!(
                    "{},{},{},{}",
                    addr.address,
                    addr.label.as_deref().unwrap_or(""),
                    addr.chain,
                    addr.tags.join(";")
                );
            }
        }
        OutputFormat::Table => {
            println!("Address Book");
            println!("===================");
            for addr in &address_book.addresses {
                println!(
                    "  {} ({}) - {}{}",
                    addr.address,
                    addr.chain,
                    addr.label.as_deref().unwrap_or("No label"),
                    if addr.tags.is_empty() {
                        String::new()
                    } else {
                        format!(" [{}]", addr.tags.join(", "))
                    }
                );
            }
            println!("\nTotal: {} addresses", address_book.addresses.len());
        }
        OutputFormat::Markdown => {
            let mut md = "# Address Book\n\n".to_string();
            md.push_str("| Address | Chain | Label | Tags |\n|---------|-------|-------|------|\n");
            for addr in &address_book.addresses {
                let tags = if addr.tags.is_empty() {
                    "-".to_string()
                } else {
                    addr.tags.join(", ")
                };
                md.push_str(&format!(
                    "| `{}` | {} | {} | {} |\n",
                    addr.address,
                    addr.chain,
                    addr.label.as_deref().unwrap_or("-"),
                    tags
                ));
            }
            md.push_str(&format!(
                "\n**Total:** {} addresses\n",
                address_book.addresses.len()
            ));
            println!("{}", md);
        }
    }

    Ok(())
}

async fn run_summary(
    args: SummaryArgs,
    data_dir: &std::path::Path,
    format: OutputFormat,
    clients: &dyn ChainClientFactory,
) -> Result<()> {
    let address_book = AddressBook::load(data_dir)?;

    if address_book.addresses.is_empty() {
        println!("Address book is empty. Add addresses with 'scope address-book add <address>'");
        return Ok(());
    }

    // Filter addresses
    let filtered: Vec<_> = address_book
        .addresses
        .iter()
        .filter(|a| args.chain.as_ref().is_none_or(|c| &a.chain == c))
        .filter(|a| args.tag.as_ref().is_none_or(|t| a.tags.contains(t)))
        .collect();

    // Fetch balances for each address
    let mut address_summaries = Vec::new();
    let mut balances_by_chain: HashMap<String, ChainBalance> = HashMap::new();

    for watched in &filtered {
        let (balance, tokens) = fetch_address_balance(
            &watched.address,
            &watched.chain,
            clients,
            args.include_tokens,
        )
        .await;

        // Aggregate chain balances
        if let Some(chain_bal) = balances_by_chain.get_mut(&watched.chain) {
            // For simplicity, we're showing individual balances, not aggregating
            // A more complete implementation would sum balances
            let _ = chain_bal;
        } else {
            balances_by_chain.insert(
                watched.chain.clone(),
                ChainBalance {
                    native_balance: balance.clone(),
                    symbol: native_symbol(&watched.chain).to_string(),
                    usd: None,
                },
            );
        }

        address_summaries.push(AddressSummary {
            address: watched.address.clone(),
            label: watched.label.clone(),
            chain: watched.chain.clone(),
            balance,
            usd: None,
            tokens,
        });
    }

    let summary = AddressBookSummary {
        address_count: filtered.len(),
        balances_by_chain,
        total_usd: None,
        addresses: address_summaries,
    };

    match format {
        OutputFormat::Json => {
            let json = serde_json::to_string_pretty(&summary)?;
            println!("{}", json);
        }
        OutputFormat::Csv => {
            println!("address,label,chain,balance,usd");
            for addr in &summary.addresses {
                println!(
                    "{},{},{},{},{}",
                    addr.address,
                    addr.label.as_deref().unwrap_or(""),
                    addr.chain,
                    addr.balance,
                    addr.usd.map_or(String::new(), |u| format!("{:.2}", u))
                );
            }
        }
        OutputFormat::Table => {
            println!("Address Book Summary");
            println!("=================");
            println!("Addresses: {}", summary.address_count);
            println!();

            for addr in &summary.addresses {
                println!(
                    "  {} ({}) - {} {}",
                    addr.label.as_deref().unwrap_or(&addr.address),
                    addr.chain,
                    addr.balance,
                    addr.usd.map_or(String::new(), |u| format!("(${:.2})", u))
                );

                // Show token balances
                for token in &addr.tokens {
                    let addr_short = if token.contract_address.len() >= 8 {
                        &token.contract_address[..8]
                    } else {
                        &token.contract_address
                    };
                    let symbol = token.symbol.as_deref().unwrap_or(addr_short);
                    println!("    └─ {} {}", token.balance, symbol);
                }
            }

            if let Some(total) = summary.total_usd {
                println!();
                println!("Total Value: ${:.2}", total);
            }
        }
        OutputFormat::Markdown => {
            let md = address_book_summary_to_markdown(&summary);
            println!("{}", md);
        }
    }

    // Generate report if requested
    if let Some(ref report_path) = args.report {
        let md = address_book_summary_to_markdown(&summary);
        std::fs::write(report_path, md)?;
        println!("\nReport saved to: {}", report_path.display());
    }

    Ok(())
}

/// Generates a markdown report for address book summary.
fn address_book_summary_to_markdown(summary: &AddressBookSummary) -> String {
    let mut md = format!(
        "# Address Book Report\n\n\
        **Generated:** {}  \n\
        **Addresses:** {}  \n\n",
        chrono::Utc::now().format("%Y-%m-%d %H:%M:%S UTC"),
        summary.address_count
    );

    if let Some(total) = summary.total_usd {
        md.push_str(&format!("**Total Value (USD):** ${:.2}  \n\n", total));
    }

    md.push_str("## Allocation by Chain\n\n");
    md.push_str(
        "| Chain | Native Balance | Symbol | USD |\n|-------|----------------|--------|-----|\n",
    );
    for (chain, bal) in &summary.balances_by_chain {
        let usd = bal
            .usd
            .map(|u| format!("${:.2}", u))
            .unwrap_or_else(|| "-".to_string());
        md.push_str(&format!(
            "| {} | {} | {} | {} |\n",
            chain, bal.native_balance, bal.symbol, usd
        ));
    }

    md.push_str("\n## Addresses\n\n");
    md.push_str("| Address | Label | Chain | Balance | USD | Tokens |\n");
    md.push_str("|---------|-------|-------|---------|-----|--------|\n");
    for addr in &summary.addresses {
        let label = addr.label.as_deref().unwrap_or("-");
        let usd = addr
            .usd
            .map(|u| format!("${:.2}", u))
            .unwrap_or_else(|| "-".to_string());
        let token_list: String = addr
            .tokens
            .iter()
            .map(|t| t.symbol.as_deref().unwrap_or(&t.contract_address))
            .take(3)
            .collect::<Vec<_>>()
            .join(", ");
        let tokens_display = if addr.tokens.len() > 3 {
            format!("{} (+{})", token_list, addr.tokens.len() - 3)
        } else {
            token_list
        };
        md.push_str(&format!(
            "| `{}` | {} | {} | {} | {} | {} |\n",
            addr.address,
            label,
            addr.chain,
            addr.balance,
            usd,
            if tokens_display.is_empty() {
                "-"
            } else {
                &tokens_display
            }
        ));
    }

    md.push_str(&scope::display::report::report_footer());
    md
}

/// Fetches the balance for an address on the specified chain using the factory.
async fn fetch_address_balance(
    address: &str,
    chain: &str,
    clients: &dyn ChainClientFactory,
    _include_tokens: bool,
) -> (String, Vec<TokenSummary>) {
    let client = match clients.create_chain_client(chain) {
        Ok(c) => c,
        Err(e) => {
            eprintln!("  ⚠ Unsupported chain: {}", chain);
            tracing::debug!(error = %e, chain = %chain, "Failed to create chain client");
            return ("Error".to_string(), vec![]);
        }
    };

    // Fetch native balance
    let native_balance = match client.get_balance(address).await {
        Ok(bal) => bal.formatted,
        Err(e) => {
            eprintln!("  ⚠ Could not fetch balance for {}", address);
            tracing::debug!(error = %e, address = %address, "Failed to fetch balance");
            "Error".to_string()
        }
    };

    // Always fetch token balances for address book summary
    let tokens = match client.get_token_balances(address).await {
        Ok(token_bals) => token_bals
            .into_iter()
            .map(|tb| TokenSummary {
                contract_address: tb.token.contract_address,
                balance: tb.formatted_balance,
                decimals: tb.token.decimals,
                symbol: Some(tb.token.symbol),
            })
            .collect(),
        Err(e) => {
            eprintln!("  ⚠ Token balances unavailable");
            tracing::debug!(error = %e, "Could not fetch token balances");
            vec![]
        }
    };

    (native_balance, tokens)
}

// ============================================================================
// Unit Tests
// ============================================================================

#[cfg(test)]
mod tests {
    use super::*;
    use tempfile::TempDir;

    fn create_test_address_book() -> AddressBook {
        AddressBook {
            addresses: vec![
                WatchedAddress {
                    address: "0x742d35Cc6634C0532925a3b844Bc9e7595f1b3c2".to_string(),
                    label: Some("Main Wallet".to_string()),
                    chain: "ethereum".to_string(),
                    tags: vec!["personal".to_string()],
                    added_at: 1700000000,
                },
                WatchedAddress {
                    address: "0xABCdef1234567890abcdef1234567890ABCDEF12".to_string(),
                    label: None,
                    chain: "polygon".to_string(),
                    tags: vec![],
                    added_at: 1700000001,
                },
            ],
        }
    }

    #[test]
    fn test_address_book_args_parsing() {
        use clap::Parser;

        #[derive(Parser)]
        struct TestCli {
            #[command(flatten)]
            args: AddressBookArgs,
        }

        let cli = TestCli::try_parse_from(["test", "list"]).unwrap();
        assert!(matches!(cli.args.command, AddressBookCommands::List));
    }

    #[test]
    fn test_address_book_add_args_parsing() {
        use clap::Parser;

        #[derive(Parser)]
        struct TestCli {
            #[command(flatten)]
            args: AddressBookArgs,
        }

        let cli = TestCli::try_parse_from([
            "test",
            "add",
            "0x742d35Cc6634C0532925a3b844Bc9e7595f1b3c2",
            "--label",
            "My Wallet",
            "--chain",
            "polygon",
            "--tags",
            "personal,defi",
        ])
        .unwrap();

        if let AddressBookCommands::Add(add_args) = cli.args.command {
            assert_eq!(
                add_args.address,
                "0x742d35Cc6634C0532925a3b844Bc9e7595f1b3c2"
            );
            assert_eq!(add_args.label, Some("My Wallet".to_string()));
            assert_eq!(add_args.chain, "polygon");
            assert_eq!(add_args.tags, vec!["personal", "defi"]);
        } else {
            panic!("Expected Add command");
        }
    }

    // ========================================================================
    // Native symbol tests
    // ========================================================================

    #[test]
    fn test_get_native_symbol_solana() {
        assert_eq!(native_symbol("solana"), "SOL");
        assert_eq!(native_symbol("sol"), "SOL");
    }

    #[test]
    fn test_get_native_symbol_ethereum() {
        assert_eq!(native_symbol("ethereum"), "ETH");
        assert_eq!(native_symbol("eth"), "ETH");
    }

    #[test]
    fn test_get_native_symbol_tron() {
        assert_eq!(native_symbol("tron"), "TRX");
        assert_eq!(native_symbol("trx"), "TRX");
    }

    #[test]
    fn test_get_native_symbol_unknown() {
        assert_eq!(native_symbol("bitcoin"), "???");
        assert_eq!(native_symbol("unknown"), "???");
    }

    // ========================================================================
    // End-to-end tests using MockClientFactory
    // ========================================================================

    use scope::chains::mocks::{MockClientFactory, MockDexSource};
    use scope::chains::{ChainClient, ChainClientFactory, DexDataSource};

    fn mock_factory() -> MockClientFactory {
        MockClientFactory::new()
    }

    use scope::error::ScopeError;

    /// Factory that fails to create chain clients - used to test error paths in fetch_address_balance.
    struct FailingChainClientFactory;

    impl ChainClientFactory for FailingChainClientFactory {
        fn create_chain_client(&self, chain: &str) -> Result<Box<dyn ChainClient>> {
            Err(ScopeError::Chain(format!("unsupported chain: {}", chain)))
        }

        fn create_dex_client(&self) -> Box<dyn DexDataSource> {
            Box::new(MockDexSource::new())
        }
    }

    #[tokio::test]
    async fn test_run_address_book_list_empty() {
        let tmp_dir = tempfile::tempdir().unwrap();
        let config = Config {
            address_book: scope::config::AddressBookConfig {
                data_dir: Some(tmp_dir.path().to_path_buf()),
            },
            ..Default::default()
        };
        let factory = mock_factory();
        let args = AddressBookArgs {
            command: AddressBookCommands::List,
            format: Some(OutputFormat::Table),
        };
        let result = super::run(args, &config, &factory).await;
        assert!(result.is_ok());
    }

    #[tokio::test]
    async fn test_run_address_book_add_and_list() {
        let tmp_dir = tempfile::tempdir().unwrap();
        let config = Config {
            address_book: scope::config::AddressBookConfig {
                data_dir: Some(tmp_dir.path().to_path_buf()),
            },
            ..Default::default()
        };
        let factory = mock_factory();

        // Add address
        let add_args = AddressBookArgs {
            command: AddressBookCommands::Add(AddArgs {
                address: "0x742d35Cc6634C0532925a3b844Bc9e7595f1b3c2".to_string(),
                label: Some("Test Wallet".to_string()),
                chain: "ethereum".to_string(),
                tags: vec!["test".to_string()],
            }),
            format: Some(OutputFormat::Table),
        };
        let result = super::run(add_args, &config, &factory).await;
        assert!(result.is_ok());

        // List
        let list_args = AddressBookArgs {
            command: AddressBookCommands::List,
            format: Some(OutputFormat::Json),
        };
        let result = super::run(list_args, &config, &factory).await;
        assert!(result.is_ok());
    }

    #[tokio::test]
    async fn test_run_address_book_summary_with_mock() {
        let tmp_dir = tempfile::tempdir().unwrap();
        let config = Config {
            address_book: scope::config::AddressBookConfig {
                data_dir: Some(tmp_dir.path().to_path_buf()),
            },
            ..Default::default()
        };
        let factory = mock_factory();

        // Add address first
        let add_args = AddressBookArgs {
            command: AddressBookCommands::Add(AddArgs {
                address: "0x742d35Cc6634C0532925a3b844Bc9e7595f1b3c2".to_string(),
                label: Some("Test".to_string()),
                chain: "ethereum".to_string(),
                tags: vec![],
            }),
            format: None,
        };
        super::run(add_args, &config, &factory).await.unwrap();

        // Summary
        let summary_args = AddressBookArgs {
            command: AddressBookCommands::Summary(SummaryArgs {
                chain: None,
                tag: None,
                include_tokens: false,
                report: None,
            }),
            format: Some(OutputFormat::Json),
        };
        let result = super::run(summary_args, &config, &factory).await;
        assert!(result.is_ok());
    }

    #[tokio::test]
    async fn test_run_address_book_remove() {
        let tmp_dir = tempfile::tempdir().unwrap();
        let config = Config {
            address_book: scope::config::AddressBookConfig {
                data_dir: Some(tmp_dir.path().to_path_buf()),
            },
            ..Default::default()
        };
        let factory = mock_factory();

        // Add then remove
        let add_args = AddressBookArgs {
            command: AddressBookCommands::Add(AddArgs {
                address: "0xtest".to_string(),
                label: None,
                chain: "ethereum".to_string(),
                tags: vec![],
            }),
            format: None,
        };
        super::run(add_args, &config, &factory).await.unwrap();

        let remove_args = AddressBookArgs {
            command: AddressBookCommands::Remove(RemoveArgs {
                address: "0xtest".to_string(),
            }),
            format: None,
        };
        let result = super::run(remove_args, &config, &factory).await;
        assert!(result.is_ok());
    }

    #[tokio::test]
    async fn test_run_address_book_summary_csv() {
        let tmp_dir = tempfile::tempdir().unwrap();
        let config = Config {
            address_book: scope::config::AddressBookConfig {
                data_dir: Some(tmp_dir.path().to_path_buf()),
            },
            ..Default::default()
        };
        let factory = mock_factory();

        // Add address
        let add_args = AddressBookArgs {
            command: AddressBookCommands::Add(AddArgs {
                address: "0xtest".to_string(),
                label: Some("TestAddr".to_string()),
                chain: "ethereum".to_string(),
                tags: vec!["defi".to_string()],
            }),
            format: None,
        };
        super::run(add_args, &config, &factory).await.unwrap();

        // CSV summary
        let summary_args = AddressBookArgs {
            command: AddressBookCommands::Summary(SummaryArgs {
                chain: None,
                tag: None,
                include_tokens: false,
                report: None,
            }),
            format: Some(OutputFormat::Csv),
        };
        let result = super::run(summary_args, &config, &factory).await;
        assert!(result.is_ok());
    }

    #[tokio::test]
    async fn test_run_address_book_summary_table() {
        let tmp_dir = tempfile::tempdir().unwrap();
        let config = Config {
            address_book: scope::config::AddressBookConfig {
                data_dir: Some(tmp_dir.path().to_path_buf()),
            },
            ..Default::default()
        };
        let factory = mock_factory();

        // Add address
        let add_args = AddressBookArgs {
            command: AddressBookCommands::Add(AddArgs {
                address: "0xtest".to_string(),
                label: Some("TestAddr".to_string()),
                chain: "ethereum".to_string(),
                tags: vec![],
            }),
            format: None,
        };
        super::run(add_args, &config, &factory).await.unwrap();

        // Table summary
        let summary_args = AddressBookArgs {
            command: AddressBookCommands::Summary(SummaryArgs {
                chain: None,
                tag: None,
                include_tokens: true,
                report: None,
            }),
            format: Some(OutputFormat::Table),
        };
        let result = super::run(summary_args, &config, &factory).await;
        assert!(result.is_ok());
    }

    #[tokio::test]
    async fn test_run_address_book_summary_with_chain_filter() {
        let tmp_dir = tempfile::tempdir().unwrap();
        let config = Config {
            address_book: scope::config::AddressBookConfig {
                data_dir: Some(tmp_dir.path().to_path_buf()),
            },
            ..Default::default()
        };
        let factory = mock_factory();

        // Add addresses on different chains
        let add_eth = AddressBookArgs {
            command: AddressBookCommands::Add(AddArgs {
                address: "0xeth".to_string(),
                label: None,
                chain: "ethereum".to_string(),
                tags: vec![],
            }),
            format: None,
        };
        super::run(add_eth, &config, &factory).await.unwrap();

        let add_poly = AddressBookArgs {
            command: AddressBookCommands::Add(AddArgs {
                address: "0xpoly".to_string(),
                label: None,
                chain: "polygon".to_string(),
                tags: vec![],
            }),
            format: None,
        };
        super::run(add_poly, &config, &factory).await.unwrap();

        // Filter by chain
        let summary_args = AddressBookArgs {
            command: AddressBookCommands::Summary(SummaryArgs {
                chain: Some("ethereum".to_string()),
                tag: None,
                include_tokens: false,
                report: None,
            }),
            format: Some(OutputFormat::Json),
        };
        let result = super::run(summary_args, &config, &factory).await;
        assert!(result.is_ok());
    }

    #[tokio::test]
    async fn test_run_address_book_summary_with_tag_filter() {
        let tmp_dir = tempfile::tempdir().unwrap();
        let config = Config {
            address_book: scope::config::AddressBookConfig {
                data_dir: Some(tmp_dir.path().to_path_buf()),
            },
            ..Default::default()
        };
        let factory = mock_factory();

        // Add addresses with tags
        let add_args = AddressBookArgs {
            command: AddressBookCommands::Add(AddArgs {
                address: "0xdefi".to_string(),
                label: None,
                chain: "ethereum".to_string(),
                tags: vec!["defi".to_string()],
            }),
            format: None,
        };
        super::run(add_args, &config, &factory).await.unwrap();

        // Filter by tag
        let summary_args = AddressBookArgs {
            command: AddressBookCommands::Summary(SummaryArgs {
                chain: None,
                tag: Some("defi".to_string()),
                include_tokens: false,
                report: None,
            }),
            format: Some(OutputFormat::Json),
        };
        let result = super::run(summary_args, &config, &factory).await;
        assert!(result.is_ok());
    }

    #[tokio::test]
    async fn test_run_address_book_summary_no_format() {
        let tmp_dir = tempfile::tempdir().unwrap();
        let config = Config {
            address_book: scope::config::AddressBookConfig {
                data_dir: Some(tmp_dir.path().to_path_buf()),
            },
            ..Default::default()
        };
        let factory = mock_factory();

        let add_args = AddressBookArgs {
            command: AddressBookCommands::Add(AddArgs {
                address: "0xtest".to_string(),
                label: None,
                chain: "ethereum".to_string(),
                tags: vec![],
            }),
            format: None,
        };
        super::run(add_args, &config, &factory).await.unwrap();

        let summary_args = AddressBookArgs {
            command: AddressBookCommands::Summary(SummaryArgs {
                chain: None,
                tag: None,
                include_tokens: false,
                report: None,
            }),
            format: None, // Default format
        };
        let result = super::run(summary_args, &config, &factory).await;
        assert!(result.is_ok());
    }

    #[tokio::test]
    async fn test_run_address_book_summary_empty() {
        let tmp_dir = tempfile::tempdir().unwrap();
        let config = Config {
            address_book: scope::config::AddressBookConfig {
                data_dir: Some(tmp_dir.path().to_path_buf()),
            },
            ..Default::default()
        };
        let factory = mock_factory();

        // Summary with no addresses added
        let summary_args = AddressBookArgs {
            command: AddressBookCommands::Summary(SummaryArgs {
                chain: None,
                tag: None,
                include_tokens: false,
                report: None,
            }),
            format: Some(OutputFormat::Table),
        };
        let result = super::run(summary_args, &config, &factory).await;
        assert!(result.is_ok());
    }

    #[tokio::test]
    async fn test_run_address_book_add_with_tags() {
        let tmp_dir = tempfile::tempdir().unwrap();
        let config = Config {
            address_book: scope::config::AddressBookConfig {
                data_dir: Some(tmp_dir.path().to_path_buf()),
            },
            ..Default::default()
        };
        let factory = mock_factory();

        let add_args = AddressBookArgs {
            command: AddressBookCommands::Add(AddArgs {
                address: "0xtagged".to_string(),
                label: Some("Tagged".to_string()),
                chain: "ethereum".to_string(),
                tags: vec!["defi".to_string(), "whale".to_string()],
            }),
            format: None,
        };
        let result = super::run(add_args, &config, &factory).await;
        assert!(result.is_ok());
    }

    #[test]
    fn test_get_native_symbol_polygon() {
        assert_eq!(native_symbol("polygon"), "MATIC");
    }

    #[test]
    fn test_get_native_symbol_bsc() {
        assert_eq!(native_symbol("bsc"), "BNB");
    }

    #[test]
    fn test_get_native_symbol_evm_l2s() {
        assert_eq!(native_symbol("arbitrum"), "ETH");
        assert_eq!(native_symbol("optimism"), "ETH");
        assert_eq!(native_symbol("base"), "ETH");
    }

    #[tokio::test]
    async fn test_run_address_book_list_csv_format() {
        let tmp_dir = tempfile::tempdir().unwrap();
        let config = Config {
            address_book: scope::config::AddressBookConfig {
                data_dir: Some(tmp_dir.path().to_path_buf()),
            },
            ..Default::default()
        };
        let factory = mock_factory();

        // Add address
        let add_args = AddressBookArgs {
            command: AddressBookCommands::Add(AddArgs {
                address: "0xCSV_test".to_string(),
                label: Some("CsvAddr".to_string()),
                chain: "ethereum".to_string(),
                tags: vec!["test".to_string()],
            }),
            format: None,
        };
        super::run(add_args, &config, &factory).await.unwrap();

        // List with CSV
        let list_args = AddressBookArgs {
            command: AddressBookCommands::List,
            format: Some(OutputFormat::Csv),
        };
        let result = super::run(list_args, &config, &factory).await;
        assert!(result.is_ok());
    }

    #[tokio::test]
    async fn test_run_address_book_list_table_format() {
        let tmp_dir = tempfile::tempdir().unwrap();
        let config = Config {
            address_book: scope::config::AddressBookConfig {
                data_dir: Some(tmp_dir.path().to_path_buf()),
            },
            ..Default::default()
        };
        let factory = mock_factory();

        // Add addresses with and without labels
        let add_args = AddressBookArgs {
            command: AddressBookCommands::Add(AddArgs {
                address: "0xTable_test1".to_string(),
                label: Some("LabeledAddr".to_string()),
                chain: "ethereum".to_string(),
                tags: vec!["personal".to_string(), "defi".to_string()],
            }),
            format: None,
        };
        super::run(add_args, &config, &factory).await.unwrap();

        let add_args2 = AddressBookArgs {
            command: AddressBookCommands::Add(AddArgs {
                address: "0xTable_test2".to_string(),
                label: None,
                chain: "polygon".to_string(),
                tags: vec![],
            }),
            format: None,
        };
        super::run(add_args2, &config, &factory).await.unwrap();

        // List with Table
        let list_args = AddressBookArgs {
            command: AddressBookCommands::List,
            format: Some(OutputFormat::Table),
        };
        let result = super::run(list_args, &config, &factory).await;
        assert!(result.is_ok());
    }

    #[tokio::test]
    async fn test_run_address_book_summary_table_with_tokens() {
        let tmp_dir = tempfile::tempdir().unwrap();
        let config = Config {
            address_book: scope::config::AddressBookConfig {
                data_dir: Some(tmp_dir.path().to_path_buf()),
            },
            ..Default::default()
        };
        let factory = mock_factory();

        // Add address
        let add_args = AddressBookArgs {
            command: AddressBookCommands::Add(AddArgs {
                address: "0xTokenTest".to_string(),
                label: Some("TokenAddr".to_string()),
                chain: "ethereum".to_string(),
                tags: vec![],
            }),
            format: None,
        };
        super::run(add_args, &config, &factory).await.unwrap();

        // Summary with Table and tokens included
        let summary_args = AddressBookArgs {
            command: AddressBookCommands::Summary(SummaryArgs {
                chain: None,
                tag: None,
                include_tokens: true,
                report: None,
            }),
            format: Some(OutputFormat::Table),
        };
        let result = super::run(summary_args, &config, &factory).await;
        assert!(result.is_ok());
    }

    #[tokio::test]
    async fn test_run_address_book_summary_multiple_chains() {
        let tmp_dir = tempfile::tempdir().unwrap();
        let config = Config {
            address_book: scope::config::AddressBookConfig {
                data_dir: Some(tmp_dir.path().to_path_buf()),
            },
            ..Default::default()
        };
        let factory = mock_factory();

        // Add addresses on the same chain to test chain balance aggregation
        let add1 = AddressBookArgs {
            command: AddressBookCommands::Add(AddArgs {
                address: "0xMulti1".to_string(),
                label: None,
                chain: "ethereum".to_string(),
                tags: vec![],
            }),
            format: None,
        };
        super::run(add1, &config, &factory).await.unwrap();

        let add2 = AddressBookArgs {
            command: AddressBookCommands::Add(AddArgs {
                address: "0xMulti2".to_string(),
                label: None,
                chain: "ethereum".to_string(),
                tags: vec![],
            }),
            format: None,
        };
        super::run(add2, &config, &factory).await.unwrap();

        // Summary - should aggregate chain balances
        let summary_args = AddressBookArgs {
            command: AddressBookCommands::Summary(SummaryArgs {
                chain: None,
                tag: None,
                include_tokens: false,
                report: None,
            }),
            format: Some(OutputFormat::Table),
        };
        let result = super::run(summary_args, &config, &factory).await;
        assert!(result.is_ok());
    }

    #[tokio::test]
    async fn test_run_address_book_list_no_format() {
        let tmp_dir = tempfile::tempdir().unwrap();
        let config = Config {
            address_book: scope::config::AddressBookConfig {
                data_dir: Some(tmp_dir.path().to_path_buf()),
            },
            ..Default::default()
        };
        let factory = mock_factory();

        // Add address
        let add_args = AddressBookArgs {
            command: AddressBookCommands::Add(AddArgs {
                address: "0xNoFmt".to_string(),
                label: Some("Test".to_string()),
                chain: "ethereum".to_string(),
                tags: vec![],
            }),
            format: None,
        };
        super::run(add_args, &config, &factory).await.unwrap();

        // List with default format (None -> Table)
        let list_args = AddressBookArgs {
            command: AddressBookCommands::List,
            format: None,
        };
        let result = super::run(list_args, &config, &factory).await;
        assert!(result.is_ok());
    }

    #[test]
    fn test_address_book_new() {
        let p = AddressBook::default();
        assert!(p.addresses.is_empty());
    }

    #[test]
    fn test_address_book_load_missing_dir() {
        let temp = tempfile::tempdir().unwrap();
        let p = AddressBook::load(temp.path());
        assert!(p.is_ok());
        assert!(p.unwrap().addresses.is_empty());
    }

    #[test]
    fn test_address_book_add_and_save_roundtrip() {
        let temp = tempfile::tempdir().unwrap();
        let mut p = AddressBook::default();
        let addr = WatchedAddress {
            address: "0x742d35Cc6634C0532925a3b844Bc9e7595f1b3c2".to_string(),
            label: Some("Test".to_string()),
            chain: "ethereum".to_string(),
            tags: vec!["tag1".to_string()],
            added_at: 1234567890,
        };
        p.add_address(addr).unwrap();
        assert_eq!(p.addresses.len(), 1);

        let data_dir = temp.path().to_path_buf();
        p.save(&data_dir).unwrap();
        let loaded = AddressBook::load(temp.path()).unwrap();
        assert_eq!(loaded.addresses.len(), 1);
        assert_eq!(
            loaded.addresses[0].address,
            "0x742d35Cc6634C0532925a3b844Bc9e7595f1b3c2"
        );
        assert_eq!(loaded.addresses[0].label, Some("Test".to_string()));
    }

    #[test]
    fn test_address_book_add_duplicate() {
        let mut p = AddressBook::default();
        let addr1 = WatchedAddress {
            address: "0x742d35Cc6634C0532925a3b844Bc9e7595f1b3c2".to_string(),
            label: None,
            chain: "ethereum".to_string(),
            tags: vec![],
            added_at: 0,
        };
        let addr2 = WatchedAddress {
            address: "0x742d35Cc6634C0532925a3b844Bc9e7595f1b3c2".to_string(),
            label: None,
            chain: "ethereum".to_string(),
            tags: vec![],
            added_at: 0,
        };
        p.add_address(addr1).unwrap();
        let result = p.add_address(addr2);
        // Should error on duplicate
        assert!(result.is_err());
        assert!(
            result
                .unwrap_err()
                .to_string()
                .contains("already in address book")
        );
    }

    #[test]
    fn test_watched_address_debug() {
        let addr = WatchedAddress {
            address: "0xtest".to_string(),
            label: Some("My Wallet".to_string()),
            chain: "ethereum".to_string(),
            tags: vec!["defi".to_string(), "staking".to_string()],
            added_at: 1700000000,
        };
        let debug = format!("{:?}", addr);
        assert!(debug.contains("WatchedAddress"));
        assert!(debug.contains("0xtest"));
    }

    // ========================================================================
    // address_book_summary_to_markdown tests
    // ========================================================================

    #[test]
    fn test_address_book_summary_to_markdown_basic() {
        let mut balances_by_chain = HashMap::new();
        balances_by_chain.insert(
            "ethereum".to_string(),
            ChainBalance {
                native_balance: "1.5".to_string(),
                symbol: "ETH".to_string(),
                usd: None,
            },
        );

        let summary = AddressBookSummary {
            address_count: 2,
            balances_by_chain,
            total_usd: None,
            addresses: vec![
                AddressSummary {
                    address: "0x742d35Cc6634C0532925a3b844Bc9e7595f1b3c2".to_string(),
                    label: Some("Main Wallet".to_string()),
                    chain: "ethereum".to_string(),
                    balance: "1.5".to_string(),
                    usd: None,
                    tokens: vec![],
                },
                AddressSummary {
                    address: "0xABCdef1234567890abcdef1234567890ABCDEF12".to_string(),
                    label: None,
                    chain: "polygon".to_string(),
                    balance: "100.0".to_string(),
                    usd: None,
                    tokens: vec![],
                },
            ],
        };

        let md = address_book_summary_to_markdown(&summary);

        // Check header elements
        assert!(md.contains("# Address Book Report"));
        assert!(md.contains("**Addresses:** 2"));
        assert!(md.contains("Allocation by Chain"));
        assert!(md.contains("## Addresses"));

        // Check chain balance table
        assert!(md.contains("ethereum"));
        assert!(md.contains("1.5"));
        assert!(md.contains("ETH"));

        // Check address table
        assert!(md.contains("0x742d35Cc6634C0532925a3b844Bc9e7595f1b3c2"));
        assert!(md.contains("Main Wallet"));
        assert!(md.contains("0xABCdef1234567890abcdef1234567890ABCDEF12"));
        assert!(md.contains("polygon"));
        assert!(md.contains("100.0"));

        // Check footer
        assert!(md.contains("Report generated by Scope"));
    }

    #[test]
    fn test_address_book_summary_to_markdown_with_usd() {
        let mut balances_by_chain = HashMap::new();
        balances_by_chain.insert(
            "ethereum".to_string(),
            ChainBalance {
                native_balance: "2.0".to_string(),
                symbol: "ETH".to_string(),
                usd: Some(3000.0),
            },
        );

        let summary = AddressBookSummary {
            address_count: 2,
            balances_by_chain,
            total_usd: Some(5000.0),
            addresses: vec![
                AddressSummary {
                    address: "0x1234567890123456789012345678901234567890".to_string(),
                    label: Some("Wallet 1".to_string()),
                    chain: "ethereum".to_string(),
                    balance: "2.0".to_string(),
                    usd: Some(3000.0),
                    tokens: vec![],
                },
                AddressSummary {
                    address: "0x0987654321098765432109876543210987654321".to_string(),
                    label: Some("Wallet 2".to_string()),
                    chain: "ethereum".to_string(),
                    balance: "1.0".to_string(),
                    usd: Some(2000.0),
                    tokens: vec![],
                },
            ],
        };

        let md = address_book_summary_to_markdown(&summary);

        // Check total USD
        assert!(md.contains("**Total Value (USD):** $5000.00"));

        // Check chain USD value
        assert!(md.contains("$3000.00"));

        // Check address USD values
        assert!(md.contains("$3000.00"));
        assert!(md.contains("$2000.00"));
    }

    #[test]
    fn test_address_book_summary_to_markdown_with_tokens() {
        let mut balances_by_chain = HashMap::new();
        balances_by_chain.insert(
            "ethereum".to_string(),
            ChainBalance {
                native_balance: "1.0".to_string(),
                symbol: "ETH".to_string(),
                usd: None,
            },
        );

        // Create more than 3 tokens to test truncation
        let tokens = vec![
            TokenSummary {
                contract_address: "0xToken1".to_string(),
                balance: "100.0".to_string(),
                decimals: 18,
                symbol: Some("USDC".to_string()),
            },
            TokenSummary {
                contract_address: "0xToken2".to_string(),
                balance: "50.0".to_string(),
                decimals: 18,
                symbol: Some("DAI".to_string()),
            },
            TokenSummary {
                contract_address: "0xToken3".to_string(),
                balance: "25.0".to_string(),
                decimals: 18,
                symbol: Some("WBTC".to_string()),
            },
            TokenSummary {
                contract_address: "0xToken4".to_string(),
                balance: "10.0".to_string(),
                decimals: 18,
                symbol: Some("UNI".to_string()),
            },
            TokenSummary {
                contract_address: "0xToken5".to_string(),
                balance: "5.0".to_string(),
                decimals: 18,
                symbol: None, // Test token without symbol
            },
        ];

        let summary = AddressBookSummary {
            address_count: 1,
            balances_by_chain,
            total_usd: None,
            addresses: vec![AddressSummary {
                address: "0x742d35Cc6634C0532925a3b844Bc9e7595f1b3c2".to_string(),
                label: Some("Token Wallet".to_string()),
                chain: "ethereum".to_string(),
                balance: "1.0".to_string(),
                usd: None,
                tokens,
            }],
        };

        let md = address_book_summary_to_markdown(&summary);

        // Check that first 3 tokens are shown
        assert!(md.contains("USDC"));
        assert!(md.contains("DAI"));
        assert!(md.contains("WBTC"));

        // Check truncation indicator (+2 for 5 tokens - 3 shown)
        assert!(md.contains("+2"));

        // Check that token without symbol uses contract address
        // The first 3 tokens have symbols, so we should see USDC, DAI, WBTC
        // Token 4 (UNI) and Token 5 (no symbol) should be truncated
        // But we need to verify the truncation logic shows "+2"
    }

    #[test]
    fn test_address_book_summary_to_markdown_empty() {
        let summary = AddressBookSummary {
            address_count: 0,
            balances_by_chain: HashMap::new(),
            total_usd: None,
            addresses: vec![],
        };

        let md = address_book_summary_to_markdown(&summary);

        // Check header
        assert!(md.contains("# Address Book Report"));
        assert!(md.contains("**Addresses:** 0"));

        // Check that chain allocation section exists (even if empty)
        assert!(md.contains("Allocation by Chain"));

        // Check that addresses section exists (even if empty)
        assert!(md.contains("## Addresses"));

        // Check footer
        assert!(md.contains("Report generated by Scope"));
    }

    // ========================================================================
    // find_by_label tests
    // ========================================================================

    #[test]
    fn test_find_by_label_exact_match() {
        let address_book = create_test_address_book();
        let found = address_book.find_by_label("Main Wallet");
        assert!(found.is_some());
        assert_eq!(
            found.unwrap().address,
            "0x742d35Cc6634C0532925a3b844Bc9e7595f1b3c2"
        );
    }

    #[test]
    fn test_find_by_label_case_insensitive() {
        let address_book = create_test_address_book();
        let found = address_book.find_by_label("main wallet");
        assert!(found.is_some());
        assert_eq!(
            found.unwrap().address,
            "0x742d35Cc6634C0532925a3b844Bc9e7595f1b3c2"
        );
    }

    #[test]
    fn test_find_by_label_with_whitespace() {
        let address_book = create_test_address_book();
        let found = address_book.find_by_label("  Main Wallet  ");
        assert!(found.is_some());
    }

    #[test]
    fn test_find_by_label_not_found() {
        let address_book = create_test_address_book();
        let found = address_book.find_by_label("nonexistent");
        assert!(found.is_none());
    }

    #[test]
    fn test_find_by_label_no_label_entries() {
        let address_book = create_test_address_book();
        // Second entry has no label
        let found = address_book.find_by_label("");
        assert!(found.is_none());
    }

    #[test]
    fn test_find_by_label_empty_address_book() {
        let address_book = AddressBook::default();
        let found = address_book.find_by_label("anything");
        assert!(found.is_none());
    }

    // ========================================================================
    // resolve_address_book_input tests
    // ========================================================================

    #[test]
    fn test_resolve_address_book_input_by_label() {
        let tmp_dir = TempDir::new().unwrap();
        let mut address_book = AddressBook::default();
        address_book
            .add_address(WatchedAddress {
                address: "0x742d35Cc6634C0532925a3b844Bc9e7595f1b3c2".to_string(),
                label: Some("hot-wallet".to_string()),
                chain: "ethereum".to_string(),
                tags: vec![],
                added_at: 0,
            })
            .unwrap();
        address_book.save(&tmp_dir.path().to_path_buf()).unwrap();

        let config = Config {
            address_book: scope::config::AddressBookConfig {
                data_dir: Some(tmp_dir.path().to_path_buf()),
            },
            ..Default::default()
        };

        let result = resolve_address_book_input("@hot-wallet", &config).unwrap();
        assert!(result.is_some());
        let (addr, chain) = result.unwrap();
        assert_eq!(addr, "0x742d35Cc6634C0532925a3b844Bc9e7595f1b3c2");
        assert_eq!(chain, "ethereum");
    }

    #[test]
    fn test_resolve_address_book_input_by_address() {
        let tmp_dir = TempDir::new().unwrap();
        let mut address_book = AddressBook::default();
        address_book
            .add_address(WatchedAddress {
                address: "0x742d35Cc6634C0532925a3b844Bc9e7595f1b3c2".to_string(),
                label: Some("test".to_string()),
                chain: "polygon".to_string(),
                tags: vec![],
                added_at: 0,
            })
            .unwrap();
        address_book.save(&tmp_dir.path().to_path_buf()).unwrap();

        let config = Config {
            address_book: scope::config::AddressBookConfig {
                data_dir: Some(tmp_dir.path().to_path_buf()),
            },
            ..Default::default()
        };

        // Resolve by raw address — should still match and return chain info
        let result =
            resolve_address_book_input("0x742d35Cc6634C0532925a3b844Bc9e7595f1b3c2", &config)
                .unwrap();
        assert!(result.is_some());
        let (_addr, chain) = result.unwrap();
        assert_eq!(chain, "polygon");
    }

    #[test]
    fn test_resolve_address_book_input_not_found() {
        let tmp_dir = TempDir::new().unwrap();
        let config = Config {
            address_book: scope::config::AddressBookConfig {
                data_dir: Some(tmp_dir.path().to_path_buf()),
            },
            ..Default::default()
        };

        let result = resolve_address_book_input("@unknown-label", &config);
        assert!(result.is_err());
    }

    #[test]
    fn test_resolve_address_book_input_empty_address_book() {
        let tmp_dir = TempDir::new().unwrap();
        let config = Config {
            address_book: scope::config::AddressBookConfig {
                data_dir: Some(tmp_dir.path().to_path_buf()),
            },
            ..Default::default()
        };

        let result = resolve_address_book_input("@anything", &config);
        assert!(result.is_err());
    }

    #[test]
    fn test_resolve_address_book_input_label_not_found_with_available_labels() {
        let tmp_dir = TempDir::new().unwrap();
        let mut address_book = AddressBook::default();
        address_book
            .add_address(WatchedAddress {
                address: "0x742d35Cc6634C0532925a3b844Bc9e7595f1b3c2".to_string(),
                label: Some("main-wallet".to_string()),
                chain: "ethereum".to_string(),
                tags: vec![],
                added_at: 0,
            })
            .unwrap();
        address_book
            .add_address(WatchedAddress {
                address: "0xABCdef1234567890abcdef1234567890ABCDEF12".to_string(),
                label: Some("trading".to_string()),
                chain: "polygon".to_string(),
                tags: vec![],
                added_at: 0,
            })
            .unwrap();
        address_book.save(&tmp_dir.path().to_path_buf()).unwrap();

        let config = Config {
            address_book: scope::config::AddressBookConfig {
                data_dir: Some(tmp_dir.path().to_path_buf()),
            },
            ..Default::default()
        };

        let result = resolve_address_book_input("@nonexistent-label", &config);
        assert!(result.is_err());
        let err_msg = result.unwrap_err().to_string();
        assert!(err_msg.contains("No address book entry matching '@nonexistent-label'"));
        assert!(err_msg.contains("Available labels"));
        assert!(err_msg.contains("@main-wallet"));
        assert!(err_msg.contains("@trading"));
    }

    #[test]
    fn test_resolve_address_book_input_case_insensitive_label() {
        let tmp_dir = TempDir::new().unwrap();
        let mut address_book = AddressBook::default();
        address_book
            .add_address(WatchedAddress {
                address: "0xABCDEF1234567890abcdef1234567890ABCDEF12".to_string(),
                label: Some("My DeFi Wallet".to_string()),
                chain: "arbitrum".to_string(),
                tags: vec![],
                added_at: 0,
            })
            .unwrap();
        address_book.save(&tmp_dir.path().to_path_buf()).unwrap();

        let config = Config {
            address_book: scope::config::AddressBookConfig {
                data_dir: Some(tmp_dir.path().to_path_buf()),
            },
            ..Default::default()
        };

        let result = resolve_address_book_input("@my defi wallet", &config).unwrap();
        assert!(result.is_some());
        let (addr, chain) = result.unwrap();
        assert_eq!(addr, "0xABCDEF1234567890abcdef1234567890ABCDEF12");
        assert_eq!(chain, "arbitrum");
    }

    #[test]
    fn test_resolve_address_book_input_raw_address_not_in_book_returns_none() {
        let tmp_dir = TempDir::new().unwrap();
        let mut address_book = AddressBook::default();
        address_book
            .add_address(WatchedAddress {
                address: "0x742d35Cc6634C0532925a3b844Bc9e7595f1b3c2".to_string(),
                label: Some("test".to_string()),
                chain: "ethereum".to_string(),
                tags: vec![],
                added_at: 0,
            })
            .unwrap();
        address_book.save(&tmp_dir.path().to_path_buf()).unwrap();

        let config = Config {
            address_book: scope::config::AddressBookConfig {
                data_dir: Some(tmp_dir.path().to_path_buf()),
            },
            ..Default::default()
        };

        // Raw address not in book (no @ prefix) -> Ok(None)
        let result =
            resolve_address_book_input("0xnonexistent123456789012345678901234567890", &config)
                .unwrap();
        assert!(result.is_none());
    }

    #[test]
    fn test_resolve_address_book_input_load_fails_returns_none() {
        let tmp_dir = TempDir::new().unwrap();
        let address_book_path = tmp_dir.path().join("address_book.yaml");
        std::fs::create_dir_all(tmp_dir.path()).unwrap();
        std::fs::write(&address_book_path, "invalid: yaml: content: [").unwrap();

        let config = Config {
            address_book: scope::config::AddressBookConfig {
                data_dir: Some(tmp_dir.path().to_path_buf()),
            },
            ..Default::default()
        };

        // When load fails (parse error), returns Ok(None)
        let result =
            resolve_address_book_input("0x742d35Cc6634C0532925a3b844Bc9e7595f1b3c2", &config);
        assert!(result.is_ok());
        assert!(result.unwrap().is_none());
    }

    #[test]
    fn test_address_book_remove_address_case_insensitive() {
        let mut address_book = create_test_address_book();
        let original_len = address_book.addresses.len();

        let removed = address_book
            .remove_address("0x742D35CC6634C0532925A3B844BC9E7595F1B3C2")
            .unwrap();

        assert!(removed);
        assert_eq!(address_book.addresses.len(), original_len - 1);
    }

    #[test]
    fn test_address_book_remove_args_parsing() {
        use clap::Parser;

        #[derive(Parser)]
        struct TestCli {
            #[command(flatten)]
            args: AddressBookArgs,
        }

        let cli = TestCli::try_parse_from([
            "test",
            "remove",
            "0x742d35Cc6634C0532925a3b844Bc9e7595f1b3c2",
        ])
        .unwrap();

        if let AddressBookCommands::Remove(remove_args) = cli.args.command {
            assert_eq!(
                remove_args.address,
                "0x742d35Cc6634C0532925a3b844Bc9e7595f1b3c2"
            );
        } else {
            panic!("Expected Remove command");
        }
    }

    #[test]
    fn test_address_book_summary_args_parsing() {
        use clap::Parser;

        #[derive(Parser)]
        struct TestCli {
            #[command(flatten)]
            args: AddressBookArgs,
        }

        let cli = TestCli::try_parse_from([
            "test",
            "summary",
            "--chain",
            "ethereum",
            "--tag",
            "defi",
            "--include-tokens",
            "--report",
            "report.md",
        ])
        .unwrap();

        if let AddressBookCommands::Summary(summary_args) = cli.args.command {
            assert_eq!(summary_args.chain, Some("ethereum".to_string()));
            assert_eq!(summary_args.tag, Some("defi".to_string()));
            assert!(summary_args.include_tokens);
            assert_eq!(
                summary_args.report,
                Some(std::path::PathBuf::from("report.md"))
            );
        } else {
            panic!("Expected Summary command");
        }
    }

    #[test]
    fn test_token_summary_serialization() {
        let token = TokenSummary {
            contract_address: "0xToken123".to_string(),
            balance: "100.5".to_string(),
            decimals: 18,
            symbol: Some("USDC".to_string()),
        };

        let json = serde_json::to_string(&token).unwrap();
        assert!(json.contains("0xToken123"));
        assert!(json.contains("100.5"));
        assert!(json.contains("USDC"));

        let token_no_symbol = TokenSummary {
            contract_address: "0xNoSymbol".to_string(),
            balance: "50.0".to_string(),
            decimals: 6,
            symbol: None,
        };
        let json2 = serde_json::to_string(&token_no_symbol).unwrap();
        assert!(!json2.contains("symbol"));
    }

    #[test]
    fn test_chain_balance_serialization_without_usd() {
        let balance = ChainBalance {
            native_balance: "10.5".to_string(),
            symbol: "ETH".to_string(),
            usd: None,
        };

        let json = serde_json::to_string(&balance).unwrap();
        assert!(json.contains("10.5"));
        assert!(json.contains("ETH"));
        assert!(!json.contains("usd"));
    }

    #[test]
    fn test_address_book_summary_to_markdown_empty_tokens_display() {
        let summary = AddressBookSummary {
            address_count: 1,
            balances_by_chain: HashMap::new(),
            total_usd: None,
            addresses: vec![AddressSummary {
                address: "0xEmptyTokens".to_string(),
                label: None,
                chain: "ethereum".to_string(),
                balance: "1.0".to_string(),
                usd: None,
                tokens: vec![],
            }],
        };

        let md = address_book_summary_to_markdown(&summary);
        assert!(md.contains("0xEmptyTokens"));
        assert!(md.contains("| Address | Label | Chain | Balance | USD | Tokens |"));
        assert!(md.contains("-"));
    }

    #[test]
    fn test_address_book_summary_to_markdown_token_without_symbol_uses_contract() {
        let mut balances = HashMap::new();
        balances.insert(
            "ethereum".to_string(),
            ChainBalance {
                native_balance: "1.0".to_string(),
                symbol: "ETH".to_string(),
                usd: None,
            },
        );

        let summary = AddressBookSummary {
            address_count: 1,
            balances_by_chain: balances,
            total_usd: None,
            addresses: vec![AddressSummary {
                address: "0xAddr".to_string(),
                label: None,
                chain: "ethereum".to_string(),
                balance: "1.0".to_string(),
                usd: None,
                tokens: vec![TokenSummary {
                    contract_address: "0xUnknownToken12345678".to_string(),
                    balance: "100".to_string(),
                    decimals: 18,
                    symbol: None,
                }],
            }],
        };

        let md = address_book_summary_to_markdown(&summary);
        assert!(md.contains("0xUnknownToken12345678"));
    }

    #[test]
    fn test_address_book_load_invalid_yaml_returns_error() {
        let temp_dir = tempfile::tempdir().unwrap();
        let invalid_path = temp_dir.path().join("address_book.yaml");
        std::fs::write(&invalid_path, "not valid: yaml: [unclosed").unwrap();

        let result = AddressBook::load(temp_dir.path());
        assert!(result.is_err());
    }

    #[test]
    fn test_address_book_save_creates_directory() {
        let temp_dir = tempfile::tempdir().unwrap();
        let nested_dir = temp_dir.path().join("scope").join("nested");
        let address_book = create_test_address_book();

        let result = address_book.save(&nested_dir);
        assert!(result.is_ok());
        assert!(nested_dir.exists());
        assert!(nested_dir.join("address_book.yaml").exists());
    }

    #[tokio::test]
    async fn test_run_address_book_add_without_label() {
        let tmp_dir = tempfile::tempdir().unwrap();
        let config = Config {
            address_book: scope::config::AddressBookConfig {
                data_dir: Some(tmp_dir.path().to_path_buf()),
            },
            ..Default::default()
        };
        let factory = mock_factory();

        let add_args = AddressBookArgs {
            command: AddressBookCommands::Add(AddArgs {
                address: "0xNoLabel".to_string(),
                label: None,
                chain: "ethereum".to_string(),
                tags: vec![],
            }),
            format: None,
        };
        let result = super::run(add_args, &config, &factory).await;
        assert!(result.is_ok());
    }

    #[tokio::test]
    async fn test_run_address_book_remove_nonexistent_address() {
        let tmp_dir = tempfile::tempdir().unwrap();
        let config = Config {
            address_book: scope::config::AddressBookConfig {
                data_dir: Some(tmp_dir.path().to_path_buf()),
            },
            ..Default::default()
        };
        let factory = mock_factory();

        let remove_args = AddressBookArgs {
            command: AddressBookCommands::Remove(RemoveArgs {
                address: "0xNeverAdded".to_string(),
            }),
            format: None,
        };
        let result = super::run(remove_args, &config, &factory).await;
        assert!(result.is_ok());
    }

    #[tokio::test]
    async fn test_run_address_book_list_markdown_format() {
        let tmp_dir = tempfile::tempdir().unwrap();
        let config = Config {
            address_book: scope::config::AddressBookConfig {
                data_dir: Some(tmp_dir.path().to_path_buf()),
            },
            ..Default::default()
        };
        let factory = mock_factory();

        let add_args = AddressBookArgs {
            command: AddressBookCommands::Add(AddArgs {
                address: "0xMdTest".to_string(),
                label: Some("MarkdownAddr".to_string()),
                chain: "ethereum".to_string(),
                tags: vec!["test".to_string()],
            }),
            format: None,
        };
        super::run(add_args, &config, &factory).await.unwrap();

        let list_args = AddressBookArgs {
            command: AddressBookCommands::List,
            format: Some(OutputFormat::Markdown),
        };
        let result = super::run(list_args, &config, &factory).await;
        assert!(result.is_ok());
    }

    #[tokio::test]
    async fn test_run_address_book_summary_markdown_format() {
        let tmp_dir = tempfile::tempdir().unwrap();
        let config = Config {
            address_book: scope::config::AddressBookConfig {
                data_dir: Some(tmp_dir.path().to_path_buf()),
            },
            ..Default::default()
        };
        let factory = mock_factory();

        let add_args = AddressBookArgs {
            command: AddressBookCommands::Add(AddArgs {
                address: "0xSummaryMd".to_string(),
                label: Some("SummaryMarkdown".to_string()),
                chain: "ethereum".to_string(),
                tags: vec![],
            }),
            format: None,
        };
        super::run(add_args, &config, &factory).await.unwrap();

        let summary_args = AddressBookArgs {
            command: AddressBookCommands::Summary(SummaryArgs {
                chain: None,
                tag: None,
                include_tokens: false,
                report: None,
            }),
            format: Some(OutputFormat::Markdown),
        };
        let result = super::run(summary_args, &config, &factory).await;
        assert!(result.is_ok());
    }

    #[tokio::test]
    async fn test_run_address_book_summary_with_report_file() {
        let tmp_dir = tempfile::tempdir().unwrap();
        let report_path = tmp_dir.path().join("portfolio_report.md");
        let config = Config {
            address_book: scope::config::AddressBookConfig {
                data_dir: Some(tmp_dir.path().to_path_buf()),
            },
            ..Default::default()
        };
        let factory = mock_factory();

        let add_args = AddressBookArgs {
            command: AddressBookCommands::Add(AddArgs {
                address: "0xReportTest".to_string(),
                label: Some("ReportAddr".to_string()),
                chain: "ethereum".to_string(),
                tags: vec![],
            }),
            format: None,
        };
        super::run(add_args, &config, &factory).await.unwrap();

        let summary_args = AddressBookArgs {
            command: AddressBookCommands::Summary(SummaryArgs {
                chain: None,
                tag: None,
                include_tokens: false,
                report: Some(report_path.clone()),
            }),
            format: Some(OutputFormat::Table),
        };
        let result = super::run(summary_args, &config, &factory).await;
        assert!(result.is_ok());
        assert!(report_path.exists());
        let content = std::fs::read_to_string(&report_path).unwrap();
        assert!(content.contains("# Address Book Report"));
        assert!(content.contains("Report generated by Scope"));
    }

    #[tokio::test]
    async fn test_run_address_book_summary_with_unsupported_chain() {
        let tmp_dir = tempfile::tempdir().unwrap();
        let config = Config {
            address_book: scope::config::AddressBookConfig {
                data_dir: Some(tmp_dir.path().to_path_buf()),
            },
            ..Default::default()
        };

        let add_args = AddressBookArgs {
            command: AddressBookCommands::Add(AddArgs {
                address: "0xUnsupported".to_string(),
                label: None,
                chain: "unsupported_chain_xyz".to_string(),
                tags: vec![],
            }),
            format: None,
        };
        super::run(add_args, &config, &mock_factory())
            .await
            .unwrap();

        let failing_factory = FailingChainClientFactory;
        let summary_args = AddressBookArgs {
            command: AddressBookCommands::Summary(SummaryArgs {
                chain: None,
                tag: None,
                include_tokens: false,
                report: None,
            }),
            format: Some(OutputFormat::Json),
        };
        let result = super::run(summary_args, &config, &failing_factory).await;
        assert!(result.is_ok());
    }

    #[tokio::test]
    async fn test_run_address_book_format_override_from_args() {
        let tmp_dir = tempfile::tempdir().unwrap();
        let config = Config {
            address_book: scope::config::AddressBookConfig {
                data_dir: Some(tmp_dir.path().to_path_buf()),
            },
            ..Default::default()
        };
        let factory = mock_factory();

        let add_args = AddressBookArgs {
            command: AddressBookCommands::Add(AddArgs {
                address: "0xFormatOverride".to_string(),
                label: None,
                chain: "ethereum".to_string(),
                tags: vec![],
            }),
            format: Some(OutputFormat::Json),
        };
        super::run(add_args, &config, &factory).await.unwrap();

        let list_args = AddressBookArgs {
            command: AddressBookCommands::List,
            format: Some(OutputFormat::Json),
        };
        let result = super::run(list_args, &config, &factory).await;
        assert!(result.is_ok());
    }
}