sbom_tools/cli/

validate.rs

//! Validate command handler.
//!
//! Implements the `validate` subcommand for validating SBOMs against compliance standards.

use crate::model::{CreatorType, ExternalRefType, HashAlgorithm, NormalizedSbom, Severity};
use crate::pipeline::{OutputTarget, exit_codes, parse_sbom_with_context, write_output};
use crate::quality::{
    ComplianceChecker, ComplianceLevel, ComplianceResult, Violation, ViolationCategory,
    ViolationSeverity,
};
use crate::reports::{ReportFormat, generate_compliance_sarif};
use anyhow::{Result, bail};
use std::collections::HashSet;
use std::path::PathBuf;

/// Run the validate command, returning the desired exit code.
///
/// # Exit codes
/// - [`exit_codes::SUCCESS`] (0): compliant (no errors; no warnings when
///   `--fail-on-warning` is set)
/// - [`exit_codes::COMPLIANCE_ERRORS`] (1): one or more compliance errors found
/// - [`exit_codes::COMPLIANCE_WARNINGS`] (2): warnings found with
///   `--fail-on-warning`
///
/// The caller is responsible for calling `std::process::exit()` with the
/// returned code when it is non-zero.
#[allow(clippy::needless_pass_by_value, clippy::too_many_arguments)]
pub fn run_validate(
    sbom_path: PathBuf,
    standard: String,
    output: ReportFormat,
    output_file: Option<PathBuf>,
    fail_on_warning: bool,
    summary: bool,
    cra_sidecar_path: Option<PathBuf>,
    cra_product_class: Option<String>,
) -> Result<i32> {
    let parsed = parse_sbom_with_context(&sbom_path, false)?;

    // Load CRA sidecar — explicit flag wins, otherwise auto-discover next to the SBOM
    let cra_sidecar = match cra_sidecar_path {
        Some(p) => Some(
            crate::model::CraSidecarMetadata::from_file(&p).map_err(|e| {
                anyhow::anyhow!("Failed to load CRA sidecar from {}: {e}", p.display())
            })?,
        ),
        None => crate::model::CraSidecarMetadata::find_for_sbom(&sbom_path),
    };

    // Resolve effective product class: sidecar wins; otherwise CLI flag.
    // Mismatch between explicit CLI flag and sidecar is reported as a Warning
    // on stderr (not turned into a Violation — sidecar is authoritative).
    let cli_class = cra_product_class
        .as_deref()
        .and_then(crate::model::CraProductClass::parse_cli);
    let sidecar_class = cra_sidecar.as_ref().and_then(|s| s.product_class);
    if let (Some(cli), Some(side)) = (cli_class, sidecar_class)
        && cli != side
    {
        tracing::warn!(
            "CRA product class mismatch: --cra-product-class={} but sidecar says {}; using sidecar.",
            cli.label(),
            side.label()
        );
    }
    let effective_class = sidecar_class.or(cli_class);

    let standards: Vec<&str> = standard.split(',').map(str::trim).collect();
    let mut results = Vec::new();

    for std_name in &standards {
        let result = match std_name.to_lowercase().as_str() {
            "ntia" => check_ntia_compliance(parsed.sbom()),
            "fda" => check_fda_compliance(parsed.sbom()),
            "cra" => {
                let mut checker = ComplianceChecker::new(ComplianceLevel::CraPhase2);
                if let Some(sc) = cra_sidecar.clone() {
                    checker = checker.with_sidecar(sc);
                }
                if let Some(c) = effective_class {
                    checker = checker.with_product_class(c);
                }
                checker.check(parsed.sbom())
            }
            "ssdf" | "nist-ssdf" | "nist_ssdf" => {
                ComplianceChecker::new(ComplianceLevel::NistSsdf).check(parsed.sbom())
            }
            "eo14028" | "eo-14028" | "eo_14028" => {
                ComplianceChecker::new(ComplianceLevel::Eo14028).check(parsed.sbom())
            }
            "cnsa2" | "cnsa-2" | "cnsa_2" | "cnsa2.0" => {
                ComplianceChecker::new(ComplianceLevel::Cnsa2).check(parsed.sbom())
            }
            "pqc" | "nist-pqc" | "nist_pqc" => {
                ComplianceChecker::new(ComplianceLevel::NistPqc).check(parsed.sbom())
            }
            "bsi" | "tr-03183" | "tr03183" | "bsi-tr-03183-2" => {
                ComplianceChecker::new(ComplianceLevel::BsiTr03183_2).check(parsed.sbom())
            }
            "oss-steward" | "cra-oss-steward" | "cra-oss" | "cra-art24" | "art24" => {
                let mut checker = ComplianceChecker::new(ComplianceLevel::CraOssSteward);
                if let Some(sc) = cra_sidecar.clone() {
                    checker = checker.with_sidecar(sc);
                }
                checker.check(parsed.sbom())
            }
            "eucc" | "eucc-substantial" | "common-criteria" => {
                let mut checker = ComplianceChecker::new(ComplianceLevel::EuccSubstantial);
                if let Some(sc) = cra_sidecar.clone() {
                    checker = checker.with_sidecar(sc);
                }
                checker.check(parsed.sbom())
            }
            "ai-act" | "ai_act" | "aiact" | "eu-ai-act" => {
                // The sidecar carries the is_high_risk_ai flag, which escalates
                // Annex IV readiness findings — attach it when present.
                let mut checker = ComplianceChecker::new(ComplianceLevel::EuAiAct);
                if let Some(sc) = cra_sidecar.clone() {
                    checker = checker.with_sidecar(sc);
                }
                checker.check(parsed.sbom())
            }
            "bsi-ai" | "bsi_ai" | "bsiai" | "sbom-for-ai" | "ai-bom" => {
                ComplianceChecker::new(ComplianceLevel::BsiSbomForAi).check(parsed.sbom())
            }
            _ => {
                bail!(
                    "Unknown validation standard: {std_name}. \
                    Valid options: ntia, fda, cra, ssdf, eo14028, cnsa2, pqc, bsi, oss-steward, eucc, ai-act, bsi-ai"
                );
            }
        };
        results.push(result);
    }

    if results.len() == 1 {
        let result = &results[0];
        if summary {
            write_compliance_summary(result, output_file)?;
        } else {
            write_compliance_output(result, output, output_file)?;
        }

        if result.error_count > 0 {
            return Ok(exit_codes::COMPLIANCE_ERRORS);
        }
        if fail_on_warning && result.warning_count > 0 {
            return Ok(exit_codes::COMPLIANCE_WARNINGS);
        }
    } else {
        // Multi-standard: merge results for output
        if summary {
            write_multi_compliance_summary(&results, output_file)?;
        } else {
            write_multi_compliance_output(&results, output, output_file)?;
        }

        let has_errors = results.iter().any(|r| r.error_count > 0);
        let has_warnings = results.iter().any(|r| r.warning_count > 0);
        if has_errors {
            return Ok(exit_codes::COMPLIANCE_ERRORS);
        }
        if fail_on_warning && has_warnings {
            return Ok(exit_codes::COMPLIANCE_WARNINGS);
        }
    }

    Ok(exit_codes::SUCCESS)
}

fn write_compliance_output(
    result: &ComplianceResult,
    output: ReportFormat,
    output_file: Option<PathBuf>,
) -> Result<()> {
    let target = OutputTarget::from_option(output_file);

    let content = match output {
        ReportFormat::Json => serde_json::to_string_pretty(result)
            .map_err(|e| anyhow::anyhow!("Failed to serialize compliance JSON: {e}"))?,
        ReportFormat::Sarif => generate_compliance_sarif(result)?,
        _ => format_compliance_text(result),
    };

    write_output(&content, &target, false)?;
    Ok(())
}

/// Compact summary for CI badge generation
#[derive(serde::Serialize)]
struct ComplianceSummary {
    standard: String,
    compliant: bool,
    score: u8,
    errors: usize,
    warnings: usize,
    info: usize,
}

fn write_compliance_summary(result: &ComplianceResult, output_file: Option<PathBuf>) -> Result<()> {
    let target = OutputTarget::from_option(output_file);
    let total = result.violations.len() + 1;
    let issues = result.error_count + result.warning_count;
    let score = if issues >= total {
        0
    } else {
        ((total - issues) * 100) / total
    }
    .min(100) as u8;

    let summary = ComplianceSummary {
        standard: result.level.name().to_string(),
        compliant: result.is_compliant,
        score,
        errors: result.error_count,
        warnings: result.warning_count,
        info: result.info_count,
    };
    let content = serde_json::to_string(&summary)
        .map_err(|e| anyhow::anyhow!("Failed to serialize summary: {e}"))?;
    write_output(&content, &target, false)?;
    Ok(())
}

fn write_multi_compliance_output(
    results: &[ComplianceResult],
    output: ReportFormat,
    output_file: Option<PathBuf>,
) -> Result<()> {
    let target = OutputTarget::from_option(output_file);

    let content = match output {
        ReportFormat::Json => serde_json::to_string_pretty(results)
            .map_err(|e| anyhow::anyhow!("Failed to serialize compliance JSON: {e}"))?,
        ReportFormat::Sarif => crate::reports::generate_multi_compliance_sarif(results)?,
        _ => {
            let mut parts = Vec::new();
            for result in results {
                parts.push(format_compliance_text(result));
            }
            parts.join("\n---\n\n")
        }
    };

    write_output(&content, &target, false)?;
    Ok(())
}

fn write_multi_compliance_summary(
    results: &[ComplianceResult],
    output_file: Option<PathBuf>,
) -> Result<()> {
    let target = OutputTarget::from_option(output_file);
    let summaries: Vec<ComplianceSummary> = results
        .iter()
        .map(|result| {
            let total = result.violations.len() + 1;
            let issues = result.error_count + result.warning_count;
            let score = if issues >= total {
                0
            } else {
                ((total - issues) * 100) / total
            }
            .min(100) as u8;

            ComplianceSummary {
                standard: result.level.name().to_string(),
                compliant: result.is_compliant,
                score,
                errors: result.error_count,
                warnings: result.warning_count,
                info: result.info_count,
            }
        })
        .collect();

    let content = serde_json::to_string(&summaries)
        .map_err(|e| anyhow::anyhow!("Failed to serialize multi-standard summary: {e}"))?;
    write_output(&content, &target, false)?;
    Ok(())
}

fn format_compliance_text(result: &ComplianceResult) -> String {
    let mut lines = Vec::new();
    lines.push(format!("Compliance ({})", result.level.name()));
    lines.push(format!(
        "Status: {} ({} errors, {} warnings, {} info)",
        if result.is_compliant {
            "COMPLIANT"
        } else {
            "NON-COMPLIANT"
        },
        result.error_count,
        result.warning_count,
        result.info_count
    ));
    lines.push(String::new());

    if result.violations.is_empty() {
        lines.push("No violations found.".to_string());
        return lines.join("\n");
    }

    for v in &result.violations {
        let severity = match v.severity {
            ViolationSeverity::Error => "ERROR",
            ViolationSeverity::Warning => "WARN",
            ViolationSeverity::Info => "INFO",
        };
        let element = v.element.as_deref().unwrap_or("-");
        lines.push(format!(
            "[{}] {} | {} | {}",
            severity,
            v.category.name(),
            v.requirement,
            element
        ));
        lines.push(format!("  {}", v.message));
    }

    lines.join("\n")
}

/// Check SBOM against NTIA minimum elements, returning a structured result.
fn check_ntia_compliance(sbom: &NormalizedSbom) -> ComplianceResult {
    let mut violations = Vec::new();

    if sbom.document.creators.is_empty() {
        violations.push(Violation {
            severity: ViolationSeverity::Error,
            category: ViolationCategory::DocumentMetadata,
            message: "Missing author/creator information".to_string(),
            element: None,
            requirement: "NTIA Minimum Elements: Author".to_string(),
            rule_id: "SBOM-NTIA-AUTHOR",
            standard_refs: Vec::new(),
        });
    }

    for (_id, comp) in &sbom.components {
        if comp.name.is_empty() {
            violations.push(Violation {
                severity: ViolationSeverity::Error,
                category: ViolationCategory::ComponentIdentification,
                message: "Component missing name".to_string(),
                element: None,
                requirement: "NTIA Minimum Elements: Component Name".to_string(),
                rule_id: "SBOM-NTIA-NAME",
                standard_refs: Vec::new(),
            });
        }
        if comp.version.is_none() {
            violations.push(Violation {
                severity: ViolationSeverity::Warning,
                category: ViolationCategory::ComponentIdentification,
                message: format!("Component '{}' missing version", comp.name),
                element: Some(comp.name.clone()),
                requirement: "NTIA Minimum Elements: Version".to_string(),
                rule_id: "SBOM-NTIA-VERSION",
                standard_refs: Vec::new(),
            });
        }
        if comp.supplier.is_none() {
            violations.push(Violation {
                severity: ViolationSeverity::Warning,
                category: ViolationCategory::SupplierInfo,
                message: format!("Component '{}' missing supplier", comp.name),
                element: Some(comp.name.clone()),
                requirement: "NTIA Minimum Elements: Supplier Name".to_string(),
                rule_id: "SBOM-NTIA-SUPPLIER",
                standard_refs: Vec::new(),
            });
        }
        if comp.identifiers.purl.is_none()
            && comp.identifiers.cpe.is_empty()
            && comp.identifiers.swid.is_none()
        {
            violations.push(Violation {
                severity: ViolationSeverity::Warning,
                category: ViolationCategory::ComponentIdentification,
                message: format!(
                    "Component '{}' missing unique identifier (PURL/CPE/SWID)",
                    comp.name
                ),
                element: Some(comp.name.clone()),
                requirement: "NTIA Minimum Elements: Unique Identifier".to_string(),
                rule_id: "SBOM-NTIA-IDENTIFIER",
                standard_refs: Vec::new(),
            });
        }
    }

    if sbom.edges.is_empty() && sbom.component_count() > 1 {
        violations.push(Violation {
            severity: ViolationSeverity::Error,
            category: ViolationCategory::DependencyInfo,
            message: "Missing dependency relationships".to_string(),
            element: None,
            requirement: "NTIA Minimum Elements: Dependency Relationship".to_string(),
            rule_id: "SBOM-NTIA-DEPENDENCY",
            standard_refs: Vec::new(),
        });
    }

    ComplianceResult::new(ComplianceLevel::NtiaMinimum, violations)
}

/// Check SBOM against FDA medical device requirements, returning a structured result.
fn check_fda_compliance(sbom: &NormalizedSbom) -> ComplianceResult {
    let mut fda_issues: Vec<FdaIssue> = Vec::new();

    validate_fda_document(sbom, &mut fda_issues);
    validate_fda_components(sbom, &mut fda_issues);
    validate_fda_relationships(sbom, &mut fda_issues);
    validate_fda_vulnerabilities(sbom, &mut fda_issues);

    let violations = fda_issues
        .into_iter()
        .map(|issue| Violation {
            severity: match issue.severity {
                FdaSeverity::Error => ViolationSeverity::Error,
                FdaSeverity::Warning => ViolationSeverity::Warning,
                FdaSeverity::Info => ViolationSeverity::Info,
            },
            category: match issue.category {
                "Document" => ViolationCategory::DocumentMetadata,
                "Component" => ViolationCategory::ComponentIdentification,
                "Dependency" => ViolationCategory::DependencyInfo,
                "Security" => ViolationCategory::SecurityInfo,
                _ => ViolationCategory::DocumentMetadata,
            },
            requirement: format!("FDA Medical Device: {}", issue.category),
            message: issue.message,
            element: None,
            rule_id: match issue.category {
                "Dependency" => "SBOM-FDA-DEPENDENCY",
                "Security" => "SBOM-FDA-SECURITY",
                _ => "SBOM-FDA-GENERAL",
            },
            standard_refs: Vec::new(),
        })
        .collect();

    ComplianceResult::new(ComplianceLevel::FdaMedicalDevice, violations)
}

/// Validate SBOM against NTIA minimum elements
#[allow(clippy::unnecessary_wraps)]
pub fn validate_ntia_elements(sbom: &NormalizedSbom) -> Result<()> {
    let mut issues = Vec::new();

    // Check document-level requirements
    if sbom.document.creators.is_empty() {
        issues.push("Missing author/creator information");
    }

    // Check component-level requirements
    for (_id, comp) in &sbom.components {
        if comp.name.is_empty() {
            issues.push("Component missing name");
        }
        if comp.version.is_none() {
            tracing::warn!("Component '{}' missing version", comp.name);
        }
        if comp.supplier.is_none() {
            tracing::warn!("Component '{}' missing supplier", comp.name);
        }
        if comp.identifiers.purl.is_none()
            && comp.identifiers.cpe.is_empty()
            && comp.identifiers.swid.is_none()
        {
            tracing::warn!(
                "Component '{}' missing unique identifier (PURL/CPE/SWID)",
                comp.name
            );
        }
    }

    if sbom.edges.is_empty() && sbom.component_count() > 1 {
        issues.push("Missing dependency relationships");
    }

    if issues.is_empty() {
        tracing::info!("SBOM passes NTIA minimum elements validation");
        println!("NTIA Validation: PASSED");
    } else {
        tracing::warn!("SBOM has {} NTIA validation issues", issues.len());
        println!("NTIA Validation: FAILED");
        for issue in &issues {
            println!("  - {issue}");
        }
    }

    Ok(())
}

/// FDA validation issue severity
#[derive(PartialEq, Eq, PartialOrd, Ord, Clone, Copy)]
enum FdaSeverity {
    Error,   // Must fix - will likely cause FDA rejection
    Warning, // Should fix - may cause FDA questions
    Info,    // Recommendation for improvement
}

impl std::fmt::Display for FdaSeverity {
    fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
        match self {
            Self::Error => write!(f, "ERROR"),
            Self::Warning => write!(f, "WARNING"),
            Self::Info => write!(f, "INFO"),
        }
    }
}

/// FDA validation issue
struct FdaIssue {
    severity: FdaSeverity,
    category: &'static str,
    message: String,
}

/// Component validation statistics
struct ComponentStats {
    total: usize,
    without_version: usize,
    without_supplier: usize,
    without_hash: usize,
    without_strong_hash: usize,
    without_identifier: usize,
    without_support_info: usize,
}

fn validate_fda_document(sbom: &NormalizedSbom, issues: &mut Vec<FdaIssue>) {
    // Manufacturer/Author Information
    if sbom.document.creators.is_empty() {
        issues.push(FdaIssue {
            severity: FdaSeverity::Error,
            category: "Document",
            message: "Missing SBOM author/manufacturer information".to_string(),
        });
    } else {
        let has_org = sbom
            .document
            .creators
            .iter()
            .any(|c| c.creator_type == CreatorType::Organization);
        if !has_org {
            issues.push(FdaIssue {
                severity: FdaSeverity::Warning,
                category: "Document",
                message: "No organization/manufacturer listed as SBOM creator".to_string(),
            });
        }

        let has_contact = sbom.document.creators.iter().any(|c| c.email.is_some());
        if !has_contact {
            issues.push(FdaIssue {
                severity: FdaSeverity::Warning,
                category: "Document",
                message: "No contact email provided for SBOM creators".to_string(),
            });
        }
    }

    // SBOM Name/Title
    if sbom.document.name.is_none() {
        issues.push(FdaIssue {
            severity: FdaSeverity::Warning,
            category: "Document",
            message: "Missing SBOM document name/title".to_string(),
        });
    }

    // Serial Number/Namespace
    if sbom.document.serial_number.is_none() {
        issues.push(FdaIssue {
            severity: FdaSeverity::Warning,
            category: "Document",
            message: "Missing SBOM serial number or document namespace".to_string(),
        });
    }
}

fn validate_fda_components(sbom: &NormalizedSbom, issues: &mut Vec<FdaIssue>) -> ComponentStats {
    let mut stats = ComponentStats {
        total: sbom.component_count(),
        without_version: 0,
        without_supplier: 0,
        without_hash: 0,
        without_strong_hash: 0,
        without_identifier: 0,
        without_support_info: 0,
    };

    for (_id, comp) in &sbom.components {
        if comp.name.is_empty() {
            issues.push(FdaIssue {
                severity: FdaSeverity::Error,
                category: "Component",
                message: "Component has empty name".to_string(),
            });
        }

        if comp.version.is_none() {
            stats.without_version += 1;
        }

        if comp.supplier.is_none() {
            stats.without_supplier += 1;
        }

        if comp.hashes.is_empty() {
            stats.without_hash += 1;
        } else {
            let has_strong_hash = comp.hashes.iter().any(|h| {
                matches!(
                    h.algorithm,
                    HashAlgorithm::Sha256
                        | HashAlgorithm::Sha384
                        | HashAlgorithm::Sha512
                        | HashAlgorithm::Sha3_256
                        | HashAlgorithm::Sha3_384
                        | HashAlgorithm::Sha3_512
                        | HashAlgorithm::Blake2b256
                        | HashAlgorithm::Blake2b384
                        | HashAlgorithm::Blake2b512
                        | HashAlgorithm::Blake3
                )
            });
            if !has_strong_hash {
                stats.without_strong_hash += 1;
            }
        }

        if comp.identifiers.purl.is_none()
            && comp.identifiers.cpe.is_empty()
            && comp.identifiers.swid.is_none()
        {
            stats.without_identifier += 1;
        }

        let has_support_info = comp.external_refs.iter().any(|r| {
            matches!(
                r.ref_type,
                ExternalRefType::Support
                    | ExternalRefType::Website
                    | ExternalRefType::SecurityContact
                    | ExternalRefType::Advisories
            )
        });
        if !has_support_info {
            stats.without_support_info += 1;
        }
    }

    // Add component issues
    if stats.without_version > 0 {
        issues.push(FdaIssue {
            severity: FdaSeverity::Error,
            category: "Component",
            message: format!(
                "{}/{} components missing version information",
                stats.without_version, stats.total
            ),
        });
    }

    if stats.without_supplier > 0 {
        issues.push(FdaIssue {
            severity: FdaSeverity::Error,
            category: "Component",
            message: format!(
                "{}/{} components missing supplier/manufacturer information",
                stats.without_supplier, stats.total
            ),
        });
    }

    if stats.without_hash > 0 {
        issues.push(FdaIssue {
            severity: FdaSeverity::Error,
            category: "Component",
            message: format!(
                "{}/{} components missing cryptographic hash",
                stats.without_hash, stats.total
            ),
        });
    }

    if stats.without_strong_hash > 0 {
        issues.push(FdaIssue {
            severity: FdaSeverity::Warning,
            category: "Component",
            message: format!(
                "{}/{} components have only weak hash algorithms (MD5/SHA-1). FDA recommends SHA-256 or stronger",
                stats.without_strong_hash, stats.total
            ),
        });
    }

    if stats.without_identifier > 0 {
        issues.push(FdaIssue {
            severity: FdaSeverity::Error,
            category: "Component",
            message: format!(
                "{}/{} components missing unique identifier (PURL/CPE/SWID)",
                stats.without_identifier, stats.total
            ),
        });
    }

    if stats.without_support_info > 0 && stats.total > 0 {
        let percentage = (stats.without_support_info as f64 / stats.total as f64) * 100.0;
        if percentage > 50.0 {
            issues.push(FdaIssue {
                severity: FdaSeverity::Info,
                category: "Component",
                message: format!(
                    "{}/{} components ({:.0}%) lack support/contact information",
                    stats.without_support_info, stats.total, percentage
                ),
            });
        }
    }

    stats
}

fn validate_fda_relationships(sbom: &NormalizedSbom, issues: &mut Vec<FdaIssue>) {
    let total = sbom.component_count();

    if sbom.edges.is_empty() && total > 1 {
        issues.push(FdaIssue {
            severity: FdaSeverity::Error,
            category: "Dependency",
            message: format!("No dependency relationships defined for {total} components"),
        });
    }

    // Check for orphan components
    if !sbom.edges.is_empty() {
        let mut connected: HashSet<String> = HashSet::new();
        for edge in &sbom.edges {
            connected.insert(edge.from.value().to_string());
            connected.insert(edge.to.value().to_string());
        }
        let orphan_count = sbom
            .components
            .keys()
            .filter(|id| !connected.contains(id.value()))
            .count();

        if orphan_count > 0 && orphan_count < total {
            issues.push(FdaIssue {
                severity: FdaSeverity::Warning,
                category: "Dependency",
                message: format!(
                    "{orphan_count}/{total} components have no dependency relationships (orphaned)"
                ),
            });
        }
    }
}

fn validate_fda_vulnerabilities(sbom: &NormalizedSbom, issues: &mut Vec<FdaIssue>) {
    let vuln_info = sbom.all_vulnerabilities();
    if !vuln_info.is_empty() {
        let critical_vulns = vuln_info
            .iter()
            .filter(|(_, v)| matches!(v.severity, Some(Severity::Critical)))
            .count();
        let high_vulns = vuln_info
            .iter()
            .filter(|(_, v)| matches!(v.severity, Some(Severity::High)))
            .count();

        if critical_vulns > 0 || high_vulns > 0 {
            issues.push(FdaIssue {
                severity: FdaSeverity::Warning,
                category: "Security",
                message: format!(
                    "SBOM contains {critical_vulns} critical and {high_vulns} high severity vulnerabilities"
                ),
            });
        }
    }
}

#[cfg(test)]
mod tests {
    use super::*;

    #[test]
    fn test_fda_severity_order() {
        assert!(FdaSeverity::Error < FdaSeverity::Warning);
        assert!(FdaSeverity::Warning < FdaSeverity::Info);
    }

    #[test]
    fn test_fda_severity_display() {
        assert_eq!(format!("{}", FdaSeverity::Error), "ERROR");
        assert_eq!(format!("{}", FdaSeverity::Warning), "WARNING");
        assert_eq!(format!("{}", FdaSeverity::Info), "INFO");
    }

    #[test]
    fn test_validate_empty_sbom() {
        let sbom = NormalizedSbom::default();
        // Should not panic
        let _ = validate_ntia_elements(&sbom);
    }

    #[test]
    fn test_fda_document_validation() {
        let sbom = NormalizedSbom::default();
        let mut issues = Vec::new();
        validate_fda_document(&sbom, &mut issues);
        // Should find missing creator issue
        assert!(!issues.is_empty());
    }
}