safe_chains/engine/resolve.rs
1//! The profile resolver — turning a parsed command into its behavior profile
2//! (annex `behavioral-taxonomy-engine`). Runs via `engine::bridge`, which is
3//! AUTHORITATIVE for every command it can resolve (`engine_verdict(tokens).unwrap_or(legacy)`
4//! in `cst::check::leaf_verdict`) — there is no opt-out.
5//!
6//! This file holds the dispatch (`resolve`) and the per-command `resolve_*` functions;
7//! the shared toolkit they build on lives in submodules: [`flags`] (the getopt-style
8//! flag walker), [`locus`] (`classify_locus` — the [`LocalLocus`] ladder that refines the
9//! old `is_safe_write_target` boolean, v1.4 §2.2), and [`capability`] (the builders that
10//! stamp out each `Capability` with the facet pairing its operation warrants).
11
12use super::facet::*;
13use crate::parse::{Token, has_flag};
14
15mod capability;
16mod flags;
17pub(crate) mod locus;
18pub(crate) mod regions;
19#[cfg(test)]
20mod scenarios;
21
22use capability::{
23 breadth_scale, creates, destroys, executes, mutates, observes, observes_path, overwrites,
24 reads_content, reads_path, reads_to_model, relocates, transfer_profile, worst,
25 writes_export_file,
26};
27use flags::{walk_positionals, walk_value};
28use locus::{classify_locus, read_locus, write_locus};
29pub(crate) use locus::{FrozenWrite, anchoring_of, frozen_write_kind, names_credential_store};
30pub(crate) use locus::is_unpinnable;
31
32/// For `for VAR in ITEMS; do …$VAR…`, the representatives to bind `$VAR` to in the body: the
33/// worst-READ item and the worst-WRITE item of the list (they can differ, so a read and a
34/// write of `$VAR` each get their list's worst case). `$VAR` then inherits the list's locus
35/// per operation — the `find … {}`→path binding, one layer up. `None` for an empty list, which
36/// leaves `$VAR` fail-closed (machine). An item the classifier cannot bound — an UNDECLARED command
37/// substitution, a process substitution, arithmetic — worst-cases to machine via a `$`-carrying
38/// sentinel representative. An item from a substitution whose inner command DECLARED its output
39/// locus is bounded, so it is classified like any other path: `for f in $(fd a app/)` reads the
40/// worktree, and `for f in $(fd a /etc)` still lands at machine because that is what the tag says.
41/// (The test here used to be a `__SAFE_CHAINS_` PREFIX match, which caught the bounded sentinel too
42/// and made the loop form deny while the bare `cat $(fd a app/)` was allowed.)
43pub(crate) fn loop_reprs(items: &[String]) -> Option<(String, String)> {
44 if items.is_empty() {
45 return None;
46 }
47 let faced: Vec<(String, LocalLocus, LocalLocus)> = items
48 .iter()
49 .map(|s| {
50 if crate::cst::check::is_opaque_value(s) {
51 ("$loop_sub".to_string(), LocalLocus::Machine, LocalLocus::Machine)
52 } else {
53 (s.clone(), read_locus(s), write_locus(s))
54 }
55 })
56 .collect();
57 let read_item = faced.iter().max_by_key(|(_, r, _)| *r).map(|(s, _, _)| s.clone())?;
58 let write_item = faced.iter().max_by_key(|(_, _, w)| *w).map(|(s, _, _)| s.clone())?;
59 // Freeze against the CURRENT (outer) loop bindings, so an inner representative like `$d/x`
60 // doesn't carry a stale outer variable into the body — nested loops compose.
61 //
62 // A GLOB item above the workspace gets no representative at all. `for f in /etc/*` binds `$f`
63 // to the literal `/etc/*`, and the body then reads a path whose last component the glob will
64 // choose — `/etc/shadow` among them — while the shield is asked about a string containing a
65 // `*`, which names nothing and clears every time.
66 let read_repr = if crate::engine::resolve::locus::glob_above_workspace(&read_item) {
67 crate::engine::resolve::locus::UNKNOWABLE_ITEM.to_string()
68 } else {
69 crate::pathctx::expand_vars(&read_item, false).into_owned()
70 };
71 let write_repr = crate::pathctx::expand_vars(&write_item, true).into_owned();
72 Some((read_repr, write_repr))
73}
74
75/// The verdict for READING the content of `path` — used to gate an input-redirect source
76/// (`cmd < path`) by its read locus, exactly as an operand read is gated, so `cat < /etc/shadow`
77/// denies like `cat /etc/shadow`. `-` / stdin never reaches here (redirects always name a file).
78pub(crate) fn read_content_verdict(path: &str) -> crate::verdict::Verdict {
79 let cap = reads_path(path, Scale::Single, "reads a redirect source");
80 crate::engine::bridge::project(&Profile::of(vec![cap]))
81}
82
83/// The verdict for reading everything UNDER `path` — a recursive searcher or an archiver's source
84/// tree, where the operand is the root of a sweep and not the file that gets read.
85pub(crate) fn read_tree_verdict(path: &str) -> crate::verdict::Verdict {
86 let cap = reads_path(path, Scale::Unbounded, "reads a tree of files");
87 crate::engine::bridge::project(&Profile::of(vec![cap]))
88}
89
90/// The verdict for WRITING/overwriting `path` — used to gate a legacy writer command's file
91/// operand (`tee`/`shred`/`bzip2`) by its write locus, so `shred /etc/hosts` denies.
92pub(crate) fn write_target_verdict(path: &str) -> crate::verdict::Verdict {
93 let cap = overwrites(write_locus(path), Scale::Single, false);
94 crate::engine::bridge::project(&Profile::of(vec![cap]))
95}
96
97/// Whether REBINDING `path` (removing it, or pointing the name elsewhere) is refused where an
98/// ordinary write is not. Only the trust-root directories answer true.
99///
100/// The nudge needs this, because its "does this reach outside" test reads the read and write faces
101/// only. A grant on `~/.config` opens both, so `rm -rf ~/.config` looked entirely unremarkable to
102/// the nudge while the engine refused it — a denial with no explanation at all, which is the worst
103/// of the outcomes available.
104pub(crate) fn rebind_is_stricter_than_write(path: &str) -> bool {
105 let rebind = overwrites(locus::rebind_locus(path), Scale::Single, false);
106 let refused = !crate::engine::bridge::project(&Profile::of(vec![rebind])).is_allowed();
107 refused && write_target_verdict(path).is_allowed()
108}
109
110/// Judge a path value, taking the WORST element when it is a colon-separated LIST.
111///
112/// The one place the list rule lives, so the environment gate and the flag gate cannot drift apart.
113/// They HAD drifted: the env gate always split on `:` while the flag gate never did, so
114/// `BORG_RSH=x:/tmp/evil` denied and `borg --rsh x:/tmp/evil` — the same operation — was approved.
115///
116/// Splitting is opt-OUT rather than opt-in, because the two mistakes are not symmetric. Treating a
117/// real list as one string is a FAIL-OPEN: `PYTHONPATH=/tmp/evil:/ok` read whole matches no locus
118/// rule and sails through. Treating a single value as a list is merely stricter. So a value splits
119/// unless its entry says it is a single value, and the entries that say so are commands
120/// (`BORG_RSH`, `RSYNC_RSH`) rather than search paths.
121///
122/// A URL is never split: `https://example.com` is not `https` plus `//example.com`, and splitting
123/// it denied every `curl` invocation in the suite.
124pub(crate) fn worst_path_element(
125 value: &str,
126 judge: fn(&str) -> crate::verdict::Verdict,
127 split_list: bool,
128) -> crate::verdict::Verdict {
129 let mut worst = judge(value);
130 if split_list && value.contains(':') && !value.contains("://") {
131 for element in value.split(':').filter(|s| !s.is_empty()) {
132 worst = worst.combine(judge(element));
133 }
134 }
135 worst
136}
137
138
139/// The verdict for EXECUTING the code in file `path` — used to gate an interpreter/runner's
140/// script operand (`bash x.sh`, `python x.py`, `node x.js`, `go run pkg/`) by its EXECUTOR
141/// locus. A worktree-local script is the dev loop → admitted at `developer`; a foreign one
142/// (`/tmp/x.sh`, `~/x.py`, `/usr/local/bin/x`) or an unpinnable path (`$VAR`, glob, `..`
143/// beyond cwd → `machine`) denies. `CallerFile` trust (code from a named file). See
144/// docs/design/behavioral-taxonomy-execution-origin.md.
145pub(crate) fn execute_file_verdict(path: &str) -> crate::verdict::Verdict {
146 // A GLOB executor (`bash *.sh`) names no specific file — the matched code is unknown, so
147 // it cannot be pinned to a worktree executor; deny (design §6). ($VAR/../cmdsub are already
148 // worst-cased by classify_locus.) A glob stays fine as a read/write OPERAND, where every
149 // match is locus-gated; only as an EXECUTOR is the code it would run unknowable.
150 if path.contains(['*', '?', '[']) {
151 return crate::engine::bridge::project(&worst("glob executor — the code that would run is unknown (§6)"));
152 }
153 // A PROCESS-SUBSTITUTION executor (`sh <(curl …)`) runs the OUTPUT of the inner command, not
154 // the inner command. The inner command is checked separately and is usually safe on its own —
155 // `curl` prints, `echo` prints — which is exactly how this hid: `sh <(curl …)` auto-approved
156 // while the identical `curl … | sh` denied. A command that is safe to RUN is not the same as a
157 // command whose output is safe to EXECUTE.
158 //
159 // Only in the executor slot. As a DATA operand the sentinel stays worktree-ordinary on purpose,
160 // because reading a `/dev/fd` pipe really is as safe as the inner command (`diff <(ls) <(ls)`).
161 if path.contains(crate::cst::eval::PROCSUB_SENTINEL) {
162 return crate::engine::bridge::project(&worst(
163 "process-substitution executor — the code that would run is a command's output (§6)",
164 ));
165 }
166 // A URL executor (`borg --rsh http://evil/x`, `rsync -e file:~`) is not a workspace file. The
167 // locus layer admits a network URL at `worktree` on purpose — for a network OPERAND the
168 // command's own handler gates the network, and a URL's `..` is a path segment rather than a
169 // filesystem escape. In an EXECUTOR slot that reasoning inverts: the thing has to be a local
170 // file the project owns, and `http://…` is not one however harmless its `..` are. Third member
171 // of the same family as the glob and process-substitution rules above.
172 if crate::engine::resolve::locus::is_url(path) {
173 return crate::engine::bridge::project(&worst(
174 "URL executor — the code that would run is not a workspace file (§6)",
175 ));
176 }
177 // An executor slot names a PATH. A value carrying whitespace is a command LINE, and judging it
178 // as one path is how `BORG_RSH='sh -c evil'` and `rsync -e 'sh -c evil'` were auto-approved:
179 // the whole string read as one oddly-named executable, which satisfied the bare-name rule.
180 //
181 // Every whitespace-separated token must therefore look like a path. That keeps the documented
182 // space-separated forms working (`LD_PRELOAD='/a.so /b.so'` judges both), while a token that is
183 // not a path — an interpreter's `-c`, the inline code after it — means the value was never a
184 // path and cannot be judged as one. Stated as a requirement ON the value, not as a list of
185 // forbidden programs: `sh -c evil` fails because `-c` is not a path, not because it is `sh`.
186 //
187 // Fail-CLOSED and known to over-deny: `rsync -e 'ssh -p 2222'` is a legitimate idiom that now
188 // refuses, because vetting a transport's own flags is a question this layer cannot answer.
189 if path.split_whitespace().count() > 1 {
190 let mut worst_seen = None;
191 for token in path.split_whitespace() {
192 if token.starts_with('-') {
193 return crate::engine::bridge::project(&worst(
194 "executor value is a command line, not a path — a non-path token means the \
195 code that would run is unknown",
196 ));
197 }
198 let v = execute_file_verdict(token);
199 worst_seen = Some(match worst_seen {
200 None => v,
201 Some(prev) => crate::verdict::Verdict::combine(prev, v),
202 });
203 }
204 return worst_seen.unwrap_or_else(|| {
205 crate::engine::bridge::project(&worst("empty executor value"))
206 });
207 }
208 let cap = executes(classify_locus(path), ExecutionTrust::CallerFile, "runs code from a named file");
209 crate::engine::bridge::project(&Profile::of(vec![cap]))
210}
211
212/// The verdict for running the CURRENT PROJECT's own code — an implicit-project runner
213/// (`cargo run`, `dotnet run`, `swift run`) with no path operand and no redirect out of the
214/// worktree. `SelfCode` @ `Worktree` → admitted at `developer`. A runner redirected out of the
215/// project (`cargo run --manifest-path ~/o/Cargo.toml`) resolves that path through
216/// [`execute_file_verdict`] instead. See docs/design/behavioral-taxonomy-execution-origin.md.
217pub(crate) fn execute_project_verdict() -> crate::verdict::Verdict {
218 let cap = executes(LocalLocus::Worktree, ExecutionTrust::SelfCode, "runs the current project's own code");
219 crate::engine::bridge::project(&Profile::of(vec![cap]))
220}
221
222/// Resolve a command's leaf tokens to its behavior profile, or `None` if the command
223/// has no resolver yet (the caller then worst-cases / falls back to the legacy
224/// classifier — §0 fail-closed). Redirects, substitutions, and chain semantics are the
225/// surrounding CST's job, not this leaf's (annex `…-engine` §1).
226pub fn resolve(tokens: &[Token]) -> Option<Profile> {
227 let arg0 = tokens.first()?;
228 // Canonicalize the invoked token through the registry's alias map (`gcat` → `cat`) BEFORE the
229 // resolver lookup: Homebrew installs GNU coreutils as g-prefixed aliases, and without this
230 // they'd miss every resolver and fall through to the ungated legacy classifier (a fail-open —
231 // `gtee /etc/cron.d/job`, `gcat /etc/shadow`). The `tokens` are passed through unchanged; the
232 // resolver gates operands by position, not by re-reading the command name.
233 let canonical = crate::registry::canonical_name(arg0.command_name());
234 // `sudo`/`doas` ELEVATE the wrapped command's authority — they are a delegating wrapper, not a
235 // command of their own. Resolve the inner command and lift its authority to root (or `other-user`
236 // for `-u`), so the safety of `sudo X` is the safety of `X` run privileged: `sudo cat ./notes`
237 // → a root READ (local-admin), `sudo rm -rf /` → the catastrophe corner (denied everywhere).
238 if canonical == "openssl" {
239 return resolve_openssl(arg0, tokens);
240 }
241 if matches!(canonical, "sudo" | "doas") {
242 return resolve_privilege_wrapper(arg0, tokens);
243 }
244 // Phase 1: a subcommand tagged with a facet archetype (`profile = …`) classifies as that
245 // archetype's static capability — the derived, self-documenting successor to `candidate = true`.
246 // Checked BEFORE command-level behavior, since a subcommand tool carries no `[command.behavior]`.
247 if let Some(names) = crate::registry::sub_archetypes(tokens) {
248 if !trusted_command_path(arg0.as_str()) {
249 return Some(worst("resolvable name invoked from a non-standard path — possible spoof (§0)"));
250 }
251 // An endpoint flag pointed at THIS machine makes the sub a DIFFERENT operation, not the same
252 // one with softened edges: `put-item --endpoint-url http://localhost:8000` writes to a
253 // process here, so `remote-mutate`'s `sends-host-data`, `effortful` reversibility and (for
254 // create) `metered` cost are all describing a cloud service that isn't in the picture. The
255 // sub names the archetype it becomes, so the substitution stays reviewable data rather than
256 // ad-hoc facet arithmetic at resolve time.
257 //
258 // Destroy archetypes may not declare a substitute at all — `assert_no_loopback_profile_on_
259 // destroy` refuses it at build time. We cannot verify the emulator claim (`ssh -L
260 // 8000:dynamodb.us-east-1.amazonaws.com:443` makes `localhost:8000` production, and no
261 // static classifier sees the tunnel), and that lie is only unrecoverable in the destroy
262 // direction.
263 // One capability per archetype (the sub's profile + each present escalating flag); the level
264 // algebra takes the max. Fail-closed: an unknown archetype name → a worst capability, so a
265 // typo or `unclassified` can never silently pass (a proptest catches typos at test time).
266 let mut caps: Vec<Capability> = names
267 .iter()
268 .map(|n| {
269 crate::engine::archetype::archetype(n).cloned().unwrap_or_else(|| {
270 Capability::worst("subcommand/flag declares an unknown archetype (§0)")
271 })
272 })
273 .collect();
274 // Destination-trust (exposure §4): a sub tagged `network_destination` gets its send TARGET
275 // classified onto the base archetype's `locus.provenance` — established remote / literal URL
276 // / opaque `$VAR` — or, for a command-transport form (`ext::…`), worst-cased as RCE.
277 if let Some(dest) = crate::registry::sub_destination_token(tokens) {
278 match destination_provenance(dest) {
279 Some(prov) => {
280 if let Some(base) = caps.first_mut() {
281 base.locus.provenance = prov;
282 }
283 }
284 None => {
285 return Some(worst(
286 "send target is a command transport (ext::…) — runs a local command, RCE (§4)",
287 ));
288 }
289 }
290 }
291 // A `data-export` sub with an OUTPUT-FILE flag (`db dump -f out.sql`) writes its bulk result
292 // to a local file — a SECOND capability beyond the remote read, gated at the file's locus
293 // (worktree write vs a system-path clobber). Absent → the export streams to stdout, so the
294 // profile is the remote read alone.
295 if let Some(path) = crate::registry::sub_output_path_token(tokens) {
296 caps.push(writes_export_file(classify_locus(path)));
297 }
298 // A declared endpoint flag naming THIS machine changes WHERE the call goes, so it changes
299 // exactly the facets the destination determines and nothing else. That boundary is the whole
300 // design: `remote-mutate` describes a cloud service in four places — it reaches a fixed
301 // remote, talks outbound, sends host data off the machine, and bills — and all four are
302 // false for `http://localhost:8000`. Its other facets (what the operation DOES: the
303 // operation itself, scale, retrieval, reversibility, persistence, disclosure) are properties
304 // of the call, not of its destination, and stay untouched.
305 //
306 // Composing rather than substituting a whole "local" archetype matters twice over: the
307 // remote archetypes do not each need a local twin, and nothing here asserts a fact the
308 // destination cannot establish. (An earlier cut swapped in `local-mutate-recoverable`, which
309 // claims `locus.local = worktree` and `persistence = data` — both untrue of a container.)
310 //
311 // DESTROY is skipped here and refused outright at build time by
312 // `assert_loopback_localizes_is_coherent`. The emulator claim is unverifiable: `ssh -L
313 // 8000:dynamodb.<region>.amazonaws.com:443` makes `localhost:8000` production and no static
314 // classifier sees the tunnel. Being wrong costs a stray write; being wrong about a delete
315 // costs the data.
316 if crate::registry::sub_loopback_localizes(tokens) {
317 for c in &mut caps {
318 if c.operation == Operation::Destroy {
319 continue;
320 }
321 c.locus.remote = RemoteReach::None;
322 c.network.direction = NetDirection::Loopback;
323 c.network.payload = NetPayload::None;
324 c.cost = Cost::None;
325 // The archetype's prose describes the cloud call and is now half wrong; say so,
326 // or `--explain` prints "changes remote state" over a profile that reaches no
327 // remote. The facets carry the classification, but the prose is what a human reads.
328 c.because = format!("{} — but the endpoint names this machine, so no remote is reached", c.because);
329 }
330 }
331 return Some(Profile::of(caps));
332 }
333 // A flat command whose top-level classifying flag (`[[command.flag]]`) is present resolves to
334 // that flag's archetype — the flag-triggered mode of a bimodal tool: `age -d` / `sops --decrypt`
335 // reveal plaintext to the model (`decrypt-read`), while the bare/encrypt form falls through to
336 // ordinary resolution below. Checked after the profiled-sub walk (a sub match wins) so a
337 // subcommand form (`sops decrypt`) and the flag form (`sops -d`) both classify.
338 if let Some(names) = crate::registry::command_flag_archetypes(tokens) {
339 if !trusted_command_path(arg0.as_str()) {
340 return Some(worst("resolvable name invoked from a non-standard path — possible spoof (§0)"));
341 }
342 let caps: Vec<Capability> = names
343 .iter()
344 .map(|n| {
345 crate::engine::archetype::archetype(n).cloned().unwrap_or_else(|| {
346 Capability::worst("command flag declares an unknown archetype (§0)")
347 })
348 })
349 .collect();
350 return Some(Profile::of(caps));
351 }
352 // Every facet-classified command declares `[command.behavior]` (the coreutils are all ported;
353 // dd/tar/sed/grep declare a `hook`). No declaration → the command is unresearched for the
354 // engine, so return `None` (the caller falls back to the legacy classifier).
355 let spec = crate::registry::command_behavior(canonical)?;
356 // A resolvable basename reached via a NON-STANDARD path (`./cat`, `/tmp/cat`, `~/bin/grep`)
357 // is not necessarily the real tool — a planted binary named `cat` would be certified as safe
358 // coreutils. Don't certify it; worst-case (§0). Bare names and standard bin paths are
359 // trusted. (Legacy classifies purely by basename and inherits the spoof; the engine is
360 // stricter here, which keeps it never-looser.)
361 if !trusted_command_path(arg0.as_str()) {
362 return Some(worst("resolvable name invoked from a non-standard path — possible spoof (§0)"));
363 }
364 Some(resolve_behavior(spec, tokens))
365}
366
367/// `sudo`/`doas`: resolve the wrapped command and ELEVATE its authority. Authority is the axis every
368/// level below `local-admin` pins to `user`, so a root capability lands at `local-admin` (or `yolo`)
369/// — the projection does the rest. Fail-closed: an unknown sudo option, a root shell/editor
370/// (`-i`/`-s`/`-e`), or an inner command from a non-standard path worst-cases; an unresolved inner
371/// returns `None` so the caller's legacy fallback denies it (never *looser* than the bare command).
372fn resolve_privilege_wrapper(arg0: &Token, tokens: &[Token]) -> Option<Profile> {
373 if !trusted_command_path(arg0.as_str()) {
374 return Some(worst("sudo/doas invoked from a non-standard path — possible spoof (§0)"));
375 }
376 let mut i = 1;
377 let mut run_as_other = false;
378 'scan: while let Some(tok) = tokens.get(i) {
379 let t = tok.as_str();
380 if t == "--" {
381 i += 1;
382 break;
383 }
384 if !t.starts_with('-') || t == "-" {
385 break; // the inner command starts here
386 }
387 if let Some(long) = t.strip_prefix("--") {
388 let (name, glued_val) = match long.split_once('=') {
389 Some((n, _)) => (n, true),
390 None => (long, false),
391 };
392 match name {
393 "login" | "shell" | "edit" => {
394 return Some(worst("sudo -i/-s/-e runs a root shell or editor — arbitrary code as root (§0)"));
395 }
396 "user" | "other-user" => {
397 run_as_other = true;
398 if !glued_val { i += 1; }
399 }
400 "group" | "prompt" | "close-from" | "host" | "role" | "type"
401 | "command-timeout" | "chroot" | "chdir" | "preserve-env" => {
402 // `--preserve-env` is boolean OR `--preserve-env=list`; only the space form of the
403 // others consumes a value. A bare `--preserve-env` just falls through (no skip).
404 if !glued_val && name != "preserve-env" { i += 1; }
405 }
406 "background" | "stdin" | "non-interactive" | "reset-timestamp"
407 | "remove-timestamp" | "set-home" | "askpass" | "help" | "version"
408 | "validate" | "list" | "bell" => {}
409 _ => return Some(worst("sudo: unrecognized option — fail-closed (§0)")),
410 }
411 } else {
412 // A short cluster (`-EH`, `-u root`, `-uroot`). Consume char by char; a valued flag eats
413 // the rest of the token as its value, or the next token if the rest is empty.
414 let rest = &t[1..];
415 for (idx, c) in rest.char_indices() {
416 match c {
417 'i' | 's' | 'e' => {
418 return Some(worst("sudo -i/-s/-e runs a root shell or editor — arbitrary code as root (§0)"));
419 }
420 'u' | 'U' | 'g' | 'p' | 'C' | 'h' | 'r' | 't' | 'T' | 'R' | 'D' => {
421 if c == 'u' || c == 'U' { run_as_other = true; }
422 if idx + c.len_utf8() == rest.len() { i += 1; } // value is the next token
423 i += 1;
424 continue 'scan; // rest of the token was this flag's value
425 }
426 'E' | 'H' | 'k' | 'K' | 'n' | 'b' | 'A' | 'S' | 'P' | 'B' | 'v' | 'l' => {}
427 _ => return Some(worst("sudo: unrecognized option — fail-closed (§0)")),
428 }
429 }
430 }
431 i += 1;
432 }
433 // A valued short flag at end-of-input (`sudo -u`, `doas -r`) consumes a "next token" that isn't
434 // there, pushing `i` one past the end — clamp so the slice can't panic (fail-OPEN crash of the
435 // hook). An overshoot means no command was left to elevate, same as the empty case below.
436 let inner = &tokens[i.min(tokens.len())..];
437 if inner.is_empty() {
438 return None; // `sudo` / `sudo -v` / `sudo -l` — no command to elevate; legacy decides
439 }
440 let elevated = if run_as_other { Authority::OtherUser } else { Authority::Root };
441 let caps = resolve(inner)?
442 .capabilities
443 .into_iter()
444 .map(|mut c| {
445 c.authority = c.authority.max(elevated);
446 c
447 })
448 .collect();
449 Some(Profile::of(caps))
450}
451
452/// openssl decrypt / private-key disclosure resolver. openssl's flag grammar defeats declarative
453/// flag-gating — it accepts `--opt` as an alias for `-opt` on every subcommand, `-text` dumps the
454/// PRIVATE key components to stdout past `-pubout`/`-noout`, and `-out`'s VALUE can itself be stdout
455/// (`-out -`, `-out /dev/stdout`) — so the disclosure-prone subs are classified here in Rust. Returns
456/// `decrypt-read` (→ yolo, denied below) only when private/decrypted material reaches the MODEL
457/// (stdout); returns `None` for public-key ops, to-FILE extraction, encrypt/sign, and the ~30 benign
458/// subs, which fall through to openssl's declarative (allow_all) classification. Fail-closed: a spoofed
459/// path worst-cases; a disclosure sub always yields a verdict rather than abstaining to the permissive
460/// legacy default.
461fn resolve_openssl(arg0: &Token, tokens: &[Token]) -> Option<Profile> {
462 if !trusted_command_path(arg0.as_str()) {
463 return Some(worst("openssl invoked from a non-standard path — possible spoof (§0)"));
464 }
465 let sub = tokens.get(1)?.as_str();
466 let args = &tokens[2..];
467 let discloses = match sub {
468 // Private-key subs: private material reaches the model UNLESS the input is public (`-pubin`),
469 // or it's public-key output (`-pubout`) with no `-text` side channel — and then only if the
470 // (private-key) output actually goes to stdout, not a file.
471 "rsa" | "pkey" | "ec" | "dsa" => {
472 if openssl_flag(args, "-pubin") {
473 false
474 } else if openssl_flag(args, "-text") {
475 true // dumps the private exponent/primes to stdout regardless of -out/-noout/-pubout
476 } else if openssl_flag(args, "-pubout") {
477 false // public-key PEM out, no -text
478 } else {
479 openssl_output_reaches_model(args)
480 }
481 }
482 // PKCS#8 is a private-key format with no public mode; disclosed if it reaches stdout.
483 "pkcs8" => openssl_flag(args, "-text") || openssl_output_reaches_model(args),
484 // Unencrypted key export (`-nodes`/`-noenc`, OpenSSL 3.0 spelling); disclosed if it hits stdout.
485 "pkcs12" => {
486 (openssl_flag(args, "-nodes") || openssl_flag(args, "-noenc"))
487 && openssl_output_reaches_model(args)
488 }
489 // Symmetric decrypt: plaintext to the model only when it goes to stdout.
490 "enc" => openssl_flag(args, "-d") && openssl_output_reaches_model(args),
491 "smime" => openssl_flag(args, "-decrypt") && openssl_output_reaches_model(args),
492 "cms" => {
493 (openssl_flag(args, "-decrypt") || openssl_flag(args, "-EncryptedData_decrypt"))
494 && openssl_output_reaches_model(args)
495 }
496 _ => return None, // benign subs — openssl's declarative (allow_all) classification
497 };
498 if discloses {
499 let cap = crate::engine::archetype::archetype("decrypt-read")
500 .cloned()
501 .unwrap_or_else(|| Capability::worst("decrypt-read archetype missing (§0)"));
502 Some(Profile::of(vec![cap]))
503 } else {
504 None // public / to-file / encrypt / benign → legacy allow_all classification
505 }
506}
507
508/// Whether an openssl BOOLEAN flag (`-d`, `-text`, `-pubout`) is present, accepting the `--` twin
509/// openssl honors on every subcommand (`--d`, `--text`). Value flags use [`openssl_flag_value`].
510fn openssl_flag(args: &[Token], flag: &str) -> bool {
511 args.iter().any(|t| {
512 let s = t.as_str();
513 s == flag || (s.starts_with("--") && s.len() > 2 && &s[1..] == flag)
514 })
515}
516
517/// Whether the sub's OUTPUT reaches the model. FAIL-CLOSED (a path string cannot be soundly matched
518/// against a denylist of device spellings — the OS collapses `//dev/stdout`, `/dev/./stdout`,
519/// `/dev/fd//1` to the same device, and openssl honors the LAST of duplicate `-out`s): the output
520/// reaches the model UNLESS it is provably diverted to a single plain FILE. So it's model-reaching
521/// when `-noout` is absent AND NOT (exactly one `-out` whose value is a plain file). `-noout`
522/// suppresses the PEM output (a validate); `-text` is checked by the caller BEFORE this, since it
523/// dumps to stdout past both `-noout` and `-out`.
524fn openssl_output_reaches_model(args: &[Token]) -> bool {
525 if openssl_flag(args, "-noout") {
526 return false;
527 }
528 let outs = openssl_flag_values(args, "-out");
529 // Diverted to disk ONLY when there is exactly one `-out` naming a plain file. No `-out` (default
530 // stdout), a duplicate `-out` (last-wins — the first is untrustworthy), or a device/`-` value all
531 // reach the model.
532 !matches!(outs.as_slice(), [only] if out_value_is_plain_file(only))
533}
534
535/// Whether an `-out` value names a plain FILE (a safe diversion), as opposed to stdout/`-`, or a
536/// device / fd / console path (`/dev/stdout`, `/dev/stderr`, `/dev/fd/1`, `/proc/self/fd/1`). Collapses
537/// redundant `/`, `.`, and `..` segments first so alternate spellings can't evade. Fail-closed: `-`,
538/// empty, or any `/dev/…` or `/proc/…/fd/…` path is NOT a plain file. (Symlinks are classified by their
539/// literal spelling — out of scope for a static classifier, per AGENTS.md.)
540///
541/// A value that is itself a FLAG token (starts with `-`) is NOT proof of diversion: openssl's own
542/// parser lets a preceding valued flag SWALLOW the `-out` token as its value (`-provider-path -out
543/// -provider-path f.pem` leaves openssl with no `-out` → stdout), and our scan then misreads the next
544/// flag as the filename. The tell in every such bypass is a dash-leading `-out` value — reject it.
545fn out_value_is_plain_file(value: &str) -> bool {
546 if value.is_empty() || value.starts_with('-') {
547 return false;
548 }
549 let norm = collapse_path(value).to_ascii_lowercase();
550 let device_or_fd =
551 norm == "/dev" || norm.starts_with("/dev/") || (norm.starts_with("/proc/") && norm.contains("/fd/"));
552 !device_or_fd
553}
554
555/// Collapse a path's redundant `/` / `.` / `..` segments (what the kernel does before opening it), so
556/// `//dev/stdout`, `/dev/./stdout`, `/dev/fd//1`, `/foo/../dev/stdout` all normalize to the device
557/// path. A leading `..` on a relative path is kept (can't resolve above an unknown cwd).
558fn collapse_path(p: &str) -> String {
559 let absolute = p.starts_with('/');
560 let mut stack: Vec<&str> = Vec::new();
561 for seg in p.split('/') {
562 match seg {
563 "" | "." => {}
564 ".." => {
565 if matches!(stack.last(), Some(&s) if s != "..") {
566 stack.pop();
567 } else if !absolute {
568 stack.push("..");
569 }
570 }
571 s => stack.push(s),
572 }
573 }
574 let joined = stack.join("/");
575 if absolute { format!("/{joined}") } else { joined }
576}
577
578/// Every value of a valued openssl flag (`-out file` / `--out file` / `-out=file` / `--out=file`),
579/// accepting the `--` twin — ALL occurrences, in order (openssl honors the last; the caller fails
580/// closed on duplicates).
581fn openssl_flag_values<'a>(args: &'a [Token], flag: &str) -> Vec<&'a str> {
582 let twin = format!("-{flag}"); // `-out` → `--out`
583 let mut out = Vec::new();
584 let mut i = 0;
585 while i < args.len() {
586 let s = args[i].as_str();
587 if let Some(v) = s
588 .strip_prefix(flag)
589 .or_else(|| s.strip_prefix(twin.as_str()))
590 .and_then(|r| r.strip_prefix('='))
591 {
592 out.push(v);
593 } else if (s == flag || s == twin)
594 && let Some(next) = args.get(i + 1)
595 {
596 out.push(next.as_str());
597 i += 1;
598 }
599 i += 1;
600 }
601 out
602}
603
604/// Classify a network-destination token's PROVENANCE (exposure §4). `None` (a bare invocation) is
605/// the configured default → `Established`. A command-transport form (`ext::<cmd>`) is not a
606/// destination but LOCAL CODE, signalled by a `None` return so the caller worst-cases it as RCE.
607fn destination_provenance(dest: Option<&str>) -> Option<Provenance> {
608 let Some(tok) = dest else {
609 return Some(Provenance::Established);
610 };
611 if tok.starts_with("ext::") {
612 return None; // `git push ext::sh -c …` runs a local command — RCE, not egress
613 }
614 // A variable / substitution: the actual target is not in the command string, so it cannot be
615 // reviewed — the fail-closed case.
616 if tok.contains('$') || tok.contains('`') {
617 return Some(Provenance::Opaque);
618 }
619 // Spelled inline: a URL scheme, an scp-style `user@host:path`, or a filesystem path. Otherwise a
620 // bare word is a reference to a configured remote (established by a prior `clone`/`remote add`).
621 let literal = tok.contains("://")
622 || (tok.contains('@') && tok.contains(':'))
623 || tok.starts_with('/')
624 || tok.starts_with("./")
625 || tok.starts_with("../");
626 Some(if literal { Provenance::Literal } else { Provenance::Established })
627}
628
629/// The generic, declaration-driven resolver: build a `Profile` from a command's
630/// `[command.behavior]` (`BehaviorSpec`) and its tokens. This is the non-legacy classification
631/// path expressed in TOML — the operation + operand-role + flag grammar are data, and this one
632/// function replaces a hardcoded `resolve_*`. Irreducible token logic a declaration can't
633/// express is delegated to a named `hook`.
634fn resolve_behavior(spec: &crate::registry::types::BehaviorSpec, tokens: &[Token]) -> Profile {
635 use crate::registry::types::{BehaviorHook, PositionalRole};
636 if let Some(hook) = spec.hook {
637 return match hook {
638 // grep's hook supplies the operand set (the irreducible token logic); the declared
639 // operation + the builders supply the facets — the composition seam (§8). grep is
640 // observe-only, so its operands become content reads.
641 BehaviorHook::Grep => {
642 let Some(g) = grep_operands(tokens) else {
643 return worst("grep: unrecognized flag or missing pattern — worst-cased (§0)");
644 };
645 let mut caps: Vec<Capability> = g
646 .pattern_files
647 .iter()
648 .map(|f| reads_path(f, Scale::Single, "reads a grep -f pattern file"))
649 .collect();
650 caps.extend(reads_to_model(&g.files, g.scale));
651 Profile::of(caps)
652 }
653 // dd/tar/sed parse their own irregular operand syntax (`key=value`, dashless mode
654 // bundles, a mini-language script) AND build their own multi-role profiles, so their
655 // hook returns the full `Profile` — the parser and the facets are entangled with the
656 // parse and stay in Rust (their DATA — flag/param sets — is small and audited).
657 BehaviorHook::Dd => resolve_dd(tokens),
658 BehaviorHook::Tar => resolve_tar(tokens),
659 BehaviorHook::Sed => resolve_sed(tokens),
660 BehaviorHook::Perl => resolve_perl(tokens),
661 };
662 }
663 // No path operands (echo): a pure stdout emitter, handled BEFORE the flag walk — echo has no
664 // flag grammar (it prints any `-x` verbatim), so walking would wrongly reject it. `observe`
665 // with model disclosure and no fs/net/exec; its args touch nothing.
666 if matches!(spec.positionals, PositionalRole::None) {
667 return match spec.operation {
668 Operation::Observe => {
669 let mut c = Capability::new(Operation::Observe);
670 c.disclosure.audience = DisclosureAudience::LocalProcess;
671 c.because = "behavior: prints its arguments to stdout; no fs/net/exec/secret".to_string();
672 Profile::of(vec![c])
673 }
674 _ => worst("behavior: none-operand role supports only observe (§0)"),
675 };
676 }
677 let long: Vec<&str> = spec.long.iter().map(String::as_str).collect();
678 let valued_long: Vec<&str> = spec.valued_long.iter().map(String::as_str).collect();
679 let Some(operands) = walk_positionals(&spec.short, &spec.valued_short, &long, &valued_long, spec.numeric_shorthand, tokens) else {
680 return worst("behavior: unrecognized flag — worst-cased (§0)");
681 };
682 let scale = behavior_scale(spec, &operands, tokens);
683 // Path-flag values (e.g. `touch -r REF`) are gated alongside the positional operands.
684 let flag_caps = path_flag_caps(spec, tokens);
685 match spec.positionals {
686 PositionalRole::Read => {
687 let mut caps = reads_to_model(&operands, scale);
688 caps.extend(flag_caps);
689 Profile::of(caps)
690 }
691 PositionalRole::Write => {
692 if operands.is_empty() {
693 // `rm --help` prints usage and exits. It is not a write whose target is hidden, so
694 // worst-casing it denied every informational invocation of every write command:
695 // `rm --help`, `mkdir --help`, `rmdir --version`. The flag already passed the
696 // command's own grammar to get here, and no operand survived the walk.
697 //
698 // LONG forms only, the same rule and the same reasoning the output-claim voider
699 // uses below: `-h`/`-V` are not reliably help/version (`sort -h` is human-numeric
700 // sort), so honoring the short spellings here would be guessing.
701 if tokens.iter().skip(1).any(|t| matches!(t.as_str(), "--help" | "--version")) {
702 let mut c = Capability::new(Operation::Observe);
703 c.disclosure.audience = DisclosureAudience::LocalProcess;
704 c.because = "behavior: prints usage and exits; nothing is written".to_string();
705 return Profile::of(vec![c]);
706 }
707 return worst("behavior: write operation with no operand — worst-cased (§0)");
708 }
709 let mut caps: Vec<Capability> = operands
710 .iter()
711 .map(|p| match spec.operation {
712 // A destroy UNBINDS the name, so it reads the rebind face: `rm -rf ~/.config`
713 // removes what the trust root points at, while `touch ~/.config/x` does not.
714 Operation::Destroy => destroys(locus::rebind_locus(p), scale),
715 Operation::Create => creates(classify_locus(p), scale),
716 Operation::Mutate => mutates(classify_locus(p), scale, "behavior: in-place mutate"),
717 _ => Capability::worst("behavior: unsupported write operation — worst-cased (§0)"),
718 })
719 .collect();
720 caps.extend(flag_caps);
721 Profile::of(caps)
722 }
723 PositionalRole::Transfer => resolve_transfer(spec, operands, flag_caps, tokens),
724 // None is handled above (before the flag walk); pattern-then-read routes through a hook
725 // (grep). Neither reaches here, so both fail closed.
726 PositionalRole::None | PositionalRole::PatternThenRead => {
727 worst("behavior: operand role not resolvable without a hook (§0)")
728 }
729 }
730}
731
732/// The transfer arm of `resolve_behavior` (cp/mv/ln): split the operands into sources and a
733/// destination (`-t`/`--target-directory` value, else the last operand), gate each at its locus
734/// — a relocate source at its WRITE face — and fold in any path-flag capabilities. Fails closed
735/// on a missing spec, a missing dest, or a `-t` dest with no sources.
736fn resolve_transfer(
737 spec: &crate::registry::types::BehaviorSpec,
738 operands: Vec<&str>,
739 flag_caps: Vec<Capability>,
740 tokens: &[Token],
741) -> Profile {
742 use crate::registry::types::TransferSource;
743 let Some(t) = &spec.transfer else {
744 return worst("behavior: transfer role without transfer spec — worst-cased (§0)");
745 };
746 // Whether the destination is DEFINITIVELY a container rather than the entry being created.
747 // `-t DIR` says so outright, and with two or more sources the last operand must be a directory
748 // for the command to make sense at all. Only the two-operand form is ambiguous, and there the
749 // conservative reading (the destination is the entry) is the safe one.
750 let (sources, dest, dest_is_container) = if let Some(d) = walk_value(&spec.valued_short, tokens, b't', "--target-directory") {
751 if operands.is_empty() {
752 return worst("behavior: transfer -t with no source operand — worst-cased (§0)");
753 }
754 (operands, d, true)
755 } else {
756 match operands.split_last() {
757 Some((last, rest)) if !rest.is_empty() => (rest.to_vec(), *last, rest.len() >= 2),
758 _ => return worst("behavior: transfer needs a source and a destination — worst-cased (§0)"),
759 }
760 };
761 let no_clobber = if t.clobber_flags.is_empty() {
762 t.no_clobber_flags.iter().any(|f| behavior_flag_present(tokens, f))
763 } else {
764 // A clobber flag PRESENT means overwrite; its absence is the no-clobber default.
765 !t.clobber_flags.iter().any(|f| behavior_flag_present(tokens, f))
766 };
767 let recursive = t.recursive_flags.iter().any(|f| behavior_flag_present(tokens, f));
768 let transfer_scale = breadth_scale(&sources, recursive);
769 // A relocate REMOVES its source, so the source name stops referring to anything: that is a
770 // REBIND, not merely a write, and it is what makes `mv ~/.config elsewhere` a relocation of the
771 // trust root rather than an edit of it.
772 let source_face = match t.source {
773 TransferSource::Relocate => locus::Face::Rebind,
774 TransferSource::Observe => locus::Face::Read,
775 };
776 // `ln` points the destination NAME at something else; `cp`/`mv` write bytes at or under it.
777 // Both are `create`/`transfer`, so only the command's own declaration separates them.
778 //
779 // But the declaration is about the ENTRY the command creates, and `ln -t DIR a` or
780 // `ln a b DIR` puts that entry INSIDE the directory instead of replacing it. Treating those as
781 // rebinds denied `ln -t ~/.config a`, which is an ordinary link into a directory you granted —
782 // the same container-versus-object mistake the write face made before this face existed.
783 let dest_face = if t.rebinds_destination && !dest_is_container {
784 locus::Face::Rebind
785 } else {
786 locus::Face::Write
787 };
788 let mut prof = transfer_profile(
789 &sources,
790 dest,
791 transfer_scale,
792 source_face,
793 dest_face,
794 |loc, sc| match t.source {
795 TransferSource::Observe => observes(loc, sc, "transfer reads the source at its locus"),
796 TransferSource::Relocate => relocates(loc, sc),
797 },
798 |loc, sc| overwrites(loc, sc, no_clobber),
799 );
800 prof.capabilities.extend(flag_caps);
801 prof
802}
803
804/// Capabilities for a command's declared PATH-FLAGS: a valued flag whose value is a path
805/// (`touch -r REF` reads REF's timestamp) is gated by its role's locus, exactly like an operand
806/// — so an out-of-workspace value denies. Folds the `[command.path_gate]` idea into behavior.
807fn path_flag_caps(spec: &crate::registry::types::BehaviorSpec, tokens: &[Token]) -> Vec<Capability> {
808 use crate::registry::types::PathRole;
809 let mut caps = Vec::new();
810 for pf in &spec.path_flags {
811 let short = pf.short.unwrap_or(0);
812 let long = pf.long.as_deref().unwrap_or("");
813 if let Some(v) = walk_value(&spec.valued_short, tokens, short, long) {
814 caps.push(match pf.role {
815 PathRole::Read => observes_path(v, Scale::Single, "behavior: a flag value is a read path"),
816 PathRole::Write => mutates(write_locus(v), Scale::Single, "behavior: a flag value is a write path"),
817 });
818 }
819 }
820 caps
821}
822
823/// The `Scale` for a behavior resolution: `single` always yields one item; `breadth` widens on
824/// operand count, a glob, or a declared unbounded flag (`rm -r`) via `breadth_scale`.
825fn behavior_scale(
826 spec: &crate::registry::types::BehaviorSpec,
827 operands: &[&str],
828 tokens: &[Token],
829) -> Scale {
830 use crate::registry::types::ScaleModel;
831 match spec.scale {
832 ScaleModel::Single => Scale::Single,
833 ScaleModel::Breadth => {
834 let recursive = spec.unbounded_flags.iter().any(|f| behavior_flag_present(tokens, f));
835 breadth_scale(operands, recursive)
836 }
837 }
838}
839
840/// Whether a declared behavior flag (a bare token like `-r` or `--recursive`) is present,
841/// via the shared `has_flag` (which handles short clustering and `--flag=value`).
842fn behavior_flag_present(tokens: &[Token], flag: &str) -> bool {
843 if flag.starts_with("--") {
844 has_flag(tokens, None, Some(flag))
845 } else {
846 has_flag(tokens, Some(flag), None)
847 }
848}
849
850/// A command name with no resolver and no plausible future one — the stable stand-in for
851/// "unresearched" across engine tests. Using a real tool here is a trap: when `rm` gained
852/// a resolver, three tests that used `rm` as their unresearched example silently broke.
853/// A name that will never be a real tool can never be silently repurposed.
854#[cfg(test)]
855pub(crate) const UNRESOLVED_CMD: &[&str] = &["safe-chains-unresolved-sentinel"];
856
857/// Whether `arg0` is a trusted way to invoke a standard tool: a bare name (found via
858/// `$PATH`) or an absolute path under a standard system bin directory. A path elsewhere
859/// (`./x`, `/tmp/x`, `~/bin/x`) may be an impostor.
860fn trusted_command_path(arg0: &str) -> bool {
861 const STD_BINS: &[&str] =
862 &["/usr/bin/", "/bin/", "/usr/local/bin/", "/opt/homebrew/bin/", "/sbin/", "/usr/sbin/"];
863 !arg0.contains('/') || STD_BINS.iter().any(|p| arg0.starts_with(p))
864}
865
866/// The classified operand set of a `grep` invocation: the positional file operands (read at
867/// `scale`, empty = stdin) and the `-f`/`--file` pattern files (each read once). This is the
868/// irreducible token logic a `[command.behavior]` declaration can't express — grep's
869/// pattern-vs-file disambiguation, `-e`/`-f` pattern flags, and the unknown-`--token`-is-a-
870/// pattern heuristic. The declared `operation` (observe) and the builders turn these operands
871/// into capabilities in `resolve_behavior`'s hook arm; this function assigns no facets.
872struct GrepOperands<'a> {
873 files: Vec<&'a str>,
874 pattern_files: Vec<&'a str>,
875 scale: Scale,
876}
877
878/// Walk a `grep` command into its `GrepOperands`, or `None` to fail closed (unrecognized flag,
879/// or no pattern operand). The behavior hook (`BehaviorHook::Grep`) for `commands/text/grep.toml`.
880fn grep_operands(tokens: &[Token]) -> Option<GrepOperands<'_>> {
881 // `-r` (or --recursive); `-R`/--dereference-recursive is not benign and worst-cases
882 // in the walk below, so it needn't be detected here.
883 let recursive = has_flag(tokens, Some("-r"), Some("--recursive"));
884 let scale = if recursive { Scale::Unbounded } else { Scale::Single };
885
886 let mut files = Vec::new(); // positional file operands
887 let mut pattern_files = Vec::new(); // -f/--file pattern files grep reads
888 let mut pattern_from_flag = false;
889 let mut unknown_flag = false;
890 let mut flags_done = false;
891 let mut i = 1;
892 while i < tokens.len() {
893 let t = tokens[i].as_str();
894 let next = tokens.get(i + 1).map(Token::as_str);
895 if !flags_done && t == "--" {
896 flags_done = true;
897 i += 1;
898 } else if flags_done || !t.starts_with('-') || t == "-" {
899 files.push(t);
900 i += 1;
901 } else if t.starts_with("--") {
902 if let Some(v) = t.strip_prefix("--file=") {
903 pattern_from_flag = true;
904 pattern_files.push(v);
905 i += 1;
906 } else if t == "--file" {
907 pattern_from_flag = true;
908 pattern_files.extend(next);
909 i += 2;
910 } else if t == "--regexp" {
911 pattern_from_flag = true;
912 i += 2;
913 } else if t.starts_with("--regexp=") {
914 pattern_from_flag = true;
915 i += 1;
916 } else if grep_long_known(t) {
917 i += 1;
918 } else if grep_long_dangerous(t) {
919 unknown_flag = true;
920 i += 1;
921 } else {
922 // An unrecognized `--token` is not a grep flag: it is the search PATTERN
923 // (grep patterns commonly look like `-->`, `---`, `--foo`). Treat it as a
924 // positional so the file operands classify the read, matching legacy.
925 files.push(t);
926 i += 1;
927 }
928 } else {
929 match grep_short_cluster(t, next) {
930 GrepShort::Unrecognized => {
931 unknown_flag = true;
932 i += 1;
933 }
934 GrepShort::Standalone => i += 1,
935 GrepShort::Pattern { file, consumes_next } => {
936 pattern_files.extend(file);
937 pattern_from_flag = true;
938 i += if consumes_next { 2 } else { 1 };
939 }
940 GrepShort::SkipValue { consumes_next } => i += if consumes_next { 2 } else { 1 },
941 }
942 }
943 }
944
945 if unknown_flag {
946 return None; // unrecognized flag → fail closed (§0)
947 }
948 if files.is_empty() {
949 // No positional operand → grep has no pattern (a `-e`/`-f` pattern still needs a
950 // search target). This is a usage error; the legacy classifier denies it, so the
951 // engine must not be looser — fail closed (§0).
952 return None;
953 }
954
955 if !pattern_from_flag {
956 files.remove(0); // the first positional is the PATTERN, not a file
957 }
958 if recursive && files.is_empty() {
959 files.push("."); // grep -r with no path searches the cwd
960 }
961
962 Some(GrepOperands { files, pattern_files, scale })
963}
964
965/// The outcome of parsing one grep short-option cluster.
966enum GrepShort<'a> {
967 /// An unrecognized short (e.g. `-R`, symlink-dereferencing recursive) → the caller worst-cases.
968 Unrecognized,
969 /// All chars benign; no value taken.
970 Standalone,
971 /// `-e`/`-f` supplied the pattern (so positionals are files); `-f`'s value, if any,
972 /// is a pattern file grep reads.
973 Pattern { file: Option<&'a str>, consumes_next: bool },
974 /// `-m`/`-A`/`-B`/`-C`/`-d` — a count/action value to skip.
975 SkipValue { consumes_next: bool },
976}
977
978/// Parse a grep short-option cluster (e.g. `-ifpatterns`), honoring GNU semantics that a
979/// value-taking short consumes the rest of its cluster (glued) or the next token.
980fn grep_short_cluster<'a>(cluster: &'a str, next: Option<&'a str>) -> GrepShort<'a> {
981 // NB: `r` (recursive) is benign, but `R` (--dereference-recursive) follows symlinks
982 // and can escape the classified locus, so it is NOT benign — it worst-cases. `P`
983 // (PCRE, `--perl-regexp`) IS benign: GNU grep's PCRE2 does not implement Perl's
984 // `(?{code})` execution, so it runs no code — it's just another regex engine like `-E`/`-F`.
985 const BENIGN: &[u8] = b"ivnclLoqswxHhaIrzZEFGbUP";
986 let bytes = cluster.as_bytes();
987 let mut k = 1;
988 while k < bytes.len() {
989 // Non-ASCII bytes aren't flags and would make `cluster[k + 1..]` slice mid-char.
990 if !bytes[k].is_ascii() {
991 return GrepShort::Unrecognized;
992 }
993 let glued = &cluster[k + 1..]; // safe: bytes[k] is ASCII → k+1 is a char boundary
994 let has = !glued.is_empty();
995 match bytes[k] {
996 b'f' => {
997 let file = if has { Some(glued) } else { next };
998 return GrepShort::Pattern { file, consumes_next: !has };
999 }
1000 b'e' => return GrepShort::Pattern { file: None, consumes_next: !has },
1001 b'm' | b'A' | b'B' | b'C' | b'd' => return GrepShort::SkipValue { consumes_next: !has },
1002 b if BENIGN.contains(&b) => k += 1,
1003 _ => return GrepShort::Unrecognized,
1004 }
1005 }
1006 GrepShort::Standalone
1007}
1008
1009/// Whether a grep long flag (its `--name`, ignoring any `=value`) is recognized-benign.
1010/// `--dereference-recursive` and anything unlisted are not → worst-case (§0).
1011fn grep_long_known(flag: &str) -> bool {
1012 const KNOWN: &[&str] = &[
1013 "--recursive", "--ignore-case", "--invert-match", // NB: --dereference-recursive
1014 // (symlink-following) is intentionally absent → worst-case (M2)
1015 "--line-number", "--count", "--files-with-matches", "--files-without-match",
1016 "--only-matching", "--perl-regexp", "--word-regexp", "--line-regexp", "--fixed-strings",
1017 "--extended-regexp", "--basic-regexp", "--with-filename", "--no-filename",
1018 "--quiet", "--silent", "--no-messages", "--null", "--byte-offset", "--text",
1019 "--color", "--colour", "--help", "--version", "--after-context", "--before-context",
1020 "--context", "--max-count", "--include", "--exclude", "--exclude-dir",
1021 "--include-dir", "--binary-files", "--devices", "--directories",
1022 ];
1023 let name = flag.split('=').next().unwrap_or(flag);
1024 KNOWN.contains(&name)
1025}
1026
1027/// The long spelling of the dangerous grep short `-R`: `--dereference-recursive` (follows
1028/// symlinks out of the classified locus, M2). Recognized so both spellings worst-case; every
1029/// OTHER unrecognized `--token` is a search pattern, not a flag. (`--perl-regexp`/`-P` is NOT
1030/// here — PCRE2 executes no code, so it is benign, like `-E`/`-F`.)
1031fn grep_long_dangerous(flag: &str) -> bool {
1032 let name = flag.split('=').next().unwrap_or(flag);
1033 matches!(name, "--dereference-recursive")
1034}
1035
1036/// `dd if=IN of=OUT bs=… …` — the operand-model breaker: `dd` takes NO getopt flags or
1037/// positionals, only `key=value` operands, so the shared `Flags`/`positionals` toolkit does
1038/// not apply and it parses its own. `if=` reads (default stdin), `of=` writes (default
1039/// stdout). It is still a transfer at the facet level — `dd if=~/.ssh/id_rsa of=./x` denies
1040/// on the input locus, `dd if=./x of=/dev/rdisk0` denies on the output locus (a raw device
1041/// is beneath the fs) — but the roles arrive inside `key=value`, not positional slots, which
1042/// is why its conservation probe is `Operands::Custom`. `bs`/`count`/`conv`/… are benign
1043/// transfer parameters; any other key, or a non-`key=value` operand, worst-cases (§0).
1044fn resolve_dd(tokens: &[Token]) -> Profile {
1045 const PARAMS: &[&str] = &[
1046 "bs", "ibs", "obs", "cbs", "count", "skip", "seek", "conv", "iflag", "oflag", "status",
1047 ];
1048 let (mut input, mut output) = (None, None);
1049 for t in &tokens[1..] {
1050 let t = t.as_str();
1051 if t == "--help" || t == "--version" {
1052 continue;
1053 }
1054 let Some((key, val)) = t.split_once('=') else {
1055 return worst("dd: non key=value operand — worst-cased (§0)");
1056 };
1057 match key {
1058 "if" => input = Some(val),
1059 "of" => output = Some(val),
1060 k if PARAMS.contains(&k) => {}
1061 _ => return worst("dd: unrecognized operand — worst-cased (§0)"),
1062 }
1063 }
1064 // dd touches exactly one input and one output — a `single` blast radius, whatever the
1065 // data VOLUME. The disk-wipe danger of `of=/dev/rdisk0` is carried by its device locus,
1066 // not by scale.
1067 // Built from the PATH, not just its locus: the locus says which rung `if=` reaches, and the
1068 // shield is what says whether the file on that rung is a credential store. Reading the rung
1069 // alone let `dd if=/etc/shadow of=./safe` copy a file `cat /etc/shadow` refuses, then read the
1070 // copy out of the worktree — the shield was never asked.
1071 match output {
1072 // of= names a sink: read the input into it (no model disclosure) + write the sink.
1073 Some(of) => Profile::of(vec![
1074 match input {
1075 Some(i) => observes_path(i, Scale::Single, "dd reads its input (if=) into the output"),
1076 None => observes(LocalLocus::Process, Scale::Single, "dd reads stdin into the output"),
1077 },
1078 overwrites(classify_locus(of), Scale::Single, false),
1079 ]),
1080 // no of= → output is stdout, so the input content reaches the model (like `cat`).
1081 None => Profile::of(vec![match input {
1082 Some(i) => reads_path(i, Scale::Single, "dd copies its input to stdout (→ the model)"),
1083 None => reads_content(
1084 LocalLocus::Process,
1085 Scale::Single,
1086 "dd copies stdin to stdout (→ the model)",
1087 ),
1088 }]),
1089 }
1090}
1091
1092/// `tar` — the flag-SYNTAX breaker: its options may be written WITHOUT a leading dash
1093/// (`tar czf` == `tar -czf`), so the getopt walker misreads the cluster as a positional; tar
1094/// parses its own. The mode letter splits the profile sharply:
1095/// - create/append (`c`/`r`/`u`): reads each member (source) + writes the archive (dest) —
1096/// a bundler, so `tar czf - ~/.ssh` denies on the member locus (golden-set).
1097/// - list (`t`): reads the archive, prints member names to the model.
1098/// - extract (`x`) and the rarer modes: extraction writes an ARCHIVE-CONTROLLED set of
1099/// paths that `..`-traversal can send anywhere — unknowable without opening the archive,
1100/// so worst-case (§0). Any value-taking option we don't model (`-C`, `-T`, …) or an
1101/// unknown letter also worst-cases.
1102fn resolve_tar(tokens: &[Token]) -> Profile {
1103 let mut p = TarParse::default();
1104 // `-C DIR` changes the directory for the members that FOLLOW it, so a member's real locus
1105 // is `DIR/member` — the same `find … {}`→path binding. tar applies `-C` CUMULATIVELY: each
1106 // `-C` chdir's relative to the already-changed directory, so consecutive `-C / -C etc`
1107 // resolves to `/etc`, not `etc`. Compose relative values onto the active dir (via the same
1108 // `tar_bound` join, which also lets an absolute value replace and routes any `..` through
1109 // the unpinnable guard); stamp each positional with the accumulated dir.
1110 let mut dir: Option<String> = None;
1111 let mut i = 1;
1112 while i < tokens.len() {
1113 let t = tokens[i].as_str();
1114 if t == "-C" || t == "--directory" {
1115 dir = tokens.get(i + 1).map(|d| tar_bound(dir.as_deref(), d.as_str()));
1116 i += 2;
1117 continue;
1118 }
1119 if let Some(d) = t.strip_prefix("--directory=").or_else(|| t.strip_prefix("-C").filter(|d| !d.is_empty())) {
1120 dir = Some(tar_bound(dir.as_deref(), d));
1121 i += 1;
1122 continue;
1123 }
1124 if let Some(long) = t.strip_prefix("--") {
1125 p.long_option(long);
1126 } else if let Some(cluster) = t.strip_prefix('-').filter(|c| !c.is_empty()) {
1127 p.cluster(cluster);
1128 } else if i == 1 {
1129 p.cluster(t); // dashless old-style option bundle (only the first argument)
1130 } else {
1131 p.positionals.push((dir.clone(), t));
1132 }
1133 i += 1;
1134 }
1135 p.into_profile()
1136}
1137
1138/// A tar positional: a member/archive path with the accumulated `-C` directory active when it
1139/// appeared (already composed across consecutive `-C` options).
1140type TarPositional<'a> = (Option<String>, &'a str);
1141
1142/// A tar positional borrowed for classification: (`-C` dir, path).
1143type TarRef<'a> = (Option<&'a str>, &'a str);
1144
1145/// A tar member/archive path resolved against an active `-C` directory: `DIR/path` for a
1146/// relative path, or `path` unchanged when there is no `-C` or the path is absolute (an
1147/// absolute member ignores `-C`).
1148fn tar_bound(dir: Option<&str>, path: &str) -> String {
1149 match dir {
1150 Some(d) if !path.starts_with('/') && !path.starts_with('~') && !path.starts_with('-') => {
1151 format!("{}/{}", d.trim_end_matches('/'), path)
1152 }
1153 _ => path.to_string(),
1154 }
1155}
1156
1157/// Accumulated `tar` parse: the mode, whether `-f` wants an archive, and `reject` — set by
1158/// any option we can't model safely (an unknown letter, or a value-taking option like `-T`
1159/// / `-X` whose ordered operand consumption we don't track). `-C` IS modeled (see
1160/// `resolve_tar`); it only reaches `cluster` inside a mixed bundle, which still worst-cases.
1161#[derive(Default)]
1162struct TarParse<'a> {
1163 mode: Option<u8>,
1164 want_archive: bool,
1165 reject: bool,
1166 long_archive: Option<&'a str>,
1167 /// Each positional with the `-C` directory active when it appeared (`None` = cwd).
1168 positionals: Vec<TarPositional<'a>>,
1169}
1170
1171impl<'a> TarParse<'a> {
1172 fn cluster(&mut self, cluster: &str) {
1173 const NOVAL: &[u8] = b"vzjJZpkmOwhSlPa"; // benign no-value option letters
1174 for b in cluster.bytes() {
1175 match b {
1176 b'c' | b'x' | b't' | b'r' | b'u' | b'A' | b'd' => self.mode = Some(b),
1177 b'f' => self.want_archive = true,
1178 b'C' | b'T' | b'X' | b'b' | b'H' | b'g' | b'K' | b'N' => self.reject = true,
1179 x if NOVAL.contains(&x) => {}
1180 _ => self.reject = true,
1181 }
1182 }
1183 }
1184
1185 fn long_option(&mut self, long: &'a str) {
1186 let name = long.split('=').next().unwrap_or(long);
1187 match name {
1188 "create" => self.mode = Some(b'c'),
1189 "extract" | "get" => self.mode = Some(b'x'),
1190 "list" => self.mode = Some(b't'),
1191 "append" => self.mode = Some(b'r'),
1192 "update" => self.mode = Some(b'u'),
1193 "file" => match long.split_once('=') {
1194 Some((_, v)) => self.long_archive = Some(v),
1195 None => self.want_archive = true,
1196 },
1197 "gzip" | "bzip2" | "xz" | "zstd" | "compress" | "verbose" | "preserve-permissions"
1198 | "same-permissions" | "to-stdout" | "help" | "version" | "dereference" | "totals" => {}
1199 _ => self.reject = true,
1200 }
1201 }
1202
1203 fn into_profile(self) -> Profile {
1204 let Some(mode) = self.mode.filter(|_| !self.reject) else {
1205 return worst("tar: unrecognized/unmodeled option — worst-cased (§0)");
1206 };
1207 // Separate the archive from the members. `--file=X` names it directly; a bare `f`
1208 // (dashless `czf` or dashed `-czf`) takes the FIRST positional as the archive.
1209 let (archive, members): (Option<TarRef>, &[TarPositional]) =
1210 if let Some(a) = self.long_archive {
1211 (Some((None, a)), &self.positionals)
1212 } else if self.want_archive {
1213 match self.positionals.split_first() {
1214 Some((first, rest)) => (Some((first.0.as_deref(), first.1)), rest),
1215 None => return worst("tar: -f without an archive — worst-cased (§0)"),
1216 }
1217 } else {
1218 (None, &self.positionals) // archive is stdin/stdout
1219 };
1220 // A `-` archive (or none) is a stdout/stdin stream, not a file to gate.
1221 let archive_file = archive.filter(|(_, a)| *a != "-");
1222
1223 match mode {
1224 b'c' | b'r' | b'u' => {
1225 let mut caps: Vec<Capability> = members
1226 .iter()
1227 // UNBOUNDED, not bounded: a member that is a directory is archived with
1228 // everything under it, so `tar -cf x.tar ~` packs every key in home into a
1229 // worktree file that is then ordinary to read. The member names the root of a
1230 // sweep, not a file, and the shield cannot clear a root.
1231 .map(|(dir, m)| observes_path(&tar_bound(dir.as_deref(), m), Scale::Unbounded, "tar reads a member into the archive"))
1232 .collect();
1233 if let Some((dir, a)) = archive_file {
1234 caps.push(overwrites(classify_locus(&tar_bound(dir, a)), Scale::Single, false));
1235 }
1236 if caps.is_empty() {
1237 return worst("tar create with no members — worst-cased (§0)");
1238 }
1239 Profile::of(caps)
1240 }
1241 b't' => {
1242 // Gated on the archive's PATH, not just its rung: `tar tf /etc/shadow` opens the
1243 // credential store and reports what it found there, which is a read of it however
1244 // poorly it parses as an archive.
1245 Profile::of(vec![match archive_file {
1246 Some((dir, a)) => reads_path(
1247 &tar_bound(dir, a),
1248 Scale::Single,
1249 "tar lists the archive's members (names → the model)",
1250 ),
1251 None => reads_content(
1252 LocalLocus::Process,
1253 Scale::Single,
1254 "tar lists stdin's members (names → the model)",
1255 ),
1256 }])
1257 }
1258 // x (extract) and A/d: archive-controlled, ..-escapable writes → worst-case.
1259 _ => worst("tar extract writes an archive-controlled, ..-escapable path set — worst-cased (§0)"),
1260 }
1261 }
1262}
1263
1264/// `sed` — the read-becomes-WRITE breaker: `sed 's/…/…/' FILE` reads FILE and prints to the
1265/// model, but `sed -i` edits the SAME file operands **in place** (a mutate), so a single
1266/// flag flips the operation on the same slots. Two more wrinkles: `-i` takes an OPTIONAL
1267/// glued suffix (`-i.bak`) the getopt walker can't express, and — like `grep` — the first
1268/// positional is the SCRIPT unless `-e`/`-f` supplied it (`-f` also reads a script file).
1269/// So `sed` parses its own flags.
1270fn resolve_sed(tokens: &[Token]) -> Profile {
1271 // HP-7: sed is a mini-language. Its `e` command/modifier executes text as a shell command
1272 // (RCE), and its `w`/`W`/`r`/`R` commands write/read arbitrary files EMBEDDED in the script —
1273 // both invisible to flag parsing. Scan the script(s): an `e`/unknown command worst-cases; the
1274 // file commands' filenames get gated by locus below (a local write is fine, `/etc/cron.d/x` is
1275 // not), exactly like the operand files.
1276 let script = crate::handlers::coreutils::sed::scan_sed(tokens);
1277 if script.exec || script.unknown {
1278 return worst("sed: script has an `e` exec or unmodeled command — worst-cased (§0, HP-7)");
1279 }
1280 // A `-f`/`--file` script comes from a file we can't read — its `e`/`w`/`r` commands are invisible,
1281 // so we can't verify it (like `awk -f`, `bash script.sh`, mlr `--load`). Worst-case it.
1282 if script.script_file {
1283 return worst("sed: -f runs a script file we can't inspect — worst-cased (§0)");
1284 }
1285 const BOOL: &[u8] = b"nrEsuz"; // no-value short flags
1286 let mut in_place = false;
1287 let mut script_from_flag = false;
1288 let mut script_files: Vec<&str> = Vec::new(); // -f FILE — sed reads these
1289 let mut files: Vec<&str> = Vec::new();
1290 let mut flags_done = false;
1291 let mut i = 1;
1292 while i < tokens.len() {
1293 let t = tokens[i].as_str();
1294 let next = tokens.get(i + 1).map(Token::as_str);
1295 if !flags_done && t == "--" {
1296 flags_done = true;
1297 i += 1;
1298 } else if flags_done || t == "-" || !t.starts_with('-') {
1299 files.push(t);
1300 i += 1;
1301 } else if let Some(long) = t.strip_prefix("--") {
1302 match sed_long(long, next, &mut in_place, &mut script_from_flag, &mut script_files) {
1303 Some(consumed) => i += consumed,
1304 None => return worst("sed: unrecognized flag — worst-cased (§0)"),
1305 }
1306 } else {
1307 match sed_cluster(&t[1..], next, BOOL) {
1308 SedShort::Bad => return worst("sed: unrecognized flag — worst-cased (§0)"),
1309 SedShort::InPlace => {
1310 in_place = true;
1311 i += 1;
1312 }
1313 SedShort::Standalone => i += 1,
1314 SedShort::Script { consumes_next } => {
1315 script_from_flag = true;
1316 i += usize::from(consumes_next) + 1;
1317 }
1318 SedShort::ScriptFile { file, consumes_next } => {
1319 script_from_flag = true;
1320 script_files.extend(file);
1321 i += usize::from(consumes_next) + 1;
1322 }
1323 SedShort::SkipValue { consumes_next } => i += usize::from(consumes_next) + 1,
1324 }
1325 }
1326 }
1327 // Without -e/-f, the first positional is the SCRIPT, not a file.
1328 if !script_from_flag && !files.is_empty() {
1329 files.remove(0);
1330 }
1331 // Blast radius: a glob (`sed -i … *`) or several operands is bounded, not single — so a
1332 // sweeping in-place edit is scored honestly (still worktree-bound by locus; a system or
1333 // home path denies whatever the scale).
1334 let scale = breadth_scale(&files, false);
1335 let mut caps: Vec<Capability> =
1336 script_files.iter().map(|f| observes_path(f, Scale::Single, "sed reads an -f script file")).collect();
1337 // Script-embedded file commands (`w`/`W` write, `r`/`R` read, `s///w` write) — gate each target
1338 // by its locus, just like an operand file.
1339 caps.extend(script.writes.iter().map(|f| mutates(classify_locus(f), Scale::Single, "sed w/W writes a file")));
1340 caps.extend(script.reads.iter().map(|f| observes_path(f, Scale::Single, "sed r/R reads a file")));
1341 if in_place {
1342 caps.extend(files.iter().map(|f| mutates(classify_locus(f), scale, "sed -i edits the file in place")));
1343 } else {
1344 caps.extend(reads_to_model(&files, scale));
1345 }
1346 Profile::of(caps)
1347}
1348
1349/// The locus of the paths a `$( … )` can PRODUCE, or `None` when nothing bounds them.
1350///
1351/// This is a different question from "is the inner command safe to run", and conflating the two is
1352/// a fail-open: `echo` is inert and `$(echo /etc/shadow)` still names a credential file. So a
1353/// command only gets an answer here if it has declared one (`[command.output]`); everything else
1354/// stays unpinnable, exactly as before. See docs/design/behavioral-taxonomy-substitution-locus.md.
1355pub(crate) fn substitution_claim(script: &crate::cst::Script) -> Option<SubClaim> {
1356 // A pipeline's VALUE is its last stage's stdout; the earlier stages feed it and are verdicted
1357 // separately as usual. Pass-through filters (`… | head -1`) emit a SUBSET of what they were
1358 // given, so walking back over them reaches the stage that actually produced the paths.
1359 let [stmt] = script.0.as_slice() else { return None };
1360 let cmds = &stmt.pipeline.commands;
1361 let mut idx = cmds.len().checked_sub(1)?;
1362 loop {
1363 match stage_output_locus(cmds.get(idx)?)? {
1364 StageOutput::Locus(l) => return Some(SubClaim::Locus(l)),
1365 // A pass-through filter emits a SUBSET of its input words, so it cannot turn an atom
1366 // into something with a separator — the claim survives the filter unchanged.
1367 StageOutput::Atom => return Some(SubClaim::Atom),
1368 StageOutput::PassThrough => idx = idx.checked_sub(1)?,
1369 }
1370 }
1371}
1372
1373enum StageOutput {
1374 Locus(LocalLocus),
1375 /// Every word of this stage's stdout is separator-free, so no word can BE a path.
1376 Atom,
1377 /// This stage only filters; ask the stage before it.
1378 PassThrough,
1379}
1380
1381/// What a `$(…)` is known to yield. Two different kinds of claim, which is why this is not an
1382/// `Option<LocalLocus>`: a locus says the value NAMES something at a rung, an atom says the value
1383/// names nothing at all and cannot traverse. The second is the weaker claim and the more useful
1384/// one — it is what lets a literal prefix survive around an interpolated leaf.
1385pub(crate) enum SubClaim {
1386 Locus(LocalLocus),
1387 Atom,
1388}
1389
1390fn stage_output_locus(cmd: &crate::cst::Cmd) -> Option<StageOutput> {
1391 let crate::cst::Cmd::Simple(simple) = cmd else { return None };
1392 let words: Vec<String> = simple.words.iter().map(crate::cst::Word::eval).collect();
1393 use crate::registry::types::OutputLocus;
1394 let (name, args) = words.split_first()?;
1395 // A resolvable name reached from a non-standard path (`./fd`) may not be the real tool, so it
1396 // gets no output-locus claim — the same spoof rule `resolve` applies to the command itself.
1397 if !trusted_command_path(name) {
1398 return None;
1399 }
1400 let token = Token::from_raw(name.clone());
1401 let canonical = crate::registry::canonical_name(token.command_name());
1402 // A SUB's claim wins over the command's, and narrows `args` to what follows the sub path so the
1403 // sub name is not counted as a path operand (`git ls-files src/` must see `src/`, not `ls-files`).
1404 let (rule, args) = match crate::registry::sub_output_locus(canonical, args) {
1405 Some((rule, rest)) => (rule, rest),
1406 None => (crate::registry::command_output_locus(canonical)?, args),
1407 };
1408 // At least one required flag must be present, or the command prints something other than paths
1409 // entirely — `git diff` without `--name-only` prints a patch. Checked before `invalidated_by`
1410 // because it is the stronger condition: absent, there is no claim to invalidate.
1411 if !rule.requires.is_empty() && !rule.requires.iter().any(|r| args.iter().any(|a| flag_present(a, std::slice::from_ref(r)))) {
1412 return None;
1413 }
1414 // `--help` and `--version` replace the command's DATA output with prose, and EVERY output
1415 // claim is a statement about the data. GNU `seq --help` prints
1416 // `<https://www.gnu.org/software/coreutils/>` — slash-bearing words under an `atom` claim that
1417 // says no word can contain a separator. Handled here rather than in each command's
1418 // `invalidated_by` so it holds for claims that do not exist yet: the danger is not seq (whose
1419 // help leaks only URLs, which as paths are relative) but the next atom source whose help
1420 // prints `/etc/foo.conf`, which would hand an ABSOLUTE path to a caller told it was confined.
1421 //
1422 // Long forms only. `-h` and `-V` are not reliably help/version — `sort -h` is human-numeric
1423 // sort — so treating them as informational would void real claims. A command whose OWN grammar
1424 // maps a short flag to help lists it in `invalidated_by` (see seq).
1425 //
1426 // Not caught by the local install: macOS ships BSD seq, whose help is terse and slash-free.
1427 if args.iter().any(|a| a == "--help" || a == "--version") {
1428 return None;
1429 }
1430 // A flag that changes what stdout CONTAINS (`fd -x cat {}` prints file bodies, `fd -l` prints
1431 // `ls -l` rows) voids the claim — the output is no longer a path at all.
1432 if args.iter().any(|a| flag_present(a, &rule.invalidated_by)) {
1433 return None;
1434 }
1435
1436 match rule.locus_from {
1437 // An ATOM names no locus — a separator-free word is not a path and cannot stand in for
1438 // one. It pays off in the PATH layer instead: a literal prefix around a FLANKED atom leaf
1439 // is confinable, because the atom cannot introduce a `/` and the flanking rules out the
1440 // leaf being `.` or `..`. Both halves of that are enforced in `locus::neutralize_atoms`;
1441 // on its own this claim widens nothing, since an atom sentinel is `is_unpinnable`.
1442 OutputLocus::Atom => Some(StageOutput::Atom),
1443 // The cwd is the workspace root by construction (the harness passes it), so `$(pwd)` is a
1444 // worktree path. `pathctx` is what decides whether the cwd itself escaped the root.
1445 OutputLocus::Cwd => Some(StageOutput::Locus(read_locus("."))),
1446 // Output descends the command's own path operands, so it is bounded by their worst read
1447 // locus. `fd x app/ lib/` → worktree; `fd x /` → machine.
1448 OutputLocus::Operands => {
1449 // ANY unpinnable argument voids the claim, checked before the path-shape filter and
1450 // over every argument rather than the ones that look like roots. A `$VAR` root carries
1451 // no `/`, so shape-filtering first read `fd pat $SECRET` as having no root at all and
1452 // reported worktree — while the command searches wherever `$SECRET` points.
1453 if args.iter().any(|a| is_unpinnable(a)) {
1454 return None;
1455 }
1456 let roots = candidate_roots(args, &rule.valued);
1457 // No path operand means the command searches `.` (`fd pattern`), which is the cwd.
1458 let worst = roots.iter().map(|r| read_locus(r)).max().unwrap_or_else(|| read_locus("."));
1459 // A bounded claim is only meaningful BELOW `user`. At worktree/adjacent/temp nothing
1460 // under the root can be a credential store, so the rung is the whole truth about the
1461 // value. At `user` or above it is not: the claim carries a LOCUS and says nothing about
1462 // WHICH file, and which file is exactly what the shield needs to see.
1463 //
1464 // `cat $(fd pat ~/.ssh)` was allowed while `cat ~/.ssh/id_rsa` denied — the tag reported
1465 // `machine`, the shield was never consulted because there was no path to consult it
1466 // about, and a substitution ended up more permissive than a path it could produce.
1467 // Caught by no_abstraction_is_more_permissive_than_a_path_it_could_denote.
1468 //
1469 // Same rule, and the same reasoning, as the synthetic pipe representative in
1470 // `cst::check::stage_output_repr`. Dropping the claim leaves the ordinary unpinnable
1471 // sentinel, which `reads_path` then treats as unshieldable.
1472 if worst >= LocalLocus::User {
1473 return None;
1474 }
1475 Some(StageOutput::Locus(worst))
1476 }
1477 // Only a filter when it is filtering: given a file operand it prints that file's CONTENTS,
1478 // which are caller-controlled text and no kind of path.
1479 OutputLocus::Stdin => {
1480 if candidate_roots(args, &rule.valued).is_empty() {
1481 Some(StageOutput::PassThrough)
1482 } else {
1483 None
1484 }
1485 }
1486 }
1487}
1488
1489/// Whether `arg` is one of `flags`, in any spelling that carries a value (`-x`, `--exec`,
1490/// `--exec=…`). A short flag may also be CLUSTERED (`-lx`), so single-char forms are matched
1491/// against the cluster's letters.
1492fn flag_present(arg: &str, flags: &[String]) -> bool {
1493 let head = arg.split('=').next().unwrap_or(arg);
1494 flags.iter().any(|f| {
1495 if head == f {
1496 return true;
1497 }
1498 match (f.strip_prefix('-'), arg.strip_prefix('-')) {
1499 (Some(letter), Some(cluster)) if f.len() == 2 && !arg.starts_with("--") => {
1500 cluster.contains(letter)
1501 }
1502 _ => false,
1503 }
1504 })
1505}
1506
1507/// Every argument that could name a search ROOT, over-approximated on purpose.
1508///
1509/// Under-counting here is a fail-OPEN — a missed root means a lower locus than the command actually
1510/// reaches — so EVERY non-flag argument counts, plus any path glued to a flag
1511/// (`--search-path=/etc`, `-E/etc/x`). Over-counting only ever raises the locus, which denies.
1512///
1513/// It deliberately does NOT ask whether an argument looks like a path. That test (`looks_like_path`)
1514/// keys on a `/` or a `.`, so a bare `~` failed it and `cat $(fd pat ~)` auto-approved a sweep of
1515/// the home directory as though it were worktree-local. A shape heuristic cannot be the last word
1516/// on a question whose wrong answer opens a hole.
1517fn candidate_roots<'a>(args: &'a [String], valued: &[String]) -> Vec<&'a str> {
1518 let mut roots = Vec::new();
1519 let mut skip_value = false;
1520 for a in args {
1521 if std::mem::take(&mut skip_value) {
1522 continue;
1523 }
1524 if a.starts_with('-') {
1525 // `valued` declares "this flag's value is NOT a path" (a count, a separator), so its
1526 // value is skipped in BOTH spellings. Handling only the separated form denied
1527 // `head --lines=5` while `head -n 5` passed — the same operation, two spellings.
1528 let (head, glued_value) = match a.split_once('=') {
1529 Some((h, v)) => (h, Some(v)),
1530 None => (a.as_str(), None),
1531 };
1532 if valued.iter().any(|v| v == head) {
1533 skip_value = glued_value.is_none();
1534 continue;
1535 }
1536 // Otherwise a glued value can still name a root. After `=` the whole value counts —
1537 // keying on `/` alone missed `--search-path=~`, the same blind spot as the shape test.
1538 // Without an `=`, a glued short value starts at the first path-ish character.
1539 let glued = glued_value.or_else(|| a.find(['/', '~']).map(|i| &a[i..]));
1540 if let Some(v) = glued.filter(|v| !v.is_empty()) {
1541 roots.push(v);
1542 }
1543 continue;
1544 }
1545 roots.push(a.as_str());
1546 }
1547 roots
1548}
1549
1550fn resolve_perl(tokens: &[Token]) -> Profile {
1551 // perl's `-e` one-liner is arbitrary code, so the identifier gate in `handlers::perl` decides
1552 // whether the CODE is inert. What that gate cannot do is judge the OPERANDS: it never looked at
1553 // them, which is why `perl -pe s/a/b/ /etc/shadow` used to read a credential file and print it
1554 // to the model. Both halves are needed — an inert one-liner over a system file is still an
1555 // exfiltration, and a worktree file rewritten by unmodeled code is still RCE.
1556 use crate::handlers::perl::PerlCode;
1557 let Some(scan) = crate::handlers::perl::scan_perl(tokens) else {
1558 return worst("perl: unmodeled flag cluster — worst-cased (§0)");
1559 };
1560 match scan.code {
1561 PerlCode::None => {
1562 let mut c = Capability::new(Operation::Observe);
1563 c.disclosure.audience = DisclosureAudience::LocalProcess;
1564 c.because = "perl: reports its own version/usage".to_string();
1565 return Profile::of(vec![c]);
1566 }
1567 // No `-e`/`-E` means the first operand is a SCRIPT FILE whose contents we cannot inspect
1568 // (like `sed -f`, `awk -f`, `bash x.sh`), and a failed identifier gate means the one-liner
1569 // reached outside the modeled vocabulary. Neither is separable from arbitrary execution.
1570 PerlCode::Opaque => return worst("perl: no inspectable -e/-E one-liner — worst-cased (§0)"),
1571 PerlCode::Inspectable => {}
1572 }
1573 // A sweeping in-place edit (`perl -pi -e … *`) is bounded but not single; locus still binds
1574 // each operand, so breadth widens the blast radius without ever admitting a system path.
1575 let files: Vec<&str> = scan.files.iter().map(String::as_str).collect();
1576 let scale = breadth_scale(&files, false);
1577 // No `execute` capability, deliberately. perl does run code, so recording one looks more
1578 // honest — but it is the wrong model here and the experiment says so: an
1579 // `executes(caller-inline)` capability denies at every band, which would take out every perl
1580 // one-liner including the in-place edits this hook exists to admit. The reason it denies is
1581 // that the `execute` rung describes running code of UNKNOWN content, and by this point the
1582 // identifier gate has already established the opposite — the one-liner reaches nothing but
1583 // pure built-ins, no I/O, no exec, no network. What remains observable is the operand reads
1584 // and writes below, and those ARE the profile. If the gate's vocabulary ever admits an
1585 // identifier with side effects, the fix belongs in the gate, not in a capability here.
1586 let caps: Vec<Capability> = if scan.in_place {
1587 files.iter().map(|f| mutates(classify_locus(f), scale, "perl -i edits the file in place")).collect()
1588 } else {
1589 reads_to_model(&files, scale)
1590 };
1591 Profile::of(caps)
1592}
1593
1594/// The outcome of parsing one `sed` short-option cluster.
1595enum SedShort<'a> {
1596 Bad,
1597 Standalone,
1598 InPlace, // -i (rest is the optional suffix)
1599 Script { consumes_next: bool }, // -e SCRIPT
1600 ScriptFile { file: Option<&'a str>, consumes_next: bool }, // -f FILE
1601 SkipValue { consumes_next: bool }, // -l N
1602}
1603
1604fn sed_cluster<'a>(cluster: &'a str, next: Option<&'a str>, boolset: &[u8]) -> SedShort<'a> {
1605 let bytes = cluster.as_bytes();
1606 let mut k = 0;
1607 while k < bytes.len() {
1608 // A flag byte is ASCII; a non-ASCII lead/continuation byte is not a flag, and slicing
1609 // `cluster[k + 1..]` at it would land mid-char and panic. Bail as unrecognized.
1610 if !bytes[k].is_ascii() {
1611 return SedShort::Bad;
1612 }
1613 let glued = &cluster[k + 1..]; // safe: bytes[k] is ASCII → k+1 is a char boundary
1614 let has = !glued.is_empty();
1615 match bytes[k] {
1616 b'i' => return SedShort::InPlace, // -i[SUFFIX]: the rest of the cluster is the suffix
1617 b'e' => return SedShort::Script { consumes_next: !has },
1618 b'f' => {
1619 let file = if has { Some(glued) } else { next };
1620 return SedShort::ScriptFile { file, consumes_next: !has };
1621 }
1622 b'l' if has || next.is_some() => return SedShort::SkipValue { consumes_next: !has }, // -l N
1623 b if boolset.contains(&b) => k += 1,
1624 _ => return SedShort::Bad,
1625 }
1626 }
1627 SedShort::Standalone
1628}
1629
1630/// Parse a `sed` long option, returning how many tokens it consumed, or `None` if unknown.
1631fn sed_long<'a>(
1632 long: &'a str,
1633 next: Option<&'a str>,
1634 in_place: &mut bool,
1635 script_from_flag: &mut bool,
1636 script_files: &mut Vec<&'a str>,
1637) -> Option<usize> {
1638 let name = long.split('=').next().unwrap_or(long);
1639 match name {
1640 "in-place" => *in_place = true, // --in-place[=SUFFIX] (glued only)
1641 "expression" => {
1642 *script_from_flag = true;
1643 return Some(if long.contains('=') { 1 } else { 2 });
1644 }
1645 "file" => {
1646 *script_from_flag = true;
1647 match long.split_once('=') {
1648 Some((_, v)) => script_files.push(v),
1649 None => {
1650 script_files.extend(next);
1651 return Some(2);
1652 }
1653 }
1654 }
1655 "quiet" | "silent" | "regexp-extended" | "null-data" | "separate" | "unbuffered"
1656 | "posix" | "help" | "version" | "debug" | "follow-symlinks" | "sandbox"
1657 | "zero-terminated" | "line-length" => {}
1658 _ => return None,
1659 }
1660 Some(1)
1661}
1662
1663#[cfg(test)]
1664mod tests {
1665 use super::*;
1666
1667 fn toks(parts: &[&str]) -> Vec<Token> {
1668 parts.iter().map(|p| Token::from_test(p)).collect()
1669 }
1670
1671 fn level(name: &str) -> &'static crate::engine::level::Level {
1672 crate::engine::authoring::default_levels()
1673 .iter()
1674 .find(|l| l.name == name)
1675 .expect("level exists")
1676 }
1677
1678 fn inert() -> &'static crate::engine::level::Level {
1679 level("paranoid")
1680 }
1681
1682 fn read_local() -> &'static crate::engine::level::Level {
1683 level("reader")
1684 }
1685
1686 /// `resolve_openssl` contract: a private-key/decrypt form reaching the MODEL classifies as
1687 /// decrypt-read (secret=reads → refused by developer, admitted only by yolo); a public/to-file/
1688 /// validate form ABSTAINS (None → openssl's legacy allow_all); a spoofed path worst-cases.
1689 #[test]
1690 fn openssl_resolver_gates_model_disclosure_only() {
1691 let (dev, yolo) = (level("developer"), level("yolo"));
1692 for parts in [
1693 &["openssl", "rsa", "-in", "priv.pem"][..],
1694 &["openssl", "rsa", "-in", "priv.pem", "-pubout", "-text"], // -text past -pubout
1695 &["openssl", "rsa", "-in", "priv.pem", "-out", "/dev/stdout"], // -out value is stdout
1696 &["openssl", "rsa", "-in", "priv.pem", "-noout", "-text"],
1697 &["openssl", "pkcs8", "-in", "priv.pem"],
1698 &["openssl", "enc", "--d", "-k", "p", "-in", "c"], // --opt alias
1699 &["openssl", "cms", "-EncryptedData_decrypt", "-in", "m"],
1700 &["openssl", "pkcs12", "-in", "f.p12", "-noenc"],
1701 ] {
1702 let p = resolve(&toks(parts)).unwrap_or_else(|| panic!("resolves: {parts:?}"));
1703 assert!(
1704 p.capabilities.iter().any(|c| c.secret.level == SecretLevel::Reads),
1705 "secret=reads: {parts:?}",
1706 );
1707 assert!(!dev.admits(&p), "developer refuses: {parts:?}");
1708 assert!(yolo.admits(&p), "yolo admits: {parts:?}");
1709 }
1710 for parts in [
1711 &["openssl", "rsa", "-in", "priv.pem", "-pubout"][..],
1712 &["openssl", "rsa", "-in", "priv.pem", "-noout"], // validate, no output
1713 &["openssl", "rsa", "-in", "enc.pem", "-out", "clean.pem"], // to a FILE, off the model
1714 &["openssl", "pkey", "-in", "pub.pem", "-pubin", "-text"], // public input → public text
1715 &["openssl", "pkcs12", "-in", "f.p12", "-nodes", "-out", "k.pem"],
1716 &["openssl", "enc", "-e", "-in", "x", "-out", "x.enc", "-k", "p"],
1717 &["openssl", "x509", "-in", "c", "-noout", "-text"],
1718 ] {
1719 assert!(resolve(&toks(parts)).is_none(), "resolver abstains (→ legacy): {parts:?}");
1720 }
1721 }
1722
1723 /// The output-destination check is FAIL-CLOSED: only a single plain-file `-out` diverts the key
1724 /// off the model. Path-normalization spellings, `/dev/stderr`, and duplicate `-out` (openssl honors
1725 /// the last) must all read as model-reaching — the sign-off review found the old device-spelling
1726 /// denylist let these through.
1727 #[test]
1728 fn openssl_output_destination_is_fail_closed() {
1729 let dev = level("developer");
1730 let reaches_model = |args: &[&str]| {
1731 let mut parts = vec!["openssl", "rsa", "-in", "priv.pem"];
1732 parts.extend_from_slice(args);
1733 // decrypt-read (secret=reads, refused by developer) ⇔ the output reached the model; a
1734 // diverted output makes the resolver ABSTAIN (None → openssl's benign legacy).
1735 match resolve(&toks(&parts)) {
1736 None => false,
1737 Some(p) => {
1738 p.capabilities.iter().any(|c| c.secret.level == SecretLevel::Reads) && !dev.admits(&p)
1739 }
1740 }
1741 };
1742 for evasion in [
1743 &["-out", "//dev/stdout"][..],
1744 &["-out", "/dev/./stdout"],
1745 &["-out", "//dev/fd/1"],
1746 &["-out", "/dev/fd//1"],
1747 &["-out=//dev/stdout"],
1748 &["-out", "/dev/stderr"],
1749 &["-out", "/foo/../dev/stdout"],
1750 &["-out", "dup.pem", "-out", "/dev/stdout"], // last-wins
1751 &["-out", "-"],
1752 // openssl's parser lets `-provider-path` swallow the `-out` token → openssl writes to
1753 // stdout; our scan then misreads the trailing flag as the filename. A dash-leading `-out`
1754 // value is the tell → fail closed.
1755 &["-provider-path", "-out", "-provider-path", "safe.pem"],
1756 &["-out", "-anything"],
1757 ] {
1758 assert!(reaches_model(evasion), "must read as model-reaching: {evasion:?}");
1759 }
1760 for diverted in [
1761 &["-out", "clean.pem"][..],
1762 &["-out", "./sub/key.pem"],
1763 &["-out", "devnotes.pem"], // "dev" prefix on a filename is not the /dev device
1764 &["-out", "/home/u/key.pem"],
1765 &["-noout"],
1766 ] {
1767 assert!(!reaches_model(diverted), "must divert off the model: {diverted:?}");
1768 }
1769 }
1770
1771 #[test]
1772 fn echo_resolves_to_a_benign_inert_profile() {
1773 let p = resolve(&toks(&["echo", "hi"])).expect("echo has a resolver");
1774 assert_eq!(p.capabilities.len(), 1);
1775 let c = &p.capabilities[0];
1776 assert_eq!(c.operation, Operation::Observe);
1777 assert_eq!(c.locus.local, LocalLocus::Process);
1778 assert_eq!(c.disclosure.audience, DisclosureAudience::LocalProcess);
1779 assert!(!c.because.is_empty(), "a structural certification cites its reason");
1780 // admitted at the *strictest* level — every facet (network/exec/secret/…) is zero
1781 assert!(inert().admits(&p), "echo is fully certified and inert-safe");
1782 }
1783
1784 #[test]
1785 fn echo_flags_do_not_change_its_profile() {
1786 let bare = resolve(&toks(&["echo", "hi"])).expect("echo");
1787 let flagged = resolve(&toks(&["echo", "-n", "-e", "hi"])).expect("echo -n -e");
1788 assert_eq!(bare, flagged);
1789 assert!(inert().admits(&flagged));
1790 }
1791
1792 #[test]
1793 fn an_unresearched_command_has_no_resolver() {
1794 assert!(resolve(&toks(UNRESOLVED_CMD)).is_none(), "unresearched → caller worst-cases");
1795 assert!(resolve(&[]).is_none(), "empty tokens");
1796 }
1797
1798 #[test]
1799 fn cat_of_a_worktree_file_is_read_local() {
1800 let p = resolve(&toks(&["cat", "./notes.md"])).expect("cat");
1801 assert!(read_local().admits(&p), "cat ./notes.md");
1802 assert!(!inert().admits(&p), "reading a real file is above inert");
1803 }
1804
1805 #[test]
1806 fn cat_of_a_path_the_shield_cannot_clear_is_denied() {
1807 // What bounds a read is the shield, not the rung: a credential store, another user's
1808 // home, a raw device, or a path we cannot resolve well enough to ASK about.
1809 for path in [
1810 "~/.ssh/id_rsa",
1811 "/etc/shadow",
1812 "$SECRET",
1813 "/var/lib/mysql/data",
1814 "/dev/mem",
1815 "/root/.bashrc",
1816 // `resolve` alone has no cwd binding, so a `..` cannot be pinned to the directory it
1817 // would land in and the unpinnable guard takes it. With a cwd (the CLI, the hook) the
1818 // same path resolves and reads — `path_policy_corpus.tsv` covers that end.
1819 "../outside",
1820 ] {
1821 let p = resolve(&toks(&["cat", path])).expect("cat");
1822 assert!(!read_local().admits(&p), "cat {path} must not be admitted as a local read");
1823 }
1824 // …while ordinary files on those same rungs now read, which is the whole point of the
1825 // shield being a NAME test rather than a rung test.
1826 for path in ["~/notes", "/etc/hosts", "/usr/bin/python3"] {
1827 let p = resolve(&toks(&["cat", path])).expect("cat");
1828 assert!(read_local().admits(&p), "cat {path} is an ordinary read");
1829 }
1830 }
1831
1832 #[test]
1833 fn machine_config_reads_but_its_credential_bearing_files_do_not() {
1834 for path in ["/etc/hosts", "/etc/os-release", "/usr/local/etc/nginx/nginx.conf"] {
1835 let p = resolve(&toks(&["cat", path])).expect("cat");
1836 assert!(read_local().admits(&p), "cat {path} is ordinary machine config");
1837 }
1838 // Same rung, different answer, and the rung is not what decided it: an auth log records
1839 // credentials outright, so it is a store however public the directory around it looks.
1840 for path in ["/var/log/auth.log", "/etc/shadow"] {
1841 let p = resolve(&toks(&["cat", path])).expect("cat");
1842 assert!(!read_local().admits(&p), "cat {path} reads credentials");
1843 }
1844 }
1845
1846 /// Distributed package CONTENT is read-admitted; its WRITE face is not.
1847 ///
1848 /// A man page, a vendored crate README, a toolchain source file: read yes, WRITE no.
1849 ///
1850 /// These used to be readable via a `package-content` region role that admitted the roots
1851 /// explicitly. That role is gone — it existed to get reads working while the bound was low,
1852 /// and it cut `/usr` into halves (`share` readable, `etc` not) that nothing justified as a
1853 /// boundary. Reads reach these paths on the general policy now.
1854 ///
1855 /// The assertion that still earns its keep is the WRITE half. Opening reads must not have
1856 /// widened what the agent can alter, and these are the paths where a write would be an
1857 /// install rather than an edit.
1858 #[test]
1859 fn package_content_is_readable_but_never_writable() {
1860 for path in [
1861 "/usr/share/doc/x",
1862 "/usr/share/man/man1/git.1",
1863 "/usr/local/share/doc/x/README",
1864 "/opt/homebrew/lib/node_modules/npm/package.json",
1865 "/Library/Developer/CommandLineTools/usr/include/stdio.h",
1866 "/nix/store/abc/share/doc/README",
1867 "~/.cargo/registry/src/idx/serde-1.0/README.md",
1868 "~/.rustup/toolchains/stable/lib/rustlib/src/core/src/lib.rs",
1869 "~/go/pkg/mod/github.com/x/y@v1/README.md",
1870 "~/.local/share/mise/installs/node/22/README.md",
1871 ] {
1872 let read = resolve(&toks(&["cat", path])).expect("cat");
1873 assert!(read_local().admits(&read), "reading package content {path} should be admitted");
1874 let write = resolve(&toks(&["rm", "-rf", path])).expect("rm");
1875 assert!(
1876 !read_local().admits(&write),
1877 "package content {path} must NOT be writable — this widens disclosure only"
1878 );
1879 }
1880 }
1881
1882 /// The credential shield outranks an admit prefix, whatever the specificity ordering says.
1883 ///
1884 /// Specificity ranks exact ≫ prefix ≫ segment, so every subtree admit outranked the shield's
1885 /// segment match: `/usr/share/.ssh/id_rsa` was APPROVED the moment package content became
1886 /// readable. A shield that a new admit node can widen is not a shield.
1887 #[test]
1888 fn an_admit_prefix_can_never_widen_the_credential_shield() {
1889 for path in [
1890 "/usr/share/.ssh/id_rsa",
1891 "/usr/local/lib/.aws/credentials",
1892 "/opt/homebrew/share/.gnupg/secring.gpg",
1893 "~/.cargo/registry/.ssh/id_ed25519",
1894 "/nix/store/x/.aws/credentials",
1895 ] {
1896 let p = resolve(&toks(&["cat", path])).expect("cat");
1897 assert!(!read_local().admits(&p), "an admit prefix widened the shield at {path}");
1898 }
1899 }
1900
1901 #[test]
1902 fn cat_stdin_is_process_scoped() {
1903 assert!(inert().admits(&resolve(&toks(&["cat"])).expect("cat")), "no operand → stdin");
1904 assert!(inert().admits(&resolve(&toks(&["cat", "-"])).expect("cat -")), "- → stdin");
1905 }
1906
1907 #[test]
1908 fn cat_reads_every_file_operand_and_one_home_read_sinks_it() {
1909 let p = resolve(&toks(&["cat", "-n", "a.txt", "src/b.rs"])).expect("cat");
1910 assert_eq!(p.capabilities.len(), 2, "-n is a flag; two files");
1911 assert!(read_local().admits(&p), "both worktree");
1912
1913 let mixed = resolve(&toks(&["cat", "a.txt", "~/.ssh/id_rsa"])).expect("cat");
1914 assert!(!read_local().admits(&mixed), "one home read sinks the whole profile");
1915 }
1916
1917 #[test]
1918 fn cat_double_dash_treats_the_rest_as_files() {
1919 let p = resolve(&toks(&["cat", "--", "-n"])).expect("cat");
1920 assert_eq!(p.capabilities.len(), 1, "-n after -- is a filename");
1921 assert!(read_local().admits(&p));
1922 }
1923
1924 #[test]
1925 fn head_tail_wc_read_like_cat_and_honor_numeric_shorthand() {
1926 use crate::engine::bridge::project;
1927 use crate::verdict::{SafetyLevel, Verdict};
1928 // worktree reads → read-local (SafeRead); home reads → denied by locus, same as cat.
1929 for cmd in [
1930 vec!["head", "README.md"],
1931 vec!["head", "-n", "5", "src/main.rs"],
1932 vec!["head", "-20", "src/main.rs"], // obsolete -NUM form must parse
1933 vec!["tail", "-f", "./log.txt"], // follow is still a bounded read
1934 vec!["tail", "-n", "100", "./log.txt"],
1935 vec!["wc", "-l", "./notes.md"],
1936 ] {
1937 assert_eq!(project(&resolve(&toks(&cmd)).expect("read")), Verdict::Allowed(SafetyLevel::SafeRead), "{cmd:?}");
1938 }
1939 // reading stdin (`-`) is process-scoped → inert, like `cat -`.
1940 assert_eq!(project(&resolve(&toks(&["wc", "-c", "-"])).expect("wc")), Verdict::Allowed(SafetyLevel::Inert), "wc stdin");
1941 for cmd in [vec!["head", "~/.ssh/id_rsa"], vec!["tail", "/etc/shadow"], vec!["wc", "-l", "$SECRET"]] {
1942 assert_eq!(project(&resolve(&toks(&cmd)).expect("read")), Verdict::Denied, "{cmd:?} beyond worktree");
1943 }
1944 // -NUM consumes no operand: `head -20 file` reads exactly `file`, not a phantom "20".
1945 let p = resolve(&toks(&["head", "-20", "src/main.rs"])).expect("head");
1946 assert_eq!(p.capabilities.len(), 1, "-20 is the count, not a file");
1947 // wc --files0-from reads an unpinnable set → worst-case → denied.
1948 assert_eq!(project(&resolve(&toks(&["wc", "--files0-from=list"])).expect("wc")), Verdict::Denied, "--files0-from");
1949 assert_eq!(project(&resolve(&toks(&["wc", "--files0-from", "-"])).expect("wc")), Verdict::Denied, "--files0-from -");
1950 // unknown flags fail closed.
1951 assert_eq!(project(&resolve(&toks(&["head", "-Z", "x"])).expect("head")), Verdict::Denied, "unknown flag");
1952 }
1953
1954 #[test]
1955 fn grep_reads_its_files_not_the_pattern() {
1956 let p = resolve(&toks(&["grep", "foo", "file.txt"])).expect("grep");
1957 assert_eq!(p.capabilities.len(), 1, "the pattern is not a file");
1958 assert!(read_local().admits(&p));
1959 }
1960
1961 #[test]
1962 fn grep_beyond_the_worktree_is_denied() {
1963 for args in [
1964 vec!["grep", "foo", "~/.ssh/config"],
1965 vec!["grep", "-r", "foo", "~"],
1966 vec!["grep", "foo", "$DIR"],
1967 ] {
1968 let p = resolve(&toks(&args)).expect("grep");
1969 assert!(!read_local().admits(&p), "{args:?}");
1970 }
1971 }
1972
1973 #[test]
1974 fn grep_recursive_is_unbounded_and_defaults_to_cwd() {
1975 let p = resolve(&toks(&["grep", "-r", "foo", "src/"])).expect("grep");
1976 assert!(p.capabilities.iter().all(|c| c.scale == Scale::Unbounded), "-r → unbounded");
1977 assert!(read_local().admits(&p), "recursive worktree search");
1978
1979 let cwd = resolve(&toks(&["grep", "-r", "foo"])).expect("grep");
1980 assert!(cwd.capabilities.iter().all(|c| c.locus.local == LocalLocus::Worktree), "cwd, not stdin");
1981 assert!(read_local().admits(&cwd));
1982 }
1983
1984 #[test]
1985 fn grep_e_and_f_supply_the_pattern_so_positionals_are_files() {
1986 // -e: pattern is the flag's value; file.txt is the only file
1987 let e = resolve(&toks(&["grep", "-e", "foo", "file.txt"])).expect("grep -e");
1988 assert_eq!(e.capabilities.len(), 1);
1989 assert!(read_local().admits(&e));
1990
1991 // -f: the pattern FILE is itself a read
1992 let f = resolve(&toks(&["grep", "-f", "patterns.txt", "file.txt"])).expect("grep -f");
1993 assert_eq!(f.capabilities.len(), 2, "patterns.txt + file.txt");
1994 assert!(read_local().admits(&f));
1995
1996 // The `-f` value is gated as a read like any other operand: an ordinary home file is
1997 // readable now, a credential store is not — and the flag is what makes it a read at all.
1998 let home = resolve(&toks(&["grep", "-f", "~/.secret-patterns", "file.txt"])).expect("grep -f");
1999 assert!(read_local().admits(&home), "an ordinary home pattern file reads");
2000 let shielded = resolve(&toks(&["grep", "-f", "~/.ssh/id_rsa", "file.txt"])).expect("grep -f");
2001 assert!(!read_local().admits(&shielded), "a shielded pattern file is still a credential read");
2002
2003 // glued short value: -fpatterns.txt and -ifpatterns.txt both name a pattern file
2004 let glued = resolve(&toks(&["grep", "-fpatterns.txt", "file.txt"])).expect("grep -f glued");
2005 assert_eq!(glued.capabilities.len(), 2, "glued -f value is still a read");
2006 // The glued spelling classifies as the spaced one does — ordinary home file reads, a
2007 // shielded one does not. What must never differ between the two forms is the ANSWER.
2008 let glued_home = resolve(&toks(&["grep", "-if~/.secrets", "x"])).expect("grep -if glued");
2009 assert!(read_local().admits(&glued_home), "glued ordinary home pattern file reads");
2010 let glued_shield = resolve(&toks(&["grep", "-if~/.ssh/id_rsa", "x"])).expect("grep -if glued");
2011 assert!(!read_local().admits(&glued_shield), "glued shielded pattern file is a credential read");
2012 }
2013
2014 #[test]
2015 fn grep_long_flags() {
2016 // --file / --file= name a pattern file grep also reads (2 caps)
2017 assert_eq!(resolve(&toks(&["grep", "--file", "p.txt", "f.txt"])).expect("grep").capabilities.len(), 2);
2018 assert_eq!(resolve(&toks(&["grep", "--file=p.txt", "f.txt"])).expect("grep").capabilities.len(), 2);
2019
2020 // --regexp supplies the pattern; the positional is the file
2021 let r = resolve(&toks(&["grep", "--regexp", "foo", "f.txt"])).expect("grep");
2022 assert_eq!(r.capabilities.len(), 1);
2023 assert!(read_local().admits(&r));
2024
2025 // a space-separated long value (`--max-count 5`) is imprecise — `5` is read as a
2026 // phantom positional — but FAIL-SAFE: still worktree-bounded, admitted at
2027 // read-local, never looser. (Precise handling needs the TOML flag schema.)
2028 let m = resolve(&toks(&["grep", "--max-count", "5", "foo", "f.txt"])).expect("grep");
2029 assert!(read_local().admits(&m), "--max-count 5 is fail-safe (imprecise)");
2030
2031 // --perl-regexp (PCRE2) runs no code — benign like any regex-engine flag; reads read-local.
2032 let pcre = resolve(&toks(&["grep", "--perl-regexp", "foo", "f"])).expect("grep");
2033 assert!(read_local().admits(&pcre), "grep --perl-regexp reads a file, it does not exec");
2034 }
2035
2036 #[test]
2037 fn grep_dash_patterns_are_search_patterns_not_flags() {
2038 // A `--`-prefixed token that is not a recognized grep flag is a SEARCH PATTERN, not
2039 // an unknown flag — grep patterns commonly look like `-->`, `---`, `--foo`. The
2040 // engine must read the file operand at read-local, matching the legacy handler, not
2041 // worst-case it.
2042 for args in [
2043 vec!["grep", "-->", "file.txt"],
2044 vec!["grep", "---", "file.txt"],
2045 vec!["grep", "--some-pattern", "file.txt"],
2046 vec!["grep", "-rn", "-->", "src/"],
2047 vec!["grep", "-i", "-r", "-n", "-->", "src/"],
2048 ] {
2049 let p = resolve(&toks(&args)).expect("grep");
2050 assert!(read_local().admits(&p), "dash-pattern should read-local: {args:?}");
2051 assert!(!inert().admits(&p), "it still reads a file: {args:?}");
2052 }
2053 // but the genuinely-dangerous long (--dereference-recursive, symlink escape) worst-cases
2054 let args = vec!["grep", "--dereference-recursive", "foo", "dir"];
2055 let p = resolve(&toks(&args)).expect("grep");
2056 assert!(!read_local().admits(&p), "dangerous long must worst-case: {args:?}");
2057 // PCRE flags now read-local (PCRE2 execs no code): -P short, --perl-regexp long, -oP combined.
2058 for args in [
2059 vec!["grep", "-P", "foo", "f"],
2060 vec!["grep", "--perl-regexp", "foo", "f"],
2061 vec!["grep", "-oP", "foo", "f"],
2062 ] {
2063 let p = resolve(&toks(&args)).expect("grep");
2064 assert!(read_local().admits(&p), "grep PCRE flag should read-local: {args:?}");
2065 }
2066 }
2067
2068 #[test]
2069 fn grep_stdin_and_standalone_flags() {
2070 assert!(inert().admits(&resolve(&toks(&["grep", "foo"])).expect("grep")), "no file → stdin");
2071 let p = resolve(&toks(&["grep", "-i", "-n", "foo", "file.txt"])).expect("grep");
2072 assert_eq!(p.capabilities.len(), 1, "-i -n standalone; foo pattern; file.txt file");
2073 assert!(read_local().admits(&p));
2074 }
2075
2076 /// The complete resolved capability for a single-capability invocation, with
2077 /// `because` cleared so the assertion is over the **facets** (not the prose).
2078 fn one_cap(cmd: &[&str]) -> Capability {
2079 let p = resolve(&toks(cmd)).expect("resolves");
2080 assert_eq!(p.capabilities.len(), 1, "{cmd:?} is a single-capability invocation");
2081 let mut c = p.capabilities[0].clone();
2082 c.because = String::new();
2083 c
2084 }
2085
2086 /// A read the credential shield cannot clear must SAY so, on the secret axis.
2087 ///
2088 /// Enumerated over the shield's own region nodes plus the unpinnable spellings, because the
2089 /// claim has to survive a new store being declared and a new reader being written. Two halves,
2090 /// and the second is the one that is easy to lose:
2091 ///
2092 /// - a path that NAMES a store (`~/.ssh/id_rsa`) — the shield can check it and it fails;
2093 /// - a path the shield cannot check AT ALL (`$VAR`, an undeclared `$(…)`, an xargs item) —
2094 /// unknowable, so possibly a credential, so refused.
2095 ///
2096 /// Today both also deny by locus, which is exactly why this guard is worth having: the locus
2097 /// cap makes the secret claim invisible in the verdict, so nothing else would notice it going
2098 /// missing — and it is the only thing that keeps `find / | xargs -I{} cat {}` refused once
2099 /// local reads open up (TODO.md).
2100 #[test]
2101 fn a_read_the_shield_cannot_clear_claims_secret() {
2102 let secret_of = |cmd: &str| {
2103 let toks: Vec<Token> = shell_words::split(cmd)
2104 .expect("splits")
2105 .into_iter()
2106 .map(Token::from_raw)
2107 .collect();
2108 resolve(&toks).map(|p| {
2109 p.capabilities.iter().any(|c| c.secret.level == crate::engine::facet::SecretLevel::Reads)
2110 })
2111 };
2112
2113 // Every declared credential store, read by the plainest reader there is.
2114 let mut checked = 0usize;
2115 for path in crate::engine::resolve::regions::declared_region_paths() {
2116 if !crate::engine::resolve::names_credential_store(&path) {
2117 continue;
2118 }
2119 // A node is a SUBTREE (`~/.ssh/`), a SEGMENT (`.ssh`) or an EXACT file
2120 // (`/etc/master.passwd`). Only the first two have anything beneath them; appending to
2121 // the exact form names a path that is not the node and is not shielded.
2122 // QUOTED, because several stores have a space in them (`~/Library/Application
2123 // Support/Firefox/`) and an unquoted probe splits into two tokens, neither of which is
2124 // the node — the guard would pass by never testing them.
2125 let probe = if path.ends_with('/') || !path.contains('/') {
2126 format!("cat '{}/probe'", path.trim_end_matches('/'))
2127 } else {
2128 format!("cat '{path}'")
2129 };
2130 if let Some(claims) = secret_of(&probe) {
2131 checked += 1;
2132 assert!(claims, "`{probe}` reads a declared credential store without claiming secret");
2133 }
2134 }
2135 assert!(checked > 0, "no credential store was probed — the guard is vacuous");
2136
2137 // Paths the shield cannot be consulted about at all.
2138 for cmd in ["cat $SOMEVAR", "cat $(hostname)", "head -c 20 ${HOME}x/$Y"] {
2139 assert_eq!(
2140 secret_of(cmd),
2141 Some(true),
2142 "`{cmd}` names a path the shield cannot check, so it must claim secret"
2143 );
2144 }
2145
2146 // ...and an ordinary, checkable read does NOT — the claim has to discriminate, or it is
2147 // just a second way of spelling "deny everything".
2148 for cmd in ["cat ./README.md", "cat src/lib.rs"] {
2149 assert_eq!(secret_of(cmd), Some(false), "`{cmd}` must not claim a secret read");
2150 }
2151 }
2152
2153 /// Golden profiles: assert **every** facet of the resolved capability for
2154 /// representative invocations. This is the "all facets covered" check (§0) — struct
2155 /// equality means a facet the resolver forgot (left at a wrong default) or set wrong
2156 /// fails the test, per command. When commands carry TOML profiles, the expected
2157 /// profile is derived from the TOML instead of hand-built here.
2158 #[test]
2159 fn golden_profiles_cover_every_facet() {
2160 // echo — the reference `structural` profile: observe, process-scoped, output to
2161 // the model, and every other axis provably zero.
2162 let mut echo = Capability::new(Operation::Observe);
2163 echo.disclosure.audience = DisclosureAudience::LocalProcess;
2164 assert_eq!(one_cap(&["echo", "hi"]), echo, "echo");
2165
2166 // cat of a worktree file — observe · worktree · content-to-model.
2167 let mut cat = Capability::new(Operation::Observe);
2168 cat.locus.local = LocalLocus::Worktree;
2169 cat.disclosure.audience = DisclosureAudience::LocalProcess;
2170 assert_eq!(one_cap(&["cat", "./notes.md"]), cat, "cat ./notes.md");
2171
2172 // cat of a plain home file resolves to `user` — the rung the ladder defines for `~` and
2173 // that, until 2026-08-15, no production path ever reached (everything under home fell
2174 // through to `unknown`/`machine`, the same rung as /etc/hosts). Still denies: `user` sits
2175 // above the reader level's cap. The rung is now HONEST, which is the prerequisite for a
2176 // level admitting a home read without also admitting the whole machine.
2177 let mut cat_home = cat.clone();
2178 cat_home.locus.local = LocalLocus::User;
2179 assert_eq!(one_cap(&["cat", "~/notes.txt"]), cat_home, "cat ~/notes.txt");
2180
2181 // An ordinary home DOTFILE is ordinary: `.zshrc` is `user`, like any other file in home.
2182 assert_eq!(one_cap(&["cat", "~/.zshrc"]), cat_home, "cat ~/.zshrc");
2183
2184 // A CREDENTIAL dotfile is not, and it is the shield that says so rather than the rung.
2185 // Excluding dotfiles from the `user` rung protected nothing — an excluded path fell through
2186 // to machine, which the read policy admits — so the shield names them instead.
2187 let mut cat_dot = cat.clone();
2188 cat_dot.locus.local = LocalLocus::Machine;
2189 cat_dot.secret.level = SecretLevel::Reads;
2190 assert_eq!(one_cap(&["cat", "~/.git-credentials"]), cat_dot, "cat ~/.git-credentials");
2191
2192 // cat of a home CREDENTIAL store: machine locus AND — the part that was missing until
2193 // 2026-08-14 — a `secret · reads` claim. The region carried `reads_secret = true` all along,
2194 // but nothing put it on the capability, so this golden recorded "reading an SSH private key
2195 // claims no secret" and the denial rested entirely on the locus cap. Both facets now, which
2196 // is what lets the locus cap be relaxed without handing over the key.
2197 let mut cat_cred = cat.clone();
2198 cat_cred.locus.local = LocalLocus::Machine;
2199 cat_cred.secret.level = SecretLevel::Reads;
2200 assert_eq!(one_cap(&["cat", "~/.ssh/id_rsa"]), cat_cred, "cat ~/.ssh/id_rsa");
2201
2202 // grep of a worktree file — like cat, bounded to the single searched file.
2203 assert_eq!(one_cap(&["grep", "foo", "file.txt"]), cat, "grep foo file.txt");
2204
2205 // grep -r — the recursive search raises scale to unbounded and nothing else.
2206 let mut grep_r = cat.clone();
2207 grep_r.scale = Scale::Unbounded;
2208 assert_eq!(one_cap(&["grep", "-r", "foo", "src/"]), grep_r, "grep -r foo src/");
2209
2210 // rm — destroy · worktree · effortful; no net/exec/secret.
2211 let mut rm = Capability::new(Operation::Destroy);
2212 rm.locus.local = LocalLocus::Worktree;
2213 rm.reversibility = Reversibility::Effortful;
2214 assert_eq!(one_cap(&["rm", "./x"]), rm, "rm ./x");
2215
2216 // mkdir — create · worktree · trivial · leaves data. A fresh dir is rmdir-removable.
2217 let mut mkdir = Capability::new(Operation::Create);
2218 mkdir.locus.local = LocalLocus::Worktree;
2219 mkdir.reversibility = Reversibility::Trivial;
2220 mkdir.persistence.level = PersistenceLevel::Data;
2221 assert_eq!(one_cap(&["mkdir", "./build"]), mkdir, "mkdir ./build");
2222
2223 // touch — the same create · worktree · trivial · data shape as mkdir.
2224 assert_eq!(one_cap(&["touch", "./new.txt"]), mkdir, "touch ./new.txt");
2225
2226 // cp -n ./a ./b — a guaranteed-non-clobbering copy is TWO capabilities:
2227 // a source read (observe, worktree, NO model disclosure) and a trivial dest create.
2228 let cp = resolve(&toks(&["cp", "-n", "./a", "./b"])).expect("cp");
2229 assert_eq!(cp.capabilities.len(), 2, "cp = source read + dest write");
2230 let mut src = Capability::new(Operation::Observe);
2231 src.locus.local = LocalLocus::Worktree; // disclosure.audience stays `none`: file→file
2232 assert_eq!(clear_because(&cp.capabilities[0]), src, "cp source read");
2233 let mut dst = Capability::new(Operation::Create);
2234 dst.locus.local = LocalLocus::Worktree;
2235 dst.reversibility = Reversibility::Trivial; // -n → cannot overwrite
2236 dst.persistence.level = PersistenceLevel::Data;
2237 assert_eq!(clear_because(&cp.capabilities[1]), dst, "cp -n dest write");
2238
2239 // mv ./a ./b — a relocation: source MUTATE (trivial, transient — the entry leaves)
2240 // + dest CREATE (recoverable overwrite). Contrast cp's source, which is an observe.
2241 let mv = resolve(&toks(&["mv", "./a", "./b"])).expect("mv");
2242 let mut mv_src = Capability::new(Operation::Mutate);
2243 mv_src.locus.local = LocalLocus::Worktree;
2244 mv_src.reversibility = Reversibility::Trivial;
2245 assert_eq!(clear_because(&mv.capabilities[0]), mv_src, "mv source relocation");
2246 let mut mv_dst = Capability::new(Operation::Create);
2247 mv_dst.locus.local = LocalLocus::Worktree;
2248 mv_dst.reversibility = Reversibility::Recoverable;
2249 mv_dst.persistence.level = PersistenceLevel::Data;
2250 assert_eq!(clear_because(&mv.capabilities[1]), mv_dst, "mv dest write");
2251
2252 // ln ./a ./b — target bridged (observe, no model disclosure) + link create (trivial,
2253 // no -f). Same facet shapes as cp -n, the point being ln reuses `observes`.
2254 let ln = resolve(&toks(&["ln", "./a", "./b"])).expect("ln");
2255 let mut ln_tgt = Capability::new(Operation::Observe);
2256 ln_tgt.locus.local = LocalLocus::Worktree;
2257 assert_eq!(clear_because(&ln.capabilities[0]), ln_tgt, "ln target bridge");
2258 let mut ln_link = Capability::new(Operation::Create);
2259 ln_link.locus.local = LocalLocus::Worktree;
2260 ln_link.reversibility = Reversibility::Trivial;
2261 ln_link.persistence.level = PersistenceLevel::Data;
2262 assert_eq!(clear_because(&ln.capabilities[1]), ln_link, "ln link create");
2263 }
2264
2265 fn clear_because(c: &Capability) -> Capability {
2266 let mut c = c.clone();
2267 c.because = String::new();
2268 c
2269 }
2270
2271 #[test]
2272 fn mkdir_creates_in_the_worktree_but_not_beyond_it() {
2273 use crate::engine::bridge::project;
2274 use crate::verdict::{SafetyLevel, Verdict};
2275 // a fresh dir is a trivial-reversibility create → write-local (SafeWrite)
2276 for cmd in [vec!["mkdir", "./build"], vec!["mkdir", "-p", "a/b/c"], vec!["mkdir", "-m", "755", "./x"]] {
2277 assert_eq!(project(&resolve(&toks(&cmd)).expect("mkdir")), Verdict::Allowed(SafetyLevel::SafeWrite), "{cmd:?}");
2278 }
2279 // outside the worktree → denied by locus
2280 for cmd in [vec!["mkdir", "/etc/evil"], vec!["mkdir", "~/newdir"], vec!["mkdir", "$HOME/x"]] {
2281 assert_eq!(project(&resolve(&toks(&cmd)).expect("mkdir")), Verdict::Denied, "{cmd:?}");
2282 }
2283 // a glued valued short (-m755) and its value must not be read as operands
2284 let g = resolve(&toks(&["mkdir", "-m755", "./x"])).expect("mkdir");
2285 assert_eq!(g.capabilities.len(), 1, "-m755 glued: only ./x is an operand");
2286 assert_eq!(g.capabilities[0].locus.local, LocalLocus::Worktree);
2287 // fail-closed on an unknown flag / no operand
2288 assert_eq!(project(&resolve(&toks(&["mkdir", "-Q", "x"])).expect("mkdir")), Verdict::Denied, "unknown flag");
2289 assert_eq!(project(&resolve(&toks(&["mkdir"])).expect("mkdir")), Verdict::Denied, "no operand");
2290 }
2291
2292 #[test]
2293 fn cp_splits_source_and_dest_loci_and_overwrite_gates_the_level() {
2294 use crate::engine::bridge::project;
2295 use crate::verdict::{SafetyLevel, Verdict};
2296
2297 // a copy is a create/overwrite, not a destroy → write-local (SafeWrite), matching
2298 // echo > config.json. Overwriting is recoverable; -n can't clobber (trivial). Both
2299 // write-local — the destroy-vs-create boundary keeps cp below rm.
2300 let plain = resolve(&toks(&["cp", "./a", "./b"])).expect("cp");
2301 assert_eq!(plain.capabilities.last().unwrap().reversibility, Reversibility::Recoverable, "dest overwrite");
2302 assert_eq!(project(&plain), Verdict::Allowed(SafetyLevel::SafeWrite), "cp ./a ./b");
2303 let nc = resolve(&toks(&["cp", "-n", "./a", "./b"])).expect("cp");
2304 assert_eq!(nc.capabilities.last().unwrap().reversibility, Reversibility::Trivial, "-n cannot clobber");
2305 assert_eq!(project(&nc), Verdict::Allowed(SafetyLevel::SafeWrite), "cp -n ./a ./b");
2306
2307 // reading a home/system SOURCE is denied by the source locus — no secret detector,
2308 // just the read locus (cp can't smuggle ~/.ssh/id_rsa into the worktree).
2309 assert_eq!(project(&resolve(&toks(&["cp", "~/.ssh/id_rsa", "./x"])).expect("cp")), Verdict::Denied, "home source");
2310 assert_eq!(project(&resolve(&toks(&["cp", "/etc/shadow", "./x"])).expect("cp")), Verdict::Denied, "system source");
2311 // writing a home/system DEST is denied by the dest locus.
2312 assert_eq!(project(&resolve(&toks(&["cp", "./x", "~/backdoor"])).expect("cp")), Verdict::Denied, "home dest");
2313 assert_eq!(project(&resolve(&toks(&["cp", "./x", "/etc/cron.d/x"])).expect("cp")), Verdict::Denied, "system dest");
2314
2315 // -t DIR makes every positional a source; the dir is the dest. All three spellings
2316 // (separate, --long=, and glued short) must parse the same way.
2317 for form in [
2318 vec!["cp", "-t", "./dest", "./a", "./b"],
2319 vec!["cp", "--target-directory=./dest", "./a", "./b"],
2320 vec!["cp", "-t./dest", "./a", "./b"], // glued short — previously worst-cased
2321 ] {
2322 let t = resolve(&toks(&form)).expect("cp -t");
2323 assert_eq!(t.capabilities.len(), 3, "{form:?}: 2 sources + 1 dest");
2324 assert_eq!(project(&t), Verdict::Allowed(SafetyLevel::SafeWrite), "{form:?}");
2325 }
2326 // a glued -t pointing outside the worktree is still denied by the dest locus.
2327 assert_eq!(project(&resolve(&toks(&["cp", "-t/etc", "./a"])).expect("cp")), Verdict::Denied, "cp -t/etc");
2328
2329 // optional-argument longs (--backup[=X], --preserve[=X]) must NOT swallow the
2330 // source operand: bare and glued forms both leave ./a a source and ./b the dest.
2331 for form in [
2332 vec!["cp", "--backup", "./a", "./b"],
2333 vec!["cp", "--preserve", "./a", "./b"],
2334 vec!["cp", "--preserve=mode", "./a", "./b"],
2335 ] {
2336 let c = resolve(&toks(&form)).expect("cp");
2337 assert_eq!(c.capabilities.len(), 2, "{form:?}: source read + dest write");
2338 assert_eq!(project(&c), Verdict::Allowed(SafetyLevel::SafeWrite), "{form:?}");
2339 }
2340
2341 // recursion raises scale to unbounded; a lone operand / unknown flag worst-cases.
2342 assert_eq!(resolve(&toks(&["cp", "-r", "./a", "./b"])).expect("cp").capabilities[0].scale, Scale::Unbounded);
2343 assert_eq!(project(&resolve(&toks(&["cp", "./only"])).expect("cp")), Verdict::Denied, "no dest");
2344 assert_eq!(project(&resolve(&toks(&["cp", "-Q", "./a", "./b"])).expect("cp")), Verdict::Denied, "unknown flag");
2345 // -t naming a dest with NO source operands is a usage error → fail closed (not a lone,
2346 // benign dest write).
2347 assert_eq!(project(&resolve(&toks(&["cp", "-t", "./dest"])).expect("cp")), Verdict::Denied, "-t no source");
2348 }
2349
2350 #[test]
2351 fn mv_relocates_within_the_worktree_and_gates_both_loci() {
2352 use crate::engine::bridge::project;
2353 use crate::verdict::{SafetyLevel, Verdict};
2354
2355 // a move within the worktree is a mutate (source) + create (dest), both trivial/
2356 // recoverable → write-local, NOT developer. Unlike rm, a move relocates, not destroys.
2357 let m = resolve(&toks(&["mv", "./a", "./b"])).expect("mv");
2358 assert_eq!(m.capabilities[0].operation, Operation::Mutate, "source is a relocation, not a destroy");
2359 assert_eq!(m.capabilities[0].reversibility, Reversibility::Trivial, "mv back");
2360 assert_eq!(project(&m), Verdict::Allowed(SafetyLevel::SafeWrite), "mv ./a ./b");
2361
2362 // both loci are gated as writes: source-out and dest-out both deny.
2363 assert_eq!(project(&resolve(&toks(&["mv", "~/.ssh/id_rsa", "./x"])).expect("mv")), Verdict::Denied, "source in home");
2364 assert_eq!(project(&resolve(&toks(&["mv", "./x", "~/exfil"])).expect("mv")), Verdict::Denied, "dest in home");
2365 // moving a worktree-TRUSTED file mutates .git → denied, even though cp of it is
2366 // allowed (cp only READS .git/config; the dest write puts cp at SafeWrite).
2367 assert_eq!(project(&resolve(&toks(&["mv", ".git/config", "./x"])).expect("mv")), Verdict::Denied, "mv .git/config");
2368 assert_eq!(project(&resolve(&toks(&["cp", ".git/config", "./x"])).expect("cp")), Verdict::Allowed(SafetyLevel::SafeWrite), "cp .git/config reads");
2369
2370 // The relocate source gates at its REBIND face, not its read face. safe-chains' own config
2371 // READS at worktree-trusted but rebinds at system-integrity (un-grantable, and above what
2372 // any level below yolo admits): `mv`ing it REMOVES it, so the removal must gate at the
2373 // rebind face; a `cp` of it only READS (worktree-trusted). Both deny by verdict, so assert
2374 // the source LOCUS to pin the face — this is the case a read-face relocate would fail open
2375 // on, and the value pins that the face is the strict one rather than plain `machine`.
2376 let cfg = "~/.config/safe-chains.toml";
2377 assert_eq!(
2378 resolve(&toks(&["mv", cfg, "./x"])).expect("mv").capabilities[0].locus.local,
2379 LocalLocus::SystemIntegrity,
2380 "mv source removal gates at the REBIND face",
2381 );
2382 assert_eq!(
2383 resolve(&toks(&["cp", cfg, "./x"])).expect("cp").capabilities[0].locus.local,
2384 LocalLocus::WorktreeTrusted,
2385 "cp source read gates at the READ face",
2386 );
2387
2388 // -t DIR and glued forms; fail-closed on unknown flag / lone operand.
2389 let t = resolve(&toks(&["mv", "-t", "./dest", "./a", "./b"])).expect("mv -t");
2390 assert_eq!(t.capabilities.len(), 3, "2 sources + 1 dest");
2391 assert_eq!(project(&resolve(&toks(&["mv", "./only"])).expect("mv")), Verdict::Denied, "no dest");
2392 assert_eq!(project(&resolve(&toks(&["mv", "-Q", "./a", "./b"])).expect("mv")), Verdict::Denied, "unknown flag");
2393 }
2394
2395 #[test]
2396 fn ln_is_cp_by_reference_and_gates_the_target_locus() {
2397 use crate::engine::bridge::project;
2398 use crate::verdict::{SafetyLevel, Verdict};
2399
2400 // a worktree link (hard or symbolic) is target-read + link-create → write-local.
2401 for cmd in [vec!["ln", "./a", "./b"], vec!["ln", "-s", "./target", "./link"]] {
2402 let p = resolve(&toks(&cmd)).expect("ln");
2403 assert_eq!(p.capabilities[0].operation, Operation::Observe, "target is a bridged read");
2404 assert_eq!(project(&p), Verdict::Allowed(SafetyLevel::SafeWrite), "{cmd:?}");
2405 }
2406 // the cp-bypass is closed: linking a SECRET/unreadable TARGET denies on the target
2407 // locus, exactly as `cp` of it would (a link would otherwise alias the secret in).
2408 assert_eq!(project(&resolve(&toks(&["ln", "~/.ssh/id_rsa", "./x"])).expect("ln")), Verdict::Denied, "hard link to home credential");
2409 assert_eq!(project(&resolve(&toks(&["ln", "-s", "/etc/shadow", "./x"])).expect("ln")), Verdict::Denied, "symlink to secret");
2410 // An ORDINARY out-of-workspace target links fine, for the same reason `cat /etc/hosts`
2411 // reads: the link aliases whatever the target could disclose, no more. What the two
2412 // asserts above pin is that the alias cannot launder a target the shield refuses.
2413 assert_eq!(project(&resolve(&toks(&["ln", "-s", "/etc/hosts", "./x"])).expect("ln")), Verdict::Allowed(SafetyLevel::SafeWrite), "symlink to ordinary system path");
2414 // writing the LINK outside the worktree denies on the link locus.
2415 assert_eq!(project(&resolve(&toks(&["ln", "-s", "./a", "~/evil"])).expect("ln")), Verdict::Denied, "link into home");
2416 // -t DIR, lone operand, unknown flag.
2417 assert_eq!(resolve(&toks(&["ln", "-t", "./dir", "./a", "./b"])).expect("ln -t").capabilities.len(), 3);
2418 assert_eq!(project(&resolve(&toks(&["ln", "./only"])).expect("ln")), Verdict::Denied, "no link name");
2419 assert_eq!(project(&resolve(&toks(&["ln", "-Q", "./a", "./b"])).expect("ln")), Verdict::Denied, "unknown flag");
2420 // -f (a clobber flag PRESENT) flips the link-create from the no-clobber default
2421 // (`trivial`) to `recoverable` — still write-local. Exercises the `clobber_flags`-present
2422 // branch of the transfer arm, the inverse of cp/mv's `no_clobber_flags`.
2423 let forced = resolve(&toks(&["ln", "-f", "./a", "./b"])).expect("ln -f");
2424 assert_eq!(project(&forced), Verdict::Allowed(SafetyLevel::SafeWrite), "ln -f worktree link");
2425 assert_eq!(forced.capabilities.last().unwrap().reversibility, Reversibility::Recoverable, "ln -f overwrites → recoverable");
2426 assert_eq!(
2427 resolve(&toks(&["ln", "./a", "./b"])).expect("ln").capabilities.last().unwrap().reversibility,
2428 Reversibility::Trivial,
2429 "ln default no-clobber → trivial",
2430 );
2431 }
2432
2433 #[test]
2434 fn dd_parses_key_value_operands_and_gates_both_sides() {
2435 use crate::engine::bridge::project;
2436 use crate::verdict::{SafetyLevel, Verdict};
2437
2438 // a worktree-to-worktree copy → write-local; params (bs/count/conv) are ignored.
2439 assert_eq!(
2440 project(&resolve(&toks(&["dd", "if=./a", "of=./b", "bs=1M", "count=10"])).expect("dd")),
2441 Verdict::Allowed(SafetyLevel::SafeWrite),
2442 "dd worktree copy",
2443 );
2444 // input from stdout (no of=) discloses the input content to the model, like cat.
2445 assert_eq!(project(&resolve(&toks(&["dd", "if=./notes"])).expect("dd")), Verdict::Allowed(SafetyLevel::SafeRead), "dd to stdout");
2446 assert_eq!(project(&resolve(&toks(&["dd"])).expect("dd")), Verdict::Allowed(SafetyLevel::Inert), "bare dd is stdin→stdout");
2447
2448 // both sides gated by locus: a home INPUT or a device/home OUTPUT denies.
2449 for cmd in [
2450 vec!["dd", "if=~/.ssh/id_rsa", "of=./x"], // read a home secret
2451 vec!["dd", "if=./x", "of=/dev/rdisk0"], // write a raw device (disk wipe)
2452 vec!["dd", "if=./x", "of=/dev/sda"],
2453 vec!["dd", "if=./x", "of=~/backup"], // write into home
2454 vec!["dd", "if=~/.ssh/id_rsa"], // home secret to stdout (→ model)
2455 ] {
2456 assert_eq!(project(&resolve(&toks(&cmd)).expect("dd")), Verdict::Denied, "{cmd:?}");
2457 }
2458 // fail-closed: a non key=value operand, or an unknown key, worst-cases.
2459 assert_eq!(project(&resolve(&toks(&["dd", "./file"])).expect("dd")), Verdict::Denied, "positional operand");
2460 assert_eq!(project(&resolve(&toks(&["dd", "exec=evil", "of=./x"])).expect("dd")), Verdict::Denied, "unknown key");
2461 }
2462
2463 #[test]
2464 fn tar_parses_dashless_bundles_and_splits_by_mode() {
2465 use crate::engine::bridge::project;
2466 use crate::verdict::{SafetyLevel, Verdict};
2467
2468 // dashless `czf` and dashed `-czf` and the long form all parse the same: a create is
2469 // members-read + archive-write → write-local for a worktree backup.
2470 for cmd in [
2471 vec!["tar", "czf", "backup.tar", "./src"],
2472 vec!["tar", "-czf", "backup.tar", "./src"],
2473 vec!["tar", "--create", "--file=backup.tar", "./src"],
2474 ] {
2475 assert_eq!(project(&resolve(&toks(&cmd)).expect("tar")), Verdict::Allowed(SafetyLevel::SafeWrite), "{cmd:?}");
2476 }
2477 // list reads the archive → read-local.
2478 assert_eq!(project(&resolve(&toks(&["tar", "tzf", "backup.tar"])).expect("tar")), Verdict::Allowed(SafetyLevel::SafeRead), "list");
2479
2480 // the bundler-exfil case (golden-set): a home member denies on the member locus,
2481 // whether the archive goes to stdout or a file.
2482 assert_eq!(project(&resolve(&toks(&["tar", "czf", "-", "~/.ssh"])).expect("tar")), Verdict::Denied, "bundle secret to stdout");
2483 assert_eq!(project(&resolve(&toks(&["tar", "czf", "out.tar", "~/.aws"])).expect("tar")), Verdict::Denied, "bundle home member");
2484 // a home/system ARCHIVE denies on the archive write locus.
2485 assert_eq!(project(&resolve(&toks(&["tar", "cf", "~/backup.tar", "./src"])).expect("tar")), Verdict::Denied, "archive into home");
2486
2487 // extract is archive-controlled (..-escapable) → worst-case, even for a benign archive.
2488 assert_eq!(project(&resolve(&toks(&["tar", "xzf", "release.tar"])).expect("tar")), Verdict::Denied, "extract");
2489 // `tar cf backup.tar` with no members creates an empty archive — a benign worktree
2490 // write, so SafeWrite (not a fail-closed case).
2491 assert_eq!(project(&resolve(&toks(&["tar", "cf", "backup.tar"])).expect("tar")), Verdict::Allowed(SafetyLevel::SafeWrite), "empty archive");
2492 // fail-closed: an unmodeled value option (-C), no mode, an empty profile, a bad letter.
2493 assert_eq!(project(&resolve(&toks(&["tar", "-C", "/etc", "xf", "a.tar"])).expect("tar")), Verdict::Denied, "-C unmodeled");
2494 assert_eq!(project(&resolve(&toks(&["tar", "c"])).expect("tar")), Verdict::Denied, "create to stdout, no members");
2495 assert_eq!(project(&resolve(&toks(&["tar", "zf", "backup.tar"])).expect("tar")), Verdict::Denied, "no mode letter");
2496 }
2497
2498 /// perl's two gates are independent and BOTH are required: the identifier allowlist decides
2499 /// whether the one-liner is inert, locus decides whether the operands may be touched. The
2500 /// second was missing — `perl -pe 's/a/b/' /etc/shadow` auto-approved, because the handler
2501 /// judged only the code — so the read cases below are the regression, and the `-i` cases are
2502 /// the capability the missing gate had been standing in for.
2503 /// Parse `line` and ask what a `$( … )` around it would evaluate to.
2504 #[cfg(test)]
2505 fn sub_locus(line: &str) -> Option<LocalLocus> {
2506 let script = crate::cst::parse(line).expect("parses");
2507 match substitution_claim(&script)? {
2508 SubClaim::Locus(l) => Some(l),
2509 // An atom names no locus, so these callers — which ask "which rung does this value
2510 // point at" — correctly see nothing.
2511 SubClaim::Atom => None,
2512 }
2513 }
2514
2515 /// No output claim survives `--help` / `--version`, for EVERY command that declares one.
2516 ///
2517 /// Enumerated over the registry rather than spot-checked on seq, because the failure is a
2518 /// property of what those flags DO — replace the command's data output with prose — and so it
2519 /// applies to every claim, including ones added later. The prose routinely carries paths and
2520 /// URLs: GNU `seq --help` prints `<https://www.gnu.org/software/coreutils/>` under an `atom`
2521 /// claim asserting no word holds a separator.
2522 ///
2523 /// Missed by hand-probing because macOS ships BSD seq, whose help is terse and slash-free —
2524 /// the local install disagreed with the upstream the claim is written against.
2525 #[test]
2526 fn no_output_claim_survives_a_help_or_version_flag() {
2527 let mut probed = 0usize;
2528 for (scope, spec) in crate::registry::output_claims() {
2529 // A claim gated on a required flag is only ever live WITH it, so the probe has to carry
2530 // it — otherwise the assertion holds for the boring reason and guards nothing.
2531 let scope = match spec.requires.first() {
2532 Some(required) => format!("{scope} {required}"),
2533 None => scope,
2534 };
2535 for flag in ["--help", "--version"] {
2536 let line = format!("{scope} {flag}");
2537 let Some(script) = crate::cst::parse(&line) else { continue };
2538 probed += 1;
2539 assert!(
2540 substitution_claim(&script).is_none(),
2541 "`{line}` still carries an output claim, but --help/--version print prose \
2542 rather than the command's data, so the claim does not describe it"
2543 );
2544 }
2545 }
2546 assert!(probed > 0, "nothing declares an output claim; this guard would be vacuous");
2547 }
2548
2549 /// A sub-scoped claim must survive every TRUSTED spelling of its command, and no other.
2550 ///
2551 /// The walker keys on the registry name, so it has to be handed the CANONICALIZED one — the
2552 /// same key the command-level lookup gets. Given the raw first word instead, `/usr/bin/git diff
2553 /// --name-only` silently lost the claim that bare `git` kept: one operation, two spellings, two
2554 /// answers, which is the false-deny class the flag-form guards exist to kill.
2555 ///
2556 /// The other half is that this must NOT extend trust: `./git` is a worktree binary that may not
2557 /// be git at all, and `trusted_command_path` is what keeps it claimless.
2558 #[test]
2559 fn a_sub_claim_follows_every_trusted_spelling_of_its_command() {
2560 let bare = sub_locus("git diff --name-only");
2561 assert!(bare.is_some(), "precondition: bare `git diff --name-only` should carry a claim");
2562 for spelling in ["/usr/bin/git", "/opt/homebrew/bin/git"] {
2563 assert_eq!(
2564 sub_locus(&format!("{spelling} diff --name-only")),
2565 bare,
2566 "`{spelling} diff --name-only` disagrees with the bare spelling",
2567 );
2568 }
2569 for untrusted in ["./git", "/tmp/git", "../git"] {
2570 assert_eq!(
2571 sub_locus(&format!("{untrusted} diff --name-only")),
2572 None,
2573 "`{untrusted}` is not a trusted path to git and must earn no output claim",
2574 );
2575 }
2576 }
2577
2578 /// A claim gated on `requires` must be DEAD without its flag. `git diff` prints a patch and
2579 /// `jj diff` a diff; only `--name-only` turns either into a list of paths, so the ungated
2580 /// invocation must stay unpinnable. Without this, `requires` could be silently ignored and the
2581 /// claim would widen every invocation of the sub.
2582 #[test]
2583 fn a_required_flag_is_necessary_for_its_claim() {
2584 let mut probed = 0usize;
2585 for (scope, spec) in crate::registry::output_claims() {
2586 if spec.requires.is_empty() {
2587 continue;
2588 }
2589 probed += 1;
2590 let Some(script) = crate::cst::parse(&scope) else { continue };
2591 assert_eq!(
2592 substitution_claim(&script).map(|_| ()),
2593 None,
2594 "`{scope}` carries an output claim without any of {:?}, which the declaration says \
2595 are required for the output to be paths at all",
2596 spec.requires,
2597 );
2598 // ...and LIVE with it, or the declaration describes nothing.
2599 for required in &spec.requires {
2600 let line = format!("{scope} {required}");
2601 let Some(script) = crate::cst::parse(&line) else { continue };
2602 assert!(
2603 substitution_claim(&script).is_some(),
2604 "`{line}` carries no output claim, but `{required}` is declared as one of the \
2605 flags that makes the claim hold"
2606 );
2607 }
2608 }
2609 assert!(probed > 0, "nothing declares `requires`; this guard would be vacuous");
2610 }
2611
2612 /// Fail-closed, enumerated over the REGISTRY: every `[command.output]` claim is probed on a HOT
2613 /// root, and must never report a locus below what reading that root reports. This is the
2614 /// fail-open the whole feature risks — a missed search root means the substitution is admitted
2615 /// at worktree while the command actually reaches `/etc`. The `match` is EXHAUSTIVE, so a new
2616 /// `OutputLocus` variant must state how it is probed or the build breaks.
2617 ///
2618 /// Red→green: drop the glued-value branch from `candidate_roots` and
2619 /// `fd --search-path=/etc x` stops reporting machine.
2620 #[test]
2621 fn every_output_claim_is_bounded_by_its_roots() {
2622 use crate::registry::types::OutputLocus;
2623
2624 let mut probed = 0usize;
2625 for (scope, spec) in crate::registry::output_claims() {
2626 probed += 1;
2627 // A `requires`-gated claim is only live with its flag, so every probe below carries it.
2628 // `name` is therefore the invocation PREFIX, not just a command name.
2629 let name = match spec.requires.first() {
2630 Some(required) => format!("{scope} {required}"),
2631 None => scope.clone(),
2632 };
2633 let name = name.as_str();
2634 match spec.locus_from {
2635 // An `atom` claim is that no output word can contain a separator, so the check is
2636 // the claim: run the command's OWN examples and read what they would print. A
2637 // command whose examples emit a `/` is mis-declared, and the consequence is not
2638 // subtle — the confinement layer treats the value as unable to leave its
2639 // component, so a separator would let it walk anywhere the prefix can reach.
2640 //
2641 // Enumerated over the registry rather than spot-checked, because the next command
2642 // to declare `atom` gets this for free, which is the only way a data-driven claim
2643 // stays honest as the data grows.
2644 // An `atom` claim cannot be checked the way the others can. The rest are probed by
2645 // asking the resolver where a HOT root lands, but "no output word contains a
2646 // separator" is a fact about the TOOL, and the only mechanical way to confirm it
2647 // would be to run the command — which a unit test must not do for arbitrary
2648 // registry entries.
2649 //
2650 // So this is a REVIEW gate, not a proof: the claim has to be argued per command,
2651 // and a new declaration fails here until someone does that and adds it. What makes
2652 // it worth having is the failure mode it guards — an atom is treated as unable to
2653 // leave its path component, so a tool that CAN emit a `/` would let the value walk
2654 // anywhere its prefix reaches. `seq`'s argument is in its TOML: numbers only, with
2655 // the three flags that inject caller text (`-s`, `-t`, `-f`) in `invalidated_by`.
2656 //
2657 // The soundness of the confinement ITSELF — that a separator-free value beside
2658 // literal text cannot escape — is proved separately, by
2659 // `a_flanked_atom_never_moves_where_the_write_lands`.
2660 OutputLocus::Atom => {
2661 const ARGUED: &[&str] = &["seq"];
2662 assert!(
2663 ARGUED.contains(&name),
2664 "command '{name}' declares `locus_from = \"atom\"`, which asserts that no \
2665 word it prints can contain a separator. That cannot be checked here \
2666 without running the command, so it must be argued in the command's TOML \
2667 (what it prints, and which flags reshape it into `invalidated_by`) and \
2668 then listed in ARGUED."
2669 );
2670 }
2671 OutputLocus::Operands => {
2672 // `~` is here as a named case, not just inside HOT_PATHS, because it is the
2673 // spelling that actually got through: it carries neither `/` nor `.`, so the
2674 // path-SHAPE test skipped it and `cat $(fd pat ~)` swept the home directory
2675 // while reporting worktree.
2676 let hot_roots: Vec<&str> =
2677 HOT_PATHS.iter().copied().chain(["~", "~/.ssh"]).collect();
2678 for hot in hot_roots {
2679 // Every spelling a root can arrive in: bare operand, separated flag value,
2680 // glued long value, glued short value. Missing any is the fail-open.
2681 for line in [
2682 format!("{name} pat {hot}"),
2683 format!("{name} --base-directory {hot} pat"),
2684 format!("{name} --search-path={hot} pat"),
2685 format!("{name} -E{hot} pat"),
2686 ] {
2687 let got = sub_locus(&line);
2688 let want = read_locus(hot);
2689 assert!(
2690 got.is_none_or(|l| l >= want),
2691 "`{line}`: reported {got:?}, but reading {hot} is {want:?}",
2692 );
2693 }
2694 }
2695 // A substitution in a root slot is unknowable — no claim.
2696 assert_eq!(sub_locus(&format!("{name} pat $(hostname)")), None, "{name}: nested sub");
2697 }
2698 // Its output is the cwd, which takes no root operand; the guard that matters is
2699 // that it does not somehow report BELOW the cwd's own locus.
2700 OutputLocus::Cwd => {
2701 assert_eq!(sub_locus(name), Some(read_locus(".")), "{name}: bare");
2702 }
2703 // A filter only filters while it has no file operand — given one it prints that
2704 // file's CONTENTS, which are not paths and must void the claim.
2705 OutputLocus::Stdin => {
2706 for hot in HOT_PATHS {
2707 assert_eq!(
2708 sub_locus(&format!("{name} {hot}")),
2709 None,
2710 "{name}: a file operand makes it print contents, not paths",
2711 );
2712 }
2713 }
2714 }
2715 // Every flag the command declares as invalidating must actually void the claim.
2716 for flag in &spec.invalidated_by {
2717 let line = format!("{name} {flag} pat");
2718 assert_eq!(sub_locus(&line), None, "`{line}`: {flag} is declared invalidating");
2719 }
2720 }
2721 assert!(probed > 0, "no command declares [command.output] — the guard is vacuous");
2722 // The enumeration must reach SUB-scoped claims, not just command-scoped ones. Without this
2723 // the extension is silently self-defeating: a walker that stopped at the top level would
2724 // make every `[command.sub.output]` skip the probes above and the guard would still be
2725 // green, reporting coverage it does not have.
2726 assert!(
2727 crate::registry::output_claims().iter().any(|(scope, _)| scope.contains(' ')),
2728 "no sub-scoped output claim was enumerated, so `[command.sub.output]` is unprobed",
2729 );
2730 }
2731
2732 /// Enumerated over the REGISTRY: a flag declared `valued` on `[command.output]` means "this
2733 /// value is not a path", and BOTH spellings must agree. Handling only the separated form denied
2734 /// `head --lines=5` while `head -n 5` passed — one operation, two spellings, two answers, which
2735 /// is the false-deny class the flag-form equivalence guards exist to kill.
2736 #[test]
2737 fn output_valued_flags_agree_across_spellings() {
2738 use crate::registry::types::OutputLocus;
2739 let mut checked = 0usize;
2740 for (scope, spec) in crate::registry::output_claims() {
2741 // As above: a `requires`-gated claim is only live with its flag, so the probe carries it.
2742 let name = match spec.requires.first() {
2743 Some(required) => format!("{scope} {required}"),
2744 None => scope.clone(),
2745 };
2746 let name = name.as_str();
2747 for flag in &spec.valued {
2748 // An invalidating flag voids the claim by design, so it is not a spelling case.
2749 if spec.invalidated_by.contains(flag) {
2750 continue;
2751 }
2752 // Two things are load-bearing about the probe shape, and without EITHER the
2753 // guard silently passes a broken skip:
2754 // - a PRODUCER stage, because a lone `stdin` command walks back off the end of
2755 // the pipeline and reports `None` whether or not it saw a file operand, hiding
2756 // the difference entirely;
2757 // - a TRAILING OPERAND, because a glued form that over-skips (swallowing the
2758 // next argument as if it were a separated value) is indistinguishable from a
2759 // correct one until there is a next argument to lose.
2760 // Together they expose the over-skip as a file operand going missing — which for
2761 // a `stdin` claim is a fail-open: contents get classified as if they were paths.
2762 let producer = match spec.locus_from {
2763 OutputLocus::Stdin => "fd a app/ | ",
2764 _ => "",
2765 };
2766 for tail in ["", " /etc/hosts"] {
2767 let separated = sub_locus(&format!("{producer}{name} {flag} 5{tail}"));
2768 let glued = sub_locus(&format!("{producer}{name} {flag}=5{tail}"));
2769 assert_eq!(
2770 separated, glued,
2771 "{name} {flag} (tail {tail:?}): separated {separated:?}, glued {glued:?}",
2772 );
2773 checked += 1;
2774 }
2775 }
2776 }
2777 assert!(checked > 0, "no output claim declares a valued flag — the guard is vacuous");
2778 }
2779
2780 /// The default is unpinnable. A command that has NOT been researched for its output locus must
2781 /// keep the opaque sentinel, so the feature can only ever widen through a deliberate
2782 /// declaration — never by a command happening to look read-only.
2783 #[test]
2784 fn undeclared_commands_get_no_output_claim() {
2785 // `echo` is the load-bearing case: as safe as a command gets, and its output is whatever
2786 // the caller typed. If it ever acquires a claim, `cat $(echo /etc/shadow)` opens up.
2787 for line in ["echo /etc/shadow", "hostname", "cat ./f", "ls", "git rev-parse --show-toplevel"] {
2788 assert_eq!(sub_locus(line), None, "`{line}` must have no output claim");
2789 }
2790 assert!(!crate::is_safe_command("cat $(echo /etc/shadow)"), "echo must not bound its output");
2791 }
2792
2793 #[test]
2794 fn perl_i_worktree_vs_system() {
2795 use crate::engine::bridge::project;
2796 use crate::verdict::{SafetyLevel, Verdict};
2797
2798 // No -i: the operands are content reads, gated by READ locus.
2799 let read = resolve(&toks(&["perl", "-pe", "s/x/y/", "./foo"])).expect("perl");
2800 assert_eq!(read.capabilities[0].operation, Operation::Observe, "no -i → read");
2801 assert_eq!(project(&read), Verdict::Allowed(SafetyLevel::SafeRead), "perl read");
2802
2803 // -i flips them to in-place MUTATES, admitted only in the worktree.
2804 let edit = resolve(&toks(&["perl", "-pi", "-e", "s/x/y/", "./foo"])).expect("perl");
2805 assert_eq!(edit.capabilities[0].operation, Operation::Mutate, "-i → in-place write");
2806 assert_eq!(project(&edit), Verdict::Allowed(SafetyLevel::SafeWrite), "perl -i worktree");
2807 let glued = resolve(&toks(&["perl", "-i.bak", "-pe", "s/x/y/", "./foo"])).expect("perl");
2808 assert_eq!(glued.capabilities[0].operation, Operation::Mutate, "-i.bak is still in-place");
2809
2810 // THE REGRESSION: an inert one-liner does not license the operand. It is gated exactly as
2811 // `cat` and `sed` gate theirs — so a credential store or an unpinnable path denies, while
2812 // an ordinary machine file (asserted below) reads.
2813 for cmd in [
2814 vec!["perl", "-pe", "s/a/b/", "/etc/shadow"],
2815 vec!["perl", "-ne", "print", "~/.ssh/id_rsa"],
2816 vec!["perl", "-pe", "s/a/b/", "$CONFIG"], // unpinnable
2817 vec!["perl", "-pi", "-e", "s/a/b/", "/etc/hosts"],
2818 vec!["perl", "-pi", "-e", "s/a/b/", "~/.bashrc"],
2819 vec!["perl", "-pi", "-e", "s/a/b/", "../outside"],
2820 ] {
2821 assert_eq!(project(&resolve(&toks(&cmd)).expect("perl")), Verdict::Denied, "{cmd:?} must deny");
2822 }
2823 // The WRITE half stays put: reading /etc/passwd is fine, rewriting it in place is not.
2824 assert_eq!(
2825 project(&resolve(&toks(&["perl", "-pe", "s/a/b/", "/etc/passwd"])).expect("perl")),
2826 Verdict::Allowed(SafetyLevel::SafeRead),
2827 "an inert one-liner over an ordinary machine file is a read"
2828 );
2829
2830 // Opaque code is refused whatever the operand: no `-e` means the first operand is a script
2831 // file we cannot read, and a failed identifier gate means the one-liner left the vocabulary.
2832 for cmd in [
2833 vec!["perl", "./script.pl"],
2834 vec!["perl", "-n", "./file.txt"],
2835 vec!["perl", "-e", "system(\"rm -rf /\")", "./foo"],
2836 vec!["perl", "-pie", "s/a/b/", "./foo"], // ambiguous suffix spelling — unmodeled
2837 ] {
2838 assert_eq!(project(&resolve(&toks(&cmd)).expect("perl")), Verdict::Denied, "{cmd:?} must deny");
2839 }
2840
2841 // A worktree-scoped sweep is bounded, not single — scored honestly, still admitted.
2842 let glob = resolve(&toks(&["perl", "-pi", "-e", "s/a/b/", "*"])).expect("perl");
2843 assert_eq!(glob.capabilities[0].scale, Scale::Bounded, "a glob is a bounded blast radius");
2844 assert_eq!(project(&glob), Verdict::Allowed(SafetyLevel::SafeWrite), "perl -i * (worktree)");
2845 }
2846
2847 #[test]
2848 fn sed_i_flips_read_to_write_and_locus_stops_system_wide_damage() {
2849 use crate::engine::bridge::project;
2850 use crate::verdict::{SafetyLevel, Verdict};
2851
2852 // -i turns the file operands from reads into in-place MUTATES.
2853 let read = resolve(&toks(&["sed", "s/x/y/", "./foo"])).expect("sed");
2854 assert_eq!(read.capabilities[0].operation, Operation::Observe, "no -i → read");
2855 assert_eq!(project(&read), Verdict::Allowed(SafetyLevel::SafeRead), "sed read");
2856 let edit = resolve(&toks(&["sed", "-i", "s/x/y/", "./foo"])).expect("sed");
2857 assert_eq!(edit.capabilities[0].operation, Operation::Mutate, "-i → in-place write");
2858 assert_eq!(project(&edit), Verdict::Allowed(SafetyLevel::SafeWrite), "sed -i worktree");
2859
2860 // THE CONCERN: a stray system-wide `sed -i` is stopped by LOCUS — a system, home, or
2861 // unpinnable target denies whatever the scale. Damage needs a target above the
2862 // worktree, and every such target is denied.
2863 for cmd in [
2864 vec!["sed", "-i", "s/a/b/", "/etc/passwd"],
2865 vec!["sed", "-i", "s/a/b/", "/etc/hosts"],
2866 vec!["sed", "-i", "s/a/b/", "~/.bashrc"],
2867 vec!["sed", "-i", "s/a/b/", "$CONFIG"], // unpinnable
2868 vec!["sed", "-i", "s/a/b/", "../outside"], // escapes the worktree
2869 vec!["sed", "-i", "-e", "s/a/b/", "/etc/x"], // -e script, system file
2870 ] {
2871 assert_eq!(project(&resolve(&toks(&cmd)).expect("sed")), Verdict::Denied, "{cmd:?} must deny");
2872 }
2873
2874 // A worktree-scoped sweep IS allowed — bounded, recoverable, your own project files.
2875 // The glob/multi-operand blast radius is scored as `bounded`, still write-local.
2876 let glob = resolve(&toks(&["sed", "-i", "s/a/b/", "*"])).expect("sed");
2877 assert_eq!(glob.capabilities[0].scale, Scale::Bounded, "a glob is a bounded blast radius");
2878 assert_eq!(project(&glob), Verdict::Allowed(SafetyLevel::SafeWrite), "sed -i * (worktree)");
2879 assert_eq!(project(&resolve(&toks(&["sed", "-i", "s/a/b/", "a", "b", "c"])).expect("sed")), Verdict::Allowed(SafetyLevel::SafeWrite), "multi-file");
2880
2881 // -i.bak (optional glued suffix) still parses as in-place.
2882 assert_eq!(project(&resolve(&toks(&["sed", "-i.bak", "s/a/b/", "./foo"])).expect("sed")), Verdict::Allowed(SafetyLevel::SafeWrite), "-i.bak");
2883 // -f runs a script file we can't inspect (its e/w/r commands are invisible) → denied, like
2884 // `awk -f`, `bash script.sh`, mlr `--load`.
2885 assert_eq!(project(&resolve(&toks(&["sed", "-f", "script.sed", "./foo"])).expect("sed")), Verdict::Denied, "-f script file unanalyzable");
2886 // a home file read (no -i) still denies by locus, like cat.
2887 assert_eq!(project(&resolve(&toks(&["sed", "s/a/b/", "~/.ssh/id_rsa"])).expect("sed")), Verdict::Denied, "read home secret");
2888 assert_eq!(project(&resolve(&toks(&["sed", "-Q", "./foo"])).expect("sed")), Verdict::Denied, "unknown flag");
2889 }
2890
2891 #[test]
2892 fn sed_exec_command_is_worst_cased_at_parity_with_legacy() {
2893 use crate::engine::bridge::project;
2894 use crate::verdict::Verdict;
2895 // The `e` command/modifier executes text as a shell command (RCE). The resolver must
2896 // worst-case it — flag parsing alone treated the script as opaque and let it through.
2897 for cmd in [
2898 vec!["sed", "s/test/touch tmp/e", "file"], // s///e modifier
2899 vec!["sed", "-e", "s/x/cmd/e", "file"], // via -e
2900 vec!["sed", "s/x/cmd/ew", "file"], // e flag BEFORE the greedy w flag
2901 vec!["sed", "1e", "file"], // address + e
2902 vec!["sed", "e"], // bare e
2903 vec!["sed", "-e", "e"],
2904 vec!["sed", "1e reboot", "file"], // address + e WITH a command argument
2905 vec!["sed", "p;e id", "file"], // e after a `;` separator
2906 ] {
2907 assert_eq!(project(&resolve(&toks(&cmd)).expect("sed")), Verdict::Denied, "{cmd:?}: exec must deny");
2908 }
2909 // `s/x/cmd/we` is NOT here: `w` is greedy-to-EOL, so `we` writes to a file named `e` (a
2910 // local SafeWrite), not w-then-e exec. `sed '1e reboot'` — the former residual gap — is now
2911 // caught by the sed sub-parser (`scan_sed`).
2912 }
2913
2914 /// HP-19 #1 (engine): `classify_locus` now resolves relative paths against the ambient
2915 /// cwd/root. With no context it falls back to relative-is-worktree (status quo); under a
2916 /// `cd /etc` context the same operands resolve to `/etc/*` and deny.
2917 #[test]
2918 fn classify_locus_resolves_relative_operands_against_the_cwd_context() {
2919 use crate::engine::bridge::project;
2920 use crate::pathctx::PathCtx;
2921 use crate::verdict::{SafetyLevel, Verdict};
2922
2923 // No context → relative is worktree (fallback), and a sweeping edit is write-local.
2924 for p in ["*", "passwd", "config"] {
2925 assert_eq!(classify_locus(p), LocalLocus::Worktree, "{p}: no ctx → worktree");
2926 }
2927 assert_eq!(project(&resolve(&toks(&["sed", "-i", "s/a/b/", "*"])).expect("sed")), Verdict::Allowed(SafetyLevel::SafeWrite), "no ctx: sed -i *");
2928
2929 // Context says the shell is in /etc → relative operands are /etc/* → machine → deny.
2930 let _g = crate::pathctx::enter(PathCtx { cwd: Some("/etc".into()), root: Some("/home/u/proj".into()), ..Default::default() });
2931 for p in ["*", "hosts", "config", "cron.d"] {
2932 assert_eq!(classify_locus(p), LocalLocus::Machine, "{p}: cwd=/etc → machine");
2933 }
2934 // /etc/passwd is the identity substrate: its WRITE face worst-cases to system-integrity
2935 // (above machine → above local-admin), even reached as a relative operand from cwd=/etc.
2936 assert_eq!(classify_locus("passwd"), LocalLocus::SystemIntegrity, "passwd: cwd=/etc → system-integrity");
2937 assert_eq!(project(&resolve(&toks(&["sed", "-i", "s/a/b/", "*"])).expect("sed")), Verdict::Denied, "cwd=/etc: sed -i * denied");
2938 assert_eq!(project(&resolve(&toks(&["dd", "if=./x", "of=passwd"])).expect("dd")), Verdict::Denied, "cwd=/etc: dd of=passwd denied");
2939 assert_eq!(project(&resolve(&toks(&["cp", "./payload", "config"])).expect("cp")), Verdict::Denied, "cwd=/etc: cp denied");
2940 }
2941
2942 #[test]
2943 fn touch_creates_in_the_worktree_and_gates_the_reference_path() {
2944 use crate::engine::bridge::project;
2945 use crate::verdict::{SafetyLevel, Verdict};
2946 for cmd in [
2947 vec!["touch", "./new.txt"],
2948 vec!["touch", "-c", "existing"],
2949 vec!["touch", "-r", "ref.txt", "./out"], // worktree reference: a read + a create, both worktree
2950 vec!["touch", "-d", "-1 day", "./out"], // -d takes a DATE literal (not a path), dash-leading value
2951 ] {
2952 assert_eq!(project(&resolve(&toks(&cmd)).expect("touch")), Verdict::Allowed(SafetyLevel::SafeWrite), "{cmd:?}");
2953 }
2954 // `-r REF` reads REF's timestamp — a path-flag gated by REF's locus. A worktree ref is a
2955 // worktree read (allowed, 2 caps), but an out-of-workspace reference DENIES (it would
2956 // otherwise be an mtime/existence oracle for arbitrary paths).
2957 let p = resolve(&toks(&["touch", "-r", "ref.txt", "./out"])).expect("touch");
2958 assert_eq!(p.capabilities.len(), 2, "./out create + ref.txt read");
2959 assert!(p.capabilities.iter().any(|c| c.operation == Operation::Observe), "the -r reference is a read");
2960 // An ordinary home reference is an ordinary read of its mtime; a credential store's is
2961 // not, and neither is a path the shield cannot be asked about.
2962 assert_eq!(project(&resolve(&toks(&["touch", "-r", "~/.bashrc", "./out"])).expect("touch")), Verdict::Allowed(SafetyLevel::SafeWrite), "ordinary home reference");
2963 assert_eq!(project(&resolve(&toks(&["touch", "-r", "/etc/shadow", "./out"])).expect("touch")), Verdict::Denied, "system reference");
2964 assert_eq!(project(&resolve(&toks(&["touch", "--reference=/etc/shadow", "./out"])).expect("touch")), Verdict::Denied, "long glued reference");
2965 assert_eq!(project(&resolve(&toks(&["touch", "--reference", "/etc/shadow", "./out"])).expect("touch")), Verdict::Denied, "long spaced reference");
2966 // -d's dash-leading date literal is NOT a path and is NOT gated.
2967 assert_eq!(project(&resolve(&toks(&["touch", "-d", "-1 day", "/tmp/../etc/x"])).expect("touch")), Verdict::Denied, "operand still gated");
2968 // beyond the worktree, and fail-closed cases
2969 assert_eq!(project(&resolve(&toks(&["touch", "/etc/x"])).expect("touch")), Verdict::Denied, "system path");
2970 assert_eq!(project(&resolve(&toks(&["touch", "-Z", "x"])).expect("touch")), Verdict::Denied, "unknown flag");
2971 assert_eq!(project(&resolve(&toks(&["touch"])).expect("touch")), Verdict::Denied, "no operand");
2972 }
2973
2974 #[test]
2975 fn worst_case_is_denied_even_by_a_permissive_yolo_shaped_level() {
2976 use crate::engine::level::{Clause, Level, OrdBound};
2977 // a yolo-shaped level: allow anything local up to `machine`, minus a destroy corner
2978 let yolo = Level::new("yolo-ish")
2979 .allowing(Clause {
2980 local_locus: Some(OrdBound::at_most(LocalLocus::Machine)),
2981 ..Default::default()
2982 })
2983 .denying(Clause {
2984 operation: Some(vec![Operation::Destroy]),
2985 reversibility: Some(OrdBound::at_least(Reversibility::Irreversible)),
2986 ..Default::default()
2987 });
2988 let wc = Profile::of(vec![Capability::worst("test")]);
2989 assert!(!yolo.admits(&wc), "worst_case (locus=kernel) exceeds even a machine-capped allow");
2990 }
2991
2992 #[test]
2993 fn rm_within_the_worktree_projects_to_developer_but_beyond_it_denies() {
2994 use crate::engine::bridge::project;
2995 use crate::verdict::{SafetyLevel, Verdict};
2996 // `developer` admits destroy WITHIN the worktree (golden-set decision 2), even
2997 // recursive/effortful; it maps to the legacy SafeWrite ceiling.
2998 for cmd in [
2999 vec!["rm", "./stale.log"],
3000 vec!["rm", "-rf", "./node_modules"],
3001 vec!["rm", "a", "b", "c"],
3002 vec!["rm", "--interactive=always", "./x"], // optional-arg long: must not worst-case
3003 ] {
3004 let p = resolve(&toks(&cmd)).expect("rm resolves");
3005 assert!(p.capabilities.iter().all(|c| c.operation == Operation::Destroy), "{cmd:?} destroys");
3006 assert_eq!(project(&p), Verdict::Allowed(SafetyLevel::SafeWrite), "{cmd:?} → developer");
3007 }
3008 // Deletion that reaches beyond the worktree (home/system) is above `developer`,
3009 // denied by locus — no clause admits a machine/user-scoped destroy.
3010 for cmd in [vec!["rm", "-rf", "/"], vec!["rm", "-rf", "~/notes"], vec!["rm", "/etc/hosts"]] {
3011 assert_eq!(project(&resolve(&toks(&cmd)).expect("rm")), Verdict::Denied, "{cmd:?} beyond worktree");
3012 }
3013 }
3014
3015 /// End-to-end: `rm -rf /` resolves to the `destroy · irreversible · unbounded` corner and
3016 /// is the one thing even a maximally-permissive yolo refuses — by facet, not by name.
3017 /// Everything one facet away stays yolo-admitted.
3018 #[test]
3019 fn rm_rf_root_is_the_one_thing_even_yolo_denies() {
3020 let yolo = level("yolo");
3021 let root = resolve(&toks(&["rm", "-rf", "/"])).expect("rm");
3022 assert_eq!(root.capabilities[0].reversibility, Reversibility::Irreversible, "rm -rf / is irreversible");
3023 assert_eq!(root.capabilities[0].scale, Scale::Unbounded);
3024 assert!(!yolo.admits(&root), "rm -rf / denied even at yolo");
3025 assert!(!yolo.admits(&resolve(&toks(&["rm", "-rf", "~/notes"])).expect("rm")), "rm -rf ~ likewise");
3026 // adjacent-by-one-facet stays yolo-allowed:
3027 assert!(yolo.admits(&resolve(&toks(&["rm", "-rf", "./node_modules"])).expect("rm")), "recoverable worktree");
3028 assert!(yolo.admits(&resolve(&toks(&["rm", "/etc/hosts"])).expect("rm")), "single (bounded) system delete");
3029 }
3030
3031 /// Phase 1 end-to-end: a subcommand tagged `profile = "<archetype>"` resolves (through the
3032 /// nested `<resource> <action>` grammar) to that archetype's exact static capability, so its
3033 /// verdict is DERIVED from facets, not hand-marked. Untagged sibling subs leave the engine
3034 /// abstaining (→ legacy).
3035 #[test]
3036 fn a_subcommand_profile_resolves_to_its_archetype() {
3037 let p = resolve(&toks(&["koyeb", "apps", "delete", "myapp"])).expect("koyeb apps delete resolves");
3038 assert_eq!(p.capabilities.len(), 1);
3039 assert_eq!(
3040 &p.capabilities[0],
3041 crate::engine::archetype::archetype("remote-destroy-recoverable").unwrap(),
3042 "the sub resolves to its declared archetype's capability",
3043 );
3044 // a differently-tagged action gets a different archetype
3045 let create = resolve(&toks(&["koyeb", "apps", "create", "myapp"])).expect("resolves");
3046 assert_eq!(create.capabilities[0].operation, Operation::Create);
3047 // an untagged read sub: no profile, no command behavior → the engine abstains (legacy decides)
3048 assert!(resolve(&toks(&["koyeb", "apps", "list"])).is_none(), "untagged sub → engine abstains");
3049 }
3050
3051 /// Per-flag escalation (Phase 1 layer): a dangerous flag ADDS a capability to the sub's profile,
3052 /// and the level algebra takes the max — so a benign base + a destructive flag lands at the
3053 /// flag's tier. `git push` is vcs-sync (network-admin); `git push --force` adds
3054 /// remote-destroy-irreversible and escalates past it, to yolo.
3055 #[test]
3056 fn an_escalating_flag_adds_a_capability_and_raises_the_tier() {
3057 let destroy = crate::engine::archetype::archetype("remote-destroy-irreversible").unwrap();
3058 // The vcs-sync base now carries the destination's provenance (exposure §4): `origin` and the
3059 // bare `--force` form (default remote) are both `established`.
3060 let vcs_sync = {
3061 let mut c = crate::engine::archetype::archetype("vcs-sync").unwrap().clone();
3062 c.locus.provenance = Provenance::Established;
3063 c
3064 };
3065
3066 let base = resolve(&toks(&["git", "push", "origin", "main"])).expect("git push resolves");
3067 assert_eq!(base.capabilities, vec![vcs_sync.clone()], "base is vcs-sync, established destination");
3068
3069 let forced = resolve(&toks(&["git", "push", "--force"])).expect("resolves");
3070 assert_eq!(forced.capabilities.len(), 2);
3071 assert!(forced.capabilities.contains(&vcs_sync) && forced.capabilities.contains(destroy),
3072 "--force ADDS remote-destroy-irreversible to the vcs-sync base");
3073
3074 // the escalation MATTERS at the level layer: network-admin admits the base but not the
3075 // forced push; the flag pushed it up to yolo.
3076 let network_admin = level("network-admin");
3077 assert!(network_admin.admits(&base), "git push is network-admin");
3078 assert!(!network_admin.admits(&forced), "git push --force escalated past network-admin");
3079 assert!(level("yolo").admits(&forced), "and lands at yolo");
3080
3081 // the -f short form escalates identically
3082 assert_eq!(resolve(&toks(&["git", "push", "-f"])).unwrap().capabilities.len(), 2);
3083 }
3084
3085 /// Destination-trust (exposure §4): `git push`'s send TARGET is classified onto
3086 /// `locus.provenance`, and an `ext::` command-transport worst-cases as RCE. The one resolver
3087 /// that makes the `locus.provenance` facet actually bind to a command.
3088 #[test]
3089 fn git_push_destination_provenance_is_classified() {
3090 use crate::engine::bridge::project;
3091 use crate::verdict::Verdict;
3092
3093 let prov = |cmd: &[&str]| resolve(&toks(cmd)).expect("push resolves").capabilities[0].locus.provenance;
3094
3095 // bare (configured default) and a bare remote NAME → established (a prior deliberate act).
3096 assert_eq!(prov(&["git", "push"]), Provenance::Established, "bare push = default remote");
3097 assert_eq!(prov(&["git", "push", "origin", "main"]), Provenance::Established, "remote name");
3098 // a flag before the target doesn't hide it.
3099 assert_eq!(prov(&["git", "push", "--force", "origin"]), Provenance::Established, "flag then name");
3100 // spelled inline → literal (visible but injectable): URL, scp-path, filesystem path.
3101 assert_eq!(prov(&["git", "push", "https://h/x.git", "main"]), Provenance::Literal, "url");
3102 assert_eq!(prov(&["git", "push", "git@h:x.git"]), Provenance::Literal, "scp-style");
3103 assert_eq!(prov(&["git", "push", "/srv/mirror.git"]), Provenance::Literal, "path");
3104 // a variable / substitution → opaque (unreviewable).
3105 assert_eq!(prov(&["git", "push", "$REMOTE"]), Provenance::Opaque, "variable");
3106
3107 // network-admin admits established + literal, refuses opaque; the ext:: transport is RCE.
3108 let net = level("network-admin");
3109 assert!(net.admits(&resolve(&toks(&["git", "push", "origin"])).unwrap()), "established at network-admin");
3110 assert!(net.admits(&resolve(&toks(&["git", "push", "https://h/x.git"])).unwrap()), "literal URL at network-admin");
3111 assert!(!net.admits(&resolve(&toks(&["git", "push", "$REMOTE"])).unwrap()), "opaque above network-admin");
3112 // ext::<cmd> runs a local command — worst-cased, denied below yolo.
3113 assert_eq!(project(&resolve(&toks(&["git", "push", "ext::sh"])).unwrap()), Verdict::Denied, "ext:: is RCE");
3114 assert!(!net.admits(&resolve(&toks(&["git", "push", "ext::sh"])).unwrap()), "ext:: not at network-admin");
3115
3116 // `--repo=<dest>` OVERRIDES the positional (the fail-open the review found: `--repo=ext::sh`
3117 // slipping past a benign `origin`). Glued and space forms; a bare remote name still allows.
3118 assert_eq!(project(&resolve(&toks(&["git", "push", "--repo=ext::sh", "origin"])).unwrap()), Verdict::Denied, "--repo=ext:: is RCE");
3119 assert!(!net.admits(&resolve(&toks(&["git", "push", "--repo", "$VAR", "origin"])).unwrap()), "--repo $VAR is opaque");
3120 assert_eq!(prov(&["git", "push", "--repo=https://h/x.git", "main"]), Provenance::Literal, "--repo URL is literal");
3121 assert!(net.admits(&resolve(&toks(&["git", "push", "--repo=upstream", "main"])).unwrap()), "--repo=<remote name> is established");
3122 }
3123
3124 /// The `data-export` resolver: a bulk remote export (`supabase db dump`) is a read that
3125 /// auto-approves to stdout, but its OUTPUT-FILE form (`-f path`) adds a SECOND, path-gated local
3126 /// write — a dump to the worktree stays local (SafeWrite) while one to a system path gates on
3127 /// locus (denied), and the glued short `-f/path` spelling can't slip that gate. The unbounded
3128 /// `scale` records the volume without itself gating the read. See `behavioral-taxonomy-exposure.md`.
3129 #[test]
3130 fn data_export_gates_its_output_file() {
3131 use crate::engine::bridge::project;
3132 use crate::verdict::{SafetyLevel, Verdict};
3133
3134 // to stdout: the bulk remote read alone — one capability, auto-approves as a read.
3135 let stdout = resolve(&toks(&["supabase", "db", "dump", "--data-only"])).expect("dump resolves");
3136 assert_eq!(stdout.capabilities.len(), 1, "stdout dump = the remote read only");
3137 assert_eq!(stdout.capabilities[0].scale, Scale::Unbounded, "a dump records its volume");
3138 assert_eq!(project(&stdout), Verdict::Allowed(SafetyLevel::SafeRead), "bulk read auto-approves");
3139
3140 // -f into the worktree: read + a worktree write → still auto-approves (SafeWrite).
3141 for cmd in [
3142 vec!["supabase", "db", "dump", "-f", "dump.sql"],
3143 vec!["supabase", "db", "dump", "--file=dump.sql", "--data-only"],
3144 ] {
3145 let p = resolve(&toks(&cmd)).expect("dump resolves");
3146 assert_eq!(p.capabilities.len(), 2, "{cmd:?}: the remote read + a local write");
3147 assert_eq!(project(&p), Verdict::Allowed(SafetyLevel::SafeWrite), "{cmd:?}");
3148 }
3149
3150 // -f onto a system path: the write gates on locus → denied, in every spelling — space,
3151 // glued `=`, AND the glued short `-f/path` that mustn't be a bypass.
3152 for cmd in [
3153 vec!["supabase", "db", "dump", "-f", "/etc/passwd"],
3154 vec!["supabase", "db", "dump", "--file=/etc/passwd"],
3155 vec!["supabase", "db", "dump", "-f/etc/passwd"],
3156 ] {
3157 assert_eq!(project(&resolve(&toks(&cmd)).expect("resolves")), Verdict::Denied, "{cmd:?} writes a system path");
3158 }
3159 }
3160
3161 /// `sudo`/`doas` elevate the wrapped command's AUTHORITY — the resolver that finally gives
3162 /// `local-admin` something to admit. `sudo <safe cmd>` = a root op (above every user-authority
3163 /// band); `sudo rm -rf /` stays the catastrophe corner; `-u`/`-i` and unknown options fail up.
3164 #[test]
3165 fn sudo_elevates_the_wrapped_commands_authority() {
3166 use crate::engine::bridge::project;
3167 use crate::verdict::Verdict;
3168 let (dev, local, net, yolo) = (level("developer"), level("local-admin"), level("network-admin"), level("yolo"));
3169
3170 // sudo cat ./notes — a ROOT read. Authority lifts to root; every band below local-admin pins
3171 // authority=user, so it lands at local-admin (and yolo), NOT developer/network-admin.
3172 let read = resolve(&toks(&["sudo", "cat", "./notes.md"])).expect("sudo cat resolves");
3173 assert_eq!(read.capabilities[0].authority, Authority::Root, "authority lifted to root");
3174 assert!(!dev.admits(&read) && !net.admits(&read), "a root op is above the user-authority bands");
3175 assert!(local.admits(&read) && yolo.admits(&read), "a root read is local-admin");
3176
3177 // benign flag clusters are skipped without losing the inner command (space + glued values too).
3178 assert_eq!(resolve(&toks(&["sudo", "-EH", "cat", "./x"])).unwrap().capabilities[0].authority, Authority::Root);
3179 assert_eq!(resolve(&toks(&["sudo", "-n", "-p", "pw", "cat", "./x"])).unwrap().capabilities[0].authority, Authority::Root);
3180
3181 // bumping authority does NOT rescue the catastrophe corner.
3182 assert_eq!(project(&resolve(&toks(&["sudo", "rm", "-rf", "/"])).unwrap()), Verdict::Denied, "sudo rm -rf / denied everywhere");
3183
3184 // -u (run as another user) → other-user authority → yolo-only (identity confusion tops the ladder).
3185 let other = resolve(&toks(&["sudo", "-u", "bob", "cat", "./x"])).expect("sudo -u resolves");
3186 assert_eq!(other.capabilities[0].authority, Authority::OtherUser, "-u = run as other user");
3187 assert!(!local.admits(&other) && yolo.admits(&other), "other-user is yolo-only");
3188 assert_eq!(resolve(&toks(&["sudo", "-ubob", "cat", "./x"])).unwrap().capabilities[0].authority, Authority::OtherUser, "glued -ubob");
3189
3190 // -i / -s / -e launch a root shell or editor → arbitrary code, worst-cased.
3191 assert_eq!(project(&resolve(&toks(&["sudo", "-i"])).unwrap()), Verdict::Denied, "sudo -i is a root shell");
3192 assert!(!local.admits(&resolve(&toks(&["sudo", "-s", "bash"])).unwrap()), "root shell not local-admin");
3193
3194 // an UNRECOGNIZED sudo option fails closed.
3195 assert_eq!(project(&resolve(&toks(&["sudo", "--nonsense", "cat", "./x"])).unwrap()), Verdict::Denied, "unknown option worst-cases");
3196
3197 // an UNRESOLVED inner → None, so the caller's legacy fallback denies (never looser than bare).
3198 assert!(resolve(&toks(&["sudo", "totallyunknowncmd", "x"])).is_none(), "unresolved inner → legacy denies");
3199 // `sudo` with no command → None (legacy decides).
3200 assert!(resolve(&toks(&["sudo", "-v"])).is_none(), "no inner command");
3201
3202 // doas is the same wrapper.
3203 assert_eq!(resolve(&toks(&["doas", "cat", "./x"])).unwrap().capabilities[0].authority, Authority::Root);
3204
3205 // A valued short flag at end-of-input has no next-token value: `i` overshot the slice and
3206 // PANICKED (fail-open hook crash, found by the parse fuzzer). Now clamps → no inner → None.
3207 assert!(resolve(&toks(&["doas", "-r"])).is_none(), "doas -r must not panic");
3208 assert!(resolve(&toks(&["sudo", "-u"])).is_none(), "sudo -u must not panic");
3209 assert_eq!(crate::command_verdict("doas -r"), Verdict::Denied, "doas -r denied, not crashed");
3210
3211 // NEVER LOOSER: at the default band every `sudo …` is denied (root authority is auto-approved
3212 // by NO level below local-admin), exactly like the legacy classifier, which denies sudo whole.
3213 for cmd in ["sudo cat ./notes.md", "sudo rm -rf ./build", "sudo -EH cat ./x", "sudo -u bob ls"] {
3214 assert_eq!(crate::command_verdict(cmd), Verdict::Denied, "`{cmd}` must not auto-approve at the default band");
3215 }
3216 }
3217
3218 /// systemctl — the first REAL command user of the `local-privileged` archetype. Read subs stay
3219 /// SafeRead (any band); service-management subs land at local-admin; and `sudo systemctl restart`
3220 /// (previously fail-closed, since systemctl's inner sub was unmodeled) now resolves to local-admin.
3221 #[test]
3222 fn systemctl_service_management_is_local_admin() {
3223 use crate::verdict::Verdict;
3224 let (dev, local, net, yolo) = (level("developer"), level("local-admin"), level("network-admin"), level("yolo"));
3225
3226 // service management → local-privileged: local-admin and yolo admit; developer/network-admin don't.
3227 for sub in ["restart", "start", "stop", "enable", "disable", "mask", "daemon-reload", "kill"] {
3228 let p = resolve(&toks(&["systemctl", sub, "nginx"])).unwrap_or_else(|| panic!("systemctl {sub} resolves"));
3229 assert!(!dev.admits(&p) && !net.admits(&p), "systemctl {sub} is above developer/network-admin");
3230 assert!(local.admits(&p) && yolo.admits(&p), "systemctl {sub} is local-admin");
3231 }
3232 // reads stay auto-approvable (SafeRead), a power-state sub denies by omission (not modeled).
3233 assert!(crate::command_verdict("systemctl status nginx").is_allowed(), "status reads");
3234 assert_eq!(crate::command_verdict("systemctl reboot"), Verdict::Denied, "reboot omitted → denied");
3235
3236 // the fail-closed case is fixed: `sudo systemctl restart` resolves the inner sub (already root).
3237 let sudo_restart = resolve(&toks(&["sudo", "systemctl", "restart", "nginx"])).expect("resolves");
3238 assert!(local.admits(&sudo_restart), "sudo systemctl restart is local-admin");
3239 assert_eq!(crate::command_verdict("sudo systemctl restart nginx"), Verdict::Denied, "still not auto-approved at default");
3240 }
3241
3242 /// The flag-conditional-archetype resolver (the `when_absent` mechanism, npm exemplar):
3243 /// `npm ci --ignore-scripts` is a PINNED, scripts-off install → `local-install-pinned`
3244 /// (developer). Dropping `--ignore-scripts` escalates it to `supply-chain-build` (yolo — runs
3245 /// fetched code at install). `npm install`/`i` are FLOATING → always `supply-chain-build`. This
3246 /// is the pattern the package-manager fan-out replicates.
3247 #[test]
3248 fn npm_install_is_classified_by_pinning_and_scripts_off() {
3249 let (dev, yolo) = (level("developer"), level("yolo"));
3250
3251 // pinned (ci) + scripts-off → developer.
3252 let safe = resolve(&toks(&["npm", "ci", "--ignore-scripts"])).expect("npm ci --ignore-scripts");
3253 assert!(dev.admits(&safe), "pinned, scripts-off ci is developer");
3254
3255 // pinned but scripts-ON → the --ignore-scripts ABSENCE escalates to supply-chain-build → yolo.
3256 let scripts_on = resolve(&toks(&["npm", "ci"])).expect("npm ci");
3257 assert!(!dev.admits(&scripts_on), "ci without --ignore-scripts runs fetched code → above developer");
3258 assert!(yolo.admits(&scripts_on), "and lands at yolo");
3259
3260 // floating installs → supply-chain-build regardless of flags.
3261 for c in [&["npm", "install"][..], &["npm", "install", "left-pad"], &["npm", "i", "react"], &["npm", "install", "--ignore-scripts"]] {
3262 let p = resolve(&toks(c)).unwrap_or_else(|| panic!("{c:?} resolves"));
3263 assert!(!dev.admits(&p) && yolo.admits(&p), "{c:?}: floating install → supply-chain (yolo)");
3264 }
3265 }
3266
3267 #[test]
3268 fn rm_flag_and_operand_fail_closed() {
3269 use crate::engine::bridge::project;
3270 use crate::verdict::Verdict;
3271 for cmd in [
3272 vec!["rm", "--no-preserve-root", "-rf", "/"], // enables rm -rf / → must worst-case
3273 vec!["rm", "-Z", "x"], // unknown flag
3274 vec!["rm"], // no operand (usage error)
3275 vec!["./rm", "x"], // basename spoof
3276 ] {
3277 assert_eq!(project(&resolve(&toks(&cmd)).expect("resolves")), Verdict::Denied, "{cmd:?}");
3278 }
3279 }
3280
3281 #[test]
3282 fn rm_scale_and_force_semantics() {
3283 let cap = |cmd: &[&str]| resolve(&toks(cmd)).expect("rm").capabilities[0].clone();
3284 assert_eq!(cap(&["rm", "./x"]).scale, Scale::Single);
3285 assert_eq!(cap(&["rm", "a", "b"]).scale, Scale::Bounded, "multiple operands");
3286 assert_eq!(cap(&["rm", "*.log"]).scale, Scale::Bounded, "a glob");
3287 assert_eq!(cap(&["rm", "-r", "./dir"]).scale, Scale::Unbounded, "recursive");
3288 // -f only suppresses prompts — it does NOT raise reversibility for rm
3289 assert_eq!(cap(&["rm", "./x"]).reversibility, Reversibility::Effortful);
3290 assert_eq!(cap(&["rm", "-f", "./x"]).reversibility, Reversibility::Effortful, "-f is not a raiser");
3291 }
3292
3293 #[test]
3294 fn a_resolvable_name_from_a_non_standard_path_worst_cases() {
3295 // ./cat, /tmp/cat, ~/bin/grep may be impostors → worst-case, not certified safe
3296 for cmd in [vec!["./cat", "x"], vec!["/tmp/cat", "x"], vec!["~/bin/grep", "foo", "f"]] {
3297 let p = resolve(&toks(&cmd)).expect("resolvable name");
3298 assert!(!read_local().admits(&p), "{cmd:?} from a non-standard path must worst-case");
3299 }
3300 // bare names and standard bin paths resolve normally
3301 assert!(read_local().admits(&resolve(&toks(&["cat", "./notes.md"])).expect("cat")));
3302 assert!(read_local().admits(&resolve(&toks(&["/usr/bin/cat", "./notes.md"])).expect("cat")));
3303 // a non-resolvable command from any path → None (the engine doesn't claim it)
3304 assert!(resolve(&toks(&["/tmp/mytool", "x"])).is_none());
3305 }
3306
3307 #[test]
3308 fn unrecognized_flags_worst_case_fail_closed() {
3309 for cmd in [
3310 vec!["cat", "-Z", "./x"],
3311 vec!["cat", "--wat", "./x"],
3312 vec!["grep", "-Q", "foo", "f"], // unknown grep short char (-Z is benign: --null)
3313 vec!["grep", "-R", "foo", "dir"], // -R follows symlinks → escapes locus (M2)
3314 ] {
3315 let p = resolve(&toks(&cmd)).expect("resolver");
3316 assert!(!inert().admits(&p) && !read_local().admits(&p), "{cmd:?} must worst-case");
3317 }
3318 // recognized-benign flags still resolve normally
3319 assert!(read_local().admits(&resolve(&toks(&["cat", "-nA", "./x"])).expect("cat")));
3320 assert!(read_local().admits(&resolve(&toks(&["grep", "-rin", "foo", "src/"])).expect("grep")));
3321 }
3322
3323 use proptest::prelude::*;
3324
3325 /// The content-transfer commands: every one moves/bridges content between a source and
3326 /// a destination operand, so BOTH roles must be locus-gated. Extend this list as
3327 /// `install`/`dd`/`rsync`/`tar` land — a resolver that forgets to gate a role then fails
3328 /// the property below (the `ln` cp-bypass class, §HP re: capability laundering).
3329 const TRANSFER_CMDS: &[&str] = &["cp", "mv", "ln"];
3330
3331 /// A sensitive path that must never be laundered through a transfer command, in any
3332 /// role. Covers each locus rung above the worktree AND the two unpinnable markers.
3333 const HOT_PATHS: &[&str] = &["/etc/shadow", "~/.ssh/id_rsa", "$SECRET", "../out", "~/.aws"];
3334
3335 proptest! {
3336 /// No capability laundering: a hot path in EITHER operand role of a transfer command
3337 /// denies — you can neither pull a secret in (`cp ~/.ssh/id_rsa ./x`) nor push one
3338 /// out (`cp ./x /etc/cron.d/y`). This is the STRICT property that catches an ignored
3339 /// operand; plain locus-monotonicity does not, because ignoring a role leaves the
3340 /// verdict unchanged, and unchanged is "not looser".
3341 #[test]
3342 fn transfer_commands_gate_both_operand_roles(
3343 cmd in prop::sample::select(TRANSFER_CMDS),
3344 hot in prop::sample::select(HOT_PATHS),
3345 ) {
3346 use crate::engine::bridge::project;
3347 use crate::verdict::Verdict;
3348 let hot_source = resolve(&toks(&[cmd, hot, "./safe"])).expect("resolves");
3349 prop_assert_eq!(project(&hot_source), Verdict::Denied, "{} hot SOURCE ({})", cmd, hot);
3350 let hot_dest = resolve(&toks(&[cmd, "./safe", hot])).expect("resolves");
3351 prop_assert_eq!(project(&hot_dest), Verdict::Denied, "{} hot DEST ({})", cmd, hot);
3352 }
3353
3354 /// The sudo/doas flag walk must never panic (a panic in the resolver is a fail-OPEN hook
3355 /// crash) nor depend on evaluation order, for ANY flag salad — crucially a valued short flag
3356 /// at end-of-input (`doas -r`, `sudo -u`), which consumes a "next token" that isn't there and
3357 /// pushed `i` one past the end. That `&tokens[i..]` out-of-range is what the parse fuzzer hit
3358 /// on `doas -r`; uniform command sampling never lands on this resolver often enough to find it.
3359 #[test]
3360 fn sudo_family_flag_walk_never_panics(
3361 head in prop::sample::select(vec!["sudo", "doas"]),
3362 args in prop::collection::vec(
3363 prop_oneof![
3364 Just("-u".to_string()), Just("-r".to_string()), Just("-g".to_string()),
3365 Just("-i".to_string()), Just("-EH".to_string()), Just("-uEH".to_string()),
3366 Just("-uroot".to_string()), Just("--".to_string()), Just("-".to_string()),
3367 Just("root".to_string()), Just("cat".to_string()), Just("./x".to_string()),
3368 "-[a-zA-Z]{1,4}",
3369 ],
3370 0..6,
3371 ),
3372 ) {
3373 let parts: Vec<&str> =
3374 std::iter::once(head).chain(args.iter().map(String::as_str)).collect();
3375 let a = resolve(&toks(&parts)).is_some();
3376 let b = resolve(&toks(&parts)).is_some();
3377 prop_assert_eq!(a, b, "nondeterministic verdict for {:?}", parts);
3378 }
3379 }
3380
3381 /// The exact roster of commands classified by `[command.behavior]`. Pinning it turns a
3382 /// DROPPED or typo'd behavior block into a test failure: `TomlCommand` deliberately lacks
3383 /// `deny_unknown_fields` (it must tolerate `[[trusted]]`), so a mistyped top-level key
3384 /// (`behaviour = …`) is silently dropped and the command reverts to its PERMISSIVE legacy
3385 /// fallback — a fail-open the enumeration guards can't see (they `continue` on `None`). This
3386 /// roster is that missing tripwire, and the guards below derive their non-vacuity floors from
3387 /// it so the floors track reality. Update deliberately when porting a command. `echo` is a
3388 /// none-role printer; `dd`/`tar`/`sed` are hook commands; `grep` is a hook + pattern-then-read;
3389 /// the other 10 are the plain positional coreutils.
3390 const EXPECTED_BEHAVIOR_COMMANDS: &[&str] = &[
3391 "cat", "cp", "dd", "echo", "grep", "head", "ln", "mkdir", "mv", "perl", "rm", "rmdir",
3392 "sed", "tail", "tar", "touch", "wc",
3393 ];
3394
3395 /// The behavior roster is exactly `EXPECTED_BEHAVIOR_COMMANDS` — no command silently lost its
3396 /// `[command.behavior]` (fail-open) and none was added without being pinned. Red→green: delete
3397 /// one command's behavior block and this fails.
3398 #[test]
3399 fn behavior_command_roster_is_pinned() {
3400 use std::collections::BTreeSet;
3401 let actual: BTreeSet<&str> = crate::registry::toml_command_names()
3402 .into_iter()
3403 .filter(|n| crate::registry::command_behavior(n).is_some())
3404 .collect();
3405 let expected: BTreeSet<&str> = EXPECTED_BEHAVIOR_COMMANDS.iter().copied().collect();
3406 assert_eq!(
3407 actual, expected,
3408 "behavior-command roster drifted — a [command.behavior] block was added, dropped, or \
3409 typo'd. A dropped block silently reverts the command to its fail-open legacy path."
3410 );
3411 }
3412
3413 /// Hot-path probes for a `[command.behavior]` command, keyed on its declared operand role
3414 /// (the parallel of `probes` for the `Operands` enum). A `@` in a slot is the hot path.
3415 fn behavior_probes(cmd: &str, role: crate::registry::types::PositionalRole, hot: &str) -> Vec<Vec<String>> {
3416 use crate::registry::types::PositionalRole;
3417 let inv = |slots: &[&str]| -> Vec<String> {
3418 std::iter::once(cmd.to_string()).chain(slots.iter().map(|s| s.replace('@', hot))).collect()
3419 };
3420 match role {
3421 PositionalRole::None => vec![],
3422 PositionalRole::Read | PositionalRole::Write => vec![inv(&["@"])],
3423 PositionalRole::PatternThenRead => vec![inv(&["PATTERN", "@"])],
3424 PositionalRole::Transfer => vec![inv(&["@", "./safe"]), inv(&["./safe", "@"])],
3425 }
3426 }
3427
3428 /// Hot-path probes for a HOOK command, whose irregular operand syntax `behavior_probes`
3429 /// (positional roles) can't express — dd's `key=value`, tar's dashless mode bundles, sed's
3430 /// script. The `match` is EXHAUSTIVE, so a new `BehaviorHook` variant must declare its probe
3431 /// rows here or the build breaks — restoring the "new entry covered automatically" property the
3432 /// deleted `every_touched_path_operand_is_gated` had via `Operands::Custom`. `@` = the hot slot.
3433 fn hook_probes(hook: crate::registry::types::BehaviorHook, cmd: &str, hot: &str) -> Vec<Vec<String>> {
3434 use crate::registry::types::BehaviorHook;
3435 let inv = |slots: &[&str]| -> Vec<String> {
3436 std::iter::once(cmd.to_string()).chain(slots.iter().map(|s| s.replace('@', hot))).collect()
3437 };
3438 match hook {
3439 // grep is pattern-then-read → already probed by `behavior_probes`; no extra rows.
3440 BehaviorHook::Grep => vec![],
3441 BehaviorHook::Dd => vec![inv(&["if=@", "of=./safe"]), inv(&["if=./safe", "of=@"])],
3442 BehaviorHook::Tar => vec![inv(&["cf", "./s.tar", "@"]), inv(&["cf", "@", "./s"]), inv(&["tf", "@"])],
3443 BehaviorHook::Sed => vec![inv(&["s/x/y/", "@"]), inv(&["-i", "s/x/y/", "@"])],
3444 BehaviorHook::Perl => {
3445 vec![inv(&["-pe", "s/x/y/", "@"]), inv(&["-pi", "-e", "s/x/y/", "@"])]
3446 }
3447 }
3448 }
3449
3450 /// Every RECURSIVE transfer refuses a source above the workspace.
3451 ///
3452 /// The shield tests a name; a recursive source is a root standing for files nobody named, so
3453 /// it cannot be cleared. `cp ~/.ssh/id_rsa ./x` was refused all along and `cp -r ~ ./x` was
3454 /// not — same theft, one flag apart — because the claim that makes a read unclearable was
3455 /// written twice and only one copy learned about sweeps.
3456 ///
3457 /// Enumerated from the registry rather than listed, so a transfer command that declares
3458 /// `recursive_flags` later is covered the day it lands and does not need anyone to remember
3459 /// this test exists.
3460 #[test]
3461 fn every_recursive_transfer_refuses_a_source_above_the_workspace() {
3462 use crate::engine::bridge::project;
3463 use crate::verdict::Verdict;
3464
3465 let mut covered = 0usize;
3466 for name in crate::registry::toml_command_names() {
3467 let Some(b) = crate::registry::command_behavior(name) else { continue };
3468 let Some(t) = b.transfer.as_ref() else { continue };
3469 for flag in &t.recursive_flags {
3470 covered += 1;
3471 let hot = vec![name.to_string(), flag.clone(), "~".to_string(), "./dest".to_string()];
3472 let refs: Vec<&str> = hot.iter().map(String::as_str).collect();
3473 if let Some(p) = resolve(&toks(&refs)) {
3474 assert_eq!(project(&p), Verdict::Denied, "{hot:?}: a recursive read of home is unclearable");
3475 }
3476 // Non-vacuity: the same command and flag over the WORKTREE must still work, or
3477 // this would pass on a build that simply refused every recursive copy.
3478 let ok = vec![name.to_string(), flag.clone(), "./src".to_string(), "./dest".to_string()];
3479 let refs: Vec<&str> = ok.iter().map(String::as_str).collect();
3480 if let Some(p) = resolve(&toks(&refs)) {
3481 assert_ne!(project(&p), Verdict::Denied, "{ok:?}: a worktree recursive copy must still allow");
3482 }
3483 }
3484 }
3485 assert!(covered >= 3, "only {covered} recursive transfer flags swept — the registry lookup is wrong");
3486 }
3487
3488 /// Fail-closed, enumerated over the REGISTRY: every `[command.behavior]` command denies an
3489 /// operand on a hot path (a secret, home, system, or unpinnable locus), AND a write-role
3490 /// command denies a write into the worktree-trusted rung (`.git/config`). Restores and
3491 /// generalizes `every_touched_path_operand_is_gated` for the declarative path — a command
3492 /// ported off Rust is covered automatically. Red→green: make `resolve_behavior` skip
3493 /// `classify_locus` and this fails on the first probe.
3494 #[test]
3495 fn every_behavior_command_gates_hot_operands() {
3496 use crate::engine::bridge::project;
3497 use crate::registry::types::PositionalRole;
3498 use crate::verdict::Verdict;
3499
3500 let deny = |cmd: &[String], why: &str| {
3501 let refs: Vec<&str> = cmd.iter().map(String::as_str).collect();
3502 let profile = resolve(&toks(&refs)).expect("behavior command resolves");
3503 assert_eq!(project(&profile), Verdict::Denied, "{cmd:?}: {why}");
3504 };
3505
3506 let mut path_bearing = 0usize;
3507 let mut hook_bearing = 0usize;
3508 for name in crate::registry::toml_command_names() {
3509 let Some(b) = crate::registry::command_behavior(name) else { continue };
3510 if !matches!(b.positionals, PositionalRole::None) {
3511 path_bearing += 1;
3512 }
3513 if b.hook.is_some() {
3514 hook_bearing += 1;
3515 }
3516 for hot in HOT_PATHS {
3517 for cmd in behavior_probes(name, b.positionals, hot) {
3518 deny(&cmd, "touched hot path not gated");
3519 }
3520 // Hook commands (dd/tar/sed) have irregular operand syntax, so they are swept by
3521 // their own probe table — restoring the enumerated coverage the deleted RESOLVERS
3522 // sweep gave them.
3523 if let Some(hook) = b.hook {
3524 for cmd in hook_probes(hook, name, hot) {
3525 deny(&cmd, "hook: touched hot path not gated");
3526 }
3527 }
3528 }
3529 // Worktree-trusted is a WRITE boundary only: reading `.git/config` (cat/grep) is
3530 // legitimately allowed, but a write/destroy/relocate into it must deny. Probe the
3531 // write face — the destination slot for a transfer, the operand for a plain write.
3532 let inv = |slots: &[&str]| -> Vec<String> {
3533 std::iter::once(name.to_string()).chain(slots.iter().map(|s| s.to_string())).collect()
3534 };
3535 match b.positionals {
3536 PositionalRole::Write => deny(&inv(&[".git/config"]), "write into worktree-trusted not gated"),
3537 PositionalRole::Transfer => deny(&inv(&["./safe", ".git/config"]), "transfer dest into worktree-trusted not gated"),
3538 _ => {}
3539 }
3540 }
3541 // Non-vacuity: every path-bearing AND every hook command on the roster was reached and
3542 // probed. Derived from the roster (not a magic number) — none-role printers (echo) don't
3543 // positionally gate; hook commands (dd/tar/sed) gate via `hook_probes`.
3544 let count = |pred: fn(&crate::registry::types::BehaviorSpec) -> bool| {
3545 EXPECTED_BEHAVIOR_COMMANDS
3546 .iter()
3547 .filter(|n| crate::registry::command_behavior(n).is_some_and(pred))
3548 .count()
3549 };
3550 assert_eq!(
3551 path_bearing,
3552 count(|b| !matches!(b.positionals, PositionalRole::None)),
3553 "path-bearing behavior commands: saw {path_bearing}"
3554 );
3555 assert_eq!(hook_bearing, count(|b| b.hook.is_some()), "hook behavior commands: saw {hook_bearing}");
3556 }
3557
3558 /// Fail-closed on unknown flags, enumerated over the REGISTRY: every DECLARATIVE flag-walking
3559 /// behavior command (a Read/Write/Transfer role, hookless) worst-cases an unrecognized flag —
3560 /// the `walk_positionals` → `worst` path. Exempt: `grep` (its hook treats an unknown `--token`
3561 /// as a search pattern — keyed on `BehaviorHook::Grep` SPECIFICALLY, not `hook.is_some()`, so a
3562 /// future hook variant is not auto-exempted), and none-role commands (echo prints its args;
3563 /// dd/tar/sed parse their own irregular syntax — all covered by their own resolver tests, and
3564 /// none-role commands take no positional path operands, so an unknown flag can't unlock danger).
3565 #[test]
3566 fn every_hookless_behavior_command_worst_cases_unknown_flags() {
3567 use crate::engine::bridge::project;
3568 use crate::registry::types::{BehaviorHook, PositionalRole};
3569 use crate::verdict::Verdict;
3570
3571 let exempt = |b: &crate::registry::types::BehaviorSpec| {
3572 matches!(b.hook, Some(BehaviorHook::Grep)) || matches!(b.positionals, PositionalRole::None)
3573 };
3574 let mut checked = 0usize;
3575 for name in crate::registry::toml_command_names() {
3576 let Some(b) = crate::registry::command_behavior(name) else { continue };
3577 if exempt(b) {
3578 continue;
3579 }
3580 let profile = resolve(&toks(&[name, "--xyzzy-unknown-42", "./safe"])).expect("resolves");
3581 assert_eq!(project(&profile), Verdict::Denied, "{name}: unknown flag not worst-cased");
3582 checked += 1;
3583 }
3584 let expected = EXPECTED_BEHAVIOR_COMMANDS
3585 .iter()
3586 .filter(|n| crate::registry::command_behavior(n).is_some_and(|b| !exempt(b)))
3587 .count();
3588 assert_eq!(checked, expected, "declarative flag-walking behavior commands: saw {checked}");
3589 }
3590
3591 /// Fail-closed authoring guard: `path_flag_caps` (which gates a valued flag's path VALUE, e.g.
3592 /// `touch -r REF`) runs ONLY on the declarative Read/Write/Transfer path — the None arm (echo)
3593 /// and the hook arm (grep/dd/tar/sed) both return before it. So a `[command.behavior.flags]`
3594 /// path-role declared on a none-role or hook command would be SILENTLY UNGATED — a fail-open.
3595 /// Assert no command does that. Red→green: add `kind = "read"` to a hook command's flags.
3596 #[test]
3597 fn no_none_or_hook_command_declares_ungated_path_flags() {
3598 use crate::registry::types::PositionalRole;
3599 for name in crate::registry::toml_command_names() {
3600 let Some(b) = crate::registry::command_behavior(name) else { continue };
3601 if b.path_flags.is_empty() {
3602 continue;
3603 }
3604 assert!(
3605 b.hook.is_none() && !matches!(b.positionals, PositionalRole::None),
3606 "{name}: behavior path-flags are gated only on the Read/Write/Transfer path; on a \
3607 none-role or hook command they would be silently ungated (fail-open)"
3608 );
3609 }
3610 }
3611}