Skip to main content

rumdl_lib/rules/
md055_table_pipe_style.rs

1use crate::rule::{LintError, LintResult, LintWarning, Rule, RuleCategory, Severity};
2use crate::utils::range_utils::calculate_line_range;
3use crate::utils::table_utils::{TableBlock, TableUtils};
4
5mod md055_config;
6use md055_config::MD055Config;
7
8/// Rule MD055: Table pipe style
9///
10/// See [docs/md055.md](../../docs/md055.md) for full documentation, configuration, and examples.
11///
12/// This rule enforces consistent use of leading and trailing pipe characters in Markdown tables,
13/// which improves readability and ensures uniform document styling.
14///
15/// ## Purpose
16///
17/// - **Consistency**: Ensures uniform table formatting throughout documents
18/// - **Readability**: Well-formatted tables are easier to read and understand
19/// - **Maintainability**: Consistent table syntax makes documents easier to maintain
20/// - **Compatibility**: Some Markdown processors handle different table styles differently
21///
22/// ## Configuration Options
23///
24/// The rule supports the following configuration options:
25///
26/// ```yaml
27/// MD055:
28///   style: "consistent"  # Can be "consistent", "leading_and_trailing", or "no_leading_or_trailing"
29/// ```
30///
31/// ### Style Options
32///
33/// - **consistent**: All tables must use the same style (default)
34/// - **leading_and_trailing**: All tables must have both leading and trailing pipes
35/// - **no_leading_or_trailing**: Tables must not have leading or trailing pipes
36///
37/// ## Examples
38///
39/// ### Leading and Trailing Pipes
40///
41/// ```markdown
42/// | Header 1 | Header 2 | Header 3 |
43/// |----------|----------|----------|
44/// | Cell 1   | Cell 2   | Cell 3   |
45/// | Cell 4   | Cell 5   | Cell 6   |
46/// ```
47///
48/// ### No Leading or Trailing Pipes
49///
50/// ```markdown
51/// Header 1 | Header 2 | Header 3
52/// ---------|----------|---------
53/// Cell 1   | Cell 2   | Cell 3
54/// Cell 4   | Cell 5   | Cell 6
55/// ```
56///
57/// ## Behavior Details
58///
59/// - The rule analyzes each table in the document to determine its pipe style
60/// - With "consistent" style, the first table's style is used as the standard for all others
61/// - The rule handles both the header row, separator row, and content rows
62/// - Tables inside code blocks are ignored
63///
64/// ## Fix Behavior
65///
66/// When applying automatic fixes, this rule:
67/// - Adds or removes leading and trailing pipes as needed
68/// - Preserves the content and alignment of table cells
69/// - Maintains proper spacing around pipe characters
70/// - Updates both header and content rows to match the required style
71///
72/// ## Performance Considerations
73///
74/// The rule includes performance optimizations:
75/// - Efficient table detection with quick checks before detailed analysis
76/// - Smart line-by-line processing to avoid redundant operations
77/// - Optimized string manipulation for pipe character handling
78///
79/// Enforces consistent use of leading and trailing pipe characters in tables
80#[derive(Debug, Default, Clone)]
81pub struct MD055TablePipeStyle {
82    config: MD055Config,
83}
84
85impl MD055TablePipeStyle {
86    pub fn new(style: String) -> Self {
87        Self {
88            config: MD055Config { style },
89        }
90    }
91
92    pub fn from_config_struct(config: MD055Config) -> Self {
93        Self { config }
94    }
95
96    /// Determine the most prevalent table style in a table block
97    fn determine_table_style(&self, table_block: &TableBlock, lines: &[&str]) -> Option<&'static str> {
98        let mut leading_and_trailing_count = 0;
99        let mut no_leading_or_trailing_count = 0;
100        let mut leading_only_count = 0;
101        let mut trailing_only_count = 0;
102
103        // Count style of header row (table line index 0)
104        let header_content = TableUtils::extract_table_row_content(lines[table_block.header_line], table_block, 0);
105        if let Some(style) = TableUtils::determine_pipe_style(header_content) {
106            match style {
107                "leading_and_trailing" => leading_and_trailing_count += 1,
108                "no_leading_or_trailing" => no_leading_or_trailing_count += 1,
109                "leading_only" => leading_only_count += 1,
110                "trailing_only" => trailing_only_count += 1,
111                _ => {}
112            }
113        }
114
115        // Count style of content rows (table line indices 2, 3, 4, ...)
116        for (i, &line_idx) in table_block.content_lines.iter().enumerate() {
117            let content = TableUtils::extract_table_row_content(lines[line_idx], table_block, 2 + i);
118            if let Some(style) = TableUtils::determine_pipe_style(content) {
119                match style {
120                    "leading_and_trailing" => leading_and_trailing_count += 1,
121                    "no_leading_or_trailing" => no_leading_or_trailing_count += 1,
122                    "leading_only" => leading_only_count += 1,
123                    "trailing_only" => trailing_only_count += 1,
124                    _ => {}
125                }
126            }
127        }
128
129        // Determine most prevalent style
130        // In case of tie, prefer leading_and_trailing (most common, widely supported)
131        let max_count = leading_and_trailing_count
132            .max(no_leading_or_trailing_count)
133            .max(leading_only_count)
134            .max(trailing_only_count);
135
136        if max_count > 0 {
137            if leading_and_trailing_count == max_count {
138                Some("leading_and_trailing")
139            } else if no_leading_or_trailing_count == max_count {
140                Some("no_leading_or_trailing")
141            } else if leading_only_count == max_count {
142                Some("leading_only")
143            } else if trailing_only_count == max_count {
144                Some("trailing_only")
145            } else {
146                None
147            }
148        } else {
149            None
150        }
151    }
152
153    /// Simple table row fix for tests - creates a dummy TableBlock without list context
154    #[cfg(test)]
155    fn fix_table_row(&self, line: &str, target_style: &str) -> String {
156        let dummy_block = TableBlock {
157            start_line: 0,
158            end_line: 0,
159            header_line: 0,
160            delimiter_line: 0,
161            content_lines: vec![],
162            list_context: None,
163        };
164        self.fix_table_row_with_context(line, target_style, &dummy_block, 0)
165    }
166
167    /// Fix a table row to match the target style, with full context for list tables
168    ///
169    /// This handles tables inside list items by stripping the list prefix,
170    /// fixing the table content, then restoring the appropriate prefix.
171    fn fix_table_row_with_context(
172        &self,
173        line: &str,
174        target_style: &str,
175        table_block: &TableBlock,
176        table_line_index: usize,
177    ) -> String {
178        // Extract blockquote prefix first
179        let (bq_prefix, after_bq) = TableUtils::extract_blockquote_prefix(line);
180
181        // Handle list context if present
182        if let Some(ref list_ctx) = table_block.list_context {
183            if table_line_index == 0 {
184                // Header line: strip list prefix (handles both markers and indentation)
185                let stripped = after_bq
186                    .strip_prefix(&list_ctx.list_prefix)
187                    .unwrap_or_else(|| TableUtils::extract_list_prefix(after_bq).1);
188                let fixed_content = self.fix_table_content(stripped.trim(), target_style);
189
190                // Restore prefixes: blockquote + list prefix + fixed content
191                let lp = &list_ctx.list_prefix;
192                if bq_prefix.is_empty() && lp.is_empty() {
193                    fixed_content
194                } else {
195                    format!("{bq_prefix}{lp}{fixed_content}")
196                }
197            } else {
198                // Continuation lines: strip indentation, then restore it
199                let content_indent = list_ctx.content_indent;
200                let stripped = TableUtils::extract_table_row_content(line, table_block, table_line_index);
201                let fixed_content = self.fix_table_content(stripped.trim(), target_style);
202
203                // Restore prefixes: blockquote + indentation + fixed content
204                let indent = " ".repeat(content_indent);
205                format!("{bq_prefix}{indent}{fixed_content}")
206            }
207        } else {
208            // No list context, just handle blockquote prefix
209            let fixed_content = self.fix_table_content(after_bq.trim(), target_style);
210            if bq_prefix.is_empty() {
211                fixed_content
212            } else {
213                format!("{bq_prefix}{fixed_content}")
214            }
215        }
216    }
217
218    /// Fix the table content (without any prefix handling)
219    fn fix_table_content(&self, trimmed: &str, target_style: &str) -> String {
220        if !trimmed.contains('|') {
221            return trimmed.to_string();
222        }
223
224        let has_leading = trimmed.starts_with('|');
225        let has_trailing = trimmed.ends_with('|');
226
227        match target_style {
228            "leading_and_trailing" => {
229                let mut result = trimmed.to_string();
230
231                // Add leading pipe if missing
232                if !has_leading {
233                    result = format!("| {result}");
234                }
235
236                // Add trailing pipe if missing
237                if !has_trailing {
238                    result = format!("{result} |");
239                }
240
241                result
242            }
243            "no_leading_or_trailing" => {
244                let mut result = trimmed;
245
246                // Remove leading pipe if present
247                if has_leading {
248                    result = result.strip_prefix('|').unwrap_or(result);
249                    result = result.trim_start();
250                }
251
252                // Remove trailing pipe if present
253                if has_trailing {
254                    result = result.strip_suffix('|').unwrap_or(result);
255                    result = result.trim_end();
256                }
257
258                result.to_string()
259            }
260            "leading_only" => {
261                let mut result = trimmed.to_string();
262
263                // Add leading pipe if missing
264                if !has_leading {
265                    result = format!("| {result}");
266                }
267
268                // Remove trailing pipe if present
269                if has_trailing {
270                    result = result.strip_suffix('|').unwrap_or(&result).trim_end().to_string();
271                }
272
273                result
274            }
275            "trailing_only" => {
276                let mut result = trimmed;
277
278                // Remove leading pipe if present
279                if has_leading {
280                    result = result.strip_prefix('|').unwrap_or(result).trim_start();
281                }
282
283                let mut result = result.to_string();
284
285                // Add trailing pipe if missing
286                if !has_trailing {
287                    result = format!("{result} |");
288                }
289
290                result
291            }
292            _ => trimmed.to_string(),
293        }
294    }
295}
296
297impl Rule for MD055TablePipeStyle {
298    fn name(&self) -> &'static str {
299        "MD055"
300    }
301
302    fn description(&self) -> &'static str {
303        "Table pipe style should be consistent"
304    }
305
306    fn category(&self) -> RuleCategory {
307        RuleCategory::Table
308    }
309
310    fn should_skip(&self, ctx: &crate::lint_context::LintContext) -> bool {
311        // Skip if no tables present (uses cached pipe count)
312        !ctx.likely_has_tables()
313    }
314
315    fn check(&self, ctx: &crate::lint_context::LintContext) -> LintResult {
316        let line_index = &ctx.line_index;
317        let mut warnings = Vec::new();
318
319        // Early return handled by should_skip()
320
321        let lines = ctx.raw_lines();
322
323        // Get the configured style explicitly and validate it
324        let configured_style = match self.config.style.as_str() {
325            "leading_and_trailing" | "no_leading_or_trailing" | "leading_only" | "trailing_only" | "consistent" => {
326                self.config.style.as_str()
327            }
328            _ => {
329                // Invalid style provided, default to "leading_and_trailing"
330                "leading_and_trailing"
331            }
332        };
333
334        // Use pre-computed table blocks from context
335        let table_blocks = &ctx.table_blocks;
336
337        // Process each table block
338        for table_block in table_blocks {
339            // First pass: determine the table's style for "consistent" mode
340            // Count all rows to determine most prevalent style (prevalence-based approach)
341            let table_style = if configured_style == "consistent" {
342                self.determine_table_style(table_block, lines)
343            } else {
344                None
345            };
346
347            // Determine target style for this table
348            let target_style = if configured_style == "consistent" {
349                table_style.unwrap_or("leading_and_trailing")
350            } else {
351                configured_style
352            };
353
354            // Collect all table lines for processing
355            let all_line_indices: Vec<usize> = std::iter::once(table_block.header_line)
356                .chain(std::iter::once(table_block.delimiter_line))
357                .chain(table_block.content_lines.iter().copied())
358                .collect();
359
360            // Check each row and emit a per-row fix. Per-row fixes ensure that
361            // inline-disabling one row does not cause the fix on another row to
362            // overwrite the disabled row's content.
363            for (table_line_idx, &line_idx) in all_line_indices.iter().enumerate() {
364                let line = lines[line_idx];
365                // Extract content to properly check pipe style (handles list/blockquote prefixes)
366                let content = TableUtils::extract_table_row_content(line, table_block, table_line_idx);
367                if let Some(current_style) = TableUtils::determine_pipe_style(content) {
368                    // Only flag lines with actual style mismatches
369                    let needs_fixing = current_style != target_style;
370
371                    if needs_fixing {
372                        let (start_line, start_col, end_line, end_col) = calculate_line_range(line_idx + 1, line);
373
374                        let message = format!(
375                            "Table pipe style should be {}",
376                            match target_style {
377                                "leading_and_trailing" => "leading and trailing",
378                                "no_leading_or_trailing" => "no leading or trailing",
379                                "leading_only" => "leading only",
380                                "trailing_only" => "trailing only",
381                                _ => target_style,
382                            }
383                        );
384
385                        // Build a per-row fix so inline-disabled rows are not
386                        // overwritten by fixes on other rows in the same table.
387                        let fixed_line =
388                            self.fix_table_row_with_context(line, target_style, table_block, table_line_idx);
389                        let row_range =
390                            line_index.line_col_to_byte_range_with_length(line_idx + 1, 1, line.chars().count());
391
392                        warnings.push(LintWarning {
393                            rule_name: Some(self.name().to_string()),
394                            severity: Severity::Warning,
395                            message,
396                            line: start_line,
397                            column: start_col,
398                            end_line,
399                            end_column: end_col,
400                            fix: Some(crate::rule::Fix::new(row_range, fixed_line)),
401                        });
402                    }
403                }
404            }
405        }
406
407        Ok(warnings)
408    }
409
410    fn fix(&self, ctx: &crate::lint_context::LintContext) -> Result<String, LintError> {
411        if self.should_skip(ctx) {
412            return Ok(ctx.content.to_string());
413        }
414        let warnings = self.check(ctx)?;
415        if warnings.is_empty() {
416            return Ok(ctx.content.to_string());
417        }
418        let warnings =
419            crate::utils::fix_utils::filter_warnings_by_inline_config(warnings, ctx.inline_config(), self.name());
420        crate::utils::fix_utils::apply_warning_fixes(ctx.content, &warnings).map_err(LintError::InvalidInput)
421    }
422
423    fn as_any(&self) -> &dyn std::any::Any {
424        self
425    }
426
427    fn default_config_section(&self) -> Option<(String, toml::Value)> {
428        let json_value = serde_json::to_value(&self.config).ok()?;
429        Some((
430            self.name().to_string(),
431            crate::rule_config_serde::json_to_toml_value(&json_value)?,
432        ))
433    }
434
435    fn from_config(config: &crate::config::Config) -> Box<dyn Rule>
436    where
437        Self: Sized,
438    {
439        let rule_config = crate::rule_config_serde::load_rule_config::<MD055Config>(config);
440        Box::new(Self::from_config_struct(rule_config))
441    }
442}
443
444#[cfg(test)]
445mod tests {
446    use super::*;
447
448    #[test]
449    fn test_md055_delimiter_row_handling() {
450        // Test with no_leading_or_trailing style
451        let rule = MD055TablePipeStyle::new("no_leading_or_trailing".to_string());
452
453        let content = "| Header 1 | Header 2 | Header 3 |\n|----------|----------|----------|\n| Data 1   | Data 2   | Data 3   |";
454        let ctx = crate::lint_context::LintContext::new(content, crate::config::MarkdownFlavor::Standard, None);
455        let result = rule.fix(&ctx).unwrap();
456
457        // With the fixed implementation, the delimiter row should have pipes removed
458        // Spacing is preserved from original input
459        let expected = "Header 1 | Header 2 | Header 3\n----------|----------|----------\nData 1   | Data 2   | Data 3";
460
461        assert_eq!(result, expected);
462
463        // Test that the check method actually reports the delimiter row as an issue
464        let warnings = rule.check(&ctx).unwrap();
465        let delimiter_warning = &warnings[1]; // Second warning should be for delimiter row
466        assert_eq!(delimiter_warning.line, 2);
467        assert_eq!(
468            delimiter_warning.message,
469            "Table pipe style should be no leading or trailing"
470        );
471
472        // Test with leading_and_trailing style
473        let rule = MD055TablePipeStyle::new("leading_and_trailing".to_string());
474
475        let content = "Header 1 | Header 2 | Header 3\n----------|----------|----------\nData 1   | Data 2   | Data 3";
476        let ctx = crate::lint_context::LintContext::new(content, crate::config::MarkdownFlavor::Standard, None);
477        let result = rule.fix(&ctx).unwrap();
478
479        // The delimiter row should have pipes added
480        // Spacing is preserved from original input
481        let expected = "| Header 1 | Header 2 | Header 3 |\n| ----------|----------|---------- |\n| Data 1   | Data 2   | Data 3 |";
482
483        assert_eq!(result, expected);
484    }
485
486    #[test]
487    fn test_md055_check_finds_delimiter_row_issues() {
488        // Test that check() correctly identifies delimiter rows that don't match style
489        let rule = MD055TablePipeStyle::new("no_leading_or_trailing".to_string());
490
491        let content = "| Header 1 | Header 2 | Header 3 |\n|----------|----------|----------|\n| Data 1   | Data 2   | Data 3   |";
492        let ctx = crate::lint_context::LintContext::new(content, crate::config::MarkdownFlavor::Standard, None);
493        let warnings = rule.check(&ctx).unwrap();
494
495        // Should have 3 warnings - header row, delimiter row, and data row
496        assert_eq!(warnings.len(), 3);
497
498        // Specifically verify the delimiter row warning (line 2)
499        let delimiter_warning = &warnings[1];
500        assert_eq!(delimiter_warning.line, 2);
501        assert_eq!(
502            delimiter_warning.message,
503            "Table pipe style should be no leading or trailing"
504        );
505    }
506
507    #[test]
508    fn test_md055_real_world_example() {
509        // Test with a real-world example having content before and after the table
510        let rule = MD055TablePipeStyle::new("no_leading_or_trailing".to_string());
511
512        let content = "# Table Example\n\nHere's a table with leading and trailing pipes:\n\n| Header 1 | Header 2 | Header 3 |\n|----------|----------|----------|\n| Data 1   | Data 2   | Data 3   |\n| Data 4   | Data 5   | Data 6   |\n\nMore content after the table.";
513        let ctx = crate::lint_context::LintContext::new(content, crate::config::MarkdownFlavor::Standard, None);
514        let result = rule.fix(&ctx).unwrap();
515
516        // The table should be fixed, with pipes removed
517        // Spacing is preserved from original input
518        let expected = "# Table Example\n\nHere's a table with leading and trailing pipes:\n\nHeader 1 | Header 2 | Header 3\n----------|----------|----------\nData 1   | Data 2   | Data 3\nData 4   | Data 5   | Data 6\n\nMore content after the table.";
519
520        assert_eq!(result, expected);
521
522        // Ensure we get warnings for all table rows
523        let warnings = rule.check(&ctx).unwrap();
524        assert_eq!(warnings.len(), 4); // All four table rows should have warnings
525
526        // The line numbers should match the correct positions in the original content
527        assert_eq!(warnings[0].line, 5); // Header row
528        assert_eq!(warnings[1].line, 6); // Delimiter row
529        assert_eq!(warnings[2].line, 7); // Data row 1
530        assert_eq!(warnings[3].line, 8); // Data row 2
531    }
532
533    #[test]
534    fn test_md055_invalid_style() {
535        // Test with an invalid style setting
536        let rule = MD055TablePipeStyle::new("leading_or_trailing".to_string()); // Invalid style
537
538        let content = "| Header 1 | Header 2 | Header 3 |\n|----------|----------|----------|\n| Data 1   | Data 2   | Data 3   |";
539        let ctx = crate::lint_context::LintContext::new(content, crate::config::MarkdownFlavor::Standard, None);
540        let result = rule.fix(&ctx).unwrap();
541
542        // Should default to "leading_and_trailing"
543        // Already has leading and trailing pipes, so no changes needed - spacing is preserved
544        let expected = "| Header 1 | Header 2 | Header 3 |\n|----------|----------|----------|\n| Data 1   | Data 2   | Data 3   |";
545
546        assert_eq!(result, expected);
547
548        // Now check a content that needs actual modification
549        let content = "Header 1 | Header 2 | Header 3\n----------|----------|----------\nData 1   | Data 2   | Data 3";
550        let ctx2 = crate::lint_context::LintContext::new(content, crate::config::MarkdownFlavor::Standard, None);
551        let result = rule.fix(&ctx2).unwrap();
552
553        // Should add pipes to match the default "leading_and_trailing" style
554        // Spacing is preserved from original input
555        let expected = "| Header 1 | Header 2 | Header 3 |\n| ----------|----------|---------- |\n| Data 1   | Data 2   | Data 3 |";
556        assert_eq!(result, expected);
557
558        // Check that warning messages also work with the fallback style
559        let warnings = rule.check(&ctx2).unwrap();
560
561        // Since content doesn't have leading/trailing pipes but defaults to "leading_and_trailing",
562        // there should be warnings for all rows
563        assert_eq!(warnings.len(), 3);
564    }
565
566    #[test]
567    fn test_underflow_protection() {
568        // Test case to ensure no underflow when parts is empty
569        let rule = MD055TablePipeStyle::new("leading_and_trailing".to_string());
570
571        // Test with empty string (edge case)
572        let result = rule.fix_table_row("", "leading_and_trailing");
573        assert_eq!(result, "");
574
575        // Test with string that doesn't contain pipes
576        let result = rule.fix_table_row("no pipes here", "leading_and_trailing");
577        assert_eq!(result, "no pipes here");
578
579        // Test with minimal pipe content
580        let result = rule.fix_table_row("|", "leading_and_trailing");
581        // Should not panic and should handle gracefully
582        assert!(!result.is_empty());
583    }
584
585    // === Issue #305: Blockquote table tests ===
586
587    #[test]
588    fn test_fix_table_row_in_blockquote() {
589        let rule = MD055TablePipeStyle::new("leading_and_trailing".to_string());
590
591        // Blockquote table without leading pipe
592        let result = rule.fix_table_row("> H1 | H2", "leading_and_trailing");
593        assert_eq!(result, "> | H1 | H2 |");
594
595        // Blockquote table that already has pipes
596        let result = rule.fix_table_row("> | H1 | H2 |", "leading_and_trailing");
597        assert_eq!(result, "> | H1 | H2 |");
598
599        // Removing pipes from blockquote table
600        let result = rule.fix_table_row("> | H1 | H2 |", "no_leading_or_trailing");
601        assert_eq!(result, "> H1 | H2");
602    }
603
604    #[test]
605    fn test_fix_table_row_in_nested_blockquote() {
606        let rule = MD055TablePipeStyle::new("leading_and_trailing".to_string());
607
608        // Double-nested blockquote
609        let result = rule.fix_table_row(">> H1 | H2", "leading_and_trailing");
610        assert_eq!(result, ">> | H1 | H2 |");
611
612        // Triple-nested blockquote
613        let result = rule.fix_table_row(">>> H1 | H2", "leading_and_trailing");
614        assert_eq!(result, ">>> | H1 | H2 |");
615    }
616
617    #[test]
618    fn test_blockquote_table_full_document() {
619        let rule = MD055TablePipeStyle::new("leading_and_trailing".to_string());
620
621        // Full table in blockquote (2 columns, matching delimiter)
622        let content = "> H1 | H2\n> ----|----\n> a  | b";
623        let ctx = crate::lint_context::LintContext::new(content, crate::config::MarkdownFlavor::Standard, None);
624        let result = rule.fix(&ctx).unwrap();
625
626        // Each line should have the blockquote prefix preserved and pipes added
627        // The leading_and_trailing style adds "| " after blockquote prefix
628        assert!(
629            result.starts_with("> |"),
630            "Header should start with blockquote + pipe. Got:\n{result}"
631        );
632        // Delimiter row gets leading pipe added, so check for "> | ---" pattern
633        assert!(
634            result.contains("> | ----"),
635            "Delimiter should have blockquote prefix + leading pipe. Got:\n{result}"
636        );
637    }
638
639    #[test]
640    fn test_blockquote_table_no_leading_trailing() {
641        let rule = MD055TablePipeStyle::new("no_leading_or_trailing".to_string());
642
643        // Table with pipes that should be removed
644        let content = "> | H1 | H2 |\n> |----|----|---|\n> | a  | b |";
645        let ctx = crate::lint_context::LintContext::new(content, crate::config::MarkdownFlavor::Standard, None);
646        let result = rule.fix(&ctx).unwrap();
647
648        // Pipes should be removed but blockquote prefix preserved
649        let lines: Vec<&str> = result.lines().collect();
650        assert!(lines[0].starts_with("> "), "Line should start with blockquote prefix");
651        assert!(
652            !lines[0].starts_with("> |"),
653            "Leading pipe should be removed. Got: {}",
654            lines[0]
655        );
656    }
657
658    #[test]
659    fn test_mixed_regular_and_blockquote_tables() {
660        let rule = MD055TablePipeStyle::new("leading_and_trailing".to_string());
661
662        // Document with both regular and blockquote tables
663        let content = "H1 | H2\n---|---\na | b\n\n> H3 | H4\n> ---|---\n> c | d";
664        let ctx = crate::lint_context::LintContext::new(content, crate::config::MarkdownFlavor::Standard, None);
665        let result = rule.fix(&ctx).unwrap();
666
667        // Both tables should be fixed
668        assert!(result.contains("| H1 | H2 |"), "Regular table should have pipes added");
669        assert!(
670            result.contains("> | H3 | H4 |"),
671            "Blockquote table should have pipes added with prefix preserved"
672        );
673    }
674
675    // === Roundtrip safety tests ===
676
677    fn assert_fix_roundtrip(rule: &MD055TablePipeStyle, content: &str) {
678        let ctx = crate::lint_context::LintContext::new(content, crate::config::MarkdownFlavor::Standard, None);
679        let fixed = rule.fix(&ctx).unwrap();
680        let ctx2 = crate::lint_context::LintContext::new(&fixed, crate::config::MarkdownFlavor::Standard, None);
681        let remaining = rule.check(&ctx2).unwrap();
682        assert!(
683            remaining.is_empty(),
684            "After fix(), check() should find 0 violations.\nOriginal: {content:?}\nFixed: {fixed:?}\nRemaining: {remaining:?}"
685        );
686    }
687
688    #[test]
689    fn test_roundtrip_leading_and_trailing() {
690        let rule = MD055TablePipeStyle::new("leading_and_trailing".to_string());
691        assert_fix_roundtrip(&rule, "H1 | H2\n---|---\na | b");
692    }
693
694    #[test]
695    fn test_roundtrip_no_leading_or_trailing() {
696        let rule = MD055TablePipeStyle::new("no_leading_or_trailing".to_string());
697        assert_fix_roundtrip(&rule, "| H1 | H2 |\n|---|---|\n| a | b |");
698    }
699
700    #[test]
701    fn test_roundtrip_consistent_mode() {
702        let rule = MD055TablePipeStyle::default();
703        assert_fix_roundtrip(&rule, "| H1 | H2 |\n|---|---|\nCell 1 | Cell 2");
704    }
705
706    #[test]
707    fn test_roundtrip_blockquote_table() {
708        let rule = MD055TablePipeStyle::new("leading_and_trailing".to_string());
709        assert_fix_roundtrip(&rule, "> H1 | H2\n> ---|---\n> a | b");
710    }
711
712    #[test]
713    fn test_roundtrip_mixed_tables() {
714        let rule = MD055TablePipeStyle::new("leading_and_trailing".to_string());
715        assert_fix_roundtrip(&rule, "H1 | H2\n---|---\na | b\n\n> H3 | H4\n> ---|---\n> c | d");
716    }
717
718    #[test]
719    fn test_roundtrip_with_surrounding_content() {
720        let rule = MD055TablePipeStyle::new("no_leading_or_trailing".to_string());
721        assert_fix_roundtrip(&rule, "# Title\n\n| H1 | H2 |\n|---|---|\n| a | b |\n\nMore text.");
722    }
723
724    #[test]
725    fn test_roundtrip_clean_content() {
726        let rule = MD055TablePipeStyle::new("leading_and_trailing".to_string());
727        assert_fix_roundtrip(&rule, "| H1 | H2 |\n|---|---|\n| a | b |");
728    }
729}