Skip to main content

rumdl_lib/rules/md060_table_format/
mod.rs

1use crate::rule::{LintError, LintResult, LintWarning, Rule, Severity};
2use crate::utils::range_utils::calculate_line_range;
3use crate::utils::regex_cache::BLOCKQUOTE_PREFIX_RE;
4use crate::utils::table_utils::TableUtils;
5use unicode_width::UnicodeWidthStr;
6
7mod md060_config;
8use crate::md013_line_length::MD013Config;
9pub use md060_config::ColumnAlign;
10pub use md060_config::MD060Config;
11
12/// Identifies the type of row in a table for formatting purposes.
13#[derive(Debug, Clone, Copy, PartialEq)]
14enum RowType {
15    /// The first row containing column headers
16    Header,
17    /// The second row containing delimiter dashes (e.g., `|---|---|`)
18    Delimiter,
19    /// Data rows following the delimiter
20    Body,
21}
22
23#[derive(Debug, Clone, Copy, PartialEq)]
24enum ColumnAlignment {
25    Left,
26    Center,
27    Right,
28}
29
30#[derive(Debug, Clone)]
31struct TableFormatResult {
32    lines: Vec<String>,
33    auto_compacted: bool,
34    aligned_width: Option<usize>,
35}
36
37/// Formatting options for a single table row.
38#[derive(Debug, Clone, Copy)]
39struct RowFormatOptions {
40    /// The type of row being formatted
41    row_type: RowType,
42    /// Whether to use compact delimiter style (no spaces around dashes)
43    compact_delimiter: bool,
44    /// Global column alignment override
45    column_align: ColumnAlign,
46    /// Header-specific column alignment (overrides column_align for header)
47    column_align_header: Option<ColumnAlign>,
48    /// Body-specific column alignment (overrides column_align for body)
49    column_align_body: Option<ColumnAlign>,
50    /// Whether to skip padding on the last column for body rows
51    loose_last_column: bool,
52}
53
54/// Rule MD060: Table Column Alignment
55///
56/// See [docs/md060.md](../../docs/md060.md) for full documentation, configuration, and examples.
57///
58/// This rule enforces consistent column alignment in Markdown tables for improved readability
59/// in source form. When enabled, it ensures table columns are properly aligned with appropriate
60/// padding.
61///
62/// ## Purpose
63///
64/// - **Readability**: Aligned tables are significantly easier to read in source form
65/// - **Maintainability**: Properly formatted tables are easier to edit and review
66/// - **Consistency**: Ensures uniform table formatting throughout documents
67/// - **Developer Experience**: Makes working with tables in plain text more pleasant
68///
69/// ## Configuration Options
70///
71/// The rule supports the following configuration options:
72///
73/// ```toml
74/// [MD013]
75/// line-length = 100  # MD060 inherits this by default
76///
77/// [MD060]
78/// enabled = false      # Default: opt-in for conservative adoption
79/// style = "aligned"    # Can be "aligned", "compact", "tight", or "any"
80/// max-width = 0        # Default: inherit from MD013's line-length
81/// ```
82///
83/// ### Style Options
84///
85/// - **aligned**: Columns are padded with spaces for visual alignment (default)
86/// - **compact**: Minimal spacing with single spaces
87/// - **tight**: No spacing, pipes directly adjacent to content
88/// - **any**: Preserve existing formatting style
89///
90/// ### Max Width (auto-compact threshold)
91///
92/// Controls when tables automatically switch from aligned to compact formatting:
93///
94/// - **`max-width = 0`** (default): Smart inheritance from MD013
95/// - **`max-width = N`**: Explicit threshold, independent of MD013
96///
97/// When `max-width = 0`:
98/// - If MD013 is disabled β†’ unlimited (no auto-compact)
99/// - If MD013.tables = false β†’ unlimited (no auto-compact)
100/// - If MD013.line_length = 0 β†’ unlimited (no auto-compact)
101/// - Otherwise β†’ inherits MD013's line-length
102///
103/// This matches the behavior of Prettier's table formatting.
104///
105/// #### Examples
106///
107/// ```toml
108/// # Inherit from MD013 (recommended)
109/// [MD013]
110/// line-length = 100
111///
112/// [MD060]
113/// style = "aligned"
114/// max-width = 0  # Tables exceeding 100 chars will be compacted
115/// ```
116///
117/// ```toml
118/// # Explicit threshold
119/// [MD060]
120/// style = "aligned"
121/// max-width = 120  # Independent of MD013
122/// ```
123///
124/// ## Examples
125///
126/// ### Aligned Style (Good)
127///
128/// ```markdown
129/// | Name  | Age | City      |
130/// |-------|-----|-----------|
131/// | Alice | 30  | Seattle   |
132/// | Bob   | 25  | Portland  |
133/// ```
134///
135/// ### Unaligned (Bad)
136///
137/// ```markdown
138/// | Name | Age | City |
139/// |---|---|---|
140/// | Alice | 30 | Seattle |
141/// | Bob | 25 | Portland |
142/// ```
143///
144/// ## Unicode Support
145///
146/// This rule properly handles:
147/// - **CJK Characters**: Chinese, Japanese, Korean characters are correctly measured as double-width
148/// - **Basic Emoji**: Most emoji are handled correctly
149/// - **Inline Code**: Pipes in inline code blocks are properly masked
150///
151/// ## Known Limitations
152///
153/// **Complex Unicode Sequences**: Tables containing certain Unicode characters are automatically
154/// skipped to prevent alignment corruption. These include:
155/// - Zero-Width Joiner (ZWJ) emoji: πŸ‘¨β€πŸ‘©β€πŸ‘§β€πŸ‘¦, πŸ‘©β€πŸ’»
156/// - Zero-Width Space (ZWS): Invisible word break opportunities
157/// - Zero-Width Non-Joiner (ZWNJ): Ligature prevention marks
158/// - Word Joiner (WJ): Non-breaking invisible characters
159///
160/// These characters have inconsistent or zero display widths across terminals and fonts,
161/// making accurate alignment impossible. The rule preserves these tables as-is rather than
162/// risk corrupting them.
163///
164/// This is an honest limitation of terminal display technology, similar to what other tools
165/// like markdownlint experience.
166///
167/// ## Fix Behavior
168///
169/// When applying automatic fixes, this rule:
170/// - Calculates proper display width for each column using Unicode width measurements
171/// - Pads cells with trailing spaces to align columns
172/// - Preserves cell content exactly (only spacing is modified)
173/// - Respects alignment indicators in delimiter rows (`:---`, `:---:`, `---:`)
174/// - Automatically switches to compact mode for tables exceeding max_width
175/// - Skips tables with ZWJ emoji to prevent corruption
176#[derive(Debug, Clone, Default)]
177pub struct MD060TableFormat {
178    config: MD060Config,
179    md013_config: MD013Config,
180    md013_disabled: bool,
181}
182
183impl MD060TableFormat {
184    pub fn new(enabled: bool, style: String) -> Self {
185        use crate::types::LineLength;
186        Self {
187            config: MD060Config {
188                enabled,
189                style,
190                max_width: LineLength::from_const(0),
191                column_align: ColumnAlign::Auto,
192                column_align_header: None,
193                column_align_body: None,
194                loose_last_column: false,
195            },
196            md013_config: MD013Config::default(),
197            md013_disabled: false,
198        }
199    }
200
201    pub fn from_config_struct(config: MD060Config, md013_config: MD013Config, md013_disabled: bool) -> Self {
202        Self {
203            config,
204            md013_config,
205            md013_disabled,
206        }
207    }
208
209    /// Get the effective max width for table formatting.
210    ///
211    /// Priority order:
212    /// 1. Explicit `max_width > 0` always takes precedence
213    /// 2. When `max_width = 0` (inherit mode), check MD013 configuration:
214    ///    - If MD013 is globally disabled β†’ unlimited
215    ///    - If `MD013.tables = false` β†’ unlimited
216    ///    - If `MD013.line_length = 0` β†’ unlimited
217    ///    - Otherwise β†’ inherit MD013's line_length
218    fn effective_max_width(&self) -> usize {
219        // Explicit max_width always takes precedence
220        if !self.config.max_width.is_unlimited() {
221            return self.config.max_width.get();
222        }
223
224        // max_width = 0 means "inherit" - but inherit UNLIMITED if:
225        // 1. MD013 is globally disabled
226        // 2. MD013.tables = false (user doesn't care about table line length)
227        // 3. MD013.line_length = 0 (no line length limit at all)
228        if self.md013_disabled || !self.md013_config.tables || self.md013_config.line_length.is_unlimited() {
229            return usize::MAX; // Unlimited
230        }
231
232        // Otherwise inherit MD013's line-length
233        self.md013_config.line_length.get()
234    }
235
236    /// Check if text contains characters that break Unicode width calculations
237    ///
238    /// Tables with these characters are skipped to avoid alignment corruption:
239    /// - Zero-Width Joiner (ZWJ, U+200D): Complex emoji like πŸ‘¨β€πŸ‘©β€πŸ‘§β€πŸ‘¦
240    /// - Zero-Width Space (ZWS, U+200B): Invisible word break opportunity
241    /// - Zero-Width Non-Joiner (ZWNJ, U+200C): Prevents ligature formation
242    /// - Word Joiner (WJ, U+2060): Prevents line breaks without taking space
243    ///
244    /// These characters have inconsistent display widths across terminals,
245    /// making accurate alignment impossible.
246    fn contains_problematic_chars(text: &str) -> bool {
247        text.contains('\u{200D}')  // ZWJ
248            || text.contains('\u{200B}')  // ZWS
249            || text.contains('\u{200C}')  // ZWNJ
250            || text.contains('\u{2060}') // Word Joiner
251    }
252
253    fn calculate_cell_display_width(cell_content: &str) -> usize {
254        let masked = TableUtils::mask_pipes_in_inline_code(cell_content);
255        masked.trim().width()
256    }
257
258    /// Parse a table row into cells using Standard flavor (default behavior).
259    /// Used for tests and backward compatibility.
260    #[cfg(test)]
261    fn parse_table_row(line: &str) -> Vec<String> {
262        TableUtils::split_table_row(line)
263    }
264
265    /// Parse a table row into cells, respecting flavor-specific behavior.
266    ///
267    /// For MkDocs flavor, pipes inside inline code are NOT cell delimiters.
268    /// For Standard/GFM flavor, all pipes (except escaped) are cell delimiters.
269    fn parse_table_row_with_flavor(line: &str, flavor: crate::config::MarkdownFlavor) -> Vec<String> {
270        TableUtils::split_table_row_with_flavor(line, flavor)
271    }
272
273    fn is_delimiter_row(row: &[String]) -> bool {
274        if row.is_empty() {
275            return false;
276        }
277        row.iter().all(|cell| {
278            let trimmed = cell.trim();
279            // A delimiter cell must contain at least one dash
280            // Empty cells are not delimiter cells
281            !trimmed.is_empty()
282                && trimmed.contains('-')
283                && trimmed.chars().all(|c| c == '-' || c == ':' || c.is_whitespace())
284        })
285    }
286
287    /// Extract blockquote prefix from a line (e.g., "> " or ">> ").
288    /// Returns (prefix, content_without_prefix).
289    fn extract_blockquote_prefix(line: &str) -> (&str, &str) {
290        if let Some(m) = BLOCKQUOTE_PREFIX_RE.find(line) {
291            (&line[..m.end()], &line[m.end()..])
292        } else {
293            ("", line)
294        }
295    }
296
297    fn parse_column_alignments(delimiter_row: &[String]) -> Vec<ColumnAlignment> {
298        delimiter_row
299            .iter()
300            .map(|cell| {
301                let trimmed = cell.trim();
302                let has_left_colon = trimmed.starts_with(':');
303                let has_right_colon = trimmed.ends_with(':');
304
305                match (has_left_colon, has_right_colon) {
306                    (true, true) => ColumnAlignment::Center,
307                    (false, true) => ColumnAlignment::Right,
308                    _ => ColumnAlignment::Left,
309                }
310            })
311            .collect()
312    }
313
314    fn calculate_column_widths(table_lines: &[&str], flavor: crate::config::MarkdownFlavor) -> Vec<usize> {
315        let mut column_widths = Vec::new();
316        let mut delimiter_cells: Option<Vec<String>> = None;
317
318        for line in table_lines {
319            let cells = Self::parse_table_row_with_flavor(line, flavor);
320
321            // Save delimiter row for later processing, but don't use it for width calculation
322            if Self::is_delimiter_row(&cells) {
323                delimiter_cells = Some(cells);
324                continue;
325            }
326
327            for (i, cell) in cells.iter().enumerate() {
328                let width = Self::calculate_cell_display_width(cell);
329                if i >= column_widths.len() {
330                    column_widths.push(width);
331                } else {
332                    column_widths[i] = column_widths[i].max(width);
333                }
334            }
335        }
336
337        // GFM requires delimiter rows to have at least 3 dashes per column.
338        // To ensure visual alignment, all columns must be at least width 3.
339        let mut final_widths: Vec<usize> = column_widths.iter().map(|&w| w.max(3)).collect();
340
341        // Adjust column widths to accommodate alignment indicators (colons) in delimiter row
342        // This ensures the delimiter row has the same length as content rows
343        if let Some(delimiter_cells) = delimiter_cells {
344            for (i, cell) in delimiter_cells.iter().enumerate() {
345                if i < final_widths.len() {
346                    let trimmed = cell.trim();
347                    let has_left_colon = trimmed.starts_with(':');
348                    let has_right_colon = trimmed.ends_with(':');
349                    let colon_count = (has_left_colon as usize) + (has_right_colon as usize);
350
351                    // Minimum width needed: 3 dashes + colons
352                    let min_width_for_delimiter = 3 + colon_count;
353                    final_widths[i] = final_widths[i].max(min_width_for_delimiter);
354                }
355            }
356        }
357
358        final_widths
359    }
360
361    fn format_table_row(
362        cells: &[String],
363        column_widths: &[usize],
364        column_alignments: &[ColumnAlignment],
365        options: &RowFormatOptions,
366    ) -> String {
367        let num_cells = cells.len();
368        let formatted_cells: Vec<String> = cells
369            .iter()
370            .enumerate()
371            .map(|(i, cell)| {
372                let is_last_column = i == num_cells - 1;
373                let target_width = column_widths.get(i).copied().unwrap_or(0);
374
375                match options.row_type {
376                    RowType::Delimiter => {
377                        let trimmed = cell.trim();
378                        let has_left_colon = trimmed.starts_with(':');
379                        let has_right_colon = trimmed.ends_with(':');
380
381                        // Delimiter rows use the same cell format as content rows: | content |
382                        // The "content" is dashes, possibly with colons for alignment
383                        // For compact_delimiter mode, we don't add spaces, so we need 2 extra dashes
384                        let extra_width = if options.compact_delimiter { 2 } else { 0 };
385                        let dash_count = if has_left_colon && has_right_colon {
386                            (target_width + extra_width).saturating_sub(2)
387                        } else if has_left_colon || has_right_colon {
388                            (target_width + extra_width).saturating_sub(1)
389                        } else {
390                            target_width + extra_width
391                        };
392
393                        let dashes = "-".repeat(dash_count.max(3)); // Minimum 3 dashes
394                        let delimiter_content = if has_left_colon && has_right_colon {
395                            format!(":{dashes}:")
396                        } else if has_left_colon {
397                            format!(":{dashes}")
398                        } else if has_right_colon {
399                            format!("{dashes}:")
400                        } else {
401                            dashes
402                        };
403
404                        // Add spaces around delimiter content unless compact_delimiter mode
405                        if options.compact_delimiter {
406                            delimiter_content
407                        } else {
408                            format!(" {delimiter_content} ")
409                        }
410                    }
411                    RowType::Header | RowType::Body => {
412                        let trimmed = cell.trim();
413                        let current_width = Self::calculate_cell_display_width(cell);
414
415                        // For loose last column in body rows, don't add padding
416                        let skip_padding =
417                            options.loose_last_column && is_last_column && options.row_type == RowType::Body;
418
419                        let padding = if skip_padding {
420                            0
421                        } else {
422                            target_width.saturating_sub(current_width)
423                        };
424
425                        // Determine which alignment to use based on row type
426                        let effective_align = match options.row_type {
427                            RowType::Header => options.column_align_header.unwrap_or(options.column_align),
428                            RowType::Body => options.column_align_body.unwrap_or(options.column_align),
429                            RowType::Delimiter => unreachable!(),
430                        };
431
432                        // Apply alignment: use override if specified, otherwise use delimiter indicators
433                        let alignment = match effective_align {
434                            ColumnAlign::Auto => column_alignments.get(i).copied().unwrap_or(ColumnAlignment::Left),
435                            ColumnAlign::Left => ColumnAlignment::Left,
436                            ColumnAlign::Center => ColumnAlignment::Center,
437                            ColumnAlign::Right => ColumnAlignment::Right,
438                        };
439
440                        match alignment {
441                            ColumnAlignment::Left => {
442                                // Left: content on left, padding on right
443                                format!(" {trimmed}{} ", " ".repeat(padding))
444                            }
445                            ColumnAlignment::Center => {
446                                // Center: split padding on both sides
447                                let left_padding = padding / 2;
448                                let right_padding = padding - left_padding;
449                                format!(" {}{trimmed}{} ", " ".repeat(left_padding), " ".repeat(right_padding))
450                            }
451                            ColumnAlignment::Right => {
452                                // Right: padding on left, content on right
453                                format!(" {}{trimmed} ", " ".repeat(padding))
454                            }
455                        }
456                    }
457                }
458            })
459            .collect();
460
461        format!("|{}|", formatted_cells.join("|"))
462    }
463
464    fn format_table_compact(cells: &[String]) -> String {
465        let formatted_cells: Vec<String> = cells.iter().map(|cell| format!(" {} ", cell.trim())).collect();
466        format!("|{}|", formatted_cells.join("|"))
467    }
468
469    fn format_table_tight(cells: &[String]) -> String {
470        let formatted_cells: Vec<String> = cells.iter().map(|cell| cell.trim().to_string()).collect();
471        format!("|{}|", formatted_cells.join("|"))
472    }
473
474    /// Checks if a table is already aligned with consistent column widths
475    /// and the delimiter row style matches the target style.
476    ///
477    /// A table is considered "already aligned" if:
478    /// 1. All rows have the same display length
479    /// 2. Each column has consistent cell width across all rows
480    /// 3. The delimiter row has valid minimum widths (at least 3 chars per cell)
481    /// 4. The delimiter row style matches the target style (compact_delimiter parameter)
482    ///
483    /// The `compact_delimiter` parameter indicates whether the target style is "aligned-no-space"
484    /// (true = no spaces around dashes, false = spaces around dashes).
485    fn is_table_already_aligned(
486        table_lines: &[&str],
487        flavor: crate::config::MarkdownFlavor,
488        compact_delimiter: bool,
489    ) -> bool {
490        if table_lines.len() < 2 {
491            return false;
492        }
493
494        // Check 1: All rows must have the same length
495        let first_len = table_lines[0].len();
496        if !table_lines.iter().all(|line| line.len() == first_len) {
497            return false;
498        }
499
500        // Parse all rows and check column count consistency
501        let parsed: Vec<Vec<String>> = table_lines
502            .iter()
503            .map(|line| Self::parse_table_row_with_flavor(line, flavor))
504            .collect();
505
506        if parsed.is_empty() {
507            return false;
508        }
509
510        let num_columns = parsed[0].len();
511        if !parsed.iter().all(|row| row.len() == num_columns) {
512            return false;
513        }
514
515        // Check delimiter row has valid minimum widths (3 chars: at least one dash + optional colons)
516        // Delimiter row is always at index 1
517        if let Some(delimiter_row) = parsed.get(1) {
518            if !Self::is_delimiter_row(delimiter_row) {
519                return false;
520            }
521            // Check each delimiter cell has at least one dash (minimum valid is "---" or ":--" etc)
522            for cell in delimiter_row {
523                let trimmed = cell.trim();
524                let dash_count = trimmed.chars().filter(|&c| c == '-').count();
525                if dash_count < 1 {
526                    return false;
527                }
528            }
529
530            // Check if delimiter row style matches the target style
531            // compact_delimiter=true means "aligned-no-space" (no spaces around dashes)
532            // compact_delimiter=false means "aligned" (spaces around dashes)
533            let delimiter_has_spaces = delimiter_row
534                .iter()
535                .all(|cell| cell.starts_with(' ') && cell.ends_with(' '));
536
537            // If target is compact (no spaces) but current has spaces, not aligned
538            // If target is spaced but current has no spaces, not aligned
539            if compact_delimiter && delimiter_has_spaces {
540                return false;
541            }
542            if !compact_delimiter && !delimiter_has_spaces {
543                return false;
544            }
545        }
546
547        // Check each column has consistent width across all content rows
548        // Use cell.width() to get display width INCLUDING padding, not trimmed content
549        // This correctly handles CJK characters (display width 2, byte length 3)
550        for col_idx in 0..num_columns {
551            let mut widths = Vec::new();
552            for (row_idx, row) in parsed.iter().enumerate() {
553                // Skip delimiter row for content width check
554                if row_idx == 1 {
555                    continue;
556                }
557                if let Some(cell) = row.get(col_idx) {
558                    widths.push(cell.width());
559                }
560            }
561            // All content cells in this column should have the same display width
562            if !widths.is_empty() && !widths.iter().all(|&w| w == widths[0]) {
563                return false;
564            }
565        }
566
567        true
568    }
569
570    fn detect_table_style(table_lines: &[&str], flavor: crate::config::MarkdownFlavor) -> Option<String> {
571        if table_lines.is_empty() {
572            return None;
573        }
574
575        // Check all rows (except delimiter) to determine consistent style
576        // A table is only "tight" or "compact" if ALL rows follow that pattern
577        let mut is_tight = true;
578        let mut is_compact = true;
579
580        for line in table_lines {
581            let cells = Self::parse_table_row_with_flavor(line, flavor);
582
583            if cells.is_empty() {
584                continue;
585            }
586
587            // Skip delimiter rows when detecting style
588            if Self::is_delimiter_row(&cells) {
589                continue;
590            }
591
592            // Check if this row has no padding
593            let row_has_no_padding = cells.iter().all(|cell| !cell.starts_with(' ') && !cell.ends_with(' '));
594
595            // Check if this row has exactly single-space padding
596            let row_has_single_space = cells.iter().all(|cell| {
597                let trimmed = cell.trim();
598                cell == &format!(" {trimmed} ")
599            });
600
601            // If any row doesn't match tight, the table isn't tight
602            if !row_has_no_padding {
603                is_tight = false;
604            }
605
606            // If any row doesn't match compact, the table isn't compact
607            if !row_has_single_space {
608                is_compact = false;
609            }
610
611            // Early exit: if neither tight nor compact, it must be aligned
612            if !is_tight && !is_compact {
613                return Some("aligned".to_string());
614            }
615        }
616
617        // Return the most restrictive style that matches
618        if is_tight {
619            Some("tight".to_string())
620        } else if is_compact {
621            Some("compact".to_string())
622        } else {
623            Some("aligned".to_string())
624        }
625    }
626
627    fn fix_table_block(
628        &self,
629        lines: &[&str],
630        table_block: &crate::utils::table_utils::TableBlock,
631        flavor: crate::config::MarkdownFlavor,
632    ) -> TableFormatResult {
633        let mut result = Vec::new();
634        let mut auto_compacted = false;
635        let mut aligned_width = None;
636
637        let table_lines: Vec<&str> = std::iter::once(lines[table_block.header_line])
638            .chain(std::iter::once(lines[table_block.delimiter_line]))
639            .chain(table_block.content_lines.iter().map(|&idx| lines[idx]))
640            .collect();
641
642        if table_lines.iter().any(|line| Self::contains_problematic_chars(line)) {
643            return TableFormatResult {
644                lines: table_lines.iter().map(|s| s.to_string()).collect(),
645                auto_compacted: false,
646                aligned_width: None,
647            };
648        }
649
650        // Extract blockquote prefix from the header line (first line of table)
651        // All lines in the same table should have the same blockquote level
652        let (blockquote_prefix, _) = Self::extract_blockquote_prefix(table_lines[0]);
653
654        // Extract list prefix if present (for tables inside list items)
655        let list_context = &table_block.list_context;
656        let (list_prefix, continuation_indent) = if let Some(ctx) = list_context {
657            (ctx.list_prefix.as_str(), " ".repeat(ctx.content_indent))
658        } else {
659            ("", String::new())
660        };
661
662        // Strip blockquote prefix and list prefix from all lines for processing
663        let stripped_lines: Vec<&str> = table_lines
664            .iter()
665            .enumerate()
666            .map(|(i, line)| {
667                let after_blockquote = Self::extract_blockquote_prefix(line).1;
668                if list_context.is_some() {
669                    if i == 0 {
670                        // Header line: strip list prefix (handles both markers and indentation)
671                        after_blockquote.strip_prefix(list_prefix).unwrap_or_else(|| {
672                            crate::utils::table_utils::TableUtils::extract_list_prefix(after_blockquote).1
673                        })
674                    } else {
675                        // Continuation lines: strip expected indentation
676                        after_blockquote
677                            .strip_prefix(&continuation_indent)
678                            .unwrap_or(after_blockquote.trim_start())
679                    }
680                } else {
681                    after_blockquote
682                }
683            })
684            .collect();
685
686        let style = self.config.style.as_str();
687
688        match style {
689            "any" => {
690                let detected_style = Self::detect_table_style(&stripped_lines, flavor);
691                if detected_style.is_none() {
692                    return TableFormatResult {
693                        lines: table_lines.iter().map(|s| s.to_string()).collect(),
694                        auto_compacted: false,
695                        aligned_width: None,
696                    };
697                }
698
699                let target_style = detected_style.unwrap();
700
701                // Parse column alignments from delimiter row (always at index 1)
702                let delimiter_cells = Self::parse_table_row_with_flavor(stripped_lines[1], flavor);
703                let column_alignments = Self::parse_column_alignments(&delimiter_cells);
704
705                for (row_idx, line) in stripped_lines.iter().enumerate() {
706                    let cells = Self::parse_table_row_with_flavor(line, flavor);
707                    match target_style.as_str() {
708                        "tight" => result.push(Self::format_table_tight(&cells)),
709                        "compact" => result.push(Self::format_table_compact(&cells)),
710                        _ => {
711                            let column_widths = Self::calculate_column_widths(&stripped_lines, flavor);
712                            let row_type = match row_idx {
713                                0 => RowType::Header,
714                                1 => RowType::Delimiter,
715                                _ => RowType::Body,
716                            };
717                            let options = RowFormatOptions {
718                                row_type,
719                                compact_delimiter: false,
720                                column_align: self.config.column_align,
721                                column_align_header: self.config.column_align_header,
722                                column_align_body: self.config.column_align_body,
723                                loose_last_column: self.config.loose_last_column,
724                            };
725                            result.push(Self::format_table_row(
726                                &cells,
727                                &column_widths,
728                                &column_alignments,
729                                &options,
730                            ));
731                        }
732                    }
733                }
734            }
735            "compact" => {
736                for line in &stripped_lines {
737                    let cells = Self::parse_table_row_with_flavor(line, flavor);
738                    result.push(Self::format_table_compact(&cells));
739                }
740            }
741            "tight" => {
742                for line in &stripped_lines {
743                    let cells = Self::parse_table_row_with_flavor(line, flavor);
744                    result.push(Self::format_table_tight(&cells));
745                }
746            }
747            "aligned" | "aligned-no-space" => {
748                let compact_delimiter = style == "aligned-no-space";
749
750                // Determine if we need to reformat: skip if table is already aligned
751                // UNLESS any alignment or formatting options require reformatting
752                let needs_reformat = self.config.column_align != ColumnAlign::Auto
753                    || self.config.column_align_header.is_some()
754                    || self.config.column_align_body.is_some()
755                    || self.config.loose_last_column;
756
757                if !needs_reformat && Self::is_table_already_aligned(&stripped_lines, flavor, compact_delimiter) {
758                    return TableFormatResult {
759                        lines: table_lines.iter().map(|s| s.to_string()).collect(),
760                        auto_compacted: false,
761                        aligned_width: None,
762                    };
763                }
764
765                let column_widths = Self::calculate_column_widths(&stripped_lines, flavor);
766
767                // Calculate aligned table width: 1 (leading pipe) + num_columns * 3 (| cell |) + sum(column_widths)
768                let num_columns = column_widths.len();
769                let calc_aligned_width = 1 + (num_columns * 3) + column_widths.iter().sum::<usize>();
770                aligned_width = Some(calc_aligned_width);
771
772                // Auto-compact: if aligned table exceeds max width, use compact formatting instead
773                if calc_aligned_width > self.effective_max_width() {
774                    auto_compacted = true;
775                    for line in &stripped_lines {
776                        let cells = Self::parse_table_row_with_flavor(line, flavor);
777                        result.push(Self::format_table_compact(&cells));
778                    }
779                } else {
780                    // Parse column alignments from delimiter row (always at index 1)
781                    let delimiter_cells = Self::parse_table_row_with_flavor(stripped_lines[1], flavor);
782                    let column_alignments = Self::parse_column_alignments(&delimiter_cells);
783
784                    for (row_idx, line) in stripped_lines.iter().enumerate() {
785                        let cells = Self::parse_table_row_with_flavor(line, flavor);
786                        let row_type = match row_idx {
787                            0 => RowType::Header,
788                            1 => RowType::Delimiter,
789                            _ => RowType::Body,
790                        };
791                        let options = RowFormatOptions {
792                            row_type,
793                            compact_delimiter,
794                            column_align: self.config.column_align,
795                            column_align_header: self.config.column_align_header,
796                            column_align_body: self.config.column_align_body,
797                            loose_last_column: self.config.loose_last_column,
798                        };
799                        result.push(Self::format_table_row(
800                            &cells,
801                            &column_widths,
802                            &column_alignments,
803                            &options,
804                        ));
805                    }
806                }
807            }
808            _ => {
809                return TableFormatResult {
810                    lines: table_lines.iter().map(|s| s.to_string()).collect(),
811                    auto_compacted: false,
812                    aligned_width: None,
813                };
814            }
815        }
816
817        // Re-add blockquote prefix and list prefix to all formatted lines
818        let prefixed_result: Vec<String> = result
819            .into_iter()
820            .enumerate()
821            .map(|(i, line)| {
822                if list_context.is_some() {
823                    if i == 0 {
824                        // Header line: add list prefix
825                        format!("{blockquote_prefix}{list_prefix}{line}")
826                    } else {
827                        // Continuation lines: add indentation
828                        format!("{blockquote_prefix}{continuation_indent}{line}")
829                    }
830                } else {
831                    format!("{blockquote_prefix}{line}")
832                }
833            })
834            .collect();
835
836        TableFormatResult {
837            lines: prefixed_result,
838            auto_compacted,
839            aligned_width,
840        }
841    }
842}
843
844impl Rule for MD060TableFormat {
845    fn name(&self) -> &'static str {
846        "MD060"
847    }
848
849    fn description(&self) -> &'static str {
850        "Table columns should be consistently aligned"
851    }
852
853    fn should_skip(&self, ctx: &crate::lint_context::LintContext) -> bool {
854        !ctx.likely_has_tables()
855    }
856
857    fn check(&self, ctx: &crate::lint_context::LintContext) -> LintResult {
858        let line_index = &ctx.line_index;
859        let mut warnings = Vec::new();
860
861        let lines = ctx.raw_lines();
862        let table_blocks = &ctx.table_blocks;
863
864        for table_block in table_blocks {
865            let format_result = self.fix_table_block(lines, table_block, ctx.flavor);
866
867            let table_line_indices: Vec<usize> = std::iter::once(table_block.header_line)
868                .chain(std::iter::once(table_block.delimiter_line))
869                .chain(table_block.content_lines.iter().copied())
870                .collect();
871
872            // Build the whole-table fix once for all warnings in this table
873            // This ensures that applying Quick Fix on any row fixes the entire table
874            let table_start_line = table_block.start_line + 1; // Convert to 1-indexed
875            let table_end_line = table_block.end_line + 1; // Convert to 1-indexed
876
877            // Build the complete fixed table content
878            let mut fixed_table_lines: Vec<String> = Vec::with_capacity(table_line_indices.len());
879            for (i, &line_idx) in table_line_indices.iter().enumerate() {
880                let fixed_line = &format_result.lines[i];
881                // Add newline for all lines except the last if the original didn't have one
882                if line_idx < lines.len() - 1 {
883                    fixed_table_lines.push(format!("{fixed_line}\n"));
884                } else {
885                    fixed_table_lines.push(fixed_line.clone());
886                }
887            }
888            let table_replacement = fixed_table_lines.concat();
889            let table_range = line_index.multi_line_range(table_start_line, table_end_line);
890
891            for (i, &line_idx) in table_line_indices.iter().enumerate() {
892                let original = lines[line_idx];
893                let fixed = &format_result.lines[i];
894
895                if original != fixed {
896                    let (start_line, start_col, end_line, end_col) = calculate_line_range(line_idx + 1, original);
897
898                    let message = if format_result.auto_compacted {
899                        if let Some(width) = format_result.aligned_width {
900                            format!(
901                                "Table too wide for aligned formatting ({} chars > max-width: {})",
902                                width,
903                                self.effective_max_width()
904                            )
905                        } else {
906                            "Table too wide for aligned formatting".to_string()
907                        }
908                    } else {
909                        "Table columns should be aligned".to_string()
910                    };
911
912                    // Each warning uses the same whole-table fix
913                    // This ensures Quick Fix on any row aligns the entire table
914                    warnings.push(LintWarning {
915                        rule_name: Some(self.name().to_string()),
916                        severity: Severity::Warning,
917                        message,
918                        line: start_line,
919                        column: start_col,
920                        end_line,
921                        end_column: end_col,
922                        fix: Some(crate::rule::Fix {
923                            range: table_range.clone(),
924                            replacement: table_replacement.clone(),
925                        }),
926                    });
927                }
928            }
929        }
930
931        Ok(warnings)
932    }
933
934    fn fix(&self, ctx: &crate::lint_context::LintContext) -> Result<String, LintError> {
935        let content = ctx.content;
936        let lines = ctx.raw_lines();
937        let table_blocks = &ctx.table_blocks;
938
939        let mut result_lines: Vec<String> = lines.iter().map(|&s| s.to_string()).collect();
940
941        for table_block in table_blocks {
942            let format_result = self.fix_table_block(lines, table_block, ctx.flavor);
943
944            let table_line_indices: Vec<usize> = std::iter::once(table_block.header_line)
945                .chain(std::iter::once(table_block.delimiter_line))
946                .chain(table_block.content_lines.iter().copied())
947                .collect();
948
949            for (i, &line_idx) in table_line_indices.iter().enumerate() {
950                result_lines[line_idx] = format_result.lines[i].clone();
951            }
952        }
953
954        let mut fixed = result_lines.join("\n");
955        if content.ends_with('\n') && !fixed.ends_with('\n') {
956            fixed.push('\n');
957        }
958        Ok(fixed)
959    }
960
961    fn as_any(&self) -> &dyn std::any::Any {
962        self
963    }
964
965    fn default_config_section(&self) -> Option<(String, toml::Value)> {
966        // Build TOML table explicitly to include all keys, even optional ones
967        // (serde skips Option::None values, which causes config validation warnings)
968        let mut table = toml::map::Map::new();
969        table.insert("enabled".to_string(), toml::Value::Boolean(self.config.enabled));
970        table.insert("style".to_string(), toml::Value::String(self.config.style.clone()));
971        table.insert(
972            "max-width".to_string(),
973            toml::Value::Integer(self.config.max_width.get() as i64),
974        );
975        table.insert(
976            "column-align".to_string(),
977            toml::Value::String(
978                match self.config.column_align {
979                    ColumnAlign::Auto => "auto",
980                    ColumnAlign::Left => "left",
981                    ColumnAlign::Center => "center",
982                    ColumnAlign::Right => "right",
983                }
984                .to_string(),
985            ),
986        );
987        // Include optional keys with placeholder values so they're recognized as valid
988        table.insert(
989            "column-align-header".to_string(),
990            toml::Value::String("auto".to_string()),
991        );
992        table.insert("column-align-body".to_string(), toml::Value::String("auto".to_string()));
993        table.insert(
994            "loose-last-column".to_string(),
995            toml::Value::Boolean(self.config.loose_last_column),
996        );
997
998        Some((self.name().to_string(), toml::Value::Table(table)))
999    }
1000
1001    fn from_config(config: &crate::config::Config) -> Box<dyn Rule>
1002    where
1003        Self: Sized,
1004    {
1005        let rule_config = crate::rule_config_serde::load_rule_config::<MD060Config>(config);
1006        let md013_config = crate::rule_config_serde::load_rule_config::<MD013Config>(config);
1007
1008        // Check if MD013 is globally disabled
1009        let md013_disabled = config.global.disable.iter().any(|r| r == "MD013");
1010
1011        Box::new(Self::from_config_struct(rule_config, md013_config, md013_disabled))
1012    }
1013}
1014
1015#[cfg(test)]
1016mod tests {
1017    use super::*;
1018    use crate::lint_context::LintContext;
1019    use crate::types::LineLength;
1020
1021    /// Helper to create an MD013Config with a specific line length for testing
1022    fn md013_with_line_length(line_length: usize) -> MD013Config {
1023        MD013Config {
1024            line_length: LineLength::from_const(line_length),
1025            tables: true, // Default: tables are checked
1026            ..Default::default()
1027        }
1028    }
1029
1030    #[test]
1031    fn test_md060_align_simple_ascii_table() {
1032        let rule = MD060TableFormat::new(true, "aligned".to_string());
1033
1034        let content = "| Name | Age |\n|---|---|\n| Alice | 30 |";
1035        let ctx = LintContext::new(content, crate::config::MarkdownFlavor::Standard, None);
1036
1037        let fixed = rule.fix(&ctx).unwrap();
1038        let expected = "| Name  | Age |\n| ----- | --- |\n| Alice | 30  |";
1039        assert_eq!(fixed, expected);
1040
1041        // Verify all rows have equal length in aligned mode
1042        let lines: Vec<&str> = fixed.lines().collect();
1043        assert_eq!(lines[0].len(), lines[1].len());
1044        assert_eq!(lines[1].len(), lines[2].len());
1045    }
1046
1047    #[test]
1048    fn test_md060_cjk_characters_aligned_correctly() {
1049        let rule = MD060TableFormat::new(true, "aligned".to_string());
1050
1051        let content = "| Name | Age |\n|---|---|\n| δΈ­ζ–‡ | 30 |";
1052        let ctx = LintContext::new(content, crate::config::MarkdownFlavor::Standard, None);
1053
1054        let fixed = rule.fix(&ctx).unwrap();
1055
1056        let lines: Vec<&str> = fixed.lines().collect();
1057        let cells_line1 = MD060TableFormat::parse_table_row(lines[0]);
1058        let cells_line3 = MD060TableFormat::parse_table_row(lines[2]);
1059
1060        let width1 = MD060TableFormat::calculate_cell_display_width(&cells_line1[0]);
1061        let width3 = MD060TableFormat::calculate_cell_display_width(&cells_line3[0]);
1062
1063        assert_eq!(width1, width3);
1064    }
1065
1066    #[test]
1067    fn test_md060_basic_emoji() {
1068        let rule = MD060TableFormat::new(true, "aligned".to_string());
1069
1070        let content = "| Status | Name |\n|---|---|\n| βœ… | Test |";
1071        let ctx = LintContext::new(content, crate::config::MarkdownFlavor::Standard, None);
1072
1073        let fixed = rule.fix(&ctx).unwrap();
1074        assert!(fixed.contains("Status"));
1075    }
1076
1077    #[test]
1078    fn test_md060_zwj_emoji_skipped() {
1079        let rule = MD060TableFormat::new(true, "aligned".to_string());
1080
1081        let content = "| Emoji | Name |\n|---|---|\n| πŸ‘¨β€πŸ‘©β€πŸ‘§β€πŸ‘¦ | Family |";
1082        let ctx = LintContext::new(content, crate::config::MarkdownFlavor::Standard, None);
1083
1084        let fixed = rule.fix(&ctx).unwrap();
1085        assert_eq!(fixed, content);
1086    }
1087
1088    #[test]
1089    fn test_md060_inline_code_with_escaped_pipes() {
1090        // In GFM tables, bare pipes in inline code STILL act as cell delimiters.
1091        // To include a literal pipe in table content (even in code), escape it with \|
1092        let rule = MD060TableFormat::new(true, "aligned".to_string());
1093
1094        // CORRECT: `[0-9]\|[0-9]` - the \| is escaped, stays as content (2 columns)
1095        let content = "| Pattern | Regex |\n|---|---|\n| Time | `[0-9]\\|[0-9]` |";
1096        let ctx = LintContext::new(content, crate::config::MarkdownFlavor::Standard, None);
1097
1098        let fixed = rule.fix(&ctx).unwrap();
1099        assert!(fixed.contains(r"`[0-9]\|[0-9]`"), "Escaped pipes should be preserved");
1100    }
1101
1102    #[test]
1103    fn test_md060_compact_style() {
1104        let rule = MD060TableFormat::new(true, "compact".to_string());
1105
1106        let content = "| Name | Age |\n|---|---|\n| Alice | 30 |";
1107        let ctx = LintContext::new(content, crate::config::MarkdownFlavor::Standard, None);
1108
1109        let fixed = rule.fix(&ctx).unwrap();
1110        let expected = "| Name | Age |\n| --- | --- |\n| Alice | 30 |";
1111        assert_eq!(fixed, expected);
1112    }
1113
1114    #[test]
1115    fn test_md060_tight_style() {
1116        let rule = MD060TableFormat::new(true, "tight".to_string());
1117
1118        let content = "| Name | Age |\n|---|---|\n| Alice | 30 |";
1119        let ctx = LintContext::new(content, crate::config::MarkdownFlavor::Standard, None);
1120
1121        let fixed = rule.fix(&ctx).unwrap();
1122        let expected = "|Name|Age|\n|---|---|\n|Alice|30|";
1123        assert_eq!(fixed, expected);
1124    }
1125
1126    #[test]
1127    fn test_md060_aligned_no_space_style() {
1128        // Issue #277: aligned-no-space style has no spaces in delimiter row
1129        let rule = MD060TableFormat::new(true, "aligned-no-space".to_string());
1130
1131        let content = "| Name | Age |\n|---|---|\n| Alice | 30 |";
1132        let ctx = LintContext::new(content, crate::config::MarkdownFlavor::Standard, None);
1133
1134        let fixed = rule.fix(&ctx).unwrap();
1135
1136        // Content rows have spaces, delimiter row does not
1137        let lines: Vec<&str> = fixed.lines().collect();
1138        assert_eq!(lines[0], "| Name  | Age |", "Header should have spaces around content");
1139        assert_eq!(
1140            lines[1], "|-------|-----|",
1141            "Delimiter should have NO spaces around dashes"
1142        );
1143        assert_eq!(lines[2], "| Alice | 30  |", "Content should have spaces around content");
1144
1145        // All rows should have equal length
1146        assert_eq!(lines[0].len(), lines[1].len());
1147        assert_eq!(lines[1].len(), lines[2].len());
1148    }
1149
1150    #[test]
1151    fn test_md060_aligned_no_space_preserves_alignment_indicators() {
1152        // Alignment indicators (:) should be preserved
1153        let rule = MD060TableFormat::new(true, "aligned-no-space".to_string());
1154
1155        let content = "| Left | Center | Right |\n|:---|:---:|---:|\n| A | B | C |";
1156        let ctx = LintContext::new(content, crate::config::MarkdownFlavor::Standard, None);
1157
1158        let fixed = rule.fix(&ctx).unwrap();
1159        let lines: Vec<&str> = fixed.lines().collect();
1160
1161        // Verify alignment indicators are preserved without spaces around them
1162        assert!(
1163            fixed.contains("|:"),
1164            "Should have left alignment indicator adjacent to pipe"
1165        );
1166        assert!(
1167            fixed.contains(":|"),
1168            "Should have right alignment indicator adjacent to pipe"
1169        );
1170        // Check for center alignment - the exact dash count depends on column width
1171        assert!(
1172            lines[1].contains(":---") && lines[1].contains("---:"),
1173            "Should have center alignment colons"
1174        );
1175    }
1176
1177    #[test]
1178    fn test_md060_aligned_no_space_three_column_table() {
1179        // Test the exact format from issue #277
1180        let rule = MD060TableFormat::new(true, "aligned-no-space".to_string());
1181
1182        let content = "| Header 1 | Header 2 | Header 3 |\n|---|---|---|\n| Row 1, Col 1 | Row 1, Col 2 | Row 1, Col 3 |\n| Row 2, Col 1 | Row 2, Col 2 | Row 2, Col 3 |";
1183        let ctx = LintContext::new(content, crate::config::MarkdownFlavor::Standard, None);
1184
1185        let fixed = rule.fix(&ctx).unwrap();
1186        let lines: Vec<&str> = fixed.lines().collect();
1187
1188        // Verify delimiter row format: |--------------|--------------|--------------|
1189        assert!(lines[1].starts_with("|---"), "Delimiter should start with |---");
1190        assert!(lines[1].ends_with("---|"), "Delimiter should end with ---|");
1191        assert!(!lines[1].contains("| -"), "Delimiter should NOT have space after pipe");
1192        assert!(!lines[1].contains("- |"), "Delimiter should NOT have space before pipe");
1193    }
1194
1195    #[test]
1196    fn test_md060_aligned_no_space_auto_compacts_wide_tables() {
1197        // Auto-compact should work with aligned-no-space when table exceeds max-width
1198        let config = MD060Config {
1199            enabled: true,
1200            style: "aligned-no-space".to_string(),
1201            max_width: LineLength::from_const(50),
1202            column_align: ColumnAlign::Auto,
1203            column_align_header: None,
1204            column_align_body: None,
1205            loose_last_column: false,
1206        };
1207        let rule = MD060TableFormat::from_config_struct(config, md013_with_line_length(80), false);
1208
1209        // Wide table that exceeds 50 chars when aligned
1210        let content = "| Very Long Column Header A | Very Long Column Header B | Very Long Column Header C |\n|---|---|---|\n| x | y | z |";
1211        let ctx = LintContext::new(content, crate::config::MarkdownFlavor::Standard, None);
1212
1213        let fixed = rule.fix(&ctx).unwrap();
1214
1215        // Should auto-compact to compact style (not aligned-no-space)
1216        assert!(
1217            fixed.contains("| --- |"),
1218            "Should be compact format when exceeding max-width"
1219        );
1220    }
1221
1222    #[test]
1223    fn test_md060_aligned_no_space_cjk_characters() {
1224        // CJK characters should be handled correctly
1225        let rule = MD060TableFormat::new(true, "aligned-no-space".to_string());
1226
1227        let content = "| Name | City |\n|---|---|\n| δΈ­ζ–‡ | 東京 |";
1228        let ctx = LintContext::new(content, crate::config::MarkdownFlavor::Standard, None);
1229
1230        let fixed = rule.fix(&ctx).unwrap();
1231        let lines: Vec<&str> = fixed.lines().collect();
1232
1233        // All rows should have equal DISPLAY width (not byte length)
1234        // CJK characters are double-width, so byte length differs from display width
1235        use unicode_width::UnicodeWidthStr;
1236        assert_eq!(
1237            lines[0].width(),
1238            lines[1].width(),
1239            "Header and delimiter should have same display width"
1240        );
1241        assert_eq!(
1242            lines[1].width(),
1243            lines[2].width(),
1244            "Delimiter and content should have same display width"
1245        );
1246
1247        // Delimiter should have no spaces
1248        assert!(!lines[1].contains("| -"), "Delimiter should NOT have space after pipe");
1249    }
1250
1251    #[test]
1252    fn test_md060_aligned_no_space_minimum_width() {
1253        // Minimum column width (3 dashes) should be respected
1254        let rule = MD060TableFormat::new(true, "aligned-no-space".to_string());
1255
1256        let content = "| A | B |\n|-|-|\n| 1 | 2 |";
1257        let ctx = LintContext::new(content, crate::config::MarkdownFlavor::Standard, None);
1258
1259        let fixed = rule.fix(&ctx).unwrap();
1260        let lines: Vec<&str> = fixed.lines().collect();
1261
1262        // Should have at least 3 dashes per column (GFM requirement)
1263        assert!(lines[1].contains("---"), "Should have minimum 3 dashes");
1264        // All rows should have equal length
1265        assert_eq!(lines[0].len(), lines[1].len());
1266        assert_eq!(lines[1].len(), lines[2].len());
1267    }
1268
1269    #[test]
1270    fn test_md060_any_style_consistency() {
1271        let rule = MD060TableFormat::new(true, "any".to_string());
1272
1273        // Table is already compact, should stay compact
1274        let content = "| Name | Age |\n| --- | --- |\n| Alice | 30 |";
1275        let ctx = LintContext::new(content, crate::config::MarkdownFlavor::Standard, None);
1276
1277        let fixed = rule.fix(&ctx).unwrap();
1278        assert_eq!(fixed, content);
1279
1280        // Table is aligned, should stay aligned
1281        let content_aligned = "| Name  | Age |\n| ----- | --- |\n| Alice | 30  |";
1282        let ctx_aligned = LintContext::new(content_aligned, crate::config::MarkdownFlavor::Standard, None);
1283
1284        let fixed_aligned = rule.fix(&ctx_aligned).unwrap();
1285        assert_eq!(fixed_aligned, content_aligned);
1286    }
1287
1288    #[test]
1289    fn test_md060_empty_cells() {
1290        let rule = MD060TableFormat::new(true, "aligned".to_string());
1291
1292        let content = "| A | B |\n|---|---|\n|  | X |";
1293        let ctx = LintContext::new(content, crate::config::MarkdownFlavor::Standard, None);
1294
1295        let fixed = rule.fix(&ctx).unwrap();
1296        assert!(fixed.contains("|"));
1297    }
1298
1299    #[test]
1300    fn test_md060_mixed_content() {
1301        let rule = MD060TableFormat::new(true, "aligned".to_string());
1302
1303        let content = "| Name | Age | City |\n|---|---|---|\n| δΈ­ζ–‡ | 30 | NYC |";
1304        let ctx = LintContext::new(content, crate::config::MarkdownFlavor::Standard, None);
1305
1306        let fixed = rule.fix(&ctx).unwrap();
1307        assert!(fixed.contains("δΈ­ζ–‡"));
1308        assert!(fixed.contains("NYC"));
1309    }
1310
1311    #[test]
1312    fn test_md060_preserve_alignment_indicators() {
1313        let rule = MD060TableFormat::new(true, "aligned".to_string());
1314
1315        let content = "| Left | Center | Right |\n|:---|:---:|---:|\n| A | B | C |";
1316        let ctx = LintContext::new(content, crate::config::MarkdownFlavor::Standard, None);
1317
1318        let fixed = rule.fix(&ctx).unwrap();
1319
1320        assert!(fixed.contains(":---"), "Should contain left alignment");
1321        assert!(fixed.contains(":----:"), "Should contain center alignment");
1322        assert!(fixed.contains("----:"), "Should contain right alignment");
1323    }
1324
1325    #[test]
1326    fn test_md060_minimum_column_width() {
1327        let rule = MD060TableFormat::new(true, "aligned".to_string());
1328
1329        // Test with very short column content to ensure minimum width of 3
1330        // GFM requires at least 3 dashes in delimiter rows
1331        let content = "| ID | Name |\n|-|-|\n| 1 | A |";
1332        let ctx = LintContext::new(content, crate::config::MarkdownFlavor::Standard, None);
1333
1334        let fixed = rule.fix(&ctx).unwrap();
1335
1336        let lines: Vec<&str> = fixed.lines().collect();
1337        assert_eq!(lines[0].len(), lines[1].len());
1338        assert_eq!(lines[1].len(), lines[2].len());
1339
1340        // Verify minimum width is enforced
1341        assert!(fixed.contains("ID "), "Short content should be padded");
1342        assert!(fixed.contains("---"), "Delimiter should have at least 3 dashes");
1343    }
1344
1345    #[test]
1346    fn test_md060_auto_compact_exceeds_default_threshold() {
1347        // Default max_width = 0, which inherits from default MD013 line_length = 80
1348        let config = MD060Config {
1349            enabled: true,
1350            style: "aligned".to_string(),
1351            max_width: LineLength::from_const(0),
1352            column_align: ColumnAlign::Auto,
1353            column_align_header: None,
1354            column_align_body: None,
1355            loose_last_column: false,
1356        };
1357        let rule = MD060TableFormat::from_config_struct(config, md013_with_line_length(80), false);
1358
1359        // Table that would be 85 chars when aligned (exceeds 80)
1360        // Formula: 1 + (3 * 3) + (20 + 20 + 30) = 1 + 9 + 70 = 80 chars
1361        // But with actual content padding it will exceed
1362        let content = "| Very Long Column Header | Another Long Header | Third Very Long Header Column |\n|---|---|---|\n| Short | Data | Here |";
1363        let ctx = LintContext::new(content, crate::config::MarkdownFlavor::Standard, None);
1364
1365        let fixed = rule.fix(&ctx).unwrap();
1366
1367        // Should use compact formatting (single spaces)
1368        assert!(fixed.contains("| Very Long Column Header | Another Long Header | Third Very Long Header Column |"));
1369        assert!(fixed.contains("| --- | --- | --- |"));
1370        assert!(fixed.contains("| Short | Data | Here |"));
1371
1372        // Verify it's compact (no extra padding)
1373        let lines: Vec<&str> = fixed.lines().collect();
1374        // In compact mode, lines can have different lengths
1375        assert!(lines[0].len() != lines[1].len() || lines[1].len() != lines[2].len());
1376    }
1377
1378    #[test]
1379    fn test_md060_auto_compact_exceeds_explicit_threshold() {
1380        // Explicit max_width = 50
1381        let config = MD060Config {
1382            enabled: true,
1383            style: "aligned".to_string(),
1384            max_width: LineLength::from_const(50),
1385            column_align: ColumnAlign::Auto,
1386            column_align_header: None,
1387            column_align_body: None,
1388            loose_last_column: false,
1389        };
1390        let rule = MD060TableFormat::from_config_struct(config, md013_with_line_length(80), false); // MD013 setting doesn't matter
1391
1392        // Table that would exceed 50 chars when aligned
1393        // Column widths: 25 + 25 + 25 = 75 chars
1394        // Formula: 1 + (3 * 3) + 75 = 85 chars (exceeds 50)
1395        let content = "| Very Long Column Header A | Very Long Column Header B | Very Long Column Header C |\n|---|---|---|\n| Data | Data | Data |";
1396        let ctx = LintContext::new(content, crate::config::MarkdownFlavor::Standard, None);
1397
1398        let fixed = rule.fix(&ctx).unwrap();
1399
1400        // Should use compact formatting (single spaces, no extra padding)
1401        assert!(
1402            fixed.contains("| Very Long Column Header A | Very Long Column Header B | Very Long Column Header C |")
1403        );
1404        assert!(fixed.contains("| --- | --- | --- |"));
1405        assert!(fixed.contains("| Data | Data | Data |"));
1406
1407        // Verify it's compact (lines have different lengths)
1408        let lines: Vec<&str> = fixed.lines().collect();
1409        assert!(lines[0].len() != lines[2].len());
1410    }
1411
1412    #[test]
1413    fn test_md060_stays_aligned_under_threshold() {
1414        // max_width = 100, table will be under this
1415        let config = MD060Config {
1416            enabled: true,
1417            style: "aligned".to_string(),
1418            max_width: LineLength::from_const(100),
1419            column_align: ColumnAlign::Auto,
1420            column_align_header: None,
1421            column_align_body: None,
1422            loose_last_column: false,
1423        };
1424        let rule = MD060TableFormat::from_config_struct(config, md013_with_line_length(80), false);
1425
1426        // Small table that fits well under 100 chars
1427        let content = "| Name | Age |\n|---|---|\n| Alice | 30 |";
1428        let ctx = LintContext::new(content, crate::config::MarkdownFlavor::Standard, None);
1429
1430        let fixed = rule.fix(&ctx).unwrap();
1431
1432        // Should use aligned formatting (all lines same length)
1433        let expected = "| Name  | Age |\n| ----- | --- |\n| Alice | 30  |";
1434        assert_eq!(fixed, expected);
1435
1436        let lines: Vec<&str> = fixed.lines().collect();
1437        assert_eq!(lines[0].len(), lines[1].len());
1438        assert_eq!(lines[1].len(), lines[2].len());
1439    }
1440
1441    #[test]
1442    fn test_md060_width_calculation_formula() {
1443        // Verify the width calculation formula: 1 + (num_columns * 3) + sum(column_widths)
1444        let config = MD060Config {
1445            enabled: true,
1446            style: "aligned".to_string(),
1447            max_width: LineLength::from_const(0),
1448            column_align: ColumnAlign::Auto,
1449            column_align_header: None,
1450            column_align_body: None,
1451            loose_last_column: false,
1452        };
1453        let rule = MD060TableFormat::from_config_struct(config, md013_with_line_length(30), false);
1454
1455        // Create a table where we know exact column widths: 5 + 5 + 5 = 15
1456        // Expected aligned width: 1 + (3 * 3) + 15 = 1 + 9 + 15 = 25 chars
1457        // This is under 30, so should stay aligned
1458        let content = "| AAAAA | BBBBB | CCCCC |\n|---|---|---|\n| AAAAA | BBBBB | CCCCC |";
1459        let ctx = LintContext::new(content, crate::config::MarkdownFlavor::Standard, None);
1460
1461        let fixed = rule.fix(&ctx).unwrap();
1462
1463        // Should be aligned
1464        let lines: Vec<&str> = fixed.lines().collect();
1465        assert_eq!(lines[0].len(), lines[1].len());
1466        assert_eq!(lines[1].len(), lines[2].len());
1467        assert_eq!(lines[0].len(), 25); // Verify formula
1468
1469        // Now test with threshold = 24 (just under aligned width)
1470        let config_tight = MD060Config {
1471            enabled: true,
1472            style: "aligned".to_string(),
1473            max_width: LineLength::from_const(24),
1474            column_align: ColumnAlign::Auto,
1475            column_align_header: None,
1476            column_align_body: None,
1477            loose_last_column: false,
1478        };
1479        let rule_tight = MD060TableFormat::from_config_struct(config_tight, md013_with_line_length(80), false);
1480
1481        let fixed_compact = rule_tight.fix(&ctx).unwrap();
1482
1483        // Should be compact now (25 > 24)
1484        assert!(fixed_compact.contains("| AAAAA | BBBBB | CCCCC |"));
1485        assert!(fixed_compact.contains("| --- | --- | --- |"));
1486    }
1487
1488    #[test]
1489    fn test_md060_very_wide_table_auto_compacts() {
1490        let config = MD060Config {
1491            enabled: true,
1492            style: "aligned".to_string(),
1493            max_width: LineLength::from_const(0),
1494            column_align: ColumnAlign::Auto,
1495            column_align_header: None,
1496            column_align_body: None,
1497            loose_last_column: false,
1498        };
1499        let rule = MD060TableFormat::from_config_struct(config, md013_with_line_length(80), false);
1500
1501        // Very wide table with many columns
1502        // 8 columns with widths of 12 chars each = 96 chars
1503        // Formula: 1 + (8 * 3) + 96 = 121 chars (exceeds 80)
1504        let content = "| Column One A | Column Two B | Column Three | Column Four D | Column Five E | Column Six FG | Column Seven | Column Eight |\n|---|---|---|---|---|---|---|---|\n| A | B | C | D | E | F | G | H |";
1505        let ctx = LintContext::new(content, crate::config::MarkdownFlavor::Standard, None);
1506
1507        let fixed = rule.fix(&ctx).unwrap();
1508
1509        // Should be compact (table would be way over 80 chars aligned)
1510        assert!(fixed.contains("| Column One A | Column Two B | Column Three | Column Four D | Column Five E | Column Six FG | Column Seven | Column Eight |"));
1511        assert!(fixed.contains("| --- | --- | --- | --- | --- | --- | --- | --- |"));
1512    }
1513
1514    #[test]
1515    fn test_md060_inherit_from_md013_line_length() {
1516        // max_width = 0 should inherit from MD013's line_length
1517        let config = MD060Config {
1518            enabled: true,
1519            style: "aligned".to_string(),
1520            max_width: LineLength::from_const(0), // Inherit
1521            column_align: ColumnAlign::Auto,
1522            column_align_header: None,
1523            column_align_body: None,
1524            loose_last_column: false,
1525        };
1526
1527        // Test with different MD013 line_length values
1528        let rule_80 = MD060TableFormat::from_config_struct(config.clone(), md013_with_line_length(80), false);
1529        let rule_120 = MD060TableFormat::from_config_struct(config.clone(), md013_with_line_length(120), false);
1530
1531        // Medium-sized table
1532        let content = "| Column Header A | Column Header B | Column Header C |\n|---|---|---|\n| Some Data | More Data | Even More |";
1533        let ctx = LintContext::new(content, crate::config::MarkdownFlavor::Standard, None);
1534
1535        // With 80 char limit, likely compacts
1536        let _fixed_80 = rule_80.fix(&ctx).unwrap();
1537
1538        // With 120 char limit, likely stays aligned
1539        let fixed_120 = rule_120.fix(&ctx).unwrap();
1540
1541        // Verify 120 is aligned (all lines same length)
1542        let lines_120: Vec<&str> = fixed_120.lines().collect();
1543        assert_eq!(lines_120[0].len(), lines_120[1].len());
1544        assert_eq!(lines_120[1].len(), lines_120[2].len());
1545    }
1546
1547    #[test]
1548    fn test_md060_edge_case_exactly_at_threshold() {
1549        // Create table that's exactly at the threshold
1550        // Formula: 1 + (num_columns * 3) + sum(column_widths) = max_width
1551        // For 2 columns with widths 5 and 5: 1 + 6 + 10 = 17
1552        let config = MD060Config {
1553            enabled: true,
1554            style: "aligned".to_string(),
1555            max_width: LineLength::from_const(17),
1556            column_align: ColumnAlign::Auto,
1557            column_align_header: None,
1558            column_align_body: None,
1559            loose_last_column: false,
1560        };
1561        let rule = MD060TableFormat::from_config_struct(config, md013_with_line_length(80), false);
1562
1563        let content = "| AAAAA | BBBBB |\n|---|---|\n| AAAAA | BBBBB |";
1564        let ctx = LintContext::new(content, crate::config::MarkdownFlavor::Standard, None);
1565
1566        let fixed = rule.fix(&ctx).unwrap();
1567
1568        // At threshold (17 <= 17), should stay aligned
1569        let lines: Vec<&str> = fixed.lines().collect();
1570        assert_eq!(lines[0].len(), 17);
1571        assert_eq!(lines[0].len(), lines[1].len());
1572        assert_eq!(lines[1].len(), lines[2].len());
1573
1574        // Now test with threshold = 16 (just under)
1575        let config_under = MD060Config {
1576            enabled: true,
1577            style: "aligned".to_string(),
1578            max_width: LineLength::from_const(16),
1579            column_align: ColumnAlign::Auto,
1580            column_align_header: None,
1581            column_align_body: None,
1582            loose_last_column: false,
1583        };
1584        let rule_under = MD060TableFormat::from_config_struct(config_under, md013_with_line_length(80), false);
1585
1586        let fixed_compact = rule_under.fix(&ctx).unwrap();
1587
1588        // Should compact (17 > 16)
1589        assert!(fixed_compact.contains("| AAAAA | BBBBB |"));
1590        assert!(fixed_compact.contains("| --- | --- |"));
1591    }
1592
1593    #[test]
1594    fn test_md060_auto_compact_warning_message() {
1595        // Verify that auto-compact generates an informative warning
1596        let config = MD060Config {
1597            enabled: true,
1598            style: "aligned".to_string(),
1599            max_width: LineLength::from_const(50),
1600            column_align: ColumnAlign::Auto,
1601            column_align_header: None,
1602            column_align_body: None,
1603            loose_last_column: false,
1604        };
1605        let rule = MD060TableFormat::from_config_struct(config, md013_with_line_length(80), false);
1606
1607        // Table that will be auto-compacted (exceeds 50 chars when aligned)
1608        let content = "| Very Long Column Header A | Very Long Column Header B | Very Long Column Header C |\n|---|---|---|\n| Data | Data | Data |";
1609        let ctx = LintContext::new(content, crate::config::MarkdownFlavor::Standard, None);
1610
1611        let warnings = rule.check(&ctx).unwrap();
1612
1613        // Should generate warnings with auto-compact message
1614        assert!(!warnings.is_empty(), "Should generate warnings");
1615
1616        let auto_compact_warnings: Vec<_> = warnings
1617            .iter()
1618            .filter(|w| w.message.contains("too wide for aligned formatting"))
1619            .collect();
1620
1621        assert!(!auto_compact_warnings.is_empty(), "Should have auto-compact warning");
1622
1623        // Verify the warning message includes the width and threshold
1624        let first_warning = auto_compact_warnings[0];
1625        assert!(first_warning.message.contains("85 chars > max-width: 50"));
1626        assert!(first_warning.message.contains("Table too wide for aligned formatting"));
1627    }
1628
1629    #[test]
1630    fn test_md060_issue_129_detect_style_from_all_rows() {
1631        // Issue #129: detect_table_style should check all rows, not just the first row
1632        // If header row has single-space padding but content rows have extra padding,
1633        // the table should be detected as "aligned" and preserved
1634        let rule = MD060TableFormat::new(true, "any".to_string());
1635
1636        // Table where header looks compact but content is aligned
1637        let content = "| a long heading | another long heading |\n\
1638                       | -------------- | -------------------- |\n\
1639                       | a              | 1                    |\n\
1640                       | b b            | 2                    |\n\
1641                       | c c c          | 3                    |";
1642        let ctx = LintContext::new(content, crate::config::MarkdownFlavor::Standard, None);
1643
1644        let fixed = rule.fix(&ctx).unwrap();
1645
1646        // Should preserve the aligned formatting of content rows
1647        assert!(
1648            fixed.contains("| a              | 1                    |"),
1649            "Should preserve aligned padding in first content row"
1650        );
1651        assert!(
1652            fixed.contains("| b b            | 2                    |"),
1653            "Should preserve aligned padding in second content row"
1654        );
1655        assert!(
1656            fixed.contains("| c c c          | 3                    |"),
1657            "Should preserve aligned padding in third content row"
1658        );
1659
1660        // Entire table should remain unchanged because it's already properly aligned
1661        assert_eq!(fixed, content, "Table should be detected as aligned and preserved");
1662    }
1663
1664    #[test]
1665    fn test_md060_regular_alignment_warning_message() {
1666        // Verify that regular alignment (not auto-compact) generates normal warning
1667        let config = MD060Config {
1668            enabled: true,
1669            style: "aligned".to_string(),
1670            max_width: LineLength::from_const(100), // Large enough to not trigger auto-compact
1671            column_align: ColumnAlign::Auto,
1672            column_align_header: None,
1673            column_align_body: None,
1674            loose_last_column: false,
1675        };
1676        let rule = MD060TableFormat::from_config_struct(config, md013_with_line_length(80), false);
1677
1678        // Small misaligned table
1679        let content = "| Name | Age |\n|---|---|\n| Alice | 30 |";
1680        let ctx = LintContext::new(content, crate::config::MarkdownFlavor::Standard, None);
1681
1682        let warnings = rule.check(&ctx).unwrap();
1683
1684        // Should generate warnings
1685        assert!(!warnings.is_empty(), "Should generate warnings");
1686
1687        // Verify it's the standard alignment message, not auto-compact
1688        assert!(warnings[0].message.contains("Table columns should be aligned"));
1689        assert!(!warnings[0].message.contains("too wide"));
1690        assert!(!warnings[0].message.contains("max-width"));
1691    }
1692
1693    // === Issue #219: Unlimited table width tests ===
1694
1695    #[test]
1696    fn test_md060_unlimited_when_md013_disabled() {
1697        // When MD013 is globally disabled, max_width should be unlimited
1698        let config = MD060Config {
1699            enabled: true,
1700            style: "aligned".to_string(),
1701            max_width: LineLength::from_const(0), // Inherit
1702            column_align: ColumnAlign::Auto,
1703            column_align_header: None,
1704            column_align_body: None,
1705            loose_last_column: false,
1706        };
1707        let md013_config = MD013Config::default();
1708        let rule = MD060TableFormat::from_config_struct(config, md013_config, true /* disabled */);
1709
1710        // Very wide table that would normally exceed 80 chars
1711        let content = "| Very Long Column Header A | Very Long Column Header B | Very Long Column Header C |\n|---|---|---|\n| data | data | data |";
1712        let ctx = LintContext::new(content, crate::config::MarkdownFlavor::Standard, None);
1713        let fixed = rule.fix(&ctx).unwrap();
1714
1715        // Should be aligned (not compacted) since MD013 is disabled
1716        let lines: Vec<&str> = fixed.lines().collect();
1717        // In aligned mode, all lines have the same length
1718        assert_eq!(
1719            lines[0].len(),
1720            lines[1].len(),
1721            "Table should be aligned when MD013 is disabled"
1722        );
1723    }
1724
1725    #[test]
1726    fn test_md060_unlimited_when_md013_tables_false() {
1727        // When MD013.tables = false, max_width should be unlimited
1728        let config = MD060Config {
1729            enabled: true,
1730            style: "aligned".to_string(),
1731            max_width: LineLength::from_const(0),
1732            column_align: ColumnAlign::Auto,
1733            column_align_header: None,
1734            column_align_body: None,
1735            loose_last_column: false,
1736        };
1737        let md013_config = MD013Config {
1738            tables: false, // User doesn't care about table line length
1739            line_length: LineLength::from_const(80),
1740            ..Default::default()
1741        };
1742        let rule = MD060TableFormat::from_config_struct(config, md013_config, false);
1743
1744        // Wide table that would exceed 80 chars
1745        let content = "| Very Long Header A | Very Long Header B | Very Long Header C |\n|---|---|---|\n| x | y | z |";
1746        let ctx = LintContext::new(content, crate::config::MarkdownFlavor::Standard, None);
1747        let fixed = rule.fix(&ctx).unwrap();
1748
1749        // Should be aligned (no auto-compact since tables=false)
1750        let lines: Vec<&str> = fixed.lines().collect();
1751        assert_eq!(
1752            lines[0].len(),
1753            lines[1].len(),
1754            "Table should be aligned when MD013.tables=false"
1755        );
1756    }
1757
1758    #[test]
1759    fn test_md060_unlimited_when_md013_line_length_zero() {
1760        // When MD013.line_length = 0, max_width should be unlimited
1761        let config = MD060Config {
1762            enabled: true,
1763            style: "aligned".to_string(),
1764            max_width: LineLength::from_const(0),
1765            column_align: ColumnAlign::Auto,
1766            column_align_header: None,
1767            column_align_body: None,
1768            loose_last_column: false,
1769        };
1770        let md013_config = MD013Config {
1771            tables: true,
1772            line_length: LineLength::from_const(0), // No limit
1773            ..Default::default()
1774        };
1775        let rule = MD060TableFormat::from_config_struct(config, md013_config, false);
1776
1777        // Wide table
1778        let content = "| Very Long Header | Another Long Header | Third Long Header |\n|---|---|---|\n| x | y | z |";
1779        let ctx = LintContext::new(content, crate::config::MarkdownFlavor::Standard, None);
1780        let fixed = rule.fix(&ctx).unwrap();
1781
1782        // Should be aligned
1783        let lines: Vec<&str> = fixed.lines().collect();
1784        assert_eq!(
1785            lines[0].len(),
1786            lines[1].len(),
1787            "Table should be aligned when MD013.line_length=0"
1788        );
1789    }
1790
1791    #[test]
1792    fn test_md060_explicit_max_width_overrides_md013_settings() {
1793        // Explicit max_width should always take precedence
1794        let config = MD060Config {
1795            enabled: true,
1796            style: "aligned".to_string(),
1797            max_width: LineLength::from_const(50), // Explicit limit
1798            column_align: ColumnAlign::Auto,
1799            column_align_header: None,
1800            column_align_body: None,
1801            loose_last_column: false,
1802        };
1803        let md013_config = MD013Config {
1804            tables: false,                          // This would make it unlimited...
1805            line_length: LineLength::from_const(0), // ...and this too
1806            ..Default::default()
1807        };
1808        let rule = MD060TableFormat::from_config_struct(config, md013_config, false);
1809
1810        // Wide table that exceeds explicit 50-char limit
1811        let content = "| Very Long Column Header A | Very Long Column Header B | Very Long Column Header C |\n|---|---|---|\n| x | y | z |";
1812        let ctx = LintContext::new(content, crate::config::MarkdownFlavor::Standard, None);
1813        let fixed = rule.fix(&ctx).unwrap();
1814
1815        // Should be compact (explicit max_width = 50 overrides MD013 settings)
1816        assert!(
1817            fixed.contains("| --- |"),
1818            "Should be compact format due to explicit max_width"
1819        );
1820    }
1821
1822    #[test]
1823    fn test_md060_inherits_md013_line_length_when_tables_enabled() {
1824        // When MD013.tables = true and MD013.line_length is set, inherit that limit
1825        let config = MD060Config {
1826            enabled: true,
1827            style: "aligned".to_string(),
1828            max_width: LineLength::from_const(0), // Inherit
1829            column_align: ColumnAlign::Auto,
1830            column_align_header: None,
1831            column_align_body: None,
1832            loose_last_column: false,
1833        };
1834        let md013_config = MD013Config {
1835            tables: true,
1836            line_length: LineLength::from_const(50), // 50 char limit
1837            ..Default::default()
1838        };
1839        let rule = MD060TableFormat::from_config_struct(config, md013_config, false);
1840
1841        // Wide table that exceeds 50 chars
1842        let content = "| Very Long Column Header A | Very Long Column Header B | Very Long Column Header C |\n|---|---|---|\n| x | y | z |";
1843        let ctx = LintContext::new(content, crate::config::MarkdownFlavor::Standard, None);
1844        let fixed = rule.fix(&ctx).unwrap();
1845
1846        // Should be compact (inherited 50-char limit from MD013)
1847        assert!(
1848            fixed.contains("| --- |"),
1849            "Should be compact format when inheriting MD013 limit"
1850        );
1851    }
1852
1853    // === Issue #311: aligned-no-space style tests ===
1854
1855    #[test]
1856    fn test_aligned_no_space_reformats_spaced_delimiter() {
1857        // Table with "aligned" style (spaces around dashes) should be reformatted
1858        // when target style is "aligned-no-space"
1859        let config = MD060Config {
1860            enabled: true,
1861            style: "aligned-no-space".to_string(),
1862            max_width: LineLength::from_const(0),
1863            column_align: ColumnAlign::Auto,
1864            column_align_header: None,
1865            column_align_body: None,
1866            loose_last_column: false,
1867        };
1868        let rule = MD060TableFormat::from_config_struct(config, MD013Config::default(), false);
1869
1870        // Input: aligned table with spaces around dashes
1871        let content = "| Header 1 | Header 2 |\n| -------- | -------- |\n| Cell 1   | Cell 2   |";
1872        let ctx = LintContext::new(content, crate::config::MarkdownFlavor::Standard, None);
1873        let fixed = rule.fix(&ctx).unwrap();
1874
1875        // Should have no spaces around dashes in delimiter row
1876        // The dashes may be longer to match column width, but should have no spaces
1877        assert!(
1878            !fixed.contains("| ----"),
1879            "Delimiter should NOT have spaces after pipe. Got:\n{fixed}"
1880        );
1881        assert!(
1882            !fixed.contains("---- |"),
1883            "Delimiter should NOT have spaces before pipe. Got:\n{fixed}"
1884        );
1885        // Verify it has the compact delimiter format (dashes touching pipes)
1886        assert!(
1887            fixed.contains("|----"),
1888            "Delimiter should have dashes touching the leading pipe. Got:\n{fixed}"
1889        );
1890    }
1891
1892    #[test]
1893    fn test_aligned_reformats_compact_delimiter() {
1894        // Table with "aligned-no-space" style (no spaces around dashes) should be reformatted
1895        // when target style is "aligned"
1896        let config = MD060Config {
1897            enabled: true,
1898            style: "aligned".to_string(),
1899            max_width: LineLength::from_const(0),
1900            column_align: ColumnAlign::Auto,
1901            column_align_header: None,
1902            column_align_body: None,
1903            loose_last_column: false,
1904        };
1905        let rule = MD060TableFormat::from_config_struct(config, MD013Config::default(), false);
1906
1907        // Input: aligned-no-space table (no spaces around dashes)
1908        let content = "| Header 1 | Header 2 |\n|----------|----------|\n| Cell 1   | Cell 2   |";
1909        let ctx = LintContext::new(content, crate::config::MarkdownFlavor::Standard, None);
1910        let fixed = rule.fix(&ctx).unwrap();
1911
1912        // Should have spaces around dashes in delimiter row
1913        assert!(
1914            fixed.contains("| -------- | -------- |") || fixed.contains("| ---------- | ---------- |"),
1915            "Delimiter should have spaces around dashes. Got:\n{fixed}"
1916        );
1917    }
1918
1919    #[test]
1920    fn test_aligned_no_space_preserves_matching_table() {
1921        // Table already in "aligned-no-space" style should be preserved
1922        let config = MD060Config {
1923            enabled: true,
1924            style: "aligned-no-space".to_string(),
1925            max_width: LineLength::from_const(0),
1926            column_align: ColumnAlign::Auto,
1927            column_align_header: None,
1928            column_align_body: None,
1929            loose_last_column: false,
1930        };
1931        let rule = MD060TableFormat::from_config_struct(config, MD013Config::default(), false);
1932
1933        // Input: already in aligned-no-space style
1934        let content = "| Header 1 | Header 2 |\n|----------|----------|\n| Cell 1   | Cell 2   |";
1935        let ctx = LintContext::new(content, crate::config::MarkdownFlavor::Standard, None);
1936        let fixed = rule.fix(&ctx).unwrap();
1937
1938        // Should be preserved as-is
1939        assert_eq!(
1940            fixed, content,
1941            "Table already in aligned-no-space style should be preserved"
1942        );
1943    }
1944
1945    #[test]
1946    fn test_aligned_preserves_matching_table() {
1947        // Table already in "aligned" style should be preserved
1948        let config = MD060Config {
1949            enabled: true,
1950            style: "aligned".to_string(),
1951            max_width: LineLength::from_const(0),
1952            column_align: ColumnAlign::Auto,
1953            column_align_header: None,
1954            column_align_body: None,
1955            loose_last_column: false,
1956        };
1957        let rule = MD060TableFormat::from_config_struct(config, MD013Config::default(), false);
1958
1959        // Input: already in aligned style
1960        let content = "| Header 1 | Header 2 |\n| -------- | -------- |\n| Cell 1   | Cell 2   |";
1961        let ctx = LintContext::new(content, crate::config::MarkdownFlavor::Standard, None);
1962        let fixed = rule.fix(&ctx).unwrap();
1963
1964        // Should be preserved as-is
1965        assert_eq!(fixed, content, "Table already in aligned style should be preserved");
1966    }
1967
1968    #[test]
1969    fn test_cjk_table_display_width_consistency() {
1970        // Test that is_table_already_aligned correctly uses display width, not byte length
1971        // CJK characters have display width of 2, but byte length of 3 in UTF-8
1972        //
1973        // This table is NOT aligned because line lengths differ
1974        // (CJK chars take 3 bytes in UTF-8 but only 2 columns in display)
1975        let table_lines = vec!["| 名前 | Age |", "|------|-----|", "| η”°δΈ­ | 25  |"];
1976
1977        // First check is raw line length equality (byte-based), which fails
1978        let is_aligned =
1979            MD060TableFormat::is_table_already_aligned(&table_lines, crate::config::MarkdownFlavor::Standard, false);
1980        assert!(
1981            !is_aligned,
1982            "Table with uneven raw line lengths should NOT be considered aligned"
1983        );
1984    }
1985
1986    #[test]
1987    fn test_cjk_width_calculation_in_aligned_check() {
1988        // calculate_cell_display_width trims content before calculating width
1989        // Verify CJK width is correctly calculated (2 per character)
1990        let cjk_width = MD060TableFormat::calculate_cell_display_width("名前");
1991        assert_eq!(cjk_width, 4, "Two CJK characters should have display width 4");
1992
1993        let ascii_width = MD060TableFormat::calculate_cell_display_width("Age");
1994        assert_eq!(ascii_width, 3, "Three ASCII characters should have display width 3");
1995
1996        // Test that spacing is trimmed before width calculation
1997        let padded_cjk = MD060TableFormat::calculate_cell_display_width(" 名前 ");
1998        assert_eq!(padded_cjk, 4, "Padded CJK should have same width after trim");
1999
2000        // Test mixed content
2001        let mixed = MD060TableFormat::calculate_cell_display_width(" ζ—₯本θͺžABC ");
2002        // 3 CJK chars (width 6) + 3 ASCII (width 3) = 9
2003        assert_eq!(mixed, 9, "Mixed CJK/ASCII content");
2004    }
2005
2006    // === Issue #317: column-align option tests ===
2007
2008    #[test]
2009    fn test_md060_column_align_left() {
2010        // Default/explicit left alignment
2011        let config = MD060Config {
2012            enabled: true,
2013            style: "aligned".to_string(),
2014            max_width: LineLength::from_const(0),
2015            column_align: ColumnAlign::Left,
2016            column_align_header: None,
2017            column_align_body: None,
2018            loose_last_column: false,
2019        };
2020        let rule = MD060TableFormat::from_config_struct(config, MD013Config::default(), false);
2021
2022        let content = "| Name | Age | City |\n|---|---|---|\n| Alice | 30 | Seattle |\n| Bob | 25 | Portland |";
2023        let ctx = LintContext::new(content, crate::config::MarkdownFlavor::Standard, None);
2024
2025        let fixed = rule.fix(&ctx).unwrap();
2026        let lines: Vec<&str> = fixed.lines().collect();
2027
2028        // Left aligned: content on left, padding on right
2029        assert!(
2030            lines[2].contains("| Alice "),
2031            "Content should be left-aligned (Alice should have trailing padding)"
2032        );
2033        assert!(
2034            lines[3].contains("| Bob   "),
2035            "Content should be left-aligned (Bob should have trailing padding)"
2036        );
2037    }
2038
2039    #[test]
2040    fn test_md060_column_align_center() {
2041        // Center alignment forces all columns to center
2042        let config = MD060Config {
2043            enabled: true,
2044            style: "aligned".to_string(),
2045            max_width: LineLength::from_const(0),
2046            column_align: ColumnAlign::Center,
2047            column_align_header: None,
2048            column_align_body: None,
2049            loose_last_column: false,
2050        };
2051        let rule = MD060TableFormat::from_config_struct(config, MD013Config::default(), false);
2052
2053        let content = "| Name | Age | City |\n|---|---|---|\n| Alice | 30 | Seattle |\n| Bob | 25 | Portland |";
2054        let ctx = LintContext::new(content, crate::config::MarkdownFlavor::Standard, None);
2055
2056        let fixed = rule.fix(&ctx).unwrap();
2057        let lines: Vec<&str> = fixed.lines().collect();
2058
2059        // Center aligned: padding split on both sides
2060        // "Bob" (3 chars) in "Name" column (5 chars) = 2 padding total, 1 left, 1 right
2061        assert!(
2062            lines[3].contains("|  Bob  |"),
2063            "Bob should be centered with padding on both sides. Got: {}",
2064            lines[3]
2065        );
2066    }
2067
2068    #[test]
2069    fn test_md060_column_align_right() {
2070        // Right alignment forces all columns to right-align
2071        let config = MD060Config {
2072            enabled: true,
2073            style: "aligned".to_string(),
2074            max_width: LineLength::from_const(0),
2075            column_align: ColumnAlign::Right,
2076            column_align_header: None,
2077            column_align_body: None,
2078            loose_last_column: false,
2079        };
2080        let rule = MD060TableFormat::from_config_struct(config, MD013Config::default(), false);
2081
2082        let content = "| Name | Age | City |\n|---|---|---|\n| Alice | 30 | Seattle |\n| Bob | 25 | Portland |";
2083        let ctx = LintContext::new(content, crate::config::MarkdownFlavor::Standard, None);
2084
2085        let fixed = rule.fix(&ctx).unwrap();
2086        let lines: Vec<&str> = fixed.lines().collect();
2087
2088        // Right aligned: padding on left, content on right
2089        assert!(
2090            lines[3].contains("|   Bob |"),
2091            "Bob should be right-aligned with padding on left. Got: {}",
2092            lines[3]
2093        );
2094    }
2095
2096    #[test]
2097    fn test_md060_column_align_auto_respects_delimiter() {
2098        // Auto mode (default) should respect delimiter row alignment indicators
2099        let config = MD060Config {
2100            enabled: true,
2101            style: "aligned".to_string(),
2102            max_width: LineLength::from_const(0),
2103            column_align: ColumnAlign::Auto,
2104            column_align_header: None,
2105            column_align_body: None,
2106            loose_last_column: false,
2107        };
2108        let rule = MD060TableFormat::from_config_struct(config, MD013Config::default(), false);
2109
2110        // Left, center, right columns via delimiter indicators
2111        let content = "| Left | Center | Right |\n|:---|:---:|---:|\n| A | B | C |";
2112        let ctx = LintContext::new(content, crate::config::MarkdownFlavor::Standard, None);
2113
2114        let fixed = rule.fix(&ctx).unwrap();
2115
2116        // Verify alignment is applied per-column based on delimiter
2117        assert!(fixed.contains("| A "), "Left column should be left-aligned");
2118        // Center and right columns with longer content in header
2119        let lines: Vec<&str> = fixed.lines().collect();
2120        // The content row should have B centered and C right-aligned
2121        // B (1 char) in "Center" (6 chars) = 5 padding, ~2 left, ~3 right
2122        // C (1 char) in "Right" (5 chars) = 4 padding, all on left
2123        assert!(
2124            lines[2].contains(" C |"),
2125            "Right column should be right-aligned. Got: {}",
2126            lines[2]
2127        );
2128    }
2129
2130    #[test]
2131    fn test_md060_column_align_overrides_delimiter_indicators() {
2132        // column-align should override delimiter row indicators
2133        let config = MD060Config {
2134            enabled: true,
2135            style: "aligned".to_string(),
2136            max_width: LineLength::from_const(0),
2137            column_align: ColumnAlign::Right, // Override all to right
2138            column_align_header: None,
2139            column_align_body: None,
2140            loose_last_column: false,
2141        };
2142        let rule = MD060TableFormat::from_config_struct(config, MD013Config::default(), false);
2143
2144        // Delimiter says left, center, right - but we override all to right
2145        let content = "| Left | Center | Right |\n|:---|:---:|---:|\n| A | B | C |";
2146        let ctx = LintContext::new(content, crate::config::MarkdownFlavor::Standard, None);
2147
2148        let fixed = rule.fix(&ctx).unwrap();
2149        let lines: Vec<&str> = fixed.lines().collect();
2150
2151        // ALL columns should be right-aligned despite delimiter indicators
2152        // "A" in "Left" column (4 chars minimum due to header length) should be right-aligned
2153        assert!(
2154            lines[2].contains("    A |") || lines[2].contains("   A |"),
2155            "Even left-indicated column should be right-aligned. Got: {}",
2156            lines[2]
2157        );
2158    }
2159
2160    #[test]
2161    fn test_md060_column_align_with_aligned_no_space() {
2162        // column-align should work with aligned-no-space style
2163        let config = MD060Config {
2164            enabled: true,
2165            style: "aligned-no-space".to_string(),
2166            max_width: LineLength::from_const(0),
2167            column_align: ColumnAlign::Center,
2168            column_align_header: None,
2169            column_align_body: None,
2170            loose_last_column: false,
2171        };
2172        let rule = MD060TableFormat::from_config_struct(config, MD013Config::default(), false);
2173
2174        let content = "| Name | Age |\n|---|---|\n| Alice | 30 |\n| Bob | 25 |";
2175        let ctx = LintContext::new(content, crate::config::MarkdownFlavor::Standard, None);
2176
2177        let fixed = rule.fix(&ctx).unwrap();
2178        let lines: Vec<&str> = fixed.lines().collect();
2179
2180        // Delimiter row should have no spaces (aligned-no-space)
2181        assert!(
2182            lines[1].contains("|---"),
2183            "Delimiter should have no spaces in aligned-no-space style. Got: {}",
2184            lines[1]
2185        );
2186        // Content should still be centered
2187        assert!(
2188            lines[3].contains("|  Bob  |"),
2189            "Content should be centered. Got: {}",
2190            lines[3]
2191        );
2192    }
2193
2194    #[test]
2195    fn test_md060_column_align_config_parsing() {
2196        // Test that column-align config is correctly parsed
2197        let toml_str = r#"
2198enabled = true
2199style = "aligned"
2200column-align = "center"
2201"#;
2202        let config: MD060Config = toml::from_str(toml_str).expect("Should parse config");
2203        assert_eq!(config.column_align, ColumnAlign::Center);
2204
2205        let toml_str = r#"
2206enabled = true
2207style = "aligned"
2208column-align = "right"
2209"#;
2210        let config: MD060Config = toml::from_str(toml_str).expect("Should parse config");
2211        assert_eq!(config.column_align, ColumnAlign::Right);
2212
2213        let toml_str = r#"
2214enabled = true
2215style = "aligned"
2216column-align = "left"
2217"#;
2218        let config: MD060Config = toml::from_str(toml_str).expect("Should parse config");
2219        assert_eq!(config.column_align, ColumnAlign::Left);
2220
2221        let toml_str = r#"
2222enabled = true
2223style = "aligned"
2224column-align = "auto"
2225"#;
2226        let config: MD060Config = toml::from_str(toml_str).expect("Should parse config");
2227        assert_eq!(config.column_align, ColumnAlign::Auto);
2228    }
2229
2230    #[test]
2231    fn test_md060_column_align_default_is_auto() {
2232        // Without column-align specified, default should be Auto
2233        let toml_str = r#"
2234enabled = true
2235style = "aligned"
2236"#;
2237        let config: MD060Config = toml::from_str(toml_str).expect("Should parse config");
2238        assert_eq!(config.column_align, ColumnAlign::Auto);
2239    }
2240
2241    #[test]
2242    fn test_md060_column_align_reformats_already_aligned_table() {
2243        // A table that is already aligned (left) should be reformatted when column-align=right
2244        let config = MD060Config {
2245            enabled: true,
2246            style: "aligned".to_string(),
2247            max_width: LineLength::from_const(0),
2248            column_align: ColumnAlign::Right,
2249            column_align_header: None,
2250            column_align_body: None,
2251            loose_last_column: false,
2252        };
2253        let rule = MD060TableFormat::from_config_struct(config, MD013Config::default(), false);
2254
2255        // This table is already properly aligned with left alignment
2256        let content = "| Name  | Age |\n| ----- | --- |\n| Alice | 30  |\n| Bob   | 25  |";
2257        let ctx = LintContext::new(content, crate::config::MarkdownFlavor::Standard, None);
2258
2259        let fixed = rule.fix(&ctx).unwrap();
2260        let lines: Vec<&str> = fixed.lines().collect();
2261
2262        // Should be reformatted with right alignment
2263        assert!(
2264            lines[2].contains("| Alice |") && lines[2].contains("|  30 |"),
2265            "Already aligned table should be reformatted with right alignment. Got: {}",
2266            lines[2]
2267        );
2268        assert!(
2269            lines[3].contains("|   Bob |") || lines[3].contains("|  Bob |"),
2270            "Bob should be right-aligned. Got: {}",
2271            lines[3]
2272        );
2273    }
2274
2275    #[test]
2276    fn test_md060_column_align_with_cjk_characters() {
2277        // CJK characters have double display width - centering should account for this
2278        let config = MD060Config {
2279            enabled: true,
2280            style: "aligned".to_string(),
2281            max_width: LineLength::from_const(0),
2282            column_align: ColumnAlign::Center,
2283            column_align_header: None,
2284            column_align_body: None,
2285            loose_last_column: false,
2286        };
2287        let rule = MD060TableFormat::from_config_struct(config, MD013Config::default(), false);
2288
2289        let content = "| Name | City |\n|---|---|\n| Alice | 東京 |\n| Bob | LA |";
2290        let ctx = LintContext::new(content, crate::config::MarkdownFlavor::Standard, None);
2291
2292        let fixed = rule.fix(&ctx).unwrap();
2293
2294        // Both Alice and Bob should be centered, and 東京 should be properly aligned
2295        // considering its double-width display
2296        assert!(fixed.contains("Bob"), "Table should contain Bob");
2297        assert!(fixed.contains("東京"), "Table should contain 東京");
2298    }
2299
2300    #[test]
2301    fn test_md060_column_align_ignored_for_compact_style() {
2302        // column-align should have no effect on compact style (minimal padding)
2303        let config = MD060Config {
2304            enabled: true,
2305            style: "compact".to_string(),
2306            max_width: LineLength::from_const(0),
2307            column_align: ColumnAlign::Right, // This should be ignored
2308            column_align_header: None,
2309            column_align_body: None,
2310            loose_last_column: false,
2311        };
2312        let rule = MD060TableFormat::from_config_struct(config, MD013Config::default(), false);
2313
2314        let content = "| Name | Age |\n|---|---|\n| Alice | 30 |\n| Bob | 25 |";
2315        let ctx = LintContext::new(content, crate::config::MarkdownFlavor::Standard, None);
2316
2317        let fixed = rule.fix(&ctx).unwrap();
2318
2319        // Compact style: single space padding, no alignment
2320        assert!(
2321            fixed.contains("| Alice |"),
2322            "Compact style should have single space padding, not alignment. Got: {fixed}"
2323        );
2324    }
2325
2326    #[test]
2327    fn test_md060_column_align_ignored_for_tight_style() {
2328        // column-align should have no effect on tight style (no padding)
2329        let config = MD060Config {
2330            enabled: true,
2331            style: "tight".to_string(),
2332            max_width: LineLength::from_const(0),
2333            column_align: ColumnAlign::Center, // This should be ignored
2334            column_align_header: None,
2335            column_align_body: None,
2336            loose_last_column: false,
2337        };
2338        let rule = MD060TableFormat::from_config_struct(config, MD013Config::default(), false);
2339
2340        let content = "| Name | Age |\n|---|---|\n| Alice | 30 |\n| Bob | 25 |";
2341        let ctx = LintContext::new(content, crate::config::MarkdownFlavor::Standard, None);
2342
2343        let fixed = rule.fix(&ctx).unwrap();
2344
2345        // Tight style: no spaces at all
2346        assert!(
2347            fixed.contains("|Alice|"),
2348            "Tight style should have no spaces. Got: {fixed}"
2349        );
2350    }
2351
2352    #[test]
2353    fn test_md060_column_align_with_empty_cells() {
2354        // Empty cells should be handled correctly with centering
2355        let config = MD060Config {
2356            enabled: true,
2357            style: "aligned".to_string(),
2358            max_width: LineLength::from_const(0),
2359            column_align: ColumnAlign::Center,
2360            column_align_header: None,
2361            column_align_body: None,
2362            loose_last_column: false,
2363        };
2364        let rule = MD060TableFormat::from_config_struct(config, MD013Config::default(), false);
2365
2366        let content = "| Name | Age |\n|---|---|\n| Alice | 30 |\n|  | 25 |";
2367        let ctx = LintContext::new(content, crate::config::MarkdownFlavor::Standard, None);
2368
2369        let fixed = rule.fix(&ctx).unwrap();
2370        let lines: Vec<&str> = fixed.lines().collect();
2371
2372        // Empty cell should have all padding (centered empty string)
2373        assert!(
2374            lines[3].contains("|       |") || lines[3].contains("|      |"),
2375            "Empty cell should be padded correctly. Got: {}",
2376            lines[3]
2377        );
2378    }
2379
2380    #[test]
2381    fn test_md060_column_align_auto_preserves_already_aligned() {
2382        // With column-align=auto (default), already aligned tables should be preserved
2383        let config = MD060Config {
2384            enabled: true,
2385            style: "aligned".to_string(),
2386            max_width: LineLength::from_const(0),
2387            column_align: ColumnAlign::Auto,
2388            column_align_header: None,
2389            column_align_body: None,
2390            loose_last_column: false,
2391        };
2392        let rule = MD060TableFormat::from_config_struct(config, MD013Config::default(), false);
2393
2394        // This table is already properly aligned
2395        let content = "| Name  | Age |\n| ----- | --- |\n| Alice | 30  |\n| Bob   | 25  |";
2396        let ctx = LintContext::new(content, crate::config::MarkdownFlavor::Standard, None);
2397
2398        let fixed = rule.fix(&ctx).unwrap();
2399
2400        // Should be preserved as-is
2401        assert_eq!(
2402            fixed, content,
2403            "Already aligned table should be preserved with column-align=auto"
2404        );
2405    }
2406}