Skip to main content

rudb_vector/
string.rs

1//! The string representation.
2//!
3//! `spec/07-execution.md` section 7.1: a string is a 16 byte structure, 4 bytes of length, 4 bytes
4//! of prefix, and 8 bytes that are either the rest of a short string or a way to find a long one.
5//! Strings of 12 bytes or fewer live entirely inside the structure. The prefix means most
6//! comparisons and most equality tests answer without dereferencing anything, which on the string
7//! heavy queries in ClickBench is the difference between a cache hit and a cache miss per row.
8//!
9//! **Where this differs from the specification, and why.** The document says the last 8 bytes are
10//! a pointer, which is what DuckDB and Umbra do. Here they are a block index and an offset, which
11//! is what Arrow's `StringView` does. The sizes are identical, the prefix trick is identical, and
12//! the prefix trick is the part that makes it fast. The difference is one predictable load against
13//! one pointer chase on the slow path only, and in exchange the whole representation is safe code
14//! with no pinning machinery, which does not exist until the buffer manager arrives at M2. This is
15//! the kind of decision that gets remeasured rather than argued about, and it is tracked as an
16//! issue so that M3 measures it instead of inheriting it.
17
18use rudb_common::{Error, Result};
19
20use crate::buffer::Buffer;
21
22/// The longest string that fits entirely inside a view.
23pub const INLINE_LIMIT: usize = 12;
24
25/// A 16 byte handle on a string.
26///
27/// The layout is a `u32` length and 12 bytes of payload. For a string of 12 bytes or fewer the
28/// payload is the string, zero padded. For a longer one the first 4 bytes are the prefix and the
29/// last 8 are the offset into the column's arena.
30///
31/// Arrow spends 4 of those 8 bytes on a buffer index and 4 on an offset within the buffer, because
32/// an Arrow array is a list of buffers. This column is one arena, so there is no buffer to name and
33/// the whole 8 bytes are the offset, which reads as one load rather than two and takes the reachable
34/// size of a column from 4 GiB to more than anything will ever put in one.
35///
36/// A view on its own cannot produce a long string, only a short one. That is deliberate: the arena
37/// lives in the [`StringColumn`] and the borrow checker is what stops a view from outliving it,
38/// rather than a rule somebody has to remember.
39#[derive(Debug, Clone, Copy, PartialEq, Eq, Hash)]
40pub struct StringView {
41    length: u32,
42    payload: [u8; 12],
43}
44
45impl StringView {
46    /// The view on the empty string.
47    ///
48    /// What a copy loop writes for a position that resolved to nowhere, for the same reason a fixed
49    /// width copy writes a zero there. The views are a parallel array to a validity mask, so a row
50    /// that got skipped rather than filled would put every row after it at the wrong index.
51    #[must_use]
52    pub const fn empty() -> Self {
53        Self { length: 0, payload: [0; 12] }
54    }
55
56    /// A view on a string that fits inline.
57    ///
58    /// # Panics
59    ///
60    /// If the string is longer than [`INLINE_LIMIT`]. Callers that do not know the length go
61    /// through [`StringColumn::push`], which decides.
62    #[must_use]
63    pub fn inline(text: &str) -> Self {
64        assert!(text.len() <= INLINE_LIMIT, "a string of {} bytes is not inline", text.len());
65        let mut payload = [0u8; 12];
66        payload[..text.len()].copy_from_slice(text.as_bytes());
67        Self { length: text.len() as u32, payload }
68    }
69
70    /// A view on a string that lives in the arena.
71    fn indirect(text: &str, offset: u64) -> Self {
72        let mut payload = [0u8; 12];
73        payload[..4].copy_from_slice(&text.as_bytes()[..4]);
74        payload[4..].copy_from_slice(&offset.to_le_bytes());
75        Self { length: text.len() as u32, payload }
76    }
77
78    /// A view on bytes, whatever they are, wherever they turn out to live.
79    ///
80    /// The one constructor that takes bytes rather than a `&str`, and the two callers want it for
81    /// different reasons. A copy between two columns has bytes that were validated on the way into
82    /// the first one and validating again would be work for nothing. A `BLOB` has bytes that were
83    /// never text and are not going to become it. `offset` is where they are in the destination
84    /// arena and is ignored for a string short enough to sit in the view.
85    ///
86    /// It is public because the string view form of a vector is built from views a caller made, and
87    /// a scan laying chunks over a page of strings is exactly the caller that has bytes and an
88    /// offset into somebody else's arena rather than a column to push into.
89    #[must_use]
90    pub fn over(bytes: &[u8], offset: u64) -> Self {
91        let mut payload = [0u8; 12];
92        if bytes.len() <= INLINE_LIMIT {
93            payload[..bytes.len()].copy_from_slice(bytes);
94        } else {
95            payload[..4].copy_from_slice(&bytes[..4]);
96            payload[4..].copy_from_slice(&offset.to_le_bytes());
97        }
98        Self { length: bytes.len() as u32, payload }
99    }
100
101    /// The length in bytes.
102    #[must_use]
103    pub fn len(&self) -> usize {
104        self.length as usize
105    }
106
107    /// Whether the string is empty.
108    #[must_use]
109    pub fn is_empty(&self) -> bool {
110        self.length == 0
111    }
112
113    /// Whether the whole string is in the view.
114    #[must_use]
115    pub fn is_inline(&self) -> bool {
116        self.len() <= INLINE_LIMIT
117    }
118
119    /// The first four bytes, zero padded.
120    ///
121    /// This is the whole point of the representation. Two strings with different prefixes are
122    /// different, and two strings with the same prefix are usually equal, so a filter on a string
123    /// column resolves without touching the payload on almost every row.
124    #[must_use]
125    pub fn prefix(&self) -> [u8; 4] {
126        [self.payload[0], self.payload[1], self.payload[2], self.payload[3]]
127    }
128
129    /// The bytes, when the whole string is in the view.
130    ///
131    /// A comparison wants bytes rather than a `&str`, because SQL's string order is byte order and
132    /// because [`Self::as_inline_str`] pays for a UTF-8 validation that a comparison has no use
133    /// for. On a filter against a varchar column that validation is the whole cost of the row.
134    #[must_use]
135    pub fn inline_bytes(&self) -> Option<&[u8]> {
136        if self.is_inline() { Some(&self.payload[..self.len()]) } else { None }
137    }
138
139    /// The string, when it is short enough to be in the view.
140    #[must_use]
141    pub fn as_inline_str(&self) -> Option<&str> {
142        if !self.is_inline() {
143            return None;
144        }
145        // `None` rather than a panic for a view that holds a blob, since the payload is whatever
146        // was written and only a column of text can promise that is a string.
147        std::str::from_utf8(&self.payload[..self.len()]).ok()
148    }
149
150    /// The bytes, given the arena the long strings of this column live in.
151    ///
152    /// A short string is in the view and the arena is not read at all, which is why this takes the
153    /// arena rather than requiring one that has the string in it.
154    ///
155    /// This exists because a view and the bytes it points at do not have to be held by the same
156    /// object. [`StringColumn`] owns both, and the string view form of a vector holds the views
157    /// itself and shares the arena with every other cut of the same page, so a cut of a varchar
158    /// column is the views and nothing else. Both of them resolve a row the same way, and this is
159    /// where that one way is written.
160    #[must_use]
161    pub fn bytes_in<'a>(&'a self, arena: &'a [u8]) -> Option<&'a [u8]> {
162        if let Some(inline) = self.inline_bytes() {
163            return Some(inline);
164        }
165        arena.get(self.offset()..self.offset() + self.len())
166    }
167
168    fn offset(&self) -> usize {
169        u64::from_le_bytes([
170            self.payload[4],
171            self.payload[5],
172            self.payload[6],
173            self.payload[7],
174            self.payload[8],
175            self.payload[9],
176            self.payload[10],
177            self.payload[11],
178        ]) as usize
179    }
180
181    /// Whether these two views are definitely different, answered from the view alone.
182    ///
183    /// A `false` here means the payloads have to be compared. A `true` means they do not, which on
184    /// a filter against a selective literal is almost every row.
185    #[must_use]
186    pub fn definitely_differs(&self, other: &Self) -> bool {
187        self.length != other.length || self.prefix() != other.prefix()
188    }
189}
190
191/// A column of strings: the views, and the one arena the long ones live in.
192///
193/// The arena is append only, so an offset recorded in a view stays correct for the life of the
194/// column even though the arena's address does not. That is the property a `Vec<u8>` has and a raw
195/// pointer into it does not, and it is the reason a view holds an offset.
196///
197/// This was a `Vec<Vec<u8>>` of fixed size blocks, which meant reading one long string was two
198/// dependent loads, the outer vector's element to find the block's data pointer and then the bytes.
199/// One arena makes it one, from a base the compiler can keep in a register across a row loop, and it
200/// deletes the case where a string longer than a block needed a block of its own. On server3, over a
201/// chunk of 1024 strings, comparing a column against a literal went from 14.9 nanoseconds a row to
202/// 13.2 at 40 bytes a string and from 14.2 to 12.9 at 120, gathering half the rows from 29.5 to 25.3
203/// and from 36.9 to 29.1, and building the column from 12.0 to 8.9 at 40 bytes.
204///
205/// # The one number that got worse, and what it actually is
206///
207/// Building a column whose payload passes 128 KiB, which at 1024 rows means strings averaging more
208/// than 128 bytes, went the other way: 14.6 nanoseconds a row to 41.0. That is not the copy and it
209/// is not the doubling, it is glibc. An allocation that size comes from `mmap` rather than the heap,
210/// so it is handed back to the kernel when the column is dropped and the next chunk faults every
211/// page of it in again, while sixteen KiB blocks come back off a free list already faulted. Run the
212/// same benchmark with `MALLOC_MMAP_THRESHOLD_` raised and the arena builds that column in 9.6
213/// nanoseconds a row against the blocks' 16.2, so the design is not what is slow there.
214///
215/// The fix is that a chunk's payload should come from a pool the engine owns rather than from
216/// `malloc` per chunk, which is the buffer manager at layer three and is where this belongs.
217/// [`Self::reserve_bytes`] is the part that is available now, and it recovers a quarter of it.
218///
219/// # Equality is about the strings and not about the arena
220///
221/// [`Self::over`] means two columns holding exactly the same strings can hold completely different
222/// arenas, because one of them was built by copying the strings in and the other was built over a
223/// page that already had them somewhere in it with other strings in between. Derived equality would
224/// call those two columns different, and every test in the workspace that compares two vectors would
225/// then be asserting on how a column was built rather than on what is in it. So equality is the
226/// strings, position by position, which is the only definition that survives the seam.
227#[derive(Debug, Clone, Default, Eq)]
228pub struct StringColumn {
229    views: Vec<StringView>,
230    arena: Buffer<u8>,
231}
232
233impl StringColumn {
234    /// How many bytes of memory this column is holding.
235    ///
236    /// The views and the arena. A short string lives inside its view and costs nothing beyond it,
237    /// which is the whole reason the representation exists, so a column of short strings costs
238    /// sixteen bytes a string and a column of long ones costs sixteen plus the bytes themselves.
239    #[must_use]
240    pub fn footprint(&self) -> usize {
241        self.views.capacity() * size_of::<StringView>() + self.arena.footprint()
242    }
243
244    /// An empty column.
245    #[must_use]
246    pub fn new() -> Self {
247        Self::default()
248    }
249
250    /// An empty column with room for `capacity` strings.
251    #[must_use]
252    pub fn with_capacity(capacity: usize) -> Self {
253        Self { views: Vec::with_capacity(capacity), arena: Buffer::new() }
254    }
255
256    /// A column with no strings in it yet, over an arena that already holds bytes.
257    ///
258    /// The seam `spec/engine/03-data-plane.md` section 3.5 asks for. Without it the only way in is
259    /// [`Self::push`], which copies, so a scan reading a Parquet page of strings copies every byte of
260    /// the page into an arena and the query then reads the copy. With it the page is the arena: the
261    /// scan hands the bytes over once, records where each string starts with
262    /// [`Self::push_in_place`], and nothing is copied but the views.
263    ///
264    /// It is useful today, because a reader that already has the page in a `Vec<u8>` can move it in
265    /// rather than copy out of it. It matters at layer three, when the [`Buffer`] is the pinned page
266    /// itself and the move is not even that.
267    ///
268    /// Appending with [`Self::push`] afterwards still works and still appends to the arena. That is
269    /// the case to keep away from once a real page is in here, because writing through a borrowed
270    /// buffer copies it, which is [`Buffer::to_mut`] and is the whole page.
271    #[must_use]
272    pub fn over(arena: Buffer<u8>) -> Self {
273        Self { views: Vec::new(), arena }
274    }
275
276    /// How many strings are in the column.
277    #[must_use]
278    pub fn len(&self) -> usize {
279        self.views.len()
280    }
281
282    /// Whether the column has no strings in it.
283    #[must_use]
284    pub fn is_empty(&self) -> bool {
285        self.views.is_empty()
286    }
287
288    /// The views, for a kernel that wants to compare prefixes without reading any payload.
289    #[must_use]
290    pub fn views(&self) -> &[StringView] {
291        &self.views
292    }
293
294    /// Appends a string and returns its index.
295    pub fn push(&mut self, text: &str) -> usize {
296        let view = if text.len() <= INLINE_LIMIT {
297            StringView::inline(text)
298        } else {
299            let offset = self.arena.len() as u64;
300            self.arena.extend_from_slice(text.as_bytes());
301            StringView::indirect(text, offset)
302        };
303        self.views.push(view);
304        self.views.len() - 1
305    }
306
307    /// Appends the string at `index` of another column, and returns its index here.
308    ///
309    /// This is what a gather and a slice over a string column want, and it is worth having next to
310    /// [`Self::push`] because that one takes a `&str` and the only way to get one out of a column
311    /// is [`Self::get`], which validates UTF-8. Validating there is a waste on this path twice
312    /// over: the bytes were validated on the way into the source column, and a copy cannot make
313    /// valid bytes invalid. Reading a ClickBench partition spent eight percent of its cycles on
314    /// that second validation.
315    ///
316    /// A position past the end of the source appends the empty string, which is what the copy loop
317    /// wants for a row that resolved to nowhere.
318    pub fn push_from(&mut self, source: &Self, index: usize) -> usize {
319        self.push_bytes(source.bytes(index).unwrap_or(b""))
320    }
321
322    /// Appends bytes that are not required to be text, and returns their index.
323    ///
324    /// What a `BLOB` is stored through. The column is the same column either way, because a string
325    /// here is already a length and some bytes and text is the reading rather than the storage, so
326    /// a blob costs nothing extra and shares every kernel that works on views. What it does not
327    /// share is [`Self::get`], which answers `None` for bytes that are not a string, so a caller
328    /// holding blobs reads them with [`Self::bytes`].
329    pub fn push_bytes(&mut self, bytes: &[u8]) -> usize {
330        let offset = self.arena.len() as u64;
331        if bytes.len() > INLINE_LIMIT {
332            self.arena.extend_from_slice(bytes);
333        }
334        self.views.push(StringView::over(bytes, offset));
335        self.views.len() - 1
336    }
337
338    /// Records a string that is already in the arena, and returns its index.
339    ///
340    /// The half of the seam that does the work. [`Self::over`] puts the page in, this says where in
341    /// it a string is, and between them a column of long strings is built without the payload being
342    /// touched at all.
343    ///
344    /// A string short enough to sit inside a view is copied into the view, which is at most twelve
345    /// bytes and is what makes it readable without going near the arena at all. Everything longer
346    /// keeps its bytes where they are and the view records the offset.
347    ///
348    /// # Errors
349    ///
350    /// If the range is not inside the arena, or if the bytes are not valid UTF-8. The validation is
351    /// the one cost this seam does not remove, and it is here rather than skipped because
352    /// [`Self::get`] hands back a `&str` and a column that cannot produce one for a string it claims
353    /// to hold is a wrong answer rather than a slow one. A scan over a page where the format
354    /// guarantees UTF-8 wants to validate the page once instead of once per string, which is a pass
355    /// the layer three reader makes and is not something this type can do on its behalf.
356    pub fn push_in_place(&mut self, offset: usize, len: usize) -> Result<usize> {
357        let end = offset.checked_add(len).ok_or_else(|| {
358            Error::internal(format!(
359                "a string at {offset} of {len} bytes runs off the end of memory"
360            ))
361        })?;
362        let bytes = self.arena.get(offset..end).ok_or_else(|| {
363            Error::internal(format!(
364                "a string at {offset} of {len} bytes is not inside a {} byte arena",
365                self.arena.len()
366            ))
367        })?;
368        let text = std::str::from_utf8(bytes)
369            .map_err(|_| Error::internal(format!("the bytes at {offset} are not valid UTF-8")))?;
370        let view = if len <= INLINE_LIMIT {
371            StringView::inline(text)
372        } else {
373            StringView::indirect(text, offset as u64)
374        };
375        self.views.push(view);
376        Ok(self.views.len() - 1)
377    }
378
379    /// The bytes the long strings live in.
380    ///
381    /// For a column over a page this is the page, including whatever of it no view points at. The
382    /// offsets in the views are offsets into exactly this, which is what makes them meaningful to a
383    /// reader that put the page here in the first place.
384    #[must_use]
385    pub fn arena(&self) -> &[u8] {
386        &self.arena
387    }
388
389    /// The views and the arena, taken out of the column rather than borrowed from it.
390    ///
391    /// What the string view form of a vector is built from. It takes `self` because the point of
392    /// that form is that the arena moves into an `Arc` and is never copied again, and a method that
393    /// borrowed would have to clone every byte of the arena to hand one over.
394    #[must_use]
395    pub fn into_parts(self) -> (Vec<StringView>, Buffer<u8>) {
396        (self.views, self.arena)
397    }
398
399    /// The bytes at `index`, or `None` past the end.
400    ///
401    /// This is what a comparison, a hash and an equality check all actually want, and it is worth
402    /// having separately from [`Self::get`] because that one validates UTF-8 and they do not need
403    /// it. Everything in a column arrived through [`Self::push`], which takes a `&str`, so the
404    /// bytes are valid either way and the validation is a scan of the payload that changes no
405    /// answer. On a varchar filter it was measured at most of the per row cost.
406    #[must_use]
407    pub fn bytes(&self, index: usize) -> Option<&[u8]> {
408        self.views.get(index)?.bytes_in(&self.arena)
409    }
410
411    /// The string at `index`, or `None` past the end.
412    #[must_use]
413    pub fn get(&self, index: usize) -> Option<&str> {
414        // Written from a `&str` into a block that is append only, so the bytes are the same bytes.
415        std::str::from_utf8(self.bytes(index)?).ok()
416    }
417
418    /// Every string in order.
419    pub fn iter(&self) -> impl Iterator<Item = &str> {
420        (0..self.len()).filter_map(|index| self.get(index))
421    }
422
423    /// Total bytes of payload held in the arena, which is what the memory accounting wants.
424    ///
425    /// For a column over a page it is the page and not the part of it any view points at, which is
426    /// the right answer for accounting, because the page is what is resident.
427    #[must_use]
428    pub fn heap_bytes(&self) -> usize {
429        self.arena.len()
430    }
431
432    /// Room for `bytes` of payload, taken in one allocation rather than as the strings arrive.
433    ///
434    /// A builder that knows the total byte count, which a scan reading a page and a gather copying a
435    /// column both do, saves the doubling entirely. Nothing is wrong without it, which is why it is
436    /// a hint and not a constructor argument.
437    pub fn reserve_bytes(&mut self, bytes: usize) {
438        self.arena.reserve(bytes);
439    }
440}
441
442/// Two columns are equal when they hold the same strings in the same order, whatever their arenas
443/// look like.
444///
445/// See the note on [`StringColumn`]. Comparing the views is not enough on its own either, because
446/// two views of the same long string at different offsets in different arenas are different views,
447/// so the comparison is length, then view by view with the payload read for the ones that are not
448/// inline. The prefix inside the view is what makes that cheap: a pair that differs in the first
449/// four bytes or in the length is settled without either arena being touched.
450impl PartialEq for StringColumn {
451    fn eq(&self, other: &Self) -> bool {
452        self.views.len() == other.views.len()
453            && (0..self.views.len()).all(|index| {
454                let mine = self.views[index];
455                let theirs = other.views[index];
456                if mine.definitely_differs(&theirs) {
457                    return false;
458                }
459                if mine.is_inline() {
460                    return mine == theirs;
461                }
462                self.bytes(index) == other.bytes(index)
463            })
464    }
465}
466
467impl<'a> Extend<&'a str> for StringColumn {
468    fn extend<T: IntoIterator<Item = &'a str>>(&mut self, iter: T) {
469        for text in iter {
470            self.push(text);
471        }
472    }
473}
474
475impl<'a> FromIterator<&'a str> for StringColumn {
476    fn from_iter<T: IntoIterator<Item = &'a str>>(iter: T) -> Self {
477        let mut column = Self::new();
478        column.extend(iter);
479        column
480    }
481}
482
483#[cfg(test)]
484mod tests {
485    use super::{INLINE_LIMIT, StringColumn, StringView};
486    use crate::buffer::Buffer;
487
488    /// The seam, used the way layer three will use it. The page arrives whole, each string is
489    /// recorded where it already is, and the arena at the end is the page byte for byte, including
490    /// the header this page has in front of the strings and the bytes between them that belong to
491    /// nothing. A column that had copied would have an arena the size of the strings instead.
492    #[test]
493    fn a_column_over_a_page_records_the_strings_without_moving_them() {
494        let page =
495            b"HEADER..a string well past the inline limit!!a second one past the limit".to_vec();
496        let mut column = StringColumn::over(Buffer::from_vec(page.clone()));
497        assert_eq!(column.push_in_place(8, 37).expect("inside the page"), 0);
498        assert_eq!(column.push_in_place(45, 27).expect("inside the page"), 1);
499        assert_eq!(column.get(0), Some("a string well past the inline limit!!"));
500        assert_eq!(column.get(1), Some("a second one past the limit"));
501        assert_eq!(column.arena(), page.as_slice());
502        assert_eq!(column.heap_bytes(), page.len());
503        assert_eq!(column.len(), 2);
504    }
505
506    /// Copying between two columns, which is what a gather and a slice over a string column are.
507    /// A column built over a page has an arena full of bytes no view points at, and the copy has to
508    /// take the strings rather than the arena, so the destination holds the strings and nothing
509    /// else. The last case is the row that resolved to nowhere, which is an empty string here and a
510    /// null in the validity mask beside it.
511    #[test]
512    fn copying_from_another_column_takes_the_strings_and_not_the_page_they_were_in() {
513        let page = b"HEADER..a string well past the inline limit!!short".to_vec();
514        let mut source = StringColumn::over(Buffer::from_vec(page.clone()));
515        source.push_in_place(8, 37).expect("inside the page");
516        source.push_in_place(45, 5).expect("inside the page");
517
518        let mut out = StringColumn::new();
519        assert_eq!(out.push_from(&source, 1), 0);
520        assert_eq!(out.push_from(&source, 0), 1);
521        assert_eq!(out.push_from(&source, 9), 2, "a position that is not there");
522
523        assert_eq!(out.get(0), Some("short"));
524        assert_eq!(out.get(1), Some("a string well past the inline limit!!"));
525        assert_eq!(out.get(2), Some(""));
526        assert!(out.views()[0].is_inline(), "a short string stays in its view");
527        assert!(!out.views()[1].is_inline());
528        assert_eq!(out.views()[1].prefix(), *b"a st", "the prefix is the string's own");
529        assert_eq!(
530            out.arena(),
531            b"a string well past the inline limit!!",
532            "the arena is the long strings and not the page"
533        );
534    }
535
536    /// Bytes that are not text, which is what a `BLOB` holds. Both sides of the inline limit,
537    /// because a short one lives in its view and a long one lives in the arena and the byte that is
538    /// not a character has to survive either way. Reading them back as text is `None` and reading
539    /// them back as bytes is what went in.
540    #[test]
541    fn a_column_holds_bytes_that_are_not_a_string() {
542        let long = b"\xff\xfe and a good deal more than twelve bytes of it";
543        let mut column = StringColumn::new();
544        assert_eq!(column.push_bytes(b"a\xffb"), 0);
545        assert_eq!(column.push_bytes(long), 1);
546        assert_eq!(column.push_bytes(b""), 2);
547
548        assert_eq!(column.bytes(0), Some(b"a\xffb".as_slice()));
549        assert_eq!(column.bytes(1), Some(long.as_slice()));
550        assert_eq!(column.bytes(2), Some(b"".as_slice()));
551        assert_eq!(column.get(0), None, "a stray 0xff is not a character");
552        assert_eq!(column.get(1), None);
553        assert!(column.views()[0].is_inline());
554        assert!(!column.views()[1].is_inline());
555        assert_eq!(column.arena(), long, "only the long one needed the arena");
556    }
557
558    /// A copy of a copy, because the second one reads its bytes out of an arena the first one wrote
559    /// rather than out of a page, and an offset written in one and read in the other is the way
560    /// this goes wrong.
561    #[test]
562    fn copying_from_a_column_that_was_itself_copied_reads_the_same_strings() {
563        let mut first = StringColumn::new();
564        for text in ["a string well past the inline limit", "short", "another long one past it"] {
565            first.push(text);
566        }
567        let mut second = StringColumn::new();
568        for index in (0..first.len()).rev() {
569            second.push_from(&first, index);
570        }
571        let mut third = StringColumn::new();
572        for index in 0..second.len() {
573            third.push_from(&second, index);
574        }
575        assert_eq!(
576            third.iter().collect::<Vec<_>>(),
577            ["another long one past it", "short", "a string well past the inline limit"]
578        );
579    }
580
581    /// A string short enough to live inside its view is copied into the view, which is twelve bytes
582    /// and is what lets it be read without the arena. The page is still the arena and is still
583    /// untouched, so a page of short strings costs the views and nothing else.
584    #[test]
585    fn a_short_string_in_a_page_is_copied_into_its_view() {
586        let mut column = StringColumn::over(Buffer::from_vec(b"one.two".to_vec()));
587        column.push_in_place(0, 3).expect("inside the page");
588        column.push_in_place(4, 3).expect("inside the page");
589        assert!(column.views()[0].is_inline());
590        assert_eq!(column.get(0), Some("one"));
591        assert_eq!(column.get(1), Some("two"));
592        assert_eq!(column.arena(), b"one.two");
593    }
594
595    /// The two ways a caller can be wrong about a page, both of them answered before anything is
596    /// recorded rather than at the point somebody reads the string back and finds nothing there.
597    #[test]
598    fn a_range_outside_the_page_or_bytes_that_are_not_text_are_refused() {
599        let mut column = StringColumn::over(Buffer::from_vec(vec![0xff, 0xfe, 0xfd]));
600        assert!(column.push_in_place(2, 4).is_err());
601        assert!(column.push_in_place(usize::MAX, 1).is_err());
602        assert!(column.push_in_place(0, 3).is_err());
603        assert_eq!(column.len(), 0);
604    }
605
606    /// What the seam does to equality. The same two strings, one column built by copying them in
607    /// and one built over a page that has them in the other order with a gap in the middle, and the
608    /// two arenas have nothing in common. Equality is the strings, so the columns are equal.
609    #[test]
610    fn the_same_strings_over_different_arenas_are_the_same_column() {
611        let copied: StringColumn =
612            ["the first string past the limit", "the second string past the limit"]
613                .into_iter()
614                .collect();
615        let page =
616            b"gap!the second string past the limit....the first string past the limit".to_vec();
617        let mut over = StringColumn::over(Buffer::from_vec(page));
618        over.push_in_place(40, 31).expect("inside the page");
619        over.push_in_place(4, 32).expect("inside the page");
620        assert_ne!(copied.arena(), over.arena());
621        assert_eq!(copied, over);
622
623        let mut different: StringColumn = copied.clone();
624        different.push("a third one past the inline limit");
625        assert_ne!(copied, different);
626    }
627
628    #[test]
629    fn a_view_is_sixteen_bytes_and_stays_sixteen_bytes() {
630        // The number the whole design is built around. A vector of 1024 strings is 16 KiB of
631        // views, which is the budget spec/07-execution.md section 7.1 spends on purpose.
632        assert_eq!(size_of::<StringView>(), 16);
633        assert_eq!(align_of::<StringView>(), 4);
634    }
635
636    #[test]
637    fn twelve_bytes_is_inline_and_thirteen_is_not() {
638        let mut column = StringColumn::new();
639        column.push("123456789012");
640        column.push("1234567890123");
641        assert!(column.views()[0].is_inline());
642        assert!(!column.views()[1].is_inline());
643        assert_eq!(column.get(0), Some("123456789012"));
644        assert_eq!(column.get(1), Some("1234567890123"));
645        assert_eq!(INLINE_LIMIT, 12);
646    }
647
648    #[test]
649    fn a_prefix_answers_the_comparison_without_reading_the_payload() {
650        let mut column = StringColumn::new();
651        column.push("https://example.com/a");
652        column.push("https://example.com/b");
653        column.push("mailto:someone@example.com");
654        let views = column.views();
655        // Same prefix, same length: the payloads have to be read. This is the case the prefix
656        // cannot help with, and on a URL column it is the common case, which is why the
657        // dictionary work at M3 matters more than this does.
658        assert!(!views[0].definitely_differs(&views[1]));
659        // Different prefix: answered from the view.
660        assert!(views[0].definitely_differs(&views[2]));
661    }
662
663    /// A string of any size goes in whole, with the short ones on either side of it still reading
664    /// back. The old layout had a size at which a string stopped fitting a block and got one of its
665    /// own, and one arena has no such size, so the case worth keeping is the one that used to be
666    /// special rather than the branch that used to handle it.
667    #[test]
668    fn a_string_far_larger_than_any_block_would_have_been_goes_in_whole() {
669        let long = "x".repeat(40 * 1024);
670        let mut column = StringColumn::new();
671        column.push("short");
672        column.push(&long);
673        column.push("also short");
674        assert_eq!(column.get(1), Some(long.as_str()));
675        assert_eq!(column.get(2), Some("also short"));
676        assert_eq!(column.heap_bytes(), long.len());
677    }
678
679    /// The property the whole arena rests on. Two thousand strings is tens of reallocations, and
680    /// every one of them moves the bytes to a new address while the offsets recorded in the views
681    /// before it stay exactly as they were. A view holding a pointer would be reading freed memory
682    /// by the end of this test.
683    #[test]
684    fn the_arena_moving_underneath_does_not_move_what_the_views_point_at() {
685        let mut column = StringColumn::new();
686        let strings: Vec<String> =
687            (0..2000).map(|i| format!("value number {i} padded out")).collect();
688        for text in &strings {
689            column.push(text);
690        }
691        for (index, text) in strings.iter().enumerate() {
692            assert_eq!(column.get(index), Some(text.as_str()), "at {index}");
693        }
694        assert_eq!(column.len(), 2000);
695        assert_eq!(column.iter().count(), 2000);
696    }
697
698    #[test]
699    fn reserving_bytes_changes_nothing_but_where_the_allocation_happens() {
700        let mut column = StringColumn::with_capacity(3);
701        column.reserve_bytes(128);
702        for text in ["a string past the limit", "another one past it", "short"] {
703            column.push(text);
704        }
705        assert_eq!(column.get(0), Some("a string past the limit"));
706        assert_eq!(column.get(1), Some("another one past it"));
707        assert_eq!(column.get(2), Some("short"));
708        assert_eq!(column.heap_bytes(), 42);
709    }
710
711    #[test]
712    fn the_empty_string_is_inline_and_reads_back_empty() {
713        let mut column = StringColumn::new();
714        column.push("");
715        assert_eq!(column.get(0), Some(""));
716        assert!(column.views()[0].is_empty());
717        assert_eq!(column.heap_bytes(), 0);
718    }
719
720    #[test]
721    fn multibyte_text_survives_the_inline_boundary() {
722        // The boundary is bytes and not characters, so a four byte emoji is what decides whether
723        // a three character string is inline.
724        let mut column = StringColumn::new();
725        column.push("héllo wörld");
726        column.push("🦀🦀🦀🦀");
727        assert_eq!(column.get(0), Some("héllo wörld"));
728        assert_eq!(column.get(1), Some("🦀🦀🦀🦀"));
729        assert!(!column.views()[1].is_inline());
730    }
731
732    #[test]
733    fn reading_past_the_end_is_none_rather_than_a_panic() {
734        let column: StringColumn = ["a", "b"].into_iter().collect();
735        assert_eq!(column.get(2), None);
736        assert_eq!(column.len(), 2);
737    }
738
739    /// The bytes and the string have to be the same string on both sides of the inline boundary
740    /// and on multibyte text, because the comparison kernels read the bytes and everything else
741    /// reads the string, and a disagreement between them would be a filter that matched a row the
742    /// projection then printed differently.
743    #[test]
744    fn the_bytes_and_the_string_are_the_same_string() {
745        let long = "x".repeat(9000);
746        let words = ["", "a", "twelve bytes", "thirteen bytes", "π is two bytes", &long];
747        let column: StringColumn = words.into_iter().collect();
748        for (index, text) in words.iter().enumerate() {
749            assert_eq!(column.bytes(index), Some(text.as_bytes()), "at {index}");
750            assert_eq!(column.get(index), Some(*text), "at {index}");
751        }
752        assert_eq!(column.bytes(words.len()), None);
753    }
754}