Skip to main content

rucc_codegen/
coverage.rs

1//! Which IR opcodes have somewhere to go, and which do not.
2//!
3//! Design: `spec/10-backend.md` section 10.2, under **Coverage**.
4//!
5//! Every opcode has to be lowered by something or be a hole somebody wrote down. Without this the
6//! way a hole is found is that somebody compiles a program containing one and the selector reports
7//! that it cannot lower an instruction, which is a fine diagnostic and a bad discovery mechanism:
8//! it turns a gap in the rule set into a user's problem rather than a failing build.
9//!
10//! # The three answers
11//!
12//! An opcode is lowered by a rule, or somewhere a rule cannot reach, or nowhere.
13//!
14//! The first is the ordinary answer and the one this can check by itself. [`crate::term`] says
15//! every name a rule could be written at, the table says every name one is written at, and an
16//! opcode is covered when each of its names is in both. That is what makes this a check about
17//! widths rather than about opcodes: an `add` with a rule at four widths and no rule at the fifth
18//! is not covered, and would be reported here as the missing name rather than as a covered opcode.
19//!
20//! The second is [`ELSEWHERE`], which is not a gap. `spec/10-backend.md` names five of them and
21//! there are more now, and they are all the same kind of thing: an opcode whose lowering depends on
22//! something no pattern can see. Where a call's arguments go depends on the signature, where a
23//! local lives depends on the frame, an unconditional jump is an edge and edges live on the block,
24//! and a `memcpy` is a run of moves whose length is a constant the pattern would have to count. A
25//! rule matches one term and can say none of that.
26//!
27//! The third is [`GAPS`], which is the number `spec/15-testing.md` section 15.8 says we keep. Each
28//! entry names why it is there and the issue that closes it, so that an opcode nobody has written a
29//! rule for is a decision somebody wrote down rather than a surprise.
30//!
31//! [`WIDTHS`] and [`NAMES`] are the same third answer said about something smaller than an opcode.
32//! A width on [`WIDTHS`] has no names at all, so no opcode is missing a rule at it, and a name on
33//! [`NAMES`] is one width of an opcode that lowers at its other widths. Both carry the issue that
34//! closes them for the same reason [`GAPS`] does.
35//!
36//! # What makes the lists honest
37//!
38//! An entry that stops being true fails. An opcode on either list that a rule starts covering is a
39//! stale entry and the tests below say so by name, which is the same rule the exclusion lists in
40//! the compatibility harness are kept under: a list nothing checks is a list that only grows.
41//!
42//! The direction this cannot check is an opcode moving from [`GAPS`] to [`ELSEWHERE`] without the
43//! list following it, because where an opcode is lowered by name is a `match` arm and there is
44//! nothing to ask about a `match` arm from here. What that costs is one line of a list going out of
45//! date; what it does not cost is a gap going unnoticed, since the opcode is still on a list and
46//! still counted.
47//!
48//! # The other question
49//!
50//! All of the above is about the rule set as it is written. [`Fired`] is about the rule set as it
51//! is used: which rules a compilation actually reached. A rule nothing reaches is proved and dead
52//! weight, or it is a construct the corpus does not contain and somebody should know which. The
53//! selector marks a rule as it fires it, the driver writes the marks out under
54//! `-Zrule-coverage=FILE`, and the harness in `tamnd/rucc-compat` unions those files over a corpus,
55//! which is what turns coverage of the rule set into a number. `spec/20-execution-testing.md`
56//! section 20.9 is the design and `tamnd/rucc#261` is the work.
57
58use core::fmt;
59use core::fmt::Write as _;
60
61use rucc_ir::Opcode;
62use rucc_target::Arch;
63
64use crate::select::{Table, Test};
65use crate::term;
66
67/// An opcode no rule is written about, and the place that lowers it instead.
68///
69/// Not one of these is a gap. Each is an opcode whose lowering depends on something a pattern
70/// cannot see, so the answer lives where that something is known.
71pub static ELSEWHERE: &[(Opcode, &str)] = &[
72    // The convention. What a call's operands are is whatever the signature made them, and which
73    // register each one arrives in depends on the classification of every argument before it.
74    (Opcode::Call, "`crate::abi`, which builds a call out of the convention"),
75    (Opcode::CallIndirect, "`crate::abi`, the same instruction with the callee in a register"),
76    // The frame, which is not known until the allocator has finished running out of registers.
77    (Opcode::Alloca, "`crate::lower`, as an address into a frame `crate::frame` lays out later"),
78    // A relocation, which is right because of what the linker does rather than because of what
79    // any bitvector equals.
80    (Opcode::GlobalAddr, "`crate::lower`, a `lea` off the instruction pointer with a name on it"),
81    // No instruction at all. The IR keeps the width the same and the machine has one register
82    // file for both, so the value is already where it needs to be.
83    (Opcode::PtrToInt, "`crate::lower`, which renames the value rather than computing anything"),
84    (Opcode::IntToPtr, "`crate::lower`, the same rename the other way round"),
85    // The edges and the two ways of writing down that control does not arrive.
86    (Opcode::Jump, "`crate::layout`, since an edge is on the block and not in the block"),
87    (Opcode::Unreachable, "nothing at all, which is the answer for a place control does not reach"),
88    (Opcode::UnreachableHint, "nothing at all, for the same reason"),
89    // Rewritten into the opcodes above before selection ever sees them.
90    (Opcode::Switch, "`crate::expand`, into the compare and branch chain it is"),
91    (Opcode::FConst, "`crate::expand`, into a constant in memory and a load of it"),
92    (Opcode::FNeg, "`crate::expand`, into the sign bit flip it is"),
93    (Opcode::UIToFP, "`crate::expand`, into a widening and a signed conversion"),
94    (Opcode::FPToUI, "`crate::expand`, into a signed conversion and a narrowing"),
95    (Opcode::Memcpy, "`crate::expand`, into the moves it stands for"),
96    (Opcode::Memset, "`crate::expand`, into the fills it stands for"),
97    (Opcode::Memmove, "`crate::expand`, into a call, since the two regions may overlap"),
98    // The variable argument list, which is four opcodes reading a structure the ABI describes.
99    (Opcode::VaStart, "`crate::varargs`, which writes the register save area the ABI describes"),
100    (Opcode::VaArg, "`crate::varargs`, into the walk over that structure"),
101    (Opcode::VaObject, "`crate::varargs`, the same walk for something that arrived in memory"),
102    (Opcode::VaCopy, "`crate::varargs`, into a copy of the structure"),
103    (Opcode::VaEnd, "`crate::varargs`, which removes it, since there is nothing to undo"),
104];
105
106/// An opcode nothing lowers, why it is here, and the issue that closes it.
107///
108/// This is the count `spec/15-testing.md` section 15.8 asks for. It is not zero yet and the
109/// spec says it should be, which is the honest reading of where the back end is: every one of
110/// these is a feature nobody has written, and all but three of them are opcodes the front end
111/// cannot produce either, so a program that reaches one of these is a program that reaches an
112/// unimplemented builtin first.
113pub static GAPS: &[(Opcode, &str, &str)] = &[
114    (Opcode::Splat, "a vector, and no rule is written about a lane count", "tamnd/rucc#200"),
115    (
116        Opcode::TargetIntrinsic,
117        "the same, since what needs one is a vector builtin",
118        "tamnd/rucc#200",
119    ),
120    (Opcode::BlockAddr, "the address of a label", "tamnd/rucc#353"),
121    (Opcode::IndirectBr, "the branch a computed goto turns into", "tamnd/rucc#353"),
122    (
123        Opcode::FRem,
124        "a call to `fmod`, so a link line question as much as a lowering one",
125        "tamnd/rucc#226",
126    ),
127    (
128        Opcode::Fma,
129        "a call or one instruction, depending on what the machine is told it has",
130        "tamnd/rucc#226",
131    ),
132    (Opcode::AtomicLoad, "an ordering, which the IR cannot say yet", "tamnd/rucc#311"),
133    (Opcode::AtomicStore, "the same", "tamnd/rucc#311"),
134    (Opcode::AtomicRmw, "the same, and a `lock` prefix per operation", "tamnd/rucc#311"),
135    (Opcode::Cmpxchg, "the same, and a result that is a pair", "tamnd/rucc#311"),
136    (
137        Opcode::Fence,
138        "the same, and nothing at all on this machine for most orderings",
139        "tamnd/rucc#311",
140    ),
141    (
142        Opcode::Ctlz,
143        "one instruction on a machine that has it and several on one that does not",
144        "tamnd/rucc#310",
145    ),
146    (Opcode::Cttz, "the same", "tamnd/rucc#310"),
147    (Opcode::Ctpop, "the same", "tamnd/rucc#310"),
148    (Opcode::Bswap, "three instructions and no rule", "tamnd/rucc#307"),
149    (Opcode::Bitreverse, "a node nothing writes and nothing lowers", "tamnd/rucc#363"),
150    (
151        Opcode::SAddOverflow,
152        "a result and a flag together, which no rule can write",
153        "tamnd/rucc#309",
154    ),
155    (Opcode::UAddOverflow, "the same", "tamnd/rucc#309"),
156    (Opcode::SSubOverflow, "the same", "tamnd/rucc#309"),
157    (Opcode::USubOverflow, "the same", "tamnd/rucc#309"),
158    (Opcode::SMulOverflow, "the same", "tamnd/rucc#309"),
159    (Opcode::UMulOverflow, "the same", "tamnd/rucc#309"),
160    (Opcode::Expect, "a branch weight nothing reads yet", "tamnd/rucc#364"),
161    (Opcode::Prefetch, "one instruction, once the hints have somewhere to go", "tamnd/rucc#313"),
162    (Opcode::FrameAddress, "a walk up the frame pointers", "tamnd/rucc#312"),
163    (Opcode::ReturnAddress, "the same walk, one word further along", "tamnd/rucc#312"),
164    (
165        Opcode::StackSave,
166        "a frame that can grow, as a variable length array needs",
167        "tamnd/rucc#291",
168    ),
169    (Opcode::StackRestore, "the same", "tamnd/rucc#291"),
170    (
171        Opcode::SetjmpMarker,
172        "a call that returns twice, which the allocator has to be told about",
173        "tamnd/rucc#223",
174    ),
175    (Opcode::LongjmpMarker, "the same", "tamnd/rucc#223"),
176    (Opcode::TailCall, "a terminator nothing writes and nothing lowers", "tamnd/rucc#365"),
177    (
178        Opcode::InlineAsm,
179        "a template, its constraints, and sixty eight torture programs",
180        "tamnd/rucc#349",
181    ),
182];
183
184/// A width no rule is written at, why, and the issue that closes it.
185///
186/// The other half of coverage, and the half an opcode list cannot say. An opcode is covered when
187/// every name it has is a name a rule is written at, and a width with no name has no names to
188/// check: an `add` of two `__int128`s is not a missing rule for `add`, it is a width the rule
189/// language cannot spell. So the widths are written down here for the same reason the opcodes are
190/// written down above.
191pub static WIDTHS: &[(&str, &str, &str)] = &[
192    (
193        "one bit",
194        "everything but and, or, xor, a constant, and the widening out of one",
195        "tamnd/rucc#352",
196    ),
197    (
198        "a hundred and twenty eight bits",
199        "no register pair, so nothing at that width has a name",
200        "tamnd/rucc#351",
201    ),
202    (
203        "eighty bits",
204        "a long double is on the x87 stack and no rule is about that stack",
205        "tamnd/rucc#326",
206    ),
207    (
208        "a vector of any lane count",
209        "a rule at a width says nothing about how many lanes",
210        "tamnd/rucc#200",
211    ),
212];
213
214/// A name a rule could be written at and deliberately is not, why, and the issue that puts it
215/// back.
216///
217/// The third list, and the one that is about a name rather than about an opcode or a width. An
218/// opcode on [`GAPS`] has no lowering at any width and a width on [`WIDTHS`] has no names at all,
219/// and neither of those can say that `add` is lowered at four widths and left alone at two.
220///
221/// This list used to be all of the narrow arithmetic. C promotes the operands of an arithmetic
222/// operator to `int` before the operator is applied, so `char a, b; a + b` is an `int` addition of
223/// two sign extended chars and there is no C program that asks the back end to add two bytes.
224/// Rules were written at those names anyway, ahead of the pass that would reach them, and they sat
225/// proved and never selected: `tamnd/rucc#261` measured that and `tamnd/rucc#368` took them out.
226/// Most of them are back, because the width narrowing pass in `tamnd/rucc#375` is that caller and
227/// it writes a byte add out of the truncation the assignment back to a `char` already was.
228///
229/// What is left is what the pass will not narrow. A divide is not narrowed because the most
230/// negative byte over minus one is a defined hundred and twenty eight at four bytes and is the
231/// overflow that raises at one, so it wants a range analysis saying that pair cannot happen. A
232/// truth value widened to a byte is not narrowed because it is a truncation of an extension that
233/// started narrower than the truncation ends, which is a third shape the pass does not have.
234///
235/// Not every narrow name was ever here, because promotion is not the only way a narrow operation
236/// is born. Reading a bitfield is a shift and a mask by constants at the width of the storage
237/// unit, writing one is a mask, a shift and an `or` of two values, and a truth test on a narrow
238/// scalar is an `icmp_ne` at that scalar's width. Those fire, so those always had rules.
239pub static NAMES: &[(&str, &str, &str)] = &[
240    ("sdiv.i8", "a narrow divide, which wants a range analysis before it can be narrowed", NARROW),
241    ("sdiv.i16", "the same", NARROW),
242    ("udiv.i8", "the same", NARROW),
243    ("udiv.i16", "the same", NARROW),
244    ("srem.i8", "the same", NARROW),
245    ("srem.i16", "the same", NARROW),
246    ("urem.i8", "the same", NARROW),
247    ("urem.i16", "the same", NARROW),
248    ("zext.i1.i8", "a truth value widened to a byte, which nothing asks for at that width", NARROW),
249    ("zext.i1.i16", "the same", NARROW),
250];
251
252/// The issue every entry of [`NAMES`] waits on, since they all wait on the same one.
253const NARROW: &str = "tamnd/rucc#375";
254
255/// What a target's rules cover, and what they do not.
256#[derive(Debug)]
257pub struct Report {
258    /// The rule file this is about, so that anything said about it names a file to open.
259    pub source: &'static str,
260    /// How many opcodes the IR has.
261    pub opcodes: usize,
262    /// The opcodes every name of which a rule is written at.
263    pub by_rule: Vec<Opcode>,
264    /// How many names those are, which is one per opcode and width.
265    pub names: usize,
266    /// A name a rule could be written at and none is, which is what a missing rule looks like.
267    pub uncovered: Vec<(Opcode, &'static str)>,
268    /// A name on [`NAMES`], which is a missing rule somebody decided to be missing.
269    pub deferred: Vec<(Opcode, &'static str)>,
270    /// A name a rule is written at that nothing can ever be called, which is a dead rule.
271    pub unreachable: Vec<&'static str>,
272    /// The opcodes lowered somewhere a rule cannot reach.
273    pub elsewhere: Vec<Opcode>,
274    /// The opcodes nothing lowers.
275    pub gaps: Vec<Opcode>,
276    /// The opcodes on none of the three lists, which is what a new opcode is until somebody says
277    /// where it goes.
278    pub unaccounted: Vec<Opcode>,
279}
280
281impl fmt::Display for Report {
282    fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
283        write!(
284            f,
285            "rucc-codegen: {} lowers {} of the {} IR opcodes by rule at {} names, {} are lowered \
286             where no rule reaches, {} have no lowering yet and {} names are left for later",
287            self.source,
288            self.by_rule.len(),
289            self.opcodes,
290            self.names,
291            self.elsewhere.len(),
292            self.gaps.len(),
293            self.deferred.len()
294        )
295    }
296}
297
298/// What a table covers.
299///
300/// Nothing is executed and nothing is compiled. The rule set and the naming of instructions are
301/// both data, and the answer is a comparison of two lists.
302#[must_use]
303pub fn report(table: &Table) -> Report {
304    let named = term::heads();
305    let patterns = pattern_heads(table);
306
307    let mut by_rule = Vec::new();
308    let mut uncovered = Vec::new();
309    let mut deferred = Vec::new();
310    for &(opcode, name) in &named {
311        if patterns.contains(&name) {
312            by_rule.push(opcode);
313        } else if NAMES.iter().any(|&(deliberate, ..)| deliberate == name) {
314            deferred.push((opcode, name));
315        } else {
316            uncovered.push((opcode, name));
317        }
318    }
319    // An opcode is covered when every name it has is covered, so one missing width takes the
320    // whole opcode off the list however many of its other widths are there. A name on `NAMES` does
321    // not take it off, because the opcode is lowered and the entry says which widths were left for
322    // later and why: that is a narrower claim than the opcode having nowhere to go, and putting it
323    // on `GAPS` instead would say the wrong thing about an `add` that lowers perfectly well at
324    // four widths.
325    for &(opcode, _) in &uncovered {
326        by_rule.retain(|&covered| covered != opcode);
327    }
328    by_rule.sort_unstable();
329    by_rule.dedup();
330
331    let names = named.len() - uncovered.len() - deferred.len();
332    let unreachable: Vec<&'static str> = patterns
333        .iter()
334        .filter(|head| !named.iter().any(|(_, name)| name == *head))
335        .copied()
336        .collect();
337
338    let elsewhere: Vec<Opcode> = ELSEWHERE.iter().map(|&(opcode, _)| opcode).collect();
339    let gaps: Vec<Opcode> = GAPS.iter().map(|&(opcode, ..)| opcode).collect();
340    let unaccounted: Vec<Opcode> = Opcode::all()
341        .filter(|opcode| {
342            !by_rule.contains(opcode) && !elsewhere.contains(opcode) && !gaps.contains(opcode)
343        })
344        .collect();
345
346    Report {
347        source: table.source,
348        opcodes: Opcode::all().count(),
349        by_rule,
350        names,
351        uncovered,
352        deferred,
353        unreachable,
354        elsewhere,
355        gaps,
356        unaccounted,
357    }
358}
359
360/// Every name a rule in a table is written about, which is the first test the trie makes.
361///
362/// Node zero is the root of the trie over the patterns and the first thing any walk asks is what
363/// the term in hand is called, so its tests are exactly the set of pattern heads. There is no
364/// wildcard there to worry about: a rule matching any term at all is one nobody has written and
365/// one that would be an error to write, since a lowering has to know what it is lowering.
366fn pattern_heads(table: &Table) -> Vec<&'static str> {
367    let Some(root) = table.nodes.first() else { return Vec::new() };
368    let mut found: Vec<&'static str> = root
369        .tests
370        .iter()
371        .filter_map(|(test, _)| match test {
372            Test::App { head, .. } => Some(*head),
373            Test::Int(_) => None,
374        })
375        .collect();
376    found.sort_unstable();
377    found.dedup();
378    found
379}
380
381/// The rules a target lowers by, or `None` where no back end in this crate covers it.
382///
383/// The same question [`crate::pipeline::Machine::for_target`] answers about the rest of a machine,
384/// and it is here as well because a caller that wants to write down what a run covered has a
385/// target and no machine. An architecture that gets a rule file at M6 gets an arm here at the same
386/// time, and until then it has no rules to report coverage of rather than an empty set of them.
387#[must_use]
388pub fn table(arch: Arch) -> Option<&'static Table> {
389    match arch {
390        Arch::X86_64 => Some(&crate::select::x86_64::TABLE),
391        Arch::Aarch64 | Arch::Riscv64 => None,
392    }
393}
394
395/// Which rules fired, over one function or over a whole compilation.
396///
397/// A bit per rule and nothing else. This is on the path of every instruction selected, so what it
398/// costs is paid by every compilation whether or not anybody asked for the number, and the cheapest
399/// thing that answers the question is a flag per rule set once.
400///
401/// The index of a rule is how this is kept and not how it is written down. An index moves the
402/// moment a rule is added above it, so [`Fired::listing`] names the rule file and the line instead:
403/// a line is a place somebody can open, and a report written by one build can still be read against
404/// a rule file that has grown since.
405#[derive(Debug, Clone, Default, PartialEq, Eq)]
406pub struct Fired {
407    /// One entry per rule, true once that rule has fired. It grows to fit the highest index
408    /// marked rather than being sized from a table, so nothing here has to be told which target
409    /// is being compiled for.
410    seen: Vec<bool>,
411}
412
413impl Fired {
414    /// Nothing has fired yet.
415    #[must_use]
416    pub const fn new() -> Fired {
417        Fired { seen: Vec::new() }
418    }
419
420    /// Records that the rule at this index fired.
421    pub fn mark(&mut self, rule: usize) {
422        if self.seen.len() <= rule {
423            self.seen.resize(rule + 1, false);
424        }
425        self.seen[rule] = true;
426    }
427
428    /// Whether the rule at this index fired.
429    #[must_use]
430    pub fn has(&self, rule: usize) -> bool {
431        self.seen.get(rule).copied().unwrap_or(false)
432    }
433
434    /// How many rules fired.
435    #[must_use]
436    pub fn count(&self) -> usize {
437        self.seen.iter().filter(|fired| **fired).count()
438    }
439
440    /// Takes in everything another one recorded.
441    ///
442    /// One compilation is many functions and one command line is many files, and the question is
443    /// about all of them together. Merging rather than writing a file per function is also what
444    /// keeps the answer the same however the work was scheduled.
445    pub fn merge(&mut self, other: &Fired) {
446        if self.seen.len() < other.seen.len() {
447            self.seen.resize(other.seen.len(), false);
448        }
449        for (mine, theirs) in self.seen.iter_mut().zip(&other.seen) {
450            *mine |= *theirs;
451        }
452    }
453
454    /// What `-Zrule-coverage=FILE` writes.
455    ///
456    /// One line per rule in the table, in the order the rule file writes them, each saying whether
457    /// the rule fired and naming the file and line it is written at. Every rule is listed rather
458    /// than only the ones that fired, so that one of these files says what the whole rule set was
459    /// as well as what this compilation reached: a reader unioning them over a corpus needs both
460    /// and would otherwise have to parse the rule file to get the second.
461    ///
462    /// The first line is a comment holding the count, which is the number a person wants and the
463    /// one thing here that is not worth making them add up.
464    #[must_use]
465    pub fn listing(&self, table: &Table) -> String {
466        let fired = table.rules.iter().enumerate().filter(|(index, _)| self.has(*index)).count();
467        let mut out = format!(
468            "# rucc rule coverage: {fired} of {} rules in {} fired\n",
469            table.rules.len(),
470            table.source
471        );
472        for (index, rule) in table.rules.iter().enumerate() {
473            let word = if self.has(index) { "fired" } else { "unused" };
474            let _ = writeln!(out, "{word} {}:{} {}", table.source, rule.line, rule.pattern);
475        }
476        out
477    }
478}
479
480#[cfg(test)]
481mod tests {
482    use super::*;
483    use crate::select::x86_64::TABLE;
484
485    /// The claim the whole module is for, in the direction that matters: a name an instruction
486    /// can be called by is a name a rule is written at. This is the width check as much as the
487    /// opcode check, since a name is an opcode and a width together.
488    #[test]
489    fn every_name_an_instruction_can_have_is_one_a_rule_is_written_at() {
490        let report = report(&TABLE);
491        assert!(
492            report.uncovered.is_empty(),
493            "nothing in {} lowers these, and each is an opcode at a width the rule language can \
494             spell: {:?}",
495            report.source,
496            report.uncovered
497        );
498    }
499
500    /// And the other direction, which costs nothing to ask and finds a rule that can never fire.
501    /// A pattern head no instruction is ever called by is a rule written against a name that was
502    /// renamed or misspelled, and it would sit there proved and unreachable.
503    #[test]
504    fn every_name_a_rule_is_written_at_is_one_an_instruction_can_have() {
505        let report = report(&TABLE);
506        assert!(
507            report.unreachable.is_empty(),
508            "{} has rules for these and no instruction is ever called one: {:?}",
509            report.source,
510            report.unreachable
511        );
512    }
513
514    /// Every opcode is one of the three things, so a new opcode in the IR fails this until
515    /// somebody says where it goes. That is the whole point: the answer for a new opcode should
516    /// be written down when it is added rather than discovered by a user compiling a program.
517    #[test]
518    fn every_opcode_is_lowered_or_is_a_gap_somebody_wrote_down() {
519        let report = report(&TABLE);
520        assert!(
521            report.unaccounted.is_empty(),
522            "no rule lowers these, `ELSEWHERE` does not say where they are lowered and `GAPS` \
523             does not say why they are not: {:?}",
524            report.unaccounted
525        );
526        assert_eq!(
527            report.by_rule.len() + report.elsewhere.len() + report.gaps.len(),
528            report.opcodes,
529            "the three lists overlap, so an opcode is counted twice"
530        );
531    }
532
533    /// An entry that starts being covered fails, which is the rule every list in this project is
534    /// kept under. An opcode a rule now lowers is one that should be off both lists, and a list
535    /// that keeps claiming otherwise is a list nobody can read.
536    #[test]
537    fn an_entry_a_rule_now_covers_is_a_stale_entry() {
538        let report = report(&TABLE);
539        for &(opcode, where_) in ELSEWHERE {
540            assert!(
541                !report.by_rule.contains(&opcode),
542                "`{}` is lowered by a rule now, so the `ELSEWHERE` entry saying it is lowered by \
543                 {where_} is stale",
544                opcode.name()
545            );
546        }
547        for &(opcode, why, issue) in GAPS {
548            assert!(
549                !report.by_rule.contains(&opcode),
550                "`{}` is lowered by a rule now, so the `GAPS` entry saying it is {why} is stale \
551                 and {issue} may be closed",
552                opcode.name()
553            );
554            assert!(
555                !report.elsewhere.contains(&opcode),
556                "`{}` is on both lists, so it is both lowered and not lowered",
557                opcode.name()
558            );
559        }
560    }
561
562    /// The same staleness rule one list down. A name a rule is written at is a name that is not
563    /// left for later, and an entry claiming otherwise is one that should have gone when the rule
564    /// arrived. The other direction is checked too: a name no instruction can ever have is a
565    /// misspelling, and it would sit here excusing nothing.
566    #[test]
567    fn a_name_a_rule_is_written_at_is_not_a_name_left_for_later() {
568        let heads = pattern_heads(&TABLE);
569        let named = term::heads();
570        for &(name, why, issue) in NAMES {
571            assert!(
572                !heads.contains(&name),
573                "`{name}` is lowered by a rule now, so the `NAMES` entry saying it is {why} is \
574                 stale and {issue} may be closer than it says"
575            );
576            assert!(
577                named.iter().any(|&(_, head)| head == name),
578                "`{name}` is not a name any instruction can have, so the `NAMES` entry excuses \
579                 nothing"
580            );
581        }
582        let report = report(&TABLE);
583        assert_eq!(report.deferred.len(), NAMES.len(), "{:?}", report.deferred);
584    }
585
586    /// Every gap names an issue, since a gap with no issue behind it is a gap nobody has decided
587    /// anything about, which is the thing this module exists to stop.
588    #[test]
589    fn every_gap_names_the_issue_that_closes_it() {
590        let issues = GAPS
591            .iter()
592            .map(|&(_, _, issue)| issue)
593            .chain(WIDTHS.iter().map(|&(_, _, issue)| issue))
594            .chain(NAMES.iter().map(|&(_, _, issue)| issue));
595        for issue in issues {
596            let number = issue
597                .strip_prefix("tamnd/rucc#")
598                .unwrap_or_else(|| panic!("{issue} is not an issue in this project's tracker"));
599            assert!(number.parse::<u32>().is_ok(), "{issue} does not name an issue number");
600        }
601    }
602
603    /// The count, which `spec/15-testing.md` section 15.8 says we keep about ourselves. CI runs
604    /// this test with the output shown, so the number lands in a log next to the rule proof
605    /// rather than in a file somebody has to go and read.
606    #[test]
607    fn the_count_is_reported() {
608        let report = report(&TABLE);
609        println!("{report}");
610        for &(opcode, why, issue) in GAPS {
611            println!("rucc-codegen: no lowering for `{}`, which is {why}: {issue}", opcode.name());
612        }
613        for &(width, why, issue) in WIDTHS {
614            println!("rucc-codegen: no rule at {width}, which is {why}: {issue}");
615        }
616        for &(name, why, issue) in NAMES {
617            println!("rucc-codegen: no rule at `{name}`, which is {why}: {issue}");
618        }
619        assert_eq!(report.gaps.len(), GAPS.len());
620    }
621
622    /// What the root of the trie is, which is the assumption [`pattern_heads`] rests on. If the
623    /// rule compiler ever built the trie some other way this would say so, rather than the
624    /// coverage numbers quietly becoming a report about an empty list.
625    #[test]
626    fn the_root_of_the_trie_is_the_head_of_every_pattern() {
627        let heads = pattern_heads(&TABLE);
628        assert!(!heads.is_empty(), "the table has rules and the root of the trie tests nothing");
629        for rule in TABLE.rules {
630            let head = rule
631                .pattern
632                .strip_prefix('(')
633                .and_then(|rest| rest.split([' ', ')']).next())
634                .expect("a pattern is an application");
635            assert!(
636                heads.contains(&head),
637                "line {}: {} is a pattern whose head the root of the trie does not test",
638                rule.line,
639                rule.pattern
640            );
641        }
642    }
643
644    /// The one target with a rule file, and the two that get one at M6. A machine that can be
645    /// compiled for has rules to report the coverage of, and one that cannot has none rather than
646    /// an empty set of them, which are different answers and would read the same as a number.
647    #[test]
648    fn a_target_with_a_back_end_is_a_target_with_a_rule_set() {
649        let x86 = table(Arch::X86_64).expect("x86-64 is what this crate lowers for");
650        assert_eq!(x86.source, TABLE.source);
651        assert!(!x86.rules.is_empty());
652        assert!(table(Arch::Aarch64).is_none(), "there is no aarch64 rule file yet");
653        assert!(table(Arch::Riscv64).is_none(), "there is no riscv64 rule file yet");
654    }
655
656    /// What a rule is called outside this process. The index is not it: a rule added at the top of
657    /// the file moves every index below it, and a report from last week would then be a report
658    /// about the wrong rules. The file and the line do not move that way and are somewhere to look.
659    #[test]
660    fn a_rule_is_written_down_as_the_place_it_is_written_at() {
661        let mut fired = Fired::new();
662        fired.mark(0);
663        let listing = fired.listing(&TABLE);
664        let first =
665            format!("fired {}:{} {}", TABLE.source, TABLE.rules[0].line, TABLE.rules[0].pattern);
666        assert!(listing.contains(&first), "{listing}");
667        assert!(listing.lines().next().is_some_and(|line| line.starts_with('#')), "{listing}");
668    }
669
670    /// Every rule is listed and not only the ones that fired, which is what lets one of these files
671    /// be read on its own. A reader that only got the rules that fired would have to parse the rule
672    /// file to find out what the rest of them were.
673    #[test]
674    fn one_file_says_what_the_whole_rule_set_is() {
675        let listing = Fired::new().listing(&TABLE);
676        let lines: Vec<&str> = listing.lines().collect();
677        assert_eq!(lines.len(), TABLE.rules.len() + 1, "one line per rule and one for the count");
678        assert_eq!(
679            lines.iter().filter(|line| line.starts_with("unused ")).count(),
680            TABLE.rules.len()
681        );
682        assert!(lines[0].contains(&format!("0 of {} rules", TABLE.rules.len())), "{}", lines[0]);
683    }
684
685    /// A compilation is many functions and a command line is many files, and the question is about
686    /// all of them at once. Merging is also what keeps the answer the same however the work was
687    /// scheduled, which is the rule `spec/03-architecture.md` section 3.7 holds everything to.
688    #[test]
689    fn what_two_runs_reached_is_what_either_of_them_reached() {
690        let mut one = Fired::new();
691        one.mark(3);
692        one.mark(3);
693        assert_eq!(one.count(), 1, "a rule that fires twice is one rule");
694        let mut two = Fired::new();
695        two.mark(0);
696        two.mark(9);
697        one.merge(&two);
698        assert_eq!(one.count(), 3);
699        assert!(one.has(0) && one.has(3) && one.has(9));
700        assert!(!one.has(1));
701
702        // The merge is symmetric, since neither order of two files is the right one.
703        let mut back = Fired::new();
704        back.mark(0);
705        back.mark(9);
706        let mut three = Fired::new();
707        three.mark(3);
708        back.merge(&three);
709        assert_eq!(back, one);
710    }
711}