rucc_codegen/coverage.rs
1//! Which IR opcodes have somewhere to go, and which do not.
2//!
3//! Design: `spec/10-backend.md` section 10.2, under **Coverage**.
4//!
5//! Every opcode has to be lowered by something or be a hole somebody wrote down. Without this the
6//! way a hole is found is that somebody compiles a program containing one and the selector reports
7//! that it cannot lower an instruction, which is a fine diagnostic and a bad discovery mechanism:
8//! it turns a gap in the rule set into a user's problem rather than a failing build.
9//!
10//! # The three answers
11//!
12//! An opcode is lowered by a rule, or somewhere a rule cannot reach, or nowhere.
13//!
14//! The first is the ordinary answer and the one this can check by itself. [`crate::term`] says
15//! every name a rule could be written at, the table says every name one is written at, and an
16//! opcode is covered when each of its names is in both. That is what makes this a check about
17//! widths rather than about opcodes: an `add` with a rule at four widths and no rule at the fifth
18//! is not covered, and would be reported here as the missing name rather than as a covered opcode.
19//!
20//! The second is [`ELSEWHERE`], which is not a gap. `spec/10-backend.md` names five of them and
21//! there are more now, and they are all the same kind of thing: an opcode whose lowering depends on
22//! something no pattern can see. Where a call's arguments go depends on the signature, where a
23//! local lives depends on the frame, an unconditional jump is an edge and edges live on the block,
24//! and a `memcpy` is a run of moves whose length is a constant the pattern would have to count. A
25//! rule matches one term and can say none of that.
26//!
27//! The third is [`GAPS`], which is the number `spec/15-testing.md` section 15.8 says we keep. Each
28//! entry names why it is there and the issue that closes it, so that an opcode nobody has written a
29//! rule for is a decision somebody wrote down rather than a surprise.
30//!
31//! [`WIDTHS`] and [`NAMES`] are the same third answer said about something smaller than an opcode.
32//! A width on [`WIDTHS`] has no names at all, so no opcode is missing a rule at it, and a name on
33//! [`NAMES`] is one width of an opcode that lowers at its other widths. Both carry the issue that
34//! closes them for the same reason [`GAPS`] does.
35//!
36//! # What makes the lists honest
37//!
38//! An entry that stops being true fails. An opcode on either list that a rule starts covering is a
39//! stale entry and the tests below say so by name, which is the same rule the exclusion lists in
40//! the compatibility harness are kept under: a list nothing checks is a list that only grows.
41//!
42//! The direction this cannot check is an opcode moving from [`GAPS`] to [`ELSEWHERE`] without the
43//! list following it, because where an opcode is lowered by name is a `match` arm and there is
44//! nothing to ask about a `match` arm from here. What that costs is one line of a list going out of
45//! date; what it does not cost is a gap going unnoticed, since the opcode is still on a list and
46//! still counted.
47//!
48//! # The other question
49//!
50//! All of the above is about the rule set as it is written. [`Fired`] is about the rule set as it
51//! is used: which rules a compilation actually reached. A rule nothing reaches is proved and dead
52//! weight, or it is a construct the corpus does not contain and somebody should know which. The
53//! selector marks a rule as it fires it, the driver writes the marks out under
54//! `-Zrule-coverage=FILE`, and the harness in `tamnd/rucc-compat` unions those files over a corpus,
55//! which is what turns coverage of the rule set into a number. `spec/20-execution-testing.md`
56//! section 20.9 is the design and `tamnd/rucc#261` is the work.
57
58use core::fmt;
59use core::fmt::Write as _;
60
61use rucc_ir::Opcode;
62use rucc_target::Arch;
63
64use crate::select::{Table, Test};
65use crate::term;
66
67/// An opcode no rule is written about, and the place that lowers it instead.
68///
69/// Not one of these is a gap. Each is an opcode whose lowering depends on something a pattern
70/// cannot see, so the answer lives where that something is known.
71pub static ELSEWHERE: &[(Opcode, &str)] = &[
72 // The convention. What a call's operands are is whatever the signature made them, and which
73 // register each one arrives in depends on the classification of every argument before it.
74 (Opcode::Call, "`crate::abi`, which builds a call out of the convention"),
75 (Opcode::CallIndirect, "`crate::abi`, the same instruction with the callee in a register"),
76 // The frame, which is not known until the allocator has finished running out of registers.
77 (Opcode::Alloca, "`crate::lower`, as an address into a frame `crate::frame` lays out later"),
78 // The stack pointer, which is not a value the program computed and so is not a value a rule
79 // could bind. A scope holding a variable length array reads it as it opens and writes it back
80 // as it closes, which is how the bytes are given back.
81 (Opcode::StackSave, "`crate::lower`, as a move out of the stack pointer"),
82 (Opcode::StackRestore, "`crate::lower`, the same move the other way round"),
83 // A relocation, which is right because of what the linker does rather than because of what
84 // any bitvector equals.
85 (Opcode::GlobalAddr, "`crate::lower`, a `lea` off the instruction pointer with a name on it"),
86 // The same instruction against a place in this function rather than a name outside it. What
87 // it addresses is a block, and a block is not a value a pattern can bind.
88 (Opcode::BlockAddr, "`crate::lower`, the same `lea` against a label of this function"),
89 // The one thing on this machine that no ordinary instruction can work out, which is why it
90 // is built here rather than matched: `%fs` is not a register a rule could name.
91 (Opcode::ThreadPointer, "`crate::lower`, as the load through `%fs` at zero that reads it"),
92 // A hint, which is built here for a reason of the same shape and one step stronger: which of
93 // the four instructions it is comes out of a number in the builtin's arguments, and a pattern
94 // matches on an opcode and a type and could not see it.
95 (Opcode::Prefetch, "`crate::lower`, as one of the four `prefetch` instructions"),
96 // No instruction at all. The IR keeps the width the same and the machine has one register
97 // file for both, so the value is already where it needs to be.
98 (Opcode::PtrToInt, "`crate::lower`, which renames the value rather than computing anything"),
99 (Opcode::IntToPtr, "`crate::lower`, the same rename the other way round"),
100 // Memory SSA, which is built at -O2, read by the passes that need it, and taken back off
101 // before selection. Nothing in the back end has ever seen a value of type `mem`.
102 (Opcode::MemEntry, "nothing at all, since memory SSA comes off before the back end runs"),
103 // The edges and the two ways of writing down that control does not arrive.
104 (Opcode::Jump, "`crate::layout`, since an edge is on the block and not in the block"),
105 // The one terminator selection does write, because what it reads is a value. How many arms it
106 // has is not fixed, and a rule says what an instruction reads rather than where a block goes.
107 (Opcode::IndirectBr, "`crate::lower`, as the jump through the register that holds the address"),
108 (Opcode::Unreachable, "nothing at all, which is the answer for a place control does not reach"),
109 (Opcode::UnreachableHint, "nothing at all, for the same reason"),
110 // Rewritten into the opcodes above before selection ever sees them.
111 (Opcode::Switch, "`crate::switch`, into the tests its clusters need"),
112 (Opcode::FConst, "`crate::expand`, into a constant in memory and a load of it"),
113 (Opcode::FNeg, "`crate::expand`, into the sign bit flip it is"),
114 (Opcode::UIToFP, "`crate::expand`, into a signed conversion with a widening or a halving"),
115 (Opcode::FPToUI, "`crate::expand`, into a signed conversion with a narrowing or a correction"),
116 (Opcode::Memcpy, "`crate::expand`, into the moves it stands for"),
117 (Opcode::Memset, "`crate::expand`, into the fills it stands for"),
118 (Opcode::Memmove, "`crate::expand`, into a call, since the two regions may overlap"),
119 (Opcode::Bswap, "`crate::expand`, into the shifts and masks that reverse the bytes"),
120 // The ordered accesses, which this machine already makes ordered. `crate::expand` says what
121 // total store order gives for nothing and what the one ordering it does not give costs.
122 (Opcode::AtomicLoad, "`crate::expand`, into the plain load that is already an acquire"),
123 (Opcode::AtomicStore, "`crate::expand`, into the plain store, and a barrier at the strongest"),
124 // The barrier itself, which is one instruction or none and neither is a rewrite of anything.
125 // The template, which is a string and not a term. A rule set cannot be written over a string,
126 // so the instructions a template names are looked up in the machine description rather than
127 // matched, which is `rucc_target::x86_64::read`.
128 (
129 Opcode::InlineAsm,
130 "`crate::lower`, as the places its operands share and the instructions its template names",
131 ),
132 (
133 Opcode::Fence,
134 "`crate::lower`, as an `mfence` at the strongest ordering and nothing below it",
135 ),
136 // The compare and exchange, which is one instruction and produces two values, and a rule
137 // replaces a term with an instruction producing one.
138 (
139 Opcode::Cmpxchg,
140 "`crate::lower`, as a locked compare and exchange and the byte that reads its answer",
141 ),
142 // The read modify write, which produces one value a rule could have named and whose operation
143 // is carried beside it rather than in the head a rule matches on, so one pattern would be all
144 // thirteen of them.
145 (
146 Opcode::AtomicRmw,
147 "`crate::lower`, as an exchange or a locked add, and `crate::retry` for the eight with no \
148 instruction, with the two on floating values refused",
149 ),
150 (Opcode::Ctpop, "`crate::expand`, into the halving sum that counts the set bits"),
151 (Opcode::Ctlz, "`crate::expand`, into a smear and a set bit count"),
152 (Opcode::Cttz, "`crate::expand`, into a mask of the low zeroes and a set bit count"),
153 (Opcode::UAddOverflow, "`crate::expand`, into an add and a comparison against an operand"),
154 (Opcode::SAddOverflow, "`crate::expand`, into an add and the sign bit of the operands"),
155 (Opcode::USubOverflow, "`crate::expand`, into a subtract and a comparison of the operands"),
156 (Opcode::SSubOverflow, "`crate::expand`, into a subtract and the sign bit of the operands"),
157 (Opcode::UMulOverflow, "`crate::expand`, into a multiply and the high half of the product"),
158 (Opcode::SMulOverflow, "`crate::expand`, into the same, with the high half corrected for sign"),
159 // The variable argument list, which is four opcodes reading a structure the ABI describes.
160 (Opcode::VaStart, "`crate::varargs`, which writes the register save area the ABI describes"),
161 (Opcode::VaArg, "`crate::varargs`, into the walk over that structure"),
162 (Opcode::VaObject, "`crate::varargs`, the same walk for something that arrived in memory"),
163 (Opcode::VaCopy, "`crate::varargs`, into a copy of the structure"),
164 (Opcode::VaEnd, "`crate::varargs`, which removes it, since there is nothing to undo"),
165 // Memory safety. A check is a call to the runtime, and the rewrite happens after the optimizer
166 // has run so that the descriptor table only has rows for checks that survived it.
167 (Opcode::CheckBounds, "`rucc_safety::lower`, into a call carrying the row that describes it"),
168 (Opcode::CheckLive, "`rucc_safety::lower`, the same call over the lifetime plane"),
169 (Opcode::CheckDeriv, "`rucc_safety::lower`, the same call where the pointer is computed"),
170 (Opcode::CheckType, "`rucc_safety::lower`, the same call, carrying the type asked about"),
171 (
172 Opcode::CheckInit,
173 "`rucc_safety::lower`, the same call over the init plane, carrying no type",
174 ),
175 (Opcode::CheckRace, "`rucc_safety::lower`, the same call over the epoch plane"),
176 // The five plane writes the same pass emits, which become calls the same way. A judgement
177 // decides nothing, so none of the calls carries a descriptor row, and neither do the two
178 // edges below them.
179 (Opcode::MetaType, "`rucc_safety::lower`, into the call that records what a store stored"),
180 (Opcode::MetaTypeCopy, "`rucc_safety::lower`, the same call over the range a copy read"),
181 (Opcode::MetaInit, "`rucc_safety::lower`, into the call that says a store wrote a range"),
182 (Opcode::MetaInitCopy, "`rucc_safety::lower`, the same call over the range a copy read"),
183 (Opcode::MetaEpoch, "`rucc_safety::lower`, into the call that says which thread stored"),
184 // The two halves of a synchronization edge, which are the same shape of call and are not a
185 // plane write at all: what they move is a thread's own clock, which lives beside the thread.
186 (
187 Opcode::MetaRelease,
188 "`rucc_safety::lower`, into the call that publishes this thread's clock at an atomic",
189 ),
190 (Opcode::MetaAcquire, "`rucc_safety::lower`, into the call that takes the other end of it"),
191 // The same pair for a fence, which are the same calls with no key, since a fence orders
192 // against every thread rather than against an object.
193 (
194 Opcode::MetaFenceRelease,
195 "`rucc_safety::lower`, into the call that publishes this thread's clock to everyone",
196 ),
197 (
198 Opcode::MetaFenceAcquire,
199 "`rucc_safety::lower`, into the call that takes what any release fence published",
200 ),
201 // The `restrict` contract, which is judgement J8 and is the one check that records as well as
202 // asks. What it records goes in a slot the block owns, and the two markers are what open and
203 // close that slot, so all four are calls to the runtime the same way.
204 (
205 Opcode::CheckRestrictRead,
206 "`rucc_safety::lower`, into the call that asks what the block has already reached",
207 ),
208 (Opcode::CheckRestrictWrite, "`rucc_safety::lower`, the same call, saying it wrote"),
209 (Opcode::RestrictEnter, "`rucc_safety::lower`, into the call that opens the block's record"),
210 (Opcode::RestrictLeave, "`rucc_safety::lower`, into the call that closes it again"),
211 (Opcode::CapExtent, "`rucc_safety::lower`, into a call that asks rather than one that judges"),
212 (Opcode::CapExtentBack, "`rucc_safety::lower`, the same call about the bytes below an address"),
213 // The capability the checks were reading, which the same pass takes out once they are calls,
214 // because a call to the runtime is handed an address and finds the rest for itself. One that
215 // something does read is a slot, and the only one of those the pass can fill so far is a
216 // capability for a pointer an allocator just returned, which is a load out of that instance's
217 // own header rather than anything worked out from the address.
218 (Opcode::CapOf, "`rucc_safety::slot`, into a call for a fresh allocation and gone otherwise"),
219 // The two ends of a capability that something does read. A capability is four words of frame
220 // and the value that stands for one is the slot's address, so the pair below is an `alloca`
221 // with four zero words written into it and a call handed the addresses of two slots.
222 (Opcode::CapNull, "`rucc_safety::slot`, into a frame slot with the bottom capability in it"),
223 (Opcode::CapStore, "`rucc_safety::slot`, into the call that writes one into the aux plane"),
224 // The other end of that write, which is the one capability nothing has to work out, because the
225 // store that put it beside the pointer already did. So this is a call too, and it is the only
226 // instruction the pass rewrites that reads a slot and fills one.
227 (Opcode::CapLoad, "`rucc_safety::slot`, into the call that reads one back out again"),
228 // The sub-object tier's whole mechanism, which is arithmetic on the range a capability holds
229 // and is a call for the same reason the rest are: where the four words sit is the runtime's to
230 // know, and a second place that agreed about it would be a second place that could stop.
231 (Opcode::CapNarrow, "`rucc_safety::slot`, into the call that moves the range in"),
232 // What `__builtin_expect` said, which the pass writes onto the arms of the branch it was said
233 // about before taking the instruction out, so that a hint and a profile are the same thing to
234 // everything downstream of the optimizer.
235 (Opcode::Expect, "`rucc_opt::expect`, which moves the hint onto the branch and removes it"),
236];
237
238/// An opcode nothing lowers, why it is here, and the issue that closes it.
239///
240/// This is the count `spec/15-testing.md` section 15.8 asks for. It is not zero yet and the
241/// spec says it should be, which is the honest reading of where the back end is: every one of
242/// these is a feature nobody has written, and all of them but one are opcodes the front end
243/// cannot produce either, so a program that reaches one of these is a program that reaches an
244/// unimplemented builtin first. The one is the remainder of two floats, which a program writes
245/// with an operator and which is a call to the maths library rather than an instruction.
246pub static GAPS: &[(Opcode, &str, &str)] = &[
247 (Opcode::Splat, "a vector, and no rule is written about a lane count", "tamnd/rucc#200"),
248 (
249 Opcode::TargetIntrinsic,
250 "the same, since what needs one is a vector builtin",
251 "tamnd/rucc#200",
252 ),
253 (
254 Opcode::FRem,
255 "a call to `fmod`, so a link line question as much as a lowering one",
256 "tamnd/rucc#226",
257 ),
258 (
259 Opcode::Fma,
260 "a call or one instruction, depending on what the machine is told it has",
261 "tamnd/rucc#226",
262 ),
263 (Opcode::Bitreverse, "a node nothing writes and nothing lowers", "tamnd/rucc#363"),
264 (Opcode::FrameAddress, "a walk up the frame pointers", "tamnd/rucc#312"),
265 (Opcode::ReturnAddress, "the same walk, one word further along", "tamnd/rucc#312"),
266 (
267 Opcode::SetjmpMarker,
268 "a call that returns twice, which the allocator has to be told about",
269 "tamnd/rucc#223",
270 ),
271 (Opcode::LongjmpMarker, "the same", "tamnd/rucc#223"),
272 (Opcode::TailCall, "a terminator nothing writes and nothing lowers", "tamnd/rucc#365"),
273 // Memory safety. These are a gap in a different sense from the rest: nothing emits one yet
274 // either, since the passes that would are milestones S5 and after, so there is no program the
275 // back end can be handed that reaches one. The ones the safety pass lowers are on `ELSEWHERE`,
276 // and four of those left this list without anything emitting them: `cap_null`, `cap_store`,
277 // `cap_load` and `cap_narrow` have a lowering waiting for the pass that will write one, because
278 // a capability had to be a value the back end could hold before any of them could be written
279 // down at all, which is tamnd/rucc#1085.
280 (Opcode::CapRecover, "a capability, and a read of the shadow planes", "tamnd/rucc#856"),
281 // The plane writes, which the runtime does for itself today because the only ranges anything
282 // asks about are the ones its own allocator handed out. A stack object needs these.
283 (Opcode::MetaBegin, "a write over a range of the lifetime plane", "tamnd/rucc#856"),
284 (
285 Opcode::MetaEnd,
286 "the same write, with the version bumped past every capability",
287 "tamnd/rucc#856",
288 ),
289 (
290 Opcode::MetaTransfer,
291 "the same, and the state a range is in while a device owns it, which is S2's",
292 "tamnd/rucc#856",
293 ),
294 (
295 Opcode::SafeRegionBegin,
296 "nothing at all, once the count document 10 section 10.2 asks for has been taken",
297 "tamnd/rucc#856",
298 ),
299 (Opcode::SafeRegionEnd, "the same, which is to say nothing", "tamnd/rucc#856"),
300];
301
302/// A width no rule is written at, why, and the issue that closes it.
303///
304/// The other half of coverage, and the half an opcode list cannot say. An opcode is covered when
305/// every name it has is a name a rule is written at, and a width with no name has no names to
306/// check: an `add` of two `__int128`s is not a missing rule for `add`, it is a width the rule
307/// language cannot spell. So the widths are written down here for the same reason the opcodes are
308/// written down above.
309pub static WIDTHS: &[(&str, &str, &str)] = &[
310 (
311 "one bit",
312 "everything but and, or, xor, a constant, and the widening out of one",
313 "tamnd/rucc#352",
314 ),
315 (
316 "a hundred and twenty eight bits",
317 "split into two halves before selection, except a division",
318 "tamnd/rucc#351",
319 ),
320 (
321 "eighty bits",
322 "a long double is on the x87 stack and no rule is about that stack",
323 "tamnd/rucc#326",
324 ),
325 (
326 "a hundred and twenty eight bits of float",
327 "turned into a call before selection, except a conditional move and the conversions \
328 against an integer that wide",
329 "tamnd/rucc#1064",
330 ),
331 (
332 "a vector of any lane count",
333 "a rule at a width says nothing about how many lanes",
334 "tamnd/rucc#200",
335 ),
336];
337
338/// A name a rule could be written at and deliberately is not, why, and the issue that puts it
339/// back.
340///
341/// The third list, and the one that is about a name rather than about an opcode or a width. An
342/// opcode on [`GAPS`] has no lowering at any width and a width on [`WIDTHS`] has no names at all,
343/// and neither of those can say that `add` is lowered at four widths and left alone at two.
344///
345/// This list used to be all of the narrow arithmetic. C promotes the operands of an arithmetic
346/// operator to `int` before the operator is applied, so `char a, b; a + b` is an `int` addition of
347/// two sign extended chars and there is no C program that asks the back end to add two bytes.
348/// Rules were written at those names anyway, ahead of the pass that would reach them, and they sat
349/// proved and never selected: `tamnd/rucc#261` measured that and `tamnd/rucc#368` took them out.
350/// Most of them are back, because the width narrowing pass in `tamnd/rucc#375` is that caller and
351/// it writes a byte add out of the truncation the assignment back to a `char` already was.
352///
353/// What is left is what the pass will not narrow. A divide is not narrowed because the most
354/// negative byte over minus one is a defined hundred and twenty eight at four bytes and is the
355/// overflow that raises at one, so it wants a range analysis saying that pair cannot happen.
356///
357/// Not every narrow name was ever here, because promotion is not the only way a narrow operation
358/// is born. Reading a bitfield is a shift and a mask by constants at the width of the storage
359/// unit, writing one is a mask, a shift and an `or` of two values, and a truth test on a narrow
360/// scalar is an `icmp_ne` at that scalar's width. Those fire, so those always had rules.
361pub static NAMES: &[(&str, &str, &str)] = &[
362 ("sdiv.i8", "a narrow divide, which wants a range analysis before it can be narrowed", NARROW),
363 ("sdiv.i16", "the same", NARROW),
364 ("udiv.i8", "the same", NARROW),
365 ("udiv.i16", "the same", NARROW),
366 ("srem.i8", "the same", NARROW),
367 ("srem.i16", "the same", NARROW),
368 ("urem.i8", "the same", NARROW),
369 ("urem.i16", "the same", NARROW),
370];
371
372/// The issue every entry of [`NAMES`] waits on, since they all wait on the same one.
373const NARROW: &str = "tamnd/rucc#375";
374
375/// What a target's rules cover, and what they do not.
376#[derive(Debug)]
377pub struct Report {
378 /// The rule file this is about, so that anything said about it names a file to open.
379 pub source: &'static str,
380 /// How many opcodes the IR has.
381 pub opcodes: usize,
382 /// The opcodes every name of which a rule is written at.
383 pub by_rule: Vec<Opcode>,
384 /// How many names those are, which is one per opcode and width.
385 pub names: usize,
386 /// A name a rule could be written at and none is, which is what a missing rule looks like.
387 pub uncovered: Vec<(Opcode, &'static str)>,
388 /// A name on [`NAMES`], which is a missing rule somebody decided to be missing.
389 pub deferred: Vec<(Opcode, &'static str)>,
390 /// A name a rule is written at that nothing can ever be called, which is a dead rule.
391 pub unreachable: Vec<&'static str>,
392 /// The opcodes lowered somewhere a rule cannot reach.
393 pub elsewhere: Vec<Opcode>,
394 /// The opcodes nothing lowers.
395 pub gaps: Vec<Opcode>,
396 /// The opcodes on none of the three lists, which is what a new opcode is until somebody says
397 /// where it goes.
398 pub unaccounted: Vec<Opcode>,
399}
400
401impl fmt::Display for Report {
402 fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
403 write!(
404 f,
405 "rucc-codegen: {} lowers {} of the {} IR opcodes by rule at {} names, {} are lowered \
406 where no rule reaches, {} have no lowering yet and {} names are left for later",
407 self.source,
408 self.by_rule.len(),
409 self.opcodes,
410 self.names,
411 self.elsewhere.len(),
412 self.gaps.len(),
413 self.deferred.len()
414 )
415 }
416}
417
418/// What a table covers.
419///
420/// Nothing is executed and nothing is compiled. The rule set and the naming of instructions are
421/// both data, and the answer is a comparison of two lists.
422#[must_use]
423pub fn report(table: &Table) -> Report {
424 let named = term::heads();
425 let patterns = pattern_heads(table);
426
427 let mut by_rule = Vec::new();
428 let mut uncovered = Vec::new();
429 let mut deferred = Vec::new();
430 for &(opcode, name) in &named {
431 if patterns.contains(&name) {
432 by_rule.push(opcode);
433 } else if NAMES.iter().any(|&(deliberate, ..)| deliberate == name) {
434 deferred.push((opcode, name));
435 } else {
436 uncovered.push((opcode, name));
437 }
438 }
439 // An opcode is covered when every name it has is covered, so one missing width takes the
440 // whole opcode off the list however many of its other widths are there. A name on `NAMES` does
441 // not take it off, because the opcode is lowered and the entry says which widths were left for
442 // later and why: that is a narrower claim than the opcode having nowhere to go, and putting it
443 // on `GAPS` instead would say the wrong thing about an `add` that lowers perfectly well at
444 // four widths.
445 for &(opcode, _) in &uncovered {
446 by_rule.retain(|&covered| covered != opcode);
447 }
448 by_rule.sort_unstable();
449 by_rule.dedup();
450
451 let names = named.len() - uncovered.len() - deferred.len();
452 let unreachable: Vec<&'static str> = patterns
453 .iter()
454 .filter(|head| !named.iter().any(|(_, name)| name == *head))
455 .copied()
456 .collect();
457
458 let elsewhere: Vec<Opcode> = ELSEWHERE.iter().map(|&(opcode, _)| opcode).collect();
459 let gaps: Vec<Opcode> = GAPS.iter().map(|&(opcode, ..)| opcode).collect();
460 let unaccounted: Vec<Opcode> = Opcode::all()
461 .filter(|opcode| {
462 !by_rule.contains(opcode) && !elsewhere.contains(opcode) && !gaps.contains(opcode)
463 })
464 .collect();
465
466 Report {
467 source: table.source,
468 opcodes: Opcode::all().count(),
469 by_rule,
470 names,
471 uncovered,
472 deferred,
473 unreachable,
474 elsewhere,
475 gaps,
476 unaccounted,
477 }
478}
479
480/// Every name a rule in a table is written about, which is the first test the trie makes.
481///
482/// Node zero is the root of the trie over the patterns and the first thing any walk asks is what
483/// the term in hand is called, so its tests are exactly the set of pattern heads. There is no
484/// wildcard there to worry about: a rule matching any term at all is one nobody has written and
485/// one that would be an error to write, since a lowering has to know what it is lowering.
486fn pattern_heads(table: &Table) -> Vec<&'static str> {
487 let Some(root) = table.nodes.first() else { return Vec::new() };
488 let mut found: Vec<&'static str> = root
489 .tests
490 .iter()
491 .filter_map(|(test, _)| match test {
492 Test::App { head, .. } => Some(*head),
493 // Neither can be at the root. A pattern is a term with a head, so the first step of
494 // every one of them is a head, and there is nothing bound yet to be the same as.
495 Test::Int(_) | Test::Same(_) => None,
496 })
497 .collect();
498 found.sort_unstable();
499 found.dedup();
500 found
501}
502
503/// The rules a target lowers by, or `None` where no back end in this crate covers it.
504///
505/// The same question [`crate::pipeline::Machine::for_target`] answers about the rest of a machine,
506/// and it is here as well because a caller that wants to write down what a run covered has a
507/// target and no machine. An architecture that gets a rule file at M6 gets an arm here at the same
508/// time, and until then it has no rules to report coverage of rather than an empty set of them.
509#[must_use]
510pub fn table(arch: Arch) -> Option<&'static Table> {
511 match arch {
512 Arch::X86_64 => Some(&crate::select::x86_64::TABLE),
513 Arch::Aarch64 | Arch::Riscv64 => None,
514 }
515}
516
517/// Which rules fired, over one function or over a whole compilation.
518///
519/// A bit per rule and nothing else. This is on the path of every instruction selected, so what it
520/// costs is paid by every compilation whether or not anybody asked for the number, and the cheapest
521/// thing that answers the question is a flag per rule set once.
522///
523/// The index of a rule is how this is kept and not how it is written down. An index moves the
524/// moment a rule is added above it, so [`Fired::listing`] names the rule file and the line instead:
525/// a line is a place somebody can open, and a report written by one build can still be read against
526/// a rule file that has grown since.
527#[derive(Debug, Clone, Default, PartialEq, Eq)]
528pub struct Fired {
529 /// One entry per rule, true once that rule has fired. It grows to fit the highest index
530 /// marked rather than being sized from a table, so nothing here has to be told which target
531 /// is being compiled for.
532 seen: Vec<bool>,
533}
534
535impl Fired {
536 /// Nothing has fired yet.
537 #[must_use]
538 pub const fn new() -> Fired {
539 Fired { seen: Vec::new() }
540 }
541
542 /// Records that the rule at this index fired.
543 pub fn mark(&mut self, rule: usize) {
544 if self.seen.len() <= rule {
545 self.seen.resize(rule + 1, false);
546 }
547 self.seen[rule] = true;
548 }
549
550 /// Whether the rule at this index fired.
551 #[must_use]
552 pub fn has(&self, rule: usize) -> bool {
553 self.seen.get(rule).copied().unwrap_or(false)
554 }
555
556 /// How many rules fired.
557 #[must_use]
558 pub fn count(&self) -> usize {
559 self.seen.iter().filter(|fired| **fired).count()
560 }
561
562 /// Takes in everything another one recorded.
563 ///
564 /// One compilation is many functions and one command line is many files, and the question is
565 /// about all of them together. Merging rather than writing a file per function is also what
566 /// keeps the answer the same however the work was scheduled.
567 pub fn merge(&mut self, other: &Fired) {
568 if self.seen.len() < other.seen.len() {
569 self.seen.resize(other.seen.len(), false);
570 }
571 for (mine, theirs) in self.seen.iter_mut().zip(&other.seen) {
572 *mine |= *theirs;
573 }
574 }
575
576 /// What `-Zrule-coverage=FILE` writes.
577 ///
578 /// One line per rule in the table, in the order the rule file writes them, each saying whether
579 /// the rule fired and naming the file and line it is written at. Every rule is listed rather
580 /// than only the ones that fired, so that one of these files says what the whole rule set was
581 /// as well as what this compilation reached: a reader unioning them over a corpus needs both
582 /// and would otherwise have to parse the rule file to get the second.
583 ///
584 /// The first line is a comment holding the count, which is the number a person wants and the
585 /// one thing here that is not worth making them add up.
586 #[must_use]
587 pub fn listing(&self, table: &Table) -> String {
588 let fired = table.rules.iter().enumerate().filter(|(index, _)| self.has(*index)).count();
589 let mut out = format!(
590 "# rucc rule coverage: {fired} of {} rules in {} fired\n",
591 table.rules.len(),
592 table.source
593 );
594 for (index, rule) in table.rules.iter().enumerate() {
595 let word = if self.has(index) { "fired" } else { "unused" };
596 let _ = writeln!(out, "{word} {}:{} {}", table.source, rule.line, rule.pattern);
597 }
598 out
599 }
600}
601
602#[cfg(test)]
603mod tests {
604 use super::*;
605 use crate::select::x86_64::TABLE;
606
607 /// The claim the whole module is for, in the direction that matters: a name an instruction
608 /// can be called by is a name a rule is written at. This is the width check as much as the
609 /// opcode check, since a name is an opcode and a width together.
610 #[test]
611 fn every_name_an_instruction_can_have_is_one_a_rule_is_written_at() {
612 let report = report(&TABLE);
613 assert!(
614 report.uncovered.is_empty(),
615 "nothing in {} lowers these, and each is an opcode at a width the rule language can \
616 spell: {:?}",
617 report.source,
618 report.uncovered
619 );
620 }
621
622 /// And the other direction, which costs nothing to ask and finds a rule that can never fire.
623 /// A pattern head no instruction is ever called by is a rule written against a name that was
624 /// renamed or misspelled, and it would sit there proved and unreachable.
625 #[test]
626 fn every_name_a_rule_is_written_at_is_one_an_instruction_can_have() {
627 let report = report(&TABLE);
628 assert!(
629 report.unreachable.is_empty(),
630 "{} has rules for these and no instruction is ever called one: {:?}",
631 report.source,
632 report.unreachable
633 );
634 }
635
636 /// Every opcode is one of the three things, so a new opcode in the IR fails this until
637 /// somebody says where it goes. That is the whole point: the answer for a new opcode should
638 /// be written down when it is added rather than discovered by a user compiling a program.
639 #[test]
640 fn every_opcode_is_lowered_or_is_a_gap_somebody_wrote_down() {
641 let report = report(&TABLE);
642 assert!(
643 report.unaccounted.is_empty(),
644 "no rule lowers these, `ELSEWHERE` does not say where they are lowered and `GAPS` \
645 does not say why they are not: {:?}",
646 report.unaccounted
647 );
648 assert_eq!(
649 report.by_rule.len() + report.elsewhere.len() + report.gaps.len(),
650 report.opcodes,
651 "the three lists overlap, so an opcode is counted twice"
652 );
653 }
654
655 /// An entry that starts being covered fails, which is the rule every list in this project is
656 /// kept under. An opcode a rule now lowers is one that should be off both lists, and a list
657 /// that keeps claiming otherwise is a list nobody can read.
658 #[test]
659 fn an_entry_a_rule_now_covers_is_a_stale_entry() {
660 let report = report(&TABLE);
661 for &(opcode, where_) in ELSEWHERE {
662 assert!(
663 !report.by_rule.contains(&opcode),
664 "`{}` is lowered by a rule now, so the `ELSEWHERE` entry saying it is lowered by \
665 {where_} is stale",
666 opcode.name()
667 );
668 }
669 for &(opcode, why, issue) in GAPS {
670 assert!(
671 !report.by_rule.contains(&opcode),
672 "`{}` is lowered by a rule now, so the `GAPS` entry saying it is {why} is stale \
673 and {issue} may be closed",
674 opcode.name()
675 );
676 assert!(
677 !report.elsewhere.contains(&opcode),
678 "`{}` is on both lists, so it is both lowered and not lowered",
679 opcode.name()
680 );
681 }
682 }
683
684 /// The same staleness rule one list down. A name a rule is written at is a name that is not
685 /// left for later, and an entry claiming otherwise is one that should have gone when the rule
686 /// arrived. The other direction is checked too: a name no instruction can ever have is a
687 /// misspelling, and it would sit here excusing nothing.
688 #[test]
689 fn a_name_a_rule_is_written_at_is_not_a_name_left_for_later() {
690 let heads = pattern_heads(&TABLE);
691 let named = term::heads();
692 for &(name, why, issue) in NAMES {
693 assert!(
694 !heads.contains(&name),
695 "`{name}` is lowered by a rule now, so the `NAMES` entry saying it is {why} is \
696 stale and {issue} may be closer than it says"
697 );
698 assert!(
699 named.iter().any(|&(_, head)| head == name),
700 "`{name}` is not a name any instruction can have, so the `NAMES` entry excuses \
701 nothing"
702 );
703 }
704 let report = report(&TABLE);
705 assert_eq!(report.deferred.len(), NAMES.len(), "{:?}", report.deferred);
706 }
707
708 /// Every gap names an issue, since a gap with no issue behind it is a gap nobody has decided
709 /// anything about, which is the thing this module exists to stop.
710 #[test]
711 fn every_gap_names_the_issue_that_closes_it() {
712 let issues = GAPS
713 .iter()
714 .map(|&(_, _, issue)| issue)
715 .chain(WIDTHS.iter().map(|&(_, _, issue)| issue))
716 .chain(NAMES.iter().map(|&(_, _, issue)| issue));
717 for issue in issues {
718 let number = issue
719 .strip_prefix("tamnd/rucc#")
720 .unwrap_or_else(|| panic!("{issue} is not an issue in this project's tracker"));
721 assert!(number.parse::<u32>().is_ok(), "{issue} does not name an issue number");
722 }
723 }
724
725 /// The count, which `spec/15-testing.md` section 15.8 says we keep about ourselves. CI runs
726 /// this test with the output shown, so the number lands in a log next to the rule proof
727 /// rather than in a file somebody has to go and read.
728 #[test]
729 fn the_count_is_reported() {
730 let report = report(&TABLE);
731 println!("{report}");
732 for &(opcode, why, issue) in GAPS {
733 println!("rucc-codegen: no lowering for `{}`, which is {why}: {issue}", opcode.name());
734 }
735 for &(width, why, issue) in WIDTHS {
736 println!("rucc-codegen: no rule at {width}, which is {why}: {issue}");
737 }
738 for &(name, why, issue) in NAMES {
739 println!("rucc-codegen: no rule at `{name}`, which is {why}: {issue}");
740 }
741 assert_eq!(report.gaps.len(), GAPS.len());
742 }
743
744 /// What the root of the trie is, which is the assumption [`pattern_heads`] rests on. If the
745 /// rule compiler ever built the trie some other way this would say so, rather than the
746 /// coverage numbers quietly becoming a report about an empty list.
747 #[test]
748 fn the_root_of_the_trie_is_the_head_of_every_pattern() {
749 let heads = pattern_heads(&TABLE);
750 assert!(!heads.is_empty(), "the table has rules and the root of the trie tests nothing");
751 for rule in TABLE.rules {
752 let head = rule
753 .pattern
754 .strip_prefix('(')
755 .and_then(|rest| rest.split([' ', ')']).next())
756 .expect("a pattern is an application");
757 assert!(
758 heads.contains(&head),
759 "line {}: {} is a pattern whose head the root of the trie does not test",
760 rule.line,
761 rule.pattern
762 );
763 }
764 }
765
766 /// The one target with a rule file, and the two that get one at M6. A machine that can be
767 /// compiled for has rules to report the coverage of, and one that cannot has none rather than
768 /// an empty set of them, which are different answers and would read the same as a number.
769 #[test]
770 fn a_target_with_a_back_end_is_a_target_with_a_rule_set() {
771 let x86 = table(Arch::X86_64).expect("x86-64 is what this crate lowers for");
772 assert_eq!(x86.source, TABLE.source);
773 assert!(!x86.rules.is_empty());
774 assert!(table(Arch::Aarch64).is_none(), "there is no aarch64 rule file yet");
775 assert!(table(Arch::Riscv64).is_none(), "there is no riscv64 rule file yet");
776 }
777
778 /// What a rule is called outside this process. The index is not it: a rule added at the top of
779 /// the file moves every index below it, and a report from last week would then be a report
780 /// about the wrong rules. The file and the line do not move that way and are somewhere to look.
781 #[test]
782 fn a_rule_is_written_down_as_the_place_it_is_written_at() {
783 let mut fired = Fired::new();
784 fired.mark(0);
785 let listing = fired.listing(&TABLE);
786 let first =
787 format!("fired {}:{} {}", TABLE.source, TABLE.rules[0].line, TABLE.rules[0].pattern);
788 assert!(listing.contains(&first), "{listing}");
789 assert!(listing.lines().next().is_some_and(|line| line.starts_with('#')), "{listing}");
790 }
791
792 /// Every rule is listed and not only the ones that fired, which is what lets one of these files
793 /// be read on its own. A reader that only got the rules that fired would have to parse the rule
794 /// file to find out what the rest of them were.
795 #[test]
796 fn one_file_says_what_the_whole_rule_set_is() {
797 let listing = Fired::new().listing(&TABLE);
798 let lines: Vec<&str> = listing.lines().collect();
799 assert_eq!(lines.len(), TABLE.rules.len() + 1, "one line per rule and one for the count");
800 assert_eq!(
801 lines.iter().filter(|line| line.starts_with("unused ")).count(),
802 TABLE.rules.len()
803 );
804 assert!(lines[0].contains(&format!("0 of {} rules", TABLE.rules.len())), "{}", lines[0]);
805 }
806
807 /// A compilation is many functions and a command line is many files, and the question is about
808 /// all of them at once. Merging is also what keeps the answer the same however the work was
809 /// scheduled, which is the rule `spec/03-architecture.md` section 3.7 holds everything to.
810 #[test]
811 fn what_two_runs_reached_is_what_either_of_them_reached() {
812 let mut one = Fired::new();
813 one.mark(3);
814 one.mark(3);
815 assert_eq!(one.count(), 1, "a rule that fires twice is one rule");
816 let mut two = Fired::new();
817 two.mark(0);
818 two.mark(9);
819 one.merge(&two);
820 assert_eq!(one.count(), 3);
821 assert!(one.has(0) && one.has(3) && one.has(9));
822 assert!(!one.has(1));
823
824 // The merge is symmetric, since neither order of two files is the right one.
825 let mut back = Fired::new();
826 back.mark(0);
827 back.mark(9);
828 let mut three = Fired::new();
829 three.mark(3);
830 back.merge(&three);
831 assert_eq!(back, one);
832 }
833}