rucc_codegen/coverage.rs
1//! Which IR opcodes have somewhere to go, and which do not.
2//!
3//! Design: `spec/10-backend.md` section 10.2, under **Coverage**.
4//!
5//! Every opcode has to be lowered by something or be a hole somebody wrote down. Without this the
6//! way a hole is found is that somebody compiles a program containing one and the selector reports
7//! that it cannot lower an instruction, which is a fine diagnostic and a bad discovery mechanism:
8//! it turns a gap in the rule set into a user's problem rather than a failing build.
9//!
10//! # The three answers
11//!
12//! An opcode is lowered by a rule, or somewhere a rule cannot reach, or nowhere.
13//!
14//! The first is the ordinary answer and the one this can check by itself. [`crate::term`] says
15//! every name a rule could be written at, the table says every name one is written at, and an
16//! opcode is covered when each of its names is in both. That is what makes this a check about
17//! widths rather than about opcodes: an `add` with a rule at four widths and no rule at the fifth
18//! is not covered, and would be reported here as the missing name rather than as a covered opcode.
19//!
20//! The second is [`ELSEWHERE`], which is not a gap. `spec/10-backend.md` names five of them and
21//! there are more now, and they are all the same kind of thing: an opcode whose lowering depends on
22//! something no pattern can see. Where a call's arguments go depends on the signature, where a
23//! local lives depends on the frame, an unconditional jump is an edge and edges live on the block,
24//! and a `memcpy` is a run of moves whose length is a constant the pattern would have to count. A
25//! rule matches one term and can say none of that.
26//!
27//! The third is [`GAPS`], which is the number `spec/15-testing.md` section 15.8 says we keep. Each
28//! entry names why it is there and the issue that closes it, so that an opcode nobody has written a
29//! rule for is a decision somebody wrote down rather than a surprise.
30//!
31//! [`WIDTHS`] and [`NAMES`] are the same third answer said about something smaller than an opcode.
32//! A width on [`WIDTHS`] has no names at all, so no opcode is missing a rule at it, and a name on
33//! [`NAMES`] is one width of an opcode that lowers at its other widths. Both carry the issue that
34//! closes them for the same reason [`GAPS`] does.
35//!
36//! # What makes the lists honest
37//!
38//! An entry that stops being true fails. An opcode on either list that a rule starts covering is a
39//! stale entry and the tests below say so by name, which is the same rule the exclusion lists in
40//! the compatibility harness are kept under: a list nothing checks is a list that only grows.
41//!
42//! The direction this cannot check is an opcode moving from [`GAPS`] to [`ELSEWHERE`] without the
43//! list following it, because where an opcode is lowered by name is a `match` arm and there is
44//! nothing to ask about a `match` arm from here. What that costs is one line of a list going out of
45//! date; what it does not cost is a gap going unnoticed, since the opcode is still on a list and
46//! still counted.
47//!
48//! # The other question
49//!
50//! All of the above is about the rule set as it is written. [`Fired`] is about the rule set as it
51//! is used: which rules a compilation actually reached. A rule nothing reaches is proved and dead
52//! weight, or it is a construct the corpus does not contain and somebody should know which. The
53//! selector marks a rule as it fires it, the driver writes the marks out under
54//! `-Zrule-coverage=FILE`, and the harness in `tamnd/rucc-compat` unions those files over a corpus,
55//! which is what turns coverage of the rule set into a number. `spec/20-execution-testing.md`
56//! section 20.9 is the design and `tamnd/rucc#261` is the work.
57
58use core::fmt;
59use core::fmt::Write as _;
60
61use rucc_ir::Opcode;
62use rucc_target::Arch;
63
64use crate::select::{Table, Test};
65use crate::term;
66
67/// An opcode no rule is written about, and the place that lowers it instead.
68///
69/// Not one of these is a gap. Each is an opcode whose lowering depends on something a pattern
70/// cannot see, so the answer lives where that something is known.
71pub static ELSEWHERE: &[(Opcode, &str)] = &[
72 // The convention. What a call's operands are is whatever the signature made them, and which
73 // register each one arrives in depends on the classification of every argument before it.
74 (Opcode::Call, "`crate::abi`, which builds a call out of the convention"),
75 (Opcode::CallIndirect, "`crate::abi`, the same instruction with the callee in a register"),
76 // The frame, which is not known until the allocator has finished running out of registers.
77 (Opcode::Alloca, "`crate::lower`, as an address into a frame `crate::frame` lays out later"),
78 // The stack pointer, which is not a value the program computed and so is not a value a rule
79 // could bind. A scope holding a variable length array reads it as it opens and writes it back
80 // as it closes, which is how the bytes are given back.
81 (Opcode::StackSave, "`crate::lower`, as a move out of the stack pointer"),
82 (Opcode::StackRestore, "`crate::lower`, the same move the other way round"),
83 // A relocation, which is right because of what the linker does rather than because of what
84 // any bitvector equals.
85 (Opcode::GlobalAddr, "`crate::lower`, a `lea` off the instruction pointer with a name on it"),
86 // No instruction at all. The IR keeps the width the same and the machine has one register
87 // file for both, so the value is already where it needs to be.
88 (Opcode::PtrToInt, "`crate::lower`, which renames the value rather than computing anything"),
89 (Opcode::IntToPtr, "`crate::lower`, the same rename the other way round"),
90 // Memory SSA, which is built at -O2, read by the passes that need it, and taken back off
91 // before selection. Nothing in the back end has ever seen a value of type `mem`.
92 (Opcode::MemEntry, "nothing at all, since memory SSA comes off before the back end runs"),
93 // The edges and the two ways of writing down that control does not arrive.
94 (Opcode::Jump, "`crate::layout`, since an edge is on the block and not in the block"),
95 (Opcode::Unreachable, "nothing at all, which is the answer for a place control does not reach"),
96 (Opcode::UnreachableHint, "nothing at all, for the same reason"),
97 // Rewritten into the opcodes above before selection ever sees them.
98 (Opcode::Switch, "`crate::switch`, into the tests its clusters need"),
99 (Opcode::FConst, "`crate::expand`, into a constant in memory and a load of it"),
100 (Opcode::FNeg, "`crate::expand`, into the sign bit flip it is"),
101 (Opcode::UIToFP, "`crate::expand`, into a signed conversion with a widening or a halving"),
102 (Opcode::FPToUI, "`crate::expand`, into a signed conversion with a narrowing or a correction"),
103 (Opcode::Memcpy, "`crate::expand`, into the moves it stands for"),
104 (Opcode::Memset, "`crate::expand`, into the fills it stands for"),
105 (Opcode::Memmove, "`crate::expand`, into a call, since the two regions may overlap"),
106 (Opcode::Bswap, "`crate::expand`, into the shifts and masks that reverse the bytes"),
107 // The ordered accesses, which this machine already makes ordered. `crate::expand` says what
108 // total store order gives for nothing and what the one ordering it does not give costs.
109 (Opcode::AtomicLoad, "`crate::expand`, into the plain load that is already an acquire"),
110 (Opcode::AtomicStore, "`crate::expand`, into the plain store, and a barrier at the strongest"),
111 // The barrier itself, which is one instruction or none and neither is a rewrite of anything.
112 // The template, which is a string and not a term. What an empty one stands for is no
113 // instructions and the places its operands share, and what a template with instructions in it
114 // stands for needs an assembler, which is `tamnd/rucc#349`.
115 (
116 Opcode::InlineAsm,
117 "`crate::lower`, as the places its operands share, while its template is empty",
118 ),
119 (
120 Opcode::Fence,
121 "`crate::lower`, as an `mfence` at the strongest ordering and nothing below it",
122 ),
123 // The compare and exchange, which is one instruction and produces two values, and a rule
124 // replaces a term with an instruction producing one.
125 (
126 Opcode::Cmpxchg,
127 "`crate::lower`, as a locked compare and exchange and the byte that reads its answer",
128 ),
129 // The read modify write, which produces one value a rule could have named and whose operation
130 // is carried beside it rather than in the head a rule matches on, so one pattern would be all
131 // thirteen of them.
132 (
133 Opcode::AtomicRmw,
134 "`crate::lower`, as an exchange or a locked add, and `crate::retry` for the eight with no \
135 instruction, with the two on floating values refused",
136 ),
137 (Opcode::Ctpop, "`crate::expand`, into the halving sum that counts the set bits"),
138 (Opcode::Ctlz, "`crate::expand`, into a smear and a set bit count"),
139 (Opcode::Cttz, "`crate::expand`, into a mask of the low zeroes and a set bit count"),
140 (Opcode::UAddOverflow, "`crate::expand`, into an add and a comparison against an operand"),
141 (Opcode::SAddOverflow, "`crate::expand`, into an add and the sign bit of the operands"),
142 (Opcode::USubOverflow, "`crate::expand`, into a subtract and a comparison of the operands"),
143 (Opcode::SSubOverflow, "`crate::expand`, into a subtract and the sign bit of the operands"),
144 (Opcode::UMulOverflow, "`crate::expand`, into a multiply and the high half of the product"),
145 (Opcode::SMulOverflow, "`crate::expand`, into the same, with the high half corrected for sign"),
146 // The variable argument list, which is four opcodes reading a structure the ABI describes.
147 (Opcode::VaStart, "`crate::varargs`, which writes the register save area the ABI describes"),
148 (Opcode::VaArg, "`crate::varargs`, into the walk over that structure"),
149 (Opcode::VaObject, "`crate::varargs`, the same walk for something that arrived in memory"),
150 (Opcode::VaCopy, "`crate::varargs`, into a copy of the structure"),
151 (Opcode::VaEnd, "`crate::varargs`, which removes it, since there is nothing to undo"),
152 // Memory safety. A check is a call to the runtime, and the rewrite happens after the optimizer
153 // has run so that the descriptor table only has rows for checks that survived it.
154 (Opcode::CheckBounds, "`rucc_safety::lower`, into a call carrying the row that describes it"),
155 (Opcode::CheckLive, "`rucc_safety::lower`, the same call over the lifetime plane"),
156 (Opcode::CheckDeriv, "`rucc_safety::lower`, the same call where the pointer is computed"),
157 (Opcode::CheckType, "`rucc_safety::lower`, the same call, carrying the type asked about"),
158 (
159 Opcode::CheckInit,
160 "`rucc_safety::lower`, the same call over the init plane, carrying no type",
161 ),
162 (Opcode::CheckRace, "`rucc_safety::lower`, the same call over the epoch plane"),
163 // The five plane writes the same pass emits, which become calls the same way. A judgement
164 // decides nothing, so none of the calls carries a descriptor row.
165 (Opcode::MetaType, "`rucc_safety::lower`, into the call that records what a store stored"),
166 (Opcode::MetaTypeCopy, "`rucc_safety::lower`, the same call over the range a copy read"),
167 (Opcode::MetaInit, "`rucc_safety::lower`, into the call that says a store wrote a range"),
168 (Opcode::MetaInitCopy, "`rucc_safety::lower`, the same call over the range a copy read"),
169 (Opcode::MetaEpoch, "`rucc_safety::lower`, into the call that says which thread stored"),
170 // The `restrict` contract, which is judgement J8 and is the one check that records as well as
171 // asks. What it records goes in a slot the block owns, and the two markers are what open and
172 // close that slot, so all four are calls to the runtime the same way.
173 (
174 Opcode::CheckRestrictRead,
175 "`rucc_safety::lower`, into the call that asks what the block has already reached",
176 ),
177 (Opcode::CheckRestrictWrite, "`rucc_safety::lower`, the same call, saying it wrote"),
178 (Opcode::RestrictEnter, "`rucc_safety::lower`, into the call that opens the block's record"),
179 (Opcode::RestrictLeave, "`rucc_safety::lower`, into the call that closes it again"),
180 (Opcode::CapExtent, "`rucc_safety::lower`, into a call that asks rather than one that judges"),
181 (Opcode::CapExtentBack, "`rucc_safety::lower`, the same call about the bytes below an address"),
182 // The capability the checks were reading, which the same pass takes out once they are calls,
183 // because a call to the runtime is handed an address and finds the rest for itself.
184 (Opcode::CapOf, "`rucc_safety::lower`, which removes it, since nothing reads it any more"),
185];
186
187/// An opcode nothing lowers, why it is here, and the issue that closes it.
188///
189/// This is the count `spec/15-testing.md` section 15.8 asks for. It is not zero yet and the
190/// spec says it should be, which is the honest reading of where the back end is: every one of
191/// these is a feature nobody has written, and all but three of them are opcodes the front end
192/// cannot produce either, so a program that reaches one of these is a program that reaches an
193/// unimplemented builtin first.
194pub static GAPS: &[(Opcode, &str, &str)] = &[
195 (Opcode::Splat, "a vector, and no rule is written about a lane count", "tamnd/rucc#200"),
196 (
197 Opcode::TargetIntrinsic,
198 "the same, since what needs one is a vector builtin",
199 "tamnd/rucc#200",
200 ),
201 (Opcode::BlockAddr, "the address of a label", "tamnd/rucc#353"),
202 (Opcode::IndirectBr, "the branch a computed goto turns into", "tamnd/rucc#353"),
203 (
204 Opcode::FRem,
205 "a call to `fmod`, so a link line question as much as a lowering one",
206 "tamnd/rucc#226",
207 ),
208 (
209 Opcode::Fma,
210 "a call or one instruction, depending on what the machine is told it has",
211 "tamnd/rucc#226",
212 ),
213 (Opcode::Bitreverse, "a node nothing writes and nothing lowers", "tamnd/rucc#363"),
214 (Opcode::Expect, "a branch weight nothing reads yet", "tamnd/rucc#364"),
215 (Opcode::Prefetch, "one instruction, once the hints have somewhere to go", "tamnd/rucc#313"),
216 (Opcode::FrameAddress, "a walk up the frame pointers", "tamnd/rucc#312"),
217 (Opcode::ReturnAddress, "the same walk, one word further along", "tamnd/rucc#312"),
218 (
219 Opcode::SetjmpMarker,
220 "a call that returns twice, which the allocator has to be told about",
221 "tamnd/rucc#223",
222 ),
223 (Opcode::LongjmpMarker, "the same", "tamnd/rucc#223"),
224 (Opcode::TailCall, "a terminator nothing writes and nothing lowers", "tamnd/rucc#365"),
225 // Memory safety. These are a gap in a different sense from the rest: nothing emits one yet
226 // either, since the passes that would are milestones S5 and after, so there is no program the
227 // back end can be handed that reaches one. The fourteen the safety pass does emit are on
228 // `ELSEWHERE`.
229 (
230 Opcode::CapLoad,
231 "a capability, whose runtime shape `spec/safe-memory/05-representation.md` decides",
232 "tamnd/rucc#856",
233 ),
234 (Opcode::CapStore, "the same, and a store into the slot beside a pointer", "tamnd/rucc#856"),
235 (
236 Opcode::CapNull,
237 "the same, and it is whatever the representation says nothing is",
238 "tamnd/rucc#856",
239 ),
240 (Opcode::CapNarrow, "the same, and arithmetic on the bounds it holds", "tamnd/rucc#856"),
241 (Opcode::CapRecover, "the same, and a read of the shadow planes", "tamnd/rucc#856"),
242 // The plane writes, which the runtime does for itself today because the only ranges anything
243 // asks about are the ones its own allocator handed out. A stack object needs these.
244 (Opcode::MetaBegin, "a write over a range of the lifetime plane", "tamnd/rucc#856"),
245 (
246 Opcode::MetaEnd,
247 "the same write, with the version bumped past every capability",
248 "tamnd/rucc#856",
249 ),
250 (
251 Opcode::MetaTransfer,
252 "the same, and the state a range is in while a device owns it, which is S2's",
253 "tamnd/rucc#856",
254 ),
255 (
256 Opcode::SafeRegionBegin,
257 "nothing at all, once the count document 10 section 10.2 asks for has been taken",
258 "tamnd/rucc#856",
259 ),
260 (Opcode::SafeRegionEnd, "the same, which is to say nothing", "tamnd/rucc#856"),
261];
262
263/// A width no rule is written at, why, and the issue that closes it.
264///
265/// The other half of coverage, and the half an opcode list cannot say. An opcode is covered when
266/// every name it has is a name a rule is written at, and a width with no name has no names to
267/// check: an `add` of two `__int128`s is not a missing rule for `add`, it is a width the rule
268/// language cannot spell. So the widths are written down here for the same reason the opcodes are
269/// written down above.
270pub static WIDTHS: &[(&str, &str, &str)] = &[
271 (
272 "one bit",
273 "everything but and, or, xor, a constant, and the widening out of one",
274 "tamnd/rucc#352",
275 ),
276 (
277 "a hundred and twenty eight bits",
278 "split into two halves before selection, except a division",
279 "tamnd/rucc#351",
280 ),
281 (
282 "eighty bits",
283 "a long double is on the x87 stack and no rule is about that stack",
284 "tamnd/rucc#326",
285 ),
286 (
287 "a vector of any lane count",
288 "a rule at a width says nothing about how many lanes",
289 "tamnd/rucc#200",
290 ),
291];
292
293/// A name a rule could be written at and deliberately is not, why, and the issue that puts it
294/// back.
295///
296/// The third list, and the one that is about a name rather than about an opcode or a width. An
297/// opcode on [`GAPS`] has no lowering at any width and a width on [`WIDTHS`] has no names at all,
298/// and neither of those can say that `add` is lowered at four widths and left alone at two.
299///
300/// This list used to be all of the narrow arithmetic. C promotes the operands of an arithmetic
301/// operator to `int` before the operator is applied, so `char a, b; a + b` is an `int` addition of
302/// two sign extended chars and there is no C program that asks the back end to add two bytes.
303/// Rules were written at those names anyway, ahead of the pass that would reach them, and they sat
304/// proved and never selected: `tamnd/rucc#261` measured that and `tamnd/rucc#368` took them out.
305/// Most of them are back, because the width narrowing pass in `tamnd/rucc#375` is that caller and
306/// it writes a byte add out of the truncation the assignment back to a `char` already was.
307///
308/// What is left is what the pass will not narrow. A divide is not narrowed because the most
309/// negative byte over minus one is a defined hundred and twenty eight at four bytes and is the
310/// overflow that raises at one, so it wants a range analysis saying that pair cannot happen.
311///
312/// Not every narrow name was ever here, because promotion is not the only way a narrow operation
313/// is born. Reading a bitfield is a shift and a mask by constants at the width of the storage
314/// unit, writing one is a mask, a shift and an `or` of two values, and a truth test on a narrow
315/// scalar is an `icmp_ne` at that scalar's width. Those fire, so those always had rules.
316pub static NAMES: &[(&str, &str, &str)] = &[
317 ("sdiv.i8", "a narrow divide, which wants a range analysis before it can be narrowed", NARROW),
318 ("sdiv.i16", "the same", NARROW),
319 ("udiv.i8", "the same", NARROW),
320 ("udiv.i16", "the same", NARROW),
321 ("srem.i8", "the same", NARROW),
322 ("srem.i16", "the same", NARROW),
323 ("urem.i8", "the same", NARROW),
324 ("urem.i16", "the same", NARROW),
325];
326
327/// The issue every entry of [`NAMES`] waits on, since they all wait on the same one.
328const NARROW: &str = "tamnd/rucc#375";
329
330/// What a target's rules cover, and what they do not.
331#[derive(Debug)]
332pub struct Report {
333 /// The rule file this is about, so that anything said about it names a file to open.
334 pub source: &'static str,
335 /// How many opcodes the IR has.
336 pub opcodes: usize,
337 /// The opcodes every name of which a rule is written at.
338 pub by_rule: Vec<Opcode>,
339 /// How many names those are, which is one per opcode and width.
340 pub names: usize,
341 /// A name a rule could be written at and none is, which is what a missing rule looks like.
342 pub uncovered: Vec<(Opcode, &'static str)>,
343 /// A name on [`NAMES`], which is a missing rule somebody decided to be missing.
344 pub deferred: Vec<(Opcode, &'static str)>,
345 /// A name a rule is written at that nothing can ever be called, which is a dead rule.
346 pub unreachable: Vec<&'static str>,
347 /// The opcodes lowered somewhere a rule cannot reach.
348 pub elsewhere: Vec<Opcode>,
349 /// The opcodes nothing lowers.
350 pub gaps: Vec<Opcode>,
351 /// The opcodes on none of the three lists, which is what a new opcode is until somebody says
352 /// where it goes.
353 pub unaccounted: Vec<Opcode>,
354}
355
356impl fmt::Display for Report {
357 fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
358 write!(
359 f,
360 "rucc-codegen: {} lowers {} of the {} IR opcodes by rule at {} names, {} are lowered \
361 where no rule reaches, {} have no lowering yet and {} names are left for later",
362 self.source,
363 self.by_rule.len(),
364 self.opcodes,
365 self.names,
366 self.elsewhere.len(),
367 self.gaps.len(),
368 self.deferred.len()
369 )
370 }
371}
372
373/// What a table covers.
374///
375/// Nothing is executed and nothing is compiled. The rule set and the naming of instructions are
376/// both data, and the answer is a comparison of two lists.
377#[must_use]
378pub fn report(table: &Table) -> Report {
379 let named = term::heads();
380 let patterns = pattern_heads(table);
381
382 let mut by_rule = Vec::new();
383 let mut uncovered = Vec::new();
384 let mut deferred = Vec::new();
385 for &(opcode, name) in &named {
386 if patterns.contains(&name) {
387 by_rule.push(opcode);
388 } else if NAMES.iter().any(|&(deliberate, ..)| deliberate == name) {
389 deferred.push((opcode, name));
390 } else {
391 uncovered.push((opcode, name));
392 }
393 }
394 // An opcode is covered when every name it has is covered, so one missing width takes the
395 // whole opcode off the list however many of its other widths are there. A name on `NAMES` does
396 // not take it off, because the opcode is lowered and the entry says which widths were left for
397 // later and why: that is a narrower claim than the opcode having nowhere to go, and putting it
398 // on `GAPS` instead would say the wrong thing about an `add` that lowers perfectly well at
399 // four widths.
400 for &(opcode, _) in &uncovered {
401 by_rule.retain(|&covered| covered != opcode);
402 }
403 by_rule.sort_unstable();
404 by_rule.dedup();
405
406 let names = named.len() - uncovered.len() - deferred.len();
407 let unreachable: Vec<&'static str> = patterns
408 .iter()
409 .filter(|head| !named.iter().any(|(_, name)| name == *head))
410 .copied()
411 .collect();
412
413 let elsewhere: Vec<Opcode> = ELSEWHERE.iter().map(|&(opcode, _)| opcode).collect();
414 let gaps: Vec<Opcode> = GAPS.iter().map(|&(opcode, ..)| opcode).collect();
415 let unaccounted: Vec<Opcode> = Opcode::all()
416 .filter(|opcode| {
417 !by_rule.contains(opcode) && !elsewhere.contains(opcode) && !gaps.contains(opcode)
418 })
419 .collect();
420
421 Report {
422 source: table.source,
423 opcodes: Opcode::all().count(),
424 by_rule,
425 names,
426 uncovered,
427 deferred,
428 unreachable,
429 elsewhere,
430 gaps,
431 unaccounted,
432 }
433}
434
435/// Every name a rule in a table is written about, which is the first test the trie makes.
436///
437/// Node zero is the root of the trie over the patterns and the first thing any walk asks is what
438/// the term in hand is called, so its tests are exactly the set of pattern heads. There is no
439/// wildcard there to worry about: a rule matching any term at all is one nobody has written and
440/// one that would be an error to write, since a lowering has to know what it is lowering.
441fn pattern_heads(table: &Table) -> Vec<&'static str> {
442 let Some(root) = table.nodes.first() else { return Vec::new() };
443 let mut found: Vec<&'static str> = root
444 .tests
445 .iter()
446 .filter_map(|(test, _)| match test {
447 Test::App { head, .. } => Some(*head),
448 // Neither can be at the root. A pattern is a term with a head, so the first step of
449 // every one of them is a head, and there is nothing bound yet to be the same as.
450 Test::Int(_) | Test::Same(_) => None,
451 })
452 .collect();
453 found.sort_unstable();
454 found.dedup();
455 found
456}
457
458/// The rules a target lowers by, or `None` where no back end in this crate covers it.
459///
460/// The same question [`crate::pipeline::Machine::for_target`] answers about the rest of a machine,
461/// and it is here as well because a caller that wants to write down what a run covered has a
462/// target and no machine. An architecture that gets a rule file at M6 gets an arm here at the same
463/// time, and until then it has no rules to report coverage of rather than an empty set of them.
464#[must_use]
465pub fn table(arch: Arch) -> Option<&'static Table> {
466 match arch {
467 Arch::X86_64 => Some(&crate::select::x86_64::TABLE),
468 Arch::Aarch64 | Arch::Riscv64 => None,
469 }
470}
471
472/// Which rules fired, over one function or over a whole compilation.
473///
474/// A bit per rule and nothing else. This is on the path of every instruction selected, so what it
475/// costs is paid by every compilation whether or not anybody asked for the number, and the cheapest
476/// thing that answers the question is a flag per rule set once.
477///
478/// The index of a rule is how this is kept and not how it is written down. An index moves the
479/// moment a rule is added above it, so [`Fired::listing`] names the rule file and the line instead:
480/// a line is a place somebody can open, and a report written by one build can still be read against
481/// a rule file that has grown since.
482#[derive(Debug, Clone, Default, PartialEq, Eq)]
483pub struct Fired {
484 /// One entry per rule, true once that rule has fired. It grows to fit the highest index
485 /// marked rather than being sized from a table, so nothing here has to be told which target
486 /// is being compiled for.
487 seen: Vec<bool>,
488}
489
490impl Fired {
491 /// Nothing has fired yet.
492 #[must_use]
493 pub const fn new() -> Fired {
494 Fired { seen: Vec::new() }
495 }
496
497 /// Records that the rule at this index fired.
498 pub fn mark(&mut self, rule: usize) {
499 if self.seen.len() <= rule {
500 self.seen.resize(rule + 1, false);
501 }
502 self.seen[rule] = true;
503 }
504
505 /// Whether the rule at this index fired.
506 #[must_use]
507 pub fn has(&self, rule: usize) -> bool {
508 self.seen.get(rule).copied().unwrap_or(false)
509 }
510
511 /// How many rules fired.
512 #[must_use]
513 pub fn count(&self) -> usize {
514 self.seen.iter().filter(|fired| **fired).count()
515 }
516
517 /// Takes in everything another one recorded.
518 ///
519 /// One compilation is many functions and one command line is many files, and the question is
520 /// about all of them together. Merging rather than writing a file per function is also what
521 /// keeps the answer the same however the work was scheduled.
522 pub fn merge(&mut self, other: &Fired) {
523 if self.seen.len() < other.seen.len() {
524 self.seen.resize(other.seen.len(), false);
525 }
526 for (mine, theirs) in self.seen.iter_mut().zip(&other.seen) {
527 *mine |= *theirs;
528 }
529 }
530
531 /// What `-Zrule-coverage=FILE` writes.
532 ///
533 /// One line per rule in the table, in the order the rule file writes them, each saying whether
534 /// the rule fired and naming the file and line it is written at. Every rule is listed rather
535 /// than only the ones that fired, so that one of these files says what the whole rule set was
536 /// as well as what this compilation reached: a reader unioning them over a corpus needs both
537 /// and would otherwise have to parse the rule file to get the second.
538 ///
539 /// The first line is a comment holding the count, which is the number a person wants and the
540 /// one thing here that is not worth making them add up.
541 #[must_use]
542 pub fn listing(&self, table: &Table) -> String {
543 let fired = table.rules.iter().enumerate().filter(|(index, _)| self.has(*index)).count();
544 let mut out = format!(
545 "# rucc rule coverage: {fired} of {} rules in {} fired\n",
546 table.rules.len(),
547 table.source
548 );
549 for (index, rule) in table.rules.iter().enumerate() {
550 let word = if self.has(index) { "fired" } else { "unused" };
551 let _ = writeln!(out, "{word} {}:{} {}", table.source, rule.line, rule.pattern);
552 }
553 out
554 }
555}
556
557#[cfg(test)]
558mod tests {
559 use super::*;
560 use crate::select::x86_64::TABLE;
561
562 /// The claim the whole module is for, in the direction that matters: a name an instruction
563 /// can be called by is a name a rule is written at. This is the width check as much as the
564 /// opcode check, since a name is an opcode and a width together.
565 #[test]
566 fn every_name_an_instruction_can_have_is_one_a_rule_is_written_at() {
567 let report = report(&TABLE);
568 assert!(
569 report.uncovered.is_empty(),
570 "nothing in {} lowers these, and each is an opcode at a width the rule language can \
571 spell: {:?}",
572 report.source,
573 report.uncovered
574 );
575 }
576
577 /// And the other direction, which costs nothing to ask and finds a rule that can never fire.
578 /// A pattern head no instruction is ever called by is a rule written against a name that was
579 /// renamed or misspelled, and it would sit there proved and unreachable.
580 #[test]
581 fn every_name_a_rule_is_written_at_is_one_an_instruction_can_have() {
582 let report = report(&TABLE);
583 assert!(
584 report.unreachable.is_empty(),
585 "{} has rules for these and no instruction is ever called one: {:?}",
586 report.source,
587 report.unreachable
588 );
589 }
590
591 /// Every opcode is one of the three things, so a new opcode in the IR fails this until
592 /// somebody says where it goes. That is the whole point: the answer for a new opcode should
593 /// be written down when it is added rather than discovered by a user compiling a program.
594 #[test]
595 fn every_opcode_is_lowered_or_is_a_gap_somebody_wrote_down() {
596 let report = report(&TABLE);
597 assert!(
598 report.unaccounted.is_empty(),
599 "no rule lowers these, `ELSEWHERE` does not say where they are lowered and `GAPS` \
600 does not say why they are not: {:?}",
601 report.unaccounted
602 );
603 assert_eq!(
604 report.by_rule.len() + report.elsewhere.len() + report.gaps.len(),
605 report.opcodes,
606 "the three lists overlap, so an opcode is counted twice"
607 );
608 }
609
610 /// An entry that starts being covered fails, which is the rule every list in this project is
611 /// kept under. An opcode a rule now lowers is one that should be off both lists, and a list
612 /// that keeps claiming otherwise is a list nobody can read.
613 #[test]
614 fn an_entry_a_rule_now_covers_is_a_stale_entry() {
615 let report = report(&TABLE);
616 for &(opcode, where_) in ELSEWHERE {
617 assert!(
618 !report.by_rule.contains(&opcode),
619 "`{}` is lowered by a rule now, so the `ELSEWHERE` entry saying it is lowered by \
620 {where_} is stale",
621 opcode.name()
622 );
623 }
624 for &(opcode, why, issue) in GAPS {
625 assert!(
626 !report.by_rule.contains(&opcode),
627 "`{}` is lowered by a rule now, so the `GAPS` entry saying it is {why} is stale \
628 and {issue} may be closed",
629 opcode.name()
630 );
631 assert!(
632 !report.elsewhere.contains(&opcode),
633 "`{}` is on both lists, so it is both lowered and not lowered",
634 opcode.name()
635 );
636 }
637 }
638
639 /// The same staleness rule one list down. A name a rule is written at is a name that is not
640 /// left for later, and an entry claiming otherwise is one that should have gone when the rule
641 /// arrived. The other direction is checked too: a name no instruction can ever have is a
642 /// misspelling, and it would sit here excusing nothing.
643 #[test]
644 fn a_name_a_rule_is_written_at_is_not_a_name_left_for_later() {
645 let heads = pattern_heads(&TABLE);
646 let named = term::heads();
647 for &(name, why, issue) in NAMES {
648 assert!(
649 !heads.contains(&name),
650 "`{name}` is lowered by a rule now, so the `NAMES` entry saying it is {why} is \
651 stale and {issue} may be closer than it says"
652 );
653 assert!(
654 named.iter().any(|&(_, head)| head == name),
655 "`{name}` is not a name any instruction can have, so the `NAMES` entry excuses \
656 nothing"
657 );
658 }
659 let report = report(&TABLE);
660 assert_eq!(report.deferred.len(), NAMES.len(), "{:?}", report.deferred);
661 }
662
663 /// Every gap names an issue, since a gap with no issue behind it is a gap nobody has decided
664 /// anything about, which is the thing this module exists to stop.
665 #[test]
666 fn every_gap_names_the_issue_that_closes_it() {
667 let issues = GAPS
668 .iter()
669 .map(|&(_, _, issue)| issue)
670 .chain(WIDTHS.iter().map(|&(_, _, issue)| issue))
671 .chain(NAMES.iter().map(|&(_, _, issue)| issue));
672 for issue in issues {
673 let number = issue
674 .strip_prefix("tamnd/rucc#")
675 .unwrap_or_else(|| panic!("{issue} is not an issue in this project's tracker"));
676 assert!(number.parse::<u32>().is_ok(), "{issue} does not name an issue number");
677 }
678 }
679
680 /// The count, which `spec/15-testing.md` section 15.8 says we keep about ourselves. CI runs
681 /// this test with the output shown, so the number lands in a log next to the rule proof
682 /// rather than in a file somebody has to go and read.
683 #[test]
684 fn the_count_is_reported() {
685 let report = report(&TABLE);
686 println!("{report}");
687 for &(opcode, why, issue) in GAPS {
688 println!("rucc-codegen: no lowering for `{}`, which is {why}: {issue}", opcode.name());
689 }
690 for &(width, why, issue) in WIDTHS {
691 println!("rucc-codegen: no rule at {width}, which is {why}: {issue}");
692 }
693 for &(name, why, issue) in NAMES {
694 println!("rucc-codegen: no rule at `{name}`, which is {why}: {issue}");
695 }
696 assert_eq!(report.gaps.len(), GAPS.len());
697 }
698
699 /// What the root of the trie is, which is the assumption [`pattern_heads`] rests on. If the
700 /// rule compiler ever built the trie some other way this would say so, rather than the
701 /// coverage numbers quietly becoming a report about an empty list.
702 #[test]
703 fn the_root_of_the_trie_is_the_head_of_every_pattern() {
704 let heads = pattern_heads(&TABLE);
705 assert!(!heads.is_empty(), "the table has rules and the root of the trie tests nothing");
706 for rule in TABLE.rules {
707 let head = rule
708 .pattern
709 .strip_prefix('(')
710 .and_then(|rest| rest.split([' ', ')']).next())
711 .expect("a pattern is an application");
712 assert!(
713 heads.contains(&head),
714 "line {}: {} is a pattern whose head the root of the trie does not test",
715 rule.line,
716 rule.pattern
717 );
718 }
719 }
720
721 /// The one target with a rule file, and the two that get one at M6. A machine that can be
722 /// compiled for has rules to report the coverage of, and one that cannot has none rather than
723 /// an empty set of them, which are different answers and would read the same as a number.
724 #[test]
725 fn a_target_with_a_back_end_is_a_target_with_a_rule_set() {
726 let x86 = table(Arch::X86_64).expect("x86-64 is what this crate lowers for");
727 assert_eq!(x86.source, TABLE.source);
728 assert!(!x86.rules.is_empty());
729 assert!(table(Arch::Aarch64).is_none(), "there is no aarch64 rule file yet");
730 assert!(table(Arch::Riscv64).is_none(), "there is no riscv64 rule file yet");
731 }
732
733 /// What a rule is called outside this process. The index is not it: a rule added at the top of
734 /// the file moves every index below it, and a report from last week would then be a report
735 /// about the wrong rules. The file and the line do not move that way and are somewhere to look.
736 #[test]
737 fn a_rule_is_written_down_as_the_place_it_is_written_at() {
738 let mut fired = Fired::new();
739 fired.mark(0);
740 let listing = fired.listing(&TABLE);
741 let first =
742 format!("fired {}:{} {}", TABLE.source, TABLE.rules[0].line, TABLE.rules[0].pattern);
743 assert!(listing.contains(&first), "{listing}");
744 assert!(listing.lines().next().is_some_and(|line| line.starts_with('#')), "{listing}");
745 }
746
747 /// Every rule is listed and not only the ones that fired, which is what lets one of these files
748 /// be read on its own. A reader that only got the rules that fired would have to parse the rule
749 /// file to find out what the rest of them were.
750 #[test]
751 fn one_file_says_what_the_whole_rule_set_is() {
752 let listing = Fired::new().listing(&TABLE);
753 let lines: Vec<&str> = listing.lines().collect();
754 assert_eq!(lines.len(), TABLE.rules.len() + 1, "one line per rule and one for the count");
755 assert_eq!(
756 lines.iter().filter(|line| line.starts_with("unused ")).count(),
757 TABLE.rules.len()
758 );
759 assert!(lines[0].contains(&format!("0 of {} rules", TABLE.rules.len())), "{}", lines[0]);
760 }
761
762 /// A compilation is many functions and a command line is many files, and the question is about
763 /// all of them at once. Merging is also what keeps the answer the same however the work was
764 /// scheduled, which is the rule `spec/03-architecture.md` section 3.7 holds everything to.
765 #[test]
766 fn what_two_runs_reached_is_what_either_of_them_reached() {
767 let mut one = Fired::new();
768 one.mark(3);
769 one.mark(3);
770 assert_eq!(one.count(), 1, "a rule that fires twice is one rule");
771 let mut two = Fired::new();
772 two.mark(0);
773 two.mark(9);
774 one.merge(&two);
775 assert_eq!(one.count(), 3);
776 assert!(one.has(0) && one.has(3) && one.has(9));
777 assert!(!one.has(1));
778
779 // The merge is symmetric, since neither order of two files is the right one.
780 let mut back = Fired::new();
781 back.mark(0);
782 back.mark(9);
783 let mut three = Fired::new();
784 three.mark(3);
785 back.merge(&three);
786 assert_eq!(back, one);
787 }
788}