Skip to main content

rucc_codegen/
coverage.rs

1//! Which IR opcodes have somewhere to go, and which do not.
2//!
3//! Design: `spec/10-backend.md` section 10.2, under **Coverage**.
4//!
5//! Every opcode has to be lowered by something or be a hole somebody wrote down. Without this the
6//! way a hole is found is that somebody compiles a program containing one and the selector reports
7//! that it cannot lower an instruction, which is a fine diagnostic and a bad discovery mechanism:
8//! it turns a gap in the rule set into a user's problem rather than a failing build.
9//!
10//! # The three answers
11//!
12//! An opcode is lowered by a rule, or somewhere a rule cannot reach, or nowhere.
13//!
14//! The first is the ordinary answer and the one this can check by itself. [`crate::term`] says
15//! every name a rule could be written at, the table says every name one is written at, and an
16//! opcode is covered when each of its names is in both. That is what makes this a check about
17//! widths rather than about opcodes: an `add` with a rule at four widths and no rule at the fifth
18//! is not covered, and would be reported here as the missing name rather than as a covered opcode.
19//!
20//! The second is [`ELSEWHERE`], which is not a gap. `spec/10-backend.md` names five of them and
21//! there are more now, and they are all the same kind of thing: an opcode whose lowering depends on
22//! something no pattern can see. Where a call's arguments go depends on the signature, where a
23//! local lives depends on the frame, an unconditional jump is an edge and edges live on the block,
24//! and a `memcpy` is a run of moves whose length is a constant the pattern would have to count. A
25//! rule matches one term and can say none of that.
26//!
27//! The third is [`GAPS`], which is the number `spec/15-testing.md` section 15.8 says we keep. Each
28//! entry names why it is there and the issue that closes it, so that an opcode nobody has written a
29//! rule for is a decision somebody wrote down rather than a surprise.
30//!
31//! [`WIDTHS`] and [`NAMES`] are the same third answer said about something smaller than an opcode.
32//! A width on [`WIDTHS`] has no names at all, so no opcode is missing a rule at it, and a name on
33//! [`NAMES`] is one width of an opcode that lowers at its other widths. Both carry the issue that
34//! closes them for the same reason [`GAPS`] does.
35//!
36//! # What makes the lists honest
37//!
38//! An entry that stops being true fails. An opcode on either list that a rule starts covering is a
39//! stale entry and the tests below say so by name, which is the same rule the exclusion lists in
40//! the compatibility harness are kept under: a list nothing checks is a list that only grows.
41//!
42//! The direction this cannot check is an opcode moving from [`GAPS`] to [`ELSEWHERE`] without the
43//! list following it, because where an opcode is lowered by name is a `match` arm and there is
44//! nothing to ask about a `match` arm from here. What that costs is one line of a list going out of
45//! date; what it does not cost is a gap going unnoticed, since the opcode is still on a list and
46//! still counted.
47//!
48//! # The other question
49//!
50//! All of the above is about the rule set as it is written. [`Fired`] is about the rule set as it
51//! is used: which rules a compilation actually reached. A rule nothing reaches is proved and dead
52//! weight, or it is a construct the corpus does not contain and somebody should know which. The
53//! selector marks a rule as it fires it, the driver writes the marks out under
54//! `-Zrule-coverage=FILE`, and the harness in `tamnd/rucc-compat` unions those files over a corpus,
55//! which is what turns coverage of the rule set into a number. `spec/20-execution-testing.md`
56//! section 20.9 is the design and `tamnd/rucc#261` is the work.
57
58use core::fmt;
59use core::fmt::Write as _;
60
61use rucc_ir::Opcode;
62use rucc_target::Arch;
63
64use crate::select::{Table, Test};
65use crate::term;
66
67/// An opcode no rule is written about, and the place that lowers it instead.
68///
69/// Not one of these is a gap. Each is an opcode whose lowering depends on something a pattern
70/// cannot see, so the answer lives where that something is known.
71pub static ELSEWHERE: &[(Opcode, &str)] = &[
72    // The convention. What a call's operands are is whatever the signature made them, and which
73    // register each one arrives in depends on the classification of every argument before it.
74    (Opcode::Call, "`crate::abi`, which builds a call out of the convention"),
75    (Opcode::CallIndirect, "`crate::abi`, the same instruction with the callee in a register"),
76    // The frame, which is not known until the allocator has finished running out of registers.
77    (Opcode::Alloca, "`crate::lower`, as an address into a frame `crate::frame` lays out later"),
78    // The stack pointer, which is not a value the program computed and so is not a value a rule
79    // could bind. A scope holding a variable length array reads it as it opens and writes it back
80    // as it closes, which is how the bytes are given back.
81    (Opcode::StackSave, "`crate::lower`, as a move out of the stack pointer"),
82    (Opcode::StackRestore, "`crate::lower`, the same move the other way round"),
83    // A relocation, which is right because of what the linker does rather than because of what
84    // any bitvector equals.
85    (Opcode::GlobalAddr, "`crate::lower`, a `lea` off the instruction pointer with a name on it"),
86    // No instruction at all. The IR keeps the width the same and the machine has one register
87    // file for both, so the value is already where it needs to be.
88    (Opcode::PtrToInt, "`crate::lower`, which renames the value rather than computing anything"),
89    (Opcode::IntToPtr, "`crate::lower`, the same rename the other way round"),
90    // Memory SSA, which is built at -O2, read by the passes that need it, and taken back off
91    // before selection. Nothing in the back end has ever seen a value of type `mem`.
92    (Opcode::MemEntry, "nothing at all, since memory SSA comes off before the back end runs"),
93    // The edges and the two ways of writing down that control does not arrive.
94    (Opcode::Jump, "`crate::layout`, since an edge is on the block and not in the block"),
95    (Opcode::Unreachable, "nothing at all, which is the answer for a place control does not reach"),
96    (Opcode::UnreachableHint, "nothing at all, for the same reason"),
97    // Rewritten into the opcodes above before selection ever sees them.
98    (Opcode::Switch, "`crate::switch`, into the tests its clusters need"),
99    (Opcode::FConst, "`crate::expand`, into a constant in memory and a load of it"),
100    (Opcode::FNeg, "`crate::expand`, into the sign bit flip it is"),
101    (Opcode::UIToFP, "`crate::expand`, into a signed conversion with a widening or a halving"),
102    (Opcode::FPToUI, "`crate::expand`, into a signed conversion with a narrowing or a correction"),
103    (Opcode::Memcpy, "`crate::expand`, into the moves it stands for"),
104    (Opcode::Memset, "`crate::expand`, into the fills it stands for"),
105    (Opcode::Memmove, "`crate::expand`, into a call, since the two regions may overlap"),
106    (Opcode::Bswap, "`crate::expand`, into the shifts and masks that reverse the bytes"),
107    // The ordered accesses, which this machine already makes ordered. `crate::expand` says what
108    // total store order gives for nothing and what the one ordering it does not give costs.
109    (Opcode::AtomicLoad, "`crate::expand`, into the plain load that is already an acquire"),
110    (Opcode::AtomicStore, "`crate::expand`, into the plain store, and a barrier at the strongest"),
111    // The barrier itself, which is one instruction or none and neither is a rewrite of anything.
112    // The template, which is a string and not a term. What an empty one stands for is no
113    // instructions and the places its operands share, and what a template with instructions in it
114    // stands for needs an assembler, which is `tamnd/rucc#349`.
115    (
116        Opcode::InlineAsm,
117        "`crate::lower`, as the places its operands share, while its template is empty",
118    ),
119    (
120        Opcode::Fence,
121        "`crate::lower`, as an `mfence` at the strongest ordering and nothing below it",
122    ),
123    // The compare and exchange, which is one instruction and produces two values, and a rule
124    // replaces a term with an instruction producing one.
125    (
126        Opcode::Cmpxchg,
127        "`crate::lower`, as a locked compare and exchange and the byte that reads its answer",
128    ),
129    // The read modify write, which produces one value a rule could have named and whose operation
130    // is carried beside it rather than in the head a rule matches on, so one pattern would be all
131    // thirteen of them.
132    (
133        Opcode::AtomicRmw,
134        "`crate::lower`, as an exchange or a locked add, and `crate::retry` for the eight with no \
135         instruction, with the two on floating values refused",
136    ),
137    (Opcode::Ctpop, "`crate::expand`, into the halving sum that counts the set bits"),
138    (Opcode::Ctlz, "`crate::expand`, into a smear and a set bit count"),
139    (Opcode::Cttz, "`crate::expand`, into a mask of the low zeroes and a set bit count"),
140    (Opcode::UAddOverflow, "`crate::expand`, into an add and a comparison against an operand"),
141    (Opcode::SAddOverflow, "`crate::expand`, into an add and the sign bit of the operands"),
142    (Opcode::USubOverflow, "`crate::expand`, into a subtract and a comparison of the operands"),
143    (Opcode::SSubOverflow, "`crate::expand`, into a subtract and the sign bit of the operands"),
144    (Opcode::UMulOverflow, "`crate::expand`, into a multiply and the high half of the product"),
145    (Opcode::SMulOverflow, "`crate::expand`, into the same, with the high half corrected for sign"),
146    // The variable argument list, which is four opcodes reading a structure the ABI describes.
147    (Opcode::VaStart, "`crate::varargs`, which writes the register save area the ABI describes"),
148    (Opcode::VaArg, "`crate::varargs`, into the walk over that structure"),
149    (Opcode::VaObject, "`crate::varargs`, the same walk for something that arrived in memory"),
150    (Opcode::VaCopy, "`crate::varargs`, into a copy of the structure"),
151    (Opcode::VaEnd, "`crate::varargs`, which removes it, since there is nothing to undo"),
152    // Memory safety. A check is a call to the runtime, and the rewrite happens after the optimizer
153    // has run so that the descriptor table only has rows for checks that survived it.
154    (Opcode::CheckBounds, "`rucc_safety::lower`, into a call carrying the row that describes it"),
155    (Opcode::CheckLive, "`rucc_safety::lower`, the same call over the lifetime plane"),
156    (Opcode::CheckDeriv, "`rucc_safety::lower`, the same call where the pointer is computed"),
157    (Opcode::CheckType, "`rucc_safety::lower`, the same call, carrying the type asked about"),
158    (
159        Opcode::CheckInit,
160        "`rucc_safety::lower`, the same call over the init plane, carrying no type",
161    ),
162    // The four plane writes the same pass emits, which become calls the same way. A judgement
163    // decides nothing, so none of the calls carries a descriptor row.
164    (Opcode::MetaType, "`rucc_safety::lower`, into the call that records what a store stored"),
165    (Opcode::MetaTypeCopy, "`rucc_safety::lower`, the same call over the range a copy read"),
166    (Opcode::MetaInit, "`rucc_safety::lower`, into the call that says a store wrote a range"),
167    (Opcode::MetaInitCopy, "`rucc_safety::lower`, the same call over the range a copy read"),
168    // The `restrict` contract, which is judgement J8 and is the one check that records as well as
169    // asks. What it records goes in a slot the block owns, and the two markers are what open and
170    // close that slot, so all four are calls to the runtime the same way.
171    (
172        Opcode::CheckRestrictRead,
173        "`rucc_safety::lower`, into the call that asks what the block has already reached",
174    ),
175    (Opcode::CheckRestrictWrite, "`rucc_safety::lower`, the same call, saying it wrote"),
176    (Opcode::RestrictEnter, "`rucc_safety::lower`, into the call that opens the block's record"),
177    (Opcode::RestrictLeave, "`rucc_safety::lower`, into the call that closes it again"),
178    (Opcode::CapExtent, "`rucc_safety::lower`, into a call that asks rather than one that judges"),
179    (Opcode::CapExtentBack, "`rucc_safety::lower`, the same call about the bytes below an address"),
180    // The capability the checks were reading, which the same pass takes out once they are calls,
181    // because a call to the runtime is handed an address and finds the rest for itself.
182    (Opcode::CapOf, "`rucc_safety::lower`, which removes it, since nothing reads it any more"),
183];
184
185/// An opcode nothing lowers, why it is here, and the issue that closes it.
186///
187/// This is the count `spec/15-testing.md` section 15.8 asks for. It is not zero yet and the
188/// spec says it should be, which is the honest reading of where the back end is: every one of
189/// these is a feature nobody has written, and all but three of them are opcodes the front end
190/// cannot produce either, so a program that reaches one of these is a program that reaches an
191/// unimplemented builtin first.
192pub static GAPS: &[(Opcode, &str, &str)] = &[
193    (Opcode::Splat, "a vector, and no rule is written about a lane count", "tamnd/rucc#200"),
194    (
195        Opcode::TargetIntrinsic,
196        "the same, since what needs one is a vector builtin",
197        "tamnd/rucc#200",
198    ),
199    (Opcode::BlockAddr, "the address of a label", "tamnd/rucc#353"),
200    (Opcode::IndirectBr, "the branch a computed goto turns into", "tamnd/rucc#353"),
201    (
202        Opcode::FRem,
203        "a call to `fmod`, so a link line question as much as a lowering one",
204        "tamnd/rucc#226",
205    ),
206    (
207        Opcode::Fma,
208        "a call or one instruction, depending on what the machine is told it has",
209        "tamnd/rucc#226",
210    ),
211    (Opcode::Bitreverse, "a node nothing writes and nothing lowers", "tamnd/rucc#363"),
212    (Opcode::Expect, "a branch weight nothing reads yet", "tamnd/rucc#364"),
213    (Opcode::Prefetch, "one instruction, once the hints have somewhere to go", "tamnd/rucc#313"),
214    (Opcode::FrameAddress, "a walk up the frame pointers", "tamnd/rucc#312"),
215    (Opcode::ReturnAddress, "the same walk, one word further along", "tamnd/rucc#312"),
216    (
217        Opcode::SetjmpMarker,
218        "a call that returns twice, which the allocator has to be told about",
219        "tamnd/rucc#223",
220    ),
221    (Opcode::LongjmpMarker, "the same", "tamnd/rucc#223"),
222    (Opcode::TailCall, "a terminator nothing writes and nothing lowers", "tamnd/rucc#365"),
223    // Memory safety. These are a gap in a different sense from the rest: nothing emits one yet
224    // either, since the passes that would are milestones S5 and after, so there is no program the
225    // back end can be handed that reaches one. The twelve the safety pass does emit are on
226    // `ELSEWHERE`.
227    (
228        Opcode::CapLoad,
229        "a capability, whose runtime shape `spec/safe-memory/05-representation.md` decides",
230        "tamnd/rucc#856",
231    ),
232    (Opcode::CapStore, "the same, and a store into the slot beside a pointer", "tamnd/rucc#856"),
233    (
234        Opcode::CapNull,
235        "the same, and it is whatever the representation says nothing is",
236        "tamnd/rucc#856",
237    ),
238    (Opcode::CapNarrow, "the same, and arithmetic on the bounds it holds", "tamnd/rucc#856"),
239    (Opcode::CapRecover, "the same, and a read of the shadow planes", "tamnd/rucc#856"),
240    (Opcode::CheckRace, "the same, over the epoch plane, which is S5's as well", "tamnd/rucc#431"),
241    // The plane writes, which the runtime does for itself today because the only ranges anything
242    // asks about are the ones its own allocator handed out. A stack object needs these.
243    (Opcode::MetaBegin, "a write over a range of the lifetime plane", "tamnd/rucc#856"),
244    (
245        Opcode::MetaEnd,
246        "the same write, with the version bumped past every capability",
247        "tamnd/rucc#856",
248    ),
249    (
250        Opcode::MetaTransfer,
251        "the same, and the state a range is in while a device owns it, which is S2's",
252        "tamnd/rucc#856",
253    ),
254    (
255        Opcode::SafeRegionBegin,
256        "nothing at all, once the count document 10 section 10.2 asks for has been taken",
257        "tamnd/rucc#856",
258    ),
259    (Opcode::SafeRegionEnd, "the same, which is to say nothing", "tamnd/rucc#856"),
260];
261
262/// A width no rule is written at, why, and the issue that closes it.
263///
264/// The other half of coverage, and the half an opcode list cannot say. An opcode is covered when
265/// every name it has is a name a rule is written at, and a width with no name has no names to
266/// check: an `add` of two `__int128`s is not a missing rule for `add`, it is a width the rule
267/// language cannot spell. So the widths are written down here for the same reason the opcodes are
268/// written down above.
269pub static WIDTHS: &[(&str, &str, &str)] = &[
270    (
271        "one bit",
272        "everything but and, or, xor, a constant, and the widening out of one",
273        "tamnd/rucc#352",
274    ),
275    (
276        "a hundred and twenty eight bits",
277        "split into two halves before selection, except a division",
278        "tamnd/rucc#351",
279    ),
280    (
281        "eighty bits",
282        "a long double is on the x87 stack and no rule is about that stack",
283        "tamnd/rucc#326",
284    ),
285    (
286        "a vector of any lane count",
287        "a rule at a width says nothing about how many lanes",
288        "tamnd/rucc#200",
289    ),
290];
291
292/// A name a rule could be written at and deliberately is not, why, and the issue that puts it
293/// back.
294///
295/// The third list, and the one that is about a name rather than about an opcode or a width. An
296/// opcode on [`GAPS`] has no lowering at any width and a width on [`WIDTHS`] has no names at all,
297/// and neither of those can say that `add` is lowered at four widths and left alone at two.
298///
299/// This list used to be all of the narrow arithmetic. C promotes the operands of an arithmetic
300/// operator to `int` before the operator is applied, so `char a, b; a + b` is an `int` addition of
301/// two sign extended chars and there is no C program that asks the back end to add two bytes.
302/// Rules were written at those names anyway, ahead of the pass that would reach them, and they sat
303/// proved and never selected: `tamnd/rucc#261` measured that and `tamnd/rucc#368` took them out.
304/// Most of them are back, because the width narrowing pass in `tamnd/rucc#375` is that caller and
305/// it writes a byte add out of the truncation the assignment back to a `char` already was.
306///
307/// What is left is what the pass will not narrow. A divide is not narrowed because the most
308/// negative byte over minus one is a defined hundred and twenty eight at four bytes and is the
309/// overflow that raises at one, so it wants a range analysis saying that pair cannot happen.
310///
311/// Not every narrow name was ever here, because promotion is not the only way a narrow operation
312/// is born. Reading a bitfield is a shift and a mask by constants at the width of the storage
313/// unit, writing one is a mask, a shift and an `or` of two values, and a truth test on a narrow
314/// scalar is an `icmp_ne` at that scalar's width. Those fire, so those always had rules.
315pub static NAMES: &[(&str, &str, &str)] = &[
316    ("sdiv.i8", "a narrow divide, which wants a range analysis before it can be narrowed", NARROW),
317    ("sdiv.i16", "the same", NARROW),
318    ("udiv.i8", "the same", NARROW),
319    ("udiv.i16", "the same", NARROW),
320    ("srem.i8", "the same", NARROW),
321    ("srem.i16", "the same", NARROW),
322    ("urem.i8", "the same", NARROW),
323    ("urem.i16", "the same", NARROW),
324];
325
326/// The issue every entry of [`NAMES`] waits on, since they all wait on the same one.
327const NARROW: &str = "tamnd/rucc#375";
328
329/// What a target's rules cover, and what they do not.
330#[derive(Debug)]
331pub struct Report {
332    /// The rule file this is about, so that anything said about it names a file to open.
333    pub source: &'static str,
334    /// How many opcodes the IR has.
335    pub opcodes: usize,
336    /// The opcodes every name of which a rule is written at.
337    pub by_rule: Vec<Opcode>,
338    /// How many names those are, which is one per opcode and width.
339    pub names: usize,
340    /// A name a rule could be written at and none is, which is what a missing rule looks like.
341    pub uncovered: Vec<(Opcode, &'static str)>,
342    /// A name on [`NAMES`], which is a missing rule somebody decided to be missing.
343    pub deferred: Vec<(Opcode, &'static str)>,
344    /// A name a rule is written at that nothing can ever be called, which is a dead rule.
345    pub unreachable: Vec<&'static str>,
346    /// The opcodes lowered somewhere a rule cannot reach.
347    pub elsewhere: Vec<Opcode>,
348    /// The opcodes nothing lowers.
349    pub gaps: Vec<Opcode>,
350    /// The opcodes on none of the three lists, which is what a new opcode is until somebody says
351    /// where it goes.
352    pub unaccounted: Vec<Opcode>,
353}
354
355impl fmt::Display for Report {
356    fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
357        write!(
358            f,
359            "rucc-codegen: {} lowers {} of the {} IR opcodes by rule at {} names, {} are lowered \
360             where no rule reaches, {} have no lowering yet and {} names are left for later",
361            self.source,
362            self.by_rule.len(),
363            self.opcodes,
364            self.names,
365            self.elsewhere.len(),
366            self.gaps.len(),
367            self.deferred.len()
368        )
369    }
370}
371
372/// What a table covers.
373///
374/// Nothing is executed and nothing is compiled. The rule set and the naming of instructions are
375/// both data, and the answer is a comparison of two lists.
376#[must_use]
377pub fn report(table: &Table) -> Report {
378    let named = term::heads();
379    let patterns = pattern_heads(table);
380
381    let mut by_rule = Vec::new();
382    let mut uncovered = Vec::new();
383    let mut deferred = Vec::new();
384    for &(opcode, name) in &named {
385        if patterns.contains(&name) {
386            by_rule.push(opcode);
387        } else if NAMES.iter().any(|&(deliberate, ..)| deliberate == name) {
388            deferred.push((opcode, name));
389        } else {
390            uncovered.push((opcode, name));
391        }
392    }
393    // An opcode is covered when every name it has is covered, so one missing width takes the
394    // whole opcode off the list however many of its other widths are there. A name on `NAMES` does
395    // not take it off, because the opcode is lowered and the entry says which widths were left for
396    // later and why: that is a narrower claim than the opcode having nowhere to go, and putting it
397    // on `GAPS` instead would say the wrong thing about an `add` that lowers perfectly well at
398    // four widths.
399    for &(opcode, _) in &uncovered {
400        by_rule.retain(|&covered| covered != opcode);
401    }
402    by_rule.sort_unstable();
403    by_rule.dedup();
404
405    let names = named.len() - uncovered.len() - deferred.len();
406    let unreachable: Vec<&'static str> = patterns
407        .iter()
408        .filter(|head| !named.iter().any(|(_, name)| name == *head))
409        .copied()
410        .collect();
411
412    let elsewhere: Vec<Opcode> = ELSEWHERE.iter().map(|&(opcode, _)| opcode).collect();
413    let gaps: Vec<Opcode> = GAPS.iter().map(|&(opcode, ..)| opcode).collect();
414    let unaccounted: Vec<Opcode> = Opcode::all()
415        .filter(|opcode| {
416            !by_rule.contains(opcode) && !elsewhere.contains(opcode) && !gaps.contains(opcode)
417        })
418        .collect();
419
420    Report {
421        source: table.source,
422        opcodes: Opcode::all().count(),
423        by_rule,
424        names,
425        uncovered,
426        deferred,
427        unreachable,
428        elsewhere,
429        gaps,
430        unaccounted,
431    }
432}
433
434/// Every name a rule in a table is written about, which is the first test the trie makes.
435///
436/// Node zero is the root of the trie over the patterns and the first thing any walk asks is what
437/// the term in hand is called, so its tests are exactly the set of pattern heads. There is no
438/// wildcard there to worry about: a rule matching any term at all is one nobody has written and
439/// one that would be an error to write, since a lowering has to know what it is lowering.
440fn pattern_heads(table: &Table) -> Vec<&'static str> {
441    let Some(root) = table.nodes.first() else { return Vec::new() };
442    let mut found: Vec<&'static str> = root
443        .tests
444        .iter()
445        .filter_map(|(test, _)| match test {
446            Test::App { head, .. } => Some(*head),
447            // Neither can be at the root. A pattern is a term with a head, so the first step of
448            // every one of them is a head, and there is nothing bound yet to be the same as.
449            Test::Int(_) | Test::Same(_) => None,
450        })
451        .collect();
452    found.sort_unstable();
453    found.dedup();
454    found
455}
456
457/// The rules a target lowers by, or `None` where no back end in this crate covers it.
458///
459/// The same question [`crate::pipeline::Machine::for_target`] answers about the rest of a machine,
460/// and it is here as well because a caller that wants to write down what a run covered has a
461/// target and no machine. An architecture that gets a rule file at M6 gets an arm here at the same
462/// time, and until then it has no rules to report coverage of rather than an empty set of them.
463#[must_use]
464pub fn table(arch: Arch) -> Option<&'static Table> {
465    match arch {
466        Arch::X86_64 => Some(&crate::select::x86_64::TABLE),
467        Arch::Aarch64 | Arch::Riscv64 => None,
468    }
469}
470
471/// Which rules fired, over one function or over a whole compilation.
472///
473/// A bit per rule and nothing else. This is on the path of every instruction selected, so what it
474/// costs is paid by every compilation whether or not anybody asked for the number, and the cheapest
475/// thing that answers the question is a flag per rule set once.
476///
477/// The index of a rule is how this is kept and not how it is written down. An index moves the
478/// moment a rule is added above it, so [`Fired::listing`] names the rule file and the line instead:
479/// a line is a place somebody can open, and a report written by one build can still be read against
480/// a rule file that has grown since.
481#[derive(Debug, Clone, Default, PartialEq, Eq)]
482pub struct Fired {
483    /// One entry per rule, true once that rule has fired. It grows to fit the highest index
484    /// marked rather than being sized from a table, so nothing here has to be told which target
485    /// is being compiled for.
486    seen: Vec<bool>,
487}
488
489impl Fired {
490    /// Nothing has fired yet.
491    #[must_use]
492    pub const fn new() -> Fired {
493        Fired { seen: Vec::new() }
494    }
495
496    /// Records that the rule at this index fired.
497    pub fn mark(&mut self, rule: usize) {
498        if self.seen.len() <= rule {
499            self.seen.resize(rule + 1, false);
500        }
501        self.seen[rule] = true;
502    }
503
504    /// Whether the rule at this index fired.
505    #[must_use]
506    pub fn has(&self, rule: usize) -> bool {
507        self.seen.get(rule).copied().unwrap_or(false)
508    }
509
510    /// How many rules fired.
511    #[must_use]
512    pub fn count(&self) -> usize {
513        self.seen.iter().filter(|fired| **fired).count()
514    }
515
516    /// Takes in everything another one recorded.
517    ///
518    /// One compilation is many functions and one command line is many files, and the question is
519    /// about all of them together. Merging rather than writing a file per function is also what
520    /// keeps the answer the same however the work was scheduled.
521    pub fn merge(&mut self, other: &Fired) {
522        if self.seen.len() < other.seen.len() {
523            self.seen.resize(other.seen.len(), false);
524        }
525        for (mine, theirs) in self.seen.iter_mut().zip(&other.seen) {
526            *mine |= *theirs;
527        }
528    }
529
530    /// What `-Zrule-coverage=FILE` writes.
531    ///
532    /// One line per rule in the table, in the order the rule file writes them, each saying whether
533    /// the rule fired and naming the file and line it is written at. Every rule is listed rather
534    /// than only the ones that fired, so that one of these files says what the whole rule set was
535    /// as well as what this compilation reached: a reader unioning them over a corpus needs both
536    /// and would otherwise have to parse the rule file to get the second.
537    ///
538    /// The first line is a comment holding the count, which is the number a person wants and the
539    /// one thing here that is not worth making them add up.
540    #[must_use]
541    pub fn listing(&self, table: &Table) -> String {
542        let fired = table.rules.iter().enumerate().filter(|(index, _)| self.has(*index)).count();
543        let mut out = format!(
544            "# rucc rule coverage: {fired} of {} rules in {} fired\n",
545            table.rules.len(),
546            table.source
547        );
548        for (index, rule) in table.rules.iter().enumerate() {
549            let word = if self.has(index) { "fired" } else { "unused" };
550            let _ = writeln!(out, "{word} {}:{} {}", table.source, rule.line, rule.pattern);
551        }
552        out
553    }
554}
555
556#[cfg(test)]
557mod tests {
558    use super::*;
559    use crate::select::x86_64::TABLE;
560
561    /// The claim the whole module is for, in the direction that matters: a name an instruction
562    /// can be called by is a name a rule is written at. This is the width check as much as the
563    /// opcode check, since a name is an opcode and a width together.
564    #[test]
565    fn every_name_an_instruction_can_have_is_one_a_rule_is_written_at() {
566        let report = report(&TABLE);
567        assert!(
568            report.uncovered.is_empty(),
569            "nothing in {} lowers these, and each is an opcode at a width the rule language can \
570             spell: {:?}",
571            report.source,
572            report.uncovered
573        );
574    }
575
576    /// And the other direction, which costs nothing to ask and finds a rule that can never fire.
577    /// A pattern head no instruction is ever called by is a rule written against a name that was
578    /// renamed or misspelled, and it would sit there proved and unreachable.
579    #[test]
580    fn every_name_a_rule_is_written_at_is_one_an_instruction_can_have() {
581        let report = report(&TABLE);
582        assert!(
583            report.unreachable.is_empty(),
584            "{} has rules for these and no instruction is ever called one: {:?}",
585            report.source,
586            report.unreachable
587        );
588    }
589
590    /// Every opcode is one of the three things, so a new opcode in the IR fails this until
591    /// somebody says where it goes. That is the whole point: the answer for a new opcode should
592    /// be written down when it is added rather than discovered by a user compiling a program.
593    #[test]
594    fn every_opcode_is_lowered_or_is_a_gap_somebody_wrote_down() {
595        let report = report(&TABLE);
596        assert!(
597            report.unaccounted.is_empty(),
598            "no rule lowers these, `ELSEWHERE` does not say where they are lowered and `GAPS` \
599             does not say why they are not: {:?}",
600            report.unaccounted
601        );
602        assert_eq!(
603            report.by_rule.len() + report.elsewhere.len() + report.gaps.len(),
604            report.opcodes,
605            "the three lists overlap, so an opcode is counted twice"
606        );
607    }
608
609    /// An entry that starts being covered fails, which is the rule every list in this project is
610    /// kept under. An opcode a rule now lowers is one that should be off both lists, and a list
611    /// that keeps claiming otherwise is a list nobody can read.
612    #[test]
613    fn an_entry_a_rule_now_covers_is_a_stale_entry() {
614        let report = report(&TABLE);
615        for &(opcode, where_) in ELSEWHERE {
616            assert!(
617                !report.by_rule.contains(&opcode),
618                "`{}` is lowered by a rule now, so the `ELSEWHERE` entry saying it is lowered by \
619                 {where_} is stale",
620                opcode.name()
621            );
622        }
623        for &(opcode, why, issue) in GAPS {
624            assert!(
625                !report.by_rule.contains(&opcode),
626                "`{}` is lowered by a rule now, so the `GAPS` entry saying it is {why} is stale \
627                 and {issue} may be closed",
628                opcode.name()
629            );
630            assert!(
631                !report.elsewhere.contains(&opcode),
632                "`{}` is on both lists, so it is both lowered and not lowered",
633                opcode.name()
634            );
635        }
636    }
637
638    /// The same staleness rule one list down. A name a rule is written at is a name that is not
639    /// left for later, and an entry claiming otherwise is one that should have gone when the rule
640    /// arrived. The other direction is checked too: a name no instruction can ever have is a
641    /// misspelling, and it would sit here excusing nothing.
642    #[test]
643    fn a_name_a_rule_is_written_at_is_not_a_name_left_for_later() {
644        let heads = pattern_heads(&TABLE);
645        let named = term::heads();
646        for &(name, why, issue) in NAMES {
647            assert!(
648                !heads.contains(&name),
649                "`{name}` is lowered by a rule now, so the `NAMES` entry saying it is {why} is \
650                 stale and {issue} may be closer than it says"
651            );
652            assert!(
653                named.iter().any(|&(_, head)| head == name),
654                "`{name}` is not a name any instruction can have, so the `NAMES` entry excuses \
655                 nothing"
656            );
657        }
658        let report = report(&TABLE);
659        assert_eq!(report.deferred.len(), NAMES.len(), "{:?}", report.deferred);
660    }
661
662    /// Every gap names an issue, since a gap with no issue behind it is a gap nobody has decided
663    /// anything about, which is the thing this module exists to stop.
664    #[test]
665    fn every_gap_names_the_issue_that_closes_it() {
666        let issues = GAPS
667            .iter()
668            .map(|&(_, _, issue)| issue)
669            .chain(WIDTHS.iter().map(|&(_, _, issue)| issue))
670            .chain(NAMES.iter().map(|&(_, _, issue)| issue));
671        for issue in issues {
672            let number = issue
673                .strip_prefix("tamnd/rucc#")
674                .unwrap_or_else(|| panic!("{issue} is not an issue in this project's tracker"));
675            assert!(number.parse::<u32>().is_ok(), "{issue} does not name an issue number");
676        }
677    }
678
679    /// The count, which `spec/15-testing.md` section 15.8 says we keep about ourselves. CI runs
680    /// this test with the output shown, so the number lands in a log next to the rule proof
681    /// rather than in a file somebody has to go and read.
682    #[test]
683    fn the_count_is_reported() {
684        let report = report(&TABLE);
685        println!("{report}");
686        for &(opcode, why, issue) in GAPS {
687            println!("rucc-codegen: no lowering for `{}`, which is {why}: {issue}", opcode.name());
688        }
689        for &(width, why, issue) in WIDTHS {
690            println!("rucc-codegen: no rule at {width}, which is {why}: {issue}");
691        }
692        for &(name, why, issue) in NAMES {
693            println!("rucc-codegen: no rule at `{name}`, which is {why}: {issue}");
694        }
695        assert_eq!(report.gaps.len(), GAPS.len());
696    }
697
698    /// What the root of the trie is, which is the assumption [`pattern_heads`] rests on. If the
699    /// rule compiler ever built the trie some other way this would say so, rather than the
700    /// coverage numbers quietly becoming a report about an empty list.
701    #[test]
702    fn the_root_of_the_trie_is_the_head_of_every_pattern() {
703        let heads = pattern_heads(&TABLE);
704        assert!(!heads.is_empty(), "the table has rules and the root of the trie tests nothing");
705        for rule in TABLE.rules {
706            let head = rule
707                .pattern
708                .strip_prefix('(')
709                .and_then(|rest| rest.split([' ', ')']).next())
710                .expect("a pattern is an application");
711            assert!(
712                heads.contains(&head),
713                "line {}: {} is a pattern whose head the root of the trie does not test",
714                rule.line,
715                rule.pattern
716            );
717        }
718    }
719
720    /// The one target with a rule file, and the two that get one at M6. A machine that can be
721    /// compiled for has rules to report the coverage of, and one that cannot has none rather than
722    /// an empty set of them, which are different answers and would read the same as a number.
723    #[test]
724    fn a_target_with_a_back_end_is_a_target_with_a_rule_set() {
725        let x86 = table(Arch::X86_64).expect("x86-64 is what this crate lowers for");
726        assert_eq!(x86.source, TABLE.source);
727        assert!(!x86.rules.is_empty());
728        assert!(table(Arch::Aarch64).is_none(), "there is no aarch64 rule file yet");
729        assert!(table(Arch::Riscv64).is_none(), "there is no riscv64 rule file yet");
730    }
731
732    /// What a rule is called outside this process. The index is not it: a rule added at the top of
733    /// the file moves every index below it, and a report from last week would then be a report
734    /// about the wrong rules. The file and the line do not move that way and are somewhere to look.
735    #[test]
736    fn a_rule_is_written_down_as_the_place_it_is_written_at() {
737        let mut fired = Fired::new();
738        fired.mark(0);
739        let listing = fired.listing(&TABLE);
740        let first =
741            format!("fired {}:{} {}", TABLE.source, TABLE.rules[0].line, TABLE.rules[0].pattern);
742        assert!(listing.contains(&first), "{listing}");
743        assert!(listing.lines().next().is_some_and(|line| line.starts_with('#')), "{listing}");
744    }
745
746    /// Every rule is listed and not only the ones that fired, which is what lets one of these files
747    /// be read on its own. A reader that only got the rules that fired would have to parse the rule
748    /// file to find out what the rest of them were.
749    #[test]
750    fn one_file_says_what_the_whole_rule_set_is() {
751        let listing = Fired::new().listing(&TABLE);
752        let lines: Vec<&str> = listing.lines().collect();
753        assert_eq!(lines.len(), TABLE.rules.len() + 1, "one line per rule and one for the count");
754        assert_eq!(
755            lines.iter().filter(|line| line.starts_with("unused ")).count(),
756            TABLE.rules.len()
757        );
758        assert!(lines[0].contains(&format!("0 of {} rules", TABLE.rules.len())), "{}", lines[0]);
759    }
760
761    /// A compilation is many functions and a command line is many files, and the question is about
762    /// all of them at once. Merging is also what keeps the answer the same however the work was
763    /// scheduled, which is the rule `spec/03-architecture.md` section 3.7 holds everything to.
764    #[test]
765    fn what_two_runs_reached_is_what_either_of_them_reached() {
766        let mut one = Fired::new();
767        one.mark(3);
768        one.mark(3);
769        assert_eq!(one.count(), 1, "a rule that fires twice is one rule");
770        let mut two = Fired::new();
771        two.mark(0);
772        two.mark(9);
773        one.merge(&two);
774        assert_eq!(one.count(), 3);
775        assert!(one.has(0) && one.has(3) && one.has(9));
776        assert!(!one.has(1));
777
778        // The merge is symmetric, since neither order of two files is the right one.
779        let mut back = Fired::new();
780        back.mark(0);
781        back.mark(9);
782        let mut three = Fired::new();
783        three.mark(3);
784        back.merge(&three);
785        assert_eq!(back, one);
786    }
787}