rucc_codegen/coverage.rs
1//! Which IR opcodes have somewhere to go, and which do not.
2//!
3//! Design: `spec/10-backend.md` section 10.2, under **Coverage**.
4//!
5//! Every opcode has to be lowered by something or be a hole somebody wrote down. Without this the
6//! way a hole is found is that somebody compiles a program containing one and the selector reports
7//! that it cannot lower an instruction, which is a fine diagnostic and a bad discovery mechanism:
8//! it turns a gap in the rule set into a user's problem rather than a failing build.
9//!
10//! # The three answers
11//!
12//! An opcode is lowered by a rule, or somewhere a rule cannot reach, or nowhere.
13//!
14//! The first is the ordinary answer and the one this can check by itself. [`crate::term`] says
15//! every name a rule could be written at, the table says every name one is written at, and an
16//! opcode is covered when each of its names is in both. That is what makes this a check about
17//! widths rather than about opcodes: an `add` with a rule at four widths and no rule at the fifth
18//! is not covered, and would be reported here as the missing name rather than as a covered opcode.
19//!
20//! The second is [`ELSEWHERE`], which is not a gap. `spec/10-backend.md` names five of them and
21//! there are more now, and they are all the same kind of thing: an opcode whose lowering depends on
22//! something no pattern can see. Where a call's arguments go depends on the signature, where a
23//! local lives depends on the frame, an unconditional jump is an edge and edges live on the block,
24//! and a `memcpy` is a run of moves whose length is a constant the pattern would have to count. A
25//! rule matches one term and can say none of that.
26//!
27//! The third is [`GAPS`], which is the number `spec/15-testing.md` section 15.8 says we keep. Each
28//! entry names why it is there and the issue that closes it, so that an opcode nobody has written a
29//! rule for is a decision somebody wrote down rather than a surprise.
30//!
31//! [`WIDTHS`] and [`NAMES`] are the same third answer said about something smaller than an opcode.
32//! A width on [`WIDTHS`] has no names at all, so no opcode is missing a rule at it, and a name on
33//! [`NAMES`] is one width of an opcode that lowers at its other widths. Both carry the issue that
34//! closes them for the same reason [`GAPS`] does.
35//!
36//! # What makes the lists honest
37//!
38//! An entry that stops being true fails. An opcode on either list that a rule starts covering is a
39//! stale entry and the tests below say so by name, which is the same rule the exclusion lists in
40//! the compatibility harness are kept under: a list nothing checks is a list that only grows.
41//!
42//! The direction this cannot check is an opcode moving from [`GAPS`] to [`ELSEWHERE`] without the
43//! list following it, because where an opcode is lowered by name is a `match` arm and there is
44//! nothing to ask about a `match` arm from here. What that costs is one line of a list going out of
45//! date; what it does not cost is a gap going unnoticed, since the opcode is still on a list and
46//! still counted.
47//!
48//! # The other question
49//!
50//! All of the above is about the rule set as it is written. [`Fired`] is about the rule set as it
51//! is used: which rules a compilation actually reached. A rule nothing reaches is proved and dead
52//! weight, or it is a construct the corpus does not contain and somebody should know which. The
53//! selector marks a rule as it fires it, the driver writes the marks out under
54//! `-Zrule-coverage=FILE`, and the harness in `tamnd/rucc-compat` unions those files over a corpus,
55//! which is what turns coverage of the rule set into a number. `spec/20-execution-testing.md`
56//! section 20.9 is the design and `tamnd/rucc#261` is the work.
57
58use core::fmt;
59use core::fmt::Write as _;
60
61use rucc_ir::Opcode;
62use rucc_target::Arch;
63
64use crate::select::{Table, Test};
65use crate::term;
66
67/// An opcode no rule is written about, and the place that lowers it instead.
68///
69/// Not one of these is a gap. Each is an opcode whose lowering depends on something a pattern
70/// cannot see, so the answer lives where that something is known.
71pub static ELSEWHERE: &[(Opcode, &str)] = &[
72 // The convention. What a call's operands are is whatever the signature made them, and which
73 // register each one arrives in depends on the classification of every argument before it.
74 (Opcode::Call, "`crate::abi`, which builds a call out of the convention"),
75 (Opcode::CallIndirect, "`crate::abi`, the same instruction with the callee in a register"),
76 // The frame, which is not known until the allocator has finished running out of registers.
77 (Opcode::Alloca, "`crate::lower`, as an address into a frame `crate::frame` lays out later"),
78 // A relocation, which is right because of what the linker does rather than because of what
79 // any bitvector equals.
80 (Opcode::GlobalAddr, "`crate::lower`, a `lea` off the instruction pointer with a name on it"),
81 // No instruction at all. The IR keeps the width the same and the machine has one register
82 // file for both, so the value is already where it needs to be.
83 (Opcode::PtrToInt, "`crate::lower`, which renames the value rather than computing anything"),
84 (Opcode::IntToPtr, "`crate::lower`, the same rename the other way round"),
85 // Memory SSA, which is built at -O2, read by the passes that need it, and taken back off
86 // before selection. Nothing in the back end has ever seen a value of type `mem`.
87 (Opcode::MemEntry, "nothing at all, since memory SSA comes off before the back end runs"),
88 // The edges and the two ways of writing down that control does not arrive.
89 (Opcode::Jump, "`crate::layout`, since an edge is on the block and not in the block"),
90 (Opcode::Unreachable, "nothing at all, which is the answer for a place control does not reach"),
91 (Opcode::UnreachableHint, "nothing at all, for the same reason"),
92 // Rewritten into the opcodes above before selection ever sees them.
93 (Opcode::Switch, "`crate::switch`, into the tests its clusters need"),
94 (Opcode::FConst, "`crate::expand`, into a constant in memory and a load of it"),
95 (Opcode::FNeg, "`crate::expand`, into the sign bit flip it is"),
96 (Opcode::UIToFP, "`crate::expand`, into a signed conversion with a widening or a halving"),
97 (Opcode::FPToUI, "`crate::expand`, into a signed conversion with a narrowing or a correction"),
98 (Opcode::Memcpy, "`crate::expand`, into the moves it stands for"),
99 (Opcode::Memset, "`crate::expand`, into the fills it stands for"),
100 (Opcode::Memmove, "`crate::expand`, into a call, since the two regions may overlap"),
101 (Opcode::Bswap, "`crate::expand`, into the shifts and masks that reverse the bytes"),
102 // The ordered accesses, which this machine already makes ordered. `crate::expand` says what
103 // total store order gives for nothing and what the one ordering it does not give costs.
104 (Opcode::AtomicLoad, "`crate::expand`, into the plain load that is already an acquire"),
105 (Opcode::AtomicStore, "`crate::expand`, into the plain store, and a barrier at the strongest"),
106 // The barrier itself, which is one instruction or none and neither is a rewrite of anything.
107 // The template, which is a string and not a term. What an empty one stands for is no
108 // instructions and the places its operands share, and what a template with instructions in it
109 // stands for needs an assembler, which is `tamnd/rucc#349`.
110 (
111 Opcode::InlineAsm,
112 "`crate::lower`, as the places its operands share, while its template is empty",
113 ),
114 (
115 Opcode::Fence,
116 "`crate::lower`, as an `mfence` at the strongest ordering and nothing below it",
117 ),
118 // The compare and exchange, which is one instruction and produces two values, and a rule
119 // replaces a term with an instruction producing one.
120 (
121 Opcode::Cmpxchg,
122 "`crate::lower`, as a locked compare and exchange and the byte that reads its answer",
123 ),
124 // The read modify write, which produces one value a rule could have named and whose operation
125 // is carried beside it rather than in the head a rule matches on, so one pattern would be all
126 // thirteen of them.
127 (
128 Opcode::AtomicRmw,
129 "`crate::lower`, as an exchange or a locked add, and `crate::retry` for the eight with no \
130 instruction, with the two on floating values refused",
131 ),
132 (Opcode::Ctpop, "`crate::expand`, into the halving sum that counts the set bits"),
133 (Opcode::Ctlz, "`crate::expand`, into a smear and a set bit count"),
134 (Opcode::Cttz, "`crate::expand`, into a mask of the low zeroes and a set bit count"),
135 (Opcode::UAddOverflow, "`crate::expand`, into an add and a comparison against an operand"),
136 (Opcode::SAddOverflow, "`crate::expand`, into an add and the sign bit of the operands"),
137 (Opcode::USubOverflow, "`crate::expand`, into a subtract and a comparison of the operands"),
138 (Opcode::SSubOverflow, "`crate::expand`, into a subtract and the sign bit of the operands"),
139 (Opcode::UMulOverflow, "`crate::expand`, into a multiply and the high half of the product"),
140 (Opcode::SMulOverflow, "`crate::expand`, into the same, with the high half corrected for sign"),
141 // The variable argument list, which is four opcodes reading a structure the ABI describes.
142 (Opcode::VaStart, "`crate::varargs`, which writes the register save area the ABI describes"),
143 (Opcode::VaArg, "`crate::varargs`, into the walk over that structure"),
144 (Opcode::VaObject, "`crate::varargs`, the same walk for something that arrived in memory"),
145 (Opcode::VaCopy, "`crate::varargs`, into a copy of the structure"),
146 (Opcode::VaEnd, "`crate::varargs`, which removes it, since there is nothing to undo"),
147 // Memory safety. A check is a call to the runtime, and the rewrite happens after the optimizer
148 // has run so that the descriptor table only has rows for checks that survived it.
149 (Opcode::CheckBounds, "`rucc_safety::lower`, into a call carrying the row that describes it"),
150 (Opcode::CheckLive, "`rucc_safety::lower`, the same call over the lifetime plane"),
151 (Opcode::CheckDeriv, "`rucc_safety::lower`, the same call where the pointer is computed"),
152 (Opcode::CapExtent, "`rucc_safety::lower`, into a call that asks rather than one that judges"),
153 // The capability the checks were reading, which the same pass takes out once they are calls,
154 // because a call to the runtime is handed an address and finds the rest for itself.
155 (Opcode::CapOf, "`rucc_safety::lower`, which removes it, since nothing reads it any more"),
156];
157
158/// An opcode nothing lowers, why it is here, and the issue that closes it.
159///
160/// This is the count `spec/15-testing.md` section 15.8 asks for. It is not zero yet and the
161/// spec says it should be, which is the honest reading of where the back end is: every one of
162/// these is a feature nobody has written, and all but three of them are opcodes the front end
163/// cannot produce either, so a program that reaches one of these is a program that reaches an
164/// unimplemented builtin first.
165pub static GAPS: &[(Opcode, &str, &str)] = &[
166 (Opcode::Splat, "a vector, and no rule is written about a lane count", "tamnd/rucc#200"),
167 (
168 Opcode::TargetIntrinsic,
169 "the same, since what needs one is a vector builtin",
170 "tamnd/rucc#200",
171 ),
172 (Opcode::BlockAddr, "the address of a label", "tamnd/rucc#353"),
173 (Opcode::IndirectBr, "the branch a computed goto turns into", "tamnd/rucc#353"),
174 (
175 Opcode::FRem,
176 "a call to `fmod`, so a link line question as much as a lowering one",
177 "tamnd/rucc#226",
178 ),
179 (
180 Opcode::Fma,
181 "a call or one instruction, depending on what the machine is told it has",
182 "tamnd/rucc#226",
183 ),
184 (Opcode::Bitreverse, "a node nothing writes and nothing lowers", "tamnd/rucc#363"),
185 (Opcode::Expect, "a branch weight nothing reads yet", "tamnd/rucc#364"),
186 (Opcode::Prefetch, "one instruction, once the hints have somewhere to go", "tamnd/rucc#313"),
187 (Opcode::FrameAddress, "a walk up the frame pointers", "tamnd/rucc#312"),
188 (Opcode::ReturnAddress, "the same walk, one word further along", "tamnd/rucc#312"),
189 (
190 Opcode::StackSave,
191 "a frame that can grow, as a variable length array needs",
192 "tamnd/rucc#291",
193 ),
194 (Opcode::StackRestore, "the same", "tamnd/rucc#291"),
195 (
196 Opcode::SetjmpMarker,
197 "a call that returns twice, which the allocator has to be told about",
198 "tamnd/rucc#223",
199 ),
200 (Opcode::LongjmpMarker, "the same", "tamnd/rucc#223"),
201 (Opcode::TailCall, "a terminator nothing writes and nothing lowers", "tamnd/rucc#365"),
202 // Memory safety. These are a gap in a different sense from the rest: nothing emits one yet
203 // either, since the passes that would are milestones S2 and after, so there is no program the
204 // back end can be handed that reaches one. The four the S1 pass does emit are on `ELSEWHERE`.
205 (
206 Opcode::CapLoad,
207 "a capability, whose runtime shape `spec/safe-memory/05-representation.md` decides",
208 "tamnd/rucc#428",
209 ),
210 (Opcode::CapStore, "the same, and a store into the slot beside a pointer", "tamnd/rucc#428"),
211 (
212 Opcode::CapNull,
213 "the same, and it is whatever the representation says nothing is",
214 "tamnd/rucc#428",
215 ),
216 (Opcode::CapNarrow, "the same, and arithmetic on the bounds it holds", "tamnd/rucc#428"),
217 (Opcode::CapRecover, "the same, and a read of the shadow planes", "tamnd/rucc#428"),
218 (Opcode::CheckType, "a read of the type plane, which is S5's", "tamnd/rucc#431"),
219 (Opcode::CheckInit, "the same, over the init plane, which is S5's too", "tamnd/rucc#431"),
220 (Opcode::CheckRace, "the same, over the epoch plane, which is S5's as well", "tamnd/rucc#431"),
221 // The plane writes, which the runtime does for itself today because the only ranges anything
222 // asks about are the ones its own allocator handed out. A stack object needs these.
223 (Opcode::MetaBegin, "a write over a range of the lifetime plane", "tamnd/rucc#428"),
224 (
225 Opcode::MetaEnd,
226 "the same write, with the version bumped past every capability",
227 "tamnd/rucc#428",
228 ),
229 (Opcode::MetaType, "the same over the type plane, which is S5's", "tamnd/rucc#431"),
230 (Opcode::MetaInit, "the same over the init plane, which is S5's", "tamnd/rucc#431"),
231 (
232 Opcode::MetaTransfer,
233 "the same, and the state a range is in while a device owns it, which is S2's",
234 "tamnd/rucc#428",
235 ),
236 (
237 Opcode::SafeRegionBegin,
238 "nothing at all, once the count document 10 section 10.2 asks for has been taken",
239 "tamnd/rucc#428",
240 ),
241 (Opcode::SafeRegionEnd, "the same, which is to say nothing", "tamnd/rucc#428"),
242];
243
244/// A width no rule is written at, why, and the issue that closes it.
245///
246/// The other half of coverage, and the half an opcode list cannot say. An opcode is covered when
247/// every name it has is a name a rule is written at, and a width with no name has no names to
248/// check: an `add` of two `__int128`s is not a missing rule for `add`, it is a width the rule
249/// language cannot spell. So the widths are written down here for the same reason the opcodes are
250/// written down above.
251pub static WIDTHS: &[(&str, &str, &str)] = &[
252 (
253 "one bit",
254 "everything but and, or, xor, a constant, and the widening out of one",
255 "tamnd/rucc#352",
256 ),
257 (
258 "a hundred and twenty eight bits",
259 "no register pair, so nothing at that width has a name",
260 "tamnd/rucc#351",
261 ),
262 (
263 "eighty bits",
264 "a long double is on the x87 stack and no rule is about that stack",
265 "tamnd/rucc#326",
266 ),
267 (
268 "a vector of any lane count",
269 "a rule at a width says nothing about how many lanes",
270 "tamnd/rucc#200",
271 ),
272];
273
274/// A name a rule could be written at and deliberately is not, why, and the issue that puts it
275/// back.
276///
277/// The third list, and the one that is about a name rather than about an opcode or a width. An
278/// opcode on [`GAPS`] has no lowering at any width and a width on [`WIDTHS`] has no names at all,
279/// and neither of those can say that `add` is lowered at four widths and left alone at two.
280///
281/// This list used to be all of the narrow arithmetic. C promotes the operands of an arithmetic
282/// operator to `int` before the operator is applied, so `char a, b; a + b` is an `int` addition of
283/// two sign extended chars and there is no C program that asks the back end to add two bytes.
284/// Rules were written at those names anyway, ahead of the pass that would reach them, and they sat
285/// proved and never selected: `tamnd/rucc#261` measured that and `tamnd/rucc#368` took them out.
286/// Most of them are back, because the width narrowing pass in `tamnd/rucc#375` is that caller and
287/// it writes a byte add out of the truncation the assignment back to a `char` already was.
288///
289/// What is left is what the pass will not narrow. A divide is not narrowed because the most
290/// negative byte over minus one is a defined hundred and twenty eight at four bytes and is the
291/// overflow that raises at one, so it wants a range analysis saying that pair cannot happen.
292///
293/// Not every narrow name was ever here, because promotion is not the only way a narrow operation
294/// is born. Reading a bitfield is a shift and a mask by constants at the width of the storage
295/// unit, writing one is a mask, a shift and an `or` of two values, and a truth test on a narrow
296/// scalar is an `icmp_ne` at that scalar's width. Those fire, so those always had rules.
297pub static NAMES: &[(&str, &str, &str)] = &[
298 ("sdiv.i8", "a narrow divide, which wants a range analysis before it can be narrowed", NARROW),
299 ("sdiv.i16", "the same", NARROW),
300 ("udiv.i8", "the same", NARROW),
301 ("udiv.i16", "the same", NARROW),
302 ("srem.i8", "the same", NARROW),
303 ("srem.i16", "the same", NARROW),
304 ("urem.i8", "the same", NARROW),
305 ("urem.i16", "the same", NARROW),
306];
307
308/// The issue every entry of [`NAMES`] waits on, since they all wait on the same one.
309const NARROW: &str = "tamnd/rucc#375";
310
311/// What a target's rules cover, and what they do not.
312#[derive(Debug)]
313pub struct Report {
314 /// The rule file this is about, so that anything said about it names a file to open.
315 pub source: &'static str,
316 /// How many opcodes the IR has.
317 pub opcodes: usize,
318 /// The opcodes every name of which a rule is written at.
319 pub by_rule: Vec<Opcode>,
320 /// How many names those are, which is one per opcode and width.
321 pub names: usize,
322 /// A name a rule could be written at and none is, which is what a missing rule looks like.
323 pub uncovered: Vec<(Opcode, &'static str)>,
324 /// A name on [`NAMES`], which is a missing rule somebody decided to be missing.
325 pub deferred: Vec<(Opcode, &'static str)>,
326 /// A name a rule is written at that nothing can ever be called, which is a dead rule.
327 pub unreachable: Vec<&'static str>,
328 /// The opcodes lowered somewhere a rule cannot reach.
329 pub elsewhere: Vec<Opcode>,
330 /// The opcodes nothing lowers.
331 pub gaps: Vec<Opcode>,
332 /// The opcodes on none of the three lists, which is what a new opcode is until somebody says
333 /// where it goes.
334 pub unaccounted: Vec<Opcode>,
335}
336
337impl fmt::Display for Report {
338 fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
339 write!(
340 f,
341 "rucc-codegen: {} lowers {} of the {} IR opcodes by rule at {} names, {} are lowered \
342 where no rule reaches, {} have no lowering yet and {} names are left for later",
343 self.source,
344 self.by_rule.len(),
345 self.opcodes,
346 self.names,
347 self.elsewhere.len(),
348 self.gaps.len(),
349 self.deferred.len()
350 )
351 }
352}
353
354/// What a table covers.
355///
356/// Nothing is executed and nothing is compiled. The rule set and the naming of instructions are
357/// both data, and the answer is a comparison of two lists.
358#[must_use]
359pub fn report(table: &Table) -> Report {
360 let named = term::heads();
361 let patterns = pattern_heads(table);
362
363 let mut by_rule = Vec::new();
364 let mut uncovered = Vec::new();
365 let mut deferred = Vec::new();
366 for &(opcode, name) in &named {
367 if patterns.contains(&name) {
368 by_rule.push(opcode);
369 } else if NAMES.iter().any(|&(deliberate, ..)| deliberate == name) {
370 deferred.push((opcode, name));
371 } else {
372 uncovered.push((opcode, name));
373 }
374 }
375 // An opcode is covered when every name it has is covered, so one missing width takes the
376 // whole opcode off the list however many of its other widths are there. A name on `NAMES` does
377 // not take it off, because the opcode is lowered and the entry says which widths were left for
378 // later and why: that is a narrower claim than the opcode having nowhere to go, and putting it
379 // on `GAPS` instead would say the wrong thing about an `add` that lowers perfectly well at
380 // four widths.
381 for &(opcode, _) in &uncovered {
382 by_rule.retain(|&covered| covered != opcode);
383 }
384 by_rule.sort_unstable();
385 by_rule.dedup();
386
387 let names = named.len() - uncovered.len() - deferred.len();
388 let unreachable: Vec<&'static str> = patterns
389 .iter()
390 .filter(|head| !named.iter().any(|(_, name)| name == *head))
391 .copied()
392 .collect();
393
394 let elsewhere: Vec<Opcode> = ELSEWHERE.iter().map(|&(opcode, _)| opcode).collect();
395 let gaps: Vec<Opcode> = GAPS.iter().map(|&(opcode, ..)| opcode).collect();
396 let unaccounted: Vec<Opcode> = Opcode::all()
397 .filter(|opcode| {
398 !by_rule.contains(opcode) && !elsewhere.contains(opcode) && !gaps.contains(opcode)
399 })
400 .collect();
401
402 Report {
403 source: table.source,
404 opcodes: Opcode::all().count(),
405 by_rule,
406 names,
407 uncovered,
408 deferred,
409 unreachable,
410 elsewhere,
411 gaps,
412 unaccounted,
413 }
414}
415
416/// Every name a rule in a table is written about, which is the first test the trie makes.
417///
418/// Node zero is the root of the trie over the patterns and the first thing any walk asks is what
419/// the term in hand is called, so its tests are exactly the set of pattern heads. There is no
420/// wildcard there to worry about: a rule matching any term at all is one nobody has written and
421/// one that would be an error to write, since a lowering has to know what it is lowering.
422fn pattern_heads(table: &Table) -> Vec<&'static str> {
423 let Some(root) = table.nodes.first() else { return Vec::new() };
424 let mut found: Vec<&'static str> = root
425 .tests
426 .iter()
427 .filter_map(|(test, _)| match test {
428 Test::App { head, .. } => Some(*head),
429 // Neither can be at the root. A pattern is a term with a head, so the first step of
430 // every one of them is a head, and there is nothing bound yet to be the same as.
431 Test::Int(_) | Test::Same(_) => None,
432 })
433 .collect();
434 found.sort_unstable();
435 found.dedup();
436 found
437}
438
439/// The rules a target lowers by, or `None` where no back end in this crate covers it.
440///
441/// The same question [`crate::pipeline::Machine::for_target`] answers about the rest of a machine,
442/// and it is here as well because a caller that wants to write down what a run covered has a
443/// target and no machine. An architecture that gets a rule file at M6 gets an arm here at the same
444/// time, and until then it has no rules to report coverage of rather than an empty set of them.
445#[must_use]
446pub fn table(arch: Arch) -> Option<&'static Table> {
447 match arch {
448 Arch::X86_64 => Some(&crate::select::x86_64::TABLE),
449 Arch::Aarch64 | Arch::Riscv64 => None,
450 }
451}
452
453/// Which rules fired, over one function or over a whole compilation.
454///
455/// A bit per rule and nothing else. This is on the path of every instruction selected, so what it
456/// costs is paid by every compilation whether or not anybody asked for the number, and the cheapest
457/// thing that answers the question is a flag per rule set once.
458///
459/// The index of a rule is how this is kept and not how it is written down. An index moves the
460/// moment a rule is added above it, so [`Fired::listing`] names the rule file and the line instead:
461/// a line is a place somebody can open, and a report written by one build can still be read against
462/// a rule file that has grown since.
463#[derive(Debug, Clone, Default, PartialEq, Eq)]
464pub struct Fired {
465 /// One entry per rule, true once that rule has fired. It grows to fit the highest index
466 /// marked rather than being sized from a table, so nothing here has to be told which target
467 /// is being compiled for.
468 seen: Vec<bool>,
469}
470
471impl Fired {
472 /// Nothing has fired yet.
473 #[must_use]
474 pub const fn new() -> Fired {
475 Fired { seen: Vec::new() }
476 }
477
478 /// Records that the rule at this index fired.
479 pub fn mark(&mut self, rule: usize) {
480 if self.seen.len() <= rule {
481 self.seen.resize(rule + 1, false);
482 }
483 self.seen[rule] = true;
484 }
485
486 /// Whether the rule at this index fired.
487 #[must_use]
488 pub fn has(&self, rule: usize) -> bool {
489 self.seen.get(rule).copied().unwrap_or(false)
490 }
491
492 /// How many rules fired.
493 #[must_use]
494 pub fn count(&self) -> usize {
495 self.seen.iter().filter(|fired| **fired).count()
496 }
497
498 /// Takes in everything another one recorded.
499 ///
500 /// One compilation is many functions and one command line is many files, and the question is
501 /// about all of them together. Merging rather than writing a file per function is also what
502 /// keeps the answer the same however the work was scheduled.
503 pub fn merge(&mut self, other: &Fired) {
504 if self.seen.len() < other.seen.len() {
505 self.seen.resize(other.seen.len(), false);
506 }
507 for (mine, theirs) in self.seen.iter_mut().zip(&other.seen) {
508 *mine |= *theirs;
509 }
510 }
511
512 /// What `-Zrule-coverage=FILE` writes.
513 ///
514 /// One line per rule in the table, in the order the rule file writes them, each saying whether
515 /// the rule fired and naming the file and line it is written at. Every rule is listed rather
516 /// than only the ones that fired, so that one of these files says what the whole rule set was
517 /// as well as what this compilation reached: a reader unioning them over a corpus needs both
518 /// and would otherwise have to parse the rule file to get the second.
519 ///
520 /// The first line is a comment holding the count, which is the number a person wants and the
521 /// one thing here that is not worth making them add up.
522 #[must_use]
523 pub fn listing(&self, table: &Table) -> String {
524 let fired = table.rules.iter().enumerate().filter(|(index, _)| self.has(*index)).count();
525 let mut out = format!(
526 "# rucc rule coverage: {fired} of {} rules in {} fired\n",
527 table.rules.len(),
528 table.source
529 );
530 for (index, rule) in table.rules.iter().enumerate() {
531 let word = if self.has(index) { "fired" } else { "unused" };
532 let _ = writeln!(out, "{word} {}:{} {}", table.source, rule.line, rule.pattern);
533 }
534 out
535 }
536}
537
538#[cfg(test)]
539mod tests {
540 use super::*;
541 use crate::select::x86_64::TABLE;
542
543 /// The claim the whole module is for, in the direction that matters: a name an instruction
544 /// can be called by is a name a rule is written at. This is the width check as much as the
545 /// opcode check, since a name is an opcode and a width together.
546 #[test]
547 fn every_name_an_instruction_can_have_is_one_a_rule_is_written_at() {
548 let report = report(&TABLE);
549 assert!(
550 report.uncovered.is_empty(),
551 "nothing in {} lowers these, and each is an opcode at a width the rule language can \
552 spell: {:?}",
553 report.source,
554 report.uncovered
555 );
556 }
557
558 /// And the other direction, which costs nothing to ask and finds a rule that can never fire.
559 /// A pattern head no instruction is ever called by is a rule written against a name that was
560 /// renamed or misspelled, and it would sit there proved and unreachable.
561 #[test]
562 fn every_name_a_rule_is_written_at_is_one_an_instruction_can_have() {
563 let report = report(&TABLE);
564 assert!(
565 report.unreachable.is_empty(),
566 "{} has rules for these and no instruction is ever called one: {:?}",
567 report.source,
568 report.unreachable
569 );
570 }
571
572 /// Every opcode is one of the three things, so a new opcode in the IR fails this until
573 /// somebody says where it goes. That is the whole point: the answer for a new opcode should
574 /// be written down when it is added rather than discovered by a user compiling a program.
575 #[test]
576 fn every_opcode_is_lowered_or_is_a_gap_somebody_wrote_down() {
577 let report = report(&TABLE);
578 assert!(
579 report.unaccounted.is_empty(),
580 "no rule lowers these, `ELSEWHERE` does not say where they are lowered and `GAPS` \
581 does not say why they are not: {:?}",
582 report.unaccounted
583 );
584 assert_eq!(
585 report.by_rule.len() + report.elsewhere.len() + report.gaps.len(),
586 report.opcodes,
587 "the three lists overlap, so an opcode is counted twice"
588 );
589 }
590
591 /// An entry that starts being covered fails, which is the rule every list in this project is
592 /// kept under. An opcode a rule now lowers is one that should be off both lists, and a list
593 /// that keeps claiming otherwise is a list nobody can read.
594 #[test]
595 fn an_entry_a_rule_now_covers_is_a_stale_entry() {
596 let report = report(&TABLE);
597 for &(opcode, where_) in ELSEWHERE {
598 assert!(
599 !report.by_rule.contains(&opcode),
600 "`{}` is lowered by a rule now, so the `ELSEWHERE` entry saying it is lowered by \
601 {where_} is stale",
602 opcode.name()
603 );
604 }
605 for &(opcode, why, issue) in GAPS {
606 assert!(
607 !report.by_rule.contains(&opcode),
608 "`{}` is lowered by a rule now, so the `GAPS` entry saying it is {why} is stale \
609 and {issue} may be closed",
610 opcode.name()
611 );
612 assert!(
613 !report.elsewhere.contains(&opcode),
614 "`{}` is on both lists, so it is both lowered and not lowered",
615 opcode.name()
616 );
617 }
618 }
619
620 /// The same staleness rule one list down. A name a rule is written at is a name that is not
621 /// left for later, and an entry claiming otherwise is one that should have gone when the rule
622 /// arrived. The other direction is checked too: a name no instruction can ever have is a
623 /// misspelling, and it would sit here excusing nothing.
624 #[test]
625 fn a_name_a_rule_is_written_at_is_not_a_name_left_for_later() {
626 let heads = pattern_heads(&TABLE);
627 let named = term::heads();
628 for &(name, why, issue) in NAMES {
629 assert!(
630 !heads.contains(&name),
631 "`{name}` is lowered by a rule now, so the `NAMES` entry saying it is {why} is \
632 stale and {issue} may be closer than it says"
633 );
634 assert!(
635 named.iter().any(|&(_, head)| head == name),
636 "`{name}` is not a name any instruction can have, so the `NAMES` entry excuses \
637 nothing"
638 );
639 }
640 let report = report(&TABLE);
641 assert_eq!(report.deferred.len(), NAMES.len(), "{:?}", report.deferred);
642 }
643
644 /// Every gap names an issue, since a gap with no issue behind it is a gap nobody has decided
645 /// anything about, which is the thing this module exists to stop.
646 #[test]
647 fn every_gap_names_the_issue_that_closes_it() {
648 let issues = GAPS
649 .iter()
650 .map(|&(_, _, issue)| issue)
651 .chain(WIDTHS.iter().map(|&(_, _, issue)| issue))
652 .chain(NAMES.iter().map(|&(_, _, issue)| issue));
653 for issue in issues {
654 let number = issue
655 .strip_prefix("tamnd/rucc#")
656 .unwrap_or_else(|| panic!("{issue} is not an issue in this project's tracker"));
657 assert!(number.parse::<u32>().is_ok(), "{issue} does not name an issue number");
658 }
659 }
660
661 /// The count, which `spec/15-testing.md` section 15.8 says we keep about ourselves. CI runs
662 /// this test with the output shown, so the number lands in a log next to the rule proof
663 /// rather than in a file somebody has to go and read.
664 #[test]
665 fn the_count_is_reported() {
666 let report = report(&TABLE);
667 println!("{report}");
668 for &(opcode, why, issue) in GAPS {
669 println!("rucc-codegen: no lowering for `{}`, which is {why}: {issue}", opcode.name());
670 }
671 for &(width, why, issue) in WIDTHS {
672 println!("rucc-codegen: no rule at {width}, which is {why}: {issue}");
673 }
674 for &(name, why, issue) in NAMES {
675 println!("rucc-codegen: no rule at `{name}`, which is {why}: {issue}");
676 }
677 assert_eq!(report.gaps.len(), GAPS.len());
678 }
679
680 /// What the root of the trie is, which is the assumption [`pattern_heads`] rests on. If the
681 /// rule compiler ever built the trie some other way this would say so, rather than the
682 /// coverage numbers quietly becoming a report about an empty list.
683 #[test]
684 fn the_root_of_the_trie_is_the_head_of_every_pattern() {
685 let heads = pattern_heads(&TABLE);
686 assert!(!heads.is_empty(), "the table has rules and the root of the trie tests nothing");
687 for rule in TABLE.rules {
688 let head = rule
689 .pattern
690 .strip_prefix('(')
691 .and_then(|rest| rest.split([' ', ')']).next())
692 .expect("a pattern is an application");
693 assert!(
694 heads.contains(&head),
695 "line {}: {} is a pattern whose head the root of the trie does not test",
696 rule.line,
697 rule.pattern
698 );
699 }
700 }
701
702 /// The one target with a rule file, and the two that get one at M6. A machine that can be
703 /// compiled for has rules to report the coverage of, and one that cannot has none rather than
704 /// an empty set of them, which are different answers and would read the same as a number.
705 #[test]
706 fn a_target_with_a_back_end_is_a_target_with_a_rule_set() {
707 let x86 = table(Arch::X86_64).expect("x86-64 is what this crate lowers for");
708 assert_eq!(x86.source, TABLE.source);
709 assert!(!x86.rules.is_empty());
710 assert!(table(Arch::Aarch64).is_none(), "there is no aarch64 rule file yet");
711 assert!(table(Arch::Riscv64).is_none(), "there is no riscv64 rule file yet");
712 }
713
714 /// What a rule is called outside this process. The index is not it: a rule added at the top of
715 /// the file moves every index below it, and a report from last week would then be a report
716 /// about the wrong rules. The file and the line do not move that way and are somewhere to look.
717 #[test]
718 fn a_rule_is_written_down_as_the_place_it_is_written_at() {
719 let mut fired = Fired::new();
720 fired.mark(0);
721 let listing = fired.listing(&TABLE);
722 let first =
723 format!("fired {}:{} {}", TABLE.source, TABLE.rules[0].line, TABLE.rules[0].pattern);
724 assert!(listing.contains(&first), "{listing}");
725 assert!(listing.lines().next().is_some_and(|line| line.starts_with('#')), "{listing}");
726 }
727
728 /// Every rule is listed and not only the ones that fired, which is what lets one of these files
729 /// be read on its own. A reader that only got the rules that fired would have to parse the rule
730 /// file to find out what the rest of them were.
731 #[test]
732 fn one_file_says_what_the_whole_rule_set_is() {
733 let listing = Fired::new().listing(&TABLE);
734 let lines: Vec<&str> = listing.lines().collect();
735 assert_eq!(lines.len(), TABLE.rules.len() + 1, "one line per rule and one for the count");
736 assert_eq!(
737 lines.iter().filter(|line| line.starts_with("unused ")).count(),
738 TABLE.rules.len()
739 );
740 assert!(lines[0].contains(&format!("0 of {} rules", TABLE.rules.len())), "{}", lines[0]);
741 }
742
743 /// A compilation is many functions and a command line is many files, and the question is about
744 /// all of them at once. Merging is also what keeps the answer the same however the work was
745 /// scheduled, which is the rule `spec/03-architecture.md` section 3.7 holds everything to.
746 #[test]
747 fn what_two_runs_reached_is_what_either_of_them_reached() {
748 let mut one = Fired::new();
749 one.mark(3);
750 one.mark(3);
751 assert_eq!(one.count(), 1, "a rule that fires twice is one rule");
752 let mut two = Fired::new();
753 two.mark(0);
754 two.mark(9);
755 one.merge(&two);
756 assert_eq!(one.count(), 3);
757 assert!(one.has(0) && one.has(3) && one.has(9));
758 assert!(!one.has(1));
759
760 // The merge is symmetric, since neither order of two files is the right one.
761 let mut back = Fired::new();
762 back.mark(0);
763 back.mark(9);
764 let mut three = Fired::new();
765 three.mark(3);
766 back.merge(&three);
767 assert_eq!(back, one);
768 }
769}