Struct rslint_core::groups::errors::NoConstantCondition

pub struct NoConstantCondition {}

Disallow constant conditions which always yield one result.

Constant conditions such as if (true) {} are almost always a mistake. Constant conditions always yield a single result which almost always ends up in unwanted behavior. This rule is aimed at catching those conditions in if, do while, while, and for statements, as well as conditional expressions.

Incorrect Code Examples

if (true) {
    //    ^ this block is always used
} else {
//^^^^ this else block is unreachable
}

// This loop endlessly runs
for(foo = 5; 5; foo++) {

}

Correct Code Examples

if (foo) {
    /* */
}

Implementations

impl NoConstantCondition

pub fn new() -> Self

Trait Implementations

impl Clone for NoConstantCondition

fn clone(&self) -> NoConstantCondition

Returns a copy of the value.

fn clone_from(&mut self, source: &Self)

Performs copy-assignment from source.

impl CstRule for NoConstantCondition

fn check_node(&self, node: &SyntaxNode, ctx: &mut RuleCtx) -> Option<()>

Check an individual node in the syntax tree. You can use the match_ast macro to make matching a node to an ast node easier. The reason this uses nodes and not a visitor is because nodes are more flexible, converting them to an AST node has zero cost and you can easily traverse surrounding nodes. Defaults to doing nothing.

fn check_token(&self, token: &SyntaxToken, ctx: &mut RuleCtx) -> Option<()>

Check an individual token in the syntax tree. Defaults to doing nothing.

fn check_root(&self, root: &SyntaxNode, ctx: &mut RuleCtx) -> Option<()>

Check the root of the tree one time. This method is guaranteed to only be called once. The root's kind will be either SCRIPT or MODULE. Defaults to doing nothing.

impl Debug for NoConstantCondition

fn fmt(&self, f: &mut Formatter<'_>) -> Result

Formats the value using the given formatter.

impl Default for NoConstantCondition

fn default() -> NoConstantCondition

Returns the "default value" for a type.

impl<'de> Deserialize<'de> for NoConstantCondition

fn deserialize<__D>(__deserializer: __D) -> Result<Self, __D::Error> where
    __D: Deserializer<'de>, 

Deserialize this value from the given Serde deserializer.

impl Rule for NoConstantCondition

fn name(&self) -> &'static str

A unique, kebab-case name for the rule.

fn group(&self) -> &'static str

The name of the group this rule belongs to.

impl Serialize for NoConstantCondition

fn serialize<__S>(&self, __serializer: __S) -> Result<__S::Ok, __S::Error> where
    __S: Serializer, 

Serialize this value into the given Serde serializer.