roxlap_scene/

fow.rs

//! FW.0 — fog-of-war mask core (`PORTING-FOW.md`): SS13-style
//! *knowledge* visibility, computed host-side, applied by renderers
//! in later substages.
//!
//! A [`FogOfWar`] tracks, per deck and per mip-0 XY column ("cell"),
//! what the observed character *knows*: never seen ([`CellState::Unseen`]),
//! seen before ([`CellState::Memory`]), currently in the facing cone /
//! peripheral radius ([`CellState::Visible`]), or revealed by a sound
//! source ([`CellState::Heard`]). Each cell carries a 6-bit intensity
//! that fades between states (the boundary is a smooth per-cell
//! taper — **no dither**, the OC round-1 lesson) and decays while in
//! Memory.
//!
//! Conventions (chapter 2: **+z is DOWN**):
//! - Cells are grid-local mip-0 XY columns; a [`DeckBand`] limits each
//!   deck's z extent (`z_top` is the ceiling — the *smaller* z).
//! - Line of sight is a 2D recursive shadowcast on the active deck: a
//!   cell blocks when any solid voxel intersects the band's eye-level
//!   z range. Cell opacity (and the light-gate sample) is cached per
//!   XY chunk tile and invalidated by [`Grid::chunk_version`]s, so
//!   edits are picked up without rescanning quiet chunks.
//! - The optional [`LightGate`] keeps *dark* cells from becoming
//!   Visible: geometric LOS is scaled by the baked brightness of the
//!   first solid surface under the eye (plus an emissive colour-key
//!   list — an emissive strip lights its cell regardless of bake).
//!   Dynamic lights do NOT open vision in v1 (entry-doc decision 5).
//!
//! This module is **presentation-only** state (entry-doc decision 10):
//! nothing in the simulation, collision, audio, or pathing may read
//! the mask, and no snapshot wire change is involved (savegame
//! persistence of explored area is an explicit follow-up). Renderers
//! consume it in FW.2/FW.3; the known-twin sync (FW.1) walks
//! [`FogOfWar::for_each_live_cell`].

use std::collections::HashMap;
use std::hash::{BuildHasherDefault, Hasher};

use glam::{DVec3, IVec2, IVec3, UVec3, Vec2};
use roxlap_formats::color::Rgb;
use roxlap_formats::vxl::Vxl;

use crate::{DirtyExtent, Grid, GridId, GridTransform, LodThresholds, Scene, CHUNK_SIZE_XY};

/// Maximum cell intensity (6 bits of the mask byte).
pub const INTENSITY_MAX: u8 = 63;

/// XY size of one mask/opacity tile — locked to the chunk footprint so
/// tile keys are chunk indices and version invalidation is 1:1.
const TILE: i32 = CHUNK_SIZE_XY as i32;
const TILE_CELLS: usize = (TILE * TILE) as usize;
const TILE_WORDS: usize = TILE_CELLS / 64;

/// Intensity settle threshold — transitions below this snap and stop
/// ticking.
const SETTLE_EPS: f32 = 0.25;

/// What the observer knows about a cell. Packed into the top 2 bits
/// of the mask byte (intensity in the low 6).
#[derive(Debug, Clone, Copy, PartialEq, Eq)]
#[repr(u8)]
pub enum CellState {
    /// Never seen — renderers draw background (FW.2).
    Unseen = 0,
    /// Seen before — the known twin's frozen last-seen look, dimmed.
    Memory = 1,
    /// In the current facing cone or peripheral radius — live.
    Visible = 2,
    /// Revealed by a heard sound source — live data, Memory styling.
    Heard = 3,
}

impl CellState {
    fn from_bits(bits: u8) -> Self {
        match bits & 3 {
            1 => Self::Memory,
            2 => Self::Visible,
            3 => Self::Heard,
            _ => Self::Unseen,
        }
    }
}

/// One deck's z extent, grid-local, inclusive, z-down (`z_top` is the
/// ceiling — numerically the smallest z). The caller derives these
/// from the same levels as CA's deck clips. The eye-level opacity band
/// is NOT here — it rides the observer ([`FowObserver::eye_z`]) so LOS
/// tracks the character's real eye over uneven ground (stairs, ramps,
/// boulders, furniture) instead of a fixed floor-relative slab.
#[derive(Debug, Clone, Copy, PartialEq, Eq)]
pub struct DeckBand {
    /// Ceiling z (inclusive, smallest value).
    pub z_top: i32,
    /// Floor z (inclusive, largest value) — the light gate scans down
    /// to here for the surface brightness sample.
    pub z_bottom: i32,
}

impl DeckBand {
    /// Does grid-local `z` fall inside this deck's `[z_top, z_bottom]`?
    #[must_use]
    pub fn contains_z(&self, z: i32) -> bool {
        (self.z_top..=self.z_bottom).contains(&z)
    }
}

/// Half-height of the eye-level opacity band around [`FowObserver::eye_z`]
/// (cells). A voxel blocks LOS when it lies within `±EYE_HALF` of the
/// observer's eye — thin, so the character sees OVER low obstacles
/// (crates, rubble) at eye level rather than being walled in by them.
const EYE_HALF: i32 = 2;

/// Decision 5 — light gates vision: a cell only reaches full Visible
/// intensity when its surface is lit. Samples the **baked** brightness
/// byte (colour high byte) of the first solid voxel scanning down from
/// `eye_top` to the deck floor; emissive colour keys count as fully
/// lit anywhere in that scan. Dynamic point lights are not sampled in
/// v1.
#[derive(Debug, Clone, PartialEq)]
pub struct LightGate {
    /// Baked-brightness byte at/above which the cell is fully lit
    /// (bakes centre around `0x80` neutral).
    pub lit_brightness: u8,
    /// Soft knee below the threshold: brightness in
    /// `[lit_brightness - softness, lit_brightness]` scales visibility
    /// linearly. `0` = hard cut.
    pub softness: u8,
    /// Colour keys (brightness-stripped, the engine's colour→material
    /// map convention) treated as self-lit — emissive strips keep
    /// their cell visible in a pitch-dark corridor.
    pub emissive_colors: Vec<Rgb>,
}

impl LightGate {
    /// Visibility factor `0..=1` for a surface of baked brightness
    /// `b`.
    #[must_use]
    pub fn lit_factor(&self, b: u8) -> f32 {
        if b >= self.lit_brightness {
            return 1.0;
        }
        if self.softness == 0 {
            return 0.0;
        }
        let knee = self.lit_brightness.saturating_sub(self.softness);
        if b <= knee {
            return 0.0;
        }
        f32::from(b - knee) / f32::from(self.softness)
    }
}

/// All FW tuning in one place. Geometry fields are in cells (mip-0
/// voxels) and radians; rates are intensity units (`0..=63`) per
/// second. The styling knobs at the bottom are read by the renderers
/// from FW.2 on — unread in FW.0.
#[derive(Debug, Clone, PartialEq)]
pub struct VisionConfig {
    /// Half-angle of the facing cone, radians.
    pub cone_half_angle: f32,
    /// Angular taper band *inside* the half-angle over which intensity
    /// falls to zero (smooth cone rim), radians.
    pub cone_taper: f32,
    /// Facing-cone reach, cells.
    pub range: f32,
    /// 360° close-range vision, cells (an observer is never blind in
    /// their own back at arm's length).
    pub peripheral_range: f32,
    /// Radial taper band inside `range` / `peripheral_range` /
    /// heard-blob radii, cells.
    pub edge_taper: f32,
    /// The decks, index-aligned with [`FowObserver::deck`] and every
    /// per-deck query. Must stay the same length across
    /// [`FogOfWar::set_config`] calls (layers are keyed by index).
    pub decks: Vec<DeckBand>,
    /// Decision 5 — `None` = geometric visibility only.
    pub light_gate: Option<LightGate>,
    /// Intensity rise rate toward a live (Visible/Heard) target.
    pub fade_in: f32,
    /// Intensity fall rate when leaving sight, down to
    /// `memory_intensity`.
    pub fade_out: f32,
    /// Where a freshly-demoted Memory cell settles before slow decay.
    pub memory_intensity: u8,
    /// Decision 7 — slow decay rate from `memory_intensity` toward
    /// `memory_floor`. `0` = memories never fade.
    pub memory_decay: f32,
    /// Decayed-memory minimum intensity — old memories stay barely
    /// readable rather than vanishing back to Unseen.
    pub memory_floor: u8,
    /// Heard-blob radius in cells per unit of loudness.
    pub heard_radius: f32,
    /// Seconds a heard blob stays live before fading out.
    pub heard_duration: f32,
    /// FW.2+ styling: Memory/Heard brightness multiplier.
    pub memory_dim: f32,
    /// FW.2+ styling: Memory/Heard desaturation amount `0..=1`.
    pub memory_desaturate: f32,
}

impl VisionConfig {
    /// Defaults tuned for ship scale (~1 voxel ≈ 10 cm): a 120° cone
    /// reaching 96 cells, 12-cell peripheral, light gate off.
    #[must_use]
    pub fn for_decks(decks: Vec<DeckBand>) -> Self {
        Self {
            cone_half_angle: 1.05,
            cone_taper: 0.12,
            range: 96.0,
            peripheral_range: 12.0,
            edge_taper: 4.0,
            decks,
            light_gate: None,
            fade_in: 240.0,
            fade_out: 120.0,
            memory_intensity: 26,
            memory_decay: 0.8,
            memory_floor: 10,
            heard_radius: 10.0,
            heard_duration: 1.5,
            memory_dim: 0.45,
            memory_desaturate: 0.6,
        }
    }

    /// Index of the deck whose `[z_top, z_bottom]` contains grid-local
    /// `z` (the head-follow deck pick, CA round-3 convention: feed the
    /// HEAD z, not the feet).
    #[must_use]
    pub fn deck_for_z(&self, z: i32) -> Option<usize> {
        self.decks.iter().position(|d| d.contains_z(z))
    }
}

/// FW.3 — the fog mask flattened for GPU upload (see
/// [`FogOfWar::gpu_mask`]). Backend-neutral: `roxlap-render` packs
/// `cells` into a storage buffer and writes the scalars as uniforms; the
/// WGSL kernel reproduces [`FowRender`]'s verdict from the same bytes +
/// bands + styling, so the two backends agree.
#[derive(Debug, Clone, PartialEq)]
pub struct GpuFowMask {
    /// Grid-local cell coordinate of the buffer's `(0, 0)`.
    pub origin_cell: [i32; 2],
    /// Buffer width in cells.
    pub width: u32,
    /// Buffer height in cells.
    pub height: u32,
    /// Per-deck `(z_top, z_bottom)` inclusive bands (deck order matches
    /// the `deck` axis of `cells`).
    pub decks: Vec<[i32; 2]>,
    /// Visual-pass round 5 (#1): the observer's ACTIVE deck — the layer
    /// every rendered voxel is classified against, regardless of its z.
    /// (The CPU [`FowRender`] reads [`FogOfWar::visible_deck`] directly;
    /// the GPU gets it here.)
    pub active_deck: usize,
    /// Deck-major, row-major mask bytes (state in bits 6–7, intensity in
    /// bits 0–5); `d*width*height + y*width + x`.
    pub cells: Vec<u8>,
    /// [`VisionConfig::memory_dim`].
    pub memory_dim: f32,
    /// [`VisionConfig::memory_desaturate`].
    pub memory_desaturate: f32,
    /// [`FogOfWar::mask_version`] this snapshot was taken at (upload gate).
    pub version: u64,
}

/// Who is looking: grid-local cell, facing, and active deck index.
/// The caller converts from world space ([`crate::world_to_grid_local`])
/// — keeping the mask grid-local makes ship rotation/movement free.
#[derive(Debug, Clone, Copy)]
pub struct FowObserver {
    /// Observer cell (grid-local mip-0 XY column).
    pub cell: IVec2,
    /// Facing direction, grid-local XY. Zero disables the cone
    /// (peripheral-only vision).
    pub facing: Vec2,
    /// Active deck index into [`VisionConfig::decks`].
    pub deck: usize,
    /// The character's eye z, grid-local (z-down). LOS is blocked by any
    /// solid voxel within `±EYE_HALF` of it, so vision tracks the real
    /// eye over stairs / ramps / boulders — not the deck floor.
    pub eye_z: i32,
}

/// One 128×128 mask tile: byte per cell, state in bits 6–7, intensity
/// in bits 0–5.
struct MaskTile {
    bytes: Box<[u8; TILE_CELLS]>,
}

impl MaskTile {
    fn new() -> Self {
        Self {
            bytes: vec![0u8; TILE_CELLS].into_boxed_slice().try_into().unwrap(),
        }
    }
}

/// Lazily-computed per-cell opacity + light sample for one XY chunk
/// tile, keyed by the chunk-version mix so edits invalidate it.
struct OpacityTile {
    key: u64,
    computed: Box<[u64; TILE_WORDS]>,
    blocked: Box<[u64; TILE_WORDS]>,
    /// Quantised lit factor `0..=255` (255 = fully lit); only
    /// meaningful where `computed` is set.
    lit: Box<[u8; TILE_CELLS]>,
}

impl OpacityTile {
    fn new(key: u64) -> Self {
        Self {
            key,
            computed: vec![0u64; TILE_WORDS]
                .into_boxed_slice()
                .try_into()
                .unwrap(),
            blocked: vec![0u64; TILE_WORDS]
                .into_boxed_slice()
                .try_into()
                .unwrap(),
            lit: vec![0u8; TILE_CELLS].into_boxed_slice().try_into().unwrap(),
        }
    }
}

/// FW.2 review perf #1 — the render styler calls `FogOfWar::state` once
/// per SOLID hit (hundreds of thousands per frame at Boarding scale, and
/// once per internal cell of a Hide volume the marcher walks through).
/// The default `HashMap` SipHash on the `(i32, i32)` tile key dominates
/// that path; this Fx-style integer hasher (the same
/// `rotate_left(5) ^ v * K` multiply rustc uses) cuts each lookup to a
/// few instructions. Deterministic, zero-dependency, and `Sync` (the
/// styler is shared read-only across the per-tile rayon workers, so a
/// mutable last-tile cache is not an option — a faster hash is).
#[derive(Default)]
struct FxHasher(u64);

impl Hasher for FxHasher {
    #[inline]
    fn finish(&self) -> u64 {
        self.0
    }
    #[inline]
    fn write(&mut self, bytes: &[u8]) {
        for &b in bytes {
            self.write_u64(u64::from(b));
        }
    }
    #[inline]
    fn write_i32(&mut self, i: i32) {
        self.write_u64(u64::from(i as u32));
    }
    #[inline]
    fn write_u64(&mut self, n: u64) {
        const K: u64 = 0x517c_c1b7_2722_0a95;
        self.0 = (self.0.rotate_left(5) ^ n).wrapping_mul(K);
    }
}

type FastMap<K, V> = HashMap<K, V, BuildHasherDefault<FxHasher>>;

/// Per-deck layers: sparse mask + opacity tiles keyed by chunk XY
/// index. Fx-hashed (perf #1).
#[derive(Default)]
struct DeckLayer {
    mask: FastMap<(i32, i32), MaskTile>,
    opacity: FastMap<(i32, i32), OpacityTile>,
}

fn split_cell(cell: IVec2) -> ((i32, i32), usize) {
    let tx = cell.x.div_euclid(TILE);
    let ty = cell.y.div_euclid(TILE);
    let ix = cell.x.rem_euclid(TILE);
    let iy = cell.y.rem_euclid(TILE);
    ((tx, ty), (iy * TILE + ix) as usize)
}

impl DeckLayer {
    fn byte(&self, cell: IVec2) -> u8 {
        let (tile, idx) = split_cell(cell);
        self.mask.get(&tile).map_or(0, |t| t.bytes[idx])
    }

    /// Write a mask byte; returns whether the stored value changed.
    fn write(&mut self, cell: IVec2, val: u8) -> bool {
        let (tile, idx) = split_cell(cell);
        if val == 0 && !self.mask.contains_key(&tile) {
            return false;
        }
        let t = self.mask.entry(tile).or_insert_with(MaskTile::new);
        let changed = t.bytes[idx] != val;
        t.bytes[idx] = val;
        changed
    }
}

fn pack(state: CellState, intensity: u8) -> u8 {
    ((state as u8) << 6) | intensity.min(INTENSITY_MAX)
}

#[inline]
fn fnv(h: &mut u64, v: u64) {
    *h ^= v;
    *h = h.wrapping_mul(0x0000_0100_0000_01b3);
}

/// Mix one chunk's change-signature: the edit version AND its
/// materialisation state. Presence matters because a generated /
/// streamed-in chunk keeps `chunk_version == 0` (same as absent) —
/// keying on the version alone would reuse a stale "all air" opacity
/// tile after the chunk appears (walls behind the fresh geometry stay
/// visible). Folding presence in flips the key on the absent→present
/// transition too.
#[inline]
fn mix_chunk_sig(h: &mut u64, grid: &Grid, idx: IVec3) {
    fnv(h, grid.chunk_version(idx));
    fnv(h, u64::from(grid.chunk(idx).is_some()));
}

fn band_chz_range(band: DeckBand, eye_lo: i32, eye_hi: i32) -> (i32, i32) {
    let cs_z = crate::CHUNK_SIZE_Z as i32;
    (
        band.z_top.min(eye_lo).div_euclid(cs_z),
        band.z_bottom.max(eye_hi).div_euclid(cs_z),
    )
}

/// Chunk-z range for a deck's RENDER extent `[z_top, z_bottom]` alone
/// (no eye band) — used by the twin sync to copy the geometry a seen
/// cell needs, independent of where the observer's eye happens to be.
fn deck_chz_range(band: DeckBand) -> (i32, i32) {
    let cs_z = crate::CHUNK_SIZE_Z as i32;
    (band.z_top.div_euclid(cs_z), band.z_bottom.div_euclid(cs_z))
}

/// FNV-1a mix of the chunk signatures (plus the config generation and the
/// observer's eye band, so light-gate retunes AND eye-height changes
/// re-sample) backing one XY tile of a deck band.
fn tile_key(
    grid: &Grid,
    band: DeckBand,
    eye_lo: i32,
    eye_hi: i32,
    config_gen: u64,
    tx: i32,
    ty: i32,
) -> u64 {
    let (chz_lo, chz_hi) = band_chz_range(band, eye_lo, eye_hi);
    let mut h: u64 = 0xcbf2_9ce4_8422_2325;
    fnv(&mut h, config_gen);
    fnv(&mut h, eye_lo as u64);
    fnv(&mut h, eye_hi as u64);
    for chz in chz_lo..=chz_hi {
        mix_chunk_sig(&mut h, grid, IVec3::new(tx, ty, chz));
    }
    h
}

/// FNV-1a mix of every chunk signature the LOS scan could touch from
/// `origin` at `radius` (cells) on `band`. Keys the LOS recompute on
/// edits *within view* only — far-side debris / streaming elsewhere on
/// the ship no longer forces a full radius-96 shadowcast every frame
/// (the old key hung on the grid-wide `mutation_counter`).
fn local_edit_key(
    grid: &Grid,
    band: DeckBand,
    eye_lo: i32,
    eye_hi: i32,
    config_gen: u64,
    origin: IVec2,
    radius: i32,
) -> u64 {
    let cs_xy = CHUNK_SIZE_XY as i32;
    let cx_lo = (origin.x - radius).div_euclid(cs_xy);
    let cx_hi = (origin.x + radius).div_euclid(cs_xy);
    let cy_lo = (origin.y - radius).div_euclid(cs_xy);
    let cy_hi = (origin.y + radius).div_euclid(cs_xy);
    let (chz_lo, chz_hi) = band_chz_range(band, eye_lo, eye_hi);
    let mut h: u64 = 0xcbf2_9ce4_8422_2325;
    fnv(&mut h, config_gen);
    for chz in chz_lo..=chz_hi {
        for cy in cy_lo..=cy_hi {
            for cx in cx_lo..=cx_hi {
                mix_chunk_sig(&mut h, grid, IVec3::new(cx, cy, chz));
            }
        }
    }
    h
}

/// One live heard reveal. Its covered cells + intensities are computed
/// ONCE at [`FogOfWar::hear`] time (they never change over the TTL), so
/// the per-tick union carries no `sqrt`.
struct HeardBlob {
    deck: usize,
    cells: Vec<(IVec2, f32)>,
    ttl: f32,
}

/// The fog-of-war state for ONE FW-enabled grid (entry-doc decision
/// 3): per-deck mask layers, the LOS cache, heard blobs, and the
/// fade/decay state machine. Owned by the host beside the scene;
/// call [`Self::update`] once per tick with the observed character's
/// grid-local pose.
pub struct FogOfWar {
    config: VisionConfig,
    config_gen: u64,
    layers: Vec<DeckLayer>,
    /// Currently-visible cells of `visible_deck` → target intensity.
    visible: HashMap<(i32, i32), f32>,
    visible_deck: usize,
    los_key: Option<(IVec2, i32, usize, i32, u64, u64)>,
    heard: Vec<HeardBlob>,
    /// Set when a blob was added, so the next tick rebuilds the union;
    /// blob expiry sets it inline. Steady state skips the rebuild.
    heard_dirty: bool,
    /// Cells currently stamped Heard → target intensity.
    heard_cells: HashMap<(usize, i32, i32), f32>,
    /// Cells mid-fade/decay → current fractional intensity (the float
    /// is the truth while transitioning; the mask byte is its
    /// rounding).
    transitions: HashMap<(usize, i32, i32), f32>,
    mask_version: u64,
    /// FW.4 — bumps ONLY when the set of Visible cells changes (a cell
    /// enters or leaves the facing cone / peripheral). Sprite visibility
    /// (decision 8) depends on nothing else — Memory/Unseen/Heard all
    /// hide — so the GPU sprite-cull skip cache keys on this, NOT on
    /// `mask_version` (which bumps on every intensity fade). Review perf
    /// #1: without it every fade frame re-culls an identical sprite set.
    sprite_epoch: u64,
}

impl FogOfWar {
    /// A fresh all-Unseen fog for `config`.
    #[must_use]
    pub fn new(config: VisionConfig) -> Self {
        let layers = config.decks.iter().map(|_| DeckLayer::default()).collect();
        Self {
            config,
            config_gen: 0,
            layers,
            visible: HashMap::new(),
            visible_deck: 0,
            los_key: None,
            heard: Vec::new(),
            heard_dirty: false,
            heard_cells: HashMap::new(),
            transitions: HashMap::new(),
            mask_version: 0,
            sprite_epoch: 0,
        }
    }

    /// Current tuning.
    #[must_use]
    pub fn config(&self) -> &VisionConfig {
        &self.config
    }

    /// Replace the tuning (sliders in the demo). The deck list must
    /// keep its length — layers are keyed by index; explored memory
    /// survives the swap. Forces a LOS + light-sample recompute.
    ///
    /// # Panics
    /// If `config.decks.len()` differs from the current one.
    pub fn set_config(&mut self, config: VisionConfig) {
        assert_eq!(
            config.decks.len(),
            self.config.decks.len(),
            "FW deck count is fixed per FogOfWar (layers are index-keyed)"
        );
        self.config = config;
        self.config_gen += 1;
    }

    /// Bumped whenever any mask byte changes — FW.3 gates the GPU
    /// mask re-upload on it.
    #[must_use]
    pub fn mask_version(&self) -> u64 {
        self.mask_version
    }

    /// FW.4 — bumped ONLY when the Visible-cell set changes (see the
    /// field docs). Sprite visibility depends on nothing else, so the
    /// GPU sprite-cull skip cache keys on this instead of `mask_version`
    /// — an intensity fade re-uploads the mask but does not re-cull the
    /// sprites (review perf #1).
    #[must_use]
    pub fn sprite_epoch(&self) -> u64 {
        self.sprite_epoch
    }

    /// The deck the last [`Self::update`] ran LOS on.
    #[must_use]
    pub fn visible_deck(&self) -> usize {
        self.visible_deck
    }

    /// What the observer knows about `cell` on `deck`, plus the
    /// current fade intensity `0..=63`.
    #[must_use]
    pub fn state(&self, deck: usize, cell: IVec2) -> (CellState, u8) {
        let Some(layer) = self.layers.get(deck) else {
            return (CellState::Unseen, 0);
        };
        let b = layer.byte(cell);
        (CellState::from_bits(b >> 6), b & INTENSITY_MAX)
    }

    /// Decision 6 — a sound source at `cell` on `deck` was heard at
    /// `loudness` (feed it `source_acoustics` transmission×gain, or
    /// any game-side loudness): stamps a live Heard blob of radius
    /// `heard_radius × loudness` for `heard_duration` seconds.
    /// Hearing goes through walls by design — no LOS test. Returns
    /// whether a blob was actually stamped (a sub-cell radius — a
    /// too-faint source — stamps nothing).
    pub fn hear(&mut self, deck: usize, cell: IVec2, loudness: f32) -> bool {
        if deck >= self.config.decks.len() || loudness <= 0.0 {
            return false;
        }
        let r = self.config.heard_radius * loudness;
        let ri = r.ceil() as i32;
        let taper = self.config.edge_taper.max(1.0);
        let mut cells = Vec::new();
        for dy in -ri..=ri {
            for dx in -ri..=ri {
                let d = f64::from(dx * dx + dy * dy).sqrt() as f32;
                let t = ((r - d) / taper).clamp(0.0, 1.0);
                if t > 0.0 {
                    cells.push((cell + IVec2::new(dx, dy), t * f32::from(INTENSITY_MAX)));
                }
            }
        }
        if cells.is_empty() {
            return false;
        }
        self.heard.push(HeardBlob {
            deck,
            cells,
            ttl: self.config.heard_duration,
        });
        self.heard_dirty = true;
        true
    }

    /// FW.4 — map a WORLD point to `(deck, grid-local cell)`, or `None`
    /// if it lies OUTSIDE the fog grid's `footprint` (grid-local cell
    /// bounds `[lo, hi)`, from [`crate::Grid::footprint_cells`]). Off the
    /// footprint = open space the fog knows nothing about (hazard 3 —
    /// actors on the water / in space are never touched). A z between
    /// decks (a stair, a jump, the hull) falls back to the observer's
    /// active deck, so an actor mid-transit over a visible XY does not
    /// pop out (review #6).
    fn resolve_world(
        &self,
        transform: &GridTransform,
        footprint: (IVec2, IVec2),
        world: DVec3,
    ) -> Option<(usize, IVec2)> {
        let glp = crate::addr::world_to_grid_local(world, transform);
        let v = crate::addr::voxel_global(glp.chunk, glp.voxel);
        let (lo, hi) = footprint;
        if v.x < lo.x || v.x >= hi.x || v.y < lo.y || v.y >= hi.y {
            return None; // outside the grid footprint — open space
        }
        let deck = self
            .config
            .deck_for_z(v.z)
            .unwrap_or_else(|| self.visible_deck());
        Some((deck, IVec2::new(v.x, v.y)))
    }

    /// FW.4 — [`Self::hear`] for a WORLD-space source: maps `world`
    /// through the fog grid's `transform` (+ its `footprint`) to a cell +
    /// deck and stamps a heard blob. Returns whether a blob was stamped —
    /// `false` when the source is OUTSIDE the footprint (a passing ship's
    /// noise must not stamp this grid's mask — review #2) or too faint to
    /// cover a cell. `transform`/`footprint` come from the fog grid.
    pub fn hear_world(
        &mut self,
        transform: &GridTransform,
        footprint: (IVec2, IVec2),
        world: DVec3,
        loudness: f32,
    ) -> bool {
        match self.resolve_world(transform, footprint, world) {
            Some((deck, cell)) => self.hear(deck, cell, loudness),
            None => false,
        }
    }

    /// FW.4 — decision 8: should a sprite at world position `world` be
    /// HIDDEN by the fog? Shown ONLY where the observer currently SEES
    /// it — a Visible cell. Memory / Unseen cells hide it (you see the
    /// frozen geometry of a remembered room, not the actors in it); a
    /// Heard cell also hides the sprite in v1 (hearing reveals the
    /// GEOMETRY pocket, not a precise live actor — a dimmed heard-sprite
    /// is a follow-up, review #5). A point OUTSIDE the grid `footprint`
    /// is open space and is NEVER hidden (hazard 3 — review #1).
    /// `transform`/`footprint` come from the fog grid. Binary (no alpha
    /// fade in v1).
    #[must_use]
    pub fn hides_sprite(
        &self,
        transform: &GridTransform,
        footprint: (IVec2, IVec2),
        world: DVec3,
    ) -> bool {
        self.resolve_world(transform, footprint, world)
            .is_some_and(|(deck, cell)| self.state(deck, cell).0 != CellState::Visible)
    }

    /// Every live cell — Visible and Heard — with its state. FW.1's
    /// known-twin sync walks this each frame to decide which chunks
    /// re-copy. Cheap: only the (small) live + heard sets. A cell that
    /// has SINCE decayed to Memory keeps its already-copied geometry in
    /// the twin, so it need not reappear here — but see
    /// [`Self::for_each_known_cell`] for a fresh twin.
    pub fn for_each_live_cell(&self, mut f: impl FnMut(usize, IVec2, CellState)) {
        for &(x, y) in self.visible.keys() {
            f(self.visible_deck, IVec2::new(x, y), CellState::Visible);
        }
        for &(deck, x, y) in self.heard_cells.keys() {
            // A cell the active deck also sees is reported once, as
            // Visible (it wins) — skip the Heard duplicate.
            if deck == self.visible_deck && self.visible.contains_key(&(x, y)) {
                continue;
            }
            f(deck, IVec2::new(x, y), CellState::Heard);
        }
    }

    /// Every KNOWN cell — Visible, Memory, or Heard (state != Unseen) —
    /// across all decks. A FRESH twin (first sync after (re)attach — fog
    /// toggled off then on, or re-armed after a load) walks this ONCE so
    /// it copies geometry for REMEMBERED rooms too; otherwise the mask
    /// would say Memory while the new twin holds no geometry there, and
    /// the remembered rooms would render empty. Steady-state syncs use
    /// the cheap [`Self::for_each_live_cell`] (a demoted cell keeps the
    /// copy it got while Visible). Walks the mask tiles, so O(explored).
    pub fn for_each_known_cell(&self, mut f: impl FnMut(usize, IVec2, CellState)) {
        for (deck, layer) in self.layers.iter().enumerate() {
            for (&(tx, ty), tile) in &layer.mask {
                for (idx, &b) in tile.bytes.iter().enumerate() {
                    let state = CellState::from_bits(b >> 6);
                    if state == CellState::Unseen {
                        continue;
                    }
                    let ix = idx as i32 % TILE;
                    let iy = idx as i32 / TILE;
                    f(deck, IVec2::new(tx * TILE + ix, ty * TILE + iy), state);
                }
            }
        }
    }

    /// Raw mask tiles of one deck (tile key = chunk XY index; 128×128
    /// row-major bytes) — the FW.3 GPU upload path.
    pub fn deck_tiles(&self, deck: usize) -> impl Iterator<Item = (IVec2, &[u8])> {
        self.layers.get(deck).into_iter().flat_map(|l| {
            l.mask
                .iter()
                .map(|(&(tx, ty), t)| (IVec2::new(tx, ty), &t.bytes[..]))
        })
    }

    /// FW.3 — flatten the whole mask into a dense deck-major, row-major
    /// byte buffer over the grid-local cell rectangle
    /// `[origin_cell, origin_cell + (width, height))`, for GPU upload.
    /// Cell `(x, y)` on deck `d` lives at
    /// `d*width*height + (y - origin_y)*width + (x - origin_x)`; cells
    /// outside a materialised tile stay `0` (Unseen ⇒ the shader hides
    /// them). The caller sizes the rectangle to the twin's
    /// [`Grid::gpu_residency_hint`] (`origin_chunk * 128`,
    /// `chunks_dims * 128`) so it covers the whole ship. Also returns the
    /// per-deck `(z_top, z_bottom)` bands and styling the shader needs to
    /// reproduce [`FowRender`]'s verdict. Gate uploads on
    /// [`Self::mask_version`].
    #[must_use]
    pub fn gpu_mask(&self, origin_cell: IVec2, width: u32, height: u32) -> GpuFowMask {
        let (w, h) = (width as usize, height as usize);
        let deck_count = self.config.decks.len();
        let mut cells = vec![0u8; deck_count * w * h];
        let tile = TILE;
        for (deck, layer) in self.layers.iter().enumerate() {
            let base = deck * w * h;
            for (&(tx, ty), t) in &layer.mask {
                // Tile's grid-local cell origin, relative to the buffer.
                let tile_x0 = tx * tile - origin_cell.x;
                let tile_y0 = ty * tile - origin_cell.y;
                for iy in 0..tile {
                    let by = tile_y0 + iy;
                    if by < 0 || by >= height as i32 {
                        continue;
                    }
                    for ix in 0..tile {
                        let bx = tile_x0 + ix;
                        if bx < 0 || bx >= width as i32 {
                            continue;
                        }
                        let src = (iy * tile + ix) as usize;
                        let dst = base + (by as usize) * w + bx as usize;
                        cells[dst] = t.bytes[src];
                    }
                }
            }
        }
        GpuFowMask {
            origin_cell: [origin_cell.x, origin_cell.y],
            width,
            height,
            decks: self
                .config
                .decks
                .iter()
                .map(|d| [d.z_top, d.z_bottom])
                .collect(),
            active_deck: self.visible_deck,
            cells,
            memory_dim: self.config.memory_dim,
            memory_desaturate: self.config.memory_desaturate,
            version: self.mask_version,
        }
    }

    /// Advance the fog one tick: recompute LOS if the observer moved /
    /// turned / switched deck or the grid was edited (the
    /// [`Grid::mutation_counter`] key), restamp heard blobs, and step
    /// every fading cell by `dt` seconds.
    pub fn update(&mut self, grid: &Grid, observer: &FowObserver, dt: f32) {
        let mut changed = false;

        // Deck switch: demote the whole visible set of the old deck.
        if observer.deck != self.visible_deck && !self.visible.is_empty() {
            let old = std::mem::take(&mut self.visible);
            let deck = self.visible_deck;
            for (cell, _) in old {
                changed |= self.demote_to_memory(deck, IVec2::new(cell.0, cell.1));
            }
            self.los_key = None;
            self.sprite_epoch = self.sprite_epoch.wrapping_add(1); // visible set emptied
        }
        self.visible_deck = observer.deck;

        // LOS recompute when the key moves.
        if observer.deck < self.config.decks.len() {
            let facing_q = quantize_facing(observer.facing);
            let band = self.config.decks[observer.deck];
            let (eye_lo, eye_hi) = (observer.eye_z - EYE_HALF, observer.eye_z + EYE_HALF);
            let radius = self.config.range.max(self.config.peripheral_range).ceil() as i32;
            let edit_key = local_edit_key(
                grid,
                band,
                eye_lo,
                eye_hi,
                self.config_gen,
                observer.cell,
                radius,
            );
            let key = (
                observer.cell,
                facing_q,
                observer.deck,
                observer.eye_z,
                edit_key,
                self.config_gen,
            );
            if self.los_key != Some(key) {
                self.los_key = Some(key);
                changed |= self.recompute_los(grid, observer);
            }
        } else if !self.visible.is_empty() {
            // Observer off every configured deck: nothing is visible.
            let old = std::mem::take(&mut self.visible);
            for (cell, _) in old {
                changed |= self.demote_to_memory(
                    observer.deck.min(self.layers.len()),
                    IVec2::new(cell.0, cell.1),
                );
            }
            self.sprite_epoch = self.sprite_epoch.wrapping_add(1); // visible set emptied
        }

        changed |= self.update_heard(dt);
        changed |= self.tick_transitions(dt);

        if changed {
            self.mask_version += 1;
        }
    }

    /// Rebuild the visible set via shadowcast; diff against the old
    /// one, stamping states and queueing fades. Returns whether any
    /// mask byte changed.
    fn recompute_los(&mut self, grid: &Grid, observer: &FowObserver) -> bool {
        let deck = observer.deck;
        let band = self.config.decks[deck];
        let mut new_visible: HashMap<(i32, i32), f32> = HashMap::new();
        {
            let layer = &mut self.layers[deck];
            let mut scan = LosScan {
                grid,
                cfg: &self.config,
                band,
                eye_lo: observer.eye_z - EYE_HALF,
                eye_hi: observer.eye_z + EYE_HALF,
                config_gen: self.config_gen,
                layer,
                origin: observer.cell,
                facing: normalize_facing(observer.facing),
                out: &mut new_visible,
                key_memo: None,
            };
            scan.run();
        }

        let mut changed = false;
        // FW.4 — the VISIBLE set is exactly what gates sprite visibility;
        // bump `sprite_epoch` iff its membership changed (a demotion or a
        // new cell), so the GPU sprite cull re-runs then — and NOT on the
        // intensity fades that follow (which leave membership untouched).
        let mut membership_changed = false;
        // Demotions: previously visible, no longer.
        let old = std::mem::take(&mut self.visible);
        for &cell in old.keys() {
            if !new_visible.contains_key(&cell) {
                changed |= self.demote_to_memory(deck, IVec2::new(cell.0, cell.1));
                membership_changed = true;
            }
        }
        // Stamps: state flips to Visible AND intensity snaps to full at
        // once. Visual-pass round 7 (#3): no fade-in — a cell only
        // briefly in the cone (the edge sweeping past as you turn) must
        // still demote at FULL intensity, or it leaves a faint memory
        // streak where the cone edge passed. The fade-in was invisible
        // live anyway (Visible is unstyled); dropping it makes the memory
        // uniform regardless of sweep speed. Any pending decay is
        // cancelled — the cell is fully lit again.
        for &(x, y) in new_visible.keys() {
            if !old.contains_key(&(x, y)) {
                membership_changed = true;
            }
            let cell = IVec2::new(x, y);
            changed |= self.layers[deck].write(cell, pack(CellState::Visible, INTENSITY_MAX));
            self.transitions.remove(&(deck, x, y));
        }
        self.visible = new_visible;
        if membership_changed {
            self.sprite_epoch = self.sprite_epoch.wrapping_add(1);
        }
        changed
    }

    /// Flip a cell to Memory (keeping its intensity) and queue its
    /// decay. No-op on Unseen cells.
    fn demote_to_memory(&mut self, deck: usize, cell: IVec2) -> bool {
        let Some(layer) = self.layers.get_mut(deck) else {
            return false;
        };
        let b = layer.byte(cell);
        if CellState::from_bits(b >> 6) == CellState::Unseen {
            return false;
        }
        let intensity = b & INTENSITY_MAX;
        let changed = layer.write(cell, pack(CellState::Memory, intensity));
        self.transitions
            .entry((deck, cell.x, cell.y))
            .or_insert_with(|| f32::from(intensity));
        changed
    }

    /// Tick blob TTLs, rebuild the heard union only when the blob set
    /// changed (perf: the union carries no `sqrt` — blob cells are
    /// precomputed), then stamp the Heard byte for every union cell the
    /// active-deck LOS pass didn't already claim as Visible.
    fn update_heard(&mut self, dt: f32) -> bool {
        let mut changed = false;
        let before = self.heard.len();
        for blob in &mut self.heard {
            blob.ttl -= dt;
        }
        self.heard.retain(|b| b.ttl > 0.0);
        let expired = self.heard.len() != before;

        // The union depends only on the blob set — rebuild solely when
        // a blob was added (`heard_dirty`) or expired. Visible-priority
        // is NOT baked in here (it changes as the observer moves); it is
        // applied at stamp time below, so union stays blob-only.
        if self.heard_dirty || expired {
            self.heard_dirty = false;
            let mut now: HashMap<(usize, i32, i32), f32> = HashMap::new();
            for blob in &self.heard {
                for &(cell, target) in &blob.cells {
                    let e = now.entry((blob.deck, cell.x, cell.y)).or_insert(0.0);
                    *e = e.max(target);
                }
            }
            // Demote cells that fell out of every blob — but NOT one the
            // just-run LOS pass marked Visible (the player turned toward
            // the noise): stomping it back to Memory left a live cell
            // dead ahead rendering as memory until the observer moved.
            let old = std::mem::take(&mut self.heard_cells);
            for &key in old.keys() {
                if now.contains_key(&key) {
                    continue;
                }
                if key.0 == self.visible_deck && self.visible.contains_key(&(key.1, key.2)) {
                    continue;
                }
                changed |= self.demote_to_memory(key.0, IVec2::new(key.1, key.2));
            }
            self.heard_cells = now;
        }

        // Stamp the Heard byte for union cells (skipping any the active
        // deck currently sees) and queue their fades. Runs every tick so
        // a cell that just left the visible cone reverts Visible→Heard.
        for (&(deck, x, y), &target) in &self.heard_cells {
            if deck == self.visible_deck && self.visible.contains_key(&(x, y)) {
                continue;
            }
            let cell = IVec2::new(x, y);
            let cur = self.layers[deck].byte(cell);
            let intensity = cur & INTENSITY_MAX;
            changed |= self.layers[deck].write(cell, pack(CellState::Heard, intensity));
            if (f32::from(intensity) - target).abs() > SETTLE_EPS {
                self.transitions
                    .entry((deck, x, y))
                    .or_insert_with(|| f32::from(intensity));
            }
        }
        changed
    }

    /// Step every transitioning cell toward its current target.
    fn tick_transitions(&mut self, dt: f32) -> bool {
        if self.transitions.is_empty() {
            return false;
        }
        let cfg = &self.config;
        let mut changed = false;
        let mut settled: Vec<(usize, i32, i32)> = Vec::new();
        let visible_deck = self.visible_deck;
        for (&key, cur) in &mut self.transitions {
            let (deck, x, y) = key;
            let cell = IVec2::new(x, y);
            // Target + rate from current membership.
            let (target, rate) = if deck == visible_deck && self.visible.contains_key(&(x, y)) {
                let t = self.visible[&(x, y)];
                (t, if *cur < t { cfg.fade_in } else { cfg.fade_out })
            } else if let Some(&t) = self.heard_cells.get(&key) {
                (t, if *cur < t { cfg.fade_in } else { cfg.fade_out })
            } else {
                // Memory: fast fall to memory_intensity, then slow
                // decay to memory_floor (0 decay = stop at sustain).
                let sustain = f32::from(cfg.memory_intensity);
                if *cur > sustain {
                    (sustain.max(f32::from(cfg.memory_floor)), cfg.fade_out)
                } else if cfg.memory_decay > 0.0 {
                    (f32::from(cfg.memory_floor).min(*cur), cfg.memory_decay)
                } else {
                    (*cur, f32::INFINITY)
                }
            };

            let step = rate * dt;
            if (*cur - target).abs() <= step.max(SETTLE_EPS) {
                *cur = target;
            } else if *cur < target {
                *cur += step;
            } else {
                *cur -= step;
            }

            let layer = &mut self.layers[deck];
            let b = layer.byte(cell);
            let state = CellState::from_bits(b >> 6);
            let rounded = (cur.round().clamp(0.0, f32::from(INTENSITY_MAX))) as u8;
            changed |= layer.write(cell, pack(state, rounded));
            if (*cur - target).abs() <= SETTLE_EPS {
                // Memory cells settle for good only once fully decayed
                // (or decay is off); live cells settle at their target.
                let memory_pending = state == CellState::Memory
                    && cfg.memory_decay > 0.0
                    && *cur > f32::from(cfg.memory_floor) + SETTLE_EPS;
                if !memory_pending {
                    settled.push(key);
                }
            }
        }
        for key in settled {
            self.transitions.remove(&key);
        }
        changed
    }
}

/// (edit version, materialised?) of a real chunk — the twin's
/// copy-freshness key. Either changing means the twin's copy is stale.
fn chunk_sig_pair(grid: &Grid, idx: IVec3) -> (u64, bool) {
    (grid.chunk_version(idx), grid.chunk(idx).is_some())
}

/// One pending twin copy: (chunk idx, cloned real chunk or `None` if
/// absent, real `(version, present)` signature, first-seen flag).
type TwinCopy = (IVec3, Option<Vxl>, (u64, bool), bool);

/// Full chunk bounding box `(origin_chunk, chunks_dims)` of a grid, for
/// the twin's GPU residency hint — sized to the WHOLE real grid so the
/// twin's pool never aliases as exploration adds chunks. `None` for an
/// empty grid.
fn grid_chunk_bbox(grid: &Grid) -> Option<([i32; 3], [u32; 3])> {
    let mut it = grid.chunks.keys();
    let first = it.next()?;
    let (mut lo, mut hi) = (*first, *first);
    for k in it {
        lo = lo.min(*k);
        hi = hi.max(*k);
    }
    Some((
        [lo.x, lo.y, lo.z],
        [
            (hi.x - lo.x + 1) as u32,
            (hi.y - lo.y + 1) as u32,
            (hi.z - lo.z + 1) as u32,
        ],
    ))
}

/// FW.1 render-config the twin mirrors from the real grid each sync, so
/// the drawn twin looks exactly like the real grid would have (a moving
/// ship, a CA deck clip, LOD / mip overrides). NOT mirrored: the flags
/// (`presentation_only` stays on the twin), streaming, water, bake
/// lights — those are authoring / sim state the twin must never carry.
struct TwinMirror {
    transform: GridTransform,
    render_sky: bool,
    mip_levels_override: Option<u32>,
    lod_thresholds: LodThresholds,
    z_clip: Option<i32>,
}

impl TwinMirror {
    fn read(g: &Grid) -> Self {
        Self {
            transform: g.transform,
            render_sky: g.render_sky,
            mip_levels_override: g.mip_levels_override,
            lod_thresholds: g.lod_thresholds,
            z_clip: g.z_clip,
        }
    }

    fn apply(&self, g: &mut Grid) {
        g.transform = self.transform;
        g.render_sky = self.render_sky;
        g.mip_levels_override = self.mip_levels_override;
        // FW.2 review #3 — the twin keeps the real grid's Near→Mid
        // behaviour (Mid mip is coarse but still marched through the
        // fog-aware DDA), but NEVER reaches the Far tier: Far blits a
        // `BillboardCache` impostor built from the raw twin with no
        // per-cell fog styling, so at Far distance the whole known+unseen
        // ship would flash fully visible — exactly the range where
        // concealment matters most. `r_mid = INFINITY` extends Mid to
        // any distance.
        let mut lod = self.lod_thresholds;
        lod.r_mid = f64::INFINITY;
        g.lod_thresholds = lod;
        g.z_clip = self.z_clip;
    }
}

/// FW.1 — the known-twin binding for one fog-of-war grid (entry-doc
/// decision 1): a second grid registered in the [`Scene`] that holds
/// the *last-seen* copy of the real grid and is what actually renders.
/// The real grid is flagged [`Grid::render_excluded`] (simulated, never
/// drawn); the twin is flagged [`Grid::presentation_only`] (drawn,
/// never queried). [`Self::sync`] copies chunks from real → twin ONLY
/// under currently Visible / Heard cells, so geometry (and its baked
/// light) outside the observer's knowledge stays frozen at what they
/// last saw — "memory" is simply the twin not being updated there.
///
/// v1 sync is **chunk-granular** (entry-doc decision 2): a chunk under
/// any live cell re-copies whenever its real edit version changed, so
/// an edit in the *unseen* part of a partially-seen chunk becomes
/// visible early (bounded by one chunk). The per-column refinement is a
/// deliberate follow-up.
pub struct FowTwin {
    real: GridId,
    twin: GridId,
    /// Per real-chunk `(version, present)` last copied into the twin.
    /// A live chunk re-copies only when this differs.
    copied: HashMap<IVec3, (u64, bool)>,
    /// Quiet-frame gate: `(mask_version, real mutation_counter)` of the
    /// last [`Self::sync`] that ran. Unchanged ⇒ nothing to copy, skip
    /// the whole live-cell rescan.
    last_synced: Option<(u64, u64)>,
}

impl FowTwin {
    /// Register a known twin for `real`: adds a grid mirroring `real`'s
    /// transform, flags `real` [`Grid::render_excluded`] and the twin
    /// [`Grid::presentation_only`], and sizes the twin's GPU residency
    /// hint to the real grid's full chunk bbox (so its slot pool covers
    /// the whole ship from the first upload — no aliasing as rooms are
    /// explored). The twin starts empty (all Unseen); the first
    /// [`Self::sync`] copies what the observer can see.
    ///
    /// # Panics
    /// If `real` is not a registered grid.
    pub fn attach(scene: &mut Scene, real: GridId) -> Self {
        let (transform, hint) = {
            let g = scene
                .grid(real)
                .expect("FowTwin::attach: real grid must be registered");
            (g.transform, grid_chunk_bbox(g))
        };
        let twin = scene.add_grid(transform);
        scene
            .grid_mut(real)
            .expect("real grid just checked")
            .render_excluded = true;
        let t = scene.grid_mut(twin).expect("twin just added");
        t.presentation_only = true;
        t.gpu_residency_hint = hint;
        Self {
            real,
            twin,
            copied: HashMap::new(),
            last_synced: None,
        }
    }

    /// The simulated grid (flagged `render_excluded`).
    #[must_use]
    pub fn real(&self) -> GridId {
        self.real
    }

    /// The rendered twin grid (flagged `presentation_only`).
    #[must_use]
    pub fn twin(&self) -> GridId {
        self.twin
    }

    /// Undo [`Self::attach`]: clear `real`'s `render_excluded` (it
    /// renders normally again) and remove the twin grid. Call before
    /// dropping the fog-of-war for this grid.
    pub fn detach(self, scene: &mut Scene) {
        if let Some(r) = scene.grid_mut(self.real) {
            r.render_excluded = false;
        }
        scene.remove_grid(self.twin);
    }

    /// Advance the twin for the current fog state: mirror the real
    /// grid's render config, then copy-on-first-seen / re-sync every
    /// chunk under a Visible or Heard cell whose real version changed.
    ///
    /// Returns `false` — and does nothing — when either grid is missing
    /// (e.g. after a snapshot load or lockstep rollback: the twin was
    /// derived state and is gone, the real grid loaded with fog off).
    /// A host **must** treat `false` as "re-arm fog-of-war": drop this
    /// binding and [`Self::attach`] a fresh one. `#[must_use]` so the
    /// signal can't be silently dropped.
    ///
    /// Cheap on quiet frames: if neither the mask nor the real grid
    /// changed since the last run it early-outs before the live-cell
    /// rescan.
    #[must_use]
    pub fn sync(&mut self, scene: &mut Scene, fow: &FogOfWar) -> bool {
        // Both grids must still exist — a lost twin means the host has
        // not re-armed after a load/rollback.
        let Some(real_mut) = scene.grid(self.real).map(Grid::mutation_counter) else {
            return false;
        };
        if scene.grid(self.twin).is_none() {
            return false;
        }

        // Quiet-frame early-out: the mask version moves on any
        // visibility/fade change, the mutation counter on any real edit
        // or chunk install/evict — nothing else can change what to copy.
        let key = (fow.mask_version(), real_mut);
        if self.last_synced == Some(key) {
            return true;
        }
        // First sync of a fresh twin (nothing copied yet): walk ALL known
        // cells so REMEMBERED geometry is copied too, not just what's
        // live this frame (#2 — else a fog off/on re-arm renders memory
        // rooms empty). Steady state uses the cheap live-only walk.
        let first_scan = self.last_synced.is_none();
        self.last_synced = Some(key);

        // Phase 1 — read the real grid: mirror, hint, and the copies due
        // (with a first-seen flag: first copy bumps the whole chunk, a
        // re-sync bumps only the edited bbox).
        let (mirror, hint, copies) = {
            let real = scene.grid(self.real).expect("checked above");
            let mirror = TwinMirror::read(real);
            let hint = grid_chunk_bbox(real);
            // Every chunk under a live cell, deduped, with its real sig.
            let mut want: HashMap<IVec3, (u64, bool)> = HashMap::new();
            let decks = &fow.config().decks;
            let mut collect = |deck: usize, cell: IVec2| {
                let Some(band) = decks.get(deck) else {
                    return;
                };
                let (chz_lo, chz_hi) = deck_chz_range(*band);
                let chx = cell.x.div_euclid(TILE);
                let chy = cell.y.div_euclid(TILE);
                for chz in chz_lo..=chz_hi {
                    let idx = IVec3::new(chx, chy, chz);
                    want.entry(idx).or_insert_with(|| chunk_sig_pair(real, idx));
                }
            };
            if first_scan {
                fow.for_each_known_cell(|deck, cell, _| collect(deck, cell));
            } else {
                fow.for_each_live_cell(|deck, cell, _| collect(deck, cell));
            }
            let mut copies: Vec<TwinCopy> = Vec::new();
            for (idx, sig) in want {
                if self.copied.get(&idx) != Some(&sig) {
                    let first_seen = !self.copied.contains_key(&idx);
                    copies.push((idx, real.chunk(idx).cloned(), sig, first_seen));
                }
            }
            (mirror, hint, copies)
        };

        // Phase 1b — drain each copied chunk's accumulated dirty extent
        // from the REAL grid. The real grid never renders, so nothing
        // else consumes its `chunk_dirty` — draining here both feeds the
        // twin's incremental GPU re-upload (edited bbox, not whole
        // chunk) and stops that orphaned map from leaking.
        let extents: Vec<Option<DirtyExtent>> = {
            let real = scene.grid_mut(self.real).expect("checked above");
            copies
                .iter()
                .map(|(idx, _, _, _)| real.take_chunk_dirty(*idx))
                .collect()
        };

        // Phase 2 — write the twin (disjoint borrow).
        let twin = scene.grid_mut(self.twin).expect("checked above");
        mirror.apply(twin);
        twin.gpu_residency_hint = hint;
        let mut any_change = false;
        for ((idx, chunk, sig, first_seen), extent) in copies.into_iter().zip(extents) {
            match chunk {
                Some(vxl) => {
                    twin.chunks.insert(idx, vxl);
                    // First copy = whole chunk is new to the twin (Full);
                    // a re-sync only touched the real edit's bbox.
                    match (first_seen, extent) {
                        (false, Some(DirtyExtent::Bbox(lo, hi))) => {
                            twin.bump_chunk_version_bbox(idx, lo, hi);
                        }
                        _ => twin.bump_chunk_version(idx),
                    }
                    self.copied.insert(idx, sig);
                    any_change = true;
                }
                None => {
                    // Absent in the real grid (evicted, or open space):
                    // KEEP the twin's last-seen copy as MEMORY — never
                    // remove it (that would drop geometry the observer is
                    // looking at) and never bump a phantom version for a
                    // chunk that exists nowhere. Record the sig only if
                    // we actually hold a memory copy, so a genuinely-
                    // empty cell doesn't re-clone every frame.
                    if twin.chunks.contains_key(&idx) {
                        self.copied.insert(idx, sig);
                    }
                }
            }
        }
        if any_change {
            // Invalidate the Far-tier impostor cache like every other
            // chunk-set path (S7.4) — else the twin renders a frozen
            // first-look impostor at distance.
            twin.billboards = None;
        }
        true
    }
}

/// FW.2 — the render-time fog-of-war classifier: wraps a [`FogOfWar`]
/// and answers the [`roxlap_core::dda::FowStyler`] verdict per hit. The
/// scene renderer builds one for the twin grid each frame and hands it
/// to the CPU DDA (`DdaEnv::fow`).
///
/// State → verdict:
/// - **Unseen** ⇒ `Hide` (the marcher treats the cell as air).
/// - **Visible** ⇒ `Show { dynamic: true }`, dimmed toward the memory
///   look at the cone edge (intensity `< max`) so the FOV boundary is a
///   smooth taper, full at the cone centre.
/// - **Memory / Heard** ⇒ `Show { dynamic: false }` (frozen baked look),
///   dimmed by [`VisionConfig::memory_dim`] scaled by the decaying
///   intensity and desaturated by [`VisionConfig::memory_desaturate`].
pub struct FowRender<'a> {
    fow: &'a FogOfWar,
}

/// Visual-pass round 9 (#1): the verdict for an UNSEEN voxel on a deck
/// BELOW the observer — rendered opaque and black (`dim 0`) so the ray
/// STOPS on it (no bright sky-hole down a stairwell, no live "two decks
/// at once") without revealing any of the unexplored deck's detail.
const OCCLUDE_BELOW: roxlap_core::dda::FowVerdict = roxlap_core::dda::FowVerdict::Show {
    dynamic: false,
    dim: 0.0,
    desaturate: 0.0,
};

impl<'a> FowRender<'a> {
    /// Wrap `fow` for a render pass.
    #[must_use]
    pub fn new(fow: &'a FogOfWar) -> Self {
        Self { fow }
    }
}

impl roxlap_core::dda::FowStyler for FowRender<'_> {
    fn verdict(&self, x: i32, y: i32, z: i32) -> roxlap_core::dda::FowVerdict {
        use roxlap_core::dda::FowVerdict;
        let cfg = self.fow.config();
        let active = self.fow.visible_deck();
        // Visual-pass round 9 (#1): classify each voxel by its OWN deck
        // (`deck_for_z`), then gate by that deck's state — round 6's Z
        // WINDOW claimed the whole NEXT deck's band for the active deck,
        // so you saw the deck below LIVE through the floor. `deck_below`
        // = a deck lower than the one you stand on.
        let below = |deck: usize| deck > active;
        let Some(deck) = cfg.deck_for_z(z) else {
            // z in a gap between bands. Below the active floor it's the
            // stair/sub-floor shaft — occlude it dark (see the note on
            // `Unseen` below); above, stay transparent.
            let active_floor = cfg.decks.get(active).map_or(i32::MAX, |b| b.z_bottom);
            return if z > active_floor {
                OCCLUDE_BELOW
            } else {
                FowVerdict::Hide
            };
        };
        let (state, intensity) = self.fow.state(deck, IVec2::new(x, y));
        let t = f32::from(intensity) / f32::from(INTENSITY_MAX);
        match state {
            // Visual-pass round 9 (#1): an UNSEEN voxel on a deck BELOW
            // the one you stand on is occluded OPAQUE-DARK, not made
            // transparent — you must not see down through your own floor
            // into an unexplored basement (that read as "two decks at
            // once", or as a bright sky-hole down the stairwell). Unseen
            // cells on the active deck or ABOVE it stay transparent
            // (`Hide`) so a deck you're under — the flooded-bilge swim,
            // round 8 — still shows through.
            CellState::Unseen if below(deck) => OCCLUDE_BELOW,
            CellState::Unseen => FowVerdict::Hide,
            // A currently-Visible cell is drawn UNSTYLED — full
            // brightness, full colour — so the cone rim / peripheral ring
            // don't read as dim/desaturated smudges (round 6 #3). Only
            // the active deck ever has Visible cells.
            CellState::Visible => FowVerdict::Show {
                dynamic: true,
                dim: 1.0,
                desaturate: 0.0,
            },
            CellState::Memory | CellState::Heard => FowVerdict::Show {
                dynamic: false,
                dim: cfg.memory_dim + (1.0 - cfg.memory_dim) * t,
                desaturate: cfg.memory_desaturate * (1.0 - t),
            },
        }
    }
}

fn normalize_facing(f: Vec2) -> Option<Vec2> {
    let len = f.length();
    if len < 1e-6 {
        None
    } else {
        Some(f / len)
    }
}

/// Facing quantised to one of 2048 buckets `[0, 2048)`, or `i32::MIN`
/// for "no facing" (peripheral-only). The sentinel sits outside the
/// bucket range so a near-zero-angle facing (e.g. `(1, -0.003)`) can
/// never alias it — aliasing froze the cone on/off across the
/// facing↔zero transition. The `rem_euclid` also folds the ±π wrap
/// (bucket 2048 ≡ 0) so opposite-signed representations of the same
/// heading share a bucket.
fn quantize_facing(f: Vec2) -> i32 {
    match normalize_facing(f) {
        None => i32::MIN,
        Some(n) => {
            let ang = f64::from(n.y).atan2(f64::from(n.x));
            let raw = (ang / std::f64::consts::TAU * 2048.0).round() as i32;
            raw.rem_euclid(2048)
        }
    }
}

/// One LOS recompute: recursive shadowcasting (the classic RogueBasin
/// 8-octant algorithm) over the deck's opacity, classifying every
/// LOS-clear cell against the cone/peripheral shape and the light
/// gate.
struct LosScan<'a> {
    grid: &'a Grid,
    cfg: &'a VisionConfig,
    band: DeckBand,
    /// Eye-level opacity band `[eye_lo, eye_hi]`, grid-local — derived
    /// from the observer's `eye_z ± EYE_HALF`, not the deck.
    eye_lo: i32,
    eye_hi: i32,
    config_gen: u64,
    layer: &'a mut DeckLayer,
    origin: IVec2,
    facing: Option<Vec2>,
    out: &'a mut HashMap<(i32, i32), f32>,
    /// Last (tile coords, tile_key) — shadowcasting has strong tile
    /// locality, so this reuses the FNV mix across the run of cells in
    /// the same tile instead of rehashing every chz version per cell.
    key_memo: Option<((i32, i32), u64)>,
}

/// Octant transforms (xx, xy, yx, yy).
const OCTANTS: [[i32; 4]; 8] = [
    [1, 0, 0, 1],
    [0, 1, 1, 0],
    [0, -1, 1, 0],
    [-1, 0, 0, 1],
    [-1, 0, 0, -1],
    [0, -1, -1, 0],
    [0, 1, -1, 0],
    [1, 0, 0, -1],
];

impl LosScan<'_> {
    fn radius(&self) -> i32 {
        self.cfg.range.max(self.cfg.peripheral_range).ceil() as i32
    }

    fn run(&mut self) {
        // The observer's own cell is always visible (gate-exempt: you
        // know where you stand even in the dark).
        self.out
            .insert((self.origin.x, self.origin.y), f32::from(INTENSITY_MAX));
        for m in OCTANTS {
            self.cast(1, 1.0, 0.0, m);
        }
    }

    /// Is LOS blocked at `cell`? Lazily computes + caches the cell's
    /// opacity/light sample.
    fn blocked_at(&mut self, cell: IVec2) -> bool {
        self.sample(cell).0
    }

    /// (blocked, lit factor 0..=1) for `cell`, from the version-keyed
    /// tile cache.
    fn sample(&mut self, cell: IVec2) -> (bool, f32) {
        let ((tx, ty), idx) = split_cell(cell);
        let key = match self.key_memo {
            Some((t, k)) if t == (tx, ty) => k,
            _ => {
                let k = tile_key(
                    self.grid,
                    self.band,
                    self.eye_lo,
                    self.eye_hi,
                    self.config_gen,
                    tx,
                    ty,
                );
                self.key_memo = Some(((tx, ty), k));
                k
            }
        };
        let tile = self
            .layer
            .opacity
            .entry((tx, ty))
            .or_insert_with(|| OpacityTile::new(key));
        if tile.key != key {
            *tile = OpacityTile::new(key);
        }
        let (w, bit) = (idx / 64, 1u64 << (idx % 64));
        if tile.computed[w] & bit == 0 {
            let (blocked, lit) = sample_cell(
                self.grid,
                self.band,
                self.eye_lo,
                self.eye_hi,
                self.cfg.light_gate.as_ref(),
                cell,
            );
            tile.computed[w] |= bit;
            if blocked {
                tile.blocked[w] |= bit;
            }
            tile.lit[idx] = (lit * 255.0).round() as u8;
        }
        (tile.blocked[w] & bit != 0, f32::from(tile.lit[idx]) / 255.0)
    }

    /// Classify an LOS-clear (or wall-face) cell at offset
    /// `(dx, dy)` from the origin and record its target intensity.
    fn visit(&mut self, cell: IVec2, dx: i32, dy: i32) {
        let d = f64::from(dx * dx + dy * dy).sqrt() as f32;
        let taper = self.cfg.edge_taper.max(1.0);
        let mut vis = 0.0f32;
        if d <= self.cfg.peripheral_range {
            vis = ((self.cfg.peripheral_range - d) / taper).clamp(0.0, 1.0);
        }
        if let Some(f) = self.facing {
            if d <= self.cfg.range && d > 0.0 {
                let dir = Vec2::new(dx as f32, dy as f32) / d;
                let ang = dir.dot(f).clamp(-1.0, 1.0).acos();
                if ang <= self.cfg.cone_half_angle {
                    let ang_t = ((self.cfg.cone_half_angle - ang) / self.cfg.cone_taper.max(1e-3))
                        .clamp(0.0, 1.0);
                    let rad_t = ((self.cfg.range - d) / taper).clamp(0.0, 1.0);
                    vis = vis.max(ang_t.min(rad_t));
                }
            }
        }
        if vis <= 0.0 {
            return;
        }
        let lit = self.sample(cell).1;
        vis *= lit;
        if vis <= 0.0 {
            return;
        }
        // Visual-pass round 7 (#3): `vis` (the cone/peripheral/light
        // taper) decides only WHETHER the cell is seen; a seen cell
        // records FULL intensity, not a taper-scaled one. Visible cells
        // are drawn unstyled, so the scaling was invisible live and only
        // shaped the MEMORY a cell became — a cone-edge / fast-swept cell
        // demoted at low intensity and left a faint gradient "развод"
        // where the cone edge had passed. Full intensity → spatially
        // uniform memory; only the temporal decay remains.
        let target = f32::from(INTENSITY_MAX);
        let e = self.out.entry((cell.x, cell.y)).or_insert(0.0);
        *e = e.max(target);
    }

    /// One octant of recursive shadowcasting.
    fn cast(&mut self, row: i32, mut start: f64, end: f64, m: [i32; 4]) {
        if start < end {
            return;
        }
        let radius = self.radius();
        let r2 = i64::from(radius) * i64::from(radius);
        let mut new_start = start;
        let mut blocked = false;
        let mut j = row;
        while j <= radius && !blocked {
            let dy = -j;
            for dx in -j..=0 {
                let l_slope = (f64::from(dx) - 0.5) / (f64::from(dy) + 0.5);
                let r_slope = (f64::from(dx) + 0.5) / (f64::from(dy) - 0.5);
                if start < r_slope {
                    continue;
                }
                if end > l_slope {
                    break;
                }
                let sx = dx * m[0] + dy * m[1];
                let sy = dx * m[2] + dy * m[3];
                let cell = self.origin + IVec2::new(sx, sy);
                if i64::from(dx) * i64::from(dx) + i64::from(dy) * i64::from(dy) <= r2 {
                    self.visit(cell, sx, sy);
                }
                let blk = self.blocked_at(cell);
                if blocked {
                    if blk {
                        new_start = r_slope;
                    } else {
                        blocked = false;
                        start = new_start;
                    }
                } else if blk && j < radius {
                    blocked = true;
                    self.cast(j + 1, start, l_slope, m);
                    new_start = r_slope;
                }
            }
            j += 1;
        }
    }
}

/// Column scan for one cell, returning `(blocked, lit 0..=1)`:
/// - **blocked** — any solid voxel in the eye band `[eye_lo, eye_hi]`
///   (LOS occlusion; the band rides the observer's eye, not the deck);
///   a ceiling / floor voxel outside the band never blocks.
/// - **lit** — with a gate, the gate factor of the **floor** surface:
///   the first solid at or below `eye_lo` scanning down to the deck
///   floor (a ceiling plate above the eye is NOT the surface — reading
///   its dark underside kept fully-lit rooms permanently unseen). An
///   emissive colour key ANYWHERE in the scanned span forces `1.0`
///   (ceiling lamps light their cell) without marking it blocked. No
///   gate ⇒ always `1.0`; no floor found under a gate ⇒ `0.0`.
///
/// Borrows the chunk once per z-layer (`chz`) rather than a per-voxel
/// grid probe — a first-fill of a 128² tile was ~340k `voxel_split` +
/// HashMap lookups.
fn sample_cell(
    grid: &Grid,
    band: DeckBand,
    eye_lo: i32,
    eye_hi: i32,
    gate: Option<&LightGate>,
    cell: IVec2,
) -> (bool, f32) {
    let cs_xy = CHUNK_SIZE_XY as i32;
    let cs_z = crate::CHUNK_SIZE_Z as i32;
    let chx = cell.x.div_euclid(cs_xy);
    let chy = cell.y.div_euclid(cs_xy);
    let ix = cell.x.rem_euclid(cs_xy) as u32;
    let iy = cell.y.rem_euclid(cs_xy) as u32;

    let z_lo = band.z_top.min(eye_lo);
    let z_hi = band.z_bottom.max(eye_hi);

    let mut blocked = false;
    let mut surface: Option<u8> = None;
    let mut lit_override = false;

    let mut cur_chz = i32::MIN;
    let mut chunk: Option<&Vxl> = None;
    for z in z_lo..=z_hi {
        let chz = z.div_euclid(cs_z);
        if chz != cur_chz {
            cur_chz = chz;
            chunk = grid.chunk(IVec3::new(chx, chy, chz));
        }
        let Some(vxl) = chunk else {
            continue;
        };
        let iz = z.rem_euclid(cs_z) as u32;
        if !Grid::chunk_voxel_solid(vxl, UVec3::new(ix, iy, iz)) {
            continue;
        }
        if (eye_lo..=eye_hi).contains(&z) {
            blocked = true;
        }
        if let Some(g) = gate {
            let color = vxl.voxel_color(ix, iy, iz);
            if let Some(c) = color {
                if g.emissive_colors.contains(&c.rgb_part()) {
                    lit_override = true;
                }
            }
            // Floor surface = first solid at or below eye level; skip
            // the ceiling region above the eye.
            if surface.is_none() && z >= eye_lo {
                surface = Some(color.map_or(0x80, |c| (c.0 >> 24) as u8));
            }
        } else if blocked {
            // No gate: once the eye band is occluded there is nothing
            // more to learn from this column.
            return (true, 1.0);
        }
    }

    let lit = match gate {
        None => 1.0,
        Some(_) if lit_override => 1.0,
        Some(g) => surface.map_or(0.0, |b| g.lit_factor(b)),
    };
    (blocked, lit)
}

#[cfg(test)]
mod tests {
    use super::*;
    use crate::GridTransform;
    use roxlap_formats::color::VoxColor;

    const FLOOR_Z: i32 = 100;
    /// Test eye height: `[EYE_Z-EYE_HALF, EYE_Z+EYE_HALF]` = [92, 96],
    /// the old fixed band's centre — 6 voxels above the floor.
    const EYE_Z: i32 = 94;

    fn band() -> DeckBand {
        DeckBand {
            z_top: 80,
            z_bottom: FLOOR_Z,
        }
    }

    /// Flat lit floor `[-64, 63]²` at `FLOOR_Z`, one deck.
    fn open_room() -> Grid {
        let mut g = Grid::new(GridTransform::identity());
        g.set_rect(
            IVec3::new(-64, -64, FLOOR_Z),
            IVec3::new(63, 63, FLOOR_Z),
            Some(VoxColor::rgb(120, 120, 120)),
        );
        g
    }

    fn cfg() -> VisionConfig {
        let mut c = VisionConfig::for_decks(vec![band()]);
        c.range = 40.0;
        c.peripheral_range = 12.0;
        c
    }

    fn observer(cell: IVec2, facing: Vec2) -> FowObserver {
        FowObserver {
            cell,
            facing,
            deck: 0,
            eye_z: EYE_Z,
        }
    }

    /// A wall column blocking the eye band at `(x, y)`.
    fn wall(g: &mut Grid, x: i32, y: i32) {
        g.set_rect(
            IVec3::new(x, y, 88),
            IVec3::new(x, y, FLOOR_Z),
            Some(VoxColor::rgb(200, 60, 60)),
        );
    }

    const SETTLE: f32 = 1000.0;

    #[test]
    fn cone_and_peripheral_classification() {
        let g = open_room();
        let mut fow = FogOfWar::new(cfg());
        fow.update(&g, &observer(IVec2::new(0, 0), Vec2::X), SETTLE);

        // Ahead, inside the cone.
        assert_eq!(fow.state(0, IVec2::new(20, 0)).0, CellState::Visible);
        // Behind, inside the peripheral radius.
        assert_eq!(fow.state(0, IVec2::new(-6, 0)).0, CellState::Visible);
        // Behind, beyond the peripheral radius.
        assert_eq!(fow.state(0, IVec2::new(-25, 0)).0, CellState::Unseen);
        // Ahead but beyond range.
        assert_eq!(fow.state(0, IVec2::new(60, 0)).0, CellState::Unseen);
        // Full intensity well inside the cone.
        assert_eq!(fow.state(0, IVec2::new(20, 0)).1, INTENSITY_MAX);
    }

    #[test]
    fn wall_blocks_line_of_sight() {
        let mut g = open_room();
        for y in -12..=12 {
            wall(&mut g, 15, y);
        }
        let mut fow = FogOfWar::new(cfg());
        fow.update(&g, &observer(IVec2::new(0, 0), Vec2::X), SETTLE);

        // The wall face itself is visible…
        assert_eq!(fow.state(0, IVec2::new(15, 0)).0, CellState::Visible);
        // …the room behind it is not.
        assert_eq!(fow.state(0, IVec2::new(25, 0)).0, CellState::Unseen);
        // Open cells before the wall are visible.
        assert_eq!(fow.state(0, IVec2::new(10, 0)).0, CellState::Visible);
    }

    /// Review #2 — a fresh twin's first sync must repaint remembered
    /// rooms: `for_each_known_cell` reports Memory cells (so their
    /// geometry re-copies), while the steady-state `for_each_live_cell`
    /// does not (a demoted cell keeps the copy it got while Visible).
    #[test]
    fn known_cells_include_memory_live_cells_dont() {
        use std::collections::HashSet;
        let g = open_room();
        let mut fow = FogOfWar::new(cfg());
        // See the +X cells, then turn away so (20, 0) demotes to Memory.
        fow.update(&g, &observer(IVec2::new(0, 0), Vec2::X), SETTLE);
        fow.update(&g, &observer(IVec2::new(0, 0), -Vec2::X), 0.01);
        assert_eq!(fow.state(0, IVec2::new(20, 0)).0, CellState::Memory);

        let mut live = HashSet::new();
        fow.for_each_live_cell(|_d, c, _s| {
            live.insert((c.x, c.y));
        });
        assert!(!live.contains(&(20, 0)), "memory cell is not LIVE");

        let mut known = HashSet::new();
        fow.for_each_known_cell(|_d, c, _s| {
            known.insert((c.x, c.y));
        });
        assert!(known.contains(&(20, 0)), "memory cell IS known");
    }

    #[test]
    fn edit_invalidates_opacity_cache() {
        let mut g = open_room();
        let mut fow = FogOfWar::new(cfg());
        fow.update(&g, &observer(IVec2::new(0, 0), Vec2::X), SETTLE);
        assert_eq!(fow.state(0, IVec2::new(25, 0)).0, CellState::Visible);

        // Build the wall AFTER first sight; the edit bumps chunk
        // versions + the mutation counter, so the same observer pose
        // recomputes against fresh opacity.
        for y in -12..=12 {
            wall(&mut g, 15, y);
        }
        fow.update(&g, &observer(IVec2::new(0, 0), Vec2::X), SETTLE);
        assert_eq!(fow.state(0, IVec2::new(25, 0)).0, CellState::Memory);
        assert_eq!(fow.state(0, IVec2::new(15, 0)).0, CellState::Visible);
    }

    #[test]
    fn memory_decays_to_floor_and_reseeing_resets() {
        let g = open_room();
        let mut c = cfg();
        c.memory_decay = 8.0;
        let floor = c.memory_floor;
        let sustain = c.memory_intensity;
        let mut fow = FogOfWar::new(c);
        let cell = IVec2::new(20, 0);
        fow.update(&g, &observer(IVec2::new(0, 0), Vec2::X), SETTLE);
        assert_eq!(fow.state(0, cell), (CellState::Visible, INTENSITY_MAX));

        // Turn around: the cell leaves the cone and falls to Memory.
        fow.update(&g, &observer(IVec2::new(0, 0), -Vec2::X), 0.05);
        assert_eq!(fow.state(0, cell).0, CellState::Memory);
        let after_fall = fow.state(0, cell).1;
        assert!(after_fall < INTENSITY_MAX);

        // Long fade-out settles at the sustain level, then decay
        // grinds it down to the floor and stops.
        fow.update(&g, &observer(IVec2::new(0, 0), -Vec2::X), 1.0);
        let at_sustain = fow.state(0, cell).1;
        assert!(at_sustain <= sustain);
        fow.update(&g, &observer(IVec2::new(0, 0), -Vec2::X), 30.0);
        assert_eq!(fow.state(0, cell).1, floor);

        // Re-seeing restores full Visible.
        fow.update(&g, &observer(IVec2::new(0, 0), Vec2::X), SETTLE);
        assert_eq!(fow.state(0, cell), (CellState::Visible, INTENSITY_MAX));
    }

    #[test]
    fn visible_snaps_full_then_memory_fades_gradually() {
        // Visual-pass round 7 (#3): a seen cell snaps to FULL intensity
        // in ONE tick (no fade-in) so the memory it later becomes is
        // spatially uniform — a briefly-glimpsed cell can't leave a faint
        // gradient. The gradual fade is now the MEMORY fall-out only.
        let g = open_room();
        let mut fow = FogOfWar::new(cfg());
        let cell = IVec2::new(20, 0);
        // One tiny tick: already fully Visible (was: a partial fade-in).
        fow.update(&g, &observer(IVec2::new(0, 0), Vec2::X), 0.001);
        assert_eq!(fow.state(0, cell), (CellState::Visible, INTENSITY_MAX));
        // Turn away: Memory, and its intensity falls GRADUALLY (fade-out),
        // not instantly, so the memory eases out over time.
        fow.update(&g, &observer(IVec2::new(0, 0), -Vec2::X), 0.05);
        let (state, mid) = fow.state(0, cell);
        assert_eq!(state, CellState::Memory);
        assert!(mid > 0 && mid < INTENSITY_MAX, "mid fade-out, got {mid}");
    }

    #[test]
    fn light_gate_caps_dark_cells() {
        // Lit floor up to x = 9, dark floor beyond (built disjoint —
        // inserting over an existing solid voxel keeps its colour, so
        // an overwrite would silently stay lit).
        let mut g = Grid::new(GridTransform::identity());
        g.set_rect(
            IVec3::new(-64, -64, FLOOR_Z),
            IVec3::new(9, 63, FLOOR_Z),
            Some(VoxColor::rgb(120, 120, 120)),
        );
        g.set_rect(
            IVec3::new(10, -64, FLOOR_Z),
            IVec3::new(63, 63, FLOOR_Z),
            Some(VoxColor::rgb(120, 120, 120).with_brightness(20)),
        );
        // An emissive strip voxel on the dark side.
        let emissive = VoxColor::rgb(80, 255, 160);
        g.set_voxel(
            IVec3::new(30, 5, FLOOR_Z - 1),
            Some(emissive.with_brightness(20)),
        );

        let mut c = cfg();
        c.light_gate = Some(LightGate {
            lit_brightness: 100,
            softness: 0,
            emissive_colors: vec![emissive.rgb_part()],
        });
        let mut fow = FogOfWar::new(c);
        fow.update(&g, &observer(IVec2::new(0, 0), Vec2::X), SETTLE);

        // Lit floor (VoxColor::rgb default brightness 0x80 = 128).
        assert_eq!(fow.state(0, IVec2::new(5, 0)).0, CellState::Visible);
        // Dark floor in the cone stays unknown.
        assert_eq!(fow.state(0, IVec2::new(20, 0)).0, CellState::Unseen);
        // The emissive cell is visible in the dark.
        assert_eq!(fow.state(0, IVec2::new(30, 5)).0, CellState::Visible);
    }

    #[test]
    fn deck_layers_are_independent() {
        let mut g = open_room();
        // A second, lower deck with its own floor.
        g.set_rect(
            IVec3::new(-64, -64, 130),
            IVec3::new(63, 63, 130),
            Some(VoxColor::rgb(90, 90, 140)),
        );
        let lower = DeckBand {
            z_top: 110,
            z_bottom: 130,
        };
        let mut c = cfg();
        c.decks = vec![band(), lower];
        let mut fow = FogOfWar::new(c);

        fow.update(&g, &observer(IVec2::new(0, 0), Vec2::X), SETTLE);
        assert_eq!(fow.state(0, IVec2::new(20, 0)).0, CellState::Visible);
        assert_eq!(fow.state(1, IVec2::new(20, 0)).0, CellState::Unseen);

        // Descend to deck 1: deck 0 demotes to Memory, deck 1 lights up.
        // The eye rides down with the observer (124 ≈ 6 above the lower
        // floor 130), as it would on a real staircase.
        let mut obs = observer(IVec2::new(0, 0), Vec2::X);
        obs.deck = 1;
        obs.eye_z = 124;
        fow.update(&g, &obs, SETTLE);
        assert_eq!(fow.state(0, IVec2::new(20, 0)).0, CellState::Memory);
        assert_eq!(fow.state(1, IVec2::new(20, 0)).0, CellState::Visible);
    }

    #[test]
    fn heard_blob_reveals_behind_wall_then_fades() {
        let mut g = open_room();
        for y in -12..=12 {
            wall(&mut g, 15, y);
        }
        let mut fow = FogOfWar::new(cfg());
        let src = IVec2::new(25, 0);
        fow.update(&g, &observer(IVec2::new(0, 0), Vec2::X), SETTLE);
        assert_eq!(fow.state(0, src).0, CellState::Unseen);

        // A noise behind the wall: revealed without LOS.
        fow.hear(0, src, 1.0);
        fow.update(&g, &observer(IVec2::new(0, 0), Vec2::X), 0.5);
        assert_eq!(fow.state(0, src).0, CellState::Heard);
        assert!(fow.state(0, IVec2::new(27, 2)).1 > 0);

        // Past the TTL the blob expires and the pocket becomes Memory.
        fow.update(&g, &observer(IVec2::new(0, 0), Vec2::X), 2.0);
        assert_eq!(fow.state(0, src).0, CellState::Memory);
    }

    #[test]
    fn mask_version_tracks_changes() {
        let g = open_room();
        let mut fow = FogOfWar::new(cfg());
        let v0 = fow.mask_version();
        fow.update(&g, &observer(IVec2::new(0, 0), Vec2::X), SETTLE);
        let v1 = fow.mask_version();
        assert!(v1 > v0);
        // Same pose, settled fades: nothing changes.
        fow.update(&g, &observer(IVec2::new(0, 0), Vec2::X), 1.0);
        assert_eq!(fow.mask_version(), v1);
    }

    #[test]
    fn live_cells_cover_visible_and_heard() {
        let mut g = open_room();
        for y in -12..=12 {
            wall(&mut g, 15, y);
        }
        let mut fow = FogOfWar::new(cfg());
        fow.hear(0, IVec2::new(25, 0), 0.5);
        fow.update(&g, &observer(IVec2::new(0, 0), Vec2::X), 0.5);
        let mut visible = 0usize;
        let mut heard = 0usize;
        fow.for_each_live_cell(|deck, _, state| {
            assert_eq!(deck, 0);
            match state {
                CellState::Visible => visible += 1,
                CellState::Heard => heard += 1,
                _ => panic!("live cells are Visible or Heard"),
            }
        });
        assert!(visible > 0 && heard > 0);
    }

    // ---- regression tests for the FW.0 review round ----

    /// Bug 1 — the light gate must sample the FLOOR under the eye, not
    /// a ceiling plate above it. A fully-lit floor room with a dark
    /// ceiling stayed permanently Unseen.
    #[test]
    fn light_gate_reads_floor_not_ceiling() {
        let mut g = open_room(); // lit floor at z=100 (brightness 0x80)
                                 // Dark ceiling plate above the eye band (z=85 < eye_top=92)
                                 // over the far half of the room.
        g.set_rect(
            IVec3::new(10, -32, 85),
            IVec3::new(40, 32, 85),
            Some(VoxColor::rgb(120, 120, 120).with_brightness(15)),
        );
        let mut c = cfg();
        c.light_gate = Some(LightGate {
            lit_brightness: 100,
            softness: 0,
            emissive_colors: Vec::new(),
        });
        let mut fow = FogOfWar::new(c);
        fow.update(&g, &observer(IVec2::new(0, 0), Vec2::X), SETTLE);
        // Floor under the dark ceiling is lit → Visible (the ceiling is
        // not the surface the gate reads).
        assert_eq!(fow.state(0, IVec2::new(20, 0)).0, CellState::Visible);
    }

    /// Bug 2 — a full `Grid::bake` rewrites brightness bytes; it must
    /// bump chunk versions so the FW opacity/light cache re-reads.
    #[test]
    fn full_bake_bumps_chunk_version() {
        let g = open_room();
        let (chunk_idx, _) = crate::voxel_split(IVec3::new(0, 0, FLOOR_Z));
        let v0 = g.chunk_version(chunk_idx);
        let mut g = g;
        g.bake(crate::BakeMode::Directional);
        assert!(
            g.chunk_version(chunk_idx) > v0,
            "full bake must bump the version (was {v0})"
        );
    }

    /// Bug 3 — a chunk materialised at version 0 (generation / stream-in
    /// keeps `chunk_version == 0`) must still invalidate the opacity
    /// tile: the key folds in chunk presence, so absent→present flips it
    /// even with no version change.
    #[test]
    fn tile_key_changes_on_materialisation_at_version_zero() {
        let mut g = Grid::new(GridTransform::identity());
        let b = band();
        let (eye_lo, eye_hi) = (EYE_Z - EYE_HALF, EYE_Z + EYE_HALF);
        let k_absent = tile_key(&g, b, eye_lo, eye_hi, 0, 0, 0);
        // Materialise chunk (0,0,0) as empty air — mirrors a stream-in:
        // version stays 0, only presence changes.
        let _ = g.ensure_chunk(IVec3::new(0, 0, 0));
        assert_eq!(g.chunk_version(IVec3::new(0, 0, 0)), 0);
        let k_present = tile_key(&g, b, eye_lo, eye_hi, 0, 0, 0);
        assert_ne!(
            k_absent, k_present,
            "presence must change the tile key at version 0"
        );
    }

    /// Bug 4 — an emissive voxel on the CEILING (above the eye band)
    /// lights its cell without blocking LOS. It used to be treated as a
    /// wall, carving an Unseen wedge behind each ceiling lamp.
    #[test]
    fn ceiling_emissive_lights_without_blocking() {
        let mut g = open_room();
        let emissive = VoxColor::rgb(80, 255, 160);
        // Lamp on the ceiling (z=85, above eye_top=92).
        g.set_voxel(IVec3::new(20, 0, 85), Some(emissive.with_brightness(30)));
        let mut c = cfg();
        c.light_gate = Some(LightGate {
            lit_brightness: 100,
            softness: 0,
            emissive_colors: vec![emissive.rgb_part()],
        });
        let mut fow = FogOfWar::new(c);
        fow.update(&g, &observer(IVec2::new(0, 0), Vec2::X), SETTLE);
        // The lamp cell is lit and does NOT block: a cell behind it
        // stays visible.
        assert_eq!(fow.state(0, IVec2::new(20, 0)).0, CellState::Visible);
        assert_eq!(fow.state(0, IVec2::new(25, 0)).0, CellState::Visible);
    }

    /// Bug 5 — turning toward a heard source must leave the cell
    /// Visible, not have `update_heard` immediately stomp it to Memory.
    #[test]
    fn facing_a_heard_source_stays_visible() {
        let g = open_room();
        let mut fow = FogOfWar::new(cfg());
        let src = IVec2::new(25, 0);
        // Heard while facing away (source behind, outside the cone).
        fow.hear(0, src, 1.0);
        fow.update(&g, &observer(IVec2::new(0, 0), -Vec2::X), 0.1);
        assert_eq!(fow.state(0, src).0, CellState::Heard);
        // Turn toward it (blob still alive): LOS claims it Visible and
        // the heard pass must not overwrite that.
        fow.update(&g, &observer(IVec2::new(0, 0), Vec2::X), 0.1);
        assert_eq!(fow.state(0, src).0, CellState::Visible);
    }

    /// Bug 6 — a near-zero-angle facing must not alias the "no facing"
    /// sentinel: switching from it to zero facing has to recompute LOS.
    #[test]
    fn near_zero_facing_distinct_from_none() {
        let g = open_room();
        let mut fow = FogOfWar::new(cfg());
        let cell = IVec2::new(30, 0); // in cone (range 40), past peripheral (12)
                                      // Facing ≈ -0.003 rad: its old bucket was -1, colliding with the
                                      // sentinel.
        fow.update(
            &g,
            &observer(IVec2::new(0, 0), Vec2::new(1.0, -0.003)),
            SETTLE,
        );
        assert_eq!(fow.state(0, cell).0, CellState::Visible);
        // Drop to no facing: must recompute (key differs) and the cone
        // cell falls out of sight.
        fow.update(&g, &observer(IVec2::new(0, 0), Vec2::ZERO), SETTLE);
        assert_eq!(fow.state(0, cell).0, CellState::Memory);
    }

    /// Perf 1 — a far-side edit outside the view radius must NOT force a
    /// LOS recompute (the key is local now, not the grid-wide mutation
    /// counter).
    #[test]
    fn far_edit_does_not_bump_mask_version() {
        let mut g = open_room();
        let mut fow = FogOfWar::new(cfg());
        fow.update(&g, &observer(IVec2::new(0, 0), Vec2::X), SETTLE);
        let v = fow.mask_version();
        // Edit far outside the radius-40 view (a whole chunk away).
        g.set_voxel(IVec3::new(600, 600, FLOOR_Z), Some(VoxColor::rgb(1, 2, 3)));
        fow.update(&g, &observer(IVec2::new(0, 0), Vec2::X), 0.0);
        assert_eq!(fow.mask_version(), v, "far edit should not recompute LOS");
    }

    // ---- FW.1: known-twin grid ----

    use crate::Scene;
    use glam::DVec3;

    /// Register a real room grid in a fresh scene; return (scene, id).
    fn scene_with_room() -> (Scene, GridId) {
        let mut scene = Scene::new();
        let id = scene.add_grid(GridTransform::identity());
        let g = scene.grid_mut(id).unwrap();
        g.set_rect(
            IVec3::new(-64, -64, FLOOR_Z),
            IVec3::new(63, 63, FLOOR_Z),
            Some(VoxColor::rgb(120, 120, 120)),
        );
        (scene, id)
    }

    /// `attach` must flag the real grid render-excluded and the twin
    /// presentation-only, so render/query iterators split them.
    #[test]
    fn attach_splits_render_and_query_grids() {
        let (mut scene, real) = scene_with_room();
        let twin = FowTwin::attach(&mut scene, real);
        assert!(scene.grid(real).unwrap().render_excluded);
        assert!(scene.grid(twin.twin()).unwrap().presentation_only);

        // Render sees the twin, not the real grid.
        let rendered: Vec<GridId> = scene.render_grids().map(|(id, _)| id).collect();
        assert!(rendered.contains(&twin.twin()));
        assert!(!rendered.contains(&real));

        // Queries see the real grid, not the twin.
        let queried: Vec<GridId> = scene.query_grids().map(|(id, _)| id).collect();
        assert!(queried.contains(&real));
        assert!(!queried.contains(&twin.twin()));
    }

    /// The real grid stays fully solid to raycasts even while excluded
    /// from rendering (sim truth is unchanged).
    #[test]
    fn excluded_real_grid_still_raycasts() {
        let (mut scene, real) = scene_with_room();
        let _twin = FowTwin::attach(&mut scene, real);
        let hit = scene.raycast(
            DVec3::new(0.5, 0.5, FLOOR_Z as f64 - 5.0),
            DVec3::new(0.0, 0.0, 1.0),
            32.0,
        );
        assert!(hit.is_some(), "real grid must still answer raycasts");
    }

    fn fow_deck() -> DeckBand {
        band()
    }

    /// Copy-on-first-seen: a chunk under a Visible cell is copied into
    /// the twin; a never-seen chunk is not.
    #[test]
    fn sync_copies_only_seen_chunks() {
        let (mut scene, real) = scene_with_room();
        let mut twin = FowTwin::attach(&mut scene, real);
        let mut fow = FogOfWar::new({
            let mut c = VisionConfig::for_decks(vec![fow_deck()]);
            c.range = 40.0;
            c.peripheral_range = 12.0;
            c
        });
        // Observer at origin (chunk 0,0,0) facing +X.
        let real_grid = scene.grid(real).unwrap();
        fow.update(real_grid, &observer(IVec2::new(0, 0), Vec2::X), SETTLE);
        assert!(twin.sync(&mut scene, &fow));

        let twin_grid = scene.grid(twin.twin()).unwrap();
        // Seen chunk (0,0,0) copied → floor voxel present.
        assert!(twin_grid.voxel_solid(IVec3::new(20, 0, FLOOR_Z)));
        // A far chunk never in view was never copied.
        assert!(twin_grid.chunk(IVec3::new(4, 4, 0)).is_none());
    }

    /// Edit behind a wall (unseen chunk) must NOT reach the twin until
    /// the observer walks over it.
    #[test]
    fn edit_behind_wall_invisible_until_seen() {
        let (mut scene, real) = scene_with_room();
        // Extend the floor into chunk (1,0,0) so there's geometry to see.
        scene.grid_mut(real).unwrap().set_rect(
            IVec3::new(128, -8, FLOOR_Z),
            IVec3::new(200, 8, FLOOR_Z),
            Some(VoxColor::rgb(120, 120, 120)),
        );
        let mut twin = FowTwin::attach(&mut scene, real);
        let mut fow = FogOfWar::new({
            let mut c = VisionConfig::for_decks(vec![fow_deck()]);
            c.range = 40.0;
            c
        });
        // See only chunk 0.
        fow.update(
            scene.grid(real).unwrap(),
            &observer(IVec2::new(0, 0), Vec2::X),
            SETTLE,
        );
        assert!(twin.sync(&mut scene, &fow));
        assert!(scene
            .grid(twin.twin())
            .unwrap()
            .chunk(IVec3::new(1, 0, 0))
            .is_none());

        // Edit the far (unseen) chunk. Still not in view → twin unchanged.
        scene.grid_mut(real).unwrap().set_voxel(
            IVec3::new(150, 0, FLOOR_Z - 1),
            Some(VoxColor::rgb(255, 0, 0)),
        );
        fow.update(
            scene.grid(real).unwrap(),
            &observer(IVec2::new(0, 0), Vec2::X),
            SETTLE,
        );
        assert!(twin.sync(&mut scene, &fow));
        assert!(
            scene
                .grid(twin.twin())
                .unwrap()
                .chunk(IVec3::new(1, 0, 0))
                .is_none(),
            "unseen edit must not reach the twin"
        );

        // Walk over so the far chunk is in view → now it copies.
        fow.update(
            scene.grid(real).unwrap(),
            &observer(IVec2::new(150, 0), Vec2::X),
            SETTLE,
        );
        assert!(twin.sync(&mut scene, &fow));
        let tg = scene.grid(twin.twin()).unwrap();
        assert!(
            tg.voxel_solid(IVec3::new(150, 0, FLOOR_Z - 1)),
            "walked-over edit now seen"
        );
    }

    /// Re-baking / editing a chunk the observer no longer sees must stay
    /// frozen in the twin (memory holds the last-seen look).
    #[test]
    fn memory_chunk_frozen_after_observer_leaves() {
        let (mut scene, real) = scene_with_room();
        let mut twin = FowTwin::attach(&mut scene, real);
        let mut fow = FogOfWar::new({
            let mut c = VisionConfig::for_decks(vec![fow_deck()]);
            c.range = 40.0;
            c.peripheral_range = 4.0;
            c
        });
        let cell = IVec3::new(20, 0, FLOOR_Z);
        // See it, copy it.
        fow.update(
            scene.grid(real).unwrap(),
            &observer(IVec2::new(0, 0), Vec2::X),
            SETTLE,
        );
        assert!(twin.sync(&mut scene, &fow));
        let seen_color = scene.grid(twin.twin()).unwrap().voxel_color(cell);
        assert!(seen_color.is_some());

        // Turn away (cell → Memory), then repaint the real voxel.
        fow.update(
            scene.grid(real).unwrap(),
            &observer(IVec2::new(0, 0), -Vec2::X),
            0.05,
        );
        scene
            .grid_mut(real)
            .unwrap()
            .set_voxel(cell, Some(VoxColor::rgb(9, 9, 9)));
        fow.update(
            scene.grid(real).unwrap(),
            &observer(IVec2::new(0, 0), -Vec2::X),
            0.05,
        );
        assert!(twin.sync(&mut scene, &fow));

        // Twin still holds the ORIGINAL colour — the edit is unseen.
        assert_eq!(
            scene.grid(twin.twin()).unwrap().voxel_color(cell),
            seen_color,
            "memory geometry must stay frozen"
        );
    }

    /// Documents the accepted v1 leak (entry-doc decision 2): an edit in
    /// the UNSEEN part of a partially-visible chunk reaches the twin,
    /// because sync is chunk-granular.
    #[test]
    fn chunk_granular_sync_leaks_within_a_seen_chunk() {
        let (mut scene, real) = scene_with_room();
        let mut twin = FowTwin::attach(&mut scene, real);
        let mut fow = FogOfWar::new({
            let mut c = VisionConfig::for_decks(vec![fow_deck()]);
            c.range = 20.0; // sees only part of chunk (0,0,0)
            c.peripheral_range = 4.0;
            c
        });
        fow.update(
            scene.grid(real).unwrap(),
            &observer(IVec2::new(0, 0), Vec2::X),
            SETTLE,
        );
        assert!(twin.sync(&mut scene, &fow));

        // Edit a cell in the SAME chunk but outside the 20-cell view.
        let unseen = IVec3::new(60, 60, FLOOR_Z - 1);
        assert_eq!(fow.state(0, IVec2::new(60, 60)).0, CellState::Unseen);
        scene
            .grid_mut(real)
            .unwrap()
            .set_voxel(unseen, Some(VoxColor::rgb(255, 0, 0)));
        // The chunk is still under visible cells → whole-chunk re-copy.
        fow.update(
            scene.grid(real).unwrap(),
            &observer(IVec2::new(0, 0), Vec2::X),
            SETTLE,
        );
        assert!(twin.sync(&mut scene, &fow));
        assert!(
            scene.grid(twin.twin()).unwrap().voxel_solid(unseen),
            "v1 chunk-granular sync copies the whole chunk (accepted leak)"
        );
    }

    /// `detach` restores the real grid and removes the twin.
    #[test]
    fn detach_restores_real_and_removes_twin() {
        let (mut scene, real) = scene_with_room();
        let twin = FowTwin::attach(&mut scene, real);
        let twin_id = twin.twin();
        twin.detach(&mut scene);
        assert!(!scene.grid(real).unwrap().render_excluded);
        assert!(scene.grid(twin_id).is_none());
    }

    /// The twin is derived state — excluded from snapshots (no wire
    /// change); the real grid persists.
    #[test]
    fn twin_excluded_from_snapshot() {
        let (mut scene, real) = scene_with_room();
        let mut twin = FowTwin::attach(&mut scene, real);
        let mut fow = FogOfWar::new({
            let mut c = VisionConfig::for_decks(vec![fow_deck()]);
            c.range = 40.0;
            c
        });
        fow.update(
            scene.grid(real).unwrap(),
            &observer(IVec2::new(0, 0), Vec2::X),
            SETTLE,
        );
        assert!(twin.sync(&mut scene, &fow));
        let snap = scene.to_snapshot();
        // Only the real grid is in the snapshot.
        assert_eq!(snap.grids.len(), 1);
        assert_eq!(snap.grids[0].0, real);
    }

    // ---- FW.1 review round ----

    fn seeing_fow() -> FogOfWar {
        let mut c = VisionConfig::for_decks(vec![fow_deck()]);
        c.range = 40.0;
        c.peripheral_range = 12.0;
        FogOfWar::new(c)
    }

    /// Bug #1/#2 — `attach` sizes the twin's GPU residency hint to the
    /// REAL grid's full chunk bbox (so the pool covers the whole ship,
    /// and the twin registers even while empty).
    #[test]
    fn attach_sets_gpu_residency_hint_to_real_bbox() {
        let (mut scene, real) = scene_with_room();
        // Add a chunk on a higher deck so the bbox spans chz 0..1.
        scene
            .grid_mut(real)
            .unwrap()
            .set_voxel(IVec3::new(10, 10, 260), Some(VoxColor::rgb(1, 2, 3)));
        let twin = FowTwin::attach(&mut scene, real);
        let hint = scene.grid(twin.twin()).unwrap().gpu_residency_hint;
        // The room `[-64, 63]²` spans chunks (-1,-1)..(0,0); the extra
        // voxel at z=260 adds chunk (0,0,1). Bbox origin (-1,-1,0),
        // dims (2,2,2).
        assert_eq!(hint, Some(([-1, -1, 0], [2, 2, 2])));
    }

    /// Bug #3/#7 — evicting a real chunk under a live cell must NOT drop
    /// it from the twin (memory holds the last-seen copy).
    #[test]
    fn real_eviction_keeps_twin_memory() {
        let (mut scene, real) = scene_with_room();
        let mut twin = FowTwin::attach(&mut scene, real);
        let mut fow = seeing_fow();
        fow.update(
            scene.grid(real).unwrap(),
            &observer(IVec2::new(0, 0), Vec2::X),
            SETTLE,
        );
        assert!(twin.sync(&mut scene, &fow));
        assert!(scene
            .grid(twin.twin())
            .unwrap()
            .voxel_solid(IVec3::new(20, 0, FLOOR_Z)));

        // Evict the real chunk (streaming does exactly this: remove +
        // bump the mutation counter) while it's still in view.
        {
            let g = scene.grid_mut(real).unwrap();
            g.chunks.remove(&IVec3::new(0, 0, 0));
            g.note_chunk_set_changed();
        }
        assert!(twin.sync(&mut scene, &fow));
        assert!(
            scene
                .grid(twin.twin())
                .unwrap()
                .voxel_solid(IVec3::new(20, 0, FLOOR_Z)),
            "twin must keep the last-seen copy after real eviction"
        );
    }

    /// Bug #5 — a lost twin (post snapshot-load / rollback) makes sync
    /// return `false` so the host knows to re-arm, instead of silently
    /// no-op'ing.
    #[test]
    fn sync_signals_lost_twin() {
        let (mut scene, real) = scene_with_room();
        let mut twin = FowTwin::attach(&mut scene, real);
        let fow = seeing_fow();
        assert!(twin.sync(&mut scene, &fow));
        // Drop the twin grid (what to_snapshot + load does).
        scene.remove_grid(twin.twin());
        assert!(!twin.sync(&mut scene, &fow), "lost twin must signal re-arm");
    }

    /// Perf P2 — a quiet frame (no mask or real-grid change) does no
    /// work: the twin is not re-bumped.
    #[test]
    fn quiet_frame_skips_resync() {
        let (mut scene, real) = scene_with_room();
        let mut twin = FowTwin::attach(&mut scene, real);
        let mut fow = seeing_fow();
        fow.update(
            scene.grid(real).unwrap(),
            &observer(IVec2::new(0, 0), Vec2::X),
            SETTLE,
        );
        assert!(twin.sync(&mut scene, &fow));
        let after_first = scene.grid(twin.twin()).unwrap().mutation_counter();
        // Same settled pose → mask_version stable, no real edit.
        fow.update(
            scene.grid(real).unwrap(),
            &observer(IVec2::new(0, 0), Vec2::X),
            1.0,
        );
        assert!(twin.sync(&mut scene, &fow));
        assert_eq!(
            scene.grid(twin.twin()).unwrap().mutation_counter(),
            after_first,
            "quiet frame must not re-bump the twin"
        );
    }

    /// Perf P1 — re-syncing an edited in-view chunk bumps the twin with
    /// the edit's BBOX (incremental GPU upload), not a whole-chunk
    /// `Full`.
    #[test]
    fn resync_bumps_twin_with_bbox_not_full() {
        let (mut scene, real) = scene_with_room();
        let mut twin = FowTwin::attach(&mut scene, real);
        let mut fow = seeing_fow();
        fow.update(
            scene.grid(real).unwrap(),
            &observer(IVec2::new(0, 0), Vec2::X),
            SETTLE,
        );
        assert!(twin.sync(&mut scene, &fow));
        // Clear the first-seen (Full) extent.
        let _ = scene
            .grid_mut(twin.twin())
            .unwrap()
            .take_chunk_dirty(IVec3::new(0, 0, 0));

        // A single-voxel edit in the seen chunk.
        scene.grid_mut(real).unwrap().set_voxel(
            IVec3::new(15, 3, FLOOR_Z - 1),
            Some(VoxColor::rgb(255, 0, 0)),
        );
        fow.update(
            scene.grid(real).unwrap(),
            &observer(IVec2::new(0, 0), Vec2::X),
            SETTLE,
        );
        assert!(twin.sync(&mut scene, &fow));
        let extent = scene
            .grid_mut(twin.twin())
            .unwrap()
            .take_chunk_dirty(IVec3::new(0, 0, 0));
        assert!(
            matches!(extent, Some(crate::DirtyExtent::Bbox(_, _))),
            "re-sync should bump a bbox extent, got {extent:?}"
        );
    }

    /// P3 — the exclusion predicates are single-sourced on `Grid`.
    #[test]
    fn exclusion_predicates() {
        let (mut scene, real) = scene_with_room();
        let twin = FowTwin::attach(&mut scene, real);
        assert!(!scene.grid(real).unwrap().renderable());
        assert!(scene.grid(real).unwrap().queryable());
        assert!(scene.grid(twin.twin()).unwrap().renderable());
        assert!(!scene.grid(twin.twin()).unwrap().queryable());
    }

    // ---- FW.2: render-time styling verdicts ----

    #[test]
    fn fow_render_verdict_maps_states() {
        use roxlap_core::dda::{FowStyler, FowVerdict};
        let g = open_room();
        let mut fow = seeing_fow();
        fow.update(&g, &observer(IVec2::new(0, 0), Vec2::X), SETTLE);
        let styler = FowRender::new(&fow);
        let zc = FLOOR_Z - 1; // inside the deck band, above the floor

        // Seen ahead → Show, dynamic on, full (t == 1 at cone centre).
        match styler.verdict(20, 0, zc) {
            FowVerdict::Show {
                dynamic,
                dim,
                desaturate,
            } => {
                assert!(dynamic);
                assert!((dim - 1.0).abs() < 1e-6, "cone-centre dim {dim}");
                assert!(desaturate.abs() < 1e-6);
            }
            FowVerdict::Hide => panic!("expected Show at the cone centre, got Hide"),
        }
        // Never seen behind → Hide.
        assert_eq!(styler.verdict(-30, 0, zc), FowVerdict::Hide);
    }

    #[test]
    fn fow_render_memory_is_baked_and_dim() {
        use roxlap_core::dda::{FowStyler, FowVerdict};
        let g = open_room();
        let mut fow = seeing_fow();
        let zc = FLOOR_Z - 1;
        // See cell (20,0), then turn away so it becomes Memory.
        fow.update(&g, &observer(IVec2::new(0, 0), Vec2::X), SETTLE);
        fow.update(&g, &observer(IVec2::new(0, 0), -Vec2::X), 0.5);
        let styler = FowRender::new(&fow);
        match styler.verdict(20, 0, zc) {
            FowVerdict::Show {
                dynamic,
                dim,
                desaturate,
            } => {
                assert!(!dynamic, "memory must skip the dynamic rig");
                assert!(dim < 1.0, "memory must be dimmed, got {dim}");
                assert!(desaturate > 0.0, "memory desaturated");
            }
            FowVerdict::Hide => panic!("expected Show(memory), got Hide"),
        }
    }

    /// FW.4 — `hides_sprite` shows sprites over Visible cells, hides over
    /// Memory/Unseen, never touches off-footprint points (open space,
    /// review #1), and uses the observer deck for off-deck z (review #6).
    #[test]
    fn hides_sprite_by_cell_state() {
        use glam::DVec3;
        let g = open_room();
        let mut fow = seeing_fow();
        let t = GridTransform::identity();
        let fp = (IVec2::new(-128, -128), IVec2::new(128, 128));
        fow.update(&g, &observer(IVec2::new(0, 0), Vec2::X), SETTLE);
        let at = |x: f64, y: f64| DVec3::new(x, y, (FLOOR_Z - 1) as f64 + 0.5);
        // Seen cell ahead → shown.
        assert!(!fow.hides_sprite(&t, fp, at(20.5, 0.5)));
        // Never-seen cell behind (over the footprint) → hidden.
        assert!(fow.hides_sprite(&t, fp, at(-30.5, 0.5)));
        // OUTSIDE the footprint (open space) → NEVER hidden (review #1).
        assert!(!fow.hides_sprite(&t, fp, at(500.5, 0.5)));
        // Off-deck z over a Visible XY → observer-deck fallback → shown
        // (review #6, no pop-out mid-transit).
        assert!(!fow.hides_sprite(&t, fp, DVec3::new(20.5, 0.5, 300.5)));

        // Turn away: the seen cell becomes Memory → now hidden.
        fow.update(&g, &observer(IVec2::new(0, 0), -Vec2::X), 0.5);
        assert_eq!(fow.state(0, IVec2::new(20, 0)).0, CellState::Memory);
        assert!(
            fow.hides_sprite(&t, fp, at(20.5, 0.5)),
            "memory hides sprites"
        );
    }

    /// FW.4 perf #1 — `sprite_epoch` bumps when the Visible set changes
    /// (a turn) but NOT on an intensity fade (a static settle), so the
    /// GPU sprite cull isn't re-run every fade frame.
    #[test]
    fn sprite_epoch_tracks_visible_set_only() {
        let g = open_room();
        let mut fow = seeing_fow();
        // First sight populates the visible set → epoch moves.
        let e0 = fow.sprite_epoch();
        fow.update(&g, &observer(IVec2::new(0, 0), Vec2::X), 0.01);
        let e1 = fow.sprite_epoch();
        assert!(e1 > e0, "seeing new cells bumps sprite_epoch");
        // Same pose, another tick (intensities still fading) → the
        // Visible set is unchanged, so the epoch holds even though the
        // mask version keeps moving.
        let mv = fow.mask_version();
        fow.update(&g, &observer(IVec2::new(0, 0), Vec2::X), 0.01);
        assert_eq!(fow.sprite_epoch(), e1, "a fade must not bump sprite_epoch");
        assert!(
            fow.mask_version() >= mv,
            "mask_version still tracks the fade"
        );
        // Turning brings new cells into view → epoch moves again.
        fow.update(&g, &observer(IVec2::new(0, 0), Vec2::Y), SETTLE);
        assert!(fow.sprite_epoch() > e1, "a turn bumps sprite_epoch");
    }

    /// FW.4 — `hear_world` stamps a heard blob for an in-footprint
    /// source, and NOTHING for one outside the footprint (review #2).
    #[test]
    fn hear_world_maps_and_stamps() {
        use glam::DVec3;
        let g = open_room();
        let mut fow = seeing_fow();
        let t = GridTransform::identity();
        let fp = (IVec2::new(-128, -128), IVec2::new(128, 128));
        // A noise at grid-local voxel (20, 0, 99) — in band()'s deck.
        assert!(fow.hear_world(&t, fp, DVec3::new(20.5, 0.5, 99.5), 1.0));
        // Observer facing away → (20,0) not Visible; the heard blob wins.
        fow.update(&g, &observer(IVec2::new(0, 0), -Vec2::X), 0.1);
        assert_eq!(fow.state(0, IVec2::new(20, 0)).0, CellState::Heard);
        // A source OUTSIDE the footprint (a passing ship) stamps nothing.
        assert!(!fow.hear_world(&t, fp, DVec3::new(500.5, 500.5, 99.5), 1.0));
    }

    /// FW.3 — `gpu_mask` flattens the sparse per-deck tiles into a dense
    /// deck-major, row-major buffer over the requested rectangle; a seen
    /// cell lands at the right offset, the rest stay Unseen (0).
    #[test]
    fn gpu_mask_flattens_seen_cells() {
        let g = open_room();
        let mut fow = seeing_fow();
        fow.update(&g, &observer(IVec2::new(0, 0), Vec2::X), SETTLE);
        // A window covering cells [0,32)² on the single deck.
        let mask = fow.gpu_mask(IVec2::ZERO, 32, 32);
        assert_eq!(mask.decks.len(), 1);
        assert_eq!(mask.decks[0], [80, FLOOR_Z]); // band()'s z_top/z_bottom
        assert_eq!(mask.cells.len(), 32 * 32);
        // Cell (20,0) was seen (Visible) → state bits 6-7 == 2.
        // Index = deck 0 base + y*width + x = 0 + 0*32 + 20.
        assert_eq!(mask.cells[20] >> 6, 2, "seen cell is Visible");
        // Cell (5, 20) far off the +X cone → Unseen (0).
        assert_eq!(mask.cells[20 * 32 + 5], 0, "unseen cell is 0");
    }

    /// Visual-pass round 6 (#1) — the verdict classifies by the active
    /// deck's Z WINDOW: its ceiling (`z_top`) down through the stair/hole
    /// shaft (to the next deck's floor, or +∞ for the bottom deck). A
    /// stair descending BELOW the band still reads on the deck you stand
    /// on; but a voxel ABOVE the ceiling falls back to strict
    /// `deck_for_z` (Hidden here, a one-deck config) so the column can't
    /// leak. Untracked cells are still gated by the per-(x,y) state.
    #[test]
    fn fow_render_classifies_by_own_deck() {
        use roxlap_core::dda::{FowStyler, FowVerdict};
        let g = open_room();
        let mut fow = seeing_fow();
        fow.update(&g, &observer(IVec2::new(0, 0), Vec2::X), SETTLE);
        let styler = FowRender::new(&fow);
        // (20, 0) is a seen cell on the single deck (band 80..=100): its
        // own-band z shows LIVE.
        assert!(matches!(
            styler.verdict(20, 0, 90),
            FowVerdict::Show { dynamic: true, .. }
        ));
        // z BELOW the deck floor (100) is a sub-floor shaft → occluded
        // opaque-dark (dim 0), NOT shown or made a sky-hole.
        assert_eq!(
            styler.verdict(20, 0, 200),
            FowVerdict::Show {
                dynamic: false,
                dim: 0.0,
                desaturate: 0.0
            }
        );
        // z ABOVE the deck ceiling (< z_top 80) is transparent (Hide).
        assert_eq!(styler.verdict(20, 0, 0), FowVerdict::Hide);
        // An unseen cell on the active deck is transparent, not occluded.
        assert_eq!(styler.verdict(5, 20, 90), FowVerdict::Hide);
    }

    /// Visual-pass round 9 (#1) — a deck BELOW the observer occludes
    /// opaque-dark when unseen (you don't see through your floor); a deck
    /// ABOVE stays transparent (so the deck you're under — the swim —
    /// shows through).
    #[test]
    fn fow_render_below_occludes_above_transparent() {
        use roxlap_core::dda::{FowStyler, FowVerdict};
        let cfg = VisionConfig::for_decks(vec![
            DeckBand {
                z_top: 0,
                z_bottom: 20,
            },
            DeckBand {
                z_top: 30,
                z_bottom: 50,
            },
        ]);
        let mut fow = FogOfWar::new(cfg);
        // Observer on the TOP deck (0, the default), nothing explored.
        // A deck-1 voxel (z=40, BELOW) that's unseen occludes dark…
        assert_eq!(
            FowRender::new(&fow).verdict(0, 0, 40),
            FowVerdict::Show {
                dynamic: false,
                dim: 0.0,
                desaturate: 0.0
            }
        );
        // …while an unseen voxel on the active deck stays transparent.
        assert_eq!(FowRender::new(&fow).verdict(0, 0, 10), FowVerdict::Hide);

        // Descend to deck 1: a deck-0 voxel is now ABOVE → transparent,
        // so a deck overhead never walls the observer in.
        let g = Grid::new(GridTransform::identity());
        let mut obs = observer(IVec2::new(0, 0), Vec2::X);
        obs.deck = 1;
        obs.eye_z = 40;
        fow.update(&g, &obs, SETTLE);
        assert_eq!(FowRender::new(&fow).verdict(9, 9, 10), FowVerdict::Hide);
    }

    /// Review #5 — the Visible→Memory seam is continuous: a cell at full
    /// brightness that just left the cone (state flips to Memory while
    /// intensity is still high) must NOT jump straight to `memory_dim` —
    /// its dim stays near 1.0 and only decays as intensity fades.
    #[test]
    fn fow_render_memory_seam_no_pop() {
        use roxlap_core::dda::{FowStyler, FowVerdict};
        let g = open_room();
        let mut fow = seeing_fow();
        let zc = FLOOR_Z - 1;
        let cell = (20, 0);
        // Fully seen (cone centre, intensity == max).
        fow.update(&g, &observer(IVec2::new(0, 0), Vec2::X), SETTLE);
        let dim_visible = match FowRender::new(&fow).verdict(cell.0, cell.1, zc) {
            FowVerdict::Show { dim, .. } => dim,
            FowVerdict::Hide => panic!("seen cell hidden"),
        };
        assert!((dim_visible - 1.0).abs() < 1e-6);

        // Turn away ONE tiny frame: the cell flips to Memory, intensity
        // still high → dim must be ~continuous with the Visible value,
        // not collapsed to memory_dim.
        fow.update(&g, &observer(IVec2::new(0, 0), -Vec2::X), 0.01);
        assert_eq!(
            fow.state(0, IVec2::new(cell.0, cell.1)).0,
            CellState::Memory
        );
        let dim_memory = match FowRender::new(&fow).verdict(cell.0, cell.1, zc) {
            FowVerdict::Show { dim, dynamic, .. } => {
                assert!(!dynamic, "memory skips the rig");
                dim
            }
            FowVerdict::Hide => panic!("just-seen memory hidden"),
        };
        let memory_dim = fow.config().memory_dim;
        assert!(
            dim_memory > 0.5 * (1.0 + memory_dim),
            "seam pop: dim dropped to {dim_memory} (memory_dim {memory_dim})"
        );
    }

    /// FW.2 review #8 — the composed `fow = Some` wiring must actually
    /// style the twin: an all-Unseen fog HIDES the rendered twin (sky),
    /// a fog that saw the room SHOWS it. (The old test compared two
    /// identical `fow = None` renders and could never fail.)
    #[test]
    fn composed_render_fow_some_hides_unseen_shows_seen() {
        use crate::render::{render_scene_composed_frame, ComposedFrameParams, SceneRenderScratch};
        use roxlap_core::{Camera, OpticastSettings};

        // Real room + twin; sync so the twin actually holds the floor.
        let (mut scene, real) = scene_with_room();
        let mut twin = FowTwin::attach(&mut scene, real);
        let mut seen = seeing_fow();
        seen.update(
            scene.grid(real).unwrap(),
            &observer(IVec2::new(0, 0), Vec2::X),
            SETTLE,
        );
        assert!(twin.sync(&mut scene, &seen));
        let twin_id = twin.twin();

        // Top-down camera over the seen floor cells (~x in 5..30).
        let camera = Camera {
            pos: [18.0, 0.0, 60.0],
            right: [1.0, 0.0, 0.0],
            down: [0.0, 1.0, 0.0],
            forward: [0.0, 0.0, 1.0],
        };
        let (w, h) = (48u32, 48u32);
        let settings = OpticastSettings::for_oracle_framebuffer(w, h);
        let render = |fow: Option<(GridId, &FogOfWar)>, scene: &mut Scene| {
            let mut fb = vec![0u32; (w * h) as usize];
            let mut zb = vec![f32::INFINITY; (w * h) as usize];
            let mut scratch = SceneRenderScratch::default();
            let mut params = ComposedFrameParams::new(&camera, &settings);
            params.fow = fow;
            let _ = render_scene_composed_frame(
                &mut fb,
                &mut zb,
                w as usize,
                w,
                h,
                scene,
                &params,
                &mut scratch,
            );
            fb
        };
        let non_sky = |fb: &[u32]| fb.iter().filter(|&&p| p != 0).count();

        // No fog → the twin's floor draws.
        let base = render(None, &mut scene);
        assert!(non_sky(&base) > 0, "the twin floor must render without fog");

        // Fog that saw this area → still drawn (Visible cells).
        let shown = render(Some((twin_id, &seen)), &mut scene);
        assert!(non_sky(&shown) > 0, "seen cells must stay visible");

        // A fresh, never-updated fog → every cell Unseen → Hide → sky.
        let blank = FogOfWar::new(seeing_fow().config().clone());
        let hidden = render(Some((twin_id, &blank)), &mut scene);
        assert_eq!(non_sky(&hidden), 0, "unseen cells must be hidden (sky)");
    }
}