roboticus_agent/

skills.rs

use std::path::{Path, PathBuf};

use sha2::{Digest, Sha256};

use roboticus_core::{InstructionSkill, Result, RoboticusError, SkillManifest, SkillTrigger};

#[derive(Debug, Clone)]
pub enum LoadedSkill {
    Structured(SkillManifest, String, PathBuf),
    Instruction(InstructionSkill, String, PathBuf),
}

impl LoadedSkill {
    pub fn name(&self) -> &str {
        match self {
            LoadedSkill::Structured(m, _, _) => &m.name,
            LoadedSkill::Instruction(i, _, _) => &i.name,
        }
    }

    pub fn triggers(&self) -> &SkillTrigger {
        match self {
            LoadedSkill::Structured(m, _, _) => &m.triggers,
            LoadedSkill::Instruction(i, _, _) => &i.triggers,
        }
    }

    pub fn hash(&self) -> &str {
        match self {
            LoadedSkill::Structured(_, h, _) | LoadedSkill::Instruction(_, h, _) => h,
        }
    }

    pub fn source_path(&self) -> &Path {
        match self {
            LoadedSkill::Structured(_, _, p) | LoadedSkill::Instruction(_, _, p) => p.as_path(),
        }
    }

    pub fn structured_manifest(&self) -> Option<&SkillManifest> {
        match self {
            LoadedSkill::Structured(m, _, _) => Some(m),
            LoadedSkill::Instruction(_, _, _) => None,
        }
    }

    pub fn description(&self) -> Option<&str> {
        match self {
            LoadedSkill::Structured(m, _, _) => Some(&m.description),
            LoadedSkill::Instruction(i, _, _) => Some(&i.description),
        }
    }

    pub fn version(&self) -> &str {
        match self {
            LoadedSkill::Structured(m, _, _) => &m.version,
            LoadedSkill::Instruction(i, _, _) => &i.version,
        }
    }

    pub fn author(&self) -> &str {
        match self {
            LoadedSkill::Structured(m, _, _) => &m.author,
            LoadedSkill::Instruction(i, _, _) => &i.author,
        }
    }
}

fn content_hash(data: &[u8]) -> String {
    let mut hasher = Sha256::new();
    hasher.update(data);
    format!("{:x}", hasher.finalize())
}

pub struct SkillLoader;

impl SkillLoader {
    pub fn load_from_dir(dir: &Path) -> Result<Vec<LoadedSkill>> {
        let mut skills = Vec::new();

        if !dir.exists() {
            return Ok(skills);
        }

        Self::load_entries(dir, &mut skills)?;

        // Recurse into immediate subdirectories (e.g. learned/, custom/).
        match std::fs::read_dir(dir) {
            Ok(entries) => {
                for entry in entries.flatten() {
                    let path = entry.path();
                    if path.is_dir()
                        && let Err(e) = Self::load_entries(&path, &mut skills)
                    {
                        tracing::warn!(
                            dir = %path.display(),
                            error = %e,
                            "failed to load skills from subdirectory, skipping"
                        );
                    }
                }
            }
            Err(e) => {
                tracing::warn!(
                    dir = %dir.display(),
                    error = %e,
                    "failed to enumerate skill subdirectories"
                );
            }
        }

        Ok(skills)
    }

    /// Load `.toml` and `.md` skill files from a single directory (non-recursive).
    fn load_entries(dir: &Path, skills: &mut Vec<LoadedSkill>) -> Result<()> {
        let entries = std::fs::read_dir(dir)?;

        for entry in entries {
            let entry = entry?;
            let path = entry.path();

            if path.is_file() {
                match path.extension().and_then(|e| e.to_str()) {
                    Some("toml") => {
                        let raw = std::fs::read_to_string(&path)?;
                        let hash = content_hash(raw.as_bytes());
                        let manifest: SkillManifest = toml::from_str(&raw).map_err(|e| {
                            RoboticusError::Skill(format!(
                                "failed to parse {}: {e}",
                                path.display()
                            ))
                        })?;
                        skills.push(LoadedSkill::Structured(manifest, hash, path.clone()));
                    }
                    Some("md") => {
                        let raw = std::fs::read_to_string(&path)?;
                        let hash = content_hash(raw.as_bytes());
                        let skill = parse_instruction_md(&raw, &path)?;
                        skills.push(LoadedSkill::Instruction(skill, hash, path.clone()));
                    }
                    _ => {}
                }
            }
        }

        Ok(())
    }
}

fn parse_instruction_md(content: &str, path: &Path) -> Result<InstructionSkill> {
    let trimmed = content.trim();

    if !trimmed.starts_with("---") {
        return Err(RoboticusError::Skill(format!(
            "no YAML frontmatter in {}",
            path.display()
        )));
    }

    let rest = &trimmed[3..];
    let end = rest.find("---").ok_or_else(|| {
        RoboticusError::Skill(format!("unclosed YAML frontmatter in {}", path.display()))
    })?;

    let yaml_str = &rest[..end];
    let body = rest[end + 3..].trim().to_string();

    #[derive(serde::Deserialize)]
    struct FrontMatter {
        name: String,
        description: String,
        #[serde(default)]
        triggers: SkillTrigger,
        #[serde(default = "default_priority")]
        priority: u32,
        #[serde(default)]
        version: Option<String>,
        #[serde(default)]
        author: Option<String>,
    }

    fn default_priority() -> u32 {
        5
    }

    let fm: FrontMatter = serde_yaml::from_str(yaml_str).map_err(|e| {
        RoboticusError::Skill(format!(
            "invalid YAML frontmatter in {}: {e}",
            path.display()
        ))
    })?;

    Ok(InstructionSkill {
        name: fm.name,
        description: fm.description,
        triggers: fm.triggers,
        priority: fm.priority,
        body,
        version: fm.version.unwrap_or_else(|| "0.0.0".into()),
        author: fm.author.unwrap_or_else(|| "local".into()),
    })
}

pub struct SkillRegistry {
    skills: Vec<LoadedSkill>,
}

impl SkillRegistry {
    pub fn new() -> Self {
        Self { skills: Vec::new() }
    }

    pub fn register(&mut self, skill: LoadedSkill) {
        self.skills.push(skill);
    }

    pub fn match_skills(&self, keywords: &[&str]) -> Vec<&LoadedSkill> {
        self.skills
            .iter()
            .filter(|skill| {
                let triggers = skill.triggers();
                keywords.iter().any(|kw| {
                    let kw_lower = kw.to_lowercase();
                    triggers
                        .keywords
                        .iter()
                        .any(|t| t.to_lowercase().contains(&kw_lower))
                })
            })
            .collect()
    }
}

impl Default for SkillRegistry {
    fn default() -> Self {
        Self::new()
    }
}

#[cfg(test)]
mod tests {
    use super::*;
    use std::fs;

    #[test]
    fn parse_toml_skill_manifest() {
        let dir = tempfile::tempdir().unwrap();
        let toml_content = r#"
name = "code_review"
description = "Reviews code for quality"
kind = "Structured"
priority = 3
risk_level = "Safe"

[triggers]
keywords = ["review", "code"]
tool_names = []
regex_patterns = []
"#;
        fs::write(dir.path().join("code_review.toml"), toml_content).unwrap();

        let skills = SkillLoader::load_from_dir(dir.path()).unwrap();
        assert_eq!(skills.len(), 1);

        match &skills[0] {
            LoadedSkill::Structured(manifest, hash, _) => {
                assert_eq!(manifest.name, "code_review");
                assert_eq!(manifest.priority, 3);
                assert!(!hash.is_empty());
            }
            _ => panic!("expected Structured skill"),
        }
    }

    #[test]
    fn parse_md_instruction_skill() {
        let dir = tempfile::tempdir().unwrap();
        let md_content = r#"---
name: greeting
description: Greets the user warmly
triggers:
  keywords:
    - hello
    - greet
priority: 2
---
Always greet the user with enthusiasm and warmth.
"#;
        fs::write(dir.path().join("greeting.md"), md_content).unwrap();

        let skills = SkillLoader::load_from_dir(dir.path()).unwrap();
        assert_eq!(skills.len(), 1);

        match &skills[0] {
            LoadedSkill::Instruction(skill, hash, _) => {
                assert_eq!(skill.name, "greeting");
                assert_eq!(skill.priority, 2);
                assert!(skill.body.contains("enthusiasm"));
                assert!(!hash.is_empty());
            }
            _ => panic!("expected Instruction skill"),
        }
    }

    #[test]
    fn trigger_matching() {
        let mut registry = SkillRegistry::new();

        let skill_a = LoadedSkill::Instruction(
            InstructionSkill {
                name: "code_review".into(),
                description: "Reviews code".into(),
                triggers: SkillTrigger {
                    keywords: vec!["review".into(), "code".into()],
                    tool_names: vec![],
                    regex_patterns: vec![],
                },
                priority: 5,
                body: "Review the code.".into(),
                version: "0.0.0".into(),
                author: "local".into(),
            },
            "hash_a".into(),
            PathBuf::from("/tmp/hash_a"),
        );

        let skill_b = LoadedSkill::Instruction(
            InstructionSkill {
                name: "deploy".into(),
                description: "Deploys services".into(),
                triggers: SkillTrigger {
                    keywords: vec!["deploy".into(), "release".into()],
                    tool_names: vec![],
                    regex_patterns: vec![],
                },
                priority: 5,
                body: "Deploy the service.".into(),
                version: "0.0.0".into(),
                author: "local".into(),
            },
            "hash_b".into(),
            PathBuf::from("/tmp/hash_b"),
        );

        registry.register(skill_a);
        registry.register(skill_b);

        let matches = registry.match_skills(&["review"]);
        assert_eq!(matches.len(), 1);
        assert_eq!(matches[0].name(), "code_review");

        let matches = registry.match_skills(&["deploy"]);
        assert_eq!(matches.len(), 1);
        assert_eq!(matches[0].name(), "deploy");

        let matches = registry.match_skills(&["unrelated"]);
        assert!(matches.is_empty());
    }

    // ── Coverage for LoadedSkill accessor methods ─────────────────

    #[test]
    fn loaded_skill_structured_accessors() {
        let manifest = SkillManifest {
            name: "code_review".into(),
            description: "Reviews code".into(),
            kind: roboticus_core::SkillKind::Structured,
            priority: 3,
            risk_level: roboticus_core::RiskLevel::Safe,
            triggers: SkillTrigger {
                keywords: vec!["review".into()],
                tool_names: vec![],
                regex_patterns: vec![],
            },
            tool_chain: None,
            policy_overrides: None,
            script_path: None,
            version: "1.0.0".into(),
            author: "tester".into(),
        };
        let skill = LoadedSkill::Structured(
            manifest.clone(),
            "abc123".into(),
            PathBuf::from("/tmp/test.toml"),
        );

        assert_eq!(skill.name(), "code_review");
        assert_eq!(skill.hash(), "abc123");
        assert_eq!(skill.source_path(), Path::new("/tmp/test.toml"));
        assert_eq!(skill.description(), Some("Reviews code"));
        assert!(skill.structured_manifest().is_some());
        assert_eq!(skill.structured_manifest().unwrap().name, "code_review");
        let triggers = skill.triggers();
        assert!(triggers.keywords.contains(&"review".to_string()));
    }

    #[test]
    fn loaded_skill_instruction_accessors() {
        let instr = InstructionSkill {
            name: "greeting".into(),
            description: "Greets user".into(),
            triggers: SkillTrigger {
                keywords: vec!["hello".into()],
                tool_names: vec![],
                regex_patterns: vec![],
            },
            priority: 5,
            body: "Greet warmly.".into(),
            version: "0.0.0".into(),
            author: "local".into(),
        };
        let skill =
            LoadedSkill::Instruction(instr, "def456".into(), PathBuf::from("/tmp/greet.md"));

        assert_eq!(skill.name(), "greeting");
        assert_eq!(skill.hash(), "def456");
        assert_eq!(skill.source_path(), Path::new("/tmp/greet.md"));
        assert_eq!(skill.description(), Some("Greets user"));
        assert!(skill.structured_manifest().is_none());
        let triggers = skill.triggers();
        assert!(triggers.keywords.contains(&"hello".to_string()));
    }

    // ── Coverage for SkillRegistry::default ──────────────────────

    #[test]
    fn skill_registry_default() {
        let registry = SkillRegistry::default();
        assert!(registry.match_skills(&["anything"]).is_empty());
    }

    // ── Coverage for SkillLoader with nonexistent dir ─────────────

    #[test]
    fn skill_loader_nonexistent_dir() {
        let result = SkillLoader::load_from_dir(Path::new("/nonexistent/skills/dir"));
        assert!(result.is_ok());
        assert!(result.unwrap().is_empty());
    }

    // ── Coverage for SkillLoader ignores other file extensions ────

    #[test]
    fn skill_loader_ignores_unknown_extensions() {
        let dir = tempfile::tempdir().unwrap();
        fs::write(dir.path().join("readme.txt"), "just text").unwrap();
        fs::write(dir.path().join("config.json"), "{}").unwrap();
        let skills = SkillLoader::load_from_dir(dir.path()).unwrap();
        assert!(skills.is_empty());
    }

    // ── Coverage for parse_instruction_md error paths ─────────────

    #[test]
    fn parse_instruction_md_no_frontmatter() {
        let content = "This is just plain text without frontmatter.";
        let result = parse_instruction_md(content, Path::new("test.md"));
        assert!(result.is_err());
    }

    #[test]
    fn parse_instruction_md_unclosed_frontmatter() {
        let content = "---\nname: test\n";
        let result = parse_instruction_md(content, Path::new("test.md"));
        assert!(result.is_err());
    }

    #[test]
    fn parse_instruction_md_invalid_yaml() {
        let content = "---\ninvalid: [unclosed\n---\nBody here.";
        let result = parse_instruction_md(content, Path::new("test.md"));
        assert!(result.is_err());
    }

    #[test]
    fn parse_instruction_md_default_priority() {
        let content = "---\nname: test_skill\ndescription: A test\n---\nBody content here.";
        let skill = parse_instruction_md(content, Path::new("test.md")).unwrap();
        assert_eq!(skill.priority, 5); // default_priority()
        assert_eq!(skill.name, "test_skill");
        assert!(skill.body.contains("Body content"));
    }

    // ── Coverage for subdirectory loading ─────────────────────────

    #[test]
    fn skill_loader_recurses_into_subdirectories() {
        let dir = tempfile::tempdir().unwrap();

        // Top-level skill
        let top_md = "---\nname: top_skill\ndescription: Top-level\n---\nTop body.";
        fs::write(dir.path().join("top.md"), top_md).unwrap();

        // Subdirectory skill (simulates learned/)
        let sub_dir = dir.path().join("learned");
        fs::create_dir(&sub_dir).unwrap();
        let sub_md = "---\nname: learned_skill\ndescription: Auto-learned\n---\nLearned body.";
        fs::write(sub_dir.join("auto.md"), sub_md).unwrap();

        let skills = SkillLoader::load_from_dir(dir.path()).unwrap();
        assert_eq!(skills.len(), 2);

        let names: Vec<&str> = skills.iter().map(|s| s.name()).collect();
        assert!(names.contains(&"top_skill"));
        assert!(names.contains(&"learned_skill"));
    }

    #[test]
    fn skill_loader_does_not_recurse_deeper_than_one_level() {
        let dir = tempfile::tempdir().unwrap();
        let nested = dir.path().join("learned").join("nested");
        fs::create_dir_all(&nested).unwrap();
        let deep_md = "---\nname: deep_skill\ndescription: Too deep\n---\nDeep body.";
        fs::write(nested.join("deep.md"), deep_md).unwrap();

        let skills = SkillLoader::load_from_dir(dir.path()).unwrap();
        // Should NOT find the deeply nested skill
        assert!(skills.is_empty());
    }

    // ── Coverage for case-insensitive keyword matching ────────────

    #[test]
    fn trigger_matching_case_insensitive() {
        let mut registry = SkillRegistry::new();
        let skill = LoadedSkill::Instruction(
            InstructionSkill {
                name: "test".into(),
                description: "Test".into(),
                triggers: SkillTrigger {
                    keywords: vec!["Review".into()],
                    tool_names: vec![],
                    regex_patterns: vec![],
                },
                priority: 5,
                body: "test".into(),
                version: "0.0.0".into(),
                author: "local".into(),
            },
            "h".into(),
            PathBuf::from("/tmp/t"),
        );
        registry.register(skill);

        let matches = registry.match_skills(&["REVIEW"]);
        assert_eq!(matches.len(), 1);

        let matches = registry.match_skills(&["review"]);
        assert_eq!(matches.len(), 1);
    }
}