riddle/

scope.rs

use crate::{
    RiddleError,
    core::Core,
    env::{Atom, AtomId, BoolExpr, CommonEnv, Env, ObjectId, Slot, Var},
    language::{ClassDef, ConstructorDef, Expr, FunctionDef, PredicateDef, ProblemDef, Statement, evaluate, execute},
};
use std::{
    cell::RefCell,
    collections::HashMap,
    fmt,
    rc::{Rc, Weak},
};

pub trait Type {
    fn name(&self) -> &str;
    fn full_name(&self) -> String {
        self.name().to_string()
    }
    fn as_class(self: Rc<Self>) -> Option<Rc<dyn Class>> {
        None
    }

    fn new_instance(self: Rc<Self>) -> Slot;
}

pub struct BoolType {
    core: Weak<dyn Core>,
}

impl BoolType {
    /// Creates the built-in boolean type.
    pub fn new(core: Weak<dyn Core>) -> Self {
        Self { core }
    }
}

impl Type for BoolType {
    fn name(&self) -> &str {
        "bool"
    }

    fn new_instance(self: Rc<Self>) -> Slot {
        let var_type = Rc::downgrade(&self);
        Slot::Primitive(Rc::new(BoolExpr::Term { var_type, term: self.core.upgrade().unwrap().new_bool_var() }))
    }
}

pub struct IntType {
    core: Weak<dyn Core>,
}

impl IntType {
    /// Creates the built-in integer type.
    pub fn new(core: Weak<dyn Core>) -> Self {
        Self { core }
    }
}

impl Type for IntType {
    fn name(&self) -> &str {
        "int"
    }

    fn new_instance(self: Rc<Self>) -> Slot {
        self.core.upgrade().unwrap().new_int_var()
    }
}

pub struct RealType {
    core: Weak<dyn Core>,
}

impl RealType {
    /// Creates the built-in real (floating-point) type.
    pub fn new(core: Weak<dyn Core>) -> Self {
        Self { core }
    }
}

impl Type for RealType {
    fn name(&self) -> &str {
        "real"
    }

    fn new_instance(self: Rc<Self>) -> Slot {
        self.core.upgrade().unwrap().new_real_var()
    }
}

pub struct StringType {
    core: Weak<dyn Core>,
}

impl StringType {
    /// Creates the built-in string type.
    pub fn new(core: Weak<dyn Core>) -> Self {
        Self { core }
    }
}

impl Type for StringType {
    fn name(&self) -> &str {
        "string"
    }

    fn new_instance(self: Rc<Self>) -> Slot {
        self.core.upgrade().unwrap().new_string_var()
    }
}

pub struct Field {
    name: String,
    field_type: Vec<String>,
    default: Option<Expr>,
}

impl Field {
    /// Creates a new field descriptor.
    pub fn new(name: String, field_type: Vec<String>, default: Option<Expr>) -> Self {
        Self { name, field_type, default }
    }

    pub fn name(&self) -> &str {
        &self.name
    }

    pub fn field_type(&self) -> &[String] {
        &self.field_type
    }

    pub fn default(&self) -> Option<&Expr> {
        self.default.as_ref()
    }
}

pub trait Scope {
    fn core(&self) -> Rc<dyn Core>;
    fn scope(&self) -> Option<Rc<dyn Scope>>;
    fn as_class(self: Rc<Self>) -> Option<Rc<dyn Class>> {
        None
    }

    fn get_fields(&self) -> Vec<Rc<Field>>;
    fn get_field(&self, name: &str) -> Option<Rc<Field>>;
    fn get_function(&self, name: &str, types: &[Rc<dyn Type>]) -> Option<Rc<Function>>;
    fn get_type(&self, name: &str) -> Option<Rc<dyn Type>>;
    fn get_predicate(&self, name: &str) -> Option<Rc<Predicate>>;
}

pub struct CommonScope {
    core: Weak<dyn Core>,
    scope: Option<Weak<dyn Scope>>,
    fields: RefCell<HashMap<String, Rc<Field>>>,
    functions: RefCell<HashMap<String, Vec<Rc<Function>>>>,
    pub(crate) types: RefCell<HashMap<String, Rc<dyn Type>>>,
    predicates: RefCell<HashMap<String, Rc<Predicate>>>,
}

impl CommonScope {
    /// Creates an empty scope with an optional parent scope.
    pub fn new(core: Weak<dyn Core>, scope: Option<Weak<dyn Scope>>) -> Self {
        Self {
            core,
            scope,
            fields: RefCell::new(HashMap::new()),
            functions: RefCell::new(HashMap::new()),
            types: RefCell::new(HashMap::new()),
            predicates: RefCell::new(HashMap::new()),
        }
    }

    /// Builds a scope populated from a class definition.
    pub fn from_class(parent_scope: Weak<dyn Scope>, class: ClassDef) -> Rc<Self> {
        let scope = Rc::new(Self::new(Rc::downgrade(&parent_scope.upgrade().expect("Scope should be valid when building class scope").core()), Some(parent_scope)));
        let weak_scope = Rc::downgrade(&scope);
        for (field_type, fields) in class.fields {
            for (name, default) in fields {
                scope.fields.borrow_mut().insert(name.clone(), Rc::new(Field { name, field_type: field_type.clone(), default }));
            }
        }
        for function_def in class.functions {
            scope.functions.borrow_mut().entry(function_def.name.clone()).or_default().push(Function::new(weak_scope.clone(), function_def));
        }
        for class_def in class.classes {
            let class_name = class_def.name.clone();
            scope.types.borrow_mut().insert(class_name, CommonClass::new(weak_scope.clone(), class_def));
        }
        for predicate_def in class.predicates {
            scope.predicates.borrow_mut().insert(predicate_def.name.clone(), Predicate::new(weak_scope.clone(), predicate_def));
        }
        scope
    }

    /// Builds a local scope for constructor arguments.
    pub fn from_constructor(parent_scope: Weak<dyn Class>, constructor: ConstructorDef) -> Self {
        let scope = Self::new(Rc::downgrade(&parent_scope.upgrade().expect("Class should be valid when building constructor scope").core()), Some(parent_scope));
        for (arg_type, arg_name) in constructor.args {
            scope.fields.borrow_mut().insert(arg_name.clone(), Rc::new(Field { name: arg_name, field_type: arg_type, default: None }));
        }
        scope
    }

    /// Builds a local scope for function arguments.
    pub fn from_function(parent_scope: Weak<dyn Scope>, function: FunctionDef) -> Self {
        let scope = Self::new(Rc::downgrade(&parent_scope.upgrade().expect("Scope should be valid when building function scope").core()), Some(parent_scope));
        for (arg_type, arg_name) in function.args {
            scope.fields.borrow_mut().insert(arg_name.clone(), Rc::new(Field { name: arg_name, field_type: arg_type, default: None }));
        }
        scope
    }

    /// Builds a local scope for predicate arguments.
    pub fn from_predicate(parent_scope: Weak<dyn Scope>, predicate: PredicateDef) -> Self {
        let scope = Self::new(Rc::downgrade(&parent_scope.upgrade().expect("Scope should be valid when building predicate scope").core()), Some(parent_scope));
        for (arg_type, arg_name) in predicate.args {
            scope.fields.borrow_mut().insert(arg_name.clone(), Rc::new(Field { name: arg_name, field_type: arg_type, default: None }));
        }
        scope
    }

    /// Merges problem-level declarations into this scope.
    pub fn add_problem(self: Rc<Self>, problem: ProblemDef) {
        let scope = Rc::downgrade(&self);
        for function_def in problem.functions {
            self.functions.borrow_mut().entry(function_def.name.clone()).or_default().push(Function::new(scope.clone(), function_def));
        }
        for class_def in problem.classes {
            self.types.borrow_mut().insert(class_def.name.clone(), CommonClass::new(scope.clone(), class_def));
        }
        for predicate_def in problem.predicates {
            self.predicates.borrow_mut().insert(predicate_def.name.clone(), Predicate::new(scope.clone(), predicate_def));
        }
    }
}

impl Scope for CommonScope {
    fn core(&self) -> Rc<dyn Core> {
        self.core.upgrade().expect("Core should never be dropped while scopes exist")
    }

    fn scope(&self) -> Option<Rc<dyn Scope>> {
        self.scope.as_ref()?.upgrade()
    }

    fn get_type(&self, name: &str) -> Option<Rc<dyn Type>> {
        self.types.borrow().get(name).cloned().or_else(|| self.scope()?.get_type(name))
    }

    fn get_predicate(&self, name: &str) -> Option<Rc<Predicate>> {
        self.predicates.borrow().get(name).cloned().or_else(|| self.scope()?.get_predicate(name))
    }

    fn get_fields(&self) -> Vec<Rc<Field>> {
        self.fields.borrow().values().cloned().collect()
    }

    fn get_field(&self, name: &str) -> Option<Rc<Field>> {
        self.fields.borrow().get(name).cloned().or_else(|| self.scope()?.get_field(name))
    }

    fn get_function(&self, name: &str, types: &[Rc<dyn Type>]) -> Option<Rc<Function>> {
        self.functions
            .borrow()
            .get(name)
            .and_then(|functions| {
                functions
                    .iter()
                    .find(|function| {
                        if function.args().len() != types.len() {
                            return false;
                        }
                        for (class, arg_type) in types.iter().zip(function.args().iter().map(|(t, _)| t)) {
                            if !get_type_by_path(self, arg_type).ok().is_some_and(|t| is_assignable_from(&t, class)) {
                                return false;
                            }
                        }
                        true
                    })
                    .cloned()
            })
            .or_else(|| self.scope.as_ref()?.upgrade()?.get_function(name, types))
    }
}

/// Executable constructor declaration.
pub struct Constructor {
    scope: Rc<CommonScope>,
    args: Vec<(Vec<String>, String)>,
    init: Vec<(Vec<String>, Vec<Expr>)>,
    statements: Vec<Statement>,
}

impl Constructor {
    /// Creates a constructor from its parsed definition.
    pub fn new(parent_scope: Weak<dyn Class>, mut constructor: ConstructorDef) -> Self {
        Self {
            args: std::mem::take(&mut constructor.args),
            statements: std::mem::take(&mut constructor.statements),
            init: std::mem::take(&mut constructor.init),
            scope: Rc::new(CommonScope::from_constructor(parent_scope, constructor)),
        }
    }

    pub fn args(&self) -> &[(Vec<String>, String)] {
        &self.args
    }

    pub fn statements(&self) -> &[Statement] {
        &self.statements
    }

    /// Creates a new object instance and runs constructor statements.
    pub fn call(&self, object: ObjectId, args: Vec<Slot>) -> Result<(), RiddleError> {
        if args.len() != self.args.len() {
            return Err(RiddleError::RuntimeError(format!("Expected {} arguments, got {}", self.args.len(), args.len())));
        }
        let obj_env = self.core().get_object(object).ok_or_else(|| RiddleError::NotFound(format!("Object {} not found", *object)))?.as_env().ok_or_else(|| RiddleError::RuntimeError("Object environment not found".into()))?;
        // the context in which the constructor is invoked..
        let constructor_env = Rc::new(CommonEnv::new(Some(obj_env.clone())));
        constructor_env.set("this".to_string(), Slot::ObjectRef(object));
        for ((arg_type, arg_name), arg_value) in self.args.iter().zip(args) {
            let expected_type = get_type_by_path(self.scope.as_ref(), arg_type)?;
            let arg_value_type = match &arg_value {
                Slot::Primitive(p) => p.var_type(),
                Slot::ObjectRef(obj_id) => self.scope.core().get_object(*obj_id).ok_or_else(|| RiddleError::NotFound(format!("Object {}", *obj_id)))?.var_type(),
                Slot::AtomRef(atom_id) => self.scope.core().get_atom(*atom_id).ok_or_else(|| RiddleError::NotFound(format!("Atom {}", *atom_id)))?.var_type(),
            };
            if !is_assignable_from(&expected_type, &arg_value_type) {
                return Err(RiddleError::TypeError(format!("Argument '{}' expected to be of type '{}', got '{}'", arg_name, expected_type.full_name(), arg_value_type.full_name())));
            }
            constructor_env.set(arg_name.clone(), arg_value);
        }

        let class = self.scope.scope.as_ref().and_then(|s| s.upgrade()).and_then(|s| s.as_class()).ok_or_else(|| RiddleError::RuntimeError("Constructor is not defined within a class".into()))?;
        // we first execute parent constructors in declaration order, passing specified arguments or defaults if provided..
        for parent in class.parents() {
            let parent_class = get_type_by_path(self.scope.as_ref(), parent)?.as_class().ok_or_else(|| RiddleError::NotAClass(parent.join(".")))?;
            if let Some((_, init_exprs)) = self.init.iter().find(|(init_field, _)| init_field.iter().map(|s| s.as_str()).eq(parent.iter().map(|s| s.as_str()))) {
                let exprs = init_exprs.iter().map(|e| evaluate(self.scope.as_ref(), constructor_env.clone(), e)).collect::<Result<Vec<_>, _>>()?;
                let types = exprs
                    .iter()
                    .map(|e| match e {
                        Slot::Primitive(p) => Ok(p.var_type()),
                        Slot::ObjectRef(obj_id) => Ok(self.scope.core().get_object(*obj_id).ok_or_else(|| RiddleError::NotFound(format!("Object {}", *obj_id)))?.var_type()),
                        Slot::AtomRef(atom_id) => Ok(self.scope.core().get_atom(*atom_id).ok_or_else(|| RiddleError::NotFound(format!("Atom {}", *atom_id)))?.var_type()),
                    })
                    .collect::<Result<Vec<_>, _>>()?;
                let constructor = parent_class.constructor(&types).ok_or_else(|| RiddleError::NotFound(format!("Constructor for parent class '{}' with specified argument types", parent_class.full_name())))?;
                constructor.call(object, exprs)?;
            } else {
                let constructor = parent_class.constructor(&[]).ok_or_else(|| RiddleError::NotFound(format!("No-arg constructor for parent class '{}'", parent_class.full_name())))?;
                constructor.call(object, vec![])?;
            }
        }

        // we then populate fields declared in this class..
        for field in class.get_fields() {
            let fld_tp = get_type_by_path(self.scope.as_ref(), field.field_type())?;
            if obj_env.get(field.name()).is_none() {
                if let Some(default_expr) = field.default() {
                    let value = evaluate(self.scope.as_ref(), constructor_env.clone(), default_expr)?;
                    let value_type = match &value {
                        Slot::Primitive(p) => p.var_type(),
                        Slot::ObjectRef(obj_id) => self.scope.core().get_object(*obj_id).ok_or_else(|| RiddleError::NotFound(format!("Object {}", *obj_id)))?.var_type(),
                        Slot::AtomRef(atom_id) => self.scope.core().get_atom(*atom_id).ok_or_else(|| RiddleError::NotFound(format!("Atom {}", *atom_id)))?.var_type(),
                    };
                    if !is_assignable_from(&fld_tp, &value_type) {
                        return Err(RiddleError::TypeError(format!("Field '{}' expected to be of type '{}', got '{}'", field.name(), fld_tp.full_name(), value_type.full_name())));
                    }
                    obj_env.set(field.name().to_string(), value);
                } else if let Some(class) = fld_tp.clone().as_class() {
                    let instances = class.instances();
                    if instances.is_empty() {
                        return Err(RiddleError::RuntimeError(format!("No instances found for field '{}' of type '{}'", field.name(), class.full_name())));
                    } else if instances.len() == 1 {
                        obj_env.set(field.name().to_string(), Slot::ObjectRef(instances[0]));
                    } else {
                        obj_env.set(field.name().to_string(), self.scope.clone().core().new_var(class, &instances)?);
                    }
                } else {
                    obj_env.set(field.name().to_string(), fld_tp.clone().new_instance());
                }
            }
        }

        // finally, we execute constructor statements in the context of the new object..
        let scope: Rc<dyn Scope> = self.scope.clone();
        for stmt in &self.statements {
            execute(&scope, constructor_env.clone(), stmt)?;
        }
        Ok(())
    }
}

impl Scope for Constructor {
    fn core(&self) -> Rc<dyn Core> {
        self.scope.core()
    }

    fn scope(&self) -> Option<Rc<dyn Scope>> {
        self.scope.scope()
    }

    fn get_fields(&self) -> Vec<Rc<Field>> {
        self.scope.get_fields()
    }

    fn get_field(&self, name: &str) -> Option<Rc<Field>> {
        self.scope.get_field(name)
    }

    fn get_function(&self, name: &str, types: &[Rc<dyn Type>]) -> Option<Rc<Function>> {
        self.scope.get_function(name, types)
    }

    fn get_type(&self, name: &str) -> Option<Rc<dyn Type>> {
        self.scope.get_type(name)
    }

    fn get_predicate(&self, name: &str) -> Option<Rc<Predicate>> {
        self.scope.get_predicate(name)
    }
}

impl fmt::Display for Constructor {
    fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
        let class_name = self.scope.scope.as_ref().and_then(|s| s.upgrade()).and_then(|s| s.as_class()).map(|c| c.full_name()).unwrap_or_else(|| "<unknown class>".to_string());
        let args = self.args.iter().map(|(t, n)| format!("{} {}", t.join("."), n)).collect::<Vec<_>>().join(", ");
        write!(f, "{}({})", class_name, args)
    }
}

pub struct Function {
    scope: Rc<CommonScope>,
    name: String,
    return_type: Option<Vec<String>>,
    args: Vec<(Vec<String>, String)>,
    statements: Vec<Statement>,
}

impl Function {
    /// Creates a function from its parsed definition.
    pub fn new(parent_scope: Weak<dyn Scope>, mut function: FunctionDef) -> Rc<Self> {
        Rc::new(Self {
            name: std::mem::take(&mut function.name),
            return_type: std::mem::take(&mut function.return_type),
            args: std::mem::take(&mut function.args),
            statements: std::mem::take(&mut function.statements),
            scope: Rc::new(CommonScope::from_function(parent_scope, function)),
        })
    }

    pub fn name(&self) -> &str {
        &self.name
    }

    pub fn return_type(&self) -> Option<&[String]> {
        self.return_type.as_deref()
    }

    pub fn args(&self) -> &[(Vec<String>, String)] {
        &self.args
    }

    pub fn statements(&self) -> &[Statement] {
        &self.statements
    }

    /// Invokes the function in a fresh local environment.
    ///
    /// The call validates argument count and type compatibility, executes all
    /// function statements, and checks the declared return type (if any).
    pub fn call(&self, env: Rc<dyn Env>, args: Vec<Slot>) -> Result<Option<Slot>, RiddleError> {
        if args.len() != self.args.len() {
            return Err(RiddleError::RuntimeError(format!("Expected {} arguments, got {}", self.args.len(), args.len())));
        }
        let function_env = Rc::new(CommonEnv::new(Some(env)));
        for ((arg_type, arg_name), arg_value) in self.args.iter().zip(args) {
            let expected_type = get_type_by_path(self.scope.as_ref(), arg_type)?;
            let arg_value_type = match &arg_value {
                Slot::Primitive(p) => p.var_type(),
                Slot::ObjectRef(obj_id) => self.scope.core().get_object(*obj_id).ok_or_else(|| RiddleError::NotFound(format!("Object {}", *obj_id)))?.var_type(),
                Slot::AtomRef(atom_id) => self.scope.core().get_atom(*atom_id).ok_or_else(|| RiddleError::NotFound(format!("Atom {}", *atom_id)))?.var_type(),
            };
            if !is_assignable_from(&expected_type, &arg_value_type) {
                return Err(RiddleError::TypeError(format!("Argument '{}' expected to be of type '{}', got '{}'", arg_name, expected_type.full_name(), arg_value_type.full_name())));
            }
            function_env.set(arg_name.clone(), arg_value);
        }
        let scope: Rc<dyn Scope> = self.scope.clone();
        for stmt in &self.statements {
            execute(&scope, function_env.clone(), stmt)?;
        }
        if let Some(return_type) = &self.return_type {
            function_env.get("__return").ok_or_else(|| RiddleError::RuntimeError("Function did not set return value".into())).and_then(|ret| {
                let expected_type = get_type_by_path(self.scope.as_ref(), return_type)?;
                let ret_type = match &ret {
                    Slot::Primitive(p) => p.var_type(),
                    Slot::ObjectRef(obj_id) => self.scope.core().get_object(*obj_id).ok_or_else(|| RiddleError::NotFound(format!("Object {}", *obj_id)))?.var_type(),
                    Slot::AtomRef(atom_id) => self.scope.core().get_atom(*atom_id).ok_or_else(|| RiddleError::NotFound(format!("Atom {}", *atom_id)))?.var_type(),
                };
                if !is_assignable_from(&expected_type, &ret_type) { Err(RiddleError::TypeError(format!("Return value expected to be of type '{}', got '{}'", expected_type.full_name(), ret_type.full_name()))) } else { Ok(Some(ret)) }
            })
        } else {
            Ok(None)
        }
    }
}

impl Scope for Function {
    fn core(&self) -> Rc<dyn Core> {
        self.scope.core()
    }

    fn scope(&self) -> Option<Rc<dyn Scope>> {
        self.scope.scope()
    }

    fn get_fields(&self) -> Vec<Rc<Field>> {
        self.scope.get_fields()
    }

    fn get_field(&self, name: &str) -> Option<Rc<Field>> {
        self.scope.get_field(name)
    }

    fn get_function(&self, name: &str, types: &[Rc<dyn Type>]) -> Option<Rc<Function>> {
        self.scope.get_function(name, types)
    }

    fn get_type(&self, name: &str) -> Option<Rc<dyn Type>> {
        self.scope.get_type(name)
    }

    fn get_predicate(&self, name: &str) -> Option<Rc<Predicate>> {
        self.scope.get_predicate(name)
    }
}

/// Class-specific API surface layered on top of type and scope behavior.
pub trait Class: Type + Scope {
    fn parents(&self) -> &[Vec<String>];
    fn constructors(&self) -> Vec<Rc<Constructor>>;
    fn constructor(&self, args: &[Rc<dyn Type>]) -> Option<Rc<Constructor>>;
    fn predicates(&self) -> Vec<Rc<Predicate>>;
    fn classes(&self) -> Vec<Rc<dyn Class>>;
    fn instances(&self) -> Vec<ObjectId>;
    fn add_instance(&self, instance: ObjectId);
}

pub struct CommonClass {
    scope: Rc<CommonScope>,
    name: String,
    parents: Vec<Vec<String>>,
    constructors: RefCell<Vec<Rc<Constructor>>>,
    instances: RefCell<Vec<ObjectId>>,
}

impl CommonClass {
    /// Creates a class type from its parsed definition, including nested members.
    pub fn new(parent_scope: Weak<dyn Scope>, mut class: ClassDef) -> Rc<Self> {
        let name = std::mem::take(&mut class.name);
        let parents = std::mem::take(&mut class.parents);
        let constructors_def = if class.constructors.is_empty() { vec![ConstructorDef { args: Vec::new(), init: Vec::new(), statements: Vec::new() }] } else { std::mem::take(&mut class.constructors) };
        let class = Rc::new(Self {
            name,
            parents,
            constructors: RefCell::new(Vec::new()),
            scope: CommonScope::from_class(parent_scope, class),
            instances: RefCell::new(Vec::new()),
        });
        let weak_class = Rc::downgrade(&class);
        class.constructors.borrow_mut().extend(constructors_def.into_iter().map(|c| Rc::new(Constructor::new(weak_class.clone(), c))));
        class
    }
}

impl Type for CommonClass {
    fn name(&self) -> &str {
        &self.name
    }

    fn full_name(&self) -> String {
        if let Some(scope) = self.scope.scope.as_ref().and_then(|scope| scope.upgrade())
            && let Some(class) = scope.as_class()
        {
            format!("{}.{}", class.full_name(), self.name)
        } else {
            self.name.clone()
        }
    }

    fn as_class(self: Rc<Self>) -> Option<Rc<dyn Class>> {
        Some(self)
    }

    fn new_instance(self: Rc<Self>) -> Slot {
        let instance = self.core().new_object(self.clone());
        self.instances.borrow_mut().push(instance);
        for parent in &self.parents {
            let parent_class = get_type_by_path(self.as_ref(), parent).expect("Parent class should exist").as_class().expect("Parent class should be a class");
            parent_class.add_instance(instance);
        }
        Slot::ObjectRef(instance)
    }
}

impl Scope for CommonClass {
    fn core(&self) -> Rc<dyn Core> {
        self.scope.core()
    }

    fn scope(&self) -> Option<Rc<dyn Scope>> {
        self.scope.scope()
    }

    fn as_class(self: Rc<Self>) -> Option<Rc<dyn Class>> {
        Some(self)
    }

    fn get_fields(&self) -> Vec<Rc<Field>> {
        self.scope.get_fields()
    }

    fn get_field(&self, name: &str) -> Option<Rc<Field>> {
        self.scope.get_field(name)
    }

    fn get_function(&self, name: &str, types: &[Rc<dyn Type>]) -> Option<Rc<Function>> {
        self.scope.get_function(name, types)
    }

    fn get_type(&self, name: &str) -> Option<Rc<dyn Type>> {
        self.scope.get_type(name)
    }

    fn get_predicate(&self, name: &str) -> Option<Rc<Predicate>> {
        self.scope.get_predicate(name)
    }
}

impl Class for CommonClass {
    fn parents(&self) -> &[Vec<String>] {
        &self.parents
    }

    fn constructors(&self) -> Vec<Rc<Constructor>> {
        self.constructors.borrow().clone()
    }

    fn constructor(&self, args: &[Rc<dyn Type>]) -> Option<Rc<Constructor>> {
        self.constructors
            .borrow()
            .iter()
            .find(|c| {
                if c.args().len() != args.len() {
                    return false;
                }
                for ((arg_type, _), tp) in c.args().iter().zip(args.iter()) {
                    if !tp.full_name().split('.').eq(arg_type.iter().map(|s| s.as_str())) {
                        return false;
                    }
                }
                true
            })
            .cloned()
    }

    fn predicates(&self) -> Vec<Rc<Predicate>> {
        self.scope.predicates.borrow().values().cloned().collect()
    }

    fn classes(&self) -> Vec<Rc<dyn Class>> {
        self.scope.types.borrow().values().filter_map(|t| t.clone().as_class()).collect()
    }

    fn instances(&self) -> Vec<ObjectId> {
        self.instances.borrow().clone()
    }

    fn add_instance(&self, instance: ObjectId) {
        self.instances.borrow_mut().push(instance);
    }
}

/// Returns the resulting numeric type for arithmetic terms.
///
/// If all terms are int the result is int, otherwise mixed int/real terms yield
/// real. Any other type combination results in a type error.
pub fn arith_type(cr: &dyn Core, terms: &[Slot]) -> Result<Rc<dyn Type>, RiddleError> {
    let types = terms
        .iter()
        .map(|t| match t {
            Slot::Primitive(p) => Ok(p.var_type()),
            Slot::ObjectRef(obj_id) => Err(RiddleError::TypeError(format!("Expected numeric type, got object reference to object {}", *obj_id))),
            Slot::AtomRef(atom_id) => Err(RiddleError::TypeError(format!("Expected numeric type, got atom reference to atom {}", *atom_id))),
        })
        .collect::<Result<Vec<_>, _>>()?;
    if types.iter().all(|t| t.name() == "int") {
        Ok(cr.get_type("int").expect("int class not found"))
    } else if types.iter().all(|t| t.name() == "int" || t.name() == "real") {
        Ok(cr.get_type("real").expect("real class not found"))
    } else {
        Err(RiddleError::TypeError("Invalid types for arithmetic operation".into()))
    }
}

/// Returns whether a value of source type can be assigned to target.
///
/// The check accepts exact type matches and direct parent/child relationships
/// between class types.
pub fn is_assignable_from(target: &Rc<dyn Type>, source: &Rc<dyn Type>) -> bool {
    if Rc::ptr_eq(target, source) {
        return true;
    }

    if let Some(target_class) = target.clone().as_class()
        && let Some(source_class) = source.clone().as_class()
        && is_subclass_of(source_class.clone(), &target_class.full_name())
    {
        return true;
    }
    false
}

fn is_subclass_of(current_class: Rc<dyn Class>, target_full_name: &str) -> bool {
    for parent_path in current_class.parents() {
        if parent_path.iter().map(|s| s.as_str()).eq(target_full_name.split('.')) {
            return true;
        }
        if let Ok(parent_type) = get_type_by_path(&*current_class, parent_path)
            && let Some(parent_class) = parent_type.as_class()
            && is_subclass_of(parent_class, target_full_name)
        {
            return true;
        }
    }
    false
}

pub struct Predicate {
    scope: CommonScope,
    name: String,
    parents: Vec<Vec<String>>,
    args: Vec<(Vec<String>, String)>,
    statements: Vec<Statement>,
    pub(crate) atoms: RefCell<Vec<AtomId>>,
}

impl Predicate {
    /// Creates a predicate from its parsed definition.
    pub fn new(scope: Weak<dyn Scope>, mut predicate: PredicateDef) -> Rc<Self> {
        Rc::new(Self {
            name: std::mem::take(&mut predicate.name),
            parents: std::mem::take(&mut predicate.parents),
            args: std::mem::take(&mut predicate.args),
            statements: std::mem::take(&mut predicate.statements),
            scope: CommonScope::from_predicate(scope, predicate),
            atoms: RefCell::new(Vec::new()),
        })
    }

    pub fn parents(&self) -> &[Vec<String>] {
        &self.parents
    }

    pub fn args(&self) -> &[(Vec<String>, String)] {
        &self.args
    }

    pub fn statements(&self) -> &[Statement] {
        &self.statements
    }

    /// Executes predicate statements against a concrete atom.
    pub fn call(self: Rc<Self>, atom: Rc<Atom>) -> Result<(), RiddleError> {
        let scope: Rc<dyn Scope> = self.clone();
        for stmt in &self.statements {
            execute(&scope, atom.clone(), stmt)?;
        }
        Ok(())
    }

    pub fn atoms(&self) -> Vec<AtomId> {
        self.atoms.borrow().clone()
    }
}

impl Type for Predicate {
    fn name(&self) -> &str {
        &self.name
    }

    fn new_instance(self: Rc<Self>) -> Slot {
        panic!("Cannot create instance of a predicate")
    }
}

impl Scope for Predicate {
    fn core(&self) -> Rc<dyn Core> {
        self.scope.core()
    }

    fn scope(&self) -> Option<Rc<dyn Scope>> {
        self.scope.scope()
    }

    fn get_fields(&self) -> Vec<Rc<Field>> {
        self.scope.get_fields()
    }

    fn get_field(&self, name: &str) -> Option<Rc<Field>> {
        self.scope.get_field(name)
    }

    fn get_function(&self, name: &str, types: &[Rc<dyn Type>]) -> Option<Rc<Function>> {
        self.scope.get_function(name, types)
    }

    fn get_type(&self, name: &str) -> Option<Rc<dyn Type>> {
        self.scope.get_type(name)
    }

    fn get_predicate(&self, name: &str) -> Option<Rc<Predicate>> {
        self.scope.get_predicate(name)
    }
}

/// Resolves a type by a dotted path-like sequence of names.
///
/// The first segment is looked up in the provided [`Scope`], and each
/// subsequent segment is resolved as a nested type of the previous class.
///
/// # Errors
///
/// Returns:
/// - [`RiddleError::RuntimeError`] if `path` is empty.
/// - [`RiddleError::NotFound`] if any path segment cannot be resolved.
/// - [`RiddleError::NotAClass`] if an intermediate segment does not resolve to a class.
pub fn get_type_by_path(scope: &dyn Scope, path: &[String]) -> Result<Rc<dyn Type>, RiddleError> {
    let (first, rest) = path.split_first().ok_or_else(|| RiddleError::RuntimeError("Empty type path".into()))?;
    rest.iter().try_fold(scope.get_type(first).ok_or_else(|| RiddleError::NotFound(first.clone()))?, |current, part| current.as_class().ok_or_else(|| RiddleError::NotAClass(first.clone()))?.get_type(part).ok_or_else(|| RiddleError::NotFound(format!("Class '{}' in path", part))))
}

/// Resolves a predicate by path.
///
/// All segments except the last are resolved as a type path via
/// [`get_type_by_path`]. The last segment is then looked up as a predicate
/// within the resolved class type.
///
/// # Errors
///
/// Returns:
/// - [`RiddleError::RuntimeError`] if `path` is empty.
/// - Any error returned by [`get_type_by_path`] for the prefix path.
/// - [`RiddleError::NotAClass`] if the resolved type path is not a class.
/// - [`RiddleError::NotFound`] if the final predicate cannot be resolved.
pub fn get_predicate_by_path(scope: &dyn Scope, path: &[String]) -> Result<Rc<Predicate>, RiddleError> {
    let (last, rest) = path.split_last().ok_or_else(|| RiddleError::RuntimeError("Empty predicate path".into()))?;
    if rest.is_empty() {
        scope.get_predicate(last).ok_or_else(|| RiddleError::NotFound(last.clone()))
    } else {
        get_type_by_path(scope, rest)?.as_class().ok_or_else(|| RiddleError::NotAClass(rest.join(".")))?.get_predicate(last).ok_or_else(|| RiddleError::NotFound(format!("Predicate '{}' in path", last)))
    }
}