reddb_server/storage/query/

lexer.rs

//! RQL Lexer
//!
//! Tokenizes RQL (RedDB Query Language) strings for parsing.
//! Supports both SQL-like table queries and Cypher-like graph patterns.
//!
//! # Token Types
//!
//! - Keywords: SELECT, FROM, WHERE, MATCH, RETURN, JOIN, GRAPH, PATH, etc.
//! - Literals: strings, integers, floats, booleans
//! - Identifiers: table names, column names, aliases
//! - Operators: comparison, arithmetic, logical
//! - Graph syntax: arrows (->), edge brackets ([-])

use std::fmt;
use std::iter::Peekable;
use std::str::Chars;

/// Token types for RQL
#[derive(Debug, Clone, PartialEq)]
pub enum Token {
    // Keywords
    Select,
    From,
    Where,
    And,
    Or,
    Not,
    Match,
    Return,
    Join,
    Graph,
    Path,
    To,
    Via,
    On,
    As,
    Is,
    Null,
    Between,
    Like,
    In,
    Order,
    By,
    Asc,
    Desc,
    Nulls,
    First,
    Last,
    Limit,
    Offset,
    Inner,
    Left,
    Right,
    Outer,
    Full,
    Cross,
    Starts,
    Ends,
    With,
    Contains,
    True,
    False,
    Enrich,
    Group,
    Count,
    Sum,
    Avg,
    Min,
    Max,
    Distinct,

    // Vector query keywords
    Vector,
    Search,
    Similar,
    Collection,
    Metric,
    Threshold,
    K,
    Hybrid,
    Fusion,
    Rerank,
    Rrf,
    Intersection,
    Union,
    Recursive,
    All,
    Weight,
    L2,
    Cosine,
    InnerProduct,
    Include,
    Metadata,
    Vectors,

    // DML/DDL keywords
    Insert,
    Into,
    Values,
    Update,
    Set,
    Delete,
    Truncate,
    Create,
    Table,
    Drop,
    Alter,
    Add,
    Column,
    Primary,
    // EXPLAIN ALTER FOR — schema diff command
    Explain,
    For,
    Format,
    Json,
    Key,
    Default,
    Compress,
    Index,
    Unique,
    If,
    Exists,
    Returning,
    Cascade,
    Rename,
    Using,

    // Entity type keywords
    Node,
    Edge,
    Document,
    Kv,

    // Time-series & Queue keywords
    Timeseries,
    Retention,
    Queue,
    Tree,
    Push,
    Pop,
    Peek,
    Purge,
    Ack,
    Nack,
    Priority,

    // Graph command keywords
    Neighborhood,
    ShortestPath,
    Centrality,
    Community,
    Components,
    Cycles,
    Traverse,
    Depth,
    Direction,
    Algorithm,
    Strategy,
    MaxIterations,
    MaxLength,
    Mode,
    Clustering,
    TopologicalSort,
    Properties,
    Text,
    Fuzzy,
    MinScore,

    // Transaction control keywords (Phase 1.1 PG parity)
    Begin,
    Commit,
    Rollback,
    Savepoint,
    Release,
    Start,
    Transaction,
    Work,

    // Maintenance keywords (Phase 1.2 PG parity)
    Vacuum,
    Analyze,

    // Schema + sequence keywords (Phase 1.3 PG parity)
    Schema,
    Sequence,
    Increment,

    // COPY command keywords (Phase 1.5 PG parity)
    Copy,
    Header,
    Delimiter,

    // View keywords (Phase 2.1 PG parity)
    View,
    Materialized,
    Refresh,

    // Partitioning keywords (Phase 2.2 PG parity)
    Partition,
    Range,
    List,
    Hash,
    Attach,
    Detach,
    Of,

    // Row Level Security keywords (Phase 2.5 PG parity)
    Policy,
    Enable,
    Disable,
    Security,
    Row,
    Level,

    // Foreign Data Wrapper keywords (Phase 3.2 PG parity)
    Foreign,
    Server,
    Wrapper,
    Options,
    Data,

    // SESSIONIZE operator (issue #585 slice 8).
    Sessionize,
    Gap,

    // Window OVER-clause keywords (issue #589 slice 7a).
    // Note: PARTITION, RANGE, BETWEEN, ROW already exist for DDL/predicate
    // contexts; reused here in window context.
    Over,
    Rows,
    Preceding,
    Following,
    Unbounded,
    Current,

    // Literals
    String(String),
    Integer(i64),
    Float(f64),
    /// Raw JSON object literal text — produced when the lexer enters JSON
    /// sub-mode at a `{` whose first non-whitespace inner char is `"`,
    /// signalling a standard JSON object. The String holds the verbatim
    /// `{...}` text, including the enclosing braces. The parser hands it
    /// to `parse_json` to materialise a `Value::Json`. See issue #86.
    JsonLiteral(String),

    // Identifiers
    Ident(String),

    // Operators
    Eq,      // =
    Ne,      // <> or !=
    Lt,      // <
    Le,      // <=
    Gt,      // >
    Ge,      // >=
    Plus,    // +
    Minus,   // -
    Star,    // *
    Slash,   // /
    Percent, // %

    // Delimiters
    LParen,   // (
    RParen,   // )
    LBracket, // [
    RBracket, // ]
    LBrace,   // {
    RBrace,   // }
    Comma,    // ,
    Dot,      // .
    Colon,    // :
    Semi,     // ;
    Dollar,   // $
    Question, // ?

    // Named-argument syntax (e.g. `louvain(g, resolution => 0.5)`)
    FatArrow, // =>

    // Graph syntax
    Arrow,      // ->
    ArrowLeft,  // <-
    Dash,       // -
    DotDot,     // ..
    Pipe,       // |
    DoublePipe, // ||

    // End of input
    Eof,
}

impl fmt::Display for Token {
    fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
        match self {
            Token::Select => write!(f, "SELECT"),
            Token::From => write!(f, "FROM"),
            Token::Where => write!(f, "WHERE"),
            Token::And => write!(f, "AND"),
            Token::Or => write!(f, "OR"),
            Token::Not => write!(f, "NOT"),
            Token::Match => write!(f, "MATCH"),
            Token::Return => write!(f, "RETURN"),
            Token::Join => write!(f, "JOIN"),
            Token::Graph => write!(f, "GRAPH"),
            Token::Path => write!(f, "PATH"),
            Token::To => write!(f, "TO"),
            Token::Via => write!(f, "VIA"),
            Token::On => write!(f, "ON"),
            Token::As => write!(f, "AS"),
            Token::Is => write!(f, "IS"),
            Token::Null => write!(f, "NULL"),
            Token::Between => write!(f, "BETWEEN"),
            Token::Like => write!(f, "LIKE"),
            Token::In => write!(f, "IN"),
            Token::Order => write!(f, "ORDER"),
            Token::By => write!(f, "BY"),
            Token::Asc => write!(f, "ASC"),
            Token::Desc => write!(f, "DESC"),
            Token::Nulls => write!(f, "NULLS"),
            Token::First => write!(f, "FIRST"),
            Token::Last => write!(f, "LAST"),
            Token::Limit => write!(f, "LIMIT"),
            Token::Offset => write!(f, "OFFSET"),
            Token::Inner => write!(f, "INNER"),
            Token::Left => write!(f, "LEFT"),
            Token::Right => write!(f, "RIGHT"),
            Token::Outer => write!(f, "OUTER"),
            Token::Full => write!(f, "FULL"),
            Token::Cross => write!(f, "CROSS"),
            Token::Starts => write!(f, "STARTS"),
            Token::Ends => write!(f, "ENDS"),
            Token::With => write!(f, "WITH"),
            Token::Contains => write!(f, "CONTAINS"),
            Token::True => write!(f, "TRUE"),
            Token::False => write!(f, "FALSE"),
            Token::Enrich => write!(f, "ENRICH"),
            Token::Group => write!(f, "GROUP"),
            Token::Count => write!(f, "COUNT"),
            Token::Sum => write!(f, "SUM"),
            Token::Avg => write!(f, "AVG"),
            Token::Min => write!(f, "MIN"),
            Token::Max => write!(f, "MAX"),
            Token::Distinct => write!(f, "DISTINCT"),
            Token::Vector => write!(f, "VECTOR"),
            Token::Search => write!(f, "SEARCH"),
            Token::Similar => write!(f, "SIMILAR"),
            Token::Collection => write!(f, "COLLECTION"),
            Token::Metric => write!(f, "METRIC"),
            Token::Threshold => write!(f, "THRESHOLD"),
            Token::K => write!(f, "K"),
            Token::Hybrid => write!(f, "HYBRID"),
            Token::Fusion => write!(f, "FUSION"),
            Token::Rerank => write!(f, "RERANK"),
            Token::Rrf => write!(f, "RRF"),
            Token::Intersection => write!(f, "INTERSECTION"),
            Token::Union => write!(f, "UNION"),
            Token::Recursive => write!(f, "RECURSIVE"),
            Token::All => write!(f, "ALL"),
            Token::Weight => write!(f, "WEIGHT"),
            Token::L2 => write!(f, "L2"),
            Token::Cosine => write!(f, "COSINE"),
            Token::InnerProduct => write!(f, "INNER_PRODUCT"),
            Token::Include => write!(f, "INCLUDE"),
            Token::Metadata => write!(f, "METADATA"),
            Token::Vectors => write!(f, "VECTORS"),
            Token::Explain => write!(f, "EXPLAIN"),
            Token::For => write!(f, "FOR"),
            Token::Format => write!(f, "FORMAT"),
            Token::Json => write!(f, "JSON"),
            Token::Insert => write!(f, "INSERT"),
            Token::Into => write!(f, "INTO"),
            Token::Values => write!(f, "VALUES"),
            Token::Update => write!(f, "UPDATE"),
            Token::Set => write!(f, "SET"),
            Token::Delete => write!(f, "DELETE"),
            Token::Truncate => write!(f, "TRUNCATE"),
            Token::Create => write!(f, "CREATE"),
            Token::Table => write!(f, "TABLE"),
            Token::Drop => write!(f, "DROP"),
            Token::Alter => write!(f, "ALTER"),
            Token::Add => write!(f, "ADD"),
            Token::Column => write!(f, "COLUMN"),
            Token::Primary => write!(f, "PRIMARY"),
            Token::Key => write!(f, "KEY"),
            Token::Default => write!(f, "DEFAULT"),
            Token::Compress => write!(f, "COMPRESS"),
            Token::Index => write!(f, "INDEX"),
            Token::Unique => write!(f, "UNIQUE"),
            Token::If => write!(f, "IF"),
            Token::Exists => write!(f, "EXISTS"),
            Token::Returning => write!(f, "RETURNING"),
            Token::Cascade => write!(f, "CASCADE"),
            Token::Rename => write!(f, "RENAME"),
            Token::Using => write!(f, "USING"),
            Token::Node => write!(f, "NODE"),
            Token::Edge => write!(f, "EDGE"),
            Token::Document => write!(f, "DOCUMENT"),
            Token::Kv => write!(f, "KV"),
            Token::Timeseries => write!(f, "TIMESERIES"),
            Token::Retention => write!(f, "RETENTION"),
            Token::Queue => write!(f, "QUEUE"),
            Token::Tree => write!(f, "TREE"),
            Token::Push => write!(f, "PUSH"),
            Token::Pop => write!(f, "POP"),
            Token::Peek => write!(f, "PEEK"),
            Token::Purge => write!(f, "PURGE"),
            Token::Ack => write!(f, "ACK"),
            Token::Nack => write!(f, "NACK"),
            Token::Priority => write!(f, "PRIORITY"),
            Token::Neighborhood => write!(f, "NEIGHBORHOOD"),
            Token::ShortestPath => write!(f, "SHORTEST_PATH"),
            Token::Centrality => write!(f, "CENTRALITY"),
            Token::Community => write!(f, "COMMUNITY"),
            Token::Components => write!(f, "COMPONENTS"),
            Token::Cycles => write!(f, "CYCLES"),
            Token::Traverse => write!(f, "TRAVERSE"),
            Token::Depth => write!(f, "DEPTH"),
            Token::Direction => write!(f, "DIRECTION"),
            Token::Algorithm => write!(f, "ALGORITHM"),
            Token::Strategy => write!(f, "STRATEGY"),
            Token::MaxIterations => write!(f, "MAX_ITERATIONS"),
            Token::MaxLength => write!(f, "MAX_LENGTH"),
            Token::Mode => write!(f, "MODE"),
            Token::Clustering => write!(f, "CLUSTERING"),
            Token::TopologicalSort => write!(f, "TOPOLOGICAL_SORT"),
            Token::Properties => write!(f, "PROPERTIES"),
            Token::Text => write!(f, "TEXT"),
            Token::Fuzzy => write!(f, "FUZZY"),
            Token::MinScore => write!(f, "MIN_SCORE"),
            Token::Begin => write!(f, "BEGIN"),
            Token::Commit => write!(f, "COMMIT"),
            Token::Rollback => write!(f, "ROLLBACK"),
            Token::Savepoint => write!(f, "SAVEPOINT"),
            Token::Release => write!(f, "RELEASE"),
            Token::Start => write!(f, "START"),
            Token::Transaction => write!(f, "TRANSACTION"),
            Token::Work => write!(f, "WORK"),
            Token::Vacuum => write!(f, "VACUUM"),
            Token::Analyze => write!(f, "ANALYZE"),
            Token::Schema => write!(f, "SCHEMA"),
            Token::Sequence => write!(f, "SEQUENCE"),
            Token::Increment => write!(f, "INCREMENT"),
            Token::Copy => write!(f, "COPY"),
            Token::Header => write!(f, "HEADER"),
            Token::Delimiter => write!(f, "DELIMITER"),
            Token::View => write!(f, "VIEW"),
            Token::Materialized => write!(f, "MATERIALIZED"),
            Token::Refresh => write!(f, "REFRESH"),
            Token::Partition => write!(f, "PARTITION"),
            Token::Range => write!(f, "RANGE"),
            Token::List => write!(f, "LIST"),
            Token::Hash => write!(f, "HASH"),
            Token::Attach => write!(f, "ATTACH"),
            Token::Detach => write!(f, "DETACH"),
            Token::Of => write!(f, "OF"),
            Token::Policy => write!(f, "POLICY"),
            Token::Enable => write!(f, "ENABLE"),
            Token::Disable => write!(f, "DISABLE"),
            Token::Security => write!(f, "SECURITY"),
            Token::Row => write!(f, "ROW"),
            Token::Level => write!(f, "LEVEL"),
            Token::Foreign => write!(f, "FOREIGN"),
            Token::Server => write!(f, "SERVER"),
            Token::Wrapper => write!(f, "WRAPPER"),
            Token::Options => write!(f, "OPTIONS"),
            Token::Data => write!(f, "DATA"),
            Token::Sessionize => write!(f, "SESSIONIZE"),
            Token::Gap => write!(f, "GAP"),
            Token::Over => write!(f, "OVER"),
            Token::Rows => write!(f, "ROWS"),
            Token::Preceding => write!(f, "PRECEDING"),
            Token::Following => write!(f, "FOLLOWING"),
            Token::Unbounded => write!(f, "UNBOUNDED"),
            Token::Current => write!(f, "CURRENT"),
            Token::String(s) => write!(f, "'{}'", s),
            Token::Integer(n) => write!(f, "{}", n),
            Token::Float(n) => write!(f, "{}", n),
            Token::JsonLiteral(s) => write!(f, "{}", s),
            Token::Ident(s) => write!(f, "{}", s),
            Token::Eq => write!(f, "="),
            Token::Ne => write!(f, "<>"),
            Token::Lt => write!(f, "<"),
            Token::Le => write!(f, "<="),
            Token::Gt => write!(f, ">"),
            Token::Ge => write!(f, ">="),
            Token::Plus => write!(f, "+"),
            Token::Minus => write!(f, "-"),
            Token::Star => write!(f, "*"),
            Token::Slash => write!(f, "/"),
            Token::Percent => write!(f, "%"),
            Token::LParen => write!(f, "("),
            Token::RParen => write!(f, ")"),
            Token::LBracket => write!(f, "["),
            Token::RBracket => write!(f, "]"),
            Token::LBrace => write!(f, "{{"),
            Token::RBrace => write!(f, "}}"),
            Token::Comma => write!(f, ","),
            Token::Dot => write!(f, "."),
            Token::Colon => write!(f, ":"),
            Token::Semi => write!(f, ";"),
            Token::Dollar => write!(f, "$"),
            Token::Question => write!(f, "?"),
            Token::FatArrow => write!(f, "=>"),
            Token::Arrow => write!(f, "->"),
            Token::ArrowLeft => write!(f, "<-"),
            Token::Dash => write!(f, "-"),
            Token::DotDot => write!(f, ".."),
            Token::Pipe => write!(f, "|"),
            Token::DoublePipe => write!(f, "||"),
            Token::Eof => write!(f, "EOF"),
        }
    }
}

/// Position in source code
#[derive(Debug, Clone, Copy, PartialEq, Eq, Default)]
pub struct Position {
    /// Line number (1-indexed)
    pub line: u32,
    /// Column number (1-indexed)
    pub column: u32,
    /// Byte offset from start
    pub offset: u32,
}

impl Position {
    /// Create a new position
    pub fn new(line: u32, column: u32, offset: u32) -> Self {
        Self {
            line,
            column,
            offset,
        }
    }
}

impl fmt::Display for Position {
    fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
        write!(f, "{}:{}", self.line, self.column)
    }
}

/// A token with its position in source
#[derive(Debug, Clone)]
pub struct Spanned {
    /// The token
    pub token: Token,
    /// Start position
    pub start: Position,
    /// End position
    pub end: Position,
}

impl Spanned {
    /// Create a new spanned token
    pub fn new(token: Token, start: Position, end: Position) -> Self {
        Self { token, start, end }
    }
}

/// Lexer error
#[derive(Debug, Clone)]
pub struct LexerError {
    /// Error message
    pub message: String,
    /// Position where error occurred
    pub position: Position,
    /// Optional structured DoS-limit annotation. When set, the
    /// `From<LexerError> for ParseError` conversion preserves this
    /// kind so callers can pattern-match on the limit programmatically.
    pub limit_hit: Option<LexerLimitHit>,
}

/// A specific DoS limit that the lexer refused to cross.
#[derive(Debug, Clone, PartialEq, Eq)]
pub enum LexerLimitHit {
    /// Identifier length cap.
    IdentifierTooLong {
        limit_name: &'static str,
        value: usize,
    },
}

impl LexerError {
    /// Create a new lexer error
    pub fn new(message: impl Into<String>, position: Position) -> Self {
        Self {
            message: message.into(),
            position,
            limit_hit: None,
        }
    }

    /// Create a lexer error tagged with a structured limit-hit kind.
    pub(crate) fn with_limit(
        message: impl Into<String>,
        position: Position,
        limit_hit: LexerLimitHit,
    ) -> Self {
        Self {
            message: message.into(),
            position,
            limit_hit: Some(limit_hit),
        }
    }
}

impl fmt::Display for LexerError {
    fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
        write!(f, "Lexer error at {}: {}", self.position, self.message)
    }
}

impl std::error::Error for LexerError {}

/// Maximum byte size of a raw JSON object literal. Mirrors the redwire
/// frame ceiling (`MAX_FRAME_SIZE` = 16 MiB) so a single SQL statement
/// can never embed a JSON literal larger than the wire payload limit.
/// Wire-side limit lives in `crate::wire::redwire::frame::MAX_FRAME_SIZE`;
/// duplicated here as a parser-side guard so the lexer can fail fast
/// without depending on the wire crate.
pub const JSON_LITERAL_MAX_BYTES: usize = 16 * 1024 * 1024;

/// RQL Lexer
pub struct Lexer<'a> {
    /// Original input text — kept so the JSON sub-mode can slice raw
    /// bytes between `{` and the matching `}` without re-tokenising.
    input: &'a str,
    /// Input characters
    chars: Peekable<Chars<'a>>,
    /// Current position
    line: u32,
    column: u32,
    offset: u32,
    /// Peeked token
    peeked: Option<Spanned>,
    /// Put-back buffer for characters we need to "unconsume"
    putback: Option<(char, Position)>,
    /// Maximum identifier characters (DoS limit, issue #87).
    max_identifier_chars: usize,
}

impl<'a> Lexer<'a> {
    /// Create a new lexer for the given input
    pub fn new(input: &'a str) -> Self {
        Self::with_limits(
            input,
            crate::storage::query::parser::ParserLimits::default(),
        )
    }

    /// Create a new lexer with explicit DoS limits.
    pub fn with_limits(
        input: &'a str,
        limits: crate::storage::query::parser::ParserLimits,
    ) -> Self {
        Self {
            input,
            chars: input.chars().peekable(),
            line: 1,
            column: 1,
            offset: 0,
            peeked: None,
            putback: None,
            max_identifier_chars: limits.max_identifier_chars,
        }
    }

    /// Maximum identifier-length cap; queried by `scan_identifier`
    /// to bail with a structured `LexerError` when an identifier
    /// would exceed the configured cap.
    pub(crate) fn max_identifier_chars(&self) -> usize {
        self.max_identifier_chars
    }

    /// Get current position
    fn position(&self) -> Position {
        Position::new(self.line, self.column, self.offset)
    }

    /// Put a character back into the stream
    fn unget(&mut self, ch: char, pos: Position) {
        self.putback = Some((ch, pos));
    }

    /// Advance and get next character
    fn advance(&mut self) -> Option<char> {
        // Check putback buffer first
        if let Some((ch, pos)) = self.putback.take() {
            // When we re-consume from putback, update position to after the char
            self.line = pos.line;
            self.column = pos.column + 1;
            self.offset = pos.offset + ch.len_utf8() as u32;
            return Some(ch);
        }

        let ch = self.chars.next()?;
        self.offset += ch.len_utf8() as u32;
        if ch == '\n' {
            self.line += 1;
            self.column = 1;
        } else {
            self.column += 1;
        }
        Some(ch)
    }

    /// Peek at next character
    fn peek(&mut self) -> Option<char> {
        // Check putback buffer first
        if let Some((ch, _)) = &self.putback {
            return Some(*ch);
        }
        self.chars.peek().copied()
    }

    /// Skip whitespace and comments
    fn skip_whitespace(&mut self) {
        while let Some(ch) = self.peek() {
            if ch.is_whitespace() {
                self.advance();
            } else if ch == '-' {
                // Could be comment (--) or operator
                let pos = self.position();
                self.advance();
                if self.peek() == Some('-') {
                    // Line comment
                    self.advance();
                    while let Some(c) = self.peek() {
                        if c == '\n' {
                            break;
                        }
                        self.advance();
                    }
                } else {
                    // Not a comment, put back - by restoring state
                    // Since we can't put back, we'll handle this in next_token
                    self.line = pos.line;
                    self.column = pos.column;
                    self.offset = pos.offset;
                    // Need to reset chars iterator - this is tricky
                    // Instead, we'll handle -- in scan_operator
                    break;
                }
            } else {
                break;
            }
        }
    }

    /// Peek at the next token without consuming it
    pub fn peek_token(&mut self) -> Result<&Spanned, LexerError> {
        if self.peeked.is_none() {
            self.peeked = Some(self.next_token_internal()?);
        }
        Ok(self.peeked.as_ref().unwrap())
    }

    /// Get the next token
    pub fn next_token(&mut self) -> Result<Spanned, LexerError> {
        if let Some(tok) = self.peeked.take() {
            return Ok(tok);
        }
        self.next_token_internal()
    }

    /// Internal implementation of next_token
    fn next_token_internal(&mut self) -> Result<Spanned, LexerError> {
        self.skip_whitespace_simple();

        let start = self.position();

        let ch = match self.peek() {
            Some(c) => c,
            None => {
                return Ok(Spanned::new(Token::Eof, start, start));
            }
        };

        // Dispatch based on first character
        let token = match ch {
            // String literals
            '\'' | '"' => self.scan_string()?,

            // Numbers
            '0'..='9' => self.scan_number()?,

            // Identifiers and keywords
            'a'..='z' | 'A'..='Z' | '_' => self.scan_identifier()?,

            // Operators and delimiters
            '=' => {
                self.advance();
                // `=>` is the named-argument arrow (e.g. `resolution => 0.5`);
                // a bare `=` stays the equality operator.
                if self.peek() == Some('>') {
                    self.advance();
                    Token::FatArrow
                } else {
                    Token::Eq
                }
            }
            '<' => self.scan_less_than()?,
            '>' => self.scan_greater_than()?,
            '!' => {
                self.advance();
                if self.peek() == Some('=') {
                    self.advance();
                    Token::Ne
                } else {
                    return Err(LexerError::new("Expected '=' after '!'", start));
                }
            }
            '+' => {
                self.advance();
                Token::Plus
            }
            '-' => self.scan_minus()?,
            '*' => {
                self.advance();
                Token::Star
            }
            '/' => {
                self.advance();
                Token::Slash
            }
            '%' => {
                self.advance();
                Token::Percent
            }
            '(' => {
                self.advance();
                Token::LParen
            }
            ')' => {
                self.advance();
                Token::RParen
            }
            '[' => {
                self.advance();
                Token::LBracket
            }
            ']' => {
                self.advance();
                Token::RBracket
            }
            '{' => {
                // JSON sub-mode trigger: if the next non-whitespace char
                // after `{` is `"`, scan a balanced raw `{...}` and emit
                // `Token::JsonLiteral`. Otherwise fall through to the
                // legacy `LBrace` token (Cypher property bag, etc.).
                // The empty-object case `{}` also takes the JSON path so
                // bare `VALUES ({})` matches `VALUES ('{}')`.
                if self.looks_like_json_object_start() {
                    return self.scan_json_literal(start);
                }
                self.advance();
                Token::LBrace
            }
            '}' => {
                self.advance();
                Token::RBrace
            }
            ',' => {
                self.advance();
                Token::Comma
            }
            '.' => self.scan_dot()?,
            ':' => {
                self.advance();
                Token::Colon
            }
            ';' => {
                self.advance();
                Token::Semi
            }
            '$' => {
                self.advance();
                Token::Dollar
            }
            '?' => {
                self.advance();
                Token::Question
            }
            '|' => {
                self.advance();
                if self.peek() == Some('|') {
                    self.advance();
                    Token::DoublePipe
                } else {
                    Token::Pipe
                }
            }
            _ => {
                return Err(LexerError::new(
                    format!("Unexpected character: '{}'", ch),
                    start,
                ));
            }
        };

        let end = self.position();
        Ok(Spanned::new(token, start, end))
    }

    /// Simple whitespace skip (no comment handling to avoid complexity)
    fn skip_whitespace_simple(&mut self) {
        while let Some(ch) = self.peek() {
            if ch.is_whitespace() {
                self.advance();
            } else if ch == '-' && self.input[self.offset as usize..].starts_with("--") {
                self.advance();
                self.advance();
                while let Some(c) = self.peek() {
                    if c == '\n' {
                        break;
                    }
                    self.advance();
                }
            } else if ch == '/' && self.input[self.offset as usize..].starts_with("/*") {
                self.advance();
                self.advance();
                while let Some(c) = self.peek() {
                    self.advance();
                    if c == '*' && self.peek() == Some('/') {
                        self.advance();
                        break;
                    }
                }
            } else {
                break;
            }
        }
    }

    /// Scan a string literal
    fn scan_string(&mut self) -> Result<Token, LexerError> {
        let quote = self.advance().unwrap(); // ' or "
        let start = self.position();
        let mut value = String::new();

        loop {
            match self.peek() {
                None => {
                    return Err(LexerError::new("Unterminated string", start));
                }
                Some(c) if c == quote => {
                    self.advance();
                    // Check for escaped quote ('')
                    if self.peek() == Some(quote) {
                        self.advance();
                        value.push(quote);
                    } else {
                        break;
                    }
                }
                Some('\\') => {
                    self.advance();
                    match self.peek() {
                        Some('n') => {
                            self.advance();
                            value.push('\n');
                        }
                        Some('r') => {
                            self.advance();
                            value.push('\r');
                        }
                        Some('t') => {
                            self.advance();
                            value.push('\t');
                        }
                        Some('\\') => {
                            self.advance();
                            value.push('\\');
                        }
                        Some(c) if c == quote => {
                            self.advance();
                            value.push(quote);
                        }
                        Some(c) => {
                            // Unknown escape, keep as-is
                            value.push('\\');
                            value.push(c);
                            self.advance();
                        }
                        None => {
                            return Err(LexerError::new("Unterminated string", start));
                        }
                    }
                }
                Some(c) => {
                    self.advance();
                    value.push(c);
                }
            }
        }

        Ok(Token::String(value))
    }

    /// Scan a number (integer or float)
    fn scan_number(&mut self) -> Result<Token, LexerError> {
        let mut value = String::new();
        let mut is_float = false;

        // Integer part
        while let Some(ch) = self.peek() {
            if ch.is_ascii_digit() {
                value.push(ch);
                self.advance();
            } else {
                break;
            }
        }

        // Check for decimal point
        if self.peek() == Some('.') {
            // Look ahead to distinguish from .. and method calls
            let dot_pos = self.position();
            self.advance(); // consume the first '.'

            if self.peek() == Some('.') {
                // It's ".." - put back the first dot using unget
                self.unget('.', dot_pos);
                // Return integer without the dot
            } else if self.peek().map(|c| c.is_ascii_digit()).unwrap_or(false) {
                is_float = true;
                value.push('.');
                while let Some(ch) = self.peek() {
                    if ch.is_ascii_digit() {
                        value.push(ch);
                        self.advance();
                    } else {
                        break;
                    }
                }
            } else {
                // Just a dot after number (like `x.method`), put it back
                self.unget('.', dot_pos);
            }
        }

        // Check for exponent
        if self.peek() == Some('e') || self.peek() == Some('E') {
            is_float = true;
            value.push(self.advance().unwrap());

            if self.peek() == Some('+') || self.peek() == Some('-') {
                value.push(self.advance().unwrap());
            }

            while let Some(ch) = self.peek() {
                if ch.is_ascii_digit() {
                    value.push(ch);
                    self.advance();
                } else {
                    break;
                }
            }
        }

        if is_float {
            match value.parse::<f64>() {
                Ok(n) => Ok(Token::Float(n)),
                Err(_) => Err(LexerError::new(
                    format!("Invalid float: {}", value),
                    self.position(),
                )),
            }
        } else {
            match value.parse::<i64>() {
                Ok(n) => Ok(Token::Integer(n)),
                Err(_) => Err(LexerError::new(
                    format!("Invalid integer: {}", value),
                    self.position(),
                )),
            }
        }
    }

    /// Scan an identifier or keyword
    fn scan_identifier(&mut self) -> Result<Token, LexerError> {
        let start_pos = self.position();
        let mut value = String::new();
        let max = self.max_identifier_chars;

        while let Some(ch) = self.peek() {
            if ch.is_alphanumeric() || ch == '_' {
                if value.chars().count() >= max {
                    // Bail before pushing — every additional char is
                    // bounded work for the attacker (1 char of input
                    // = 1 byte of allocation), so refuse early.
                    return Err(LexerError::with_limit(
                        format!(
                            "identifier exceeds maximum length (max_identifier_chars = {})",
                            max
                        ),
                        start_pos,
                        LexerLimitHit::IdentifierTooLong {
                            limit_name: "max_identifier_chars",
                            value: max,
                        },
                    ));
                }
                value.push(ch);
                self.advance();
            } else {
                break;
            }
        }

        // Check for keywords (case-insensitive)
        let token = match value.to_uppercase().as_str() {
            "SELECT" => Token::Select,
            "FROM" => Token::From,
            "WHERE" => Token::Where,
            "AND" => Token::And,
            "OR" => Token::Or,
            "NOT" => Token::Not,
            "MATCH" => Token::Match,
            "RETURN" => Token::Return,
            "JOIN" => Token::Join,
            "GRAPH" => Token::Graph,
            "PATH" => Token::Path,
            "TO" => Token::To,
            "VIA" => Token::Via,
            "ON" => Token::On,
            "AS" => Token::As,
            "IS" => Token::Is,
            "NULL" => Token::Null,
            "BETWEEN" => Token::Between,
            "LIKE" => Token::Like,
            "IN" => Token::In,
            "ORDER" => Token::Order,
            "BY" => Token::By,
            "ASC" => Token::Asc,
            "DESC" => Token::Desc,
            "NULLS" => Token::Nulls,
            "FIRST" => Token::First,
            "LAST" => Token::Last,
            "LIMIT" => Token::Limit,
            "OFFSET" => Token::Offset,
            "INNER" => Token::Inner,
            "LEFT" => Token::Left,
            "RIGHT" => Token::Right,
            "OUTER" => Token::Outer,
            "FULL" => Token::Full,
            "CROSS" => Token::Cross,
            "STARTS" => Token::Starts,
            "ENDS" => Token::Ends,
            "WITH" => Token::With,
            "CONTAINS" => Token::Contains,
            "TRUE" => Token::True,
            "FALSE" => Token::False,
            "ENRICH" => Token::Enrich,
            "GROUP" => Token::Group,
            "COUNT" => Token::Count,
            "SUM" => Token::Sum,
            "AVG" => Token::Avg,
            "MIN" => Token::Min,
            "MAX" => Token::Max,
            "DISTINCT" => Token::Distinct,
            "VECTOR" => Token::Vector,
            "SEARCH" => Token::Search,
            "SIMILAR" => Token::Similar,
            "COLLECTION" => Token::Collection,
            "METRIC" => Token::Metric,
            "THRESHOLD" => Token::Threshold,
            "K" => Token::K,
            "HYBRID" => Token::Hybrid,
            "FUSION" => Token::Fusion,
            "RERANK" => Token::Rerank,
            "RRF" => Token::Rrf,
            "INTERSECTION" => Token::Intersection,
            "UNION" => Token::Union,
            "RECURSIVE" => Token::Recursive,
            "ALL" => Token::All,
            "WEIGHT" => Token::Weight,
            "L2" => Token::L2,
            "COSINE" => Token::Cosine,
            "INNER_PRODUCT" | "INNERPRODUCT" => Token::InnerProduct,
            "INCLUDE" => Token::Include,
            "METADATA" => Token::Metadata,
            "VECTORS" => Token::Vectors,
            "EXPLAIN" => Token::Explain,
            "FOR" => Token::For,
            "FORMAT" => Token::Format,
            "JSON" => Token::Json,
            "INSERT" => Token::Insert,
            "INTO" => Token::Into,
            "VALUES" => Token::Values,
            "UPDATE" => Token::Update,
            "SET" => Token::Set,
            "DELETE" => Token::Delete,
            "TRUNCATE" => Token::Truncate,
            "CREATE" => Token::Create,
            "TABLE" => Token::Table,
            "DROP" => Token::Drop,
            "ALTER" => Token::Alter,
            "ADD" => Token::Add,
            "COLUMN" => Token::Column,
            "PRIMARY" => Token::Primary,
            "KEY" => Token::Key,
            "DEFAULT" => Token::Default,
            "COMPRESS" => Token::Compress,
            "INDEX" => Token::Index,
            "UNIQUE" => Token::Unique,
            "IF" => Token::If,
            "EXISTS" => Token::Exists,
            "RETURNING" => Token::Returning,
            "CASCADE" => Token::Cascade,
            "RENAME" => Token::Rename,
            "USING" => Token::Using,
            "NODE" => Token::Node,
            "EDGE" => Token::Edge,
            "DOCUMENT" => Token::Document,
            "KV" => Token::Kv,
            "TIMESERIES" => Token::Timeseries,
            "RETENTION" => Token::Retention,
            "QUEUE" => Token::Queue,
            "TREE" => Token::Tree,
            "PUSH" => Token::Push,
            "POP" => Token::Pop,
            "PEEK" => Token::Peek,
            "PURGE" => Token::Purge,
            "ACK" => Token::Ack,
            "NACK" => Token::Nack,
            "PRIORITY" => Token::Priority,
            "LPUSH" => Token::Ident("LPUSH".to_string()),
            "RPUSH" => Token::Ident("RPUSH".to_string()),
            "LPOP" => Token::Ident("LPOP".to_string()),
            "RPOP" => Token::Ident("RPOP".to_string()),
            "NEIGHBORHOOD" => Token::Neighborhood,
            "SHORTEST_PATH" | "SHORTESTPATH" => Token::ShortestPath,
            "CENTRALITY" => Token::Centrality,
            "COMMUNITY" => Token::Community,
            "COMPONENTS" => Token::Components,
            "CYCLES" => Token::Cycles,
            "TRAVERSE" => Token::Traverse,
            "DEPTH" => Token::Depth,
            "DIRECTION" => Token::Direction,
            "ALGORITHM" => Token::Algorithm,
            "STRATEGY" => Token::Strategy,
            "MAX_ITERATIONS" | "MAXITERATIONS" => Token::MaxIterations,
            "MAX_LENGTH" | "MAXLENGTH" => Token::MaxLength,
            "MODE" => Token::Mode,
            "CLUSTERING" => Token::Clustering,
            "TOPOLOGICAL_SORT" | "TOPOLOGICALSORT" => Token::TopologicalSort,
            "PROPERTIES" => Token::Properties,
            "TEXT" => Token::Text,
            "FUZZY" => Token::Fuzzy,
            "MIN_SCORE" | "MINSCORE" => Token::MinScore,
            "BEGIN" => Token::Begin,
            "COMMIT" => Token::Commit,
            "ROLLBACK" => Token::Rollback,
            "SAVEPOINT" => Token::Savepoint,
            "RELEASE" => Token::Release,
            "START" => Token::Start,
            "TRANSACTION" => Token::Transaction,
            "WORK" => Token::Work,
            "VACUUM" => Token::Vacuum,
            "ANALYZE" => Token::Analyze,
            "SCHEMA" => Token::Schema,
            "SEQUENCE" => Token::Sequence,
            "INCREMENT" => Token::Increment,
            "COPY" => Token::Copy,
            "HEADER" => Token::Header,
            "DELIMITER" => Token::Delimiter,
            "VIEW" => Token::View,
            "MATERIALIZED" => Token::Materialized,
            "REFRESH" => Token::Refresh,
            "PARTITION" => Token::Partition,
            "RANGE" => Token::Range,
            "LIST" => Token::List,
            "HASH" => Token::Hash,
            "ATTACH" => Token::Attach,
            "DETACH" => Token::Detach,
            "OF" => Token::Of,
            "POLICY" => Token::Policy,
            "ENABLE" => Token::Enable,
            "DISABLE" => Token::Disable,
            "SECURITY" => Token::Security,
            "ROW" => Token::Row,
            "LEVEL" => Token::Level,
            "FOREIGN" => Token::Foreign,
            "SERVER" => Token::Server,
            "WRAPPER" => Token::Wrapper,
            "OPTIONS" => Token::Options,
            "DATA" => Token::Data,
            "SESSIONIZE" => Token::Sessionize,
            "GAP" => Token::Gap,
            "OVER" => Token::Over,
            "ROWS" => Token::Rows,
            "PRECEDING" => Token::Preceding,
            "FOLLOWING" => Token::Following,
            "UNBOUNDED" => Token::Unbounded,
            "CURRENT" => Token::Current,
            _ => Token::Ident(value),
        };

        Ok(token)
    }

    /// Scan less-than variants: <, <=, <>, <-
    fn scan_less_than(&mut self) -> Result<Token, LexerError> {
        self.advance(); // consume '<'
        match self.peek() {
            Some('=') => {
                self.advance();
                Ok(Token::Le)
            }
            Some('>') => {
                self.advance();
                Ok(Token::Ne)
            }
            Some('-') => {
                self.advance();
                Ok(Token::ArrowLeft)
            }
            _ => Ok(Token::Lt),
        }
    }

    /// Scan greater-than variants: >, >=
    fn scan_greater_than(&mut self) -> Result<Token, LexerError> {
        self.advance(); // consume '>'
        if self.peek() == Some('=') {
            self.advance();
            Ok(Token::Ge)
        } else {
            Ok(Token::Gt)
        }
    }

    /// Scan minus variants: -, ->, --comment
    fn scan_minus(&mut self) -> Result<Token, LexerError> {
        self.advance(); // consume '-'
        match self.peek() {
            Some('>') => {
                self.advance();
                Ok(Token::Arrow)
            }
            Some('-') => {
                // Line comment, skip to end of line
                self.advance();
                while let Some(c) = self.peek() {
                    if c == '\n' {
                        break;
                    }
                    self.advance();
                }
                // Recursively get next token
                self.skip_whitespace_simple();
                if self.peek().is_none() {
                    Ok(Token::Eof)
                } else {
                    let next = self.next_token_internal()?;
                    Ok(next.token)
                }
            }
            _ => Ok(Token::Dash),
        }
    }

    /// Scan dot variants: ., ..
    fn scan_dot(&mut self) -> Result<Token, LexerError> {
        self.advance(); // consume '.'
        if self.peek() == Some('.') {
            self.advance();
            Ok(Token::DotDot)
        } else {
            Ok(Token::Dot)
        }
    }

    /// Look ahead from the current `{` to decide whether this is a
    /// JSON object literal (next non-ws char is `"` or `}`) or a
    /// legacy brace token (Cypher property bag, Python-style key
    /// without quotes, etc.). Pure read — does not advance.
    fn looks_like_json_object_start(&self) -> bool {
        let bytes = self.input.as_bytes();
        let mut i = self.offset as usize;
        // We're at `{`. Look one past it.
        debug_assert!(bytes.get(i) == Some(&b'{'));
        i += 1;
        while i < bytes.len() {
            match bytes[i] {
                b' ' | b'\t' | b'\n' | b'\r' => i += 1,
                b'"' | b'}' => return true,
                _ => return false,
            }
        }
        false
    }

    /// JSON sub-mode: scan a balanced `{...}` from the current `{`,
    /// returning a `Spanned(Token::JsonLiteral(raw_text), …)`.
    ///
    /// Tracks string boundaries so `{` and `}` inside `"..."` don't
    /// affect the brace counter. Honours `\\`, `\"`, `\\` etc. so an
    /// escaped quote does not close the string. Errors on EOF inside
    /// an unbalanced literal and on payload size > JSON_LITERAL_MAX_BYTES.
    ///
    /// State machine:
    /// - `Outside` (default): counts `{`/`}`, transitions to `InString` on `"`
    /// - `InString`: ignores braces, transitions back to `Outside` on
    ///   unescaped `"`. On `\`, transitions to `EscapeInString`.
    /// - `EscapeInString`: consume one byte unconditionally then back to
    ///   `InString`. Multi-byte UTF-8 sequences after `\u` are handled by
    ///   ordinary char iteration; we don't validate the JSON here, just
    ///   the brace balance.
    fn scan_json_literal(&mut self, start: Position) -> Result<Spanned, LexerError> {
        let start_offset = self.offset as usize;
        // Consume the opening `{`.
        self.advance();
        let mut depth: u32 = 1;
        let mut in_string = false;
        let mut escape = false;
        loop {
            let ch = match self.peek() {
                Some(c) => c,
                None => {
                    return Err(LexerError::new(
                        format!(
                            "unterminated JSON object literal (started at offset {})",
                            start.offset
                        ),
                        self.position(),
                    ));
                }
            };

            // Enforce payload size limit on the raw scan.
            let scanned_bytes = self.offset as usize - start_offset;
            if scanned_bytes > JSON_LITERAL_MAX_BYTES {
                return Err(LexerError::new(
                    format!(
                        "JSON object literal exceeds JSON_LITERAL_MAX_BYTES ({} bytes)",
                        JSON_LITERAL_MAX_BYTES
                    ),
                    start,
                ));
            }

            self.advance();

            if escape {
                escape = false;
                continue;
            }

            if in_string {
                match ch {
                    '\\' => escape = true,
                    '"' => in_string = false,
                    _ => {}
                }
                continue;
            }

            match ch {
                '"' => in_string = true,
                '{' => depth += 1,
                '}' => {
                    depth -= 1;
                    if depth == 0 {
                        let end = self.position();
                        let end_offset = self.offset as usize;
                        // Final size check including the trailing `}`.
                        if end_offset - start_offset > JSON_LITERAL_MAX_BYTES {
                            return Err(LexerError::new(
                                format!(
                                    "JSON object literal exceeds JSON_LITERAL_MAX_BYTES ({} bytes)",
                                    JSON_LITERAL_MAX_BYTES
                                ),
                                start,
                            ));
                        }
                        let raw = self.input[start_offset..end_offset].to_string();
                        return Ok(Spanned::new(Token::JsonLiteral(raw), start, end));
                    }
                }
                _ => {}
            }
        }
    }

    /// Tokenize entire input
    pub fn tokenize(&mut self) -> Result<Vec<Spanned>, LexerError> {
        let mut tokens = Vec::new();
        loop {
            let tok = self.next_token()?;
            let is_eof = tok.token == Token::Eof;
            tokens.push(tok);
            if is_eof {
                break;
            }
        }
        Ok(tokens)
    }
}

// ============================================================================
// Tests
// ============================================================================

#[cfg(test)]
mod tests {
    use super::*;

    fn tokenize(input: &str) -> Vec<Token> {
        let mut lexer = Lexer::new(input);
        lexer
            .tokenize()
            .unwrap()
            .into_iter()
            .map(|s| s.token)
            .collect()
    }

    #[test]
    fn test_keywords() {
        let tokens = tokenize("SELECT FROM WHERE AND OR NOT");
        assert_eq!(
            tokens,
            vec![
                Token::Select,
                Token::From,
                Token::Where,
                Token::And,
                Token::Or,
                Token::Not,
                Token::Eof
            ]
        );
    }

    #[test]
    fn test_identifiers() {
        let tokens = tokenize("hosts users ip_address");
        assert_eq!(
            tokens,
            vec![
                Token::Ident("hosts".into()),
                Token::Ident("users".into()),
                Token::Ident("ip_address".into()),
                Token::Eof
            ]
        );
    }

    #[test]
    fn test_numbers() {
        let tokens = tokenize("42 2.5 1e10 2.5e-3");
        assert_eq!(
            tokens,
            vec![
                Token::Integer(42),
                Token::Float(2.5),
                Token::Float(1e10),
                Token::Float(2.5e-3),
                Token::Eof
            ]
        );
    }

    #[test]
    fn test_strings() {
        let tokens = tokenize("'hello' \"world\" 'it''s'");
        assert_eq!(
            tokens,
            vec![
                Token::String("hello".into()),
                Token::String("world".into()),
                Token::String("it's".into()),
                Token::Eof
            ]
        );
    }

    #[test]
    fn test_operators() {
        let tokens = tokenize("= <> < <= > >= != + - * /");
        assert_eq!(
            tokens,
            vec![
                Token::Eq,
                Token::Ne,
                Token::Lt,
                Token::Le,
                Token::Gt,
                Token::Ge,
                Token::Ne,
                Token::Plus,
                Token::Dash,
                Token::Star,
                Token::Slash,
                Token::Eof
            ]
        );
    }

    #[test]
    fn test_delimiters() {
        // Note: `{ a }` (not `{ }`) — a bare `{ }` now triggers JSON
        // sub-mode and lexes as a single `JsonLiteral("{ }")` token.
        // The brace pair around a non-string token still produces the
        // legacy LBrace/RBrace pair (Cypher property bag, etc.).
        let tokens = tokenize("( ) [ ] { a } , . : ;");
        assert_eq!(
            tokens,
            vec![
                Token::LParen,
                Token::RParen,
                Token::LBracket,
                Token::RBracket,
                Token::LBrace,
                Token::Ident("a".into()),
                Token::RBrace,
                Token::Comma,
                Token::Dot,
                Token::Colon,
                Token::Semi,
                Token::Eof
            ]
        );
    }

    #[test]
    fn test_json_literal_empty_object() {
        let tokens = tokenize("{ }");
        assert_eq!(tokens, vec![Token::JsonLiteral("{ }".into()), Token::Eof]);
    }

    #[test]
    fn test_json_literal_simple() {
        let tokens = tokenize(r#"{"a":1}"#);
        assert_eq!(
            tokens,
            vec![Token::JsonLiteral(r#"{"a":1}"#.into()), Token::Eof]
        );
    }

    #[test]
    fn test_json_literal_nested() {
        let raw = r#"{"a":{"b":[1,2,{"c":"}"}]}}"#;
        let tokens = tokenize(raw);
        assert_eq!(tokens, vec![Token::JsonLiteral(raw.into()), Token::Eof]);
    }

    #[test]
    fn test_json_literal_escaped_quote_in_string() {
        // The `}` inside the escaped-quote string must not close the object.
        let raw = r#"{"path":"O\"Brien}"}"#;
        let tokens = tokenize(raw);
        assert_eq!(tokens, vec![Token::JsonLiteral(raw.into()), Token::Eof]);
    }

    #[test]
    fn test_json_literal_unbalanced_eof() {
        let mut lexer = Lexer::new(r#"{"a":1"#);
        let err = lexer.tokenize().expect_err("expected unterminated error");
        assert!(
            err.message.contains("unterminated JSON object literal"),
            "got: {}",
            err.message
        );
    }

    #[test]
    fn test_json_literal_property_bag_compatible() {
        // Cypher-style property bag must still tokenise as LBrace/.../RBrace
        // because the inner content does not start with `"`.
        let tokens = tokenize("{name: 'value'}");
        assert_eq!(tokens[0], Token::LBrace);
        assert_eq!(*tokens.last().unwrap(), Token::Eof);
    }

    #[test]
    fn test_graph_syntax() {
        let tokens = tokenize("-> <- - ..");
        assert_eq!(
            tokens,
            vec![
                Token::Arrow,
                Token::ArrowLeft,
                Token::Dash,
                Token::DotDot,
                Token::Eof
            ]
        );
    }

    #[test]
    fn test_table_query() {
        let tokens = tokenize("SELECT ip, hostname FROM hosts WHERE os = 'Linux' LIMIT 10");
        assert_eq!(
            tokens,
            vec![
                Token::Select,
                Token::Ident("ip".into()),
                Token::Comma,
                Token::Ident("hostname".into()),
                Token::From,
                Token::Ident("hosts".into()),
                Token::Where,
                Token::Ident("os".into()),
                Token::Eq,
                Token::String("Linux".into()),
                Token::Limit,
                Token::Integer(10),
                Token::Eof
            ]
        );
    }

    #[test]
    fn test_graph_query() {
        let tokens = tokenize("MATCH (h:Host)-[:HAS_SERVICE]->(s:Service) RETURN h, s");
        assert_eq!(
            tokens,
            vec![
                Token::Match,
                Token::LParen,
                Token::Ident("h".into()),
                Token::Colon,
                Token::Ident("Host".into()),
                Token::RParen,
                Token::Dash,
                Token::LBracket,
                Token::Colon,
                Token::Ident("HAS_SERVICE".into()),
                Token::RBracket,
                Token::Arrow,
                Token::LParen,
                Token::Ident("s".into()),
                Token::Colon,
                Token::Ident("Service".into()),
                Token::RParen,
                Token::Return,
                Token::Ident("h".into()),
                Token::Comma,
                Token::Ident("s".into()),
                Token::Eof
            ]
        );
    }

    #[test]
    fn test_join_query() {
        let tokens = tokenize("FROM hosts h JOIN GRAPH (h)-[:HAS_VULN]->(v) ON h.ip = v.id");
        assert_eq!(
            tokens,
            vec![
                Token::From,
                Token::Ident("hosts".into()),
                Token::Ident("h".into()),
                Token::Join,
                Token::Graph,
                Token::LParen,
                Token::Ident("h".into()),
                Token::RParen,
                Token::Dash,
                Token::LBracket,
                Token::Colon,
                Token::Ident("HAS_VULN".into()),
                Token::RBracket,
                Token::Arrow,
                Token::LParen,
                Token::Ident("v".into()),
                Token::RParen,
                Token::On,
                Token::Ident("h".into()),
                Token::Dot,
                Token::Ident("ip".into()),
                Token::Eq,
                Token::Ident("v".into()),
                Token::Dot,
                Token::Ident("id".into()),
                Token::Eof
            ]
        );
    }

    #[test]
    fn test_path_query() {
        let tokens = tokenize("PATH FROM host('192.168.1.1') TO host('10.0.0.1') VIA [:AUTH]");
        assert_eq!(
            tokens,
            vec![
                Token::Path,
                Token::From,
                Token::Ident("host".into()),
                Token::LParen,
                Token::String("192.168.1.1".into()),
                Token::RParen,
                Token::To,
                Token::Ident("host".into()),
                Token::LParen,
                Token::String("10.0.0.1".into()),
                Token::RParen,
                Token::Via,
                Token::LBracket,
                Token::Colon,
                Token::Ident("AUTH".into()),
                Token::RBracket,
                Token::Eof
            ]
        );
    }

    #[test]
    fn test_variable_length_pattern() {
        let tokens = tokenize("(a)-[*1..5]->(b)");
        assert_eq!(
            tokens,
            vec![
                Token::LParen,
                Token::Ident("a".into()),
                Token::RParen,
                Token::Dash,
                Token::LBracket,
                Token::Star,
                Token::Integer(1),
                Token::DotDot,
                Token::Integer(5),
                Token::RBracket,
                Token::Arrow,
                Token::LParen,
                Token::Ident("b".into()),
                Token::RParen,
                Token::Eof
            ]
        );
    }

    #[test]
    fn test_case_insensitive_keywords() {
        let tokens = tokenize("select FROM Where AND");
        assert_eq!(
            tokens,
            vec![
                Token::Select,
                Token::From,
                Token::Where,
                Token::And,
                Token::Eof
            ]
        );
    }

    #[test]
    fn test_comments() {
        let tokens = tokenize("SELECT -- this is a comment\nip FROM hosts");
        assert_eq!(
            tokens,
            vec![
                Token::Select,
                Token::Ident("ip".into()),
                Token::From,
                Token::Ident("hosts".into()),
                Token::Eof
            ]
        );
    }

    #[test]
    fn test_escaped_strings() {
        let tokens = tokenize(r"'hello\nworld' 'tab\there'");
        assert_eq!(
            tokens,
            vec![
                Token::String("hello\nworld".into()),
                Token::String("tab\there".into()),
                Token::Eof
            ]
        );
    }

    #[test]
    fn test_keyword_matrix_and_alias_spellings() {
        let cases = [
            ("SELECT", Token::Select),
            ("FROM", Token::From),
            ("WHERE", Token::Where),
            ("AND", Token::And),
            ("OR", Token::Or),
            ("NOT", Token::Not),
            ("MATCH", Token::Match),
            ("RETURN", Token::Return),
            ("JOIN", Token::Join),
            ("GRAPH", Token::Graph),
            ("PATH", Token::Path),
            ("TO", Token::To),
            ("VIA", Token::Via),
            ("ON", Token::On),
            ("AS", Token::As),
            ("IS", Token::Is),
            ("NULL", Token::Null),
            ("BETWEEN", Token::Between),
            ("LIKE", Token::Like),
            ("IN", Token::In),
            ("ORDER", Token::Order),
            ("BY", Token::By),
            ("ASC", Token::Asc),
            ("DESC", Token::Desc),
            ("NULLS", Token::Nulls),
            ("FIRST", Token::First),
            ("LAST", Token::Last),
            ("LIMIT", Token::Limit),
            ("OFFSET", Token::Offset),
            ("INNER", Token::Inner),
            ("LEFT", Token::Left),
            ("RIGHT", Token::Right),
            ("OUTER", Token::Outer),
            ("FULL", Token::Full),
            ("CROSS", Token::Cross),
            ("STARTS", Token::Starts),
            ("ENDS", Token::Ends),
            ("WITH", Token::With),
            ("CONTAINS", Token::Contains),
            ("TRUE", Token::True),
            ("FALSE", Token::False),
            ("ENRICH", Token::Enrich),
            ("GROUP", Token::Group),
            ("COUNT", Token::Count),
            ("SUM", Token::Sum),
            ("AVG", Token::Avg),
            ("MIN", Token::Min),
            ("MAX", Token::Max),
            ("DISTINCT", Token::Distinct),
            ("VECTOR", Token::Vector),
            ("SEARCH", Token::Search),
            ("SIMILAR", Token::Similar),
            ("COLLECTION", Token::Collection),
            ("METRIC", Token::Metric),
            ("THRESHOLD", Token::Threshold),
            ("K", Token::K),
            ("HYBRID", Token::Hybrid),
            ("FUSION", Token::Fusion),
            ("RERANK", Token::Rerank),
            ("RRF", Token::Rrf),
            ("INTERSECTION", Token::Intersection),
            ("UNION", Token::Union),
            ("RECURSIVE", Token::Recursive),
            ("ALL", Token::All),
            ("WEIGHT", Token::Weight),
            ("L2", Token::L2),
            ("COSINE", Token::Cosine),
            ("INNER_PRODUCT", Token::InnerProduct),
            ("INNERPRODUCT", Token::InnerProduct),
            ("INCLUDE", Token::Include),
            ("METADATA", Token::Metadata),
            ("VECTORS", Token::Vectors),
            ("EXPLAIN", Token::Explain),
            ("FOR", Token::For),
            ("FORMAT", Token::Format),
            ("JSON", Token::Json),
            ("INSERT", Token::Insert),
            ("INTO", Token::Into),
            ("VALUES", Token::Values),
            ("UPDATE", Token::Update),
            ("SET", Token::Set),
            ("DELETE", Token::Delete),
            ("TRUNCATE", Token::Truncate),
            ("CREATE", Token::Create),
            ("TABLE", Token::Table),
            ("DROP", Token::Drop),
            ("ALTER", Token::Alter),
            ("ADD", Token::Add),
            ("COLUMN", Token::Column),
            ("PRIMARY", Token::Primary),
            ("KEY", Token::Key),
            ("DEFAULT", Token::Default),
            ("COMPRESS", Token::Compress),
            ("INDEX", Token::Index),
            ("UNIQUE", Token::Unique),
            ("IF", Token::If),
            ("EXISTS", Token::Exists),
            ("RETURNING", Token::Returning),
            ("CASCADE", Token::Cascade),
            ("RENAME", Token::Rename),
            ("USING", Token::Using),
            ("NODE", Token::Node),
            ("EDGE", Token::Edge),
            ("DOCUMENT", Token::Document),
            ("KV", Token::Kv),
            ("TIMESERIES", Token::Timeseries),
            ("RETENTION", Token::Retention),
            ("QUEUE", Token::Queue),
            ("TREE", Token::Tree),
            ("PUSH", Token::Push),
            ("POP", Token::Pop),
            ("PEEK", Token::Peek),
            ("PURGE", Token::Purge),
            ("ACK", Token::Ack),
            ("NACK", Token::Nack),
            ("PRIORITY", Token::Priority),
            ("LPUSH", Token::Ident("LPUSH".into())),
            ("RPUSH", Token::Ident("RPUSH".into())),
            ("LPOP", Token::Ident("LPOP".into())),
            ("RPOP", Token::Ident("RPOP".into())),
            ("NEIGHBORHOOD", Token::Neighborhood),
            ("SHORTEST_PATH", Token::ShortestPath),
            ("SHORTESTPATH", Token::ShortestPath),
            ("CENTRALITY", Token::Centrality),
            ("COMMUNITY", Token::Community),
            ("COMPONENTS", Token::Components),
            ("CYCLES", Token::Cycles),
            ("TRAVERSE", Token::Traverse),
            ("DEPTH", Token::Depth),
            ("DIRECTION", Token::Direction),
            ("ALGORITHM", Token::Algorithm),
            ("STRATEGY", Token::Strategy),
            ("MAX_ITERATIONS", Token::MaxIterations),
            ("MAXITERATIONS", Token::MaxIterations),
            ("MAX_LENGTH", Token::MaxLength),
            ("MAXLENGTH", Token::MaxLength),
            ("MODE", Token::Mode),
            ("CLUSTERING", Token::Clustering),
            ("TOPOLOGICAL_SORT", Token::TopologicalSort),
            ("TOPOLOGICALSORT", Token::TopologicalSort),
            ("PROPERTIES", Token::Properties),
            ("TEXT", Token::Text),
            ("FUZZY", Token::Fuzzy),
            ("MIN_SCORE", Token::MinScore),
            ("MINSCORE", Token::MinScore),
            ("BEGIN", Token::Begin),
            ("COMMIT", Token::Commit),
            ("ROLLBACK", Token::Rollback),
            ("SAVEPOINT", Token::Savepoint),
            ("RELEASE", Token::Release),
            ("START", Token::Start),
            ("TRANSACTION", Token::Transaction),
            ("WORK", Token::Work),
            ("VACUUM", Token::Vacuum),
            ("ANALYZE", Token::Analyze),
            ("SCHEMA", Token::Schema),
            ("SEQUENCE", Token::Sequence),
            ("INCREMENT", Token::Increment),
            ("COPY", Token::Copy),
            ("HEADER", Token::Header),
            ("DELIMITER", Token::Delimiter),
            ("VIEW", Token::View),
            ("MATERIALIZED", Token::Materialized),
            ("REFRESH", Token::Refresh),
            ("PARTITION", Token::Partition),
            ("RANGE", Token::Range),
            ("LIST", Token::List),
            ("HASH", Token::Hash),
            ("ATTACH", Token::Attach),
            ("DETACH", Token::Detach),
            ("OF", Token::Of),
            ("POLICY", Token::Policy),
            ("ENABLE", Token::Enable),
            ("DISABLE", Token::Disable),
            ("SECURITY", Token::Security),
            ("ROW", Token::Row),
            ("LEVEL", Token::Level),
            ("FOREIGN", Token::Foreign),
            ("SERVER", Token::Server),
            ("WRAPPER", Token::Wrapper),
            ("OPTIONS", Token::Options),
            ("DATA", Token::Data),
            ("plain_ident", Token::Ident("plain_ident".into())),
        ];

        for (input, expected) in cases {
            let tokens = tokenize(input);
            assert_eq!(tokens, vec![expected, Token::Eof], "{input}");
        }
    }

    #[test]
    fn test_display_all_token_variants() {
        let cases = [
            (Token::Select, "SELECT"),
            (Token::From, "FROM"),
            (Token::Where, "WHERE"),
            (Token::And, "AND"),
            (Token::Or, "OR"),
            (Token::Not, "NOT"),
            (Token::Match, "MATCH"),
            (Token::Return, "RETURN"),
            (Token::Join, "JOIN"),
            (Token::Graph, "GRAPH"),
            (Token::Path, "PATH"),
            (Token::To, "TO"),
            (Token::Via, "VIA"),
            (Token::On, "ON"),
            (Token::As, "AS"),
            (Token::Is, "IS"),
            (Token::Null, "NULL"),
            (Token::Between, "BETWEEN"),
            (Token::Like, "LIKE"),
            (Token::In, "IN"),
            (Token::Order, "ORDER"),
            (Token::By, "BY"),
            (Token::Asc, "ASC"),
            (Token::Desc, "DESC"),
            (Token::Nulls, "NULLS"),
            (Token::First, "FIRST"),
            (Token::Last, "LAST"),
            (Token::Limit, "LIMIT"),
            (Token::Offset, "OFFSET"),
            (Token::Inner, "INNER"),
            (Token::Left, "LEFT"),
            (Token::Right, "RIGHT"),
            (Token::Outer, "OUTER"),
            (Token::Full, "FULL"),
            (Token::Cross, "CROSS"),
            (Token::Starts, "STARTS"),
            (Token::Ends, "ENDS"),
            (Token::With, "WITH"),
            (Token::Contains, "CONTAINS"),
            (Token::True, "TRUE"),
            (Token::False, "FALSE"),
            (Token::Enrich, "ENRICH"),
            (Token::Group, "GROUP"),
            (Token::Count, "COUNT"),
            (Token::Sum, "SUM"),
            (Token::Avg, "AVG"),
            (Token::Min, "MIN"),
            (Token::Max, "MAX"),
            (Token::Distinct, "DISTINCT"),
            (Token::Vector, "VECTOR"),
            (Token::Search, "SEARCH"),
            (Token::Similar, "SIMILAR"),
            (Token::Collection, "COLLECTION"),
            (Token::Metric, "METRIC"),
            (Token::Threshold, "THRESHOLD"),
            (Token::K, "K"),
            (Token::Hybrid, "HYBRID"),
            (Token::Fusion, "FUSION"),
            (Token::Rerank, "RERANK"),
            (Token::Rrf, "RRF"),
            (Token::Intersection, "INTERSECTION"),
            (Token::Union, "UNION"),
            (Token::Recursive, "RECURSIVE"),
            (Token::All, "ALL"),
            (Token::Weight, "WEIGHT"),
            (Token::L2, "L2"),
            (Token::Cosine, "COSINE"),
            (Token::InnerProduct, "INNER_PRODUCT"),
            (Token::Include, "INCLUDE"),
            (Token::Metadata, "METADATA"),
            (Token::Vectors, "VECTORS"),
            (Token::Explain, "EXPLAIN"),
            (Token::For, "FOR"),
            (Token::Format, "FORMAT"),
            (Token::Json, "JSON"),
            (Token::Insert, "INSERT"),
            (Token::Into, "INTO"),
            (Token::Values, "VALUES"),
            (Token::Update, "UPDATE"),
            (Token::Set, "SET"),
            (Token::Delete, "DELETE"),
            (Token::Truncate, "TRUNCATE"),
            (Token::Create, "CREATE"),
            (Token::Table, "TABLE"),
            (Token::Drop, "DROP"),
            (Token::Alter, "ALTER"),
            (Token::Add, "ADD"),
            (Token::Column, "COLUMN"),
            (Token::Primary, "PRIMARY"),
            (Token::Key, "KEY"),
            (Token::Default, "DEFAULT"),
            (Token::Compress, "COMPRESS"),
            (Token::Index, "INDEX"),
            (Token::Unique, "UNIQUE"),
            (Token::If, "IF"),
            (Token::Exists, "EXISTS"),
            (Token::Returning, "RETURNING"),
            (Token::Cascade, "CASCADE"),
            (Token::Rename, "RENAME"),
            (Token::Using, "USING"),
            (Token::Node, "NODE"),
            (Token::Edge, "EDGE"),
            (Token::Document, "DOCUMENT"),
            (Token::Kv, "KV"),
            (Token::Timeseries, "TIMESERIES"),
            (Token::Retention, "RETENTION"),
            (Token::Queue, "QUEUE"),
            (Token::Tree, "TREE"),
            (Token::Push, "PUSH"),
            (Token::Pop, "POP"),
            (Token::Peek, "PEEK"),
            (Token::Purge, "PURGE"),
            (Token::Ack, "ACK"),
            (Token::Nack, "NACK"),
            (Token::Priority, "PRIORITY"),
            (Token::Neighborhood, "NEIGHBORHOOD"),
            (Token::ShortestPath, "SHORTEST_PATH"),
            (Token::Centrality, "CENTRALITY"),
            (Token::Community, "COMMUNITY"),
            (Token::Components, "COMPONENTS"),
            (Token::Cycles, "CYCLES"),
            (Token::Traverse, "TRAVERSE"),
            (Token::Depth, "DEPTH"),
            (Token::Direction, "DIRECTION"),
            (Token::Algorithm, "ALGORITHM"),
            (Token::Strategy, "STRATEGY"),
            (Token::MaxIterations, "MAX_ITERATIONS"),
            (Token::MaxLength, "MAX_LENGTH"),
            (Token::Mode, "MODE"),
            (Token::Clustering, "CLUSTERING"),
            (Token::TopologicalSort, "TOPOLOGICAL_SORT"),
            (Token::Properties, "PROPERTIES"),
            (Token::Text, "TEXT"),
            (Token::Fuzzy, "FUZZY"),
            (Token::MinScore, "MIN_SCORE"),
            (Token::Begin, "BEGIN"),
            (Token::Commit, "COMMIT"),
            (Token::Rollback, "ROLLBACK"),
            (Token::Savepoint, "SAVEPOINT"),
            (Token::Release, "RELEASE"),
            (Token::Start, "START"),
            (Token::Transaction, "TRANSACTION"),
            (Token::Work, "WORK"),
            (Token::Vacuum, "VACUUM"),
            (Token::Analyze, "ANALYZE"),
            (Token::Schema, "SCHEMA"),
            (Token::Sequence, "SEQUENCE"),
            (Token::Increment, "INCREMENT"),
            (Token::Copy, "COPY"),
            (Token::Header, "HEADER"),
            (Token::Delimiter, "DELIMITER"),
            (Token::View, "VIEW"),
            (Token::Materialized, "MATERIALIZED"),
            (Token::Refresh, "REFRESH"),
            (Token::Partition, "PARTITION"),
            (Token::Range, "RANGE"),
            (Token::List, "LIST"),
            (Token::Hash, "HASH"),
            (Token::Attach, "ATTACH"),
            (Token::Detach, "DETACH"),
            (Token::Of, "OF"),
            (Token::Policy, "POLICY"),
            (Token::Enable, "ENABLE"),
            (Token::Disable, "DISABLE"),
            (Token::Security, "SECURITY"),
            (Token::Row, "ROW"),
            (Token::Level, "LEVEL"),
            (Token::Foreign, "FOREIGN"),
            (Token::Server, "SERVER"),
            (Token::Wrapper, "WRAPPER"),
            (Token::Options, "OPTIONS"),
            (Token::Data, "DATA"),
            (Token::String("x".into()), "'x'"),
            (Token::Integer(7), "7"),
            (Token::Float(1.5), "1.5"),
            (Token::JsonLiteral(r#"{"x":1}"#.into()), r#"{"x":1}"#),
            (Token::Ident("id".into()), "id"),
            (Token::Eq, "="),
            (Token::Ne, "<>"),
            (Token::Lt, "<"),
            (Token::Le, "<="),
            (Token::Gt, ">"),
            (Token::Ge, ">="),
            (Token::Plus, "+"),
            (Token::Minus, "-"),
            (Token::Star, "*"),
            (Token::Slash, "/"),
            (Token::Percent, "%"),
            (Token::LParen, "("),
            (Token::RParen, ")"),
            (Token::LBracket, "["),
            (Token::RBracket, "]"),
            (Token::LBrace, "{"),
            (Token::RBrace, "}"),
            (Token::Comma, ","),
            (Token::Dot, "."),
            (Token::Colon, ":"),
            (Token::Semi, ";"),
            (Token::Dollar, "$"),
            (Token::FatArrow, "=>"),
            (Token::Arrow, "->"),
            (Token::ArrowLeft, "<-"),
            (Token::Dash, "-"),
            (Token::DotDot, ".."),
            (Token::Pipe, "|"),
            (Token::DoublePipe, "||"),
            (Token::Eof, "EOF"),
        ];

        for (token, expected) in cases {
            assert_eq!(token.to_string(), expected);
        }
    }

    #[test]
    fn fat_arrow_lexes_distinctly_from_eq() {
        // `=>` is the named-argument arrow; a bare `=` stays equality.
        assert_eq!(
            tokenize("resolution => 0.5"),
            vec![
                Token::Ident("resolution".into()),
                Token::FatArrow,
                Token::Float(0.5),
                Token::Eof,
            ]
        );
        assert_eq!(
            tokenize("x = 1"),
            vec![
                Token::Ident("x".into()),
                Token::Eq,
                Token::Integer(1),
                Token::Eof,
            ]
        );
    }

    #[test]
    fn test_string_escape_and_error_matrix() {
        let tokens = tokenize(
            r#"'line\nrow' 'carriage\rreturn' 'tab\tstop' 'slash\\' 'quote\'' "dq\"" 'raw\z'"#,
        );
        assert_eq!(
            tokens,
            vec![
                Token::String("line\nrow".into()),
                Token::String("carriage\rreturn".into()),
                Token::String("tab\tstop".into()),
                Token::String("slash\\".into()),
                Token::String("quote'".into()),
                Token::String("dq\"".into()),
                Token::String(r"raw\z".into()),
                Token::Eof
            ]
        );

        let mut lexer = Lexer::new("'unterminated");
        assert!(lexer
            .next_token()
            .unwrap_err()
            .message
            .contains("Unterminated string"));

        let mut lexer = Lexer::new(r"'bad\");
        assert!(lexer
            .next_token()
            .unwrap_err()
            .message
            .contains("Unterminated string"));
    }

    #[test]
    fn test_operator_comment_peek_limit_and_tokenize_paths() {
        let tokens = tokenize("!= % ; $ || | 123.abc 1..2 1e+2 <- -> /* block */ SELECT");
        assert_eq!(
            tokens,
            vec![
                Token::Ne,
                Token::Percent,
                Token::Semi,
                Token::Dollar,
                Token::DoublePipe,
                Token::Pipe,
                Token::Integer(123),
                Token::Dot,
                Token::Ident("abc".into()),
                Token::Integer(1),
                Token::DotDot,
                Token::Integer(2),
                Token::Float(1e2),
                Token::ArrowLeft,
                Token::Arrow,
                Token::Select,
                Token::Eof,
            ]
        );

        let mut lexer = Lexer::new("SELECT FROM");
        assert_eq!(lexer.peek_token().unwrap().token, Token::Select);
        assert_eq!(lexer.next_token().unwrap().token, Token::Select);
        assert_eq!(lexer.next_token().unwrap().token, Token::From);

        let mut lexer = Lexer::new("!");
        assert!(lexer
            .next_token()
            .unwrap_err()
            .message
            .contains("Expected '=' after '!'"));

        let limits = crate::storage::query::parser::ParserLimits {
            max_identifier_chars: 3,
            ..crate::storage::query::parser::ParserLimits::default()
        };
        let mut lexer = Lexer::with_limits("abcd", limits);
        assert_eq!(lexer.max_identifier_chars(), 3);
        let err = lexer.next_token().unwrap_err();
        assert!(matches!(
            err.limit_hit,
            Some(LexerLimitHit::IdentifierTooLong { value: 3, .. })
        ));
    }
}