Skip to main content

reddb_server/storage/unified/store/
impl_pages.rs

1use super::*;
2use crate::storage::unified::entity_cache::EntityCache;
3use parking_lot::RwLock;
4
5const CHECKPOINT_BATCH_BYTES: usize = 1024 * 1024;
6const CHECKPOINT_BATCH_ROWS: usize = 512;
7
8/// Keep encoded payload memory proportional to a small batch, not a collection.
9/// A single large value retains the existing B-tree value-size contract.
10struct CheckpointTreeBuilder {
11    tree: Arc<BTree>,
12    records: Vec<(Vec<u8>, Vec<u8>)>,
13    bytes: usize,
14}
15
16impl CheckpointTreeBuilder {
17    fn new(pager: &Arc<Pager>) -> Self {
18        Self {
19            tree: Arc::new(BTree::new(Arc::clone(pager))),
20            records: Vec::new(),
21            bytes: 0,
22        }
23    }
24
25    fn push(&mut self, record: (Vec<u8>, Vec<u8>)) -> Result<(), StoreError> {
26        let bytes = record.0.len() + record.1.len();
27        if !self.records.is_empty()
28            && (self.bytes.saturating_add(bytes) > CHECKPOINT_BATCH_BYTES
29                || self.records.len() >= CHECKPOINT_BATCH_ROWS)
30        {
31            self.flush()?;
32        }
33        self.bytes += bytes;
34        self.records.push(record);
35        #[cfg(test)]
36        CHECKPOINT_BUFFERED_BYTES.with(|peak| peak.set(peak.get().max(self.bytes)));
37        Ok(())
38    }
39
40    fn flush(&mut self) -> Result<(), StoreError> {
41        self.tree
42            .bulk_insert_sorted(&self.records)
43            .map_err(|e| StoreError::Io(std::io::Error::other(e.to_string())))?;
44        self.records.clear();
45        self.bytes = 0;
46        Ok(())
47    }
48
49    fn copy_prefix(&mut self, previous: &BTree, count: usize) -> Result<(), StoreError> {
50        let mut cursor = previous
51            .cursor_first()
52            .map_err(|e| StoreError::Io(std::io::Error::other(e.to_string())))?;
53        for _ in 0..count {
54            let record = cursor
55                .next()
56                .map_err(|e| StoreError::Io(std::io::Error::other(e.to_string())))?
57                .ok_or_else(|| StoreError::Serialization("checkpoint prefix disappeared".into()))?;
58            self.push(record)?;
59        }
60        Ok(())
61    }
62}
63
64#[cfg(test)]
65thread_local! {
66    static CHECKPOINT_SERIALIZED_ROWS: std::cell::Cell<usize> = const { std::cell::Cell::new(0) };
67    static CHECKPOINT_BUFFERED_BYTES: std::cell::Cell<usize> = const { std::cell::Cell::new(0) };
68}
69
70fn checkpoint_visibility_matches(
71    previous: &CheckpointVersion,
72    current: &CheckpointVersion,
73    manager: &SegmentManager,
74) -> bool {
75    if previous.aborted_revision == current.aborted_revision
76        && previous.pending_vault == current.pending_vault
77    {
78        return true;
79    }
80    // A rollback or vault publication in another collection must not force
81    // payload serialization here. Only the persisted visibility matters.
82    let mut matches = true;
83    manager.for_each_entity(|entity| {
84        let skipped = |version: &CheckpointVersion| {
85            version.pending_vault.contains(&entity.id)
86                || (matches!(entity.data, EntityData::Row(_) | EntityData::Vector(_))
87                    && version.aborted.contains(&entity.xmin))
88        };
89        let previous_skipped = skipped(previous);
90        let current_skipped = skipped(current);
91        matches = previous_skipped == current_skipped
92            && (current_skipped
93                || !matches!(entity.data, EntityData::Row(_))
94                || previous.aborted.contains(&entity.xmax)
95                    == current.aborted.contains(&entity.xmax));
96        matches
97    });
98    matches
99}
100
101// ── Pager-meta overflow chain (gh-477) ──────────────────────────────────────
102// When the serialized collection registry + cross-refs exceed a single page,
103// page 1 carries a native metadata-overflow header pointing at an overflow chain of
104// `PageType::Overflow` pages. Single-page metadata keeps the historical
105// bit-identical layout (`METADATA_MAGIC = "RDM2"` written directly at the
106// content offset).
107//
108// Page 1 (overflow form), starting at `HEADER_SIZE`:
109//   [0..4]   native metadata-overflow magic
110//   [4..8]   format_version (u32, mirrors inner payload version for debug)
111//   [8..12]  total_payload_bytes (u32)
112//   [12..16] next_overflow_page_id (u32, > 0)
113//   [16..]   first payload chunk (up to META_V3_FIRST_PAYLOAD_CAP bytes)
114//
115// Overflow continuation page, starting at `HEADER_SIZE`:
116//   [0..4]   next_overflow_page_id (u32, 0 if last)
117//   [4..8]   chunk_bytes (u32)
118//   [8..]    chunk payload (up to META_V3_OVERFLOW_PAYLOAD_CAP bytes)
119const META_PAGE_CONTENT_CAP: usize =
120    crate::storage::engine::PAGE_SIZE - crate::storage::engine::HEADER_SIZE;
121const META_V3_PAGE1_HEADER: usize = reddb_file::METADATA_OVERFLOW_HEADER_BYTES;
122const META_V3_OVERFLOW_HEADER: usize = reddb_file::METADATA_OVERFLOW_CONTINUATION_HEADER_BYTES;
123const META_V3_FIRST_PAYLOAD_CAP: usize = META_PAGE_CONTENT_CAP - META_V3_PAGE1_HEADER;
124const META_V3_OVERFLOW_PAYLOAD_CAP: usize = META_PAGE_CONTENT_CAP - META_V3_OVERFLOW_HEADER;
125
126fn existing_overflow_chain(pager: &Pager) -> Result<Vec<u32>, PagerError> {
127    let cs = crate::storage::engine::HEADER_SIZE;
128    let page = match pager.read_page(1) {
129        Ok(p) => p,
130        Err(_) => return Ok(Vec::new()),
131    };
132    let bytes = page.as_bytes();
133    if bytes.len() < cs + META_V3_PAGE1_HEADER {
134        return Ok(Vec::new());
135    }
136    let Some(header) =
137        reddb_file::decode_native_metadata_overflow_header(&bytes[cs..]).map_err(|err| {
138            PagerError::InvalidDatabase(format!("invalid metadata overflow header: {err}"))
139        })?
140    else {
141        return Ok(Vec::new());
142    };
143    let mut next = header.next_overflow_page_id;
144    let mut pages = Vec::new();
145    let mut seen = std::collections::HashSet::new();
146    while next != 0 {
147        if !seen.insert(next) || pages.len() >= pager.page_count()? as usize {
148            return Err(PagerError::InvalidDatabase(
149                "cyclic metadata overflow chain".into(),
150            ));
151        }
152        let ov = match pager.read_page(next) {
153            Ok(p) => p,
154            Err(_) => break,
155        };
156        let ob = ov.as_bytes();
157        let nn = match reddb_file::decode_native_metadata_overflow_continuation_header(&ob[cs..]) {
158            Ok(header) => header.next_overflow_page_id,
159            Err(_) => 0,
160        };
161        pages.push(next);
162        next = nn;
163    }
164    Ok(pages)
165}
166
167fn publish_paged_metadata(pager: &Pager, meta_data: &[u8]) -> Result<(), PagerError> {
168    let retired = existing_overflow_chain(pager)?;
169    let page = build_meta_page1_with_overflow(pager, meta_data)?;
170    // Cache eviction order must not publish a root before its children.
171    pager.sync()?;
172    pager.write_page(1, page)?;
173    pager.sync()?;
174    for id in retired {
175        pager.free_page(id)?;
176    }
177    Ok(())
178}
179
180fn build_meta_page1_with_overflow(
181    pager: &Pager,
182    meta_data: &[u8],
183) -> Result<crate::storage::engine::Page, PagerError> {
184    use crate::storage::engine::{Page, PageType, HEADER_SIZE};
185
186    let mut page1 = Page::new(PageType::Header, 1);
187    let cs = HEADER_SIZE;
188
189    if meta_data.len() <= META_PAGE_CONTENT_CAP {
190        // Single-page: bit-identical to the historical layout.
191        let buf = page1.as_bytes_mut();
192        buf[cs..cs + meta_data.len()].copy_from_slice(meta_data);
193        return Ok(page1);
194    }
195
196    // Multi-page overflow form. Split the inner payload into the first chunk
197    // (held on page 1) followed by zero-or-more continuation chunks chained
198    // through `PageType::Overflow` pages.
199    let first_chunk = &meta_data[..META_V3_FIRST_PAYLOAD_CAP];
200    let mut tail = &meta_data[META_V3_FIRST_PAYLOAD_CAP..];
201    let mut chunks: Vec<&[u8]> = Vec::new();
202    while !tail.is_empty() {
203        let take = tail.len().min(META_V3_OVERFLOW_PAYLOAD_CAP);
204        chunks.push(&tail[..take]);
205        tail = &tail[take..];
206    }
207
208    let mut overflow_pages: Vec<Page> = Vec::with_capacity(chunks.len());
209    let mut overflow_ids: Vec<u32> = Vec::with_capacity(chunks.len());
210    for _ in 0..chunks.len() {
211        let pg = pager.allocate_page(PageType::Overflow)?;
212        overflow_ids.push(pg.page_id());
213        overflow_pages.push(pg);
214    }
215
216    for i in 0..chunks.len() {
217        let next = if i + 1 < chunks.len() {
218            overflow_ids[i + 1]
219        } else {
220            0u32
221        };
222        let len = chunks[i].len() as u32;
223        let buf = overflow_pages[i].as_bytes_mut();
224        reddb_file::encode_native_metadata_overflow_continuation_header(
225            &mut buf[cs..cs + META_V3_OVERFLOW_HEADER],
226            reddb_file::NativeMetadataOverflowContinuationHeader {
227                next_overflow_page_id: next,
228                chunk_bytes: len,
229            },
230        )
231        .map_err(|err| PagerError::InvalidDatabase(err.to_string()))?;
232        buf[cs + 8..cs + 8 + chunks[i].len()].copy_from_slice(chunks[i]);
233    }
234    for (idx, page) in overflow_pages.into_iter().enumerate() {
235        let id = overflow_ids[idx];
236        pager.write_page(id, page)?;
237    }
238
239    // Mirror the inner format_version for debug-friendly hex dumps.
240    let format_version = reddb_file::decode_native_paged_metadata_header(meta_data)
241        .ok()
242        .flatten()
243        .map_or(0, |header| header.format_version);
244
245    let buf = page1.as_bytes_mut();
246    reddb_file::encode_native_metadata_overflow_header(
247        &mut buf[cs..cs + META_V3_PAGE1_HEADER],
248        reddb_file::NativeMetadataOverflowHeader {
249            format_version,
250            total_payload_bytes: meta_data.len() as u32,
251            next_overflow_page_id: overflow_ids[0],
252        },
253    )
254    .map_err(|err| PagerError::InvalidDatabase(err.to_string()))?;
255    buf[cs + META_V3_PAGE1_HEADER..cs + META_V3_PAGE1_HEADER + first_chunk.len()]
256        .copy_from_slice(first_chunk);
257
258    Ok(page1)
259}
260
261fn storage_integrity(
262    zone: &str,
263    id: impl Into<String>,
264    collection: Option<String>,
265    detail: impl Into<String>,
266) -> StoreError {
267    StoreError::StorageIntegrity(crate::api::StorageIntegrityError::new(
268        zone, id, collection, detail,
269    ))
270}
271
272fn page_integrity(
273    page_id: u32,
274    collection: Option<String>,
275    detail: impl Into<String>,
276) -> StoreError {
277    storage_integrity("page", page_id.to_string(), collection, detail)
278}
279
280/// Assemble the full metadata payload from the internal manifest zone: page 1
281/// plus its overflow chain when the native overflow wrapper is present. Returns
282/// the bytes that the metadata parser would see starting from the content
283/// offset of page 1. Single-page metadata returns the raw page content
284/// (including trailing zero-pad), so the legacy parser sees the same bytes it
285/// always saw.
286///
287/// The zone is rooted by the superblock and checksummed per ADR 0074 §2: a
288/// failing checksum surfaces the didactic manifest-zone integrity error
289/// directly — there is no sidecar copy to fall back to since ADR 0038 §4
290/// phase 1 retired the shadows.
291fn read_meta_payload(pager: &Pager) -> Result<Option<Vec<u8>>, StoreError> {
292    let cs = crate::storage::engine::HEADER_SIZE;
293    let meta_page = pager.read_manifest_page().map_err(|err| {
294        storage_integrity(
295            "manifest",
296            "manifest",
297            None,
298            format!("internal manifest zone read failed ({err})"),
299        )
300    })?;
301    let bytes = meta_page.as_bytes();
302    if bytes.len() < cs + 4 {
303        return Ok(Some(bytes.get(cs..).unwrap_or(&[]).to_vec()));
304    }
305    let header = match reddb_file::decode_native_metadata_overflow_header(&bytes[cs..])
306        .map_err(|err| page_integrity(1, None, err.to_string()))?
307    {
308        Some(header) => header,
309        None => {
310            return Ok(Some(bytes[cs..].to_vec()));
311        }
312    };
313    if bytes.len() < cs + META_V3_PAGE1_HEADER {
314        return Err(page_integrity(
315            1,
316            None,
317            "metadata overflow header is truncated",
318        ));
319    }
320    let total = header.total_payload_bytes as usize;
321    let mut next = header.next_overflow_page_id;
322    let mut payload: Vec<u8> = Vec::with_capacity(total);
323    let first_take = total.min(META_V3_FIRST_PAYLOAD_CAP);
324    payload.extend_from_slice(
325        &bytes[cs + META_V3_PAGE1_HEADER..cs + META_V3_PAGE1_HEADER + first_take],
326    );
327    while next != 0 && payload.len() < total {
328        let ov = pager
329            .read_page(next)
330            .map_err(|err| page_integrity(next, None, err.to_string()))?;
331        let ob = ov.as_bytes();
332        if ob.len() < cs + META_V3_OVERFLOW_HEADER {
333            return Err(page_integrity(
334                next,
335                None,
336                "metadata overflow continuation is truncated",
337            ));
338        }
339        let continuation =
340            reddb_file::decode_native_metadata_overflow_continuation_header(&ob[cs..])
341                .map_err(|err| page_integrity(next, None, err.to_string()))?;
342        let nn = continuation.next_overflow_page_id;
343        let len = continuation.chunk_bytes as usize;
344        let remaining = total - payload.len();
345        let take = len.min(remaining).min(META_V3_OVERFLOW_PAYLOAD_CAP);
346        payload.extend_from_slice(
347            &ob[cs + META_V3_OVERFLOW_HEADER..cs + META_V3_OVERFLOW_HEADER + take],
348        );
349        next = nn;
350    }
351    Ok(Some(payload))
352}
353
354impl UnifiedStore {
355    /// Compare and encode one borrowed row at a time. Begin a new tree only at
356    /// the first difference, copying its already-verified prefix in bounded
357    /// batches. Unchanged trees require no replacement allocation.
358    fn checkpoint_tree(
359        &self,
360        pager: &Arc<Pager>,
361        manager: &SegmentManager,
362        previous: Option<&Arc<BTree>>,
363        mut encode: impl FnMut(&UnifiedEntity, Option<Metadata>) -> Option<Vec<u8>>,
364    ) -> Result<Arc<BTree>, StoreError> {
365        let mut cursor = previous
366            .map(|tree| tree.cursor_first())
367            .transpose()
368            .map_err(|e| StoreError::Io(std::io::Error::other(e.to_string())))?;
369        let mut matched = 0;
370        let mut builder = None;
371        let mut failure = None;
372        manager.for_each_entity_with_metadata_in_id_order(|entity, metadata| {
373            let Some(value) = encode(entity, metadata) else {
374                return true;
375            };
376            let record = (entity.id.raw().to_be_bytes().to_vec(), value);
377            let result = (|| {
378                if builder.is_none() {
379                    if let Some(cursor) = cursor.as_mut() {
380                        if cursor
381                            .next()
382                            .map_err(|e| StoreError::Io(std::io::Error::other(e.to_string())))?
383                            .as_ref()
384                            == Some(&record)
385                        {
386                            matched += 1;
387                            return Ok(());
388                        }
389                    }
390                    let mut replacement = CheckpointTreeBuilder::new(pager);
391                    if let Some(previous) = previous {
392                        replacement.copy_prefix(previous, matched)?;
393                    }
394                    builder = Some(replacement);
395                }
396                builder
397                    .as_mut()
398                    .expect("replacement initialized")
399                    .push(record)
400            })();
401            if let Err(error) = result {
402                failure = Some(error);
403                return false;
404            }
405            true
406        });
407        if let Some(error) = failure {
408            return Err(error);
409        }
410        if builder.is_none() {
411            if let (Some(previous), Some(cursor)) = (previous, cursor.as_mut()) {
412                if cursor
413                    .next()
414                    .map_err(|e| StoreError::Io(std::io::Error::other(e.to_string())))?
415                    .is_none()
416                {
417                    return Ok(Arc::clone(previous));
418                }
419            }
420            let mut replacement = CheckpointTreeBuilder::new(pager);
421            if let Some(previous) = previous {
422                replacement.copy_prefix(previous, matched)?;
423            }
424            builder = Some(replacement);
425        }
426        let mut builder = builder.expect("replacement or reused tree");
427        builder.flush()?;
428        Ok(builder.tree)
429    }
430
431    /// Publication first, reuse second. The immediately preceding generation
432    /// stays in the durable ledger for one more publication. Cursors and cloned
433    /// tree handles defer retirement further without holding the writer fence.
434    fn publish_reclaimable_trees(
435        &self,
436        pager: &Pager,
437        metadata: &mut Vec<u8>,
438        live: &HashMap<String, Arc<BTree>>,
439    ) -> Result<(), StoreError> {
440        let mut retired = self.retired_btrees.lock();
441        let mut roots = Vec::new();
442        let mut reclaim = Vec::new();
443        let mut remove = std::collections::HashSet::new();
444        for (index, entry) in retired.iter().enumerate() {
445            if live.values().any(|tree| Arc::ptr_eq(tree, &entry.tree)) {
446                remove.insert(index);
447                continue;
448            }
449            if entry.published
450                && Arc::strong_count(&entry.tree) == 1
451                && !entry.tree.has_retirement_readers()
452            {
453                reclaim.extend(
454                    entry
455                        .tree
456                        .retired_pages()
457                        .map_err(|e| StoreError::Io(std::io::Error::other(e.to_string())))?,
458                );
459                remove.insert(index);
460            } else if entry.tree.root_page_id() != 0 {
461                roots.push(entry.tree.root_page_id());
462            }
463        }
464        roots.sort_unstable();
465        roots.dedup();
466        reddb_file::encode_native_paged_retired_trees(metadata, &roots)
467            .map_err(|e| StoreError::Serialization(e.to_string()))?;
468        // Do not mutate retirement state or the free list before both the new
469        // children and the manifest that forgets old roots have been synced.
470        publish_paged_metadata(pager, metadata)
471            .map_err(|e| StoreError::Io(std::io::Error::other(e.to_string())))?;
472        let mut index = 0;
473        retired.retain_mut(|entry| {
474            let keep = !remove.contains(&index);
475            entry.published = true;
476            index += 1;
477            keep
478        });
479        if !reclaim.is_empty() {
480            pager
481                .free_retired_pages(&reclaim)
482                .map_err(|e| StoreError::Io(std::io::Error::other(e.to_string())))?;
483            pager
484                .sync()
485                .map_err(|e| StoreError::Io(std::io::Error::other(e.to_string())))?;
486        }
487        Ok(())
488    }
489
490    pub(super) fn retire_btree(&self, tree: Arc<BTree>) {
491        let mut retired = self.retired_btrees.lock();
492        if tree.root_page_id() != 0 && !retired.iter().any(|entry| Arc::ptr_eq(&entry.tree, &tree))
493        {
494            retired.push(RetiredBTree {
495                tree,
496                published: false,
497            });
498        }
499    }
500
501    /// A completed inline insert already made this tree match its manager.
502    /// Advance the reuse proof only for that single, fenced mutation. Any
503    /// untracked edit or segment publication keeps the full comparison path.
504    pub(crate) fn note_paged_insert(
505        &self,
506        collection: &str,
507        manager: &Arc<SegmentManager>,
508        before: &[(u64, u64)],
509        id: EntityId,
510    ) {
511        let after = manager.checkpoint_revisions();
512        if before.len() != after.len() {
513            return;
514        }
515        let mut changed = 0;
516        for ((old_id, old_revision), (new_id, new_revision)) in before.iter().zip(&after) {
517            if old_id != new_id {
518                return;
519            }
520            if old_revision != new_revision {
521                if old_revision.checked_add(1) != Some(*new_revision) {
522                    return;
523                }
524                changed += 1;
525            }
526        }
527        if changed != 1 {
528            return;
529        }
530        let mut versions = self.checkpoint_versions.write();
531        let Some(previous) = versions.get_mut(collection) else {
532            return;
533        };
534        if previous.manager.ptr_eq(&Arc::downgrade(manager))
535            && previous.segments == before
536            && previous.format_version == self.format_version()
537            && !previous.pending_vault.contains(&id)
538            && !previous.aborted.contains(&0)
539        {
540            previous.segments = after;
541        }
542    }
543
544    pub(crate) fn mark_paged_registry_dirty(&self) {
545        self.paged_registry_dirty.store(true, Ordering::Release);
546    }
547
548    /// Get (or lazily create) the per-collection B-tree under a *read*
549    /// lock whenever possible. Returns a cloned `Arc<BTree>` so callers
550    /// can mutate the tree without holding the outer map's RwLock —
551    /// previously every insert serialised on `btree_indices.write()`,
552    /// costing ~60% of the concurrent-insert throughput ceiling.
553    pub(crate) fn get_or_create_btree(&self, collection: &str) -> Option<Arc<BTree>> {
554        let pager = self.pager.as_ref()?;
555        if let Some(btree) = self.btree_indices.read().get(collection).cloned() {
556            return Some(btree);
557        }
558        let mut write = self.btree_indices.write();
559        let btree = write
560            .entry(collection.to_string())
561            .or_insert_with(|| Arc::new(BTree::new(Arc::clone(pager))))
562            .clone();
563        Some(btree)
564    }
565
566    pub(crate) fn flush_paged_state(&self) -> Result<(), StoreError> {
567        let Some(pager) = &self.pager else {
568            return Ok(());
569        };
570
571        if self.paged_registry_dirty.load(Ordering::Acquire) {
572            self.flush_paged_registry()?;
573            self.paged_registry_dirty.store(false, Ordering::Release);
574            return Ok(());
575        }
576
577        pager
578            .flush()
579            .map_err(|e| StoreError::Io(std::io::Error::other(e.to_string())))
580    }
581
582    pub(crate) fn flush_paged_registry(&self) -> Result<(), StoreError> {
583        let _vault_guard = self.vault_publication_lock.lock();
584        let Some(pager) = &self.pager else {
585            return Ok(());
586        };
587
588        match pager.read_page(1) {
589            Ok(_) => {}
590            Err(PagerError::PageNotFound(_)) => {
591                let meta_page = pager
592                    .allocate_page(crate::storage::engine::PageType::Header)
593                    .map_err(|e| StoreError::Io(std::io::Error::other(e.to_string())))?;
594                pager
595                    .write_page(meta_page.page_id(), meta_page)
596                    .map_err(|e| StoreError::Io(std::io::Error::other(e.to_string())))?;
597            }
598            Err(e) => {
599                return Err(StoreError::Io(std::io::Error::other(e.to_string())));
600            }
601        }
602
603        let format_version = STORE_VERSION_V11;
604        self.set_format_version(format_version);
605
606        let collections = self.collections.read();
607        let btree_indices = self.btree_indices.read();
608        let mut collection_roots = Vec::with_capacity(collections.len());
609        for (name, _) in collections.iter() {
610            let root_page = btree_indices
611                .get(name)
612                .map_or(0, |btree| btree.root_page_id());
613            collection_roots.push((name.clone(), root_page));
614        }
615        drop(btree_indices);
616        drop(collections);
617
618        let mut meta_data = Vec::with_capacity(4096);
619        reddb_file::encode_native_paged_metadata_header(
620            &mut meta_data,
621            reddb_file::NativePagedMetadataHeader {
622                format_version,
623                collection_count: collection_roots.len() as u32,
624            },
625        );
626        for (name, root_page) in &collection_roots {
627            reddb_file::encode_native_paged_collection_root(&mut meta_data, name, *root_page);
628        }
629
630        let cross_refs = self.cross_refs.read();
631        let total_refs: usize = cross_refs.values().map(|v| v.len()).sum();
632        meta_data.extend_from_slice(&(total_refs as u32).to_le_bytes());
633        for (source_id, refs) in cross_refs.iter() {
634            for (target_id, ref_type, collection) in refs {
635                reddb_file::encode_native_paged_cross_ref(
636                    &mut meta_data,
637                    source_id.raw(),
638                    target_id.raw(),
639                    ref_type.to_byte(),
640                    collection,
641                );
642            }
643        }
644
645        self.publish_reclaimable_trees(pager, &mut meta_data, &self.btree_indices.read())?;
646
647        Ok(())
648    }
649
650    /// Get a reference to the underlying pager (if in paged mode).
651    pub fn pager(&self) -> Option<&Arc<Pager>> {
652        self.pager.as_ref()
653    }
654
655    /// Bytes of page-cache memory currently occupied by resident pages
656    /// (ADR 0073 §2). Slots are fixed size, so occupancy times the page size
657    /// *is* the footprint; a store without a pager occupies none.
658    pub fn page_cache_bytes_in_use(&self) -> u64 {
659        self.pager.as_ref().map_or(0, |pager| {
660            pager.cache_len() as u64 * crate::storage::memory_pools::PAGE_CACHE_PAGE_SIZE_BYTES
661        })
662    }
663
664    /// Bytes of WAL buffer memory held by this store's group-commit
665    /// coordinator: queued records plus the writer's fixed append buffer.
666    pub fn wal_buffer_bytes_in_use(&self) -> u64 {
667        self.commit
668            .as_ref()
669            .map_or(0, |commit| commit.buffered_bytes())
670    }
671
672    /// Approximate resident bytes across every collection's segment arena
673    /// (ADR 0073 §2). Same number `stats().total_memory_bytes` reports, without
674    /// building the per-collection stats map a sampler would throw away.
675    pub fn segment_memory_bytes(&self) -> u64 {
676        let managers: Vec<Arc<SegmentManager>> =
677            self.collections.read().values().map(Arc::clone).collect();
678
679        managers
680            .iter()
681            .map(|manager| manager.resident_bytes())
682            .fold(0, u64::saturating_add)
683    }
684
685    /// Borrow the immutable store configuration. Runtime hooks (e.g. the
686    /// `auto_index_id` first-insert hook in `MutationEngine`) read knobs
687    /// off this struct without going through the legacy global config tree.
688    pub fn config(&self) -> &UnifiedStoreConfig {
689        &self.config
690    }
691
692    pub fn with_config(config: UnifiedStoreConfig) -> Self {
693        Self {
694            config,
695            format_version: AtomicU32::new(STORE_VERSION_V11),
696            next_entity_id: AtomicU64::new(1),
697            collections: RwLock::new(HashMap::new()),
698            cross_refs: RwLock::new(HashMap::new()),
699            reverse_refs: RwLock::new(HashMap::new()),
700            pager: None,
701            db_path: None,
702            btree_indices: RwLock::new(HashMap::new()),
703            checkpoint_versions: RwLock::new(HashMap::new()),
704            retired_btrees: parking_lot::Mutex::new(Vec::new()),
705            context_index: ContextIndex::new(),
706            entity_cache: EntityCache::new(),
707            graph_label_index: RwLock::new(HashMap::new()),
708            paged_registry_dirty: AtomicBool::new(false),
709            commit: None,
710            unindex_cross_refs_fast_path: AtomicU64::new(0),
711            replayed_turbo_inserts: parking_lot::Mutex::new(HashMap::new()),
712            replayed_probabilistic_deltas: parking_lot::Mutex::new(Vec::new()),
713            aux_metadata: RwLock::new(Vec::new()),
714            snapshot_manager: std::sync::OnceLock::new(),
715            vault_publication_lock: parking_lot::ReentrantMutex::new(()),
716            pending_vault_versions: RwLock::new(std::collections::HashSet::new()),
717        }
718    }
719
720    /// Open or create a page-based database
721    ///
722    /// This uses the page engine for ACID durability with B-tree indices.
723    /// The database file uses 16 KiB pages with checksums and efficient caching.
724    ///
725    /// # Arguments
726    ///
727    /// * `path` - Path to the database file (e.g., "data.rdb")
728    ///
729    /// # Example
730    ///
731    /// ```rust,ignore
732    /// let store = UnifiedStore::open("security.rdb")?;
733    /// store.create_collection("hosts")?;
734    /// // ... operations ...
735    /// store.persist()?; // Flush to disk
736    /// ```
737    pub fn open(path: impl AsRef<Path>) -> Result<Self, StoreError> {
738        Self::open_with_config(path, UnifiedStoreConfig::default())
739    }
740
741    pub fn open_with_config(
742        path: impl AsRef<Path>,
743        config: UnifiedStoreConfig,
744    ) -> Result<Self, StoreError> {
745        let path = path.as_ref();
746        let mut pager_config = PagerConfig::default();
747        // ADR 0073 §2 — the page cache is pre-sized from its budget share.
748        // The pager's own `cache_size` default survives only for direct
749        // library callers who never resolved a budget.
750        if let Some(slots) = config.page_cache_slots {
751            pager_config.cache_size = slots;
752        }
753        // Tunables via env — experimental, used by the benchmark harness
754        // to compare durability profiles head-to-head with Postgres.
755        // REDDB_DOUBLE_WRITE=0 requests skipping the double-write buffer,
756        // which otherwise adds two fsyncs per pager flush (one on DWB, one
757        // on the main file). The pager honors this only when the actual
758        // data file is proven to live on a CoW filesystem with atomic page
759        // writes; otherwise it fails closed and keeps DWB enabled.
760        if matches!(
761            std::env::var("REDDB_DOUBLE_WRITE").ok().as_deref(),
762            Some("0") | Some("false") | Some("off")
763        ) {
764            pager_config.double_write = false;
765        }
766        let pager = Pager::open(path, pager_config)
767            .map_err(|e| StoreError::Io(std::io::Error::other(e.to_string())))?;
768
769        let wal_path = reddb_file::layout::unified_wal_path(path);
770        // Explicit transactions and WAL-only vault versions need committed
771        // batches in every durability mode, including Strict's inline fsync.
772        let commit = Some(Arc::new(
773            StoreCommitCoordinator::open(wal_path, config.durability_mode, config.group_commit)
774                .map_err(StoreError::Io)?,
775        ));
776
777        let store = Self {
778            config,
779            format_version: AtomicU32::new(STORE_VERSION_V11),
780            next_entity_id: AtomicU64::new(1),
781            collections: RwLock::new(HashMap::new()),
782            cross_refs: RwLock::new(HashMap::new()),
783            reverse_refs: RwLock::new(HashMap::new()),
784            pager: Some(Arc::new(pager)),
785            db_path: Some(path.to_path_buf()),
786            btree_indices: RwLock::new(HashMap::new()),
787            checkpoint_versions: RwLock::new(HashMap::new()),
788            retired_btrees: parking_lot::Mutex::new(Vec::new()),
789            context_index: ContextIndex::new(),
790            entity_cache: EntityCache::new(),
791            graph_label_index: RwLock::new(HashMap::new()),
792            paged_registry_dirty: AtomicBool::new(false),
793            commit,
794            unindex_cross_refs_fast_path: AtomicU64::new(0),
795            replayed_turbo_inserts: parking_lot::Mutex::new(HashMap::new()),
796            replayed_probabilistic_deltas: parking_lot::Mutex::new(Vec::new()),
797            aux_metadata: RwLock::new(Vec::new()),
798            snapshot_manager: std::sync::OnceLock::new(),
799            vault_publication_lock: parking_lot::ReentrantMutex::new(()),
800            pending_vault_versions: RwLock::new(std::collections::HashSet::new()),
801        };
802
803        // Load existing data from pages if database exists
804        store.load_from_pages()?;
805        if let Some(commit) = &store.commit {
806            commit.replay_into(&store).map_err(StoreError::Io)?;
807        }
808        store.recover_operational_manifest()?;
809
810        Ok(store)
811    }
812
813    /// Replay changes the authoritative managers first. Build replacement trees
814    /// only for changed collections, leaving every published tree untouched until
815    /// all replacement pages are durable. Retain the WAL for auxiliary recovery.
816    pub(crate) fn reconcile_replayed_btrees(&self) -> Result<(), StoreError> {
817        let Some(pager) = &self.pager else {
818            return Ok(());
819        };
820        let collections = self.collections.read();
821        let mut indices = self.btree_indices.write();
822        for (name, manager) in collections.iter() {
823            let tree =
824                self.checkpoint_tree(pager, manager, indices.get(name), |entity, metadata| {
825                    Some(Self::serialize_entity_record(
826                        entity,
827                        metadata.as_ref(),
828                        self.format_version(),
829                    ))
830                })?;
831            if indices
832                .get(name)
833                .is_some_and(|previous| Arc::ptr_eq(previous, &tree))
834            {
835                continue;
836            }
837            if let Some(previous) = indices.insert(name.clone(), tree) {
838                self.retire_btree(previous);
839            }
840            self.mark_paged_registry_dirty();
841        }
842        drop(indices);
843        drop(collections);
844        self.flush_paged_state()?;
845        // Opening has no concurrent writers. Replay has now durably reconciled
846        // these raw trees; do not immediately rebuild them at the first flush.
847        if self.snapshot_manager.get().is_none() && self.pending_vault_versions.read().is_empty() {
848            let collections = self.collections.read();
849            let mut versions = self.checkpoint_versions.write();
850            for (name, manager) in collections.iter() {
851                versions.insert(
852                    name.clone(),
853                    CheckpointVersion {
854                        manager: Arc::downgrade(manager),
855                        segments: manager.checkpoint_revisions(),
856                        aborted_revision: 0,
857                        aborted: Arc::default(),
858                        pending_vault: Arc::default(),
859                        format_version: self.format_version(),
860                    },
861                );
862            }
863        }
864        Ok(())
865    }
866
867    pub(crate) fn recover_operational_manifest(&self) -> Result<(), StoreError> {
868        let Some(path) = &self.db_path else {
869            return Ok(());
870        };
871        let mut collections = self.list_collections();
872        collections.sort();
873        let pending_drops =
874            crate::storage::operational_manifest::OperationalManifest::for_db_path(path)
875                .recover_or_bootstrap(&collections)
876                .map_err(|err| storage_integrity("manifest", "current", None, err.to_string()))?;
877        for name in pending_drops {
878            if self.get_collection(&name).is_some() {
879                self.drop_collection(&name)?;
880            }
881        }
882        Ok(())
883    }
884
885    pub(crate) fn prepare_operational_collection_create(
886        &self,
887        name: &str,
888    ) -> Result<Option<reddb_file::PreparedCollectionCreate<reddb_file::StdVfs>>, StoreError> {
889        let Some(path) = &self.db_path else {
890            return Ok(None);
891        };
892        crate::storage::operational_manifest::OperationalManifest::for_db_path(path)
893            .prepare_collection_create(name)
894            .map(Some)
895            .map_err(StoreError::Io)
896    }
897
898    pub(crate) fn prepare_operational_collection_drop(
899        &self,
900        name: &str,
901    ) -> Result<Option<reddb_file::PreparedCollectionDrop<reddb_file::StdVfs>>, StoreError> {
902        let Some(path) = &self.db_path else {
903            return Ok(None);
904        };
905        crate::storage::operational_manifest::OperationalManifest::for_db_path(path)
906            .prepare_collection_drop(name)
907            .map(Some)
908            .map_err(StoreError::Io)
909    }
910
911    /// Load data from page-based storage
912    ///
913    /// Reads the B-tree indices and reconstructs collections from pages.
914    fn load_from_pages(&self) -> Result<(), StoreError> {
915        let pager = match &self.pager {
916            Some(p) => p,
917            None => return Ok(()), // No pager, nothing to load
918        };
919
920        // Get page count
921        let page_count = pager.page_count().map_err(|e| {
922            StoreError::Io(std::io::Error::other(format!(
923                "failed to read page count: {}",
924                e
925            )))
926        })?;
927        if page_count <= 1 {
928            // Empty database (only header page)
929            return Ok(());
930        }
931
932        // Read metadata starting from page 1 (collections registry). The
933        // helper transparently follows the `RDM3` overflow chain when the
934        // metadata blob spans multiple pages and falls back to the legacy
935        // `<data>-meta` shadow when page 1 itself is corrupted.
936        if let Some(content_vec) = read_meta_payload(pager)? {
937            let content: &[u8] = &content_vec;
938            if content.len() >= 4 {
939                let mut pos = 0;
940                let mut format_version = STORE_VERSION_V1;
941
942                let collection_count = if let Some(header) =
943                    reddb_file::decode_native_paged_metadata_header(content)
944                        .map_err(|err| StoreError::Serialization(err.to_string()))?
945                {
946                    format_version = header.format_version;
947                    pos += reddb_file::METADATA_HEADER_BYTES;
948                    header.collection_count as usize
949                } else {
950                    let count = u32::from_le_bytes([
951                        content[pos],
952                        content[pos + 1],
953                        content[pos + 2],
954                        content[pos + 3],
955                    ]) as usize;
956                    pos += 4;
957                    count
958                };
959
960                self.set_format_version(format_version);
961
962                if pos > content.len() {
963                    return Ok(());
964                }
965
966                // Read collection names and their B-tree root pages
967                for _ in 0..collection_count {
968                    if let Ok(root) =
969                        reddb_file::decode_native_paged_collection_root(content, &mut pos)
970                    {
971                        // Root page ID for this collection's B-tree
972                        let root_page = root.root_page;
973                        let name = root.collection;
974
975                        // Hydrate the collection in memory only. Loading must
976                        // not emit WAL entries or rewrite the on-disk registry
977                        // before the existing B-tree roots are attached.
978                        let _ = self.create_collection_in_memory(&name);
979
980                        // Load B-tree with root page if it exists
981                        if root_page > 0 {
982                            let btree = BTree::with_root(Arc::clone(pager), root_page);
983
984                            // Load all entities from B-tree into the collection
985                            let mut cursor = btree.cursor_first().map_err(|err| {
986                                page_integrity(root_page, Some(name.clone()), err.to_string())
987                            })?;
988                            let manager = self.get_collection(&name);
989                            loop {
990                                let next = cursor.next().map_err(|err| {
991                                    page_integrity(root_page, Some(name.clone()), err.to_string())
992                                })?;
993                                let Some((key, value)) = next else {
994                                    break;
995                                };
996                                // Deserialize entity from value bytes
997                                if let Ok((entity, metadata)) =
998                                    Self::deserialize_entity_record(&value, self.format_version())
999                                {
1000                                    if let Some(m) = &manager {
1001                                        let id = entity.id;
1002                                        if let EntityKind::TableRow { row_id, .. } = &entity.kind {
1003                                            m.register_row_id(*row_id);
1004                                        }
1005                                        self.context_index.index_entity(&name, &entity);
1006                                        m.restore_snapshot_entity(entity.clone())?;
1007                                        if let Some(metadata) = metadata {
1008                                            let _ = m.set_metadata(id, metadata);
1009                                        }
1010                                        self.register_entity_id(id);
1011                                        if self.config.auto_index_refs {
1012                                            self.index_cross_refs(&entity, &name)?;
1013                                        }
1014                                    }
1015                                }
1016                            }
1017
1018                            // Store the B-tree for future lookups
1019                            self.btree_indices
1020                                .write()
1021                                .insert(name.clone(), Arc::new(btree));
1022                            if format_version == STORE_VERSION_V11 {
1023                                if let Some(manager) = &manager {
1024                                    self.checkpoint_versions.write().insert(
1025                                        name,
1026                                        CheckpointVersion {
1027                                            manager: Arc::downgrade(manager),
1028                                            segments: manager.checkpoint_revisions(),
1029                                            aborted_revision: 0,
1030                                            aborted: Arc::default(),
1031                                            pending_vault: Arc::default(),
1032                                            format_version,
1033                                        },
1034                                    );
1035                                }
1036                            }
1037                        }
1038                    } else {
1039                        break;
1040                    }
1041                }
1042
1043                if format_version >= STORE_VERSION_V2 && pos + 4 <= content.len() {
1044                    let cross_ref_count = u32::from_le_bytes([
1045                        content[pos],
1046                        content[pos + 1],
1047                        content[pos + 2],
1048                        content[pos + 3],
1049                    ]) as usize;
1050                    pos += 4;
1051
1052                    for _ in 0..cross_ref_count {
1053                        let Ok(cross_ref) =
1054                            reddb_file::decode_native_paged_cross_ref(content, &mut pos)
1055                        else {
1056                            break;
1057                        };
1058                        let source_id = EntityId::new(cross_ref.source_id);
1059                        let target_id = EntityId::new(cross_ref.target_id);
1060                        let ref_type = RefType::from_byte(cross_ref.ref_type);
1061                        let target_collection = cross_ref.target_collection;
1062
1063                        self.cross_refs.write().entry(source_id).or_default().push((
1064                            target_id,
1065                            ref_type,
1066                            target_collection.clone(),
1067                        ));
1068
1069                        if let Some((collection, mut entity)) = self.get_any(source_id) {
1070                            let exists = entity.cross_refs().iter().any(|xref| {
1071                                xref.target == target_id
1072                                    && xref.ref_type == ref_type
1073                                    && xref.target_collection == target_collection
1074                            });
1075                            if !exists {
1076                                entity.cross_refs_mut().push(CrossRef::new(
1077                                    source_id,
1078                                    target_id,
1079                                    target_collection.clone(),
1080                                    ref_type,
1081                                ));
1082                                if let Some(manager) = self.get_collection(&collection) {
1083                                    let _ = manager.update(entity);
1084                                }
1085                            }
1086                        }
1087                    }
1088                }
1089                let retired = reddb_file::decode_native_paged_retired_trees(content, &mut pos)
1090                    .map_err(|e| StoreError::Serialization(e.to_string()))?;
1091                let live_roots: std::collections::HashSet<_> = self
1092                    .btree_indices
1093                    .read()
1094                    .values()
1095                    .map(|tree| tree.root_page_id())
1096                    .collect();
1097                for root in retired {
1098                    if live_roots.contains(&root)
1099                        || root
1100                            >= pager
1101                                .page_count()
1102                                .map_err(|e| StoreError::Io(std::io::Error::other(e.to_string())))?
1103                    {
1104                        return Err(page_integrity(
1105                            root,
1106                            None,
1107                            "retired root aliases a live or missing page",
1108                        ));
1109                    }
1110                    self.retired_btrees.lock().push(RetiredBTree {
1111                        tree: Arc::new(BTree::with_root(Arc::clone(pager), root)),
1112                        published: true,
1113                    });
1114                }
1115            }
1116        }
1117
1118        if self.format_version() < STORE_VERSION_V11 {
1119            self.set_format_version(STORE_VERSION_V11);
1120        }
1121
1122        Ok(())
1123    }
1124
1125    /// Deserialize an entity from binary bytes
1126    pub(crate) fn deserialize_entity(
1127        data: &[u8],
1128        format_version: u32,
1129    ) -> Result<UnifiedEntity, StoreError> {
1130        let mut pos = 0;
1131        Self::read_entity_binary(data, &mut pos, format_version)
1132            .map_err(|e| StoreError::Serialization(e.to_string()))
1133    }
1134
1135    /// Serialize an entity to binary bytes
1136    pub(crate) fn serialize_entity(entity: &UnifiedEntity, format_version: u32) -> Vec<u8> {
1137        // Pre-allocate ~256 bytes to cover the typical 15-column
1138        // typed row without any Vec growth. Bulk insert calls this
1139        // millions of times per bench run; saving 2-3 reallocs per
1140        // entity amortises.
1141        let mut buf = Vec::with_capacity(256);
1142        Self::write_entity_binary(&mut buf, entity, format_version);
1143        buf
1144    }
1145
1146    pub(crate) fn serialize_entity_record(
1147        entity: &UnifiedEntity,
1148        metadata: Option<&Metadata>,
1149        format_version: u32,
1150    ) -> Vec<u8> {
1151        let entity_bytes = Self::serialize_entity(entity, format_version);
1152        // Skip the intermediate metadata Vec when there's no metadata
1153        // (common OLTP bulk-insert case): write a zero-length prefix
1154        // directly into the record buffer. Only fall back to the old
1155        // serialize_metadata() allocation when the caller actually
1156        // has fields to persist.
1157        let has_meta = matches!(metadata, Some(m) if !m.fields.is_empty());
1158        if has_meta {
1159            let metadata_bytes = serialize_metadata(metadata);
1160            reddb_file::encode_native_entity_record_frame(&entity_bytes, Some(&metadata_bytes))
1161        } else {
1162            reddb_file::encode_native_entity_record_frame(&entity_bytes, None)
1163        }
1164    }
1165
1166    pub(crate) fn deserialize_entity_record(
1167        data: &[u8],
1168        format_version: u32,
1169    ) -> Result<(UnifiedEntity, Option<Metadata>), StoreError> {
1170        let Some(frame) = reddb_file::decode_native_entity_record_frame(data)
1171            .map_err(|err| StoreError::Serialization(err.to_string()))?
1172        else {
1173            return Self::deserialize_entity(data, format_version).map(|entity| (entity, None));
1174        };
1175
1176        let entity = Self::deserialize_entity(frame.entity, format_version)?;
1177        let metadata = if frame.metadata.is_empty() {
1178            None
1179        } else {
1180            let metadata = deserialize_metadata(frame.metadata)?;
1181            if metadata.is_empty() {
1182                None
1183            } else {
1184                Some(metadata)
1185            }
1186        };
1187
1188        Ok((entity, metadata))
1189    }
1190
1191    /// Persist all data to page-based storage
1192    ///
1193    /// Writes all entities to B-tree pages and flushes to disk.
1194    /// This provides ACID durability guarantees.
1195    pub fn persist(&self) -> Result<(), StoreError> {
1196        let _vault_guard = self.vault_publication_lock.lock();
1197        let pending_vault_versions = self.pending_vault_versions.read();
1198        let pager = match &self.pager {
1199            Some(p) => p,
1200            None => {
1201                // No pager attached - use binary file fallback if path available
1202                if let Some(path) = &self.db_path {
1203                    return self
1204                        .save_to_file(path)
1205                        .map_err(|e| StoreError::Serialization(e.to_string()));
1206                }
1207                return Err(StoreError::Io(std::io::Error::other(
1208                    "No pager or path configured for persistence",
1209                )));
1210            }
1211        };
1212
1213        match pager.read_page(1) {
1214            Ok(_) => {}
1215            Err(PagerError::PageNotFound(_)) => {
1216                let meta_page = pager
1217                    .allocate_page(crate::storage::engine::PageType::Header)
1218                    .map_err(|e| StoreError::Io(std::io::Error::other(e.to_string())))?;
1219                pager
1220                    .write_page(meta_page.page_id(), meta_page)
1221                    .map_err(|e| StoreError::Io(std::io::Error::other(e.to_string())))?;
1222            }
1223            Err(e) => {
1224                return Err(StoreError::Io(std::io::Error::other(e.to_string())));
1225            }
1226        }
1227
1228        if let Some(commit) = &self.commit {
1229            commit.force_sync().map_err(StoreError::Io)?;
1230        }
1231
1232        let collections = self.collections.read();
1233        let mut btree_indices = self.btree_indices.write();
1234
1235        // Collect collection names and their B-tree root pages
1236        let mut collection_roots: Vec<(String, u32)> = Vec::new();
1237
1238        // Build unpublished replacements. Deleting from the current trees here
1239        // would destroy the last checkpoint if a write fails before publication.
1240        let mut rebuilt_indices = HashMap::with_capacity(collections.len());
1241        let previous_versions = self.checkpoint_versions.read();
1242        let mut checkpoint_versions = HashMap::with_capacity(collections.len());
1243        let pending_vault = Arc::new(pending_vault_versions.clone());
1244        let (aborted_revision, aborted) = self.snapshot_manager.get().map_or_else(
1245            || (0, Default::default()),
1246            |manager| manager.checkpoint_aborted_state(),
1247        );
1248        let aborted = Arc::new(aborted);
1249        for (name, manager) in collections.iter() {
1250            let version = CheckpointVersion {
1251                manager: Arc::downgrade(manager),
1252                segments: manager.checkpoint_revisions(),
1253                aborted_revision,
1254                aborted: Arc::clone(&aborted),
1255                pending_vault: Arc::clone(&pending_vault),
1256                format_version: self.format_version(),
1257            };
1258            if let (Some(previous), Some(tree)) =
1259                (previous_versions.get(name), btree_indices.get(name))
1260            {
1261                if previous.manager.ptr_eq(&version.manager)
1262                    && previous.segments == version.segments
1263                    && previous.format_version == version.format_version
1264                    && checkpoint_visibility_matches(previous, &version, manager)
1265                {
1266                    collection_roots.push((name.clone(), tree.root_page_id()));
1267                    rebuilt_indices.insert(name.clone(), Arc::clone(tree));
1268                    checkpoint_versions.insert(name.clone(), version);
1269                    continue;
1270                }
1271            }
1272            checkpoint_versions.insert(name.clone(), version);
1273            let btree = self.checkpoint_tree(
1274                pager,
1275                manager,
1276                btree_indices.get(name),
1277                |entity, metadata| {
1278                    #[cfg(test)]
1279                    CHECKPOINT_SERIALIZED_ROWS.with(|count| count.set(count.get() + 1));
1280                    if pending_vault_versions.contains(&entity.id)
1281                        || (matches!(entity.data, EntityData::Row(_) | EntityData::Vector(_))
1282                            && aborted.contains(&entity.xmin))
1283                    {
1284                        return None;
1285                    }
1286                    let mut normalized = std::borrow::Cow::Borrowed(entity);
1287                    if matches!(entity.data, EntityData::Row(_)) && aborted.contains(&entity.xmax) {
1288                        normalized.to_mut().xmax = 0;
1289                    }
1290                    Some(Self::serialize_entity_record(
1291                        &normalized,
1292                        metadata.as_ref(),
1293                        self.format_version(),
1294                    ))
1295                },
1296            )?;
1297
1298            collection_roots.push((name.clone(), btree.root_page_id()));
1299            rebuilt_indices.insert(name.clone(), btree);
1300        }
1301
1302        // Write collection metadata to page 1
1303        let mut meta_data = Vec::with_capacity(4096);
1304
1305        let format_version = STORE_VERSION_V11;
1306        self.set_format_version(format_version);
1307
1308        reddb_file::encode_native_paged_metadata_header(
1309            &mut meta_data,
1310            reddb_file::NativePagedMetadataHeader {
1311                format_version,
1312                collection_count: collection_roots.len() as u32,
1313            },
1314        );
1315
1316        // Write each collection's name and B-tree root page
1317        for (name, root_page) in &collection_roots {
1318            reddb_file::encode_native_paged_collection_root(&mut meta_data, name, *root_page);
1319        }
1320
1321        // Write cross-reference metadata
1322        let cross_refs = self.cross_refs.read();
1323        let total_refs: usize = cross_refs.values().map(|v| v.len()).sum();
1324        meta_data.extend_from_slice(&(total_refs as u32).to_le_bytes());
1325        for (source_id, refs) in cross_refs.iter() {
1326            for (target_id, ref_type, collection) in refs {
1327                reddb_file::encode_native_paged_cross_ref(
1328                    &mut meta_data,
1329                    source_id.raw(),
1330                    target_id.raw(),
1331                    ref_type.to_byte(),
1332                    collection,
1333                );
1334            }
1335        }
1336
1337        for (name, previous) in btree_indices.iter() {
1338            if !rebuilt_indices
1339                .get(name)
1340                .is_some_and(|tree| Arc::ptr_eq(tree, previous))
1341            {
1342                self.retire_btree(Arc::clone(previous));
1343            }
1344        }
1345        self.publish_reclaimable_trees(pager, &mut meta_data, &rebuilt_indices)?;
1346
1347        // Only the now-durable catalog may replace the live tree handles. The
1348        // previous generation is retained in the manifest retirement ledger.
1349        *btree_indices = rebuilt_indices;
1350        drop(previous_versions);
1351        *self.checkpoint_versions.write() = checkpoint_versions;
1352
1353        if let Some(commit) = &self.commit {
1354            commit.truncate().map_err(StoreError::Io)?;
1355        }
1356
1357        Ok(())
1358    }
1359
1360    /// Check if the store is using page-based persistence
1361    pub fn is_paged(&self) -> bool {
1362        self.pager.is_some()
1363    }
1364
1365    /// Current root page for a collection's primary B-tree, if one has
1366    /// been materialized in this store.
1367    pub(crate) fn collection_root_page(&self, collection: &str) -> Option<u32> {
1368        self.btree_indices
1369            .read()
1370            .get(collection)
1371            .map(|btree| btree.root_page_id())
1372            .filter(|root| *root != 0)
1373    }
1374
1375    /// Get the database file path (if using paged mode)
1376    pub fn db_path(&self) -> Option<&Path> {
1377        self.db_path.as_deref()
1378    }
1379}
1380
1381fn serialize_metadata(metadata: Option<&Metadata>) -> Vec<u8> {
1382    let Some(metadata) = metadata else {
1383        return Vec::new();
1384    };
1385    if metadata.is_empty() {
1386        return Vec::new();
1387    }
1388
1389    let mut entries: Vec<_> = metadata.iter().collect();
1390    entries.sort_by_key(|(a, _)| *a);
1391
1392    let mut buf = Vec::new();
1393    buf.extend_from_slice(&(entries.len() as u32).to_le_bytes());
1394    for (key, value) in entries {
1395        write_string(&mut buf, key);
1396        write_metadata_value(&mut buf, value);
1397    }
1398    buf
1399}
1400
1401fn deserialize_metadata(data: &[u8]) -> Result<Metadata, StoreError> {
1402    let mut pos = 0usize;
1403    let count = read_u32(data, &mut pos)? as usize;
1404    let mut metadata = Metadata::new();
1405    for _ in 0..count {
1406        let key = read_string(data, &mut pos)?;
1407        let value = read_metadata_value(data, &mut pos)?;
1408        metadata.set(key, value);
1409    }
1410    Ok(metadata)
1411}
1412
1413fn write_string(buf: &mut Vec<u8>, value: &str) {
1414    reddb_file::encode_native_len_prefixed_str(buf, value);
1415}
1416
1417fn write_bytes(buf: &mut Vec<u8>, value: &[u8]) {
1418    reddb_file::encode_native_len_prefixed_bytes(buf, value);
1419}
1420
1421fn write_ref_target(buf: &mut Vec<u8>, target: &crate::storage::unified::RefTarget) {
1422    use crate::storage::unified::RefTarget;
1423
1424    match target {
1425        RefTarget::TableRow { table, row_id } => {
1426            buf.push(0);
1427            write_string(buf, table);
1428            buf.extend_from_slice(&row_id.to_le_bytes());
1429        }
1430        RefTarget::Node {
1431            collection,
1432            node_id,
1433        } => {
1434            buf.push(1);
1435            write_string(buf, collection);
1436            buf.extend_from_slice(&node_id.raw().to_le_bytes());
1437        }
1438        RefTarget::Edge {
1439            collection,
1440            edge_id,
1441        } => {
1442            buf.push(2);
1443            write_string(buf, collection);
1444            buf.extend_from_slice(&edge_id.raw().to_le_bytes());
1445        }
1446        RefTarget::Vector {
1447            collection,
1448            vector_id,
1449        } => {
1450            buf.push(3);
1451            write_string(buf, collection);
1452            buf.extend_from_slice(&vector_id.raw().to_le_bytes());
1453        }
1454        RefTarget::Entity {
1455            collection,
1456            entity_id,
1457        } => {
1458            buf.push(4);
1459            write_string(buf, collection);
1460            buf.extend_from_slice(&entity_id.raw().to_le_bytes());
1461        }
1462    }
1463}
1464
1465fn write_metadata_value(buf: &mut Vec<u8>, value: &MetadataValue) {
1466    match value {
1467        MetadataValue::Null => buf.push(0),
1468        MetadataValue::Bool(v) => {
1469            buf.push(1);
1470            buf.push(u8::from(*v));
1471        }
1472        MetadataValue::Int(v) => {
1473            buf.push(2);
1474            buf.extend_from_slice(&v.to_le_bytes());
1475        }
1476        MetadataValue::Float(v) => {
1477            buf.push(3);
1478            buf.extend_from_slice(&v.to_le_bytes());
1479        }
1480        MetadataValue::String(v) => {
1481            buf.push(4);
1482            write_string(buf, v);
1483        }
1484        MetadataValue::Bytes(v) => {
1485            buf.push(5);
1486            write_bytes(buf, v);
1487        }
1488        MetadataValue::Array(values) => {
1489            buf.push(6);
1490            buf.extend_from_slice(&(values.len() as u32).to_le_bytes());
1491            for value in values {
1492                write_metadata_value(buf, value);
1493            }
1494        }
1495        MetadataValue::Object(values) => {
1496            buf.push(7);
1497            let mut entries: Vec<_> = values.iter().collect();
1498            entries.sort_by_key(|(a, _)| *a);
1499            buf.extend_from_slice(&(entries.len() as u32).to_le_bytes());
1500            for (key, value) in entries {
1501                write_string(buf, key);
1502                write_metadata_value(buf, value);
1503            }
1504        }
1505        MetadataValue::Timestamp(v) => {
1506            buf.push(8);
1507            buf.extend_from_slice(&v.to_le_bytes());
1508        }
1509        MetadataValue::Geo { lat, lon } => {
1510            buf.push(9);
1511            buf.extend_from_slice(&lat.to_le_bytes());
1512            buf.extend_from_slice(&lon.to_le_bytes());
1513        }
1514        MetadataValue::Reference(target) => {
1515            buf.push(10);
1516            write_ref_target(buf, target);
1517        }
1518        MetadataValue::References(targets) => {
1519            buf.push(11);
1520            buf.extend_from_slice(&(targets.len() as u32).to_le_bytes());
1521            for target in targets {
1522                write_ref_target(buf, target);
1523            }
1524        }
1525    }
1526}
1527
1528fn read_exact_slice<'a>(
1529    data: &'a [u8],
1530    pos: &mut usize,
1531    len: usize,
1532) -> Result<&'a [u8], StoreError> {
1533    if *pos + len > data.len() {
1534        return Err(StoreError::Serialization(
1535            "truncated metadata payload".to_string(),
1536        ));
1537    }
1538    let slice = &data[*pos..*pos + len];
1539    *pos += len;
1540    Ok(slice)
1541}
1542
1543fn read_u32(data: &[u8], pos: &mut usize) -> Result<u32, StoreError> {
1544    let bytes = read_exact_slice(data, pos, 4)?;
1545    let mut raw = [0u8; 4];
1546    raw.copy_from_slice(bytes);
1547    Ok(u32::from_le_bytes(raw))
1548}
1549
1550fn read_u64(data: &[u8], pos: &mut usize) -> Result<u64, StoreError> {
1551    let bytes = read_exact_slice(data, pos, 8)?;
1552    let mut raw = [0u8; 8];
1553    raw.copy_from_slice(bytes);
1554    Ok(u64::from_le_bytes(raw))
1555}
1556
1557fn read_i64(data: &[u8], pos: &mut usize) -> Result<i64, StoreError> {
1558    let bytes = read_exact_slice(data, pos, 8)?;
1559    let mut raw = [0u8; 8];
1560    raw.copy_from_slice(bytes);
1561    Ok(i64::from_le_bytes(raw))
1562}
1563
1564fn read_f64(data: &[u8], pos: &mut usize) -> Result<f64, StoreError> {
1565    let bytes = read_exact_slice(data, pos, 8)?;
1566    let mut raw = [0u8; 8];
1567    raw.copy_from_slice(bytes);
1568    Ok(f64::from_le_bytes(raw))
1569}
1570
1571fn read_u8(data: &[u8], pos: &mut usize) -> Result<u8, StoreError> {
1572    let bytes = read_exact_slice(data, pos, 1)?;
1573    Ok(bytes[0])
1574}
1575
1576fn read_string(data: &[u8], pos: &mut usize) -> Result<String, StoreError> {
1577    reddb_file::decode_native_len_prefixed_string(data, pos)
1578        .map_err(|err| StoreError::Serialization(err.to_string()))
1579}
1580
1581fn read_bytes(data: &[u8], pos: &mut usize) -> Result<Vec<u8>, StoreError> {
1582    reddb_file::decode_native_len_prefixed_bytes(data, pos)
1583        .map(|bytes| bytes.to_vec())
1584        .map_err(|err| StoreError::Serialization(err.to_string()))
1585}
1586
1587fn read_ref_target(
1588    data: &[u8],
1589    pos: &mut usize,
1590) -> Result<crate::storage::unified::RefTarget, StoreError> {
1591    use crate::storage::unified::RefTarget;
1592
1593    match read_u8(data, pos)? {
1594        0 => Ok(RefTarget::TableRow {
1595            table: read_string(data, pos)?,
1596            row_id: read_u64(data, pos)?,
1597        }),
1598        1 => Ok(RefTarget::Node {
1599            collection: read_string(data, pos)?,
1600            node_id: EntityId::new(read_u64(data, pos)?),
1601        }),
1602        2 => Ok(RefTarget::Edge {
1603            collection: read_string(data, pos)?,
1604            edge_id: EntityId::new(read_u64(data, pos)?),
1605        }),
1606        3 => Ok(RefTarget::Vector {
1607            collection: read_string(data, pos)?,
1608            vector_id: EntityId::new(read_u64(data, pos)?),
1609        }),
1610        4 => Ok(RefTarget::Entity {
1611            collection: read_string(data, pos)?,
1612            entity_id: EntityId::new(read_u64(data, pos)?),
1613        }),
1614        tag => Err(StoreError::Serialization(format!(
1615            "unknown metadata ref target tag {tag}"
1616        ))),
1617    }
1618}
1619
1620fn read_metadata_value(data: &[u8], pos: &mut usize) -> Result<MetadataValue, StoreError> {
1621    match read_u8(data, pos)? {
1622        0 => Ok(MetadataValue::Null),
1623        1 => Ok(MetadataValue::Bool(read_u8(data, pos)? != 0)),
1624        2 => Ok(MetadataValue::Int(read_i64(data, pos)?)),
1625        3 => Ok(MetadataValue::Float(read_f64(data, pos)?)),
1626        4 => Ok(MetadataValue::String(read_string(data, pos)?)),
1627        5 => Ok(MetadataValue::Bytes(read_bytes(data, pos)?)),
1628        6 => {
1629            let count = read_u32(data, pos)? as usize;
1630            let mut values = Vec::with_capacity(count);
1631            for _ in 0..count {
1632                values.push(read_metadata_value(data, pos)?);
1633            }
1634            Ok(MetadataValue::Array(values))
1635        }
1636        7 => {
1637            let count = read_u32(data, pos)? as usize;
1638            let mut values = std::collections::HashMap::with_capacity(count);
1639            for _ in 0..count {
1640                let key = read_string(data, pos)?;
1641                let value = read_metadata_value(data, pos)?;
1642                values.insert(key, value);
1643            }
1644            Ok(MetadataValue::Object(values))
1645        }
1646        8 => Ok(MetadataValue::Timestamp(read_u64(data, pos)?)),
1647        9 => Ok(MetadataValue::Geo {
1648            lat: read_f64(data, pos)?,
1649            lon: read_f64(data, pos)?,
1650        }),
1651        10 => Ok(MetadataValue::Reference(read_ref_target(data, pos)?)),
1652        11 => {
1653            let count = read_u32(data, pos)? as usize;
1654            let mut targets = Vec::with_capacity(count);
1655            for _ in 0..count {
1656                targets.push(read_ref_target(data, pos)?);
1657            }
1658            Ok(MetadataValue::References(targets))
1659        }
1660        tag => Err(StoreError::Serialization(format!(
1661            "unknown metadata value tag {tag}"
1662        ))),
1663    }
1664}
1665
1666#[cfg(test)]
1667mod checkpoint_work_tests {
1668    use super::*;
1669
1670    #[test]
1671    fn retired_tree_pages_remain_pinned_by_a_cursor() {
1672        let directory = tempfile::tempdir().expect("temporary store");
1673        let store = UnifiedStore::open(&directory.path().join("data.rdb")).expect("paged store");
1674        for id in 1..=100 {
1675            store.insert_auto("rows", row(id, 1)).expect("seed");
1676        }
1677        store.persist().expect("initial checkpoint");
1678        let tree = store
1679            .btree_indices
1680            .read()
1681            .get("rows")
1682            .cloned()
1683            .expect("tree");
1684        let mut cursor = tree.cursor_first().expect("cursor");
1685        drop(tree);
1686        let manager = store.get_collection("rows").expect("rows");
1687        for value in 2..=6 {
1688            manager.update(row(1, value)).expect("change");
1689            store.persist().expect("checkpoint with old reader");
1690        }
1691        let mut count = 0;
1692        while let Some((_, bytes)) = cursor.next().expect("pinned tree must stay readable") {
1693            let (entity, _) =
1694                UnifiedStore::deserialize_entity_record(&bytes, store.format_version())
1695                    .expect("decode");
1696            assert_eq!(
1697                entity.data.as_row().expect("row").columns,
1698                [Value::Integer(1)]
1699            );
1700            count += 1;
1701        }
1702        assert_eq!(count, 100);
1703        drop(cursor);
1704        store.persist().expect("reclaim after reader release");
1705        assert!(store.retired_btrees.lock().is_empty());
1706    }
1707
1708    #[test]
1709    fn checkpoint_payload_buffer_is_bounded_for_a_large_collection() {
1710        let directory = tempfile::tempdir().expect("temporary store");
1711        let store = UnifiedStore::open(&directory.path().join("data.rdb")).expect("paged store");
1712        store.create_collection("rows").expect("collection");
1713        let manager = store.get_collection("rows").expect("rows");
1714        for id in (1..=1200).rev() {
1715            manager
1716                .insert(UnifiedEntity::table_row(
1717                    EntityId::new(id),
1718                    "rows",
1719                    id,
1720                    vec![Value::text("x".repeat(4096))],
1721                ))
1722                .expect("seed");
1723        }
1724        CHECKPOINT_BUFFERED_BYTES.with(|peak| peak.set(0));
1725        store.persist().expect("bounded checkpoint");
1726        assert!(CHECKPOINT_BUFFERED_BYTES.with(|peak| peak.get()) <= CHECKPOINT_BATCH_BYTES);
1727        assert!(CHECKPOINT_BUFFERED_BYTES.with(|peak| peak.get()) > 0);
1728        assert_eq!(store.get_collection("rows").expect("rows").count(), 1200);
1729    }
1730
1731    #[test]
1732    fn unchanged_checkpoint_does_not_serialize_collection_rows() {
1733        let directory = tempfile::tempdir().expect("temporary store");
1734        let store = UnifiedStore::open(&directory.path().join("data.rdb")).expect("paged store");
1735        store.create_collection("rows").expect("collection");
1736        for id in 1..=40 {
1737            store
1738                .insert(
1739                    "rows",
1740                    UnifiedEntity::table_row(
1741                        EntityId::new(id),
1742                        "rows",
1743                        id,
1744                        vec![Value::Integer(id as i64)],
1745                    ),
1746                )
1747                .expect("seed row");
1748        }
1749        store.persist().expect("initial checkpoint");
1750        CHECKPOINT_SERIALIZED_ROWS.with(|count| count.set(0));
1751        store.persist().expect("unchanged checkpoint");
1752        assert_eq!(
1753            CHECKPOINT_SERIALIZED_ROWS.with(|count| count.get()),
1754            0,
1755            "unchanged collections must not hold the writer fence while serializing every row"
1756        );
1757        drop(store);
1758        let reopened = UnifiedStore::open(&directory.path().join("data.rdb")).expect("reopen");
1759        CHECKPOINT_SERIALIZED_ROWS.with(|count| count.set(0));
1760        reopened.persist().expect("unchanged recovered generation");
1761        assert_eq!(CHECKPOINT_SERIALIZED_ROWS.with(|count| count.get()), 0);
1762    }
1763
1764    #[test]
1765    fn paged_reopen_preserves_stored_sequence_identity() {
1766        let directory = tempfile::tempdir().expect("temporary store");
1767        let path = directory.path().join("data.rdb");
1768        let store = UnifiedStore::open(&path).expect("paged store");
1769        store.create_collection("rows").expect("collection");
1770        for id in [30, 10, 20] {
1771            store.insert("rows", row(id, id as i64)).expect("insert");
1772        }
1773        store.persist().expect("checkpoint");
1774        let sequences = [10, 20, 30].map(|id| {
1775            store
1776                .get("rows", EntityId::new(id))
1777                .expect("row")
1778                .sequence_id
1779        });
1780        drop(store);
1781        let reopened = UnifiedStore::open(&path).expect("reopen");
1782        let recovered = [10, 20, 30].map(|id| {
1783            reopened
1784                .get("rows", EntityId::new(id))
1785                .expect("row")
1786                .sequence_id
1787        });
1788        assert_eq!(
1789            recovered, sequences,
1790            "opening a checkpoint must not rewrite stored row identities"
1791        );
1792    }
1793
1794    #[test]
1795    fn auto_insert_persists_the_assigned_sequence_identity() {
1796        let directory = tempfile::tempdir().expect("temporary store");
1797        let store = UnifiedStore::open(&directory.path().join("data.rdb")).expect("paged store");
1798        for id in 1u64..=3 {
1799            store
1800                .insert_auto("rows", row(id, id as i64))
1801                .expect("insert");
1802        }
1803        let manager = store.get_collection("rows").expect("rows");
1804        let tree = store
1805            .btree_indices
1806            .read()
1807            .get("rows")
1808            .cloned()
1809            .expect("tree");
1810        for id in 1u64..=3 {
1811            let bytes = tree
1812                .get(&id.to_be_bytes())
1813                .expect("lookup")
1814                .expect("stored row");
1815            let (persisted, _) =
1816                UnifiedStore::deserialize_entity_record(&bytes, store.format_version())
1817                    .expect("decode");
1818            assert_eq!(
1819                persisted.sequence_id,
1820                manager
1821                    .get(EntityId::new(id))
1822                    .expect("live row")
1823                    .sequence_id
1824            );
1825        }
1826    }
1827
1828    #[test]
1829    fn completed_inline_insert_reuses_history_but_not_untracked_edits() {
1830        let directory = tempfile::tempdir().expect("temporary store");
1831        let path = directory.path().join("data.rdb");
1832        let store = UnifiedStore::open(&path).expect("paged store");
1833        store.insert_auto("rows", row(1, 1)).expect("seed");
1834        store.persist().expect("checkpoint");
1835        store.insert_auto("rows", row(2, 2)).expect("append");
1836        CHECKPOINT_SERIALIZED_ROWS.with(|count| count.set(0));
1837        store.persist().expect("inline append checkpoint");
1838        assert_eq!(CHECKPOINT_SERIALIZED_ROWS.with(|count| count.get()), 0);
1839        store
1840            .get_collection("rows")
1841            .expect("rows")
1842            .update(row(1, 99))
1843            .expect("untracked edit");
1844        store.insert_auto("rows", row(3, 3)).expect("next append");
1845        CHECKPOINT_SERIALIZED_ROWS.with(|count| count.set(0));
1846        store.persist().expect("untracked edit checkpoint");
1847        assert!(CHECKPOINT_SERIALIZED_ROWS.with(|count| count.get()) > 0);
1848        drop(store);
1849        let reopened = UnifiedStore::open(&path).expect("reopen");
1850        assert_eq!(
1851            reopened
1852                .get("rows", EntityId::new(1))
1853                .expect("row")
1854                .data
1855                .as_row()
1856                .expect("table")
1857                .columns,
1858            vec![Value::Integer(99)]
1859        );
1860    }
1861
1862    #[test]
1863    fn replayed_trees_are_reusable_after_durable_reconciliation() {
1864        let directory = tempfile::tempdir().expect("temporary store");
1865        let path = directory.path().join("data.rdb");
1866        let store = UnifiedStore::open(&path).expect("paged store");
1867        store.insert_auto("rows", row(1, 1)).expect("seed");
1868        store.persist().expect("checkpoint");
1869        store
1870            .insert_auto("rows", row(2, 2))
1871            .expect("WAL-backed append");
1872        drop(store);
1873        let reopened = UnifiedStore::open(&path).expect("replay");
1874        assert!(reopened.get("rows", EntityId::new(2)).is_some());
1875        CHECKPOINT_SERIALIZED_ROWS.with(|count| count.set(0));
1876        reopened.persist().expect("checkpoint reconciled tree");
1877        assert_eq!(CHECKPOINT_SERIALIZED_ROWS.with(|count| count.get()), 0);
1878    }
1879
1880    fn row(id: u64, value: i64) -> UnifiedEntity {
1881        UnifiedEntity::table_row(EntityId::new(id), "rows", id, vec![Value::Integer(value)])
1882    }
1883
1884    #[test]
1885    fn checkpoint_reuse_tracks_manager_updates_metadata_deletes_and_bulk_inserts() {
1886        let directory = tempfile::tempdir().expect("temporary store");
1887        let path = directory.path().join("data.rdb");
1888        let store = UnifiedStore::open(&path).expect("paged store");
1889        store.create_collection("rows").expect("collection");
1890        store.insert("rows", row(1, 1)).expect("seed");
1891        store.persist().expect("initial checkpoint");
1892        let manager = store.get_collection("rows").expect("rows");
1893        manager.update(row(1, 2)).expect("direct update");
1894        CHECKPOINT_SERIALIZED_ROWS.with(|count| count.set(0));
1895        store.persist().expect("updated row checkpoint");
1896        assert_eq!(CHECKPOINT_SERIALIZED_ROWS.with(|count| count.get()), 1);
1897        let mut metadata = Metadata::new();
1898        metadata.set("verified", MetadataValue::Bool(true));
1899        manager
1900            .set_metadata(EntityId::new(1), metadata)
1901            .expect("metadata");
1902        CHECKPOINT_SERIALIZED_ROWS.with(|count| count.set(0));
1903        store.persist().expect("metadata-only checkpoint");
1904        assert_eq!(CHECKPOINT_SERIALIZED_ROWS.with(|count| count.get()), 1);
1905        manager
1906            .bulk_insert(vec![row(2, 2), row(3, 3)])
1907            .expect("bulk insert");
1908        CHECKPOINT_SERIALIZED_ROWS.with(|count| count.set(0));
1909        store.persist().expect("bulk insert checkpoint");
1910        assert_eq!(CHECKPOINT_SERIALIZED_ROWS.with(|count| count.get()), 3);
1911        manager.delete(EntityId::new(2)).expect("delete");
1912        CHECKPOINT_SERIALIZED_ROWS.with(|count| count.set(0));
1913        store.persist().expect("changed checkpoint");
1914        assert_eq!(CHECKPOINT_SERIALIZED_ROWS.with(|count| count.get()), 2);
1915        drop(store);
1916        let recovered = UnifiedStore::open(&path).expect("recover changed rows");
1917        let manager = recovered.get_collection("rows").expect("rows");
1918        assert_eq!(manager.count(), 2);
1919        assert_eq!(
1920            manager
1921                .get(EntityId::new(1))
1922                .expect("row")
1923                .data
1924                .as_row()
1925                .expect("table")
1926                .columns,
1927            vec![Value::Integer(2)]
1928        );
1929        assert!(manager.get(EntityId::new(2)).is_none());
1930        assert!(manager
1931            .get_metadata(EntityId::new(1))
1932            .expect("metadata")
1933            .get("verified")
1934            .is_some());
1935    }
1936
1937    #[test]
1938    fn unrelated_visibility_changes_do_not_serialize_collection_rows() {
1939        let directory = tempfile::tempdir().expect("temporary store");
1940        let store = UnifiedStore::open(&directory.path().join("data.rdb")).expect("paged store");
1941        let snapshots = Arc::new(crate::storage::transaction::snapshot::SnapshotManager::new());
1942        assert!(store.snapshot_manager.set(Arc::clone(&snapshots)).is_ok());
1943        store.create_collection("rows").expect("collection");
1944        for id in 1..=40 {
1945            store.insert("rows", row(id, id as i64)).expect("seed");
1946        }
1947        store.persist().expect("initial checkpoint");
1948        let unrelated = snapshots.begin();
1949        snapshots.rollback(unrelated);
1950        CHECKPOINT_SERIALIZED_ROWS.with(|count| count.set(0));
1951        store.persist().expect("unrelated rollback checkpoint");
1952        assert_eq!(CHECKPOINT_SERIALIZED_ROWS.with(|count| count.get()), 0);
1953
1954        store
1955            .pending_vault_versions
1956            .write()
1957            .insert(EntityId::new(100));
1958        CHECKPOINT_SERIALIZED_ROWS.with(|count| count.set(0));
1959        store.persist().expect("unrelated vault checkpoint");
1960        assert_eq!(CHECKPOINT_SERIALIZED_ROWS.with(|count| count.get()), 0);
1961        store.pending_vault_versions.write().clear();
1962        CHECKPOINT_SERIALIZED_ROWS.with(|count| count.set(0));
1963        store
1964            .persist()
1965            .expect("unrelated vault publication checkpoint");
1966        assert_eq!(CHECKPOINT_SERIALIZED_ROWS.with(|count| count.get()), 0);
1967    }
1968
1969    #[test]
1970    fn rollback_invalidates_reuse_without_a_segment_mutation() {
1971        let directory = tempfile::tempdir().expect("temporary store");
1972        let path = directory.path().join("data.rdb");
1973        let store = UnifiedStore::open(&path).expect("paged store");
1974        let snapshots = Arc::new(crate::storage::transaction::snapshot::SnapshotManager::new());
1975        assert!(store.snapshot_manager.set(Arc::clone(&snapshots)).is_ok());
1976        store.create_collection("rows").expect("collection");
1977        let xid = snapshots.begin();
1978        let mut pending = row(1, 1);
1979        pending.xmin = xid;
1980        store.insert("rows", pending).expect("version");
1981        store.persist().expect("before rollback");
1982        snapshots.rollback(xid);
1983        store.persist().expect("after rollback");
1984        drop(store);
1985        let recovered = UnifiedStore::open(&path).expect("recover");
1986        assert_eq!(recovered.get_collection("rows").expect("rows").count(), 0);
1987    }
1988
1989    #[test]
1990    fn rolled_back_delete_is_normalized_without_a_segment_mutation() {
1991        let directory = tempfile::tempdir().expect("temporary store");
1992        let path = directory.path().join("data.rdb");
1993        let store = UnifiedStore::open(&path).expect("paged store");
1994        let snapshots = Arc::new(crate::storage::transaction::snapshot::SnapshotManager::new());
1995        assert!(store.snapshot_manager.set(Arc::clone(&snapshots)).is_ok());
1996        store.create_collection("rows").expect("collection");
1997        let xid = snapshots.begin();
1998        let mut deleted = row(1, 1);
1999        deleted.xmax = xid;
2000        store.insert("rows", deleted).expect("version");
2001        store.persist().expect("before rollback");
2002        snapshots.rollback(xid);
2003        store.persist().expect("after rollback");
2004        drop(store);
2005        let recovered = UnifiedStore::open(&path).expect("recover");
2006        let manager = recovered.get_collection("rows").expect("rows");
2007        assert_eq!(manager.get(EntityId::new(1)).expect("retained row").xmax, 0);
2008    }
2009
2010    #[test]
2011    fn publishing_a_pending_vault_version_invalidates_reuse() {
2012        let directory = tempfile::tempdir().expect("temporary store");
2013        let path = directory.path().join("data.rdb");
2014        let store = UnifiedStore::open(&path).expect("paged store");
2015        store.create_collection("rows").expect("collection");
2016        store.insert("rows", row(1, 1)).expect("row");
2017        store
2018            .pending_vault_versions
2019            .write()
2020            .insert(EntityId::new(1));
2021        store.persist().expect("exclude pending vault version");
2022        store
2023            .pending_vault_versions
2024            .write()
2025            .remove(&EntityId::new(1));
2026        store.persist().expect("include published vault version");
2027        drop(store);
2028        let recovered = UnifiedStore::open(&path).expect("recover");
2029        assert_eq!(recovered.get_collection("rows").expect("rows").count(), 1);
2030    }
2031}