react_auditor/rules/react/
no_side_effects_in_render.rs

1use oxc_ast::ast::Program;
2use oxc_ast_visit::Visit;
3use oxc_semantic::Semantic;
4
5use crate::rules::{Rule, RuleFinding, RuleMeta, Severity};
6
7pub struct NoSideEffectsInRender;
8
9const RULE_META: RuleMeta = RuleMeta {
10    id: "no-side-effects-in-render",
11    default_severity: Severity::Error,
12    category: "react",
13    description: "No side effects (subscriptions, mutations) during render",
14};
15
16impl Rule for NoSideEffectsInRender {
17    fn meta(&self) -> &RuleMeta {
18        &RULE_META
19    }
20
21    fn run(&self, program: &Program, _semantic: &Semantic, source_text: &str) -> Vec<RuleFinding> {
22        let mut collector = SideEffectCollector {
23            findings: Vec::new(),
24            source: source_text,
25        };
26        collector.visit_program(program);
27        collector.findings
28    }
29}
30
31struct SideEffectCollector<'a> {
32    findings: Vec<RuleFinding>,
33    source: &'a str,
34}
35
36impl<'a> Visit<'a> for SideEffectCollector<'a> {
37    fn visit_call_expression(&mut self, expr: &oxc_ast::ast::CallExpression<'a>) {
38        if let oxc_ast::ast::Expression::Identifier(ident) = &expr.callee {
39            match ident.name.as_str() {
40                "addEventListener"
41                | "removeEventListener"
42                | "subscribe"
43                | "unsubscribe"
44                | "setTimeout"
45                | "setInterval"
46                | "MutationObserver"
47                | "IntersectionObserver"
48                | "fetch"
49                | "XMLHttpRequest" => {
50                    let start = expr.span.start as usize;
51                    let line = self.source[..start].lines().count().max(1);
52                    let col = start - self.source[..start].rfind('\n').map(|i| i + 1).unwrap_or(0);
53                    self.findings.push(RuleFinding {
54                        line,
55                        column: col + 1,
56                        message: format!(
57                            "Potential side effect `{}()` in render — move to useEffect",
58                            ident.name
59                        ),
60                    });
61                }
62                _ => {}
63            }
64        }
65    }
66}
react_auditor/rules/react/no_side_effects_in_render.rs

react_auditor/rules/react/
no_side_effects_in_render.rs
