react_auditor/rules/react/
no_inline_functions.rs

1use oxc_ast::ast::Program;
2use oxc_ast_visit::Visit;
3use oxc_semantic::Semantic;
4
5use crate::rules::{Rule, RuleFinding, RuleMeta, Severity};
6
7pub struct NoInlineFunctions;
8
9const RULE_META: RuleMeta = RuleMeta {
10    id: "no-inline-functions",
11    default_severity: Severity::Warning,
12    category: "react",
13    description: "Avoid inline function definitions in JSX props",
14};
15
16impl Rule for NoInlineFunctions {
17    fn meta(&self) -> &RuleMeta {
18        &RULE_META
19    }
20
21    fn run(&self, program: &Program, _semantic: &Semantic, source_text: &str) -> Vec<RuleFinding> {
22        let mut collector = InlineFnCollector {
23            findings: Vec::new(),
24            source: source_text,
25        };
26        collector.visit_program(program);
27        collector.findings
28    }
29}
30
31struct InlineFnCollector<'a> {
32    findings: Vec<RuleFinding>,
33    source: &'a str,
34}
35
36impl<'a> Visit<'a> for InlineFnCollector<'a> {
37    fn visit_jsx_opening_element(&mut self, el: &oxc_ast::ast::JSXOpeningElement<'a>) {
38        for attr_item in &el.attributes {
39            if let oxc_ast::ast::JSXAttributeItem::Attribute(attr) = attr_item
40                && let Some(val) = &attr.value
41                && let oxc_ast::ast::JSXAttributeValue::ExpressionContainer(container) = val
42            {
43                let is_inline = matches!(
44                    &container.expression,
45                    oxc_ast::ast::JSXExpression::ArrowFunctionExpression(_)
46                        | oxc_ast::ast::JSXExpression::FunctionExpression(_)
47                );
48                if is_inline {
49                    let start = attr.span.start as usize;
50                    let line = self.source[..start].lines().count().max(1);
51                    let col = start - self.source[..start].rfind('\n').map(|i| i + 1).unwrap_or(0);
52                    let name = if let oxc_ast::ast::JSXAttributeName::Identifier(id) = &attr.name {
53                        id.name.as_str()
54                    } else {
55                        "prop"
56                    };
57                    self.findings.push(RuleFinding {
58                        line,
59                        column: col + 1,
60                        message: format!(
61                            "Avoid inline function for `{name}` prop — extract to a named handler"
62                        ),
63                    });
64                }
65            }
66        }
67    }
68}
react_auditor/rules/react/no_inline_functions.rs

react_auditor/rules/react/
no_inline_functions.rs
